[00:11:39] not to mention no actual image editing tools. VE is a lie! ;-) [00:29:24] 3VisualEditor / 3Mobile: VisualEditor: Cursor appears over the toolbar in ipad mini for Mobile VE - 10https://bugzilla.wikimedia.org/65325 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15390 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15390&action=edit Screenshot Steps... [00:30:25] 3VisualEditor / 3Mobile: VisualEditor: Cursor appears over the toolbar in iPad Mini for Mobile VE - 10https://bugzilla.wikimedia.org/65325 (10ryasmeen) a:3Jon [00:40:54] 3VisualEditor / 3Mobile: VisualEditor:Tapping on a link inside mobile VE with iPad Mini redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE that has link inside it. 2.Tap on any link Obse... [00:41:24] 3VisualEditor / 3Mobile: VisualEditor:Tapping on a link inside mobile VE with iPad Mini redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10ryasmeen) a:3Jon [00:57:49] (03PS39) 10Catrope: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [02:03:46] (03CR) 10Catrope: [C: 04-1] Image model and the media edit dialog (0331 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [07:10:38] 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463 (10James Forrester) [07:10:53] 3VisualEditor / 3Editing Tools: VisualEditor: Font is too small in dialogs in standalone VE - 10https://bugzilla.wikimedia.org/65322 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low [07:11:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314 (10James Forrester) p:5Unprio>3High [07:11:52] 3VisualEditor / 3Technical Debt: VisualEditor: Use $.when() rather than sourceCount in MediaSearchWidget - 10https://bugzilla.wikimedia.org/65321 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [07:12:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Clearer message when cancelling out of active edit - 10https://bugzilla.wikimedia.org/50955 (10James Forrester) 5PAT>3RES/FIX a:3Alex Monk [07:21:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create hooks for extensions to show/hide things when VE activates/deactivates - 10https://bugzilla.wikimedia.org/65320 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc [07:22:08] 3VisualEditor / 3Editing Tools: VisualEditor: On load, async pre-load all the TemplateData for the page to make editing templates speedier - 10https://bugzilla.wikimedia.org/64772#c2 (10James Forrester) (Needs performance investigation.) [07:22:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre] There is an extra space appearing in media search result dialog (scroll bar displacing last column of results) - 10https://bugzilla.wikimedia.org/64911 (10James Forrester) [07:23:08] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, the context menu's background sometimes does not appear for items inside a media caption (but the icons appear still) - 10https://bugzilla.wikimedia.org/64332#c1 (10James Forrester) Needs investigation as to the cause. [09:16:53] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c9 (10James Forrester) Additional fixes made for the 2014-05-15 release – but not sure what counts as "fixing" this bug. Jon, could you re-test? [10:06:58] (03PS4) 10Esanders: Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 [10:07:00] (03PS4) 10Esanders: Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 [11:48:24] Hm.. link inspector has a quick where selected suggested value is not used. Somehow it wants you to press "Enter" or something extra, merely selecting it from the dropdown and blurring it / clicking save, is not enough [11:48:24] http://cl.ly/11431q402d3A [11:48:50] However I can only reproduce it if the entered text before the suggestion is an incomplete title (e.g. title = Foo, type in Ba, select Bar) [11:48:58] It will stay Foo [11:49:06] if I type Bar and select Bar, it's fine [11:49:22] In the video it stayed "javascript deprecations" instead of "ResourceLoade" >"ResourceLoader" [11:49:37] There's so many bugs with the link inspector, I can't even begin to find an existing one [11:51:29] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10Krinkle) [11:51:56] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores typed text if user presses [enter] too quickly, explodes with new links - 10https://bugzilla.wikimedia.org/51415 (10Krinkle) [11:51:56] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores typed text if user presses [enter] too quickly, explodes with new links - 10https://bugzilla.wikimedia.org/51415 (10Krinkle) [11:51:57] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [11:51:59] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector crashes when inserting link on non-linkable or empty selection - 10https://bugzilla.wikimedia.org/51404 (10Krinkle) [11:52:00] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [12:02:02] filed https://bugzilla.wikimedia.org/show_bug.cgi?id=65343 [12:03:23] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [12:03:25] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None 1. Edit some text (e.g the -> foo) 1. Edit existing link (e.g. on [[mw:VisualEditor]], link to "Parsoid") 2. Enter text that makes... [13:21:33] (03CR) 10Esanders: "Is there any reason Process isn't in OO core, apart from the jQuery dependency?" (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [13:38:47] Hm.. interesting, GitHub has a visual diff now for Markdown edits [13:38:48] not bad [13:38:52] https://github.com/mdevils/node-jscs/pull/377/files?short_path=04c6e90#diff-04c6e90faac2675aa89e2176d2eec7d8 [13:39:13] orange line indicates diff context, green/red markings for the obvious, and even an "expand" context button like in source view [13:39:27] probably only works as long as sections are not nested and everything is at the root. [13:39:40] but a good 80/20% approach for the common case. [13:40:05] context expansion lost scroll position though, but oh well [14:18:50] (03PS1) 10Krinkle: build: Update jscs config and minor node-qunit update [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 [14:19:21] (03CR) 10Krinkle: "Finally, that was the last of the deprecated jshint/jscs stuff." [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 (owner: 10Krinkle) [14:29:10] 3VisualEditor: [VisualEditor] File namespace: Reload page after saving to show file - 10https://bugzilla.wikimedia.org/65349 (10Raimond Spekking) 3NEW p:3Unprio s:3normal a:3None After saving an edit in the file namespace the big thumbnail of the file is not shown. [14:29:25] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [14:29:58] (03CR) 10Krinkle: [BREAKING CHANGE] Window refactor, introduction of Processes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [14:42:07] (03PS2) 10Krinkle: build: Update jscs config, minor node-qunit update, fix grunt-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 [14:42:11] edsanders|away: fixes grunt-watch [14:42:14] will apply to ui as well [15:17:42] (03PS1) 10Krinkle: build: Update jscs config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133478 [15:25:08] (03PS1) 10Krinkle: build: Update jscs and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133481 [15:50:46] o/ James_F [15:50:55] Krinkle: Doing CR now. [15:51:02] jQuery 1.11 BAM [15:51:05] (03PS2) 10Jforrester: build: Update jscs and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133481 (owner: 10Krinkle) [15:51:11] (03CR) 10Jforrester: [C: 032] build: Update jscs and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133481 (owner: 10Krinkle) [15:51:44] We need to fix our repos as well, but without jquery.migrate ideally [15:52:01] standalone etc. [15:53:06] * James_F nods. [15:53:19] Krinkle: "BAM" == "no in time for wmf5"? :-P [15:53:35] No, it landed, kabam [15:53:46] It did? [15:54:12] (03PS3) 10Jforrester: build: Update jscs config, minor node-qunit update, fix grunt-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 (owner: 10Krinkle) [15:54:14] (03Merged) 10jenkins-bot: build: Update jscs and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133481 (owner: 10Krinkle) [15:54:17] (03CR) 10Jforrester: [C: 032] build: Update jscs config, minor node-qunit update, fix grunt-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 (owner: 10Krinkle) [15:54:48] Krinkle: BTW, V+2 should probably be disabled in VisualEditor/VisualEditor. [15:55:30] (03Merged) 10jenkins-bot: build: Update jscs config, minor node-qunit update, fix grunt-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/133469 (owner: 10Krinkle) [15:55:47] Hm.. mw-ve is quite far behind. That one doesn't even have the first jscs update yet. Untouched since it was first added. [15:57:14] :-( [15:57:14] almost done [15:58:36] Kk. [16:09:09] Oh nice. Sublime Text 3 brought back style violations in their scroll overview area [16:09:26] http://i.imgur.com/VdcI8WC.png [16:09:32] Note the orange dots on the right [16:10:18] (03PS2) 10Jforrester: build: Update jscs config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133478 (owner: 10Krinkle) [16:10:23] (03CR) 10Jforrester: [C: 032] build: Update jscs config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133478 (owner: 10Krinkle) [16:11:00] (03Merged) 10jenkins-bot: build: Update jscs config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133478 (owner: 10Krinkle) [16:12:24] Yeah, I know. [16:12:43] JSCS warnings in-editor are helpful. :-) [16:14:38] (03PS1) 10Krinkle: build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 [16:14:40] (03PS1) 10Krinkle: mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 [16:16:41] (03CR) 10jenkins-bot: [V: 04-1] build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 (owner: 10Krinkle) [16:16:43] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [16:17:27] oh oh [16:19:18] James_F: So, it looks like there is a small problem, maybe. [16:19:36] Oh? [16:19:36] This is the first test ran after jQuery upgrade. [16:19:36] Yeah. [16:19:36] in core [16:19:37] We have migrate [16:19:43] Oh, MW core breakage even with Migrate? [16:19:47] * James_F sighs. [16:19:54] OK, revert, fix and re-apply? [16:19:55] and there is of course lots of bug fixes since 1.8 that aren't features and shouldn't be undone by migrate. [16:20:04] No, I've got it already. This is a mistake in VE> [16:20:12] Ah, OK. [16:20:14] Cool. [16:20:18] But unexpected. [16:20:21] I'll +2 if it fixes qunit. :-) [16:20:49] We're giving jQuery a VeDmDocument [16:20:55] instead of HTMLDocument [16:20:57] as context argument [16:21:05] :D [16:21:25] Ha. [16:21:27] Whoops. [16:21:58] But it's an error in src, not in the unit test itself. So not sure how easy it is to fix. It's obviously wrong now (old jQuery probably just ignored it) [16:22:08] edsanders: Can you help on a fix? [16:22:13] ve.dm.InternalList [16:22:37] yes [16:22:41] * James_F will hit him 'til it works. [16:22:42] Update mediawiki/core to latest, and ve-mw as wlel, run unit tests like /wiki/Special:JavaScriptTest/qunit?filter=ve&debug=true [16:23:06] ve.dm.InternalList.prototype.convertToData is being give a VeDmDocument somewhere instead of HTMLDocument (which is in VeDmDocument#documentNode) [16:23:15] Causes $( '
', doc ) to throw [16:24:01] QUnit.test 'convertToData' [16:25:22] I see undefined is not a function [16:26:10] Yep, jQuery is making assumptions about the document it is given, it has to be an actual document, not some weird VE object [16:26:15] ok [16:26:15] old jquery just swallowed it [16:26:24] new jquery throws unfortunately. [16:27:50] #htmlDocument rather, not #documentNode. I'm not sure where to fix this, could break other things. I hope we're not relying on this actually. [16:27:56] Krinkle: Can you fix? Ed's a bit busy with server-fixing [16:28:04] Krinkle: And we probably are… [16:28:12] we used weird cases in tests [16:28:19] so probably doesn't affect anything [16:28:23] OK [16:28:32] You in the same room? [16:29:23] Yeah. [16:31:30] so in the test case that fails [16:31:55] you can just use doc.getHtmlDocument() [16:33:10] Krinkle, I'll fix it [16:35:19] (03PS1) 10Esanders: Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133494 [16:42:56] (03CR) 10Krinkle: [C: 032] Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133494 (owner: 10Esanders) [16:44:21] (03Merged) 10jenkins-bot: Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133494 (owner: 10Esanders) [16:45:52] (03PS2) 10Krinkle: build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 [16:46:04] (03PS2) 10Jforrester: mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [16:47:04] grrrit-wm: lies, that wasn't me. [16:48:31] (03CR) 10jenkins-bot: [V: 04-1] build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 (owner: 10Krinkle) [16:48:33] Krinkle: there's a bug for that [16:48:33] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [16:49:11] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=60781 [16:49:56] (03PS1) 10Krinkle: Update VE core submodule to master (ced9f77) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133498 [16:50:07] James_F: ^ [16:50:37] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (ced9f77) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133498 (owner: 10Krinkle) [16:52:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (ced9f77) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133498 (owner: 10Krinkle) [16:52:36] (03PS3) 10Krinkle: build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 [16:56:48] (03CR) 10Jforrester: [C: 032] build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 (owner: 10Krinkle) [16:58:06] (03PS3) 10Jforrester: mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [16:58:13] (03CR) 10Jforrester: [C: 032] mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [16:58:29] (03Merged) 10jenkins-bot: build: Update jscs and jshint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133492 (owner: 10Krinkle) [16:59:57] (03Merged) 10jenkins-bot: mw.ViewPageTarget.init: Remove redundant hasOwn check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133493 (owner: 10Krinkle) [17:03:30] Krinkle: Stand-up? [17:03:47] In a phone call, few sec. [17:34:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: On saving a page in the File: namespace the file preview is not reshown (until reload) - 10https://bugzilla.wikimedia.org/65349 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3minor [17:40:32] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [17:40:34] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [17:45:42] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [17:45:44] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [17:45:52] (03CR) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [17:47:30] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [17:47:55] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [17:54:41] (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [17:55:08] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [17:56:24] 3VisualEditor / 3Mobile: VisualEditor:Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10ryasmeen) [17:58:45] dude, how do you generate docs for OOUI now? [17:58:55] it's changed, and there's no documentation about it [17:59:43] (03PS9) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [18:00:14] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [18:10:30] TrevorParscal: ./bin/generateDocs.sh or something? [18:10:40] 3VisualEditor: VisualEditor: redlinks in templates do not display as red - 10https://bugzilla.wikimedia.org/65353 (10Trevor (Wikia)) 3NEW p:3Unprio s:3minor a:3None Redlinks are displayed as blue links in templates inside the VisualEditor https://en.wikipedia.org/wiki/Javier_Payo?veaction=edit [18:10:42] TrevorParscal: You need jsduck installed locally. [18:22:37] (03PS10) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [18:22:42] nevermind, it was simple [18:23:22] we could rename our jsduck.config.json files to jsduck.json and then we can just run "> jsduck" instead of "> jsduck --config=jsduck.config.json" [18:23:23] 3VisualEditor: VisualEditor: redlinks in templates do not display as red - 10https://bugzilla.wikimedia.org/65353#c1 (10James Forrester) *** Bug 65355 has been marked as a duplicate of this bug. *** [18:23:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes - 10https://bugzilla.wikimedia.org/65355#c1 (10James Forrester) 5NEW>3RES/DUP p:5Unprio>3High Bah. *** This bug has been marked as a duplicate of bug 65353 *** [18:23:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Blue link / red link logic should descend into links inside generated content nodes (e.g. templates) - 10https://bugzilla.wikimedia.org/65353 (10James Forrester) 5NEW>3ASS p:5Unprio>3High [18:26:25] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion content blocks don't auto-expand in Firefox - 10https://bugzilla.wikimedia.org/65356 (10James Forrester) 3ASS p:3Unprio s:3minor a:3None Probably the same issue as we had for parameter fields? [18:26:53] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion content blocks don't auto-expand in Firefox - 10https://bugzilla.wikimedia.org/65356 (10James Forrester) p:5Unprio>3High [18:39:15] TrevorParscal: Tell Krinkle|detached, not me. :-) [18:44:42] James_F: i realize that, I'm just bringing it to the attention of whoever is listening, it's like therapy [18:44:56] TrevorParscal: And how does that make you feel? [18:45:51] Lol. Well, it all started when my daddy... <2 hours later> and that's why I think I'm not able to feel normal human emotions... y'know? [18:46:12] Wait, is this hypnotherapy? [18:46:40] 3VisualEditor / 3Data Model: VisualEditor: Edit led to a tag being removed (?) - 10https://bugzilla.wikimedia.org/65360 (10Tomasz W. Kozlowski) 3NEW p:3Unprio s:3normal a:3None * https://www.mediawiki.org/w/index.php?diff=prev&oldid=1002914 I performed the edit by highlighting the digit... [18:46:53] 3VisualEditor / 3Data Model: VisualEditor: Edit led to a tag being removed (?) - 10https://bugzilla.wikimedia.org/65360 (10Tomasz W. Kozlowski) p:5Unprio>3Normal s:5normal>3major [18:47:53] TrevorParscal: Sure. Except it's the wrong way around. Surely I'm meant to be getting you to write code? ;-) [18:49:38] (03CR) 10Jforrester: [C: 032] Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 (owner: 10Esanders) [18:52:10] 3VisualEditor / 3Data Model: VisualEditor: Edit led to a tag being removed (?) - 10https://bugzilla.wikimedia.org/65360 (10James Forrester) 5NEW>3ASS a:3Ed Sanders [18:54:34] (03CR) 10Jforrester: [C: 032] Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 (owner: 10Esanders) [18:56:04] (03Merged) 10jenkins-bot: Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 (owner: 10Esanders) [18:56:06] (03Merged) 10jenkins-bot: Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 (owner: 10Esanders) [18:57:52] TrevorParscal: We predate that config option, I vauged for it upstream, and it got accepted, as jsduc.json [18:58:01] jsduck* [18:58:17] Should be good to change, though non-trivial because its hardcoded in jenkins. SO we need to orchestrate it between two commits. [19:00:06] Krinkle|detached: Sounds fun. :-) [19:02:10] 3VisualEditor: URLs followed immediately by {{templates}} are un-editable alienated content in VisualEditor - 10https://bugzilla.wikimedia.org/65362 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Reproducible: Always This: http://example.com{{deadlink}} cannot be edited in VisualEditor. It shoul... [19:02:23] 3VisualEditor: URLs followed immediately by {{templates}} are un-editable alienated content in VisualEditor - 10https://bugzilla.wikimedia.org/65362 (10WhatamIdoing) s:5enhanc>3normal [19:06:37] Krinkle|detached: that's why I didn't just change it, I knew jenkins was doing something with it [19:06:51] but I'm happy to +2 if you want to venture into that abyss [19:12:53] 3VisualEditor / 3Data Model: VisualEditor: Deal with universal types like mw:Error, mw:ExpandedAttrs, mw:Placeholder - 10https://bugzilla.wikimedia.org/61969 (10James Forrester) [19:12:53] 3VisualEditor / 3Data Model: VisualEditor: URLs followed immediately by {{templates}} are un-editable alienated content, because they're mw:ExpandedAttrs - 10https://bugzilla.wikimedia.org/65362#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal Caused by mw:ExpandedAttrs from Parsoid. Input: | htt... [19:19:08] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to edit references defined within a template - 10https://bugzilla.wikimedia.org/50896 (10James Forrester) [19:19:08] 3VisualEditor / 3Data Model: VisualEditor: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost - 10https://bugzilla.wikimedia.org/65301 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [19:25:40] 3VisualEditor: VisualEditor not opening consistently in Firefox - 10https://bugzilla.wikimedia.org/65365 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Be me, or one of several other people, but not James F. (This step may be difficult to reproduce. ;-) 2. Login on Firef... [19:59:15] (03PS1) 10Alex Monk: Set up edit notices for things like unknown browsers on each activation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133537 (https://bugzilla.wikimedia.org/65236) [20:00:52] Where is gerritadmin? [20:00:54] (03CR) 10jenkins-bot: [V: 04-1] Set up edit notices for things like unknown browsers on each activation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133537 (https://bugzilla.wikimedia.org/65236) (owner: 10Alex Monk) [20:01:52] grumble grumble, missing semicolon [20:01:58] (03PS2) 10Alex Monk: Set up edit notices for things like unknown browsers on each activation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133537 (https://bugzilla.wikimedia.org/65236) [20:03:12] 3VisualEditor / 3MediaWiki integration: VisualEditor: Browser greylist notice alert not shown the second time you edit a page in the same JS session - 10https://bugzilla.wikimedia.org/65236#c4 (10Alex Monk) 5ASS>3PAT a:3Alex Monk Gerritadmin seems to be missing, I uploaded Gerrit change 133537 [20:06:38] anybody seen rummana around? [20:07:06] ryasmeen: rummana? [20:07:10] awjr: I am working from home today [20:07:28] ryasmeen: did you see the meeting invite/can you join via hangout? [20:07:58] ryasmeen if not we can reschedule [20:09:09] ryasmeen: let's just reschedule [20:09:15] awjr: I didnt get any invite, but i think it is better if we can reschedule it to tomorrow? [20:09:22] I will be in office tomorrow [20:09:30] ryasmeen: ok, we'll need to reschedule for next week [20:09:37] do you usually work from home on wednesdays? [20:09:58] ryasmeen: the invite was sent to your WMF email address [20:10:35] nope i dont usually, only this week :) [20:11:02] ryasmeen: ok; tuesday at 1130 work for you? [20:11:15] awjr: strange! I dont see any invite :S [20:11:23] sure , thats sounds fine [20:11:27] ok cool, thanks :) [20:11:51] ryasmeen: ok, invite sent [20:11:59] ryasmeen: let me know if you dont see it [20:13:04] awjr: yes, got it this time [20:13:09] ryasmeen: :D [20:43:46] (03CR) 10Trevor Parscal: [C: 032] Set up edit notices for things like unknown browsers on each activation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133537 (https://bugzilla.wikimedia.org/65236) (owner: 10Alex Monk) [20:45:26] (03Merged) 10jenkins-bot: Set up edit notices for things like unknown browsers on each activation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133537 (https://bugzilla.wikimedia.org/65236) (owner: 10Alex Monk) [20:48:38] (03CR) 10Trevor Parscal: Allow extensions to add extra meta item checkboxes to the page settings dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [20:49:00] (03CR) 10Trevor Parscal: [C: 04-1] "As per comments by Krinkle and me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [20:52:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer "cancel" option in save dialog to escape VisualEditor - 10https://bugzilla.wikimedia.org/51116#c4 (10Trevor Parscal) It's really cool that Alex has added a patch, but I feel pretty confident this is a mistake. If you open a dialog and then hit cance... [20:52:48] (03PS3) 10Trevor Parscal: [DESIGN DISPUTED] Add cancel & discard changes button to save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 (https://bugzilla.wikimedia.org/51116) (owner: 10Alex Monk) [20:54:02] (03CR) 10Trevor Parscal: [C: 032] Remove Firefox cursoring hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132445 (owner: 10Esanders) [20:55:12] (03Merged) 10jenkins-bot: Remove Firefox cursoring hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132445 (owner: 10Esanders) [20:56:03] (03CR) 10Trevor Parscal: [C: 032] Remove MWCommandHelpDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133391 (owner: 10Catrope) [20:58:36] (03Merged) 10jenkins-bot: Remove MWCommandHelpDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133391 (owner: 10Catrope) [21:08:20] (03PS4) 10Alex Monk: Allow extensions to add extra meta item checkboxes to the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) [21:11:23] (03PS5) 10Alex Monk: Allow extensions to add extra meta item checkboxes to the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) [21:17:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761#c5 (10ryasmeen) 5RES/?>3VER Verified in production [21:17:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer "cancel" option in save dialog to escape VisualEditor - 10https://bugzilla.wikimedia.org/51116#c5 (10Erik Moeller) Agree with Trevor, also on basic grounds of minimizing clutter; we should only add this if there's user testing that shows users don't... [21:21:08] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334#c10 (10ryasmeen) ... [21:22:06] (03CR) 10Trevor Parscal: Image model and the media edit dialog (0315 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [21:22:09] (03Abandoned) 10Alex Monk: [DESIGN DISPUTED] Add cancel & discard changes button to save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 (https://bugzilla.wikimedia.org/51116) (owner: 10Alex Monk) [21:22:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer "cancel" option in save dialog to escape VisualEditor - 10https://bugzilla.wikimedia.org/51116#c6 (10Alex Monk) Hmm... Yes, after thinking about this some more, I agree. Who wants to mark this wontfix? [21:47:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Browser greylist notice alert not shown the second time you edit a page in the same JS session - 10https://bugzilla.wikimedia.org/65236 (10Alex Monk) 5PAT>3RES/FIX [22:04:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE - 10https://bugzilla.wikimedia.org/65302#c2 (10ryasmeen) This is now appearing in production as well after today's deployment [22:08:31] anyone who knows ooui here? [22:11:02] !ask | cscott [22:11:04] cscott, try asking a question about ooui [22:11:32] Krenair: Do you know about ooui? [22:11:36] i'm asking for a friend ;) [22:13:10] kaldari, I've made a couple of patches and understand the basic ideas. [22:13:15] i think the 2 questions were: #1 what's the standard way to "grey out" an inactive menu bar item in ooui, and #2 how do you add textual separator items to a drop down menu. [22:13:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109#c3 (10ryasmeen) 5NEW>3RES/FIX This issue got fixed after the wmf 4 deployment to production.Marking as fixed and verified . [22:13:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109 (10ryasmeen) 5RES/?>3VER [22:14:21] It doesn't look like there is any generic way to visually disable items. Looks like you have to implement something in your ooui theme/skin yourself [22:14:45] although that seems like something of an oversight [22:15:44] Krenair: 2nd… When defining a toolbarGroup, how do I create a label at the top (non-functional)? [22:15:59] Perhaps edsanders can help you. [22:23:40] 3VisualEditor / 3Editing Tools: VisualEditor:Cannot save a page in Betalabs ,"NS_ERROR_NOT_AVAILABLE" appearing while trying to do that - 10https://bugzilla.wikimedia.org/65373 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None NS_ERROR_NOT_AVAILABLE: appearing while trying to save a page in Betalabs [22:27:09] 3VisualEditor / 3Editing Tools: VisualEditor:Cannot save a page in Betalabs in Firefox ,"NS_ERROR_NOT_AVAILABLE" appearing while trying to do that - 10https://bugzilla.wikimedia.org/65373#c1 (10ryasmeen) This is not happening with Chrome though, but with Firefox [22:31:27] (03CR) 10Ori.livneh: "Gabriel, I'd rather not. In my experience, when I do the instrumentation, it becomes my responsibility to interpret and validate the data " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [22:31:40] 3VisualEditor / 3Editing Tools: VisualEditor: Opening a popupToolGroup should disable other tools - 10https://bugzilla.wikimedia.org/65374 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None Per the design mock-up at https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-styling (and a conv... [22:58:40] 3VisualEditor: VisualEditor: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - 10https://bugzilla.wikimedia.org/65377 (10Ryan Kaldari) 3NEW p:3Unprio s:3normal a:3None See design mock-up at https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-sty... [23:04:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] NS_ERROR_NOT_AVAILABLE when trying to open dialog in Firefox - 10https://bugzilla.wikimedia.org/65373#c2 (10Roan Kattouw) New in wmf5, happens when opening any dialog. [23:07:45] That bug is really weird... Why are we getting network errors while opening dialogs? [23:09:14] FF points to it coming from this line: "ret = computed ? computed.getPropertyValue( name ) || computed[ name ] : undefined;" [23:09:54] No network requests appear in console [23:10:05] er, developer tools, network tab (not console) [23:12:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE - 10https://bugzilla.wikimedia.org/65302#c3 (10Roan Kattouw) The dropdown appears to be unstyled in the mobile skin. Also, the mobile CSS that removes all text labels everywhere is probably undesirable in th... [23:30:36] (03PS1) 10Alex Monk: Update wikitext-warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) [23:37:34] (03PS1) 10Alex Monk: Update beta warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) [23:56:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] NS_ERROR_NOT_AVAILABLE when trying to open dialog in Firefox - 10https://bugzilla.wikimedia.org/65373#c3 (10Roan Kattouw) Correction, not ALL dialogs. The media insertion dialog isn't affected, all the others do seem to be.