[00:05:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] NS_ERROR_NOT_AVAILABLE when trying to open dialog in Firefox - 10https://bugzilla.wikimedia.org/65373#c4 (10Roan Kattouw) Caused by the jQuery 1.11 upgrade. [00:07:09] 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563#c1 (10ryasmeen) 5NEW>3ASS a:3Moriel Schottlender This did not get... [00:21:38] 3VisualEditor / 3Editing Tools: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c2 (10ryasmeen) This issue did not get resolved with new image model. [00:32:55] 3VisualEditor / 3ContentEditable: VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize - 10https://bugzilla.wikimedia.org/62284#c5 (10ryasmeen) a:3Moriel Schottlender I am not getting the phantom appearing at wrong position issue anymore ,but what I am see n... [00:41:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Beta warning should say that you can switch to wikitext without unsaved changes being lost - 10https://bugzilla.wikimedia.org/57699#c5 (10Alex Monk) 5ASS>3PAT a:3Alex Monk I uploaded Gerrit change 133639 for this [00:42:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning needs to be updated to refer to switching to wikitext editor without losing unsaved changes - 10https://bugzilla.wikimedia.org/57700#c1 (10Alex Monk) 5ASS>3PAT a:3Alex Monk I uploaded Gerrit change 133637 for this [01:01:10] 3VisualEditor / 3Editing Tools: VisualEditor: A straight line appears above the image while making it (Frameless/Basic-Left/Right-border) - 10https://bugzilla.wikimedia.org/64966#c1 (10ryasmeen) 5NEW>3ASS a:3Moriel Schottlender This issue did not get resolved with new image model [01:04:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314#c5 (10ryasmeen) Verified the fix in Betalabs [03:03:01] Hi anyone out there? I'm having a strange issue with VE and I thought someone who knows the code might want to help me track it down and, if appropriate, file a bug :) [03:03:36] Hi TrevorParscal! ^ [03:11:04] Anyway, for the record, I keep getting "NS_ERROR_NOT_AVAILABLE: Component is not available" from line 6128 of load.php (ret = computed ? computed.getPropertyValue( name ) || computed[ name ] : undefined;) when I go into Visual Editor and try to save a page, on mediawiki.org [03:11:35] Using Iceweasel (Firefox) 25.0 on Debian [03:14:11] Seems to be new. I used VE on mediawiki.org fine for a while earlier today. No issues on enwiki [03:24:33] ^ ah I see the bug is already filed, https://bugzilla.wikimedia.org/show_bug.cgi?id=65373 [07:43:38] 3VisualEditor / 3ContentEditable: VisualEditor: A straight line appears above the image while making it (Frameless/Basic-Left/Right-border) - 10https://bugzilla.wikimedia.org/64966 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor [07:44:08] 3VisualEditor / 3ContentEditable: VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize - 10https://bugzilla.wikimedia.org/62284#c6 (10James Forrester) (In reply to ryasmeen from comment #5) > I am not getting the phantom appearing at wrong position issue anymo... [08:22:25] (03CR) 10Mooeypoo: Image model and the media edit dialog (0334 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [08:22:50] (03PS40) 10Mooeypoo: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [08:24:34] (03CR) 10jenkins-bot: [V: 04-1] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [08:39:46] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) (owner: 10Alex Monk) [08:40:22] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) (owner: 10Alex Monk) [10:01:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] NS_ERROR_NOT_AVAILABLE when trying to open dialog in Firefox - 10https://bugzilla.wikimedia.org/65373#c5 (10Krinkle) Most likely, such as was with Ia7db42b7727b8ca16ae, this is one of three things: 1) We're giving the DOM or jQuery garbage, and... [10:39:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf5] NS_ERROR_NOT_AVAILABLE when trying to open dialog in Firefox - 10https://bugzilla.wikimedia.org/65373#c6 (10Krinkle) Narrowed it down... A breakpoint doesn't seem to work as this is a lower level exception, this is most likely a bug inside Fire... [10:39:53] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10Krinkle) [12:31:08] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c7 (10Krinkle) Caused by OO.ui.ConfirmationDialog.prototype.initialize -> OO.ui.PanelLayout (only when passing $: this.$, without it it works fine, so it is... [12:59:02] (03CR) 10Esanders: Update wikitext-warning to refer to 'Switch to source editing' (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) (owner: 10Alex Monk) [13:11:58] (03CR) 10Esanders: Update beta warning to refer to 'Switch to source editing' (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) (owner: 10Alex Monk) [13:13:50] (03CR) 10Esanders: [C: 031] "Looks good, will let Timo re-review too." [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [13:33:04] (03CR) 10Esanders: [C: 04-1] Ignore SelectWidget mouseup events that started outside the widget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [13:34:00] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [13:42:40] (03CR) 10Krinkle: "4 minor issues." [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [13:46:02] (03CR) 10Krinkle: "btw, in case the magic return false *is* the an important reason and not a convenience afterthought, know that one can return a rejected p" [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [13:52:02] I have loaded up a page on mediawiki.org and hit Edit, then edited the page, then clicked "Save page" - the button seems to register the onclick&button-up, but the page does not respond overall. Any tips on what I should look at in the dev console to file a proper bug? [14:17:53] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c8 (10Krinkle) Inside .css(): [1.8.3] jQuery.fn.css -> curCSS computed = window.getComputedStyle( elem, null ), style = elem.style if ( computed ) { // ge... [14:18:24] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c9 (10Krinkle) So it's no longer using the global window and pass the (foreign) node, but uses the correct window now (ownerDocument.defaultView). If anything, th... [14:48:08] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c10 (10Krinkle) To reproduce: http://jsfiddle.net/v8Syf/4/ [14:53:09] Krinkle: Having fun with Firefox? :-( [14:53:16] yeah, #jquery-dev [14:53:21] https://bugzilla.mozilla.org/show_bug.cgi?id=358415 [14:54:04] Basically, it's whether we use window.getComputedStyle( node from other document ) or node.ownerDocument.defaultView.getComputedStyle( node ) [14:54:07] the latter is obvious correct [14:54:12] and that's what jQuery changed it into [14:54:20] because IE otherwise fails [14:54:40] (when dealing with popups, e.g. window.open, that new window can't deal with fringe nodes) [14:54:49] Right. [14:55:15] which makes sense, the fact that the global getComputedStyle works in other browsers is more a courtesy afaik [14:55:39] anyway, turns out Firefox has a weird null pointer exception when doing it that way, specifically when dealing with iframes. [14:55:51] somehow the iframe window lost its reference [14:56:02] when I say null pointer I mean really null pointer. Not javascript land, but native. [14:56:11] the variable is fine according to javascript [14:56:29] Ugh, no idea what they'll do. or what we should. [14:56:58] We could go balls in and substitute this part of jquery for an IE unfriendly hack [14:57:13] we can't patch our jquery because that would break people's stuff in IE. [15:00:27] * James_F nods. [15:00:43] So an OOUI jQuery module replacement? [15:00:45] Eww. [15:01:20] Like we have with focusin/focusout [15:01:32] a method on OO.ui.Element that fixes .css() for Firefox and breaks it for IE [15:01:59] When doing a reduced test case it doesn't happen. Firefox, iframes and getComputedStyle are fine in general. [15:02:20] It's just that somehow with all we're doing with stylesheet transplants and complex layouts, it somehow loses its reference [15:02:30] deterministically so [15:02:45] maybe some random memory leak [15:10:41] "Deterministic" and "random memory leak" don't really go together. :-) [15:28:59] James_F: Should we have a tracker bug or some collection of some kind where people can report jqmigrate triggers? Extension authors might not find them all themselves, especially if they only trigger in certain use cases. [15:29:20] I see MMV has one on load for browser support, ULS has a couple when using the search input field etc. [15:29:22] Krinkle: As a blocker to removing jQuery Migrate? [15:29:38] Krinkle: Possibly. [15:29:47] Well, I wouldn't call it blocking the removal, but I suppose yes. [15:34:56] Right now there are failing unit tests in core with Migrate moved out of jQuery, let alone extensions, so… [15:35:17] For extensions in production I'd suggest that it does indeed block. [15:35:29] Random skins not in production, OTOH, … :-) [16:06:26] 3VisualEditor / 3Editing Tools: Save button no longer works in FF - 10https://bugzilla.wikimedia.org/65401 (10Chris McMahon) 3NEW p:3Unprio s:3critic a:3None Seen in Firefox 27 on Windows 8, FF 29 on OSX 10.6 Reported also on Win7, OSX 10.9 Edit any page on mw.o (or beta labs) Save button is clicka... [16:06:38] 3VisualEditor / 3Editing Tools: Save button no longer works in FF - 10https://bugzilla.wikimedia.org/65401#c1 (10Chris McMahon) Note: FF on Linux is fine. [16:13:53] 3VisualEditor / 3Editing Tools: Save button no longer works in FF - 10https://bugzilla.wikimedia.org/65401#c2 (10Chris McMahon) JS console log reports "JQMIGRATE: jQuery.browser is deprecated" [16:41:06] (03PS2) 10Alex Monk: Update beta warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) [16:47:24] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10James Forrester) [16:47:25] 3VisualEditor / 3Editing Tools: VisualEditor: Save button no longer works in FF - 10https://bugzilla.wikimedia.org/65401 (10James Forrester) 5NEW>3ASS p:5Unprio>3Highes a:3Krinkle [16:47:54] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10James Forrester) 5NEW>3ASS p:5Unprio>3Highes s:5normal>3critic a:3Krinkle [16:48:20] Krinkle: ^^^ Another(?) jQuery-upgrade critical VE bug. [16:49:12] (03PS2) 10Alex Monk: Update wikitext-warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) [16:49:38] 3VisualEditor / 3Editing Tools: VisualEditor: Save button no longer works in FF - 10https://bugzilla.wikimedia.org/65401#c3 (10Krinkle) (In reply to Chris McMahon from comment #2) > JS console log reports "JQMIGRATE: jQuery.browser is deprecated" Unrelated. [16:51:53] 3VisualEditor / 3Editing Tools: VisualEditor: Firefox throws NS_ERROR_NOT_AVAILABLE when clicking save button - 10https://bugzilla.wikimedia.org/65401 (10Krinkle) [16:53:56] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jquery.browser - 10https://bugzilla.wikimedia.org/65404 (10James Forrester) 3ASS p:3Unprio s:3enhanc a:3Ed Sanders ve.ce.Surface uses $.browser to do paste special casing; replace or remove this. [16:54:10] (03PS2) 10Jforrester: [WIP] Remove IE check from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [16:54:54] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jquery.browser - 10https://bugzilla.wikimedia.org/65404 (10James Forrester) p:5Unprio>3High [16:57:39] 3VisualEditor / 3Editing Tools: VisualEditor: Firefox throws NS_ERROR_NOT_AVAILABLE when clicking save button - 10https://bugzilla.wikimedia.org/65401#c4 (10James Forrester) (In reply to Krinkle from comment #3) > (In reply to Chris McMahon from comment #2) > > JS console log reports "JQMIGRATE: jQuery.brows... [16:58:23] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404 (10Krinkle) [16:59:47] (03CR) 10Jforrester: "This will need rebasing, at least, given I957880e1866c9 – but possibly abandoned?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131078 (owner: 10Krinkle) [17:08:05] (03PS1) 10Krinkle: [WIP] Element: Work around Firefox exception in getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) [17:10:38] 3VisualEditor / 3Editing Tools: VisualEditor: Firefox throws NS_ERROR_NOT_AVAILABLE when clicking save button - 10https://bugzilla.wikimedia.org/65401#c5 (10Chris McMahon) Also, I was wrong above, FF on Ubuntu/Linux also shows the problem. [17:11:23] 3VisualEditor / 3Editing Tools: VisualEditor: Firefox throws NS_ERROR_NOT_AVAILABLE when clicking save button - 10https://bugzilla.wikimedia.org/65401#c6 (10Krinkle) 5ASS>3RES/DUP Hm.. not caused by the save button click, but due to the dialog being opened. So the same as bug 65373. *** This bug has bee... [17:11:24] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c12 (10Krinkle) *** Bug 65401 has been marked as a duplicate of this bug. *** [17:12:08] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c13 (10Krinkle) Happens when opening any dialog that inherits directionality (OO.ui.ConfirmationDialog, ve.ui.MWSaveDialog, etc.) [17:43:53] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c14 (10Krinkle) More elaborate trace: Error: [Exception... "Component is not available" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame ::... [18:05:55] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot save any page on Betalabs with chrome , 500 (Internal Server Error) appears in the console - 10https://bugzilla.wikimedia.org/65407 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15418 --> https://bugzilla.wikimedia.org/attachme... [18:06:38] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c15 (10James Forrester) *** Bug 65407 has been marked as a duplicate of this bug. *** [18:06:39] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot save any page on Betalabs with chrome , 500 (Internal Server Error) appears in the console - 10https://bugzilla.wikimedia.org/65407#c1 (10James Forrester) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 65373 *** [18:08:02] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=65407 is in Chrome [18:08:14] which was working fine yesterday [18:08:50] ryasmeen: Huh. But the same as https://bugzilla.wikimedia.org/show_bug.cgi?id=65401 ? [18:09:49] I dont know if they are related or not, but its a different error [18:09:57] and a different behavior [18:10:16] Hmm. OK, reopening. :-) [18:10:23] In firefox the NS_Error thing appears as soon as you open some dialogs [18:10:50] but in Chrome, it's not happening for any other dialogs, only when I click Save on the "Save Page " dialog [18:10:53] okay :) [18:11:10] Yeah. [18:11:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot save any page on Betalabs, 500 (Internal Server Error) appears in the console in Chrome - 10https://bugzilla.wikimedia.org/65407 (10James Forrester) 5RES/DUP>3REO p:5Unprio>3Immedi s:5normal>3critic a:3Roan Kattouw [18:11:46] ryasmeen: Have RoanKattouw_away and TrevorParscal made it in yet, or are they still biking? [18:11:53] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10James Forrester) [18:11:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot save any page on Betalabs, 500 (Internal Server Error) appears in the console in Chrome - 10https://bugzilla.wikimedia.org/65407 (10James Forrester) 5REO>3ASS [18:12:28] James_F: No they are here :) , I will let them know about it [18:12:39] ryasmeen: Thanks! [18:16:49] James_F: we are here [18:17:09] we got in a while ago, but took a min to cool down, eat something, change shirts, etc. [18:20:40] The Chrome save dialog thing is a fatal in TimedMediaHandler [18:23:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot save any page on Betalabs, 500 (Internal Server Error) appears in the console in Chrome - 10https://bugzilla.wikimedia.org/65407#c2 (10Roan Kattouw) This is a 500 from an API request: PHP fatal error in /srv/common-local/php-master/i... [18:23:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot save any page on Betalabs, 500 (Internal Server Error) appears in the console in Chrome - 10https://bugzilla.wikimedia.org/65407#c3 (10Roan Kattouw) Caused by https://gerrit.wikimedia.org/r/#/c/120827/ [18:28:15] TrevorParscal: You and I should collude with Melissa and take advantage of this: http://www.sfbike.org/news/rainbow-discount-back-for-june/ [18:30:08] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c16 (10Krinkle) Upstream bug report: http://bugs.jquery.com/ticket/15098 [18:32:38] (03CR) 10Catrope: [C: 04-1] "Typo in comment" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [18:36:09] (03CR) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [18:38:42] RoanKattouw: Fatal in TMH? Fun… [18:39:17] Yeah [18:39:27] So now I have to get this thing set up to reproduce the fatal, then test a fix [18:43:39] RoanKattouw: So, fun thing: http://jsfiddle.net/eXt63/ [18:44:07] RoanKattouw: With http://bugs.jquery.com/ticket/15098#comment:6 in mind [18:44:19] RoanKattouw: However here too there is a flaw in our code [18:44:28] We're doing getDir after display none [18:44:39] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set table cell background (and other formatting options) - 10https://bugzilla.wikimedia.org/52180#c1 (10WhatamIdoing) "Other formatting" should include support for font size and line height, so that tables like the ones seen at https://en.wikipedia.org... [18:44:44] Eventhough we specifially have visibility hidden first so that we can compute stuff [18:44:49] Right [18:45:07] I have to catch a train in 20 minutes, I"ll be online in 2 hours [18:45:16] OK [18:45:32] Would be nice if someone could change https://gerrit.wikimedia.org/r/#/c/133738/ to instead call it at the right time [18:45:44] The call I found was in PanelLayout, as used by ConfirmationDialog [18:45:48] Where is it called from? [18:45:49] Oh OK [18:45:53] It's called on a hidden panel? [18:45:59] Use demos/dialogs.html [18:46:01] last button [18:46:03] in oojs-ui [18:46:07] In Firefox [18:46:34] Will work on master because lib/jquery is still 1.8.3 so curl/wget https://code.jquery.com/jquery-1.11.1.js in there [18:46:44] No need for migrate plugin in oojs-ui afaik, at least not for this [18:47:03] as soon as you replace jquery, it will start failing in firefox when you click the confirmation dialog open button in the demo/dialogs [18:47:27] (03CR) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [18:47:32] OK [18:47:32] I'll poke at that later [18:47:41] http://bugs.jquery.com/ticket/15098#comment:6 http://jsfiddle.net/eXt63/ https://bugzilla.wikimedia.org/show_bug.cgi?id=65373 [18:47:49] all that should be enough info :) [18:47:58] g2g, thx, will check in later [18:49:30] (03CR) 10Krinkle: [C: 04-1] "-" [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [18:50:31] (03PS11) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [18:56:45] (03PS1) 10Jforrester: Upgrade jQuery from 1.8.2 to 1.11.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/133768 [18:57:03] RoanKattouw: ^^^ So you can do easier testing (and once fixed, we can merge it). [18:57:12] Thanks [19:23:54] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314#c6 (10ryasmeen) Verified the fix in test2 [19:26:54] 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463#c6 (10ryasmeen) 5RES/FIX>3REO The message "No results found" stays in the dialog even if user changed the search string and the... [19:27:23] 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463#c7 (10ryasmeen) Created attachment 15419 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15419&action=edit Screenshot [19:28:32] mooeypoo: I reopened this bug and added a comment to it:https://bugzilla.wikimedia.org/show_bug.cgi?id=52463 [19:31:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269#c5 (10ryasmeen) Verified the fix on test2 [19:44:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239#c6 (10ryasmeen) Verified the fix in test2 [19:44:42] TrevorParscal, so I'm looking at optimisations [19:45:25] the whole point of shields is to work around the IE ce=false bug? [19:48:03] edsanders: Yes. [19:48:08] two things occur to me [19:49:14] 1. we can special case IE, that would solve the mobile problem. We still need to build the focus outline but that can be done on click or first mouseenter [19:50:50] https://gerrit.wikimedia.org/r/#/c/133284/4/src/elements/ButtonedElement.js,unified [19:50:54] 2. there's a workaround for IE if you double wrap in ce=false [19:54:55] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10James Forrester) [19:55:05] edsanders: The original plan was to do

[19:55:13] edsanders: But I think it was considered ugly, or something. [19:57:38] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set table cell background (and other formatting options) - 10https://bugzilla.wikimedia.org/52180#c2 (10James Forrester) (In reply to WhatamIdoing from comment #1) > "Other formatting" should include support for font size and line height, so > that tab... [20:00:53] TrevorParscal, re:mousedown return false: every tool, otherwise we blur the document and nullify the range [20:01:34] I think in general clickable should not mean focusable [20:01:56] 3VisualEditor / 3Mobile: VisualEditor: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15420 --> https://bugzilla.wikimedia.org/at... [20:02:04] we should mixin focusable when we want that, and then we can add focus methods [20:02:54] 3VisualEditor / 3Mobile: VisualEditor: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411 (10ryasmeen) a:3Jon [20:04:56] 3VisualEditor / 3Mobile: VisualEditor: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411#c1 (10ryasmeen) Correction: Do not edit the page on step2 just tap on CE to place the cursor and cross the VE out to r... [20:06:08] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) 5PAT>3RES/FIX [20:10:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411 (10ryasmeen) [20:17:09] (03CR) 10Esanders: Ignore SelectWidget mouseup events that started outside the widget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [20:17:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: The tapping on Mobile VE is extremely inconsistent compared to standard - 10https://bugzilla.wikimedia.org/65413 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None I experienced a huge inconsistency around the precision of tapping action for Mobile VE in all k... [20:17:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: The tapping on Mobile VE is extremely inconsistent compared to standard - 10https://bugzilla.wikimedia.org/65413 (10ryasmeen) a:3Jon [20:18:18] TrevorParscal: Ping. You should look at the thread "How to disable MediaViewer for some images" on multimedia@… and possibly reply – they're talking about maybe doing semantic image type markup. [20:18:26] And with that, I'm running way. [20:18:28] +a [20:30:55] 3VisualEditor / 3Mobile: VisualEditor: Lock sign appearing over the Edit option on Mobile VE even if user has Beta and Experimental Mode on - 10https://bugzilla.wikimedia.org/65414 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15421 --> https://bugzilla.wikimedia.org/attachment.c... [20:31:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: Lock sign appearing over the Edit option on Mobile VE even if user has Beta and Experimental Mode on - 10https://bugzilla.wikimedia.org/65414 (10ryasmeen) [20:38:38] 3VisualEditor / 3Editing Tools: VisualEditor: Opening a popupToolGroup should disable other tools - 10https://bugzilla.wikimedia.org/65374#c1 (10Ryan Kaldari) 5NEW>3RES/INV After talking with Trevor and Kaity, we're going to punt this one for now. [20:39:20] edsanders: hey, so about this return false [20:40:09] I agree that it should return false by default, and we can configure it not to in cases (like in ButtonOptionWidget) [20:40:44] but, I'm interested in your thoughts about how we arleady have tabIndex=-1 for prevent tab focusing, because then if we have a focusable option, that seems odd [20:41:18] what I need is an option called focusOnClick but that feels like an awkward name to me [20:41:30] what do you think? [20:41:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: VE is not appearing as an option to edit even if Beta-Experimental mode is on - 10https://bugzilla.wikimedia.org/65415 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15422 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15422&acti... [20:43:11] 3VisualEditor: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None Reproducible: Didn't try Tables like the ones seen at https://en.wikipedia.org/w/index.php?oldid=608813235#... [20:44:08] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set table cell background (and other formatting options) - 10https://bugzilla.wikimedia.org/52180#c3 (10WhatamIdoing) This issue of table cell paragraph formatting is now Bug 65416. [20:48:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: VE is not appearing as an option to edit even if Beta-Experimental mode is on in iPhone 4S - 10https://bugzilla.wikimedia.org/65415 (10ryasmeen) [20:56:03] (03CR) 10GWicke: "Don't fear too much! Since I have already defined what's measured interpretation & validation should not be an issue here. All that's miss" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [20:58:08] 3VisualEditor: VisualEditor: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - 10https://bugzilla.wikimedia.org/65377#c1 (10Ryan Kaldari) After discussing with Trevor we decided the best way to implement this would be to have a parameter like 'label-position' which co... [20:58:48] mooeypoo: lol, Rummana found a bug with your "No results found" code: https://bug-attachment.wikimedia.org/attachment.cgi?id=15419 [20:58:49] TrevorParscal: Is there someone I should assign this bug to or should I take a stab at it myself: https://bugzilla.wikimedia.org/show_bug.cgi?id=65377 [20:59:47] That should probably be a bug in OOJS-UI [21:00:03] IMO you should take a stab at it yourself, with some guidance from TrevorParscal [21:00:10] Would help you get your feet wet with OOUI a bit [21:00:18] and go with option 1 [21:00:52] 3VisualEditor: VisualEditor: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - 10https://bugzilla.wikimedia.org/65377#c2 (10Trevor Parscal) I would recommend option 1. [21:02:55] (03PS5) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [21:03:04] edsanders: see ^^^^^^ [21:03:46] TrevorParscal, what's the conflict between tabindex=-1 and focusable then? [21:04:08] well, I ended up using a static configuration instead of an instance one [21:04:37] anytime you find yourself overriding configs in a constructor, you probably are doing something wrong [21:04:47] also, I named it cancelButtonMouseDownEvents [21:04:51] very long, but very clear [21:07:45] so you're saying a future FocusableElement mixin would override that to false? [21:19:25] 3VisualEditor / 3Mobile: VisualEditor: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15423 --> https://bugzilla.wikimedia.org/attac... [21:19:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418 (10ryasmeen) a:3Jon [21:20:12] FocusableElement? [21:20:22] is the an imaginary mixin from the future? [21:20:36] are you thinking about FocusableNode? [21:21:20] ryasmeen: https://bugzilla.wikimedia.org/show_bug.cgi?id=65407 should be fixed now [21:22:26] TrevorParscal: [21:22:27] https://en.wikipedia.org/wiki/Wikipedia:VE/F#VE_is_actually_becoming_usable [21:26:53] 3VisualEditor / 3Editing Tools: VisualEditor: Change "newspaper" to "news" - 10https://bugzilla.wikimedia.org/65207#c1 (10Roan Kattouw) (In reply to WhatamIdoing from comment #0) > https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition. > json says: > > { "name": "news", "icon": "ref-c... [21:28:03] (03PS1) 10Catrope: Change label for news citation tool from "Newspaper" to "News" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133839 (https://bugzilla.wikimedia.org/65207) [21:28:54] (03CR) 10Catrope: "Trivial change, but I'd like James to look at it before it's merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133839 (https://bugzilla.wikimedia.org/65207) (owner: 10Catrope) [21:32:08] 3VisualEditor / 3Editing Tools: VisualEditor: Change "newspaper" to "news" - 10https://bugzilla.wikimedia.org/65207#c3 (10Roan Kattouw) (In reply to Gerrit Notification Bot from comment #2) > Change 133839 had a related patch set uploaded by Catrope: > Change label for news citation tool from "Newspaper" to... [21:41:35] imaginary mixin from the future [21:43:46] TrevorParscal, this sort of thing: https://gist.github.com/edg2s/18b8879766d7ea45c6db [21:44:14] TrevorParscal: Is now a good time to get some pointers from you on adding the label-position param? [21:44:57] mostly just trying to figure out where the parameters actually get processed, but it's something of a maze [21:45:23] 3VisualEditor / 3Data Model: VisualEditor: URLs followed immediately by {{templates}} are un-editable alienated content, because they're mw:ExpandedAttrs - 10https://bugzilla.wikimedia.org/65362#c2 (10Roan Kattouw) Supposedly the reason for this is that http://example.com{{echo|/index.php}} would produce a l... [21:45:34] (03CR) 10Thiemo Mättig (WMDE): "> SVG support is considered a mandatory minimum for VisualEditor." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133099 (owner: 10Bartosz Dziewoński) [21:46:49] (03CR) 10Catrope: "The check is there, but in practice we're already blacklisting all browsers that fail the check anyway, and we've neglected to add PNGs fo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133099 (owner: 10Bartosz Dziewoński) [21:51:50] TrevorParscal: ping ^ [21:55:08] 3VisualEditor / 3Editing Tools: Raster icons missing from VE toolbar - 10https://bugzilla.wikimedia.org/65271#c3 (10Thiemo Mättig) 5RES/WON>3REO (In reply to James Forrester from comment #2) > We do not intend to load raster icons in VisualEditor. You *do* load raster icons in VisualEditor. Look: https... [21:55:45] (03PS1) 10Trevor Parscal: Change Cite > Newspaper to Cite > News [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133841 [21:57:22] kaldari: looking [21:57:57] edsanders: that patch would only give a way to support the focus() method, not deal with focusing via tab or click [21:58:32] right [22:01:43] but it could override that new static [22:05:39] 3VisualEditor / 3Editing Tools: Citation tools in Mobile VE broken in Firefox - 10https://bugzilla.wikimedia.org/65422 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None If I choose a citation tool from the Cite drop-down in Firefox, I get the JS error "NS_ERROR_NOT_AVAILABLE". It works fine from Chrom... [22:06:26] The citations tools in mobile VE are broken in Firefox, BTW: ^ [22:08:08] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c17 (10ryasmeen) *** Bug 65422 has been marked as a duplicate of this bug. *** [22:08:09] 3VisualEditor / 3Editing Tools: Citation tools in Mobile VE broken in Firefox - 10https://bugzilla.wikimedia.org/65422#c1 (10ryasmeen) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 65373 *** [22:08:10] kaldari: looks like https://bugzilla.wikimedia.org/show_bug.cgi?id=65401 [22:08:52] chrismcmahon: ah, good spot [22:13:44] kaldari: that should only be in mw.o and it should be fixed like any minute if it isn't already [22:14:06] (03PS2) 10Trevor Parscal: Change Cite > Newspaper to Cite > News [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133841 [22:15:58] (03PS3) 10Catrope: Change Cite > Newspaper to Cite > News [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133841 (https://bugzilla.wikimedia.org/65207) (owner: 10Trevor Parscal) [22:20:40] What in the name of all that is imagey is this bug [22:21:27] also, hi everyone. I'm back. That's not to say I'm successful. I have to go back for more form-hunting on Tuesday. Yaaa-aay. [22:24:01] Yaay [22:24:04] mooeypoo: What bug? [22:24:18] (03Abandoned) 10Catrope: Change label for news citation tool from "Newspaper" to "News" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133839 (https://bugzilla.wikimedia.org/65207) (owner: 10Catrope) [22:24:59] (03CR) 10Jforrester: [C: 032] Change Cite > Newspaper to Cite > News [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133841 (https://bugzilla.wikimedia.org/65207) (owner: 10Trevor Parscal) [22:25:39] 3VisualEditor / 3Editing Tools: VisualEditor: Change "newspaper" to "news" - 10https://bugzilla.wikimedia.org/65207 (10James Forrester) 5PAT>3RES/FIX p:5Unprio>3Normal a:3Trevor Parscal [22:26:13] RoanKattouw, the 'results not found' bug. I can't replicate, and I can't understand why it *would* happen.. it's being reset on every initial call. Unless there's a mixup in the count, which seems odd. [22:26:17] Right [22:26:23] in any case, I can't reproduce it. Works for me on labs and on master [22:26:27] mooeypoo: Maybe while one request has come back but the other hasn't? [22:26:35] (03Merged) 10jenkins-bot: Change Cite > Newspaper to Cite > News [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133841 (https://bugzilla.wikimedia.org/65207) (owner: 10Trevor Parscal) [22:26:42] I've been typing/deleting fast [22:26:48] seems to behave properly for me on labs [22:26:59] oh [22:27:00] there we go [22:27:11] yes. Hm. Okay, when tons of answers go out at once [22:27:38] damnit. [22:28:02] Hey. [22:28:03] (03PS1) 10Alex Monk: Don't add ve-edit tab in namespaces where it's not available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133851 (https://bugzilla.wikimedia.org/64142) [22:30:23] meh... [22:30:39] I'm guessing there'll still be bugs related to that one^ [22:30:41] RoanKattouw, I guess I'll make it go with the $.when() if I'm already fixing it up. I've never dealt with $.when() though. The code is going over and setting up api requests.. do I set those (including their individual .done() and .always() into an array and then feed that array into the $.when() ? [22:31:08] there are way too many different things to check to see whether VE should be on or off [22:33:10] mooeypoo, you can use $.when to trigger some code when multiple promises have been resolved/rejected, if that's what you mean [22:33:49] yeah, i'm trying to figure out how to sort the promises out individually [22:33:55] mooeypoo: The API requests individually return promises, you can gather those into an array [22:33:59] in any case, I have a solution for the bug regardless of the $.when() [22:34:04] I might do that first [22:34:07] 3VisualEditor / 3ContentEditable: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [22:34:09] Like, the return value of ajax() is a promise (kind of) [22:34:17] mooeypoo: Yeah definitely fix the bug first [22:34:25] 3VisualEditor / 3ContentEditable: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416 (10James Forrester) a:3Ed Sanders [22:34:48] (03PS1) 10Krinkle: build: Implement build target optimised for jQuery [oojs/core] - 10https://gerrit.wikimedia.org/r/133855 [22:34:49] RoanKattouw, okay, that's what I thought. Got a bit confused with the .done() and .always() of the *individual* promises vs the $.when() which is after all are over [22:34:50] (03PS1) 10Krinkle: test: Clean up [oojs/core] - 10https://gerrit.wikimedia.org/r/133856 [22:34:52] (03CR) 10Alex Monk: [C: 04-1] " meh..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133851 (https://bugzilla.wikimedia.org/64142) (owner: 10Alex Monk) [22:34:52] I'll have to sort it out. [22:34:53] tadaa [22:35:09] At least that 1 hour delay in Germany wasn't all for nothing [22:35:14] We have oojs.jquery.js now [22:36:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: VE is not appearing as an option to edit even if Beta-Experimental mode is on in iPhone 4S - 10https://bugzilla.wikimedia.org/65415 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [22:36:52] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10Krinkle) 5PAT>3NEW [22:37:35] RoanKattouw: Any luck on the getDir thingy? [22:37:49] Just starting to look at it [22:38:07] Put in a debugger; and a console.log('wtf'); , let's see what happens [22:38:51] (03CR) 10jenkins-bot: [V: 04-1] build: Implement build target optimised for jQuery [oojs/core] - 10https://gerrit.wikimedia.org/r/133855 (owner: 10Krinkle) [22:38:53] (03CR) 10jenkins-bot: [V: 04-1] test: Clean up [oojs/core] - 10https://gerrit.wikimedia.org/r/133856 (owner: 10Krinkle) [22:39:12] ()riDteg [22:39:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3major [22:40:07] hm, I'm getting a jscs bug that doesn't seem to be related to my code .. anyone else sees it? "Warning: requireMultipleVarDecl option requires boolean value Use --force to continue." [22:40:09] mooeypoo: No no no. [22:40:19] mooeypoo: )riDteg). [22:40:23] James_F, on on On. [22:40:32] oh, capitalization fail. [22:40:38] I lose [22:40:39] * James_F grins. [22:41:36] (03PS1) 10Mooeypoo: Hide 'no results found' once there's at least one result [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133858 (https://bugzilla.wikimedia.org/52463) [22:41:57] Timo would like my commit message. It's very explanatory. [22:42:13] I'm sure he'd find something to complain about. :-D [22:43:12] I can probably make it even clearer [22:44:55] Anyway. I'm off. [22:44:58] * James_F waves. [22:45:04] See ya James! [22:45:06] have a good weekend [22:45:10] And you! [22:49:34] mooeypoo: If you're having jshint/jscs trouble, make sure you're 1) rebased onto master cause Timo messed with the config and 2) run npm install to update those packages, because Timo's config-messing requires recent versions [22:56:14] Krinkle: Hmm so I'm pretty sure that that line in the PanelLayout constructor that calls getDir() is completely unnecessary [22:56:30] The directionality should already be inherited through [22:56:51] Always alias npm test to npm install. npm-install is a cheap no-op (not even network 304) if nothing changed. [22:56:57] npm install && npm test [22:57:20] RoanKattouw: Yeah [22:57:28] RoanKattouw: I noticed that in Frame.load [22:57:32] we set it like three times [22:57:42] this.dir = closest([dir]).prop('dir') [22:57:54] then class=content-{dir}, direciton:{dir} and dir={dir} [22:57:56] in doc.write() [22:58:04] so setting it again really ought to not be needed [22:58:10] I saw that, but didn't connect the two [22:58:15] good find [22:58:20] I guess thats's why it works [22:58:30] actually, it might be breaking something [22:58:39] since it will return 'ltr' unconditionally under display none [22:58:41] (I think) [22:58:46] default styles [22:58:56] (and null or empty string in FF) [22:59:02] (with jq 1.8.3) [22:59:20] RoanKattouw: Hm.. OK. I'll just remove for now then and see what happens [22:59:32] I just found the commit that introduced it [22:59:43] It took some effort to find it, across a repo move and a VE/OO split [22:59:49] e8e0413dfa0aaf81047b1430336cfa6bb337e64c [23:00:41] It sounds like there might have been an issue with the outline of a BookletLayout appearing on the wrong side, but I can't reproduce that [23:00:52] Maybe CSS transplantation made that problem go away [23:01:26] In any case, there's a direction: property set on the iframe's , and that direction is then re-asserted on the panel, so the only reason that would ever affect anything is if there was another direction set in between, and I don't see why that would ever happen [23:03:03] (03PS2) 10Krinkle: PanelLayout: Remove call to getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) [23:04:12] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/69341/ ? [23:04:21] (03PS3) 10Catrope: PanelLayout: Remove call to getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [23:04:23] e8e0413dfa0 wasn't found but via git raw I retreived it [23:04:44] Right [23:04:45] (03PS4) 10Krinkle: PanelLayout: Remove call to getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) [23:04:51] That hash must be the imported version in OOJS-UI [23:04:52] using gerrit change-id instead [23:04:57] yeah [23:05:10] Krinkle: Also, retr*ie*ving [23:05:16] i before e except after c [23:05:19] because it belongs to MW-VE originally according to gerrit [23:05:21] I know, sorry. [23:05:29] It's like floating point math. [23:05:44] storing the exact rules is too expensive. [23:05:45] haha [23:06:23] mooeypoo: Could I get your thoughts on https://gerrit.wikimedia.org/r/#/c/133738/ please? [23:07:11] mooeypoo: It fixes a very nasty Firefox problem but I'm wary of removing RTL support code that was introduced by you [23:14:50] (03CR) 10Catrope: [C: 032] Hide 'no results found' once there's at least one result [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133858 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:15:42] RoanKattouw: If you can merge that oojs-ui change, let's see if we can do a pull through to master, and once that's confirmed on beta, we can schedule a swat asap before the next train station [23:15:45] (03CR) 10Catrope: [C: 04-1] "Nooooes! This makes changes to $wgVisualEditorNamespaces take effect very slowly." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133851 (https://bugzilla.wikimedia.org/64142) (owner: 10Alex Monk) [23:15:47] (deploy train that is) [23:16:20] (03Merged) 10jenkins-bot: Hide 'no results found' once there's at least one result [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133858 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:17:45] RoanKattouw, due to caching I guess? [23:17:53] ugh [23:18:15] Yeah [23:18:31] Krinkle: Yeah this needs to be in Monday morning's SWAT [23:18:45] I guess breaking RTL slightly is less bad than breaking Firefox completely [23:19:00] RoanKattouw, guess I could detect whether or not the VE edit button is visible when you trigger it [23:19:07] (03CR) 10Catrope: [C: 032] PanelLayout: Remove call to getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [23:19:24] Krenair: I mean we already hide the button client side in that case [23:19:29] yeah [23:19:33] (03Merged) 10jenkins-bot: PanelLayout: Remove call to getDir() [oojs/ui] - 10https://gerrit.wikimedia.org/r/133738 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [23:19:37] The only reason it shows up again is due to a Vector bug [23:19:38] but that doesn't stop the accesskey from working, apparently [23:20:02] Urgh [23:20:13] (see the bug this commit was intended to fix) [23:20:18] Right [23:20:22] I assumed it was a different bug [23:20:36] Maybe we should kill the accesskey when we hide [23:23:29] RoanKattouw, pretty sure it's hidden by the fact that we have .ve-not-available set on the HTML tag in CSS [23:23:53] Hmm right [23:24:00] (03PS1) 10Jforrester: Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) [23:24:10] I mean, CSS hides it because has .ve-not-available. I should go to bed. [23:24:31] Krenair: RoanKattouw: any reason why you don't do $('#ca-ve-edit:hidden').remove() in init/startup/whatever somewhere? [23:24:42] that seems like it'd fix a ton of bugs [23:25:09] yeah that sounds like another way to fix it. [23:25:13] related to the tab being sorta-hidden-but-not-really [23:25:38] (03CR) 10jenkins-bot: [V: 04-1] Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) (owner: 10Jforrester) [23:25:55] also wouldn't need to consider the veaction param in the URL that way [23:28:29] MatmaRex, could just removeAttr the accesskey too [23:28:48] Krenair: there's another bug about the tab reappearing due to vector's collapsibleTabs [23:29:22] MatmaRex, link please? [23:30:03] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=65292 / https://bugzilla.wikimedia.org/show_bug.cgi?id=65294 [23:31:08] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (d4086ff6e6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133867 [23:31:31] MatmaRex, ugh. ok, thanks. [23:46:49]