[08:47:38] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c4 (10Derk-Jan Hartman) 5RES/FIX>3REO Far from fixed. oo-ui-tool-link's for help and edit notices, should have tabIndex=0 and role=button to make them a focusable elements and they need... [08:56:14] 3OOjs UI: OOjs UL: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None The dialog doesn't have the role=dialog. Dialogs don't keep focus inside the dialog (can be fixed with putting aria-hidden=true on the rest of the content of the... [09:13:11] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10Andre Klapper) [09:13:26] 3OOjs UI: OOjs UL: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473 (10Andre Klapper) [09:19:13] 3VisualEditor / 3Editing Tools: Template editor is missing accessibility features - 10https://bugzilla.wikimedia.org/65474 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None ve-ui-mwParameterPage-actions have tabindex=-1, which makes them unreachable by keyboard, the same for the "Add parameter" b... [10:15:51] (03CR) 10Esanders: [C: 031] build: Implement build target optimised for jQuery [oojs/core] - 10https://gerrit.wikimedia.org/r/133855 (owner: 10Krinkle) [10:49:59] (03PS1) 10Esanders: Phantom optimisations, episode II [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 [10:51:10] (03CR) 10jenkins-bot: [V: 04-1] Phantom optimisations, episode II [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [13:14:28] 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni) [13:14:30] 3VisualEditor / 3Language: VisualEditor: Category autocompletion is broken in RTL wikis - 10https://bugzilla.wikimedia.org/65483 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 15438 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15438&action=edit a screenshot with the... [13:50:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: The "Review changes" button should be disabled when save dialog is locked during saving - 10https://bugzilla.wikimedia.org/65485 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None It should be disabled/muted like we do in other cases. [13:50:43] 3VisualEditor / 3Editing Tools: VisualEditor: The "Review your changes" button should be disabled when save dialog is busy - 10https://bugzilla.wikimedia.org/65310 (10Krinkle) [13:50:43] 3VisualEditor / 3Editing Tools: VisualEditor: The "Review your changes" button remains active and clickable on the Save dialog while the loading bar is in progress for saving the page - 10https://bugzilla.wikimedia.org/65310#c1 (10Krinkle) *** Bug 65485 has been marked as a duplicate of this bug. *** [13:50:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: The "Review changes" button should be disabled when save dialog is locked during saving - 10https://bugzilla.wikimedia.org/65485#c1 (10Krinkle) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 65310 *** [15:03:15] hi Krinkle is it known that in V [15:03:52] hi Krinkle is it known that right now in VisualEditor clicking the Insert/Template does nothing at all in Firefox? [15:04:06] Krinkle: this is on mw.o and beta labs [15:06:08] Yes, this was fixed last week and is pending SWAT today [15:06:20] Krinkle: thanks [15:06:23] Krinkle: the SWAT is just being discussed on #-operations btw [15:06:31] you totally want to chime in [15:22:11] 3VisualEditor / 3Language: VisualEditor: IME detection realies on jQuery.browser - 10https://bugzilla.wikimedia.org/65077#c1 (10David Chan) I'm in the process of stripping these checks out anyway, because the inIme checks cannot be made realiable. Does this need removing immediately? If so I can submit a sma... [15:23:26] 3VisualEditor / 3Language: VisualEditor: IME detection realies on jQuery.browser - 10https://bugzilla.wikimedia.org/65077#c2 (10Krinkle) It needs to not use $.browser within 2 weeks tops. [15:24:13] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404 (10Krinkle) [15:24:13] 3VisualEditor / 3Language: VisualEditor: IME detection realies on jQuery.browser - 10https://bugzilla.wikimedia.org/65077 (10Krinkle) [15:24:25] James_F: ping ? [15:24:47] matanya: Pong. [15:24:57] weirdest bug ever in VE [15:25:18] OK… :-) [15:25:21] when i edit an article in beta labs i get a different article than the one shown [15:25:59] Krinkle: Is the rest of the fix for bug 65373 coming in the next two hours, or are we reverting jQuery to 1.8? [15:26:11] matanya: Hmm. Sounds like a Parsoid issue. [15:26:18] and now 500 [15:26:20] James_F: What rest? [15:26:30] parsoidserver-http-bad-status: 500 [15:26:31] Right [15:27:41] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=65373#c19 [15:27:54] matanya: Yeah, sounds like Parsoid is borked in Beta Labs. :-( [15:28:50] thanks James_F i starting thinking i lost my vision [15:29:22] matanya: But it's working for me on my sandbox page. [15:29:29] matanya: What page were you having difficulties on? [15:29:53] James_F: e.g.: http://he.wikipedia.beta.wmflabs.org/wiki/%D7%96%27%D7%90%D7%9F_%D7%9E%D7%90%D7%A8%D7%94 [15:30:22] aritcle about Jean Alfred Villain-Marais and i get to edit Yizhak Rabin [15:30:36] Hmm. Yeah. [15:31:08] hmm, cool, every page get other random editing article [15:31:18] we should use this on April 1 [15:32:17] * James_F grins. [15:32:19] Let's not. [15:32:49] hmm, i get articles that don't even exist in beta labs, how is that possible [15:34:06] * MatmaRex remebers a parsoid bug like that [15:34:23] (when it would load content from a different wiki than the one you were editing on) [15:34:49] MatmaRex: it comes from production [15:36:00] matanya: Anyway, we should take this it -parsoid. :-) [15:45:42] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c20 (10Krinkle) btw, since Firefox's NS_ERROR_NOT_AVAILABLE exceptions have no stack trace. This is how you catch it: Locally modify jquery.js like this: --- a/... [15:50:56] Ugh, this is so fucked up [15:51:13] Basically OOjs UI is lacking a crucial way to handle its component setup [15:51:31] It's doing style computation at random places. Except for OO.ui.Frame which is pretty good in separating the two. [15:51:36] Krinkle: Fix now, complain to Trevor later? :-) [15:52:05] I can "fix" it by removing the getDir call. While that will make it no longer handle rtl, that's fine since that never worked (the code was a fake). However not entirely [15:52:17] the method that calls getDir is used both during setup and during redraw [15:52:25] Fun. [15:52:27] during setup it's fake and can be removed, during redraw it works fine now [15:52:33] can i veto removing RTL ? [15:52:34] and removing it would break rtl [15:52:34] (That sounds moderately inefficient.) [15:52:57] Krinkle: Can't we read it once, and if unset, read it that time? [15:53:13] either way, 80% of OOjs UI doesn't work properly in RTL right now (at least not the initial setup, because it's doing it while hidden). So that's a TODO item either way. [15:53:35] Krinkle: "dir = null; getDir() = { return (dir = null ? : dir; } [15:53:49] this., etc. etc. [15:53:51] James_F: Youd' still have to know when to get it [15:54:10] there is only 1 place that get called in both call stacks, very different call stacks [15:54:10] Krinkle: Don't fetch it at all at setup; make it null at tear-down. [15:54:25] (dialog.initialise, and dm-update>/ layout > update) [15:54:33] Krinkle: It doesn't change from moment to moment, but it might for different dialogs, yes?\ [15:54:42] I don't think it ever changes [15:55:09] It can between openings of a dialog, though. [15:55:13] https://github.com/wikimedia/oojs-ui/blob/master/src/layouts/GridLayout.js#L133 [15:55:31] Open an image dialog in an LTR document -> LTR [15:55:42] Open an image dialog in an RTL block inside an LTR document -> RTL [15:55:44] Right? [15:56:03] gets called from the constructor, which is used at random (whenever someone instantiates GridLayout, in case of Media Edit, it is instantiated in Dialog#initialize which is after it gets hidden) [15:56:14] Hmm. [15:56:16] but also from update() [15:56:31] mooeypoo: Have you noticed this being an issue to date with RTL support? [16:01:12] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c21 (10Krinkle) * Media Edit dialog mw.log James_F: Good news is, the three you reported are all caused by the same thing (GridLayout) [16:01:26] Krinkle: That is good, yes. [16:01:33] Krinkle: How fixable, though? [16:01:58] I'm considering adding a boolean property in the first line of the constructor and negating it in the last line of the constructor [16:02:01] and if that, skip getDir [16:02:07] there might be such a property already [16:02:13] e.g. isInitialising [16:02:54] Meh, no, it doesnt' have a link to the dialog tiself [16:02:58] they're independent elements [16:04:33] (03CR) 10Esanders: [C: 031] Whitelist Opera 15+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133110 (owner: 10Bartosz Dziewoński) [16:20:11] (03PS1) 10Krinkle: demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 [16:20:36] (03CR) 10Krinkle: [C: 032] Upgrade jQuery from 1.8.2 to 1.11.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/133768 (owner: 10Jforrester) [16:20:39] (03CR) 10jenkins-bot: [V: 04-1] demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 (owner: 10Krinkle) [16:21:16] (03Merged) 10jenkins-bot: Upgrade jQuery from 1.8.2 to 1.11.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/133768 (owner: 10Jforrester) [16:24:08] (03PS1) 10Esanders: Initialise save panel on 'ready' so focus works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134108 (https://bugzilla.wikimedia.org/65222) [16:24:10] (03PS2) 10Krinkle: demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 [16:24:59] (03CR) 10jenkins-bot: [V: 04-1] demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 (owner: 10Krinkle) [16:26:17] (03PS3) 10Krinkle: demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 [16:30:07] (03PS1) 10Krinkle: [WIP] GridLayout: Don't call getDir() during initialize [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) [16:31:11] (03PS4) 10Krinkle: demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 [16:31:16] (03PS2) 10Krinkle: [WIP] GridLayout: Don't call getDir() during initialize [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) [16:32:13] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c23 (10Krinkle) Hmm.. with https://gerrit.wikimedia.org/r/134110 applied locally, GridLayout dialogs still fail, this time a little further down the line: demos/... [16:36:46] Ugh, same again here. We're doing scrollIntoView form within the "setSelected" method, and we're using that method both for setting, unsetting and changing the value. [16:36:59] Especially using it for the initial value while there is no DOM yet, this is problematic. [16:37:14] And that's why you don't want to use one event for everything, Trevor.. [16:37:30] And we can't add an event now, because the semantic meaning is not present anywhere [16:38:01] RoanKattouw I'm runing out of my comfort zone, this is all above my head, I don't know anthing about OOjs UI it semes I'm fighting every class I encounter with fire. [16:38:40] What's going on? [16:38:49] More NS_ERROR_NOT_AVAILABLE stuff? [16:38:51] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=65373#c23 [16:38:59] Check out https://gerrit.wikimedia.org/r/134110 [16:39:05] open Grid sample dialog in demos/dialogs.html [16:39:10] OK, hold on [16:39:14] And witness that stack happening [16:39:19] This stack trace is from GridLayout *initialize* [16:39:33] Surely we should be allowed to measure CSS by the time that is called [16:39:44] Basically we need to not call scrollIntoView() when the iframe is still hidden (e.g. during initialize, which is called right *after* the iframe is loaded and hidden, but before its made visible) [16:40:05] s/call scrollIntoView()/( do css stuff ) [16:40:09] Well, then maybe that's the problem? Maybe the frame should be visibility: hidden; rather than display: none; while it's being initialized? [16:40:27] I mean constructors being weird, sure, but come on, there has to be a safe place to do .css() stuff [16:40:44] we don't separate those two very well [16:40:56] most constructors, espeially Layout subclasses, do it all in the constructor [16:41:06] I'm just plugging holes at this point [16:41:16] I'll see if moving all of initialize works [16:41:35] Do you mean moving all of this stuff *to* initialize? [16:42:00] No [16:42:11] RoanKattouw: Well, we're already doing this actually [16:42:19] display none / visibility hidden is done from Window#initialize [16:42:20] not before it [16:42:23] but we call the super first [16:42:31] (and have to for other stuff) [16:43:22] Okay, OnAfterInitialize is born [16:44:53] Wait wait [16:44:58] We shouldn't need onAfterInitialize [16:45:07] Surely widgets' initialize should only be called once the window is initialized? [16:45:37] Oh, I see what you're saying [16:46:40] But, no wait [16:47:02] Any subclass of Window (like Dialog or specific dialog implementations) should call its parent constructor first [16:47:08] That parent constructor should then set visibility hiddne [16:47:09] Right? [16:48:30] It already has visibility hidden from the get go [16:48:35] this is about changing it to display none [16:48:39] in the constructor [16:48:42] Oh [16:48:43] Well crap [16:48:46] initialize is what removes it and adds display none [16:48:48] Yeah that shouldn't happen [16:51:43] Hm.. works [16:53:43] (03PS3) 10Krinkle: [WIP] Window: Apply display:none after initialize, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) [16:55:21] (03PS4) 10Krinkle: Window: Apply display:none after initialize, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) [16:55:33] RoanKattouw: what do you think? [16:58:14] Let's see [16:58:54] Krinkle: Looks reasonable [16:58:55] Though you should test this [16:58:59] .hide() is full of dark magic [16:59:07] If it decides that what you're trying to hide is already hidden, it may be a no-op [16:59:20] Oh, nm [16:59:23] You're porting existing code [17:01:28] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c24 (10Krinkle) Instead of trying to fill all the wholes where we're doing style computation to early, I've revised https://gerrit.wikimedia.org/r/134110 to inste... [17:01:47] James_F: Yep, all dialogs work again for me with that patch applied. Yay. [17:05:15] Krinkle, are you going to join us? [17:27:04] (03CR) 10Catrope: [C: 032] Window: Apply display:none after initialize, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [17:28:55] (03Merged) 10jenkins-bot: Window: Apply display:none after initialize, not before [oojs/ui] - 10https://gerrit.wikimedia.org/r/134110 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [17:30:48] RoanKattouw: How come oojs-ui.css was committed? [17:30:48] the update script excludes it [17:30:49] meidawiki core [17:31:38] When was it committed? [17:31:49] Yeah somehow the update script doesn't exclude it for me, I don't know why [17:32:28] mooeypoo: I can reproduce your category dropdown alignment problem, and it doesn't appear to be caused by my/Timo's RTL change [17:35:55] RoanKattouw: I suspect you had the file in your local directory already as an older untracked file [17:36:18] Though I'm not sure how that would work [17:36:24] we have --exclude and --delete [17:36:51] Yeah I deleted it before, and it appears to have come back [17:39:03] are dialogs broke in MW on FF? [17:39:59] Yeees? [17:40:05] They have been since Thursday [17:40:10] This is what all the fuss was about [17:40:22] We just landed a fix in OOUI, I'll do a pull-through [17:42:04] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (521a9e242b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134133 [17:42:44] 3VisualEditor: VisualEditor: Special character inserter breaks up links to other pages - 10https://bugzilla.wikimedia.org/65497 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Start with a link to another page, e.g., [[abc]]. 2. Use the special character inserter tool to add... [17:44:01] Krinkle, edsanders: https://gerrit.wikimedia.org/r/134135 & https://gerrit.wikimedia.org/r/134133 [17:44:42] edsanders: Does https://gerrit.wikimedia.org/r/#/c/134108/ suffer from the issue you were talking about with focus in Firefox? [17:44:48] Is it good to merge regardless? [17:45:04] I'd tell you if I could test it :), and yes [17:45:06] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (521a9e242b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134133 (owner: 10Catrope) [17:45:33] haha that's right you can't test it [17:45:56] Once Jenkins gets around to merging that pull-through that Krinkle just +2ed, you will be able to [17:46:08] (03CR) 10Catrope: [C: 032] Initialise save panel on 'ready' so focus works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134108 (https://bugzilla.wikimedia.org/65222) (owner: 10Esanders) [17:46:31] (03CR) 10Catrope: [C: 032] On file pages, only replace the (local) image description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133897 (https://bugzilla.wikimedia.org/65349) (owner: 10Alex Monk) [17:47:15] (03CR) 10Catrope: [C: 032] Remove edit tab from the DOM if it's hidden [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133851 (https://bugzilla.wikimedia.org/64142) (owner: 10Alex Monk) [17:47:31] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (521a9e242b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134133 (owner: 10Catrope) [17:48:56] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c26 (10Greg Grossmeier) (In reply to Gerrit Notification Bot from comment #25) > Change 134110 merged by jenkins-bot: > Window: Apply display:none after initializ... [17:49:14] (03PS1) 10Esanders: Fix styling on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134137 [17:49:27] (03Merged) 10jenkins-bot: Initialise save panel on 'ready' so focus works [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134108 (https://bugzilla.wikimedia.org/65222) (owner: 10Esanders) [17:49:27] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c27 (10Roan Kattouw) (In reply to Greg Grossmeier from comment #26) > (In reply to Gerrit Notification Bot from comment #25) > > Change 134110 merged by jenkins-b... [17:50:08] (03CR) 10Catrope: [C: 032] Fix styling on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134137 (owner: 10Esanders) [17:51:10] (03Merged) 10jenkins-bot: On file pages, only replace the (local) image description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133897 (https://bugzilla.wikimedia.org/65349) (owner: 10Alex Monk) [17:51:13] (03Merged) 10jenkins-bot: Remove edit tab from the DOM if it's hidden [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133851 (https://bugzilla.wikimedia.org/64142) (owner: 10Alex Monk) [17:51:20] James_F: Could you CR these message changes? https://gerrit.wikimedia.org/r/#/c/133637/ & https://gerrit.wikimedia.org/r/#/c/133639/ [17:52:30] (03CR) 10Catrope: [C: 032] Phantom optimisations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133892 (owner: 10Esanders) [17:53:11] mooeypoo: hallo [17:53:34] (03Merged) 10jenkins-bot: Fix styling on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134137 (owner: 10Esanders) [17:53:39] (03Merged) 10jenkins-bot: Phantom optimisations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133892 (owner: 10Esanders) [17:53:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Don't bind the 'v' accesskey for VisualEditor in namespaces where VE is not enabled - 10https://bugzilla.wikimedia.org/64142 (10James Forrester) 5PAT>3RES/FIX a:3Alex Monk [17:54:32] James_F: as usual, things are even worse than expected: [17:55:19] en: [17:55:19] { prefix: 'en', [17:55:19] local: '', [17:55:19] language: 'English', [17:55:21] url: 'http://en.wikipedia.org/wiki/$1' }, [17:55:22] but [17:55:23] 'en-gb': [17:55:24] { prefix: 'en-gb', [17:55:26] url: '//en-gb.wikipedia.org/wiki/$1', [17:55:27] language: 'British English' }, [17:55:30] cscott: Oh. Dear. [17:56:32] so switching to protocol-agnostic urls has to be done on a case-by-case basis for every interwiki? [17:57:03] i'm not sure parsoid's InterWikiMatcher actually matches http://foo if the url pattern is //foo -- i can fix that [17:57:05] cscott: Also I might add that there is no such thing as en-gb.wikipedia.org [17:57:17] Did Parsoid build their interwiki map on the assumption that every single language code has a Wikipedia? [17:57:20] RoanKattouw: i was similarly surprised to find it in the list of interwiki links [17:57:41] * James_F sighs. [17:57:45] Yay breakage. [17:58:09] RoanKattouw: let me double-check to see if parsoid is playing games. we should be getting this directly from an API request [17:58:21] (03CR) 10Esanders: demos: Add sample dialog with GridLayout (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 (owner: 10Krinkle) [17:58:27] Because I've seen some earlier versions of how Parsoid deals with these interwikis (including an Enormous Regex Of Doom) and they all seemed spectacularly misinformed about how this stuff actually works [17:58:50] As in either having things that don't exist, or missing important things, or not being flexible enough to deal with inevitable additions [17:59:12] i think the latter, and not the middle, but certainly the former as well. ;) [17:59:24] wait, i meant "not the latter" [17:59:33] (03Abandoned) 10Catrope: demos: Add sample dialog with GridLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 (owner: 10Krinkle) [17:59:43] also ++Giant RegExp of Doom, but gitblame marktraceur ;) [18:00:49] What did I do [18:01:41] actually i think you just added jsduck comments, bad marktraceur [18:01:56] the original giant regexp of doom was written by 'plancalculus'? dunno who that is/was. [18:02:31] How daaaare I [18:02:42] cscott: They're around the repos in various capacities [18:02:57] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c28 (10ryasmeen) I am still getting that error : when I try to open Media Settings Dialog, Template and Media Settings. [18:02:59] (03CR) 10Krinkle: "Hm.. weird, that wasn't supposed to be squashed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134106 (owner: 10Krinkle) [18:03:45] RoanKattouw: http://git.wikimedia.org/blob/mediawiki%2Fservices%2Fparsoid.git/3ac048d7c4b8917ec1b7768e1ba820ff102dcd3a/lib%2Fmediawiki.WikiConfig.js#L139 [18:04:07] "Add in wikipedia languages too -- they are not necessarily registered as interwikis and are expected by parserTests" [18:04:07] RoanKattouw, have you registered to vote? [18:04:13] RoanKattouw: Did that OO change with squashing cover Ed's comments? [18:04:31] the latter part of that comment is not true [18:04:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: Lock sign appearing over the Edit option on Mobile VE even if user has Beta and Experimental Mode on - 10https://bugzilla.wikimedia.org/65414#c1 (10Jon) Works for me.. https://en.m.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox?mobileaction=alpha [18:04:52] that is, parserTests sets up its own interwiki info, which should not be reflected in non-parserTests config code [18:05:27] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c29 (10ryasmeen) Also, when I try to open Language inspector. [18:05:48] don't go bad-mouthing parser tests, anonymous comment-writer. [18:05:54] * cscott <3s parsertests [18:05:56] 3VisualEditor / 3Mobile: VisualEditor Mobile: VE is not appearing as an option to edit even if Beta-Experimental mode is on in iPhone 4S - 10https://bugzilla.wikimedia.org/65415#c1 (10Jon) VisualEditor is only loaded when you are on a screen with a resolution of 768px width / height. Thus this will currently... [18:06:11] it's an ugly baby, but i loves it [18:10:56] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c30 (10Krinkle) It has not been backported to production yet (will happen soon). The automatic deploy to beta.wmflabs.org ran 2 minute after your comment was sub... [18:11:01] edsanders: Yeah and they've sent me my ballot ages ago (via e-mail), but not the envelope to send it back in yet (via snail mail) [18:13:42] Maybe Canada could troll the UK by voting for UKIP or the BNP en masse [18:14:02] (03CR) 10Catrope: [C: 04-1] "You're actually messing with shields, not phantoms, which is why you're getting test failures." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [18:15:02] I can only vote for Dutch parties though [18:15:12] So I can't vote for anyone as racist as UKIP or BNP [18:15:19] Except Wilders [18:15:24] I can vote for JESUS LIVES though [18:15:26] RoanKattouw: I was going to say. [18:16:10] I guess UKIP might be affiliated with the Anti EU(ro) Party [18:16:39] RoanKattouw, as a Canadian you can vote in "UK parliamentary general elections, local government elections, European elections, Police and Crime Commissioner elections" [18:16:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editor is unavailable, edit menu item can re-appear - 10https://bugzilla.wikimedia.org/65292 (10James Forrester) 5PAT>3RES/FIX a:5Krinkle>3Alex Monk [18:16:53] which is exactly the same list of things that I can vote in [18:17:12] 3VisualEditor / 3ContentEditable: VisualEditor: Automatically place cursor in edit summary field - 10https://bugzilla.wikimedia.org/65222 (10James Forrester) 5PAT>3RES/FIX [18:18:39] https://www.gov.uk/what-elections-you-can-vote-in [18:18:57] haha [18:19:05] I doubt I'd be able to vote in the EU elections twice though [18:19:18] Also you probably have to be a Canadian citizen resident in the UK to vote in the EU elections, right? [18:19:37] (03PS2) 10Esanders: Phantom optimisations, episode II [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 [18:19:57] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c31 (10ryasmeen) Yes, the dialogs are working opening for me now, but I still get this error when I click on Insert Template on Template dialog. [18:20:13] RoanKattouw: Yeah, it's mis-written. [18:21:19] Hmm, it sounds like they mailed this stuff out a while ago and forgot about me [18:21:33] And the deadline for requesting a new one has passed as well [18:21:33] :-( [18:21:34] (03PS1) 10Cmcmahon: [browser test] use css for Template selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134148 [18:21:39] So unless it magically shows up in my mailbox in the next few days, I'll be disenfranchised [18:21:50] RoanKattouw: Bug report filed. [18:22:22] (03CR) 10Jforrester: [C: 032] Update beta warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) (owner: 10Alex Monk) [18:22:36] (03CR) 10Jforrester: [C: 032] Update wikitext-warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) (owner: 10Alex Monk) [18:22:58] (03CR) 10Cmcmahon: [C: 032] "tested on beta labs with FF and Chrome" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134148 (owner: 10Cmcmahon) [18:23:22] Krinkle: So Rummana found a new way to get the NS_ERROR thing [18:23:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: Beta warning should say that you can switch to wikitext without unsaved changes being lost - 10https://bugzilla.wikimedia.org/57699 (10James Forrester) 5PAT>3RES/FIX [18:23:27] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning needs to be updated to refer to switching to wikitext editor without losing unsaved changes - 10https://bugzilla.wikimedia.org/57700 (10James Forrester) 5PAT>3RES/FIX [18:23:31] Apparently the template dialog does something weird on *teardown* [18:23:40] RoanKattouw: Ha. [18:24:05] If you do Insert -> Template and use the dialog to insert the template, then when you apply changes, you get an inserted template, an error in your console, and you can't open the template dialog again [18:24:22] (03Merged) 10jenkins-bot: Update beta warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133639 (https://bugzilla.wikimedia.org/57699) (owner: 10Alex Monk) [18:24:54] (03Merged) 10jenkins-bot: Update wikitext-warning to refer to 'Switch to source editing' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133637 (https://bugzilla.wikimedia.org/57700) (owner: 10Alex Monk) [18:25:10] (03Merged) 10jenkins-bot: [browser test] use css for Template selector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134148 (owner: 10Cmcmahon) [18:27:12] James_F: hallo [18:27:22] Could anybody take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=65483 some time? [18:27:43] RoanKattouw: Hm.. indeed, checking. [18:28:27] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c32 (10ryasmeen) Also, if you just close the Template insertion dialog without adding anything, it throws the error. [18:29:57] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c33 (10Krinkle) Confirmed. Closing the Template dialog triggers it as well. Looks like we found another hole that needs to be plugged. Trace: curCSS() load.ph... [18:30:37] Krinkle: Without looking it up, can you guess what the return value is of $.isEmptyObject( undefined ) ? [18:30:54] RoanKattouw: Hm.. no idea [18:31:03] aharoni: Moriel flagged it and I've confirmed it, but I need Firefox to not be completely broken before I can look into it [18:31:03] should be false [18:31:07] should [18:31:11] But it's true [18:31:15] It is [18:31:16] No [18:31:34] It is false [18:31:39] Ahm [18:31:43] Which version of jQuery are you using? [18:31:47] isPlainObject: function( obj ) { if ( !obj ... ) { return false [18:31:50] 1.11.1 naturally [18:32:01] Me too [18:32:05] And it returns true [18:32:05] Same in 1.8.3 [18:32:12] $.isEmptyObject(undefined) [18:32:13] true [18:32:14] Oh, isEmpty object [18:32:37] yeah, but its signature is Object [18:32:55] lol, but isPlainObject return false? [18:32:55] I'd say that is definable [18:32:55] defendable [18:33:04] So the things that isEmptyObject recognizes is not a subset of the things that isPlainObject recognizes? :O [18:33:18] non-plain object can be empty [18:33:31] Right, yeah I suppose so [18:33:44] RoanKattouw: Firefox, broken? [18:34:01] any object instance without own enumerable properties (e.g. new String, new Array, new ve.Foo) [18:34:16] aharoni: All dialogs were completely broken in Firefox until like half an hour ago [18:34:26] RoanKattouw: I agree though, usually isEmptyObject is used as a type check not just to assert what is already knkown to be an object to be empty [18:34:27] Mostly fixed but there are lingering issues [18:34:38] same for isPlainObject [18:34:54] ok thanks [18:34:59] RoanKattouw: looking into the template dialog teardown now, or are you? [18:35:12] looks like its the same thing again, GridLayout/BookletLayout calling getDir [18:35:17] just like on initialize [18:35:33] Krinkle: I'm not, I'm reviewing Moriel's code (hence the isEmptyObject thing) so go for it [18:35:39] OK [18:35:54] Also, I feel like DOM manipulation in teardown should probably be safe [18:35:57] It's not happening on the simple dialog with grid layout in the demos though when closing that one, so we must be doing something else [18:36:15] Or be made to be safe the way we did with initialize [18:36:15] Yeah, but not style computation. It's the reverse of initialize [18:36:19] Right [18:36:21] No, it's not [18:36:24] It's the reverse of setup [18:36:25] We hide it first, including transition [18:36:34] Right [18:36:41] we don't want the dom to change during the transition, this is post-hide [18:36:44] I mean really DOM manip in teardown is ugly [18:36:50] yeah [18:36:55] I have no idea why it would need getDir [18:36:57] You should be doing that during the next setup call [18:37:00] looks like it's late to the party [18:37:13] or early, yeah, depending on what its for [18:37:15] Apart from maybe removing stuff from the DOM [18:37:22] next initialize I assume? Or is setup the one that happens on each open? [18:37:28] setup [18:38:33] (03CR) 10Catrope: [C: 04-1] Image model and the media edit dialog (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:39:03] RoanKattouw: So windows have close and teardown. [18:39:03] (03CR) 10Catrope: Image model and the media edit dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:39:14] RoanKattouw, did you see my comments on the previous patchset? [18:39:16] RoanKattouw: close is like initialize, it is hiding during that method somewhere [18:39:28] (03CR) 10Catrope: Image model and the media edit dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:39:33] RoanKattouw: teardown is explicitly called in the base close() method of Window after $element.hide() [18:40:01] So I guess we should just move anything that needs styles and visible stuff to be moved to in .close() and do it before caling the parent? [18:40:06] (like we do elsewhere already) [18:40:11] or do you want to move it entirely? [18:41:00] basically either move https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js#L335 from teardown() to close() [18:41:02] mooeypoo: Yes, I did [18:41:07] or move teardown() itself in https://github.com/wikimedia/oojs-ui/blob/master/src/Window.js#L387 [18:41:09] I responded to those too [18:41:11] Krinkle: I would like for teardown() not to need visible stuff or style computation [18:41:32] Most rearranging of the DOM should happen in the next setup() [18:41:36] With the exception of removing garbage [18:41:36] Cool, I like that. So we need to fix bad usage of teardown() [18:41:51] In the case of the template dialog you probably do want to remove things related to the previous template in teardown [18:41:59] Because there might be 60 parameters or whatever [18:42:17] But that's just removing things, that should be possible without getDir() and other style computation stuff, you'd think [18:42:22] RoanKattouw: "Even Timo didn't know that ;)" needs to become a t-shirt slogan. ;-) [18:42:29] It's not doing any of that though [18:42:33] it just does setMode(single) [18:42:35] (03PS3) 10Esanders: Phantom optimisations, episode II [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 [18:42:48] Krinkle: Hmm, why is setMode( 'single' ) in both setup and teardown? [18:42:52] Exactly [18:42:55] Is this an animation thing maybe? [18:43:01] Let me git blame the teardown version of ti [18:43:45] The commit that introduced it is a huge "merge these two dialogs into one" commit so that doesn't help us understand it [18:44:13] Krinkle: What happens if you just remove the setMode() call from teardown? Does that cause it to animate while opening if you inspect a simple template and then a complex one? [18:44:41] (03PS1) 10Krinkle: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134156 (https://bugzilla.wikimedia.org/65373) [18:44:55] testing now [18:45:37] RoanKattouw: nope, works fine [18:46:00] testing the opposite now [18:46:15] I suspect it might be changing to single mode from advanced mode just before it fades out on master [18:46:43] nah, it's not doing that (because teardown is after the animiation) [18:46:49] so were good [18:47:10] No, I think it's trying to prevent a weird effect on the next open [18:47:22] If you open it in advanced mode, close it, then open it in simple mode [18:47:32] It might try to animate from advanced to simple while opening [18:49:28] (03CR) 10Mooeypoo: Image model and the media edit dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:49:30] RoanKattouw: Well, that's an existing problem. For example, when you open it for the first time on any page, it visibly transitions its size from neither simple or advanced to simple (the default is somewhere in between!?) [18:50:03] and from what I can tell, it does not remember the advanced size enough that it transisions on the next open to a simple dialog. It just opens correctly [18:50:55] OK [18:51:06] ve-ui-mwTemplateDialog-ready helps with this [18:51:15] css transision property is not applied while busy [18:51:16] (03CR) 10Catrope: [C: 032] MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134156 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [18:51:16] e.g. during load [18:51:46] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css#L43-L48 [18:52:13] (03CR) 10Catrope: Image model and the media edit dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:52:51] (03Merged) 10jenkins-bot: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134156 (https://bugzilla.wikimedia.org/65373) (owner: 10Krinkle) [18:53:36] RoanKattouw, hm, on top of the 'getSelectedNode' thing , shouln't I select the newly inserted node for the user? [18:53:37] (03PS1) 10Catrope: Document that SurfaceFragment#getSelectedNode doesn't require selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134158 [18:53:55] mooeypoo: Yes, you probably should [18:54:14] (03PS1) 10Jforrester: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) [18:54:15] I could do it either before or after inserting the caption, either way it shouldn't affect the selection anyways [18:54:21] Yeah that seems fine [18:54:24] * mooeypoo nods [18:54:32] but good on changing the docs, I thought 'selected' means actually selected [18:55:14] However, that means that the selection needs to then be updated for the other changes, which means you need an autoselecting fragment [18:55:32] I'd rather the selection only be changed once, at the end [18:56:30] (03CR) 10jenkins-bot: [V: 04-1] MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) (owner: 10Jforrester) [18:59:12] RoanKattouw: Why do https://gerrit.wikimedia.org/r/#/c/133864/ and https://gerrit.wikimedia.org/r/134159 cherry-picks both V-1? [18:59:32] Because Jenkins is broken for wmf branches [18:59:49] Helpful. [18:59:57] Hmm no they fixed that? [19:04:41] RoanKattouw, so why do we have shields if phantoms are created on mouse over? [19:04:48] Selection [19:05:00] But yeah a lot of this stuff is duplicative [19:12:46] RoanKattouw: Hm.. qunit is failing on the converter test (see full log on that link) [19:12:55] that's the failure we got when we first upgraded jquery [19:13:02] It's also failing some completeness thing isn't it? [19:13:08] Weird [19:13:10] What is the failure? [19:13:32] * RoanKattouw ctrl+f's [19:13:43] 23:24:50 >> TypeError: 'undefined' is not a function (evaluating 'context.createElement(parsed[1])') [19:14:12] Hmm that suggests we expect context to be an HTMLDocument but it isn't one/ [19:14:15] Oh, I see [19:14:22] You fixed that, but we never cherry-picked the fix [19:14:23] That explains [19:14:54] James_F|Away: V-1 diagnosis: jQuery upgrade uncovered a bug, Timo fixed it, but fix wasn't cherry-picked [19:15:05] bug in the tests that it [19:15:11] *is [19:15:12] RoanKattouw: completness thing? [19:15:27] Never mind, I misread [19:15:49] Fix: https://gerrit.wikimedia.org/r/#/c/133494/ [19:19:31] (03PS1) 10Krinkle: Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134162 [19:19:57] created wmf/1.24wmf5 branch at 19be0c1 (lib/ve of mediawiki/extensions/VisualEditor@ wmf/1.24wmf5) [19:20:17] (03CR) 10Krinkle: [C: 032] Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134162 (owner: 10Krinkle) [19:21:43] (03Merged) 10jenkins-bot: Pass HTMLDocument to convertToData [VisualEditor/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134162 (owner: 10Krinkle) [19:22:30] (03PS1) 10Krinkle: Update VE core submodule to wmf/1.24wmf5 (3ea2629) [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134163 [19:23:30] RoanKattouw_away: James_F|Away: ^ merge and rebase [19:41:22] (03CR) 10Krinkle: [C: 032] "This was previously effectively whitelisted already since Opera 15+ identifies itself with Chromium/Chrome version numbers as well. Until " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133110 (owner: 10Bartosz Dziewoński) [19:43:00] (03Merged) 10jenkins-bot: Whitelist Opera 15+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133110 (owner: 10Bartosz Dziewoński) [20:10:43] (03PS4) 10Krinkle: Add 'date' type support for ISO 8601 date-times [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132449 (owner: 10Jforrester) [20:10:57] (03PS5) 10Krinkle: Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [20:14:13] (03CR) 10Krinkle: [C: 04-1] Add 'boolean' type support (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [20:28:55] Krinkle: If I need to modify ooui, where should I actually push the changes? core, VE, some other repository? [20:29:04] kaldari: oojs/ui.git [20:29:47] RoanKattouw: thanks [20:30:27] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c37 (10ryasmeen) All dialogs are now opening and closing without any error in Betalabs. [20:41:14] (03PS1) 10Kaldari: Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 [20:42:22] mooeypoo: I left some more comments on the image model change a few hours ago; are you around to deal with those? [20:42:34] The change is really close to being able to be merged, it would be nice if we could merge it today [20:42:35] (03PS2) 10Kaldari: Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 [20:45:59] (03PS1) 10Catrope: Make flags on buttons in confirmation dialog configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 [20:46:33] (03PS1) 10Kaldari: Adding header to top of citation pop-up list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 [20:47:11] (03PS2) 10Kaldari: Adding header to top of citation pop-up list in mobile view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 [20:47:27] (03PS1) 10Catrope: Set flags for confirm dialog buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 [20:47:41] (03CR) 10Catrope: "Soft-depends on https://gerrit.wikimedia.org/r/134239" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 (owner: 10Catrope) [20:48:08] (03CR) 10Catrope: [C: 032] Use OOUI confirmation dialog rather than native confirm() for switching to source editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133896 (owner: 10Alex Monk) [20:50:32] (03Merged) 10jenkins-bot: Use OOUI confirmation dialog rather than native confirm() for switching to source editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133896 (owner: 10Alex Monk) [20:50:34] (03PS1) 10Catrope: Set flags for confirm dialog buttons for switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134243 [20:51:22] (03CR) 10Catrope: "Soft-depends on https://gerrit.wikimedia.org/r/134239. Split off from https://gerrit.wikimedia.org/r/134241 so that one can be cherry-pick" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134243 (owner: 10Catrope) [20:51:59] Krinkle: Can I get some CR for stuff that needs to go out today? https://gerrit.wikimedia.org/r/134239 & https://gerrit.wikimedia.org/r/134241 [20:52:57] (03PS2) 10Jforrester: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) [20:53:11] (03PS2) 10Jforrester: Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) [20:54:37] (03CR) 10jenkins-bot: [V: 04-1] MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) (owner: 10Jforrester) [20:54:48] (03CR) 10jenkins-bot: [V: 04-1] Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) (owner: 10Jforrester) [20:55:09] (03CR) 10Krinkle: [C: 04-1] "Two questions:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [20:55:19] (03CR) 10Krinkle: [C: 031] Set flags for confirm dialog buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 (owner: 10Catrope) [20:55:42] (03CR) 10Krinkle: "Soft-depends on https://gerrit.wikimedia.org/r/134239 in oojs-ui." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 (owner: 10Catrope) [20:56:12] James_F: Merge https://gerrit.wikimedia.org/r/#/c/134163/ and rebase [20:56:42] [21:19] Krinkle: created wmf/1.24wmf5 branch at 19be0c1 (lib/ve of mediawiki/extensions/VisualEditor@ wmf/1.24wmf5) [20:56:48] [21:23] Krinkle: RoanKattouw_away: James_F|Away: ^ merge and rebase [20:57:26] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.24wmf5 (3ea2629) [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134163 (owner: 10Krinkle) [20:57:28] Krinkle: Yeah, RoanKattouw just said he would. [20:57:32] Timing. :-) [20:58:59] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.24wmf5 (3ea2629) [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134163 (owner: 10Krinkle) [20:59:30] (03CR) 10Catrope: "Re #1: yes, they're being cleared to wipe out the previous setup()'s flags." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [20:59:56] (03PS2) 10Catrope: Make flags on buttons in confirmation dialog configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 [21:00:08] Krinkle: Addressed CR [21:01:47] RoanKattouw: Hm.. one more thing, can you add default values to @param doc? [21:01:59] Sure [21:02:02] (03CR) 10Kaldari: [C: 04-1] "-1 until dependency is merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [21:02:05] Note they are also missing in existing code [21:02:22] And all the defaults are very nasty [21:02:25] (messages, arrays) [21:02:32] So I'm inclined to not put them there [21:02:53] [data.okFlags="constructive"] seems useful though [21:03:06] What about data.okLabel though? [21:03:11] The default is a message [21:03:32] and 'object' is lowercase [21:03:43] and it documentes 'null' as an expected type (why?) [21:03:47] I agree [21:03:54] (03CR) 10Krinkle: [C: 032] Make flags on buttons in confirmation dialog configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [21:04:21] (03Merged) 10jenkins-bot: Make flags on buttons in confirmation dialog configurable [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [21:06:44] Krinkle: Thanks. Could you do https://gerrit.wikimedia.org/r/#/c/134241/ too?/ [21:07:00] Then I'll go do pull-throughs [21:08:44] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134248 [21:11:11] (03CR) 10Krinkle: [C: 032] Set flags for confirm dialog buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 (owner: 10Catrope) [21:11:34] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134248 (owner: 10Catrope) [21:13:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0fbf6bd14e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134248 (owner: 10Catrope) [21:14:32] (03Merged) 10jenkins-bot: Set flags for confirm dialog buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134241 (owner: 10Catrope) [21:20:42] (03PS1) 10Catrope: Set flags for confirm dialog buttons [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134253 [21:20:55] (03PS3) 10Catrope: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) (owner: 10Jforrester) [21:20:57] (03PS3) 10Catrope: Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) (owner: 10Jforrester) [21:21:55] it's probably my fault [21:27:00] edsanders: Hmm, have you noticed that when you press right arrow while a focusablenode is selected, the page scrolls to the top? [21:27:56] Funny, Inez is looking at this stuff right now. [21:28:24] We're working on running a test without slugs, so we're looking closely at keyboard selection interaction. [21:28:30] hah [21:28:43] Ed was working on a patch that does shields on mouse over [21:28:58] isn't that just ProtectedNode? [21:29:20] Yeah [21:29:36] So I was testing keyboard selection, because that's how you can select things without causing mouse events [21:29:38] (03PS1) 10Krinkle: test: Drop 'OO.ui' file prefix in test suites [oojs/ui] - 10https://gerrit.wikimedia.org/r/134255 [21:29:39] Then I noticed this [21:29:40] (03PS1) 10Krinkle: Support strings in FlaggableElement#setFlags [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 [21:30:00] (03PS1) 10Krinkle: ConfirmationDialog: Clean up setup() documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/134257 [21:30:45] the shields, iirc, are generated for nodes on init and they are used for natural highlighting when selecting across. Then, ProtectedNode generates phantoms that mirror the shields on mouseover. [21:30:51] Yeah [21:31:05] So Ed removed the generation of shields on init, instead only generating them on mouseover [21:31:08] (03CR) 10Krinkle: Make flags on buttons in confirmation dialog configurable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [21:31:15] I'm testing his commit to see if that breaks selection highlighting [21:31:41] yeah, test placing the cursor in some text before the node and drag to select into some text after the node [21:31:51] without shields in the node, i bet the highlight isn't correct [21:32:14] You're right, the highlight is wrong [21:32:42] I can tell because we override the highlight color and Chrome doesn't respect that in all cases [21:34:12] It would be cool to disable native selection on protected nodes all the time, ditch the shields, and generate a correct highlight when the element is selected (or part of an expanded selection) [21:34:38] Inez and I talk about it semi-frequently. [21:36:12] 3VisualEditor / 3Editing Tools: VisualEditor: Instrument all actions in visual editing toolbar for organization and frequency of use analysis and improvements - 10https://bugzilla.wikimedia.org/65510 (10Jared Zimmerman (WMF)) [21:38:00] Yeah that sounds good [21:38:12] Ed said we don't need shields for selection correctness really, except in IE9 [21:39:53] (03CR) 10Catrope: [C: 04-1] "This makes selection behave strangely if you manage to select something without triggering mouseover (e.g. using the keyboard). This is es" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [21:41:30] (03CR) 10Catrope: Phantom optimisations, episode II (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [21:42:43] (03CR) 10Catrope: [C: 032] MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) (owner: 10Jforrester) [21:42:48] (03CR) 10Catrope: [C: 032] Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) (owner: 10Jforrester) [21:43:04] (03CR) 10Catrope: [C: 032] Set flags for confirm dialog buttons [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134253 (owner: 10Catrope) [21:44:24] (03Merged) 10jenkins-bot: MWTransclusionDialog: Remove setMode() call from teardown() [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134159 (https://bugzilla.wikimedia.org/65373) (owner: 10Jforrester) [21:44:28] (03Merged) 10jenkins-bot: Hide 'no results found' once there's at least one result [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/133864 (https://bugzilla.wikimedia.org/52463) (owner: 10Jforrester) [21:45:24] (03Merged) 10jenkins-bot: Set flags for confirm dialog buttons [extensions/VisualEditor] (wmf/1.24wmf5) - 10https://gerrit.wikimedia.org/r/134253 (owner: 10Catrope) [21:47:30] I'd be very surprised, but stoked to hear that shields aren't necessary. :) [21:48:38] Yeah [21:49:00] Ed has been doing some nice performance optimizations in the shields/phantoms area [21:55:02] (03CR) 10Krinkle: [C: 032] Set flags for confirm dialog buttons for switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134243 (owner: 10Catrope) [21:56:39] (03Merged) 10jenkins-bot: Set flags for confirm dialog buttons for switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134243 (owner: 10Catrope) [21:57:18] (03CR) 10Catrope: [C: 032] test: Drop 'OO.ui' file prefix in test suites [oojs/ui] - 10https://gerrit.wikimedia.org/r/134255 (owner: 10Krinkle) [21:57:44] (03Merged) 10jenkins-bot: test: Drop 'OO.ui' file prefix in test suites [oojs/ui] - 10https://gerrit.wikimedia.org/r/134255 (owner: 10Krinkle) [21:57:57] (03CR) 10Catrope: [C: 04-1] Support strings in FlaggableElement#setFlags (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [21:59:20] (03CR) 10Catrope: Support strings in FlaggableElement#setFlags (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [21:59:29] (03CR) 10Krinkle: Support strings in FlaggableElement#setFlags (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [22:00:26] (03CR) 10Catrope: Support strings in FlaggableElement#setFlags (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [22:00:54] (03CR) 10Catrope: [C: 032] ConfirmationDialog: Clean up setup() documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/134257 (owner: 10Krinkle) [22:02:23] (03PS2) 10Krinkle: Support strings in FlaggableElement#setFlags [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 [22:03:22] (03CR) 10Krinkle: Support strings in FlaggableElement#setFlags (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [22:03:22] (03PS2) 10Krinkle: ConfirmationDialog: Clean up setup() documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/134257 [22:05:56] (03CR) 10Catrope: [C: 04-1] Add ability to put a header at the top of a toolGroup pop-up (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:06:11] (03CR) 10Krinkle: Add ability to put a header at the top of a toolGroup pop-up (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:06:35] 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463#c12 (10ryasmeen) Verified the fix in Betalabs [22:07:04] TrevorP|Away: Any thoughts on this: https://gerrit.wikimedia.org/r/#/c/134237/2/src/toolgroups/PopupToolGroup.js [22:07:21] (03CR) 10Catrope: Add ability to put a header at the top of a toolGroup pop-up (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:07:24] RoanKattouw: Is Trevor around today? Haven't seen him on IRC. [22:07:37] kaldari: He's on vacation this whole week :S [22:07:42] ack [22:07:49] The thing is this is kind of tricky [22:08:01] So, $group is provided by GroupElement, which manages it in terms of indexing and stuff [22:08:37] Common usage won't break but if someone's trying to do something index-based with a toolgroup, your span will cause them to be off by one [22:08:53] So ideally, your span would be a sibling to $group [22:09:00] But that means it needs to live higher up, in ToolGroup [22:09:49] Which is reasonable, I suppose, but 1) it requires a bit of restructuring in ToolGroup (not too scary though) and 2) I don't have a good name for this container off the top of my head [22:10:06] $randomShitThatIsNotToolsButShouldAppearInTheToolsArea [22:13:35] (03CR) 10Catrope: [C: 032] Support strings in FlaggableElement#setFlags [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [22:14:01] (03PS12) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [22:14:03] (03Merged) 10jenkins-bot: Support strings in FlaggableElement#setFlags [oojs/ui] - 10https://gerrit.wikimedia.org/r/134256 (owner: 10Krinkle) [22:14:05] (03Merged) 10jenkins-bot: ConfirmationDialog: Clean up setup() documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/134257 (owner: 10Krinkle) [22:14:47] (03PS13) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [22:29:49] (03CR) 10Jforrester: Make flags on buttons in confirmation dialog configurable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [22:34:56] https://gerrit.wikimedia.org/r/#/c/134252/1..2//COMMIT_MSG [22:46:35] (03CR) 10Krinkle: Make flags on buttons in confirmation dialog configurable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [22:48:55] (03CR) 10Krinkle: [C: 031] "A noble effort. Though at the moment I don't know of many templates that use this particular date format (commons:Template:Information is " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132449 (owner: 10Jforrester) [22:55:27] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes (0315 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [23:00:18] (03CR) 10Jforrester: "@Timo: It's occasional practice to use ISO-standard dates for tables (so they're sortable) and some users populate citation templates' fie" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132449 (owner: 10Jforrester) [23:01:18] (03CR) 10Catrope: "Timo: What you wrote is what we started with, but Trevor and I agreed that that was way too much boilerplate code and is far from simple o" [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [23:01:33] (03CR) 10Krinkle: "I think usage as-is is fairly common (especially in hidden values like table sort), but interpretation inside a template parameter is not " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132449 (owner: 10Jforrester) [23:01:55] (03CR) 10Jforrester: Add 'boolean' type support (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [23:02:43] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Go to Insert>Language 3.Now click on "Find Lan... [23:02:58] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10ryasmeen) a:3Ed Sanders [23:04:43] Krinkle: https://en.wikipedia.org/wiki/Module:Parsedate takes a date (in several formats) and returns the human-format version of it, with the ISO format as well in a micro-format hint. [23:04:49] Krinkle: That good enough an example? [23:05:42] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c1 (10ryasmeen) In Firefox, it is comparatively faster than Chrome [23:05:57] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10ryasmeen) 5NEW>3ASS [23:07:11] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c39 (10James Forrester) 5PAT>3RES/FIX Marking this as "FIXED". [23:14:29] 3VisualEditor / 3Data Model: VisualEditor: Link inspector dirties links, causes dirty diffs for links with underscores - 10https://bugzilla.wikimedia.org/62229#c1 (10James Forrester) Is there anything for VE to do here or will it Just Work™ once Parsoid updates the production service? [23:15:40] (03CR) 10Jforrester: Make flags on buttons in confirmation dialog configurable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134239 (owner: 10Catrope) [23:22:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editor is unavailable, edit menu item can re-appear - 10https://bugzilla.wikimedia.org/65292 (10James Forrester) [23:47:42] 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373#c40 (10ryasmeen) Verified the backported fix in test2