[00:01:02] (03CR) 10Kaldari: Add ability to put a header at the top of a toolGroup pop-up (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [00:19:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: The "Review your changes" button should be disabled when save dialog is busy - 10https://bugzilla.wikimedia.org/65310 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [00:23:12] (03PS3) 10Kaldari: Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 [00:26:13] 3VisualEditor / 3Technical Debt: VisualEditor: Disentangle MWSaveDialog and ViewPageTarget - 10https://bugzilla.wikimedia.org/65513 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Right now, the way that the save button is disabled when you click it is that MWSaveDialog listens to the button's clic... [00:28:43] 3VisualEditor / 3Technical Debt: VisualEditor: Disentangle MWSaveDialog and ViewPageTarget - 10https://bugzilla.wikimedia.org/65513#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3enhanc a:3Alex Monk This'd be lovely to get fixed properly. Alex, could you take a look at this at so... [00:29:39] (03PS41) 10Mooeypoo: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [00:30:20] RoanKattouw, sorry, I was out for a couple of hours (sorting out some papers issues) -- but I'm nto sure it's a good idea to merge before we have time to test thoroughly? [00:31:10] mooeypoo: The way we get thorough testing is to merge it with a belief that it works, and let ryasmeen_ tell us how we're hopelessly wrong. :-) [00:31:17] (03CR) 10jenkins-bot: [V: 04-1] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [00:31:18] mooeypoo: If not now, when? ;-) [00:31:34] James_F, aye, but on Wednesday it will be in production, then, no? [00:31:36] is that enough time? [00:31:49] mooeypoo: I can haz length > 4 ? [00:31:57] Jenkins! No! Bad jenkins. It passed grunt, damnit [00:32:27] mooeypoo: Thursday. Two days' testing will be enough to revert or accept the number of bugs as OK collateral. :-) [00:32:52] RoanKattouw, it didn't work last I checked...? :\ [00:32:55] James_F, ok, fair enough. [00:33:03] length > 4 doesn't work? [00:33:11] getLength() > 4 didn't work [00:33:12] OK I can merge it without that and do a follow-up [00:33:15] is there a difference? [00:33:20] Yeah that's what I meant [00:33:23] I'm just a lazy typist [00:33:26] let me retest [00:33:48] (03PS3) 10Kaldari: Adding header to top of citation pop-up list in mobile view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 [00:34:34] there were so many other things that went wrong back then with the caption insertion, i may have tested it badly. I'm retesting [00:34:37] mooeypoo: Re Jenkins failures, [00:34:45] " Unknown type ve.mw.MWImageNode" --> should be ve.*dm*.MWImageNode [00:37:24] oh bah [00:37:37] sticky fingers [00:38:41] 3VisualEditor: VisualEditor: Special character inserter behaves oddly if you don't click somewhere in the page first - 10https://bugzilla.wikimedia.org/60507#c1 (10James Forrester) 5NEW>3RES/WOR This has now been "fixed" by the simple effort of making this route impossible; tools are now disabled if there... [00:40:13] 3VisualEditor / 3Editing Tools: VisualEditor: Character inserter does not inherit annotations of context (no pre-annotation), so breaks up links, isn't styled, etc. - 10https://bugzilla.wikimedia.org/60476 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3minor a:3Ed Sanders [00:40:41] 3VisualEditor: VisualEditor: Special character inserter breaks up links to other pages - 10https://bugzilla.wikimedia.org/65497#c1 (10James Forrester) 5NEW>3RES/DUP Yeah, merging this with bug 60476 and expanding the description there. *** This bug has been marked as a duplicate of bug 60476 *** [00:40:42] 3VisualEditor / 3Editing Tools: VisualEditor: Character inserter does not inherit annotations of context (no pre-annotation), so breaks up links, isn't styled, etc. - 10https://bugzilla.wikimedia.org/60476#c1 (10James Forrester) *** Bug 65497 has been marked as a duplicate of this bug. *** [00:51:25] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/134049/ [00:55:26] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [00:56:12] 3VisualEditor / 3Editing Tools: VisualEditor: Template editor is missing accessibility features - 10https://bugzilla.wikimedia.org/65474 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [00:56:12] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) 5REO>3ASS [00:56:27] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473 (10James Forrester) [00:56:27] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) [01:01:57] mooeypoo: .... ? [01:02:08] my browser keeps crashing [01:02:14] getLength() is not a function [01:02:17] trying .length [01:02:18] mooeypoo: You OK with me just merging this thing as-is (or with fixes so Jenkins will swallow it) and doing the length thing later? [01:02:21] andmy browser crashed twice [01:02:21] Oh, ahm [01:02:22] sure [01:02:51] this.getCaptionDocument().data.getLength() [01:02:53] Because of course [01:04:25] ha [01:04:40] ok, we can merge as is and change it [01:04:48] but i'm testing (my damn computer is acting up) [01:04:49] Yeah I'll do that [01:04:59] Need to placate Jenkins first though, working on that now [01:06:04] I changed locally but while testing. If you can do that, it'll save me time [01:06:07] i'm going to have to reboot [01:06:13] * mooeypoo shoots her laptop [01:06:45] We need to get you a new one of those [01:08:05] yeah I'm actually worried about wikimania [01:08:19] I have my PC at home, which is usually good to work on (ubuntu on it) [01:08:23] I'll talk to Terry [01:08:27] but the laptop is driving me crazy [01:11:22] ok i got it [01:11:28] .data.getLength() > 4 works [01:11:48] passing through grunt and sending to review [01:12:27] RoanKattouw, are you working on this already? I'm about to send to review... should I or did you already change it? [01:12:37] I'm still installing ruby [01:12:45] Did you fix the ve.mw --> ve.dm. things? [01:12:49] yep [01:12:52] (03PS42) 10Mooeypoo: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [01:13:05] Sweet [01:13:30] (03CR) 10Catrope: [C: 032] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [01:15:32] (03Merged) 10jenkins-bot: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [01:15:44] \o/ [01:16:30] ~o~ [01:17:22] Now... testing. [01:17:25] testing testing testing. [01:34:07] mooeypoo: While you're here and in an imagey state of mind: what is going on with dm.MWImageNode having an updateType() method? It seems like the wrong place for that kind of code to live, and I think there was a this.mediaType property in either that class or in MWImageModel that was set but never read [01:34:14] That bit still seems like a bit of a mess [01:35:27] RoanKattouw, I answered it in the review note, hang on [01:35:39] https://gerrit.wikimedia.org/r/#/c/120808/39/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js [01:35:54] Right, I remember having asked this question before but I couldn't find it [01:36:02] the idea is to make sure all calculations of default size and max/min confines re in the same place [01:36:14] that place is, logically, the place where we deal with the scalable -- which is the image [01:36:52] Right, so it updates the Scalable for the type change? [01:36:52] What I *do* need to do, I think, is add .updateType() to when the scalable API response is accepted, so it's updated as per the new details [01:36:59] it does [01:37:01] Right [01:37:03] and it also updates the initial ones [01:37:07] i need to change the name of that method, I think [01:37:17] Yeah, the name could be clearer [01:37:28] it's not quite updateType() .. it's more like "syncScalableToImage()" or something like that [01:37:36] and it should be called at the end of the api request [01:38:02] because the image may not have originaldimensions (and so, the wrong max/min limits, but then change that when the API is done) [01:39:38] RoanKattouw, also the this.mediaType is to differentiate between svg and png/jpg/etc [01:39:49] Yeah [01:40:05] I think one of the two classes (node or model) had it but didn't use it, or something [01:40:24] the calculation used to be in the model [01:40:55] Right, MWImageModel has a getter and setter for the property but otherwise doesn't use it at all [01:41:06] but then the calculation also needs to be in other places like insertion of a new image (Which I need to adjust a little after the new inline/block changes) [01:41:11] Oh I see the setter is actually used [01:41:14] So that's somewhat reasonable [01:41:15] so the reasonable place was to put it in the image itself [01:41:30] Right, OK [01:41:47] Wouldn't the insertion of a new image also be done through the ImageModel code? [01:41:50] media insert has some of that calculations in there, it shouldn't though [01:42:03] not at the moment, but I guess it could be? [01:42:18] Right [01:42:25] Yeah it should be [01:42:28] we could, eventually, (if I did things right) have the edit dialog allow for a switch of image [01:42:30] That's how ReferenceModel is used too [01:42:42] which means that insert and edit *could* be in the same dialog [01:43:02] you'll have a search media and then before insertion it'll let you edit whatever parameters before insertion [01:43:10] instead of just adding in a block image and then letting you edit. [01:43:15] Right [01:43:40] aye, that's the plan. I didn't want to overdo things in this huge commit, though [01:43:44] Sure [01:43:52] Yeah let's make inserting images using the model the next thing [01:43:54] want to make sure the model itself works properly, then we can change the insert dialog. [01:43:57] * mooeypoo nods [01:43:59] After the dust settles down on this one [01:44:41] * mooeypoo nods [01:44:43] sounds good [05:58:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as read - 10https://bugzilla.wikimedia.org/65517 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None It's possible to have a category bubble in the category editor for a category that doesn't have a... [06:00:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Category names cannot be edited - 10https://bugzilla.wikimedia.org/65518 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Clicking the down arrow on a category name allows deleting it and changing its sort name. It would also be useful to be a... [10:38:31] (03CR) 10Esanders: Phantom optimisations, episode II (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [11:07:18] (03PS2) 10JGonera: Add check icon for Apply button in ActionDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132353 [11:09:49] (03CR) 10JGonera: "I know. Who should make a call on this? If this is undesired, then how would we hide the icon in current desktop theme (apex)? Just by hid" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132353 (owner: 10JGonera) [11:10:00] (03CR) 10Esanders: "The huge amounts of orange in your screenshot are caused by a browser bug where it doesn't like blocks inside of inlines. Currently we are" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [11:23:05] (03PS4) 10JGonera: Hide unsupported UI elements in references on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132355 [11:23:24] (03PS4) 10Esanders: Phantom optimisations, episode II [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 [11:23:54] 3VisualEditor / 3Editing Tools: VisualEditor: Category editor should also suggest categories which 'exist' but are without a description page - 10https://bugzilla.wikimedia.org/49044 (10Alex Monk) [11:23:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as read - 10https://bugzilla.wikimedia.org/65517 (10Alex Monk) [11:24:19] (03CR) 10Esanders: "Added in shielding on dragover, and made mozilla transparent selection CSS on apply after shielding. Should reduce the edge cases where we" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134069 (owner: 10Esanders) [11:25:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as red - 10https://bugzilla.wikimedia.org/65517 (10Amir E. Aharoni) [11:29:27] (03CR) 10JGonera: "I want to load them mutually exclusively, but wasn't sure about the directory structure for this, so thanks for the input. Is it OK now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132355 (owner: 10JGonera) [11:33:28] (03PS2) 10JGonera: Add more Agora dialogs styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/132352 [11:33:45] (03CR) 10Alex Monk: "I think I had an idea which involved other extensions registering their extra meta item stuff on the server side and then sending it to th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [12:02:24] (03PS1) 10Esanders: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 [12:24:00] AzSz88: Hi :) [12:28:01] Ok guys, probably a stupid question, but I should be returning wikitext to VE right? and then VE will pass it on to parsoid? [12:39:36] mvolz, I think I'm missing quite a lot of context... [12:39:52] Hey Krenair! [12:39:57] Congrats, btw :) [12:41:42] So basically the transclusion dialog is going to be making REST api requests to an node service that will return citations to it [12:42:00] But I have a pretty fuzzy (i.e. non existent) understanding of how parsoid and VE interact [12:43:26] I'm thinking actually the dialogue might want a different format like json come to think of it. [12:43:48] in fact I think Trevor mentioned that at one point. [12:44:01] Thanks Krenair ;) [12:48:31] I haven't looked into much of the details of how VE connects to parsoid [12:49:51] But you appear to be asking about how your code should interact with the VE dialog? [12:51:36] Yeah, it's not really important to get an answer right now. [12:51:42] just thinking ahead [14:16:09] mvolz, I think it would be good to think of this service as in independent data provider [14:16:51] VE knows how to construct transclusions from data [14:17:35] to it, transclusion parameters actually look like JSON attributes: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Transclusion_content [14:33:03] gwicke: ty [14:34:54] mvolz, we are working on a general public REST API that this can be one entry point of [14:35:36] the front-end will typically just dispatch to a back-end service, and provide a unified namespace [14:36:36] so if you build the back-end with a simple REST interface, we'll be able to hook it up as /v1/util/url2cite or the like [14:37:06] GET /v1/util/url2cite/http%3A%2F%2Ffoo.com%2Fbar [14:37:07] ok gotcha [14:37:16] as a sample request [14:47:16] (03PS1) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 [14:48:24] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (owner: 10Esanders) [14:50:43] (03PS1) 10Esanders: Use new FocusableNode system [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 [14:51:10] (03CR) 10Esanders: "MW fixed in Ie5157041" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (owner: 10Esanders) [14:52:31] (03CR) 10jenkins-bot: [V: 04-1] Use new FocusableNode system [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [14:53:50] (03CR) 10Esanders: "Fixed in Math extension in I7d5e1174." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders) [15:42:40] (03PS15) 10Jforrester: WIP: [BrowserTest] Step definition for long target link scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) (owner: 10Jagori79) [15:42:52] (03PS19) 10Jforrester: [WIP] [BrowserTest] Testing typing in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/83966 (https://bugzilla.wikimedia.org/54393) (owner: 10Amire80) [15:44:08] Krenair: How do you think https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default is, BTW? [15:46:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories without description pages don't show as red - 10https://bugzilla.wikimedia.org/65517 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3minor [15:47:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Category names cannot be edited - 10https://bugzilla.wikimedia.org/65518 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:5normal>3enhanc [15:47:45] James_F, hm. what is the criteria for a commit showing up on each of these sections? [15:48:00] Krenair: Click on the titles and you'll see the query string. [15:48:06] ew [15:48:32] Krenair: Suggestions welcome, and yeah, the queries suck a little, but note that we're limited to 10 (and the expressive power of gerrit configuration). [15:52:28] James_F, this is off-topic, but.. what's the status of VE compatibility with the translate extension? [15:53:10] Krenair: Needs possibly some major work (of the level of a total re-write) in the Translate extension, but no-one's sure. [15:53:18] Krenair: "Stalled" would be a polite way to put it. :-) [15:53:20] Krenair: Why? [15:53:26] Ok, so it's not ready to go to wikis which use Translate then? [15:53:59] What do you mean? It's been live on MediaWiki for years, and on Meta and Commons for a while. [15:54:07] Which wikis were you thinking of? [15:54:35] I was looking at the dashboard and saw the commit for enabling on OTRS wiki [15:54:59] Oh, that's just waiting for the OTRS admins to make a decision. They said they'd get back to me but still haven't. [15:55:06] The translation side of things is relatively minor. [15:55:53] James_F, okay. I've been doing some poking of people on the OTRS side [15:55:59] * James_F nods. [15:56:14] No great hurry, though. :-) [15:56:27] yeah. [15:59:00] James_F, what is "Other stuff"? [15:59:15] Krenair: Things that don't go into the other boxes but are of interest. [15:59:40] Krenair: So things in other repos, either by the team or mentioning VE, OOjs or OOjs UI. [15:59:52] Ah [16:00:00] I wondered why some of my unrelated core stuff was there [16:00:05] * James_F grins. [16:00:14] Yeah, and a bunch of Krinkle's stuff gets found there too. [16:01:38] James_F, so I had my Physics unit 1 exam today. Nothing tomorrow, something minor on thursday and nothing on friday. nothing next week. [16:01:50] That means I have some time to do wikimedia stuff [16:02:12] Krenair: Doesn't mean you shouldn't spend time revising. ;-) [16:02:17] yeah [16:02:51] But it's not the "oh **** my physics exam is tomorrow I can't remember any of this" panic [16:03:31] * James_F grins. [16:04:00] Which is what happened yesterday. (Kind of.) [16:04:04] :-( [16:04:27] Krenair: So… you could work on those two things you've been putting off for weeks! ;-) [16:04:29] * James_F grins. [16:04:39] So, yeah, I need to work out what I'm going to do. [16:05:37] Today in the hangout I will ask for thoughts on how we should do the MWSaveDialog/ViewPageTarget untangling [16:07:30] * James_F nods. [16:39:22] Krinkle, is Trevor on vacation? [16:39:28] or James_F [16:39:40] He'll be back next week I think [16:40:26] what about Roan? will he be online today? [16:44:25] (03CR) 10Krinkle: Add 'boolean' type support (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [16:45:40] jgonera: Trevor is, this entire week [16:45:44] on vacation [16:45:48] jgonera: I'm here, just in meetings. [17:23:26] Krinkle: https://en.wikipedia.org/wiki/Null_(SQL) is slightly unhelpful, but relevant. [17:24:42] https://en.wikipedia.org/wiki/Null_(SQL)#Null-specific_and_3VL-specific_comparison_predicates [17:28:00] Yeah, SQL's "NULL" is fundamentally wrong because it combines "set as no value" and "not set as a value" into one. [17:32:19] (03PS1) 10Krinkle: build: Enable jscs "requireSpacesInsideArrayBrackets" rule [oojs/ui] - 10https://gerrit.wikimedia.org/r/134393 [17:33:33] (03CR) 10Jforrester: [C: 032] build: Enable jscs "requireSpacesInsideArrayBrackets" rule [oojs/ui] - 10https://gerrit.wikimedia.org/r/134393 (owner: 10Krinkle) [17:34:00] (03Merged) 10jenkins-bot: build: Enable jscs "requireSpacesInsideArrayBrackets" rule [oojs/ui] - 10https://gerrit.wikimedia.org/r/134393 (owner: 10Krinkle) [17:50:26] 3VisualEditor / 3ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - 10https://bugzilla.wikimedia.org/48290#c7 (10Amir E. Aharoni) Indeed not WYSIWYG, but I happen to love this feature. I practically always remove these links when I see them. I'd say W... [17:51:11] aharoni: :-) [17:58:37] 3VisualEditor: VisualEditor: automatically convert URLs to readable links - 10https://bugzilla.wikimedia.org/65540 (10Amir E. Aharoni) 3NEW p:3Unprio s:3enhanc a:3None Quora has a lovely feature in its visual editor: paste a URL and it's immediately and automatically converted in a smart way. * If it'... [18:01:27] edsanders: Heya. [18:01:45] Hi [18:03:51] ok i'm running to get stuff from school. I'll be back shortly (hopefully, if there are no weird issues again) [18:03:52] bbiab [18:05:48] 3VisualEditor / 3Editing Tools: VisualEditor: automatically convert URLs to readable links - 10https://bugzilla.wikimedia.org/65540#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal Interesting idea. We've got some work planned to do this kind of thing for citations (you feed it a URL, it inserts a... [18:18:58] (03CR) 10Jforrester: Add 'boolean' type support (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:39:25] (03CR) 10Krinkle: Add 'boolean' type support (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:40:09] (03PS6) 10Krinkle: Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:40:28] (03CR) 10Krinkle: [C: 031] Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:40:39] (03CR) 10Jforrester: [C: 031] Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:42:33] (03CR) 10Krinkle: [C: 032] Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:43:30] (03Merged) 10jenkins-bot: Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [18:44:52] 3MediaWiki extensions / 3TemplateData: TemplateData: Add parameter type for boolean - 10https://bugzilla.wikimedia.org/55331#c4 (10James Forrester) 5PAT>3RES/FIX a:3James Forrester Done. [18:45:22] Woo. [18:48:31] Krinkle: https://gerrit.wikimedia.org/r/#/c/132449/ – did you see the Lua scripts I pointed to that took in ISO (and other) date formats? [18:49:05] James_F: Where? [18:49:15] Krinkle: In here yesterday when you asked. [18:49:23] James_F: Krinkle: https://en.wikipedia.org/wiki/Module:Parsedate takes a date (in several formats) and returns the human-format version of it, with the ISO format as well in a micro-format hint. [18:49:29] i see [18:50:17] Krinkle: But it's relatively minor, you're right. [18:51:23] James_F: That one doesn't seem to be used anywhere and doesn't have tests [18:53:19] https://en.wikipedia.org/wiki/Module:TimeAgo [18:55:40] Krinkle: Hmm, yeah, that one does too. [18:55:53] I'm not sure how it does it though [18:56:04] mw.language I think [18:56:13] https://github.com/wikimedia/mediawiki-extensions-Scribunto/blob/master/engines/LuaCommon/lualib/mw.language.lua [18:57:27] https://github.com/wikimedia/mediawiki-extensions-Scribunto/blob/master/engines/LuaCommon/LanguageLibrary.php [18:57:36] https://github.com/wikimedia/mediawiki-extensions-Scribunto/blob/master/engines/LuaCommon/LanguageLibrary.php#L239-L261 [18:57:37] Krinkle: Lovely. [18:58:02] $dateObject = new DateTime( $date, $utc ); [18:58:35] http://www.php.net/manual/en/datetime.construct.php [18:58:42] http://www.php.net/manual/en/datetime.formats.php [18:58:44] Right... [18:58:47] down the barrel we go [18:59:02] Oh well [18:59:05] should be pretty optimised I guess [19:02:58] * James_F grins. [19:03:09] We can add other date types if we really need to. [19:03:17] But the main date type should be the ISO standard one, I feel. [19:04:17] James_F, so, good news: one of the changes I had been avoiding and thought didn't work... appears to be working (?) [19:04:39] bad news: I found some annoying minor bug in something else in the process. [19:04:54] Krenair: Ha. Odd. [19:04:57] Krenair: Boo. [19:05:20] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Tracking bug for getting TemplateData's editor into a state that is stable enough for use on major wikis. [19:05:34] 3MediaWiki extensions / 3TemplateData: TemplateData: Create an editor for template data (in the wikitext editor) - 10https://bugzilla.wikimedia.org/51734 (10Krinkle) [19:06:20] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3major a:3Moriel Schottlender [19:06:20] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) [19:06:22] Krenair: Which one was fixed, and which is the new bug? [19:06:22] 3MediaWiki extensions / 3TemplateData: TemplateData: Template data editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Issues related to the editor interface of TemplateData. [19:06:30] James_F, the bug is that existing hidden categories on the page aren't marked as hidden (if you select it a popup comes up which should mention this) [19:06:34] 3MediaWiki extensions / 3TemplateData: TemplateData: Re-label "Manage template documentation" to something else - 10https://bugzilla.wikimedia.org/63389 (10Krinkle) [19:06:34] 3MediaWiki extensions / 3TemplateData: TemplateData: Template data editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) [19:06:44] but it's fine if you remove and re-add the category (or are just adding a new category to the page) [19:06:46] Krenair: Eww. Irritating. [19:06:49] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator uses old types - 10https://bugzilla.wikimedia.org/60693 (10Krinkle) [19:06:49] 3MediaWiki extensions / 3TemplateData: TemplateData: Template data editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) [19:07:04] 3MediaWiki extensions / 3TemplateData: TemplateData: Template data editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Krinkle) [19:07:09] The one that appears to be fine is the action=prefixsearch thing that is blocked on 1.23 release anyway [19:07:19] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10James Forrester) [19:08:01] Krenair: Oh, it's already done? How? [19:08:04] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) [19:08:05] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3enhanc a:3James Forrester [19:08:27] Krinkle: Sorry for messing with your bugs mid-creation; I'll hold off until you're done [19:09:30] James_F, the action=prefixsearch use? [19:09:36] Krenair: Yeah. [19:09:49] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) [19:09:51] 3MediaWiki extensions / 3TemplateData: TemplateData: Message templatedata-model-table-param-type-file missing - 10https://bugzilla.wikimedia.org/65545 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None The dialog contains the following as of late: