[00:01:56] <mooeypoo>	 ryasmeen, awesome, they're all assigned to me, right?
[00:01:58] <mooeypoo>	 i'm going by the list
[00:02:23] <ryasmeen>	 yes mooeypoo: they are 
[00:02:26] <ryasmeen>	 sure
[00:03:55] <mooeypoo>	 speaking of which, can we close this? https://bugzilla.wikimedia.org/show_bug.cgi?id=51290  and https://bugzilla.wikimedia.org/show_bug.cgi?id=64303 ?
[00:15:53] <cscott>	 are any of those image bugs parsoid-related?
[00:18:55] <mooeypoo>	 so far not that I saw.
[00:19:21] <mooeypoo>	 Most of those are behavior issues in VE. I think RoanKattouw_away mentioned something about a parsoid issue, but I am not sure exactly what it was, and I didn't replicate anything yet.
[00:36:19] <cscott>	 mooeypoo: yeah, roan ran the parsoid issue by me.  it related to _ and ? characters in image filenames.
[00:36:40] <cscott>	 i hope he bugzilla'ed it.
[00:36:44] <James_F>	 cscott: He did.
[00:37:36] <James_F>	 mooeypoo: When you convert an image type, it changes from <figure> to <img>. This means Parsoid's SelSer doesn't get a chance to fix things, so Parsoid nastily encodes the name of the file.
[00:38:13] <cscott>	 James_F: that's not quite accurate, but probably close enough.
[00:38:42] <mooeypoo>	 Hmm.
[00:38:51] <cscott>	 basically parsoid doesn't try hard enough to prettify resource names we are getting from HTML without the benefit of serlser/data-parsoid hints.
[00:39:02] <James_F>	 cscott: The bug is less inaccurate. :-)
[00:39:05] <mooeypoo>	 I was trying to keep all the attributes from type to type but I think that might (maybe?) produce a problem as well.
[00:39:35] <cscott>	 <img resource="File:foo_b%3Fr.jpg" ...> should after much gear grinding and gnashing of teeth become [[File:foo b?r.jpg]]
[00:39:36] <mooeypoo>	 I have a feeling I'll want to adjust inline images a bit to make them support the new system a bit better. For now they're good, but we don't have the advanced features yet.
[00:39:40] <James_F>	 mooeypoo: Oh, yes, merge https://gerrit.wikimedia.org/r/#/c/134755/ now please.
[00:39:53] <mooeypoo>	 things like "oh wait, you want caption? it's alternate text in inline! because why not."
[00:39:54] <James_F>	 cscott: Indeed.
[00:40:00] <cscott>	 mooeypoo: oh, and the latest word from the RfC meeting is that upright is likely to be deprecated and removed from wikitext entirely
[00:40:06] <James_F>	 mooeypoo: Yay MediaWiki.
[00:40:08] <cscott>	 so you'll never have to support it in VE. ;)
[00:40:13] <James_F>	 cscott: Tsk.
[00:40:24] <James_F>	 cscott: We already support it in VE, it's commented out because of Parsoid.
[00:40:38] <mooeypoo>	 I didn't know you can put these characters in image names at all
[00:40:40] <cscott>	 you should have been lazier ;)
[00:40:48] <mooeypoo>	 my brain is still in 1995 ascii
[00:40:49] <mooeypoo>	 :D
[00:41:37] <mooeypoo>	 James_F, oh! that looks good code-wise, but I can't test it since I didn't see the bug that it produced. 
[00:41:39] <cscott>	 James_F: i've implemented upright in parsoid at least two different times, i keep getting overridden by the forces which want to clean up wikitext and not support overtly broken stuff.
[00:42:12] <mooeypoo>	 cscott, "not support overtly broken stuff" will mean rewriting many many parts of wikitext...
[00:42:23] <cscott>	 not that i'm opposed to that goal, i just tend to not be as Bold
[00:42:27] <James_F>	 mooeypoo: I did; it fixed it IME.
[00:42:42] <James_F>	 mooeypoo: :D
[00:42:43] <cscott>	 mooeypoo: it turns out that only something like 0.4% of image references use upright at all, and most of those would render the same if it were simply omitted.
[00:42:51] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Looks good!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134755 (owner: 10Catrope)
[00:43:22] <mooeypoo>	 cscott, the bigger question now is how much of this do users *really* need to care about in terms of front end
[00:43:31] <mooeypoo>	 a lot of the wikitext stuff came about to make the wikitext-writers' lives easier
[00:43:48] <mooeypoo>	 not necessarily to make the users' lives easier
[00:44:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't add |link= when converting block images to inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134755 (owner: 10Catrope)
[00:44:40] <cscott>	 one of my to-do tasks is to collect statistics to find out more details on the users of upright
[00:44:47] <mooeypoo>	 I mean, we have to support it 'cause it's in wikitext, but a lot of the media editor is just plain confusing unless you write wikitext and want to produce a specific wikitext output.
[00:45:07] <cscott>	 mooeypoo: we just landed a patch to make default-sized thumbnails use a square bounding box by default, so most of the motivation to use upright is now gone.
[00:45:22] <mooeypoo>	 cscott, I write the code and feel like Indiana Jones, pulling random levers to prevent the walls from caving in...
[00:46:13] <mooeypoo>	 cscott, and yet, people request the feature.
[00:46:23] <mooeypoo>	 I can see the benefit in having a sort of percentage resizing thing
[00:46:42] <mooeypoo>	 but not necessarily in the same way upright was designed. It's a bit messed up.
[00:47:00] <cscott>	 mooeypoo: sort of.  but not really, since user's thumbnail preferences are completely dynamic.  so "50% of the user's preferred thumbnail size (whatever that is)" isn't really terribly useful.
[00:47:18] <mooeypoo>	 yeah that's the problem, that it's percentage out of thumbnail size
[00:47:24] <cscott>	 the user wants a particular thumbnail size.  so the remaining users of 'upright' are deliberately giving the user a size *other* than their preferred one.
[00:47:33] <mooeypoo>	 yeah
[00:48:12] <mooeypoo>	 It becomes inconsistent really fast, very tough trying to make sure that new users specifically know what to expect when choosing combinations of options.
[00:48:38] <cscott>	 anyway, we didn't reach a firm resolution in the RfC meeting.  But the preference of TimStarling and gwicke leaned heavily toward making 'upright' a no-op, deprecating it, and eventually removing it.  If we can get away with that -- which is what I need to collect statistics to find out.
[00:48:38] <mooeypoo>	 cscott, although, I have to say, I was a bit surprised to see something a little similar to the percentage concept of upright in Wordpress
[00:48:53] <cscott>	 bad ideas seed each other! ;)
[00:49:26] <mooeypoo>	 it looks a lot more intuitive there, though, you only get the option after the image is already up, if you want to make it a bit smaller. But yes, I agree. :p
[00:49:30] <grrrit-wm>	 (03PS1) 10Jforrester: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 
[00:49:41] <mooeypoo>	 I thought the whole 'upright' shenanigans is something users insisted on
[00:51:15] <cscott>	 mooeypoo: it was added because mw only did width-based scaling.  it was the wrong solution to the problem, in retrospect.
[00:51:30] * cscott  has to catch a train

[00:53:10] <mooeypoo>	 yeah.
[01:13:15] <spagewmf>	 James_F, gwicke: my "clunky" :) 'ext.parsoid.styles' makes it explicit that it's a CSS-only module. Can I make the same assumption for 'mediawiki.skinning.content.parsoid'?  Flow *has* to have reasonable no-JS rendering.
[01:13:58] <James_F>	 spagewmf: Yeah, it'll be CSS-only.
[01:14:13] <James_F>	 spagewmf: I imagine soon enough it will be handled by skins themselves, anyway.
[01:17:53] <spagewmf>	 James_F: Thanks.  I see right now the module has only skinStyles.
[01:18:06] <James_F>	 spagewmf: Indeed.
[01:24:48] <gwicke>	 spagewmf, reasonable CSS-only rendering != no JS is ever used if supported
[01:25:41] <James_F>	 gwicke: That too.
[01:26:13] <gwicke>	 it should definitely degrade gracefully
[02:28:37] <spagewmf>	 gwicke: yes, it should degrade well, but AIUI if you AddModuleStyles( 'mediawiki.skinning.content.parsoid' ) for no-JS and AddModules( 'mediawiki.skinning.content.parsoid' ) for JavaScript goodness, the CSS is loaded twice. Maybe skinStyles works differently
[07:05:59] <grrrit-wm>	 (03PS1) 10Mattflaschen: Preserve veaction, vesection on special redirects to wiki pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) 
[07:07:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Preserve veaction, vesection on special redirects to wiki pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) (owner: 10Mattflaschen)
[10:44:51] <grrrit-wm>	 (03CR) 10Krinkle: "Nice try James, but I don't think we'll allow javascript execution in SVGs just yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester)
[10:45:30] <Krinkle>	 or third-party scriptl oading for that matter
[10:45:32] <Krinkle>	 wait, what?
[10:45:52] <Krenair>	 haha, what.
[10:45:55] <Krinkle>	 These aren't svg
[10:45:59] <Krinkle>	 this is HTML
[10:46:01] <Krinkle>	 Dude :P
[10:50:11] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Hm.. while <script> can exist in SVG and some editors insert a small harmless footprint, these aren't SVG. This is HTML; The Dropbox downl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester)
[11:02:32] <grrrit-wm>	 (03PS1) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) 
[11:04:00] <grrrit-wm>	 (03PS2) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) 
[11:16:49] <grrrit-wm>	 (03PS3) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) 
[11:18:49] <grrrit-wm>	 (03CR) 10Krinkle: Use CSS Janus to generate RTL stylesheets (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders)
[13:44:20] <wikibugs>	 3VisualEditor / 3MediaWiki integration: Confusing experience when Cite extension not enabled - 10https://bugzilla.wikimedia.org/65630 (10Jon) 3NEW p:3Unprio s:3normal a:3None I spent a lot of time wondering why my citations were not rendering properly.  VisualEditor shows a cite menu which behaves st...
[14:47:43] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Ignore SelectWidget mouseup events that started outside the widget (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal)
[14:55:52] <grrrit-wm>	 (03PS9) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[15:05:40] <jgonera>	 jdlrobson, have you started working on one of the VE stories?
[15:05:55] <jdlrobson>	 jgonera: i'm trying to
[15:06:06] <jdlrobson>	 i've been trying to get help all day with it :(
[15:06:10] <jdlrobson>	 i was drafting a big long email
[15:06:17] <jgonera>	 jdlrobson, move it to "in development" so that I don't start working on the same thing
[15:06:17] <jdlrobson>	 i can't work out how to wire it up correctly
[15:06:21] <jdlrobson>	 i did no?
[15:06:27] <jgonera>	 oh
[15:06:34] <jgonera>	 it's use existing references dialog?
[15:06:39] <jdlrobson>	 yeh use existing yeh
[15:06:50] <jdlrobson>	 didn't add myself to it though - done that now
[15:07:09] <jgonera>	 ok, can you add yourself as a member in the card when you start working on something? this way we can quickly see by avatar who's working on what ;)
[15:07:13] <jgonera>	 thanks!
[15:07:45] <jdlrobson>	 i usually try to but it's not automatic :||
[15:07:54] <jgonera>	 I know
[15:07:55] <jdlrobson>	 you can usually work it out though quite easily from the history
[15:08:01] <jdlrobson>	 i've added you and kaldari and max to ones in the past
[15:08:02] <jgonera>	 I know that too ;)
[15:08:06] <jdlrobson>	 ok cool as long as you do :)
[15:08:23] <jgonera>	 but it's cool that we can have more than one person as a member, this way you know which designer is working on it too
[15:08:56] <jdlrobson>	 yeh
[15:09:29] <jdlrobson>	 but yeh any idea how to start with this citation story?
[15:09:43] <jdlrobson>	 firstly for some reason VE doesn't understand how to convert the reference tag into a list
[15:09:48] <jdlrobson>	 so i'm seeing VE in reference view
[15:14:04] <jdlrobson>	 jgonera: u have mail with regards to above ^
[15:29:28] <grrrit-wm>	 (03PS1) 10Esanders: Blockquote node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 
[15:33:44] <grrrit-wm>	 (03PS2) 10Esanders: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 
[15:39:52] <grrrit-wm>	 (03PS3) 10Esanders: Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) 
[15:42:59] <Krenair>	 Hi James_F 
[15:44:17] <grrrit-wm>	 (03PS1) 10Esanders: Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) 
[15:44:54] <James_F>	 Hey Krenair.
[15:45:00] <jdlrobson>	 edsanders: you there?
[15:45:07] <edsanders>	 yo
[15:45:15] <jdlrobson>	 hey i'm having issues with VE :(
[15:45:18] <jdlrobson>	 and i'm running out of time
[15:45:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[15:45:29] <jdlrobson>	 I sent a mail to ve-tech elaborating
[15:46:12] <James_F>	 jdlrobson: You've probably not styled the references list yet by the looks of the thing.
[15:46:21] <edsanders>	 ok
[15:46:26] <James_F>	 jdlrobson: Hmm, no, ignore that.
[15:46:32] <James_F>	 jdlrobson: Do you have the Cite extension installed?
[15:46:37] <jdlrobson>	 James_F: yes.
[15:46:42] <jdlrobson>	 it works fine in non-VE mode
[15:46:49] <James_F>	 Hmm. Odd.
[15:46:54] <jdlrobson>	 as you can see in the other image
[15:47:16] <James_F>	 I can't "see", I can surmise maybe.
[15:47:30] <James_F>	 There are lots of things that simulate references without actually using them.
[15:47:38] <James_F>	 Welcome to the worst area of wikitext. :-(
[15:48:36] <edsanders>	 let me look at mobile
[15:49:37] <edsanders>	 so they render properly for me in ve mobile
[15:49:37] <edsanders>	 the fact you're seeing <ref> tags suggest something quite bad
[15:49:37] <Krenair>	 James_F, I looked into the ActionDialog stuff some more... I recall Roan mentioning yesterday that I should look at this before doing the MWSaveDialog-VPT untangling
[15:49:43] <James_F>	 Krenair: Kk.
[15:49:44] <edsanders>	 like at the Parsoid level
[15:50:10] <edsanders>	 do they work in ve-desktop?
[15:50:13] <Krenair>	 I don't want to duplicate Trevor's work though
[15:51:06] <Krenair>	 Though I also don't want to conflict with it. sigh
[15:51:13] <James_F>	 Krenair: Honestly, no-one has any idea (including Trevor) what he was fiddling around with in that area three weeks ago. :-(
[15:51:16] <edsanders>	 jdlrobson, did you restart Parsoid after install Cite?
[15:51:44] <jdlrobson>	 restart parsoid?
[15:51:45] <jdlrobson>	 mmm
[15:51:52] <jdlrobson>	 let me reboot vagrant but that's possible
[15:52:12] <James_F>	 edsanders: The Cite bit of Parsoid is built-in; I'm pretty sure you can't switch it off.
[15:55:20] <edsanders>	 James_F, given he's seeing wikitext HTML as opposed to parsoid html (<span class="reference">) I would suggest Parsoid isn't converting them.
[15:55:55] <James_F>	 Yeah.
[15:57:42] * edsanders  confirms that if you disable Cite and restart Parsoid you get <ref> tags in VE

[15:58:58] <jdlrobson>	 errg now my vagrant instance isn't turned off
[15:59:02] <jdlrobson>	 rather it isn't turning on
[15:59:12] <jdlrobson>	 	Ok Ed confirmed
[15:59:27] <jdlrobson>	 that solved that issue
[15:59:37] <jdlrobson>	 now what am i doing failing to launch a references dialog?
[16:02:06] <edsanders>	 erm
[16:02:16] <James_F>	 jdlrobson: Do you have any JS console errors?
[16:02:27] <James_F>	 jdlrobson: (Which references dialog? I thought you were doing the citation dialog?)
[16:03:07] <jdlrobson>	 Well i want the use existing reference thingy
[16:03:16] <jdlrobson>	 but as detailed in the email that's inside the Reference Dialog
[16:03:28] <jdlrobson>	 and i thought a good first step would be to launch that from the menu
[16:03:34] <James_F>	 Which menu?
[16:03:42] <jgonera>	 jdlrobson, I don't see any emails from you
[16:03:48] <James_F>	 You want to launch the generic reference from the cite menu?
[16:03:57] <James_F>	 'Cos Kaity was very adamant that we shouldn't make that available…
[16:04:04] <jgonera>	 jdlrobson, do you mean a post on mobile-l?
[16:04:20] <James_F>	 jdlrobson: Are you remote right now?
[16:04:49] <jdlrobson>	 James_F: yup
[16:04:52] <jdlrobson>	 jgonera: yup
[16:05:01] <jdlrobson>	 James_F: please read the email
[16:05:06] <jdlrobson>	 i say in that it's a first logical step
[16:05:14] <jdlrobson>	 i'm not planning to use the entire dialog
[16:05:24] <edsanders>	 jdlrobson, what exception did you get?
[16:05:30] <James_F>	 jdlrobson: OK, but is this cleared by design and product? 'Cos otherwise this seems like a lot of work…
[16:05:47] <jdlrobson>	 actually edsanders here's an idea.. what are you doing tomorrow afternoon and are you in London?
[16:05:55] <jgonera>	 jdlrobson, descriptions like "Sadly this caused things to explode, and I'm unable to debug this in
[16:05:55] <jgonera>	 any coherent fashion to work this out." are not going to help us solve your problem
[16:06:02] <jdlrobson>	 jgonera: you me both
[16:06:15] <edsanders>	 jdlrobson, driving to Nottingham :/
[16:06:18] <jdlrobson>	 edsanders: arg
[16:06:33] <jdlrobson>	 is anymore of the osmosoft london division around?
[16:06:50] <edsanders>	 osmosoft?
[16:06:55] <James_F>	 jdlrobson: I've read your e-mail. Twice. I still don't know what problem you're getting in sufficient detail to help.
[16:06:55] <jgonera>	 jdlrobson, first things first, do references work for you now?
[16:07:12] <jdlrobson>	 edsanders: sorry ve london division
[16:07:17] <jdlrobson>	 a few of you are based in london right?
[16:07:32] <James_F>	 jdlrobson: Only Ed, and Krenair is near-ish.
[16:07:40] <jdlrobson>	 James_F: so the first point is fixed now which is good
[16:07:49] <edsanders>	 David is in Wales, and is also driving to Nottingham on Friday
[16:08:02] <jdlrobson>	 sorry if i'm appearing incoherent but it's been a very frustrating day for me :)
[16:08:06] <James_F>	 jdlrobson: We're PDT-centred as a team, which is why the first thing I'd have said when asked is "don't for the love of anything try to explore this remotely".
[16:08:33] <edsanders>	 if you want to do a hangout with a screenshare though
[16:09:47] <jdlrobson>	 edsanders: just checking when i have this space till
[16:10:27] <jdlrobson>	 edsanders: ok so i need to leave this office in 15 mins but if you wouldn't mind having a quick look at what i'm doing that would be most appreciated
[16:10:54] <jdlrobson>	 edsanders: are you free now?
[16:12:15] <jgonera>	 jdlrobson, what is the current problem?
[16:13:56] <jdlrobson>	 jgonera: if edsanders is able to hangout with me i think this is my best chance at working it out
[16:16:24] <jdlrobson>	 fyi James_F this is what i'm trying to implement https://trello.com/c/m3m53BdN/32-5-use-existing-references-dialog
[16:16:40] <jdlrobson>	 the link to this dialog appears here - https://trello.com/c/xCo6uLAZ/23-5-references-dropdown-from-toolbar-styling
[16:17:31] <James_F>	 jdlrobson: Wait, really?
[16:17:51] <James_F>	 jdlrobson: 'Cos design have been adamant that we can't put the non-cite reference things in that menu.
[16:17:56] <James_F>	 jdlrobson: Why the different approach?
[16:18:20] <jdlrobson>	 James_F: well this is the story i was given as created by kaity|away jgonera and RoanKattouw_away and Kenan/ maryana
[16:18:40] <edsanders>	 jdlrobson, free now
[16:18:49] <James_F>	 Aren't the stories meant to be created in the Monday meetings, and the Tuesdays are about deciding how much effort they will take?
[16:18:57] <James_F>	 Because that's the basis we've been operating on before.
[16:18:58] * James_F  sighs.

[16:19:02] <jdlrobson>	 thanks edsanders - would be great to quickly work out what i'm doing wrong in VE land
[16:19:24] * James_F  writes an e-mail to Arthur asking WTF is going on.

[16:25:34] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Make the reference, reference list and citation systems depend on the Cite extension (how?) - 10https://bugzilla.wikimedia.org/65630#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low Yeah, this is a bit of a crummy situation. We should fix this.
[16:26:37] <jdlrobson>	 edsanders: modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
[16:33:48] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Add redirect=no to URL after a page with a redirect is saved - 10https://bugzilla.wikimedia.org/65621#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3minor Ick. We shouldn't actually be refreshing the page to the extent that a re...
[16:40:30] <James_F>	 edsanders: Did you manage to help Jon?
[16:40:31] <edsanders>	 so the main bug is that SurfaceWidget always creates a DesktopSurface, regardless of the target (Desktop/Mobile) :/
[16:40:48] <James_F>	 Eurgh. That's definitely likely to cause bugs, yes.
[16:40:52] <James_F>	 Easy fix?
[16:42:13] <edsanders>	 potentially a bit fiddly
[16:42:20] <edsanders>	 because createSurface is on the target
[16:42:25] <edsanders>	 should be easy enough though
[16:42:30] <James_F>	 Kk.
[16:45:13] <grrrit-wm>	 (03PS1) 10Alex Monk: Detect that a category is hidden when following a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134847 
[16:45:27] <Krenair>	 James_F, that annoying minor bug I mentioned the other day ^
[16:45:35] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: SurfaceWidget always creates a DesktopSurface, even when the target is mobile - 10https://bugzilla.wikimedia.org/65642 (10James Forrester) 3ASS p:3Unprio s:3major a:3Ed Sanders This is bad.
[16:45:48] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: SurfaceWidget always creates a DesktopSurface, even when the target is mobile - 10https://bugzilla.wikimedia.org/65642 (10James Forrester) p:5Unprio>3Highes
[16:46:47] <Krenair>	 (Well, only annoying to me because I wrote the code for dealing with that redirect mess, it was fiddly and now I found it wasn't 100% working in all cases)
[16:47:22] <James_F>	 Krenair: You just wanted to give yourself the chance to come back for a victory lap on that part of the codebase. :-)
[16:47:49] <Krenair>	 Meh. I hate what I wrote.
[16:48:40] <Krenair>	 I should have made it more clear in each case what each variable held (formatting-wise and is-this-a-redirect-or-its-target-wise)
[16:56:28] <grrrit-wm>	 (03PS2) 10Jforrester: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 
[17:00:25] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "Please make XML more like original, specifically:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester)
[17:05:36] <grrrit-wm>	 (03PS2) 10Mattflaschen: Preserve veaction, vesection on special redirects to wiki pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) 
[17:07:07] <grrrit-wm>	 (03CR) 10Mattflaschen: "I had to break the hook registration line for the voting line length check." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) (owner: 10Mattflaschen)
[17:13:27] <jgonera>	 edsanders, I'm not sure why QUnit is failing here: https://gerrit.wikimedia.org/r/#/c/134748/ is it because I added a non-existent CSS file to a module (VE core needs to be updated first)?
[17:24:19] <grrrit-wm>	 (03PS1) 10Esanders: Remove DesktopContext.css/js from core, leave in desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134854 
[17:26:55] <grrrit-wm>	 (03CR) 10Jforrester: "Given that the contributor is not on gerrit, you should probably e-mail them." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester)
[17:44:50] <wikibugs>	 3VisualEditor: VisualEditor:  Support editing {{int:name}} blocks - 10https://bugzilla.wikimedia.org/65644 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This is related to Bug 50855 about parser functions and magic words.  When I have a sentence on a page like this:     Choose the "{{int:visualedit...
[17:47:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusions editor should have a special mode for Parser Function and Magic Word calls - 10https://bugzilla.wikimedia.org/50855 (10WhatamIdoing)
[17:47:03] <wikibugs>	 3VisualEditor: VisualEditor:  Support editing {{int:name}} blocks - 10https://bugzilla.wikimedia.org/65644 (10WhatamIdoing)
[17:52:39] <grrrit-wm>	 (03PS1) 10Esanders: Make MWGalleryInspector wider [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134856 
[17:53:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Make MWGalleryInspector wider (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134856 (owner: 10Esanders)
[17:53:37] <wikibugs>	 3VisualEditor: VisualEditor:  Span tags for Language tool only mark part of the page - 10https://bugzilla.wikimedia.org/65645 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Mark almost an entire page with language (en) and direction (LTR).  Steps to Reproduce: 1.  Open the page and select...
[17:54:48] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463 (10James Forrester) 5PAT>3RES/FIX
[17:56:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615 (10James Forrester)
[17:56:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] There is an extra space appearing in media search result dialog (scroll bar displacing last column of results) - 10https://bugzilla.wikimedia.org/64911 (10James Forrester)
[17:56:18] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616 (10James Forrester)
[17:56:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Left aligned Frameless/Basic image does not move to right upon changing the alignment to Right - 10https://bugzilla.wikimedia.org/65596 (10James Forrester)
[17:56:19] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617 (10James Forrester)
[17:56:33] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] While changing the Image Type to Frame/Basic, it automatically selects the alignment as Left when it is positioned at the right of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/65564 (10J...
[17:56:33] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10James Forrester)
[17:56:33] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does not include the Right and Border in the wikitext - 10https://bugzilla.wikimedia.org/62852 (10James Forrester)
[18:10:50] <grrrit-wm>	 (03PS1) 10Esanders: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 
[18:11:53] <grrrit-wm>	 (03CR) 10Esanders: Make MWGalleryInspector wider (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134856 (owner: 10Esanders)
[18:16:35] <wikibugs>	 3VisualEditor: Please don't put catgories or DEFAULTSORT tags all on one line - 10https://bugzilla.wikimedia.org/65647 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Sometimes editing a page in VisualEditor is rearranging categories so that they always end up on a single line, which is inconvenient...
[18:21:35] <wikibugs>	 3VisualEditor: VisualEditor:  Coordinates template is displaying in the wrong place - 10https://bugzilla.wikimedia.org/65648 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.  Open any page that contains the {{coord}} template on en.wp  See, e.g., https://en.wikipedia.org/wiki/H...
[18:23:04] <wikibugs>	 3VisualEditor: [Regression] Catgories and DEFAULTSORT meta items getting modified to strip default whitespace? - 10https://bugzilla.wikimedia.org/65647 (10Gabriel Wicke) a:5Gabriel Wicke>3None
[19:25:03] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with Translate extension's save abort hooks - 10https://bugzilla.wikimedia.org/65653 (10James Forrester) p:5Unprio>3Normal
[19:25:05] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Deal with Translate extension's save abort hooks - 10https://bugzilla.wikimedia.org/65653 (10James Forrester) 3ASS p:3Unprio s:3minor a:3None "Translation unit markers in unexpected position." can just go die in Hell. Gah.
[19:30:00] <James_F>	 edsanders: Any luck with the SurfaceWidget->DesktopSurface issue?
[19:30:53] <edsanders>	 not yet
[19:31:22] <James_F>	 edsanders: :-(
[19:34:29] <grrrit-wm>	 (03PS10) 10Jforrester: Remove media item styling moved to MW-core in I400336c12d. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo)
[19:39:03] <Krenair>	 mooeypoo, I am not having much luck with this VM...
[19:39:14] <mooeypoo>	 :\
[19:39:27] <mooeypoo>	 I wish I could help, but it sounds like Linux trouble, I'm not as familiar with those
[19:39:33] <Krenair>	 pretty much.
[19:39:44] <mooeypoo>	 If the VM was working, I could walk you through how to set up "slow" computer
[19:39:51] <mooeypoo>	 but if it doesn't work, i have no idea :\
[19:40:41] <Krenair>	 yeah, having issues setting up Ubuntu, weirdly enough. Have never had issues there before...
[20:01:01] <edsanders>	 mooeypoo, do you know how MW sets the rtl on frames?
[20:02:22] <mooeypoo>	 RoanKattouw_away, and TrevorP|Away made jenkins work inside frames
[20:03:00] <mooeypoo>	 IIRC it was injecting the post-jenkins output to the frame
[20:03:39] <edsanders>	 mooeypoo, I think I've found some code - I was searching for oo-ui-rtl, but it is 'oo-ui-' + dir
[20:05:09] <edsanders>	 why do we do 
[20:05:10] <edsanders>	 this.dir = this.$element.closest( '[dir]' ).prop( 'dir' ) || 'ltr' 
[20:05:39] <edsanders>	 instead of
[20:05:53] <edsanders>	 this.dir = this.$element.css('direction'); ?
[20:11:31] <mooeypoo>	 I need to double check but if I remember correctly, the css( 'direction' ) attribute has issues with inheritance
[20:12:08] <mooeypoo>	 I know the css attribute has a problem with inheritance in tables, but I am not sure if that's the only inheritance issue.
[20:13:41] <mooeypoo>	 edsanders, according to this, tables are its only shortfall, so it should be safe to use .css('direction') .. we can handle tables later when they're more relevant. https://developer.mozilla.org/en-US/docs/Web/CSS/direction
[20:14:59] <mooeypoo>	 the oo-ui- dir is to get cssjanus to work, roan and trevor have another piece of code that actually inject post-janusified to frames
[20:16:47] <James_F>	 mooeypoo: Regressing behaviour in tables would be bad. :-(
[20:17:06] <mooeypoo>	 James_F, yeah, but the code above also has potential problems, especially for standalone
[20:17:15] <mooeypoo>	 in MW, we always have dir='something' in the body tag
[20:17:25] <James_F>	 Hmm.
[20:17:43] <mooeypoo>	 standalone might not. So we either want to make sure people put that in or juggle something smartassy for templates later
[20:17:48] <mooeypoo>	 err tables
[20:17:50] <mooeypoo>	 not templates.
[20:17:59] <James_F>	 Yeah.
[20:39:15] <grrrit-wm>	 (03PS1) 10Mooeypoo: [WIP] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 
[20:39:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (owner: 10Mooeypoo)
[20:56:30] <Nihiltres>	 Hey, have there been any bugs filed over VE buttons not working in Safari? I've been playing around a little and they're only working some of the time.
[20:57:57] <RoanKattouw>	 Maybe?
[20:58:25] <RoanKattouw>	 ryasmeen: Have you noticed something similar to what Nihiltres said ---^^ on that test iPad of yours?
[20:58:31] <RoanKattouw>	 (Since iOS devices run Safari)
[20:59:53] <Nihiltres>	 In particular, I'm seeing odd delays—click on a cite button shortly after loading the editor, and it doesn't do anything, but then hit another button later, and I get both
[21:00:13] <Nihiltres>	 I'm using Safari 5.1.10 on Mac OS 10.6.8
[21:00:27] <RoanKattouw>	 That's odd
[21:03:09] <ryasmeen>	 RoanKattouw: nope not on iPad , but i got this issue once which seems like working again now: https://bugzilla.wikimedia.org/show_bug.cgi?id=65414
[21:03:29] <Nihiltres>	 Another example: I selected "Options", then "Page settings", then "Categories" from the "hamburger" ("menu icon"?) menu, and only the "Categories" item worked.
[21:04:25] <Nihiltres>	 …but then shortly after, each of them worked
[21:05:28] <Nihiltres>	 …are parts of VE loaded on-demand?
[21:06:23] <RoanKattouw>	 Not those parts
[21:06:33] <RoanKattouw>	 None of the code is loaded on demand in that sense
[21:06:41] <RoanKattouw>	 It might be something weird with iframe behavior
[21:06:59] <RoanKattouw>	 Given that all of the things you're talking about involve opening dialogs, which open in iframes
[21:08:08] <Nihiltres>	 That sounds plausible, and yes, you're right
[21:09:13] <Nihiltres>	 I'll file a bug later with the odd behaviour I'm seeing.
[21:14:31] <grrrit-wm>	 (03PS1) 10Catrope: Followup 682b4d0b88: bring this.isSetup back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134937 
[21:14:40] <RoanKattouw>	 edsanders, James_F: ---^^
[21:16:49] <grrrit-wm>	 (03PS1) 10Catrope: .unbind() -> .off() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134938 
[21:17:47] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Followup 682b4d0b88: bring this.isSetup back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134937 (owner: 10Catrope)
[21:17:53] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] .unbind() -> .off() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134938 (owner: 10Catrope)
[21:18:45] <James_F>	 Nihiltres: I don't think we've tested very extensively on Safari 5.x; mostly we've tested 6.x and 7.x.
[21:19:17] <James_F>	 Nihiltres: Maybe we need to blacklist Safari 5.x?
[21:19:28] <Nihiltres>	 :/
[21:19:43] <James_F>	 Nihiltres: Sounds like really-delayed loading of CSS, maybe?
[21:19:57] * Nihiltres  uses Safari 5.x because he hasn't "upgraded" Mac OS in a while

[21:20:58] <RoanKattouw>	 James_F: Do we have browserstack coverage for those Safari versions?
[21:20:58] <RoanKattouw>	 If so it wouldn't be hard to figure out which versions are affected
[21:21:26] <RoanKattouw>	 James_F: It's almost certainly something weird with CSS loading in iframes since opening dialogs blocks on that
[21:21:38] <RoanKattouw>	 The pollExternalStylesheets hairball
[21:22:21] <grrrit-wm>	 (03CR) 10Catrope: "Removing -2 because the relevant change has been merged" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo)
[21:23:21] <James_F>	 RoanKattouw: We don't use BrowserStack, I think, but I'm sure it's /possible/ to try to run the tests in more environments.
[21:23:50] <James_F>	 RoanKattouw: Right now we just run Chrome/Firefox latest in Linux, and Chrome latest in Mac OS X/Windows, IIRC.
[21:24:17] <James_F>	 RoanKattouw: Running the full suite is a bit expensive in noise level given that most tests fail from time to time.
[21:26:05] <wikibugs>	 3VisualEditor: Dialogs initially don't work in Safari 5 - 10https://bugzilla.wikimedia.org/65656 (10Nihiltres) 3NEW p:3Unprio s:3normal a:3None I noticed today that dialogs are delayed or fail to work some of the time in VE, using Safari 5.1.10 on Mac OS 10.6.8. The first click on a button that produce...
[21:26:11] <grrrit-wm>	 (03PS2) 10Jforrester: Document that SurfaceFragment#getSelectedNode doesn't require selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134158 (owner: 10Catrope)
[21:26:14] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Followup 682b4d0b88: bring this.isSetup back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134937 (owner: 10Catrope)
[21:26:15] <RoanKattouw>	 s/BrowserStack/whatever it is that we typically use/
[21:26:36] <Nihiltres>	 so there, a palindromic bug number :P
[21:26:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Document that SurfaceFragment#getSelectedNode doesn't require selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134158 (owner: 10Catrope)
[21:27:15] <James_F>	 Nihiltres: Thanks.
[21:27:22] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Document that SurfaceFragment#getSelectedNode doesn't require selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134158 (owner: 10Catrope)
[21:27:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 682b4d0b88: bring this.isSetup back [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134937 (owner: 10Catrope)
[21:28:16] <grrrit-wm>	 (03PS4) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) 
[21:28:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Document that SurfaceFragment#getSelectedNode doesn't require selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134158 (owner: 10Catrope)
[21:28:49] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs initially don't work in Safari 5.x (but do with 6.x+?) - 10https://bugzilla.wikimedia.org/65656#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal a:3ryasmeen Odd. Rummana, can you test this and confirm behaviour?
[21:30:35] <James_F>	 Bleh to cherry-picking.
[21:31:26] <RoanKattouw>	 James_F: Want me to do that cherry-pick?
[21:31:31] <James_F>	 RoanKattouw: Doing.
[21:31:33] <RoanKattouw>	 OK
[21:31:40] <James_F>	 I can cheat with this one.
[21:31:45] <James_F>	 No intervening changes.
[21:31:51] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134941 
[21:32:15] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134941 (owner: 10Jforrester)
[21:32:15] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/134942 
[21:33:21] <grrrit-wm>	 (03PS1) 10Esanders: Compute directionality for frame correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/134943 
[21:33:23] <RoanKattouw>	 hah
[21:33:26] <RoanKattouw>	 Nice cop-out James_F 
[21:33:32] * James_F  bows. :-D

[21:33:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134941 (owner: 10Jforrester)
[21:33:46] <James_F>	 RoanKattouw: You OK with that going out in the SWAT tonight?
[21:34:15] <RoanKattouw>	 Yes please do
[21:34:17] <James_F>	 OK.
[21:34:27] <James_F>	 Now I just need to get someone to create the submodule update.
[21:34:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Compute directionality for frame correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/134943 (owner: 10Esanders)
[21:34:29] * James_F  sighs.

[21:34:35] <RoanKattouw>	 James_F: I can do that
[21:34:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Compute directionality for frame correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/134943 (owner: 10Esanders)
[21:34:59] <James_F>	 RoanKattouw: Thanks. But really I should get the tools so I can, I guess.
[21:35:12] <RoanKattouw>	 James_F: OK, let me walk you through it
[21:35:18] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Implement inferred templatedata as fallback based on the contents of the template - 10https://bugzilla.wikimedia.org/52581#c10 (10kipod) for many many simple templates, just getting the list of parameter names is enough for even moderately experienced edit...
[21:35:24] <RoanKattouw>	 I strongly recommend creating a second checkout of MediaWiki core called wmf-core or core-wmf or something
[21:35:27] <James_F>	 RoanKattouw: I need +2 in wmf/… for it to work.
[21:35:34] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463#c13 (10ryasmeen) 5RES/?>3VER Verified in production
[21:35:36] <RoanKattouw>	 James_F: Not to submit changes
[21:35:39] <RoanKattouw>	 Only to merge them
[21:35:58] <James_F>	 RoanKattouw: But I need https://gerrit.wikimedia.org/r/134942 in VE's wmf/1.24wmf6 to be merged.
[21:36:01] <RoanKattouw>	 Oh, I suppose you need +2 in wmf/* of VE
[21:36:04] <James_F>	 Yeah.
[21:36:07] <RoanKattouw>	 I'll merge that real quick
[21:36:11] <James_F>	 Cheat. :-)
[21:36:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/134942 (owner: 10Jforrester)
[21:37:34] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239#c7 (10ryasmeen) 5RES/?>3VER Verified the fix in production
[21:37:34] <grrrit-wm>	 (03PS10) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[21:37:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (1c1eb3a) [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/134942 (owner: 10Jforrester)
[21:38:09] <James_F>	 RoanKattouw: OK, I have a second checkout of MW-core.
[21:38:14] <RoanKattouw>	 OK awesome
[21:38:25] <RoanKattouw>	 Don't use this checkout for anything except messing with wmf branches, to avoid headaches
[21:38:31] * James_F  nods.

[21:38:34] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269#c6 (10ryasmeen) 5RES/?>3VER Verified the fix in prod...
[21:38:35] <RoanKattouw>	 Having said that
[21:38:41] <RoanKattouw>	 cd into that dir and do git checkout wmf/1.24wmf6
[21:38:54] <James_F>	 Hmm.
[21:39:11] <RoanKattouw>	 (conversely, don't run that in your normal mw core checkout unless you have reason to believe it won't screw you over)
[21:39:24] <James_F>	 Maybe I shouldn't have done a shallow checkout.
[21:39:29] * James_F  sighs at himself.

[21:39:32] <RoanKattouw>	 Shallow?
[21:39:33] <wikibugs>	 3VisualEditor: [Regression] Categories and DEFAULTSORT meta items getting modified to strip default whitespace? - 10https://bugzilla.wikimedia.org/65647 (10Elitre)
[21:39:39] <James_F>	 RoanKattouw: --depth 1
[21:39:46] <James_F>	 RoanKattouw: Avoids ~ 100MB of git fetch.
[21:39:48] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314#c7 (10ryasmeen) 5RES/?>3VER Verified the fix in production
[21:40:18] <RoanKattouw>	 James_F: Just do a filesystem copy of your existing checkout
[21:40:35] <RoanKattouw>	 that avoids even more git fetch
[21:40:59] <James_F>	 Ha.
[21:41:04] <wikibugs>	 3OOjs UI: [Regression 1.24wmf5] OOjs UI: Firefox throws NS_ERROR_NOT_AVAILABLE when opening certain dialogs - 10https://bugzilla.wikimedia.org/65373 (10ryasmeen) 5RES/?>3VER
[21:42:03] <James_F>	 Though it has all my extensions. Boo.
[21:42:14] <RoanKattouw>	 Don't worry
[21:42:23] <James_F>	 It's taking forever. :-)
[21:42:28] <RoanKattouw>	 That git checkout command I warned you to never use in your real clone will destroy those fast enough
[21:42:35] * James_F  knows.

[21:43:00] <RoanKattouw>	 Also, psh you and your spinning rust
[21:43:05] <James_F>	 It's SSD.
[21:43:22] <RoanKattouw>	 Oh :O
[21:43:34] <James_F>	 And almost certainly the same SSF manufacturer as you.
[21:43:35] <James_F>	 (I have a /lot/ of extensions.)
[21:43:58] <James_F>	 OK, done.
[21:45:18] <RoanKattouw>	 OK, so the process is something like
[21:45:22] <RoanKattouw>	 git checkout wmf/1.24wmf6
[21:45:24] <James_F>	 RoanKattouw: I just want to change extensions/VisualEditor to 805dbdd5bb5d11798acb5956ce2fc7d18df8d148 right? (the merged commit ID of that change).
[21:45:33] <RoanKattouw>	 cd extensions/VisualEditor
[21:45:44] <RoanKattouw>	 git fetch # not needed right now, but needed in the typical case
[21:45:57] <RoanKattouw>	 git checkout origin/wmf/1.24wmf6
[21:46:00] <RoanKattouw>	 cd ../..
[21:46:11] <RoanKattouw>	 git diff extensions/VisualEditor # NO TRAILING SLASH
[21:46:16] <RoanKattouw>	 # Verify diff
[21:46:25] <RoanKattouw>	 git commit extensions/VisualEditor
[21:46:31] <RoanKattouw>	 git review
[21:46:32] <James_F>	 Verify what?
[21:46:45] <RoanKattouw>	 Verify that the new hash is what you expect it to be
[21:46:48] <James_F>	 It's blank.
[21:47:02] <RoanKattouw>	 Really
[21:47:15] <RoanKattouw>	 What is cd extensions/VisualEditor && git log -1 --oneline ?
[21:47:29] <James_F>	 Create the new wmf6.
[21:47:47] <James_F>	 But https://gerrit.wikimedia.org/r/#/c/134942/ merged…
[21:48:02] <RoanKattouw>	 Right
[21:48:16] <RoanKattouw>	 Did you do git fetch && git checkout origin/wmf/1.24wmf6 ?
[21:48:20] <RoanKattouw>	 (in the VisualEditor dir)
[21:48:45] <James_F>	 Yes.
[21:49:13] <RoanKattouw>	 Then it should have picked it up
[21:49:13] * RoanKattouw  tries locally

[21:49:16] <James_F>	 Maybe the VE-brokenness means this doesn't work?
[21:49:23] <James_F>	 VE-broken-for-gerrit-updates?
[21:49:52] <RoanKattouw>	 $ git log -1 --oneline
[21:49:53] <RoanKattouw>	 1de681b Update VE core submodule to master (1c1eb3a)
[21:49:55] <RoanKattouw>	 WM
[21:49:57] <RoanKattouw>	 *WFM
[21:50:08] <James_F>	 https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions,n,z looks like it's only running for master, not wmf/1.24wmfN
[21:50:15] <RoanKattouw>	 Yeah but that's fine
[21:50:17] <RoanKattouw>	 Oh, hold on
[21:50:26] <RoanKattouw>	 I forgot a setup step
[21:50:30] <RoanKattouw>	 Go back into the wmf-core directory
[21:50:33] <James_F>	 Ha.
[21:50:39] <RoanKattouw>	 And run git submodule update --init extensions/VisualEditor
[21:50:40] <RoanKattouw>	 :)
[21:50:42] <James_F>	 su… yeah.
[21:50:57] <James_F>	 That'd help. :-D
[21:51:03] <RoanKattouw>	 Then repeat the steps I gave you initially
[21:52:58] <James_F>	 Should the commit message justify?
[21:53:03] <James_F>	 Or just not bother?
[21:54:53] <James_F>	 (Finished and listed.)
[21:57:16] <RoanKattouw>	 Sorry, was on the phone
[21:57:22] <James_F>	 No worries. Done anyway. :-)
[21:57:31] <RoanKattouw>	 Looks good
[21:57:44] <James_F>	 Now I just need to remember to be on IRC at 16:00.
[21:58:35] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616#c4 (10James Forrester) 5PAT>3RES/FIX a:5Ed Sanders>3Roan Kattouw...
[21:58:37] <grrrit-wm>	 (03PS11) 10Jforrester: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[22:24:45] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "This is fixed in my phantom-menace commit you still haven't reviewed, but ok. More rebases for me." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134938 (owner: 10Catrope)
[22:25:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: .unbind() -> .off() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134938 (owner: 10Catrope)
[22:26:20] <Krenair>	 mooeypoo, after failing at getting a Ubuntu VM to run on my laptop, someone suggested a really simple way to fix my desktop virtualbox install (which worked, though I have no idea how)
[22:26:46] <Krenair>	 I didn't need to change anything because the machine already ran ridiculously slow. The basic idea certainly seemed to work.
[22:27:02] <grrrit-wm>	 (03PS12) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[22:39:32] <Krenair>	 Guess I just need to work out where to draw the "too slow" line
[22:55:32] <mooeypoo>	 hah
[22:55:49] <mooeypoo>	 Krenair, well, you can set up the number of cores and memory size in the VM settings
[22:55:55] <mooeypoo>	 make it slower/faster
[23:00:27] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make MWGalleryInspector wider [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134856 (owner: 10Esanders)
[23:02:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make MWGalleryInspector wider [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134856 (owner: 10Esanders)
[23:05:49] <James_F>	 Krenair: Pick an arbitrary default and we can always tweak it in future. :-)
[23:07:30] <Krenair>	 var s = +new Date(); this.doc = ve.createDocumentFromHtml( this.originalHtml ); /* Anything worse than 0.001 seconds per byte triggers an edit notice */ if ( ( new Date() - s ) / data.content.length > 0.001 ) { data.notices.push( 'Too slow!' ); }
[23:07:41] <grrrit-wm>	 (03CR) 10Jforrester: "I believe the concerns have been resolved…" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132449 (owner: 10Jforrester)
[23:08:41] <Krenair>	 (0.001 was a completely random arbitrary variable that appeared to work on the first test for some reason)
[23:09:12] <James_F>	 >> var s = +new Date(); this.doc = ve.createDocumentFromHtml( this.originalHtml ); /* Anything worse than 0.001 seconds per byte triggers an edit notice */ if ( ( new Date() - s ) / data.content.length > 0.001 ) { data.notices.push( 'Too slow!' ); }
[23:09:20] <James_F>	 …
[23:09:26] <James_F>	 Ah, ecmabot is dead?
[23:19:48] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616#c6 (10James Forrester) 5PAT>3RES/FIX Still fixed.
[23:37:14] <Krenair>	 James_F, or at least, worked on my laptop. My desktop is apparently too slow...
[23:47:56] <James_F>	 Krenair: Ha.
[23:48:28] <Krenair>	 Doing some entirely unscientific testing to find a decent threshold where VE begins to become a pain to use
[23:49:54] * James_F  nods.