[00:02:46] (03PS3) 10Jforrester: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 [00:05:20] (03PS2) 10Jforrester: Dump raster support (unuseful) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 [00:06:16] (03PS4) 10Jforrester: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 [00:23:46] I think I accidentally slowed the damn thing down to the point where it doesn't load anything at all [00:23:59] * James_F grins. [00:27:49] 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563 (10James Forrester) p:5Unprio>3Normal a:5Moriel Schottlender>3Ed... [00:29:40] (03Abandoned) 10Jforrester: [WIP] Add support for
s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120578 (https://bugzilla.wikimedia.org/51009) (owner: 10Jforrester) [00:37:33] (03CR) 10Jforrester: "Things that should be fixed:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [00:37:41] (03CR) 10Jforrester: [C: 04-1] Editable blockquotes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [00:46:58] (03PS1) 10Jforrester: Convert toolbar structure group from bar to list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 [00:47:57] (03PS1) 10Jforrester: Convert toolbar structure group from bar to list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134986 [00:48:25] (03CR) 10Jforrester: "(Have now done the simplified toolbar in I84a4d948ae – thoughts?)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [01:25:04] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616#c7 (10ryasmeen) Verified the fix in Betalabs and test 2 [01:29:48] 3VisualEditor / 3Editing Tools: VisualEditor: When an image has a full size which is smaller than the default size, it does not set the default size to the value of full size - 10https://bugzilla.wikimedia.org/62293#c15 (10ryasmeen) verified the fix in test2 [01:31:49] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Switching to edit source mode throws TypeError: Cannot read property 'css' of null and TypeError: Cannot read property 'each' of null for a specific case - 10https://bugzilla.wikimedia.org/65557#c6 (10ryasmeen) Verified the fix on test 2 [01:39:33] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot close Media Settings dialog, empty caption field and the TypeError: TypeError: node.getCaptionNode is not a function appears - 10https://bugzilla.wikimedia.org/65568#c9 (10ryasmeen) Verified the fix in test2 [05:36:03] 3VisualEditor: [Regression] Categories and DEFAULTSORT meta items getting modified to strip default whitespace? - 10https://bugzilla.wikimedia.org/65647#c3 (10NicoV) Other example https://fr.wikipedia.org/w/index.php?title=Mines_de_Ranci%C3%A9&diff=104031209&oldid=97118583 [08:10:44] (03PS1) 10Esanders: Move DesktopContext.css into desktop module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135001 [09:54:33] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c4 (10NicoV) It's still happening, several times a day on frwiki. If you need examples, there's a... [10:52:35] (03PS1) 10Esanders: Register target globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 [10:52:37] (03PS1) 10Esanders: Add createSurface to base target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 [10:52:41] (03PS1) 10Esanders: Used registered target, instead of ve.init.Target. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [10:52:43] (03PS1) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [10:54:14] (03CR) 10jenkins-bot: [V: 04-1] Used registered target, instead of ve.init.Target. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [10:54:16] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [11:23:48] Krinkle|detached: edsanders what is VisualEditor/VisualEditor and how does it corresponds to extensions/VisualEditor? [11:24:01] jdlrobson, it's VE core [11:24:10] extensions is all the MW specific stuff [11:24:24] and loads VE/core as a submodule in lib/ve [11:25:21] edsanders: so how do i update the submodule to point at https://gerrit.wikimedia.org/r/#/c/135001/1 ? [11:25:34] i haven't used submodules in a while so i'm pretty rusty [11:29:25] jdlrobson, we have a script for it [11:29:36] I usually get Roan or James to do it :) [11:30:10] if you just want to use the code while it's in review [11:30:22] :-S [11:30:24] just cd into lib/ve and do git review -d as usual [11:30:53] oh that's not too hard then :) [11:30:54] * jdlrobson tries [11:31:17] right, I'm off [11:31:30] hit me up on hangouts if you need anything urgent [11:35:26] so edsanders that seems to fix some of the problems - i'll keep poking to fix the other ones :) [12:28:20] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674 (10Quim Gil) 3NEW p:3Unprio s:3normal a:3None Seasoned Catalan Wikipedia editors are finding strange diffs done by new editors using VisualEditor. See these examples: https:/... [13:02:33] 3VisualEditor / 3ContentEditable: VisualEditor: Upload-by-insertion of images via copy-paste - 10https://bugzilla.wikimedia.org/37932 (10Florian) [14:40:28] Hello i want to ask how to use the parsoid for the visual editor because i did it with the nodejs way [14:42:18] kyriakoshadj, You "did it with the nodejs way"? [14:42:41] i download nodejs and git [14:43:01] but it wanted to be in extensions folder of the mediawiki [14:44:00] That shortcut parts the channel in XChat. Sigh. [14:44:15] kyriakoshadj, so the "Parsoid" extension needs to be in the MediaWiki extensions folder, yeah [14:44:23] yes [14:44:34] you also need parsoid itself [14:44:48] which .. I think you can put anywhere. I have mine under extensions/VisualEditor though [14:45:26] so what can i do [14:46:37] Well you need to get parsoid itself from the deb repository or git [14:46:52] I would run "git clone https://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid" from the VisualEditor extension directory [14:47:11] Then see https://www.mediawiki.org/wiki/Parsoid/Setup#JS_dependencies [14:47:21] ok thanks [14:50:16] kyriakoshadj, if you are running Debian or Ubuntu, I'd recommend to use our package [14:50:30] https://www.mediawiki.org/wiki/Parsoid/Setup#Ubuntu_.2F_Debian [14:50:32] Windows 8 x64 Enterprise [14:50:51] okay, then it's all manual [14:50:58] https://www.mediawiki.org/wiki/Parsoid/Setup#Windows_Setup [14:51:14] @Krenair still not working [14:51:26] ? [14:51:38] @gwicke i have done that and not working [14:52:42] if you believe that it's a parsoid issue, then follow https://www.mediawiki.org/wiki/Parsoid/Troubleshooting [14:52:57] otherwise, check the VE instructions [14:53:30] @gwicke i have double checked the VE instructions and there is not parsoid problem [14:54:20] So are you saying Parsoid is working or it isn't working? [14:56:09] is working but not the way VE wants [14:56:32] What is happening? [15:00:49] Krenair it need a Parsoid.php [15:01:49] kyriakoshadj, you need to install the Parsoid extension I mentioned earlier [15:03:27] yes i installed it and one minute to copy the upload the image [15:06:03] https://www.filepicker.io/api/file/SAv5VRlxRDmq5czFJN8t [15:06:34] Krenair this is the image of the errors [15:07:38] @Krenair are you there? [15:08:36] kyriakoshadj, you didn't install it [15:08:51] you need to download the Parsoid extension and put it in your MW extensions folder [15:09:03] yes i put it [15:09:11] F:\wamp\www\thelifewiki\extensions\parsoid [15:09:38] @Krenair [15:10:27] I don't know how PHP works on Windows. Maybe you need to change the include line to use backslashes instead of forward ones? [15:14:05] i dit it and no [15:33:15] (03PS1) 10Alex Monk: Attempt to detect slow machines and show an edit notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135046 (https://bugzilla.wikimedia.org/50518) [15:37:37] (03CR) 10Alex Monk: [C: 04-2] "Obviously, this is not ready for merging. I would like feedback on the general idea however." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135046 (https://bugzilla.wikimedia.org/50518) (owner: 10Alex Monk) [16:07:21] Heya. [16:07:50] * Krenair waves [16:09:58] jdlrobson: Did you say that VE has moved from alpha to beta on Mobile? [16:10:16] hey James_F: there is a story to do that this iteration if we get round to it [16:10:42] jdlrobson: Right, OK. Awesome! [16:10:57] jdlrobson: Did Ed's fiddling with DesktopSurface fix things for you? [16:11:20] James_F: i made a little bit of progress but to be honest i think it's going to be a hell of a lot easier when i'm back in the office Tuesday [16:11:45] jdlrobson: Yeah. [16:11:48] (Sorry. :-() [16:14:12] Krenair: BTW, if you want a change of scene https://bugzilla.wikimedia.org/show_bug.cgi?id=50964 is a bit different and you probably know how to fix it instantly. :-) [16:14:44] Krenair: (TemplateData, so PHP – need to give TD PageProps for the redirect's target if the template is a redirect.) [16:16:11] I still have https://bugzilla.wikimedia.org/show_bug.cgi?id=49044 to look at [16:16:28] But after that I will need other stuff, so I'll put this on my list [16:18:00] * James_F nods. [16:18:01] Cool. [16:18:13] James_F, comment 3 mentions Parsoid changes.. [16:18:34] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateData is not available to VisualEditor if the template is a redirect - 10https://bugzilla.wikimedia.org/50964 (10James Forrester) a:3Alex Monk [16:20:31] Krenair: See comment 5, though; it can all be fixed with part 1 of Krinkle's suggestion. [16:23:03] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10James Forrester) p:5Unprio>3High [16:23:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617 (10James Forrester) p:5Unprio>3High [16:23:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10James Forrester) p:5Unprio>3High [16:38:32] (03CR) 10Krinkle: [C: 04-1] "Be sure to dereference on teardown/destroy." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 (owner: 10Esanders) [16:40:03] James_F: So... want me to drop everything and have a migration sprint? [16:40:43] I'll need someone to review/merge of course (could be you) [16:41:20] Krinkle: I think we may have to push back the jQuery 1.11 change a little. [16:41:29] Yeah, I know. [16:41:34] Krinkle: People just aren't remotely ready. [16:41:45] I don't like the plugin approach. I'd rather just hold back the removal until we're ready. [16:41:57] So respond on the thread rather than ignoring it? [16:42:15] Also, *cough* RL functional dependencies *cough*. [16:42:20] Which thread? bug1, bug2, gerrit-removal, gerrit-plugin or wikitech? [16:42:25] "It will be ready today, maybe tomorrow". [16:42:28] Wikitech-l. [16:44:08] Note though, that so far all things I've seen from migrate were either actual bugs being silenced (the one in VE/oojs-ui about computing a hidden frame) - which I havent' seen anywhere else but on oojs-ui. And in other cases very minor mistakes. These features have been deprecated for a looong time, the traffic I'm seeing in the notices are very minimal. Nothing compared to legacy.wikibits or [16:44:08] mw.log.deprecate [16:44:30] LIke $.browser or $.live() [16:45:00] Sure, easy fixes are easy, but they still need doing. [16:45:13] ain't that the truth [16:45:37] (And yes, if you write them I'll merge them, but first RLFuncDeps kthxbai. ;-)) [16:46:29] How do I get the version of the transclusion dialog that's in VE on beta.wmflabs.org? I did $wgVisualEditorEnableExperimentalCode = true; but still not seeing it, wondering what I'm missing :) is there another branch somewhere or something? [16:47:24] mvolz: What bit is "missing"? [16:47:40] mvolz: Do you mean some of the buttons don't show up in the dialog? [16:48:19] yes [16:48:35] basically all the cite functions [16:48:48] Oh, right, the cite menu is missing? [16:48:57] You need to define a special message for that to appear. [16:49:01] aha [16:49:05] See en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json [16:49:09] ok thanks [16:49:10] will do [16:49:14] https://www.mediawiki.org/wiki/VisualEditor/Citation_tool is the documentation. [16:49:18] A bit hidden, sorry. [16:49:21] excellent, thank you [16:50:46] James_F: well, I think we've got ourselves a textbook example of (relatively simple) frontend dev that needs doing that simply is not going to get done unless people get assigned to it. It's too generic for people to feel responsible, and not breaking enough (yet) that people freak out. [16:51:17] Krinkle: If you try to break the cluster you'll just get reverted, however. greg-g is quite clear on that. :-) [16:51:31] I'm not suggesting that [16:51:45] I'm saying nobody is going to do a one line fix in LQT unless it's horribly broken or someone gets assigned to do it. [16:51:56] By the almightly powers that be. [16:52:08] Yeah. I asked S to make sure someone gets the LQT ones done. [16:52:16] But the wider point is true. [16:52:30] * greg-g looks aroun [16:52:30] d [16:52:34] The only other way it will happen is when volunteers get around to it or random people running into it and wanting to scratch the itch. [16:52:50] 3VisualEditor: Small text can get even smaller - 10https://bugzilla.wikimedia.org/65682 (10Elitre) 3NEW p:3Unprio s:3normal a:3None At the bottom of that diff you can see I copypasted some text between near other words which were already small, causing tags galore (it reminded me of bug... [16:54:43] Krinkle, is there grunt in TemplateData extension? doesn't work for me [16:55:13] (03CR) 10Krinkle: "If we're unable to test this I recommend going with just binding to 'paste' (which is what we always did in non-msie browsers and will not" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [16:55:18] mooeypoo: There is not [16:55:47] Run Special:JavaScriptTest/qunit in the browser for unit tests, and for linting use whatever is running in your editor or run "jshint ." from the command line [16:56:11] Maybe we should set it up. [16:56:17] But anyway. [16:56:21] * James_F wanders over to The Room. [16:56:34] Krinkle, yeah, I created new tests and used jshint in the editor, but jenkins still hates me. [16:57:06] mooeypoo: link? [16:57:28] Krinkle, speaking of which, this is still WIP, but I'd love it if you could take a look and see if I'm in the right track. I refactored the editor to use a model/view separately [16:58:04] Krinkle, oh, the errors are understandable -- I have double quotes in test json strings instead of single quotes (my fault) but it was annoying I didn't have anything to catch it before I sent to review. [16:58:06] anyways: https://gerrit.wikimedia.org/r/#/c/134928/ [16:59:02] Krinkle, I hope my event usage is not too convoluded [16:59:03] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateData is not available to VisualEditor if the template is a redirect - 10https://bugzilla.wikimedia.org/50964#c8 (10Krinkle) (In reply to Krinkle from comment #3) > Both VE and TemplateData should address this in their own way. Both parties > need t... [16:59:30] mooeypoo: Hm.. looks like genuine errors from jshint [16:59:32] https://integration.wikimedia.org/ci/job/mwext-TemplateData-jslint/108/console [16:59:39] Are you not getting those locally? [16:59:44] Krinkle, aye, they are, i'll fix them, but they're not showing locally [16:59:47] Maybe it's not picking up the jshintrc config? [16:59:53] also make sure you're runing 2.5.0 [16:59:58] hmmm [17:00:00] (npm install -g jshint) will upgrade it to that [17:13:37] (03CR) 10Krinkle: [WIP] Refactor TemplateData Editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (owner: 10Mooeypoo) [17:16:45] (03CR) 10Krinkle: [WIP] Refactor TemplateData Editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (owner: 10Mooeypoo) [17:19:26] (03PS1) 10Alex Monk: Allow following of redirects via API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/135064 (https://bugzilla.wikimedia.org/50964) [17:20:41] (03PS1) 10Alex Monk: Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) [17:20:55] James_F|Away, are we registering for wikimania + hackathon, right? [17:23:25] Krenair: Hm.. interesting, looks like &redirects already worked (just didn't expose the from>to resolved values in the result yet, but it did work) [17:23:35] I figured it would require it being listed in the params section first, but it just gets it somehow [17:23:50] " redirects - Automatically resolve redirects " [17:23:57] ApiPageSet adds it [17:23:58] Yeah, it did [17:24:07] So you're overriding the description for that parameter now [17:24:19] ApiPageSet just checks mParams['redirects'] (I looked into how ApiQuery does it earlier) [17:24:32] public function getParamDescription() { [17:24:32] return $this->getPageSet()->getParamDescription() + array( [17:24:38] oh, right. yeah. [17:24:44] public function getAllowedParams( ) { [17:24:44] return $this->getPageSet() [17:24:49] etc/ [17:24:57] So the change can be reduced a little bit. [17:24:59] Looks good otherwise. [17:25:16] (03PS2) 10Alex Monk: Allow following of redirects via API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/135064 (https://bugzilla.wikimedia.org/50964) [17:25:19] fixed [17:25:39] (I actually wrote what has ended up as PS2 first and tested it, then made what became PS1 without testing just before commit) [17:25:59] mooeypoo: Yes. The full-whammy one. [17:26:12] (03CR) 10Krinkle: "The "redirects" parameter is already registered by ApiPageSet (just like "titles" is already), no need to repeat here. We just weren't han" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/135064 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [17:28:47] Krenair: btw, might want to do "converttitles" as well. That one is also exposed in the api help already and works, but its results are not included [17:29:11] * action=templatedata * [17:29:11] redirects - Automatically resolve redirects [17:29:11] converttitles - Convert titles to other variants if necessary. [17:29:21] See ApiQuery#outputGeneralPageInfo [17:29:39] I'm not sure about the others (interwiki, badrevids) [17:29:39] Krinkle: So Template:X for Modèl:X? [17:29:59] James_F: No, I think this is language converter [17:30:12] Oooh, script variants not title variants. [17:30:19] something silently handled by ApiQuery normally, but since this is its own module you have to enable it explicitly. The logic itself is being resused. [17:30:22] yeah [17:32:08] Krinkle, I don't intend to do those in this commit. [17:32:12] sure [17:32:30] (03CR) 10Krinkle: [C: 032] Allow following of redirects via API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/135064 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [17:32:50] (03Merged) 10jenkins-bot: Allow following of redirects via API [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/135064 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [17:33:42] And the VE side of this was pretty much a duplication of the normalisation code. I should probably have just combined the two lists or moved the code out into a function or something [17:34:44] (03PS5) 10Krinkle: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [17:36:19] (03CR) 10Krinkle: "Hm.. not sure if we should have these in the repository. We'll need to be extra careful about not letting them go stale. I was thinking ma" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [17:54:46] Krinkle: Re. the CSSJanus thing, I asked whether it was possible to generate the RTL sheets on the fly inside the demo. Ed didn't seem to want to discuss the option… [17:55:11] Client-side? [17:55:15] No, I wouldn't would that either [17:55:31] I mean the same way we generate oojs-ui.js and oojs-ui.css in oojs-ui [17:55:39] generated and on disk, but in dist/, and not in the repo [17:55:43] grunt build [17:56:07] Yes, but demos don't currently live in a distribution, they're meant to hook directly in [17:59:05] 3VisualEditor: "Edit" button for Visual Editor does not appear in IE 9 on Vista - 10https://bugzilla.wikimedia.org/65688 (10Tom Hart) 3UNC p:3Unprio s:3normal a:3None There is no Edit button in IE 9 on Vista, so I cannot bring up the Visual Editor. Only the Edit Source button appears. STEPS: 1. Launch... [18:05:03] 3VisualEditor: "Edit" button for Visual Editor does not appear in IE 9 on Vista - 10https://bugzilla.wikimedia.org/65688#c1 (10James Forrester) 5UNC>3RES/DUP IE9 is blacklisted as it doesn't work yet, sorry. *** This bug has been marked as a duplicate of bug 50085 *** [18:05:04] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085#c1 (10James Forrester) *** Bug 65688 has been marked as a duplicate of this bug. *** [18:07:07] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reprod... [18:11:51] Krenair: Did you want to re-do https://gerrit.wikimedia.org/r/#/c/135065 for speed or are you happy to merge? [18:12:33] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3e... [18:12:34] s/speed/code niceness/ [18:12:52] (03CR) 10Krinkle: Follow redirects when looking up template data (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [18:13:31] Krenair: with the merging of normalised/redirects what you said earlier, what do you mean by that? [18:13:37] the loops on VE's side? [18:13:48] Krinkle: I assumed so. [18:14:06] I guess you could loop over something like var map = redirects.concat(normalised); [18:14:12] maps* [18:14:29] there's gonna be a third one [18:16:34] (03CR) 10Krinkle: Follow redirects when looking up template data (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [18:17:52] (03PS3) 10Jforrester: Dump raster support (unuseful) and assert SVG works before loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 [18:19:03] 3VisualEditor / 3Editing Tools: Raster icons missing from VE toolbar - 10https://bugzilla.wikimedia.org/65271#c4 (10James Forrester) 5REO>3RES/WON (In reply to Thiemo Mättig from comment #3) > (In reply to James Forrester from comment #2) > > We do not intend to load raster icons in VisualEditor. > > Yo... [18:22:33] (03CR) 10Jforrester: Add ability to put a header at the top of a toolGroup pop-up (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [18:25:44] RoanKattouw: They let you have your laptop? [18:27:48] A few others have a laptop out [18:27:53] Many more have tables and phones out [18:28:01] And I'm sitting down inside now as opposed to standing on the sidewalk [18:28:04] So work time [18:28:11] Unfortunately that means annual review paperwork [18:28:22] Oh look they just called #7 [18:28:24] This thing is moving [18:28:59] That helps. :-) [18:29:00] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/132353/ CR first? [18:29:03] Gosh. [18:29:07] The US consulates won't let you take any electronic devices in, including watches, phones, latops, … [18:29:20] I know [18:29:26] I've been to the US consulate in Amsterdam [18:29:40] That experience was about on par with this one [18:29:47] Oh dear. :-) [18:29:57] I mean the wait was less bad [18:30:27] But standing in line on a public sidewalk in SF in May is better than standing in line on a square in Amsterdam in February during the Great European Cold Snap of 2012 [18:30:53] True. [18:31:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: Need to refresh to see category tree and updated footer on category page - 10https://bugzilla.wikimedia.org/64239#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal Sounds like the same problem as for File: pages. [18:31:09] Thankfully none of your fingers fell off, so we still wanted you at the end of the process. :-) [18:31:42] Exactly [18:31:58] Well, "wanted". "Put up with", perhaps. [18:32:20] Also this place is walking distance from where I live (Montgomery & Bush) [18:32:43] I didn't have to get in a car at 6am this morning and drive in rush hour traffic with snow [18:33:06] Let alone put on gloves for the 3-meter walk from the door to the car [18:33:19] 3VisualEditor / 3MediaWiki integration: VisualEditor: Button to initiate UploadWizard and insert image on completion - 10https://bugzilla.wikimedia.org/38030 (10James Forrester) a:5Rob Moen>3None [18:33:20] 3VisualEditor / 3Editing Tools: VisualEditor: Table of Contents should be a draggableNode and insert __TOC__ as needed - 10https://bugzilla.wikimedia.org/49994 (10James Forrester) a:5Rob Moen>3Ed Sanders [18:33:20] 3VisualEditor / 3Editing Tools: VisualEditor: Using up-arrow to scroll lets you put the cursor under the toolbar - 10https://bugzilla.wikimedia.org/48787 (10James Forrester) a:5Rob Moen>3Ed Sanders [18:33:20] 3VisualEditor / 3Editing Tools: VisualEditor: "Clear formatting" should never be highlighted - 10https://bugzilla.wikimedia.org/58371 (10James Forrester) a:5Rob Moen>3Ed Sanders [18:34:18] 3VisualEditor / 3MediaWiki integration: VisualEditor: Editor not triggered on system redirects - 10https://bugzilla.wikimedia.org/50877 (10James Forrester) 5ASS>3PAT [18:34:32] (03PS2) 10Alex Monk: Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) [18:34:48] (03CR) 10Catrope: [C: 032] Add check icon for Apply button in ActionDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132353 (owner: 10JGonera) [18:36:18] (03Merged) 10jenkins-bot: Add check icon for Apply button in ActionDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132353 (owner: 10JGonera) [18:36:23] Krenair: LGTM. Did you want also to refactor to use the same loop for normalisation and de-redirectification? [18:36:40] Was about to do this but read this: [18:36:41] there's gonna be a third one [18:36:51] I have no idea what he was talking bout [18:37:12] Krenair: Krinkle often makes mysterious comments and then disconnects from IRC. It's his way of testing whether or not we love him. (We don't. ;-)) [18:37:37] I think he means we'll be adding another list of stuff to concat onto it [18:37:54] (PageSet has a few of these redirects/normalised cases) [18:38:46] (03PS1) 10Jforrester: Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135079 [18:39:15] (03PS2) 10Catrope: Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134748 (owner: 10JGonera) [18:39:24] Ha. Got ahead of me. :-) [18:39:44] James_F: I hijacked Juliusz's VisualEditor.php change :) [18:39:59] (03Abandoned) 10Catrope: Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135079 (owner: 10Jforrester) [18:40:08] RoanKattouw: Badly. [18:40:14] ? [18:40:31] RoanKattouw: You should also mention local changes. [18:40:38] * James_F fixes and merges. [18:40:40] I did [18:40:46] Second non-blank line of the commit msg [18:40:50] Oh. [18:40:54] I'm totally blind to that. [18:41:06] Local changes always go below the import, don't they? [18:42:03] (03PS3) 10Jforrester: Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134748 (owner: 10JGonera) [18:42:08] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134748 (owner: 10JGonera) [18:42:37] Maybe? I don't know [18:42:39] Whatever you want [18:42:46] Hmm I should probably also do my expense reports [18:43:04] WMF owes me something like $5k by now [18:43:10] RoanKattouw: *cough* annual review paperwork *cough* :-) [18:43:13] Yeah and that [18:43:30] Trying to come up with people to nominate that aren't on my (quite broadly defined) team [18:43:33] Taking suggestions [18:43:34] I should do Wellness. It's definitely ~1.5k now. [18:43:54] RoanKattouw: I'd suggest Juliusz, Greg and Bryan. [18:43:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (a42143c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134748 (owner: 10JGonera) [18:44:02] Krenair: there's this thing called dinner. [18:44:04] Yeah I did wellness a month ago, apparently you can pre-expense up to the full $1800, and they'll just set up a standing reimbursement for $150/month [18:44:04] Magically appears each day making me disconnect from irc at an unforeseen moment. [18:44:08] Krenair: the third one is converttitles [18:44:09] (and your accrual the first time) [18:44:25] Krinkle: For most humans dinner isn't unexpected. :-) [18:44:31] Krenair: ApiPageSet has two more in addition to those three (interwikis, badrevids), but I'm not sure about those. As they aren't exposed through an api paraemter. [18:44:31] Hmm [18:44:35] Krinkle: And "AFK" doesn't take that long to write. [18:44:56] RoanKattouw: Your ops/deployment stuff is the biggest non-VE thing you do, right? [18:45:00] Krenair: converttitles is a priority because we already expose it, and yields no warning, but a result that has changed titles that you can't map to on the client. [18:45:02] I guess so [18:45:04] Krinkle, yes, I had dinner as well. I wasn't moaning that you'd disappeared. [18:45:04] That's a good point [18:45:13] (That was James.) [18:45:38] Krinkle: Blame me, not Krenair. He's innocent, I was the one needling you (to great effect, it turns out). [18:45:55] Krenair: I know, I'm replying to you because you asked what the myserious third one is [18:46:01] (not in so many words) [18:46:14] James_F: What's up? [18:46:15] Hmm, also Parsoid people aren't in the list that is defined as my team [18:46:27] RoanKattouw: I was counting them as part of it. [18:46:30] (03PS3) 10Alex Monk: Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) [18:46:44] James_F: They are not in that copy list of yours [18:46:44] Krinkle, Krenair: Yeah, I imagine we'll have a few areas where we'll need to make adjustments for language script conversion. [18:46:56] RoanKattouw: So I just noticed. Hmm. :-( [18:47:24] Krinkle: I was wondering where you'd got to with RLFuncDeps, given you've not answered the question directly for two days. :-) [18:47:33] James_F: He's working on it [18:47:51] We had a backchannel conversation about working around the fact that existing infrastructure makes it difficult to send the right data to the client [18:47:59] And decided to just send it as a string [18:48:06] Fun. [18:49:09] James_F: Do you want me to put Scott down as one of my nominees or do you want me to assume he'll be counted as part of my team? [18:50:29] RoanKattouw: cscott_away says that the Parsoid team hasn't discussed. [18:50:34] OK [18:54:06] (03CR) 10Krinkle: Follow redirects when looking up template data (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [18:57:27] (03PS4) 10Alex Monk: Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) [19:22:41] mrr. [19:25:51] >>> n = undefined; +n === +n [19:26:05] No ecmabot-wm? [19:40:59] RoanKattouw, ^ [19:41:17] Looks like the cron that keeps it up disappeared. Fixed. [19:41:30] >>> n = undefined; +n === +n [19:41:30] RoanKattouw: (boolean) false [19:41:35] Thanks Krenair [19:41:59] RoanKattouw: I've granted you access to tools.ecmabot service group [19:42:08] cool [19:42:12] ssh tools-login; become ecmabot; cat crontab.txt [19:42:29] it should never need to be started but just in case [19:42:48] And thanks Krinkle [19:42:53] Damn you guys and your overly similar nicks ;) [19:44:03] RoanKattouw: I think your own nick is more similar to his (for some definition of similarity), but yeah, it's not fair you have to type 3 characters. [19:44:04] :P [19:44:27] nvm, yours is not more similar [19:44:31] though it does hae r, k, a [19:46:36] okay, there's something i must get off my chest before i explode [19:46:49] image wikitext is asinine. [19:46:51] That is all. [20:04:06] (03PS2) 10Esanders: Register target globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 [20:04:08] (03PS2) 10Esanders: Add createSurface to base target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 [20:32:33] 3VisualEditor / 3MediaWiki integration: VisualEditor: Use a hidden preference rather than cookie for logged-in users to remember hidebetawelcome - 10https://bugzilla.wikimedia.org/55551#c5 (10Tom Hart) Where is this preference to turn of the Welcome overlay located? I am always getting the "Welcome..." dialo... [20:52:52] (03CR) 10Krinkle: [C: 031] Register target globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 (owner: 10Esanders) [20:55:24] (03CR) 10Krinkle: "Hm.. need to verify this doesn't cause another dependency paradox like the one we have with ve.init.platform being called by ve.msg in ve." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [20:56:02] (03CR) 10Krinkle: Used registered target, instead of ve.init.Target. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [20:56:57] (03PS2) 10Jforrester: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [20:59:00] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [21:00:28] (03CR) 10Esanders: "Blockquote isn't really common enough to warrant such a high profile keyboard shortcut. Also I don't think you'd ever reasonably want to n" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [21:01:19] (03CR) 10Jforrester: "Sure, nesting them may not be something to solve now, but we should certainly not break badly on content with them, which this patch does." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [21:02:04] (03CR) 10Esanders: "The issue this fixes is the simple case of a blockquote on it's own being alienated. Anything more complex should probably be a separate b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [21:03:00] edsanders: Your patch goes from uneditable but unbroken to partial-editable and broken. This is a regression. [21:03:14] James_F, in what case? [21:03:27] edsanders: Nested blockquotes. Which exist in wikitext right now. [21:03:39] James_F, where and why? [21:03:51] Places, to multiply-indent content. [21:03:57] Better than :::Foo. [21:06:20] James_F, where? [21:06:42] edsanders: There's this site called Wikipedia. You may have heard of it. :-) [21:07:10] James_F, where? [21:07:22] * James_F sighs. [21:07:35] edsanders: You're not winning this argument through obduracy. [21:07:49] you're making claims but providing no evidence [21:07:55] show me an example [21:07:58] No, you are. [21:08:04] James_F, I've been looking at this category input for categories without pages thing... I'm tempted to base it on https://gerrit.wikimedia.org/r/#/c/134632/ (which is -2 until 1.23 release) because that looks like it might simplify things... [21:08:06] You're claiming such wikitext doesn't exist. [21:08:16] Whereas I've encountered it in the wild a few times. [21:08:26] Krenair: 1.23 is released… [21:08:37] 1.23? uh [21:08:46] James_F, and if you weren't the boy who cried wolf I wouldn't have to ask for proof [21:08:52] Krenair: As in, it's cut from MW so we can start depending on MW 1.24 code. [21:09:00] edsanders: Indeed. [21:09:07] Oh. Okay. [21:09:19] * Krenair should probably know this. [21:09:27] Krenair: :-) [21:10:01] (03CR) 10Jforrester: [C: 04-1] "Should bump our wfUseMw dependency (or whatever it's called) to 1.24" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [21:10:12] (03CR) 10Alex Monk: "since 1.23 got branched we can start depending on it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [21:10:30] Yeah, sorry, I meant to 1.23. [21:11:42] James_F, we already wfUseMW( '1.23' )... [21:11:48] 3VisualEditor / 3MediaWiki integration: Save dialog looks glitched after pressing the final save button on Firefox 29 on Windows 7 - 10https://bugzilla.wikimedia.org/65435 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3minor [21:11:54] Krenair: Hmm. In that case, let's just merge it. :-D [21:12:11] (03CR) 10Alex Monk: "we already wfUseMW( '1.23' )..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [21:12:12] Krenair: At the time the bug was written we were on 1.22. [21:14:03] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c10 (10Eran Roz) Yes, I would like if it would be possible to create an extra different menu, instead of adding all the tools to mislabelled "Insert". I think the new "Language" op... [21:22:48] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c11 (10James Forrester) (In reply to Eran Roz from comment #10) > Yes, I would like if it would be possible to create an extra different menu, > instead of adding all the tools to... [21:31:28] hi RoanKattouw do you know anything about a situation in recent times where VE because loses track of the session, for example https://saucelabs.com/jobs/f1cb23be98cb4c88973393ea6e3ad776 I see this in automated browser tests in Firefox particularly [21:32:17] RoanKattouw: I tracked it down as far as ve.init.mw.ViewPageTarget.js line 547 [21:33:52] badtoken [21:33:52] So yeah that means the session was lost [21:34:07] Don't we re-fetch in that case? [21:34:11] I am skeptical that this would be a VE issue [21:34:12] Yes we do [21:34:28] I think you can only get a token error if you get two failures in a row [21:34:33] A network trace would be quite useful [21:34:53] RoanKattouw: it seems to happen fairly consistently when switching between VE and wikitext editing modes in the same session. again, seen in Firefox not Chrome [21:35:54] hmm [21:36:13] I'll need to see the list of network requests the browser is making [21:36:21] RoanKattouw: in a few cases we lose logon completely (seen in the screencast here https://saucelabs.com/jobs/4b44f611b60c43628a95073c9ea67f79) [21:36:22] Firefox provides this in the inspector [21:36:36] RoanKattouw: But not in the automated testing system; [21:36:44] Right [21:36:57] If you could reproduce this in a human--driven browser that would be nice [21:37:07] RoanKattouw: OK, I haven't seen it when running locally, but I haven't tried real hard either. If can get a network trace I'll add that. [21:37:08] Because then we have a chance of figuring out what's going on [21:37:48] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text colour - 10https://bugzilla.wikimedia.org/52645#c7 (10Helder) (Copied from https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Textcolor) Hi there :-) Just wondering, why there is no feature for "coloring Text". In know, there is a... [21:37:56] I strongly suspect it's either the server losing the session (it's beta labs, so I wouldn't be surprised) or the browser losing the session cookie (it's a Selenium-driven browser, so I wouldn't be surprised) [21:38:28] RoanKattouw: we had a very similar issue in MobileFrontend not long ago https://bugzilla.wikimedia.org/show_bug.cgi?id=62614 where no one could repro but we could see 1000s of instances in prod logs. [21:38:33] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c12 (10Eran Roz) I can only think of "Language" and "Replace", so I guess we don't have enougth tools right now for a new menu. (or maybe the "advanced" options (page settings, cat... [21:39:05] prod logs? [21:39:14] Logs of tests or logs of actual production requests not related to tests? [21:39:16] RoanKattouw: EventLogging nothing about beta labs should make it more prone to losing session cookies. [21:40:44] RoanKattouw: relevant comment: https://bugzilla.wikimedia.org/show_bug.cgi?id=62614#c61 [21:41:14] RoanKattouw: so yeah, I remain suspicious that we're really doing tokens right 100% of the time [21:41:29] Well the thing is [21:41:40] We are not doing anything weird with tokens [21:41:46] We're handing them off to the MW core edit API [21:42:15] What I'd look for in the network trace is if the token changes every time it's fetched [21:42:24] If that's the case there's a session retention problem [21:44:46] RoanKattouw: so you'd want to see e.g. a network session from Firefox or Wireshark or something showing token handling then, and there's not anything in VE that will point toward further information? [21:46:17] Yeah exactly [21:46:26] In that last screencast you sent me, the user just gets logged out entirely [21:46:29] VE doesn't have the power to do that [21:46:44] Even if VE is mishandling tokens, the user wouldn't get logged out [21:47:06] RoanKattouw: yep, but it happens when switching edit modes and I don't see it under any other circumstances in any other extensions or whatever [21:47:21] Weird [21:47:51] Is there anything else that triggers it other than switching from VE to source editing? [21:48:24] RoanKattouw: the only test that triggers the badtoken situation is the edit-mode-switch test [21:48:38] chrismcmahon: Is it a new breakage? [21:49:06] James_F: fairly new, within the last say 2 weeks or so. [21:49:13] Hmm. [21:49:27] I know Krenair fixed a bug with the wrong article ID being sent for the edit mode switch. [21:49:33] But that should have had any impact on this. [21:49:57] RoanKattouw: speaking of only seen in VE, https://bugzilla.wikimedia.org/show_bug.cgi?id=65486 is it possible that some other db return msg. is triggering the "readonly" status here? [21:50:35] RoanKattouw: b/c if the db were really readonly I would be having a ton of other failures and I don't see them [21:55:30] Possibly [21:55:44] But again I'm pretty sure VE doesn't map these error messages in any way [21:55:51] So if you're getting 'readonly' it's coming from MW core [21:56:50] RoanKattouw: yeah, but I was thinking that only VE actually generates an alert or other notice (that I've seen anyway) [21:57:18] The normal edit page will also refuse your edit with the same message, but the message might be presented differently [21:57:46] yeah, that's what's funny, I haven't seen that, only from VE [21:58:29] RoanKattouw: anyway, that's my 30 minutes of questions :-) I'll file a BZ for the session stuff if only to track it for a while [21:58:40] OK [22:28:24] (03CR) 10Catrope: [C: 032] Register target globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 (owner: 10Esanders) [22:29:40] (03Merged) 10jenkins-bot: Register target globally [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135011 (owner: 10Esanders) [22:32:00] (03CR) 10Catrope: [C: 04-1] Add createSurface to base target (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:32:50] (03CR) 10Catrope: "@Krinkle: It's in the ve.ui.SurfaceWidget *constructor*, not in the main body of the file, so it's fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:33:00] RoanKattouw, so you'll have noticed that we can only register one target [22:33:18] which got me thinking about something like flow [22:33:28] Well [22:33:29] would the plan there be to have one target that creates multiple surfaces? [22:33:39] There should be a single target that manages everything [22:33:41] Yeah exaclty [22:34:35] 3VisualEditor: PageTriage UI appears after save - 10https://bugzilla.wikimedia.org/65702 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15467 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15467&action=edit PageTriage shown after saving edit. I've seen this a few times,... [22:34:46] (03CR) 10Krinkle: "No, it's not. The same applies to ve.msg, that's inside the method, not in the global scope. But anything exposed by a module should be im" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:35:10] (03CR) 10Krinkle: "(and yet it often fails in random race condions when getMessage is property of undefined)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:36:29] (03PS3) 10Esanders: Add createSurface to base target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 [22:36:57] (03CR) 10Esanders: Add createSurface to base target (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:40:25] (03CR) 10Esanders: "If you loaded a surface without a target you'd have many other problems (no paste rules or commands, for example)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (owner: 10Esanders) [22:40:36] (03CR) 10Catrope: Switch action=opensearch calls to list=prefixsearch where appropriate (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [22:40:41] (03CR) 10Catrope: [C: 04-1] Switch action=opensearch calls to list=prefixsearch where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [22:48:05] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Go to Insert>Re... [22:55:04] 3VisualEditor / 3Editing Tools: VisualEditor: The previous line is also getting highlighted while adding a reference list - 10https://bugzilla.wikimedia.org/65706#c1 (10ryasmeen) Steps to reproduce: 1.Open a page with VE 2.Go to the end of the page 3.Insert a reference list Observed Result: It is highligh... [23:02:12] (03CR) 10Esanders: "Everything has fill="#575757", these should be removed so they default back to black (the whole object already has opacity=0.75)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester) [23:03:18] 3VisualEditor / 3Editing Tools: VisualEditor: The previous line is also getting highlighted while adding a reference list - 10https://bugzilla.wikimedia.org/65706#c2 (10ryasmeen) This is happening in Chrome only not in Firefox [23:11:43] (03CR) 10Catrope: [C: 032] Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [23:13:22] (03Merged) 10jenkins-bot: Follow redirects when looking up template data [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135065 (https://bugzilla.wikimedia.org/50964) (owner: 10Alex Monk) [23:14:01] (03CR) 10Esanders: "Are we really that low on horizontal space (on Desktop) that this is required? We should keep common tools accessible, I think we need to " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [23:15:16] (03CR) 10Catrope: [C: 032] Convert toolbar structure group from bar to list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [23:15:29] Whoops canceled +2 [23:15:33] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateData is not available to VisualEditor if the template is a redirect - 10https://bugzilla.wikimedia.org/50964 (10Alex Monk) 5PAT>3RES/FIX [23:15:47] (03CR) 10Catrope: "Code looks fine, wisdom appears to be under discussion still" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [23:16:26] (03PS1) 10Esanders: Truncate undo stack before applying staged changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135129 [23:16:28] (03PS1) 10Esanders: Optionally allow undo while staging. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135130 [23:16:30] (03PS1) 10Esanders: WIP Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 [23:18:05] 3VisualEditor: seen in automated browser tests: Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10Chris McMahon) 3NEW p:3Unprio s:3minor a:3None No manual repro or network trace so far, this is for tracking VE loses user token: ht... [23:18:18] (03CR) 10jenkins-bot: [V: 04-1] Truncate undo stack before applying staged changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135129 (owner: 10Esanders) [23:23:35] 3VisualEditor: switching rapidly between VE and wikitext editor causes beta warning to reappear (many times) - 10https://bugzilla.wikimedia.org/65710 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15468 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15468&action=edit beta... [23:25:46] (03CR) 10Catrope: "Is this associated with a VE core commit?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134854 (owner: 10Esanders) [23:26:18] 3VisualEditor: switching rapidly between VE and wikitext editor causes beta warning to reappear (many times) - 10https://bugzilla.wikimedia.org/65710 (10Chris McMahon) [23:26:18] 3VisualEditor: seen in automated browser tests: Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c1 (10Chris McMahon) Note: a close look at the screencast of the logout instance shows the logout happens instantly upon clicking Edit source for... [23:26:20] (03CR) 10Catrope: [C: 032] Fix dependencies for eg-iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134676 (owner: 10Esanders) [23:27:07] (03CR) 10Catrope: [C: 032] Detect that a category is hidden when following a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134847 (owner: 10Alex Monk) [23:29:28] (03Merged) 10jenkins-bot: Detect that a category is hidden when following a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134847 (owner: 10Alex Monk) [23:32:52] (03PS2) 10Esanders: Truncate undo stack before applying staged changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135129 [23:32:54] (03PS2) 10Esanders: Optionally allow undo while staging. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135130 [23:32:56] (03PS2) 10Esanders: WIP Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 [23:33:50] 3VisualEditor / 3Editing Tools: VisualEditor: The "Undo" button remains active when the cursor in alternative text field inside Media Settings dialog - 10https://bugzilla.wikimedia.org/65713 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an image 3.... [23:34:35] (03CR) 10Catrope: [C: 032] Switch from Parsoid extension's styles to MediaWiki core's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134664 (owner: 10Jforrester) [23:35:04] (03CR) 10Catrope: [C: 032] Preserve veaction, vesection on special redirects to wiki pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) (owner: 10Mattflaschen) [23:36:22] (03Merged) 10jenkins-bot: Switch from Parsoid extension's styles to MediaWiki core's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134664 (owner: 10Jforrester) [23:36:57] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/115533/ should now be good to go (otherwise it'll duplicate rules, may indeed break things). [23:37:34] (03CR) 10Catrope: [C: 032] Remove media item styling moved to MW-core in I400336c12d. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [23:37:50] (03CR) 10Jforrester: "@Roan: Yes, I62e19d64b." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134854 (owner: 10Esanders) [23:38:56] (03CR) 10Catrope: [C: 032] Move DesktopContext.css into desktop module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135001 (owner: 10Esanders) [23:38:58] (03Merged) 10jenkins-bot: Preserve veaction, vesection on special redirects to wiki pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134788 (https://bugzilla.wikimedia.org/50877) (owner: 10Mattflaschen) [23:39:12] (03CR) 10jenkins-bot: [V: 04-1] Move DesktopContext.css into desktop module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135001 (owner: 10Esanders) [23:39:33] 3VisualEditor / 3MediaWiki integration: VisualEditor: Editor not triggered on system redirects - 10https://bugzilla.wikimedia.org/50877 (10James Forrester) 5PAT>3RES/FIX [23:39:48] (03CR) 10Catrope: Remove DesktopContext.css/js from core, leave in desktop (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134854 (owner: 10Esanders) [23:39:58] (03Merged) 10jenkins-bot: Remove media item styling moved to MW-core in I400336c12d. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [23:40:03] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c13 (10James Forrester) (In reply to Eran Roz from comment #12) > I can only think of "Language" and "Replace", so I guess we don't have > enougth tools right now for a new menu. >... [23:41:57] RoanKattouw: Coud you give a rough view on https://gerrit.wikimedia.org/r/#/c/135085/ ? [23:42:31] Looking [23:44:48] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester) [23:44:50] 3VisualEditor / 3ContentEditable: VisualEditor: Test whether paste binding needs "beforepaste" for MSIE compatibility - 10https://bugzilla.wikimedia.org/65714 (10James Forrester) 3ASS p:3Unprio s:3minor a:3None ve.ce.Surface.js only binds to paste; possibly it also needs to bind to beforepaste to wor... [23:45:03] 3VisualEditor / 3ContentEditable: VisualEditor: Test whether paste binding needs "beforepaste" for MSIE compatibility - 10https://bugzilla.wikimedia.org/65714 (10James Forrester) p:5Unprio>3High [23:46:31] (03PS3) 10Jforrester: Remove IE check (and possible compatibility) from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:46:37] James_F: Is that new bug in anticipation of https://bugzilla.wikimedia.org/show_bug.cgi?id=65714 and a possible revision to https://gerrit.wikimedia.org/r/#/c/132431/2 ? [23:46:41] (03CR) 10Jforrester: "@Timo: Done." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:46:43] Right.. [23:47:01] :) [23:47:02] Krinkle: :-D [23:47:12] Krinkle: Patience is a virtue. [23:47:44] I'm like nodejs, I don't get distracted, but I do (ever so briefly) handle incoming events whenever I yield for a sec. [23:48:01] * James_F hugs the oh-so-incredibly-lame Krinkle. :-) [23:48:07] One day we'll have atomic transactions in the third dimension [23:48:18] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c5 (10James Forrester) Ping on this bug again – do you need any support/advice/help? [23:48:48] 3VisualEditor: seen in automated browser tests: Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c2 (10Chris McMahon) I should have said: Note: a close look at the screencast of the logout instance shows the logout happens instantly upon cl... [23:52:20] 3VisualEditor / 3Editing Tools: VisualEditor:The image does not remain highlighted but the areas around it,after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15470 --> https://bugzilla.wikime... [23:52:58] (03PS4) 10Krinkle: Remove IE check (and possible compatibility) from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:53:05] Krinkle: I left some comments but I have no good advice for you just yet regarding the pile of FIXME comments in mediawiki.js [23:53:16] (03PS5) 10Krinkle: Remove IE check (and possible compatibility) from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:53:27] (03CR) 10Krinkle: Remove IE check (and possible compatibility) from beforepaste/paste event switch (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:53:35] (03CR) 10Krinkle: [C: 031] Remove IE check (and possible compatibility) from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:53:51] (03CR) 10Krinkle: "fixed space and used chain" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:55:03] (03CR) 10Jforrester: [C: 031] Remove IE check (and possible compatibility) from beforepaste/paste event switch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132431 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [23:57:19] (03PS4) 10Jforrester: Fix dependencies for eg-iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134676 (owner: 10Esanders) [23:57:32] (03CR) 10Jforrester: "PS4 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134676 (owner: 10Esanders) [23:57:40] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134676 (owner: 10Esanders) [23:59:13] (03Merged) 10jenkins-bot: Fix dependencies for eg-iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134676 (owner: 10Esanders)