[02:29:33] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c4 (10Andre Klapper) I asked because I'm wondering if this is another case of broken browser plugins (bug 52327)... [07:42:03] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c5 (10Quim Gil) The user hasn't answered yet. However, while bug 52327 is about "garbage" being injected in pages, that garbage consists at least in JavaScript chunks. In this case it... [14:36:51] Heya. [14:51:12] (03CR) 10Phuedx: [C: 031] "This certainly facilitates the dependant patch (Icd68ab91598ebac840c0fefdbcd53c27640a6a95) but I'd like Robmoen or a member of the VE team" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135328 (owner: 10Mattflaschen) [15:06:51] hey [15:08:33] Hey Krenair. [15:12:44] Hello [15:12:58] I need to add VisualEditor support to a skin that isn't vector based. How do I do that? [15:13:10] georgebarnick: Hey. [15:13:24] First step would be for me to put the skin on a server that can run VisualEditor but here is the skin: http://georgebarnick.com/refreshed-beta [15:13:39] Krenair: Do you think your notes are good to go? They looked fine to me… [15:13:43] It's http://enwp.org/mw:Skin:Refreshed 's next version [15:13:58] James_F, honestly I think what I have is fine, I just don't know how useful they are. [15:14:16] I would certainly like to point people looking for help getting skins to work with VE to them [15:14:18] Krenair: Should we copy them somewhere on MW.org then? [15:14:21] * James_F nods. [15:14:26] I guess, yeah [15:15:07] After writing what I ended up with, I thought this couldn't possibly be all we needed to write. But maybe it is.. [15:15:25] georgebarnick: Neat. [15:16:43] georgebarnick, can you set up a wiki with VE and the skin, then take a look at https://docs.google.com/a/wikimedia.org/document/d/1awG4IKujTFd72RJzr_4DVInKDO1BqRxRHbTnCHvYLr4/edit ? [15:17:31] we'll have to do that [15:19:43] Krenair: I'll move it to MediaWiki.org/VisualEditor/Skin_requirements if that makes sense? [15:20:55] James_F, sounds good to me [15:29:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Document what is needed in terms of support for custom MediaWiki skins - 10https://bugzilla.wikimedia.org/61500#c4 (10James Forrester) 5ASS>3RES/FIX I'm going to deem this fixed based on the details in https://www.mediawiki.org/wiki/VisualEditor/Skin_... [15:33:03] James_F, eh, VE-deploy-2014-05-29 for a wiki doc change? :/ [15:33:24] Krenair: Well, we just mark it against whatever deployment it relates to. :-) [15:34:18] Krenair: Otherwise I won't put it in the release notes. [15:34:27] heh, ok [16:14:47] Krinkle: Having fun with your Internet connexion? [16:15:54] James_F: Yep [16:15:56] It's not that bad actually. [16:15:58] Just been moving around a lot and spotty reception in the house. [16:16:00] Nice weather outsdie [16:17:04] Ah, nice. :-) [16:17:17] Krinkle: Will we have you do the KIT from the garden? :-) [16:18:45] James_F: Regarding td gui, it's really not ready. In my opinion it was too soon for mw.org as well. It still has breaking bugs, and the user interface is not yet up to what it should be. Someone being tech ambass, doesn't make that easier (unless it's per user opt-in) [16:19:11] Krinkle: So why not actually fix it rather than just say it's broken for 6 months? :-) [16:21:08] Very funny. But I don't have availability for user testing tdg, and sit down for a user interface draft. Right now the layout is still the initial iteration to expose the functionality. [16:21:27] Yes. And users who've used it say they're happy for it to go live. [16:21:44] And you're saying that we should veto community requests based on your vague and unspecified "I don't like it yet" claims. [16:21:45] I mean I could, but I just because I see a problem doesn't make me responsible for managing and fixing it. [16:21:59] Sure, but you are responsible for, say, filing a quick bug. [16:22:07] Actionable comments are helpful. [16:22:10] I have done that as well. [16:22:30] Last week [16:22:39] that is for 1 of 2 issues (the technical blockers) [16:22:49] Which only has one blocker, bug 60089. [16:23:08] James_F, wtf: http://i.imgur.com/QMGmAbp.png ? [16:23:16] edsanders: Blame Krenair. [16:23:26] Krenair, wtf: http://i.imgur.com/QMGmAbp.png ? [16:23:34] edsanders: It's https://bugzilla.wikimedia.org/show_bug.cgi?id=65702. [16:23:48] what is it, why is it, and why is it hurting my eyes [16:23:52] That's the PageTriage bar [16:23:58] edsanders: That my friend is (..) called Page curation [16:24:18] who is it shown to? [16:24:19] lol [16:24:23] Wait, that appears post-save? [16:24:26] Krinkle: Like all WMF projects, it's renamed now. [16:24:42] Krinkle: Yeah, Krenair's code blindly unhides it rather than only if it was visible at first. [16:24:54] edsanders: +sysops, +rollbackers and a few others. [16:24:56] Why might we start with a hidden bar? [16:25:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: PageTriage UI appears after save - 10https://bugzilla.wikimedia.org/65702 (10Alex Monk) a:3Alex Monk [16:25:31] (03PS2) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [16:25:40] (03CR) 10jenkins-bot: [V: 04-1] Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [16:25:51] Krenair: If you've not activated it I believe it's always present but hidden. Yay coding. :-( [16:26:00] Krinkle: And bug 60089 is PTR but hadn't been noted. [16:26:05] sounds efficient [16:26:10] Indeed. [16:27:37] huh. how do I activate/deactivate it? [16:28:06] (03PS3) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [16:28:14] Krenair: Go to Special:PageTriage I think. [16:28:19] Krenair: Or somesuch page. [16:28:26] Krenair: It sets a cookie or something ghastly. [16:28:36] edsanders: Down boy. Not our code to fix. :-) [16:28:50] ugh. [16:28:58] Indeed. [16:29:02] I'm here to create problems, not solutions [16:29:24] Well then, you're doing great. [16:29:26] 3MediaWiki extensions / 3TemplateData: TemplateData: Create an editor for template data (in the wikitext editor) - 10https://bugzilla.wikimedia.org/51734 (10Krinkle) [16:29:26] 3MediaWiki extensions / 3TemplateData: TemplateData: Creating TemplateData blocks should be direction neutral - 10https://bugzilla.wikimedia.org/50436 (10Krinkle) [16:29:27] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) [16:32:56] 3MediaWiki extensions / 3TemplateData: TemplateData: Store TemplateData in its own namespace ("Template data:") with a JSON content type and associated to the Template: namespace - 10https://bugzilla.wikimedia.org/54140#c4 (10James Forrester) p:5Normal>3High s:5normal>3enhanc Re-wording; this is bloc... [16:33:46] Krinkle: I think you're confused; the GUI fixes bug 50436, it's not waiting to be fixed in the GUI. [16:34:41] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle) [16:34:43] 3MediaWiki extensions / 3TemplateData: TemplateData: Design a user interface - 10https://bugzilla.wikimedia.org/65815 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None While from the processing point of view (backend of the frontend) it is pretty stable, the actual user interface is still mostly a proof o... [16:35:09] James_F: I didn't add or remote 50436 from the gui blocker [16:35:21] James_F: I changed it from being dependent on deployment to block deployment [16:35:31] I don't know whether it should block deployment, but it certainly doesn't make sense to depend on it [16:35:39] the act of deploying it doesn't make rtl work [16:36:12] Krinkle: Actually, it does in this case. [16:36:31] Because deploying the RTL-aware tool fixes the RTL-doesn't-work issue. [16:36:42] James_F, yeah, haven't been able to work out how to turn off the bar so it's hidden [16:36:56] 3MediaWiki extensions / 3TemplateData: TemplateData: Design a user interface - 10https://bugzilla.wikimedia.org/65815#c1 (10Krinkle) Created attachment 15486 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15486&action=edit Screenshot of current version. [16:37:05] James_F: Deploying the gui yes, but it was dependent on the bug for deploying td in general [16:37:20] Krinkle: No? [16:37:22] Like I said, I did not change its relation to the editor (it didn't have any) [16:37:26] Krinkle: TD already is deployed everywhere. [16:37:33] Krinkle: That was done in June last year. [16:37:37] Right [16:37:51] Well, then how is there an RTL issue in the current version? [16:38:18] It's wikitext, that never works in RTL, never has since the beginning of time. Any page with
or {{something is messed up, that's unfortunate snafu. [16:38:29] Krinkle: Because bug 60158 – deploying the GUI, which thus circumvents the RTL issue – isn't done yet. [16:38:37] I see [16:38:50] So it was the right way around. [16:39:21] Well, not really. That's if the bug was in Wikimedia, it was in TD. In TD it is already fixed. [16:39:33] But I'll swap it [16:39:37] OK. [16:39:48] * James_F stops swapping it back then. :-) [16:40:12] 3MediaWiki extensions / 3TemplateData: TemplateData: Creating TemplateData blocks should be direction neutral - 10https://bugzilla.wikimedia.org/50436 (10Krinkle) [16:40:27] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator should roundtrip unexpected JSON values - 10https://bugzilla.wikimedia.org/60089 (10James Forrester) a:3Moriel Schottlender [16:43:47] (03CR) 10Krinkle: [C: 04-1] "I forgot about this one too. Looks like a solid approach. Per comments on PS1 though." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [16:54:52] (03PS5) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [16:54:54] (03CR) 10jenkins-bot: [V: 04-1] Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [16:55:04] (03CR) 10Jforrester: Make TemplateDataGenerator use new types (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [16:57:08] (03PS6) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [16:57:23] (03CR) 10Jforrester: "PS6 is a rebase." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [16:57:30] (03CR) 10jenkins-bot: [V: 04-1] Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [17:12:59] 3VisualEditor: mw.o/test2wiki: beta warning cookie not being set - 10https://bugzilla.wikimedia.org/65821 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None On mediawiki.org in both Chrome and FF. Edit any page with VE, either logged in or not. Note that you get the beta warning. Save your edit. Edi... [17:14:56] 3VisualEditor: mw.o/test2wiki: beta warning cookie not being set - 10https://bugzilla.wikimedia.org/65821#c1 (10Chris McMahon) *** Bug 65710 has been marked as a duplicate of this bug. *** [17:14:56] 3VisualEditor: invoking VE multiple times causes beta warning to reappear over and over - 10https://bugzilla.wikimedia.org/65710#c1 (10Chris McMahon) 5NEW>3RES/DUP Update: Seen on test2wiki and thus probably on mw.o also. As logged in user *** This bug has been marked as a duplicate of bug 65821 *** [17:23:53] James_F, hey. Is Terry around today? [17:24:03] Krenair: Will go look. [17:25:28] 3VisualEditor / 3Mobile: VisualEditor on mobile doesn't load - 10https://bugzilla.wikimedia.org/65823 (10Jon) 3NEW p:3Unprio s:3normal a:3None Error: Unknown dependency: mediawiki.skinning.content.parsoid Error {stack: (...), message: "Unknown dependency: mediawiki.skinning.content.parsoid"} load.php... [17:26:07] (03PS4) 10Mooeypoo: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) [17:28:02] jdlrobson, hi [17:28:32] Do you have the 'Parsoid' *extension* installed on the wiki you're getting this error from? [17:30:44] Krenair: Not yet; have asked Oliver to get him to call you ASAP. [17:30:51] Krenair: s/call/content/ blegh. [17:31:08] contact, James_F? :) [17:31:24] Krenair: That too. [17:31:27] * James_F glares. :-) [17:32:12] 3VisualEditor: mw.o/test2wiki: beta warning appears for every edit - 10https://bugzilla.wikimedia.org/65821 (10Chris McMahon) [17:32:41] 3VisualEditor / 3Mobile: VisualEditor on mobile doesn't load - 10https://bugzilla.wikimedia.org/65823#c1 (10Alex Monk) Sounds like you just didn't install the Parsoid *extension* when it became required (used to be optional). [17:35:53] Krenair: No, mediawiki.skinning.content.parsoid is from core, not Parsoid.php. [17:36:36] I think I am confusing it with ext.parsoid.styles [17:37:11] 3VisualEditor / 3Mobile: VisualEditor on mobile doesn't load - 10https://bugzilla.wikimedia.org/65823#c2 (10James Forrester) 5NEW>3RES/INV mediawiki.skinning.content.parsoid is provided by MW-core as of Wednesday – see gerrit 130770. [17:37:17] (03PS5) 10Mooeypoo: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) [17:37:31] Krenair: Yeah, we switched mediawiki.skinning.content.parsoid in for ext.parsoid.styles removing the requirement on the Parsoid PHP extension (which wasn't helpful). [17:37:33] Krinkle, ^^ I generalized it to work on more than "just" the description [17:37:40] oh and I forgot to add the bug it fixes, ha [17:37:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617#c1 (10ryasmeen) Verified the fix on Betalabs [17:37:59] I found https://gerrit.wikimedia.org/r/#/c/130770/ and was thinking of pointing to it, but didn't know enough about the change [17:38:01] ah, ok [17:38:21] oh, James_F already did! well then, nevermind. [17:38:56] mooeypoo: :-) [17:38:56] 3VisualEditor: mw.o/test2wiki: beta warning appears for every edit - 10https://bugzilla.wikimedia.org/65821#c2 (10Chris McMahon) Actually, this is seen on test2 only so far. [17:39:34] hey Krenair [17:39:46] Krenair: i'm seeing this issue on beta labs [17:39:51] it's not invalid :) [17:40:13] James_F, ^ [17:40:34] Krenair: it should be an easy fix [17:40:41] 3VisualEditor / 3Mobile: VisualEditor on mobile doesn't load - 10https://bugzilla.wikimedia.org/65823#c3 (10Jon) 5RES/INV>3REO It's not invalid. This is on beta labs which mirrors production. It sounds like Parsoid is declaring a module that has not been set to the mobile target. We had this exact issue... [17:41:12] 3VisualEditor / 3Mobile: VisualEditor on mobile doesn't load - 10https://bugzilla.wikimedia.org/65823#c4 (10Jon) See also bug 64607 [17:46:45] jdlrobson: Hmm. In that case you'll need to adjust mobile to pull in that module? I thought we pulled it in for both… [17:50:31] James_F, am I missing something here? if not, this could probably be closed? https://bugzilla.wikimedia.org/show_bug.cgi?id=64303 [17:55:20] mooeypoo: Looking. [17:56:56] 3VisualEditor / 3Editing Tools: VisualEditor: The default size is not getting applied on an image after clicking on "Apply Changes" - 10https://bugzilla.wikimedia.org/64303#c2 (10James Forrester) 5NEW>3RES/INV Agreed; basic images have a default size of full size. [17:58:16] mooeypoo: (Agreed.) [17:58:26] mooeypoo: However, there are a bunch of issues with default alignment still. :-( [17:59:49] there are? [18:01:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c1 (10Moriel Schottlender) This should be resolved now following the change of default alignment. [18:01:25] I just tested this, and it seems to be good now ^^ [18:01:25] mooeypoo: Yeah. :-( [18:02:02] mooeypoo: https://www.mediawiki.org/wiki/VisualEditor:TestImageTypes - e.g. first four images are align:none but shown as alight:right. [18:02:24] mooeypoo: s/shown as/shown in the UI but not in CE as/ [18:02:40] mooeypoo: Probably just a small fix in the UI-CE code? [18:03:55] James_F, https://test2.wikipedia.org/wiki/User:Mooeypoo?veaction=edit <-- works here, though? [18:04:10] mooeypoo: … no? [18:04:32] oh oh I see it [18:04:33] mooeypoo: It shows as "Wrap text around this item" checked (wrong) and "Right" highlighted (also wrong). [18:04:36] hm [18:04:45] mooeypoo: Basic images have default alignment of none, yeah? [18:04:50] aye [18:05:06] But it's showing them as right. [18:05:09] indeed [18:05:11] damnit. [18:05:16] Whereas things that are actually right/left/centre show correctly. [18:05:24] hm. [18:05:33] Damnit. This was supposed to be fixed with Friday's fix. [18:06:17] (Friday's fix hit the wikis this morning, FWIW.) [18:07:18] (03PS7) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [18:07:47] James_F, but it should already be on test and mw.org no? [18:08:06] mooeypoo: Yes, it hit test2 and mw.org this morning. [18:08:15] * mooeypoo sighs [18:08:25] bah. [18:08:54] Eurgh. Rebasing 133944 and 113183 together isn't going to be much fun. [18:14:55] TrevorParscal: So… [18:16:56] 3VisualEditor / 3MediaWiki integration: VisualEditor mw.o/test2wiki: beta warning appears for every edit for some users - 10https://bugzilla.wikimedia.org/65821#c3 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal Yeah, this is a worrying regression, possibly due to the bug 55551 changes. (Saw breakag... [18:18:13] Krenair: ^^^ Could do with some poking at if you have a mo. :-( [18:24:30] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/134237/ needs your CR now, and then https://gerrit.wikimedia.org/r/#/c/132352/ (extra-careful-let's-not-break-all-dialogs-yet-again). [18:25:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: [? Regression wmf6] mw.o/test2wiki: beta warning appears for every edit for some users - 10https://bugzilla.wikimedia.org/65821 (10James Forrester) [18:31:27] James_F: why do images added to articles with VE use non-localised File: namespace name? :( https://pl.wikipedia.org/w/index.php?title=Par%C3%B3wka&diff=39532569&oldid=39493158 [18:36:07] MatmaRex: Parsoid bug. [18:36:44] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=51852 [18:43:28] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf7] Mobile VE doesn't load due to dependency on mediawiki.skinning.content. parsoid which is not available for mobile target - 10https://bugzilla.wikimedia.org/65823#c5 (10James Forrester) 5REO>3ASS p:5Unprio>3High s:5normal>3critic a:3Jam... [18:43:35] s/bug/feature/ in LTR languages ;) [18:44:17] gwicke: :-) [18:46:16] up to the communities though [18:46:34] as long as we get the value to use from some api we'll be happy [19:01:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: [? Regression] Beta warning appears for every edit for some users - 10https://bugzilla.wikimedia.org/65821#c4 (10James Forrester) Also getting reports of this on enwiki etc. – not great. [19:08:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: Use a hidden preference rather than cookie for logged-in users to remember hidebetawelcome - 10https://bugzilla.wikimedia.org/55551#c6 (10Alex Monk) (In reply to Tom Hart from comment #5) > Where is this preference to turn of the Welcome overlay located?... [19:08:36] (03CR) 10Krinkle: [C: 031] "Looks and works well. I see that the template description still changes to [object Object] though. Could be handled in a separate commit i" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [19:09:53] James_F, did you test https://gerrit.wikimedia.org/r/#/c/125914/10 ? [19:10:12] Krenair: Yeah; it seemed to work. But I wrote it a while ago… [19:10:35] I thought you weren't able to change hidden preferences at all... maybe I'm wrong though [19:10:56] Krenair: I'm pretty sure you are – don't we do this for other things? [19:11:08] Krenair: See the bug for Steven saying they do it for the GettingStarted stuff. [19:11:55] Oh okay so you're not adding it to $wgHiddenPrefs, just not adding anything to the Special:Preferences page... [19:12:02] Krenair: Yeah. [19:12:06] I think. [19:12:53] Did you check what happens to the actual preference change API request? [19:13:10] mw.user.tokens.get( 'optionsToken' ) might be undefined [19:13:58] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model - 10https://bugzilla.wikimedia.org/65829 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None This is a tracking bug for all the issues related with new Image model [19:14:18] Krenair: Wait, hmm. [19:14:23] Krenair: It should be editToken. [19:14:28] Krenair: optionsToken doesn't actually exist. [19:14:30] * James_F sighs. [19:14:32] ... [19:14:40] Krenair: I thought we fixed that in CR? [19:15:01] Krenair: Oh, wait, no, that was fixed in post-CR from Ed. [19:15:27] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model - 10https://bugzilla.wikimedia.org/65829 (10ryasmeen) [19:15:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615 (10ryasmeen) [19:15:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] While changing the Image Type to Frame/Basic, it automatically selects the alignment as Left when it is positioned at the right of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/65564 (10r... [19:17:15] Krenair: https://gerrit.wikimedia.org/r/#/c/132736/ [19:37:41] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf7] Mobile VE doesn't load due to dependency on mediawiki.skinning.content.parsoid which is not available for mobile target - 10https://bugzilla.wikimedia.org/65823#c8 (10James Forrester) 5PAT>3RES/FIX Should now be fixed. [19:40:51] (03PS1) 10Vikassy: [Browser-test]Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [19:41:15] (03PS2) 10Jforrester: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (owner: 10Vikassy) [19:42:49] mooeypoo: Did you see Krinkle's comment on https://gerrit.wikimedia.org/r/133944 (TemplateData GUI – Block object descriptions from being edited)? [19:44:25] (03PS6) 10Jforrester: Block object descriptions from being edited [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [19:45:56] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [19:45:58] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal a:3ryasmeen [19:49:30] James_F, oh. Bah. Okay, I can fix that. [19:49:50] James_F, dealing with default alignment atm, though. I think I have a fix. [19:49:52] mooeypoo: Would love to get TD fixed enough that we can deploy it. [19:49:57] mooeypoo: Aha. Awesome. :-) [19:52:36] (03PS3) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [19:56:11] (03PS4) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [20:13:54] (03PS5) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [20:14:19] (03PS6) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [20:15:14] (03PS7) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [20:35:21] (03PS7) 10Mooeypoo: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) [20:35:34] James_F|Away / Krinkle I added general template description too ^^ [20:35:45] now back to adventures in default alignment [20:38:33] mooeypoo: The UI is not tested by qunit right (shouldn't be I suppose, but just checking) [20:38:51] if it is we should add tests for this, but it isn't, so it's fine. [20:39:15] hm, there's a convoluded test I made, actually, so some of it is tested [20:39:46] more of a "find and check the inputs" thing. I can add the test. [20:40:22] Yeah, the model is still a bit intermixed between UI and data, I think it'd be nice if these data properties were not put into the UI DOM, but instead kept in the data records. That would make the test a bit more straight forward (eg. not require jquery ui) [20:40:38] Krinkle, that's what I do in the refactor [20:40:43] I'm ready to merge it. If you think it's relatively easy to add a test for it, go ahead though :) [20:40:48] Yeah, looking forward to it :) [20:41:11] sorry if I haven't been around lately to review stuff. I know you can and want to do it. Keep poking me. [20:41:24] Hm, I'm checking the tests now.. going back and forth between that and the default alignment [20:41:38] aye, no problems and thanks :) [20:51:56] (03PS13) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) [20:54:14] If anyone wants to review one of my 12 commits... [20:55:22] Krinkle, i have a quick way to test, but it's not perfect.. [20:55:42] then again, the entire version is not too perfect due to the non separation of UI and model [20:56:00] (03PS8) 10Mooeypoo: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) [20:56:26] (03CR) 10jenkins-bot: [V: 04-1] Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo) [20:57:05] Krinkle, is this allowed: https://gerrit.wikimedia.org/r/#/c/135587/1/modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolbarView.js [20:57:13] https://gerrit.wikimedia.org/r/#/q/owner:esanders%2540wikimedia.org+status:open+-label:Verified%253D-1+-label:Code-Review%253D-2,n,z [20:57:15] (elem.prop('autoUnhide', true) [20:57:21] will pick one in a bit [20:57:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c2 (10ryasmeen) This is still happening on Betalabs [20:57:53] don't you have to use #data for custom keys [20:58:13] edsanders: 'have to', well, 'should' [20:58:45] this works, but is slower (DOM operation), leaks in IE (expando properties are not supported in IE, they become full on attributes), .. [20:58:52] yeah, use data() instead. [20:58:57] which is pure js [20:59:47] edsanders: the is:visible check is redundant and quite expensive. Ideally it also doesn't make 4 search queries [21:00:06] Krinkle, feel free to add more comments [21:00:44] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/134774/ and https://gerrit.wikimedia.org/r/#/c/134983/ [21:01:25] done [21:01:42] oh, gerrit didn't show me yours until I refreshed. It just merges silently [21:08:24] (03PS5) 10Jforrester: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 [21:09:01] TrevorParscal: Ping on CR: https://gerrit.wikimedia.org/r/#/c/134237/ and https://gerrit.wikimedia.org/r/#/c/132352/ [21:11:12] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10James Forrester) [21:11:12] 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10James Forrester) [21:11:13] 3MediaWiki extensions / 3TemplateData: TemplateData: Design a more user-centred interface - 10https://bugzilla.wikimedia.org/65815#c2 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3enhanc a:3None Improve phrasing; I don't think this blocks "stable" GUI. [21:15:27] (03PS6) 10Trevor Parscal: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester) [21:15:41] (03CR) 10Trevor Parscal: [C: 032] New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester) [21:15:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] While changing the Image Type to Frame/Basic, it automatically selects the alignment as Left when it is positioned at the right of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/65564#c8 (... [21:16:02] TrevorParscal: Bleh. [21:16:08] what? [21:16:16] TrevorParscal: That change doesn't have PNG versions. [21:16:30] TrevorParscal: Which is why it depended on the death-to-PNG commit. [21:16:38] TrevorParscal: Now PNG and SVG icons don't match up… [21:16:49] where is the death to PNG commit? [21:16:59] TrevorParscal: The one you just un-parented it from. :-) [21:17:11] yeah, I didn't do that on Gerrit [21:17:26] i have it [21:17:41] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/134758/ in VE-MW, https://gerrit.wikimedia.org/r/#/c/134754/ in VE-core. [21:17:49] TrevorParscal: (They don't technically depend on each other.) [21:19:05] (03Merged) 10jenkins-bot: New icons for cite, references [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134774 (owner: 10Jforrester) [21:24:35] hmm [21:25:16] TrevorParscal, SelectWidget doesn't seem to be checking if the clicked/chosen item is already chosen -- it emits the choose event even if we click on the item that is already selected. Is this an oversight, or is that intended? [21:25:59] ryasmeen: hi! just wanted to check in and make sure you have everything you need for mobile ve performance analysis [21:31:49] (03CR) 10Trevor Parscal: [C: 032] Dump raster support (unuseful) and assert SVG works before loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 (owner: 10Jforrester) [21:31:56] (03CR) 10Trevor Parscal: [C: 032] Dump raster support; turned out to be un-useful in practice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134754 (owner: 10Jforrester) [21:32:31] James_F, I might be missing something, but can an inline image have both caption= and alt= set ? caption is its alternate text.. right? the alt= is not used? [21:32:56] mooeypoo: No, you can set both, MW will just ignore caption if alt= is set. [21:33:02] (03Merged) 10jenkins-bot: Dump raster support; turned out to be un-useful in practice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134754 (owner: 10Jforrester) [21:33:59] (03PS2) 10Trevor Parscal: Convert toolbar structure group from bar to list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [21:34:36] ok we're going to have to see how we strategically deal with that in inline images [21:34:52] right now caption is caption and alt text is alt text and caption is *not* preserved. That's not right. [21:35:05] but I am concentrating on alignment first [21:35:10] (03CR) 10Krinkle: Trim linebreaks from block level extensions and preserve (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [21:35:12] Sure [21:37:47] ryasmeen: hi! just wanted to check in and make sure you have everything you need for mobile ve performance analysis [21:37:53] ryasmeen_: ^ [21:40:30] (03PS1) 10Mooeypoo: Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 [21:41:06] James_F: so, i guess there are like 4 or 5 things in VE core that haven't been pulled through to VEMW? [21:41:13] because head of both doesn't flyh [21:41:14] TrevorParscal: A bunch, yeah. [21:41:19] * James_F looks. [21:42:15] James_F, Default alignment, part deux et demi [21:43:23] Hi awjr [21:44:17] Do you have any tool to do that performance analysis or you want me to do that manually? [21:46:33] (03PS1) 10Jforrester: Update VE core submodule to master (f340daa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135705 [21:48:27] James_F: probably my fault, but ve is doing infinite spinner of death on that one... [21:48:35] TrevorParscal: No, probably Ed's fault. [21:48:54] who is conveniently away all of a sudden! pfff [21:48:56] edsanders|away: Hm.. testing gerrit 134857 locally causes an exception. Could be unrelated though [21:49:12] ve.Branch.setDocument, 'length' of undefined (resolving children.length) [21:49:24] TrevorParscal: Yeah. :-) [21:49:40] TrevorParscal: I mean, Ed's done all this great stuff with Context and Target and it might well have broken stuff. [21:50:08] (03CR) 10Krinkle: "Testing locally yields exception on veaction=edit load:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [21:50:20] TrevorParscal: See https://gerrit.wikimedia.org/r/#/c/135012/ etc. [21:50:34] TrevorParscal: But the OOUI change from Kaldari is more urgent. [21:51:31] ryasmeen: however you feel is best :) ori may have some suggestions of tools to use [21:51:55] ah okay! :) [21:52:11] TrevorParscal: Hmm, that pull-through did get V+2'ed by Jenkins, though… [21:52:17] James_F, when you have time, can you test this before merge? https://gerrit.wikimedia.org/r/#/c/135699/ I'm trying to make sure I'm not missing anything with the default alignment saga [21:52:22] TrevorParscal: Which is a little surprising if spinning-ball-of-death… [21:52:34] mooeypoo: I won't have time this quarter… [21:52:46] mooeypoo: I'm probably not a good person to ask to test things right now. :-( [21:53:28] 3VisualEditor / 3ContentEditable: VisualEditor: Up and down cursor keys don't let you cursor from a focusable node into a slug - 10https://bugzilla.wikimedia.org/62542 (10James Forrester) a:3Ed Sanders [21:53:30] oh okay no matter [21:53:37] Sorry. [21:53:40] and.. wow, 'this quarter' ? that bad? [21:53:41] 3VisualEditor / 3ContentEditable: VisualEditor: Left/right cursoring into block slug doesn't trigger animations - 10https://bugzilla.wikimedia.org/65742 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [21:53:56] mooeypoo: Yeah. :-( [21:54:11] (03CR) 10Trevor Parscal: [C: 032] Add more Agora dialogs styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/132352 (https://bugzilla.wikimedia.org/65504) (owner: 10JGonera) [21:54:21] no matter, I was just trying to save rumanna some work. And me, but mostly rumanna.... [21:54:22] :P [21:55:28] (03Merged) 10jenkins-bot: Add more Agora dialogs styling [oojs/ui] - 10https://gerrit.wikimedia.org/r/132352 (https://bugzilla.wikimedia.org/65504) (owner: 10JGonera) [21:56:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Send Accept-encoding: gzip to Parsoid service - 10https://bugzilla.wikimedia.org/56605#c6 (10James Forrester) 5PAT>3RES/WON Appears intractable. :-( [21:57:03] (03Abandoned) 10Jforrester: [WIP] Accept-Encoding: gzip for read requests from Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/101454 (https://bugzilla.wikimedia.org/56605) (owner: 10Jforrester) [21:58:59] (03CR) 10Trevor Parscal: [C: 04-1] Add ability to put a header at the top of a toolGroup pop-up (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:01:23] James_F: left some comments [22:03:41] TrevorParscal: So I see. :-) [22:07:43] TrevorParscal: If it's OK can we just fix the documentation and merge? [22:10:58] i have to test it quickly, but i'm getting into fights with gerrit and our millions of repos being out of sync and broken [22:16:17] i'm figuring out what ed broke [22:17:48] i think it was me... to do with PNG death out of order [22:22:40] (03PS4) 10Trevor Parscal: Dump raster support (unuseful) and assert SVG works before loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 (owner: 10Jforrester) [22:22:51] TrevorParscal: :-( [22:22:53] (03CR) 10Trevor Parscal: [C: 032] Dump raster support (unuseful) and assert SVG works before loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 (owner: 10Jforrester) [22:22:57] TrevorParscal: So, my fault? [22:24:04] (03PS2) 10Trevor Parscal: Update VE core submodule to master (f340daa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135705 (owner: 10Jforrester) [22:24:26] no no, i'm sorting it out [22:24:32] (03Merged) 10jenkins-bot: Dump raster support (unuseful) and assert SVG works before loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134758 (owner: 10Jforrester) [22:24:34] don't worry, it will probably work eventually [22:25:38] TrevorParscal: You sorting it out !== not my fault. :-) [22:25:54] i've lost track of blame [22:25:57] * James_F grins. [22:26:03] You'll learn it soon enough now you're back. [22:26:57] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (f340daa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135705 (owner: 10Jforrester) [22:30:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (f340daa) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135705 (owner: 10Jforrester) [22:34:06] (03PS8) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [22:35:13] (03PS9) 10Vikassy: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 [22:36:13] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15496 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15496&... [22:36:43] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10ryasmeen) 5NEW>3ASS a:3Moriel Schottlender [22:36:57] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10ryasmeen) [22:36:57] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10ryasmeen) [22:38:18] (03PS4) 10Trevor Parscal: Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:38:47] (03CR) 10Trevor Parscal: [C: 032] Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:38:55] TrevorParscal: Ha, was doing that for you given radio silence. :-) [22:39:23] (03Merged) 10jenkins-bot: Add ability to put a header at the top of a toolGroup pop-up [oojs/ui] - 10https://gerrit.wikimedia.org/r/134237 (owner: 10Kaldari) [22:39:35] TrevorParscal: Was hunting for where `type`, `include` and `title` were from. [22:41:04] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7b283a9dcc) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135710 [22:41:23] (03CR) 10Trevor Parscal: [C: 032] Convert toolbar structure group from bar to list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [22:42:19] TrevorParscal: https://gerrit.wikimedia.org/r/135711 and https://gerrit.wikimedia.org/r/135710 would be good. [22:42:46] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (7b283a9dcc) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135710 (owner: 10Jforrester) [22:42:54] yeah, those are good [22:43:04] Yay. [22:44:27] (03Merged) 10jenkins-bot: Convert toolbar structure group from bar to list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [22:44:41] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7b283a9dcc) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135710 (owner: 10Jforrester) [22:47:02] (03CR) 10Jforrester: [C: 032] "Dependency merged and made available." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [22:47:27] (03CR) 10jenkins-bot: [V: 04-1] Adding header to top of citation pop-up list in mobile view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [23:05:14] Krinkle, I saw your comments on https://gerrit.wikimedia.org/r/#/c/135587/1/modules/ext.pageTriage.views.toolbar/ext.pageTriage.toolbarView.js [23:05:21] We're deliberately adding the visibility check [23:05:47] Krenair: Even in ve.activate? [23:05:56] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10James Forrester) p:5Unprio>3Normal [23:06:13] Krenair: Hey, waht about css? [23:06:25] .ve-activated [23:06:25] that's added/removed autoamtically [23:06:31] that allows a display: none that doesn't need undoing [23:06:42] it will un-apply cascadingly without needing anything [23:06:48] I guess that is the reason you dont want to call .hide() [23:06:53] because that'll make it sticky? [23:07:01] (harder to undo when you want to show it independently from VE) [23:07:37] .ve-activated #mwe-pt-toolbar { display: none; } [23:07:56] Krinkle, well I guess we could move it to be done more efficiently [23:08:11] .ve-activated idea sounds better, hadn't considered that... [23:08:44] Also, I'd recomemnd still doing it without :visible, e.g. use the direct property. Presumably it being visible is under your control, so you probably have a javascript variable or method that you can call instead. Avoid using the DOM to interpret data [23:09:11] (aside from the css approach, as a good practice in general, avoid using the DOM to retrieve information about the state of the application) [23:10:03] as it's slower, and could also change over time, and makes things more data driven. E.g. inside ve we'd use ve.isAvailable to communicate availability, not body.hasClass('ve-available') [23:10:18] yes, that makes sense. [23:10:32] (change as in, maybe it'll be collapsed or minimised instead of completely hidden one day, or maybe a gadget is doing that to PageTriage already) [23:10:37] [23:10:38] Krenair: the DOM is like a politician, makes a lot of promises on paper, but in practice tells lies and is generally unreliable [23:10:55] TrevorParscal: and cost a lot of money [23:10:58] heh. [23:11:01] lol, yes [23:11:33] I've never understood why *politicians* have million dollar fundraisers. There's just something fundemantally wrong about that. [23:11:58] I mean, I know why and all, I'm well informed, but taking a step back and thinking about it, it's absurd. [23:12:09] it's because they can [23:12:35] and because people can't [23:12:47] people do all the time, for various causes [23:13:04] and because people can't ... make the right choice without a campaign telling them. [23:13:07] (or so they think( [23:13:33] a politician advertises themselves a solution to a political problem, thus it's like raising money to solve any other problem [23:13:37] TrevorParscal: btw, this means I now have 3 keyed instruments at home. 2 organs and a synth/keyboard. [23:13:51] nice [23:13:52] one includes a leslie [23:14:07] Hammond organ, my favourite [23:14:24] (03PS1) 10Jforrester: Update .docs/eg-iframe.html to sync with new changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135716 [23:14:26] those are classic man [23:16:26] (03PS5) 10Jforrester: Adding header to top of citation pop-up list in mobile view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [23:17:08] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/134620/ and https://gerrit.wikimedia.org/r/#/c/127408/ would be nice to merge next. :-) [23:18:37] (03CR) 10Jforrester: [C: 032] "Let's see if this +2 works…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [23:18:58] (03CR) 10Trevor Parscal: "Am I taking crazy pills, or does this seem like a perfect place to return a promise that is either resolved or rejected... ?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:19:36] (03CR) 10Krinkle: [C: 032] Update .docs/eg-iframe.html to sync with new changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135716 (owner: 10Jforrester) [23:19:44] Krinkle: Thanks. [23:20:01] https://gerrit.wikimedia.org/r/#/c/127408/14/src/layouts/StackLayout.js,unified is this sort of mixed up with the whole selectItem( null ) thing? [23:20:12] James_F: btw, any luck on pre-commit hook? [23:20:12] (03Merged) 10jenkins-bot: Adding header to top of citation pop-up list in mobile view [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134240 (owner: 10Kaldari) [23:20:18] setItem( null ) is like unsetCurrentItem() no? [23:20:22] TrevorParscal: Also, https://gerrit.wikimedia.org/r/#/c/133284/ needs a comment adding (and a typo fixed) for Ed to be happy to merge. [23:20:35] Krinkle: Not worked on it since you left. Without you I'm bereft of reason. [23:20:43] James_F: https://github.com/jzaefferer/commitplease for inspiration [23:20:45] lol [23:20:51] (npm-based, git-precommit hook) [23:21:10] Krinkle: Hmm. Tempting. [23:21:17] Gah. No. Must. Not. Write. Code. [23:21:24] * James_F parks it. [23:21:35] that should provide most of the bootstrapping of getting it installed locally and working [23:21:47] i gotta take a little break, i've been working in the car on the way to my sister in law's house, she just had a baby and we are just arriving to see it [23:21:51] (03Merged) 10jenkins-bot: Update .docs/eg-iframe.html to sync with new changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135716 (owner: 10Jforrester) [23:22:13] i will be back online in a bit [23:22:25] TrevorParscal: Give me a response for https://gerrit.wikimedia.org/r/#/c/133284/5/src/widgets/ButtonOptionWidget.js very quickly? [23:23:09] TrevorParscal: Yes, like setItem(null) but with proper event emission. The main reason to have it is because we were *not* using setItem(null) but assigning currentItem=null; which didn't emit an event [23:23:37] (e.g. in #clearItems ) [23:23:55] (03PS15) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408