[01:13:21] (03CR) 10Alex Monk: "Perhaps from open, but that would mean overriding the parent (marked "Do not override this method.") which is chainable..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [01:48:51] (03PS1) 10Mooeypoo: Make sure
has proper dimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135729 (https://bugzilla.wikimedia.org/65836) [01:49:07] * mooeypoo oomphs oomphs oomphs another bug bites the dust oomph oomph oomph [01:49:21] Hey. [01:50:39] aaaand now I have that song stuck in my head. [01:52:11] * James_F grins. [04:11:01] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] Emit a single event from confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [04:11:17] (03CR) 10Krinkle: "Untested, but pretty sure this doesn't work." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [10:05:11] (03CR) 10Esanders: "What node is that happening on (check the stack trace). If it's a math node, then the parent change is a breaking change with a patch in t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [10:28:57] (03CR) 10Alex Monk: [BREAKING CHANGE] Emit a single event from confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [10:46:59] (03CR) 10Alex Monk: "So perhaps the argument given to the 'done' event should be a boolean or something, but this seems to work..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [12:25:01] (03CR) 10Krinkle: "Local copy of this page https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet?action=edit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [12:27:36] (03CR) 10Krinkle: "OK. That should indeed work. I got the part of the new 'done' event, but that it removed an event wasn't obvious. That's kind of a breakin" [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [12:30:32] (03CR) 10Krinkle: "James' put it in the commit message. Thx." [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [15:21:58] I'm having a little bit of weirdness on localhost. My tags are properly rendered as a reference on the "read" tab, but in VE they show up as literals. [15:22:21] Also is there some way to register the fields of each cite template with VE? [15:22:37] I can manually add "title" and "url" but in production of course they are already there. [16:28:41] 3VisualEditor / 3Data Model: VisualEditor removes a colon from the first existing indented list item when adding another item to the list - 10https://bugzilla.wikimedia.org/63079 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3major [16:31:00] mvolz: Aha, I know this bug. [16:31:07] mvolz: You need to restart Parsoid. [16:37:44] (03PS1) 10Alex Monk: Suggest categories that exist but don't necessarily have pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135782 (https://bugzilla.wikimedia.org/49044) [16:44:20] James_F: thanks! :) [16:44:29] James_F: (for both?) [16:44:43] mvolz: Oh, that bit is TemplateData. [16:44:52] mvolz: https://www.mediawiki.org/wiki/Extension:TemplateData [16:45:43] great, thanks :) [16:46:06] mvolz: Sorry, bit of a midden. [16:47:04] np [17:08:41] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c6 (10Andre Klapper) Just in case those users all use Firefox, https://bugzilla.mozilla.org/show_bug.cgi?id=1015433 comes to my mind, though rather unlikely. We really need more info... [17:09:21] how odd. on restarting parsoid, VE has stopped loading entirely... [17:09:36] not sure if it's the ref thing or something else random i did in the interrum [17:24:30] (03CR) 10Krinkle: [C: 04-1] Make TemplateDataGenerator use new types (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [17:26:29] 3VisualEditor: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None If the "description" field for TemplateData is empty, clicking the help/informatio... [17:32:20] Krinkle: For 113183, what name would you suggest? 'value'? [17:33:06] Krinkle: … given that you were the one that suggested calling it 'type' last time around. :-) [17:33:18] Krinkle: https://gerrit.wikimedia.org/r/#/c/113183/4..7/modules/ext.templateDataGenerator.core.js [17:33:19] I doubt that [17:33:39] I did not [17:33:44] It was already named that [17:33:49] Oh, I see, you just suggested re-using it. [17:33:52] I was referring to using the variable instead of the path it represented [17:33:56] * James_F grumbles at other people's code. [17:33:58] * Krinkle nods [17:34:15] Anyway. IDGAF what it's called, so… [17:36:46] * James_F goes with 'value'. [17:36:50] (03PS8) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [17:37:03] (03CR) 10Jforrester: Make TemplateDataGenerator use new types (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [17:37:49] (03PS6) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [17:38:01] (03PS7) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [17:39:21] (03CR) 10Trevor Parscal: [C: 032] StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:39:50] (03Merged) 10jenkins-bot: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:39:56] edsanders: take that! https://gerrit.wikimedia.org/r/#/c/133284/ [17:43:00] TrevorParscal, hey [17:43:05] howdy [17:43:11] so, the save dialog thingy [17:43:15] yeah [17:43:20] ActionDialog [17:43:47] right now, what sucks, is the save dialog emits an event when the save button is pressed and then crap in the init does things, then closes the window manually [17:44:50] what we need to do instead is use action dialog, which provides the functionality for async apply behavior (which makes the dialog look pending while it's occuring) and also error handling [17:48:47] So action dialog deals with errors and an apply button (in this case, 'Save page') [17:49:30] we only want an apply button on the 'save' dialog, rather than review/conflict/nochanges [17:50:02] AlienBlockNode inherits from AlienNode inherits from LeafNode :( [17:52:06] TrevorParscal, so does the SelectWidget cancel the mousedown? [17:54:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6]For all Image Types after changing the alignment to left , it automatically selects the alignment as Right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/... [17:54:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6]For all Image Types after changing the alignment to left , it automatically selects the alignment as Right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/... [17:56:19] edsanders: /me hangs head in shame [17:56:29] I didn't realize I'd done that, that's horrible [17:58:51] TrevorParscal, if you can take a look at this, that'll be awesome https://gerrit.wikimedia.org/r/#/c/135729/ [17:59:15] TrevorParscal, without it, we have a regression bug with images that are none/centered :\ [18:01:14] 3VisualEditor / 3Editing Tools: VisualEditor: When the toolbar is disabled , clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an image 3.Click somewhere outside t... [18:04:42] 3VisualEditor / 3Editing Tools: VisualEditor: When the toolbar is disabled , clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866#c1 (10ryasmeen) Created attachment 15500 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15500&action=edit video capture of the bug [18:07:35] RoanKattouw, so if AlienBlockNode is a branch node, it's contents end up DM [18:07:44] (not just as a 'text' attribute) [18:08:08] Oh, right [18:08:10] Sorry [18:08:12] No, that's why [18:08:16] I keep forgetting this [18:08:26] AlienBlockNode is like this edge case we collectively keep forgetting about [18:08:44] It's a structural leaf node [18:08:48] Or whatever you wanna call it [18:08:51] It's a leaf node but not a content node [18:09:11] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa computer. [18:09:18] So it cannot have children but it also cannot appear inside of paragraphs [18:09:28] RoanKattouw, how is it prevented form being in paragraphs? [18:09:38] It behaves like a structural node like table except that it can't have children [18:09:52] edsanders: .static.isContent = false; [18:09:52] (03PS12) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [18:09:52] * mooeypoo shakes her fist at the gods of silicon [18:09:53] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 [18:09:57] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [18:10:07] Unless I screwed this up when I changed .isContent = true; to be the default in LeafNode? [18:10:17] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [18:10:40] mooeypoo: Having fun? [18:10:58] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [18:10:59] * mooeypoo mutters at technology [18:11:13] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [18:11:24] mooeypoo: :-( [18:12:30] James_F, I'm a little concerned about wikimania.. is there a chance you guys can bring a spare borrow laptop just for the event? [18:12:58] mooeypoo: … possibly. Did you speak to Terry about getting us to get you one anyway? [18:12:59] My laptop is unpredictable with the VM :\ [18:13:07] I did not? [18:13:29] I wasn't aware that was an option. I can mostly work with the main PC at home ,but I won't be able to take it to Wikimania. [18:13:40] Well, I guess I could... that would be.. interesting. [18:14:37] Hacking VE code with a PC and monitor on my lap. Now THAT's hard core. [18:15:06] As you saw most of us hook up our laptops to external monitors and keyboards and stuff [18:15:17] Because we like seeing things and not getting carpal tunnel [18:15:20] RoanKattouw, I don't get it, tableNode is a BranchNode [18:15:37] RoanKattouw, aye, in Wikimania too? [18:15:45] mooeypoo: There not as much, no [18:15:55] That's where you actually want a portable computer :) [18:16:11] edsanders: So, the simplistic view of the world is that block = branch and inline = leaf [18:16:19] Oh, I have a portable computer. It just crashes occasionaly and makes weird 1980's style loud beeps. [18:16:20] This is almost correct [18:16:22] mooeypoo: It's totally an option. [18:16:48] The only case (IIRC) where these aren't the same is AlienBlock [18:16:48] RoanKattouw, so the code in the the transaction builder [18:17:01] which splits paragraphs when you insert a block node [18:17:14] does that not look for BranchNodeness? [18:17:25] Nope [18:17:28] It looks for .isContent [18:17:38] >>> x = true; x.foobar; [18:17:38] RoanKattouw: undefined [18:17:40] TrevorParscal: ---^^ [18:23:10] RoanKattouw, isContent is only set on AlienInlineNode [18:25:52] Exactly [18:26:03] isContent corresponds to inline-ness [18:26:10] isContent=false corresponds to block-ness [18:26:22] Those correspondences are exact [18:26:39] The branch-block, leaf-inline correspondences are not exact (they are true most of the time but not all of the time) so we don't use them for decisions like these [18:28:43] Is it possible that there are images you can't embed?? [18:28:46] this is frustrating. [18:29:09] mooeypoo: "embed"? [18:29:20] [[File:Ulmer_M?nster-1024409.jpeg|thumb|Ulmer M?nster-1024409]] <-- the ? appears in wikitext + in the "page" that lets me embed this image individually. And yet, this is the only image I could see that reproduces the bug rummana reported regarding the scalable [18:29:31] I thought it had to do with large images, but no other large image I've tested produced this bug [18:29:42] mooeypoo: Oh, is that the Parsoid serialisation bug? [18:30:01] mooeypoo: IIRC Parsoid was double-encoding the ? and it was causing breakage… [18:30:03] I wanted to take this image but it just WON'T go.. I copied the wikitext, I took the 'embed this' string from the new commons layover... I transformed the image to thumb so I can grab it [18:30:10] mooeypoo: This might be due to various problems concerning the ? character [18:30:11] James_F, no, it appears in VE, it just doesn't get the size correctly [18:30:16] I am trying to figure out why [18:30:18] but I can't TAKE the image [18:30:21] See if there's anything weird going on with the API request [18:30:26] Look at what the API response is [18:30:29] yeah I think that's the problem [18:30:34] Question marks are very confusing to a lot of code [18:30:34] bad API response = bad scalable [18:30:40] (03CR) 10Krinkle: Make TemplateDataGenerator use new types (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg) [18:30:56] I am just trying to see if my proposed fix works, and I can't *take* the image to my local version to test :\ [18:31:16] ugh, php sucks, Redis in tool labs is pretty awesome [18:32:35] * James_F|Away coughs. [18:32:52] RoanKattouw, yes, we are getting bad response from the API because of the image name -- now.. :\ any ideas on how I can figure out what the original name *is* so I can test my solution on local? :\ [18:34:06] I can't believe I'm saying it, but damn you unicode. [18:36:49] ryasmeen, how did you find/add this image to begin with? I can't find it in the 'add media' search and copy/pasting the wikitext won't work [18:37:11] 3VisualEditor / 3Editing Tools: VisualEditor: hard breaks [Return/enter] are ignored when pages is saved by visual editor - 10https://bugzilla.wikimedia.org/65707#c2 (10Jared Zimmerman (WMF)) go to https://en.wikipedia.org/wiki/User:Jaredzimmerman_%28WMF%29/VEtest 1. place cursor after "line 1" 2. press ent... [18:38:11] 3VisualEditor / 3Editing Tools: VisualEditor: hard breaks [Return/enter] are ignored when pages is saved by visual editor - 10https://bugzilla.wikimedia.org/65707#c3 (10Jared Zimmerman (WMF)) Created attachment 15502 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15502&action=edit pre-save [18:38:26] 3VisualEditor / 3Editing Tools: VisualEditor: hard breaks [Return/enter] are ignored when pages is saved by visual editor - 10https://bugzilla.wikimedia.org/65707#c4 (10Jared Zimmerman (WMF)) Created attachment 15503 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15503&action=edit post-save [18:40:59] 3VisualEditor / 3MediaWiki integration: VisualEditor should not include pt interwiki prefix on ptwiki - 10https://bugzilla.wikimedia.org/65869 (10Helder) 3NEW p:3Unprio s:3major a:3None On https://pt.wikipedia.org/w/index.php?diff=39026438 the link [[:pt:Grupo_ACS|ACS]] should be just [[Grupo_ACS|ACS... [18:43:50] (03CR) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [18:44:53] (03PS13) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [18:47:58] 3VisualEditor / 3ContentEditable: VisualEditor: When the toolbar is disabled , clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866 (10Roan Kattouw) a:3Ed Sanders [18:48:56] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10Roan Kattouw) [18:49:09] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 [18:49:28] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [18:50:08] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [18:50:26] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [18:50:56] 3VisualEditor / 3ContentEditable: VisualEditor: Undo/redo remain active when surface is blurred - 10https://bugzilla.wikimedia.org/65713#c1 (10Roan Kattouw) p:5Unprio>3Low This is because the undo and redo buttons remain active when the surface is blurred. I know this is intentional, but maybe it should... [18:51:56] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705#c1 (10Roan Kattouw) It's simultaneously opening (animating from 0.5 scaling factor to 1.0) and animating from norm... [18:52:22] (03CR) 10Trevor Parscal: [C: 032] Make sure
has proper dimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135729 (https://bugzilla.wikimedia.org/65836) (owner: 10Mooeypoo) [18:52:28] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10Roan Kattouw) a:3Trevor Parscal [18:53:56] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689#c1 (10Roan Kattouw) James says it should disable when the surface is... [18:54:11] (03Merged) 10jenkins-bot: Make sure
has proper dimensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135729 (https://bugzilla.wikimedia.org/65836) (owner: 10Mooeypoo) [18:54:55] TrevorParscal, what about cases where we *want* the apply button to be disabled after it is used? [18:55:25] (spam blacklist error and empty server response, according to the current code) [18:55:51] perhaps we could make dialog use a function called isApplyable or something to determine this? [18:55:59] and unknown error [18:56:22] that way you could override it and base the result on a boolean property you can set inside the class [18:56:26] the subclass that is [18:58:03] then in popPending, this.applyButton.setDisabled( !this.isApplyable || this.isPending() ); ? [18:59:27] yeah [18:59:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611#c1 (10Roan Kattouw) This is because the image in question is the feared Image With A Question M... [19:00:33] mooeypoo: So this image [19:00:57] It has an actual question mark in its name [19:01:07] Not anything weird with Unicode, an actual question mark [19:01:16] (Although it was clearly intended to be a ü instead) [19:01:35] yeah I saw that too -- %3F [19:01:46] drives me crazy though, how do I add it in :\ doesn't work [19:02:02] The relevant wikitext seems to be [[File:Ulmer_M%3Fnster-1024409.jpeg|thumb]] [19:02:08] which is wrong [19:02:13] Corrupted by an earlier Parsoid bug [19:02:20] I don't know why %3F even works there, it shouldn't [19:02:24] I'll try changing that back to ? [19:02:59] That doesn't seem to fix the bug though [19:05:17] Aha [19:05:31] mooeypoo: So the API call seems to be going to the %3F version of the title [19:07:57] mooeypoo: Hmm so what you could try is adding decodeURIComponent() to ve.dm.MWImageNode#getFilename [19:08:50] TrevorParscal, btw, do we have a bug for this? [19:09:05] For SaveDialog -> ActionDialog? Almost certainly not [19:09:10] no [19:09:19] you can make one if you like [19:09:27] it looks good on our reports when we close a lot of bugs [19:09:51] * TrevorParscal makes a bug for lunch today, will probably close it with WORKSFORME when he returns [19:10:03] heh [19:10:34] mooeypoo: That seems to fix it for me, submitting [19:13:46] RoanKattouw: decodeURIComponent() will throw on some valid filenames [19:13:57] like File:%.png or something along these lines [19:14:49] https://commons.wikimedia.org/wiki/File:50%25.svg [19:16:13] Then that's an invalid resource attribute [19:16:24] TrevorParscal, what about when we need to show an HTML error/form for an error? [19:16:29] If a file is named %.png, the resource attribute should be ./File:%25.png [19:16:30] e.g. for captcha [19:16:39] Still, the fact that decodeURIComponent() can throw is horrible [19:18:19] TrevorParscal, currently we pass a jQuery object to showMessage [19:18:37] RoanKattouw, ahha [19:18:39] but ActionDialog's error system limits you to strings to add as text only [19:18:45] mooeypoo: I'm doing it already [19:18:53] A bit more complex than I thought, and some more stuff to clean up [19:19:22] RoanKattouw, I have a more strategic fix in mind as well, see this: https://gerrit.wikimedia.org/r/#/c/125428/ [19:19:58] mooeypoo: Does that affect the behavior in this case? [19:19:58] RoanKattouw, the fix you're talking about will definitely help with the url issue, but I'm concerned about other potential issues with us not getting a proper response from the API [19:20:13] Because last we talked about this I asked you to come up with a case where this helped us [19:20:15] so the fix I propose *should* prevent the scalable from getting updated with faulty information [19:20:28] Yes, and I said bad API response ,but didn't have an example [19:20:59] and it's REALLY tough to reproduce an example usually, but occasionally I see this pop up -- and then get fixed if you close the dialog and reopen it again, like if the API was slow momentarily [19:21:13] RoanKattouw, the trouble is that I can't reproduce the bug so I can't really test if that solution works on the long run [19:21:22] logically it should be a good fallback [19:22:23] one of the problems now is that the scalable width/height are updated with null/undefined if the response is bad [19:22:53] which, at the moment, makes the scalable *think* it has a valid object, because it has { width: undefined } (which is an object) so it *thinks* it can process it [19:23:22] You can reproduce it now [19:23:22] mooeypoo, if you use the search term "ulmer" inside Media Dialog, you will few other images with ? on its name [19:23:25] Create an image with ? in the name [19:23:38] (and don't apply the patch I'm about to submit which fixes the ? bug) [19:23:48] get* [19:23:49] but it can't. RoanKattouw , the fix I propose should prevent the scalable from updating itself with anything *other* than a valid width/height [19:23:51] oh, ok [19:23:54] (03PS1) 10Catrope: Decode URL encoding in resource attriute for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135832 (https://bugzilla.wikimedia.org/65611) [19:23:57] let me try that [19:25:33] How is this "[ ve.dm.example.data[14] [new ve.dm.TextNode( 1 )] ]" (missing comma in the middle) not a syntax error?! [19:26:24] RoanKattouw_away, funny if we can add that image through the media insert dialog though -- that sends an almost identical API request. [19:27:54] I think it's parsed a 2D array lookup: x[y] [z] is allowed :/ [19:37:45] (03PS5) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [19:38:33] RoanKattouw_away, so not only is the length argument for LeafNodes (acutally just TextNodes) only used in tests [19:38:49] but the children argument for BranchNode is too [19:39:24] so both ve.dm.LeafNode and ve.dm.BranchNode have as their first argument, a test hack [19:47:41] TrevorParscal, actually, I wonder if the captcha error should use ActionDialog's error system at all... [19:56:28] (03PS1) 10Esanders: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 [19:58:51] (03PS6) 10Mooeypoo: Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [19:59:31] RoanKattouw_away, ^^ this works, and I think that it should be on top of your localized ? fix. It should fix *all* cases where we get either bad API responses or some invalid dimensions for whatever reason. [20:04:15] (03PS2) 10Esanders: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 [20:04:17] (03PS2) 10Esanders: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 [20:04:19] (03PS1) 10Esanders: Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 [20:04:34] small one: https://gerrit.wikimedia.org/r/#/c/135878/ [20:07:26] 3VisualEditor / 3MediaWiki integration: VisualEditor should create links in the format [[PAGE]] instead of [[:pt:PAGE|PAGE]] on ptwiki - 10https://bugzilla.wikimedia.org/65869#c1 (10Helder) * https://pt.wikipedia.org/w/index.php?diff=39027324&oldid=39008291 [20:12:12] 3VisualEditor: VisualEditor: Scroll bar not working in link inspector - 10https://bugzilla.wikimedia.org/65774#c1 (10ryasmeen) This issue is happening for all the scroll bars that we have in VE .As soon as you click on it the dropdown box disappears [20:25:38] (03CR) 10Hashar: "The qunit job https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/9754/console was apparently eating a lot of memory so I ma" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [20:25:45] (03CR) 10Hashar: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [20:31:49] (03CR) 10jenkins-bot: [V: 04-1] Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [20:32:44] (03CR) 10Hashar: "I gave it another try: the qunit tests hang somehow and slowly eat memory. I have manually cancelled the job. Something need to be debug" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [20:34:08] (03CR) 10Krinkle: "Both times it hangs for 14 minutes eating an increasing amount of memory on the same test:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [20:34:43] 3VisualEditor / 3Editing Tools: VisualEditor:Cannot go to the next line of an article after inserting a special character in a block slug and the TypeError: Inserted data is trying to close the root node (at index 0) appears - 10https://bugzilla.wikimedia.org/65873 (10ryasmeen) 3NEW p:3Unprio s:3normal... [21:00:36] (03CR) 10Jforrester: [C: 032] Decode URL encoding in resource attriute for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135832 (https://bugzilla.wikimedia.org/65611) (owner: 10Catrope) [21:01:08] Is Trevor around, James_F? [21:01:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Make full size button is getting disabled,the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10James Forrester) a:5Moriel Schottlender>3Roan Kattouw [21:01:35] hi [21:01:38] how's it going? [21:01:44] Krenair: Yes. :-) [21:01:55] TrevorParscal, not sure if you saw my messages earlier [21:02:11] ActionDialog has it's own error system. [21:03:05] 1) It forces everything to be a string. No jQuery objects with images etc. [21:04:45] (03Merged) 10jenkins-bot: Decode URL encoding in resource attriute for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135832 (https://bugzilla.wikimedia.org/65611) (owner: 10Catrope) [21:04:55] 2) I changed my local copy to .append( errors[i] ) instead of .text( String( errors[i] ) ) to work around that. Captcha forms (generated by an error) do show up and work but the UI is... confusing. [21:06:30] Hmm. [21:06:41] Maybe it should take more than just strings? [21:06:41] Krenair: Re #2, that'll need to be modified a bit to use .text() for text and .append() for jQuery objects [21:06:46] for security reasons [21:07:10] (03PS2) 10Mooeypoo: Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) [21:07:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10James Forrester) 5PAT>3RES/FIX [21:07:15] hmm [21:07:17] (03PS1) 10Jforrester: Decode URL encoding in resource attriute for images [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135922 [21:07:21] RoanKattouw, oh and I somehow need to deal with the output of $.parseHTML which is used for errors like spamblacklist [21:07:25] but yeah [21:07:31] the captcha thing, I didn't consider that being something you would use the error system for, that's interesting [21:07:43] can I see a screenshot? [21:08:03] wouldn't we show the captcha before they click save? [21:08:17] not hit them with it after they hit save? [21:08:41] TrevorParscal: No. [21:08:42] ConfirmEdit only does captchas if the user adds a new external URL to the page [21:08:43] TrevorParscal: The way this API works currently is you have to try to save before you get the CAPTCHA [21:08:44] Also [21:08:53] TrevorParscal: The CAPTCHA can be triggered by certain things. [21:08:54] So you have to save, then the captcha comes back in an error [21:09:00] Sometimes whether you get a CAPTCHA at all depends on what content you're trying to save [21:09:03] TrevorParscal: E.g. adding external links to risky sites. [21:09:04] Yeah what these guys are saying [21:09:06] Yeah. [21:09:06] Krenair: well, ideally we could know that before they click save, is what I am saying [21:10:21] in any case, can I see a screenshot, or could you throw a WIP up? [21:10:27] screenshot is easier for me [21:10:35] I haven't actually looked into if ConfirmEdit can be customised to give captchas in different situations. All I've tested is anonymous users adding new external links [21:10:50] ConfirmEdit allows limited customization [21:10:59] one sec TrevorParscal [21:11:10] But obviously, the API used by ConfirmEdit to hook into this allows arbitrary checks against the to-be-saved content [21:12:45] E.g. AbuseFilters. [21:14:12] TrevorParscal, http://imgur.com/BSA5FEE [21:14:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does not include the Right and Border in the wikitext - 10https://bugzilla.wikimedia.org/62852#c6 (10ryasmeen) Verified the fix in Betalabs [21:14:42] that comes up when you initially hit save [21:15:16] If you fill it out correctly, click 'Go back' and hit save again, it's fine. (Obviously if you get it wrong, the same thing happens but you get a new captcha) [21:15:26] Krenair: So the save dialog has this notion of recoverable and unrecoverable errors [21:15:35] You can tell because some error handlers disable the save button whereas others don;t [21:15:38] the "Something went wrong" should be customizable or something [21:15:39] yeah. [21:15:48] You could extend that notion to create a third category for not-really-error-errors like CAPTCHAs [21:16:19] ok, this is the problem [21:16:35] we need 2 systems, errors and notices [21:16:52] a notice is non-error information (like captcha) and has a continue button [21:17:06] errors have no continue button [21:17:11] they both have a go back button [21:17:22] I can still easily make it use the old error system for captchas, RoanKattouw. Just seems wrong since this is kind of an error. [21:18:07] so, we need showNotices, dismissNotices, etc. [21:18:38] i'm saying, visually and functionally, they are different, so we really should add notices separate from errors [21:19:06] Continue - would that clear the errors and allow you to change the edit summary etc. again or just retry? [21:19:07] i mean the captcha is more of a prompt [21:19:11] yeah. [21:19:33] but my point is we shouldn't pretend things are errors that aren't [21:21:03] error = new ve.ui.DialogError( 'content' ); error.isRecoverable(); [21:21:06] lol [21:21:17] when in doubt, make more objects [21:21:38] heh [21:21:41] 3VisualEditor / 3Editing Tools: VisualEditor: Moving an image to the centre makes the image to appear distorted inside VE - 10https://bugzilla.wikimedia.org/62850#c2 (10Moriel Schottlender) This should be fixed now. [21:21:49] seriously though, i'm just thinking that treating the capcha as an error is really wrong [21:22:20] the errors are shown because the deferred object is rejected with an array of reasons [21:22:39] (03CR) 10Catrope: [C: 04-1] Another default alignment fix to MWImageModel (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo) [21:22:42] but, maybe there's a way to reject with something else to go a different route [21:22:46] mooeypoo: ---^^ (minor issues all) [21:22:56] woot, thanks! [21:23:10] I like the general design of the promises and rejecting with data and behaving on that, but maybe an array of strings is not quite enough to go on? [21:23:12] I think for now I'll just have captchas show errors the current way instead of through ActionDialog [21:23:22] yeah [21:23:37] so, it would reject without any error strings [21:23:48] and then show the captcha [21:27:04] anyway, I still think we should allow more complex actiondialog errors than just plain text [21:27:27] I'm pretty sure there's already some code *somewhere* that does the .text()-if-text-and-.append()-otherwise logic [21:27:47] yeah. But I couldn't remember where. :P [21:28:21] Me neither [21:28:27] And grep isn't finding it just yet [21:28:43] So I didn't look into doing it properly yet and just used the easy/wrong way to get the text showing [21:29:01] RoanKattouw: http://en.wikipedia.beta.wmflabs.org/wiki/19thMarChrome?veaction=edit :-( [21:29:29] Krenair: that's what LabeledElement does [21:29:30] look there [21:29:50] LabeledElement -> setLabel [21:29:55] just found it :) [21:30:35] you could make ErrorListWidget (which mixes in GroupElement) and ErrorItemWidget (which mixes in LabeledElement) [21:31:12] may as well use GroupWidget and ItemWidget as your baseclasses [21:32:11] Then, the ErrorItemWidgets can be constructed with { 'label': /* whatever you want */ } or you can use setLabel( /* whatever you want */ ) [21:32:48] it's like 20 lines of code and 4 files (mostly boilerplate JS, move some CSS around for the 2 stylesheets) [21:33:20] and you've got a reusable error list [21:34:41] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850#c3 (10James Forrester) No, definitely still happening. Issue seems to be that the centre-floa... [21:39:38] RoanKattouw, sanity check for my brain, please.. this: return align && align !== 'none'; <-- should return 'false' for cases where align='none' and cases where align=null/undefined (which exist in initialization of inline images before we figure out their fauxlignment) ... did I do this wrong? [21:42:15] mooeypoo: Yes, that sounds right. Falsy align fails the first, 'none' fails the second. [21:42:32] Okay, I got a comment about it from RoanKattouw so I had to double-check [21:43:26] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10James Forrester) 5PAT>3RES/FIX [21:47:42] mooeypoo: Is it possible for align to ever be falsey? [21:47:52] Cause you do align = align || this.getAlignment() or whatever right before [21:47:52] it's possible for align to be null [21:47:54] or undefined [21:48:11] yes, this.getAlignment() can be undefined [21:48:25] Then you should fix the docs [21:48:35] It says the return value is always a string [21:48:54] RoanKattouw, inline images have no attr.align -- the model attaches a faux alignment ("none") later to make sure the switch between nodes work properly, but on initialization, align may be null [21:49:14] oh [21:49:16] will do [21:52:44] RoanKattouw, what's the proper way to deal with the output of $.parseHTML ? [21:53:32] RoanKattouw, also, welcome to adventures in inline/block alignment. Please remain seated with your seatbelt buckled and avoid putting any limbs near the machinery. [21:54:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611#c4 (10ryasmeen) Verified the fix in Betalabs [21:54:37] \o/ [21:57:14] It was previously just .appending everything, now I have to be careful to make sure it's not a string before appending [21:58:43] Looks like I can just add $() around the $.parseHTML call... [22:00:12] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10James Forrester) [22:00:12] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10James Forrester) 5NEW>3ASS [22:01:26] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10James Forrester) p:5Unprio>3Normal [22:04:25] (03PS1) 10Alex Monk: ActionDialog: Allow errors to be jQuery objects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135943 [22:05:12] 3VisualEditor / 3ContentEditable: VisualEditor: When the toolbar is disabled, clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low [22:05:47] (03PS3) 10Mooeypoo: Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) [22:06:59] (03CR) 10Catrope: [C: 032] Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo) [22:07:02] (03PS1) 10Alex Monk: [WIP] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 [22:07:12] 3VisualEditor / 3ContentEditable: VisualEditor: Undo/redo should not (?) remain active when surface is blurred - 10https://bugzilla.wikimedia.org/65713 (10James Forrester) 5NEW>3ASS [22:07:14] ^ am I doing this right? [22:07:20] Krenair: Isn't the point of $.parseHTML() to always return a jQuery object? [22:07:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk) [22:07:37] (03CR) 10Mooeypoo: Another default alignment fix to MWImageModel (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo) [22:07:41] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3minor [22:07:44] oh crap [22:07:45] RoanKattouw, I thought it would but: [22:07:48] $.parseHTML( '' ) instanceof jQuery [22:07:48] false [22:08:00] RoanKattouw, I didn't see you already merged the commit before sending my comments in [22:08:01] eek [22:08:12] mooeypoo: +2 canceled [22:08:15] It won't merge now [22:08:29] crap.. didn't mean to do that [22:08:42] I sent my review and then wanted to send the comments I wrote as answers to yours [22:08:48] ... and I didn't notice you +2'ed already. [22:08:55] Oh is it good to go though? [22:08:58] yeah [22:09:02] I just answered your comments [22:09:06] k [22:09:14] (03CR) 10Catrope: [C: 032] Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo) [22:09:31] oh awesome [22:09:33] thanks! [22:09:48] (03PS1) 10Jforrester: Another default alignment fix to MWImageModel [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135946 [22:10:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [22:11:19] (03PS2) 10Alex Monk: [WIP] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 [22:11:44] RoanKattouw, any idea what's up with .parseHTML ? [22:12:02] (03Merged) 10jenkins-bot: Another default alignment fix to MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135699 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo) [22:13:18] Krenair: It's an array :O [22:13:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk) [22:13:29] (sorry, meeting) [22:14:45] (03PS3) 10Alex Monk: [WIP] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 [22:17:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Left aligned Frameless/Basic image does not move to right upon changing the alignment to Right - 10https://bugzilla.wikimedia.org/65596#c7 (10ryasmeen) Verified the fix in Betalabs [22:35:42] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836#c3 (10ryasmeen) Verified the fix on betalabs [22:44:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c3 (10Moriel Schottlender) This should be resolved now following the change of default alignment pt II [22:46:35] (03CR) 10Esanders: "It depends on a change in core which hasn't been merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [22:48:16] (03PS2) 10Esanders: Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 [22:48:18] (03PS3) 10Esanders: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 [22:48:21] (03PS3) 10Esanders: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 [22:48:30] (03CR) 10jenkins-bot: [V: 04-1] Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [22:48:43] (03CR) 10jenkins-bot: [V: 04-1] Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [23:04:59] (03CR) 10Catrope: [C: 032] Convert toolbar structure group from bar to list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134986 (owner: 10Jforrester) [23:05:05] Woo. [23:06:37] (03Merged) 10jenkins-bot: Convert toolbar structure group from bar to list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134986 (owner: 10Jforrester) [23:08:49] RoanKattouw, so yeah, $.parseHTML actually just returns an array of elements [23:10:35] Yeah [23:10:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c4 (10James Forrester) 5ASS>3RES/FIX Provisionally, fixed in gerrit 135699. [23:10:48] You can run that through $() to make it a jQuery collection [23:11:43] yeah [23:11:49] that's what I ended up doing [23:11:58] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343 (10James Forrester) [23:11:58] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644 (10James Forrester) [23:11:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] There is an extra space appearing in media search result dialog (scroll bar displacing last column of results) - 10https://bugzilla.wikimedia.org/64911 (10James Forrester) [23:11:58] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [23:11:59] 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563 (10James Forrester) [23:12:17] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/135012/ is the last outstanding PTR for the cut, apparently. [23:14:01] James_F: Ugh. I don't like what that commit to SurfaceWidget. But this is needed for reference editing in mobile so I'll merge it and file a tech debt bug [23:14:09] RoanKattouw: Yeah. :-( [23:14:12] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [23:14:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c5 (10ryasmeen) Verified the fix in Betalabs [23:14:42] (03CR) 10Catrope: [C: 032] "Merging under protest; we need the SurfaceWidget change for reference editing on mobile to not be broken, but I don't like it. I'll file a" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (https://bugzilla.wikimedia.org/65642) (owner: 10Esanders) [23:15:49] (03Merged) 10jenkins-bot: Add createSurface to base target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (https://bugzilla.wikimedia.org/65642) (owner: 10Esanders) [23:19:14] 3VisualEditor / 3Technical Debt: VisualEditor: Make SurfaceWidget constructor not depend on global target - 10https://bugzilla.wikimedia.org/65881 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None See discussion at https://gerrit.wikimedia.org/r/#/c/135012/ . I think the SurfaceWidget constructor sho... [23:19:24] (03CR) 10Catrope: "https://bugzilla.wikimedia.org/show_bug.cgi?id=65881" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (https://bugzilla.wikimedia.org/65642) (owner: 10Esanders) [23:19:27] 3VisualEditor / 3Technical Debt: VisualEditor: Make SurfaceWidget constructor not depend on global target - 10https://bugzilla.wikimedia.org/65881 (10Roan Kattouw) a:3Ed Sanders [23:20:41] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [23:20:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Left aligned Frameless/Basic image does not move to right upon changing the alignment to Right - 10https://bugzilla.wikimedia.org/65596 (10James Forrester) [23:20:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf18] Making an image Right, Basic and Border does not include the Right and Border in the wikitext - 10https://bugzilla.wikimedia.org/62852 (10James Forrester) [23:20:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615 (10James Forrester) [23:20:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10James Forrester) [23:20:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [23:20:56] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression pre-wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616 (10James Forrester) [23:21:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615 (10James Forrester) [23:21:27] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [23:21:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [23:21:27] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10James Forrester) [23:22:26] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [23:22:26] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester) [23:22:56] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10James Forrester) [23:23:31] RoanKattouw: Also, please merge https://gerrit.wikimedia.org/r/#/c/135587/ [23:26:51] RoanKattouw: Easy fix… [23:31:08] (03PS1) 10Jforrester: Update VE core submodule to master (2490eb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135963 [23:33:14] 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Go to a page with an image that's below the fold (i.e. you have to scroll down to see it). Drag it and drop... [23:34:41] RoanKattouw: ^^^ [23:35:43] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None James's suggestion: never split a paragraph with a block image. It's not at all obvious what happened, especial... [23:36:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2490eb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135963 (owner: 10Jforrester) [23:36:55] (03PS4) 10Jforrester: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [23:37:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (2490eb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135963 (owner: 10Jforrester) [23:38:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: PageTriage UI appears after save - 10https://bugzilla.wikimedia.org/65702 (10James Forrester) 5PAT>3RES/FIX [23:38:42] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10ryasmeen) [23:38:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617 (10ryasmeen) [23:38:49] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [23:40:44] (03PS1) 10Catrope: Remove gallery tool from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135965 [23:40:47] James_F: --^^ [23:41:07] (03CR) 10Jforrester: [C: 032] Remove gallery tool from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135965 (owner: 10Catrope) [23:41:56] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616 (10James Forrester) [23:41:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617 (10James Forrester) [23:42:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Left aligned Frameless/Basic image does not move to right upon changing the alignment to Right - 10https://bugzilla.wikimedia.org/65596 (10James Forrester) [23:42:53] (03Merged) 10jenkins-bot: Remove gallery tool from toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135965 (owner: 10Catrope) [23:48:41] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3enhanc [23:49:12] 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10James Forrester) 5NEW>3ASS p:5Unprio>3High a:3Ed Sanders [23:49:42] 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10James Forrester) [23:50:06] RoanKattouw: "Merging under protest; we need the SurfaceWidget change for reference editing on mobile to not be broken, but I don't like it. I'll file a tech debt bug about cleaning this up." – bug please. [23:50:31] James_F: See comment below it [23:51:26] RoanKattouw: Ah, too many bugs. Sorry. [23:53:11] 3VisualEditor / 3Technical Debt: VisualEditor: Make SurfaceWidget constructor not depend on global target - 10https://bugzilla.wikimedia.org/65881 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3enhanc [23:53:56] 3VisualEditor / 3ContentEditable: VisualEditor: SurfaceWidget always creates a DesktopSurface, even when the target is mobile - 10https://bugzilla.wikimedia.org/65642#c3 (10James Forrester) Is this now fixed? [23:55:11] James_F: Re ---^^ it should be [23:55:23] RoanKattouw: No VE-MW changes needed? [23:55:28] I merged the SurfaceWidget change that purports to do it [23:55:40] Purports to do bits of it, at least. [23:55:51] No, that infrastructure was partially already in place, and partially added in commits that were merged earlier [23:55:57] The commit msg of this commit is not very good [23:56:10] It doesn't mention the actually important part, which is the 1-line change to SurfaceWidget.js