[00:04:56] (03CR) 10Catrope: [C: 032] Suggest categories that exist but don't necessarily have pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135782 (https://bugzilla.wikimedia.org/49044) (owner: 10Alex Monk) [00:06:11] (03CR) 10Catrope: [C: 032] Add a hook so GuidedTour, etc. can know when save button is clickable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135328 (owner: 10Mattflaschen) [00:06:29] (03Merged) 10jenkins-bot: Suggest categories that exist but don't necessarily have pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135782 (https://bugzilla.wikimedia.org/49044) (owner: 10Alex Monk) [00:08:41] 3VisualEditor / 3Editing Tools: VisualEditor: Category editor should also suggest categories which 'exist' but are without a description page - 10https://bugzilla.wikimedia.org/49044 (10Alex Monk) 5PAT>3RES/FIX [00:09:21] (03Merged) 10jenkins-bot: Add a hook so GuidedTour, etc. can know when save button is clickable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135328 (owner: 10Mattflaschen) [00:15:17] (03PS4) 10Alex Monk: Switch action=opensearch call to list=prefixsearch where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) [00:16:39] (03PS7) 10Catrope: Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [00:16:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836 (10James Forrester) [00:16:57] (03CR) 10Catrope: [C: 032] Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [00:17:41] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/135946/ and https://gerrit.wikimedia.org/r/#/c/135922/ [00:18:21] (03CR) 10jenkins-bot: [V: 04-1] Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [00:19:00] (03CR) 10Alex Monk: "Well... That was pretty stupid of me." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [00:23:05] (03CR) 10Alex Monk: "Turns out it was fine. I was looking at the wrong diff." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [00:27:11] 3VisualEditor / 3Editing Tools: VisualEditor:Wrapping is not working properly for Reference numbers in reflist as it gets overlapped by a left aligned image - 10https://bugzilla.wikimedia.org/64073#c1 (10Roan Kattouw) 5NEW>3RES/INV Not a VE issue, happens in read mode too. (That should be fixed though) [00:28:14] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=64332 [00:29:55] (03CR) 10Catrope: [C: 032] Another default alignment fix to MWImageModel [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135946 (owner: 10Jforrester) [00:30:01] (03CR) 10Catrope: [C: 032] Decode URL encoding in resource attriute for images [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135922 (owner: 10Jforrester) [00:31:30] (03Merged) 10jenkins-bot: Another default alignment fix to MWImageModel [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135946 (owner: 10Jforrester) [00:31:38] (03CR) 10Catrope: [C: 032] Allow extensions to add extra meta item checkboxes to the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [00:31:44] (03Merged) 10jenkins-bot: Decode URL encoding in resource attriute for images [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/135922 (owner: 10Jforrester) [00:33:20] (03Merged) 10jenkins-bot: Allow extensions to add extra meta item checkboxes to the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [00:34:42] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, the context menu's background sometimes does not appear for items inside a media caption (but the icons appear still) - 10https://bugzilla.wikimedia.org/64332#c2 (10James Forrester) Probable browser bug. Fun. [00:36:16] (03CR) 10Catrope: [C: 032] Switch action=opensearch call to list=prefixsearch where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [00:38:11] 3VisualEditor / 3Technical Debt: VisualEditor: Switch action=opensearch calls to list=prefixsearch where appropriate - 10https://bugzilla.wikimedia.org/63555 (10James Forrester) [00:38:21] (03Merged) 10jenkins-bot: Switch action=opensearch call to list=prefixsearch where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134632 (https://bugzilla.wikimedia.org/63555) (owner: 10Alex Monk) [00:39:12] 3VisualEditor / 3Editing Tools: VisualEditor:The image does not remain highlighted but the areas around it, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716#c1 (10ryasmeen) Corrected steps to reproduce: 1.Open a page with VE 2.Insert an image 3.Make it Frameless-... [00:41:57] 3VisualEditor / 3Technical Debt: VisualEditor: Switch action=opensearch calls to list=prefixsearch where appropriate - 10https://bugzilla.wikimedia.org/63555 (10James Forrester) 5PAT>3RES/FIX [00:42:11] 3VisualEditor / 3ContentEditable: VisualEditor: SurfaceWidget always creates a DesktopSurface, even when the target is mobile - 10https://bugzilla.wikimedia.org/65642#c4 (10James Forrester) 5PAT>3RES/FIX Apparently… [00:43:43] James_F, yeah I need to update this disambiguator commit as well [00:43:59] it's based on an older version of the dependency [00:44:56] 3VisualEditor / 3MediaWiki integration: Toolbar: Merge 'Save' and 'Cancel' buttons to a one group - 10https://bugzilla.wikimedia.org/64479 (10James Forrester) 5UNC>3ASS p:5Unprio>3Normal [00:45:12] Krenair: Ah, right. [00:45:58] 3VisualEditor / 3Data Model: VisualEditor: Handle transclusions within a table better - 10https://bugzilla.wikimedia.org/50951 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc a:3Roan Kattouw [00:46:26] 3VisualEditor / 3Data Model: VisualEditor: Handle transclusions within a table better - 10https://bugzilla.wikimedia.org/50951 (10James Forrester) [00:46:26] 3VisualEditor / 3ContentEditable: VisualEditor: Templated table cells not rendered properly in VE, but correct in Parsoid output - 10https://bugzilla.wikimedia.org/50607 (10James Forrester) [00:55:31] James_F, and I have no idea why Jenkins suddenly hates it [00:56:00] It was fine on PS4, and none of the errors match up with the tiny changes made in PS5/PS6 [00:56:10] I guess the tests changed or something [00:57:14] Krenair: Hmm. :-( [00:58:56] 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [01:01:28] 3VisualEditor / 3Editing Tools: VisualEditor: Changing image from floated (right+basic) to thumb does not update size correctly - 10https://bugzilla.wikimedia.org/65886 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Moriel Schottlender Take an image like [[File:Bigimage.png|border|right]], inspect it,... [01:02:26] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [01:02:27] 3VisualEditor / 3Editing Tools: VisualEditor: Changing image from floated (right+basic) to thumb does not update size correctly - 10https://bugzilla.wikimedia.org/65886 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal [01:04:27] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [01:36:42] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (09b223d279) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135984 [01:36:58] (03PS1) 10Catrope: Make images look better, account for e82629895b38 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135985 [01:37:11] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (09b223d279) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135984 (owner: 10Jforrester) [01:37:32] RoanKattouw: https://gerrit.wikimedia.org/r/135986 [01:38:07] (03CR) 10Jforrester: [C: 032] Make images look better, account for e82629895b38 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135985 (owner: 10Catrope) [01:38:59] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (09b223d279) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135984 (owner: 10Jforrester) [01:40:34] (03Merged) 10jenkins-bot: Make images look better, account for e82629895b38 in MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135985 (owner: 10Catrope) [05:58:58] 3VisualEditor: If linking to a redirect, show the redirect's destination - 10https://bugzilla.wikimedia.org/65890 (10George Barnick (Meiko)) 3UNC p:3Unprio s:3normal a:3None VisualEditor can determine if the link you are adding is a redirect or not (since Bug 50240), but it doesn't tell what the redire... [07:28:36] (03CR) 10Hashar: "> It depends on a change in core which hasn't been merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [08:45:11] 3VisualEditor: If linking to a redirect, show the redirect's destination - 10https://bugzilla.wikimedia.org/65890 (10Andre Klapper) s:5normal>3enhanc [11:02:01] (03PS2) 10Esanders: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 [11:03:46] (03PS3) 10Esanders: Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 [11:03:48] (03PS4) 10Esanders: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 [11:03:50] (03PS4) 10Esanders: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 [11:04:23] (03CR) 10jenkins-bot: [V: 04-1] Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders) [11:04:31] (03CR) 10jenkins-bot: [V: 04-1] Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders) [11:04:38] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders) [11:23:50] (03PS5) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [11:24:27] (03PS3) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [11:25:02] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [11:25:40] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [11:32:12] rakkaus: [2014-05-29 03:17:02 +00:00] [29-May-2014 03:18:08 UTC] PHP Notice: Undefined variable: _SESSION in /www/translatewiki.net/w/extensions/LiquidThreads/classes/View.php on line 415 [11:32:15] https://github.com/wikimedia/mediawiki-extensions-LiquidThreads/commit/f2caf1cdf20c3604fe1e635b9d8e869575f751fa [11:32:22] RoanKattouw_away: The you of 2011 had it wrong [11:32:43] That does not address the problem and also doesn't hide the E_NOTICE [11:32:44] lol [11:33:03] well, it hides the notice for loop over non-array [11:33:07] not for session undefined [11:33:08] xD [11:34:59] (03PS4) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [11:35:01] (03PS6) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [11:36:13] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [11:36:26] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [11:41:18] https://bugzilla.wikimedia.org/show_bug.cgi?id=28826 [12:11:10] (03PS14) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) [12:13:34] (03PS1) 10Esanders: Don't fix selection on document focus is focusedNode is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136013 (https://bugzilla.wikimedia.org/65866) [12:42:07] (03PS10) 10Amire80: [BrowserTest] Adding support for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (owner: 10Vikassy) [14:07:18] (03PS1) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 [14:44:13] (03PS1) 10Esanders: Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 [14:46:17] (03CR) 10Esanders: "review?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [14:47:30] (03CR) 10Esanders: "I considered that, but then don't we have to mirror the directory structure inside dist?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [14:48:31] (03CR) 10Esanders: "Also, could we create a jenkins task that runs grunt-build and asserts there are no changes?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [14:49:49] (03CR) 10Esanders: "Trevor: thoughts on my comment?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134983 (owner: 10Jforrester) [14:52:23] (03CR) 10Esanders: "awaiting re-review" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135130 (owner: 10Esanders) [14:54:03] (03PS2) 10Esanders: Don't fix selection on document focus if focusedNode is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136013 (https://bugzilla.wikimedia.org/65866) [14:55:41] 3VisualEditor / 3Language: VisualEditor: IME detection relies on jQuery.browser - 10https://bugzilla.wikimedia.org/65077 (10Ed Sanders) [15:02:24] Heya. [15:10:32] hi [15:24:26] 3VisualEditor / 3Editing Tools: VisualEditor: When providing a list of potential links, show redirects' destinations, not just that they are redirects - 10https://bugzilla.wikimedia.org/65890#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal The idea is that it's generally a mistake to link to a r... [15:44:57] (03PS1) 10Jforrester: Update VE core submodule to master (610021b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136108 [15:45:23] Krenair: ^^^ Trivial no-op merge that cleans up the core/MW tree – nice if you could merge. :-) [16:12:28] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (610021b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136108 (owner: 10Jforrester) [16:13:11] Thanks, Krinkle. :-) [16:13:37] (03PS1) 10Cmcmahon: [browser test] WIP: updates for new bullets/indent UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 [16:13:58] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=65077 time is passing quickly... [16:14:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (610021b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136108 (owner: 10Jforrester) [16:14:24] Krinkle: Ask divec about it; he said he was going to have it in last week. [16:14:36] (03PS7) 10Krinkle: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:15:11] (03CR) 10Krinkle: "Dependency in ve-core has been merged and ve-mw has been updated. Rebasing for extra effect." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:15:29] James_F: We can just do $.client.profile() if needed. There is no need to refactor it. [16:15:34] They're essentially unrelated things [16:15:40] Indeed. [16:15:45] It's nice that we found that due to $.browser going away, but... [16:16:06] (03PS5) 10Krinkle: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [16:16:13] 3VisualEditor / 3Language: VisualEditor: IME detection relies on jQuery.browser - 10https://bugzilla.wikimedia.org/65077#c3 (10James Forrester) p:5High>3Highes Bumping priority as this needs to be done very soon… [16:16:14] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:16:45] (03CR) 10Jforrester: [browser test] WIP: updates for new bullets/indent UI (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 (owner: 10Cmcmahon) [16:17:12] Krinkle: I rebased 135013 onto the merged dependency last night; it V-1'ed. [16:17:41] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [16:17:43] (03CR) 10Krinkle: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (owner: 10Esanders) [16:17:43] Krinkle: The rebase artefacts of "<<<<<< HEAD" in the file don't help. :-) [16:18:00] * James_F fixes. [16:18:42] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404#c3 (10Krinkle) 5RESO/FIX>3REOP Still one use in ve.ce.Surface. [16:19:12] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404 (10Krinkle) [16:19:12] 3VisualEditor / 3Language: VisualEditor: IME detection should not use useragent sniffing - 10https://bugzilla.wikimedia.org/65077#c4 (10Krinkle) p:5Highes>3High Rephrasing to be the bug David wants to work on in general. For the literal usage of $.browser, see bug 65404. [16:19:13] (03PS2) 10Krinkle: Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [16:21:59] (03PS8) 10Jforrester: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:23:03] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:30:19] (03PS9) 10Jforrester: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:31:35] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:34:56] James_F, hey [16:35:01] Dealing with https://bugzilla.wikimedia.org/show_bug.cgi?id=65821#c3 now [16:35:23] Should seeing the beta warning dialog as anonymous user stop you from seeing it while logged in? [16:35:38] (03CR) 10Jforrester: Use registered target, instead of ve.init.Target (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [16:38:02] Krenair: Eh. Probably not. [16:38:06] Krenair: E.g. shared computer/etc. [16:38:47] ok [16:42:50] (03PS1) 10Alex Monk: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136120 (https://bugzilla.wikimedia.org/65821) [16:43:20] Krenair: D'oh. [16:44:27] (03CR) 10Alex Monk: "Caused bug 65821, fixed in I84e31323" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [16:44:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: [? Regression] Beta warning appears for every edit for some users - 10https://bugzilla.wikimedia.org/65821 (10Alex Monk) a:3Alex Monk [16:45:08] James_F, :D [16:47:52] (03CR) 10Jforrester: Fix beta warning appearing for some users that it shouldn't. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136120 (https://bugzilla.wikimedia.org/65821) (owner: 10Alex Monk) [16:50:46] huh, mixing and indent-pre causes VE to go a bit bonkers. https://www.mediawiki.org/wiki/Extension:GraphViz#Examples [16:51:09] i can't select inside nor modify the code blocks in any way there [16:51:29] cursor jumps directly from before the block to after the block, and trying to backspace or delete kills it [16:51:40] i can't remove the formatting, either [16:51:54] MatmaRex: It's alienated, yes. [16:52:10] it's not alienated, or i don't know what alienated means [16:52:26] alienated elements react to being clicked or hovered? [16:52:36] "ve-ce-alienNode ve-ce-alienInlineNode ve-ce-protectedNode ve-ce-protectedNode-shielded". [16:52:38] Definitely alienated. [16:53:47] Eww. [16:54:00] this is pretty weird, though. [16:54:02] Parsoid is injecting the element straight into the . [16:54:04] Is that valid? [16:54:10] you can't remove the formatting, for example [16:54:31] that is, you can click that in VE and it disappears partially, but you can't save the page because there are "no changes" [16:54:51] Yeah, ugly. [16:54:55] (03PS2) 10Alex Monk: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136120 (https://bugzilla.wikimedia.org/65821) [16:55:33] (03CR) 10Jforrester: [C: 032] Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136120 (https://bugzilla.wikimedia.org/65821) (owner: 10Alex Monk) [16:56:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf5] Beta warning appears for every edit for users who didn't get a cookie set whilst anon - 10https://bugzilla.wikimedia.org/65821 (10James Forrester) [16:57:08] (03PS1) 10Jforrester: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136122 [16:57:20] (03Merged) 10jenkins-bot: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136120 (https://bugzilla.wikimedia.org/65821) (owner: 10Alex Monk) [16:57:22] (03PS1) 10Jforrester: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136124 (https://bugzilla.wikimedia.org/65821) [16:57:56] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404 (10James Forrester) [17:01:36] (03PS2) 10Cmcmahon: [BrowserTest] WIP: updates for new bullets/indent UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 [17:18:51] (03PS3) 10Cmcmahon: [BrowserTest] updates for new bullets/indent UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 [17:24:37] (03PS8) 10Mooeypoo: Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [17:25:23] Krinkle, the above commit passed jenkins and got +2'ed by Roan yesterday and then jenkins failed it on a previously-notfound style error [17:25:26] which I just fixed [17:25:46] Did we change anything in gerrit or something? How was this error not caught before? [17:26:35] Krinkle, also, I just noticed I'm getting errors on grunt "Running "jscs:src" (jscs) task Warning: requireMultipleVarDecl option requires boolean value" [17:30:30] (03PS4) 10Cmcmahon: [BrowserTest] updates for new bullets/indent UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 [17:31:34] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 (owner: 10Cmcmahon) [17:34:21] mooeypoo: Have you done `npm install` recently? We changed versions of jscs recently-ish. [17:37:58] (03CR) 10Jforrester: [C: 032] "Per Roan." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:38:13] (03Merged) 10jenkins-bot: [BrowserTest] updates for new bullets/indent UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136113 (owner: 10Cmcmahon) [17:39:30] (03Merged) 10jenkins-bot: Fallback options for receiving bad information into Scalable object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:40:41] James_F, I shall again [17:42:20] ha, ok, that works [17:42:30] James_F, thanks! [17:42:44] mooeypoo: No worries. [17:45:13] (03PS3) 10Jforrester: Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [17:45:49] (03CR) 10Jforrester: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [17:54:36] (03PS4) 10Esanders: Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) [17:54:49] (03CR) 10Esanders: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [17:58:19] (03CR) 10Jforrester: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [18:02:25] (03CR) 10Esanders: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [18:04:10] TrevorParscal, re: https://gerrit.wikimedia.org/r/#/c/133284/7/src/widgets/ButtonOptionWidget.js I asked: does SelectWidget cancel the mousedown when it bubbles up? [18:05:08] (03CR) 10Jforrester: Remove last jQuery.browser uses with temporary ve.isMsie hack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [18:39:41] edsanders: yes it does, SelectWidget.js on line 110 [18:40:13] it's also quite evident when using the OOUI demo, you can put the cursor in an input widget, then mess with a select widget, and the focus is not taken [18:45:46] TrevorParscal, sweet [18:46:44] (03CR) 10Esanders: [C: 032] Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [18:46:45] 3VisualEditor / 3Language: VisualEditor: IME detection should not use useragent sniffing - 10https://bugzilla.wikimedia.org/65077 (10Andre Klapper) p:5High>3Highes [18:48:18] (03Merged) 10jenkins-bot: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [18:49:42] (03CR) 10Krinkle: [C: 031] "This looks good to me. I'd merge but want to make sure still Ed or James doesn't oppose themselves. MSIE is good for "old IE". I'd say we " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [18:50:25] (03CR) 10Jforrester: [C: 031] "S'fine. We have enough MSIE issues I just worry about leaving such an obvious one unfixed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [18:51:39] (03CR) 10Krinkle: "Hm.. the << (03CR) 10Trevor Parscal: Use registered target, instead of ve.init.Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [19:14:34] (03CR) 10Trevor Parscal: [C: 032] Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [19:15:16] 3VisualEditor / 3Technical Debt: VisualEditor: Remove use of jQuery.browser - 10https://bugzilla.wikimedia.org/65404#c5 (10James Forrester) 5PATC>3RESO/FIX Thanks Ed! [19:15:34] (03PS6) 10Trevor Parscal: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [19:15:49] (03Merged) 10jenkins-bot: Remove last jQuery.browser uses with temporary ve.isMsie hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136036 (https://bugzilla.wikimedia.org/65404) (owner: 10Esanders) [19:16:28] (03CR) 10Trevor Parscal: [C: 032] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [19:16:59] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [19:17:01] (03CR) 10Trevor Parscal: [C: 032] Don't fix selection on document focus if focusedNode is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136013 (https://bugzilla.wikimedia.org/65866) (owner: 10Esanders) [19:18:11] (03Merged) 10jenkins-bot: Don't fix selection on document focus if focusedNode is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136013 (https://bugzilla.wikimedia.org/65866) (owner: 10Esanders) [19:18:45] (03CR) 10Trevor Parscal: [C: 032] Optionally allow undo while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135130 (owner: 10Esanders) [19:18:45] 3VisualEditor / 3ContentEditable: VisualEditor: When the toolbar is disabled, clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866 (10James Forrester) 5PATC>3RESO/FIX [19:19:53] (03Merged) 10jenkins-bot: Optionally allow undo while staging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135130 (owner: 10Esanders) [19:21:17] (03CR) 10Trevor Parscal: [C: 04-1] "I'm also not really a fan of this. I think we need to have an RTL stylesheet in dist since it is generated. Having generated and non-gener" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [19:21:55] (03CR) 10Trevor Parscal: [C: 032] Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [19:22:33] edsanders: can you figure out what's keeping this from merging? https://gerrit.wikimedia.org/r/#/c/135014/ [19:23:13] has the dependency been pulled through? [19:23:25] so, in core yes [19:23:29] edsanders: Yes, but the local dependency hasn't. [19:23:33] right [19:23:38] so, lets talk about that commit [19:23:43] https://gerrit.wikimedia.org/r/#/c/135013/ [19:24:41] I made getPasteRules... [19:24:59] not sure what's gone on, James keeps editing my commits [19:24:59] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/134620/ [19:25:12] can you taze him whenever he does that [19:25:21] edsanders: Nonsense. I fixed your botched rebase. [19:25:25] right, so the thing about using ve.init.target is that it's not there until you instantiate a target (it gets set in the constructor of ve.init.Target) [19:25:50] * TrevorParscal purchases tazer [19:26:21] * TrevorParscal is impressed with how affordable they are on amazon, and is excited about the prospect of having one delivered by Friday for only $4.99 shipping [19:26:23] https://gerrit.wikimedia.org/r/#/c/135013/7..9/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js is the entirety of my changes there. [19:28:09] Krenair: re https://gerrit.wikimedia.org/r/#/c/134620/2/src/dialogs/ConfirmationDialog.js,unified [19:28:57] I thought we discussed moving away from using events altogether for this, and instead doing something with promises, is that still the long term idea and this is an intermediate fix? [19:30:27] (03PS7) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [19:30:29] (03PS10) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [19:30:58] edsanders: so, anyway, I was just saying, I think that https://gerrit.wikimedia.org/r/#/c/135013/9/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js,unified smells a bit because ve.init.target is not statically set, and we are accessing it statically, which makes me feel like we should have a static method perhaps that does the extending and access and all that [19:31:48] so I wrote this this morning: https://gerrit.wikimedia.org/r/#/c/135013/10/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js [19:31:48] (03CR) 10jenkins-bot: [V: 04-1] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [19:31:50] the method of course being used after everything is loaded, this is sort of the whole race condition issue that led to us creating deferMsg [19:31:50] (03CR) 10jenkins-bot: [V: 04-1] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [19:32:35] why did I not see that earlier? hmm [19:32:39] yes, that looks cool [19:33:28] I don't think I checked it in properly [19:33:39] (Yay for gerrit.) [19:33:47] still needs a pull through I imagine [19:33:57] edsanders: There isn't anything left to pull through, is there? [19:34:06] edsanders: I pulled the code it refers to through on Tuesday. [19:34:20] * edsanders checks [19:34:24] yeah, it seems odd, it's not behaving as I would expect [19:36:15] holy crap you weren't joking about tazers. why are they all pink http://www.amazon.com/gp/feature.html?ie=UTF8&docId=1001004361 ? [19:36:44] lol [19:36:49] edsanders: Those are for women. [19:36:55] edsanders: (Srsly. It's ridiculous.) [19:37:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot close Media Settings dialog, empty caption field and the TypeError: TypeError: node.getCaptionNode is not a function appears - 10https://bugzilla.wikimedia.org/65568#c10 (10ryasmeen) Verified the fix in production [19:37:04] right, like in the pink biros [19:37:36] Indeed. [19:37:37] (03CR) 10Trevor Parscal: [BREAKING CHANGE] Emit a single event from confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [19:38:16] #YessAllWomen need tazers? [19:38:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf6] Cannot close Media Settings dialog, empty caption field and the TypeError: TypeError: node.getCaptionNode is not a function appears - 10https://bugzilla.wikimedia.org/65568 (10ryasmeen) 5RESO/?>3VERI [19:38:58] (Hey ryasmeen!) [19:38:59] is this for pleasure or pain http://www.amazon.com/gp/product/B00HPQPXVI/ ? [19:39:02] or both? [19:39:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Switching to edit source mode throws TypeError: Cannot read property 'css' of null and TypeError: Cannot read property 'each' of null for a specific case - 10https://bugzilla.wikimedia.org/65557#c7 (10ryasmeen) 5RESO/?>3VERI Verified the... [19:39:24] Hi James_F :) [19:39:59] I kinda feel like a tazer isn't something you want to pay less than $10 for... I mean, should you need to use it, it's going to be saving you from something horrific, some things just don't seem like good things to get for too cheap, like brain surgery [19:40:26] edsanders: there's no way to know for sure [19:40:39] TrevorParscal: edsanders had no issues with the US$5 brain surgery option! [19:40:44] TrevorParscal: Just look at him now! [19:41:09] he done thinkin well [19:44:00] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c1 (10James Forrester) I thought we had disabled these, but apparently not. Bah. [19:46:46] 3VisualEditor / 3Editing Tools: VisualEditor: When an image has a full size which is smaller than the default size, it does not set the default size to the value of full size - 10https://bugzilla.wikimedia.org/62293#c16 (10ryasmeen) Verified the fix in production [19:52:00] ugh, the tests use a SA target for doing MW tests [20:24:50] TrevorParscal, you wrote some tests with promises the other day, yes? [20:25:00] yeah? [20:25:05] where at? [20:25:11] you suggested a qunit lib for that stuff [20:25:20] it's in my patchset that nobody will freaking merge! [20:25:21] I did [20:25:23] ooui processes [20:25:27] ah [20:25:38] I need to use it for create an MW target in tests [20:25:45] TrevorParscal: Roan said he'd merge it tomorrow if edsanders doesn't do his duty and do it for you. [20:25:52] ;-) [20:49:10] this is a nightmare [20:49:32] all of the unit tests are using SA targets [20:50:00] MW targets construct asynchronously which makes them horrible (and slower) to use in tests [20:50:14] when most of the time all we want is the surface [20:53:50] I thought we discussed moving away from using events altogether for this, and instead doing something with promises, is that still the long term idea and this is an intermediate fix? [20:53:55] I recall that you suggested it [20:54:27] TrevorParscal, oh, yeah, I replied on the gerrit change: [20:54:29] "Perhaps from open, but that would mean overriding the parent (marked "Do not override this method.") which is chainable..." [21:11:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c6 (10ryasmeen) Verified the fix in test2 [21:26:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [21:28:32] James_F: ^^ :( [21:28:59] I reopened this bug but it has now different steps to reproduce [21:29:59] Hmmm. [21:30:05] * James_F just goes for food. [21:44:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [21:44:56] TrevorParscal? [21:47:47] 3VisualEditor / 3Data Model: VisualEditor: Two types of alignment can be set for an image in the media settings dialog after unchecking and checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15519 --> https://bugzilla.w... [21:48:16] 3VisualEditor / 3Data Model: VisualEditor: Two types of alignment can be set for an image in the media settings dialog after unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10ryasmeen) [21:51:11] (03CR) 10Alex Monk: [BREAKING CHANGE] Emit a single event from confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [21:53:46] 3VisualEditor / 3Editing Tools: VisualEditor: When providing a list of potential links, show redirects' destinations, not just that they are redirects - 10https://bugzilla.wikimedia.org/65890#c2 (10George Barnick (Meiko)) (In reply to James Forrester from comment #1) > The idea is that it's generally a mista... [22:10:16] 3VisualEditor / 3Editing Tools: VisualEditor: If a user has scrollbars on (e.g. on Windows/Linux), the width of the media search dialog is insufficient and so displays 4 results and a large margin per row - 10https://bugzilla.wikimedia.org/64911#c4 (10James Forrester) Re-phrasing title based on feedback from... [22:18:43] TrevorParscal, ping? [22:23:19] Krenair: hi [22:23:24] aha. hi. [22:23:36] So yeah, it definitely sounds like a good idea to be using a deferred/promise for the confirm dialog [22:24:07] feels like we would need the open method to return it [22:24:13] Just wasn't sure we could properly expose it without making VE core or OOUI changes [22:24:33] yeah, unfortunately that's supposed to be chainable and is marked "do not override" [22:24:35] yeah, so I'm happy to do the implementing there, at the lower level, and then I will let you know when it's ready [22:25:04] oh, okay, sure. [22:25:16] in the mean time, we can do the event change, but i just wanted to see where you were at there [22:29:07] https://gerrit.wikimedia.org/r/#/c/134620/2 says it is breaking, and https://gerrit.wikimedia.org/r/#/c/135945/ uses it, any preferences on when this gets merged, given the response in VE is still WIP? [22:32:43] TrevorParscal, not sure how https://gerrit.wikimedia.org/r/#/c/135945/ uses it? [22:32:47] https://gerrit.wikimedia.org/r/#/c/134621/ uses it... [22:38:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836#c4 (10ryasmeen) Verified the fix in test2 [22:39:26] Krenair: oh, right, sorry - wrong one [22:39:47] I wish we had a nice way of auto-creating 2-way cross-repo dependencies [22:39:56] yeah :( [22:40:10] TrevorParscal: Maybe Phabricator will support some of that stuff. [22:40:24] maybe... does it? [22:40:37] Maybe === we haven't explored enough to know. [22:40:51] But it's written in PHP, so if it doesn't /yet/ that doesn't mean it /won't/. :-) [22:41:02] As opposed to gerrit's Java black hole of doom. [22:43:17] 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:3Moriel Schottlender [22:43:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [22:43:47] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [22:43:47] 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10James Forrester) [22:45:29] I have no special love for Gerrit, but goodness, why can't we hire a single Java engineer to work on Gerrit, I love how multi lingual the office is, except when it comes to programming languages and then it's PHP or death (more recently JavaScript has been more generally accepted as a real language worth knowing) [22:49:39] TrevorParscal: we do have Java experience, just it is trapped in Search right now [22:50:03] greg-g: ahh.. right - that's true [22:50:20] Isn't chad like a gerrit ninja already? [22:50:27] Krenair: so, in my https://gerrit.wikimedia.org/r/#/c/133193/ commit, we return a promise when calling open and close [22:50:38] TrevorParscal: he won't admit it [22:51:02] but those promises get resolved or rejected based on the window successfully opening/closing [22:57:56] so, I will have to think hard about the idea of a promise for the dialog being open/closed [23:18:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171 (10Gabriel Wicke) [23:18:32] 3VisualEditor / 3Editing Tools: VisualEditor: If a user has scrollbars on (e.g. on Windows/Linux), the width of the media search dialog is insufficient and so displays 4 results and a large margin per row - 10https://bugzilla.wikimedia.org/64911 (10James Forrester) a:3Alex Monk [23:19:32] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862 (10James Forrester) a:3Alex Monk [23:28:07] * James_F dumps a couple of bugs on Krenair. ;-) [23:28:13] yeah, I saw [23:28:27] busy messing with that damn slow computer edit notice thing [23:28:33] No worries. :-) [23:44:02] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to Reproduce: 1. Open a page that contains inline images at the start of a... [23:48:42] >>> 0 / 0 [23:48:43] Krenair: (number) NaN [23:48:45] >>> 1 / 0 [23:48:45] Krenair: (number) Infinity [23:53:03] 3VisualEditor: VisualEditor: When editing a page in the Category: namespace, the contents of the category do not display upon saving - 10https://bugzilla.wikimedia.org/65925 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Intention: Change the contents of a category page (the description, not the fil... [23:58:13] Krenair: Having fun? :-)