[00:00:26] not particularly. [00:03:13] James_F, somehow performance.now() - performance.now() gives 0 on my very slow VM but a very precise decimal on my host [00:03:33] Krenair: Is the executor on the VM caching it? [00:03:37] Krenair: Or is the browser local? [00:04:17] The browser is running in an old XP VM which I've given limited resources [00:05:50] Hmm. [00:06:53] When I look at the recorded start time and end time, they're both exactly the same (38243.99999999991) [00:07:16] * James_F blames bad browsers. [00:10:51] (03PS14) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [00:11:11] meh, although annoying while messing around in console, it shouldn't effect my actual code [00:12:32] Krenair: https://gerrit.wikimedia.org/r/#/c/133193/13..14/src/Window.js i added a promise which is passed through the opening promise upon being resolved, and is resolved when closing begins [00:12:39] that will be the promise we can use for the confirm dialog [00:12:46] 3VisualEditor: VisualEditor: When editing a page in the Category: namespace, the contents of the category do not display upon saving - 10https://bugzilla.wikimedia.org/65925#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 64239 *** [00:12:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Need to refresh to see category tree and updated footer on category page - 10https://bugzilla.wikimedia.org/64239#c2 (10James Forrester) *** Bug 65925 has been marked as a duplicate of this bug. *** [00:13:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: Need to refresh to see category tree and updated footer on category page - 10https://bugzilla.wikimedia.org/64239#c3 (10James Forrester) Presumably this is pretty trivial? [00:13:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: Need to refresh to see category tree and updated footer on category page - 10https://bugzilla.wikimedia.org/64239 (10James Forrester) a:3Alex Monk [00:14:22] so we will rig it up a bit, and then you can use something like this: [00:14:22] confirmDialog.open().then( function ( action ) { action.then( function () { /* ok */ }, function () { /* cancel */ } ) } ) [00:14:32] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender [00:14:45] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [00:14:47] TrevorParscal, sounds good [00:21:28] James_F, sigh. the machine is slow enough to make VE a pain to use, but doesn't appear to be effecting the speed of the thing I'm measuring [00:21:49] Krenair: Helpful. [00:22:04] Krenair: First 1000 digits of \pi instead? [00:22:06] More annoying is that this appeared to be working well enough the other day [00:22:13] * James_F blames Roan, then. [00:28:18] 3VisualEditor: VisualEditor: I can't edit a redirect - 10https://bugzilla.wikimedia.org/65926 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Click on https://en.wikipedia.org/wiki/Sugar_candies?veaction=edit 2. Wonder why it is editing https://en.wikipedia.org/wiki/Sugar_can... [00:54:31] James_F, I actually tried messing around with some operations that involving calculating things like pi [00:54:42] Krenair: Oh? No dice? [00:54:58] (they wouldn't depend on annoying things like document complexity or whatever) [00:55:03] Yeah. [00:55:10] Like Bitcoin? ;-) [00:55:13] haha [00:56:23] unfortunately my slow VM (that struggles to run VE) appears to be calculating things faster than my (quick) host. [00:56:30] … [00:56:32] Interesting [00:56:35] yep. [00:56:42] Maybe your "slow" VM isn't? [00:57:04] Well it definitely feels slow when trying to use the UI [00:58:01] like, unusably slow [00:58:07] Helpful. [00:59:03] James_F, I'm not having much luck with this [00:59:48] I wonder whether it's worth the effort [00:59:55] Yeah. :-( [01:03:18] Krenair: Park it for now? [01:03:27] Krenair: You can always come back. :-) [01:03:33] Will abandon the gerrit change [01:03:38] Boo. [01:05:07] (03Abandoned) 10Alex Monk: Attempt to detect slow machines and show an edit notice [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135046 (https://bugzilla.wikimedia.org/50518) (owner: 10Alex Monk) [01:05:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add an edit notice for users of slower computers advising them to use source mode - 10https://bugzilla.wikimedia.org/50518 (10James Forrester) 5PATC>3ASSI [01:06:31] I have apparently broken google docs [01:07:22] Ooh, fun one. [01:07:24] ? [01:08:02] 3VisualEditor / 3Editing Tools: VisualEditor: Existing page shows up under New Page section inside Link Inspector in production - 10https://bugzilla.wikimedia.org/65927 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15527 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15527&... [01:08:22] if I try to select the whole entry for this bug on my work list, or at least the last line of it, I get a "File unavailable" error that makes me reload the page [01:08:27] select it and delete it* [01:08:29] Err. Gosh. [01:08:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: On pages which are redirects, veaction=edit should actually do redirect=no&veaction=edit - 10https://bugzilla.wikimedia.org/65926#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal https://en.wikipedia.org/w/index.php?title=Sugar_candies&redirect... [01:10:16] James_F, I can narrow it down to selecting and deleting from the end of a line before a new list item, to the end of said list item [01:10:31] So from end of 'Gerrit' to end of 'p' on the current version of the document [01:10:34] Krenair: Sadly "bugs in Google Docs" is a large set. [01:11:24] If I delete the character(s) individually without selecting the whole thing, that's fine [01:12:02] Probably a selection issue. [01:12:12] They've had issues in that area before. [01:13:48] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Click on... [02:27:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Categories not showing up in category dialog on a category page - 10https://bugzilla.wikimedia.org/61921#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Very odd. [02:27:30] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool breaks in Firefox - 10https://bugzilla.wikimedia.org/50822 (10James Forrester) s:5normal>3major [02:29:00] 3VisualEditor / 3Data Model: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - 10https://bugzilla.wikimedia.org/50474#c30 (10James Forrester) *** Bug 63210 has been marked as a duplicate of this bug. *** [02:29:15] 3VisualEditor / 3Editing Tools: reference numbers do not match in read and edit mode - 10https://bugzilla.wikimedia.org/63210#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 50474 *** [02:29:30] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395 (10James Forrester) s:5normal>3major [02:30:16] 3VisualEditor / 3Editing Tools: Description of the parametr doesnt fit into the window - 10https://bugzilla.wikimedia.org/62918#c1 (10James Forrester) 5NEW>3RESO/WOR In the design used at the time, this text trailed off with an ellipsis; clicking on the text expanded it so you could read the entire comme... [02:30:45] 3VisualEditor / 3Editing Tools: VisualEditor: Show the "*" mark beside the required parameter in the Add Parameter section - 10https://bugzilla.wikimedia.org/62161 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:35:01] 3VisualEditor: VE is unable to insert a internal reference with sub-section - 10https://bugzilla.wikimedia.org/61428#c1 (10James Forrester) 5UNCO>3RESO/DUP I don't understand this bug report, sorry. It is certainly possible right now to write "Foo#Bar" as your target, though VisualEditor doesn't validate... [02:35:01] 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget should understand section links - 10https://bugzilla.wikimedia.org/50881#c13 (10James Forrester) *** Bug 61428 has been marked as a duplicate of this bug. *** [02:37:00] 3VisualEditor / 3ContentEditable: VisualEditor: For formulae (and some other nodes?), inspection trigger region is a single line, not the whole block - 10https://bugzilla.wikimedia.org/64625 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [02:37:31] 3VisualEditor / 3ContentEditable: VisualEditor: For alienated block nodes in inline positions, alienation area is a single line, not the whole block - 10https://bugzilla.wikimedia.org/50791 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:39:01] 3VisualEditor / 3Editing Tools: VisualEditor: Apply styles for redirects/disambiguation links in suggestions in link inspector - 10https://bugzilla.wikimedia.org/61072#c1 (10James Forrester) *** Bug 64584 has been marked as a duplicate of this bug. *** [02:39:01] 3VisualEditor: VisualEditor: Have redirected links in green at the edit mode - 10https://bugzilla.wikimedia.org/64584#c1 (10James Forrester) 5NEW>3RESO/DUP VisualEditor is designed to look like the read mode; having redirects as green for read mode is bug 166, and making VE copy them if they change is bug... [02:40:45] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not highlight/remove default linked text sometimes in automated testing in Chrome - 10https://bugzilla.wikimedia.org/64655 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:42:00] 3VisualEditor / 3Editing Tools: Visual Editor: Input box for template parameters does not handle two-line parameters well - 10https://bugzilla.wikimedia.org/64250#c4 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal This is very odd. Browser bug, maybe? This isn't the behaviour for me in Chrome, Safar... [02:42:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: Warns about nonexistent edit conflicts - 10https://bugzilla.wikimedia.org/64237#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal I think (hope) that this was fixed in the fixes to edit conflict code a few weeks ago. [02:43:30] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] "Middle click" / Cmd+Click on mac no longer open links' targets in a new tab - 10https://bugzilla.wikimedia.org/64974 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:44:45] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE - 10https://bugzilla.wikimedia.org/65302#c4 (10James Forrester) 5NEW>3RESO/WOR This apparently was intentional. Now styled. :-) [02:45:30] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar appears to be a bit wider on hovering over it in Firefox - 10https://bugzilla.wikimedia.org/65240#c1 (10James Forrester) 5NEW>3RESO/INV That's OS behaviour when it thinks you want to manually interact with the scrollbar. [02:46:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: VE is not appearing as an option to edit even if Beta-Experimental mode is on in iPhone 4S - 10https://bugzilla.wikimedia.org/65415#c2 (10James Forrester) 5ASSI>3RESO/INV Intentional behaviour. [02:47:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: Lock sign appearing over the Edit option on Mobile VE even if user has Beta and Experimental Mode on - 10https://bugzilla.wikimedia.org/65414#c2 (10James Forrester) 5NEW>3RESO/WOR Probably a glitch in protection checking or something odd? [02:48:15] 3VisualEditor / 3Mobile: VisualEditor: Create browser tests for using VE via Mobile UI - 10https://bugzilla.wikimedia.org/60290 (10James Forrester) p:5Normal>3High [02:49:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: The tapping on Mobile VE is extremely inconsistent compared to standard - 10https://bugzilla.wikimedia.org/65413 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [02:49:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:51:30] 3VisualEditor / 3Mobile: VisualEditor: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [02:51:45] 3VisualEditor / 3Mobile: VisualEditor: Cursor appears over the toolbar in iPad Mini for Mobile VE - 10https://bugzilla.wikimedia.org/65325 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [02:51:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Link inspector icon remains highlighted in the toolbar for mobile VE even if no new link has been added - 10https://bugzilla.wikimedia.org/65305 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [02:52:31] 3MediaWiki extensions / 3TemplateData: TemplateData: Add property to indicate a template must be substituted - 10https://bugzilla.wikimedia.org/65550 (10James Forrester) 5NEW>3ASSI a:3None [02:56:01] 3VisualEditor / 3Editing Tools: VisualEditor: A black shadow is appearing in the Cite Web template dialog inside Media Settings after scrolling down a bit - 10https://bugzilla.wikimedia.org/61394#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal This appears to now be fixed,... [02:57:46] 3VisualEditor / 3Editing Tools: VisualEditor: Cite options are appearing as empty dialog on a new empty page for some time - 10https://bugzilla.wikimedia.org/63042#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High s:5normal>3enhanc a:3Trevor Parscal It shouldn't be very long (but that's a d... [02:58:45] 3VisualEditor / 3ContentEditable: VisualEditor: Reference's highlight is misplaced for the if the references list is placed before the reference - 10https://bugzilla.wikimedia.org/63244 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [02:59:00] 3VisualEditor / 3Editing Tools: VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal - 10https://bugzilla.wikimedia.org/63091 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [03:00:16] 3VisualEditor / 3Editing Tools: VisualEditor or Parsoid: inserted HTML code instead of Wikilink - 10https://bugzilla.wikimedia.org/52544#c1 (10James Forrester) 5NEW>3RESO/WOR I'm pretty sure this was a horrible artefact of a nasty bug we fixed back in September; provisionally marking as WORKSFORME. Sorry... [03:01:45] 3VisualEditor: Users unintentionally add line breaks when inserting or moving images - 10https://bugzilla.wikimedia.org/52657#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 51292 *** [03:01:45] 3VisualEditor / 3ContentEditable: VisualEditor: It should be clearer to users that they are inserting a media item in an odd place (e.g. into the middle of a word, middle of a paragraph) - 10https://bugzilla.wikimedia.org/51292#c4 (10James Forrester) *** Bug 52657 has been marked as a duplicate of this bug.... [03:02:45] 3VisualEditor / 3ContentEditable: VisualEditor: It should be clearer to users that they are inserting a media item in an odd place (e.g. into the middle of a word, middle of a paragraph) - 10https://bugzilla.wikimedia.org/51292#c5 (10James Forrester) The initial plan is to try bug 65883 and see whether this... [03:02:45] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883 (10James Forrester) [03:05:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning not triggered when editing image captions, references - 10https://bugzilla.wikimedia.org/56213 (10James Forrester) a:5Ed Sanders>3None [03:07:15] 3VisualEditor:
in wikitext is represented in VE as ↵ but typing ↵ does not result in a
in wikitext or in a line break when page is saved. - 10https://bugzilla.wikimedia.org/65324#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 48290 *** [03:07:15] 3VisualEditor / 3ContentEditable: VisualEditor: ↵ is shown when wikicode contains single newline, which is not very WYSIWYG - 10https://bugzilla.wikimedia.org/48290#c8 (10James Forrester) *** Bug 65324 has been marked as a duplicate of this bug. *** [04:01:45] 3VisualEditor / 3Editing Tools: Visual Editor: Input box for template parameters does not handle two-line parameters well - 10https://bugzilla.wikimedia.org/64250#c5 (10Sage Ross) Maybe a browser bug. It happens to me (still) in Iceweasel (Debian Jessie), but not in Chromium. [04:31:00] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c1 (10Moriel Schottlender) I'm a bit confused. You mentioned you need to de-select the floating value of the image, but inline images are... [05:29:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Warns about nonexistent edit conflicts - 10https://bugzilla.wikimedia.org/64237#c2 (10ryasmeen) I got this issue today again, while I was trying to add a new section in edit source mode.But could not reproduce it later.But this is the second time I experi... [06:15:32] 3VisualEditor / 3Editing Tools: VisualEditor: Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromOffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934 (10ryasmeen) 3NEW p:3Unprio s:3normal... [06:26:18] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference - 10https://bugzilla.wikimedia.org/65935 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce; 1.Open a page 2.Op... [06:26:31] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935 (10ryasmeen) [06:30:03] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery option is missing from the Insert Menu - 10https://bugzilla.wikimedia.org/65936 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15529 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15529&action=edit Screenshot I dont see... [06:58:46] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935#c1 (10ryasmeen) This is also happening while closing Media Settings dialog in Firefox [08:36:56] (03PS8) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [08:36:58] (03PS11) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [11:33:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Long target names no longer get shortened in the link inspector - 10https://bugzilla.wikimedia.org/62796#c2 (10Alex Monk) Works for me. Did this get fixed at some point since this bug was filed? [12:44:45] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c2 (10Alex Monk) If the parameter is required, I do get 'Field is required.' which should be shown still. But if it's... [12:46:15] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c3 (10Alex Monk) WhatamIdoing, can you perhaps give an example page where it does this? [13:08:20] (03PS1) 10Alex Monk: On category pages, only replace category description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136311 (https://bugzilla.wikimedia.org/64239) [13:33:19] (03PS1) 10Alex Monk: Change padding on media search results so we can display 4 results on a row with a scrollbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136314 (https://bugzilla.wikimedia.org/64911) [14:03:37] (03CR) 10Jforrester: [C: 031] "Neat." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [14:47:30] (03CR) 10Esanders: "So what's the solution, mirroring directory structure inside dist?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [14:53:33] (03PS6) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) [15:09:16] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c4 (10WhatamIdoing) Open the infobox in https://en.wikipedia.org/wiki/Aberystwyth and look at the parameter "os_grid_r... [15:12:45] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c5 (10Alex Monk) The description is set as a single space for this parameter, so I think this is expected behaviour. [15:13:01] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c2 (10WhatamIdoing) Look at what happens to the "laundromat" image at http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=100058&oldid=... [15:15:46] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c3 (10WhatamIdoing) Created attachment 15534 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15534&action=edit Inline image has be... [15:16:46] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c4 (10WhatamIdoing) Created attachment 15535 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15535&action=edit Before moving the i... [15:23:47] (03PS7) 10Esanders: Use CSS Janus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) [15:27:12] (03CR) 10Esanders: "So I've tried working with a /dist folder but now we need to rewrite all the url paths inside the files :(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [15:54:40] Heya. [15:58:02] hey [16:07:16] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, Firefox loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c3 (10Chris McMahon) Now seen in Chrome also https://wmf.ci.cloudbees.com/job/VisualEditor-en... [16:07:31] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10Chris McMahon) [16:22:18] 3MediaWiki extensions / 3TemplateData: GUI import function looks only on current page - 10https://bugzilla.wikimedia.org/65951 (10Saehrimnir) 3UNCO p:3Unprio s:3blocke a:3None Right now the import button makes the script search the source code of the page which one is editing which is the /doc page n... [16:23:45] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Saehrimnir) [16:23:46] 3MediaWiki extensions / 3TemplateData: GUI import function looks only on current page - 10https://bugzilla.wikimedia.org/65951 (10Saehrimnir) [16:47:15] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI import function looks only on current page - 10https://bugzilla.wikimedia.org/65951 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High s:5blocke>3major [16:48:31] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI import function looks only on current page - 10https://bugzilla.wikimedia.org/65951#c1 (10James Forrester) It's hard to see how we'd "know" what the main template is, though ascending up the sub-page tree might be a place to start. (Long-term TD will... [16:49:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Long target names no longer get shortened in the link inspector - 10https://bugzilla.wikimedia.org/62796#c3 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal Oh, yeah, we fixed this in the inspector styling tweaks in April, I think. [17:07:15] 3VisualEditor / 3ContentEditable: VisualEditor: If TemplateData does not have a description for the parameter, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c6 (10WhatamIdoing) Ah: the TemplateData at https://en.wikipedia.org/wiki/Template:Infobox_UK_place/doc#TemplateData... [17:20:34] (03PS1) 10Alex Monk: Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) [17:35:22] RoanKattouw_away: Ouch. https://stats.wikimedia.org/EN/TablesWikipediansEditsGt100.htm [17:36:20] edsanders: so, https://gerrit.wikimedia.org/r/#/c/134802/7 looks like you are now puting the RTL stuff only in the dist/ dir [17:36:28] which I support [17:36:59] why are we needing to generate these indivudal styles, like modules-ve-ce-styles-nodes-ve.ce.ResizableNode.rtl.css ? [17:37:24] sure, but the problem there is you need to rewrite the url('') paths [17:37:40] hmm [17:37:53] right, I can see that being an issue [17:38:20] the problem we are salving here is the standalone/3rd party use of VE on it's own needing support for RTL [17:38:23] right? [17:38:33] right [17:40:29] so, i feel like what we really want is a dist build anyway, of the whole thing (js, icons, ltr and rtl css) [17:40:56] (03CR) 10Jforrester: [C: 032] Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) (owner: 10Alex Monk) [17:40:58] hmm [17:41:35] i mean, if we made a wordpress plugin, we wouldn't want to include like 50 files, we would want a single JS and a single CSS, maybe one extra for the icons [17:41:45] 3VisualEditor / 3Editing Tools: VisualEditor: If the TemplateData description for a parameter is just whitespace, then hide the help/information button - 10https://bugzilla.wikimedia.org/65862#c8 (10James Forrester) 5PATC>3RESO/FIX Thanks! [17:42:54] (03CR) 10jenkins-bot: [V: 04-1] Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) (owner: 10Alex Monk) [17:43:19] edsanders: so, do you want to get a build process (a la ooui) together, or should we have someone else poke at that? [17:43:29] like Timo, or perhaps James [17:43:53] wtf? [17:44:13] we haven't addressed the url() issue in OOJS have we? [17:44:15] 3VisualEditor / 3Editing Tools: VisualEditor: Remove gallery button from the Insert Menu - 10https://bugzilla.wikimedia.org/65936#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal Yes, sorry, this was done intentionally in gerit 135965. [17:44:20] Krenair: Just Jenkins having fun… [17:44:48] (03PS1) 10JGonera: [WIP] Highlight proper item in Cite menu when reference selected [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136358 [17:47:33] edsanders: we do it by copying the images folder [17:47:39] which is usually a child of the styles dir [17:47:47] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10James Forrester) a:3Alex Monk [17:48:17] and we get lucky because we only use URL in the icons file, which is in the root [17:48:55] so it will need to be expanded on [17:49:03] also we could support @embed [17:49:17] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot close the Media Settings dialog as the error Uncaught TypeError: Object # has no method 'getCaptionNode' appears in the console - 10https://bugzilla.wikimedia.org/63132#c2 (10James Forrester) 5ASSI>3RESO/FIX a:5Trevor Parscal>3Ed San... [17:49:18] I see that SpecialCharacterInspector.css uses spinner.gif (this is probably evil, we should be using an ooui-texture here) [17:49:33] otherwise, the only use of URL is in the icons file [17:49:38] so, the build would be identical [17:49:51] spinner.gif can probably be killed [17:49:55] just copy the images dir to dist and the URLS are the same [17:50:01] yeah, I think it might not even work [17:50:10] it's for a theoretical use where a charlist is loaded async [17:50:19] 3VisualEditor / 3Editing Tools: VisualEditor: The "Insert reference" button remains enabled in the reference dialog even if it is empty - 10https://bugzilla.wikimedia.org/62399 (10James Forrester) a:5Trevor Parscal>3Alex Monk [17:50:19] right [17:50:19] 3VisualEditor / 3Editing Tools: VisualEditor: The message that appears while adding a template with no description should use the readable form of template name - 10https://bugzilla.wikimedia.org/62679 (10James Forrester) a:3Alex Monk [17:50:39] mooeypoo can explain, but it should at least be in MW [17:50:59] we really need to add push/pop pending to inspectors [17:51:01] 3VisualEditor / 3Editing Tools: VisualEditor: Icons for citation tool don't all appear to be the same (visual) weight — the book icon looks darker than the others - 10https://bugzilla.wikimedia.org/63130#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Kaity Hammerstein Fixed with the new icons. [17:51:03] TrevorParscal, does that mean you need a unique filename policy for images? [17:51:09] and also improve the look of it [17:51:32] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:3Alex Monk [17:51:42] no, I'm saying you copy the whole images folder as is [17:52:04] only UI has one [17:52:20] don't get me wrong, this isn't clean and beautiful, but we can improve it when needed [17:53:15] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements to reference editing, including local wiki-specific workflows - 10https://bugzilla.wikimedia.org/50458#c14 (10James Forrester) 5ASSI>3RESO/FIX This was resolved with the new citation system released last month. [17:53:50] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) a:5Trevor Parscal>3Alex Monk [17:56:03] 3VisualEditor / 3Editing Tools: VisualEditor: Toolbar icons - "reference" (bookmark) alternatives or improvements - 10https://bugzilla.wikimedia.org/51372#c3 (10James Forrester) 5ASSI>3RESO/FIX a:3Kaity Hammerstein I'm going to provisionally deem this solved with the new icon. [17:57:32] 3VisualEditor / 3Editing Tools: VisualEditor: On opening a reference which includes a single template and nothing else, also open that template's dialog - 10https://bugzilla.wikimedia.org/53713#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal This was done (for citation templates) in the new ci... [17:58:48] 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182 (10James Forrester) a:3Alex Monk [18:01:01] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a wiki-specific tool in the formatting menu that wraps selections in templates for semantic mark-up - 10https://bugzilla.wikimedia.org/65173 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [18:01:10] Krenair: I'm throwing a bunch of reference/citation UI bugs at you; hope this is OK. [18:02:45] 3VisualEditor / 3Editing Tools: VisualEditor: A lock icon is appearing in all references for a reference list in Firefox in test2 - 10https://bugzilla.wikimedia.org/58917#c1 (10James Forrester) 5NEW>3RESO/INV This is because the links are to HTTPS sites. [18:10:01] 3VisualEditor / 3Editing Tools: VisualEditor: reusing existing reference generates duplicate references - 10https://bugzilla.wikimedia.org/52755#c2 (10James Forrester) 5NEW>3RESO/INV I'm not sure I understand this bug report – surely it's obvious that if you re-use a reference, we need to modify the orig... [18:13:47] 3VisualEditor / 3Editing Tools: VisualEditor: Expand commands (keyboard shortcuts) to target level commands - 10https://bugzilla.wikimedia.org/57723#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders Is this now fixed? We now have save-page, show-help and other target-level shortcuts… [18:14:00] 3VisualEditor / 3Editing Tools: VisualEditor: Please add a shortcut for adding a reference to a page (?which?) - 10https://bugzilla.wikimedia.org/57452 (10James Forrester) [18:14:16] 3VisualEditor / 3Editing Tools: VisualEditor: Add keyboard shortcut for code element/style - 10https://bugzilla.wikimedia.org/52597 (10James Forrester) [18:14:18] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [18:14:18] 3VisualEditor / 3Editing Tools: VisualEditor: Please add a shortcut for adding a reference to a page (?which?) - 10https://bugzilla.wikimedia.org/57452 (10James Forrester) [18:14:19] 3VisualEditor / 3Editing Tools: VisualEditor: Add a shortcut for strikethrough (?which?) - 10https://bugzilla.wikimedia.org/60257 (10James Forrester) [18:14:19] 3VisualEditor / 3ContentEditable: VisualEditor: Shift-Delete keyboard "cut" shortcut doesn't work - 10https://bugzilla.wikimedia.org/33080 (10James Forrester) [18:14:20] 3VisualEditor / 3Editing Tools: VisualEditor: Additional keyboard shortcuts (tracking) - 10https://bugzilla.wikimedia.org/65955 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None More keyboard shortcuts help users. [18:14:30] 3VisualEditor / 3Editing Tools: VisualEditor: Additional keyboard shortcuts (tracking) - 10https://bugzilla.wikimedia.org/65955 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [18:17:28] RoanKattouw_away: ^^^^ I'm assigning https://bugzilla.wikimedia.org/show_bug.cgi?id=62590 as the image-centering bug for you. [18:17:32] 3VisualEditor / 3ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - 10https://bugzilla.wikimedia.org/62590 (10James Forrester) a:3Roan Kattouw [18:18:50] RoanKattouw: That's https://bugzilla.wikimedia.org/show_bug.cgi?id=62850 [18:19:02] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester) a:5Moriel Schottlender>3Roan Kattouw [18:19:45] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester) [18:19:46] 3VisualEditor / 3ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - 10https://bugzilla.wikimedia.org/62590 (10James Forrester) [18:21:01] 3VisualEditor / 3ContentEditable: VisualEditor: Fix "Uncaught Error: Offset could not be translated to a DOM element and offset: 2409" - 10https://bugzilla.wikimedia.org/51526#c2 (10James Forrester) This appears to now be fixed. Marking as such, though can't determine exactly what fixed fixed it (probably Ed... [18:21:17] 3VisualEditor / 3ContentEditable: VisualEditor: Fix "Uncaught Error: Offset could not be translated to a DOM element and offset: 2409" - 10https://bugzilla.wikimedia.org/51526 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders [18:22:01] 3VisualEditor / 3Editing Tools: VisualEditor: Template editor is missing accessibility features - 10https://bugzilla.wikimedia.org/65474 (10James Forrester) a:3Alex Monk [18:39:09] TrevorParscal, regarding the spinner - it's also used in MWMediaInsertDialog, and it probably should be something in oojs or at least a more centralized spinner. I was planning to replace it at some point, but if you're making it an oojs element, that will probably be better [18:40:05] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/136314 [18:41:49] James_F/RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=65934 is a bug that is happening on Firefox from yesterday, I am not sure if https://bugzilla.wikimedia.org/show_bug.cgi?id=65935 is also related with this :S [18:42:23] (03PS2) 10Alex Monk: Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) [18:42:25] (03CR) 10Jforrester: [C: 032] Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) (owner: 10Alex Monk) [18:42:31] ryasmeen: That seems like it could be related [18:42:37] (03Merged) 10jenkins-bot: Trim description when working out whether or not we should disable the info button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136348 (https://bugzilla.wikimedia.org/65862) (owner: 10Alex Monk) [18:42:41] edsanders: Could you investigate those bugs ryasmeen mentioned ---^^ ? [18:42:48] 3VisualEditor / 3Editing Tools: VisualEditor: The message that appears while adding a template with no description should use the readable form of template name - 10https://bugzilla.wikimedia.org/62679#c1 (10Alex Monk) 5ASSI>3RESO/FIX a:5Alex Monk>3Bartosz Dziewoński This appears to have been fixed i... [18:43:02] (03CR) 10Alex Monk: "Fixed bug 62679" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132723 (owner: 10Bartosz Dziewoński) [18:43:15] yeah , and that error appears while closing Media Settings dialog as well [18:46:18] and it has gone to wmf7 by the way [18:47:16] 3VisualEditor / 3Data Model: VisualEditor: SyntaxHighligherGeSHi: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist." - 10https://bugzilla.wikimedia.org/55453 (10James Forrester) [18:47:30] 3VisualEditor / 3Data Model: VisualEditor: SyntaxHighligherGeSHi: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist." - 10https://bugzilla.wikimedia.org/55453 (10James Forrester) p:5High>3Low s:5normal>3major [18:48:31] 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c1 (10Alex Monk) According to ve.ui.MWReferenceDialog.prototype.onDocumentTransact, this apply button is supposed to be disa... [18:48:51] James_F, ^ after I typed that, I fiddled around and the length became 8 while the box is empty [18:49:01] So I really have no idea what is going on there [18:50:55] Krenair: Hmm. :-( [18:52:02] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025#c3 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed... [18:52:30] 3VisualEditor / 3Editing Tools: VisualEditor: Uncaught TypeError: Object # has no method 'lookup' appears upon loading any page on test2 - 10https://bugzilla.wikimedia.org/63551#c1 (10James Forrester) 5NEW>3RESO/WOR This now WFM; possibly a gadget issue? [18:52:59] RoanKattouw touched this code in https://gerrit.wikimedia.org/r/#/c/88618/ [18:53:24] And edsanders in https://gerrit.wikimedia.org/r/#/c/81438/ [18:53:30] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10James Forrester) p:5Normal>3High [18:54:06] (03CR) 10Alex Monk: "See bug 52182" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/81438 (https://bugzilla.wikimedia.org/53345) (owner: 10Esanders) [18:54:10] (03CR) 10Alex Monk: "See bug 52182" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/88618 (owner: 10Catrope) [18:54:31] 3VisualEditor / 3Editing Tools: VisualEditor: A black shadow is appearing in the Cite Web template dialog inside Media Settings after scrolling down a bit - 10https://bugzilla.wikimedia.org/61394#c3 (10ryasmeen) 5RESO/?>3VERI Verified the fix. [18:55:00] 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c2 (10James Forrester) length < 4 is a hack and we probably shouldn't be using it… [18:55:33] James_F, so I think I asked about the citation dialog at some point and you mentioned obscure mediawiki: namespace pages are needed to turn it on? [18:55:42] or was that something else... [18:55:55] Krenair: en.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json [18:56:30] 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c3 (10Alex Monk) See Gerrit change 81438 and Gerrit change 88618 [18:56:48] 3VisualEditor / 3Editing Tools: Matching (existing) Categories are not displayed - 10https://bugzilla.wikimedia.org/65956 (10Alex) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15536 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15536&action=edit Shown, existing category not a suggest... [18:57:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal... [18:57:47] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf7] Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromO ffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934 (10James Forrester) 5NEW>... [19:02:31] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot close the Media Settings dialog as the error Uncaught TypeError: Object # has no method 'getCaptionNode' appears in the console - 10https://bugzilla.wikimedia.org/63132#c3 (10ryasmeen) 5RESO/?>3VERI Yes, Checked in production,appears to... [19:02:36] (03PS15) 10Catrope: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [19:24:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Warns about nonexistent edit conflicts - 10https://bugzilla.wikimedia.org/64237#c3 (10ryasmeen) Created attachment 15537 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15537&action=edit Screenshot Again, reproduced on test2, screenshot attached.R... [19:25:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Warns about nonexistent edit conflicts - 10https://bugzilla.wikimedia.org/64237 (10ryasmeen) 5RESO/FIX>3REOP [19:30:14] (03PS5) 10Catrope: [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [19:30:16] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [19:37:40] (03PS1) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [19:38:50] ^ Not as nice as I would like (involves overriding MWTemplateDialog's setPageByName and onTransclusionReady, then looking into BookletLayout's pages object [19:38:54] but seems to work [19:39:19] (03CR) 10jenkins-bot: [V: 04-1] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [19:41:30] (03PS2) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [19:43:11] (03CR) 10jenkins-bot: [V: 04-1] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [19:43:32] (03PS3) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [19:47:01] (03CR) 10Esanders: "This should have been marked as a breaking change, as it changes the arguments of createSurface" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135012 (https://bugzilla.wikimedia.org/65642) (owner: 10Esanders) [19:49:16] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf7] Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromOffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934#c1 (10Ed Sanders) Caused by h... [19:49:30] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c5 (10Alex Monk) If wikis use their own template instead of using directly, this doesn't sound like a good idea... [19:51:49] 65934 will be fixed by merging https://gerrit.wikimedia.org/r/#/c/135014 [19:52:31] 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c4 (10Alex Monk) *** Bug 62399 has been marked as a duplicate of this bug. *** [19:52:31] 3VisualEditor / 3Editing Tools: VisualEditor: The "Insert reference" button remains enabled in the reference dialog even if it is empty - 10https://bugzilla.wikimedia.org/62399#c1 (10Alex Monk) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 52182 *** [19:56:31] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c6 (10Jared Zimmerman (WMF)) Will break or display an error or will it just look different in the wikitext than what they a... [20:00:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935#c2 (10Ed Sanders) Almost certainly the same cause as bug 65934 [20:07:21] (03PS1) 10Alex Monk: "Use an existing reference" in the reference dialog should be disabled when there is content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136443 (https://bugzilla.wikimedia.org/65689) [20:13:45] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c7 (10Alex Monk) It 'just' looks different in most cases, as far as I'm aware. [20:19:00] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c8 (10James Forrester) (In reply to Alex Monk from comment #5) > If wikis use their own template instead of using directly,... [20:26:01] 3VisualEditor / 3Editing Tools: VisualEditor: The message that appears while adding a template with no description should use the readable form of template name - 10https://bugzilla.wikimedia.org/62679 (10James Forrester) [20:27:01] (03CR) 10Trevor Parscal: [C: 04-1] Use registered target, instead of ve.init.Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [20:27:09] edsanders: easy fix: https://gerrit.wikimedia.org/r/#/c/135013/ [20:29:41] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/135013/ and https://gerrit.wikimedia.org/r/#/c/135014/ kthxbai. [20:33:31] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10Alex Monk) [20:34:57] edsanders: Does https://gerrit.wikimedia.org/r/#/c/135014 actually depend on its dependency? [20:35:09] It seems like it could be applied without [20:35:49] probably [20:36:14] I'll try [20:36:17] OK I'll do that [20:36:28] (03PS9) 10Esanders: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 [20:39:17] (03PS2) 10Alex Monk: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136122 (https://bugzilla.wikimedia.org/65821) (owner: 10Jforrester) [20:39:36] ^ James_F that missed the Bug: line somehow [20:39:50] also added RoanKattouw to review since I'm not a deployer [20:40:02] Krenair: It was deliberate to not fill up the bug with cherry-picks. [20:40:12] oh, ok [20:40:19] Krenair: And no need to add Roan to the review list; he won't see it any more if you do that. [20:40:20] you kept it for wmf6 [20:40:29] Yeah, I screwed up. :-) [20:40:36] https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default is how Roan finds code to review. :-) [20:40:42] Um. [20:40:46] Okay. [20:41:15] (03CR) 10Esanders: Use registered target, instead of ve.init.Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [20:42:49] https://gerrit.wikimedia.org/r/#/c/127835/ and https://gerrit.wikimedia.org/r/#/c/123875/ are waiting for him on the review list [20:45:17] (03CR) 10Catrope: [C: 032] Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [20:46:08] edsanders: ve.ce.MWNumberedExternalLinkNode.js behaves differently between head and https://gerrit.wikimedia.org/r/#/c/134364 [20:46:50] (03Merged) 10jenkins-bot: Cleanup createSurface methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135014 (owner: 10Esanders) [20:46:50] in both cases it's not relocatable (which sucks, don't know why) but in your patch clicking and dragging it looks glitchy and deselects it (in head, it just stays selected and does nothing) [20:47:25] Krenair: He knows. :-) [20:48:51] (03PS1) 10Jforrester: Cleanup createSurface methods [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136451 (https://bugzilla.wikimedia.org/65934) [20:49:26] RoanKattouw: Cherry-picks for you: https://gerrit.wikimedia.org/r/#/c/136451/ https://gerrit.wikimedia.org/r/#/c/136122/ https://gerrit.wikimedia.org/r/#/c/136124/ [20:50:47] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf7] Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromOffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934 (10James Forrester) 5PATC>... [20:51:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935 (10James Forrester) 5PATC>3RESO/FIX a:5Roan Kattouw>3Ed Sa... [20:57:02] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [21:00:00] 3VisualEditor / 3Editing Tools: VisualEditor: Category editor should also suggest categories which 'exist' but are without a description page - 10https://bugzilla.wikimedia.org/49044#c5 (10James Forrester) *** Bug 65956 has been marked as a duplicate of this bug. *** [21:00:01] 3VisualEditor / 3MediaWiki integration: Matching (existing) Categories are not displayed - 10https://bugzilla.wikimedia.org/65956#c1 (10James Forrester) 5UNCO>3RESO/DUP We actually just fixed this yesterday – bug 49044. Sorry for the disruption! *** This bug has been marked as a duplicate of bug 49044 *** [21:01:16] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c9 (10Jared Zimmerman (WMF)) So if it's a difference in the look or style of the wikitext only. And the resolution is fewer or no errors f... [21:09:04] edsanders: i'm seeing that same buggy behavior with reference lists [21:09:40] (03CR) 10Trevor Parscal: [C: 04-1] "Reference list nods and internal link nodes doesn't behave the same as they did before." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [21:10:01] 3VisualEditor / 3Editing Tools: VisualEditor: Append references section and list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c10 (10James Forrester) I disagree that this is blocked by bug 51260; this bug will avoid breakage for users (who insert references and do... [21:11:01] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c11 (10James Forrester) Removing "section"; this is totally un-do-able in a scalable fashion. [21:11:15] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Update VE Core (Processes) (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [21:14:15] (03CR) 10Catrope: [BREAKING CHANGE] Update VE Core (Processes) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [21:15:30] (03CR) 10Catrope: [C: 032] Cleanup createSurface methods [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136451 (https://bugzilla.wikimedia.org/65934) (owner: 10Jforrester) [21:17:01] 3VisualEditor / 3MediaWiki integration: Matching (existing) Categories are not displayed - 10https://bugzilla.wikimedia.org/65956#c2 (10Alex) I discovered the problem was actually that a page didn't exist for those categories. When I create a page, it auto-populates the list as I begin typing. [21:17:18] (03Merged) 10jenkins-bot: Cleanup createSurface methods [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136451 (https://bugzilla.wikimedia.org/65934) (owner: 10Jforrester) [21:21:34] (03CR) 10Catrope: [C: 032] Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136122 (https://bugzilla.wikimedia.org/65821) (owner: 10Jforrester) [21:21:42] (03CR) 10Catrope: [C: 032] Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136124 (https://bugzilla.wikimedia.org/65821) (owner: 10Jforrester) [21:21:45] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c12 (10Alex Monk) (In reply to Jared Zimmerman (WMF) from comment #9) > So if it's a difference in the look or style of the wikitext only. And the > r... [21:24:25] (03Merged) 10jenkins-bot: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136122 (https://bugzilla.wikimedia.org/65821) (owner: 10Jforrester) [21:24:43] (03Merged) 10jenkins-bot: Fix beta warning appearing for some users that it shouldn't. [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136124 (https://bugzilla.wikimedia.org/65821) (owner: 10Jforrester) [21:29:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf5] Beta warning appears for every edit for users who didn't get a cookie set whilst anon - 10https://bugzilla.wikimedia.org/65821 (10James Forrester) 5PATC>3RESO/FIX [21:30:51] yo.. RoanKattouw it seems I can't have a tool without an icon? [21:31:04] Maybe not? [21:31:06] I don't know [21:31:10] What goes wrong? [21:32:15] 3VisualEditor / 3MediaWiki integration: Matching (existing) Categories are not displayed - 10https://bugzilla.wikimedia.org/65956#c3 (10James Forrester) (In reply to Alex from comment #2) > I discovered the problem was actually that a page didn't exist for those > categories. When I create a page, it auto-po... [21:43:42] RoanKattouw: sorry got sidetracked [21:43:59] It generates an empty [21:44:56] (03PS1) 10Jdlrobson: Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 [21:46:39] (03CR) 10jenkins-bot: [V: 04-1] Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [21:47:34] (03PS2) 10Jdlrobson: Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 [21:48:08] jdlrobson: That's expected [21:48:22] RoanKattouw: mm.. so should i specify an icon and use CSS to hide it? [21:48:34] No? [21:48:37] What's wrong with that empty span? [21:48:42] It doesn't render as anything, does it? [21:49:42] In mobile we set .oo-ui-iconedElement-icon to have a width and height [21:49:47] i guess i can fix our selector [21:50:49] (03PS3) 10Jdlrobson: Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 [21:51:07] I don't know how we do it [21:51:15] It probably has a w/h anyway? I don't know [21:53:15] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906#c13 (10Jared Zimmerman (WMF)) Saying this depends on native VE support of multi-column reflists before fixing it is rediculous as saying native galler... [21:58:32] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10Alex Monk) a:5Alex Monk>3Trevor Parscal [22:24:59] (03CR) 10Catrope: [C: 032] "Use an existing reference" in the reference dialog should be disabled when there is content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136443 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk) [22:26:19] (03CR) 10Catrope: [C: 04-1] ActionDialog: Allow errors to be jQuery objects (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135943 (owner: 10Alex Monk) [22:26:34] (03Merged) 10jenkins-bot: "Use an existing reference" in the reference dialog should be disabled when there is content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136443 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk) [22:28:48] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (469d40c88f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136482 [22:30:01] (03PS2) 10Alex Monk: ActionDialog: Allow errors to be jQuery objects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135943 [22:30:35] (03CR) 10Catrope: [C: 032] ActionDialog: Allow errors to be jQuery objects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135943 (owner: 10Alex Monk) [22:33:11] (03Merged) 10jenkins-bot: ActionDialog: Allow errors to be jQuery objects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135943 (owner: 10Alex Monk) [22:39:15] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10Alex Monk) 5PATC>3RESO/FIX [22:41:55] (03CR) 10Catrope: [C: 04-1] Add use existing reference to VisualEditor menu (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [22:45:13] RoanKattouw, edsanders: So I was looking into https://bugzilla.wikimedia.org/show_bug.cgi?id=52182#c1 and found that the ref dialog's apply button is disabled when there is less than 4 ... bits? - of content [22:46:06] which seems fine for new references but existing ones appear to have an internalItem section that includes the stored elements [22:46:29] Ugh [22:46:31] Of course [22:46:34] Yeah the whole 4 thing is a hack [22:46:41]

is 4 [22:47:01] But yeah existing refs will have internalItems in them and it all goes to hell [22:47:10] yeah. [22:47:45] Is internalList always at the end? Maybe we can just loop through until then [22:48:06] It's supposed to be [22:48:19] We could also provide a utility function in ElementLinearData that counts the length sans internal stuff [22:48:27] (03CR) 10Catrope: [C: 04-1] "This doesn't work very well. I have the TemplateData for cite news locally, which adds a couple of parameters by default (but empty), and " (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [22:49:47] BTW could someone +2 https://gerrit.wikimedia.org/r/136482 and https://gerrit.wikimedia.org/r/136484 for me? [22:49:50] RoanKattouw, so just count everything except when we're in between 'internalList' and '/internalList'? [22:50:02] There's actually an isInternal function somewhere [22:50:07] To support multiple internal node types [22:50:16] This should be a counting method in ElementLinearData [22:56:47] RoanKattouw: lolz at my FIXME in the patch [22:56:53] i thought i checked in some docs my bad [23:00:15] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (469d40c88f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136482 (owner: 10Catrope) [23:00:53] (03PS4) 10Jdlrobson: Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 [23:01:00] ^ RoanKattouw :) [23:01:19] RoanKattouw: Done. [23:01:22] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (469d40c88f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136482 (owner: 10Catrope) [23:01:26] James_F: Thanks [23:01:49] (03CR) 10Catrope: [C: 032] Add use existing reference to VisualEditor menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [23:01:51] (03PS6) 10Jforrester: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [23:02:00] RoanKattouw: \o/ :) [23:02:27] RoanKattouw: Gah, please fix that commit summary to say Mobile. [23:02:27] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [23:02:39] RoanKattouw: ^^^ RegEx added, but other comments not address 'cos I'm not TrevorParscal and don't have the talent for that. [23:02:57] (03PS5) 10Catrope: Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [23:03:04] Ta. [23:03:10] (Sorry, Jon. ;-)) [23:03:16] James_F: As I told you Trevor has already done this locally [23:05:43] RoanKattouw: You told me? [23:05:56] * James_F has been in meetings for > 60 minutes. [23:06:01] on gchat [23:06:10] Oh. [23:06:14] * James_F looks. [23:06:29] Apparently it's fun to auto-mute Chats. [23:06:34] * James_F grumbles at Google. [23:09:02] (03PS1) 10Catrope: Update VE core submodule to master (0f178b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136491 [23:09:10] James_F: ---^^ [23:09:26] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (0f178b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136491 (owner: 10Catrope) [23:09:30] RoanKattouw: Was already looking. :-) [23:09:37] Thanks :) [23:10:14] RoanKattouw: When's https://gerrit.wikimedia.org/r/#/c/133193/ going to land, hmm? ;-) Also https://gerrit.wikimedia.org/r/#/c/134620/ is I think good to go (with agreed tech debt backlog). [23:11:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (0f178b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136491 (owner: 10Catrope) [23:11:57] James_F: Trevor is putting the last touches on the processes stuff [23:12:02] Once he's done it'll land [23:12:09] I'm doing all those pull-throughs in preparation for that [23:12:29] I'm also reading Ed's node constructor changes, if there's nothing wrong with those and Trevor is too slow, I'll land those first [23:13:01] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf7] Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromOffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934#c4 (10ryasmeen) Verified the... [23:13:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935#c5 (10ryasmeen) Verified the fix in Betalabs [23:18:22] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Emit a single event from confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:19:59] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Emit a single event from confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/134620 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:23:30] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (0f101c6f5d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136495 [23:23:38] James_F: ---^^ & https://gerrit.wikimedia.org/r/136494 [23:28:52] (03PS1) 10Alex Monk: Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 [23:29:31] (03CR) 10jenkins-bot: [V: 04-1] Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 (owner: 10Alex Monk) [23:29:42] RoanKattouw, ^ what do you think of that (when you have a moment)? [23:30:45] (03CR) 10Catrope: [C: 04-1] Add a function to ElementLinearData to count all elements that aren't in internalList (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 (owner: 10Alex Monk) [23:30:56] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (0f101c6f5d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136495 (owner: 10Catrope) [23:32:39] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (0f101c6f5d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136495 (owner: 10Catrope) [23:32:59] (03PS2) 10Alex Monk: Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 [23:33:04] woops yeah, that was pretty stupid. PS2 is better [23:33:26] No [23:33:29] No it is not. [23:33:36] (03CR) 10jenkins-bot: [V: 04-1] Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 (owner: 10Alex Monk) [23:33:39] * Krenair facedesk [23:33:54] I should not allow myself to code at this time [23:34:42] (03PS3) 10Alex Monk: Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 [23:35:30] And I suppose jenkins wants that damn linebreak [23:35:35] (03CR) 10jenkins-bot: [V: 04-1] Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 (owner: 10Alex Monk) [23:35:39] yeah [23:35:43] (03PS4) 10Alex Monk: Add a function to ElementLinearData to count all elements that aren't in internalList [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 [23:36:39] (03PS1) 10Catrope: Update VE core submodule to master (418cd67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136497 [23:37:51] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (418cd67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136497 (owner: 10Catrope) [23:44:37] (03PS3) 10Catrope: Clean up interaction with confirmation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134621 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:47:14] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 [23:47:16] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [23:47:20] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [23:47:33] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal) [23:53:20] (03CR) 10Catrope: [C: 032] Clean up interaction with confirmation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134621 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:54:55] (03Merged) 10jenkins-bot: Clean up interaction with confirmation dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134621 (https://bugzilla.wikimedia.org/65571) (owner: 10Alex Monk) [23:55:30] 3VisualEditor / 3Technical Debt: VisualEditor: Clean up unbinding of ConfirmDialog events - 10https://bugzilla.wikimedia.org/65571 (10Alex Monk) 5PATC>3RESO/FIX [23:56:52] James_F|Away: just a headsup, for a moment on beta today it seems the "Minor edit" part of UI went away: https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/26/ Looks fine now though.