initially [17:26:42] then reattached to

on focus [17:26:55] but it appears than they lose their click handlers when then happens [17:27:07] is that possible, or have I missed something? [17:27:20] *mousedown handlers [17:31:42] looks like I might need jQuery#detach [17:32:24] ed, when you move it, use detach() and then append() [17:32:25] right [17:32:49] you figured it out while i was typing - why are you so freaking smart? you bastard, be dumber! [17:37:02] (03CR) 10Catrope: [C: 032] Use correctly in the Media and Reference toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136767 (https://bugzilla.wikimedia.org/66039) (owner: 10Amire80) [17:38:37] (03Merged) 10jenkins-bot: Use correctly in the Media and Reference toolbars [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136767 (https://bugzilla.wikimedia.org/66039) (owner: 10Amire80) [17:39:01] 3VisualEditor / 3Editing Tools: VisualEditor: Add reference (footnote) dialog is LTR in RTL wikis - 10https://bugzilla.wikimedia.org/66037 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [17:40:27] (03PS1) 10Jforrester: Use correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136782 (https://bugzilla.wikimedia.org/66039) [17:40:41] (03PS1) 10Jforrester: Use correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136783 (https://bugzilla.wikimedia.org/66039) [17:42:17] 3OOjs UI: OOjs UI: [Regression] "Switch to source editing" brings up empty "Confirm" dialog - 10https://bugzilla.wikimedia.org/66034 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Alex Monk [17:47:31] 3OOjs UI: OOjs UI: [Regression] "Switch to source editing" brings up empty "Confirm" dialog - 10https://bugzilla.wikimedia.org/66034 (10Alex Monk) 5ASSI>3PATC [17:54:48] (03PS1) 10Trevor Parscal: Resolve the opened promise after teardown [oojs/ui] - 10https://gerrit.wikimedia.org/r/136789 [17:55:05] (03PS2) 10Catrope: Resolve the opened promise after teardown [oojs/ui] - 10https://gerrit.wikimedia.org/r/136789 (owner: 10Trevor Parscal) [17:55:27] (03CR) 10Catrope: [C: 032] Resolve the opened promise after teardown [oojs/ui] - 10https://gerrit.wikimedia.org/r/136789 (owner: 10Trevor Parscal) [17:56:30] (03Merged) 10jenkins-bot: Resolve the opened promise after teardown [oojs/ui] - 10https://gerrit.wikimedia.org/r/136789 (owner: 10Trevor Parscal) [17:56:37] (03CR) 10Trevor Parscal: [C: 04-1] [BREAKING CHANGE] Use promises for confirmation dialog instead of done event (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 (owner: 10Alex Monk) [17:56:58] (03CR) 10Catrope: [C: 04-1] Add a function to ElementLinearData to count all elements that aren't in internalList (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136496 (owner: 10Alex Monk) [17:58:58] Krenair: see my review https://gerrit.wikimedia.org/r/#/c/136542/3/src/dialogs/ConfirmationDialog.js,unified and let me know if you have any questions [17:59:48] I'm glad you wrote this because it helped me catch a design flaw in the opened promise, which i fix in https://gerrit.wikimedia.org/r/#/c/136789/ [18:09:46] RoanKattouw: i saw you +2'd https://gerrit.wikimedia.org/r/#/c/136468/5 but it looks like altering the commit message blocked the merge [18:10:45] hm, I'm trying to load ve and i'm getting an error "OO.ui.ToggleButtonWidget.super.prototype.setValue.call( this, value );" [18:10:49] anyone knows about this? [18:21:14] TrevorParscal, yeah, I was confused about that [18:21:23] But just worked around it :p [18:24:17] mvolz, any luck? [18:26:51] awjr: Right, that one [18:27:29] Krenair: Sorry for that -1, my earlier review of that commit was half-assed (trying to -1 it so I could move on to other stuff), I promise this is actually all of my objections this time :) [18:27:51] awjr: I meant to go and test it but I never did. I'll do that now [18:28:48] RoanKattouw: thanks :) [18:30:38] RoanKattouw, I only see one review today on the linear data non-internal count thing? [18:30:45] Yeaah that one [18:31:03] I had -1ed it last week but not actually pointed out everything that I should have pointed out at the time [18:31:17] oh, and the earlier one was PS1 from last week [18:31:59] it's fine [18:34:14] er I can't load VE [18:34:25] TypeError: OO.ui.ToggleButtonWidget.super.prototype.setValue is undefined [18:34:37] anyone else is getting this? [18:34:47] Is your version of MW core up to date mooeypoo? [18:34:57] I just updated it, but I'll reupdate [18:35:23] latest unmodified master of VE? [18:35:37] I always update both [18:37:56] well, updated both, even ran update.php [18:38:04] still getting that error [18:38:39] :\ [18:41:25] mooeypoo: That is in fact undefined [18:41:32] But VE runs for me [18:41:36] Let me try updating everything [18:43:42] I accidentally updated my IRC client and it needed a restart [18:44:12] * James_F grins. [18:44:20] * James_F was going to say "my OS". [18:44:34] (03PS4) 10Alex Monk: [BREAKING CHANGE] Use promises for confirmation dialog instead of done event [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 [18:45:20] mooeypoo: It appears you've found a bug [18:47:21] mooeypoo: Aka Roan: "Trevor, you and I are both idiots!". [18:47:55] Question about the multi-media search [18:48:10] Rosencrantz: Sure. [18:48:34] I've got instant commons turned off, and a foreign file repo (API) set up, but it doesn't seem to be searching the foreign file repo [18:48:44] Is there something else that needs to be turned on somewhere? [18:48:49] Rosencrantz: Do you have your wiki hosted in the root of your domain? [18:49:14] (03PS1) 10Catrope: Followup 205fa98a: fix incorrect use of .super [oojs/ui] - 10https://gerrit.wikimedia.org/r/136797 [18:49:16] Rosencrantz: I.e. are your URLs ….com/w/index.php?title=Foo or ….com/index.php?title=Foo or something different? [18:49:31] it's w/index.php?title=foo [18:49:34] well [18:49:38] mooeypoo: https://gerrit.wikimedia.org/r/136797 [18:49:49] plus an apache redirect [18:49:49] Rosencrantz: Hmm. In that case, it should "just work". [18:50:40] Rosencrantz: Does /w/api.php?action=query&prop=revisions&meta=filerepoinfo return anything? [18:50:46] ha [18:50:59] for which wiki? the one with VE, or the foreign file repo? [18:51:31] Rosencrantz: The one with VE. [18:51:49] yeah it does [18:52:10] RoanKattouw, how can I test this in VE when oojs is in lib? [18:52:10] Rosencrantz: http://en.wikipedia.org/w/api.php?action=query&prop=revisions&meta=filerepoinfo is what the English Wikipedia returns, for instance; one for the remote repo and another for the local one. [18:52:24] mooeypoo: Build script in mw-core. [18:52:35] oh hmm [18:52:36] James_F, ? [18:52:37] mooeypoo: maintenance/resources/update-oojs-ui.sh [18:52:40] oh [18:53:09] Rosencrantz: The next question is what search engine you're using – MediaWiki's default out-of-the-box search is quite poor. [18:53:22] I'm using Sphinx [18:53:33] Rosencrantz: E.g. a file called File:Foo.jpg won't be returned by the search for "foo". [18:53:56] Rosencrantz: In that case I might be out of ideas. :-( [18:54:10] Rosencrantz: Is there anything in the Javascript console log when you search? [18:54:35] James_F, I'm confused, I review this and then update oojs? [18:55:14] mooeypoo: Merge https://gerrit.wikimedia.org/r/136797, run script in MW-core to update and everything should work. [18:55:20] mooeypoo: "Should". [18:55:27] (03PS6) 10Catrope: Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [18:55:31] mooeypoo: Normally I do that bit. :-) [18:56:23] James_F: No errors on the javascript. [18:56:29] James_F: Does the protocol matter? [18:56:53] I noticed the wikipedia one doesn't have the protocol listed [18:56:58] Rosencrantz: Oh, is it HTTP and you're using HTTPS on the wiki? Maybe the browser might block it? [18:56:59] James_F, oh, I thought I was supposed to test first [18:57:04] was confused as to where to review this [18:57:09] (03CR) 10jenkins-bot: [V: 04-1] Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [18:57:23] Rosencrantz: Yeah, we use protocol-relative links to avoid issues. [18:57:29] mooeypoo: You can just manually build it and copy the files to test. [18:57:43] Apache is forwarding the foreign file repo to https [18:58:23] mooeypoo: `git review -d 136797 && npm install && grunt build && cp -r dist/* /resources/lib/oojs-ui/` [18:58:29] mooeypoo: Ish. [18:59:14] TrevorParscal, have you tested https://gerrit.wikimedia.org/r/#/c/136789/ ? [18:59:31] 3VisualEditor / 3Technical Debt: VisualEditor: Use $.when() rather than sourceCount in MediaSearchWidget - 10https://bugzilla.wikimedia.org/65321 (10James Forrester) p:5Normal>3High s:5normal>3enhanc [18:59:36] Rosencrantz: I'm sorry, no ideas. [19:00:10] Thanks, no worries. Just mostly using it for some common template and help images [19:01:47] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High a:3Moriel Schottlender [19:03:02] (03CR) 10Mooeypoo: [C: 031] "Works now!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/136797 (owner: 10Catrope) [19:03:04] James_F, RoanKattouw awesome, I just tested and it works, but I don't have +2 privileges on oojs repo [19:04:40] TrevorParscal, I tried making these changes: s://gist.github.com/Krenair/d941ba55d67454927cec after rebasing, but get a very useless error when pressing buttons [19:04:48] that's https://gist.github.com/Krenair/d941ba55d67454927cec [19:05:52] mooeypoo: You don't? [19:05:59] James_F, nay [19:06:07] I could only +1 it [19:06:15] Hmm… [19:07:17] I can also only +1 [19:07:38] * James_F sighs. [19:08:15] RoanKattouw: https://gerrit.wikimedia.org/r/#/admin/groups/621,members [19:08:45] RoanKattouw: https://gerrit.wikimedia.org/r/#/admin/projects/oojs,access [19:09:29] Krenair, mooeypoo: Should be fixed now. [19:11:29] (Please confirm. ;-)) [19:12:25] Krinkle|detached: jsduck doesn't let you do subproperty-only overrides? I tried to do @param {Object} [data] in the parent and @inheritdoc @param {boolean} [data.foo] in the child, and it yelled at me [19:12:36] (03PS7) 10Catrope: Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [19:13:44] (03CR) 10Mooeypoo: [C: 032] Followup 205fa98a: fix incorrect use of .super [oojs/ui] - 10https://gerrit.wikimedia.org/r/136797 (owner: 10Catrope) [19:13:51] James_F, ^^ confirmed :D [19:13:57] mooeypoo: That answers that question. :-D [19:14:03] \o/ thanks! [19:14:25] (03Merged) 10jenkins-bot: Followup 205fa98a: fix incorrect use of .super [oojs/ui] - 10https://gerrit.wikimedia.org/r/136797 (owner: 10Catrope) [19:14:46] (03CR) 10Catrope: [C: 032] Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [19:15:29] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 [19:15:56] mooeypoo: +2 for https://gerrit.wikimedia.org/r/136801 and https://gerrit.wikimedia.org/r/136802 appreciated. [19:15:59] (03CR) 10Catrope: [C: 032] On category pages, only replace category description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136311 (https://bugzilla.wikimedia.org/64239) (owner: 10Alex Monk) [19:16:22] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/136314 ? [19:16:44] (03PS2) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 [19:16:46] (03PS15) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) [19:17:00] (03Merged) 10jenkins-bot: Add use existing reference to toolbar on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136468 (owner: 10Jdlrobson) [19:17:30] (03PS2) 10Catrope: Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk) [19:18:31] (03CR) 10jenkins-bot: [V: 04-1] Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk) [19:18:33] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 (owner: 10Jforrester) [19:19:11] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 (owner: 10Jforrester) [19:20:08] (03PS3) 10Esanders: Use new FocusableNode system [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 [19:20:10] (03PS3) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 [19:20:12] (03PS16) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) [19:20:16] (03CR) 10jenkins-bot: [V: 04-1] On category pages, only replace category description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136311 (https://bugzilla.wikimedia.org/64239) (owner: 10Alex Monk) [19:20:59] (03CR) 10Catrope: [C: 032] On category pages, only replace category description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136311 (https://bugzilla.wikimedia.org/64239) (owner: 10Alex Monk) [19:21:32] (03CR) 10jenkins-bot: [V: 04-1] Use new FocusableNode system [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [19:21:47] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [19:22:07] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 (owner: 10Jforrester) [19:22:41] (03Merged) 10jenkins-bot: On category pages, only replace category description when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136311 (https://bugzilla.wikimedia.org/64239) (owner: 10Alex Monk) [19:23:31] I'm getting an OOJS exception in the VE core master [19:24:03] RoanKattouw, you beat me to +2'ing with "odobriť" in the message. I thought I was oh so smaht. [19:24:25] edsanders: Already being fixed [19:24:29] ToggleButtonWidget I take it? [19:24:32] yup [19:25:23] Is Trevor around or..? [19:25:50] / Parent method (from mixin) [19:26:29] don't we call that mixin method [19:27:28] Krenair: i gotta go eat, but I am around [19:27:34] okay [19:27:35] can I talk to you in a bit? [19:27:38] sure [19:28:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: Need to refresh to see category tree and updated footer on category page - 10https://bugzilla.wikimedia.org/64239 (10James Forrester) 5PATC>3RESO/FIX [19:38:18] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to specify a file name in the media or image dialog, even if search can't find the file - 10https://bugzilla.wikimedia.org/66046 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None This might be something that could be associated with Bug 52463: I... [19:38:41] Third party keyboards in iOS 8 #ThingsAndroidHadNYearsAgo (attn divec) [19:41:02] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to specify a file name in the media or image dialog, even if search can't find the file - 10https://bugzilla.wikimedia.org/66046 (10WhatamIdoing) [19:41:02] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10WhatamIdoing) [19:46:18] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Add Label" throws TypeError: this.linkNode is null in link inspector - 10https://bugzilla.wikimedia.org/66047 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15554 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15554&... [19:46:31] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to specify a file name in the media or image dialog, even if search can't find the file - 10https://bugzilla.wikimedia.org/66046 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [19:46:32] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Add Label" in link inspector throws TypeError: this.linkNode is null in link inspector - 10https://bugzilla.wikimedia.org/66047 (10ryasmeen) [19:47:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label" in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:57:32] * aharoni just realized that there's no way to change the file name in the Media settings dialog. [20:09:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label"/Close button in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047 (10ryasmeen) [20:23:09] hmmm [20:23:18] something is forcing ltr on document nodes. [20:25:16] James_F: Are you still around? [20:25:24] Rosencrantz: Yes. [20:25:29] mooeypoo: I blame edsanders's changes. [20:25:40] mooeypoo: It might be wrong, but I know he was fiddling there. [20:26:03] forcing despite my urges to the opposite. wtf. [20:26:13] James_F, I can't see where anything's even setting dir='' on it [20:26:19] I found an API error in my logs, but let me actually run the correct search [20:26:22] but it's now not accepting my urges for rtl at all [20:26:28] Rosencrantz: OK. [20:26:44] so references and image captions are LTR'ed in hebrew, which is not good [20:26:52] jQuery1830314409211743623_1401740640192({"error":{"code":"iiiiurlwidth","info":"iiurlheight cannot be used without iiurlwidth"}}) [20:27:20] edsanders, did you change anything with directionality on ve.ce.DocumentNode ? [20:27:32] Rosencrantz: Oh. Hmm. That's odd. [20:27:37] It has dir="ltr" attribute which I can't find where it is set and can't remove [20:27:53] mooeypoo: ^^^ Have you seen that error before? [20:28:06] O.O no? [20:29:11] oooooh waaaait a sec [20:29:22] Old MW core version? [20:29:41] The ability to use height without width was introduced semi-recently [20:29:54] 1.21 [20:30:34] Yeah if you're using MW 1.21 to run VisualEditor you're gonna have a bad time [20:30:48] I'm running VE on 1.23 [20:30:54] Oh OK [20:30:58] It's trying to hit a Foreign Repo on 1.21 [20:31:02] Ooooh [20:31:04] Right [20:31:09] Ah, yeah, that's going to not go well. [20:31:44] Ok, well at least I know now [20:31:58] Sorry. :-( [20:32:01] Nah, it's fine. [20:32:14] I need to test my 1.23 upgrade on another one of my dev sites anyway [20:32:20] hm [20:32:32] So I'll just point it at that instead once I get it up [20:32:49] this is supposed to be fixed by the pre-emptive code from last week [20:33:02] fixed as in size is ignored, full size button and default buttons disabled. [20:44:50] Ok, it works if you change iiurlheight to iiurlwidth [20:53:45] James_F, is there a set time to update oojs in ve? so I stop having to worry about updating mediawiki and overriding those patch files? [20:55:28] mooeypoo: Waiting for Timo to fix Jenkins so we can merge the pull-throughs. :-( [20:57:09] ah ok well, I'll repatch then [21:01:42] Rosencrantz: https://bugzilla.wikimedia.org/show_bug.cgi?id=61508#c2 apparently. [21:03:41] (03PS1) 10Catrope: Remove link node inspector from insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136899 (https://bugzilla.wikimedia.org/66047) [21:03:52] James_F: --^^ [21:04:17] (03CR) 10Jforrester: [C: 032] Remove link node inspector from insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136899 (https://bugzilla.wikimedia.org/66047) (owner: 10Catrope) [21:04:17] James_F: Also, bug link you promised me? [21:05:08] (03PS2) 10Catrope: Remove link node inspector from insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136899 (https://bugzilla.wikimedia.org/66047) [21:05:19] Rosencrantz: Sorry, that was meant to be at RoanKattouw. [21:05:58] (03CR) 10Jforrester: [C: 032] Remove link node inspector from insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136899 (https://bugzilla.wikimedia.org/66047) (owner: 10Catrope) [21:07:35] (03Merged) 10jenkins-bot: Remove link node inspector from insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136899 (https://bugzilla.wikimedia.org/66047) (owner: 10Catrope) [21:08:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label"/Close button in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [21:14:41] edsanders, this ltr/rtl issue si driving me crazy. Something's attaching a 'dir': 'ltr' on DocumentNodes and I can't convince it to flip itself [21:14:54] I can't even spot WHERE it's being attached. [21:16:28] TrevorParscal: What's wrong with this code? [21:16:30] offset += view.getModel().isWrapped ? 1 : 0; [21:17:15] Is Trevor here? [21:17:35] Krenair: Yes. [21:18:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Merging in bug 61149 to this. [21:18:43] I was waiting for him to reply back :/ [21:18:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Resize text in Option menu or put it on two lines if too long - 10https://bugzilla.wikimedia.org/61149#c4 (10James Forrester) 5ASSI>3RESO/DUP Merging into bug 57366. *** This bug has been marked as a duplicate of bug 57366 *** [21:18:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c2 (10James Forrester) *** Bug 61149 has been marked as a duplicate of this bug. *** [21:18:55] Krenair: Don't ask to ask. :-) [21:24:06] (03PS5) 10Alex Monk: [BREAKING CHANGE] Use promises for confirmation dialog instead of done event [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 [21:24:34] (03CR) 10Alex Monk: [C: 04-1] "Why doe sthis not work?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 (owner: 10Alex Monk) [21:25:28] (03PS4) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [21:25:41] (03CR) 10jenkins-bot: [V: 04-1] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [21:25:46] 3VisualEditor / 3Editing Tools: Clicking the Media Settings Widget does not open the dialog - 10https://bugzilla.wikimedia.org/60397#c1 (10Chris Koerner) 5UNCO>3RESO/INV Updating to a more recent build of VisualEditor resolves this issue. [21:28:11] (03PS5) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [21:29:53] (03CR) 10jenkins-bot: [V: 04-1] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [21:30:47] (03CR) 10Alex Monk: [C: 04-1] Don't allow inserting blank citations (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [21:31:10] (03PS6) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [21:33:46] (03CR) 10jenkins-bot: [V: 04-1] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk) [21:39:01] Krenair: my version of VE was only a few days old but I just rebased anyway and now terrible things have happened to the cite dialogue. [21:39:12] I feel like this happens everytime I check something new out [21:39:19] is there some cache somewhere I should be flushing? [21:40:01] now even the close button of the insert reference dialog fires off an uncaught type error :( [21:41:40] (03PS5) 10Catrope: [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 [21:41:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [21:42:02] mvolz: Did you update MW core as well? [21:42:18] no. that'll probably do it [21:42:22] i always forget that [21:42:23] :) [21:42:34] We landed a big refactor on Friday that touched both [21:42:59] (03PS7) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) [21:49:57] what... [21:50:11] James_F, suddenly all images don't load at all in VE, is this what you were talking about before? [21:50:55] Didn't do the trick so I updated parsoid and templatedata too. Now VE doesn't load at all :( [21:50:56] it just started, though. what in the name of all that is imagey .... [21:51:20] mooeypoo: … no. [21:51:31] My whole page is empty of images :\ [21:51:44] just started happening [21:54:17] mooeypoo: Empty as in the s point to a wrong URL. [21:54:43] empty as in no images are loading at all [21:54:51] the page only shows the text, no images [21:55:04] i tested one image in the page, and the page loaded as if it was completely empty in VE [21:56:09] oh! [21:56:11] now it works [21:56:22] ok this is odd [21:56:31] with debug=true the images load, without it, the images don't [21:56:33] O.o [21:56:58] how do you set debug = true in VE? [21:57:02] that will probably help. [21:57:05] (me) [21:57:06] mvolz: ?debug=true [21:57:09] scratch that, they don't load now with debug=true either [21:57:12] what in the name of.. [21:57:19] oh you just have to append it [21:57:20] mooeypoo: WTF is going on with your setup? [21:57:34] Did you update Parsoid recently or something? Did it break? Are you using images from Commons or locally uploaded ones? [21:57:52] mvolz: Yeah it's just a query string param. Warning: loading things in debug mode is slow as molasses [21:57:57] interesting [21:58:02] [21:58:11] This is the tags I'm getting from the API response [21:58:13] the init [21:58:19] Ooh, aha [21:58:25] This smells of Parsoid bugs [21:58:35] my page only has this wikitext: [[File:A bug's land.JPG|thumb]] [21:58:36] that's it. [21:58:37] mooeypoo: Did you recently either update Parsoid, or mess with your file repo config? [21:58:53] I update Parsoid every time I activate it [21:58:57] OK [21:58:59] but it was a bit earlier today [21:59:05] Also, does this break for images that don't have weird characters in their names? [21:59:20] yep [21:59:28] I have VisualEditor logo [21:59:37] it doesn't load either [21:59:57] [[File:VisualEditor-logo.svg]] <-- that doesn't load either [22:00:23] hah [22:00:24] Let me try [22:00:50] RoanKattouw, when I check the output in parsoid itself it seems to be good [22:01:19] If you're getting mw:Placeholder stuff, I doubt it [22:01:47] yeah, I know, but .. [22:02:18] I tried to see what I get with image wikitext in http://localhost:8000/_wikitext/ [22:02:23] and I get an image html [22:02:25] so... :\ [22:07:08] now it appears [22:07:22] now it doesn't [22:07:23] wtf [22:07:31] RoanKattouw, it seems to come back occasionally [22:07:39] it might be something local on my end, then..? it's so weird [22:07:51] either that, or something with the api? [22:08:38] It could be API-related [22:08:40] RoanKattouw, I found a pattern to when it works and when it doesn't [22:08:52] I think mw:Placeholder is what Parsoid does when it gets bad or no API data [22:08:54] Ooooh, what's that? [22:09:06] so, it works for the first load of the wiki page. Reload = doesn't work, no matter how many refreshes I make [22:09:38] however, if I then go and ask parsoid to process something through the /_wikitext link, it works, *and* the wiki page refreshes [22:09:46] wt [22:09:48] f [22:09:48] could parsoid be caching something? [22:09:51] That's not what happens for me at all [22:09:53] Maybe? [22:10:41] I can't reproduce this at all though [22:10:42] I can consistently reproduce this. [22:10:53] including the pattern [22:11:11] the only thing I changed back and forth on my local settings was language = 'he' and back to langage ='en' [22:11:15] that shouldn't affect anything [22:12:12] What's the output of the Parsoid server in the terminal? [22:12:51] [info][localhost/TestImages] starting parsing [22:12:51] [info][localhost/TestImages?oldid=107] completed parsing in 6925 ms [22:13:00] hah [22:13:08] That means it's probably timing out on an API request somewhere [22:13:24] Could you pastebin the wikitext of that TestImages page? [22:13:36] I should've picked an easier page [22:13:42] it's huge in terms of images [22:13:54] let me get a better example instead [22:13:57] OK, whatever the smallest page you have is that will reproduce this problem [22:14:19] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 (owner: 10Jforrester) [22:14:50] ok, errors are getting thrown.... from calling console.log. console is undefined. [22:14:58] why would console be undefined... [22:15:00] :( [22:15:04] mvolz: WTF [22:15:17] Well production code shouldn't be doing console.log() directly [22:15:29] The only case of console being undefined, AFAIK, though, is in IE when the console isn't open [22:15:43] chromium so far. [22:15:46] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (527ad0ee5a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136802 (owner: 10Jforrester) [22:15:50] I'll try in firefox [22:16:00] Wait, console undefined in *Chromium*? [22:16:01] That's very weird [22:16:17] ok RoanKattouw response from parsoid: [info][localhost/TestImageBug] starting parsing [22:16:17] [info][localhost/TestImageBug?oldid=109] completed parsing in 1910 ms [22:16:17] there's no need for pastebin. the wikitext is simply [22:16:17] [[File:A bug's land.JPG|thumb]] [22:16:17] [[File:VisualEditor-logo.svg]] [22:16:38] Is that the log of a failed parse? [22:16:48] Because 1910ms is too fast for a 5-second timeout to have occurred [22:16:54] it failed, yeah [22:17:38] RoanKattouw, actually these are all failures: [22:17:39] [info][localhost/TestImageBug] starting parsing [22:17:39] [info][localhost/TestImageBug?oldid=109] completed parsing in 121 ms [22:17:39] [info][localhost/TestImageBug] starting parsing [22:17:39] [info][localhost/TestImageBug?oldid=109] completed parsing in 104 ms [22:17:39] [info][localhost/TestImageBug] starting parsing [22:17:41] [info][localhost/TestImageBug?oldid=109] completed parsing in 81 ms [22:17:43] :\ they're all fast [22:17:49] wtf is happening. [22:18:03] Yeah I see the same pattern [22:18:06] But I get no broken images [22:18:39] Oooooh hold on [22:18:48] So Parsoid queries your local MW API [22:18:57] I am getting this on and off [22:19:04] And it relays queries to the Commons API via the ForeignAPIFileRepo system [22:19:19] But that system has caching built into it [22:19:23] right [22:19:25] ah [22:19:33] hm, ok so how do I clear it? [22:19:58] What is $wgMainCacheType set to in your LocalSettings.php ? [22:20:23] CACHE_NONE [22:20:27] hmph [22:20:35] the plot thickens. [22:20:40] * mooeypoo grunts [22:20:43] OK try running the SQL query TRUNCATE objectcache; against your DB [22:21:33] Let's see [22:21:59] (03PS3) 10Alex Monk: Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) [22:23:19] still doesn't work in FF but errors are more sensical. bedtime. night all [22:23:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label"/Close button in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047#c3 (10ryasmeen) Verified the fix in Betalabs [22:24:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label"/Close button in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047 (10ryasmeen) 5RESO/?>3VERI [22:24:05] RoanKattouw, it worked for a second (refresh = images showed) but then on second refresh again images don't show [22:24:16] wtf [22:24:28] Does the Parsoid HTML have mw:Placeholder stuff in it again? [22:25:34] yea [22:27:02] eh, I'm going to be late for dinner with Sumanna [22:27:11] damnit, what the hell is wrong with my wiki [22:27:19] it just started happening, too.. :\ [22:27:40] RoanKattouw, you can't manage to duplicate this at all? [22:27:46]