[00:00:11] <grrrit-wm>	 (03PS7) 10Catrope: Inflict a gruesome death on ve.ce.getOffset() and reincarnate it [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 
[00:07:00] <grrrit-wm>	 (03CR) 10Catrope: "PS5: Fix stupid typo in the code, update tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[00:11:35] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Per Ed, Roan." [oojs/core] - 10https://gerrit.wikimedia.org/r/133855 (owner: 10Krinkle)
[00:11:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] test: Various clean up [oojs/core] - 10https://gerrit.wikimedia.org/r/133856 (owner: 10Krinkle)
[00:12:01] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (26a1027) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136947 
[00:12:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Implement build target optimised for jQuery [oojs/core] - 10https://gerrit.wikimedia.org/r/133855 (owner: 10Krinkle)
[00:12:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: test: Various clean up [oojs/core] - 10https://gerrit.wikimedia.org/r/133856 (owner: 10Krinkle)
[00:12:20] <grrrit-wm>	 (03PS2) 10Catrope: Fix reference dialog apply button disabling when modifying existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136505 (owner: 10Alex Monk)
[00:12:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix reference dialog apply button disabling when modifying existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136505 (owner: 10Alex Monk)
[00:17:26] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (26a1027) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136949 
[00:18:39] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (26a1027) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136947 (owner: 10Catrope)
[00:18:47] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update VE core submodule to master (26a1027) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136949 (owner: 10Jforrester)
[00:20:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (26a1027) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136947 (owner: 10Catrope)
[00:20:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix reference dialog apply button disabling when modifying existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136505 (owner: 10Alex Monk)
[00:20:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This doesn't work at all. The code in applyChanges() for reusing existing references seems to assume insertion and doesn't seem to be able" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[00:26:39] <Krenair>	 RoanKattouw, unrelated to the above change, are you getting "Uncaught TypeError: undefined is not a function" when closing dialogs?
[00:31:00] <RoanKattouw>	 Yes
[00:31:05] <RoanKattouw>	 I fixed it in oojs-ui already
[00:31:13] <RoanKattouw>	 Not sure if the pull-throughs were merged yet
[00:31:37] <RoanKattouw>	 Krenair: Can you confirm that the thing it's complaining isn't a function is this.opened.isResolved() or something similar?
[00:32:51] <Krenair>	 RoanKattouw, https://gerrit.wikimedia.org/r/#/c/136941/3 ?
[00:33:00] <RoanKattouw>	 Yeah
[00:33:02] <RoanKattouw>	 I just realized that isn't merged yet
[00:33:30] <RoanKattouw>	 Krenair: Would you like to use the +2 powers you gained today? ;)
[00:35:58] <grrrit-wm>	 (03CR) 10Alex Monk: Follow-up 205fa98a, 8dd3460a: Move away from isResolved()/isRejected() (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/136941 (owner: 10Catrope)
[00:36:48] <Krenair>	 (just nitpicking, haven't actually checked that this fixes the issue yet)
[00:37:38] <grrrit-wm>	 (03PS4) 10Catrope: Followup 205fa98a, 8dd3460a: move away from isResolved()/isRejected() [oojs/ui] - 10https://gerrit.wikimedia.org/r/136941 
[00:38:23] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Followup 205fa98a, 8dd3460a: move away from isResolved()/isRejected() [oojs/ui] - 10https://gerrit.wikimedia.org/r/136941 (owner: 10Catrope)
[00:38:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 205fa98a, 8dd3460a: move away from isResolved()/isRejected() [oojs/ui] - 10https://gerrit.wikimedia.org/r/136941 (owner: 10Catrope)
[00:40:07] <RoanKattouw>	 Thanks man
[00:40:54] <Krenair>	 done, yay. thanks for figuring that bug out
[00:48:46] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (6379e76bf5) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136959 
[00:50:29] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (6379e76bf5) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136959 (owner: 10Jforrester)
[00:51:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (6379e76bf5) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136959 (owner: 10Jforrester)
[00:52:28] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/136960
[01:16:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Citation dialog changes title after opening - 10https://bugzilla.wikimedia.org/66059 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor
[01:30:01] <wikibugs>	 3VisualEditor: VisualEditor: Duplicate setting of named parameter in template removed when you edit the template in some unrelated way - 10https://bugzilla.wikimedia.org/66009#c1 (10James Forrester) 5UNCO>3RESO/WON This is intended behaviour, yeah; we won't dirty-diff to fix broken wikitext when you edit s...
[01:30:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Citation dialog changes title after opening - 10https://bugzilla.wikimedia.org/66059 (10James Forrester) a:5Trevor Parscal>3None
[01:34:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Draw shields using SVG polygons and getClientRect(s) for inline/block items - 10https://bugzilla.wikimedia.org/51202 (10James Forrester) s:5normal>3enhanc a:3Ed Sanders
[04:25:53] <grrrit-wm>	 (03PS1) 10Mooeypoo: Adjust default alignment when switching from inline to block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136971 (https://bugzilla.wikimedia.org/65564) 
[04:41:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c3 (10Barry Coughlan) I did some more re-thinking about this.  I examined the jQuery code and the 'crossDomain' attribute is jus...
[07:30:25] <grrrit-wm>	 (03PS1) 10Mooeypoo: Apply 'default' or 'custom' size on load [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136980 
[07:34:32] <grrrit-wm>	 (03PS1) 10Mooeypoo: Update image size after changing type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) 
[07:39:36] <grrrit-wm>	 (03PS2) 10Mooeypoo: Apply 'default' or 'custom' size on load [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136980 
[08:30:35] <eranroz>	 hi, do you know of stats for VE edits across projects? (in which  languages VE is more popular?) [I found http://ee-dashboard.wmflabs.org/datasources# but it doesn't compare languages]
[09:05:33] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Unnecessary HTML code is shown when adding template parameters with double quotes - 10https://bugzilla.wikimedia.org/66065 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None To reproduce: 1. Edit an article in the English Wikipedia. 2. Press Ins...
[09:08:46] <edsanders>	 eranroz, you might have to wait until the SF people wake up at 1800UTC
[09:09:43] <eranroz>	 edsanders, thanks (btw what is SF?)
[09:09:50] <edsanders>	 San Fran
[09:09:54] <eranroz>	 :)
[09:13:32] <aharoni>	 eranroz: we in hewiki are pretty active VE adopters and bug reporters :)
[09:14:24] <aharoni>	 and, just like you, I'd love to see more convenient VE metrics
[09:14:35] <aharoni>	 I have two impressions:
[09:14:50] <aharoni>	 in wikis where VE is enabled by default, the usage is higher
[09:15:08] <aharoni>	 so in French and Hebrew the usage is higher (in percents) than in English and German
[09:16:51] <aharoni>	 and the other impression, simply from looking at recent changes tagged as visualeditor in hewiki, is that almost all of them are done by anons and by users who aren't known as experienced hewiki editors.
[09:16:52] <eranroz>	 I think it was error to set in early stage the message "soruce edit" vs just "edit", which make VE the "default" editing mode when it was not mature enougth
[09:17:14] <aharoni>	 both guesses can be confirmed by more careful analysis and visualization.
[09:19:19] <eranroz>	 so based on this I can guess frwiki are active VE adopters too? :)
[09:19:33] <aharoni>	 eranroz: It's definitely mature enough now. As far as my day-to-day experience goes, Wikipedia's VE is considerably less buggy than GMail's rich text editor.
[09:19:56] <aharoni>	 My favorite VisualEditor is Quora. Of course, it's good for Quora's needs, which are less complicated than Wikipedia's.
[09:20:14] <aharoni>	 and yes, it's quite possible that frwiki are active adopters.
[09:20:20] <eranroz>	 yes, I just mentioned it as historical error. Currently VE is pretty mature
[09:20:35] <aharoni>	 French is a big language, but somehow I know very little about frwiki.
[09:49:04] <grrrit-wm>	 (03PS4) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[09:49:06] <grrrit-wm>	 (03PS17) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[09:49:56] <grrrit-wm>	 (03PS5) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[09:49:58] <grrrit-wm>	 (03PS18) 10Esanders: [BREAKING CHANGE] Merge protected node into focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[10:34:51] <mvolz>	 More generally, so whenever I rebase core / ve, ve seems to no longer loads (localhost). Happens 9/10 and happens whether I'm using vagrant to provision or apache on localhost. Does this happen to anyone else? Is there something I'm doing wrong here? Any advice would be appreciated :). 
[10:35:30] <mvolz>	 More specifically, this time I'm getting ""TypeError: OO.ui.ToggleButtonWidget.super.prototype.setValue is undefined" in my console debugger.
[10:42:40] <grrrit-wm>	 (03CR) 10Nikerabbit: "According to the docs [1] these were removed in 1.8 already after being deprecated in 1.7." [oojs/ui] - 10https://gerrit.wikimedia.org/r/136941 (owner: 10Catrope)
[11:13:56] <grrrit-wm>	 (03PS6) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[11:13:58] <grrrit-wm>	 (03PS19) 10Esanders: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[11:14:00] <grrrit-wm>	 (03PS1) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 
[11:14:15] <grrrit-wm>	 (03PS4) 10Esanders: Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 
[11:14:17] <grrrit-wm>	 (03PS1) 10Esanders: Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 
[11:15:23] <grrrit-wm>	 (03PS2) 10Esanders: Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 
[11:15:25] <grrrit-wm>	 (03PS5) 10Esanders: Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 
[11:16:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders)
[11:16:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders)
[11:20:02] <grrrit-wm>	 (03PS3) 10Esanders: Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 
[11:21:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders)
[12:11:07] <grrrit-wm>	 (03PS2) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 
[12:11:09] <grrrit-wm>	 (03PS7) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[12:11:11] <grrrit-wm>	 (03PS20) 10Esanders: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[13:01:25] <mvolz>	 Krenair: re what you were trying to help me with yesterday, I'm looking at the request for template data right now: http://localhost/api.php?format=json&action=templatedata&titles=Template%3ACite+journal&lang=en-gb&redirects=1
[13:02:19] <mvolz>	 Response is the following: {"pages":{}}
[13:02:26] <mvolz>	 well that explains it.
[13:02:27] <mvolz>	 :)
[13:11:59] <mvolz>	 not quite sure where to go from here though. 
[13:24:17] <wikibugs>	 3VisualEditor: VisualEditor: Double colons when linking to File/Category - 10https://bugzilla.wikimedia.org/63353 (10Elitre)
[13:24:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - 10https://bugzilla.wikimedia.org/63355 (10Elitre)
[13:25:17] <wikibugs>	 3VisualEditor: VisualEditor: Double colons when linking to File/Category - 10https://bugzilla.wikimedia.org/63353#c2 (10Elitre) Also happening with FF, Win8. The resulting wikilink works, though.
[14:28:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10Chris McMahon)
[15:08:17] <grrrit-wm>	 (03PS6) 10Alex Monk: [BREAKING CHANGE] Use promises for confirmation dialog instead of done event [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 
[15:14:14] <grrrit-wm>	 (03CR) 10Alex Monk: "It's fine I think, I was just running into that issue with isResolved/isRejected yesterday (and somehow thought it was related to this)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 (owner: 10Alex Monk)
[15:14:21] <James_F>	 mvolz: If you make a null edit to the template (open it, press save without any changes) it should re-calculate any TemplateData.
[15:14:25] <James_F>	 mvolz: (Yay MediaWiki.)
[15:14:53] <Krenair>	 yeah, just remembered that trick and told him in #mediawiki
[15:15:12] <Krenair>	 I ran into this myself on English Wikipedia but couldn't edit the page.
[15:15:28] * James_F nods.
[15:15:30] <James_F>	 (Her.)
[15:15:40] <Krenair>	 Oops. Sorry.
[15:16:00] <Krenair>	 I asked someone in #wikipedia-en to null edit the page, they gave me template editor permissions.
[15:16:19] <mvolz>	 Haha yeah thanks
[15:16:24] <mvolz>	 :)
[15:17:30] <James_F>	 mvolz: BTW, there's a daily stand-up meeting in Google Hangout at 10:00 PDT (18:00 UK time) for the VE team that you're welcome to come along to if you want. No a requirement or anything, just an option if you think it would be helpful.
[15:17:44] <James_F>	 Though the timing might not work out well. :-)
[15:17:46] <Krenair>	 James_F, It would be nice if we could find some way to do it that doesn't involve making an edit to the template page (which is restricted on some wikis)
[15:18:08] <James_F>	 Krenair: Unfortunately MW doesn't re-calc PageProperties without an edit.
[15:18:14] <Krenair>	 yeah :/
[15:18:16] <James_F>	 Krenair: Action=purge doesn't do it, for instance.
[15:18:35] <mvolz>	 Hi James, how do I get to it?
[15:18:42] <mvolz>	 No guarantees but I might be able to pop in
[15:19:14] <James_F>	 mvolz: I'll sling you an invite.
[15:19:33] <mvolz>	 Yeah, Krenair showed me how to do action=purge and only editing did the trick :(
[15:19:53] <mvolz>	 James_F: tnx
[15:21:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c5 (10Alex Monk) So Gerrit change 136496 fixed the existing intended behaviour, but didn't go as far as this bug suggests (i...
[15:24:03] <grrrit-wm>	 (03PS5) 10Alex Monk: MWReferenceDialog: Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) 
[15:53:32] <grrrit-wm>	 (03CR) 10Alex Monk: "Ah yes, looks like I wasn't fully able to test this when I wrote it due to I4b9bb866. I see the issue now, and I think there might be an e" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[15:54:17] <grrrit-wm>	 (03PS6) 10Alex Monk: MWReferenceDialog: Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) 
[17:04:00] <grrrit-wm>	 (03PS4) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 
[17:04:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk)
[17:04:12] <grrrit-wm>	 (03PS5) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 
[17:04:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk)
[17:04:36] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "didnt properly rebase, oops" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk)
[17:04:36] <grrrit-wm>	 (03PS6) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 
[17:05:22] <grrrit-wm>	 (03PS1) 10Esanders: Fix selection after block node drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 
[17:05:28] <grrrit-wm>	 (03CR) 10Divec: [C: 04-1] "Looking good!" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[17:49:57] <grrrit-wm>	 (03PS1) 10Mooeypoo: Small SVG images should still adhere to default thumb size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) 
[18:04:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not highlight/remove default linked text sometimes in automated testing in Chrome - 10https://bugzilla.wikimedia.org/64655#c2 (10Chris McMahon) 5ASSI>3RESO/WOR No consistent repro
[18:10:45] <wikibugs>	 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10ryasmeen)
[18:10:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None This is a tracking bug for all shields/highlights/phantoms related issues.
[18:13:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The previous line is also getting highlighted while adding a reference list - 10https://bugzilla.wikimedia.org/65706 (10ryasmeen)
[18:13:03] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716 (10ryasmeen)
[18:13:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Gallery remains highlighted even after clicking elsewhere in the page - 10https://bugzilla.wikimedia.org/61068 (10ryasmeen)
[18:13:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Gallery Highlight is not getting redrawn in correct position while changing the Heading style applied on it - 10https://bugzilla.wikimedia.org/61766 (10ryasmeen)
[18:13:05] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10ryasmeen)
[18:13:06] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681 (10ryasmeen)
[18:15:31] <grrrit-wm>	 (03PS8) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[18:15:44] <wikibugs>	 3VisualEditor: VisualEditor: Double colons when linking to File/Category - 10https://bugzilla.wikimedia.org/63353#c3 (10WhatamIdoing) Here's a variation:  1.  Edit page on using VisualEditor.  2.  Type the file name you want (with or without the colon prefix that you want):  File:Example.jpg  3.  Open the link...
[18:16:56] <grrrit-wm>	 (03PS3) 10Esanders: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 
[18:19:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10ryasmeen)
[18:20:00] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Reference's highlight is misplaced for the if the references list is placed before the reference - 10https://bugzilla.wikimedia.org/63244 (10ryasmeen)
[18:20:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563 (10ryasmeen)
[18:25:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The previous line is also getting highlighted while adding a reference list/image - 10https://bugzilla.wikimedia.org/65706 (10ryasmeen)
[18:25:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The previous line is also getting highlighted while adding a reference list - 10https://bugzilla.wikimedia.org/65706#c3 (10ryasmeen) The previous line also gets highlighted while adding an image.
[18:25:56] <edsanders>	 TrevorParscal, review https://gerrit.wikimedia.org/r/#/c/135878/ ?
[18:27:49] <edsanders>	 which is fixed in MW by https://gerrit.wikimedia.org/r/#/c/135881/
[18:28:10] <edsanders>	 which allows us to merge https://gerrit.wikimedia.org/r/#/c/134333/ in MW
[18:28:33] <edsanders>	 which are both fixed by https://gerrit.wikimedia.org/r/#/c/134366/ in Math
[18:28:34] <James_F>	 edsanders: Is there a related Math change for these?
[18:28:39] <James_F>	 Ha. Snap. :-)
[18:33:58] <edsanders>	 feel free to use the taser on him if he ever turns up
[18:34:33] <James_F>	 edsanders: He's WFH today…
[18:34:36] <James_F>	 edsanders: It's a Tuesday.
[18:34:54] <edsanders>	 have one delivered to Melissa
[18:35:12] <edsanders>	 or if you really want him to suffer, Cadence
[18:36:22] * James_F laughs.
[18:36:25] <James_F>	 That works for me. :-)
[18:38:31] <TrevorParscal>	 edsanders: lookin
[18:41:27] <TrevorParscal>	 Ed, why did you remove the documentation for model and config args?
[18:41:46] <TrevorParscal>	 edsanders: ping ^
[18:42:30] <grrrit-wm>	 (03CR) 10Krinkle: "Nice." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[18:42:50] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[18:59:35] <edsanders>	 TrevorParscal, duplicatin
[18:59:52] <edsanders>	 *ion
[19:00:20] <edsanders>	 the verbose documentation is in the parent
[19:01:21] <TrevorParscal>	 how do docs inherit for constructors?
[19:02:07] <TrevorParscal>	 I just want to make sure the constructors are documented nicely in the JSDuck output
[19:02:13] <TrevorParscal>	 all for reducing duplication
[19:02:38] <TrevorParscal>	 but if we are going to remove "Configuration options" from there, why not everywhere? or at least more places?
[19:02:45] <TrevorParscal>	 not saying that's a bad idea
[19:03:03] <TrevorParscal>	 just, wondering what you think about how it affects the JSDuck output
[19:18:37] <edsanders>	 sounds like a question for Krinkle ...
[19:21:37] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Inflict a gruesome death on ve.ce.getOffset() and reincarnate it (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[19:24:37] <Krinkle>	 TrevorParscal: edsanders: Hm.. not sure what you're asking.
[19:25:02] <Krinkle>	 Is this using @cfg or @param?
[19:25:45] <Krinkle>	 Anything you want to re-use in child classes and cannot be unset should use @cfg. Like methods, a subclass can't unset those (they can be overrridden though, and new ones added)
[19:26:09] <Krinkle>	 @param is always all or nothing (e.g. you specify none to inherit, you specify one or more, and nothing is inherited, requires duplication)
[19:26:41] <Krinkle>	 There shouldn't be much in the @param though, the way it is now (couple words) seems fine.
[19:26:59] <TrevorParscal>	 Krinkle: so, what is your suggestion re: https://gerrit.wikimedia.org/r/#/c/135878/3/modules/ve/ce/nodes/ve.ce.AlienNode.js,unified
[19:27:01] <Krinkle>	 one of the params can be used as config container 
[19:27:27] <Krinkle>	 eg. @param .. "Configuration options", and specify @cfg keyHere instead of @param [config.keyName]
[19:27:28] <TrevorParscal>	 should we remove the docs (as the patch does) or bring them back (as they were before)
[19:27:50] <Krinkle>	 Oh you mean just the 2/3 word caption?
[19:28:01] <Krinkle>	 TrevorParscal: 
[19:28:01] <TrevorParscal>	 yess
[19:28:33] <TrevorParscal>	 he removed them everywhere, which i felt was probably going to negatively affect the JSDuck output
[19:29:00] <Krinkle>	 Not really. It'll be exactly like the change in the js file. Say "config" instead of "config: Configuration options"
[19:29:40] <Krinkle>	 Hm.. I'd say these params speak for themselves. Given that it is repeated that many times, keeping it everywhere is only repetitive and potentially inconsistent/prone to error.
[19:29:55] <Krinkle>	 If there's no way to get it wrong though, having those few words there can't hurt.
[19:30:18] <Krinkle>	 e.g. short enough so that it can't contain an error.
[19:30:27] <Krinkle>	 just a label
[19:30:45] <TrevorParscal>	 Yeah, I think we should keep them because you and I think they are self explanitory, but a new user may not
[19:31:43] <Krinkle>	 But they don't explain anything. It's just casting of id to label. It doesn't add much.
[19:32:10] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 04-1] "Could you bring the short descriptions for params like model and config back? The documentation getting worse is an avoidable side-effect." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[19:33:06] <grrrit-wm>	 (03PS9) 10Krinkle: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[19:33:38] <grrrit-wm>	 (03CR) 10Krinkle: Block object descriptions from edit (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[19:33:43] <grrrit-wm>	 (03CR) 10Krinkle: "jshint violation" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[19:34:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[19:59:17] <grrrit-wm>	 (03PS1) 10Mooeypoo: Use subpage only for media search string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) 
[20:01:03] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] Use subpage only for media search string (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) (owner: 10Mooeypoo)
[20:01:09] <James_F>	 mooeypoo: Ooh, nice bug to fix. :-)
[20:01:19] <James_F>	 (But issue, sorry! ;-))
[20:01:30] <mooeypoo>	 That was a fast issue!
[20:01:49] * James_F knew it immediately when looking at the code, sorry.
[20:01:53] * James_F is evil.
[20:02:11] <mooeypoo>	 ohh I did not think of that.
[20:02:13] <mooeypoo>	 Hmm.
[20:02:31] <mooeypoo>	 How do I know if a namespace supports subpages? is it in the api?
[20:03:47] <mooeypoo>	 ah, found it
[20:03:48] <mooeypoo>	 I think
[20:09:06] <grrrit-wm>	 (03PS1) 10Alex Monk: Add tabindexes to template editor and required attribute where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) 
[20:16:15] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: The 'beta' element in the edit tab has an overline instead of underline in Firefox - 10https://bugzilla.wikimedia.org/52493#c4 (10Alex Monk) Seems to be already reported as https://bugzilla.mozilla.org/show_bug.cgi?id=727125
[20:18:35] <jeffo>	 hello!
[20:18:49] <James_F>	 Hello jeffo.
[20:19:04] <jeffo>	 I'm having problems implementing visual editor on my mediawiki implementation, and was hoping for some help
[20:19:21] <jeffo>	 i've spent hours trawling the faq and website and i've exhausted myself
[20:19:35] <James_F>	 jeffo: That's not good. What's the problem you're having?
[20:19:55] <jeffo>	 I have parsoid working, e.g. i can goto http://wiki:8000/ and then do the RT test which demonstrates conversion into Html DOM
[20:20:47] <jeffo>	 I can even use parsoid to manually convert pages from my wiki, e.g. http://wiki_name:8000/wiki_name/wiki/Main_Page works fine
[20:20:56] <mooeypoo>	 James_F, I'm running into issues with $wgNamespacesWithSubpages which should be the config option indicating which pages allow for subpages -- when I take it from the wiki config, it seems to be 'null' - but the documentation says its default is "all except 'main' namespace". Any ideas about that?
[20:20:57] * James_F nods.
[20:21:03] <mooeypoo>	 Are you familiar with it by any chance?
[20:21:29] <jeffo>	 but in mediawiki when I click on the Edit button I receive the error "parsoidserver-http-bad-status: 500"
[20:21:30] <James_F>	 mooeypoo: No, sorry – Krenair might be.
[20:21:49] <mooeypoo>	 Krenair, any ideas? are you familiar with $wgNamespacesWithSubpages ?
[20:21:52] <James_F>	 jeffo: Hmm. Do you have VisualEditor configured to point at Parsoid correctly?
[20:22:00] <jeffo>	 i think so
[20:22:16] <jeffo>	 $wgVisualEditorParsoidURL = 'http://localhost:8000';
[20:22:26] <jeffo>	 $wgVisualEditorParsoidPrefix = 'localhost';
[20:22:40] <jeffo>	 $wgVisualEditorParsoidForwardCookies = true;  (because i am using LDAP authentication)
[20:23:29] <James_F>	 jeffo: I take it that your wiki is locked down so only a few pages can be read by unauth'ed users?
[20:23:35] <jeffo>	 thats right
[20:23:55] <James_F>	 What happens when you go to Main_Page?veaction=edit – do you get the same error?
[20:24:11] <jeffo>	 $wgGroupPermissions['*']['read'] = false;
[20:24:41] <jeffo>	 same error if i goto http://wiki_name/wiki/Main_Page?veaction=edit
[20:25:14] <grrrit-wm>	 (03PS1) 10Jforrester: Gallery editor: Fix 'inpsector' typo to 'inspector' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137156 
[20:25:18] <Krenair>	 hi jeffo 
[20:25:23] <jeffo>	 heyo
[20:26:29] <gwicke>	 jeffo, didn't you run parsoid at port 8142?
[20:26:37] <gwicke>	 that's the default port when using the deb
[20:26:56] <jeffo>	 in my troubleshooting i've actually got my mediawiki running on 2 different linux vm's
[20:27:02] <gwicke>	 that'd be $wgVisualEditorParsoidURL = 'http://localhost:8142';
[20:27:12] <jeffo>	 one is centos and that's where i started
[20:27:46] <jeffo>	 in my efforts to fix this, and because all the documentation seemed to be debian/ubuntu native and after learning that enwiki is run on ubuntu, i spun up an ubuntu server and followed the documentation exactly as written
[20:27:47] <grrrit-wm>	 (03PS1) 10Jforrester: Bump the MW required version to 1.24 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 
[20:28:19] <jeffo>	 but i ended up getting the same error there
[20:28:29] <jeffo>	 but now its not that error anymore on that 2nd instance for what its worth
[20:28:50] <jeffo>	 on my 2nd instance, it actually seems to be more broken now
[20:28:59] <jeffo>	 when i click the edit button on that instance, it does nothing
[20:29:11] <James_F>	 I don't recall whether anyone has reported using LDAP authentication successfully for this purpose – might that be the issue?
[20:30:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump the MW required version to 1.24 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 (owner: 10Jforrester)
[20:30:25] <jeffo>	 using mediawiki 1.23 rc2 and the rel1_23 of visualeditor it just does nothing
[20:31:12] <James_F>	 That's not good.
[20:31:17] <jeffo>	 nah not really
[20:31:38] <jeffo>	 that does bring up an interesting question though
[20:31:46] <jeffo>	 what version of mediawiki should i be using
[20:31:48] <jeffo>	 1.22.7?
[20:32:09] <jeffo>	 i see in various discussion pages people using 1.23wmf whatever
[20:32:19] <jeffo>	 and visualeditor seems to be being programmed towards the wmf release
[20:32:22] <James_F>	 I don't think there's a version of VE in the wild that works reliably in 1.22.x, sorry.
[20:32:26] <jeffo>	 rightfully so mind you
[20:32:44] <James_F>	 VE master relies on features in MW master (i.e., in what will be MW 1.24.0)
[20:33:04] <jeffo>	 im unfamiliar with the lingo
[20:33:06] <James_F>	 REL1_23 of VE might not work very well; it was automatically branched rather than actually tested, unfortunately.
[20:33:11] <jeffo>	 oh
[20:33:15] <jeffo>	 WELL
[20:33:20] <jeffo>	 that might be my problem
[20:33:56] <James_F>	 Possibly. I should try to get things set up with REL1_23 and identify all the things that might have been broken by it.
[20:34:21] <jeffo>	 what's the best way to download visualeditor that might work with 1.23?
[20:34:23] <jeffo>	 get the master?
[20:34:47] <James_F>	 No, VE master definitely isn't going to work well with MW 1.23.
[20:34:49] <James_F>	 One moment.
[20:35:01] <jeffo>	 thanks James
[20:35:36] <grrrit-wm>	 (03PS2) 10Jforrester: Bump the MW required version to 1.24 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 
[20:35:55] <jeffo>	 the problem from my perspective seems to be that mediawiki development has semi forked into something called wmf
[20:36:10] <jeffo>	 MW1.24wmf7? what does that mean
[20:36:19] <James_F>	 jeffo: I believe that 48eff393e35ff40a9670d5eb6938930b6d2f08b6 ("wmf/1.24wmf6") should work fine with MediaWiki 1.23.x
[20:36:24] <jeffo>	 wikimediafoundation?
[20:36:27] <Krenair>	 hi mooeypoo 
[20:36:36] <mooeypoo>	 heya Krenair 
[20:36:38] <James_F>	 jeffo: Indeed, if it does we'll probably back-port it to REL1_23.
[20:36:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Bump the MW required version to 1.24 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 (owner: 10Jforrester)
[20:37:03] <mooeypoo>	 Krenair, I am making a few assumptions and I'm hoping I'm correct... you know about http://www.mediawiki.org/wiki/Manual:$wgNamespacesWithSubpages ?
[20:37:23] <mooeypoo>	 The docs are a bit confusing. It says there's a default value, but my local wiki uses default and the variable reads as null
[20:37:24] <James_F>	 jeffo: MW1.24wmf7 is the seventh weekly alpha cut of MediaWiki 1.24, as made by the Wikimedia Foundation, yes.
[20:37:26] <jeffo>	 ok i will see if i can figure out how to get that release of visualeditor
[20:37:56] <James_F>	 jeffo: `git checkout 48eff393e35ff40a9670d5eb6938930b6d2f08b6` should work.
[20:39:18] <jeffo>	 i dont have git setup 
[20:39:26] <jeffo>	 and i have no idea how to use it like developers do
[20:39:52] <James_F>	 jeffo: Ah, OK.
[20:40:04] <Krenair_>	 I think there's something wrong with my VPS. Managed to send a couple of messages earlier but not receive anything until reconnect
[20:40:43] <Krenair_>	 mooeypoo, what code are you using to read the value of it?
[20:41:17] <jeffo>	 ok i cant figure out how to get that specific release
[20:41:22] <jeffo>	 how do i setup git?
[20:41:41] <James_F>	 jeffo: Do you have git installed? If not, `apt-get install git` or whatever.
[20:41:46] <jeffo>	 it is installed
[20:42:03] <jeffo>	 i think i just need to define the repository
[20:42:07] <jeffo>	 but i do not know how to do that
[20:42:13] <mooeypoo>	 Krenair, I added it to the hooks just like wgsvgMaxSize and wgUserOptions
[20:42:35] <mooeypoo>	 Krenair, and then I read it through mw.config.get( 'wgVisualEditor' ).namespacesWithSubpages
[20:42:35] <James_F>	 jeffo: Once that's done, `git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/VisualEditor.git && cd VisualEditor && git checkout 48eff393e35ff40a9670d5eb6938930b6d2f08b6`.
[20:43:19] <James_F>	 jeffo: That will create a directory called 'VisualEditor' and put the latest working-with-1.23 version of VisualEditor into it.
[20:43:25] <Krenair_>	 mooeypoo, wgVisualEditorConfig ?
[20:43:37] <mooeypoo>	 Krenair, yeah I added it to that in the hooks
[20:43:57] <mooeypoo>	 Krenair, hang on, I'll post what I hve to gerrit so you can take a look
[20:44:00] <Krenair>	 ok
[20:44:56] <grrrit-wm>	 (03PS2) 10Mooeypoo: Use subpage only for media search string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) 
[20:45:02] <mooeypoo>	 Krenair, ^^
[20:45:26] <mooeypoo>	 Krenair, I need to sort out the conditions and make the code a bit nicer, but look at the wg variables i'm using
[20:45:28] <mooeypoo>	 it should work, no?
[20:45:38] <Krenair>	 mooeypoo, you need to add that variable to the list of globals
[20:45:41] <mooeypoo>	 it resolves to null. So I figured 'null' means default... but i'm not sure that's true.
[20:45:43] <Krenair>	 global $wgStylePath, $wgSVGMaxSize;
[20:45:46] <jeffo>	 ok bummer
[20:45:49] <Krenair>	 -> global $wgStylePath, $wgSVGMaxSize, $wgNamespacesWithSubpages;
[20:45:52] <mooeypoo>	 Krenair, oh, hah
[20:46:28] <grrrit-wm>	 (03PS3) 10Jforrester: Bump the MW required version to 1.24wmf6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 
[20:46:32] <jeffo>	 im running mediawiki 1.23.0-rc.2 and after downloading that snapshot of visualeditor, it still does not work
[20:46:39] <James_F>	 jeffo: Same outcome?
[20:46:48] <jeffo>	 this is my 2nd instance yeah
[20:46:54] <jeffo>	 i click "edit" and it just does nothing
[20:47:04] <James_F>	 Nothing on the JS console log?
[20:47:20] <jeffo>	 remedial question time: wheres the js console
[20:47:27] <jeffo>	 sry
[20:47:28] <James_F>	 jeffo: Which browser? Chrome?
[20:47:32] <jeffo>	 yes chrome
[20:47:42] <mooeypoo>	 Krenair, ok, it still resolves to null
[20:47:55] <mooeypoo>	 oh, no, sorry, scratch that, apparently that was my cache.
[20:47:57] <mooeypoo>	 Krenair, now it works
[20:47:59] <Krenair>	 :D
[20:48:06] <James_F>	 jeffo: Click on the menu (parallel lines in the top right), Tools, then Javascript Console.
[20:48:11] <mooeypoo>	 yay! Krenair thanks!
[20:48:17] <Krenair>	 you're welcome
[20:48:35] <jeffo>	 all kinds of nasty
[20:48:48] <jeffo>	 Use of "mwCustomEditButtons" is deprecated. Use mw.toolbar instead. 
[20:48:51] <jeffo>	 x4
[20:48:59] <jeffo>	 Calling CSSStyleSheet.insertRule() with one argument is deprecated. Please pass the index argument as well: insertRule(x, 0). 
[20:49:00] <jeffo>	 then that
[20:49:15] <James_F>	 jeffo: Deprecation warnings are not going to break VE.
[20:49:16] <jeffo>	 that last one is adblock though forget that
[20:49:44] <jeffo>	 yeah gosh those are all nonsense
[20:50:24] <mooeypoo>	 Krenair, ok, this is weird. mw.config.get( 'wgVisualEditor' ).namespacesWithSubpages resolves to an array when I load it from User:whatever namespace but it resolves to NULL when I load it from the main namespace
[20:50:32] <mooeypoo>	 that makes no sense
[20:50:34] <Krenair>	 cache?
[20:50:43] <mooeypoo>	 I will empty it again
[20:50:45] <mooeypoo>	 but this is weird
[20:51:14] <jeffo>	 interesting though if i browse manually to http://wiki_name/wiki/Main_Page?veaction=edit it seems like i get an HTML dom of my page..
[20:51:21] <jeffo>	 so that is exciting
[20:51:40] <mooeypoo>	 Krenair, yes. Firefox decided to ignore my cache dumping. It works fine now that I forced it to comply.
[20:51:47] <mooeypoo>	 thanks ;)
[20:55:46] <grrrit-wm>	 (03PS3) 10Mooeypoo: Use subpage only for media search string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) 
[20:55:52] <jeffo>	 ok well that was fail also
[20:55:52] <mooeypoo>	 James_F, ^^ :D
[20:56:16] <jeffo>	 i tried using that snap of visualeditor on 1.22 and it blew it up 
[20:56:42] <jeffo>	 ok so 
[20:56:43] <jeffo>	 lets see
[20:57:36] * James_F runs to meeting.
[21:02:30] <grrrit-wm>	 (03PS4) 10Esanders: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 
[21:03:31] <grrrit-wm>	 (03PS4) 10Esanders: Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 
[21:03:33] <grrrit-wm>	 (03PS5) 10Esanders: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 
[21:03:35] <grrrit-wm>	 (03PS5) 10Esanders: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 
[21:04:40] <grrrit-wm>	 (03CR) 10Esanders: [BREAKING CHANGE] Fix Node construction arguments (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[21:07:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[21:08:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[21:08:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[21:12:07] <jeffo>	 what's the most likely way i would have success implementing visual editor
[21:12:17] <jeffo>	 should i be running 1.24wmf7 on my internal wiki
[21:12:29] <jeffo>	 or should i stick with 1.22.7 or run 1.23 rc2?
[21:12:38] <jeffo>	 things seem rather disconnected
[21:12:50] <edsanders>	 TrevorParscal, well I've done your version for now then
[21:13:00] <TrevorParscal>	 :)
[21:13:49] <MatmaRex>	 jeffo: i'm not part of the development team, but i don't think VE was ever made to work with MW 1.22
[21:14:03] <MatmaRex>	 jeffo: 1.23 rc will turns into a release this thursday, IIRC
[21:14:08] <MatmaRex>	 will turn*
[21:16:18] <jeffo>	 makes sense
[21:16:25] <jeffo>	 what version of mediawiki should i be using?
[21:16:38] <jeffo>	 1.23 rc, the release to come, or one that tracks WMF?
[21:16:51] <jeffo>	 mind, i just want visualeditor to work 
[21:17:00] <jeffo>	 to shutup these people who dont want to deal with markup
[21:17:52] <jeffo>	 alrighty
[21:17:55] <jeffo>	 be back tomorrow
[21:17:59] <jeffo>	 thanks for the help
[21:18:30] <MatmaRex>	 jeffo: i suggest trying the 1.23 release version first
[21:26:22] <Keegan>	 w00t
[21:27:48] <Krenair>	 ?
[21:39:16] <grrrit-wm>	 (03PS1) 10Trevor Parscal: [WIP] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 
[21:40:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal)
[21:40:14] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [WIP] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 
[21:40:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal)
[21:42:00] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 
[21:42:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal)
[22:03:34] <James_F>	 TrevorParscal: Gosh, code in gerrit already? You rock.
[22:08:04] <grrrit-wm>	 (03CR) 10Divec: Inflict a gruesome death on ve.ce.getOffset() and reincarnate it (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[22:29:24] <TrevorParscal>	 James_F: well, you know.. :)
[22:29:44] <TrevorParscal>	 actually the tricky part is next, getting tools to describe the model
[22:29:49] <James_F>	 TrevorParscal: Yeah…
[22:29:54] <James_F>	 TrevorParscal: Links are easy, I guess.
[22:30:05] <James_F>	 TrevorParscal: And references have a serialisation already?
[22:30:18] <James_F>	 s/serialisation/canonical textual description form/
[22:30:19] <TrevorParscal>	 well, actually, when we run getToolsForAnnotations, we loose the context of which annotation the tools that match actually matched
[22:30:29] <TrevorParscal>	 refs will suck
[22:30:58] <James_F>	 Oh. Fun.
[22:31:30] <TrevorParscal>	 we are going to have to render the ref (presumably it's already rendered in the reflist) and then get the jQuery text from that, or something
[22:31:58] <TrevorParscal>	 because if it's a cite template, for instance, there won't be any plain text in the model
[22:32:36] <TrevorParscal>	 i'm torn about whether this rendering belongs in dm, ce or ui
[22:32:44] <TrevorParscal>	 i will sort it out
[22:34:02] <James_F>	 TrevorParscal: DM.
[22:34:16] <James_F>	 TrevorParscal: It's "provide canonical basic-HTML rendering of this content".
[22:34:32] <superm401>	 Is it deliberate that isMsie is false for IE 11?
[22:34:37] <James_F>	 TrevorParscal: Also, it should have <i>, etc.
[22:34:46] <James_F>	 superm401: It's a tech-debt bug, yeah.
[22:34:54] <James_F>	 superm401: So "no" but "known".
[22:35:36] <James_F>	 superm401: In MW you can use jquery.client instead.
[22:35:43] <superm401>	 James_F, okay, so known but not filed.
[22:35:57] <James_F>	 superm401: Huh. I thought I did file it, but maybe not?
[22:36:16] <superm401>	 Yeah, I'm going to make a tracking bug for people removing jQuery.browser so they stop cluttering my log.  That's how I thought of this.
[22:36:30] <superm401>	 James_F, https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=isMsie&list_id=319133 and https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=ve.isMsie&list_id=319132 give nothing.
[22:36:50] <superm401>	 If you don't mind doing the isMsie one, I'll move on.
[22:37:18] <James_F>	 superm401: Hmm, you're right; I'll fix.
[22:39:16] <TrevorParscal>	 James_F: how would MWTransclusionNode provide a basic HTML rendering?
[22:39:20] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: isMsie doesn't catch MSIE 11+ - 10https://bugzilla.wikimedia.org/66096 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[22:39:20] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester)
[22:39:20] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: isMsie doesn't catch MSIE 11+ - 10https://bugzilla.wikimedia.org/66096 (10James Forrester) 3NEW p:3Unprio s:3normal a:3None So odd behaviour untested in MSIE11 for CE isn't done differently…
[22:39:25] <TrevorParscal>	 strip HTML tags?
[22:39:41] <James_F>	 TrevorParscal: Yeah, I was thinking a whitelist of <a>, <i> and <b> and the rest can go hang…
[22:39:53] <James_F>	 TrevorParscal: What do you think?
[22:40:27] <TrevorParscal>	 something like that would work, we need to cache it, and update it when things change...
[22:40:47] <James_F>	 TrevorParscal: Yeah, hence DM. :-)
[22:47:05] <mooeypoo>	 TrevorParscal, I'm trying to add a paragraph with text in it programmatically.. so into a { 'type': 'paragraph' }, { 'type': '/paragraph' } structure.. can I do this?
[22:47:29] <TrevorParscal>	 sure
[22:47:45] <TrevorParscal>	 there's also a way to split up a string into data array items
[22:48:00] <mooeypoo>	 { 'type': 'paragraph', 'internal': { 'generated': 'wrapper' } } <-- this is what I usually insert when I insert a block image
[22:48:12] <mooeypoo>	 only this time I want predefined text in the initial caption -- so, in this paragraph
[22:49:24] <mooeypoo>	 TrevorParscal, It's for the block image caption. I hope this will work out, roan mentioned something about first inserting the image and then pushing in the caption, but that was when I had a separate caption document...
[22:49:54] <TrevorParscal>	 textData = ve.splitClusters( "my string of text" );
[22:50:24] <TrevorParscal>	 you should be able to insert the whole data array, not have to do it in steps
[22:51:10] <mooeypoo>	 oh, so this goes in between the  'paragraph' and '/paragraph' ?
[22:51:30] <mooeypoo>	 or do I need to wrap it again with a text node?
[22:53:42] <mooeypoo>	 hrm. okay, that doesn't work.
[22:55:55] <mooeypoo>	 TrevorParscal, I'm getting "annotation is undefined" when I try to insert the paragraph with the text
[22:57:37] <TrevorParscal>	 hmm
[23:01:29] <mooeypoo>	 I'm trying a different tactic
[23:08:59] <mooeypoo>	 ok, I am getting 'annotation is undefined' in this strategy too
[23:13:06] <grrrit-wm>	 (03PS1) 10Mooeypoo: [wip] Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) 
[23:13:59] <mooeypoo>	 TrevorParscal, can you take a look at that code ? https://gerrit.wikimedia.org/r/#/c/137222/1/modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
[23:14:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) (owner: 10Mooeypoo)
[23:15:06] <mooeypoo>	 TrevorParscal, I tried at first to just insert { 'type': 'paragraph' } .... etc with the splitClusters -- but that produced a "TypeError: annotation is undefined" so I switched to the strategy I use in the image model -- insert the image first, then adjust the caption
[23:15:10] <mooeypoo>	 but that gives me the same error
[23:15:22] <TrevorParscal>	 lol
[23:15:28] <TrevorParscal>	 ok, so, you have to concat
[23:15:35] <TrevorParscal>	 you will laugh when you realize what you've done
[23:15:45] <mooeypoo>	 Better than crying...
[23:15:46] <mooeypoo>	 :D
[23:16:19] <TrevorParscal>	 [ { 'type': 'paragraph' }, 'a',  'b', 'c', { 'type': '/paragraph' } ] not [ { 'type': 'paragraph' }, [ 'a',  'b', 'c' ], { 'type': '/paragraph' } ]
[23:16:28] <mooeypoo>	 oh foo I put it in the wrong place
[23:16:52] <mooeypoo>	 ahha, also that. Interesting
[23:17:12] <TrevorParscal>	 you see, the data array contains objects (elements), single character strings (plain text) and arrays (annotated text)
[23:17:18] <mooeypoo>	 ohhh
[23:17:24] <mooeypoo>	 ha!
[23:18:02] <TrevorParscal>	 So, if b is bold, it would be like this: [ { 'type': 'paragraph' }, 'a',  ['b', annotationSetContainingBold], 'c', { 'type': '/paragraph' } ] 
[23:18:28] <mooeypoo>	 oh, that's why it broke on annotation.
[23:18:40] <TrevorParscal>	 so, when you dumped all your content into a single index of the data array, it saw 'a' with annotation set 'b', and was like, dude, 'b' is not an annotation set!
[23:18:47] <TrevorParscal>	 yeah
[23:19:07] <TrevorParscal>	 more specifically, b[0].annotation (or something like that) was undefined
[23:19:18] * mooeypoo nods
[23:19:18] <TrevorParscal>	 because "b"[0] === "b"
[23:19:18] <mooeypoo>	 okay that makes sense
[23:19:23] <TrevorParscal>	 and "b".annotation === undefined
[23:19:28] <TrevorParscal>	 so there you go
[23:20:12] * TrevorParscal goes back to writing talk about how evil browsers are and why template libraries are akin to one night stands
[23:22:50] <mooeypoo>	 it works! it works! thanks TrevorParscal 
[23:22:57] * mooeypoo does the "IT WORKS!" dance
[23:23:12] <TrevorParscal>	 lol
[23:25:21] <TrevorParscal>	 I apologize for not giving you the 4 hour lecture on how VisualEditor works internally when you started, you got such a soft start as a GSOC student... Normally when people join, I sit them down and pour metric tones of information on them, and the mistake you just made is likely because you weren't given a proper beating, I mean education, in VisualEditor's internals at the get go
[23:30:50] <mooeypoo>	 TrevorParscal, you could spare yourself the trouble if it was in the documentation.. or.. is it?
[23:33:28] <TrevorParscal>	 Well, some of it is documented https://www.mediawiki.org/wiki/VisualEditor/Design/Software_overview and some of it has been described by Roan and I at various conferences http://www.trevorparscal.com/resume/#presentations
[23:35:56] <grrrit-wm>	 (03PS2) 10Mooeypoo: Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) 
[23:36:23] <mooeypoo>	 TrevorParscal, ^^  \o/
[23:36:31] <mooeypoo>	 oooh!! presentations!
[23:40:07] <grrrit-wm>	 (03PS3) 10Mooeypoo: Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) 
[23:41:48] <mooeypoo>	 oh, I was happy too quickly. Damnit. There are description templates. <sigh>
[23:42:13] <grrrit-wm>	 (03PS4) 10Mooeypoo: [wip] Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) 
[23:42:22] <James_F>	 mooeypoo: Hmm. Bug 51032 is going to be exceptionally hard to do…
[23:42:51] <James_F>	 mooeypoo: We've got that blocked on the year-long work Multimedia are going to start doing in a few months to make image descriptions be stored in structured data…
[23:42:51] <mooeypoo>	 yes. Well. I just noticed the fact that there are templates. I thought to myself how hard can it be -- just get the description from the api!
[23:42:53] <mooeypoo>	 meh.
[23:43:09] <mooeypoo>	 Well, foo.
[23:43:33] <mooeypoo>	 James_F, at least one good thing came out of it: I learned how to properly insert text to the data model
[23:44:20] <mooeypoo>	 I wasn't aware of the description templates. <sigh> okay, should I leave this as wip blocked with a comment, or abandon?
[23:45:43] <James_F>	 mooeypoo: Probably abandon. :-(
[23:45:50] <James_F>	 mooeypoo: But yes, good news. :-)
[23:52:29] <mooeypoo>	 hehe
[23:53:06] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: [wip] Use the image description as the caption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137222 (https://bugzilla.wikimedia.org/51032) (owner: 10Mooeypoo)
[23:53:11] <mooeypoo>	 well. okay then.
[23:54:37] <mooeypoo>	 James_F, ed is working on the phantoms/highlights right? https://bugzilla.wikimedia.org/show_bug.cgi?id=62681