[00:08:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Already added category appears again under the new category section in category editor while attempting to add it again - 10https://bugzilla.wikimedia.org/66105 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15561   --> https://bugzilla....
[00:09:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Already added category appears again under the new category section in category editor while attempting to add it again immediately after that - 10https://bugzilla.wikimedia.org/66105 (10ryasmeen) a:3Alex Monk
[00:09:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Already added category appears again under the new category section in category editor while attempting to add it again immediately after that - 10https://bugzilla.wikimedia.org/66105 (10ryasmeen) 5NEW>3ASSI
[00:29:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it - 10https://bugzilla.wikimedia.org/66106 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15562   --> https://bugzilla.wikimed...
[00:29:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10ryasmeen)
[00:30:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it - 10https://bugzilla.wikimedia.org/66106 (10ryasmeen)
[01:16:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3ryasmeen
[01:18:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10James Forrester)
[01:32:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When inserting an image, set its caption by default to be the Commons image description - 10https://bugzilla.wikimedia.org/51032 (10James Forrester)
[01:32:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog - 10https://bugzilla.wikimedia.org/49662 (10James Forrester)
[01:33:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When inserting an image, set its caption by default to be the Commons image description - 10https://bugzilla.wikimedia.org/51032 (10James Forrester)
[01:33:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog - 10https://bugzilla.wikimedia.org/49662 (10James Forrester)
[01:35:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When inserting an image, set its caption by default to be the Commons image description - 10https://bugzilla.wikimedia.org/51032 (10James Forrester) 5PATC>3ASSI
[01:39:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If you have added a category already, typing it in a second time doesn't show it in the list — except if the category is a "red link", in which case it will suggest it as a new one again - 10https://bugzilla.wikimedia.org/66105 (10James Forrester) p:5Unprio>3N...
[01:40:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it and then moving mouse out of the object - 10https://bugzilla.wikimedia.org/66106 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>...
[01:47:30] <grrrit-wm>	 (03PS10) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[01:47:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[01:48:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When inserting an image, set its caption by default to be the Commons image description - 10https://bugzilla.wikimedia.org/51032#c4 (10Tisza Gergő) For the time being, you could use the extmetadata API:  https://en.wikipedia.org/w/api.php?action=query&prop=imagei...
[01:52:10] <grrrit-wm>	 (03CR) 10Jforrester: Block object descriptions from edit (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[01:52:22] <grrrit-wm>	 (03PS11) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[02:07:47] <grrrit-wm>	 (03CR) 10Jforrester: Make TemplateDataGenerator use new types (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[02:08:00] <grrrit-wm>	 (03PS9) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[02:08:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[02:09:23] <grrrit-wm>	 (03PS10) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[02:09:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[02:35:22] <grrrit-wm>	 (03PS1) 10Jforrester: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 
[02:40:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When inserting an image, set its caption by default to be the Commons image description - 10https://bugzilla.wikimedia.org/51032#c5 (10James Forrester) (In reply to Tisza Gergő from comment #4) > For the time being, you could use the extmetadata API: >  > https:/...
[02:51:59] <grrrit-wm>	 (03CR) 10Krinkle: Add a grunt checker for jshint, jscs, csslint, and banana and pass them (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 (owner: 10Jforrester)
[02:52:42] <grrrit-wm>	 (03CR) 10Jforrester: Add a grunt checker for jshint, jscs, csslint, and banana and pass them (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 (owner: 10Jforrester)
[02:57:59] <grrrit-wm>	 (03PS2) 10Jforrester: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 
[03:07:15] <grrrit-wm>	 (03PS1) 10Krinkle: Grunt: Clean up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137260 
[03:08:33] <grrrit-wm>	 (03PS1) 10Krinkle: Grunt: Clean up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137261 
[03:11:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Grunt: Clean up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137261 (owner: 10Krinkle)
[03:12:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Grunt: Clean up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137261 (owner: 10Krinkle)
[03:13:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Grunt: Clean up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137260 (owner: 10Krinkle)
[03:14:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Grunt: Clean up [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137260 (owner: 10Krinkle)
[03:16:24] <grrrit-wm>	 (03PS3) 10Jforrester: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 
[03:23:08] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 (owner: 10Jforrester)
[03:23:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/137254 (owner: 10Jforrester)
[03:23:41] <James_F>	 Whee.
[03:23:44] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Double colons when linking to File/Category - 10https://bugzilla.wikimedia.org/63353 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[03:32:39] <grrrit-wm>	 (03PS11) 10Jforrester: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:32:48] <grrrit-wm>	 (03PS12) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[03:33:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:37:07] <grrrit-wm>	 (03PS12) 10Krinkle: Make use of new Param types in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:37:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make use of new Param types in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:37:53] <grrrit-wm>	 (03PS13) 10Krinkle: Make use of new Param type names in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:38:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make use of new Param type names in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:45:48] <grrrit-wm>	 (03PS14) 10Krinkle: Make use of new Param type names in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:46:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make use of new Param type names in TemplateDataGenerator [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (https://bugzilla.wikimedia.org/60693) (owner: 10Ltrlg)
[03:52:39] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Fix DM node construction, inheritence and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[04:01:27] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Bump the MW required version to 1.24wmf6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 (owner: 10Jforrester)
[04:03:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump the MW required version to 1.24wmf6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137158 (owner: 10Jforrester)
[08:20:07] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[12:46:08] <grrrit-wm>	 (03PS1) 10Esanders: Move comment down so DOCTYPE is on first line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137296 
[12:54:37] <grrrit-wm>	 (03CR) 10Hashar: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137296 (owner: 10Esanders)
[13:02:23] * edsanders spent hours trying to work out why IE9 wasn't loading the two stylesheets from the demo folder. Turns out they are <link> tags 32 and 33 and IE9 only allows 31 link tags
[13:02:50] * edsanders moves VE core build script up the priority queue
[13:08:19] <wikibugs>	 3VisualEditor: VisualEditor: Create distribution files for VE core - 10https://bugzilla.wikimedia.org/66117 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None OOJS(UI) has a build script which creates a dist folder with concatenated JS/CSS and copied images and i18n files. VE should have the same so that:...
[13:10:41] <grrrit-wm>	 (03PS1) 10Esanders: Skip history#replaceState if not available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137298 
[13:42:28] <jeffo>	 Hello
[13:42:52] <jeffo>	 can someone please tell me the most recent compatible versions of mediawiki and a snapshot of VisualEditor were confirmed to work together?
[13:43:14] <jeffo>	 I cannot get VE to work, it may be for many reasons, but i think it's mostly to do with the fact VE is under active development with the WMF fork of mediawiki
[13:43:24] <jeffo>	 so I cannot get it to work
[13:50:21] <mvolz>	 Hi Jeffo, the issue with the snapshot of VE is that it doesn't include the VE core, which is a submodule
[13:51:27] <mvolz>	 jeffo: If you get the stable branch of VE from the git repo, and then do git submodule update --init, it will fetch the core for you
[13:52:08] <mvolz>	 or you can get the core snapshot (although I've never tried that) and put it in extensions/VisualEditor/lib/
[13:53:03] <grrrit-wm>	 (03PS1) 10Alex Monk: Check last existing category for whether or not we're trying to re-add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137307 (https://bugzilla.wikimedia.org/66105) 
[13:53:39] <mvolz>	 also there were changes to both media wiki core and VE this weekend 
[13:53:57] <mvolz>	 so the most current version of VE won't work with the past stable branches, I'm pretty sure.
[13:54:31] <mvolz>	 Those changes were interdependent.
[14:14:03] <jeffo>	 hey back
[14:15:09] <jeffo>	 mvolz yeah ok
[14:15:40] <jeffo>	 really that's very interesting and all but i /really/ need to know what versions of MW are compatible with any snapshot of VE
[14:15:55] <jeffo>	 and i may be using the wrong parlance, snapshot
[14:15:59] <jeffo>	 i have no idea what it means
[14:16:01] <jeffo>	 im not a developer
[14:16:21] <jeffo>	 i am probably selling myself short but i'm only a passable linux sysadmin besides
[14:17:15] <jeffo>	 right now i am having a major problem because i cannot get visualeditor to work at all and its been difficult to find anyone to say whether there exists a version of visualeditor that worked with any mediawiki implementation besides the WMF work
[14:17:18] <jeffo>	 WMF fork
[14:17:38] <jeffo>	 so i feel like a good starting place would be to find out
[14:17:56] <jeffo>	 if there exists any version of mediawiki that has been confirmed functional with visualeditor
[14:18:06] <jeffo>	 outside of the wmf fork
[14:18:15] <jeffo>	 bcause ive been told running wmf fork as an internal wiki is illadvised
[14:46:02] <mvolz>	 jeffo: do you know what version of mediawiki you're running?
[14:46:12] <mvolz>	 This is a list of the stable VE branches: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/VisualEditor,branches
[14:46:47] <mvolz>	 I actually don't know the answer to your question but the VE team is on PDT time and will be in in a few hours
[14:47:22] <mvolz>	 that said, it looks like newest stable verion of MediaWiki is 1.22.7
[14:47:41] <mvolz>	 and the wmf branches seem to be ahead of that
[14:47:46] <mvolz>	 but like I said, I don't really know :)
[14:49:15] <mvolz>	 Maybe it's the REL1_22 branch of VE that goes along with MediaWiki 1.22.7?
[14:50:37] <mvolz>	 I would guess that's the case
[14:57:50] <mvolz>	 I'd try REL1_23 mediawiki core with REL1_23 Visual Editor and REL1_23 Parsoid. Those branches should all work together and they aren't wmf branches. 
[15:15:26] <jeffo>	 i learned yesterday that the REL1_23 release of VE was an automated untested branch that occurred
[15:15:37] <jeffo>	 so its not as good as it would seem
[15:15:37] <mvolz>	 ok, then 1_22 then :)
[15:15:46] <jeffo>	 there's no version of VE that works with 1.22
[15:15:59] <jeffo>	 or at least someone said that yesterday
[15:16:15] <jeffo>	 <MatmaRex> jeffo: i'm not part of the development team, but i don't think VE was ever made to work with MW 1.22
[15:16:21] <mvolz>	 ok they probably know better than I do!
[15:17:18] <mvolz>	 the dev team will be on in an hour or two so so if you hang around long enough they'll probably be able to give you a better answer :)
[15:17:49] <jeffo>	 okok thanks
[15:20:07] <mvolz>	 according to this 1.23 is supposed to come out this month so maybe you'll only have to wait a few weeks :) https://www.mediawiki.org/wiki/Version_lifecycle
[15:20:46] <aharoni>	 hola
[15:21:18] <aharoni>	 If I recall correctly, there was some talk once about checking for bad addition of <nowiki> by the VisualEditor using Abuse Filter.
[15:21:39] <aharoni>	 Was something like this done anywhere? In the English Wikipedia? In any others?
[15:49:31] <wikibugs>	 3VisualEditor / 3Language: The language selector tool takes a long time to load and then to apply - 10https://bugzilla.wikimedia.org/66124 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None When loading the language selection tool from the language annotation, the list takes a very long time to...
[16:00:07] <jeffo>	 so the coming major release of mediawiki will be along with a confirmed compatible version of visual editor extension?
[16:10:45] <wikibugs>	 3VisualEditor / 3Language: The language selector tool takes a long time to load and then to apply - 10https://bugzilla.wikimedia.org/66124#c1 (10ryasmeen) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 65512 ***
[16:10:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c2 (10ryasmeen) *** Bug 66124 has been marked as a duplicate of this bug. ***
[16:14:00] <wikibugs>	 3VisualEditor / 3Language: The language selector tool takes a long time to load and then to apply - 10https://bugzilla.wikimedia.org/66124 (10ryasmeen)
[16:14:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10ryasmeen)
[16:21:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c3 (10Moriel Schottlender) (Additional information from the duplicate bug)  The slowness also means the user can click somewhere on the screen to...
[16:47:55] <jeffo>	 so the coming major release of mediawiki will be along with a confirmed compatible version of visual editor extension?
[17:06:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Gallery editor: Fix 'inpsector' typo to 'inspector' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137156 (owner: 10Jforrester)
[17:07:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Gallery editor: Fix 'inpsector' typo to 'inspector' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137156 (owner: 10Jforrester)
[17:09:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Small SVG images should still adhere to default thumb size (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[17:12:17] <grrrit-wm>	 (03CR) 10Mooeypoo: Small SVG images should still adhere to default thumb size (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[17:15:58] <Krinkle>	 edsanders: TrevorP|Away: https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki/mediawiki.js#L767-L778
[17:20:05] <alteredstate>	 FYI, just added a {{warning}} to http://www.mediawiki.org/wiki/Extension:VisualEditor about the depreciation of Parsoid.php
[17:22:21] <ryasmeen>	 RoanKattouw_away:https://bugzilla.wikimedia.org/show_bug.cgi?id=65512
[17:24:00] <mooeypoo>	 well damnit.
[17:25:11] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] WIP: new test for page options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137355 
[17:27:57] <mvolz>	 alteredstate: is the parsoid extension necessary at all in the current build?
[17:28:31] <gwicke>	 it shouldn't be -- the CSS is now provided by core
[17:29:16] <gwicke>	 the VE folks are just returning to their desks
[17:29:36] <gwicke>	 you might be helped soon ;)
[17:29:54] <alteredstate>	 It probably doesn't, but following the instructions on the wiki that parsoid.php require causes a 500
[17:31:06] <edsanders>	 divec, are you sure it's today, I just did a Baidu News search for Tianenmen and got nothing: http://goo.gl/f88i1u
[17:35:10] <James_F>	 alteredstate: Aha, yes, thanks for that; it changed last week.
[17:38:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move comment down so DOCTYPE is on first line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137296 (owner: 10Esanders)
[17:38:40] <alteredstate>	 James_F: do you know of a newer instructions to get it working... right now the edit beta tab doesn't even appear on the newest git pulls
[17:39:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Skip history#replaceState if not available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137298 (owner: 10Esanders)
[17:39:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move comment down so DOCTYPE is on first line [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137296 (owner: 10Esanders)
[17:39:55] <alteredstate>	 I'm on 1.24alpha (c265c30)
[17:40:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Skip history#replaceState if not available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137298 (owner: 10Esanders)
[17:40:20] <alteredstate>	 VE 0.1.0 (70fc15d) 04:03, 4 June 2014
[17:41:43] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Small SVG images should still adhere to default thumb size (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[17:41:53] <biberao>	 hi
[17:42:08] <biberao>	 going to upgrade VE
[17:42:32] <James_F>	 alteredstate: We've not written any newer instructions, no; beyond the code, the wiki is it.
[17:43:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Small SVG images should still adhere to default thumb size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[17:43:41] <James_F>	 alteredstate: Are there any JS console errors?
[17:43:56] <James_F>	 alteredstate: Note that the latest VE requires MW 1.24alpha.
[17:49:20] <alteredstate>	 yeah I'm on 1.24alpha (c265c30)
[17:49:39] <James_F>	 alteredstate: Ah, sorry, yes, you said.
[17:52:19] <alteredstate>	 wow yeah jeez
[17:52:32] <alteredstate>	 but not VE or MW
[17:53:17] <alteredstate>	 apparently node installed as usr/local/bin/node not usr/local/bin/nodejs
[17:53:20] <James_F>	 alteredstate: Lots of JS console errors but none of them from MW or VE?
[17:53:28] <James_F>	 alteredstate: Ah, are you running on Debian?
[17:53:33] <alteredstate>	 I did a ln and every thing is working now
[17:53:36] <alteredstate>	 yes
[17:53:51] <James_F>	 That would be the problem, sorry; Debian's packagers made some, umm, interesting choices.
[17:53:53] <alteredstate>	 you ask that like you were expecting it lol
[17:54:01] <James_F>	 Yeah. It's bitten a few of us. :-(
[17:54:26] <James_F>	 Maybe we should put something in the installation notes about Debain not playing nicely with node…
[17:54:35] <James_F>	 Also Debian. :-)
[17:54:54] <alteredstate>	 heh true... as a debian user that's depressing though lol
[17:55:07] <edsanders>	 James_F, you got as far as concatenating css?
[17:57:54] <grrrit-wm>	 (03CR) 10Esanders: [WIP] Use ContextWidget instead of toolbar inside context menu (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal)
[17:57:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c5 (10Moriel Schottlender) After further examination, this isn't an image bug per say, it is a list bug.  When the image is transformed f...
[17:58:11] <mooeypoo>	 James_F, Sherry helped me figure out the bug behavior here: https://bugzilla.wikimedia.org/show_bug.cgi?id=65924
[17:58:43] <mooeypoo>	 James_F, this is a list item issue (and I think we have it with different things too like users trying to write multiline list items with shift-enter)
[17:59:06] <biberao>	 what could be the issue when somethings saving something with VE it says busy for quite some time?
[17:59:08] <mooeypoo>	 The wikitext doesn't reflect what we see on the screen
[18:01:04] <alteredstate>	 heh weird, logged out and back in and the edit button is gone again
[18:02:34] <mooeypoo>	 oh dear goodness, SVGs.
[18:03:02] <grrrit-wm>	 (03CR) 10Esanders: Inflict a gruesome death on ve.ce.getOffset() and reincarnate it (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[18:03:25] <edsanders>	 RoanKattouw_away, so one can put the cursor inside a protected node now? ^^
[18:04:30] <jeffo>	 alteredstate
[18:04:33] <jeffo>	 i can't get VE working either
[18:04:36] <jeffo>	 what are you doing?
[18:05:32] <alteredstate>	 mine did work after I made a symbolic link from node->nodejs.. but when I logged out to change users I lost it again
[18:05:46] <alteredstate>	 (edit tab no longer shows, only edit source)
[18:05:55] <grrrit-wm>	 (03CR) 10Mooeypoo: "Followup" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137054 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[18:06:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c6 (10Ed Sanders) Why does it always add a paragraph? Surely that's for fixUpInsertion to decide?
[18:06:25] <James_F>	 alteredstate: Does it show when you log back in?
[18:06:29] <alteredstate>	 no
[18:06:35] <James_F>	 That's… very odd.
[18:06:40] <James_F>	 Did your preferences change?
[18:06:59] <alteredstate>	 no
[18:07:48] <alteredstate>	 heh I don't think it's the software
[18:07:52] <alteredstate>	 it's something on my install
[18:11:31] <alteredstate>	 jeffo: are you getting any errors? I think I've seen them all this morning lol
[18:17:02] <grrrit-wm>	 (03PS1) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos and third parties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 
[18:17:12] <James_F>	 Oh, yes, there was a bug.
[18:19:35] <grrrit-wm>	 (03PS2) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos etc. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) 
[18:20:16] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Create distribution files for VE core - 10https://bugzilla.wikimedia.org/66117 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc a:3James Forrester
[18:21:21] <edsanders>	 James_F, VE (caps) ?
[18:21:37] <edsanders>	 (outro.js.txt)
[18:22:26] <James_F>	 edsanders: Oops, yeah, forgot that one.
[18:22:28] * James_F fixes.
[18:22:40] <grrrit-wm>	 (03PS3) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos etc. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) 
[18:22:41] <edsanders>	 don't think we need the closure
[18:22:46] <James_F>	 Also some file paths.
[18:23:00] <James_F>	 If you're sure, sure. I was just following the OOUI model.
[18:24:34] <grrrit-wm>	 (03PS4) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos etc. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) 
[18:25:29] <James_F>	 It needs some path munging and we should think about paths in general – really modules/ve -> src/ and modules/ve/i18n/ -> i18n/ and modules/unicodejs -> lib/unicodejs (with a new repo maybe?).
[18:25:42] <James_F>	 But I thought it'd be more valuable to get some feedback for now. :-)
[18:25:55] <James_F>	 (It's also not used by the demos yet; that'd be a follow-up.)
[18:26:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c7 (10Moriel Schottlender) If we can have fixUpInsertion insert the image into an existing paragraph in the case of lists, that can be a...
[18:26:58] <edsanders>	 there's a new recursive function in there, don't we already have that in buildloader?
[18:27:14] <James_F>	 edsanders: I wrote both; they need to do totally different things.
[18:27:33] <James_F>	 edsanders: Also, the idea is that we'd massively simplify buildloader once we're happy with this approach.
[18:32:24] <James_F>	 mooeypoo: Can I close https://bugzilla.wikimedia.org/show_bug.cgi?id=62893 or were you going to do another patch for "the other path"?
[18:35:12] <mooeypoo>	 James_F, I'm making another patch
[18:35:27] <James_F>	 mooeypoo: OK. :-)
[18:35:31] <mooeypoo>	 Running into unexpected weirdness in scalable, so it's taking a bit longer than I expected.
[18:35:45] * James_F nods.
[18:39:25] <jeffo>	 alteredstate, i am getting a parsoid 500 error 
[18:39:35] <jeffo>	 i heard you mention 500
[18:39:41] <jeffo>	 but i didnt know if it were the same as mine or not
[18:40:41] <alteredstate>	 yeah mine was from an include, not the actual service
[18:44:56] <jeffo>	 so your wiki is working with visual editor
[18:45:00] <jeffo>	 what versions are you using together?
[18:46:23] <alteredstate>	 Mine is working now.  Wikimedia V1.24 alpha - VisualEditor 0.1.0 (70fc15d) 04:03, 4 June 2014 - 
[18:46:50] <James_F>	 alteredstate: What did you do to get it working the second time? Is there a bug we need to fix?
[18:47:06] <alteredstate>	 PEBKAC issue
[18:47:12] <James_F>	 Ha. :-)
[18:53:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This -1 adjustment was added deliberately in ea78f230 to prevent behavior like: http://i.imgur.com/CQK9rhj.png . In this screenshot, it's " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137307 (https://bugzilla.wikimedia.org/66105) (owner: 10Alex Monk)
[19:04:25] <grrrit-wm>	 (03CR) 10Catrope: Inflict a gruesome death on ve.ce.getOffset() and reincarnate it (035 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[19:04:41] <grrrit-wm>	 (03PS2) 10Alex Monk: Check last existing category for whether or not we're trying to re-add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137307 (https://bugzilla.wikimedia.org/66105) 
[19:04:55] <Krenair>	 RoanKattouw, ugh. I guess it was some case like that.
[19:05:09] <Krenair>	 This function is horrible.
[19:05:47] <James_F>	 Krenair: :-(
[19:05:49] <Krenair>	 guessed it was*
[19:07:05] <Krenair>	 It's partially my fault.
[19:08:27] <Krenair>	 Probably mostly my fault.
[19:09:06] <grrrit-wm>	 (03CR) 10Inez: "Happy to see you working on this function." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)
[19:09:33] <James_F>	 InezK: See you in 20 minutes?
[19:09:44] <InezK>	 James_F: yes
[19:10:09] <James_F>	 Good.
[19:11:40] <Krenair>	 And I'm pretty sure some of the checks dealing with redirects are broken. I might just re-write it.
[19:11:52] <RoanKattouw>	 Krenair: It's a piece of garbage, feel free to set it on fire
[19:15:00] <mooeypoo>	 what in the name of all that is deferred is going on to scalable promises 
[19:15:03] * mooeypoo mutters
[19:16:18] <mooeypoo>	 RoanKattouw, images are not being updated with mediatype, so I put a debug stop on the line for "this.scalablePromise = ve.init.mw.Target.static.apiRequest(" in ve.dm.MWImageNode and also on its '.then' and on several lines inside the function inside the 'then' including the one that's supposed to update this.mediaType
[19:17:35] <mooeypoo>	 RoanKattouw, and they're not triggering... even after I can see the API response complete in the console. How can that be? :\
[19:18:20] <mooeypoo>	 the first line of the request and the 'then' is triggering, but anything inside the anonymous function isn't, and the image doesn't get the correct mediaType 
[19:20:55] <alteredstate>	 thanks for all the help VE folks.
[19:52:31] <wikibugs>	 3VisualEditor: VisualEditor: some external link urls not accepted - 10https://bugzilla.wikimedia.org/66135 (10Gabriel Wicke) 3NEW p:3Unprio s:3normal a:3None VE does not seem to accept the following link:  https://graphite.wikimedia.org/render/?width=588&height=310&_salt=1401910888.742&from=00%3A00_201...
[19:53:12] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] new test for page options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137355 
[19:53:14] <wikibugs>	 3VisualEditor: VisualEditor: some external link urls not accepted - 10https://bugzilla.wikimedia.org/66135#c1 (10Gabriel Wicke) Browser: Chromium 35.0.1916.114 Debian Linux
[19:55:07] <grrrit-wm>	 (03PS1) 10Mooeypoo: Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) 
[20:07:54] <grrrit-wm>	 (03PS3) 10Cmcmahon: [BrowserTest] new test for page options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137355 
[20:13:59] <wikibugs>	 3VisualEditor: VisualEditor: some external link urls not accepted - 10https://bugzilla.wikimedia.org/66135#c2 (10Gabriel Wicke) This shows up in the JS console:  Failed to load resource: the server responded with a status of 400 (Bad Request) https://www.mediawiki.org/w/api.php?format=json&action=query&generat...
[20:42:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None This results in a quite bad outcome for the user, totally inexplicably. Inste...
[20:42:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139 (10James Forrester) p:5Unprio>3Normal s:5normal>3major
[20:43:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139 (10James Forrester)
[20:43:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should not send external link urls to the API for suggestions (because it won't be valuable) - 10https://bugzilla.wikimedia.org/66135#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High This is two separate bugs – we shouldn't be sending thes...
[21:23:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester)
[21:23:31] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10James Forrester)
[21:23:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10James Forrester)
[21:23:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644 (10James Forrester)
[21:23:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester)
[21:23:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343 (10James Forrester)
[21:23:46] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - 10https://bugzilla.wikimedia.org/62590 (10James Forrester)
[21:23:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester)
[21:24:46] <James_F>	 mooeypoo: For https://bugzilla.wikimedia.org/show_bug.cgi?id=65924 (images and lists) do you know if you or edsanders are going to be able to fix it in the next few hours? :-)
[21:25:18] <James_F>	 mooeypoo: Also https://bugzilla.wikimedia.org/show_bug.cgi?id=65916 which looks like the UI is not getting selected correctly the first time it's enabled.
[21:26:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] The previous line is also getting highlighted while adding a reference list/image - 10https://bugzilla.wikimedia.org/65706 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[21:27:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal - 10https://bugzilla.wikimedia.org/63091 (10James Forrester) a:3Roan Kattouw
[21:34:29] <edsanders>	 James_F, you can't bundle the third party libraries in the dist file
[21:34:59] <edsanders>	 for one rangy doesn't use strict
[21:35:51] <edsanders>	 well that can be fixed by removing use strict from intro, but nonetheless we shouldn't have a lib folder
[21:36:29] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c1 (10Alex Monk) (In reply to Derk-Jan Hartman from comment #0) > Dialogs don't keep focus inside the dialog (can be fixed with putting > aria-hidden=true on the rest of the content of the page  So just aria-hidden=true on t...
[22:03:24] <grrrit-wm>	 (03CR) 10Esanders: "FIXME: one case of hard coded png background in a CSS for a class, instead of raster/vector" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal)
[22:03:31] <edsanders>	 TrevorP|Away, Fixme on https://gerrit.wikimedia.org/r/#/c/116651/
[22:03:52] <RoanKattouw>	 mooeypoo: Sorry for my unresponsiveness, back now
[22:04:03] <RoanKattouw>	 divec: In case you still want to talk, I have finally made it to my desk after all these meetings
[22:11:30] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Minor things" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[22:11:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Check last existing category for whether or not we're trying to re-add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137307 (https://bugzilla.wikimedia.org/66105) (owner: 10Alex Monk)
[22:11:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use subpage only for media search string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) (owner: 10Mooeypoo)
[22:11:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Check last existing category for whether or not we're trying to re-add it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137307 (https://bugzilla.wikimedia.org/66105) (owner: 10Alex Monk)
[22:11:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use subpage only for media search string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137151 (https://bugzilla.wikimedia.org/51290) (owner: 10Mooeypoo)
[22:14:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If you have added a category already, typing it in a second time doesn't show it in the list — except if the category is a "red link", in which case it will suggest it as a new one again - 10https://bugzilla.wikimedia.org/66105#c3 (10Alex Monk) 5PATC>3RESO/FIX...
[22:14:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Add tabindexes to template editor and required attribute where appropriate (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[22:15:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If you have added a category already, typing it in a second time doesn't show it in the list — except if the category is a "red link", in which case it will suggest it as a new one again - 10https://bugzilla.wikimedia.org/66105 (10Alex Monk)
[22:16:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "I'd like to get Trevor's take on how to best approach this, but this seems a bit excessively all-you-have-is-a-hammer-y to me. We already " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[22:19:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Update image size after changing type (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)
[22:21:01] <grrrit-wm>	 (03CR) 10Alex Monk: Add tabindexes to template editor and required attribute where appropriate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[22:30:22] <grrrit-wm>	 (03PS2) 10Alex Monk: Add tabindexes to template editor and required attribute where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) 
[22:32:27] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Add tabindexes to template editor and required attribute where appropriate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[22:33:03] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Adjust default alignment when switching from inline to block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136971 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo)
[22:33:38] <grrrit-wm>	 (03CR) 10Krinkle: Add tabindexes to template editor and required attribute where appropriate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[22:36:35] <grrrit-wm>	 (03CR) 10Krinkle: Add tabindexes to template editor and required attribute where appropriate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[22:37:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adjust default alignment when switching from inline to block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136971 (https://bugzilla.wikimedia.org/65564) (owner: 10Mooeypoo)
[22:38:59] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c2 (10Krinkle) Define "main document"? The dialog is technically a child of the main <body> and <html>, I assume we'll want to add it lower than that. We can't guarantee our dialog is the only thing next to that that is focu...
[22:40:08] <grrrit-wm>	 (03PS3) 10Alex Monk: Add tabindexes to template editor and required attribute where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) 
[22:42:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[22:43:08] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556...
[22:43:08] <James_F>	 edsanders|away: (But yes, licensing FTW.)
[22:43:23] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Don't allow inserting blank citations (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk)
[22:45:50] <grrrit-wm>	 (03PS1) 10Catrope: Fix potential race condition with nulling out Dialog/Inspector fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137479 
[22:45:56] <RoanKattouw>	 TrevorP|Away: ---^^
[22:48:37] <grrrit-wm>	 (03CR) 10Catrope: "Functionally OK, just the minor issues in the inline comments and apart from that it's good to go." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk)
[22:52:37] <grrrit-wm>	 (03PS8) 10Alex Monk: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) 
[22:55:41] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk)
[22:56:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715 (10James Forrester) 5PATC>3RESO/FIX
[22:56:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715 (10James Forrester)
[22:57:14] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester)
[22:57:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't allow inserting blank citations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136436 (https://bugzilla.wikimedia.org/64715) (owner: 10Alex Monk)
[23:05:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Default search text for images should ignore text before / in namespaces which support sub-pages - 10https://bugzilla.wikimedia.org/51290 (10James Forrester) 5PATC>3RESO/FIX
[23:11:55] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/136314
[23:12:00] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/137479
[23:13:05] <James_F>	 mooeypoo: Are you fixing https://gerrit.wikimedia.org/r/#/c/137442/ or should I and let you get on with important things?
[23:13:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Apply 'default' or 'custom' size on load [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136980 (owner: 10Mooeypoo)
[23:13:28] <RoanKattouw>	 I'll fix it
[23:14:48] <mooeypoo>	 what? who? sorry, I am trying to figure out something in scalable
[23:15:07] <mooeypoo>	 oh, I was working on the other fix
[23:15:12] <mooeypoo>	 thanks RoanKattouw !
[23:15:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Apply 'default' or 'custom' size on load [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136980 (owner: 10Mooeypoo)
[23:18:55] <grrrit-wm>	 (03PS2) 10Catrope: Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:19:41] <grrrit-wm>	 (03CR) 10Catrope: "PS2: unify .getMediaType() between MWImageNode and MWImageModel, fix docs, complain about duplication" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:19:51] <RoanKattouw>	 mooeypoo: You may want to read the PS1..PS2 diff there
[23:19:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:20:06] <grrrit-wm>	 (03CR) 10Mooeypoo: Update image size after changing type (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)
[23:20:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:20:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136783 (https://bugzilla.wikimedia.org/66039) (owner: 10Jforrester)
[23:21:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136782 (https://bugzilla.wikimedia.org/66039) (owner: 10Jforrester)
[23:21:50] <mooeypoo>	 RoanKattouw, wait, so "setMediaType" should go away too if that's the case
[23:22:19] <mooeypoo>	 "getMediaType" takes it from the image itself, no need to set the media type individually for the model
[23:22:19] <grrrit-wm>	 (03CR) 10Catrope: Update image size after changing type (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)
[23:22:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf6) - 10https://gerrit.wikimedia.org/r/136783 (https://bugzilla.wikimedia.org/66039) (owner: 10Jforrester)
[23:22:32] <RoanKattouw>	 mooeypoo: I don't really understand the mediaType mess very well
[23:22:39] <mooeypoo>	 it used to be only in the model
[23:22:48] <mooeypoo>	 then i had to use it in the node, and the model got redundant
[23:22:53] <RoanKattouw>	 I just added FIXME comments in the hope that someone more knowledgeable (read: you) would clean it up later
[23:22:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use <visualeditor-toolbar-cite-label> correctly in the Media and Reference toolbars [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/136782 (https://bugzilla.wikimedia.org/66039) (owner: 10Jforrester)
[23:22:59] * mooeypoo nods
[23:23:08] <mooeypoo>	 should I edit this patchset or create another one?
[23:23:37] <RoanKattouw>	 Hold on one second
[23:23:46] <grrrit-wm>	 (03PS3) 10Catrope: Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:23:48] <RoanKattouw>	 There
[23:23:50] <RoanKattouw>	 Go amend that one
[23:24:02] * mooeypoo goes to amend
[23:25:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add tabindexes to template editor and required attribute where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[23:28:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add tabindexes to template editor and required attribute where appropriate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137152 (https://bugzilla.wikimedia.org/65474) (owner: 10Alex Monk)
[23:28:42] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Fix potential race condition with nulling out Dialog/Inspector fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137479 (owner: 10Catrope)
[23:29:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix potential race condition with nulling out Dialog/Inspector fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137479 (owner: 10Catrope)
[23:34:27] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Change padding on media search results so we can display 4 results on a row with a scrollbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136314 (https://bugzilla.wikimedia.org/64911) (owner: 10Alex Monk)
[23:35:01] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Change padding on media search results so we can display 4 results on a row with a scrollbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136314 (https://bugzilla.wikimedia.org/64911) (owner: 10Alex Monk)
[23:36:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal - 10https://bugzilla.wikimedia.org/63091#c1 (10Roan Kattouw) This is hard to fix. Blacklisted annotation types are done on a per-node-type basis. Normal references are of type 'mwReference', but citations are...
[23:36:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change padding on media search results so we can display 4 results on a row with a scrollbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136314 (https://bugzilla.wikimedia.org/64911) (owner: 10Alex Monk)
[23:37:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal - 10https://bugzilla.wikimedia.org/63091#c2 (10Roan Kattouw) For templates we may need to have some kind of function that dynamically determines whether the template is linkable :(
[23:37:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: If a user has scrollbars on (e.g. on Windows/Linux), the width of the media search dialog is insufficient and so displays 4 results and a large margin per row - 10https://bugzilla.wikimedia.org/64911 (10Roan Kattouw) 5PATC>3RESO/FIX
[23:39:01] <RoanKattouw>	 mooeypoo: I'm reserving judgment until your other changes land, but there's some crazy shit going on with the alignment part of the media edit dialog
[23:39:46] <mooeypoo>	 RoanKattouw, some of it might be due to things awaiting merge
[23:39:56] <RoanKattouw>	 See bug 65916
[23:40:03] <RoanKattouw>	 I'm writing a comment there to explain more crazy behavior
[23:40:59] <mooeypoo>	 ah, i saw that one and didn't check into it yet, but it sounds like a bug in select widget
[23:41:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916#c1 (10Roan Kattouw) Also, if you set the image type to Basic, the alignment checkbox will behave really strangely...
[23:41:20] <RoanKattouw>	 "Go home alignment widget, you're drunk." ----^^
[23:41:27] <grrrit-wm>	 (03PS4) 10Mooeypoo: Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) 
[23:41:59] <mooeypoo>	 f you set to basic and the alignment is default the alignment box is supposed to be unchecked
[23:42:32] <RoanKattouw>	 Yeah, but it's not supposed to resist being checked
[23:42:40] <RoanKattouw>	 It fights you
[23:42:50] <mooeypoo>	 ahha
[23:42:53] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:42:56] <mooeypoo>	 ... yes, that's.. not supposed to happen.
[23:43:09] <mooeypoo>	 I have a feeling why it does that, though
[23:43:13] <mooeypoo>	 guess what it is again?
[23:43:16] <mooeypoo>	 *default alignment*
[23:43:36] <mooeypoo>	 The evilness that is default alignment between block and inline images.
[23:44:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup to small SVG default size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137442 (https://bugzilla.wikimedia.org/62893) (owner: 10Mooeypoo)
[23:45:25] <mooeypoo>	 RoanKattouw, you know why this happens, right? I just **had** to say I need more bugs to fix in today's standup.
[23:45:37] <RoanKattouw>	 haha
[23:46:01] <RoanKattouw>	 mooeypoo: Also, about https://gerrit.wikimedia.org/r/#/c/136981/1 : since it fixes a bug and it's Wednesday, I can merge it under protest, but it's indicative of a bug in scalable that needs to be looked at
[23:46:13] <RoanKattouw>	 We can merge it with a tech debt bug assigned to you if you like
[23:46:32] <mooeypoo>	 RoanKattouw, yeah, I tend to agree. Something's up with scalable *and* the media size widget 
[23:46:47] <mooeypoo>	 I'm thinking of adding defaults to scalable, but that's a bit more elaborate than this fix
[23:46:52] <mooeypoo>	 so maybe a tech debt
[23:48:16] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: ve.dm.MWImageModel#getUpdatedAttributes shouldn't need to modify Scalable - 10https://bugzilla.wikimedia.org/66149 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Moriel Schottlender See comments on https://gerrit.wikimedia.org/r/#/c/136981
[23:48:48] <grrrit-wm>	 (03PS2) 10Catrope: Update image size after changing type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)
[23:49:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Merging under protest, I dislike the approach but it fixes a bug. Filed tech debt bug https://bugzilla.wikimedia.org/66149" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)
[23:50:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update image size after changing type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136981 (https://bugzilla.wikimedia.org/65886) (owner: 10Mooeypoo)