[00:00:00] * mooeypoo shoots her computer
[00:01:53] <mooeypoo>	 James_F, RoanKattouw, will I be stoned to death if I suggest we should also get mediatype information on images from Parsoid, considering the fact they behave differently?
[00:02:03] <RoanKattouw>	 Not by us
[00:02:05] <RoanKattouw>	 Maybe by them
[00:02:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Changing image from floated (right+basic) to thumb does not update size correctly - 10https://bugzilla.wikimedia.org/65886 (10James Forrester) 5PATC>3RESO/FIX
[00:02:44] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: ve.dm.MWImageModel#getUpdatedAttributes shouldn't need to modify Scalable - 10https://bugzilla.wikimedia.org/66149 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc
[00:02:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Use promises for confirmation dialog instead of done event [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 (owner: 10Alex Monk)
[00:02:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Changing image from floated (right+basic) to thumb does not update size correctly - 10https://bugzilla.wikimedia.org/65886 (10James Forrester)
[00:03:02] <James_F>	 mooeypoo: You mean images rather than figures?
[00:03:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Use promises for confirmation dialog instead of done event [oojs/ui] - 10https://gerrit.wikimedia.org/r/136542 (owner: 10Alex Monk)
[00:03:31] <mooeypoo>	 "BITMAP" vs "DRAWING"
[00:04:11] <mooeypoo>	 The difference between how these two behave is fairly significant, especially size-wise
[00:04:20] <gwicke>	 mooeypoo, there's a bug about providing original dimensions somewhere
[00:04:26] <gwicke>	 moment..
[00:04:35] <mooeypoo>	 gwicke, aye, I posted it I believe
[00:04:47] <gwicke>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=62881
[00:05:03] <mooeypoo>	 gwicke, that's why I was worrying about suggesting yet another addition.. I know you were concerned about having to supply too much data
[00:05:22] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/133944/
[00:05:33] <gwicke>	 the current thinking is towards separating out data-mw as well
[00:05:37] <mooeypoo>	 We're dealing with things now by requesting another api call, but mediatype seems to be an inherent attribute, I was thinking it makes sense to get it initially.
[00:05:50] <gwicke>	 and letting VE retrieve it separately as a JSON blob
[00:05:58] * mooeypoo nods
[00:06:11] <gwicke>	 which should make the size issue moot for normal page views
[00:06:30] <Krenair>	 RoanKattouw, thanks. So I think we need to pull the newer version of oojs-ui into core/ve
[00:06:44] <RoanKattouw>	 Krenair: James is already doing that
[00:06:47] <gwicke>	 mooeypoo, can you just add that request to the bug?
[00:06:49] <Krenair>	 okay
[00:06:51] <RoanKattouw>	 But he got pulled away from his desk
[00:07:07] <gwicke>	 we have that info readily available at render time, so it's easy to add
[00:07:12] <mooeypoo>	 gwicke, yeah the size is probably unnecessary for anything other than an editor. We need it for editing purposes. "mediatype" might be a different issue, though, I'm not sure. We definitely need it for editing, but it *might* be beneficial for other purposes, since it separates svg images from bitmap etc.
[00:07:48] <gwicke>	 the only thing that might be a bit icky is that those attributes are really read-only
[00:08:11] <gwicke>	 we are not going to resize the original or turn a bitmap into a vector image if you modify that info in VE ;)
[00:08:39] <gwicke>	 but I think that's fine if well documented
[00:09:58] * mooeypoo nods
[00:10:21] <mooeypoo>	 gwicke, "mediatype" is read only anyways, you can't change it at all unless you change the image itself, which changes the entire property set anyways.
[00:10:41] <mooeypoo>	 Most of these are read only on purpose, too. Default/Original size is also read only unless you change the entire image.
[00:11:06] <gwicke>	 yes, it just differs from other info in data-mw, which is normally read-write
[00:11:33] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (cbc62ac803) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137502 
[00:11:39] <mooeypoo>	 Ah, yeah, good point
[00:11:57] <gwicke>	 we can put it into an imageinfo object and mark that as ro
[00:12:21] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/137503 and https://gerrit.wikimedia.org/r/137502 please.
[00:13:30] <mooeypoo>	 that works. And it will save us a bunch of api calls.
[00:13:44] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (cbc62ac803) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137502 (owner: 10Jforrester)
[00:13:49] <mooeypoo>	 and a whole bunch of calculations.
[00:14:24] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 032] Use promises for confirmation dialog instead of done event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136543 (owner: 10Alex Monk)
[00:15:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (cbc62ac803) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137502 (owner: 10Jforrester)
[00:16:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use promises for confirmation dialog instead of done event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136543 (owner: 10Alex Monk)
[00:18:12] <mooeypoo>	 RoanKattouw, TrevorParscal you know what we need? a way to update the value of a checkbox WITHOUT setting off the event. Possible?
[00:18:39] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (7a4d039) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137507 
[00:18:45] <mooeypoo>	 This checkbox is driving me nuts. Most of the problem is that it's emiting the change event every time it's clicked, which creates loop-de-loops and massive annoyances.
[00:19:02] <James_F>	 mooeypoo: Can you debounce in your catcher?
[00:19:19] <mooeypoo>	 There's gotta be a way to separate between intentional user-click and the code marking it as checked
[00:20:02] <mooeypoo>	 James_F, I can probably find creative solutions,but it would be a whole lot easier if I can set checked/unchecked values without firing the event, like we have "chooseItem" vs "selectItem" in the select widget
[00:21:57] <James_F>	 mooeypoo: Is "chooseItem" vs "selectItem" the cause of https://bugzilla.wikimedia.org/show_bug.cgi?id=65916 ?
[00:21:59] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: The "Cite" toolbar item is not internationalised in the Media and Reference dialogs - 10https://bugzilla.wikimedia.org/66039#c7 (10James Forrester) 5PATC>3RESO/FIX Cherry-picks going out tomorrow.
[00:22:34] <mooeypoo>	 James_F, no, it should be the checkbox event this time. The 'choose' vs 'select' was the cause of previous bugs, it *shouldn't* be a problem anymore (but I'm still checking)
[00:22:51] <mooeypoo>	 it seems so far that the checkbox event itself is the culprit
[00:22:56] <James_F>	 mooeypoo: Ah. :-(
[00:23:23] <mooeypoo>	 I'll find a creative solution to bind it to my will.
[00:23:34] * mooeypoo takes out her code whip
[00:25:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Small default sized SVG images behave differently than small default sized PNG images - 10https://bugzilla.wikimedia.org/62893 (10James Forrester) 5PATC>3RESO/FIX
[00:25:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester)
[00:25:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563 (10James Forrester)
[00:30:45] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal templates (but not reference nodes), which is confusing - 10https://bugzilla.wikimedia.org/63091 (10James Forrester) p:5High>3Low s:5major>3minor a:5Roan Kattouw>3None
[00:31:44] <RoanKattouw>	 mooeypoo: The typical workaround is this.ignoreChangeEvent = true; checkbox.setValue( ... ); this.ignoreChangeEvent = false;
[00:33:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Very minor stuff" (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:33:19] <RoanKattouw>	 mooeypoo: Fix those minor things ---^^ and I'll mergre it
[00:33:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Template editor is missing accessibility features - 10https://bugzilla.wikimedia.org/65474 (10James Forrester) 5PATC>3RESO/FIX
[00:35:07] <grrrit-wm>	 (03CR) 10Catrope: Block object descriptions from edit (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:35:24] <James_F>	 mooeypoo: Don't worry, I'll do it.
[00:35:30] <James_F>	 mooeypoo: You work on checkboxen. :-)
[00:37:11] <grrrit-wm>	 (03PS13) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:37:27] <grrrit-wm>	 (03CR) 10Jforrester: Block object descriptions from edit (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:38:00] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:38:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556...
[00:38:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Block object descriptions from edit [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/133944 (https://bugzilla.wikimedia.org/60089) (owner: 10Mooeypoo)
[00:38:59] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator should roundtrip unexpected JSON values - 10https://bugzilla.wikimedia.org/60089#c4 (10James Forrester) 5PATC>3ASSI Now fixed for descriptions, but not (I think?) in general.
[00:40:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7a4d039) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137507 (owner: 10Jforrester)
[00:41:32] <mooeypoo>	 ooh
[00:41:44] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (7a4d039) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137507 (owner: 10Jforrester)
[00:42:07] <James_F>	 mooeypoo: ?
[00:43:23] <mooeypoo>	 the ignoreChangeEvent workaround is awesome
[00:43:58] <James_F>	 :-)
[00:44:16] <mooeypoo>	 RoanKattouw, quick question though -- change events are asynchronous though, aren't they? That is, if i do something like this.ignoreEvent=true; checkbox.setValue(blah); this.ignoreEvent=false; --> I might end up making the ignore event false before it was fired. No?
[00:44:44] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - 10https://bugzilla.wikimedia.org/63355 (10James Forrester)
[00:44:46] <RoanKattouw>	 No, oojs events are synchronous
[00:44:53] <RoanKattouw>	 I have to go, srry
[00:44:55] <mooeypoo>	 oh, okay
[00:44:57] <mooeypoo>	 awesome, thanks!
[01:18:36] <mooeypoo>	 Keegan! hi
[01:22:43] <mooeypoo>	 er
[01:34:32] <Keegan>	 Hi mooeypoo 
[01:34:44] <mooeypoo>	 are you back home?
[01:46:52] <Keegan>	 mooeypoo: I am for a few days
[01:47:08] <mooeypoo>	 ah yes, i sent you a pm, but none of this is urgent
[01:47:10] <mooeypoo>	 i know you're busy
[02:32:20] <grrrit-wm>	 (03PS1) 10Mooeypoo: [wip] Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137524 (https://bugzilla.wikimedia.org/65916) 
[02:40:47] <grrrit-wm>	 (03PS16) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) 
[02:50:44] <grrrit-wm>	 (03PS17) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) 
[02:53:28] <grrrit-wm>	 (03PS18) 10Jagori79: WIP: [Browser test] Adding step definition and page object for external link scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) 
[07:01:33] <grrrit-wm>	 (03CR) 10Esanders: Grunt: Create a single file stand-alone distribution for demos etc. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[08:38:31] <wikibugs>	 3VisualEditor: VisualEditor: When saving, cursor (caret) stays in the editing area instead of focusing on the edit summary dialog - 10https://bugzilla.wikimedia.org/66168 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Note: This happens in mediawiki.org (1.24wmf7 (941d0e1)), but not in en.wikiped...
[08:42:45] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c3 (10Derk-Jan Hartman) With main document I mean every document parts but the dialog. If the dialog is a direct sibling of the body, then it means that all siblings of the dialog should theoretically be 'aria-hidden' and sh...
[08:43:29] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c4 (10Derk-Jan Hartman) 'direct sibling' -> 'direct child'
[09:59:54] <indaba>	 is there a mailing list for VE ?
[15:02:07] <James_F>	 indaba: There isn't one, no; would you find it useful?
[15:21:17] <grrrit-wm>	 (03PS15) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 
[15:55:01] <grrrit-wm>	 (03CR) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos etc. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[16:01:05] <James_F>	 edsanders: Re. https://bugzilla.wikimedia.org/show_bug.cgi?id=65924 – do you have a response re. fixUpInsertion (does it "just work")?
[16:02:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10James Forrester)
[16:02:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924 (10James Forrester)
[16:02:16] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10James Forrester)
[16:12:30] <edsanders>	 James_F, should work, need to test to prove it
[16:12:51] <James_F>	 edsanders: Kk. Do you want to do that or should mooeypoo?
[16:14:46] <edsanders>	 I'll let her
[16:15:26] <James_F>	 So gallant. :-)
[16:38:27] <James_F>	 Morning Krinkle.
[16:44:53] <Krinkle>	 Hi
[16:55:01] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [BrowserTest] new test for page options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137355 (owner: 10Cmcmahon)
[16:56:03] <mooeypoo>	 Test? 
[16:56:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] new test for page options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137355 (owner: 10Cmcmahon)
[17:01:52] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] Update gems in support of WMF Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137703 
[17:02:59] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137703 (owner: 10Cmcmahon)
[17:04:24] <grrrit-wm>	 (03PS5) 10Esanders: Grunt: Create a single file stand-alone distribution for demos etc. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[17:04:26] <grrrit-wm>	 (03PS1) 10Esanders: Only show debug bar when ve.debug is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137704 
[17:04:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Update gems in support of WMF Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137703 (owner: 10Cmcmahon)
[17:43:01] <TrevorParscal>	 edsanders: mr language widget, if I wanted to have the ve.ce.LanguageAnnotation be able to describe itself in the language name, like "English" instead of "en", how might I obtain such information?
[17:43:24] <mooeypoo>	 ha, challenge.
[17:43:45] <mooeypoo>	 TrevorParscal, can i bug you about the oojs bug?
[17:43:56] <TrevorParscal>	 yes
[17:44:01] <TrevorParscal>	 you mean ooui right?
[17:45:49] <mooeypoo>	 yep, sorry, ooui -- look at this if you got a minute https://gerrit.wikimedia.org/r/#/c/137524/ 
[17:46:23] <mooeypoo>	 this is my fix to the checkbox issue in the media edit dialog, but the widget is still stuck with 2 selections 
[17:47:25] <mooeypoo>	 so to reproduce: review that change; insert an image, then edit the image in the media edit dialog. Remove floating (uncheck the position checkbox) switch type or something, like to 'basic' and click the checkbox again. "Right" will be the default (which is good) but now click "Left" -- both right and left are selected.
[17:47:49] <mooeypoo>	 TrevorParscal, but code-wise, only the latest-clicked actually counts, so it seems that the widget knows which was actually chosen, it just shows both
[17:50:04] <mooeypoo>	 TrevorParscal, I tried to look at the ooui code, but the difference between the three selection types was a bit confusing to me
[17:50:06] <TrevorParscal>	 Well, i can't seem to get this problem to occur in the OOUI demo (by disabling/enabling)
[17:50:12] <TrevorParscal>	 looking further
[17:51:51] <TrevorParscal>	 ok, got it
[17:51:58] <TrevorParscal>	 it's caused by using chooseItem() while disabled
[17:52:06] <TrevorParscal>	 I can reproduce in the ooui demo
[17:52:30] <TrevorParscal>	 you disable, choose and item, enable, both will be depressed
[17:52:32] <TrevorParscal>	 let me fix
[17:54:09] <mooeypoo>	 ahh
[17:54:12] <mooeypoo>	 hmm
[17:54:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Only show debug bar when ve.debug is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137704 (owner: 10Esanders)
[17:54:30] <wikibugs>	 3OOjs UI: VisualEditor Mobile: Link inspector - after selection, search field is buggy on iOS - 10https://bugzilla.wikimedia.org/64575#c7 (10Jon) a:3None This appears to be a bug in OOJS-UI It seems selecting an item does something weird with the focus of the input on an iPad.
[17:54:32] <mooeypoo>	 damn; I changed the order because otherwise the checkbox event ruins stuff
[17:54:44] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator should roundtrip unexpected JSON values - 10https://bugzilla.wikimedia.org/60089#c5 (10Krinkle) (In reply to James Forrester from comment #4) > Now fixed for descriptions, but not (I think?) in general.  (In reply to Gerrit Notificati...
[17:54:46] <mooeypoo>	 TrevorParscal, okay, I guess I'll have to use roan's ignoreEvent tweak
[17:55:01] <TrevorParscal>	 what is really strange is that selectItem works, but chooseItem does not, and chooseItem really only calls selectItem and then emits 'choose'
[17:55:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only show debug bar when ve.debug is set [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137704 (owner: 10Esanders)
[17:56:59] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator should roundtrip unexpected JSON values - 10https://bugzilla.wikimedia.org/60089#c6 (10James Forrester) 5ASSI>3RESO/FIX OK, in that case I'm marking this bug closed (but we should follow-up with the wider tech debt, indeed).
[17:57:46] <mooeypoo>	 TrevorParscal, are you changing this through oojs, or should I not allow my code to select an item when it's disabled?
[17:57:57] <TrevorParscal>	 i'm fixing in OOUI
[17:58:21] <TrevorParscal>	 well, if it's disabled, it would seem that we should ignore choose and select and stuff
[17:58:41] <mooeypoo>	 TrevorParscal, well, the idea was that I select so that when it's not disabled it displays whatever the previous selection was
[17:58:45] <mooeypoo>	 is that not good strategy?
[17:58:57] <mooeypoo>	 instead of having it come back from being disabled as empty
[17:59:04] <TrevorParscal>	 well, it's sort of evil
[17:59:17] <TrevorParscal>	 because disabled means "user can't change it"
[17:59:25] <mooeypoo>	 no, but code can?
[17:59:31] <TrevorParscal>	 we don't want to get into a situation where the program has to enable, change and disable
[17:59:40] <mooeypoo>	 the select widget reflects the value of the code, that's why I thought it was logical
[17:59:44] <TrevorParscal>	 or wait for the control to be enabled to set the value
[18:00:24] <mooeypoo>	 TrevorParscal, yeah, that's why I thought the system can choose the item regardless of the select widget being disabled for the user
[18:00:29] <mooeypoo>	 but if that doesn't make sense, I'll change it
[18:02:30] <jdlrobson>	 TrevorParscal: I'm trying to debug an issue with the link inspector search - which function is called when a search result is clicked? 
[18:03:13] <mooeypoo>	 TrevorParscal, this whole trickses-business started because unlike most oojs setters, checkbox 'set' values *always* emit the set event, and if I hit that event before the widget has value in it, that produces an event loop-de-loop. However, I can solve this in other ways.
[18:04:41] <TrevorParscal>	 hmm, now I can't reporoduce
[18:04:51] <RoanKattouw>	 jdlrobson: MWLinkTargetInputWidget#onLookupMenuItemChoose
[18:05:02] <jdlrobson>	 thanks RoanKattouw !
[18:05:42] <TrevorParscal>	 mooeypoo: we need to filter the event on actual change, like the others
[18:06:04] <TrevorParscal>	 CheckboxInputWidget appears to have filtering
[18:06:45] <mooeypoo>	 TrevorParscal, oh, it actually changes.
[18:06:52] <mooeypoo>	 I just don't want it to fire the full event.
[18:07:19] <mooeypoo>	 TrevorParscal, similar to 'choose' vs 'select' there's a difference between the user actually clicking this checkbox and the system enabling/selecting this checkbox due to data changing
[18:07:37] <mooeypoo>	 one should emit change, the other should behave differently -- and it's hard to know which is which when both emit the same event. 
[18:07:39] <TrevorParscal>	 mooeypoo: ah, right
[18:08:06] <mooeypoo>	 TrevorParscal, I can use Roan's trick, he suggested I do this.ignoreCheckboxEvent =true; checkbox.val(..); this.ignoreCheckboxEvent=false;
[18:08:18] <TrevorParscal>	 well, in the response to the checkbox changing, it should only act if the new value is not already in sync with the model
[18:08:21] <TrevorParscal>	 this is normal
[18:08:31] <TrevorParscal>	 value change filtering
[18:08:36] <mooeypoo>	 hmm.
[18:08:42] <TrevorParscal>	 his trick is evil
[18:09:41] <TrevorParscal>	 what you need it so write the checkbox's "set" event handler to only carry out action if the checkbox is introducing a new value to the model, if the model is already in the same state as the checkbox now is, then we are all set
[18:09:59] <mooeypoo>	 Syncing with the model is a good point. I tried a bunch of things and ran into a couple of issues, but I am not sure if that's something I tried.
[18:10:03] * mooeypoo nods
[18:10:38] <TrevorParscal>	 the reason we have select and choose with menus isn't to do with these event loops, it's because we want to visually provide feedback for highlighting (hovering) selecting (mousedown and drag) and choosing (mouseup)
[18:12:04] <TrevorParscal>	 keeping a model and view in sync will tempt you into having 2 paths to update the UI, one that the user takes and another that the model takes, but you will hit the wall quickly - you need to check if the model has indeed changed (or let the model do that internally, as we do inside input widget setValue() methods) before carrying out any action
[18:12:12] <grrrit-wm>	 (03CR) 10Krinkle: "I was wondering where i saw this before. Maybe mention it was copied from oojs-ui build process (moduleUtils.js etc.)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[18:14:56] <mooeypoo>	 TrevorParscal, aye, but it also makes sense in terms of behavior, I thought. As in, "User changed value" vs "System changed value" which should suggest different behavior
[18:15:28] <mooeypoo>	 It was a bit annoying that checkboxes don't allow for that distinction. I get why, but when you get used to a good thaaang...
[18:16:04] <RoanKattouw>	 TrevorParscal: Thanks for sanitizing my suggestion there
[18:19:27] <jdlrobson>	 RoanKattouw: having troubles with debugging https://bugzilla.wikimedia.org/show_bug.cgi?id=64575 - there is a nasty iOS bug that seems to mess with the focus on the input which puts it in a state where the soft keyboard is open but you can't type unless you unfocus. Would be good to sit down with you later and brainstorm some ideas on what's going on
[18:20:30] <TrevorParscal>	 mooeypoo: so, I'm not able to reproduce on the demo, looking at your actual patches in a sec
[18:22:04] <mooeypoo>	 TrevorParscal, ok, I'll be editing it to make the code not update the disabled widget anyways, though... or do you want me to wait?
[18:22:34] <TrevorParscal>	 let me sort this out, i'm seeing it doing this in your patch, there's gotta be a way to fix it
[18:23:12] <mooeypoo>	 TrevorParscal, okay, though your point about checking the model first is good idea, i'll have to change the code a bit later. I'm waiting for you to finish first, though.
[18:23:51] <TrevorParscal>	 ok, so what I am seeing is that it's not actually selecting the "right" option, but the button element inside the option is "active"
[18:24:25] <TrevorParscal>	 if you look at the DOM, initially the "right" option doesn't have .oo-ui-optionWidget-selected set as you might expect it to
[18:27:18] <TrevorParscal>	 ok, I can reproduce in the ooui demo now, because I know what is going on
[18:27:30] <mooeypoo>	 hmmm
[18:27:55] <TrevorParscal>	 if you choose/select an item, while there is no current item and it's disabled it will get into a strange state
[18:27:57] <TrevorParscal>	 working on that
[18:28:05] * mooeypoo nods
[18:28:11] <mooeypoo>	 okay, so it's due to selecting while it's disabled
[18:28:16] <mooeypoo>	 okay, that makes sense
[18:29:00] <TrevorParscal>	 it's because OO.ui.ButtonOptionWidget doesn't prevent setting active when it's disabled, but OO.ui.OptionWidget does prevent setting selected when it's disabled
[18:29:09] <TrevorParscal>	 which isn't needed, and is causing this chaos
[18:29:25] * mooeypoo nods
[18:29:45] <mooeypoo>	 so are you going to prevent for disabled for all, or for none?
[18:30:02] <mooeypoo>	 I should still go by the model sync strategy that you suggested regardless.
[18:31:07] <TrevorParscal>	 i'm going to fix it so you can change it while it's disabled (just not by clicking) and it works properly
[18:32:03] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Similar to how we have ve.batchSplice for splice.apply
[18:33:35] <mooeypoo>	 TrevorParscal, awesomeness
[18:33:36] <mooeypoo>	 thanks!
[18:36:20] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Allow programatic selection of options while disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/137729 
[18:36:49] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Allow programatic selection of options while disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/137729 
[18:36:59] <TrevorParscal>	 there you go, https://gerrit.wikimedia.org/r/#/c/137729/
[18:37:18] <TrevorParscal>	 i am going to mozy on over to metrics for a bit, see what I can see
[18:37:47] <James_F>	 TrevorParscal: It's very full up here.
[18:41:50] <RoanKattouw>	 So I've managed to get LanguageSearchWidget#addResults (on initial load) down from 14056ms to 1750ms
[18:41:52] <RoanKattouw>	 So that's good
[18:42:00] <RoanKattouw>	 But still not really fast
[18:42:46] <wikibugs>	 3VisualEditor / 3Editing Tools: Fields are case sensitive in citation dialog, allowing duplicates of the same field - 10https://bugzilla.wikimedia.org/66207 (10marielle.volz) 3UNCO p:3Unprio s:3trivia a:3None Created attachment 15572   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15572&action...
[18:42:53] <RoanKattouw>	 The addItems() component of that went down from 13030ms to 63ms :O
[18:43:20] <RoanKattouw>	 Now I just have to deal with the fact that updateLabel() takes 1662ms
[18:45:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715#c3 (10marielle.volz) Created attachment 15573   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15573&action=edit More than one field error
[18:46:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715#c4 (10marielle.volz) Whoops, sorry, wrong bug report :(
[18:47:29] <wikibugs>	 3VisualEditor / 3Editing Tools: Fields are case sensitive in citation dialog, allowing duplicates of the same field - 10https://bugzilla.wikimedia.org/66207#c1 (10marielle.volz) Created attachment 15574   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15574&action=edit Two fields error
[18:47:49] <RoanKattouw>	 Hah
[18:47:59] <RoanKattouw>	 Apparently node adoption is really expensive in Chrome
[18:48:15] <RoanKattouw>	 Using this.$() instead of $() appears to turn that 1662ms into 243ms
[18:50:17] <RoanKattouw>	 It looks like jQuery's efforts to clean up the mess made by mixing $() and this.$() causes a ~10x overhead
[18:50:44] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Message templatedata-model-table-param-type-file missing - 10https://bugzilla.wikimedia.org/65545 (10Krinkle)
[18:50:44] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543 (10Krinkle)
[18:51:28] <Krinkle>	 RoanKattouw: so this.$ is faster?
[18:51:35] <RoanKattouw>	 Well
[18:51:42] <RoanKattouw>	 Using the correct document consistently is faster
[18:52:14] <RoanKattouw>	 appending things made with $() to things made with this.$ (assuming this.$()'s document is not the global document) is what appears to be slow
[18:52:39] <RoanKattouw>	 Specifically, the place where I'm fixing this is ve.ui.LanguageResultWidget#highlightQuery
[18:53:07] <RoanKattouw>	 If you look at its only caller (in the same file), you'll see that for an unfiltered language list, that kind of mismatch happens a couple hundred times
[18:53:28] <Krinkle>	 I'm trying to figure out where jQuery does this slow recovery
[18:53:40] <Krinkle>	 Youre saying it will import/adopt the nde?
[18:53:41] <Krinkle>	 node*
[18:53:45] <RoanKattouw>	 domManip calling buildFragment apparently
[18:53:58] <Krinkle>	 yeah, that's where I ended up as well.
[18:54:43] <RoanKattouw>	 Sizzle.setDocument appears to only be present in the bad trace, and appears to take a lot of time
[18:54:56] <RoanKattouw>	 To test this, do the following
[18:55:17] <RoanKattouw>	 Change LanguageResultWidget#highlightQuery to an instance method rather than a static method (which I'm doing in an upcoming patch)
[18:55:27] <RoanKattouw>	 Then profile the code with $() vs this.$() in that function
[18:55:43] <RoanKattouw>	 (right now it obviously uses $(), since this.$() doesn't exist in static methods)
[18:55:53] <RoanKattouw>	 When I say "profile the code", I mean:
[18:56:12] <RoanKattouw>	 Open VE, open language inspector, start profile, click Change language, wait for dialog to appear, stop profile
[18:56:21] <RoanKattouw>	 You need my GroupElement fixes for this to not take 14 seconds
[18:56:51] <RoanKattouw>	 But the function where you can see the this.$() vs $() performance difference is LanguageResultWidget#updateLabell
[18:56:53] <RoanKattouw>	 -l
[19:00:48] <Krinkle>	 RoanKattouw: what do you mean by "Change language"
[19:00:54] <Krinkle>	 I see Find language
[19:01:15] <Krinkle>	 Is that the one?
[19:01:31] <Krinkle>	 this is the first time I've seen this version of the inspector
[19:03:47] <James_F>	 Krinkle: It changed ~ two months ago I think. Ed went bonkers.
[19:06:12] <RoanKattouw>	 Yeah that one
[19:09:23] <grrrit-wm>	 (03PS1) 10Catrope: Use this.$() in LanguageResultWidget#highlightQuery [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137736 (https://bugzilla.wikimedia.org/65512) 
[19:09:39] <RoanKattouw>	 James_F: Surprising performance result ---^^
[19:10:05] <James_F>	 Gosh, numbers.
[19:10:09] <mvolz>	 JamesF: we decided the field mappings should be in a MediaWiki:mappings.json file correct? and not service side? 
[19:10:12] * James_F approves as a ve-performance bug.
[19:10:30] <James_F>	 mvolz: Yes, because they'll alter from wiki to wiki.
[19:10:38] <aharoni>	 hola
[19:10:41] <James_F>	 mvolz: But we could theoretically do it a different way.
[19:10:43] <mvolz>	 nah
[19:10:46] <mvolz>	 works for me
[19:10:49] <aharoni>	 James_F: did you notice https://bugzilla.wikimedia.org/show_bug.cgi?id=66168 ?
[19:11:06] <James_F>	 mvolz: Maybe in TemplateData with locked-in (Dublin Core? Etc.) tags?
[19:11:27] <James_F>	 aharoni: I'll get to triage it in the next 2–3 days.
[19:11:35] <James_F>	 aharoni: But I'm pretty sure it's a duplicate.
[19:11:39] <aharoni>	 ok :)
[19:12:02] <aharoni>	 as long as it stays on mediawiki.org and doesn't go to Wikipedias
[19:12:18] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137524 (https://bugzilla.wikimedia.org/65916) 
[19:12:30] <aharoni>	 hi mooeypoo 
[19:12:35] <mooeypoo>	 heya
[19:12:37] <mvolz>	 Hmmm. I worry about unnessecarily dropping types if it's in each separate template
[19:12:38] <mooeypoo>	 how are you aharoni ?
[19:12:43] <aharoni>	 life is good.
[19:12:48] <aharoni>	 did you see the new reports on my he.wikipedia user page?
[19:12:57] <aharoni>	 very curious stuff for you
[19:13:01] <mooeypoo>	 oh, no? I saw your message, didn't have time to check. Going now
[19:13:23] <aharoni>	 mooeypoo: more <nowiki> examples and another weird thing with spurious <span>s
[19:13:36] <mooeypoo>	 ooh
[19:14:52] <mvolz>	 but you're right we need to match field for field in some cases...
[19:14:59] <mvolz>	 hence template data...
[19:22:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439#c2 (10James Forrester) *** Bug 63050 has been marked as a duplicate of this bug. ***
[19:22:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Close inspectors when the user clicks on the toolbar (e.g. on "Save Page") so it's clear that it has applied to the document - 10https://bugzilla.wikimedia.org/63050#c2 (10James Forrester) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 5...
[19:22:42] <eranroz>	 aharoni, mooeypoo: I added filter to catch <nowiki> edits https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%99%D7%95%D7%97%D7%93:%D7%99%D7%95%D7%9E%D7%9F_%D7%94%D7%94%D7%A9%D7%97%D7%AA%D7%95%D7%AA&wpSearchFilter=45
[19:22:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors and context menu should close when blurring the document and/or when opening the save dialog - 10https://bugzilla.wikimedia.org/51439 (10James Forrester) p:5Low>3High
[19:23:01] <aharoni>	 thanks eranroz 
[19:23:06] <mooeypoo>	 eranroz, oh, great!
[19:23:07] <mooeypoo>	 thanks
[19:23:14] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Diff styling in save dialog is broken - 10https://bugzilla.wikimedia.org/60497 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[19:23:36] <Krinkle>	 RoanKattouw: Ah, found it.
[19:23:47] <Krinkle>	 RoanKattouw: I couldn't find why it goes into setDocument from looking a the code
[19:23:56] <Krinkle>	 it's not because it's wanting to import or adtop
[19:23:58] <Krinkle>	 adopt*
[19:24:01] <Krinkle>	 it's because of the contains() check
[19:24:28] <eranroz>	 wikibugs, use "window" not "dialog". ve doesn't load properly with "dialog" :)
[19:24:58] <James_F>	 eranroz: What?
[19:25:09] <Krinkle>	 RoanKattouw: So it executes all its assert tests and stuff again. Basically it's initial startup footprint.
[19:25:31] <Krinkle>	 to see what the document and window support
[19:25:51] <Krinkle>	 and its not even doing an import/adopt
[19:25:55] <Krinkle>	 so it'll probably still fail
[19:26:15] <Krinkle>	 or work because appenChild or something is doing it implicitly
[19:26:16] <eranroz>	 James_F, this is a joke, but I had a script that used dialog factory and the name changed to window factory
[19:26:31] <eranroz>	 and then ve.addPlugin caused ve to not load anymore
[19:26:33] <Krinkle>	 RoanKattouw: setDocument is just slow, it doesnt' set the document of the node, it sets the document related variarbles of the Sizzle engin 
[19:26:43] <Krinkle>	 bascially re-instantiate the Sizzle singleton for that document
[19:26:44] <eranroz>	 (there is no timeout for "bad code")
[19:27:22] <Krinkle>	 I like the new inspector a lot
[19:27:25] <Krinkle>	 ULS can learn from that
[19:27:28] <Krinkle>	 A lot
[19:27:39] <James_F>	 eranroz: Ah, whoops. Sorry about that.
[19:27:58] <James_F>	 eranroz: Breaking changes happen quite a lot right now; lots of technical debt being paid down.
[19:28:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:  Edit summary typed into the article instead of the Save dialog in Firefox - 10https://bugzilla.wikimedia.org/64521#c1 (10James Forrester) 5ASSI>3RESO/DUP On reflection, I'm going to assume that this was caused by bug 65222 which is now resolved and so up-m...
[19:28:30] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Automatically place cursor in edit summary field - 10https://bugzilla.wikimedia.org/65222#c3 (10James Forrester) *** Bug 64521 has been marked as a duplicate of this bug. ***
[19:28:32] <eranroz>	 James_F, yea it is OK. better now than later :)
[19:30:22] <mooeypoo>	 eranroz, I'm a bit confused, sorry if this is a silly question, but I'm looking at the articles in the filter
[19:30:32] <mooeypoo>	 https://he.wikipedia.org/w/index.php?title=%D7%94%D7%A4%D7%A8%D7%93%D7%AA_%D7%94%D7%93%D7%AA_%D7%9E%D7%94%D7%9E%D7%93%D7%99%D7%A0%D7%94&diff=prev&oldid=15545338 <-- there's no <nowiki> there?
[19:31:00] <mooeypoo>	 However, it fits the idea of nowiki tags being due to internal links. So i'm confused.. why was this caught in the filter? am I missing something?
[19:31:28] <eranroz>	 mooeypoo, it doesn't look in the diff text but in the new article text (e.g - it may be nowiki that was in the previous version)
[19:31:38] <mooeypoo>	 gotcha
[19:31:50] <mooeypoo>	 okay, from this, it seems it's pretty clearly something with internal links
[19:33:58] * mooeypoo waits for wikibugs to--
[19:34:01] <wikibugs>	 3VisualEditor: <nowiki> tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None <nowiki> tags appear when editing on the Hebrew Wikipedia:  Examples: https://he.wikipedia.org/w/index.php?title=%D7%99%D7%A8%D7%95%D7%9F...
[19:34:05] <mooeypoo>	 \o/
[19:45:12] <James_F>	 mooeypoo: :-(
[19:46:47] <grrrit-wm>	 (03PS1) 10Catrope: Fix GroupElement performance [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) 
[19:48:16] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf7] Cursor is no longer getting automatically placed in the edit summary field; document isn't unfocussed in Firefox - 10https://bugzilla.wikimedia.org/66168#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3major a:3Ed S...
[19:48:23] <James_F>	 edsanders|away: ^^^ Not good. :-(
[19:48:50] <RoanKattouw_away>	 James_F: With that --^^ and the other commit, opening the language selector dialog is down to ~300ms, and the lag in search results appearing after you delete the last character in the search field is about ~200ms
[19:49:12] <James_F>	 RoanKattouw_away: Nice. Thank you. :-)
[19:49:15] <RoanKattouw_away>	 The latter is still noticeably laggy and I want to improve it, but it was about 12-14 seconds before, so...
[19:49:22] <James_F>	 RoanKattouw_away: Also, your _away is showing. ;-)
[19:49:27] <RoanKattouw_away>	 Yeah
[19:49:30] <RoanKattouw_away>	 I'm about to get lunch
[19:51:59] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: If making a null change, the "Your edit was saved" message appears, even if there were no changes and so it wasn't - 10https://bugzilla.wikimedia.org/51243#c5 (10James Forrester) Confirmed that this is still broken for VisualEditor (and not for wikitext e...
[20:00:10] <grrrit-wm>	 (03PS1) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137742 
[20:00:28] <James_F>	 Krinkle: Could you +2 https://gerrit.wikimedia.org/r/#/c/137742/ so I can create the cherry-pick?
[20:00:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Block object descriptions from edit [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137742 (owner: 10Jforrester)
[20:00:51] <James_F>	 Eurgh. Or not.
[20:00:56] <Krinkle>	 James_F: That is the cherry pick
[20:01:10] <James_F>	 Krinkle: The cherry-pick-pull-through in mw-core.
[20:01:26] <Krinkle>	 Doesn't SWAT do that for us?
[20:01:28] <James_F>	 Krinkle: That's the code cherry pick, not the extension cherry pick that SWAT now wants.
[20:01:36] <James_F>	 We've been asked to do it ourselves.
[20:01:54] <Jwoods1>	 Hi. So, I am running Mediawiki on a WAMP server on a windows 8.1 machine. I have parsoid running on my local machine. When I run the echo test, it seems to work fine. I installed VisualEditor using the steps I saw, however, with it up and running, when I click on "Edit" nothing seems to happen. No error message, nothing. Thoughts?
[20:01:56] <James_F>	 Hmm. That V-1 is perplexing.
[20:02:26] <James_F>	 Jwoods1: Hey. Do you have anything in your browser console log? What browser are you using?
[20:02:37] <Jwoods1>	 Chrome, let me check the console.
[20:02:39] <Krinkle>	 James_F: not really
[20:02:47] <Krinkle>	 James_F: grunt was added there very recently, by you.
[20:03:03] <Krinkle>	 after wmf7 was cut
[20:03:08] <grrrit-wm>	 (03PS1) 10Krinkle: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137744 
[20:03:09] <James_F>	 Krinkle: Ah, of course.
[20:03:13] * James_F is a fool. :-)
[20:03:14] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137744 (owner: 10Krinkle)
[20:03:29] <Jwoods1>	 The console is literally empty
[20:03:33] <Jwoods1>	 No error messages, nothing.
[20:03:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a grunt checker for jshint, jscs, csslint, and banana and pass them [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137744 (owner: 10Krinkle)
[20:04:17] <James_F>	 Jwoods1: You have both edit tabs? Special:Version lists VisualEditor?
[20:04:42] <grrrit-wm>	 (03PS2) 10Jforrester: Block object descriptions from edit [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137742 
[20:04:49] <Jwoods1>	 ok, I refreshed, then clicked, now i get "Failed to load resource: the server responded with a status of 404 (Not Found) " referencing a file "wiki.png"
[20:05:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Block object descriptions from edit [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137742 (owner: 10Jforrester)
[20:05:04] <James_F>	 Jwoods1: That won't affect VE.
[20:05:06] <Jwoods1>	 yes, I also see "Edit:Source" and that allows me to edit as per normal
[20:05:12] <James_F>	 Jwoods1: Right, OK.
[20:05:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Block object descriptions from edit [extensions/TemplateData] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137742 (owner: 10Jforrester)
[20:05:25] <James_F>	 Jwoods1: What browser are you using?
[20:05:51] <Jwoods1>	 And special:versions lists "VisualEditor0.1.0(4c36d6e)"
[20:05:55] <Jwoods1>	 Chrome
[20:06:08] <Jwoods1>	 Chrome Version 35.0.1916.114 m
[20:06:59] <James_F>	 What version of MediaWiki are you running?
[20:07:03] <Jwoods1>	 1.23
[20:08:15] <James_F>	 Jwoods1: Ah, that would be the issue. 4c36d6e requires MediaWiki 1.24.
[20:08:41] <James_F>	 Jwoods1: If you look at your MW error logs you should see a notice that VE requires MW 1.24 which isn't loaded.
[20:08:52] <Jwoods1>	 hmm
[20:09:16] <Jwoods1>	 honestly, didn't even realize there was a 1.24. 1.23 was just realeased today... Thought I was up to the latest. ha
[20:09:36] <James_F>	 Jwoods1: You are; 1.24 alpha is what we run and build against.
[20:09:44] <James_F>	 Jwoods1: 9182fc1958a4436038c2900a2b2d0ec9fc9e41ab should work with 1.23.
[20:10:15] <Jwoods1>	 I see
[20:10:17] <James_F>	 Jwoods1: That requires the Parsoid extension's CSS styling, which was moved to MW after 1.23 (hence the need for MW 1.24).
[20:13:32] <Jwoods1>	 Forgive my ignorance... but what would be the best way to attain 9182fc1958a4436038c2900a2b2d0ec9fc9e41ab? I'm still not incredibly familiar with git
[20:14:56] <James_F>	 Jwoods1: Ah, sorry; have you got VisualEditor through git or otherwise?
[20:15:21] <Jwoods1>	 I think the version I have I used git bash for windows and did "git checkout master"
[20:15:28] <James_F>	 Aha, right.
[20:15:42] <James_F>	 Jwoods1: In that case you just want to change version, so do `git checkout 9182fc1958a4436038c2900a2b2d0ec9fc9e41ab` and you'll be done.
[20:15:49] <Jwoods1>	 ok, cool
[20:15:55] <Jwoods1>	 Really appreciate all the help!
[20:16:03] <James_F>	 Jwoods1: That plus `git submodule update`.
[20:16:15] <James_F>	 Jwoods1: No problem. If you have any further problems just shout. :-)
[20:16:43] <Jwoods1>	 well, one more...
[20:16:46] <Jwoods1>	 "git checkout 9182fc1958a4436038c2900a2b2d0ec9fc9e41ab"
[20:16:48] <Jwoods1>	 no quotes
[20:16:56] <Jwoods1>	 returns "fatal: reference is not a tree
[20:16:57] <Jwoods1>	 "
[20:18:21] <James_F>	 Well, isn't that fun?
[20:18:38] <James_F>	 Do "git remote update" first?
[20:19:29] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc
[20:19:45] <Jwoods1>	 aha! that seems to have allowed it
[20:21:20] <Jwoods1>	 Even with a hard refresh of the page, still nothing when I click edit. (server was restarted afterwards)
[20:24:17] <Krinkle>	 Something you dont' want to see next to a bunch of regexes:
[20:24:19] <Krinkle>	  // have no idea what this doing
[20:24:26] <Krinkle>	 https://gerrit.wikimedia.org/r/#/c/135546/2/includes/page/PageContentBuilder.php
[20:26:48] <James_F>	 Krinkle: Gosh. Yeah.
[20:27:26] <James_F>	 Jwoods1: Hmm.
[20:27:39] <James_F>	 Jwoods1: Anything in the server logs?
[20:27:58] <Jwoods1>	 "Error: constructor must be a function, cannot be a undefined Error load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140605T1…:145
[20:27:58] <Jwoods1>	 "
[20:28:16] <Krinkle>	 RoanKattouw_away: Not sure if you found it before, but I finally found some documentation about javascript engine's arguments list limit
[20:28:16] <Krinkle>	 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply
[20:28:16] <Jwoods1>	 thats in the console now
[20:28:25] <Krinkle>	 "But beware: in using apply this way, you run the risk of exceeding the JavaScript engine's argument length limit."
[20:30:34] <James_F>	 Jwoods1: What happens if you go to <wiki>/wiki/Main_Page?veaction=edit&debug=true
[20:31:22] <Jwoods1>	 ... That seems to have worked.
[20:32:15] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf7] Cursor is no longer getting automatically placed in the edit summary field; document isn't unfocussed in Firefox - 10https://bugzilla.wikimedia.org/66168#c2 (10Amir E. Aharoni) I can still reproduce it in Firefox and Chrome on mediawiki.org....
[20:32:28] <Jwoods1>	 Yeah, it let me make a change, save the page, and on refresh, it is still there
[20:32:32] <Jwoods1>	 the change is
[20:32:58] <aharoni>	 James_F: That focus problem happens to me now in enwiki and mw.org
[20:33:01] <Jwoods1>	 but simply clicking on the "Edit" does nothing.
[20:33:59] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf7] Cursor is no longer getting automatically placed in the edit summary field; document isn't unfocussed in Firefox - 10https://bugzilla.wikimedia.org/66168#c3 (10James Forrester) Sorry, that comment was half-written about a different bug. Bah Bu...
[20:34:17] <James_F>	 aharoni: Yes, because Bugzilla helpfully copied half my comment from a different bug. Sorry. :-(
[20:34:25] <aharoni>	 :)
[20:34:40] <James_F>	 Jwoods1: So it's probably a caching issue that should sort itself out after a few minutes.
[20:34:54] <James_F>	 Jwoods1: Congratulations for making the first VE edit on that wiki. ;-)
[20:35:24] <James_F>	 Jwoods1: After a few minutes it shouldn't be necessary to use ?debug=true to kick VE into working (by now even, hopefully).
[20:36:12] <grrrit-wm>	 (03PS3) 10Mooeypoo: Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137524 (https://bugzilla.wikimedia.org/65916) 
[20:37:22] <mooeypoo>	 TrevorP|Away, ^^ changed, and it works now, though I tested it without your patch to make sure I succeed on strategy rather than on relying on your patch to mask my luck.
[20:38:32] <Jwoods1>	 Still nothing. How long should I wait before getting concerned its stilll not working
[20:39:02] <James_F>	 Jwoods1: It entirely depends on your setup (especially with regard to caching).
[20:42:46] <mooeypoo>	 TrevorParscal, I awesomodelified my fix code. Thanks for the help :) 
[20:44:04] <James_F>	 Jwoods1: But the normal configuration would be around 5–10 minutes.
[20:44:18] <James_F>	 Jwoods1: It could also be caught by your browser cache.
[20:44:50] <mvolz>	 when i insert things into a page in VE, am I inserting html always? does wikitext ever get sent back to parsoid ajaxilly, or is that only on saving the page>
[20:45:51] <Jwoods1>	 I did a ctrl+R refresh, so I don't know if thats it
[20:46:49] <grrrit-wm>	 (03PS3) 10Catrope: Allow programmatic selection of options while disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/137729 (https://bugzilla.wikimedia.org/65916) (owner: 10Trevor Parscal)
[20:48:45] * mvolz is confused :(
[20:49:11] <grrrit-wm>	 (03CR) 10Catrope: "Actually, after talking with James, I've become convinced that this is actually the *right* way to do it and changing attributes would act" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[20:55:15] <Jwoods1>	 yeah, ctrl f5 and its still giving me the error after ~20min
[20:57:29] <gwicke>	 mvolz, VE is an HTML editor
[20:58:11] <gwicke>	 the only wikitext hold-out is currently template parameters
[20:58:15] <mvolz>	 ok. yes
[20:58:23] <mvolz>	 that's what I was wondering.
[20:58:24] <gwicke>	 but that'll go away very soon as well
[20:58:38] <gwicke>	 we have the support for HTML params already in Parsoid
[20:58:45] <gwicke>	 it's still switched off in production
[20:58:54] <gwicke>	 (the production part)
[20:59:12] <gwicke>	 we might or might not already support HTML params produced by VE
[20:59:23] <mvolz>	 so then, for example, a citation template would be html with the params annotated?
[20:59:24] <gwicke>	 depends on whether the option switches that off or not
[20:59:40] <gwicke>	 transclusions are always HTML
[20:59:59] <gwicke>	 the only bit of wikitext is currently inside the data-mw JSON attribute
[21:00:23] <mvolz>	 very helpful, thank you
[21:01:21] <mvolz>	 although it makes the shortcut I was thinking of taking impossible :)
[21:01:26] <mvolz>	 but cleaner in the end
[21:02:45] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10Roan Kattouw) a:3Ed Sanders
[21:05:57] <Jwoods1>	 still doesn't do anything unless i add the &debug=true at the end of the URL... Thoughts?
[21:06:45] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should not send external link urls to the API for suggestions (because it won't be valuable) - 10https://bugzilla.wikimedia.org/66135 (10Roan Kattouw) a:3Alex Monk
[21:07:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139 (10Roan Kattouw) a:3Alex Monk
[21:10:16] <wikibugs>	 3VisualEditor / 3Language: VisualEditor: Category autocompletion is broken in RTL wikis - 10https://bugzilla.wikimedia.org/65483 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3High a:3Moriel Schottlender
[21:12:59] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c1 (10Roan Kattouw) It seems like the dm.Surface's selection is getting set to the b...
[21:17:04] <Jwoods1>	 Error: constructor must be a function, cannot be a undefined Error {stack: (...), message: "constructor must be a function, cannot be a undefined"} load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140605T1…:145logload.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140605T1…:145runScriptload.php?debug=false&lang=en&modules=jquery%2Cmedi
[21:17:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: New references added after existing re-used references (<ref name=":0" />) replacing rather than proceeding them - 10https://bugzilla.wikimedia.org/54944#c4 (10Roan Kattouw) 5ASSI>3RESO/WOR Closing unless and until this is shown to still be a problem.
[21:22:30] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync - 10https://bugzilla.wikimedia.org/52171#c3 (10Roan Kattouw) 5ASSI>3RESO/FIX a:5David Chan>3Ed Sanders Was fixed by something Ed did a while ago.
[21:27:47] <gwicke>	 mvolz, here's the DOM spec btw: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Transclusion_content
[21:55:10] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 
[21:55:13] <mvolz>	 gwicke: tnx
[21:56:52] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 
[21:57:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal)
[21:58:15] <RoanKattouw>	 mvolz: Also, when you're inserting/changing things in VE, you're not actually dealing with the HTML directly, you're dealing with our data model
[21:58:17] <RoanKattouw>	 Which is different still
[21:58:18] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 
[22:00:02] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Stable version of the GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65543#c1 (10James Forrester) 5ASSI>3RESO/FIX Deeming this "fixed" (but lots of improvements to come to be tracked in bug 65544).
[22:00:22] <RoanKattouw>	 mvolz: At some point I should give you a 4-hour introduction to all things VE, but for now if you could tell me what you're trying to do I can give more targeted advice
[22:01:02] <mvolz>	 i.e. in ve.dm.MWReferenceModel.js ?
[22:01:58] <mvolz>	 well in short I have JSON that I need to make into a reference :)
[22:02:02] <RoanKattouw>	 OK
[22:02:13] <RoanKattouw>	 A reference, or a citation template?
[22:02:39] <RoanKattouw>	 Like, will the resulting wikitext be <ref>Text here</ref> or will it be {{cite book|author=Aldous Huxley|title=Brave New World}} ?
[22:03:02] <mvolz>	 uh, both. but let's do citation for now
[22:03:06] <mvolz>	 L(
[22:03:07] <mvolz>	 :)
[22:03:20] <mvolz>	 although I guess ref is the simpler case
[22:04:12] <RoanKattouw>	 It is, yeah
[22:04:15] <RoanKattouw>	 A bit
[22:04:19] <RoanKattouw>	 They're very different
[22:04:31] <RoanKattouw>	 Ahm, OK so for the citation case you want TransclusionModel
[22:04:58] <RoanKattouw>	 I don't know exactly how to work with it offhand, but with reading code+docs and some help from Trevor you should be able to figure it out
[22:05:38] <RoanKattouw>	 Unfortunately, 1) the existing usage of TransclusionModel in TransclusionDialog is pretty complicated and not really conducive to learning from, and 2) Trevor and I are in a meeting for the next hour
[22:06:08] <mvolz>	 Yeah I've been basically doing 1) for the last few days. there are a lot of layers of abstraction :)
[22:07:21] <RoanKattouw>	 mvolz: Shall we schedule a chat between you and (me and/or Trevor) to walk through this?
[22:07:27] <RoanKattouw>	 Like, tomorrow after the standup or something?
[22:07:38] <RoanKattouw>	 (Or whatever time works for you)
[22:07:43] <mvolz>	 RoanKattouw: that would be great
[22:07:44] <RoanKattouw>	 (And when I say chat I mean Google Hangout)
[22:08:18] <mvolz>	 Yeah that would probably work
[22:08:43] <mvolz>	 Thanks!
[22:08:50] <RoanKattouw>	 We can do pretty much any time after 10:30 PDT (18:30 BST)
[22:09:17] <mvolz>	 let's tentatively say after hangout?
[22:09:20] <RoanKattouw>	 OK cool
[22:20:38] <grrrit-wm>	 (03PS2) 10Catrope: Fix GroupElement performance [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) 
[22:23:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and reopening the VE again - 10https://bugzilla.wikimedia.org/66222 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15576   --> https://bugzilla.wikimedia.org/attachment.c...
[22:23:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and reopening the VE again, also cannot switch to edit source mode after that - 10https://bugzilla.wikimedia.org/66222 (10ryasmeen)
[22:23:48] <ryasmeen>	 RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=66222
[22:24:04] <RoanKattouw>	 Thanks ryasmeen 
[22:25:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that - 10https://bugzilla.wikimedia.org/66222 (10ryasmeen)
[22:26:31] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and reopening the VE again, also cannot switch to edit source mode after that - 10https://bugzilla.wikimedia.org/66222#c1 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders This s...
[22:26:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that - 10https://bugzilla.wikimedia.org/66222 (10Roan Kattouw)
[22:27:59] <grrrit-wm>	 (03CR) 10Esanders: Grunt: Create a single file stand-alone distribution for demos etc. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[22:29:00] <grrrit-wm>	 (03CR) 10Jforrester: Grunt: Create a single file stand-alone distribution for demos etc. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[22:29:50] <grrrit-wm>	 (03PS3) 10Catrope: Fix GroupElement performance [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) 
[22:43:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c6 (10Roan Kattouw) These two patches get it down to 780ms on my computer. This breaks down in about 520ms for opening the dialog (including cons...
[22:44:00] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10Roan Kattouw) a:5Ed Sanders>3Roan Kattouw
[23:12:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420 (10WhatamIdoing)
[23:12:29] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10WhatamIdoing)
[23:16:30] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that - 10https://bugzilla.wikimedia.org/66222#c2 (10ryasmeen) Also getting this error now:  Error: Range error: Range...
[23:20:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10James Forrester)
[23:22:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222 (10James Forrester) s:5normal>3critic
[23:28:31] <wikibugs>	 3VisualEditor: VisualEditor:  Some images not displayed in the correct place - 10https://bugzilla.wikimedia.org/66228 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 15578   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15578&action=edit Where the image was displayed before...
[23:29:14] <wikibugs>	 3VisualEditor: VisualEditor:  Some images not displayed in the correct place - 10https://bugzilla.wikimedia.org/66228#c1 (10WhatamIdoing) Created attachment 15579   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15579&action=edit Where the image was (correctly) displayed after saving
[23:30:29] <wikibugs>	 3VisualEditor: VisualEditor:  Some images not displayed in the correct place - 10https://bugzilla.wikimedia.org/66228 (10WhatamIdoing)
[23:30:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10WhatamIdoing)
[23:34:18] <Krenair>	 James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=66135 seems to work for me...
[23:35:07] <James_F>	 Krenair: Did we change something? It was fatal-ing for me yesterday.
[23:35:40] <Krenair>	 As in, I can make a link with that given URL as the target
[23:37:14] <Krenair>	 James_F, can you still replicate that isuse?
[23:37:21] <James_F>	 Krenair: Yes. Where are you testing?
[23:37:33] <Krenair>	 my local dev wiki
[23:38:05] <James_F>	 Krenair: Ah. It's fatal-ing on MW.org and en.wikipedia.beta.wmflabs.org for me.
[23:38:30] <James_F>	 Krenair: Hmm. But not on enwiki for some reason?
[23:38:42] <Krenair>	 James_F, are we checking the same thing?
[23:39:07] <James_F>	 Krenair: Creating a link to the example link in https://bugzilla.wikimedia.org/show_bug.cgi?id=66135#c0 and watching it fatal?
[23:39:25] <Krenair>	 I'm checking that I can add that given graphite URL link as the target of a link
[23:39:29] <James_F>	 Yes.
[23:39:31] <Krenair>	 And it appears to be fine
[23:39:40] <James_F>	 Have you tried on MW.org?
[23:39:42] <Krenair>	 latest master
[23:40:20] <Krenair>	 I can replicate the issue on mediawiki.org
[23:41:02] <James_F>	 Krenair: Can you also not replicate it on enwiki like me?
[23:41:30] <James_F>	 Krenair: Very odd; must be a config issue or something? (It was a problem yesterday on MW.org when that was running wmf7, which is now what enwiki is running).
[23:41:48] <Krenair>	 James_F, confirmed enwiki seems fine
[23:41:57] * James_F blames pixies.
[23:43:14] <Krenair>	 Would enwiki have https://gerrit.wikimedia.org/r/#/c/134632/4 ?
[23:43:26] <James_F>	 Krenair: Yes.
[23:43:42] * James_F hard-reloads just to check.
[23:44:06] <James_F>	 Nope, still works.
[23:45:59] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should not send external link urls to the API for suggestions (because it won't be valuable) - 10https://bugzilla.wikimedia.org/66135#c4 (10Alex Monk) I can replicate this on mediawiki.org but not en.wikipedia.org or my local dev wiki.
[23:47:59] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateData is not available to VisualEditor if the template is a redirect - 10https://bugzilla.wikimedia.org/50964#c13 (10Erik Moeller) Confirmed fixed in 1.24wmf7, yay :-)
[23:49:00] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Would be nice if copying/pasting kept working after a fatal - 10https://bugzilla.wikimedia.org/66229 (10James Forrester) p:5Unprio>3High
[23:49:01] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Would be nice if copying/pasting kept working after a fatal - 10https://bugzilla.wikimedia.org/66229 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None Obviously it'd also be nice if fatals didn't happen, but I have less faith that that is possible i...