[00:00:51] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [WIP] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 
[00:01:05] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [WIP] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 
[00:01:19] <grrrit-wm>	 (03PS2) 10Trevor Parscal: [WIP] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 
[00:01:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (owner: 10Trevor Parscal)
[00:01:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (owner: 10Trevor Parscal)
[00:10:38] <Krenair>	 looks like https://gerrit.wikimedia.org/r/#/c/136599/ and https://gerrit.wikimedia.org/r/#/c/138016/ didn't get merged despite the +2s from Roan
[00:11:19] <Krenair>	 guess it's due to the jenkins/zuul/gearman issues earlier
[00:11:45] <edsanders>	 don't be offended that I've recommended you all for a demotions and pay cuts, it's just game theory
[00:13:23] <edsanders>	 also if my code isn't all merged by tomorrow ( https://gerrit.wikimedia.org/r/#/q/owner:Esanders+status:open,n,z )
[00:13:48] <edsanders>	 I'm going to say you spend 7 hours a day on Facebook
[00:14:02] <edsanders>	 and 45 minutes playing solitaire
[00:48:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Cleanup special character inspector CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138111 (owner: 10Trevor Parscal)
[00:49:35] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cleanup special character inspector CSS [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138111 (owner: 10Trevor Parscal)
[00:52:57] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[00:54:31] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders)
[00:55:07] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138096 (owner: 10Kaldari)
[00:55:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: MWReferenceDialog: Allow swapping of existing references for others [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136599 (https://bugzilla.wikimedia.org/65689) (owner: 10Alex Monk)
[00:55:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Calculate offset correctly in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders)
[00:56:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Split off core image components from pieces needed for image inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138096 (owner: 10Kaldari)
[00:59:21] <grrrit-wm>	 (03PS1) 10Jforrester: Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138122 (https://bugzilla.wikimedia.org/65916) 
[01:00:15] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk)
[01:01:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] Cannot check the wrap option after changing a Thumbnail/Frame image to Frameless/Basic - 10https://bugzilla.wikimedia.org/66291#c5 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal This makes for a confusing bug history. :-)
[01:01:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916 (10James Forrester) 5PATC>3RESO/FIX
[01:01:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't send invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk)
[01:07:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689 (10Alex Monk) 5PATC>3RESO/FIX
[01:14:00] <James_F>	 RoanKattouw_away: Please +2 https://gerrit.wikimedia.org/r/#/c/138122/
[01:30:35] <mooeypoo>	 James_F, I'm being completely selfish going over the bugs with the new image model and finding reasons why the only remaining 2 bugs are not mine.
[01:31:02] <mooeypoo>	 seriously, though :P This is actually a list bug, I think we've had something similar before with multiline items in lists? https://bugzilla.wikimedia.org/show_bug.cgi?id=65924
[01:32:01] <mooeypoo>	 *OR* should we go with changing the fixUpInsertion? I think that would affect all block nodes inside lists, however. Should I go with that?
[01:32:57] <RoanKattouw>	 mooeypoo: Can you explain what's going on there?
[01:33:04] <mooeypoo>	 indeed I can
[01:33:24] <mooeypoo>	 spent time talking to Sherry about this
[01:33:51] <mooeypoo>	 so here's the deal: If you take an inline image in *general*, turn it into a block image, then back into an inline image, the result at the end will be an image inside its own paragraph
[01:33:53] <mooeypoo>	 and that makes sense
[01:34:03] <mooeypoo>	 but this gets a bit wonky inside lists
[01:34:24] <RoanKattouw>	 Yeah I heard it gets wonky
[01:34:29] <RoanKattouw>	 Can you explain what "wonky" means, in detail?
[01:34:31] <mooeypoo>	 so if you do the same to the image in a list, it will go BACK to the same list item it was on, but it will be in its own paragraph. This makes it so the user sees the image<br>text
[01:34:35] <mooeypoo>	 (I'm explaining) :p
[01:34:39] <RoanKattouw>	 argh
[01:34:41] <RoanKattouw>	 OK, I see
[01:34:49] <mooeypoo>	 That happens because both elements are in their own paragraph
[01:34:51] <RoanKattouw>	 It gets its own paragraph rather than being merged into an existing one
[01:34:54] <mooeypoo>	 but then the wikitext is as if that <br> isn't there
[01:34:59] <mooeypoo>	 so either we add a <br> in there
[01:35:03] <RoanKattouw>	 And Parsoid is buggy and doesn't render a <p> there?
[01:35:16] <mooeypoo>	 or we make it so the image goes into the <p> of the existing paragraph
[01:35:32] <mooeypoo>	 I don't think it can, there's an issue with more than 1 <p> tag in wikitext lists IIRC
[01:35:41] <mooeypoo>	 i remember something about this from block language
[01:36:06] <mooeypoo>	 There's a problem in general about multiline lists, especially ones with tags, too.
[01:40:43] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138122 (https://bugzilla.wikimedia.org/65916) (owner: 10Jforrester)
[01:41:01] <mooeypoo>	 hm, there's no issues now with <p> tags when I test them. It was only <pre>
[01:41:07] <mooeypoo>	 RoanKattouw, you're right. this works fine: * <p>[[File:F.C.C.jpg|255x255px]]</p><p>text par2</p>
[01:42:07] <mooeypoo>	 wikitext-wise, I mean. Should this be a Parsoid fix, then? To make sure it adds <p> or should we fixup the insertion and add the image to the existing paragraph
[01:42:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing issues in the alignment select in Media Edit dialog [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/138122 (https://bugzilla.wikimedia.org/65916) (owner: 10Jforrester)
[01:44:44] <mooeypoo>	 w00t
[01:46:38] <RoanKattouw>	 mooeypoo: So we have definitely exposed a Parsoid bug
[01:46:44] <RoanKattouw>	 But we also should try not to do this in the first place
[01:47:04] <RoanKattouw>	 We could see if fixupInsertion could be convinced to put the image into the nearest paragraph
[01:47:22] <RoanKattouw>	 Whether that is reasonable depends on what the removal transaction looks like and what fixupInsertion's input looks like
[01:51:46] <mooeypoo>	 RoanKattouw, should we do this for all cases?
[01:51:50] <mooeypoo>	 that is, not just for lists?
[01:52:24] <James_F>	 mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=65883 might be interesting for this, BTW.
[01:52:26] <RoanKattouw>	 Yes
[01:52:27] <mooeypoo>	 I'm wondering if inserting the image to the logically-closest paragraph may be possible
[01:52:29] <RoanKattouw>	 So, if this is what I think it is
[01:52:41] <RoanKattouw>	 We have <p>Foo</p>|<p>Bar</p> , insertion = inlineImage
[01:52:57] <RoanKattouw>	 I feel like in this case fixupInsertion should move the insertion position into one of the paragraphs
[01:52:58] <mooeypoo>	 right. Maybe always take the previous one, that makes logical sense at least in my mind
[01:53:10] <RoanKattouw>	 (Alternatively one of those two might be absent, but there will be at least one adjacent paragraph)
[01:53:19] <RoanKattouw>	 However, I believe that fixupInsertion already does this
[01:53:23] <RoanKattouw>	 So maybe something else is going on
[01:53:39] <RoanKattouw>	 Or, fixupInsertion *is* doing this, but that still leaves two paragraphs, which is less than three but still one too many
[01:54:01] <mooeypoo>	 James_F, ah, that's a good point too
[01:54:01] <RoanKattouw>	 i.e. <p>Foo<img>Bar</p> --> <p>Foo</p><figure>...</figure><p>Bar</p> --> <p>Foo<img></p><p>Bar</p>
[01:54:03] <mooeypoo>	 that bug
[01:54:14] <RoanKattouw>	 And fixupInsertion is not designed to undo a previous fixupInsertion's paragraph splits
[01:54:28] <mooeypoo>	 hmm
[01:54:33] <RoanKattouw>	 So yeah maybe we could do paragraph unsplitting as part of this, or something
[01:54:37] <RoanKattouw>	 Or not split the paragraph at all
[01:54:44] <mooeypoo>	 oh I see what you mean
[01:54:46] <James_F>	 Indeed.
[01:54:49] <RoanKattouw>	 And do <p>Foo<img>Bar</p> --> <figure>...</figure><p>FooBar</p>
[01:55:00] <mooeypoo>	 you're saying that when we made the image from inline to block it split the paragraph
[01:55:07] <mooeypoo>	 and then returning it to inline it put it in the newly created paragraph
[01:55:08] <mooeypoo>	 right?
[01:55:12] <RoanKattouw>	 Well
[01:55:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883 (10James Forrester) a:3Moriel Schottlender
[01:55:21] <RoanKattouw>	 Naively, you would expect three paragraphs
[01:55:27] <RoanKattouw>	 One with Foo, one with the image, one with Bar
[01:55:31] <mooeypoo>	 hmm
[01:55:38] <RoanKattouw>	 But even with non-naive code, you'd still get two paragraphs
[01:55:44] <mooeypoo>	 are we talking about the case with the list or a general foo|img|bar ?
[01:55:46] <RoanKattouw>	 One with Foo, one with Bar, and the image is in one of those two
[01:55:51] <RoanKattouw>	 In general
[01:56:10] <mooeypoo>	 Because in the case of the list it didn't seem to bring it back to the only paragraph that remained in the list item
[01:56:11] <RoanKattouw>	 The only list-specific thing is that inside lists, we really really want to have only one paragraph, not two
[01:56:14] <RoanKattouw>	 Outside of lists we don't care
[01:56:21] <mooeypoo>	 right
[01:57:25] <mooeypoo>	 hmmm
[01:58:07] <mooeypoo>	 RoanKattouw, if you're saying that the fixupInsertion does it now, though, shouldn't it have inserted the new inline image to the existing paragraph and not create a new one? Or is it a mixup with the list item itself this time?
[01:58:23] <RoanKattouw>	 I don't know exactly what happens
[01:58:29] <RoanKattouw>	 I'm just theorizing about what fixupInsertion is doing
[01:58:41] <RoanKattouw>	 What I recommend doing depends on what is actually happening
[01:58:44] <RoanKattouw>	 So we should find out
[02:00:00] * mooeypoo nods
[02:00:06] <mooeypoo>	 I'm trying to follow the code
[02:02:46] <mooeypoo>	 ... if my computer lets me
[02:02:52] <mooeypoo>	 grr.
[02:16:08] <grrrit-wm>	 (03PS4) 10Jforrester: Use this.$ where available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137913 (owner: 10Esanders)
[02:16:12] <grrrit-wm>	 (03PS4) 10Jforrester: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 (owner: 10Esanders)
[02:16:16] <grrrit-wm>	 (03PS9) 10Jforrester: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) 
[02:17:30] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (626f5ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138134 
[02:50:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (626f5ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138134 (owner: 10Jforrester)
[02:52:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (626f5ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138134 (owner: 10Jforrester)
[02:54:36] <grrrit-wm>	 (03CR) 10Jforrester: "Is this going to be merged into I83ebc801?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders)
[02:56:01] <grrrit-wm>	 (03PS5) 10Jforrester: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[02:56:24] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/135878/ doesn't need rebasing but https://gerrit.wikimedia.org/r/#/c/134363/ does, so maybe do the former first?
[02:57:13] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Highlights, resize handles, etc. not repositioned on window resize - 10https://bugzilla.wikimedia.org/55789 (10James Forrester)
[03:05:32] <James_F>	 mooeypoo: Network issues?
[03:05:45] <mooeypoo>	 Computer issues.
[03:05:55] <mooeypoo>	 Had to restart. <sigh>
[03:10:48] <James_F>	 mooeypoo: Did we get an answer on getting you a new laptop?
[03:11:00] <RoanKattouw>	 James_F: Terry told me he'd do it
[03:11:05] <RoanKattouw>	 Forgot to relay that, sorry
[03:11:08] <James_F>	 RoanKattouw: Ha. OK.
[03:13:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Fix Node construction arguments (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[03:14:52] <mooeypoo>	 Aye I got the email(s) from him and IT
[03:14:55] <grrrit-wm>	 (03PS6) 10Catrope: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[03:14:57] <mooeypoo>	 thank you for that!
[03:15:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[03:15:55] <grrrit-wm>	 (03PS5) 10Catrope: Fix DM node construction, inheritance and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:16:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix DM node construction, inheritance and documentation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:16:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Fix Node construction arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135878 (owner: 10Esanders)
[03:16:34] <James_F>	 mooeypoo: Happy to help. :-)
[03:17:32] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138140 
[03:19:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138140 (owner: 10Jforrester)
[03:20:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Fix DM node construction, inheritance and documentation (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:22:17] <grrrit-wm>	 (03PS6) 10Catrope: Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:22:40] <grrrit-wm>	 (03Abandoned) 10Catrope: Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138140 (owner: 10Jforrester)
[03:24:56] <grrrit-wm>	 (03PS6) 10Catrope: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:28:52] <grrrit-wm>	 (03PS7) 10Catrope: Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:28:54] <grrrit-wm>	 (03PS7) 10Catrope: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:29:19] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/134366/
[03:37:52] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:40:30] <grrrit-wm>	 (03PS8) 10Catrope: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:43:31] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:43:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:43:45] <grrrit-wm>	 (03PS6) 10Catrope: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[03:45:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (2587549) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135881 (owner: 10Esanders)
[03:46:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Separate ExtensionNode in Block/Inline [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134333 (owner: 10Esanders)
[03:48:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Trim linebreaks from block level extensions and preserve (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[03:50:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use this.$ where available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137913 (owner: 10Esanders)
[03:51:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use this.$ where available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137913 (owner: 10Esanders)
[03:52:01] <RoanKattouw>	 James_F: this.isBlock = !this.constructor.static.nodeModel.static.isContent;
[03:52:04] <mooeypoo>	 RoanKattouw, use what where available?
[03:52:07] <mooeypoo>	 har. har har.
[03:52:23] <mooeypoo>	 Sorry, I'm.. lame friday night humor.
[03:52:41] <mooeypoo>	 Speaking of which -- are you two still in the office??
[03:52:47] <James_F>	 mooeypoo: :-)
[03:52:49] <RoanKattouw>	 Yeeaaaahh
[03:52:49] <James_F>	 mooeypoo: And yes.
[03:53:03] <James_F>	 mooeypoo: RoanKattouw can eat dinner after he merges all the things. ;-)
[03:53:06] <RoanKattouw>	 mooeypoo: Did you see my commit message about how using this.$() correctly is 30 times faster than not doing so?
[03:54:11] <mooeypoo>	 Aye, I did
[03:54:20] <mooeypoo>	 that was interesting. I knew it helped, didn't think it helped that much
[03:54:28] <RoanKattouw>	 I didn't either
[03:54:30] <mooeypoo>	 RoanKattouw, you should collect data and publish an IEEE paper!
[03:54:30] <RoanKattouw>	 I had no idea
[03:54:33] <RoanKattouw>	 haha
[03:54:34] <mooeypoo>	 :D
[03:54:52] <RoanKattouw>	 but I had noticed it in reading the code earlier, and tried to fix it just because I couldn't see what else in that function was slow, and presto
[03:57:03] <grrrit-wm>	 (03PS21) 10Jforrester: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[03:57:28] <grrrit-wm>	 (03PS3) 10Jforrester: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders)
[03:57:30] <grrrit-wm>	 (03PS9) 10Jforrester: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders)
[03:57:32] <grrrit-wm>	 (03PS7) 10Catrope: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[03:57:52] <mooeypoo>	 RoanKattouw, any ideas why there's such a big difference?
[03:58:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[03:58:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[03:58:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders)
[03:58:37] <RoanKattouw>	 mooeypoo: Sizzle (selector engine, run from the jQuery constructor) needs to reinitialize itself when it starts dealing with a different document contex
[03:58:39] <RoanKattouw>	 t
[03:58:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders)
[03:59:00] <mooeypoo>	 Interesting
[03:59:09] <RoanKattouw>	 So creating a few nodes and appending them to each other in document A, then appending that subtree to a node in document B, repeat 300 times, will reinitialize Sizzle 600 times
[03:59:22] <mooeypoo>	 ha
[03:59:22] <RoanKattouw>	 (Roughly speaking)
[03:59:35] <RoanKattouw>	 So the Sizzle init function was taking like 2 seconds
[03:59:38] <mooeypoo>	 I can see how it might create a slight lag.
[03:59:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Trim linebreaks from block level extensions and preserve [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134857 (owner: 10Esanders)
[03:59:44] <RoanKattouw>	 (aggregated over all calls)
[03:59:45] <James_F>	 RoanKattouw: https://integration.wikimedia.org/ci/job/VisualEditor-npm/1647/console
[03:59:57] <mooeypoo>	 yeah, ouch. wow.
[04:00:30] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/134363/21/modules/ve/test/ce/ve.ce.test.js
[04:14:07] <grrrit-wm>	 (03PS22) 10Catrope: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[05:13:57] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode (0310 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[05:14:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Inline comments on PS21." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders)
[06:28:51] <grrrit-wm>	 (03PS16) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 
[06:29:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (owner: 10Vikassy)
[08:24:10] <grrrit-wm>	 (03PS8) 10Krinkle: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders)
[08:32:02] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Fix GroupElement performance (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope)
[08:35:46] <grrrit-wm>	 (03CR) 10Krinkle: Fix GroupElement performance (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope)
[09:27:51] <grrrit-wm>	 (03PS17) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 
[11:59:58] <grrrit-wm>	 (03CR) 10Esanders: "Responded, please re-review" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders)
[12:48:12] <grrrit-wm>	 (03PS23) 10Esanders: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[12:48:14] <grrrit-wm>	 (03PS1) 10Esanders: Destroy old target before initialising new one in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138166 
[12:49:21] <grrrit-wm>	 (03PS4) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 
[12:50:46] <grrrit-wm>	 (03PS10) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[12:58:53] <grrrit-wm>	 (03PS5) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 
[12:58:55] <grrrit-wm>	 (03PS11) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 
[12:58:57] <grrrit-wm>	 (03PS2) 10Esanders: Destroy old target before initialising new one in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138166 
[12:58:59] <grrrit-wm>	 (03PS3) 10Esanders: *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 (https://bugzilla.wikimedia.org/66222) (owner: 10Catrope)
[12:59:01] <grrrit-wm>	 (03PS24) 10Esanders: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) 
[12:59:35] <grrrit-wm>	 (03CR) 10Esanders: "Rebased while making a dependency of phantom-menace" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 (https://bugzilla.wikimedia.org/66222) (owner: 10Catrope)
[13:02:31] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 (https://bugzilla.wikimedia.org/66222) (owner: 10Catrope)
[13:03:33] <grrrit-wm>	 (03Merged) 10jenkins-bot: *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 (https://bugzilla.wikimedia.org/66222) (owner: 10Catrope)
[14:44:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222 (10James Forrester) 5PATC>3RESO/FIX
[15:04:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "manual subst" hack doesn't work any more - 10https://bugzilla.wikimedia.org/66281#c1 (10Alex Monk) 5ASSI>3RESO/INV I can't replicate this bug. But I think this is actually invalid.  This 'Clarify' template on enwiki uses some clever 'Unsubst' lu...
[15:31:29] <grrrit-wm>	 (03PS1) 10Paladox: Update jQuery for oojs [oojs/core] - 10https://gerrit.wikimedia.org/r/138169 
[15:32:23] <grrrit-wm>	 (03CR) 10Paladox: [C: 031] Update jQuery for oojs [oojs/core] - 10https://gerrit.wikimedia.org/r/138169 (owner: 10Paladox)
[20:05:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "manual subst" hack doesn't work any more - 10https://bugzilla.wikimedia.org/66281#c2 (10James Forrester) Aha. Anti-subst tech? Whatever next?
[20:05:40] <grrrit-wm>	 (03PS2) 10Jforrester: Upgrade jQuery from 1.8.2 to 1.11.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/138169 (owner: 10Paladox)
[20:05:52] <grrrit-wm>	 (03PS3) 10Jforrester: Upgrade jQuery from 1.8.2 to 1.11.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/138169 (owner: 10Paladox)
[23:16:55] <dpk>	 hi, can someone confirm a possible bug for me?
[23:17:37] <dpk>	 https://en.wikipedia.org/wiki/Oxford_English_Dictionary — editing with the visual editor, the infobox in the section "Second edition" gets … mangled
[23:17:46] <dpk>	 stretches out weirdly
[23:17:50] <dpk>	 it saves okay though
[23:19:40] <Krenair>	 That's because of the parsing issue you see
[23:19:57] <Krenair>	 Likely a Parsoid issue
[23:23:12] <gwicke>	 dpk, could you create a bug?
[23:23:36] <dpk>	 sure, just wanted someone to confirm it wasn't just me first
[23:23:58] <gwicke>	 no, just confirmed that it's indeed parsoid by looking at http://parsoid.wmflabs.org/enwiki/Oxford_English_Dictionary?oldid=612007420