[06:11:45] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?) - 10https://bugzilla.wikimedia.org/66353#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High s:5major>3normal a:3Moriel Schottlender Thanks for this bug; it seems like a regression(?!... [06:14:59] 3VisualEditor / 3Data Model: VisualEditor: Handle transclusions within a table better - 10https://bugzilla.wikimedia.org/50951 (10James Forrester) 5NEW>3ASSI [06:20:29] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933#c4 (10James Forrester) *** Bug 50970 has been marked as a duplicate of this bug. *** [06:20:30] 3VisualEditor: Overlapping templates - 10https://bugzilla.wikimedia.org/50970#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 51933 *** [06:20:44] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933#c5 (10James Forrester) *** Bug 54301 has been marked as a duplicate of this bug. *** [06:20:44] 3VisualEditor: VisualEditor: blue template overlay overlaps other page elements - 10https://bugzilla.wikimedia.org/54301#c2 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 51933 *** [06:21:13] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [06:21:59] 3VisualEditor / 3Editing Tools: VisualEditor: The Strikethrough and Underline gets overlapped for a superscript text - 10https://bugzilla.wikimedia.org/60782#c1 (10James Forrester) 5NEW>3RESO/INV I don't believe this is anything other than Firefox being difficult… [06:22:16] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933 (10James Forrester) [06:22:16] 3VisualEditor / 3Editing Tools: VisualEditor: {{clr}} prevents user from editing content - 10https://bugzilla.wikimedia.org/52431 (10James Forrester) [06:22:17] 3VisualEditor: Overlapping templates - 10https://bugzilla.wikimedia.org/50970 (10James Forrester) [06:24:14] 3VisualEditor: VisualEditor: Parse link in Newarticletext - 10https://bugzilla.wikimedia.org/63673#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 63600 *** [06:24:15] 3VisualEditor / 3MediaWiki integration: VisualEditor : {{FULLPAGENAME}} in replaced by “API” - 10https://bugzilla.wikimedia.org/63600#c6 (10James Forrester) *** Bug 63673 has been marked as a duplicate of this bug. *** [06:26:29] 3VisualEditor / 3Data Model: VisualEditor: Deleting a paragraph separator and subsequently typing any character messes up the page - 10https://bugzilla.wikimedia.org/64128 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [06:26:59] 3VisualEditor / 3ContentEditable: VisualEditor: Breaking words on diacritics - 10https://bugzilla.wikimedia.org/61955 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [06:32:00] 3VisualEditor / 3Editing Tools: VisualEditor: Edited formulae display as raw LaTeX inside VisualEditor if user has MathJax switched on - 10https://bugzilla.wikimedia.org/60728#c2 (10James Forrester) *** Bug 64572 has been marked as a duplicate of this bug. *** [06:32:00] 3VisualEditor / 3Editing Tools: VisualEditor: Math formula does not display correctly if preferences are set to both TeX and MathJax - 10https://bugzilla.wikimedia.org/64572#c3 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 60728 *** [06:33:13] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [06:33:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109 (10James Forrester) p:5Unprio>3High [06:33:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239 (10James Forrester) p:5Unprio>3High [06:42:39] (03PS1) 10Jforrester: Re-order special character mathematical symbols to be degress, minutes, seconds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138304 (https://bugzilla.wikimedia.org/60626) [06:43:16] 3VisualEditor: VisualEditor: Character set in mathematical symbols is out of order (degree, seconds, minutes) - 10https://bugzilla.wikimedia.org/60626 (10James Forrester) p:5Unprio>3Low a:3James Forrester [06:45:15] 3VisualEditor / 3Editing Tools: VisualEditor: There is no keyboard function to exit the Math Inspector and Gallery - 10https://bugzilla.wikimedia.org/63336#c1 (10James Forrester) 5ASSI>3RESO/WOR Escape works for me… [06:47:00] 3VisualEditor / 3Editing Tools: VisualEditor: Closing a Math inspector deletes the selected node/element - 10https://bugzilla.wikimedia.org/60591#c3 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Ed Sanders This was fixed a while ago by Ed. [11:22:29] 3VisualEditor / 3Data Model: VisualEditor: Deleting a paragraph separator and subsequently typing any character messes up the page - 10https://bugzilla.wikimedia.org/64128#c1 (10Ed Sanders) Works for me, probably resolved at some point in the last couple of months. [12:47:22] (03PS4) 10Esanders: Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 [12:47:24] (03PS6) 10Esanders: Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 [12:48:46] (03CR) 10jenkins-bot: [V: 04-1] Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [12:49:00] (03CR) 10jenkins-bot: [V: 04-1] Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [13:37:59] (03PS1) 10Esanders: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) [13:38:35] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933 (10Ed Sanders) a:3Ed Sanders [13:39:24] (03CR) 10jenkins-bot: [V: 04-1] Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [13:39:26] (03CR) 10Esanders: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [13:51:21] (03PS2) 10Esanders: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) [14:43:43] edsanders: Nice. [15:41:14] 3VisualEditor / 3Editing Tools: VisualEditor: hard breaks [Return/enter] are ignored when pages is saved by visual editor - 10https://bugzilla.wikimedia.org/65707#c6 (10James Forrester) 5UNCO>3RESO/INV Closing temporarily as there's no proposed action. Please feel free to re-open. [15:46:29] 3VisualEditor / 3Data Model: VisualEditor: Span tags for Language tool only mark part of the page - 10https://bugzilla.wikimedia.org/65645#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal The language tool only covers text, not block content, so that's expected. The not-getting-to-the-end-of-the... [15:47:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog's request for checkboxes should respect the uselang param - 10https://bugzilla.wikimedia.org/65455 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [15:50:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Using "page down" (PgDn) key to scroll down moves the wrong number of lines if the toolbar is on multiple lines - 10https://bugzilla.wikimedia.org/65241 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [15:51:05] Hey [15:51:22] so i've been working on getting VE to work with my internal wiki for some time now [15:51:29] 3VisualEditor: Where/what have I edited - 10https://bugzilla.wikimedia.org/65247#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 37931 *** [15:51:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: Highlight changes made since save in some way (e.g. with a text-background?) so users can see what changes they have outstanding - 10https://bugzilla.wikimedia.org/37931#c4 (10James Forrester) *** Bug 65247 has been marked as a duplicate of this bug. *** [15:51:37] i've gotten to the point where i have it working so long as my wiki is public [15:51:50] if i change it to be a private wiki requiring login it does not work [15:52:03] i am willing to work on this but need help figuring out how to debug what's going on [15:52:08] [warning/api][null/Main_Page] Failed API request, 8 retries remaining. [15:52:17] that's the error message I get in the PARSOID service [15:52:44] 3VisualEditor / 3Language: VisualEditor: Using auto select zhu-yin input and it keeps bouncing duplicate chinese characters - 10https://bugzilla.wikimedia.org/61429 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5normal>3major [15:53:18] jeffo: did you send a valid cookie with your request? [15:54:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - 10https://bugzilla.wikimedia.org/61575 (10James Forrester) [15:55:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar help menu doesn't render nicely if the alert (edit notices) other half of the group isn't active - 10https://bugzilla.wikimedia.org/61575 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [15:55:29] i have to assume i have, i am using Chrome and I have the cookie setting set to true [15:55:43] $wgVisualEditorParsoidForwardCookies = true; [15:56:14] 3VisualEditor / 3Technical Debt: VisualEditor: Move floating functionality from SurfaceToolbar to Toolbar? - 10https://bugzilla.wikimedia.org/55784 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [15:56:37] i would test in internet explorer, but for some reason i don't get the VE button "Edit" when using IE but that's another issue I'd just as soon leave alone [15:56:56] jeffo: IE is blacklisted because it doesn't work yet. [15:57:00] sweet [15:57:05] good to know [15:57:31] jeffo: If you fish the XHR out of your browser and plug it into the API, does the request work? [15:58:47] 3VisualEditor / 3Editing Tools: VisualEditor: Shows "<" icon on the last clicked link, if user clicks on the link icon from the toolbar on a blank space - 10https://bugzilla.wikimedia.org/56503#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal This was fixed a while ago; so... [15:58:50] i wish i knew how to do that [15:59:29] 3VisualEditor / 3Technical Debt: VisualEditor: Instrument all actions in visual editing toolbar for organization and frequency of use analysis and improvements - 10https://bugzilla.wikimedia.org/65510 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [16:00:19] 3VisualEditor / 3MediaWiki integration: VisualEditor: Footnote number is not localized while editing - 10https://bugzilla.wikimedia.org/66338#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 56240 *** [16:01:07] oh [16:01:09] i think i just did [16:01:37] http://wiki_url/core/api.php?format=json&action=visualeditor&paction=parse&page=Main_Page [16:01:44] does that look what you're after? [16:02:08] if i go to that page it just says "Waiting" and i get the same messages in the parsoid [16:02:24] [info][localhost/Main_Page] starting parsing [16:02:24] [warning/api][localhost/Main_Page] Failed API request, 8 retries remaining. [16:02:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Reset title opacity on API call failure - 10https://bugzilla.wikimedia.org/53707#c1 (10James Forrester) 5NEW>3ASSI I believe we fixed this a few months ago; sorry for the slow triage. [16:03:17] jeffo: That API call is the one that VE makes to VE-server which relays it to Parsoid. [16:04:40] jeffo: I assume …/api.php?action=parse&page=Main_Page works without a cookie, right? [16:04:53] if i make my wiki public everything works [16:05:06] jeffo: And that http://www.mediawiki.org/w/api.php?action=parse&page= doesn't? [16:05:07] and going there works too [16:05:42] ok actually /api.php?action=parse&page=Main_Page does not work [16:05:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Reset title opacity on API call failure - 10https://bugzilla.wikimedia.org/53707 (10James Forrester) 5ASSI>3RESO/FIX p:5Unprio>3Normal [16:06:03] let me turn public on [16:07:14] 3VisualEditor / 3Editing Tools: Visual Editor: Different behaviour in the link editor on pressing escape for the first and subsequent links in a page - 10https://bugzilla.wikimedia.org/53302#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal Sorry for the slow triage; this was an irritating bug... [16:07:42] if i turn public read on, everything works [16:07:55] including /api.php?action=parse&page=Main_Page [16:08:15] Sure, but if you don't, what happens? [16:08:30] if i turn public read off, the apache thread hangs waiting on a response from parsoid [16:08:42] [info][localhost/Main_Page] starting parsing [16:08:42] [warning/api][localhost/Main_Page] Failed API request, 3 retries remaining. [16:08:48] i get that warning like 8 times [16:08:50] finally times out [16:08:55] then apache is responsive again [16:09:05] it seems like parsoid cannot pull the page to parse [16:09:05] jeffo: Sure, because your private wiki config isn't working with Parsoid. We worked that out. :-) [16:09:14] Yeah [16:09:22] jeffo: To help you any more, we need to know what is causing it to fail. [16:09:28] but i am not sure what to do about it because i've got the flag set for that in the VE config [16:09:32] right [16:09:35] how do I debug that? [16:10:38] jeffo: With the server locked down, go to …/api.php?action=parse&page= that won't work if you're not authorised. [16:10:47] jeffo: E.g. /api.php?action=parse&page=SecretPlans or whatever. [16:11:02] done [16:11:10] open read only is now [16:11:11] jeffo: You get an error, right? [16:11:11] of [16:11:13] off [16:11:33] and when i browse to /api.php?action=parse&page=Main_Page it is now not working [16:11:47] You get "" ? [16:11:47] im not really getting an error [16:11:57] well [16:12:08] let me let it time out then [16:24:14] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?) - 10https://bugzilla.wikimedia.org/66353#c2 (10Moriel Schottlender) Yes, after a bit of analysis, I believe there's a problem with the way the scalable object analyzes default vs custom values. I'... [16:27:14] "The Scalable Rises From The Deep", a new movie, now in theaters! Staring ImageEditDialog as Damaged But Talented Superhero, and TheImageWikitext as Dr. Villain. Critics go wild on Bugzilla! Check your local listings for a schedule! [16:28:59] :-) [16:29:54] hm, also, I think I found a bug in Parsoid [16:30:06] {"error":{"code":"parsoidserver-http-request-error","info":"MWHttpRequest error"}} [16:32:09] [[File:Kostel Charvatce - půdorys.jpg|Půdorys kostela v Charvatcích|none|frame|700x700px]] <-- this image appears in Parsoid (through VE but also in the standalone wikitext test in parsoid) as 923x467 ... shouldn't the 700x700 limit the width to 700? [16:32:43] mooeypoo: it's a frame image [16:32:51] gwicke, aye, it is [16:33:04] its default values are full width, but in this case there's an explicit size [16:33:23] https://www.mediawiki.org/wiki/Help:Images#Size_and_frame : "An image with frame always ignores the size specification, the original image will be reduced if it exceeds the maximum size defined in user preferences." [16:33:57] ... [16:34:03] gods I missed that part. [16:35:15] the rules for images are tricky [16:35:16] Is this new?? how did I miss this. [16:35:23] gwicke: s/tricky/stupid/ [16:35:24] gwicke, understatement of the century. [16:35:39] ;) [16:35:47] well. James_F, that seems to be the reason for the bug above, then. I thought it was my default size thing. I still should (and will) refactor it, but yes... [16:36:13] Also, this means I might have to disable the size widget when we're on "frame" then, since it doesn't matter. [16:36:14] mooeypoo: it's not new [16:37:30] gwicke, yeah I am going to revisit all size limitations once again. I went through this page before, but I seem to have missed this (pretty glaring humongous issue) before. [16:38:44] 3VisualEditor: Drop-down menu in VisualEditor toolbar causes alternating horizontal scroll bars in dropdown and page - 10https://bugzilla.wikimedia.org/56713#c1 (10James Forrester) 5NEW>3RESO/WOR I can't reproduce; do you have a screenshot? [16:39:38] ok so [16:39:40] this is weird [16:40:14] 3VisualEditor / 3Editing Tools: VisualEditor: "existing references" in the references dialog not identifying references - 10https://bugzilla.wikimedia.org/52742#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 50474 *** [16:40:15] 3VisualEditor / 3Data Model: VisualEditor: References created by templates numbered alone, not with the rest of the page, and don't show up as references to insert - 10https://bugzilla.wikimedia.org/50474#c31 (10James Forrester) *** Bug 52742 has been marked as a duplicate of this bug. *** [16:41:15] 3VisualEditor: VisualEditor: Re-used references don't always match - 10https://bugzilla.wikimedia.org/64104#c1 (10James Forrester) 5NEW>3RESO/WON I'm pretty sure this is a WONTFIX; if the wikitext is in such a broken state that it defines a reference twice, there's nothing sane that VisualEditor can reall... [16:42:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add redirect=no to URL after a page is newly created as a redirect - 10https://bugzilla.wikimedia.org/65621 (10James Forrester) [16:42:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: On pages which are redirects, veaction=edit should actually do redirect=no&veaction=edit - 10https://bugzilla.wikimedia.org/65926 (10James Forrester) [16:42:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) [16:43:14] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) 5REOP>3ASSI p:5Low>3High [16:44:44] 3VisualEditor / 3Editing Tools: VisualEditor: "Clear formatting" should never be highlighted - 10https://bugzilla.wikimedia.org/58371#c5 (10James Forrester) 5REOP>3RESO/FIX That bit is now fixed too AFAICT. [16:44:45] so here's some weirdness [16:44:53] i set the VE Timeout for waiting on parsoid to 10 seconds [16:45:10] i get the MWHttpRequest error in my web browser [16:45:20] but it appears that when that timeout occurs, parsoid works [16:45:28] [info][localhost/Main_Page?oldid=4] completed parsing in 20666 ms [16:45:36] but it's only after the timeout lock is released [16:45:59] 3VisualEditor / 3ContentEditable: VisualEditor: Using up-arrow to scroll lets you put the cursor under the toolbar in Firefox - 10https://bugzilla.wikimedia.org/48787 (10James Forrester) 5REOP>3ASSI [16:46:25] 20s to parse the main page? What on Earth do you have on there? :-) [16:47:30] 3VisualEditor / 3Editing Tools: VisualEditor: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them - 10https://bugzilla.wikimedia.org/62084#c3 (10James Forrester) 5REOP>3ASSI Ruddy Firefox bugs. [16:47:32] the word "test" [16:47:38] but it's not taking 20s to parse [16:47:43] something else is happening [16:47:45] to cause the lock [16:47:53] ahhh, I have an idea [16:47:57] then the lock is released and parsoid finishes only because the lock is relased [16:48:11] but parsoid is delivering the info to a train thats already left [16:48:13] you are probably using php's native session storage? [16:48:37] if thats a default i am [16:48:51] IIRC there was some deadlock issue with that [16:48:59] 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933 (10James Forrester) [16:49:41] jeffo: basically you can't do two concurrent requests to PHP using the same session when using the default session storage [16:49:54] mkay [16:49:56] we don't have that problem in production as we are using memcached [16:50:06] what can i change to test that? [16:50:14] IIRC there's also an option to use the DB if you don't have memcached [16:50:28] 3VisualEditor / 3Editing Tools: VisualEditor: Additional keyboard shortcuts (tracking) - 10https://bugzilla.wikimedia.org/65955 (10WhatamIdoing) [16:50:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog description field doesn't respond to 'Enter' or 'Return' keys - 10https://bugzilla.wikimedia.org/38042 (10WhatamIdoing) [16:50:31] 3VisualEditor / 3Editing Tools: VisualEditor: Ctrl-Alt-s / ⌘-Opt-s should trigger the save dialog, and the save button when inside said dialog - 10https://bugzilla.wikimedia.org/50897 (10WhatamIdoing) [16:51:58] jeffo: I don't remember the details off hand, RoanKattouw_away will know [16:52:14] 3VisualEditor / 3Editing Tools: VisualEditor: Allow users to set/edit __DISAMBIG__ status in the page meta-data panel - 10https://bugzilla.wikimedia.org/61073 (10James Forrester) [16:53:25] ok [16:53:35] but this is something that would only happen in the case of a private wiki? [16:54:48] jeffo: https://www.mediawiki.org/wiki/Manual:$wgSessionsInMemcached might be useful [16:55:03] mkay [16:55:10] or rather, https://www.mediawiki.org/wiki/Manual:$wgSessionsInObjectCache [16:55:54] "This can be useful to improve performance, or to avoid the locking behaviour of PHP's default session handler, which tends to prevent multiple requests for the same user from acting concurrently." [16:55:57] oh ffs [16:56:23] should add this to the VE docs if it's not yet inthere [16:56:32] hold on [16:57:03] jesus christ [16:57:04] that was it [16:57:13] i skipped right over it [16:57:39] because i had no idea what a non-locking session store was [16:57:58] glad it works now [16:58:01] no shit [16:58:03] im elated [16:58:18] thanks for the laser focus on that issue [16:58:36] is there any way i can contribute to make the documentation more fool proof? [16:58:52] sometimes when a fool doesn't write the documentation it can be confusing to someone like me [17:00:13] in https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis that setting is commented out -- maybe it should not be to make it clearer? [17:00:31] /cc James_F|Away RoanKattouw_away [17:01:28] i will edit it in a way that would've helped me catch it [17:01:28] sec [17:07:27] ok all set [17:09:23] im going to begin work on migrating our internal wiki to 1.24a and applying the VE stuff i learned on my test install [17:09:41] if i find anything else, i'll modify some more documentation that would've helped me avoid some pitfalls [17:20:19] oh speaking of docs, gwicke, I forgot to ask -- I think that the parsoid install docs are missing the new parsoid extension..? [17:20:47] gwicke, I was going to add this manually to my newbie-dev install manual but then realized I should probably add it in source -- unless it exists on another page? [17:26:41] Krinkle: No stand-up? :-( [17:27:06] James_F: no sorry, I'm in enemy territory. [17:27:21] Krinkle: … jQuery conference? Hardly enemy… [17:27:40] what? is that today? It better not be. [17:28:16] Krinkle: OK, I'll not ask what you mean then. :-) [17:29:04] I was implying I'm in Germany, though that's not the case. Just visiting friends and can't talk here. [17:29:12] Aha. [17:29:23] How would Germany be enemy territory? Has Putin invaded already? [17:29:29] Hehe [17:30:00] I don't know, it felt like an appropriate given I am half German and there was this thing in WW2. [17:30:53] Krinkle: The bit where the country I'm in perpetrated war crimes? :-) [17:30:59] 3VisualEditor / 3Editing Tools: VisualEditor: hard breaks [Return/enter] are ignored when pages is saved by visual editor - 10https://bugzilla.wikimedia.org/65707#c7 (10Jared Zimmerman (WMF)) 5RESO/INV>3REOP Two possible proposals that we could use one, both, or some variations When consecutive breaks a... [17:34:36] (03CR) 10Catrope: [C: 032] Destroy old target before initialising new one in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138166 (owner: 10Esanders) [17:37:39] hey, can i steal krinkle or roan for some reviewing and wmf-backporting? CSS changes. https://gerrit.wikimedia.org/r/#/c/137715/ https://gerrit.wikimedia.org/r/#/c/138356/ [17:37:54] (in core, about the new "More" dropdown in Vector) [17:38:17] MatmaRex: Eurgh, sure. Krinkle? [17:38:27] Yep [17:38:43] I approve this message. [17:38:45] And this one [17:39:08] (03Merged) 10jenkins-bot: Destroy old target before initialising new one in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138166 (owner: 10Esanders) [17:44:09] (03PS2) 10Catrope: Re-order special character mathematical symbols to be degrees, minutes, seconds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138304 (https://bugzilla.wikimedia.org/60626) (owner: 10Jforrester) [17:44:28] (03CR) 10Catrope: [C: 032] Re-order special character mathematical symbols to be degrees, minutes, seconds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138304 (https://bugzilla.wikimedia.org/60626) (owner: 10Jforrester) [17:45:51] (03Merged) 10jenkins-bot: Re-order special character mathematical symbols to be degrees, minutes, seconds [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138304 (https://bugzilla.wikimedia.org/60626) (owner: 10Jforrester) [17:46:29] 3VisualEditor / 3Editing Tools: VisualEditor: Character set in mathematical symbols is out of order (degree, seconds, minutes) - 10https://bugzilla.wikimedia.org/60626 (10James Forrester) 5PATC>3RESO/FIX [17:50:42] (03CR) 10Catrope: Fix GroupElement performance (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [17:50:48] ( Krinkle ---^^ ) [17:52:35] RoanKattouw: k [17:52:36] RoanKattouw: also, https://gerrit.wikimedia.org/r/#/c/135085/ [17:52:50] Right, yes [17:52:52] That one [17:57:40] (03PS1) 10Vikassy: [BrowserTest]Added script to run cucumber for varios languages and upload it to wikimedia commons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138377 [17:58:21] Oh right those FIXME comments in mediawiki.js are still tere [17:58:23] *there [17:58:40] (03CR) 10Krinkle: Fix GroupElement performance (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [17:59:29] (03CR) 10Krinkle: Fix GroupElement performance (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [18:00:08] (03PS2) 10Vikassy: [BrowserTest]Added script to run cucumber for various languages and upload it to commons using mediawiki_api gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138377 [18:00:35] Krinkle: What do you mean exactly by "the victim is cloned as necessary"? [18:00:47] $('.foo').append('.bar') [18:00:54] will duplicate all of .bar's for each .foo [18:01:05] OK [18:01:15] Oooooh I see what you're saying [18:01:18] the original will be moved to the first match, as appendChild normally would, the others get a clone. [18:01:21] foo.$element.before( $lotsOfStuff ) [18:01:25] Yeah [18:01:33] If foo.$element.length > 1, then $lotsOfStuff is cloned and appended before each one? [18:01:40] Yep [18:01:43] Aha [18:01:51] OK in that case we definitely need to assume .$element.length === 1 [18:01:54] which is fine anyway [18:01:59] * RoanKattouw amends [18:02:05] A naive implemention might move it around the dom (append to each, so it ends up in the last one), but jQuery doesn't do that. [18:02:39] ... since native appendChild always implies detaching from current parent. [18:03:12] Ah, I didn't make that extra step. Very well then, let's do this :) [18:05:41] wahaha [18:05:42] its working [18:05:44] unbelievable [18:06:19] so fwiw i can confirm mediawiki 1.24a + master VE + master LDAPAuthenticator works so long as you're smarter than the config file [18:07:50] jeffo: Sorry about all that work! [18:11:20] well im just glad it turned out to be mostly me [18:11:27] i mean how could it be anything else [18:11:32] but it was a pain getting there [18:11:46] jeffo: :-( [18:12:00] ok it was all me [18:12:24] jeffo: I think our config messaging needed improvement too. [18:13:42] Krinkle: Re where to check the skip function, I left a comment there too [18:14:04] Basically if you're worried about calling the skip function multiple times, just null it out regardless of its return value [18:14:11] That way you're guaranteed to only check it once [18:14:39] It would be a bit cleaner to check it in the "right" place, but the fact that you and I between us have trouble figuring out what that right place is tells me that this code needs serious refactoring [18:14:41] even for small pages, parsing seems to take 2-4 seconds [18:14:52] is there any tweaks i should make for that? [18:14:55] are there [18:15:50] jeffo: In the WMF setup we have a Varnish cache in front of Parsoid [18:16:00] On my system small pages parse a bit faster than that but not too much faster [18:16:25] mkay [18:16:33] caching doesnt make sense on my mini wiki [18:16:38] but thats cool [18:17:04] hmmm [18:17:10] Why is Parsoid parsing two versions of my Main Page.... [18:18:56] Oh maybe just because I have these weird cache settings [18:18:58] err TrevorParscal I added a 'setDisabled' routine (custom) to the MediaSizeWidget and it seems it's being called automatically before the widget is fully built [18:19:00] Disabling that makes it go away [18:19:17] jeffo: So with a vanilla-ish config, parsing a simple page with just an image on it takes 600ms for me [18:19:26] TrevorParscal, I added conditions to check if the widgets exist before disabling... but... should that happen? [18:19:53] mooeypoo: Oh, setDisabled is infamous for this [18:19:58] It gets called from the Widget constructor [18:19:59] meh. [18:20:03] Which runs before your constructor [18:20:13] RoanKattouw, why? [18:20:27] So yeah, in your custom setDisabled function, check if the widget is fully constructed and bail otherwise [18:20:43] See e.g. GroupWidget#setDisable [18:20:48] RoanKattouw, okay [18:20:48] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c4 (10ryasmeen) Created attachment 15607 --> https://bugzilla.wikimedia.org/attachment.cgi?... [18:20:50] mooeypoo: Because ... reasons [18:20:59] oh, that makes perfect sense, then [18:20:59] roan: [info][localhost/Projects?oldid=1764] completed parsing in 832 ms [18:20:59] :D [18:21:02] The constructor calls .setDisabled( false ); [18:21:03] me too looks like [18:21:13] RoanKattouw, ok, awesome, I just wanted to make sure I didn't find a new undiscovered bug [18:21:14] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c5 (10ryasmeen) Created attachment 15608 --> https://bugzilla.wikimedia.org/attachment.cgi?... [18:21:26] RoanKattouw: https://gerrit.wikimedia.org/r/133037 is the Disambiguation change FWIW. [18:21:27] jeffo: Yeah that's about what I get too. Mine is a little bit faster but it varies by +/- a couple hundred ms between runs anyway [18:21:44] mooeypoo: No, you just found a skeleton in the closet :) [18:21:48] probably doesn't help that ive got parsoid started interactively [18:22:04] Wait, started interactively? [18:22:09] yeah [18:22:14] RoanKattouw, it's pride month. We shouldn't have anything in the closet. [18:22:16] node api/server.js in an active ssh [18:22:30] instead of node api/server.js & or started through init.d or whatever [18:22:39] i may be using the wrong term [18:22:48] Oh, right [18:22:53] No I'm running it the same way [18:22:53] mooeypoo: :-) [18:22:57] but i also have debug turned on, so i see a stream of nonsense every time i parse a page [18:29:03] (03PS4) 10Catrope: Fix GroupElement performance [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) [18:29:10] RoanKattouw, this one concerned my a bit retrospectively: https://gerrit.wikimedia.org/r/#/c/138166/ [18:30:01] the reason it was necessary was that in the SA demo, when you loaded a second page, the event window.resize event handler was getting ubound before it was getting bound [18:30:27] but as it's unbound by function reference that shouldn't matter surely? [18:30:47] edsanders: I think that might be $.proxy()'s "helpfulness" [18:30:53] Krinkle|detached will now [18:30:55] *know [18:31:35] Also, in the mobile UI we had this problem where the old surface was never destroyed, and if you started a new editor, the two surfaces would fight, and you'd get a crash when one of them had a longer document than the other because of array index out of bounds errors [18:31:35] $.proxy(fn1) === $.proxy(fn1) ? [18:31:43] which sounded really scary [18:32:03] We "fixed" it by destroying the old surface, but it bodes ill for our capacity to have multiple surfaces active on any given page [18:32:37] shouldn't these be different functions because they're different instances of surface? [18:33:10] Yeah I suppose they should be [18:33:14] RoanKattouw, right, want to get an SA demo with multiple surfaces working [18:33:16] The object they bind to is different [18:33:21] edsanders: Yeah I'd like that [18:33:49] but looks like I'm missing something about $.off [18:34:00] Maybe [18:34:28] I also don't want to use event classes there because then one instance would unbind other instances' events [18:34:34] (we should audit existing uses of event classes for that) [18:35:45] Maybe the problems are with both surfaces binding to events on global things like window, and both responding in ways that fight each other? I don't know [18:36:23] Krinkle|detached: I've amended https://gerrit.wikimedia.org/r/#/c/137741 [18:46:03] (03PS1) 10Mooeypoo: Allow for the disabling of the MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 [18:46:28] (03PS4) 10Jforrester: history: Add notes for v1.0.10-pre [oojs/core] - 10https://gerrit.wikimedia.org/r/138215 [18:47:48] (03PS5) 10Jforrester: history: Add notes for v1.0.10-pre [oojs/core] - 10https://gerrit.wikimedia.org/r/138215 [18:48:14] (03CR) 10Jforrester: [C: 032] "PS4 added a history line, but I thought better of it, so +2." [oojs/core] - 10https://gerrit.wikimedia.org/r/138215 (owner: 10Jforrester) [18:49:12] (03Merged) 10jenkins-bot: history: Add notes for v1.0.10-pre [oojs/core] - 10https://gerrit.wikimedia.org/r/138215 (owner: 10Jforrester) [18:49:24] (03PS1) 10Mooeypoo: Disable the size widget for 'frame' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) [18:51:59] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?) - 10https://bugzilla.wikimedia.org/66353#c4 (10Moriel Schottlender) Scratch my last remark. There is still a technical debt (that is being taken care of) about default vs. custom size but the issu... [18:59:26] RoanKattouw, yeah I think we're only using event namespaces for focusable which at the moment wouldn't cause a problem [18:59:37] but should probably be changed [19:06:35] (03PS1) 10Esanders: [BREAKING CHANGE] Remove $document cache from target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138393 [19:06:45] (03PS1) 10Esanders: Replace instances of target.$document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 [19:07:16] (03CR) 10Esanders: "Fixed in MW by Ibff83cae" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138393 (owner: 10Esanders) [19:07:16] edsanders: You checked the Mobile integration still works with that? [19:07:18] (03CR) 10jenkins-bot: [V: 04-1] Replace instances of target.$document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 (owner: 10Esanders) [19:07:38] * James_F is nervous. [19:09:16] yes [19:10:01] if it didn't that would be bad, they shouldn't be reaching inside the target from outside VE code [19:11:30] 3VisualEditor / 3Data Model: VisualEditor: Span tags for Language tool only mark part of the page - 10https://bugzilla.wikimedia.org/65645#c2 (10WhatamIdoing) When I've selected the whole page, I'd rather have the whole page marked with a single pair of tags, even if defining the block content as having a "... [19:12:14] 3VisualEditor / 3Data Model: VisualEditor: Span tags for Language tool only mark part of the page - 10https://bugzilla.wikimedia.org/65645#c3 (10James Forrester) (In reply to WhatamIdoing from comment #2) > When I've selected the whole page, I'd rather have the whole page marked > with a single pair of tags... [19:16:14] 3VisualEditor: VisualEditor: Re-used references don't always match - 10https://bugzilla.wikimedia.org/64104#c2 (10WhatamIdoing) There's no way for VisualEditor to know which is the "right" ref when two refs have the same name but different content. I've seen this occasionally, and the "mismatched" refs somet... [19:18:29] 3VisualEditor: VisualEditor: Re-used references don't always match - 10https://bugzilla.wikimedia.org/64104#c3 (10James Forrester) (In reply to WhatamIdoing from comment #2) > There's no way for VisualEditor to know which is the "right" ref when two > refs have the same name but different content. I've seen... [19:20:00] 3VisualEditor / 3Editing Tools: VisualEditor: Allow users to set/edit __DISAMBIG__ status in the page meta-data panel - 10https://bugzilla.wikimedia.org/61073 (10James Forrester) 5PATC>3RESO/FIX [19:22:14] 3OOjs: OOjs: Provide a shim for greater browser compatibility - 10https://bugzilla.wikimedia.org/56341#c1 (10Matthew Flaschen) https://kangax.github.io/compat-table/es5/ and http://blogs.msdn.com/b/ie/archive/2010/06/25/enhanced-scripting-in-ie9-ecmascript-5-support-and-more.aspx both indicate IE9 supports alm... [19:24:00] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c6 (10Chris McMahon) also still getting this in automated tests launched from WMF Jenkins (no... [19:24:31] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes " button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3Non... [19:28:44] 3OOjs: OOjs: Provide a shim for greater browser compatibility - 10https://bugzilla.wikimedia.org/56341#c2 (10James Forrester) (In reply to Matthew Flaschen from comment #1) > https://kangax.github.io/compat-table/es5/ and > http://blogs.msdn.com/b/ie/archive/2010/06/25/enhanced-scripting-in-ie9- > ecmascript-5... [19:29:44] 3OOjs: OOjs: Provide a shim for greater browser compatibility - 10https://bugzilla.wikimedia.org/56341 (10James Forrester) [19:30:29] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes " button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389 (10James Forrester) 5NEW>3ASSI p:5Unprio>3No... [19:33:26] (03PS1) 10Esanders: Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 [19:36:27] (03CR) 10jenkins-bot: [V: 04-1] Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 (owner: 10Esanders) [19:36:54] (03PS4) 10Jforrester: core: Avoid IE8 bug fatal error when parsing "super" property [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) [19:37:04] (03CR) 10Jforrester: "PS4 is a rebase." [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [19:38:03] (03PS2) 10Esanders: Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 [19:39:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For all Image Types after changing the alignment to left, it automatically selects the alignment as right when it is positioned at the left of the page, but it doesn't change position in CE surface until save - 10https://bugzilla.wikimedia.org/6556... [19:46:15] 3VisualEditor / 3Editing Tools: VisualEditor: If a user has scrollbars on (e.g. on Windows/Linux), the width of the media search dialog is insufficient and so displays 4 results and a large margin per row - 10https://bugzilla.wikimedia.org/64911#c7 (10ryasmeen) Verified the fix in Betalabs and test2 [19:48:02] James_F, is there a bug like https://bugzilla.wikimedia.org/show_bug.cgi?id=65455 for edit notices? [19:50:18] (03PS1) 10Alex Monk: Send language when making API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) [19:50:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog's request for checkboxes should respect the uselang param - 10https://bugzilla.wikimedia.org/65455 (10Alex Monk) a:3Alex Monk [19:54:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf8] Clicking on "Add Label"/Close button in simple link inspector throws TypeError: this.linkNode is null - 10https://bugzilla.wikimedia.org/66047#c4 (10ryasmeen) Verified the fix in test2 [19:59:57] James_F: So I'm walking a friend through their first Parsoid patch [20:00:08] And he was reading [[Gerrit/git-review]] [20:00:17] Totally naturally, he did this: https://www.mediawiki.org/w/index.php?title=Gerrit/git-review&curid=79984&diff=1032423&oldid=1022111 [20:00:26] So proud of all of this [20:02:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf7] TypeError: sel.nativeSelection is null appears while closing the reference dialog or adding reference /using existing reference in Firefox - 10https://bugzilla.wikimedia.org/65935#c6 (10ryasmeen) Verified the fix in test2 [20:08:52] Hm.. what's the English expression that involves something being fruitful or yielding its fruits? [20:09:09] something like, it already started giving off fruits. Or it gave off fruits. [20:09:14] I'm close. [20:12:00] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf7] Characters and Pawns are getting added in each line and throwing error: ve.dm.Document.getNodeFromOffset(): offset -1 is out of bounds while trying to add a reference in Firefox - 10https://bugzilla.wikimedia.org/65934#c5 (10ryasmeen) Verified the... [20:16:00] 3VisualEditor / 3ContentEditable: VisualEditor: When the toolbar is disabled, clicking an image on the page does not select it - 10https://bugzilla.wikimedia.org/65866#c4 (10ryasmeen) Verified the fix in Betalabs and test2 [20:20:16] Krinkle: It's started to bear fruit? [20:21:12] yeah, "bear" is what I found in the dictionary but it doesn't sound right. I think I've heard another expression. [20:21:40] Hm.. maybe I'm thinking of a Dutch expression? Do we have something like that? [20:21:48] Krinkle: Vruchten afwerpen? [20:22:06] (03PS3) 10Esanders: Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 [20:22:23] RoanKattouw: Yeah, that's probably it. [20:22:53] bear sounds weird. [20:23:02] I want to say it's spawning its fruits. [20:23:05] :)D [20:23:17] No, sorry, trees really do bear fruit [20:23:45] Also, women bear children, and Americans have the right to bear arms [20:24:05] marktraceur: Cool. :-) [20:24:09] And yesterday's weather was unbearable [20:24:13] yeah, but bare with me, I can't bear it. [20:24:18] (c.f. dragen/verdragen) [20:24:41] hehe [20:24:46] method overloading is evil [20:25:11] RoanKattouw / edsanders: Parsoid team would like your thoughts on https://gerrit.wikimedia.org/r/#/c/135814/3 [20:25:42] >> var cl = console.log; console.log = function ( msg ) { console.log( 'Oh shit: ' + msg ); }; console.log( 'ERROR' ); [20:25:43] marktraceur: RangeError: Maximum call stack size exceeded [20:25:47] Awwww. [20:26:13] >> var cl = console.log; console.log = function ( msg ) { cl( 'Oh shit: ' + msg ); }; console.log( 'ERROR' ); [20:26:14] marktraceur: undefined; Console: 'Oh shit: ERROR' [20:26:42] Krinkle: "Spawn" has some very specific connotations in English, BTW. [20:27:26] I am aware [20:27:45] Krinkle: Only demonically-posessed trees would spawn things. :-) [20:27:57] Spawn. Like salmon. [20:28:13] Or frogs. [20:28:20] Or campers in TF2. [20:31:18] (03PS1) 10Esanders: Multi-surface fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138430 [20:32:37] (03PS2) 10Esanders: Multi-surface fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138430 [20:33:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c7 (10ryasmeen) 5RESO/FIX>3REOP This is... [20:41:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c8 (10Ed Sanders) 5REOP>3RESO/FIX MW ha... [20:43:35] (03PS1) 10Esanders: Update VE core submodule to master (3a80662) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138458 [20:43:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c9 (10Roan Kattouw) (In reply to Ed Sanders... [20:50:42] (03CR) 10Catrope: [C: 032] Send language when making API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [20:51:10] (03CR) 10Catrope: "MWAHAHAH the evils of uselang!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [20:51:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (3a80662) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138458 (owner: 10Esanders) [20:52:16] (03Merged) 10jenkins-bot: Send language when making API requests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [20:53:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (3a80662) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138458 (owner: 10Esanders) [20:55:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog's request for checkboxes should respect the uselang param - 10https://bugzilla.wikimedia.org/65455 (10Alex Monk) 5PATC>3RESO/FIX [20:55:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog's request for checkboxes should respect the uselang param - 10https://bugzilla.wikimedia.org/65455 (10Alex Monk) [20:57:25] Krenair: Yay. :-) [21:07:16] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689#c8 (10ryasmeen) Verified the fix in Betalabs [21:12:29] 3VisualEditor / 3Language: VisualEditor: In WebKit, moving the cursor (caret) with the arrow keys breaks connected Arabic letters - 10https://bugzilla.wikimedia.org/66339 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [21:12:51] (03CR) 10Krinkle: "You mean a warning specific about uselang or about it being an "Unrecognized parameter". I think there's definitely a good number of reque" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [21:13:15] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10James Forrester) [21:13:15] 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester) [21:13:18] (03CR) 10Catrope: [C: 04-1] "Minor things, looks fine" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 (owner: 10Mooeypoo) [21:14:18] Krinkle: https://gerrit.wikimedia.org/r/#/c/137741/3..4/src/elements/GroupElement.js means this is good to merge? [21:15:01] (03PS5) 10Krinkle: GroupElement: Improve performance by avoiding .add() overhead [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [21:24:20] (03CR) 10Krinkle: [C: 031] GroupElement: Improve performance by avoiding .add() overhead [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [21:24:46] Krinkle: Srsly? [21:25:58] testing now [21:26:20] the stacklayout thingy looks good but looks fragile, just making sure :) [21:26:25] Why +1 before testing? :-) [21:26:26] I hadn't even pulled the code until now [21:26:37] FYI the StackLayout change was written by Trevor on my machine :D [21:26:58] So it's doubly-suspect? :-) [21:27:00] haha [21:27:09] Ahhh. I am post haircut. [21:27:29] Uh, Houston? what happened to our button widgets? [21:27:34] (03CR) 10Alex Monk: "Yeah, that warning. I wasn't 100% sure if we should do this either, but I couldn't come up with much against it, so uploaded for review. " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [21:27:43] I guess they never worked in agora? [21:27:43] Krinkle: Are you seeing empty buttons? [21:27:50] unstyled text [21:27:52] If so, make sure your repos are all in sync? [21:27:54] oojs/ui/demos/widgets_agora.html [21:27:57] clicked the wrong demo :) [21:27:58] Oh, hah [21:28:05] it looks broken though [21:28:06] :-D [21:28:13] Not everything is styled in Agora and you're surprised? :P [21:28:20] Agora styles are being written as needed [21:28:27] Everything is broken until someone needs it to work and fixes it [21:28:28] rm **/*agora* [21:28:30] Krinkle: If only it published to doc.wikimedia.org I could point out the ones that don't work easily. [21:29:13] (:-P) [21:29:28] I should play with these demos more often [21:29:34] Yes. [21:29:39] But maybe after you +2? ;-) [21:29:39] InlineMenuWidget has regressed again [21:30:02] it's doing that thing again where when you select something it flashes back to white (as if not hovered), then blue again, twice, and then it closes the dropdown [21:30:19] That doesn't sound good. [21:30:22] RoanKattouw, when you told me last week that you're merging my code with reservation + code debt, does that mean there's a bug about the code debt? I am not sure where it is, if that's the case? [21:30:34] I think there should be one? [21:30:36] Or should I just work on it and remove whatever //TODO comments we put in? [21:30:39] (03CR) 10Krinkle: [C: 032] GroupElement: Improve performance by avoiding .add() overhead [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [21:30:44] I should have put the bug URL in a Gerrit comment [21:30:49] mooeypoo: Gerrit link? [21:30:51] oh, let me check there. [21:30:52] Thanks Krinkle [21:30:53] mooeypoo: Normally, yes. [21:31:03] Thanks Krinkle. :-) [21:31:10] (03Merged) 10jenkins-bot: GroupElement: Improve performance by avoiding .add() overhead [oojs/ui] - 10https://gerrit.wikimedia.org/r/137741 (https://bugzilla.wikimedia.org/65512) (owner: 10Catrope) [21:31:54] Found it [21:32:02] Sorry, I'm blind. [21:32:03] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512 (10James Forrester) 5PATC>3RESO/FIX [21:32:19] It's even assigned to me... I just completely missed it in my list despite looking for it. Pff. [21:32:25] :-) [21:32:41] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138471 [21:33:02] RoanKattouw: ^^^ and https://gerrit.wikimedia.org/r/138470 equivalent pull-through in MW-core. [21:33:38] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138471 (owner: 10Jforrester) [21:34:04] RoanKattouw, code review! https://gerrit.wikimedia.org/r/#/q/owner:Esanders+status:open,n,z [21:34:13] edsanders: He's doing human-review mostly. :-) [21:34:32] edsanders: Hush, I'm reviewing you rather than your code [21:34:54] As part of this I'm "complaining" that you write so much code for me to review :) [21:35:07] (But yes, I desperately need to get through this CR backlog) [21:35:18] RoanKattouw: How about I just randomly +2 half the things? [21:35:43] James_F: I haven't written your review yet either [21:35:43] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138471 (owner: 10Jforrester) [21:35:54] RoanKattouw: Yeah yeah. :-P [21:42:02] Krinkle: So what's going on with the skip function commit? [21:42:18] I'm going to amend it per your feedback [21:42:22] Cool [21:42:38] With filter() exposed and the skip function nulled out after the first call, it should be good to go IMO [21:43:30] 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916#c8 (10ryasmeen) Verified the fix in Betalabs [21:43:57] RoanKattouw: So you're okay with exposing filter() then? [21:44:28] Yeah I'm OK with tha [21:44:58] aight [21:45:31] I mean it has a symbolic name interface [21:45:39] why would we have that if it's private :) [21:50:42] edsanders: You got anywhere with fixing https://bugzilla.wikimedia.org/show_bug.cgi?id=56644 or https://bugzilla.wikimedia.org/show_bug.cgi?id=65882 ? [21:55:25] not yet [21:56:00] 3OOjs UI: OOjs UI: [Regression] "Switch to source editing" brings up empty "Confirm" dialog - 10https://bugzilla.wikimedia.org/66034 (10ryasmeen) 5PATC>3RESO/FIX [21:57:15] 3OOjs UI: OOjs UI: [Regression] "Switch to source editing" brings up empty "Confirm" dialog - 10https://bugzilla.wikimedia.org/66034#c3 (10ryasmeen) Verified the fix in Betalabs and test2 [21:59:28] (03PS6) 10Trevor Parscal: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 [21:59:30] (03CR) 10jenkins-bot: [V: 04-1] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [21:59:52] (03PS7) 10Jforrester: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [22:04:57] (03PS3) 10Trevor Parscal: [WIP] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 [22:05:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (owner: 10Trevor Parscal) [22:06:10] (03CR) 10Jforrester: [C: 04-1] "Remove the console.log calls please. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (owner: 10Trevor Parscal) [22:07:17] (03PS3) 10Trevor Parscal: [WIP] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [22:09:00] James_F, err, remember our conversation about adding "default" to alignment? [22:09:12] mooeypoo: … yeah? [22:09:37] James_F, we should revisit this idea. There is, apparently, an inconsistent difference between literally saying "none" in wikitext, and having no value (default) but only in certain types of images, because why not. Look: https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test [22:09:41] (03PS1) 10Kaldari: Adding ext.visualEditor.mwimage.core to ext.visualEditor.mobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138475 [22:09:57] mooeypoo: I just want to sigh. [22:10:03] I will join you. [22:10:14] (03PS2) 10Jforrester: Adding ext.visualEditor.mwimage.core to ext.visualEditor.mobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138475 (owner: 10Kaldari) [22:10:26] (03CR) 10Jforrester: [C: 032] Adding ext.visualEditor.mwimage.core to ext.visualEditor.mobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138475 (owner: 10Kaldari) [22:12:05] (03Merged) 10jenkins-bot: Adding ext.visualEditor.mwimage.core to ext.visualEditor.mobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138475 (owner: 10Kaldari) [22:12:10] James_F, Right now these images don't display correctly in VE -- but there's also no way for the user to indicate a difference between "none" (no alignment on purpose) and "default" (no alignment specified) ... so... meh. Should we add 'default' ? or.. I don't know.. there's a difference between whether it's "rendered inline" or not.. does the user care? https://www.mediawiki.org/wiki/Help:Images#Horizontal_alignment [22:12:19] I am not sure how to set this up properly, UI-wise. [22:12:51] mooeypoo: Me neither. [22:13:04] TrevorParscal would love this, btw. [22:13:16] TrevorParscal, maybe we should proceed with our "presets". [22:13:16] * James_F doubts it. ;-D [22:13:20] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [22:13:51] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [22:13:53] (03PS6) 10Jforrester: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [22:14:05] hehe [22:14:16] Full stops are important. :-) [22:14:31] Full stops? [22:18:24] mooeypoo: Periods. Of the punctuation variety. [22:18:53] ("Full stop" is the en-gb term for that) [22:19:48] RoanKattouw, en-gb people should really start speaking ENGLISH. [22:20:39] mooeypoo: "Oooh. See, in *English*, we say..." -- Cadence, to Menna [22:20:53] rofl, she learns early. [22:21:19] The fact that Menna does in fact speak non-English languages doesn't make this easier to explain to a 6yo :) [22:21:41] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 [22:22:21] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (owner: 10Trevor Parscal) [22:24:38] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 [22:25:20] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (owner: 10Trevor Parscal) [22:27:44] (03PS3) 10Trevor Parscal: [BREAKING CHANGES] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 [22:27:58] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGES] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (owner: 10Trevor Parscal) [22:28:13] (03PS4) 10Trevor Parscal: [BREAKING CHANGES] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 [22:28:26] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGES] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (owner: 10Trevor Parscal) [22:28:35] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 [22:28:49] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (owner: 10Trevor Parscal) [22:37:39] James_F|Away, is https://bugzilla.wikimedia.org/show_bug.cgi?id=65926 a regression? [22:42:28] (03PS6) 10Jforrester: [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [22:42:52] Krenair: I don't think so? Maybe. [22:43:09] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [22:44:12] (03PS6) 10Jforrester: [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [22:44:29] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [22:45:03] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=60843 and https://bugzilla.wikimedia.org/show_bug.cgi?id=65343 [22:48:29] 3VisualEditor / 3Data Model: VisualEditor: Deleting a paragraph separator and subsequently typing any character messes up the page - 10https://bugzilla.wikimedia.org/64128#c2 (10Tilman Bayer) Yes, works for me too now in Chromium and Firefox. [22:50:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c10 (10ryasmeen) Verified the fix in Betalabs [22:51:30] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c9 (10ryasmeen) Verified the fix in Betalabs [23:28:47] (03PS1) 10Catrope: Follow-up 2334482: actually clear items in clearItems() [oojs/ui] - 10https://gerrit.wikimedia.org/r/138494 [23:34:26] (03PS1) 10Mooeypoo: Reorganize initialization of default size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138497 (https://bugzilla.wikimedia.org/66149) [23:40:23] (03PS1) 10Mooeypoo: Initialize 'default' size properly in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138500 (https://bugzilla.wikimedia.org/66149) [23:41:24] TrevorP|Away: https://gerrit.wikimedia.org/r/138494 [23:43:17] (03CR) 10Trevor Parscal: [C: 032] Follow-up 2334482: actually clear items in clearItems() [oojs/ui] - 10https://gerrit.wikimedia.org/r/138494 (owner: 10Catrope) [23:43:34] Wow, that was quick. [23:43:45] (03Merged) 10jenkins-bot: Follow-up 2334482: actually clear items in clearItems() [oojs/ui] - 10https://gerrit.wikimedia.org/r/138494 (owner: 10Catrope) [23:43:59] mooeypoo: The diff might amuse you [23:44:19] What's more difficult is seeing how that omission caused the bug at hand (link inspector breakage) [23:44:26] RoanKattouw, I hope you keep updating your weird/interesting/funny patchsets [23:44:36] haha [23:44:54] I haven't been [23:44:56] But I should [23:44:57] RoanKattouw, it would have amused me more if there was a 2-paragraph commit message explaining how this benefits humanity. [23:44:59] \o/ [23:45:17] mooeypoo: Mind adding this one? :) [23:45:24] As well as "Actual death and/or actual destruction" [23:45:36] oh I need to find the list, hang on [23:45:44] https://www.mediawiki.org/wiki/User:Catrope/Ridiculous_VE_commits [23:45:49] got it [23:45:52] Found by typing "ridi" into the address bar [23:45:53] I love Firefox [23:45:55] I bookmarked :D [23:47:12] RoanKattouw: https://gerrit.wikimedia.org/r/138503 [23:47:39] (03CR) 10Krinkle: "(for future reference: 233448261366c, since gerrit is an idiot, too)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/138494 (owner: 10Catrope) [23:49:05] RoanKattouw, updated! [23:49:45] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [23:51:02] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None I have been getting this issue since this... [23:51:04] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (15f4156bac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138505 [23:51:18] RoanKattouw: ^^^ and https://gerrit.wikimedia.org/r/138503 [23:51:32] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396 (10ryasmeen) a:3Roan Kattouw [23:52:36] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (15f4156bac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138505 (owner: 10Jforrester) [23:54:41] (03CR) 10Catrope: [C: 04-1] Use ContextWidget instead of toolbar inside context menu (0312 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [23:55:29] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (15f4156bac) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138505 (owner: 10Jforrester) [23:56:42] (03CR) 10Catrope: [C: 04-1] Update VE core to include ContextWidget changes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal)