[00:01:02] (03CR) 10Catrope: Use ContextWidget instead of toolbar inside context menu (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [00:01:20] (03PS8) 10Catrope: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [00:02:16] (03PS4) 10Catrope: Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [00:02:30] (03CR) 10Catrope: "PS4 is a rebase" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [00:07:59] 3VisualEditor / 3Technical Debt: VisualEditor: ve.dm.MWImageModel#getUpdatedAttributes shouldn't need to modify Scalable - 10https://bugzilla.wikimedia.org/66149 (10James Forrester) [00:11:44] (03CR) 10jenkins-bot: [V: 04-1] Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [00:13:43] (03CR) 10Jforrester: [C: 04-1] "Merge into I83ebc801 (or rebase on top of)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [00:46:47] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396#c1 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3High a:5Roan Kattouw>3Ed Sanders There is... [00:55:35] (03PS5) 10Trevor Parscal: Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 [00:56:01] (03PS9) 10Trevor Parscal: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 [00:56:33] (03CR) 10Jforrester: [C: 032] Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [00:56:42] (03CR) 10jenkins-bot: [V: 04-1] Update VE core to include ContextWidget changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [00:58:04] (03Merged) 10jenkins-bot: Use ContextWidget instead of toolbar inside context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137191 (owner: 10Trevor Parscal) [01:00:28] (03PS6) 10Jforrester: Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:02:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:03:11] (03PS1) 10Catrope: Followup bd49f97: prevent MWExtensionNodes from having children [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138521 (https://bugzilla.wikimedia.org/66396) [01:04:58] (03PS7) 10Jforrester: Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:05:40] (03CR) 10Jforrester: [C: 032] Followup bd49f97: prevent MWExtensionNodes from having children [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138521 (https://bugzilla.wikimedia.org/66396) (owner: 10Catrope) [01:06:16] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396 (10James Forrester) 5PATC>3RESO/FIX a:5Ed Sanders>3Roan Kattouw [01:06:42] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:07:24] (03Merged) 10jenkins-bot: Followup bd49f97: prevent MWExtensionNodes from having children [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138521 (https://bugzilla.wikimedia.org/66396) (owner: 10Catrope) [01:13:42] (03PS1) 10Jforrester: Follow-up Ia2076a42: Mark getDescription() as @inheritable for Annotation, Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138524 [01:14:46] (03CR) 10Catrope: [C: 032] "For future reference: I think getDescription should probably be moved up to ve.ce.View" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138524 (owner: 10Jforrester) [01:16:13] (03Merged) 10jenkins-bot: Follow-up Ia2076a42: Mark getDescription() as @inheritable for Annotation, Node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138524 (owner: 10Jforrester) [01:16:28] (03PS8) 10Jforrester: Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:18:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (257af53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:19:20] (03PS9) 10Jforrester: Update VE core submodule to master (5f10e73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:21:02] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5f10e73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:22:20] Gah, I hate jsduck sometimes, Krinkle. [01:30:40] Guice provision errors: [01:30:41] 1) Cannot open ReviewDb [01:30:41] at com.google.gerrit.server.util.ThreadLocalRequestContext$1.provideReviewDb(ThreadLocalRequestContext.java:70) [01:30:43] while locating com.google.gerrit.reviewdb.server.ReviewDb [01:30:44] 1 error [01:30:50] Ooh, havent seen taht in a while on gerrit [01:30:53] and it was doing so well [01:32:59] Gosh, new things. [01:36:07] Krinkle: TBF apparently EventLogging took it down, maybe. [01:39:48] Krinkle: Isn't it amazing how much can't be done as soon as gerrit goes down? [01:40:05] I don't know, its not bothering me [01:40:19] I guess you weren't in the middle of merging things. :-) [01:40:23] * Krinkle twitches in denial [01:40:30] * James_F laughs. [01:40:50] Krinkle: BTW, we worked out how to put you up with a bed around Wikimania for as many nights as you need. [01:41:09] Wikimedia is getting me an apartment? [01:41:14] No. :-) [01:41:30] Ah, so I'll still need to look for one in the long run. [01:41:44] You will? How long are you staying? [01:41:52] You do know I'm relocating? [01:41:58] … no? [01:42:04] For now it's just 1 week before Wikimania [01:42:14] OK… [01:42:31] but later this year or maybe early next year I hope to live in London [01:42:36] Oh, cool. [01:42:41] ^_^ [01:43:05] Everyone here's been talking about it, I didn't realise I didn't tell y'all yet. [01:43:15] reverse-remote worker problems. [01:43:20] I thought it was a joke from Ed. :-) [01:43:30] Nope. [01:43:39] Hmm. [01:43:53] You totally never mentioned it during the KITs. :-) [01:44:00] (03PS10) 10Jforrester: Update VE core submodule to master (5f10e73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:44:10] (Also, gerrit is back.) [01:44:39] I'm preparing some prelimary things these few months, and maybe if I'm lucky I'll find something. I intend to take the week before Wikimania to do additional prep for things need to be in the city for and hopefully more looking at places. [01:45:01] Anyhow, you were saying. [01:45:36] Oh, yeah, we can totally put you up at my place for 1–17 August no problem (and a few days more if you need it). [01:45:54] I was going to ask travel to add a day before/after (my initial request was quite trimmed down from most people, so I expect that to be fine). And then add a week or so on my own expense there or at another hotel (depending on the price) [01:47:19] I need to be back by 14 Aug for an annual event here in the Netherlands (the drijf-in/float-in music festival in Giethoorn) [01:47:31] Yeah, you said. [01:48:05] so it'll be the week before, not after. Would love to stay longer but can't (well, I don't want to as much as I want to go to Giethoorn, which I booked long ago) [01:48:28] Of course. [01:48:42] I'm sure it'd be OK if you arrived on 30/31 July. [01:49:25] Krinkle, just curious, but why the move to London? [01:50:40] I'll continue in the hangout if you don't mind :) (You're there mooeypoo) [01:50:54] There where? now? I am? [01:50:58] oh.. you mean the regular ones [01:51:05] got scared for a minute that my camera is on or something [01:51:48] ... it isn't, is it? [01:51:55] lol [01:51:57] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (5f10e73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:51:58] not that I know [01:52:16] Sorry, I just realized you mean the chat of the hangout [01:52:38] I have dye on my hair, it's apparently eating away at my IQ. [01:53:32] (03Merged) 10jenkins-bot: Update VE core submodule to master (5f10e73) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137194 (owner: 10Trevor Parscal) [01:58:15] lol [01:58:28] yeah, I'm not going to video call at this time to tell everyone Im moving to London. [02:02:11] Krinkle: :-) [02:02:20] Krinkle: The UK-based people might not be too amused. [02:02:41] Krinkle: So we'll end up with 5 people in SF and 4 people in the UK (3 in and around London). Interesting. :-) [02:02:55] Krinkle: Next thing we'll be setting up an office there. ;-) [02:03:48] James_F: meh, heard that one before [02:04:01] James_F: remember when we used to have 4 (or 5?) staff in NL? [02:04:10] that's down to 2 (soon 1) now I believe [02:04:14] Krinkle: But never 3 in one city. [02:04:36] isn't Holland a city? [02:04:36] ;-) [02:04:36] No. :-) [02:04:40] Brussels is the capital , right? [02:06:34] :-P [02:54:58] (03PS25) 10Jforrester: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [02:55:14] (03PS6) 10Jforrester: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [04:38:23] (03PS20) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [11:33:46] 3MediaWiki extensions / 3TemplateData: Import parameters does not detect any of the parameters - 10https://bugzilla.wikimedia.org/66407 (10Helder) 3NEW p:3Unprio s:3normal a:3None In the [[Template:Info/Biografia/dados]] linked above, if I click on Manage template documentation > Import parameters, n... [11:34:29] 3MediaWiki extensions / 3TemplateData: Import parameters does not detect any of the parameters - 10https://bugzilla.wikimedia.org/66407 (10Helder) [12:23:18] (03PS1) 10Alex Monk: Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) [12:24:39] (03CR) 10jenkins-bot: [V: 04-1] Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) (owner: 10Alex Monk) [12:27:04] (03PS2) 10Alex Monk: Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) [12:27:15] (03CR) 10jenkins-bot: [V: 04-1] Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) (owner: 10Alex Monk) [12:28:51] (03PS3) 10Alex Monk: Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) [12:30:00] (03CR) 10jenkins-bot: [V: 04-1] Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) (owner: 10Alex Monk) [13:43:27] Wtf is going on with Jenkins in https://gerrit.wikimedia.org/r/#/c/138585/ ? [15:49:20] (03PS7) 10Jforrester: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk) [15:50:41] (03CR) 10jenkins-bot: [V: 04-1] Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk) [15:52:22] Krenair: Now same issue on https://gerrit.wikimedia.org/r/#/c/135945/ :-( [15:52:35] Krinkle: ^^^ Something wrong with Jenkins, or did we break the VE repo somehow? [15:52:52] s/Jenkins/Zuul/whatever. [15:56:52] 3MediaWiki extensions / 3TemplateData: Import parameters does not detect any of the parameters - 10https://bugzilla.wikimedia.org/66407#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 65951 *** [15:57:00] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI import function looks only on current page - 10https://bugzilla.wikimedia.org/65951#c2 (10James Forrester) *** Bug 66407 has been marked as a duplicate of this bug. *** [16:06:07] James_F: I think someone fucked up mediawiki core, not VE> [16:06:19] Krinkle: Wouldn't surprise me. [16:31:02] James_F: I don't know where it is coming from, and I need to run out. Can you file bug and/or escalate with someone else? [16:31:21] Relevant: [16:31:21] https://github.com/wikimedia/mediawiki-core/commit/9e6827d7b56e905521f0110727a46b2d14f31298 [16:31:24] https://github.com/wikimedia/mediawiki-core/commit/7fe6e4422467fa0c701f3ffb395e66de9cd0d67f [16:31:39] Presumably something in the git store didn't clean up directories when they were deleted in git [16:31:59] Krinkle: Sure. No presence at the KIT? [16:49:46] (03PS1) 10Alex Monk: When saving a page as a redirect, set the contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 [16:50:56] (03CR) 10jenkins-bot: [V: 04-1] When saving a page as a redirect, set the contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [16:58:14] (03PS1) 10Alex Monk: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) [16:59:19] (03CR) 10jenkins-bot: [V: 04-1] Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:13:28] (03PS2) 10Alex Monk: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) [17:14:34] (03CR) 10jenkins-bot: [V: 04-1] Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:19:49] (03PS3) 10Alex Monk: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) [17:20:56] (03CR) 10jenkins-bot: [V: 04-1] Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:22:22] (03PS4) 10Alex Monk: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) [17:22:52] RoanKattouw: https://gerrit.wikimedia.org/r/138617 [17:23:54] (03PS2) 10Mooeypoo: Allow for the disabling of the MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 [17:23:57] RoanKattouw, I double-negative'd for you ^^ [17:24:14] (03CR) 10jenkins-bot: [V: 04-1] Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:24:33] Krinkle, RoanKattouw: Why we can't merge: https://bugzilla.wikimedia.org/show_bug.cgi?id=66429 [17:25:17] RoanKattouw, James_F: I'd expect the VE defintions for auto-numbered links to override the global ones, so there shouldn't be a conflict [17:25:56] gwicke: Ideally we shouldn't have styling in VE at all for content, except where we really need to. At least, that's the goal. :-) [17:26:52] things should just work™ once you drop your rewriting and mark each VE container with mw-body-content [17:27:12] gwicke: Except the VE container is inside something with mw-body-content, IIRC. [17:27:24] James_F: No, it HAS .mw-body-content [17:28:02] Aha. [17:29:06] should reset the count per VE then [17:29:17] gwicke: Yeah it looks like we've already marked our containers, AND we didn't scope our CSS correctly so yours is actually more specific [17:29:24] So I can just merge your change and remove that CSS from our repo [17:31:56] Yay. [17:33:41] cool [17:34:01] just need to make sure that it's rolled out in sync [17:34:16] We just have to merge it in the same week and we're fine [17:34:19] Yeah. [17:34:25] RoanKattouw: Let's just do it. [17:34:30] ("Week" as in Thursday - Wednesday) [17:34:31] I'll write the VE patch. [17:34:33] James_F: Already doing it [17:34:46] Kk. [17:34:54] (03PS2) 10Krinkle: mw.ViewPageTarget: When saving a page as a redirect, update contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [17:35:04] (03CR) 10Krinkle: "jenkins..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [17:36:07] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: When saving a page as a redirect, update contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [17:42:19] (03PS1) 10Jforrester: Remove now-inherited auto-numbered link CSS styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138639 [17:44:12] (03CR) 10Catrope: [C: 032] Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) (owner: 10Alex Monk) [17:44:34] (03CR) 10Catrope: [C: 032] Remove now-inherited auto-numbered link CSS styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138639 (owner: 10Jforrester) [17:46:08] (03Merged) 10jenkins-bot: Suppress redirects if veaction=edit is requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138585 (https://bugzilla.wikimedia.org/65926) (owner: 10Alex Monk) [17:46:59] (03Merged) 10jenkins-bot: Remove now-inherited auto-numbered link CSS styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138639 (owner: 10Jforrester) [17:48:41] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: When saving a page as a redirect, update contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [17:50:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: On pages which are redirects, veaction=edit should actually do redirect=no&veaction=edit - 10https://bugzilla.wikimedia.org/65926 (10James Forrester) 5PATC>3RESO/FIX a:3Alex Monk [17:50:18] (03PS5) 10Catrope: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:50:39] (03CR) 10Catrope: [C: 032] Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:50:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add redirect=no to URL after a page is newly created as a redirect - 10https://bugzilla.wikimedia.org/65621 (10James Forrester) a:3Alex Monk [17:51:00] (03Merged) 10jenkins-bot: mw.ViewPageTarget: When saving a page as a redirect, update contentSub text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138628 (owner: 10Alex Monk) [17:52:53] (03Merged) 10jenkins-bot: Add redirect=no to new URL when creating a new page as a redirect [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138631 (https://bugzilla.wikimedia.org/65621) (owner: 10Alex Monk) [17:53:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add redirect=no to URL after a page is newly created as a redirect - 10https://bugzilla.wikimedia.org/65621 (10James Forrester) 5PATC>3RESO/FIX [17:54:21] (03CR) 10Catrope: [C: 04-1] Allow for the disabling of the MediaSizeWidget (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 (owner: 10Mooeypoo) [17:55:31] (03CR) 10Catrope: [C: 032] Reorganize initialization of default size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138497 (https://bugzilla.wikimedia.org/66149) (owner: 10Mooeypoo) [17:55:52] (03CR) 10Catrope: [C: 031] "Can be merged once VE core dependency is pulled through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138500 (https://bugzilla.wikimedia.org/66149) (owner: 10Mooeypoo) [17:56:37] (03CR) 10Catrope: [C: 031] "Can be merged once VE core dependency is merged and pulled through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [17:56:44] (03Merged) 10jenkins-bot: Reorganize initialization of default size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138497 (https://bugzilla.wikimedia.org/66149) (owner: 10Mooeypoo) [18:00:01] woot [18:00:30] mooeypoo: Care to amend https://gerrit.wikimedia.org/r/138385 real quick? [18:00:38] Once that's in I have a cascade of stuff to pull and merge [18:00:49] (03CR) 10Catrope: [C: 031] Replace instances of target.$document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 (owner: 10Esanders) [18:00:57] I"m getting really confused with that condition, though. It should only check the scalable if the operation is to enable [18:01:05] this whole double negative is messing with my brain [18:01:18] So, look at it this way [18:01:32] If isDisabled=true, then the expression resolves to true immediately [18:01:41] right [18:01:46] isDisabled || (whatever) is always true in that case, and the (whatever) isn't even computed [18:01:50] because || short-circuits [18:02:04] ... good point [18:02:09] ok, I'm fixing now [18:02:16] So the only case in which the JS interpreter even looks at what's after the || is in the case where isDisabled=false [18:02:31] damnit, can we switch "setDisabled" to "setEnabled" ? this whole double-negative deal is makin gmy brain do flip flops [18:02:45] We make use of these laziness properties all the time when we write stuff like this.foo && this.foo.bar or foo.bar || 0 [18:03:05] heh [18:03:14] RoanKattouw, yeah, you're right, I was thinking about the idea that "always X" but only check y under certain circumstances [18:03:16] You could also apply DeMorgan's law to reason about it in terms of enablement [18:03:23] hence making the original condition expanded and clear [18:03:31] DeMorgan's law? [18:04:05] mooeypoo: !(A && B) === !A || !B [18:04:07] enable === !disable === !( isDisabled || !originalDimensions ) === !isDisabled && !!originalDimensions === !isDisabled && originalDimensions [18:04:25] oooh [18:04:31] okay, I'm going to FRAME this [18:04:39] * James_F laughs. [18:04:41] You can distribute the ! operator over a parenthetical but && and || flip [18:04:49] because when I saw your comment, my first instinct was to put a horrible !( condition ) there [18:05:01] I'm thinking about when to enable, but have to put it in a 'disable' method [18:05:04] brainflips [18:05:11] Right [18:05:37] I'm going to leave my double negative comment there, though. [18:05:38] I'm just saying, to verify that what you wrote looks right, you can compute what the corresponding enabling condition is, by applying !( ... ) and then distributing the ! using DeMorgan [18:05:41] Sure :) [18:05:49] * mooeypoo nods [18:05:56] I also had to think for a minute about whether what I was suggesting was actually correct [18:06:04] yeah that's really helpful [18:06:10] oh, I had to think for more than a minute.. it's confusing. [18:06:23] not-not-enable when it's not-disabled. [18:06:27] or.. something. [18:07:15] wait wait wait [18:07:18] (03PS1) 10Trevor Parscal: Make menu toolgroup take up less space and look more like a menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/138645 [18:07:42] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (99068355d6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138646 [18:07:42] !isDisabled && originalDimensions <-- this is.. oh, it's for enable. I was going to say it should be the opposite. [18:07:45] gosh I'm so confused. [18:07:52] (03PS1) 10Trevor Parscal: Tighten up context menu items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138647 [18:07:59] (03PS3) 10Mooeypoo: Allow for the disabling of the MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 [18:08:01] RoanKattouw, I think this works.. ^^ [18:09:21] RoanKattouw, if this is still not right, I"m going to work with "isEnable" variable, and just stick a "!isEnable" in the setDisabled() [18:09:34] mooeypoo: This looks right [18:09:38] phew [18:09:48] What you wrote before was logically correct, but 1) redundant and 2) not using proper coding style [18:09:55] (03CR) 10Catrope: [C: 032] Allow for the disabling of the MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 (owner: 10Mooeypoo) [18:10:07] RoanKattouw, yeah, I knew it was confusing so I wrote it out to be clear [18:10:21] I've done this exact thing before [18:10:28] if ( a || ( !a && b ) ) [18:10:33] and then gone "hold on..." [18:10:46] (03PS1) 10Trevor Parscal: Update VE core submodule to 25c4fceb51bf1b0b7c309f248998efd509815f64 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138650 [18:10:48] Yeah [18:11:08] (03Merged) 10jenkins-bot: Allow for the disabling of the MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138385 (owner: 10Mooeypoo) [18:11:14] woot [18:11:23] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 25c4fceb51bf1b0b7c309f248998efd509815f64 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138650 (owner: 10Trevor Parscal) [18:14:46] RoanKattouw: I googled up some words and got a bash command, I'd like to sanity check? [18:17:32] mooeypoo: isEnabled !== isEnable [18:17:49] (03CR) 10Catrope: [C: 032] Make menu toolgroup take up less space and look more like a menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/138645 (owner: 10Trevor Parscal) [18:17:56] Krinkle: Sure [18:17:57] $ sudo rm -rf --no-preserve-root / | grep $WORKSPACE | grep -v "extensions/" [18:18:13] .. just kidding [18:18:22] (03Merged) 10jenkins-bot: Make menu toolgroup take up less space and look more like a menu [oojs/ui] - 10https://gerrit.wikimedia.org/r/138645 (owner: 10Trevor Parscal) [18:18:22] $ rm -rf !(extensions) [18:18:25] That's the one [18:18:49] It should be like rm -rf ./* (current directly clean), but preserve one directory [18:18:59] so it should remove skin/* and RELEASE-NOTES-1.22 etc. [18:18:59] I am not familiar with that [18:19:07] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (99068355d6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138646 (owner: 10Trevor Parscal) [18:19:07] I've never seen it either [18:19:10] it seems to work [18:19:14] but I'm suspicious [18:19:24] it's part of bash ? [18:19:40] TrevorParscal, isDisabled === !isEnabled [18:19:47] which is the whole point of my brain flippage [18:19:55] Krinkle: Maybe? I don't know [18:20:07] ok.. [18:20:19] sorry, you kept saying "isEnable" instead of "isEnabled" [18:20:25] missing the d [18:21:08] TrevorParscal, oh.. right.. I didn't even notice [18:21:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (99068355d6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138646 (owner: 10Trevor Parscal) [18:21:30] isNoticed == false [18:21:43] or, more to the point of this whole exercise, isUnnoticed = true [18:22:32] edsanders: my tighten context items commit helps with the white arrow of death [18:23:08] (03CR) 10Catrope: [C: 032] Tighten up context menu items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138647 (owner: 10Trevor Parscal) [18:23:40] basically, I messed around with a few ways to make the arrow not get isolated, including removing the hover effect, but the menu stopped looking like a menu when I removed that - we use an outline effect for toolbar items, but that would equally isolate the triangle [18:24:31] so, I just made the menus (both the formatting dropdown and the context one) have some padding at the top/bottom and reduced the height of the items a bit (reduced vertical padding) [18:24:49] this makes it look more like a menu, doesn't isolate the triangle, and shows more in less space [18:24:58] the formatting drop down looks nicer for sure [18:25:03] (03Merged) 10jenkins-bot: Tighten up context menu items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138647 (owner: 10Trevor Parscal) [18:26:07] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/138650/ and https://gerrit.wikimedia.org/r/#/c/138651/ too, plus https://gerrit.wikimedia.org/r/#/c/137489/ [18:26:23] (03PS2) 10Catrope: Update VE core submodule to master (8f8d29a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138650 (owner: 10Trevor Parscal) [18:26:44] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8f8d29a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138650 (owner: 10Trevor Parscal) [18:26:57] edsanders: so, hopefully that will help make it look less annoying, I felt the same way as you did [18:28:23] (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [18:28:25] (03CR) 10Catrope: [C: 032] Disable the size widget for 'frame' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [18:28:31] (03CR) 10Catrope: [C: 032] Initialize 'default' size properly in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138500 (https://bugzilla.wikimedia.org/66149) (owner: 10Mooeypoo) [18:28:49] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Remove $document cache from target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138393 (owner: 10Esanders) [18:28:50] TrevorParscal, so, we need to talk Images. I know it's your favorite topic. [18:29:17] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396#c4 (10ryasmeen) Verified the fix in Betalabs [18:30:24] TrevorParscal, more to the point, we should consider what to do with 'none' vs 'default', because image behavior is inconsistently different between explicitly saying "none" and inexplicitly choosing "pick whatever for me". :\ no option exists right now for default or literal 'none', and I'm not sure how we can implement such a thing, but we should take this into account..... [18:30:24] mooeypoo: what's the crack mate/ [18:30:29] (03CR) 10Catrope: [C: 032] Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 (owner: 10Esanders) [18:31:19] you know how we have checkboxes that enable sections of controls [18:31:36] TrevorParscal, aye, and we have a checkbox to say whether you want to have alignment or not [18:31:36] maybe, we need to do a little more with that [18:31:50] edsanders: Good catch with the debounce thing [18:32:05] if we had the same for frame (and assuming we could do this visually in a nice way) [18:32:08] how would that go? [18:32:14] (03CR) 10Catrope: [C: 032] Multi-surface fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138430 (owner: 10Esanders) [18:32:22] TrevorParscal, what do you mean? [18:33:23] you are asking, if we had a default vs none [18:33:31] default would be the lack of a setting, yes? [18:33:42] partially yes. [18:33:44] and none is an explicit "none" value [18:33:49] explain [18:34:06] TrevorParscal, now that I think of it, I think we already have the functionality, just the code itself needs to be adjusted to follow the wikitext. [18:34:20] how so? [18:34:28] okay, so, there's either explicitly saying "none" in alignment, or just not writing an alignment (which is default) [18:34:41] the behavior of those two choices is (wait for it!) inconsistent across different types of images [18:35:47] TrevorParscal, so, putting |none in a frame image will align it to left (in ltr), but putting nothing will align to right [18:36:19] here: https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test [18:36:20] so rediculous [18:36:35] TrevorParscal, check out my testing page. [18:36:41] You're going to love it. [18:36:43] ok, here's where I'm at with this [18:37:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (8f8d29a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138650 (owner: 10Trevor Parscal) [18:37:51] we need to allow control over these parameters, but attempts to abstract them that fall short of an actual preset selector will always fail [18:38:05] so, we need to support all the different options, in as nice of a way as possible [18:38:25] ... while showing where each of those options is invalid in different types. [18:38:35] TrevorParscal, I think it might be awesome to consider working on your presets idea [18:38:47] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove $document cache from target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138393 (owner: 10Esanders) [18:39:04] (03Merged) 10jenkins-bot: Cleanup target properties [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138403 (owner: 10Esanders) [18:39:06] (03Merged) 10jenkins-bot: Multi-surface fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138430 (owner: 10Esanders) [18:39:10] but I really want to start working on, as soon as we can, a way for the community to define a JSON blob (we can fall back to something sensible) that provides VisualEditor with a list of like 4 presets, settings for an image with names like "Main image", "illustration", etc [18:39:20] * mooeypoo nods [18:39:26] and then the "advanced" section can be wikitext-levers, where we cater more to the specific and less care about making things understandable for newbies. [18:39:31] yes [18:40:00] TrevorParscal, every time I play with the media edit dialog advanced section I feel like I'm in an Indiana Jones movie, and flipping the wrong thing will get the walls to cave in. [18:40:47] (03CR) 10jenkins-bot: [V: 04-1] Disable the size widget for 'frame' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [18:40:57] and for power users, who do strange things (but probably repeat those things over and over) we could also make it so if you have an image with settings that don't match one of the current presets, you could "Save these settings as a preset" and have personal presets [18:41:31] we should just be careful about saving bugs [18:41:41] sure [18:41:47] (03Merged) 10jenkins-bot: Initialize 'default' size properly in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138500 (https://bugzilla.wikimedia.org/66149) (owner: 10Mooeypoo) [18:41:56] Well, I need to do some design work, I will try and get you some sketches [18:41:59] like, if there was something wonky with the preset, making sure it's not saved for the user, or is updated. [18:42:00] * mooeypoo nods [18:42:14] TrevorParscal, for now I"m going to try and make sure the behavior is at least as close as possible for wikitext [18:42:21] yes [18:42:23] perfect [18:42:28] But yeah, it's not just weird work, it's completely not intuitive [18:43:31] (03PS2) 10Jforrester: Disable the size widget for 'frame' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [18:44:13] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [18:44:14] 3VisualEditor / 3Technical Debt: VisualEditor: ve.dm.MWImageModel#getUpdatedAttributes shouldn't need to modify Scalable - 10https://bugzilla.wikimedia.org/66149 (10James Forrester) 5PATC>3RESO/FIX [18:47:01] 3VisualEditor / 3Language: VisualEditor: Category autocompletion is broken in RTL wikis - 10https://bugzilla.wikimedia.org/65483 (10James Forrester) 5PATC>3RESO/FIX [18:50:14] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c5 (10Alex Monk) (In reply to Derk-Jan Hartman from comment #0) > Dialogs don't keep focus inside the dialog (can be fixed with putting > aria-hidden=true on the rest of the content of the page Can you explain exactly how t... [18:51:24] (03Merged) 10jenkins-bot: Disable the size widget for 'frame' images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138388 (https://bugzilla.wikimedia.org/66353) (owner: 10Mooeypoo) [18:51:47] mooeypoo: Amazing. [18:51:57] mooeypoo: Not one commit about images in gerrit from you! :-D [18:52:05] mooeypoo: https://gerrit.wikimedia.org/r/#/q/owner:moriel%2540gmail.com+status:open,n,z [18:52:25] RoanKattouw_away, I cheated, I put two targets on the page and saw what broke [18:52:47] edsanders: Still impressive. :-) [18:54:06] Krinkle: Once the jenkins things have calmed down (now?) it'd be really great it you could look at Roan's CR on https://gerrit.wikimedia.org/r/#/c/135085/ (skip function for RL) and address his -1. [18:58:53] James_F, wait for it... [18:58:54] :P [19:00:35] mooeypoo: :-) [19:01:03] I'm working on rumanna's bugs. [19:01:07] mooeypoo: There are still 2 things with your name against them on https://bugzilla.wikimedia.org/buglist.cgi?columnlist=bug_severity%2Cpriority%2Ccomponent%2Cassigned_to%2Ctarget_milestone%2Cbug_status%2Cresolution%2Cshort_desc&list_id=320788&order=bug_status%2Cassigned_to%2Cpriority%2Cbug_id&product=VisualEditor&query_based_on=VE-%21marked-for-next-release&query_format=advanced&target_milestone=VE-d [19:01:07] eploy-2014-06-12 yeah. [19:01:14] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286#c2 (10Moriel Schottlender) I can't manage to reproduce this bug... [19:01:17] (Gosh that's long.) [19:03:32] 3VisualEditor / 3Editing Tools: VisualEditor: Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15622 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15622&action=ed... [19:03:41] James_F, the second one (inline images aren't converted properly) is about lists, and I'm not sure it can be done quickly. I started going over the fixUpInsertion routine, but it might take me a bit to figure it out enough to fix the issue .. is this urgent for 6-12 ? [19:03:46] 3VisualEditor / 3Editing Tools: VisualEditor: Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444 (10ryasmeen) a:3Trevor Parscal [19:04:16] mooeypoo: "Urgent", no, but edsanders said he'd give advice if you tried to fix it. [19:04:26] mooeypoo: And it's reasonably important, perhaps. [19:04:27] * mooeypoo nods [19:04:31] i'll take him up on that [19:04:43] * James_F grins. [19:06:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [19:06:35] TrevorParscal: You dun gone broke the styling of the context menu ^^^. :-( [19:06:43] ? [19:06:50] fixed you mean? [19:07:00] screenshot? [19:07:01] TrevorParscal: No, the change made the highlight box too small – https://bugzilla.wikimedia.org/attachment.cgi?id=15622 [19:07:13] * James_F tries to reproduce. [19:07:24] that was on purpose [19:07:54] Oh. It looks… broken. [19:08:03] open to suggestions, but ed and I were annoyed by the arrow at the top being white and being isolated looking [19:08:44] I was annoyed by it too, but this is worse; the smaller padding I liked. [19:08:55] Now it looks like you forgot to highlight half of it. [19:09:21] i was more going for the way menus in OSX have space at the top and bottom [19:09:23] what about the same styling as a toolbar [19:09:46] (It looks lots better if there are two entries rather than one in the context.) [19:09:46] the border will make the arrow look just as cut off [19:09:57] edsanders: You mean a grey border rather than a blue highlight? [19:09:58] James_F: agreed [19:10:45] TrevorParscal: Maybe a special-case if there's only one, making the whole thing blue? [19:10:48] * James_F doesn't know. [19:11:15] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286#c3 (10ryasmeen) This is no more reproducible in Betalabs and tes... [19:12:15] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286#c4 (10James Forrester) 5ASSI>3RESO/FIX OK, let's declare thi... [19:12:36] mooeypoo: Success! Magic fixing of bugs in reverse time using tachyons. [19:12:36] the arrow being blue too? [19:12:37] (03PS2) 10Krinkle: Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [19:12:44] (03CR) 10Krinkle: "Jenkins test.." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [19:13:40] (03CR) 10jenkins-bot: [V: 04-1] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [19:13:47] TrevorParscal: Yeah. Not sure about it though. [19:13:49] \o/ [19:22:11] James_F, I'd like to adjust the none/default alignment issue before the fixup insertion. That ok? [19:22:46] mooeypoo: WFM. [19:22:57] (03PS1) 10Mooeypoo: Disable/Enable alignment select widget with checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138663 [19:36:45] what the hell.. I have
which works in mediawiki.org but in my local wiki it displays as if it's text [19:36:49] ... is this a settings issue?? [19:42:13] mooeypoo: It… shouldn't be. [19:42:23] ok, I'm going to separate between alignment (left/right/center/none/default/undefined) and *actual* alignment (left/right/center) [19:42:37] mooeypoo: Check that the "<" and ">" are real characters and not unicode glyphs that look like them. [19:42:45] mooeypoo: It's position, not alignment, BTW. [19:42:49] James_F, I copy/pasted the wikitext :\ this is weird [19:42:52] James_F, which one? [19:42:56] mooeypoo: Alignment is top/bottom/text-middle/etc. [19:43:05] isn't that vertical alignment? [19:43:12] in the attributes you have attrs.align and attrs.valign [19:43:40] I just made a table of what goes where in which case and what type [19:43:44] mooeypoo: Hmm. That's Parsoid being wrong then. :-) [19:43:59] ah [19:44:04] mooeypoo: I believe that "alignment" in MW means vertical alignment. [19:44:17] mooeypoo: And horizontal alignment is called "location". [19:44:26] mooeypoo: Because to hell with sensible names. :-) [19:44:39] well thankfully we have user-facing messages [19:44:46] where we can write whatever we want [19:44:54] mooeypoo: Yeah, indeed. :-) [19:44:59] ... in the code, I think I'll stick to "alignment" and "vertical alignment" [19:45:06] * James_F nods. [19:45:30] and now add "actualPageAlignmentBecauseWikitextIsnt()" [19:45:36] well,.. maybe slightly shorter. [19:45:46] * James_F smiles. [19:53:18] TrevorParscal: So… HTML comments. Thoughts about just stuffing a little in the gutter which toggles showing it (in-line)? [20:00:26] we're going to get rid of the metadata document first [20:01:31] edsanders: Really? 'Cos you've not done that for months and months whilst users complain… [20:01:41] edsanders: So ISTR we decided that we weren't going to wait. [20:17:46] I think the problem is rendering HTML comments isn't something we can do so long as they are in the metadata, and hiding/showing them is shady if they are inline (because you would be removing things you can't see most of the time) [20:18:26] We also talked about having them as little PostIt-yellow boxes inline (not meta-data at all), didn't we? [20:18:52] If you selected around a whole paragraph and there was a comment in the middle, fair play, but if you happened to select a comment on the edge of something you were deleting, maybe only deleting to insert something similar in it's place (typo fix) imagine the response the community will have about the comment going missing, and the confusion of the user for being yelled at for dele [20:18:52] ting something completely invisible [20:18:55] So micro-box of [!] which expands on default, with a left-gutter extra indicator? [20:19:12] * James_F nods. [20:19:21] right, so a small note will probably need to always be rendered, but hopefully that isn't super annoying [20:19:26] Yeah. [20:19:32] or, we could render the nodes in the gutter [20:19:41] A small note with a click action (and gutter action as well?)? [20:19:43] Eurgh. [20:19:46] and when you hover them a little anchor appears to show you where they come from [20:19:55] That is problematic because s aren't ranged. [20:20:07] ? [20:20:33] I'm saying, we render notes in the gutter, and only when you click on the note (maybe hover it too) do we show a little marker of where the note came from [20:20:35] So '''Barrack ''Hussein'' Obama II … [20:20:47] That would be confusing if pulled out the paragraph and so context-less. [20:20:54] Oh. Hmm. [20:20:59] I'm not sure… [20:21:04] i'm not either [20:21:08] hence why I've skipped it [20:21:15] see my media dialog email [20:21:19] It feels quite heavy for the main item to be in the gutter. [20:21:23] Yeah, see my reply. [20:21:27] Oh, wait, I didn't click send. [20:23:21] waiting... [20:24:00] * James_F kicks GMail. [20:24:12] Spolier: Mostly I said "yay". :-) [20:24:18] Err. Spoiler. [20:27:44] I haven't eaten yet... nor have the girls... And Mel is gone at her appt. Gotta go put food in mouths, be back in a bit [20:28:14] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c6 (10Derk-Jan Hartman) (In reply to Alex Monk from comment #5) > (In reply to Derk-Jan Hartman from comment #0) > > Dialogs don't keep focus inside the dialog (can be fixed with putting > > aria-hidden=true on the rest of t... [20:28:20] TrevorParscal: Excuses. :-) [20:51:00] (03PS6) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [20:51:08] (03CR) 10Catrope: [C: 032] Disable/Enable alignment select widget with checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138663 (owner: 10Mooeypoo) [20:52:06] (03PS1) 10Catrope: Update VE core submodule to master (ba8872e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138718 [20:52:08] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [20:52:44] (03CR) 10Divec: "PS6 is a rebase too" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [20:52:47] (03Merged) 10jenkins-bot: Disable/Enable alignment select widget with checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138663 (owner: 10Mooeypoo) [20:53:05] (03PS2) 10Catrope: Update VE core submodule to master (ba8872e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 (owner: 10Esanders) [20:53:51] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (ba8872e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 (owner: 10Esanders) [20:54:05] RoanKattouw, TrevorP|Away James_F|Away I made a "SPOT THE DIFFERENCES" Image Alignment Wikitext game! https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test [20:55:15] * mooeypoo uses that to finally kill all alignment bugs [20:55:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (ba8872e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138394 (owner: 10Esanders) [20:55:59] mooeypoo: that test page makes a bit more sense visually if you add some text before and after each image [20:56:17] (you can see that 'none' is not the same as 'left' at a glance) [20:56:29] MatmaRex, there are very few circumstances where image alingment makes sense. But fine, I'll add text. [20:56:47] oh, i'm not saying it makes sense [20:57:03] i'm just saying that default, 'none' and 'left' all look the same right now, while they're not necessarily so :) [21:00:37] MatmaRex, here, good point, I updated the page [21:01:09] some of those are even worse btw, but who am I to judge Teh Wikitext. [21:01:59] Now I'm convinced I need to separate "wikitext alignment" and "visual alignment", especially between different types. [21:02:33] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Highlighting entire paragraphs and applying or removing list formatting should consistently apply... [21:02:47] mooeypoo: :-( [21:02:49] mooeypoo: Yay for complexity. [21:03:50] (03Abandoned) 10Catrope: Update VE core submodule to master (ba8872e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138718 (owner: 10Catrope) [21:08:20] James_F, at this stage, this is CLARITY. [21:09:52] mooeypoo: I meant complexity in the code. For users it sounds like a good move. [21:10:07] oh, yes, absolutely. [21:18:07] mooeypoo: AFAICT there are four visible states – inline, left float, centre float, right float. Yes? [21:19:38] yeah, visibly, yes [21:19:43] the visible alignment will be easy [21:19:46] James_F: judging by the test page, there's also a 'none float' [21:19:58] it's finding the connection between wikitext alignment + type that will dictate visual alignment [21:20:04] (unless you want to consider this the same as 'inline') [21:20:06] I'm adding that functionality to the image model [21:20:16] MatmaRex: I think that's inline, surely? [21:20:47] MatmaRex, none float is either inline if it's frameless/basic or block image (so visually left, just on its own line) [21:20:50] James_F: doesn't look like it. https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#frameless [21:21:07] although i have no idea why would anyone need this [21:21:43] MatmaRex: That's not different from inline. [21:21:57] MatmaRex: Compare https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#default_3 and https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#default_4 [21:22:08] looks plenty different to me [21:22:35] one is inline, the other is block [21:22:37] MatmaRex: Oh, you mean https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#default_4 vs https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#.27none.27_4 ? [21:22:37] MatmaRex: Block-inline? [21:22:39] Yeah. [21:22:45] yeah [21:22:47] Bloody MediaWiki. [21:22:48] that's just inline [21:22:50] just block, even [21:22:55] We need to burn image types to the ground and start again. [21:22:56] no no [21:22:59] why block? [21:23:00] D: [21:23:07] MatmaRex: Don't think we won't do it. :-) [21:23:08] it's inline... it's part of the line [21:23:21] mooeypoo:
[21:23:27] oh [21:23:28] goddamnit [21:23:29]
s are definitely block [21:23:33] mooeypoo: Yeah. [21:23:41] the 'none' one is block, the default one is inline [21:24:02] wait [21:24:06] oh [21:24:07] James_F: eh, some… culling might be in order, but burning to the ground? [21:24:10] the none.. i was looking at the default [21:24:13] the default is inline [21:24:34] MatmaRex: Starting from scratch with "what do we want to help users do" rather than "what new fiddles can we add to make it more complex"… [21:24:37] but, if you kill the 'none' alignment and replace it with 'center', you have my blessing [21:24:48] (03CR) 10Catrope: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [21:24:53] (03PS26) 10Catrope: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [21:26:01] (03PS7) 10Catrope: Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [21:26:37] (03PS8) 10Catrope: Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [21:27:07] (03CR) 10jenkins-bot: [V: 04-1] Remove ProtectedNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [21:28:52] TrevorP|Away: So about those context menus [21:29:15] TrevorP|Away: I think the white padding around them is almost defensible if you're like on some text that happens to have only one annotation [21:30:01] TrevorP|Away: But look at what it looks like for a large image, where 1) there is no chance of more than one menu entry appearing, and 2) because the image is large enough it goes to the top right corner [21:30:08] Especially #2 makes it look bad IMO [21:30:22] Especially on hover when part of it turns blue but part of it doesn't [21:31:36] James_F, https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#by_alignment [21:31:44] this makes it easier to examine [21:35:11] mooeypoo: Sort instead by outcome? [21:35:47] 3VisualEditor: VisualEditor: the edit summary dialog is annoying - 10https://bugzilla.wikimedia.org/66454 (10Elitre) 3NEW p:3Unprio s:3normal a:3None I need to report recent comments by a couple of users in different communities about how the edit summary dialog is just too big, slow and intrusive - g... [21:37:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: the edit summary dialog is annoyingly big - 10https://bugzilla.wikimedia.org/66454#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor (In reply to Elitre from comment #0) > Not being able to > edit it in the changes review dialo... [21:43:26] James_F, what I need to do is compare it to the parsoid output [21:43:34] mooeypoo: Making you a table. :-) [21:43:34] I need to make sure the parsoid css classes are attached properly [21:44:18] Aye, I'm filling it in, but more than whether it's floating or not, I need to check parsoid's output. In terms of floating, for example, thumbnail 'none' and 'left' are both floating left, but parsoid has different css classes for both [21:45:28] actually, I'm missing 'block-no float' [21:45:30] [21:47:32] 3VisualEditor / 3ContentEditable: VisualEditor: GeneratedContentNode rerenders with double-escaped HTML entities - 10https://bugzilla.wikimedia.org/66456 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None * Create a page with foo && bar * Open the p... [21:50:07] mooeypoo: https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Test#by_outcome [21:52:15] oh! [21:52:20] thanks James_F ! [21:52:27] I was going to go one by one and inspect [21:52:44] oh, so block no-float is inline-block ? [21:53:53] dude, is anyone else's mediawiki install look insane on head? [21:54:00] James_F: "inline-block"? not just "block"? [21:56:34] TrevorParscal: I just noticed all the navigation is gone in beta labs [21:56:55] Fix "CSSMin url() value remapping not working in certain obscure cases is to blame [21:57:19] Really! [21:57:29] https://gerrit.wikimedia.org/r/#/c/138286/ [21:58:11] MatmaRex: "Block" covers all of those images except "inline". [21:58:56] James_F: it's just confusing to me because in CSS, inline-block is something else [21:59:01] TrevorParscal: :( [22:00:03] Shall I revert? [22:01:22] i guess. no idea why would that cause this [22:02:41] it borks CSS [22:02:46] seems simple enought to me [22:02:50] wait okay James_F I am running into a problem [22:03:24] in the case of frameless and basic, how do I let the user decide between choosing "none" (explicitly) and "default" (which in this case is no alignment set) [22:03:34] TrevorParscal: Revert away. [22:03:38] without having a "none" button, the alignment checkbox sets "default" [22:03:48] which is no alignment. How do I let the user *set* "none" ? [22:04:21] mooeypoo: Yeah… [22:04:46] I'm working on figuring out whether the image is default or none, but I just realized I can't really know in the case of frameless and basic [22:04:57] mooeypoo: Instead have buttons for inline, block, left, centre, right? [22:04:57] unless we let the user set it explicitly [22:05:00] that's confusing :\ [22:05:15] besides, you have inline-block [22:05:17] https://gerrit.wikimedia.org/r/#/c/138739/ [22:05:19] and block-left or block-right [22:05:22] ... :\ [22:05:53] James_F, how about adding a "Use default" checkbox? [22:06:02] mooeypoo: Eww. [22:06:09] or "Deafult" button the the directions [22:06:13] mooeypoo: inline-block might be a good label for us, but not users.z [22:06:14] yes, well, the whole thing is eww [22:06:20] yeah :\ [22:06:32] mooeypoo: I don't think editors GAF about the resultant wikitext so much as /what/ the change will be visually. [22:06:58] but if we have buttons for 'inline', 'block', left' ... I don't think users will understand the difference between them either, especially between 'block' and the directions [22:07:16] James_F, sure , but right now we can't give the the functionality of 'none' [22:07:19] which they are complaining about [22:07:35] mooeypoo: If we give them a new button they can. [22:07:53] mooeypoo: Currently four buttons (well, three plus checkbox); instead, have five (somehow). [22:08:02] wait [22:08:03] wait wait [22:08:10] Or don't. [22:08:13] i think i figured something out [22:08:15] * James_F is just throwing out ideas. [22:08:23] okay, so here's the deal [22:08:39] unchecking the checkbox means "no alignment = default" for *block* images (frame and thumb) [22:08:43] Yes. [22:09:20] wait, no, it also means no alignment to inline images, since they by default have undefined [22:09:23] * mooeypoo sighs [22:09:28] i thought i had an idea, but it turns out I don't. [22:09:43] The easiest solution would be to either add "None" or "Default" to the buttons [22:09:47] then it's only 1 button [22:10:06] and it's clear what it does: Wraps text around the block to the left, right, center, or none (i think even word has this) [22:10:07] "Only". [22:10:28] And has to be disabled for some image types. [22:10:28] But eh. [22:10:35] or default would be a separate button like the size widget's "make full size" that when you click it, magically clicks stuff for you to make it default [22:10:46] James_F, "none" can be active on everything [22:10:57] So is default. The *results* are different. [22:11:17] mooeypoo: I suggested having buttons about outcome, not wikitext. [22:11:27] aye, we can deal with wikitext [22:11:47] mooeypoo: So "Right", "Left", "Centre" if floated, or "Inline" and "Block" if not. [22:11:56] mooeypoo: Maybe two grouped multi-selects? [22:12:03] Hmm [22:12:10] * James_F still thinks this sounds very complicated. [22:12:19] I don't know if I would've known what "block" means, but I don't think we have much choice [22:12:36] what does TrevorParscal think ? he's redesigning the whole dialog anyways [22:12:45] Icons FTW. :-) [22:12:46] Yeah. [22:13:02] Add that complication to the ones I wrote in the email :P [22:13:33] Editing advanced images will look like working in a nuclear facility. [22:13:49] We should have a "DON'T CLICK THE RED BUTTON" sign [22:13:53] :-) [22:14:05] Use rather than <ø> icon? [22:14:10] Also, I very very strongly disagree with putting alt text behind "advanced". [22:14:24] eh, so should I drop this none/no-alignment business for now? :\ [22:14:26] I think we should figure out what we're doing with alt/caption anyways thoug [22:14:35] Yes. [22:14:48] for inline images, alt is caption when alt isn't there [22:14:55] which is insanely confusing [22:15:07] I think we need to figure this out, only for the andvanced settings [22:15:15] Anyways, cow by cow, as we say in Hebrew. [22:15:58] Yes; in general I'd recommend enabling the alt text all the time, and the caption only for appropriate types of images (disabled rather than hidden). [22:15:58] What do we do for now? Do I drop all these things and work on the fixupAlignment 'till we figure out the GUI ? [22:16:05] TrevorParscal: Do you have a thought? [22:16:24] James_F, ok, what if you started with block image, then switched levers so you're now in inline (no caption) but your alt isn't set either -- which means your caption is alt [22:16:27] do we copy over the content? [22:16:33] It seems like we need a way to specifiy the absence of a value separate from "none" and that there are some strange caveats to doing that [22:16:34] mooeypoo: That was an idea [22:16:38] mooeypoo: I'm not so sure. [22:16:49] But then we need to take into account that the wikitext will change [22:17:00] Yeah. :-( [22:17:17] or if we don't change it, that alt has limitations that caption doesn't.. so if the user later goes back and makes the image block again, they'll see different results. [22:17:26] James_F, just when you think you beat the wikitext.... [22:17:35] TrevorParscal, yes. [22:18:01] TrevorParscal, "no alignment" is usually default. "None" is "I explicitly specify I want block image that is not floated, kthxbai" [22:18:11] Only the last string is a bit long for a button. [22:23:09] "Unfloated" vs. "Inline" maybe? [22:25:15] "Just sitting there". [22:25:28] Do people know what floating is though? [22:29:30] Probably not. [22:29:34] What's the Word time? [22:29:46] Sure [22:30:02] I'm trying to figure out how word or open office does it [22:30:37] they seem to have all the images block first [22:30:50] so you can just align them left/right/center with the text alignment tool [22:30:56] Err. [22:31:00] What's the Word label? [22:31:00] but those are not floated [22:31:07] * James_F nods. [22:31:08] those take up the whole line [22:31:11] I don't see a word for that [22:31:17] you just put an image in, and that's what it is [22:31:26] THEN you can have it floating, let me see what they call it [22:31:37] you can decide to put it inside the text [22:32:30] ok [22:32:36] so.. block without float: "In line with text" [22:33:39] Then there's a "With Text Wrapping" option that has visual buttons for middle (the text wraps all around, I don't think we have this in MW except for inline images but those are one-liners, [22:33:44] and they seem to change how tight the text is [22:34:23] James_F, yu also have the option "Move with text" and "Fix position on page" -- those two are optionboxes so you pick one or the other [22:34:28] that's what I have in Word 2013 [22:34:38] And it makes sense but it is unsuitable for MW [22:35:01] I guess "In line with text" is their inline [22:35:20] James_F, want a screenshot? [22:35:37] mooeypoo: Yes. And attach to a bug about this so we don't lose it. :-) [22:35:53] I'm wondering about the best way to deal with https://bugzilla.wikimedia.org/show_bug.cgi?id=56213 ... [22:35:53] oki doki [22:36:17] Krenair: RoanKattouw_away looked like he had something to say around that… [22:36:23] I think we need to find some way to generalise the existing code so that it can be used for multiple different surfaces [22:36:57] Krenair: (During the KIT.) [22:36:59] But we can't just put it all straight into ve core because it's checking wikitext stuff [22:37:07] Yeah. [22:37:20] Maybe have a ve.ui.MWSurfaceWidget? [22:37:36] Or do we already have that? [22:38:07] I don't think that would work for the main surface [22:38:35] Bah. Possibly. [22:39:17] At the moment this code sits in VPT which extends ve-mw's Target which extends ve's Target, which deals with setting up the surface [22:39:51] * James_F nods. [22:41:18] So we'd need a WikitextFreeSurface or something I guess? And then we'd need some way to tell Target and SurfaceWidget how to set that up. [22:43:47] James_F, we could change the function to accept a surface parameter, then make it static somewhere and have each antiwikitext surface to set up an event handler for it? [22:47:07] TrevorParscal: ping [22:48:26] Krenair: Maybe… [22:48:51] Krenair: Roan is probably better to judge than me. [22:51:15] 3VisualEditor / 3Editing Tools: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None There is a difference in behavior between explicitly stating "none" in the image wikitext and setting no ali... [22:51:21] James_F, ^^ [22:52:57] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10James Forrester) [22:52:57] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [22:55:59] Re wikitext warning in SurfaceWidgets: no, I didn't have anything to say about that, I just groaned [22:56:00] Because I understood why it was broken and how much of a pain it would be to fix [22:56:37] * James_F grins. [22:56:53] heh. [22:57:19] We'd probably want an MWSurfaceWidget extending SurfaceWidget that takes a config option (default true) telling it whether to do wikitext warnings [22:57:30] The event bindings would be easy to port [22:57:41] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c1 (10Moriel Schottlender) Created attachment 15623 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15623&action=edit Word 2013 image alignment menu [22:57:46] What's nastier is that we use mw.notify which is not gonna work so well while a dialog is open [22:57:56] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c2 (10Moriel Schottlender) Created attachment 15624 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15624&action=edit Word 2013 image popup menu [22:58:12] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c3 (10Moriel Schottlender) Created attachment 15625 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15625&action=edit Word 2013 image position menu [22:58:14] RoanKattouw: mw.notify doesn't scope itself to OOUI dialogs?! ;-) [22:58:42] oh geesh [22:59:20] mooeypoo: … wow. [22:59:26] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c4 (10Moriel Schottlender) Created attachment 15626 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15626&action=edit Word 2013 image wrap text menu [22:59:27] mooeypoo: Let's not copy Word's interace. [22:59:28] didn't expect wikibugs to report EVERY attachment [22:59:34] James_F, let's not. [22:59:43] James_F, see also the fact they have a whole BUNCH of separate menus for this [22:59:50] Indeed! [23:00:04] But maybe the wording will help us [23:01:26] 3VisualEditor / 3ContentEditable: VisualEditor: GeneratedContentNode rerenders with double-escaped HTML entities - 10https://bugzilla.wikimedia.org/66456 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [23:02:54] RoanKattouw, James_F suggested MWSurfaceWidget earlier, which I think would be okay if we didn't need this to work for the main surface as well? [23:03:14] Or is the main surface a SurfaceWidget? [23:04:04] Right! [23:04:09] The main surface is not a SurfaceWidget [23:04:13] Though we could make it one [23:04:58] Althoug, hmmm [23:05:06] I think SurfaceWidget has a non-floating toolbar? [23:05:27] For consistency it would probably be nice to wrap all surfaces in SurfaceWidgets, but we should discuss that with TrevorP|Away [23:05:58] Yeah toolbars don't float on SurfaceWidgets [23:07:01] So if you edit a very long reference, for instance, so the dialog scrolls, the toolbar scrolls out of view [23:07:08] Which is pretty sucky, I never realized it worked that way [23:07:33] (03PS27) 10Catrope: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [23:08:16] (03CR) 10Catrope: "PS27: Moved this.surface setting back to setup instead of live, to fix JS error on GeneratedContentNode rerender" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [23:09:53] James_F|Away, RoanKattouw, I was curious so I opened Google Docs to see how they do their image alignment, and GUESS WHAT POPPED UP! "New! Edit images right inside Docs -- Now you can crop, rotate, and add borders to images without leaving your document. Just select an image and edit from the toolbar, Format menu, or right click menu." [23:09:54] ... [23:10:30] NEW! You can do this thing VE has been able to do forever! [23:10:51] It's kind of like Apple with iOS isn't it [23:11:01] NEW! We now have these cool new features! Which Android has had for two years! [23:13:00] :D [23:13:19] RoanKattouw, though they, too, allow for editing image alignment by drag/drop [23:13:28] Oh that is nice [23:14:08] They have "In line" (inline) "Wrap Text" (block, and you can drag the image either left, center or right) and "Break Text" which is pretty much our "none" [23:16:00] 3VisualEditor / 3Editing Tools: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None * Create two references, one above the fold and one below * Scroll down to the one below the fold, inspect it... [23:16:56] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c5 (10Moriel Schottlender) Created attachment 15627 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15627&action=edit Image alignment in Google Docs [23:17:58] RoanKattouw, what do you think about we could change the function to accept a surface parameter, then make it static somewhere and have each antiwikitext surface to set up an event handler for it? [23:18:03] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [23:18:17] Krenair: Which function? [23:18:31] checkForWikitextWarning [23:18:49] Maybe [23:18:54] That could work [23:19:05] But longer term it should probably be done more nicely [23:19:08] Yes [23:19:10] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Merge ProtectedNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134363 (https://bugzilla.wikimedia.org/55789) (owner: 10Esanders) [23:19:13] Also, you'll have to come up with a way to render the warning [23:19:27] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c6 (10Moriel Schottlender) Interestingly enough, in Google Docs you seem to have three main alignment options: * In line - an inline image * Wrap text - Block... [23:19:28] mw.notify isn't gonna work too well when there's a dialog-induced overlay over the entire page [23:19:29] It's not a great solution.. [23:19:30] I promise, I will stop spamming with wikibugs. [23:20:21] RoanKattouw, is TrevorP|Away still around? [23:21:16] (03PS9) 10Catrope: Update VE core submodule to master (e1b0e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:21:24] mooeypoo: He's WFH on Tuesdays [23:21:34] oh, oh, ok [23:21:37] thx [23:22:52] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (e1b0e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:23:25] RoanKattouw, Google Doc's way of aligning images is pretty slick [23:23:36] Even if you don't consider the drag/drop, I have to admit [23:24:03] it's either wrapping text (in our case, float left or float right) or "Break line" (which is both 'none' and 'center' for us) or it's "In line" [23:24:08] pretty slick and simple. [23:27:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning not triggered when editing image captions, references - 10https://bugzilla.wikimedia.org/56213#c1 (10Alex Monk) I started looking at this. It's annoying because the code to do the wikitext detection is already there and working for the ma... [23:35:01] (03PS1) 10Krinkle: Element: Add unit tests for focusin/focusout hack [oojs/ui] - 10https://gerrit.wikimedia.org/r/138752 [23:35:03] (03PS1) 10Krinkle: Element: Add unit tests for focusin/focusout hack [oojs/ui] - 10https://gerrit.wikimedia.org/r/138753 [23:36:22] (03PS2) 10Krinkle: Element: Remove focusin/focusout hack in onDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/138753 [23:36:24] (03PS2) 10Krinkle: Element: Add unit tests for focusin/focusout hack [oojs/ui] - 10https://gerrit.wikimedia.org/r/138752 [23:47:16] (03CR) 10Catrope: "Test breakage is caused by AlienNode now being a FocusableNode while it wasn't one previously." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:48:18] RoanKattouw, do you know how to set up an ooui toolbar with a button outside of VE ? I've been looking at the ooui docs but there's info about widgets and surface and no toolbar setup [23:48:39] Have you seen the toolbar demo? [23:48:52] no! where? [23:48:58] file:///path/to/oojs/ui/demos/tools.html [23:49:04] ooh [23:52:56] (03PS10) 10Catrope: Update VE core submodule to master (e1b0e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:54:07] (03CR) 10Catrope: "PS10: Update test cases for aliens now being focusable. Note that there is a behavioral change, as implied by the tests: the left and righ" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:54:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (e1b0e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders) [23:55:54] (03PS7) 10Catrope: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [23:56:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (e1b0e33) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134364 (owner: 10Esanders)