[00:05:25] (03PS5) 10Catrope: Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [00:06:30] (03CR) 10jenkins-bot: [V: 04-1] Remove RelocatableNode mixins for new FocusableNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [00:09:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning not triggered when editing image captions, references - 10https://bugzilla.wikimedia.org/56213 (10Alex Monk) a:3Alex Monk [00:11:13] (03PS1) 10Alex Monk: Show wikitext warnings in the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) [00:12:53] (03CR) 10jenkins-bot: [V: 04-1] Show wikitext warnings in the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) (owner: 10Alex Monk) [00:16:30] (03PS2) 10Alex Monk: Show wikitext warnings in the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) [00:24:04] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Merge RelocatableNode into FocusableNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [00:32:58] 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563#c4 (10ryasmeen) 5PATC>3RESO/FIX This seems to be working fine now.Th... [00:34:24] Krenair: BTW, {{DISPLAYTITLE:…}} is now supported in Parsoid as of an hour ago if you didn't see. [00:34:29] yeah, I saw [00:34:34] Trying to work out why my code doesn't appear to work right now [00:35:12] * James_F grins. [00:35:22] It seems that when I set the displaytitle, the diff just shows that 'DISPLAYTITLE' has been added to the top of the document :| [00:35:27] 3VisualEditor / 3ContentEditable: VisualEditor: Highlights, resize handles, etc. not repositioned on window resize - 10https://bugzilla.wikimedia.org/55789#c5 (10James Forrester) 5PATC>3RESO/FIX At least the first part of this is done. [00:36:14] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c7 (10James Forrester) (In reply to Moriel Schottlender from comment #6) > Interestingly enough, in Google Docs you seem to have three main alignment > options... [00:36:24] Krenair: Have you killed and restarted Parsoid since the update? [00:36:36] Yeah [00:36:44] Hmm. [00:36:45] Ah. Oops. [00:36:48] Then I'm out of ideas. :-) [00:36:49] Oh. [00:37:06] I called it mw:PageProp/displaytitle. [00:37:26] It looks like parsoid is referring to it as mw:PageProp/categorydisplaytitle... [00:38:21] Err. [00:38:25] "categorydisplaytitle"? [00:38:28] That seems… wrong. [00:39:23] Does it work if you use that though? [00:39:40] When Parsoid starts "supporting" a feature, they don't always think to also support it on the serialization end [00:39:48] * James_F grins. [00:39:57] 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10James Forrester) [00:39:57] 3VisualEditor / 3ContentEditable: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [00:40:14] So they may parse {{DISPLAYTITLE:foo}} correctly but then barf when you feed them the same HTML on a page that didn't previously have it [00:40:25] Also, yes, James_F is right, display title has nothing to do with categories [00:40:31] They must be confusing it with defaultsort [00:41:13] yeah, it successfully saves now, doesn't appear to properly load existing displaytitles. [00:41:20] probably my fault [00:41:44] Krenair: The category naming seems to have been accidental, I've commented on the (already merged) Gerrit change [00:42:06] ok [00:44:50] Ah, right. [00:45:14] So it turns out the not successfully loading existing value thing... is caused by me not changing BOTH references to mw:PageProp/displaytitle, just one,. [00:46:10] Ah yes [00:46:16] Also, that should get you a corruption warning, most likely [00:46:28] Depending on which way around you had it [00:47:02] I changed the meta.setAttribute call but not matchRdfaTypes [00:50:37] Aha OK [00:50:47] Yeah that way around it just won't be recognized [00:55:05] RoanKattouw, James_F|Away sorry .. I didn't apply mind there and research what displaytitle was. [00:55:21] (03PS2) 10Alex Monk: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) [00:55:22] we'll get it right second time around. :) [00:55:54] Thanks :) [00:56:07] (03CR) 10Alex Monk: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk) [00:56:09] Krenair has already gone and "corrected" the type that VE looks for [00:56:23] But ideally we'd use a sensical one from the start [00:56:41] I'm going to revert that patch for now. [00:56:52] :| [00:57:19] subbu: AFAICT the only thing that's wrong is the name, that should be easy to fix, right? [00:57:31] (03CR) 10jenkins-bot: [V: 04-1] Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk) [00:58:10] RoanKattouw, i dont know what displaytitle is actually .. so i should read up on it if something else is broken with it .. i just assumed it was some category like thing for some strange reason. [00:59:09] i have to run now so cannot look at it now, but if it is simple to fix, please leave a comment on the patch. arlo might do it and/or I'll take a look later tonight. [01:00:07] (03PS3) 10Alex Monk: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) [01:00:52] subbu, some of the code there was dealing with defaultsort, which iirc is to do with categories [01:01:12] yes [01:01:36] anyway, signing off, bye [01:01:44] (03CR) 10jenkins-bot: [V: 04-1] Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk) [05:19:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: the edit summary dialog is annoyingly big - 10https://bugzilla.wikimedia.org/66454#c2 (10Elitre) Is it? I was still talking about the edit summary field. Thanks for fixing the title. [06:31:26] 3VisualEditor / 3Editing Tools: VisualEditor: Design a good solution for image alignment "none" vs "default" - 10https://bugzilla.wikimedia.org/66460#c8 (10Moriel Schottlender) The comparison to wikitext functionality should be something like: * In line: frameless/basic without alignment * Wrap text: thumb/f... [08:21:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: the edit summary dialog is annoyingly big - 10https://bugzilla.wikimedia.org/66454#c3 (10Amir E. Aharoni) I spoke about this with an experienced editor in the Hebrew Wikipedia and noticed a curious contradiction: This dialog was designed with the intentio... [10:46:48] (03CR) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [10:56:59] (03PS8) 10Esanders: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 [10:57:01] (03PS12) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 [10:57:03] (03PS3) 10Esanders: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) [10:57:05] (03PS1) 10Esanders: Centre callout on small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 [12:09:46] (03PS2) 10Esanders: Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 [13:16:22] (03PS3) 10Esanders: Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 [13:16:24] (03PS13) 10Esanders: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 [13:16:26] (03PS4) 10Esanders: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) [13:20:41] (03CR) 10Esanders: "Two renames in the CSS, only one rename in the JS. Oops." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137156 (owner: 10Jforrester) [13:22:23] (03PS1) 10Esanders: Fix typo in class name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138808 [13:28:08] (03PS1) 10Esanders: Don't select contents of textarea in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138810 [13:32:41] (03PS1) 10Esanders: Set traditional galleries to inline-block to get correct width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138812 [14:38:15] (03PS4) 10Alex Monk: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) [14:44:17] (03PS8) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 [14:47:03] (03CR) 10Krinkle: [C: 032] Fix typo in class name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138808 (owner: 10Esanders) [14:48:37] (03Merged) 10jenkins-bot: Fix typo in class name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138808 (owner: 10Esanders) [14:48:59] (03PS5) 10Alex Monk: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) [15:12:13] (03PS1) 10Cmcmahon: [BrowserTest] Remove obsolete test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138825 [15:12:34] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Remove obsolete test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138825 (owner: 10Cmcmahon) [15:14:15] (03Merged) 10jenkins-bot: [BrowserTest] Remove obsolete test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138825 (owner: 10Cmcmahon) [15:35:11] 3VisualEditor / 3Data Model: VisualEditor: Edit led to a tag being removed (?) - 10https://bugzilla.wikimedia.org/65360#c1 (10Ed Sanders) Can't reproduce in Firefox or Chrome. [15:39:56] 3VisualEditor / 3ContentEditable: VisualEditor: Copy-Paste of a block of HTML disables all further copy-paste of anything: FF28 on Linux - 10https://bugzilla.wikimedia.org/64009#c1 (10Ed Sanders) Works for me. [16:06:19] (03PS1) 10Esanders: Don't refocus the document in onModelSelect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) [16:08:34] (03PS1) 10Esanders: toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 [16:14:19] (03PS1) 10Cmcmahon: [BrowserTest] Update login tests to use api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138837 [16:19:56] (03PS1) 10Krinkle: ve.dm.Converter.test: Use teardown to restore mw.config instead of ad-hoc [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138838 [16:20:14] (03CR) 10Krinkle: "Done in I24ac5d8be278." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/107539 (owner: 10Catrope) [16:48:59] (03PS1) 10Esanders: Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 [16:50:10] (03CR) 10Esanders: "Screenshot: http://i.imgur.com/DxlgPpF.png" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders) [16:58:41] 3VisualEditor / 3ContentEditable: VisualEditor: Copy-Paste of a block of HTML disables all further copy-paste of anything: FF28 on Linux - 10https://bugzilla.wikimedia.org/64009#c2 (10James Forrester) 5ASSI>3RESO/DUP It's almost certainly because the copy-paste code fatals on come content currently, and... [16:58:56] 3VisualEditor / 3ContentEditable: VisualEditor: Would be nice if copying/pasting kept working after a fatal - 10https://bugzilla.wikimedia.org/66229#c1 (10James Forrester) *** Bug 64009 has been marked as a duplicate of this bug. *** [17:32:56] 3VisualEditor / 3ContentEditable: VisualEditor: Would be nice if copying/pasting kept working after a fatal - 10https://bugzilla.wikimedia.org/66229#c2 (10Ed Sanders) Need an example so I know where to put the try/catch. [17:43:06] (03CR) 10Catrope: [C: 032] ve.dm.Converter.test: Use teardown to restore mw.config instead of ad-hoc [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138838 (owner: 10Krinkle) [17:44:36] (03CR) 10Catrope: [C: 032] Don't select contents of textarea in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138810 (owner: 10Esanders) [17:44:40] (03Merged) 10jenkins-bot: ve.dm.Converter.test: Use teardown to restore mw.config instead of ad-hoc [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138838 (owner: 10Krinkle) [17:45:14] edsanders: WTF is mw-gallery-traditional? [17:45:31] it's the one that isn't the new packed gallery [17:45:35] Right [17:45:39] Yeah James just explained it [17:45:46] (03CR) 10Catrope: [C: 031] Set traditional galleries to inline-block to get correct width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138812 (owner: 10Esanders) [17:46:49] the ul is 100% width which is unnecessary but harmless except when you're trying to get an accurate measurement [17:46:49] (03Merged) 10jenkins-bot: Don't select contents of textarea in extension inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138810 (owner: 10Esanders) [17:47:12] (03PS9) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 [17:47:14] 3VisualEditor / 3ContentEditable: VisualEditor: Clouds are added at the end of a paste - 10https://bugzilla.wikimedia.org/58389#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High s:5normal>3major a:3Ed Sanders I believe we fixed this bug with the CE select-all change that Ed worked on two mo... [17:48:29] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (063ec067fa) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138857 [17:48:42] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) [17:49:57] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [17:50:28] 3VisualEditor / 3ContentEditable: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462 (10James Forrester) a:3Ed Sanders [17:50:52] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420 (10James Forrester) a:3Ed Sanders [17:53:49] (03CR) 10Catrope: "How does this fix the bug? Is there a moment where text is selected rather than a focusable node, like between the removal of the old node" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [18:01:00] (03CR) 10Esanders: "Removing the focusable node (which happens before inserting it in another place) eventually triggers onModelSelect (I forget the stack tra" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [18:03:03] (03CR) 10Esanders: "So my first attempt to fix was to wrap the focus call in a if(!this.relocating), but that doesn't catch another instance of this bug trigg" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [18:04:08] (03CR) 10Catrope: "Wait, you're saying that if you just cursor off a focusable node, there is code *other than this code* that causes the surface to be focus" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [18:05:51] (03CR) 10Esanders: "The reason we can get away with this in VE is that the gallery gets wrapped in a generated content wrapper div, so there are no issues wit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138812 (owner: 10Esanders) [18:11:34] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [18:12:47] (03PS14) 10Catrope: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [18:13:40] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Merge RelocatableNode into FocusableNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137003 (owner: 10Esanders) [18:15:08] (03PS6) 10Catrope: Update VE core submodule to master (fc52878) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [18:18:41] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (fc52878) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [18:20:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (fc52878) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137004 (owner: 10Esanders) [18:20:24] (03PS15) 10Catrope: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [18:21:07] (03CR) 10Catrope: Better measurement of focusable node for context menu (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [18:21:13] (03CR) 10Catrope: [C: 032] Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [18:21:19] (03PS5) 10Catrope: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [18:21:21] (03CR) 10jenkins-bot: [V: 04-1] Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [18:22:38] (03Merged) 10jenkins-bot: Better measurement of focusable node for context menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/136021 (owner: 10Esanders) [18:25:01] RoanKattouw, rebase problems? [18:25:38] Yeah I'm on it [18:26:03] (03CR) 10Catrope: Special case for shielding of generated content wrappers (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [18:26:08] (03PS6) 10Catrope: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [18:26:54] I think Jenkins might be full of crap there though [18:27:10] My local git refuses to rebase saying it's up to date [18:27:13] Maybe this patchset will pass [18:27:34] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/138812/ [18:30:52] edsanders: nice [18:31:20] (03CR) 10Catrope: [C: 04-1] "This breaks hiero nodes. They consist of a and a (the span only contains a newline, and only if Tidy is disabled or somethi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [18:32:25] (03PS3) 10Alex Monk: Show wikitext warnings in the reference and media caption dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) [18:33:23] (03PS7) 10Jforrester: [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [18:33:59] (03PS8) 10Jforrester: [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [18:34:22] (03CR) 10Jforrester: "PS7 is a rebase; PS8 removes comment about fixing something that Ed fixed in parallel." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [18:34:48] (03PS8) 10Jforrester: [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [18:35:35] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [18:41:32] (03PS4) 10Catrope: Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 (owner: 10Esanders) [18:41:41] 3VisualEditor / 3ContentEditable: VisualEditor: Would be nice if copying/pasting kept working after a fatal - 10https://bugzilla.wikimedia.org/66229#c3 (10James Forrester) Mostly seems to be caused by elements it doesn't recognise (? like
), especially when copying bits of tables and other structure... [18:45:31] (03PS5) 10Esanders: Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 [18:47:06] (03CR) 10Catrope: [C: 032] Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 (owner: 10Esanders) [18:50:20] (03Merged) 10jenkins-bot: Centre callout on context menu for small focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138797 (owner: 10Esanders) [18:50:58] James_F, what is that character we're using on the VE worklist that ends the page and continues text on the next page? [18:55:12] Krenair: Character? [18:55:34] Well.. I'm not really sure what it is [18:55:46] Krenair: Oh, that's a built-in Google Docs thing. [18:55:51] Krenair: "Break page". [18:55:58] Krenair: Does it break VE pasting? [18:56:38] No, I ran into that issue (again) that I mentioned a while ago involving deleting certain list items when in a certain combination of lists/sublists/break page markers etc. [18:56:45] Thought I'd try reporting it [18:59:51] * James_F nods. [18:59:54] Fun. [19:06:33] RoanKattouw_away, hiero outputs a table with display:inline... wat [19:08:07] edsanders: Yeah. Welcome to crapextensionland, population lots. [19:20:44] (03PS1) 10Esanders: Fix terrible Hiero CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138897 [19:21:07] edsanders: Hack! ;-) [19:21:59] (03CR) 10Esanders: "Stupid hiero:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [19:22:41] (03CR) 10Esanders: "This one could possibly be upstreamed (further testing may be required), but let's not sit around waiting for that to happen." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138897 (owner: 10Esanders) [19:23:11] edsanders: Yeah. [19:23:19] edsanders: Have you been able to reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=56644 yet? [19:26:00] will try later [19:27:11] edsanders: Thanks. [19:31:14] 3VisualEditor / 3Editing Tools: VisualEditor: For an image inside the caption of an image the context menu that appears at the top is completely aligned with the image shield - 10https://bugzilla.wikimedia.org/66494 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15630 --> https://... [19:32:13] (03PS1) 10Esanders: Remove setValue call from live extension setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138898 [19:32:14] 3VisualEditor / 3Editing Tools: VisualEditor: For an image inside the caption of an image the context menu that appears at the top is completely aligned with the image shield - 10https://bugzilla.wikimedia.org/66494 (10ryasmeen) a:3Ed Sanders [19:36:11] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [19:50:17] James_F, why is the Hiero module not loaded on production? [19:51:05] edsanders: Because it was a silly toy. Now I suppose it's about ready, though not exactly widely desired. [19:51:19] edsanders: Next time we revamp the toolbar we'll put it in. [19:51:25] It's always been ready [19:51:39] it's only ever been an extension of MWExtension [19:51:56] edsanders: The switch to MWLiveExtensionInspector or whatever made it a lot better, certainly. [19:51:57] it means they're alienated [19:52:06] Yes, I'm aware. :-) [19:52:19] is alienextension not enabled? [19:52:40] No? [19:53:11] * James_F checks. [19:53:27] No, it's not; that also wasn't considered ready. [19:55:09] pf [19:55:27] IIRC we said that once you could add/remove attributes it'd be good to go. [19:55:35] And you said you'd do it later. [19:55:41] I said editing was better than not editing [19:55:49] And we said we disagreed. :-) [19:56:05] No, you then +2'd the change [19:56:17] Same goes for Hiero, it doesn't need to be in the toolbar [19:56:31] From a user perspective being able to edit half of it and then have to switch to the wikitext editor is worse than being uneditable. [19:56:44] Because you have the interface make promises that your code can't keep. [19:57:26] you can edit all of it [19:58:01] Except the attributes, which are critical for many extension tags like syntaxhighlight, listings, gallery, … [19:58:13] syntaxhighlight has one required attribute, so you're done [19:58:29] gallery is already handled by another extensions which *doesn't* let you edit attributes [19:58:29] Not for inserting, but fair point. [19:58:38] Indeed, which is why gallery isn't in the toolbar any more. [19:58:51] but yet we still have it for editing [19:58:55] For now. [19:59:02] so we should do the same with the others [19:59:04] Maybe you're right and we should take it out. [19:59:30] really, you're going to cut off your nose to spite your face? [20:00:06] These tools cover 95% of use cases [20:00:37] It's the 5% that's the problem, though. [20:00:54] Because rushing out the tool half-done makes for huge amounts of angst and complaints. [20:01:18] I can defend an image editor that lets you do the most common things, because images are basic. [20:01:25] For specialist things, people have different expectations. [20:01:32] And yet we have the concept of alien nodes [20:01:46] Indeed. [20:01:57] we do release when we support 'most things' and add other tools later [20:02:11] For some things and not others. [20:02:18] It's a judgement call. [20:02:26] And so far you're not convincing me. [20:04:39] The majority of edits are fixes. If I see an incorrect caption in a gallery, I'd rather the tool let me edited the caption, than be completely disabled because I can insert another new gallery, or change the thumbnail size, both of which I didn't want to do in the first palce [20:04:42] *place [20:04:56] TrevorParscal, fetch the taser [20:13:38] (03PS1) 10Trevor Parscal: Make highlighting of context widget items less loud [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138906 [20:14:46] edsanders: https://gerrit.wikimedia.org/r/#/c/138906/ [20:15:02] i give up on doing anything interesting with the highlight on context widget [20:15:23] the problem is all of OOUI needs to be cleaned up, and this will just be deferred until then [20:16:00] (03CR) 10Esanders: [C: 032] Make highlighting of context widget items less loud [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138906 (owner: 10Trevor Parscal) [20:16:09] ok [20:17:34] can you explain to James why he's wrong because I've fulfilled my time-wasted-debating-with-James quota for the day [20:18:09] (03Merged) 10jenkins-bot: Make highlighting of context widget items less loud [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138906 (owner: 10Trevor Parscal) [20:23:32] (03CR) 10Cmcmahon: "I just realized that transclusion.feature is going to fail on a Vagrant wiki because no Templates exist to populate the suggestions the te" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138837 (owner: 10Cmcmahon) [20:33:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] While changing an image type from Thumbnail/Frame to Frameless/Basic, the wrap option gets unchecked but the alignment tabs remain active in Betalabs - 10https://bugzilla.wikimedia.org/66288#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX Fixed in 8... [20:33:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] While changing an image type from Thumbnail/Frame to Frameless/Basic, the wrap option gets unchecked but the alignment tabs remain active in Betalabs - 10https://bugzilla.wikimedia.org/66288#c2 (10Roan Kattouw) I mean gerrit 80d1240 [20:33:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] While changing an image type from Thumbnail/Frame to Frameless/Basic, the wrap option gets unchecked but the alignment tabs remain active in Betalabs - 10https://bugzilla.wikimedia.org/66288#c3 (10Roan Kattouw) I REALLY mean gerrit 138663 [20:34:58] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes " button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389 (10Roan Kattouw) a:3Trevor Parscal [20:36:13] 3VisualEditor / 3Editing Tools: VisualEditor:Cannot go to the next line of an article after inserting a special character in a block slug and the TypeError: Inserted data is trying to close the root node (at index 0) appears - 10https://bugzilla.wikimedia.org/65873 (10Roan Kattouw) a:3Ed Sanders [20:38:34] (03PS1) 10Esanders: Remove Hiero extension code from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 [20:39:19] (03PS1) 10Trevor Parscal: Remove use of imaginary config option in OutlineControlsWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/138958 [20:55:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] While changing an image type from Thumbnail/Frame to Frameless/Basic, the wrap option gets unchecked but the alignment tabs remain active in Betalabs - 10https://bugzilla.wikimedia.org/66288#c4 (10ryasmeen) Verified the fix [20:55:55] woot [21:06:41] harumph. [21:23:17] (03CR) 10Jforrester: [C: 032] Remove use of imaginary config option in OutlineControlsWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/138958 (owner: 10Trevor Parscal) [21:23:54] (03Merged) 10jenkins-bot: Remove use of imaginary config option in OutlineControlsWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/138958 (owner: 10Trevor Parscal) [21:27:44] TrevorParscal, I'm suddenly getting an oojs error in console when I load VE [21:27:59] TypeError: originFn is undefined [21:27:59] [21:27:59] for ( key in originFn.prototype ) { [21:28:08] oojs.js line 158 [21:29:48] mooeypoo: if you are in debug mode it should catch, and then you can move up the stack a bit and see which use of inheritClass is using an undefined symbol [21:30:09] usually it's because a class is loaded too late (order of files in the module is wrong) or a typo [21:30:14] Looking now [21:30:32] Hm ,it doesn't stop [21:30:46] there's a warning in the console, but the code keeps going (with later errors) [21:31:48] well, that's the reason, passing undefined into inheritClass [21:32:13] usually like OO.inheritClass( SomeClassThatDoesExist, SomeClassThatDoesNotExist ); [21:32:24] either because of loading order or a typo [21:33:05] I'm going over that loop now [21:33:09] waiting to see which triggers it [21:33:25] (03PS1) 10Catrope: Check language's direction rather than global direction in LanguageAnnotation description [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138996 [21:33:32] TrevorParscal, it's in OO.mixinClass [21:33:39] waiting to see which is called [21:33:45] sure, same deal basically [21:34:03] (03CR) 10Jforrester: [C: 032] Check language's direction rather than global direction in LanguageAnnotation description [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138996 (owner: 10Catrope) [21:34:31] are you adding a file, maybe forget to list it in the VisualEditor.php file list? [21:34:53] no, my code is clean [21:34:59] I just updated mw and ve [21:35:13] (03Merged) 10jenkins-bot: Check language's direction rather than global direction in LanguageAnnotation description [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138996 (owner: 10Catrope) [21:35:18] oh wait, I forgot to update the submodule. [21:35:52] hah. Okay, that did it. Sorry TrevorParscal that was my fault. Updating the submodule fixed everything right up. [21:36:09] no worries, sorry it was difficult to diagnose [21:44:17] (03CR) 10Catrope: [C: 04-1] "Feature request: if you select Arabic using the dialog, the directionality widget automatically switches to RTL. But if you type "ar" into" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders) [21:52:28] (03PS1) 10Dduvall: [BrowserTest] Ignore puppet-managed configuration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139005 [21:54:37] (03CR) 10Catrope: [C: 032] toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 (owner: 10Esanders) [21:54:39] (03CR) 10jenkins-bot: [V: 04-1] toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 (owner: 10Esanders) [21:55:58] (03PS2) 10Catrope: toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 (owner: 10Esanders) [21:56:22] (03CR) 10Catrope: [C: 032] toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 (owner: 10Esanders) [21:57:26] (03Merged) 10jenkins-bot: toLowerCase language code when searching for autonym [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138834 (owner: 10Esanders) [22:03:48] (03PS1) 10Jforrester: Create 'next' and 'previous' indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/139006 [22:16:29] (03CR) 10Cmcmahon: [C: 032] "gitignore stuff we don't need" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139005 (owner: 10Dduvall) [22:19:04] (03Merged) 10jenkins-bot: [BrowserTest] Ignore puppet-managed configuration [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139005 (owner: 10Dduvall) [22:22:57] 3VisualEditor / 3ContentEditable: VisualEditor: Cannot go to the next line of an article after inserting a special character in a block slug and "TypeError: Inserted data is trying to close the root node (at index 0)" appears - 10https://bugzilla.wikimedia.org/65873#c1 (10James Forrester) 5NEW>3ASSI p:5... [22:24:57] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes" button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389 (10James Forrester) [22:25:45] (03CR) 10Catrope: [C: 032] Fix terrible Hiero CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138897 (owner: 10Esanders) [22:25:59] (03CR) 10Catrope: [C: 032] Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [22:26:42] (03CR) 10Catrope: [C: 032] Set traditional galleries to inline-block to get correct width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138812 (owner: 10Esanders) [22:27:12] (03Merged) 10jenkins-bot: Special case for shielding of generated content wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138338 (https://bugzilla.wikimedia.org/51933) (owner: 10Esanders) [22:27:14] (03PS10) 10Catrope: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [22:27:24] (03Merged) 10jenkins-bot: Fix terrible Hiero CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138897 (owner: 10Esanders) [22:28:12] (03Merged) 10jenkins-bot: Set traditional galleries to inline-block to get correct width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138812 (owner: 10Esanders) [22:30:49] (03CR) 10Esanders: Improved layout of language input widget (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders) [22:31:12] (03PS2) 10Esanders: Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 [22:43:21] (03CR) 10Jforrester: "Right arrow ("next") indicator provided in I6211b2af in OOUI." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders) [22:44:38] (03PS1) 10Trevor Parscal: Re-enable apply button in action dialog on close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139019 (https://bugzilla.wikimedia.org/66389) [22:47:50] (03CR) 10Catrope: [C: 032] Re-enable apply button in action dialog on close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139019 (https://bugzilla.wikimedia.org/66389) (owner: 10Trevor Parscal) [22:48:59] (03Merged) 10jenkins-bot: Re-enable apply button in action dialog on close [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139019 (https://bugzilla.wikimedia.org/66389) (owner: 10Trevor Parscal) [22:51:27] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes" button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389 (10James Forrester) 5PATC>3RESO/FIX [22:51:30] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15631 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15631&action=edit tag not honored found in the co... [22:51:57] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502#c1 (10Chris McMahon) Created attachment 15632 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15632&action=edit "Use existing reference" button disabled on a page with a reference [22:53:26] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502#c2 (10Roan Kattouw) Did you install the Cite extension? Without it, the and tags don't work in read mode either. [22:54:12] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502#c3 (10Roan Kattouw) (In reply to Chris McMahon from comment #1) > Created attachment 15632 [details] > "Use existing reference" button disabled on a page with a reference Nice vacation accrual stats ;) (... [22:55:56] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502#c4 (10Chris McMahon) gah, [22:56:26] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502#c5 (10Chris McMahon) I hate screen shots [22:56:41] 3VisualEditor / 3ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - 10https://bugzilla.wikimedia.org/62590 (10James Forrester) [22:56:46] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644 (10James Forrester) [22:56:46] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10James Forrester) [22:56:46] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10James Forrester) [22:56:47] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester) [22:56:56] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502 (10Chris McMahon) [22:57:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444#c1 (10James Forrester) 5ASSI>3RESO/FIX Fixed by gerrit 138906. [22:57:56] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502 (10Chris McMahon) [22:58:56] 3VisualEditor: bare wiki + VE does not handle References properly - 10https://bugzilla.wikimedia.org/66502 (10Chris McMahon) 5NEW>3RESO/INV [23:12:16] RoanKattouw: beyond needing Cite for references in VE, is any other extension required for handling templates in VE properly? [23:13:09] chrismcmahon: TemplateData. [23:13:26] chrismcmahon: And Lua and ParserFunctions for most of the existing corpus of templates. [23:13:47] James_F: awesome [23:16:31] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Window process cleanup (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [23:24:40] (03PS1) 10Cmcmahon: [BrowserTest] remove experimental cursor test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139031 [23:25:05] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] remove experimental cursor test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139031 (owner: 10Cmcmahon) [23:25:20] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Update login tests to use api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138837 (owner: 10Cmcmahon) [23:26:56] (03Merged) 10jenkins-bot: [BrowserTest] remove experimental cursor test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139031 (owner: 10Cmcmahon) [23:27:29] (03Merged) 10jenkins-bot: [BrowserTest] Update login tests to use api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138837 (owner: 10Cmcmahon) [23:28:08] (03PS9) 10Catrope: [BREAKING CHANGE] Window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal) [23:30:04] James_F: we are actually very close to having a Vagrant VM where browser tests work. References and Templates are the holdouts at this point, all the test infrastructure works, thanks to Dan Duvall [23:35:11] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Window process cleanup (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [23:43:02] (03Abandoned) 10Catrope: Separate concerns between FocusableNode and ProtectedNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107540 (owner: 10Catrope) [23:43:14] RoanKattouw: :-D [23:43:19] chrismcmahon: Gosh. [23:44:09] (03CR) 10Catrope: [C: 032] Remove setValue call from live extension setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138898 (owner: 10Esanders) [23:44:20] RoanKattouw: One way to fix a WIP. [23:44:27] Exactly [23:44:28] James_F: I know that's something you've wanted for a long time, it's just about ready now [23:45:15] chrismcmahon: Brilliant. :-) [23:45:24] (03PS11) 10Catrope: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [23:45:42] (03Merged) 10jenkins-bot: Remove setValue call from live extension setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138898 (owner: 10Esanders) [23:50:36] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [23:51:06] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Window process cleanup [oojs/ui] - 10https://gerrit.wikimedia.org/r/138112 (owner: 10Trevor Parscal) [23:52:26] (03PS1) 10Alex Monk: Accessibility: Set role=dialog on dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/139039 (https://bugzilla.wikimedia.org/65473) [23:56:35] (03PS9) 10Catrope: [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal) [23:57:17] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)