[10:51:11] 3VisualEditor / 3ContentEditable: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462#c1 (10Ed Sanders) May have been fixed by https://gerrit.wikimedia.org/r/#/c/138833/ ? [10:51:19] (03CR) 10Esanders: "Yes and yes." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [10:54:29] (03CR) 10Esanders: "Actually to the second one, not really: When a focusable is focused we move native selection to the pasteTarget which clears the document " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders) [11:00:06] (03PS1) 10Esanders: Trigger endRelocation on focusable drag end [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139673 [11:00:08] (03PS1) 10Esanders: Block item drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139674 [11:03:05] (03PS1) 10Esanders: Fix sheild CSS broken by Parsoid styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139675 [11:05:41] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c9 (10Krinkle) This can be reproduced when using the input field for the Media insertion dialog. E.g. on https://www.medi... [11:31:42] (03PS1) 10Esanders: Remove margins from paragraphs inside table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 [11:36:39] (03CR) 10Esanders: [C: 032] Element: Remove focusin/focusout hack in onDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/138753 (owner: 10Krinkle) [11:38:10] (03CR) 10Esanders: [C: 032] Element: Add unit tests for focusin/focusout hack [oojs/ui] - 10https://gerrit.wikimedia.org/r/138752 (owner: 10Krinkle) [11:38:41] (03Merged) 10jenkins-bot: Element: Add unit tests for focusin/focusout hack [oojs/ui] - 10https://gerrit.wikimedia.org/r/138752 (owner: 10Krinkle) [11:38:43] (03Merged) 10jenkins-bot: Element: Remove focusin/focusout hack in onDOMEvent [oojs/ui] - 10https://gerrit.wikimedia.org/r/138753 (owner: 10Krinkle) [11:45:39] (03PS2) 10Esanders: Remove margins from paragraphs inside table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) [11:46:57] 3VisualEditor / 3ContentEditable: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416#c1 (10Ed Sanders) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/139676/ [11:57:51] (03PS1) 10Esanders: Wait for onDocumentFocus to happen before setting section range [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139677 (https://bugzilla.wikimedia.org/65928) [11:59:06] (03PS3) 10Esanders: Remove margins from paragraphs inside table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) [12:07:30] (03CR) 10Krinkle: "This might solve the problem at hand, but I'm not sure if it's right." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [12:07:47] (03PS2) 10Esanders: Wait for onDocumentFocus to happen before setting section range [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139677 (https://bugzilla.wikimedia.org/65928) [12:08:09] (03PS2) 10Krinkle: Remove Hiero extension code from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [12:10:26] 3VisualEditor / 3ContentEditable: VisualEditor: Typing into empty paragraph with inspector open creates pawn - 10https://bugzilla.wikimedia.org/62220#c1 (10Ed Sanders) 5NEW>3RESO/FIX Fixed these focus/range issues a while ago. [12:11:06] (03PS2) 10Krinkle: Tidy up SVG sources and fix pixel snapping [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders) [12:20:39] https://code.google.com/p/chromium/issues/detail?id=384827 [12:25:21] (03CR) 10Krinkle: [C: 031] "I couldn't find any visual difference when opening up the icons demo from master and from this branch in separate tabs and switching betwe" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders) [12:28:42] 3VisualEditor / 3Data Model: VisualEditor: Deleting a paragraph separator and subsequently typing any character messes up the page - 10https://bugzilla.wikimedia.org/64128 (10Ed Sanders) 5ASSI>3RESO/WOR [12:33:26] (03CR) 10Krinkle: [C: 031] Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [12:34:08] (03CR) 10Krinkle: Edit HTML mode in demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [12:35:46] (03CR) 10Krinkle: [C: 04-1] Indent demo HTML (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 (owner: 10Esanders) [12:38:18] (03CR) 10Krinkle: [C: 032] Wait for onDocumentFocus to happen before setting section range [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139677 (https://bugzilla.wikimedia.org/65928) (owner: 10Esanders) [12:39:56] (03Merged) 10jenkins-bot: Wait for onDocumentFocus to happen before setting section range [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139677 (https://bugzilla.wikimedia.org/65928) (owner: 10Esanders) [12:48:15] 3VisualEditor: VisualEditor: Keyboard events not detected after selecting a focusable node with the mouse - 10https://bugzilla.wikimedia.org/66638 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3Ed Sanders 1. Click on an image 2. Press delete Nothing happens Contrast with focussing an image by keyboard na... [12:52:04] (03PS1) 10Esanders: Defer focusableNode selection fix until after native selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139679 (https://bugzilla.wikimedia.org/66638) [12:59:27] 3VisualEditor / 3ContentEditable: VisualEditor: Replacing a selected template with a keyboard press creates a pawn (♙) - 10https://bugzilla.wikimedia.org/52185#c11 (10Ed Sanders) Pressing anything other than delete no longer does anything for me, which seems sensible. [13:01:41] 3VisualEditor / 3ContentEditable: VisualEditor: Inline templates don't wrap, assume width:100%, so break layout around floated items - 10https://bugzilla.wikimedia.org/51708#c3 (10Ed Sanders) Inline templates are overridden to inline-block, but setting them back to inline would mean we have to calculate the... [13:08:14] hey [13:08:16] https://pl.wikipedia.org/w/index.php?title=Bagnet_M9&diff=prev&oldid=39636662 [13:10:13] MatmaRex and I suspect that either only location of __TOC__ is remembered and then restored, or, since toc is not visible, user unknowingly moved it [13:10:34] so that -> https://bugzilla.wikimedia.org/show_bug.cgi?id=49224 would be probably nice [19:29:37] (03CR) 10Vikassy: "Doubts" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [19:35:06] (03CR) 10Manybubbles: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [19:44:41] (03CR) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [20:50:41] (03PS21) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [20:53:14] (03PS22) 10Vikassy: [BrowserTest] Adding Browser test for Headings and its screenshot elements for Language Screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [20:59:16] (03PS23) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737)