[10:49:00] (03PS1) 10Esanders: Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 [10:49:02] (03PS1) 10Esanders: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) [10:53:52] (03PS1) 10Esanders: Remove display:inline-block highlight hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139806 (https://bugzilla.wikimedia.org/51708) [11:03:06] (03PS2) 10Esanders: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) [12:24:09] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery Highlight is not getting redrawn in correct position while changing the Heading style applied on it - 10https://bugzilla.wikimedia.org/61766#c2 (10Ed Sanders) 5NEW>3RESO/FIX Galleries can no longer take a paragraph style, which is correct and fixes th... [12:26:38] 3VisualEditor / 3Editing Tools: VisualEditor: After inserting a gallery, the newly inserted gallery does not remain highlighted but the inspector icon shows up at the corner of the page - 10https://bugzilla.wikimedia.org/61065#c2 (10Ed Sanders) 5NEW>3RESO/FIX mwGallery is not in the insert menu anymore,... [12:27:25] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery remains highlighted even after clicking elsewhere in the page - 10https://bugzilla.wikimedia.org/61068#c1 (10Ed Sanders) 5NEW>3RESO/FIX Appears to have been fixed a while ago. [12:30:26] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Ed Sanders) [12:30:27] 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it and then moving mouse out of the object - 10https://bugzilla.wikimedia.org/66106#c1 (10Ed Sanders) Not a shield issue. [12:30:38] 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it and then moving mouse out of the object - 10https://bugzilla.wikimedia.org/66106#c2 (10Ed Sanders) 5ASSI>3RESO/FIX Appears to have been fixed. [12:31:54] 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716#c2 (10Ed Sanders) Selection range issue, not a shield issue. [12:31:55] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Ed Sanders) [12:39:05] (03PS3) 10Esanders: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) [12:39:07] (03PS2) 10Esanders: Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 [12:39:09] (03PS1) 10Esanders: Make all focusable nodes clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139814 [12:44:53] (03PS2) 10Esanders: [BREAKING CHANGE] Make all focusable nodes clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139814 [12:44:55] (03PS4) 10Esanders: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) [12:44:57] (03PS3) 10Esanders: Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 [12:48:18] (03PS3) 10Esanders: [BREAKING CHANGE] Make all focusable nodes clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139814 [12:48:20] (03PS5) 10Esanders: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) [12:48:22] (03PS4) 10Esanders: Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 [12:49:54] (03PS6) 10Esanders: [BREAKING CHANGE (ish)] Track orignal data position in insertion operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/62681) [12:51:09] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Ed Sanders) [12:51:10] 3VisualEditor / 3Editing Tools: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c4 (10Ed Sanders) Issue is with dm selection, not shields/highlights. [12:53:10] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Ed Sanders) [12:53:10] 3VisualEditor / 3Editing Tools: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c5 (10Ed Sanders) 5PATC>3ASSI Edited wrong bug, ignore change 137040 and above comment. [12:53:39] 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716#c3 (10Ed Sanders) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 6... [12:53:40] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] The previous line is also getting highlighted while adding a reference list/image - 10https://bugzilla.wikimedia.org/65706#c4 (10Ed Sanders) *** Bug 65716 has been marked as a duplicate of this bug. *** [12:54:08] 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716 (10Ed Sanders) 5RESO/DUP>3REOP [12:54:19] (03PS7) 10Esanders: [BREAKING CHANGE (ish)] Track orignal data position in insertion operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) [13:32:48] (03PS1) 10Esanders: Fix selection after inserting nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) [13:33:55] 3VisualEditor / 3ContentEditable: VisualEditor: Issues with shields/highlights/phantoms (tracking) - 10https://bugzilla.wikimedia.org/66083 (10Ed Sanders) [13:33:55] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] The previous line is also getting highlighted while adding a reference list/image - 10https://bugzilla.wikimedia.org/65706#c6 (10Ed Sanders) DM selection issue, not a shield bug. [13:35:56] (03PS2) 10Esanders: Fix selection after inserting nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) [13:44:28] (03PS2) 10Esanders: Block item drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139674 (https://bugzilla.wikimedia.org/51666) [15:01:28] 3VisualEditor: beta labs: Review your changes throws error - 10https://bugzilla.wikimedia.org/66669 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None On any page at http://en.wikipedia.beta.wmflabs.org/ Make an edit Click Review your changes User sees a modal dialog saying "Error loading data from... [15:01:57] 3VisualEditor: beta labs: Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669#c1 (10Chris McMahon) Note: saving changes works correctly [16:41:08] 3VisualEditor: beta labs: Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669 (10Chris McMahon) s:5normal>3major [17:07:12] Hmmm...have any of y'all seen a big about opening up edt [17:07:25] ack [17:07:25] Let's try that again [17:08:07] Have any of y'all seen a bug report about opening up edit&ssection=0 using VE puts the cursor at the bottom of the window? [17:08:19] * Keegan is lost in the see of VE on Bugzilla [17:08:46] *page, not window. Coffee. Need. [17:09:55] (03CR) 10Vikassy: [BrowserTest]Added script to run cucumber for various languages and upload it to commons using mediawiki_api gem (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138377 (owner: 10Vikassy) [17:15:54] James_F my daaaahling, how's OOJS/IE detection going? [17:24:22] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c1 (10Moriel Schottlender) The problem seems to be in ve.ce.Document.p... [17:26:37] RoanKattouw_away, I'm not sure why ve.ce.Document looks fro the followup image node when you change an unrelated 2-nodes-away image node, but it seems to fail on that part. https://bugzilla.wikimedia.org/show_bug.cgi?id=66604 [17:30:06] marktraceur: https://gerrit.wikimedia.org/r/#/c/139308/ [17:30:30] Keegan: No, that sounds like a new one. :-( [17:30:46] Well, it's just quirky [17:30:48] James_F, What did you mean by 'Write the copy on the commits' at https://bugzilla.wikimedia.org/show_bug.cgi?id=51798#c3 ? [17:30:49] Just filed the bug [17:30:54] 3VisualEditor: VisualEditor: Edit&vesection=0 does not behave as expected - 10https://bugzilla.wikimedia.org/66674 (10Keegan Peterzell) 3NEW p:3Unprio s:3normal a:3None When a page is opened in the wikitext editor with section=0, the top of the page is presented for editing The is the desired and expec... [17:31:07] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10Ed Sanders) 5PATC>3RESO/FIX [17:31:52] 3VisualEditor / 3ContentEditable: VisualEditor: Edit&vesection=0 does not behave as expected - 10https://bugzilla.wikimedia.org/66674 (10Keegan Peterzell) [17:32:32] James_F: It's largely a ru.wp workflow issue, but still a bug [17:33:04] Keegan: Indeed. [17:33:56] One doesn't easily wind up at veaction?edit&vesection=0 [17:34:33] Or whatever the URL string is [17:34:39] Krenair: I meant, feel free to do a WIP commit with "WRITEME" for the i18n strings and I can write the actual values, rather than spending time on that bit if you don't want. [17:34:53] okay [17:35:15] Krenair: Yeah, but the existing bug in this area say that the cursor is at the top, not the bottom. [17:35:35] Keegan, ^? [17:35:44] Bah, sorry, yes [17:36:07] You three need to get different nicks. :-) [17:39:10] James_F: I misspoke when I first asked [17:39:25] The cursor stays at the top, the page scrolls to the bottom [17:40:52] Tim_Kasher: Ah, right; does the page scroll to the 'right' place but the cursor doesn't? [17:41:58] James_F: Other way around :) [17:42:24] Tim_Kasher: That's… decidedly odd. [17:42:38] edsanders: http://cl.ly/image/1J0X0c0V090B [17:42:40] edsanders: I agree with you [17:42:50] https://en.wikipedia.org/w/index.php?title=Armadillo&veaction=edit&vesection=0 [17:42:56] You should stay at the top of the page [17:42:58] But nope [17:43:57] a confirm dialog, unlike other dialogs which are designed to encapsulate an activity, are very simple and have a direct response that should be below [17:44:10] i will be making sure we do this [17:44:20] Tim_Kasher: Aha, but https://en.wikipedia.org/w/index.php?title=Armadillo&veaction=edit&vesection=1 works fine? Interesting. Thanks for the report! [17:44:40] Sure sure! [17:46:39] 3VisualEditor / 3ContentEditable: VisualEditor: Scrolling for &vesection=N works correctly except for N=0, where it scrolls to the bottom of the document - 10https://bugzilla.wikimedia.org/66674 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders [17:48:01] TrevorParscal, did you erase your iPhone to prove a point? [17:48:10] ? [17:48:17] no, it's just a random screenshot [17:48:24] and, I'm making your point [17:48:41] :0 [17:48:43] :) [17:49:09] edsanders, I was going to ask the same thing! [17:49:22] *That's* dedication. [17:49:37] I thought he'd finally seen the light and got a nexus [17:50:15] Or a Windows phone? [17:51:14] ryasmeen, are you around? I have a question about that bug.. did you write the wikitext for the insane caption by hand, or is this inserted through VE ? [17:51:41] mooeypoo, I inserted that from VE [17:51:56] hm [17:52:20] We might want to prevent those, then. Even the PHP parser is having trouble, it seems. It's not showing the content as the caption of the image. [17:54:43] mooeypoo: the first image on that page does not have anything in its caption field [17:54:56] ryasmeen, I know, but the bug seems to be related to the other image. [17:55:06] Without that image, all works well. [17:55:09] oh okay [17:56:38] 3VisualEditor: beta labs: Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669#c2 (10Chris McMahon) I am seeing this error modal dialog also intermittently on test2wiki (and presumably mediawiki.org) when switching modes from VE to wikitext editor. [17:57:16] Something's massively wrong with that caption. It's not displaying half of what's in there. [17:58:11] RoanKattouw_away, re that bug, this seems to be the cause, and it has a lot more problems than just the offset crunching.. php-parser isn't displaying it right either: https://test2.wikipedia.org/wiki/User:Mooeypoo/CaptionMadness [18:23:09] mooeypoo: OK so talk to me about image weirdness [18:23:09] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error loading data from server while reviewing changes from Save dialog - 10https://bugzilla.wikimedia.org/66681 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15665 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15665&ac... [18:23:27] I'm sorry it took me so long to get on IRC, my computer crashed while running git fetch and the resulting cleanup (which involved rm -rf .git) took a while [18:31:20] RoanKattouw, oh, it's not image weirdness, it's image madness. [18:31:37] RoanKattouw, it got *upgraded!* [18:31:43] RoanKattouw, anyways, look here: https://test2.wikipedia.org/wiki/User:Mooeypoo/CaptionMadness [18:32:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf10] Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Roan Kattouw [18:32:25] RoanKattouw, sorry, let me start from the beginning. The bug is this: https://bugzilla.wikimedia.org/show_bug.cgi?id=66604#c1 and I believe I found the cause,I believe, and it is the insanity that is this caption. [18:32:37] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error loading data from server while reviewing changes from Save dialog - 10https://bugzilla.wikimedia.org/66681#c2 (10James Forrester) 5PATC>3RESO/DUP *** This bug has been marked as a duplicate of bug 66669 *** [18:32:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf10] Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669#c3 (10James Forrester) *** Bug 66681 has been marked as a duplicate of this bug. *** [18:35:33] mooeypoo: OK [18:35:39] So, can you give me the narrative here? [18:36:56] (03PS8) 10Catrope: [BREAKING CHANGE (ish)] Track original data position in insertion operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) (owner: 10Esanders) [18:37:38] (03CR) 10Catrope: [C: 04-1] Don't use jQuery show() or toggle() (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 (owner: 10Esanders) [18:38:40] RoanKattouw_MSc, Okay, so if you try to make a block image into inline in that page (the first or second images will produce this bug) you will get an offset error. I figured out it comes from ve.ce.Document.getNodeAndOffset(), where the while loop's running. [18:39:26] OK [18:39:27] RoanKattouw_MSc, I thought at first it was because of the "link-math" combination but even taking those out the bug recurs. [18:39:32] Let me do that locally and debug [18:39:42] It only stopped when I took the big image out, the one with the huge caption. [18:40:37] Hold on [18:40:40] That page only has one inline image [18:40:45] Everything else is in that image's caption [18:40:54] So what am I supposed to do to trigger the bug? [18:41:39] wait [18:42:18] RoanKattouw_MSc, sorry, I gave you the wrong page -- here's the original page for the bug: https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&oldid=87309 [18:42:54] (03PS2) 10Catrope: Fix shield CSS broken by Parsoid styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139675 (owner: 10Esanders) [18:43:06] (03CR) 10Catrope: [C: 032] Fix shield CSS broken by Parsoid styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139675 (owner: 10Esanders) [18:43:13] RoanKattouw_MSc, take the first [K] image, open the edit dialog, transform it into "basic" (so, inline) and click "apply". YOu'll see the error in the console "Uncaught Error: Offset could not be translated to a DOM element..." [18:43:31] It'ds something about looking for the image's outer range. [18:43:49] I couldn't figure out why it dies like that. [18:44:13] OK I've reproduced the error [18:44:21] (03Merged) 10jenkins-bot: Fix shield CSS broken by Parsoid styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139675 (owner: 10Esanders) [18:44:37] Is there a more ... minimal test caes? [18:44:44] RoanKattouw_MSc: congratulations btw! [18:45:00] gwicke: Thanks :) [18:45:24] was the ceremony this weekend? [18:45:29] heard something about Sunday [18:46:50] RoanKattouw_MSc, yes, https://test2.wikipedia.org/wiki/User:Mooeypoo/CaptionMadness [18:47:28] RoanKattouw_MSc, in that case the image actually does seem to be inserted -- but the error pops up anyways in the console. That's why I think it has to do with the big caption even though it's 2 nodes away. [18:47:52] I was able to make all of those images inline without problems [18:48:00] So what do I actually do on that page to reproduce the bug? [18:48:17] gwicke: Yeah it was yesterday [18:48:48] RoanKattouw_MSc: awesome! [18:49:00] I got to wear a black gown and a black cap and sit still for 2 hours (twice) in the sun (once) in 27C <_< [18:49:01] welcome to the post-graduation life ;) [18:49:04] :) [18:49:30] RoanKattouw_MSc, okay, hang on, I'm redoing the minimal wikitext. Give me a sec. [18:50:11] (03PS2) 10Catrope: Trigger endRelocation on focusable drag end [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139673 (owner: 10Esanders) [18:50:21] (03CR) 10Catrope: [C: 032] Trigger endRelocation on focusable drag end [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139673 (owner: 10Esanders) [18:50:31] edsanders: Which were the most important commits of yours for me to review? [18:51:17] (03CR) 10Catrope: [C: 032] Remove margins from paragraphs inside table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:51:45] (03Merged) 10jenkins-bot: Trigger endRelocation on focusable drag end [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139673 (owner: 10Esanders) [18:51:59] (03CR) 10Catrope: [C: 032] Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [18:52:39] (03Merged) 10jenkins-bot: Remove margins from paragraphs inside table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:53:55] (03CR) 10Catrope: "Krinkle makes good points, and I probably wouldn't have merged this had he actually -1ed. In the future, please cast a -1 vote when making" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:55:47] (03CR) 10Krinkle: "They were meant for Ed, not for someone reviewing it instead of me. Not that we actively claim commits, but generally someone who starts r" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:56:07] But sure, I'll -1 more often. [18:56:25] Krinkle: -1 == I've looked at this and think it may not be perfect for merge right now. :-) [18:56:51] -1 is: I don't own this change and should read through the comment log but instead rely on a boolean flag someone else left. [18:56:53] (03CR) 10Catrope: "Yeah I should have read the comments, my bad. But if you comment what's effectively a -1 without actually -1ing, it's not very visible." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:57:08] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way for users to insert variable magic words - 10https://bugzilla.wikimedia.org/49996#c4 (10Alex Monk) (In reply to Alex Monk from comment #3) > Actually, maybe we should just have VE query > api.php?action=query&meta=siteinfo&siprop=magicwords, then lo... [18:57:08] 3VisualEditor / 3ContentEditable: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416#c4 (10James Forrester) 5PATC>3RESO/FIX We should probably do a follow-up tech debt bug about margins for non-paragraphs in table cells… [18:57:12] Just my 2c, but can't wait to no longer have a +1/-1 [18:57:19] like github already does, and phab I believe as well. [18:57:30] instead comments are left and need to be dealt with (at which point they're hidden by default) [18:58:14] I'll -1 more often, but don't get used to it, or make sure to block fab on it. [18:59:24] (03CR) 10Krinkle: "Okay, I can understand that. I think the process should be to read the comments, not to rely on -1, but in case of Gerrit (as opposed to P" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [19:00:44] James_F: I also very much miss the 'fixme/needs-fixup' or 'needs-followup' tag (e.g. the tag to indicate this needs to be reverted soon if not fixed up soon, and the tag indicating there's a comment proposing an improvement). We prbably shouldn't have the latter tag, better to file a bug. [19:01:04] but fixme/needs-fixup seems useful for the lightweight short-lived cycles [19:01:21] right now I"m using "star" or browser bookmarks, which is tedious [19:04:20] (03PS1) 10Esanders: Revert "Fix shield CSS broken by Parsoid styles" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139886 [19:05:31] (03CR) 10Catrope: [C: 032] Revert "Fix shield CSS broken by Parsoid styles" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139886 (owner: 10Esanders) [19:05:54] (03PS2) 10Esanders: Don't use jQuery show() or toggle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 [19:06:42] (03CR) 10Esanders: Don't use jQuery show() or toggle() (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 (owner: 10Esanders) [19:06:44] (03Merged) 10jenkins-bot: Revert "Fix shield CSS broken by Parsoid styles" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139886 (owner: 10Esanders) [19:07:27] (03CR) 10Krinkle: [C: 04-1] "not sure if it's worth it here, but may want to toggle class based on this and hide it in css (thus having the class only activate the css" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 (owner: 10Esanders) [19:08:44] RoanKattouw_MSc, https://test2.wikipedia.org/w/index.php?title=User:Mooeypoo/CaptionMadness [19:09:32] (03CR) 10Catrope: [C: 032] Don't use jQuery show() or toggle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 (owner: 10Esanders) [19:09:48] RoanKattouw_MSc, try to get the first image from block to inline (media edit -> 'basic') [19:10:18] Hah [19:10:26] But that image doesn't even have a weird caption! [19:10:43] ed_s_MA_Cantab: :-P [19:11:04] (03Merged) 10jenkins-bot: Don't use jQuery show() or toggle() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139422 (owner: 10Esanders) [19:11:11] RoanKattouw_MSc, getClientRects [19:11:23] * James_F is James_F_MEng_MIET (and was James_F_MEng_MIET_MBCS_MRI) but who cares really? [19:11:26] and block drag and drop [19:12:38] RoanKattouw_MSc, the third one does... I initially took out the beginning of that wikitext and could reproduce it again, so I thought it was the big caption-mess image.. but... I'm not sure anymore. [19:15:56] RoanKattouw_MSc, take off the line "[[link]]link

\pi

" -- the bug is still happening without it [19:17:20] mooeypoo: Could you edit that out? [19:18:03] yes, and it didn't happen when I removed [[Language]] so could that be the cause? [19:18:28] I don't know, I haven't looked in depth yet [19:18:35] Right now I'm reviewing Ed's code while he's still awake [19:18:47] You're usually around later than Ed, for obvious reasons :) [19:20:36] I'm a night owl. [19:22:44] And 5 hours behind [19:22:59] RoanKattouw_MSc, I edited the page. It seems to only happen with both [[Language]] and the huge caption image, and I have no idea why, but removing either one of those "fixes" the bug. [19:23:08] OK [19:23:10] That too [19:23:18] So you've minimized it now? Removal of anything at all no longer triggers the bug [19:23:19] ? [19:23:31] Let me try removing one more [19:23:50] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Debug bar refactor (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 (owner: 10Esanders) [19:28:13] RoanKattouw_MSc, okay, I tried to remove things from *inside* that caption, but anything I remove "fixes" the bug. So I'm leaving this as-is. https://test2.wikipedia.org/w/index.php?title=User:Mooeypoo/CaptionMadness [19:29:45] OK [19:29:55] That confirms the test case is locally minimal :) [19:29:57] thanks for that [19:30:06] I'm reviewing some of Ed's stuff now but I'll come back to your bug later today [19:32:01] RoanKattouw_MSc, minimal, but confusing as hell. It seems there's a precise combination of magical stuff to make this bug happen. [19:32:47] ryasmeen used an enchanted map to find it, I swear. [19:34:08] haha [19:39:02] also, RoanKattouw_MSc this is a double-bug. There's the bug I reported, and there's another hiding inside, about the caption itself not really being interpreted by VE and the php parser (but we allow for it in the edit dialog) [19:39:09] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Make all focusable nodes clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139814 (owner: 10Esanders) [19:39:14] Krinkle: No chance of even a 3-second-OMG-this-approach-sucks CR on https://gerrit.wikimedia.org/r/139308 ? :-) [19:39:38] ryasmeen, do you get bonus points for finding a double-bug ? C-C-C-COMBO! [19:40:17] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Make all focusable nodes clickable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139814 (owner: 10Esanders) [19:42:07] ed_s_MA_Cantab: Where is the VE-MW change for killing ClickableNode? [19:43:49] James_F: OMG enough? [19:44:18] Krinkle: Sure. :-) [19:44:43] Krinkle: Also, needing to put the tester in resoureces/lib to avoid the test failures of doing return not inside a function makes me sad. [19:44:55] mooeypoo : I am also trying to find the exact steps to reproduce that bug in a different and much simpler page :) [19:45:48] mooeypoo: I was trying to delete each item from the caption but i cant delete the image inside it for some reason :S [19:46:20] (03PS1) 10Catrope: Update VE core submodule to b16dbb52 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139900 [19:46:47] James_F: I think the majority of the list can be reduced on what is mutually exclusive and overlapping subsets in actual engines. Technically a single method check (anythign ES5) should be enough but browsers did do them gradually so checking more than one is indeed needed. [19:47:26] mooeypoo:https://test2.wikipedia.org/wiki/11thfebchrome?veaction=edit [19:47:44] James_F: https://gerrit.wikimedia.org/r/139900 [19:47:52] in this page I cannot delete anymore item from the second image's caption field [19:47:54] James_F: What do you mean? [19:48:04] James_F: about return not inside a function [19:48:07] return in the global scope is fine [19:49:23] mooeypoo: I am trying to delete those items from VE btw [19:49:25] James_F: For Date.parse plain "Date.parse" is sufficient, it is not our job to assert whether the native method works. es5-shim has all that already. [19:49:42] it does tests on method that are known to have been implemented early in a broken way [19:50:11] (03PS1) 10Esanders: Remove clickable node mixins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139928 [19:50:17] RoanKattouw_MSc, ^^ [19:50:22] forgot to push apparently [19:51:16] Thanks [19:51:24] ed_s_MA_Cantab: Can I get a +2 on https://gerrit.wikimedia.org/r/139900 ? [19:52:30] (03CR) 10Esanders: [C: 032] Update VE core submodule to b16dbb52 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139900 (owner: 10Catrope) [19:54:08] (03Merged) 10jenkins-bot: Update VE core submodule to b16dbb52 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139900 (owner: 10Catrope) [19:54:09] Thanks [19:54:16] I'll do the pull-through of the ClickableNode change after lunch [19:54:33] ...or now [19:56:33] ryasmeen, ... TRIPLE BUG! K-K-K-KO! [19:56:40] wow, I'm really dating myself here. [19:57:27] ryasmeen, of course it won't let you delete this image. *it doesn't exist* (see, it won't appear in VE or the view mode at all) you found a ghost. [19:57:33] ryasmeen, can you post that as a bug too? [19:57:38] mooeypoo: :D [19:57:56] This is somewhere between hilarious and awfully sad. [19:58:03] ha! [19:58:06] I managed to remove it [19:58:10] (03PS1) 10Catrope: Update VE core submodule to master (89820e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140005 [19:58:30] ryasmeen, put your cursor in the caption's first line. Hit "delete". That works. [19:58:40] btw on my attempt to minimize the caption from edit source , i found that the image inside it and the cite web template both of these are need to be there, to reproduce it [19:58:42] The only thing that seems to not work is marking the image and trying to delete it. [19:59:00] needed * [19:59:06] RoanKattouw_MSc, ^^ [19:59:45] it appears the offset bug is indeed a caption issue. Though again, I'm confused. Removing the [[Language]] link from the beginning fixed the bug for me, too, so.. it's very odd. [19:59:48] (03PS2) 10Catrope: Update VE core submodule to master (89820e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139928 (owner: 10Esanders) [20:00:13] (03Abandoned) 10Catrope: Update VE core submodule to master (89820e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140005 (owner: 10Catrope) [20:01:22] mooeypoo:so this is the page with minimum wikitext needed to reproduce:https://test2.wikipedia.org/wiki/14th_january?veaction=edit [20:02:13] OK actually leaving for lunch now [20:02:46] RoanKattouw_away, bon apetit [20:03:25] ryasmeen, ha! you rock! how did it not work for me without [[Language]]... okay, weird. I updated the page I sent RoanKattouw_away with this. Thanks! [20:09:53] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (89820e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139928 (owner: 10Esanders) [20:11:30] (03Merged) 10jenkins-bot: Update VE core submodule to master (89820e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139928 (owner: 10Esanders) [20:42:18] (03PS7) 10Esanders: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 [20:42:29] (03PS8) 10Esanders: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 [20:44:23] (03PS1) 10Esanders: Use new setupToolbar and setupDebugbar methods in base target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 [20:44:36] (03CR) 10jenkins-bot: [V: 04-1] Use new setupToolbar and setupDebugbar methods in base target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 (owner: 10Esanders) [20:59:42] (03PS2) 10Esanders: Use new setupToolbar and setupDebugbar methods in base target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 [21:00:13] (03CR) 10jenkins-bot: [V: 04-1] Use new setupToolbar and setupDebugbar methods in base target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 (owner: 10Esanders) [21:46:14] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 (owner: 10Esanders) [21:47:01] Krinkle, hey [21:47:20] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 (owner: 10Esanders) [21:47:38] For https://bugzilla.wikimedia.org/show_bug.cgi?id=49996 I was fiddling with some TemplateData stuff, basically sending a bunch of info about magic words [21:47:38] (03PS3) 10Catrope: Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [21:48:02] (03CR) 10Catrope: [C: 032] Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [21:48:31] (03PS3) 10Catrope: Indent demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 (owner: 10Esanders) [21:49:17] (03Merged) 10jenkins-bot: Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders) [21:49:22] it ends up looking like this: https://gist.github.com/Krenair/c211269f3537ddca3879 [21:49:27] checking [21:49:32] ed_s_MA_Cantab: Did you also write and forget to submit a VE-MW change for the debug bar change? [21:49:58] RoanKattouw_MSc: Did you see my comment on that one (edit html) [21:50:09] Also from last weekend [21:50:26] Yeah [21:50:32] You said "can X be used here?" [21:50:34] yes, but submitted it an hour ago [21:50:36] But it seemed pretty minor [21:50:43] * RoanKattouw_MSc presses F5 [21:50:45] 140018 [21:51:01] Cool, thanks [21:51:39] minor, but not an intentional lack to be enhanced later, I think it was just a copy/paste oversight. Trivial to fix. [21:52:09] The stack seemed ready otherwise so I wanted to get it in :) [21:52:15] k [21:52:19] But then I noticed your more substantial comment on the other one (alien vs cite) and held that one back [21:52:30] But by then it was too late to hold back the other one [21:52:37] Sorry, my bad [21:53:17] (03PS3) 10Catrope: Update VE core submodule to master (155f4ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 (owner: 10Esanders) [21:54:09] Krenair: What's title? [21:54:30] (03PS1) 10Esanders: Use cached surfaceView [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140030 [21:54:32] Krinkle, ^^ [21:55:02] I wasn't quite sure whether it had to refetch, since it did swap targets at some point [21:55:03] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (155f4ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 (owner: 10Esanders) [21:55:21] (03CR) 10Catrope: [C: 032] Use cached surfaceView [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140030 (owner: 10Esanders) [21:55:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf10] Review your changes throws fatal error - 10https://bugzilla.wikimedia.org/66669#c6 (10ryasmeen) 5PATC>3RESO/FIX Verified the fix in Betalabs [21:55:41] Krenair: Does our DOM contain the canonical name for magic words? [21:55:54] (since there are back-compat aliases and localised variants) [21:56:12] hm, don't think I need that title. It's just the same as the key. [21:56:13] no, that's all inside surfaceReady [21:56:57] Krenair: 0 is the colon argument? [21:56:58] As for canonical vs. aliases/localised, etc. - I'm not sure. will check [21:57:38] Krenair: params is an object, not an array. [21:57:41] (03Merged) 10jenkins-bot: Use cached surfaceView [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140030 (owner: 10Esanders) [21:57:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (155f4ab) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140018 (owner: 10Esanders) [21:59:30] Krenair: I'd add a boolean parameter to TemplateData API to include magicwords. VE can make a separate call for that, or include it in the first call for a template (whichever). [21:59:38] Krinkle, 0 was the first argument, yeah. Was going to check how it actually handles templates arguments without names... [21:59:58] yeah, I already put it behind a 'magicwords' parameter. this is the result when it's turned on [22:00:02] just as any other name. Parsoid then sometimes omits 1=, 2= if possible as prettification. [22:00:26] (03CR) 10Catrope: [C: 032] Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 (owner: 10Esanders) [22:00:29] but we'll need to implemetn support for the colon argument in Parsoid and VisualEditor DM first. [22:00:36] Right, yeah, it should be 1. [22:00:40] No [22:00:52] {{FOO:magical|this is 1}} [22:00:55] magical != 1 [22:01:45] Concrete example: {{#if:condition|yes|no}} --> condition is argument 0, yes is 1, no is 2 [22:02:36] (03PS6) 10Catrope: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) (owner: 10Esanders) [22:02:38] (03Merged) 10jenkins-bot: Create highlight elements on demand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139804 (owner: 10Esanders) [22:02:40] (03CR) 10jenkins-bot: [V: 04-1] Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) (owner: 10Esanders) [22:03:51] huh, ok. [22:04:39] James_F, I need moar bugs. [22:07:09] 3VisualEditor / 3Editing Tools: VisualEditor:Getting Error: Inserted data is trying to close the root node (at index 0) while trying to go the next line after inserting a Hiero in Firefox - 10https://bugzilla.wikimedia.org/66691 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Ope... [22:07:40] RoanKattouw_MSc, you rebasing getclientrects? [22:07:44] mooeypoo: I don't know what kind of work James had in mind for you, but if you wanted to help with IE stuff while I drown in Ed's flood of commits, you could see if the unit test suite still runs in IE (probably not) and fix the things that break it [22:07:46] ed_s_MA_Cantab: Yes [22:08:12] RoanKattouw_MSc, I can try. Last time I couldn't get IE to load VE at all, though [22:08:30] That's why I wanna start with the test suite [22:08:40] It'll be easier to diagnose individual issues in individual tests [22:08:50] Most likely, a bunch of tests will crash with JS errors [22:08:53] And some will fail [22:09:09] Debugging failures can be difficult but JS errors are usually pretty doable [22:09:27] * mooeypoo nods [22:09:53] (03PS7) 10Catrope: Shields are dead, long live getClientRects [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139805 (https://bugzilla.wikimedia.org/52339) (owner: 10Esanders) [22:10:46] ed_s_MA_Cantab: Easy conflict, it was just the addition of the endRelocation() call to the dragend handler conflicting with the class removal being renamed and moved to a different element [22:11:03] RoanKattouw_MSc, ok, I'm finishing up a bug and then I'll see how to get VE to work thorugh master on Windows so I can unit test. [22:11:12] OK [22:11:34] mooeypoo: Do you know how to run the VE core unit tests only? That may help limit the scope of the problems :) [22:12:04] That way you don't have to get MediaWiki working either [22:12:45] oooh [22:12:53] I don't? [22:13:06] (that wasn't supposed to be a question.) [22:13:12] localhost/w/extensions/VisualEditor/lib/ve/modules/ve/test/ [22:13:22] Plus the http:// that Chrome helpfully isn't writing to the clipboard [22:18:23] * mooeypoo nods [22:20:25] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null and this.debugBar is null and cannot re-open after that - 10https://bugzilla.wikimedia.org/66692 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Create... [22:20:38] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null and this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692 (10ryasmeen) [22:33:43] ed_s_MA_Cantab: Hah so I was reading your O(n^2) algorithm for eliminating rectangles contained in other rectangles. I knew there was a better way to do it but didn't remember. James had the same thing. Ironically, Trevor (the only one here who doesn't have a college degree) knew how to do it [22:33:51] (scanline) [22:33:59] We can optimize it later though :) [22:34:07] ...are y'all putting random letters after yer names today [22:34:14] Because srsly [22:34:27] Anyway I came to ask if there's a public demo site for OOJS yet [22:34:29] in practice it's nowhere near O(n^2) [22:34:39] Because I'm having trouble building on my machine and it's stupid that I have to [22:34:49] marktraceur: "Building"? [22:34:56] Building OOJs [22:35:01] Er, OOJSUI [22:35:03] with grunt? [22:35:04] marktraceur: You mean `npm build` doesn't work? [22:35:06] Yeah [22:35:17] That's… novel. [22:35:21] It is? [22:35:25] Are you using a Debian-based distro? [22:35:28] It's probably just a permissions error [22:35:29] Yeah, I am [22:35:32] That'd be it. [22:35:40] Debian decided to try to break node. [22:35:41] But I play with fire and run npm with root too [22:35:58] (Package naming conflicts. Yay.) [22:36:06] Also that, yay [22:36:18] Anyway, back to "is there a public HTTP server with demos/ on it yet" [22:36:32] No, we're still waiting for the publication system to work. [22:36:33] I think. [22:36:40] Sighballs [22:36:45] ed_s_MA_Cantab: What does the list of rectangles look like in practice? Cause AIUI your loop checks every rect against every rect [22:36:59] James_F: But you have a working demo directory right now...right? [22:37:09] Can you like, tar that shit up and I'll stick it on marktraceur.info? [22:37:12] marktraceur: Of course. It works fine. [22:37:15] so case 1: a complex template [22:37:39] 3VisualEditor: VisualEditor: Typing diacritics results in stray accent marks at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/66693 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None María typed her name in VisualEditor on a Mac: [SHIFT] m + a + r + [OPTION] e + i + a. She runs Ch... [22:37:51] the first rect will likely contain all the subsequent ones [22:38:07] 3VisualEditor: VisualEditor: Typing diacritics results in stray accent marks at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/66693#c1 (10WhatamIdoing) I can't reproduce this in Safari 6.1.4 on my Mac and haven't tried to reproduce it in Chrome. [22:38:09] so boundRects will only ever have length one [22:38:38] (03PS1) 10Mooeypoo: Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) [22:38:46] case 2: wrapped text [22:38:47] ed_s_MA_Cantab, I semi-stole your bug [22:39:16] marktraceur: E-mail OK? [22:39:23] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, choosing any language from the Language Inspector shows error this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c1 (10ryasmeen) The second error: TypeError: this.debugBar is null appears after selecting an... [22:39:28] Associate of Whatever Areas Y'all want [22:39:33] James_F: Sure [22:39:40] (rare) a couple of non-intersecting rectangles [22:40:26] James_F, btw, I got approval for flights and such a little while ago, but was I supposed to get approval or some record of hotel room for wikimania? [22:40:35]