[00:36:54] hey, any chance i could get 10 minutes of TrevorParscal's time for a core patch? https://gerrit.wikimedia.org/r/#/c/138368/ "Stop using a suboptimal structure for Vector's variants menu" (+the followup) [00:40:39] (03PS1) 10Mooeypoo: Verify there is proper document before returning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140050 [01:56:32] (03PS6) 10Trevor Parscal: [WIP] Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 [01:56:34] (03PS2) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [01:57:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [04:55:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor appears over the toolbar in iPad Mini and Nexus 7 for Mobile VE - 10https://bugzilla.wikimedia.org/65325 (10ryasmeen) [08:07:16] (03CR) 10Esanders: Insert images at the start of paragraphs (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [08:09:17] (03CR) 10Esanders: "The differences are 100ths of pixels so likely not. Just cleaner source code. Don't think it requires Trevor's approval as no real visual " [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders) [08:09:40] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [08:10:17] (03PS2) 10Esanders: Improve equalRange assertion and use in more places [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139364 [08:26:45] (03PS3) 10Esanders: Block item drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139674 (https://bugzilla.wikimedia.org/51666) [08:33:29] (03CR) 10Esanders: [C: 04-1] Use more standard format for displaying keyboard shortcuts (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [10:58:15] does anyone know if TemplateData can take arbitrary params? i.e. [10:59:03] "website": { [10:59:03] "label": "Website title", [10:59:03] "description": "Title of the website; may be wikilinked; will display in italics", [10:59:03] "type": "string", [10:59:03] "aliases": ["work"], [10:59:03] "suggested": true, [10:59:03] "zotero-aliases":["websiteTitle"], } [10:59:21] or would this be something the TemplateExtension would need to be edited to handle? [11:39:22] 3VisualEditor / 3ContentEditable: VisualEditor: It should be clearer to users that they are inserting a media item in an odd place (e.g. into the middle of a word, middle of a paragraph) - 10https://bugzilla.wikimedia.org/51292#c6 (10Ed Sanders) 5ASSI>3RESO/DUP 51666 is the more general bug for relocatin... [11:39:38] 3VisualEditor / 3ContentEditable: VisualEditor: When dragging content, possible places to place content (e.g. a line before the head of a section, or at the end of the page) should appear when the content gets near - 10https://bugzilla.wikimedia.org/51666#c5 (10Ed Sanders) *** Bug 51292 has been marked as a... [11:42:53] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883 (10Ed Sanders) [11:42:53] 3VisualEditor / 3ContentEditable: VisualEditor: When dragging content, possible places to place content (e.g. a line before the head of a section, or at the end of the page) should appear when the content gets near - 10https://bugzilla.wikimedia.org/51666 (10Ed Sanders) [11:42:53] 3VisualEditor / 3ContentEditable: VisualEditor: It should be clearer to users that they are inserting a media item in an odd place (e.g. into the middle of a word, middle of a paragraph) - 10https://bugzilla.wikimedia.org/51292 (10Ed Sanders) [12:26:38] 3VisualEditor: VisalEditor: Dragging selected text from one place to another on the same page results in broken wikitext (external URL, internal link format) - 10https://bugzilla.wikimedia.org/60265#c1 (10Ed Sanders) 5NEW>3RESO/WOR Drag and drop of text does nothing at the moment, can't reproduce. [12:38:09] (03PS1) 10Esanders: Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) [12:38:12] (03CR) 10jenkins-bot: [V: 04-1] Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) (owner: 10Esanders) [12:38:53] (03CR) 10Manybubbles: [C: 031] [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [12:40:22] 3VisualEditor: Can drag and drop non-editable elements from outside the VE surface area - 10https://bugzilla.wikimedia.org/56578#c1 (10Ed Sanders) 5NEW>3RESO/WOR Can't reproduce in FF. [12:40:52] 3VisualEditor / 3ContentEditable: VisualEditor: Show user that drag-and-drop of textual content is not supported - 10https://bugzilla.wikimedia.org/54757#c2 (10Ed Sanders) 5ASSI>3RESO/WON Given we are about to support text drag and drop with bug 49981, marking as wontfix. [12:41:52] 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop requires the item (image/reference/template) to be selected before it can be dragged - 10https://bugzilla.wikimedia.org/51665#c3 (10Ed Sanders) 5ASSI>3RESO/WOR This doesn't appear to be a problem in master. [13:57:55] 3VisualEditor: page remains "editable" after Save - 10https://bugzilla.wikimedia.org/66717 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15672 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15672&action=edit VE editable div remains after Save As a logged in user on beta... [13:59:03] (03PS1) 10Cmcmahon: [BrowserTest] new locator for page content after Save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140120 [13:59:58] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140120 (owner: 10Cmcmahon) [14:01:36] (03Merged) 10jenkins-bot: [BrowserTest] new locator for page content after Save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140120 (owner: 10Cmcmahon) [14:07:37] 3VisualEditor: page remains "editable" after Save - 10https://bugzilla.wikimedia.org/66717 (10Chris McMahon) s:5normal>3major [14:36:21] (03PS2) 10Esanders: Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) [14:37:33] (03CR) 10jenkins-bot: [V: 04-1] Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) (owner: 10Esanders) [14:57:50] Tried to edit a template on https://www.mediawiki.org/wiki/Extension:Gadgets and getting TypeError: title is null; known bug? [15:01:14] AzaToth, is this for the templatedata editor ? [15:01:17] or VE [15:01:37] mooeypoo: Edit template in VE [15:01:51] TypeError: title is null [15:01:51] https://bits.wikimedia.org/static-1.24wmf9/resources/src/mediawiki/mediawiki.Title.js [15:01:51] Line 123 [15:01:52] ah yes I see it [15:02:16] (also the overlay issue you notice) [15:02:22] Interesting, I'm getting "TypeError: Cannot read property 'replace' of null" [15:02:52] I'm not sure if it's a known bug. Can you report it anyways? We can merge, worse case. [15:03:05] k [15:03:14] dunno if I should report both as one [15:03:31] what's the second bug? [15:03:59] if you hover over installation section, it overlays over the infobox [15:04:06] (03PS1) 10Esanders: Remove repositionOnly argument from update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140135 [15:04:12] dunno if it's a VE bug or local CSS/JS [15:06:54] 3VisualEditor: Editing infobox throws TypeError: title is null - 10https://bugzilla.wikimedia.org/66724 (10Carl Fürstenberg) 3NEW p:3Unprio s:3normal a:3None on https://www.mediawiki.org/wiki/Extension:Gadgets and edit throws following error: TypeError: title is null https://bits.wikimedia.org/static-1... [15:20:55] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [15:38:18] (03CR) 10Jforrester: [C: 032] Tidy up SVG sources and fix pixel snapping [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders) [15:38:55] (03Merged) 10jenkins-bot: Tidy up SVG sources and fix pixel snapping [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders) [15:41:59] lovely, copy/paste differernces in IE [15:42:04] why am I susprised. [15:44:39] 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop requires the item (image/reference/template) to be selected before it can be dragged - 10https://bugzilla.wikimedia.org/51665#c4 (10James Forrester) 5RESO/WOR>3RESO/FIX a:3Ed Sanders Specifically, this was fixed by Ed's changes to clickable... [15:45:25] 3VisualEditor / 3ContentEditable: VisualEditor: When dragging content, possible places to place content (e.g. a line before the head of a section, or at the end of the page) should appear when the content gets near - 10https://bugzilla.wikimedia.org/51666 (10James Forrester) a:3Ed Sanders [15:45:27] edsanders, "In IE 11, document.selection is gone and insertHTML is still not supported" :\ [15:50:09] 3VisualEditor / 3ContentEditable: VisalEditor: Dragging selected text from one place to another on the same page results in broken wikitext (external URL, internal link format) - 10https://bugzilla.wikimedia.org/60265 (10James Forrester) a:3Ed Sanders [16:06:28] (03CR) 10Jforrester: "LGTM except for the commit message." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [16:11:55] mooeypoo, where do we use document.selection? [16:14:05] edsanders, in the tests. I'm trying to find an alternative but it seems to be annoyingly complicated for IE11 [16:14:59] edsanders, we also have "document.execCommand( 'insertHTML', false, pasteHtml );" which is another IE issue. [16:15:14] it's in ve.ce.Surface.test.js line #809 in core tests [16:17:01] if the tests don't pass it's not the end of the world [16:17:05] *run [16:17:28] hm, I guess not. [16:17:53] I was hoping it had a simple solution, but it seems to be a bit elaborate. I'll move on to the next test. [16:21:54] hi ryasmeen this turned up today: https://bugzilla.wikimedia.org/show_bug.cgi?id=66717 there are probably related problems after saving an edit today [16:28:03] James_F: can haz ooui-demo.tar.gz? :) [16:28:12] marktraceur: Did you not get it? [16:28:19] Hm, no [16:28:20] I think [16:28:36] No [16:28:46] mtraceur@wikimedia.org is no good ;) [16:32:33] James_F: OK, I see it on the remote now. Thanks :) [16:32:54] marktraceur: I found that it was a draft, sorry. :-) [16:33:02] Aha [16:33:18] God *damn* riseup is slow today [16:45:44] James_F: Did you give me a tarball with no top level directory [16:45:59] * marktraceur prays to the UNIX gods to forgive your soul [16:46:27] Oh, wait, no [16:47:17] I see. [16:52:07] James_F: http://marktraceur.info/oojs-demo/widgets_apex.html [16:54:22] James_F: Can TemplateData can take arbitrary params? i.e. "website": {"label": "Website title","description": "Title of the website; may be wikilinked; will display in italics","type": "string","aliases": ["work"],"suggested": true, "zotero-aliases":["websiteTitle"], "my-arbitrary-param-here":"so arbitrary" } [16:56:07] mvolz: Ish. [16:56:10] marktraceur: :-P [16:56:30] marktraceur: Also, woo. [16:56:46] Now that I think about it, I could have tried building the library on caine-the-longshot (i.e. marktraceur.info) [16:56:46] mvolz: TemplateData whitelists parameters, but we can extend it if needed. [16:56:52] But meh [16:59:14] ok, so this means I'll need to add "citoid-aliases" to the whitelist to access it via the api? (I'd like to have it point to a list like aliases) [17:07:02] (03PS2) 10Alex Monk: Media search dialog: Only try to abort request if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) [17:11:56] mooeypoo, on top of my code review I think you could remove a lot of the DM node code from the image model [17:13:22] after https://gerrit.wikimedia.org/r/#/c/137040/ the surface fragment ranges should adjust correctly [17:15:13] (03PS2) 10Catrope: [WIP] Verify there is proper document before returning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140050 (owner: 10Mooeypoo) [17:16:35] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/140135/1 ? It's trivial but I want to check that it isn't a bad idea [17:17:55] k [17:18:05] (03CR) 10Esanders: [C: 032] Followup 00af434: only tear down debug bar if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140039 (https://bugzilla.wikimedia.org/66692) (owner: 10Catrope) [17:19:39] (03Merged) 10jenkins-bot: Followup 00af434: only tear down debug bar if it exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140039 (https://bugzilla.wikimedia.org/66692) (owner: 10Catrope) [17:19:44] (03CR) 10Trevor Parscal: [C: 032] Remove repositionOnly argument from update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140135 (owner: 10Esanders) [17:19:56] RoanKattouw: lgtm [17:20:06] Awesome thanks [17:20:10] And thanks edsanders [17:20:40] also, fyi, we will be moving away from hide/show methods and using toggleVisibility instead soon [17:20:54] What is that? [17:21:05] (03Merged) 10jenkins-bot: Remove repositionOnly argument from update [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140135 (owner: 10Esanders) [17:21:05] css visibility? [17:21:36] yeah, well widgets will have this, and in some cases it will be overridden with additional logic [17:22:02] I also think the boolean transition flag is evil and the context will need to be cleaned up to no longer need it [17:22:13] edsanders, what do you mean the dm node code? the model and node are mostly separate, except for the node creation and attribute changes [17:22:17] but anyway, just see the code when it's in (soon) [17:22:29] mooeypoo, anywhere we use selectNodes [17:22:50] oh [17:22:54] or indirectly through fragment.getNodes [17:23:11] we're building new linmod, it shouldn't be necessary [17:23:22] edsanders, I'm using it when inserting the caption [17:24:02] It doesn't work to insert the caption manually, so finding the right node and then where to insert to seemed the best solution [17:24:57] you need a separate transaction [17:25:02] but you don't need DM nodes to find the range [17:25:20] the caption is always the first child [17:25:30] *and only [17:25:34] we make that assumption elsewhere [17:25:57] Hmmm, I see what you mean [17:26:35] it always goes at imageFragment.getRange().start + 2 [17:27:14] we also get the type of the node from the DM node, but we already know it, we've just created the linmod [17:28:04] Hm. [17:28:15] edsanders, good point [17:28:23] (03CR) 10Jforrester: [C: 032] Media search dialog: Only try to abort request if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [17:28:51] you should also look at the MW follow up https://gerrit.wikimedia.org/r/#/c/139824/ [17:29:08] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604 (10James Forrester) 5PATC>3RESO/FIX [17:29:36] dialogs call this.fragment.select(), so anywhere in your code you create a new fragment (by use a SF method which returns a clone) you need to make sure that dialog.fragment gets updated [17:29:57] (03Merged) 10jenkins-bot: Media search dialog: Only try to abort request if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [17:41:51] mooeypoo, you should also be able to do updateImageNode with that assumption as well (that block image contains nothing, or a single caption) [17:42:47] and if you're still stuck for bugs you could work out how to unit test the image model [18:12:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, choosing any language from the Language Inspector shows error this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c4 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High a:3Roa... [18:21:24] (03PS12) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [18:32:09] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, choosing any language from the Language Inspector shows error this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c5 (10ryasmeen) Sorry, the language inspector throwing "TypeError:sel.... [18:33:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, choosing any language from the Language Inspector shows error this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c6 (10James Forrester) (In reply to ryasmeen from comment #5) > Sorry,... [18:34:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, choosing any language from the Language Inspector shows error this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c7 (10ryasmeen) Verified the fix in Betalabs [18:35:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, Saving the edit on a page everytime throws error: this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692 (10ryasmeen) [18:35:42] (03PS1) 10Esanders: Fix MW tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 [18:37:28] (03CR) 10jenkins-bot: [V: 04-1] Fix MW tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 (owner: 10Esanders) [18:41:05] (03PS2) 10Esanders: Fix MW tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 [18:42:43] (03CR) 10jenkins-bot: [V: 04-1] Fix MW tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 (owner: 10Esanders) [18:45:40] 3VisualEditor / 3Editing Tools: VisualEditor:In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15674 --> https://bugzilla.wikimedia.org/att... [18:46:29] edsanders, I have a problem switching to linmod in the 'insertImageNode' in the model. After I insert the image, the fragment includes a much larger chunk of data -- namely, 'paragraph', 's','t','u','f','f', '/paragraph','paragraph','mwInlineImage','/paragraph' ... etc etc. So, I need to only take the chunk of the mwInlineImage, which is why I do the whole 'getCoveredNodes' and the while loop checking types. [18:47:05] are you basing off the getTranslatedOffset fix? [18:47:28] oh, I did not. I'll do that now. [18:47:47] " after https://gerrit.wikimedia.org/r/#/c/137040/ the surface fragment ranges should adjust correctly" [18:47:55] I missed that one [18:47:58] * moo|food nods [18:48:00] rebasing now [18:48:01] " you should also look at the MW follow up https://gerrit.wikimedia.org/r/#/c/139824/" [18:48:12] well the first one is in core [18:48:33] oh, ha [18:48:35] the other one also makes sure you collapse the range to the end before inserting [18:48:48] * mooeypoo nods [18:48:49] sounds like you have that problem too [18:49:05] before the core fix you would have got [/p, image, /image, p] [18:49:35] *but* if you change the fragment, you must pass it back to dialog.fragment somehow [18:49:49] as we call this.fragment.select() on dialog close [18:50:36] Well, in this case I don't necessarily want to collapse the range to the end, but i do need to get the offset of the 'mwImageCaption','/mwImageCaption' inside a 'mwBlockImage' [18:51:05] my MW fix makes that behaviour consistent (collapse to end) [18:51:31] so you should do that to [18:51:46] there's another problem with not collapsing to end and using select nodes [18:51:58] yeah, I should probably rebase my 'insert image at beginning of paragraph' off that one too [18:52:11] if you had another image selected when you fired up the insert dialog, your resulting selection would contain two images [18:52:23] and selectNodes would give you the wrong one [18:52:40] you could probably verify that as a bug in master [18:52:52] Hey, I'm having the same issue as https://bugzilla.wikimedia.org/show_bug.cgi?id=64822 [18:53:17] The rest of posts after the first one are a bit beyond me at the moment [18:53:26] It should be fine to follow the work around given, right? [18:58:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders [19:00:23] edsanders, VE doesn't load for me when I pull 137040 [19:00:35] O.o [19:00:36] git submodule update? [19:01:04] doesn't that update the pointer so it's not in that review patch anymore in the submodule? [19:01:21] oh that's a core patch [19:01:52] meh. maybe it needs rebasing [19:02:19] done [19:02:20] (03PS9) 10Esanders: [BREAKING CHANGE (ish)] Track original data position in insertion operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) [19:04:06] edsanders, woot, now it works, thanks! [19:05:53] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c4 (10ryan.glasnapp) I ran into the same problem myself my private wiki (1.23 and the REL1_23 branch of VE) What are the securi... [19:08:39] 3VisualEditor: VisualEditor: Please strip trailing spaces and returns from media or image captions - 10https://bugzilla.wikimedia.org/66736 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None The solution for this may be related to Bug 61049: If you add a caption to an image, and you press return in th... [19:13:09] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10WhatamIdoing) [19:13:09] 3VisualEditor: VisualEditor: Please strip trailing spaces and returns from media or image captions - 10https://bugzilla.wikimedia.org/66736 (10WhatamIdoing) [19:29:43] (03PS1) 10Mooeypoo: Use linear model instead of getNode() in MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140183 [19:32:38] 3VisualEditor: VisualEditor: Please strip trailing spaces and returns from media or image captions - 10https://bugzilla.wikimedia.org/66736#c1 (10Ed Sanders) The same is true for the main document, but I'd rather issue warnings than do automatic document modification (cf. typing wikitext into VE) [19:36:38] (03CR) 10Krinkle: "Well, the difference is that the global is not a registry. It's a singleton cache basically. mw.targets on the other hand is an array. We " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [19:39:42] (03CR) 10Esanders: "Yes, it's just a singleton at the moment. A future commit to allow for multiple targets would have to fix that (and a whole bunch of other" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [19:41:14] (03PS13) 10Esanders: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 [19:47:58] (03CR) 10Esanders: [C: 032] Insert inline image inside list to the existing paragraph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139269 (https://bugzilla.wikimedia.org/65924) (owner: 10Mooeypoo) [19:49:38] (03Merged) 10jenkins-bot: Insert inline image inside list to the existing paragraph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139269 (https://bugzilla.wikimedia.org/65924) (owner: 10Mooeypoo) [19:52:14] hm. edsanders I'm thinking of starting to work on the caption tech debt without waiting for the new design -- but I am not sure if that will fix the entire issue [19:52:41] what issue? [19:52:48] (s) [19:56:21] edsanders, preserving the caption data in parsoid for wikitext. I'm discussing it with cscott now, though. [19:59:34] edsanders, see #mediawiki-parsoid [20:00:44] edsanders, we have to keep
for floated images so the data is preserved for Parsoid. We should hide them in CSS based on type. I *do* need to keep the caption data in the model, but that won't affect the fact we need
[20:06:38] 3VisualEditor / 3Editing Tools: VisualEditor: Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924 (10James Forrester) 5PATC>3RESO/FIX [20:46:10] (bringing the descussion back here.) edsanders, *initially* we're not rendering a figcaption unless a caption exists. The main issue is what to do after the user edits, especially if a caption *does* exist already. [20:49:43] So for Parsoid HTML it seems unavoidable [20:49:56] but for CE HTML it's a waste of time for us to render it, so just ignore it [20:50:50] obviously we're keeping {'type':'figcaption'} in the DM, but there's no need to put it in the CE dom [20:52:48] edsanders, but we'll need to send it to Parsoid with the
at the end [20:52:58] oh, I see what you mean here. [20:53:03] yup, but that's DM html [20:53:06] * mooeypoo nods [20:53:11] I realized as I typed [20:53:42] edsanders: afaik you already have the code to render the figcaption [20:53:49] so it might just avoid a special case [20:55:26] edsanders, so you mean not to render
in CE if the caption is either empty or hidden when we rebuild the image? This is of course doable, but it will mean a more complex conditions and insertions/deletions even when we "just" change image attributes. [20:56:45] that's true [20:56:47] so, right now the image model works with either change attributes or completely create a new image. Creating a new image is only done if we change from inline to block or vise versa (and in that case, the figcaption can be conditional on whether it is empty) -- the changing attributes, though, is the trickier part. It happens when the user changes image properties or floated types -- like thumb to frameless|left [20:57:29] so we'll have to add a bunch of rules and deletions/insertions for these cases if we want to not render figcaption in CE there. It's doable, I'm just not sure it is better than just leaving the node in [20:57:31] surely when we change from thumb to frameless, we are doing some significant CE changes? [20:57:41] not if the framless is floated, no [20:58:01] We just change the image type and classes. There's not a lot of changes needed for that case. [20:58:03] if it's easier to leave it in there then maybe that's the best way [20:58:47] floated images are basically all the same, except for their image type (mwImage/foo) and their classes. [21:24:24] James_F: currently working on a mini grunt plugin to assert opening a page in a browser (phantomjs) throws no exceptions [21:24:25] for the demos [21:37:08] Krenair: Nice! [21:37:10] Bah. [21:37:12] Krinkle: Nice! [21:49:47] edsanders: Hmm, so you're changing the definition of getModifiedRange()... [21:50:16] that's one way of seeing it [21:50:23] Now it gets the range spanning modifications the user intended to make, rather than the range spanning modifications that were actually made [21:50:40] It seems reasonable to me because the former is arguably more useful [21:50:51] But I think we should probably clarify this in the docs [21:51:39] sure, I didn't read the docs, but I can't think of when you'd want the former [21:51:56] Sorry, I meant [21:52:03] The way you did it is more useful [21:52:09] The way I had it is less useful [21:52:15] But the docs still say "all modifications" [21:52:54] sure [21:52:56] I understood [21:53:03] in fact it's only used by SF.insertContent [21:53:34] maybe we should rename it to getInsertedRange? [21:54:18] (03CR) 10Catrope: [C: 04-1] "Code looks fine, just arguing semantics :) and tests" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) (owner: 10Esanders) [21:54:34] Yeah that seems sensible [21:58:53] James_F: Is it just me or is it really weird to use expression 'well hung' to describe a localisation message file? [21:58:56] https://github.com/Krinkle/intuition/pull/28 [22:00:32] edsanders: Are you suggesting we have separate functions for both things? [22:08:25] Hello. I'm trying to figure out why the following wikitext makes the file thumbnail uneditable within VE: [22:08:29] '''some text[[File:image.jpg|thumb]]more text''' [22:08:40] And is that a feature or a bug? [22:10:00] (03CR) 10Catrope: [C: 04-1] Fix selection after inserting nodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) (owner: 10Esanders) [22:10:15] mattk_: Hmm let me take a look at that [22:11:48] Thanks [22:11:51] mattk_: Grr, it's a Parsoid bug [22:12:17] Is there an open ticket for it? [22:12:24] The HTML that Parsoid gives us for that is some text
...
more text [22:12:38] Problem is,
isn't something you're allowed to have inside of a [22:12:38] No, there's not [22:12:39] We didn't know about this yet [22:12:41] I'll file one [22:13:02] OK [22:13:05] Although I do remember an issue with images inside of that was reported a while ago and has allegedly been fixed [22:13:31] Oh that was the reverse [22:14:06] Someone was trying to do [[File:image.jpg|thumb]] and Parsoid was doing something like text
....
More text [22:14:08] which is very wrong [22:14:14] But what they're doing here is also wrong [22:15:02] Hmm should the parser end the text formatting tag before the figure and start it again after? [22:15:19] Yeah it should [22:15:27] I'm writing a bug report [22:15:43] mattk_: How would you like me to credit you? [22:15:48] RoanKattouw, no, just a rename [22:16:13] RoanKattouw: we were actually following the HTML5 spec [22:16:32] we've since tweaked it to elide the small inside the figure [22:16:41] it'll be pushed into the figcaption instead [22:16:47] which is what we want [22:19:52] gwicke: Awesome, yeah that sounds better [22:19:58] I'm filing a bug about something different [22:20:02] Where an entire
is bolded [22:20:15] edsanders: OK that's also fine [22:21:01] RoanKattouw: yeah that's the case I was talking about [22:21:21] [[file:foo...]] [22:21:26] Yeah [22:21:36] So what I get from that is foo
bar [22:21:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=66749 [22:21:45] will be handled as described above for small [22:21:53] Right [22:22:53] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c4 (10ryasmeen) Verified the fix in Betalabs [22:22:54] Actually no that's not true [22:23:14] Even foo[[File:Image.jpg|thumb|Some caption]]bar doesn't push the down into the caption [22:23:31] You just get foo
Some caption
bar [22:24:05] yeah, maybe I we only do the elision [22:24:14] s/I// [22:24:16] RoanKattouw: OK, thanks for opening the bugzilla issue [22:24:17] Oh, hah [22:24:22] gwicke: No it's only if you're in a

[22:24:32] If I wrap it in

...

it works fine [22:24:45] I suspect that if I insert newlines to force

tags to appear, it'll also work right [22:25:11] the

case is actually broken for me [22:25:18] It's just when it's doing plain text outside of a

that it's broken [22:25:25] I see a tag wrapping the figcaption [22:25:44] Oh, yes you're right [22:25:58] By definition of "not broken" was too narrow apparently [22:26:03] *My [22:26:12] It's just broken in a different way, one that'll freak out VE even worse [22:26:20] either this is not yet merged, or the fix wasn't very good [22:27:01] Putting

inside of is naughty but we deal with it (block inside of inline --> alienate). Putting anything that's not an , or
inside of
is a Parsoid spec violation which we just assume won't happen [22:27:24] RoanKattouw: Hm.. could you look at https://gerrit.wikimedia.org/r/#/c/74400/ again and determine what needs to be done? It was hard to reproduce once, I think you're one of few left who still know what's up [22:27:25] yup [22:27:51] Krinkle: oooh that one [22:27:53] It's made it to be on the bottom entry on my dashboard [22:27:59] It made it* [22:28:12] It made it to the bottom of my dashboard. [22:28:15] anyway [22:28:25] It made it the bottom of my dashboard. [22:28:26] even [22:28:32] it made the bottom of my dashboard. [22:28:33] ha [22:28:36] Aaron made a good poit [22:28:49] But I need to get back into this thing to figure out how to address it [22:30:51] Hm. OK [22:51:39] 3VisualEditor / 3Mobile: VisualEditor Mobile:Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66753 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15678 --> https://bugzilla.wikimedi... [22:59:09] (03CR) 10Catrope: "Looks good except for inline comment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) (owner: 10Esanders) [22:59:19] (03CR) 10Catrope: [C: 031] Use linear model instead of getNode() in MWImageModel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140183 (owner: 10Mooeypoo) [23:16:26] (03PS1) 10Catrope: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 [23:17:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [23:17:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66754 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15679 --> https://bugzilla.wikimedia.org/attachme... [23:17:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with mobile VE 2.Tap at the end of... [23:19:02] (03PS3) 10Catrope: Update VE core submodule to master (4c599b0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 (owner: 10Esanders) [23:19:49] (03PS2) 10Catrope: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 [23:23:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4c599b0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 (owner: 10Esanders) [23:24:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (4c599b0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140171 (owner: 10Esanders) [23:25:26] (03CR) 10Catrope: [C: 032] Remove display:inline-block highlight hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139806 (https://bugzilla.wikimedia.org/51708) (owner: 10Esanders) [23:25:40] (03CR) 10Catrope: [C: 031] Fix test to include new insertion operation properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139365 (owner: 10Esanders) [23:27:11] (03Merged) 10jenkins-bot: Remove display:inline-block highlight hacks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139806 (https://bugzilla.wikimedia.org/51708) (owner: 10Esanders) [23:27:52] 3VisualEditor / 3ContentEditable: VisualEditor: Inline templates don't wrap, assume width:100%, so break layout around floated items - 10https://bugzilla.wikimedia.org/51708 (10James Forrester) 5PATC>3RESO/FIX [23:30:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open any page with Mobile VE in Nexus 7(Android 4.4.2) 2.Type a text 3.Save the page... [23:53:51] (03CR) 10Catrope: [C: 032] Improve equalRange assertion and use in more places [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139364 (owner: 10Esanders) [23:55:01] (03Merged) 10jenkins-bot: Improve equalRange assertion and use in more places [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139364 (owner: 10Esanders)