[00:03:20] (03CR) 10Catrope: [C: 032] Block item drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139674 (https://bugzilla.wikimedia.org/51666) (owner: 10Esanders) [00:04:30] (03Merged) 10jenkins-bot: Block item drag and drop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139674 (https://bugzilla.wikimedia.org/51666) (owner: 10Esanders) [00:04:39] 3VisualEditor / 3Mobile: VisualEditor: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobile VE 2.Type a text 3.Tap on... [00:16:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10ryasmeen) [00:27:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: For the first time in each edit session in Nexus 7(Android 4.4.2), Link Inspector gets auto-zoomed in,which looks like partial rendering of the UI - 10https://bugzilla.wikimedia.org/66759 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15... [00:33:06] (03PS3) 10Catrope: Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) (owner: 10Esanders) [00:46:24] (03CR) 10Catrope: [C: 032] Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) (owner: 10Esanders) [00:47:37] (03Merged) 10jenkins-bot: Drag and drop of arbitrary selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140103 (https://bugzilla.wikimedia.org/49981) (owner: 10Esanders) [01:05:13] RoanKattouw, you still around? I'm trying to figure out how to add data so that it will translate into Parsoid in data-mw [01:05:16] (03CR) 10Catrope: [C: 032] Test cases for annotating handles own children nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140040 (owner: 10Esanders) [01:05:24] mooeypoo: Yeah I'm here [01:05:28] What are you trying to do exactly [01:05:30] ? [01:06:40] RoanKattouw, I'm working on making Captions a bit better, so, storing them in the nodes as attributes for better consistency on top of the

-- but more importantly, I want to make sure the data of the caption stays (if it existed before) even if the user converts the image to inline or to an image that doesn't support Caption, so it reflects in the wikitext. [01:06:56] According to the Parsoid team, inline images' captions are kept in the data-mw field [01:07:14] (03Merged) 10jenkins-bot: Test cases for annotating handles own children nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140040 (owner: 10Esanders) [01:07:15] so.. I'll store them in the node -- but how do I make sure that when we convert the dm to parsoid html, that data goes into the data-mw ? [01:08:29] That actually raises a second question but that's more UX-related. Do I keep captions in inline images that already existed before, or should I also updated them if they were updated? I can give an example case if that's confusing. [01:14:49] OK, so [01:14:58] I think we should retain captions always [01:15:20] Ed and I talked about a technology we could use for this called subdocuments [01:15:55] Right now, we have reference contents in internal items, and caption contents inside the image using handlesOwnChildren stuff [01:16:02] Instead, we could use subdocuments for both uses [01:16:18] Then, you could have a caption be associated with either a block image or an inline image and it would work equally well [01:16:34] and you'd only have to worry about how to represent it in HTML when you're rendering and when you're sending things to Parsoid [01:16:37] Am I making sense so far? [01:17:21] (03PS2) 10Catrope: Defer focusableNode selection fix until after native selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139679 (https://bugzilla.wikimedia.org/66638) (owner: 10Esanders) [01:17:34] (03CR) 10Catrope: [C: 032] Defer focusableNode selection fix until after native selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139679 (https://bugzilla.wikimedia.org/66638) (owner: 10Esanders) [01:19:20] (03Merged) 10jenkins-bot: Defer focusableNode selection fix until after native selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139679 (https://bugzilla.wikimedia.org/66638) (owner: 10Esanders) [01:19:51] (03CR) 10Catrope: [C: 032] Accessibility: Set role=dialog on dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/139039 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [01:20:26] (03Merged) 10jenkins-bot: Accessibility: Set role=dialog on dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/139039 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [01:21:50] hmmmm [01:22:47] RoanKattouw, yes, you're making perfect sense. We had a long discussion about whether we should render

for block images that don't support captions (like frameless|left or such) but the trouble really comes with retaining data with inline images that have no caption at all. [01:22:56] that makes sense, the sub documents. [01:24:38] (03CR) 10Krinkle: "I don't think you understood the bug nor verified that this fixed anything." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [01:24:44] (03CR) 10Krinkle: "See bug" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [01:25:20] Yeah, OK [01:25:20] So the problem with this is that it's vaporware [01:25:27] We don't have subdocuments yet [01:25:30] I can ask Ed to work on that next [01:25:40] (03PS1) 10Krinkle: Revert "Media search dialog: Only try to abort request if possible" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140266 [01:26:34] But once they exist they'll be a nice place for you to stash captions [01:26:38] As for the data-mw thing [01:27:12] In the toDataElement and toDomElements functions for mwInlineImage, we'd have to do decode/encode that data-mw format [01:27:27] * mooeypoo nods [01:27:57] okay, should I "fake it" ? As in, I can retain the captin in wikitext format in raw plaintext and then spit it out to data-mw [01:28:05] For presentation we're using the

anyways [01:28:12] You mean for now? [01:28:34] yeah. But it will be a bit of work, the question is -- should I do that as a sort of hacky way for now, or just wait. It's not urgent. [01:28:43] I'd say wait for subdocuments to come [01:28:48] * mooeypoo nods [01:28:51] OK [01:28:53] You could also try to make it use internal items while subdocuments don't exist [01:29:08] I don't know how practical it is to use internal items for things that aren't references, Ed can help you with that [01:29:38] But for an idea of what we'd do for inline images, look at MWReferenceNode [01:29:52] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c13 (10Krinkle) 5RESO/FIX>3REOP That patch, as far as I can see, did nothing. And if it did, it would actually have ca... [01:29:57] We take mwData.body.html and throw it into converter.internalList.queueItemHtml [01:30:08] hmmm [01:30:27] Actually it looks like you should be able to do the same thing that references are doing, and if you use a prefix that isn't 'mwReference/' then everything should be fine (should) [01:30:51] I'll talk to ed about this tomorrow. If subdocuments are a-coming, then maybe I shouldn't waste time on this? (I could, but I don't want to split in a different direction than what you intended) [01:30:56] Well [01:31:02] RoanKattouw: Can you merge that revert? [01:31:06] We've talked about them, but we haven't talked about when [01:31:06] it might actually be worse than waiting, if it takes things to a completely different direction. [01:31:08] Krinkle: Sure [01:31:08] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c14 (10Krinkle) 5REOP>3RESO/WON As such, please don't waste any more time on this. This is harmless errors that we can... [01:31:41] If you could try doing it with internal items, doing the same thing that references do but with a different prefix to keep them out of each other's hair, then that can easily be ported to subdocuments later [01:31:52] My only concern is that the prefixing keeping them apart might not actually work well [01:32:14] If that turns out to be a problem, then it may or may not be worth to fix these problems in code we want to get rid of in the long term anyway [01:32:30] * mooeypoo nods [01:32:34] okay, I'll take a look at that, then. [01:33:14] MWReferenceModel#toDataElement is pretty much a model for what you'll need to do, minus some group name complexity [01:34:11] MWReferenceModel#toDomElements is mind-bogglingly complex and isn't a model for what you'll need to do, it'll be much easier [01:34:17] (03PS2) 10Krinkle: Revert "Media search dialog: Only try to abort request if possible" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140266 [01:34:39] (03CR) 10Catrope: [C: 032] Revert "Media search dialog: Only try to abort request if possible" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140266 (owner: 10Krinkle) [01:35:55] If you have questions about any of this code, you can ask me or Ed. Ed wrote almost all of this code [01:36:19] (03Merged) 10jenkins-bot: Revert "Media search dialog: Only try to abort request if possible" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140266 (owner: 10Krinkle) [01:38:38] 3VisualEditor / 3ContentEditable: VisualEditor: Keyboard events not detected after selecting a focusable node with the mouse - 10https://bugzilla.wikimedia.org/66638 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3major [01:38:38] 3VisualEditor / 3ContentEditable: VisualEditor: Keyboard events not detected after selecting a focusable node with the mouse - 10https://bugzilla.wikimedia.org/66638 (10James Forrester) [01:40:03] RoanKattouw, is this ve.dm.MWReferenceModel ? [01:40:27] I can't see toDataElement in there [01:41:01] Sorry [01:41:05] MWReference*Node* [01:41:09] My bad [01:41:22] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c15 (10Krinkle) Also: * Upstream jQuery: http://bugs.jquery.com/ticket/8744 (status: cantfix) * Closely related upstream F... [01:41:31] Thx [01:42:02] ah! thanks RoanKattouw [01:43:26] (03CR) 10Catrope: [C: 032] Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [01:44:09] 3VisualEditor / 3ContentEditable: VisualEditor: Drag-and-drop of content (text, transclusions, references, …) to move it - 10https://bugzilla.wikimedia.org/49981 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [01:44:58] (03CR) 10Catrope: [C: 04-1] "See also Ed's comments" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [01:45:02] (03Merged) 10jenkins-bot: Use registered target, instead of ve.init.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135013 (owner: 10Esanders) [01:47:23] RoanKattouw: You going to do a VE core pull-through in the next few minutes? Should I? [01:47:52] (03PS1) 10Catrope: Update VE core submodule to master (52dc4e8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140270 [01:47:56] James_F: Thanks for the reminder :) [01:47:57] Ha. :-) [01:48:07] RoanKattouw: That looks sane? [01:48:13] LGTM [01:48:17] Ed's drag and drop stuff is pretty cool [01:48:32] (03CR) 10Jforrester: [C: 032] "Because I am, if nothing else, Roan's minion." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140270 (owner: 10Catrope) [01:48:46] RoanKattouw: One of the reasons I'm keen to get it into Beta so we can test it. :-) [01:50:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (52dc4e8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140270 (owner: 10Catrope) [01:51:52] (03CR) 10Catrope: Add a clean-up script for use as a pre-commit hook (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [01:54:20] RoanKattouw: Bah, yeah, that's the wrong way around; I always second-guess myself with ln and get it wrong. [01:54:28] No, it's not [01:54:31] RoanKattouw: And on the interactive rebase, probably, and I don't know. [01:54:33] It is ln TARFGET LINKNAME [01:54:37] That part is right [01:54:39] *TARGET [01:54:53] Oh, so it's right? [01:54:55] * James_F sighs. [01:54:59] But TARGET is resolved relative to $(dirname LINKNAME) [01:55:00] Apparently we both get confused. :-) [01:55:12] Not relative to whatever the current directory of the creator of the link happens to be [01:55:19] Oh. Really? [01:55:25] That's… impressively unhelpful. [01:56:04] (03PS2) 10Mooeypoo: Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) [01:56:19] Yeah I tested it and that is in fact how it works [01:56:39] * James_F grumbles. [01:56:45] Anyway. [01:56:50] ln gives you full control over the exact string that gets written into the symlink, which is annoying in most cases [01:56:52] Did you test the use of the script in a rebase? [01:57:00] I haven't yet [01:57:14] Could you? You're the only person that does that, after all. :-) [01:57:23] (03CR) 10jenkins-bot: [V: 04-1] Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [02:01:47] err VE doesn't load for me with https://gerrit.wikimedia.org/r/#/c/137040/ again [02:04:58] (03CR) 10Catrope: [C: 04-1] Port MWSaveDialog to use ActionDialog (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk) [02:05:57] err [02:06:41] RoanKattouw, VE doesn't load (there's /* internal error */ in load.php?..) when I pull my commit https://gerrit.wikimedia.org/r/140037 which I just rebased on top of Ed's [02:06:47] .... meh? [02:07:26] He says his commit functionally depends on an unmerged commit in VE core [02:07:40] So you could try cd lib/ve; git review -d 137040 [02:08:07] aye I have it [02:08:10] hm. [02:08:24] RoanKattouw, I think it's a problem with my commit. If I only have his in core, VE loads [02:08:32] the second I bring mine up in ve-mw VE doesn't load [02:08:33] Hm [02:08:44] meh [02:09:16] Ahm [02:09:23] Do you realize you have a syntax error in there? [02:09:36] There are two separate places where you do insertContent( [ [02:09:41] But only one where you close that ] ) [02:09:42] oh, foo, bad rebsase. [02:09:47] rebase. [02:09:54] didn't notice. pff. [02:10:09] I'm changing this anyways [02:11:07] RoanKattouw, I fixed it and it still doesn't load. No errors, either. Wouldn't this have brought up errors?? [02:12:21] Maybe [02:12:30] Do you see any load.php responses with errors in a top comment? [02:12:54] (03PS3) 10Mooeypoo: Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) [02:12:54] RoanKattouw, yes, the all helpful "/* Internal error */" [02:13:11] RoanKattouw, here's the fixed code, which I can't test because VE doesn't load. At least no typos here (I hope) [02:13:21] (03CR) 10Catrope: [C: 032] Add more authors from `git shortlog -s -n` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137951 (owner: 10Amire80) [02:14:19] eh. [02:14:35] (03CR) 10jenkins-bot: [V: 04-1] Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [02:15:00] (03Merged) 10jenkins-bot: Add more authors from `git shortlog -s -n` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137951 (owner: 10Amire80) [02:15:22] RoanKattouw, if I go 'git submodule update' it loads. But I need ed's core fix, so when I go into lib/ve and review it again it doesn't work. Something with the combination of both? Does that even make sense? [02:15:30] (03CR) 10Catrope: [C: 04-1] Insert images at the start of paragraphs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [02:16:05] (03CR) 10Catrope: Insert images at the start of paragraphs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [02:16:40] mooeypoo: Oh maybe you need to take Ed's core fix and run git fetch; git rebase origin/master [02:16:54] Also, see my -1 comments for why your code broken for other reasons [02:16:57] +is [02:16:57] let me try that [02:17:08] aye, I didn't even start reviewing it, since VE doesn't load. It's blind-code. [02:17:32] but wait, git fetch/ etc in core, or to my patch after I already have ed's patch in core? [02:17:52] cd lib/ve; git review -d edspatch; git fetch; git rebase origin/master [02:18:04] uh oh, conflicts. [02:18:10] There you go [02:18:15] I can fix them if you like [02:19:07] Ugh I see the conflict [02:19:17] It's an annoying one, I have to go read both conflicting commits [02:19:44] I just checked to follow up on what ed did [02:19:50] I.. think I corrected the conflict [02:20:24] (03PS10) 10Catrope: [BREAKING CHANGE (ish)] Track original data position in insertion operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) (owner: 10Esanders) [02:20:33] There that has the conflict fixed [02:20:35] oh! ha, I was going to. [02:20:46] * mooeypoo had her finger on the 'enter' key [02:20:50] you beat me to it :D [02:20:51] :) [02:21:35] RoanKattouw, still not loading :( [02:21:52] (03CR) 10Catrope: [C: 032] Update displaytitle on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139205 (https://bugzilla.wikimedia.org/50341) (owner: 10Alex Monk) [02:22:14] (03CR) 10Catrope: "Is this still "don't merge"?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) (owner: 10Alex Monk) [02:22:45] what the.. [02:22:47] (03CR) 10Catrope: [C: 032] Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [02:23:30] (03Merged) 10jenkins-bot: Update displaytitle on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139205 (https://bugzilla.wikimedia.org/50341) (owner: 10Alex Monk) [02:32:12] (03CR) 10Catrope: [C: 032] Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [02:32:51] (03Merged) 10jenkins-bot: Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [02:38:37] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c11 (10James Forrester) 5PATC>3ASSI Is there anything further outstanding here? [02:39:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341 (10James Forrester) 5PATC>3RESO/FIX [02:41:25] (03PS5) 10Jforrester: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 [02:42:02] (03CR) 10Jforrester: Add a clean-up script for use as a pre-commit hook (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester) [02:57:07] 3VisualEditor / 3Data Model: VisualEditor: Getting "Error: Inserted data is trying to close the root node (at index 0)" while trying to go the next line after inserting a Hiero in Firefox - 10https://bugzilla.wikimedia.org/66691 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [02:57:54] 3VisualEditor / 3ContentEditable: VisualEditor: Selection highlighting breaks if an inline alien wraps - 10https://bugzilla.wikimedia.org/52339 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [02:58:52] 3VisualEditor / 3Technical Debt: VisualEditor: Image CE HTML should match Parsoid - 10https://bugzilla.wikimedia.org/66610 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc [02:59:24] 3VisualEditor / 3ContentEditable: VisualEditor: Replacing a selected template with a keyboard press creates a pawn (♙) - 10https://bugzilla.wikimedia.org/52185 (10James Forrester) 5ASSI>3RESO/FIX a:5David Chan>3Ed Sanders [03:00:53] 3VisualEditor / 3ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681 (10James Forrester) [03:00:54] 3VisualEditor / 3Data Model: VisualEditor: Deleting a paragraph separator and subsequently typing any character messes up the page - 10https://bugzilla.wikimedia.org/64128 (10James Forrester) 5RESO/WOR>3RESO/FIX a:3Ed Sanders [03:01:09] 3VisualEditor / 3ContentEditable: VisualEditor: Typing into empty paragraph with inspector open creates pawn - 10https://bugzilla.wikimedia.org/62220 (10James Forrester) a:3Ed Sanders [03:02:53] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way for users to insert variable magic words - 10https://bugzilla.wikimedia.org/49996#c6 (10James Forrester) (In reply to Alex Monk from comment #5) > Apparently some of the magic words involving 'colon arguments' will need > Parsoid/VE DM support. Doe... [03:05:39] 3VisualEditor / 3Editing Tools: VisualEditor: For all drop down boxes, the first match with check mark and highlight, loses it highlight upon hovering over it and then moving mouse out of the object - 10https://bugzilla.wikimedia.org/66106 (10James Forrester) a:3Trevor Parscal [03:06:09] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery Highlight is not getting redrawn in correct position while changing the Heading style applied on it - 10https://bugzilla.wikimedia.org/61766 (10James Forrester) a:3Ed Sanders [03:06:24] 3VisualEditor / 3Editing Tools: VisualEditor: After inserting a gallery, the newly inserted gallery does not remain highlighted but the inspector icon shows up at the corner of the page - 10https://bugzilla.wikimedia.org/61065 (10James Forrester) p:5Unprio>3Normal a:3Ed Sanders [03:06:24] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery remains highlighted even after clicking elsewhere in the page - 10https://bugzilla.wikimedia.org/61068 (10James Forrester) a:3Ed Sanders [03:08:07] 3VisualEditor / 3ContentEditable: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462#c2 (10James Forrester) 5ASSI>3RESO/FIX It is indeed fixed. Thanks Ed! [03:20:22] 3VisualEditor / 3ContentEditable: VisualEditor: When dragging content, possible places to place content (e.g. a line before the head of a section, or at the end of the page) should appear when the content gets near - 10https://bugzilla.wikimedia.org/51666 (10James Forrester) 5PATC>3RESO/FIX [03:41:26] (03PS5) 10Jforrester: core: Avoid ES5 syntax that causes ES3 browsers to fatal on parse [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) [05:27:08] (03PS1) 10Catrope: Fix scrollIntoView() in the case where the scrollable container is the [oojs/ui] - 10https://gerrit.wikimedia.org/r/140306 [07:36:07] 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303#c10 (10Krinkle) Enabling 'es3: true' in jshintrc shows that we're supposed to avoid "throws" (qunit), "super" (oojs) and "static" (oojs). I know for a fact that "throws" is perfectly safe (for I did extensive research to v... [07:36:22] (03CR) 10Krinkle: "Enabling 'es3: true' in jshintrc shows that we're supposed to avoid "throws" (qunit), "super" (oojs) and "static" (oojs)." [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [07:47:45] (03PS6) 10Krinkle: core: Use bracket notation for 'super' for ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [07:48:16] (03CR) 10Krinkle: [C: 031] "Tests still fail in IE8 because of Object.create and other ES5 methods missing, but this is a solid step forward now." [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [07:52:22] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync - 10https://bugzilla.wikimedia.org/52171#c4 (10Jonathan Haas) 5RESO/FIX>3REOP The underlying bug doesn't seem to be fixed. To reproduce (Linux, Firefox): 1. Copy the Text "Foundation" (without... [07:56:16] (03CR) 10Esanders: Insert images at the start of paragraphs (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [07:58:47] (03PS3) 10Esanders: Fix selection after inserting nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) [10:02:08] (03CR) 10Zfilipin: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [10:02:47] (03PS1) 10Esanders: Catch rangy exception thrown in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140326 (https://bugzilla.wikimedia.org/66734) [10:10:18] (03PS24) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [10:12:16] (03PS25) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [10:15:23] (03PS1) 10Esanders: Remove old, unused version of rangy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140327 [11:45:05] 3VisualEditor: Editing infobox throws TypeError: title is null - 10https://bugzilla.wikimedia.org/66724#c1 (10Ed Sanders) Looks like we don't support evaluated template names: {{ {{TNTN:Extension}} |... }} Not sure if this a VE or Parsoid problem. [11:49:46] (03PS4) 10Esanders: Fix selection after inserting nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) [11:57:18] 3VisualEditor: page remains "editable" after Save - 10https://bugzilla.wikimedia.org/66717#c1 (10Ed Sanders) Getting server errors on beta, but can't reproduce in master. [13:05:30] (03PS1) 10Esanders: Prevent getOffset from return an offset inside a content node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140345 (https://bugzilla.wikimedia.org/66691) [13:29:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: there's no way to apply heading styles - 10https://bugzilla.wikimedia.org/66782 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None There's no way to apply heading styles. [13:32:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: cursor moving handle doesn't appear - 10https://bugzilla.wikimedia.org/66783 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None On mobile devices there's the "stick" blinking cursor, and usually also another handle for moving the cursor around more conv... [15:31:35] (03PS4) 10Mooeypoo: Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) [15:33:22] (03CR) 10jenkins-bot: [V: 04-1] Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [15:52:06] (03PS5) 10Mooeypoo: Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) [16:04:46] (03CR) 10Jforrester: [C: 031] core: Use bracket notation for 'super' for ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [16:07:23] is it correct that ve master does not work with mw 1.23 ? [16:08:33] 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303#c11 (10James Forrester) (In reply to Gilles Dubuc from comment #9) > That plan looks good to me. Since this bug is still marked as low priority, > I imagine that you guys won't get around to it for at least a few months. >... [16:10:26] Richlv: Yes. We removed the confusing dependency on the Parsoid PHP extension and instead made it a MediaWiki core extension, but unfortunately the MediaWiki core maintainers released in the few week window when that was the case. [16:12:04] (03PS4) 10Alex Monk: Show wikitext warnings in the reference and media caption dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) [16:12:22] (03CR) 10Alex Monk: "If you think it's good enough, go for it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138761 (https://bugzilla.wikimedia.org/56213) (owner: 10Alex Monk) [16:18:46] James_F, duh. i was waiting for .23 to test it again :) [16:19:03] but does that mean that parsoid is not needed at all now ? [16:21:35] 3VisualEditor: beta labs: save fails with fatal error - 10https://bugzilla.wikimedia.org/66792 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None as a logged in user on any page in http://en.wikipedia.beta.wmflabs.org/ edit a page and attempt to save. Save your changes interface shows "Error: unknown... [16:22:31] Richlv: No, that was the problem – there's a Parsoid nodejs service (that all VisualEditor versions need) and also a Parsoid PHP extension (which is only useful for server farms, except we also had the styling here). [16:22:34] 3VisualEditor: page remains "editable" after Save - 10https://bugzilla.wikimedia.org/66717 (10Chris McMahon) [16:22:34] 3VisualEditor: beta labs: save fails with fatal error - 10https://bugzilla.wikimedia.org/66792 (10Chris McMahon) [16:22:47] Richlv: It was very confusing for sysadmins. :-( [16:23:08] Richlv: VisualEditor REL1_23 should work fine with MediaWiki 1.23 (but I've heard that some people had some issues). [16:23:30] Richlv: We may backport the styling dependency to MW 1.23.1 so that VE master can work for everyone [16:25:11] James_F, thanks for the info. if master would work on .23, i'd set it up and do some tests :) [16:25:28] Richlv: I'll get on it. :-) [16:26:26] edsanders: You around? Having odd issues with Beta Labs – 500 error on save, but if debug=true none of the buttons, including save, trigger anything. [16:36:02] mooeypoo: https://www.mediawiki.org/w/index.php?title=Parsoid/MediaWiki_DOM_spec/Language_conversion_blocks&diff=next&oldid=1039064 makes me sigh inside about our ability to build a nice UX… [16:38:00] James_F: don't worry too much.. [16:38:20] hehe [16:38:23] gwicke: You think we're going to dump language variants in MW instead? [16:38:54] I am optimistic that content translation will cover many of the difficult use cases, so that the remaining variant conversion stuff will be more straightforward stuff like script conversions [16:39:07] Ah. Yeah, that'd be good. [16:39:08] At least it's mostly the same directionality language. [16:39:15] mooeypoo: Not true. [16:39:22] The variants (as far as I understand) aren't switching directions [16:39:24] ... no? [16:39:29] mooeypoo: Kk is in Latin, Cyrillic and Arabic. [16:39:37] mooeypoo: Because why be hard when you can be insane instead? [16:39:44] oh lovely. [16:39:47] Indeed. [16:39:58] Okay, that might pose a bigger (understatement) issue, then. [16:40:12] :-D [16:40:39] Wow. [16:40:47] What's Kk ? [16:40:59] And are people in that language actually used to reading both ltr and rtl ? [16:41:20] mooeypoo: probably ku klux klan [16:41:47] hee [16:41:49] with a missing k [16:41:53] edsanders: Go to https://it.wikipedia.org/wiki/Takeshi_Obata?veaction=edit ; hover over the VIAF template in the top right; watch it disappear. [16:42:00] gwicke: :-P [16:42:38] mooeypoo: It's Kazakh. [16:42:55] good thing we don't use shields anymore [16:43:09] edsanders: Oh, is that a shields bug? [16:43:42] dunno, but given the new system doesn't touch the generated content DOM, I'd wait for that to roll out to confirm [16:43:50] OK. [16:44:04] Any luck with working out what's happened to Beta Labs? [16:45:42] (03PS10) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 [16:46:35] me? [16:46:54] edsanders: Yes. [16:47:16] nope, just got a server error [16:47:54] Me neither. [16:48:18] (03CR) 10Alex Monk: "Yep, it now looks like I didn't understand it at all. Sorry for wasting your time" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140044 (https://bugzilla.wikimedia.org/59604) (owner: 10Alex Monk) [16:49:05] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604 (10Alex Monk) a:5Alex Monk>3Krinkle [16:51:33] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c12 (10Alex Monk) (In reply to James Forrester from comment #11) > Is there anything further outstanding here? I need to figure out that aria-hidden thing. [16:56:18] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way for users to insert variable magic words - 10https://bugzilla.wikimedia.org/49996#c7 (10Alex Monk) 2014-06-16 22:00:29 but we'll need to implemetn support for the colon argument in Parsoid and VisualEditor DM first. [17:37:04] 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303#c12 (10Tisza Gergő) (In reply to Krinkle from comment #10) > I know for a fact that "throws" is perfectly safe (for I did extensive > research to verify it's safety going back to IE6 before adopting it un > QUnit). It woul... [17:56:15] (03CR) 10Catrope: [C: 032] Prevent getOffset from return an offset inside a content node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140345 (https://bugzilla.wikimedia.org/66691) (owner: 10Esanders) [17:56:57] (03CR) 10Catrope: [C: 032] Remove old, unused version of rangy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140327 (owner: 10Esanders) [17:57:25] (03CR) 10Catrope: [C: 032] Catch rangy exception thrown in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140326 (https://bugzilla.wikimedia.org/66734) (owner: 10Esanders) [17:57:28] (03Merged) 10jenkins-bot: Prevent getOffset from return an offset inside a content node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140345 (https://bugzilla.wikimedia.org/66691) (owner: 10Esanders) [17:58:19] 3VisualEditor / 3Data Model: VisualEditor: Getting "Error: Inserted data is trying to close the root node (at index 0)" while trying to go the next line after inserting a Hiero in Firefox - 10https://bugzilla.wikimedia.org/66691 (10James Forrester) 5PATC>3RESO/FIX a:3Ed Sanders [17:58:31] (03Merged) 10jenkins-bot: Remove old, unused version of rangy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140327 (owner: 10Esanders) [17:58:48] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/140326/ needs a cherry-pick to wmf9 (and is in ve-core), helpfully. [17:59:04] (03Merged) 10jenkins-bot: Catch rangy exception thrown in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140326 (https://bugzilla.wikimedia.org/66734) (owner: 10Esanders) [17:59:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734#c2 (10James Forrester) 5PATC>3RESO/FIX Change 140326 merged by jenkins-bot: Catch rangy exceptio... [17:59:20] 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303#c13 (10Krinkle) (In reply to Tisza Gergő from comment #12) > (In reply to Krinkle from comment #10) > > I know for a fact that "throws" is perfectly safe (for I did extensive > > research to verify it's safety going back to... [17:59:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734 (10James Forrester) 5PATC>3RESO/FIX [18:00:20] 3OOjs: OOjs: Should be parseable by ES3 engines - 10https://bugzilla.wikimedia.org/63303 (10Krinkle) a:5James Forrester>3Krinkle [18:01:04] 3OOjs: OOjs: Document features that need a polyfil in ES3 and recommended a shim - 10https://bugzilla.wikimedia.org/56341 (10Krinkle) [18:03:35] 3OOjs: OOjs: Support ES3 (tracking) - 10https://bugzilla.wikimedia.org/66804 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None After bug 63303 and 56341 are fixed, we're not done yet. I just ran a bunch of tests and IE8 is breaking all over the place due to various bugs and lackings in its javascript engin... [18:03:50] 3OOjs: OOjs: Document features that need a polyfil in ES3 and recommended a shim - 10https://bugzilla.wikimedia.org/56341 (10Krinkle) [18:03:50] 3OOjs: OOjs: Should be parseable by ES3 engines - 10https://bugzilla.wikimedia.org/63303 (10Krinkle) [18:03:50] 3OOjs: OOjs: Support ES3 (tracking) - 10https://bugzilla.wikimedia.org/66804 (10Krinkle) 5NEW>3ASSI a:3Krinkle [18:04:33] 3OOjs: OOjs: Support ES3 (tracking) - 10https://bugzilla.wikimedia.org/66804 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc [18:04:38] (03PS1) 10Catrope: Catch rangy exception thrown in FF [VisualEditor/VisualEditor] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140426 (https://bugzilla.wikimedia.org/66734) [18:05:40] (03CR) 10Jforrester: [C: 032] Catch rangy exception thrown in FF [VisualEditor/VisualEditor] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140426 (https://bugzilla.wikimedia.org/66734) (owner: 10Catrope) [18:06:55] (03Merged) 10jenkins-bot: Catch rangy exception thrown in FF [VisualEditor/VisualEditor] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140426 (https://bugzilla.wikimedia.org/66734) (owner: 10Catrope) [18:12:40] (03PS1) 10Jforrester: Update VE core submodule to master (33b43ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140427 [18:16:30] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.24wmf9 (7306211) [extensions/VisualEditor] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140428 [18:28:49] RoanKattouw, ryasmeen: https://gist.github.com/anonymous/8e6fd4b5d47c9d7d617f [18:29:59] *knock knock* [18:30:09] anyone have a chance to talk VE deploy tomorrow? [18:30:28] greg-g: Here too. :-) [18:30:32] heh [18:30:37] * greg-g tries to stay on topic [18:30:48] and 'go to where the people live' [18:31:10] Sure. [18:31:33] so, basic statement: Given the instability/last minuteness (as expressed by Roan today in the SoS), I'm wary of this going out with basically zero time on Beta Cluster for it bake. [18:31:39] convince me otherwise or not. Go! [18:31:55] I have no idea what Roan said, but there's nothing particularly unusual about the scale of changes this week. [18:32:07] 2–3 (internally) breaking changes is about usual. [18:32:51] greg-g: https://gist.github.com/anonymous/8e6fd4b5d47c9d7d617f is the change list (so far), and is the worrying changes are presumably mostly related to Ed's performance work, which we've been testing for a couple of weeks. [18:33:08] greg-g: Half of those changes went out last week without incident. [18:33:21] he mentioned "completely torn apart and put back together, so it's going to be messy until the end" (paraphrase) [18:33:29] something Trevor is doing [18:33:36] Oh, that? That's not landing today. [18:33:38] (I think) [18:33:40] ohhhhh [18:33:46] * greg-g whews [18:33:49] That's /next/ week's big change. [18:33:53] :) [18:33:59] * greg-g un-whews ;) [18:33:59] We'll land it tomorrow morning just after the cut, like we try to do normally. [18:34:04] * greg-g nods [18:34:07] good deal, thanks! [18:34:12] Maximal testing time FTW. [18:34:18] * greg-g hugs the VE team [18:34:23] * James_F grins. [18:34:30] just don't let us revert a dependent extension with your needed changes [18:34:33] greg-g: BTW, the office is actually pretty quiet. [18:34:34] :) [18:34:41] Ha. Indeed. Please don't do that again, kthxbai. ;-) [18:34:44] everyone had the same idea, I presume [18:34:50] Yeah. [18:38:01] (03CR) 10Krinkle: [C: 032] core: Use bracket notation for 'super' for ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [18:39:22] (03Merged) 10jenkins-bot: core: Use bracket notation for 'super' for ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [18:48:46] (03PS1) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 [18:49:49] (03CR) 10Krinkle: "Verify by checking out, run `grunt build`, start IE8 (e.g. at browserstack) and open localhost/oojs/core/test/index.html *and* localhost/o" [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (owner: 10Krinkle) [18:50:34] 3OOjs: OOjs: Support ES3 - 10https://bugzilla.wikimedia.org/66804 (10Krinkle) p:5High>3Unprio s:5enhanc>3normal [18:50:55] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/140306 ? [18:51:05] If you recall I wrote it last night on your couch :) [18:51:08] (03PS2) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/66804) [18:51:43] (03CR) 10Trevor Parscal: [C: 032] Fix scrollIntoView() in the case where the scrollable container is the [oojs/ui] - 10https://gerrit.wikimedia.org/r/140306 (owner: 10Catrope) [18:51:53] (03PS1) 10Esanders: Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 [18:52:00] (03PS1) 10Esanders: Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 [18:52:15] (03Merged) 10jenkins-bot: Fix scrollIntoView() in the case where the scrollable container is the [oojs/ui] - 10https://gerrit.wikimedia.org/r/140306 (owner: 10Catrope) [18:53:03] (03CR) 10jenkins-bot: [V: 04-1] Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [18:53:22] (03CR) 10jenkins-bot: [V: 04-1] Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (owner: 10Esanders) [18:56:50] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10Roan Kattouw) [18:56:50] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10Roan Kattouw) [18:57:19] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829 (10Roan Kattouw) 5ASSI>3RESO/FIX [18:59:48] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10Roan Kattouw) [19:00:33] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501 (10Roan Kattouw) [19:02:03] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10Roan Kattouw) [19:03:19] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501 (10Roan Kattouw) [19:03:21] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery and Math inspector closes with an animation from right to left after clicking on "<" to close them - 10https://bugzilla.wikimedia.org/66552 (10Roan Kattouw) p:5Unprio>3Normal s:5normal>3minor a:3Trevor Parscal [19:03:33] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery and Math inspector closes with an animation from right to left after clicking on "<" to close them - 10https://bugzilla.wikimedia.org/66552 (10Roan Kattouw) 5NEW>3ASSI [19:04:33] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222 (10Roan Kattouw) 5PATC>3RESO/FIX [19:06:23] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (33b43ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140427 (owner: 10Jforrester) [19:08:32] (03CR) 10Catrope: [C: 032 V: 032] Update VE core submodule to wmf/1.24wmf9 (7306211) [extensions/VisualEditor] (wmf/1.24wmf9) - 10https://gerrit.wikimedia.org/r/140428 (owner: 10Jforrester) [19:08:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (33b43ec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140427 (owner: 10Jforrester) [19:09:59] (03PS3) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/66804) [19:14:01] (03PS4) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [19:14:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c15 (10ryasmeen) 5RESO/?>3VERI Verified... [19:14:50] 3OOjs: OOjs: Should be parseable by ES3 engines - 10https://bugzilla.wikimedia.org/63303 (10Krinkle) 5PATC>3RESO/FIX a:5Krinkle>3James Forrester [19:15:50] (03PS5) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [19:23:37] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c2 (10ryasmeen) This is the minimum wikitext required to reproduce thi... [19:30:02] (03CR) 10Catrope: [C: 04-1] "-1 per comments on PS9" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (https://bugzilla.wikimedia.org/65716) (owner: 10Esanders) [19:31:01] (03PS1) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://bugzilla.wikimedia.org/49996) [19:35:33] (03PS6) 10Krinkle: Implement support for ES3 browsers (tests passing in IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [19:36:04] 3VisualEditor / 3Editing Tools: VisualEditor: Issues with new Image model (tracking) - 10https://bugzilla.wikimedia.org/65829#c1 (10Elitre) Wow. This looks nice. [19:41:56] (03CR) 10Catrope: [C: 04-1] "Breaks a bunch of tests" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [19:46:49] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c3 (10ryasmeen) Found the steps to reproduce it from VE :D 1.Open a p... [19:47:18] (03CR) 10Catrope: [C: 031] Fix selection after inserting nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139824 (https://bugzilla.wikimedia.org/65706) (owner: 10Esanders) [19:48:05] (03CR) 10Catrope: [C: 031] Insert images at the start of paragraphs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140037 (https://bugzilla.wikimedia.org/65883) (owner: 10Mooeypoo) [19:51:35] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless with out any wrap option deletes the content of the caption - 10https://bugzilla.wikimedia.org/66808 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an image 3.Add caption to it 4... [19:51:50] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frameless with out any wrap option deletes the content of the caption - 10https://bugzilla.wikimedia.org/66808 (10ryasmeen) a:3Moriel Schottlender [19:58:24] (03PS7) 10Krinkle: Implement support for ES3 browsers (tests passing in IE7 + IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [19:58:42] (03PS8) 10Krinkle: Implement support for ES3 browsers (tests passing in IE6-8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [19:58:51] Holy shit [19:58:57] IE6 support ladies and gentlemen [19:59:30] (IE6 was the same as IE7 except for a minor bug in the test suite itself) [20:01:53] (03PS9) 10Krinkle: Implement support for ES3 browsers (tests passing in IE7 + IE8!) [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) [20:02:04] (03CR) 10Krinkle: "OK. Done now (I think)." [oojs/core] - 10https://gerrit.wikimedia.org/r/140436 (https://bugzilla.wikimedia.org/56341) (owner: 10Krinkle) [20:08:19] (03PS3) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [20:08:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [20:12:59] Krinkle: Well done good sir [20:14:10] Krinkle: Impressive! [20:14:27] James_F: I'm adding json2.js with skipFunction to core now [20:14:39] Krinkle: Very nice. [20:14:40] which allows us to save about 100kb bandwith [20:14:45] * James_F nods. [20:14:57] becuase we're using jquery.json.js now which has no skipFunction (and cant' because it exposes a different interface) [20:15:08] so it is currently shipped everywhere json is needed [20:18:10] (03PS7) 10Trevor Parscal: [WIP] Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 [20:18:43] (03PS4) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [20:18:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [20:20:02] (03PS1) 10Catrope: Revert "Update displaytitle on save" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140558 (https://bugzilla.wikimedia.org/66792) [20:20:21] (03CR) 10Jforrester: [C: 032] Revert "Update displaytitle on save" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140558 (https://bugzilla.wikimedia.org/66792) (owner: 10Catrope) [20:21:11] (03PS2) 10Catrope: Revert "Update displaytitle on save" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140558 (https://bugzilla.wikimedia.org/66792) [20:21:20]