[00:07:13] 3VisualEditor / 3Editing Tools: VisualEditor: When getting TemplateData, VE automatically adds "Template:" even if another namespace is provided - 10https://bugzilla.wikimedia.org/52609#c2 (10Alex Monk) (Okay, it's not as simple as I was hoping) [00:10:49] Thanks gwicke [00:10:55] I have to go but I'll look at it later [00:10:57] Looks interesting [00:11:50] RoanKattouw, [00:12:01] Hey mooeypoo [00:12:03] Looking [00:12:08] \o/ thanks [00:12:30] You're setting active on a /page/ [00:12:33] What do you expect to happen? [00:12:45] the dialog displays that page? [00:12:50] is that... not... what should happen? [00:12:54] Oh it has a setActive method [00:13:00] Never mind, I was getting confused [00:13:14] ok, so the user just chose an image in the search page.. I want the dialog to automatically go to the general page now [00:13:35] Is this page part of a StackLayout? [00:13:48] Oh it's in a BookletLayout [00:13:53] it's booklet layout [00:13:54] yeah [00:14:08] RoanKattouw, btw, this also works in *changing* the image. Woot [00:14:10] I think you need to use this.bookletLayout.setPage() instead [00:14:29] Which calls page.setActive( true ); and does a whole bunch of other things [00:14:38] oh [00:15:26] let me see [00:15:29] Basically after creating the pages you don't want to touch them afterwards, and let the booklet manage them [00:15:35] This is one of these undocumented patterns [00:15:49] oh, okay, that makes sense [00:15:56] OK I gotta go but I'll be on hangouts if you need me [00:16:02] thanks! [00:21:00] 3VisualEditor / 3Editing Tools: VisualEditor: For large SVG images while trying to make it full size, it says "Size values are invalid" - 10https://bugzilla.wikimedia.org/66865 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert a svg image with large siz... [00:21:29] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863 (10ryasmeen) [00:23:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734#c10 (10ryasmeen) 5ASSI>3RESO/FIX After re-deployment , it is now fixed :) [00:25:12] (03PS1) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [00:26:05] (03PS2) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [00:27:43] 3VisualEditor / 3Editing Tools: VisualEditor: When getting TemplateData, VE automatically adds "Template:" even if another namespace is provided - 10https://bugzilla.wikimedia.org/52609#c4 (10Alex Monk) This was also hiding another problem (templates outside of the Template namespace ended up prefixed with '... [01:30:26] (03PS3) 10Mooeypoo: [wip] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [07:13:10] Hello everyone. [07:13:10] Looking for help regarding the installation and the configuration of the extension VisualEditor. [07:13:10] After several tests, I get nothing conclusive. [07:13:10] OS: GNU/Linux Debian jessie/sid | WM: 1.23 | VE: manual snapshot made for MediaWiki 1.23 [07:13:10] nodejs 0.10.29 and parsoid 0.1.12 installed with aptitude [15:39:02] (03PS12) 10Esanders: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [16:50:02] (03PS13) 10Jforrester: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) [16:50:28] (03CR) 10Jforrester: "PS13 notes that moduleUtils is partially shared with the OOjs UI project." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [17:19:59] RoanKattouw_away, so here's the cunning plan [17:20:48] converting a template gives you back spans from Parsoid because it has not context [17:21:24] so we go up the DM tree and build linmod with context [17:21:47] so [table, tableSection, mwTransclusion, /, /, /] [17:22:14] then... we tag the mwTransclusion with a special attribute (data-something) [17:22:34] then we pass the linmod to the convert to get DM HTML [17:22:53] then we find the special attribute and work out how many wrapping nodes were generated [17:23:25] (a node could generate complex structure) [17:23:56] then we pass the DM HTML to the API and have it converted to wikitext and back [17:24:07] then we unwrap the correct number of wrapping nodes [17:24:13] and tada [17:24:37] https://www.youtube.com/watch?v=x5BobUhVt4A [17:27:19] edsanders: in most cases just re-expanding full transclusions should be a good approximation for existing multi-template content [17:30:21] gwicke, but that means re-rendering other nodes [17:58:02] edsanders: yup [17:58:10] but that's really the only safe way to do it [17:58:48] the plan is to fix the scope of multi-template content with tags, see https://www.mediawiki.org/wiki/Parsoid/domparse [18:00:01] although, I guess in theory there could be balanced -producing templates at some point that are not part of a larger multi-template content block [18:00:39] once we have wrapping we'll actually make those safe too by enforcing the balancing [18:01:36] there is more content constraint work going on in that context though, which you might be able to leverage [18:02:19] see https://www.mediawiki.org/wiki/Parsoid/DOM_notes for details on that [18:04:33] gwicke, sure but that seems like a lot of work and may not be ready for a while, right [18:05:39] my guess would be that re-expanding multi-template content blocks as a unit should cover most use cases right now [18:06:14] & is likely to result in more accurate rendering [18:11:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885 (10James Forrester) 3ASSI p:3Unprio s:3minor a:3Alex Monk Created atta... [18:11:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885 (10James Forrester) p:5Unprio>3Normal [18:41:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Cursor jumps to the beginning of the document after adding citations/references - 10https://bugzilla.wikimedia.org/64041#c8 (10ryasmeen) 5RESO/FIX>3REOP This bug has been reborn in wmf 10 [18:45:43] gwicke, so 1: it seems like domparse won't be ready for a while, and 2: re-rendering multiple nodes is complex and something we haven't done before [18:46:26] the solution I have is simple(ish) and will improve a number of major cases (e.g. episode list), while not breaking existing cases [18:46:36] unless I am mistaken [19:10:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Cursor jumps to the beginning of the document after adding citations/references - 10https://bugzilla.wikimedia.org/64041#c9 (10Ed Sanders) Works in master. Deployment issue? [19:19:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Cursor jumps to the beginning of the document after adding citations/references - 10https://bugzilla.wikimedia.org/64041#c10 (10James Forrester) (In reply to Ed Sanders from comment #9) > Works in master. Doesn't work in Beta Labs, which is run... [20:02:16] James_F: hey, can i get VE in more namespaces on mw.org? in particular, "Skin:" :) [20:18:03] MatmaRex: Sure. I thought it was on in all namespaces; are those new? [20:22:00] 3VisualEditor / 3Editing Tools: VisualEditor: Formula icon is missing in the Insert menu - 10https://bugzilla.wikimedia.org/66890 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15690 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15690&action=edit Screenshot Formula icon is... [20:22:44] 3VisualEditor / 3Editing Tools: VisualEditor: Formula icon is missing in the Insert menu in Betalabs - 10https://bugzilla.wikimedia.org/66890 (10ryasmeen) [20:33:57] MatmaRex: Done in https://gerrit.wikimedia.org/r/#/c/141053/ [20:38:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Formula icon is missing in the Insert menu - 10https://bugzilla.wikimedia.org/66890#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3trivia a:3Ed Sanders Did the registration in the Math extension not work? [20:38:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734 (10James Forrester) [20:53:49] James_F: i don't think it's new, but it was kind of unused before [20:54:18] MatmaRex: It wasn't there when I enabled VE on all MWW namespaces, apparently. [20:54:26] MatmaRex: So "newer". :-) [20:54:37] hm. [20:54:46] thanks :) [21:19:44] (03PS1) 10Catrope: Also annotate metadata in TransactionProcessor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141063 (https://bugzilla.wikimedia.org/52127) [21:26:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf10] In Firefox, Saving the edit on a page everytime throws error: this.debugBar is null and cannot re-open VE after that - 10https://bugzilla.wikimedia.org/66692#c10 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production(en.wiki) [21:31:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] Cannot switch to edit source mode , shows the message "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." on top of the page - 10https://bugzilla.wikimedia.org/66231#c5 (10ryasmeen) 5RE... [21:32:59] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an existing reference" in the reference dialog button should be disabled once user enters content in the text field and re-enabled upon deleting it - 10https://bugzilla.wikimedia.org/65689#c10 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production(en.... [21:38:35] (03CR) 10Jforrester: "The bug this is tagged with was a meta-at-end-of-annotation situation; Roan and I discussed possibly being aggressive in including adjacen" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141063 (https://bugzilla.wikimedia.org/52127) (owner: 10Catrope) [21:38:59] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396#c6 (10ryasmeen) Verified the fix in production (en.wiki) [21:39:14] 3VisualEditor / 3Editing Tools: VisualEditor:Getting "Your edit may have been corrupted – please review before saving" message while making changes to an image in the page - 10https://bugzilla.wikimedia.org/66396 (10ryasmeen) 5RESO/?>3VERI [21:41:59] 3VisualEditor / 3Editing Tools: VisualEditor: Language selector from Language inspector takes long time (~15 secs) to load - 10https://bugzilla.wikimedia.org/65512#c11 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [21:44:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] While changing an image type from Thumbnail/Frame to Frameless/Basic, the wrap option gets unchecked but the alignment tabs remain active in Betalabs - 10https://bugzilla.wikimedia.org/66288#c6 (10ryasmeen) 5RESO/?>3VERI Verified the fix... [21:45:59] 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705#c5 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [21:47:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [21:51:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] Cannot check the wrap option after changing a Thumbnail/Frame image to Frameless/Basic - 10https://bugzilla.wikimedia.org/66291#c8 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [21:52:44] 3VisualEditor / 3Editing Tools: VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option - 10https://bugzilla.wikimedia.org/65916#c10 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [21:55:59] 3VisualEditor / 3Editing Tools: VisualEditor: The highlight boxes for templates/images/cite notes/math/references inside the caption of an image are appearing on hovering over the image inside VE - 10https://bugzilla.wikimedia.org/64563#c6 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [22:02:14] 3VisualEditor / 3Data Model: VisualEditor: Opening and closing the link inspector dirties the link, adding a pointless transaction - 10https://bugzilla.wikimedia.org/57205#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [22:04:13] 3VisualEditor: VisualEditor: Typing diacritics results in stray accent marks at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/66693#c3 (10WhatamIdoing) Testing after the latest update was unable to reproduce the problem. [22:05:44] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector opens up in the wrong place after inside Media Settings dialog - 10https://bugzilla.wikimedia.org/62857#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [22:06:08] James_F, around? [22:06:35] https://bugzilla.wikimedia.org/51798 suggests links in the title [22:07:01] but you're providing text to go into the i18n messages..? [22:08:16] Krenair: Hey. [22:08:54] Krenair: Yeah, the idea is maybe each field set should have the abilities to add (?) icons which on click give contextual help for each thing. [22:10:05] okay, some that pops up on hover or something? [22:10:18] Krenair: On click maybe? Touch doesn't have hover. Or both. [22:11:09] Krenair: So e.g. "redirecting" would have some description available to explain what that is, without demanding user attention for those that know what it is already, as would "show table of contents" and "disable edit links" and "this is a disambiguation page". [22:11:16] Is there some OOjs UI way to do this? [22:11:28] Krenair: (That last one means the __DISAMBIG__ hook may be insufficient.) [22:12:00] There's the (?) icon in template fields – maybe that could be generalised? [22:12:43] * James_F doesn't know for sure, sorry. [22:15:44] 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes" button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389#c5 (10ryasmeen) 5RESO/?>3VERI Verified the fix i... [22:17:08] hah, James_F I see 3 new 'regression' bug emails and think "oh noes!" and then notice they're all "Verified fix".. phew :) Concentrating on the merge instead. [22:17:24] mooeypoo: :-) [22:18:40] James_F, so all of these use FieldLayout to show their label text [22:18:47] (in OOUI) [22:19:50] I think it might make sense to use IconedElement from there when configured [22:23:41] TrevorParscal: lets continue our earlier discussion some time next week over lunch or so? [22:26:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] In Firefox, closing the Language Inspector without making any change throws sel.nativeSelection is null - 10https://bugzilla.wikimedia.org/66734#c11 (10ryasmeen) Verified the fix in test2 [22:27:37] James_F, this way I think each page settings entry would only need an extra config option to provide the info... [22:29:00] (03PS1) 10Cmcmahon: [BrowserTest] temporarily don't check for minor edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141068 [22:34:59] 3VisualEditor / 3ContentEditable: VisualEditor: The image does not remain highlighted but the areas around it are instead, after making an image frameless-right or basic-right - 10https://bugzilla.wikimedia.org/65716#c12 (10ryasmeen) Verified the fix in test2 [22:36:23] (03CR) 10Cmcmahon: "reduce noise for now" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141068 (owner: 10Cmcmahon) [22:38:41] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] temporarily don't check for minor edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141068 (owner: 10Cmcmahon) [22:43:54] (03Merged) 10jenkins-bot: [BrowserTest] temporarily don't check for minor edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141068 (owner: 10Cmcmahon) [22:48:29] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] The previous line is also getting highlighted while adding a reference list/image - 10https://bugzilla.wikimedia.org/65706#c12 (10ryasmeen) Verified the fix in test2 [22:59:44] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c5 (10ryasmeen) 5RESO/FIX>3REOP Not fixed for Firefox , there is no cursor at al... [23:05:32] Krenair: That could work. [23:09:35] Yeah, I got the icon displaying [23:18:33] Is TrevorParscal around? [23:20:53] howdy [23:21:23] something about help icons on fieldsets? [23:26:29] 3VisualEditor / 3ContentEditable: VisualEditor: It should be possible to add a link with only pressing enter once - 10https://bugzilla.wikimedia.org/56434#c3 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [23:37:59] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928 (10ryasmeen) 5REOP>3ASSI [23:39:44] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c3 (10Philippe Verdy) What is happening to **inline** images (sometimes used to replace some text which is hard to render, such as letters with stacked diacritics rarely... [23:57:52] TrevorParscal, I was wondering if there's any proper way to have some kind of popup help text when hovering over (or clicking) an element in OOUI? [23:59:44] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c4 (10James Forrester) (In reply to Philippe Verdy from comment #3) > What is happening to **inline** images (sometimes used to replace some text > which is hard to rend...