[00:09:08] (03PS1) 10Catrope: Work around element sizing bug in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/141081 [00:12:34] i really like the new tooltips on things. (transclusions, links.) [00:12:45] Oh, yeah [00:12:52] We still want to change tthe ones on references [00:12:56] Right now it just says "Reference" [00:13:03] But we want to make it some sort of preview of the reference text [00:13:04] Indeed. [00:13:25] oooh. neat. [00:14:02] can i follow this up with a complaint? :D in the tooltip for templates, the template name is displayed in the same casing as it's written in wikicode, and not in canonical form [00:14:19] it looks untidy. :) [00:14:27] (i'm looking at mw.org) [00:14:30] Oh, right [00:14:34] Yeah that should be fixed [00:14:39] MatmaRex: Yeah, that's on the list. [00:15:00] MatmaRex: Even better, if the template invocation is {{Foo |…}}, guess what happens. :-) [00:16:23] haha [00:18:38] ... WOW, me. Wow. Really. Just.. wow. I'm at awe at my own blindness. [00:19:33] I've been trying to figure out WHAT is causing my code to go all foo on "undefined is not a function" .. debugging... checking..... yeah. Great. I forgot a bracket. A BRACKET! Oh, brackets. [00:27:16] 3VisualEditor / 3Technical Debt: VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace - 10https://bugzilla.wikimedia.org/66893 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None Right now we have things like mw.Title.newFromText( template ); , while... [00:29:16] (03PS1) 10Catrope: Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 [00:29:21] MatmaRex: ---^^ [00:29:52] whee [00:30:07] RoanKattouw, do you know if there's a way to do setDisabled() to an entire page in bookletLayout ? I am going over ooui OO.ui.PageLayout and 'setActive' doesn't seem to be it, and the BookletLayout doesn't seem to have that. [00:30:18] the alternative is me disabling the widgets individually [00:30:21] What does it mean to disable an entire page? [00:30:22] RoanKattouw: is that a ', '? i18n guys will hunt you down for no using comma-separator :P [00:30:30] not using* [00:30:33] I guess we should use that, yes [00:30:53] RoanKattouw, ok, let's say you want to insert a new image. You click on the insert image and the dialog pops up. There's no need (or way) for you to edit caption or any of the other stuff before you CHOSE an image. [00:30:55] (03PS2) 10Bartosz Dziewoński: Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (owner: 10Catrope) [00:30:59] (03CR) 10Bartosz Dziewoński: [C: 031] Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (owner: 10Catrope) [00:31:25] so I want them all disabled until you choose an image... a lot depends on whether the image is SVG or not, or on its original size, so we have to have the image first and then the properties. [00:31:34] mooeypoo: OK [00:31:38] You should talk to Trevor about this [00:31:47] RoanKattouw, I can disable all widgets individually until you choose an image, or I can disable the two "basic" and "advanced" pages. [00:32:35] Oh, okay, he's probably out already, no? [00:32:41] No he's talking to Kaity [00:33:23] oh. TrevorParscal when you're around, let me know. I have a question regarding pages in BookletLayout (read up the previous 5-6 lines for info) [00:33:25] * mooeypoo beeps [00:33:33] oh, the wonders of IRC [00:34:01] 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator - 10https://bugzilla.wikimedia.org/66894 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None There are a few places where we use the string ', ' but in all of those cases we should really be using the comma-separator message. This requi... [00:35:04] mooeypoo: i think the image selection should be on a separate page [00:35:16] you shouldn't need to disable anything [00:35:21] don't use a booklet [00:35:26] TrevorParscal, it is on a separate page. [00:35:34] TrevorParscal: There is already a booklet for general vs advanced [00:35:41] mooeypoo: Are you adding a third page to that booklet or something? [00:35:45] yes [00:35:52] "Search image" (or something worded better) [00:35:55] use a stack panel layout, that contains the image chooser on one panel and the booklet layout in another [00:35:56] because users can also *change* the image [00:36:09] basically combine the two dialogs by making them panels in a stackpanel [00:36:18] oh [00:36:26] then choose the panel based on whether the user is selecting or editing [00:36:39] That defeats the whole point [00:36:43] You're supposed to be able to change the image [00:36:44] TrevorParscal, but even if the user is editing they need access to the search [00:36:45] yeah [00:36:53] So then you need a button to switch back to that? [00:36:57] yes [00:37:00] That's a bit confusing, isn't it? [00:37:06] image selection should be a full dialog experience [00:37:19] it's a full page experience... that's pretty close [00:37:20] we are getting rid of the outline on the left [00:37:56] TrevorParscal, when we have the immersive experience of the new dialog, perhaps, but now, too? [00:39:16] So what he's suggesting is having a button called Change image, that when you click it switches you to an image search, then as soon as you click an image, it takes you back to where you came from [00:39:30] I'm a bit skeptical of having two separate navigation systems there but it sort of feels OK to me [00:39:39] and that you can cancel out of the image search as well [00:39:49] basically, images search/selection is a sub-modal task [00:39:52] not an editor [00:39:58] hmm [00:40:04] That seems reasonable I guess [00:40:04] you start out doing it first when inserting [00:40:10] hmm [00:40:13] but it's really an edge case for normal image editing [00:40:30] Okay. Are they still considered the same dialog? [00:40:38] code wise? [00:40:53] and once you go into the image selection panel, as an editor, you would need to show the current image, and other options, in a panel on the right, so the image options would be super small or you will only see a couple at a time [00:40:56] I am confused. Is this just a presentation choice, or are we still splitting the dialogs, just calling one from the other? [00:41:16] i think you are merging them, no? [00:41:25] ... I thought I was, but now I'm confused. [00:41:33] yes, merge them [00:41:42] Merge merge merge. :-) [00:41:47] TrevorParscal, k, can I show you what I have so far, then? [00:41:51] let me just update a real quick thing [00:41:53] But you'd keep them as separate panels in a top-level StackLayout [00:42:02] okay, I see. [00:42:08] In one panel you have the image search, in the other you have the BookletLayout [00:42:14] exactly [00:42:19] Also on insert you have to switch back to "edit" so you can set up all the options for your new image [00:42:29] gotcha. I think. [00:43:14] you can make it so when you select an image, instead of inserting it, you go to the booklet layout with the settings [00:43:23] that's exactly what happens now [00:43:26] only with booklet layout [00:43:54] yeah, so then to get back to the image selection, you just add a button in the bottom left called "Change image" and it takes you to the selection panel [00:44:08] (03PS1) 10JGonera: [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [00:44:28] when they select, it updates the image URL and does some magic to merge the settings (sizes will change, formats may changes as well) and let you continue editing [00:44:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [00:45:10] TrevorParscal, that's exactly what I've been trying to do. The only difference (I think?) between your suggestion and my code, as far as I understand, is the stack layout [00:45:14] ... or.. I hope. :D [00:45:21] i think so [00:45:38] it sounds like what you were trying to do before was to make the image selection just another page in the booklet [00:45:59] i'm suggesting you encapsulate the booklet, and the image selection, in a stacklayout [00:46:07] indeed [00:46:09] * mooeypoo nods [00:46:15] right on [00:46:18] ok so all the functionality will stay the same [00:46:31] just encapsulate the new page with a stacklayout instead of it being a new page. [00:46:40] yes, the only interesting bits are going from insert to edit instead of insert to closed [00:46:54] yeah that already happens. [00:47:16] and going from edit to select and then select back to edit, merging the new image information into the image model being edited [00:47:24] (03PS4) 10Mooeypoo: [wip] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [00:47:25] TrevorParscal, ^^ check it out [00:47:58] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c5 (10Philippe Verdy) So the current Tech News needs correction. The expressions "block image" is ambiguous, at first reading I wondered who was right. Yes having clien... [00:48:07] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (69060dd93f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [00:48:09] (03PS1) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [00:48:26] that's exactly what it's doing. I added a new function to the image model to produce a new node (unattached to the document) so the image model can use its internal functionality (type/scalable changes,etc) whenever a new image is selected. [00:48:33] then it's just going with the image model the same as before [00:49:04] (03PS7) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [00:49:29] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (69060dd93f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [00:49:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [00:49:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:52:52] looks really cool - also make sure you pay attention to merging the new image info with the old image info, because I'm noticing that the size info from the old one can end up sticking to the new one and be invalid [00:53:00] i gtg, this is looking great mooeypoo [00:54:24] awesome [00:54:33] The new size *should* be updated, but I'll double check [00:54:51] thanks TrevorParscal ! [01:01:30] (03PS1) 10Jforrester: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 [01:02:46] (03CR) 10jenkins-bot: [V: 04-1] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [01:05:54] (03PS2) 10Jforrester: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 [01:06:45] RoanKattouw, do you happen to know off hand a dialog that uses stack panel? I forgot to ask TrevorP|Away [01:07:11] I think templates dialog does that? [01:07:25] mooeypoo: Templates and Meta. [01:07:35] awesome, thanks James_F [01:10:07] (03PS1) 10Jforrester: Sync eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141093 [01:11:06] mooeypoo: Not offhand [01:11:21] But a StackPanelLayout is basically the same as a BookletLayout, it just doesn't have a thing on the left [01:12:22] "Basically the same" === subclass of. :-) [01:13:00] this is quite confusing. [01:13:19] I'm trying to see how to set that up, and the Meta and Template dialogs seem to both be using booklet layout [01:14:07] Oh, yeah; Template just makes the Booklet hide itself. [01:16:43] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c6 (10James Forrester) (In reply to Philippe Verdy from comment #5) > So the current Tech News needs correction. Our submissions to Tech News are generally re-written t... [01:19:48] shouldn't this be more like the save dialog with the 'show diff' ? [01:27:54] Well, except you don't transition between them (right now). [01:28:40] (03CR) 10Jforrester: [C: 031] Normalize titles in template descriptions in context menu (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (owner: 10Catrope) [01:29:21] (03PS3) 10Jforrester: Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (https://bugzilla.wikimedia.org/66893) (owner: 10Catrope) [01:29:37] (03CR) 10Jforrester: "But see my comment on PS1." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (https://bugzilla.wikimedia.org/66893) (owner: 10Catrope) [01:30:58] 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator - 10https://bugzilla.wikimedia.org/66894 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [01:31:06] James_F, I'm.. supposed to O,o [01:31:32] mooeypoo: ? [01:32:24] I thought the entire point is that we do switch between them [01:32:48] on insert new, we start with 'search' .. user selects an image -> switch to 'edit' panel [01:33:04] on edit, we start with 'general settings'... but user also has a button "switch image" where we can switch to 'search' [01:33:11] I thought that's what TrevorP|Away said [01:37:31] (03PS1) 10Alex Monk: [WIP] Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 [01:37:48] (03CR) 10Alex Monk: [C: 04-2] [WIP] Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (owner: 10Alex Monk) [01:43:04] mooeypoo: Eventually, yes. [01:43:31] hah. Well. I managed to stack both panels together, only they're both visible. Very.. interesting design. [01:43:44] James_F, it's already ready for this behavior. The only problem I have is the stack layout [01:43:51] which.. is very confusing. [01:44:13] mooeypoo: (Though I don't think the insert-but-not-just-yet! change is one we'd want to do, probably.) [01:44:26] The switch image thing definitely is. [01:44:38] James_F, the current merge does both [01:45:13] * James_F nods [01:45:15] It's fairly straight forward for the both of them to happen. The main issue is the way it looks; trevor wants them to be different panels rather than "just" different pages in the booklet layout [01:45:29] OK… [01:45:40] I am really confused, though. [01:45:51] Did I misunderstand? :\ [01:46:28] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c7 (10Philippe Verdy) - It is a bug of the Tech News that incorrectly says it applies to all images. - This is in our control (Tech News can be fixed to say it applies o... [01:46:42] the stack layout should really be less of a mess to use. [01:52:00] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c8 (10Philippe Verdy) (In reply to James Forrester from comment #4) See Bug 66896 (general RFE plus a real bug) For allowing max-height and general improvement to clie... [01:57:21] mooeypoo: No, you got it right, I just remain to be convinced about the right UX for inserting images being adding a new step. [01:57:44] yeah the entire dialog is going to ahve to be re-UX'ed [01:58:00] but the merging wasn't too insane, so for now I guess that'll work. [01:58:03] * James_F nods. [02:01:54] woot! [02:02:00] okay, I managed to get stack layout to work [02:02:09] but I had to cheat it. So.. I hope Trevor approves. [02:06:15] :-) [02:09:35] (03PS2) 10Alex Monk: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 [02:11:18] (03PS3) 10Alex Monk: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 [02:12:55] (03CR) 10jenkins-bot: [V: 04-1] Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (owner: 10Alex Monk) [02:13:09] jenkins, wut? [02:13:46] (03PS5) 10Mooeypoo: [wip] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [02:14:02] RoanKattouw, James_F, Stack Layout ^^ \o/ [02:15:47] (03PS4) 10Alex Monk: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 [02:18:53] (03CR) 10Alex Monk: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (owner: 10Alex Monk) [02:25:01] mooeypoo: Woo. :-) [02:48:48] RoanKattouw, just to make sure, ve.extendObject( objA, objB ) --> if objA and objB share a key, it will get objB's value. Right? [02:49:58] Yes [02:50:05] Even if the value is an object or array [02:50:10] Ahm, hold on [02:50:16] I forget who wins [02:50:29] Yeah you're right B wins [02:50:34] (You can test this in the console) [02:51:17] yeah, I wanted to make sure I didn't miss anything with that. It's like deep $.extend [02:51:27] * James_F goes home. [02:51:35] have a good weekend, James_F [02:51:40] See some of you online tomorrow, even though I shouldn't. :-) [02:51:42] * James_F waves. [02:51:54] hehe [02:54:35] ok, RoanKattouw I think we talked about this in the past, but I'm not sure what the result was. If I want to delete a file in my commit -- do I just git rm && git commit .. etc [02:54:52] oh, hehe, nevermind. have a good weekend! [02:55:32] (03PS6) 10Mooeypoo: [wip] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [04:44:58] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c7 (10Quim Gil) This problem keeps happening regularly, e.g. https://ca.wikipedia.org/w/index.php?title=Ferran_Clavell&diff=prev&oldid=13600764 The most surreal edit we have seen so... [07:18:15] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c6 (10Tony Thomas) 5ASSI>3NEW a:5Tony Thomas>3None Sorry, I got bit busy with my other project. [12:07:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Formula icon is missing in the Insert menu - 10https://bugzilla.wikimedia.org/66890#c2 (10Ed Sanders) Definitely works in master, must be a deployment issue. [13:40:18] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None Until Parsoid removes metadata, large articles are going to consist of several megabytes of data (en:Barack_Obama = 3.4MiB).... [13:43:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914#c1 (10Bartosz Dziewoński) Supporting section editing (bug 48429), and submitting only modified section to the server, might be a better way to increase performance. [15:26:30] 3VisualEditor / 3Editing Tools: VisualEditor: Only insert block images at the start of a paragraph - 10https://bugzilla.wikimedia.org/65883#c9 (10Andre Klapper) Please discuss Tech News issues by going to Tech News (e.g. Talk page) and not to a VE bug report in Bugzilla. General questions like at the end of... [15:29:59] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c8 (10Andre Klapper) (In reply to Quim Gil from comment #7) > it includes ☃ and ♙ ! These specific two icons (snowman ☃ and chess pawn ♙) are a debugging feature of VE and unrelated... [16:52:45] 3MediaWiki extensions / 3TemplateData: TemplateData: GUI editor (tracking) - 10https://bugzilla.wikimedia.org/65544 (10Helder) [16:52:47] 3MediaWiki extensions / 3TemplateData: Unable to select type "string/line" in the GUI editor - 10https://bugzilla.wikimedia.org/66920 (10Helder) 3NEW p:3Unprio s:3normal a:3None I don't see the option to change the type of a parameter to "string/line" when I edit https://pt.wikipedia.org/wiki/Templat... [23:44:14] 3VisualEditor: Hypothetical generation of strange characters at the beginning of pages - 10https://bugzilla.wikimedia.org/65674#c9 (10Drongou) See also Bug 63395