[07:17:33] (03PS8) 10Krinkle: Remove Hiero extension code from VisualEditor extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [07:18:56] (03PS9) 10Krinkle: Remove Hiero extension code from VisualEditor extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [07:18:59] (03CR) 10Krinkle: "Removed 4 messages with keys like 'visualeditor-preference-mwhiero-*' that were no longer used." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [07:19:49] (03CR) 10Krinkle: [C: 032] Remove Hiero extension code from VisualEditor extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [07:21:28] (03Merged) 10jenkins-bot: Remove Hiero extension code from VisualEditor extension [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138948 (owner: 10Esanders) [08:17:25] (03PS26) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [08:36:52] (03PS27) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [08:39:03] (03PS28) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [09:04:38] (03PS29) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [13:49:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (owner: 10Mooeypoo) [14:25:15] 3VisualEditor / 3Data Model: VisualEditor: ISBN link labels (from magic words) can be changed, but not the underlying links - 10https://bugzilla.wikimedia.org/61558#c1 (10NicoV) Other recent examples of ISBN problems caused by VE (awful syntax, link incoherent with displayed ISBN, nowiki added) : https://fr... [14:33:58] Krinkle|detached: Bah, you shouldn't have merged that; see my comments on PS1. :-( [15:25:46] (03PS1) 10Krinkle: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 [15:27:46] 3VisualEditor / 3Editing Tools: Template lookahead finds nothing - 10https://bugzilla.wikimedia.org/66981 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Edit a page at http://en.wikipedia.beta.wmflabs.org Click Template to bring up the inspector Enter something simple into the inspector like "S... [15:32:11] (03PS1) 10Krinkle: build: Update jscs and use new "wikimedia" preset [oojs/core] - 10https://gerrit.wikimedia.org/r/141443 [15:32:16] (03PS5) 10Alex Monk: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (https://bugzilla.wikimedia.org/50341) [15:36:14] (03PS8) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [15:37:32] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [15:39:52] (03PS1) 10Krinkle: build: Update jscs and use new "wikimedia" preset [oojs/ui] - 10https://gerrit.wikimedia.org/r/141445 [15:40:27] (03CR) 10jenkins-bot: [V: 04-1] build: Update jscs and use new "wikimedia" preset [oojs/ui] - 10https://gerrit.wikimedia.org/r/141445 (owner: 10Krinkle) [15:43:11] (03PS2) 10Krinkle: build: Update jscs and use new "wikimedia" preset [oojs/ui] - 10https://gerrit.wikimedia.org/r/141445 [15:47:30] (03CR) 10Krinkle: "Inpsection :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130250 (owner: 10Esanders) [15:49:23] (03CR) 10Jforrester: [C: 032] build: Update jscs and use new "wikimedia" preset [oojs/ui] - 10https://gerrit.wikimedia.org/r/141445 (owner: 10Krinkle) [15:52:28] (03Merged) 10jenkins-bot: build: Update jscs and use new "wikimedia" preset [oojs/ui] - 10https://gerrit.wikimedia.org/r/141445 (owner: 10Krinkle) [15:59:37] (03CR) 10Jforrester: [C: 031] "Neat." [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [16:15:48] (03PS1) 10Alex Monk: Accessibility: Set aria-hidden attribute on elements while dialogs are open [oojs/ui] - 10https://gerrit.wikimedia.org/r/141456 (https://bugzilla.wikimedia.org/65473) [16:19:32] (03PS1) 10Divec: Remove .inIme state from CE Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141457 [16:54:03] (03PS1) 10Krinkle: build: Update jscs and use new "wikimedia" preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141465 [16:56:58] (03CR) 10Jforrester: [C: 032] "Though if we moved UnicodeJS to its own library we could re-enable validateIndentation which would be a nice win." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141465 (owner: 10Krinkle) [16:58:15] (03Merged) 10jenkins-bot: build: Update jscs and use new "wikimedia" preset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141465 (owner: 10Krinkle) [17:09:33] (03CR) 10Divec: "Can someone test this on MacOSX when typing "naïve pâté"?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141457 (owner: 10Divec) [17:25:44] 3VisualEditor: Can drag and drop non-editable elements from outside the VE surface area - 10https://bugzilla.wikimedia.org/56578#c2 (10Elitre) I confirm that it does not happen for me as well - I seem to be able to drag and drop items, but after I do that nothing changes, and as a matter of fact VE won't promp... [18:00:22] (03PS30) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [18:18:20] Krinkle: when you have time, it would be great if you could revisit https://gerrit.wikimedia.org/r/#/c/139473/ [18:29:12] (03CR) 10Catrope: [C: 04-1] Accessibility: Set aria-hidden attribute on elements while dialogs are open (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/141456 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [18:31:16] 3VisualEditor / 3Editing Tools: VisualEditor: Template suggestions are not appearing in Betalabs while trying to add a template - 10https://bugzilla.wikimedia.org/66987 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15699 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15699... [18:33:13] (03PS2) 10Alex Monk: Accessibility: Set aria-hidden attribute on elements while dialogs are open [oojs/ui] - 10https://gerrit.wikimedia.org/r/141456 (https://bugzilla.wikimedia.org/65473) [18:33:46] 3VisualEditor: VisualEditor: Toolbar is sometimes misaligned and ugly at Beta Labs in Safari - 10https://bugzilla.wikimedia.org/66988 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None Created attachment 15700 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15700&action=edit Misaligned toolbar... [18:37:40] (03CR) 10Catrope: [C: 032] Accessibility: Set aria-hidden attribute on elements while dialogs are open [oojs/ui] - 10https://gerrit.wikimedia.org/r/141456 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [18:38:08] (03CR) 10Catrope: [C: 032] Remove .inIme state from CE Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141457 (owner: 10Divec) [18:38:16] (03Merged) 10jenkins-bot: Accessibility: Set aria-hidden attribute on elements while dialogs are open [oojs/ui] - 10https://gerrit.wikimedia.org/r/141456 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk) [18:39:24] (03Merged) 10jenkins-bot: Remove .inIme state from CE Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141457 (owner: 10Divec) [18:40:43] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c17 (10James Forrester) 5PATC>3RESO/FIX I… guess that this is now fixed? [18:41:47] (03PS2) 10Krinkle: build: Update jscs and use new "wikimedia" preset [oojs/core] - 10https://gerrit.wikimedia.org/r/141443 [18:47:29] (03CR) 10Krinkle: "Or we just wait a few days for upstream to make a minor release. They've already fixed it in master. Awesome :)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141465 (owner: 10Krinkle) [18:48:38] (03CR) 10Jforrester: "Wow. Neat. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141465 (owner: 10Krinkle) [18:51:14] James_F, yep, that OOUI accessibility bug is now fixed [18:54:34] Krenair: Awesome. :-) [18:54:42] (I think) [18:55:09] * James_F grins. [18:55:17] I'm sure thedj will correct us if not. [18:58:43] * mooeypoo is back [18:59:05] RoanKattouw, did you see my email by any chance? [18:59:12] mooeypoo: I did [18:59:20] It'll take me some time to respond [18:59:23] * mooeypoo nods [18:59:24] I'm preparing my talk for tomorrow [18:59:26] just making sure [18:59:30] (About browser bugs, incidentally) [18:59:39] Yeah, I know you're leaving tomorrow, that's why I sent it quickly today [18:59:44] Also my Windows laptop is still IE10, not IE11 [18:59:50] I just got the email from my contact this morning [18:59:54] Right, OK [19:00:00] So, off the top of my head [19:00:05] it doesn't have to be a comprehensive list of bugs, just something that shows them the main issues I think [19:00:32] She asked about examples for the issues we encounter with VisualEditor and IE [19:01:23] Yeah [19:01:26] So, I seem to recall [19:01:37] that contentEditable=false doesn't work [19:01:43] But I don't have proof of that offhand [19:01:49] I might test that later today and maybe include it in my talk [19:02:22] There was something like if you nested contentEditable=false twice it did work [19:04:07] mooeypoo: One thing I can tell you right now that it annoys me is the fact that new DOMParser().parseFromString( '', 'text/html' ); returns an HTMLDocument whose .head, .body and .documentElement properties are all null [19:04:15] (this is the bug you were investigating earlier) [19:05:02] * mooeypoo adds that to the list [19:05:04] yeah [19:05:09] What about those security issues? [19:05:25] I don't remember exactly what it was, butI remember it used to be huge.. we solved them by cheating, or something, didn't we? [19:05:32] No we didn't solve them [19:05:34] I remember those [19:05:35] not allowing cross-domain stuff, we had a problem with labs or something? [19:05:39] Let me see if those are still an issue [19:05:44] 3VisualEditor / 3Editing Tools: Template lookahead finds nothing - 10https://bugzilla.wikimedia.org/66981#c1 (10James Forrester) 5NEW>3RESO/DUP Merging with bug 66987. *** This bug has been marked as a duplicate of bug 66987 *** [19:05:44] 3VisualEditor / 3Editing Tools: VisualEditor: Template suggestions are not appearing in Betalabs while trying to add a template - 10https://bugzilla.wikimedia.org/66987#c1 (10James Forrester) *** Bug 66981 has been marked as a duplicate of this bug. *** [19:06:55] btw, what do other browsers return for new DOMParser().parseFromString( '', 'text/html' ); ? [19:07:08] It's an empty string, do they not return null? [19:08:03] ah, I just tested that in chrome and firefox. [19:08:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Template suggestions are not appearing in Betalabs while trying to add a template - 10https://bugzilla.wikimedia.org/66987 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:08:46] mooeypoo: The same as if you passed '' [19:09:02] So my workaround for this is to map the empty string to that [19:09:13] hah, so I spun up IE11 in crossbrowsertesting.com [19:09:20] Who knows how accurate their rendering is, but [19:09:30] I can see right now that highlights aren't rendered as transparent [19:09:33] They're opaque [19:10:04] oy. [19:14:04] err how do I disable the ie block again? [19:14:10] what's the get param? [19:15:52] mooeypoo: ?vewhitelist=1 [19:15:56] I think. [19:16:35] perfect. thanks [19:17:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885 (10Alex Monk) [19:17:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: Incorrect tab text (create vs. edit) shown on Special:MovePage, Special:Undelete, others? - 10https://bugzilla.wikimedia.org/49000 (10Alex Monk) [19:18:27] RoanKattouw, I just loaded VE in IE11 [19:18:50] it actually loaded, unlike last time. IT has errors, but it's up. [19:19:09] the security issues seem to be solved, but I suspect it might be because I forced IE to never use compatibility mode [19:20:45] Sadly IE is forced to compatibility mode for *.wikipedia.org. [19:20:50] Inside the browser. [19:20:53] No way to switch it off. [19:21:16] (That might have been for IE8 compatibility down to IE6 mode, but IIRC it's still an issue.) [19:21:57] mooeypoo: BTW, https://gerrit.wikimedia.org/r/#/c/141093/ is a trivial +2 if you can spare 10s to click. :-) [19:21:57] mooeypoo: OK so I isolated the issue with nontransparent highlights [19:22:05] http://jsfiddle.net/PDt23/ [19:22:13] Compare in Chrome vs IE [19:22:26] Also if you add position: absolute; to .wrapper, it's fixed [19:22:41] Alternatively, move the opacity rule from .wrapper to .highlight (that's probably what I'll do in VE) [19:23:31] mooeypoo: The security issues are for saving [19:23:51] Cross-domain non-origin saving, specifically? [19:25:06] (03PS2) 10JGonera: [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [19:26:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [19:26:49] Yeah well [19:26:57] There are several roadblocks to even testing that right now [19:27:04] The save button does not activate when you edit [19:27:20] (I confirmed this isn't due to the usual cause: surprisingly, history tracking does actually work, and the DM does change) [19:27:37] And even if it did, remember how dialogs are unstyled because our iframe black magic doesn't account for IE? [19:29:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [19:30:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [19:30:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [19:37:28] (03CR) 10Mooeypoo: [C: 032] Sync eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141093 (owner: 10Jforrester) [19:39:09] (03Merged) 10jenkins-bot: Sync eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141093 (owner: 10Jforrester) [19:40:23] RoanKattouw, I remember that I couldn't even load VE because it wanted to load elements from another domain [19:40:31] hang on, let me verify on my WinRT tablet [19:43:44] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885#c1 (10Alex Monk) So it looks like the patch for 49000 was supposed to fix this... [19:45:47] oh wow [19:45:48] it works [19:45:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885 (10Alex Monk) [19:46:37] haha scratch that. RoanKattouw you'll love this: In IE11 I can't put my cursor into a paragraph. It marks the entire paragraph as if it's some object.. can't edit anything. [19:46:49] Yeah I have the same issue [19:46:53] This might be a hasLayout thing [19:46:55] It's also extremely slow [19:47:02] Does the paragraph have a line-height applied to it? [19:47:02] and it's worse in terms of usability in the tablet [19:47:36] RoanKattouw, it has line-height: inherit [19:48:26] oh! this is fascinating. If I'm in "inspect dom" mode? I can actually put my cursor into the paragraph AND type. But when I am out of the inspect-dom mode, It's again all-selected [19:48:29] how weird is that. [19:49:28] RoanKattouw, I'm also getting "object doesn't support property or method 'getBoundingDocumentRect' multiple times [19:53:10] mooeypoo: Hm.. do you have latest lib/ve? [19:53:32] Krinkle: She's running VE in IE [19:53:42] That's a more likely explanation for why it explodes :) [19:54:13] It's been in IE for longer than any other browser though (if MDN is accurate) [19:54:35] Yeah but no [19:54:44] getBoundingCLIENTRect is the browser one [19:54:51] getBoundingDOCUMENTRect is rangy [19:55:10] right [19:55:18] google is "correcting" it [19:55:23] hehe [19:56:34] RoanKattouw, so, I have 2 items on my list to my microsoft friend, 'cause I"m not sure how to present the security issue concisely [19:56:52] the dom parser one, and the fact our highlights are opaque [19:56:56] Yeah [19:57:08] Did you get my jsfiddle link for the highlights? [19:57:15] anything I can add as a big example? or maybe something general? [19:57:20] I mean there are many more bugs, but we haven't tracked them all down yet [19:57:26] Let me try the cE=false thing real quick [19:57:44] RoanKattouw, yeah I also looked at VE in IE11 now and totally see the opaque highlights. bah [19:58:06] RoanKattouw, yeah, I want to give them an idea of "how bad" it is [19:58:25] in terms of why we could use someone to help us along the way [19:58:51] Should I give them a link to testing page with ?vewhitelist=1 and have them see for themselves? :D [20:00:06] I mean that's without a lot of triage [20:00:18] But it might give them an impression of what a clusterfuck it is [20:00:22] Here's the cE=false issue: http://jsfiddle.net/BG8EW/ [20:00:42] If you drop the cursor outside the uneditable block and use arrow keys or backspace, the cursor goes around it [20:00:51] (although backspace doesn't seem to delete it as it should) [20:01:03] But it'll happily let you click inside the uneditable block and start editing it [20:02:34] hm [20:03:22] I mean inability to make things uneditable is a pretty big deal [20:03:45] Yeah [20:03:48] Okay, I added that. [20:04:19] Should I give her a link to some test page in mediawiki.org with ?vewhitelist=1 so they can try? Or wait to see what they say? [20:05:19] You could do that [20:05:31] I mean we probably don't expect them to go triage all of our issues for us [20:05:47] no of course not, but they can see that it looks really bad [20:05:49] But just as a "here's what happens if you don't look at IE for a while and develop for real browsers instead" case study :) [20:06:01] haha [20:09:14] 3OOjs UI: OOjs UI: Dialogs are not accessible - 10https://bugzilla.wikimedia.org/65473#c18 (10Derk-Jan Hartman) Good work ppl, I'm glad to see that we have put effort in this. It is significant more effort than we have put in most other projects on the accessibility front. A very good step forward. [20:09:27] James_F: jscs just made a minor release (1.5.4) and grunt task has a range version as dependency (1.5.x) so itll auto-update next time you purge npm-install locally. [20:09:43] James_F: I removed hte override locally in lib/ve/.jscsrc [20:09:45] 1900 errors [20:09:49] :-/ [20:10:21] something is wrong [20:15:38] (03PS1) 10Krinkle: build: Re-enable validateIndentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141557 [20:15:57] Oh, I thought for a second it reported every single line but we have way more than 1900 lines of code [20:16:09] It's just some files it reported all lines of because of the outer closure indentation [20:16:23] (03CR) 10jenkins-bot: [V: 04-1] build: Re-enable validateIndentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141557 (owner: 10Krinkle) [20:33:34] Krinkle: Remove the spaces-in-arrays thing and you get ~4500 errors. [20:33:42] yeah [20:33:50] * James_F gave up trying to fix that with regexes. [20:33:52] I'll do validateIndentation for now, relatively easy. [20:34:06] just shift-select and cmd+] to indent [20:34:38] and affects readability in some cases so more useful than spaces in array and quotes which are mostly just a consistency thing [20:35:04] though I do notice it influencing readability once you get used to seeing spaces in arrays [20:35:13] and then not having them [20:37:48] One of the football players's names (Neymar, Brazil) sounds like "Nee maar" (Dutch for "Oh, really?). Subject of laughter (and confusion at first) in the Dutch commentary for the CMR-BRA match. [20:39:19] (03PS2) 10Krinkle: build: Re-enable validateIndentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141557 [20:39:32] * James_F nods. [20:42:26] swift review on the +2144, -2130 indent fix would be appreciated :) [20:44:07] * James_F checks. [20:45:59] (03CR) 10Jforrester: [C: 032] build: Re-enable validateIndentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141557 (owner: 10Krinkle) [20:47:14] (03Merged) 10jenkins-bot: build: Re-enable validateIndentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141557 (owner: 10Krinkle) [20:48:54] (03PS3) 10JGonera: [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [20:49:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [20:55:56] James_F: thx [21:00:30] 3VisualEditor / 3ContentEditable: VisualEditor: Swapping an existing reference scrolls viewport to top - 10https://bugzilla.wikimedia.org/66462#c3 (10ryasmeen) Verified the fix in test2 and Betalabs. [21:04:32] Krinkle: Hey. [21:04:57] Krinkle: I'm getting "Warning: Cannot read property 'type' of undefined Use --force to continue." when running npm test on VE-core master. [21:05:06] Krinkle: And yes, I've npm install'ed. [21:06:21] James_F: Since the version bump was implicit (grunt-jscs depends on 1.5.x not 1.5.4) npm-install doesn't fetch it by default because the one that got installed when you ran npm-install earlier satisfies 1.5.x [21:06:27] rm -rf node_modules/ and re-run npm install [21:06:36] Aha. [21:06:47] grunt-jscs is still at 0.6.0, no change there. [21:07:17] * James_F nods. Yeah, working now. Thanks! [21:28:32] 3VisualEditor / 3Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Created attachment 15702 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15702&action=edit Double tap required If yo... [21:38:01] Krinkle: how do you generate OOUI docs? [21:38:08] there's no bin dir, no .docs dir [21:38:16] is it a grunt command? [21:38:16] 3VisualEditor / 3Mobile: Second tap on a reference closes VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None As mentioned in bug 66999 references require two taps on iOS Safari. Often, the first tap results in a lighter "semi-selection" appea... [21:38:20] TrevorParscal: No [21:38:34] TrevorParscal: The .sh files we have elsewhere are only because of the custom plugins it needs to register [21:38:44] 3VisualEditor / 3Mobile: Second tap on a reference closes VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c1 (10Juliusz Gonera) Created attachment 15703 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15703&action=edit Editor closes [21:38:46] in oojs-ui is is just plain jsduck.json, no bash magic [21:38:51] jsduck jsduck.config.json [21:38:54] like that? [21:38:59] so you run jsduck --config=jsduck.config.json [21:38:59] 3VisualEditor / 3Mobile: Second tap on a reference closes VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c2 (10Juliusz Gonera) Created attachment 15704 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15704&action=edit Editor shows confirmation dialog [21:39:16] or a space instead of '=' ,but yeah [21:40:00] I'm hoping to phase out the sh files for jsduck in VE as well, makes it harder to run in Jenkins. I'd rather standardise it like jshint and jscs without needing a custom sh file. [21:40:19] right on [21:40:22] After we rename it to jsduck.json, you can also omit the --config argument [21:40:27] right [21:40:29] jsduck.json is the default (like jshintrc for jshint) [21:40:29] that will be nice [21:40:51] My calling it .docs/config.json and jsduck.config.json predates that feature existing in jsduck [21:41:19] Krinkle: Renaming it requires a parallel change in JJBC I guess? [21:41:32] Yes, that's why I've held off for now. Needs orchestration. [21:41:57] I suppose we could try a symlink if we really want to maintain both for a while. [21:42:38] * James_F nods. [21:43:44] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326#c1 (10Juliusz Gonera) This bug happens on any iOS Safari probably. The link doesn't seem to go to the destination in some cases (in... [21:44:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326#c2 (10Juliusz Gonera) Created attachment 15705 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15705&action=edit Link is fol... [21:47:45] James_F, how do I subscribe to ve-tech? [21:49:06] jgonera: Ask me. :-) [21:49:39] James_F, how do I subscribe to ve-tech? ;) [21:49:52] * James_F grins. [21:51:14] jgonera: {{Done}}. :-) [21:51:18] thanks! [21:52:03] oh, James_F, I thought there was a Wikimedia mailing list called "ve-tech" too, you don't use that? [21:52:49] jgonera: No, it's a Google Group. [21:52:56] or maybe a different question James_F, I want to cross-post something to mobile-l and X about VE on mobile, where should I post it? [21:53:05] i.e. what is X [21:53:33] jgonera: Oh. We generally use wikitech-l; wikitext-l exists and maybe we should use that instead. [21:53:46] hm [21:56:02] Are Sherry or Trevor around? [21:56:32] TrevorParscal is here [21:57:59] 3VisualEditor / 3Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c1 (10Juliusz Gonera) Ignore wrong positioning of mobile context (second toolbar), it's fixed now. To actually see the context though you need those patches: https://gerrit.wikimedia.o... [21:58:18] TrevorParscal, for https://bugzilla.wikimedia.org/show_bug.cgi?id=51798 I wanted to show a (small) popup of text on hover/click.. Is there a proper way of doing this with OOUI? [21:59:05] PopupButtonWidget [21:59:24] it's a button (which you can configure to be framed, or not, icon or not, label or not, indicator or not, etc. [21:59:29] and it's got a popup [21:59:32] which when clicked is shown [21:59:49] Oh, that sounds exactly like what I was looking for. Great, thanks [21:59:49] and the popup and button interact consistently (toggle, event bubbling, etc.) [21:59:50] TrevorParscal, I have a couple of comments about stack layout. [22:00:11] getPopup() will give you the PopupWidget (see PopuppableElement) [22:00:16] mooeypoo: yes? [22:00:22] you want to kill it? [22:00:31] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326 (10Juliusz Gonera) 5ASSI>3NEW a:5Jon>3None [22:00:36] * TrevorParscal stands back [22:00:47] TrevorParscal, stack layout has a setPage (or similar, I'm looking ro the code) but from my going over the other code that uses stack layout, like meta and template dialogs, it seems whoever is using it should do the logic of the switching [22:01:02] so why not add the hide/show of the proper panel to the stack layout itself? [22:01:21] setItem( layoutObject ) [22:01:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link inside mobile VE with iPad Mini/iPad 2 redirects to the link target page - 10https://bugzilla.wikimedia.org/65326#c3 (10Juliusz Gonera) Jon has never worked on this bug. [22:01:40] StackLayout #149 [22:01:54] aye. But that doesn't seem to work. I had to .hide() and.show() the panels [22:02:00] TrevorParscal, see line #610 https://gerrit.wikimedia.org/r/#/c/140813/6/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js [22:02:24] I may have done it wrong, but from my reading of the other two dialogs, it's either not working in ooui directly, or it's really unclear? [22:02:26] they panels should be shown in their CSS,a nd this will override their inline display properties (the way hide and show do) [22:02:49] but it doesn't. If I don't actively show/hide the proper panels, I get one on top of the other [22:02:56] all visible. And when I choose setItem() it does nothing [22:03:00] it's supposed to work like a group element, addItems, removeItems, clearItems, with the addition of mutually exclusive visibility, setItem [22:03:07] so either I didn't do something right in the initialization, or it doesn't work right? [22:03:22] seems odd [22:03:24] I got them all stacked on top of one another. [22:03:38] because BookletLayout uses setItem [22:03:41] see meta dialog, too, it doesn't use setItem, it seems to reload itself [22:03:44] James_F, I'm not sure how to do this then, should I post to mobile-l (so that mobile people can see it) and CC all the members of VE? [22:03:44] and does nothing with visiblity itself [22:03:47] hmmm [22:03:55] setPage uses setItem [22:04:00] BookletLayout #399 [22:04:17] jgonera: Why are you posting to mobile-l? To get external input? If so, you should probably post to wikitech-l too. [22:04:26] TrevorParscal, I don't know, when I comment out the show/hide in that code, it gets all stacked on top of one another despite the fact I choose the layout object. TrevorParscal Did I choose the wrong object maybe? [22:04:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog animates size while animating open if it was large when it was closed - 10https://bugzilla.wikimedia.org/62859#c2 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki) [22:05:13] TrevorParscal, see line 613 and 620, I go 'setItem()' on the layout objects, either bookletLayout or mediaSearchPanel (which is a panel) maybe that's why it doesn't work? [22:05:23] James_F, it's more about transparency rather than input (in an unlikely case of a volunteer wanting to work on something I'll write about) [22:06:00] James_F, I want to point out three important bugs that need to be fixed in VE so that it works on iPads [22:06:06] * James_F nods. [22:06:08] TrevorParscal, I got really confused with it. I am not sure if it ended up working because I cheated my way into forcing it to work, or if there's something inherently confusing with it [22:06:24] Wikitech-l is fine for that. [22:06:24] ok [22:06:35] stackLayout = new OO.ui.StackLayout(); /* add some items */ stackLayout.setItem( oneOfTheItemsYouAdded ); [22:06:41] I'll still CC you so that it doesn't get lost, James_F [22:08:10] jgonera: Cool. :-) [22:08:48] TrevorParscal, is 'panel' a layout object? [22:09:08] they are both Layouts [22:09:19] StackLayout can contain any number of PanelLayout objects [22:09:22] okay. I got confused iwth that a bit. [22:09:33] Layout is like Widget, they are all layouts [22:09:41] TrevorParscal, alright, it didn't work for me when I tried it straight forward, but let me try it again just to make sure. [22:11:27] TrevorParscal, I'm sorry, it doesn't work :\ [22:12:05] TrevorParscal, I commented out all *my* hide/show code and only kept the 'this.panels.setItem( this.bookletLayout ) and this.panels.setItem( this.mediaSearchPanel ) [22:12:23] when either one of thise is clicked, the new layout is visible *on top* of the old layout (the old layout is not hidden) [22:12:32] if that's a bug, I can try and fix it up in OOJS [22:12:38] err OOUI i mean [22:12:55] you must be doing something strange, look at how ve.ui.MWReferenceDialog works [22:14:02] :\ weird. [22:14:14] weeeeeird. What am I doing wrong. Maybe I set them up wrong? [22:14:35] you use the proper { '$': this.$ } ? [22:15:51] let me verify [22:16:45] ... yes :\ [22:17:25] (03PS7) 10Mooeypoo: [wip] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [22:17:37] TrevorParscal, ^^ I commented out my hide/show and only left setItem() [22:18:22] the only thing that seems to be different from the reference dialog is that I use two different layouts.. BookletLayout and PanelLayout [22:18:56] other than that, I think I'm doing it pretty much the same [22:19:26] Initializing the definition.. doing this.panels.addItems( [ ... ] ) and this.panels.setItem( this.bookletLayout ) [22:21:23] The booklet layout isn't getting hidden. [22:29:27] Well if you call setItem( this.bookletLayout ) of course it doesn't get hidden [22:29:35] Did you mean the other way arond? [22:30:14] ooooh hold on [22:30:19] Maybe it's a CSS override thing? [22:30:28] It seems like there's CSS causing things inside of a StackLayout to be display: none; [22:30:34] Maybe there's something stronger making it visible again [22:31:01] 3VisualEditor: VisualEditor: Broken Kloutify browser extension injects garbage into the page - 10https://bugzilla.wikimedia.org/67006 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/w/index.php?title=Lobstick&curid=43120379&diff=614082884&oldid=614013920 The user edited the... [22:31:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken browser plugins cause cruft to be injected into the page (tracker) - 10https://bugzilla.wikimedia.org/52327 (10WhatamIdoing) [22:31:14] 3VisualEditor: VisualEditor: Broken Kloutify browser extension injects garbage into the page - 10https://bugzilla.wikimedia.org/67006 (10WhatamIdoing) [22:32:36] RoanKattouw, yeah [22:32:42] I switch between the two panels. [22:33:07] The booklet layout always appears. But when I call setItem( this.mediaSearchPanel ) the panel appears *behind* the booklet [22:33:22] that, and a minor fix I just added ,seem to be the only things that stop this from being taken out of WIP [22:38:38] Krinkle: How do I increase the timeout for PhantomJS so it gives me results? [22:38:52] James_F: context? [22:39:31] Krinkle: VE-core. Running npm test. In qunit:ve, I get FF....F..F etc. and then "PhantomJS timed out, possibly due to a missing QUnit start() call.". [22:40:03] That message about the start() is just bogus. [22:40:12] Does it not show the F errors somewhere? [22:40:14] try --verbose [22:40:19] grunt test --verbose [22:40:29] Ah, OK. [22:40:36] Normally it tells you the failures on exit. [22:40:52] yeah, you may wanna file an upstream bug against grunt-contrib-qunit [22:41:10] I can't give them an easy reproduction, though. [22:41:56] (03PS4) 10JGonera: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [22:43:02] (03CR) 10jenkins-bot: [V: 04-1] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [22:43:32] TrevorParscal, hmm. Yeah, actually I don't want a proper button at all [22:43:56] I just want an icon which shows some popup text when you click on it [22:46:12] (03PS5) 10JGonera: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [22:49:24] (03CR) 10jenkins-bot: [V: 04-1] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [23:25:33] (03PS8) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [23:25:45] James_F, it's out of WIP, but really should be tested more [23:26:01] James_F, also, I didn't find a bug for it, is there one? I thought there might be? [23:26:03] (03PS6) 10JGonera: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [23:47:35] >>> [].splice.apply( [], new Array( 65535 ) ) [23:47:35] RoanKattouw: RangeError: Maximum call stack size exceeded [23:47:41] >>> [].splice.apply( [], new Array( 65500 ) ) [23:47:41] RoanKattouw: RangeError: Maximum call stack size exceeded [23:47:46] >>> [].splice.apply( [], new Array( 100 ) ) [23:47:47] RoanKattouw: (object) [] [23:47:50] >>> [].splice.apply( [], new Array( 1000 ) ) [23:47:50] RoanKattouw: (object) [] [23:47:53] >>> [].splice.apply( [], new Array( 2000 ) ) [23:47:53] RoanKattouw: (object) [] [23:49:29] lolwut [23:49:34] This thing has a weird argument length limit [23:49:37] >>> [].splice.apply( [], new Array( 62145 ) ) [23:49:38] RoanKattouw: (object) [] [23:49:40] >>> [].splice.apply( [], new Array( 62146 ) ) [23:49:40] RoanKattouw: RangeError: Maximum call stack size exceeded [23:53:48] 62146 ?