[00:02:20] (03PS1) 10Jforrester: Split out ve.{dm,ce}.TextStyleAnnotation into parts and add other HTML5 annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 [00:04:01] (03PS2) 10Jforrester: Split out ve.{dm,ce}.TextStyleAnnotation into parts and add other HTML5 annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 [00:04:19] (03CR) 10Jforrester: "PS2 remembers to git add the output of grunt. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (owner: 10Jforrester) [00:08:02] (03PS3) 10Jforrester: Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) [00:11:14] 3VisualEditor: VisualEditor not working with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c2 (10Kevin Stange) I can confirm this bug. It is throwing the following JS exception: Exception thrown by ext.visualEditor.core Error: constructor must be a function, cannot be a undefined The exception get... [00:13:45] TrevorParscal, the patch I was talking about (that moves a lot of stuff in Contexts): https://gerrit.wikimedia.org/r/#/c/141085/ [00:19:41] cool, thanks [00:20:35] (03PS4) 10Jforrester: Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) [00:21:01] (03CR) 10Jforrester: "PS4 restores a test suite accidentally blanked(!?)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) (owner: 10Jforrester) [00:24:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Formula icon is missing in the Insert menu - 10https://bugzilla.wikimedia.org/66890#c3 (10ryasmeen) 5ASSI>3RESO/FIX Works in Betalabs too now. [00:47:29] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/140560/3 is Timo's JSON patch. [01:09:00] 3VisualEditor / 3Editing Tools: VisualEditor: Support the tag as a text annotation - 10https://bugzilla.wikimedia.org/64376 (10James Forrester) a:3James Forrester [01:09:15] 3VisualEditor / 3Editing Tools: VisualEditor: Support the tag as a text annotation - 10https://bugzilla.wikimedia.org/52664 (10James Forrester) a:3James Forrester [01:20:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [01:22:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) 5NEW>3ASSI [01:22:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10James Forrester) [01:23:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [01:23:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10James Forrester) [01:25:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c3 (10James Forrester) a:3Ed Sanders Pushing to Ed because it appears to be a shield/highlight issue. [01:25:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c2 (10James Forrester) a:3Ed Sanders Pushing to Ed because it appears to be a shield/highlight issue. [01:25:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c4 (10James Forrester) a:3Ed Sanders Pushing to Ed because it appears to be a shield/highlight issue. [01:29:29] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762 (10James Forrester) 5NEW>3ASSI [01:54:26] (03PS1) 10Jforrester: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) [01:54:45] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as small - 10https://bugzilla.wikimedia.org/51614 (10James Forrester) 5PATC>3ASSI a:3James Forrester [01:54:58] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as small - 10https://bugzilla.wikimedia.org/51614 (10James Forrester) 5ASSI>3PATC [01:55:15] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as big - 10https://bugzilla.wikimedia.org/51613 (10James Forrester) a:3James Forrester [09:25:56] RoanKattouw_away: Argument limit for apply is dynamic in V8. You'll find the same in Chrome. Per engine life time it's different. [09:26:16] e.g. when you reload the page it'll be a fresh start. In ecmabot-wm I'm not sure how it's done. I think I have it create a completely fresh vm for each command. [09:26:59] 3VisualEditor: VisualEditor not working with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c3 (10Hermann Schwärzler) Hello Kevin, thank you for the confirmation and the additional information! Switching to the git-Version of VisualEditor and using branch wmf/1.23wmf22 did indeed make it work for me... [09:59:29] 3VisualEditor: VisualEditor not working with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c4 (10Krinkle) Relevant commits that were in wmf/1.23wmf22 but not in REL1_23 yet: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/compare/REL1_23...wmf/1.23wmf22 https://github.com/wikimedia/V... [10:00:14] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519 (10Krinkle) [12:10:11] "Foundation's Editing (formerly VisualEditor) team" huh. [12:11:02] (03Abandoned) 10Zfilipin: [BrowserTest] Finding minimum bounding rectangle for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141295 (owner: 10Vikassy) [12:12:20] the minutes are all about performance, yet they don't even mention section editing :( [12:12:51] (03PS31) 10Zfilipin: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [12:21:17] (03PS32) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [12:54:55] (03PS1) 10Esanders: Compress HTML data with deflate before POSTing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) [12:55:10] (03PS2) 10Esanders: Compress HTML data with deflate before POSTing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) [12:55:48] (03CR) 10Esanders: "Going to need some cross browser testing and performance testing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [12:56:32] (03CR) 10jenkins-bot: [V: 04-1] Compress HTML data with deflate before POSTing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [13:34:38] (03CR) 10Bartosz Dziewoński: "(Sorry to sound like a broken record, and I understand that this is not directly related to this patch, but has anyone even considered imp" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [14:10:58] (03PS33) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [14:14:41] (03PS34) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [14:22:09] (03CR) 10Esanders: "Yes, it's been discussed at great length, but potentially unbalanced HTML makes it a lot more complicated than you think." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [14:25:56] (03PS35) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [14:27:14] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c6 (10Ed Sanders) WFM in Firefox at http://en.wikipedia.beta.wmflabs.org/wiki/WikiNo... [14:43:13] (03CR) 10Bartosz Dziewoński: "I know that it's between hard and impossible in the general case (bad HTML, headings inside tables, headings in templates, all sorts of we" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [15:02:59] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c7 (10James Forrester) 5ASSI>3RESO/FIX Probably a deployment issue; fixed on MW.... [15:21:49] (03CR) 10Esanders: "As you say this is a bit off topic, that issue can be discussed at bug 48429 https://bugzilla.wikimedia.org/show_bug.cgi?id=48429" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [15:32:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914#c3 (10Ed Sanders) There are a number of things we can do to avoid this heavy payload: * Section editing * Separating Parsoid metadata * Sending differential linmod data using a serv... [15:36:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c3 (10Ed Sanders) Isn't this fixed then (comment 1)? [16:30:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914 (10Gabriel Wicke) [16:30:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171 (10Gabriel Wicke) [16:39:11] (03PS3) 10Esanders: Compress HTML data with deflate before POSTing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) [16:41:25] (03CR) 10Jforrester: Compress HTML data with deflate before POSTing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [16:43:44] 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator - 10https://bugzilla.wikimedia.org/66894#c1 (10Ed Sanders) The MW message includes HTML. Ew. [16:45:44] 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator - 10https://bugzilla.wikimedia.org/66894#c2 (10Ed Sanders) ...but it gets converted. Hm. [17:08:50] (03PS9) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [17:15:24] crap, I have eg-iframe in there [17:19:33] mooeypoo: Hmm, thought I fixed and merged that one? [17:21:13] mooeypoo: https://gerrit.wikimedia.org/r/#/c/141093/ [17:21:20] mooeypoo: Just rebase and it should work. [17:21:57] mooeypoo: Or I can? [17:25:13] James_F, yeah i will ni a few [17:25:34] i have a local commit that depends on this one, so I don't want to mess it up with a rebase before I send it first to gerrit? [17:26:07] mooeypoo: Sure; it'll probably rebase automagically. [17:26:39] I'm hoping I did the local dependency correctly, too. [17:38:09] ryasmeen: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/MobileFrontend,dashboards/default [17:42:38] Thanks James_F [17:58:18] (03PS14) 10Krinkle: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [17:58:31] (03PS2) 10Krinkle: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://bugzilla.wikimedia.org/49996) (owner: 10Alex Monk) [18:00:16] (03CR) 10jenkins-bot: [V: 04-1] Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [18:00:46] 3VisualEditor / 3ContentEditable: VisualEditor: On Chrome, new relocatable node does not work - 10https://bugzilla.wikimedia.org/67040 (10Trevor (Wikia)) 3NEW p:3Unprio s:3normal a:3None https://www.mediawiki.org/wiki/VisualEditor:Test1234?veaction=edit Dragging the image on this page on Chrome Vers... [18:03:15] (03PS15) 10Jforrester: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) [18:03:30] (03CR) 10Jforrester: "PS15 fixes the code indentation issue." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [18:16:45] 3VisualEditor: VisualEditor: REL1_23 branch not compatible with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c5 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3High a:3James Forrester I've updated REL1_23 to just simply use 1.23wmf22 instead, which should fix the incompatibility. Sorry abou... [18:19:59] 3VisualEditor / 3ContentEditable: VisualEditor: On Chrome, new relocatable node does not work - 10https://bugzilla.wikimedia.org/67040#c1 (10George Marbulcanti (Wikia)) https://www.mediawiki.org/wiki/VisualEditor:Test1234?veaction=edit Similarly, the interaction is not working for me on Chrome 35.0.1916.153... [18:41:35] VE gadget question: Is there anywhere that lists out more detail about what you can send to insertContent? [18:42:20] Rosencrantz: You mean more than https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.dm.SurfaceFragment-method-insertContent ? [18:43:00] Maaaybe, didn't know about that.. let me take a look at it [18:43:08] I was looking at https://www.mediawiki.org/wiki/VisualEditor_gadgets [18:43:10] It's not very helpful, to be fair. [18:43:23] That page should probably link to the documentation. :_() [18:43:24] Well.. better question [18:43:43] Is it possible to make a gadget that can insert a table? [18:43:49] Definitely. [18:44:18] Ok.. one of the big asks we got from our users.. I was going to try and throw it at one of our development teams, but was checking to see if it was a reasonable request first [18:44:32] * James_F nods. [18:46:54] Awesome, thanks [18:47:13] Rosencrantz: The "Array" is an array of linear model entries. [18:48:48] Rosencrantz: So something like [ {'type': 'table'}, {'type': 'tr'}, {'type': 'td'}, {'type': 'paragraph'}, '1', {'type': '/paragraph'}, {'type': '/td'}, {'type': '/tr'}, {'type': '/table'} ] [18:49:00] Aaaaaaaaaah [18:49:17] More tds / trs to suit. [18:49:20] I got the type table to work, just by context, but wasn't sure where to go from there [18:49:34] * James_F nods. [18:49:53] You can also insert tbody etc. but it'll get ignored on save by Parsoid (because MW ignores them). [18:49:59] th works. [18:50:03] And captions. [19:00:36] (03PS1) 10Mooeypoo: [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [19:02:03] (03PS10) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [19:02:13] (03PS2) 10Mooeypoo: [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [19:07:39] oooh we got an interesting bug report from hewiki [19:07:56] about links in references [19:08:14] It's not rtl-specific, either [19:10:10] mooeypoo: Fun. :-( [19:11:09] Rosencrantz: https://www.mediawiki.org/wiki/VisualEditor_gadgets#Adding_a_table is a working code snippet for that, FWIW. [19:12:10] James_F: Even better! Thanks! [19:12:21] Rosencrantz: Happy to help. [19:12:46] 3VisualEditor / 3Editing Tools: Images change size when in edit mode - 10https://bugzilla.wikimedia.org/67047 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None When editing "default size" in mw prefs is not honored [19:14:29] 3VisualEditor / 3Editing Tools: Scrolling a long template parameter, then clicking causes the cursor to jump to the top of the long parameter field - 10https://bugzilla.wikimedia.org/63135#c1 (10Trevor (Wikia)) 5NEW>3RESO/WOR I think this is now fixed on production, and this ticket should be closed. [19:18:49] James_F, I think it also has to do with the general way we deal with inspectors [19:19:52] mooeypoo: If you don't file it in Bugzilla how can I judge? :-) [19:20:13] James_F, I'm trying to phrase it [19:20:20] * mooeypoo is adding the bug now [19:21:46] 3VisualEditor / 3Editing Tools: When adding a link to a reference without dismissing the link inspector, the link isn't applied - 10https://bugzilla.wikimedia.org/67049 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None When adding a link inside a reference in VisualEditor, if one clicks 'apply... [19:21:49] James_F, my best attempt at phrasing this bug [19:23:33] Ta. [19:27:00] mooeypoo: 67049 looks like a race condition. [19:27:16] mooeypoo: Same thing as closing inspectors when the save button is pressed. [19:30:29] 3VisualEditor / 3Editing Tools: VisualEditor: Adding new content via an inspector (formula, gallery, hiero, etc.) and opening the save dialog results in confusion - 10https://bugzilla.wikimedia.org/60837 (10James Forrester) [19:30:29] 3VisualEditor / 3Editing Tools: VisualEditor: When adding a link to a reference without dismissing the link inspector, the link isn't applied (race condition) - 10https://bugzilla.wikimedia.org/67049#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Maybe we just need to give the edit box focus whe... [19:32:22] James_F, yep, that's why I mentioned it might be a general inspector thing. It probably happens with all inspectors [19:33:21] mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=60837 fixed this for the save dialog; it /should/ be simple to do the same for the two other cases (reference and media) to fix this bug, probably. [19:40:34] יצ [19:40:38] hm [19:48:15] ... RoanKattouw aren't you supposed to be like.. airborne ? [19:48:59] No I gave my talk already [19:49:01] SF-Portland is only like 500 miles [19:49:08] wait, that's not the right word, is it? unless you're contagious. [19:49:10] So I got on the bus at 4:15am, plane at 6am, landed at 7:30, was here at 8:30, gave my talk at 10 [19:49:15] Oh! How was it! [19:49:22] Now I'm waiting for the lunch line to subside [19:49:30] It was good! People laughed and asked questions and things [19:49:35] Great! [19:49:44] I hope they laughed at the things you wanted them to laugh. [19:49:49] :D [19:49:55] According to the room monitor 22 people showed up [19:49:58] This included an old boss of mine who I hadn't seen in a while [19:50:01] And Liz Henry (Mozilla bug wrangler) entered the room on cue [19:50:06] ooo [19:50:31] just as I was thanking her for responding to Kaldari's pokes regarding a 12-year-old Firefox bug that was fixed in the FF30 release (released two weeks ago) [19:51:17] James_F: Retrospectively I should have taken all of those video converters with me; my VGA converter that worked at the office didn't work here :( [19:51:29] A kind volunteer ran to Office Depot and got me an HDMI cable instead [19:51:53] oh nice [19:58:45] 3VisualEditor / 3ContentEditable: VisualEditor: On Chrome, new relocatable node does not work - 10https://bugzilla.wikimedia.org/67040#c2 (10Roan Kattouw) 5NEW>3ASSI a:3Ed Sanders Works for me in Chrome 34 but broken for me in Firefox 30 (both on Ubuntu 14.04) [19:59:56] rmoen: Hey man, are you at OSB today by any chance? [20:00:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Template suggestions are not appearing in Betalabs while trying to add a template - 10https://bugzilla.wikimedia.org/66987#c2 (10ryasmeen) 5ASSI>3RESO/FIX This is fixed now. [20:02:03] RoanKattouw: I'm not there today but might make an appearance tomorrow or Thurs. Not sure really. [20:03:58] OK [20:05:29] 3VisualEditor / 3ContentEditable: VisualEditor: On Chrome, new relocatable node does not work - 10https://bugzilla.wikimedia.org/67040#c3 (10Trevor (Wikia)) Update to my earlier comment. It's working for me on Firefox 30, Mac OSX 10.9.3 [20:06:02] I'm only here for the day [20:06:16] Steven is giving a talk later, on Thursday I think [20:09:44] what's up, kflorenc1 [20:11:35] RoanKattouw: awe, yeah i sorta got a bit of heat exhaustion Sunday so I've been just hanging in the house these last couple of days. I think I will make it out Thursday [20:12:46] RoanKattouw: Ah well. [20:14:13] rmoen: Crap, feel better man [20:57:05] hello :) [20:57:32] I have a question about a weird thing a user just noticed at it.wp. [20:58:25] He was adding categories, and while typing he noticed VE would suggest 3 categories based on what he was typing. [20:58:49] Two of them exist; the other one doesn't, and it never did. [20:59:59] so, search engine bug is my guess, but I wanted to check - I can file this in case, or add to the main one about search results not being perfect. [21:00:25] James_F: thoughts? :) [21:15:15] TrevorParscal, so when I asked about popups yesterday you suggested I try PopupButtonWidget [21:15:31] But I want it on an icon instead of a button [21:20:41] * Elitre feels lonely and neglected. [21:22:21] Elitre, it might be a bug. . . Can you show me exactly what is going on? [21:24:23] krenair, sure! just one sec. [21:26:15] you can head to https://it.wikipedia.org/wiki/Utente:Elitre_%28WMF%29/Sandbox_VE?veaction=edit , for example, and try to add a category. If you start typing "Terminologia dello", it will suggest "Terminologia dello sport". but that category doesn't exist and never did. (There's no page or template called Terminologia dello sport either). [21:42:07] Elitre, well the databases certainly thinks it exists [21:45:51] Elitre, I have no idea why the search returns that. Sorry. [21:46:27] link to https://it.wikipedia.org/w/api.php?format=json&uselang=en-gb&action=query&list=allcategories&acprefix=Terminologia+dello+sport&acprop=hidden&redirects= if you make a bug [21:48:55] thanks, krenair. [21:49:15] James_F, around? [22:13:42] Krenair: In meeting but around-ish. [22:17:47] James_F, what are the default options for enwiki for VE? I'm asking about what mw.config.get( 'wgVisualEditorConfig' ) returns. Where is it set, mediawiki-config? [22:18:01] jgonera: Yes. [22:18:08] * James_F looks. [22:18:31] James_F, where specifically? I tried grepping for defaultUserOptions but found nothing [22:19:02] jgonera: See lines 1881+ of CommonSettings.php [22:20:41] hm. James_F so far, the bug I reported seems to be not as easy as I thought .. the internal surface doesn't seem to react to getting focus like the main document does. [22:20:51] mooeypoo: Hmm. Ask edsanders? [22:20:55] mooeypoo: He fixed the original. [22:22:42] edsanders, you around? I'm trying to replicate your solution to applying the link even if the inspector isn't closed when 'save' is pressed -- to the reference dialog. But setting focus() to the CE surface of the referenceSurface doesn't seem to work. [22:23:15] James_F, thanks [22:23:25] jgonera: Is that what you needed? [22:23:30] edsanders, I'm talking about your fix: https://gerrit.wikimedia.org/r/#/c/112893/1/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js [22:23:36] probably James_F [22:23:48] jgonera: Sorry it's so complex; we've had a bunch of different configs over time. [22:26:33] James_F, so in InitialiseSettings.php, L11268, there's "default" and "visualeditor-default". What is the latter for? [22:26:59] jgonera: visualeditor-default == "all users get VisualEditor unless they opt out". [22:27:16] jgonera: default == "this happens if nothing else is matched". [22:27:27] yeah, but what does that mean? I'm used to seeing "default", "enwiki", "testwiki", etc. in those settings [22:27:35] so basically, instances of mediawiki [22:28:03] Ah, dammit, looks like my bouncer died and I didn't realise my messages weren't going through. I had been expecting it to do that at some point... [22:35:42] jgonera, visualeditor-default is a dblist [22:35:59] Just like every other dblist in that repo [22:36:51] Open up visualeditor-default.dblist to see what individual wikis it refers to [22:41:23] thanks Krenair [22:52:08] James_F, did the setting for VE change recently on enwiki? I mean, didn't it use to be the default? is it opt-in now? [22:52:25] jgonera: It was opt-out, then switched to opt-in, yes. [22:52:40] James_F, when did this happen, more or less? [22:54:11] jgonera: Opt-out in June 2013; opt-in in September 2013. [22:54:26] I see, thanks [23:09:15] James_F, a patch to mediawiki-vagrant to make it resemble enwiki: https://gerrit.wikimedia.org/r/#/c/141860/ [23:24:43] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c5 (10Juliusz Gonera) *** Bug 66559 has been marked as a duplicate of this bug. ***