[00:07:32] 3VisualEditor / 3MediaWiki integration: VisualEditor:
not always preventing editing in VE - 10https://bugzilla.wikimedia.org/53767#c14 (10James Forrester) 5ASSI>3RESO/WON (In reply to This, that and the other from comment #13) > As it stands, this is a dupe of bug 52141.... [00:10:18] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863 (10James Forrester) p:5Unprio>3High [00:11:32] 3VisualEditor / 3Editing Tools: VisualEditor: Provide an action button on images to make them default sized - 10https://bugzilla.wikimedia.org/67048 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest s:5normal>3enhanc [00:14:17] 3VisualEditor / 3Editing Tools: VisualEditor: Display "default" sized images in user-preference default size rather than wiki-standard default size - 10https://bugzilla.wikimedia.org/67047#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest s:5normal>3enhanc This is verging on a WONTFIX; we activ... [00:15:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Only display the wikitext warning once per session - 10https://bugzilla.wikimedia.org/67083#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Lowest s:5normal>3enhanc Not sure that this is not a WONTFIX. We don't really want it to be lost on users... [00:17:02] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor is appearing in the read mode in Firefox after canceling the edit in VE - 10https://bugzilla.wikimedia.org/67106 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:18:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken Kloutify browser extension injects garbage into the page - 10https://bugzilla.wikimedia.org/67006 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [00:18:33] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor a:3Alex Monk [00:18:47] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c1 (10James Forrester) I blame mwTitle. Because it's always at fault. [00:19:47] 3MediaWiki extensions / 3TemplateData: TemplateData: Unable to select type "string/line" in the GUI editor - 10https://bugzilla.wikimedia.org/66920#c1 (10James Forrester) Didn't we remove those sub-types? [00:20:48] 3OOjs UI: OOjs UI: The Cancel dialog should not have an X (just "Continue editing" and "Discard edits"), and if it does, clicking it shouldn't discard changes - 10https://bugzilla.wikimedia.org/66851 (10James Forrester) 5NEW>3PATC p:5Unprio>3Normal a:3Trevor Parscal [00:20:49] 3OOjs UI: OOjs UI: The Cancel dialog should not have an X (just "Continue editing" and "Discard edits"), and if it does, clicking it shouldn't discard changes - 10https://bugzilla.wikimedia.org/66851 (10James Forrester) 5NEW>3PATC p:5Unprio>3Normal a:3Trevor Parscal [00:21:07] (03CR) 10Jforrester: [WIP|BREAKING CHANGE] The great and terrible dialog refactor (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:28:47] 3VisualEditor / 3ContentEditable: VisualEditor: Insert a
when the user creates a new line from an existing blank link - 10https://bugzilla.wikimedia.org/65707#c8 (10James Forrester) 5REOP>3ASSI p:5Unprio>3Lowest s:5normal>3enhanc (In reply to Jared Zimmerman (WMF) from comment #7) > Two po... [00:32:17] 3VisualEditor / 3Editing Tools: VisualEditor: The Math and Heiro Inspector jumps to the beginning of the article while opening it for the first time of every edit session - 10https://bugzilla.wikimedia.org/66813#c3 (10ryasmeen) Verified the fix in Betalabs [00:33:17] 3VisualEditor / 3ContentEditable: VisualEditor: Spaces at the start of a paragraph aren't very obvious - 10https://bugzilla.wikimedia.org/66628#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor They actually are shown – but it's very hard to see them. Re-wording. [00:34:02] 3VisualEditor / 3ContentEditable: VisualEditor: Insert a
when the user creates a new line from an existing blank link - 10https://bugzilla.wikimedia.org/65707#c9 (10Jared Zimmerman (WMF)) Where do we draw the line about being paternalistic and disallowing users to do things they want to do but we don'... [00:35:04] 3VisualEditor: Small text can get even smaller - 10https://bugzilla.wikimedia.org/65682#c1 (10James Forrester) 5NEW>3RESO/WON This is intentional; lots of pages (sadly) use Foo Bar Baz (and the same with ). [00:35:32] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452#c1 (10James Forrester) (In reply to Jared Zimmerman (WMF) from comment #0) > Highlighting entire paragraphs and applying or removing list formatting > should consist... [00:38:01] 3VisualEditor / 3ContentEditable: VisualEditor: IE9 skips header line in table - 10https://bugzilla.wikimedia.org/63046 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [00:38:02] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester) [00:38:32] 3VisualEditor / 3Initialisation: VisualEditor: Internet Explorer compatibility (tracking) - 10https://bugzilla.wikimedia.org/50085 (10James Forrester) [00:38:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: IE9 doesn't load new page when when re-editing a page modified in another browser - 10https://bugzilla.wikimedia.org/63048 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:38:32] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855#c5 (10ryasmeen) Verified the fix in Betalabs. [00:38:33] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855#c5 (10ryasmeen) Verified the fix in Betalabs. --- Comment #6 from ryasmeen@wikimedia.org ---... [00:38:33] (03PS3) 10Catrope: Update VE core submodule to master (000935e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 (owner: 10Esanders) [00:38:45] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (000935e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 (owner: 10Esanders) [00:39:02] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452#c2 (10Jared Zimmerman (WMF)) Nested list items… Shouldn't clear formatting clear nested list items styles as well? That would be my expectation. [00:39:03] 3VisualEditor / 3Initialisation: VisualEditor: Console shows "Permission denied" on IE9 when VE is first initiated - 10https://bugzilla.wikimedia.org/63039 (10James Forrester) p:5Unprio>3High s:5normal>3major a:3Roan Kattouw [00:40:18] 3VisualEditor / 3Editing Tools: VisualEditor: Automatically remove empty ref tags (and refuse to insert new ones) - 10https://bugzilla.wikimedia.org/61503#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Alex Monk We fixed this a while ago. Sorry for the slow triage! [00:40:30] (03Merged) 10jenkins-bot: Update VE core submodule to master (000935e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 (owner: 10Esanders) [00:44:27] (03PS1) 10Mooeypoo: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142171 (https://bugzilla.wikimedia.org/66863) [00:55:03] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452#c3 (10James Forrester) (In reply to Jared Zimmerman (WMF) from comment #2) > Nested list items… > > Shouldn't clear formatting clear nested list items styles as wel... [01:06:32] 3VisualEditor / 3Data Model: VisualEditor: Please strip trailing spaces and returns from media or image captions - 10https://bugzilla.wikimedia.org/66736 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [01:15:08] (03CR) 10Catrope: [C: 032] Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142171 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [01:17:32] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452#c4 (10Jared Zimmerman (WMF)) I'd love for us to do a set of user tests around this. Just because word/gdocs/openoffice does something doesn't mean it is the correct... [01:17:44] (03Merged) 10jenkins-bot: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142171 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [01:18:47] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863 (10James Forrester) 5PATC>3RESO/FIX [01:19:02] 3VisualEditor / 3Editing Tools: List functions do not apply and clear list formatting in expected ways - 10https://bugzilla.wikimedia.org/66452#c5 (10Jared Zimmerman (WMF)) @abbey, can you create a card in the backlog to help the VE team validate some of the assumptions around formatting behavior best practi... [01:20:47] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to make images default sized without invoking a dialog - 10https://bugzilla.wikimedia.org/67048 (10Jared Zimmerman (WMF)) [01:21:32] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to make images default sized without invoking a dialog - 10https://bugzilla.wikimedia.org/67048#c1 (10Jared Zimmerman (WMF)) updated the title to not jump to the conclusion of how this should be done, not sure if a button is the right answer, [01:23:02] 3VisualEditor / 3ContentEditable: VisualEditor: Merging behaviour of lists should be looked at - 10https://bugzilla.wikimedia.org/42115 (10James Forrester) [01:23:02] 3VisualEditor / 3Editing Tools: VisualEditor: Reconsider list functions' application and clearing - 10https://bugzilla.wikimedia.org/66452#c6 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc (In reply to Jared Zimmerman (WMF) from comment #4) > I'd love for us to do a set of user t... [01:26:02] 3VisualEditor / 3Editing Tools: VisualEditor: Display "default" sized images in user-preference default size rather than wiki-standard default size - 10https://bugzilla.wikimedia.org/67047#c2 (10Jared Zimmerman (WMF)) I think i might have been unclear on this one. The gist is "Image should not change size... [01:26:17] 3VisualEditor / 3Editing Tools: VisualEditor: Image should not change size when going from read to edit - 10https://bugzilla.wikimedia.org/67047 (10Jared Zimmerman (WMF)) [01:27:26] (03CR) 10Catrope: [C: 032] Don't prepend extra colon to category/file links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142136 (https://bugzilla.wikimedia.org/50279) (owner: 10Alex Monk) [01:28:02] 3VisualEditor / 3Editing Tools: VisualEditor: Image should not change size when going from read to edit - 10https://bugzilla.wikimedia.org/67047#c3 (10James Forrester) (In reply to Jared Zimmerman (WMF) from comment #2) > I think i might have been unclear on this one. > > The gist is "Image should not chan... [01:28:47] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to make images default sized without invoking a dialog - 10https://bugzilla.wikimedia.org/67048#c2 (10James Forrester) (In reply to Jared Zimmerman (WMF) from comment #1) > updated the title to not jump to the conclusion of how this should be done,... [01:29:08] (03Merged) 10jenkins-bot: Don't prepend extra colon to category/file links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142136 (https://bugzilla.wikimedia.org/50279) (owner: 10Alex Monk) [01:29:47] 3VisualEditor / 3Data Model: VisualEditor: Link input widget outwits itself with the leading colon for Category/file links - 10https://bugzilla.wikimedia.org/50279 (10James Forrester) 5PATC>3RESO/FIX [01:30:34] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) a:5Moriel Schottlender>3Roan Kattouw [01:30:47] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync in Firefox - 10https://bugzilla.wikimedia.org/52171 (10James Forrester) [01:30:48] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063 (10James Forrester) [01:31:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) [01:31:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341 (10James Forrester) [01:31:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002 (10James Forrester) [01:31:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10James Forrester) [01:31:03] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10James Forrester) [01:31:04] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [02:01:02] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to make images default sized without invoking a dialog - 10https://bugzilla.wikimedia.org/67048#c3 (10Jared Zimmerman (WMF)) or it could be a spot in the resize steps which replaces the "XXX x XXX" with "Default size" There are any number of options. [08:12:56] (03PS36) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [09:36:22] (03CR) 10Esanders: Only allow slugs where paragraphs are allowed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [09:36:59] (03PS3) 10Esanders: Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 [09:37:17] (03PS4) 10Esanders: Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 [10:41:22] (03PS1) 10Krinkle: build: Update jscs and use new "wikimedia" preset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 [11:24:54] edsanders: Would you mind reviewing that indentation-sensitive commit ^ [11:26:44] (03PS1) 10Krinkle: build: Sync buildloader in eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142226 [11:28:18] (03PS1) 10Krinkle: build: Implement "git-status" task and run it in CI environment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142227 [11:29:14] (03CR) 10Krinkle: "This task is imho useful to have in general, but for the buildloader specifically we'll have much less trouble once I83ebc801cdd0 is done." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142227 (owner: 10Krinkle) [11:30:12] (03PS17) 10Krinkle: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [11:32:52] I don't like this style: [11:32:53] new Foo( { [11:32:53] 'bar': 'baz' [11:32:53] } ) [11:32:53] .method(); [11:33:18] * edsanders tries spaces: [11:33:20] new Foo( { [11:33:20] 'bar': 'baz' [11:33:20] } ) [11:33:20] .method(); [11:33:25] would prefer [11:33:26] edsanders: There are about 4 ways to do it without illogical indentation. The current code was illogical. [11:33:28] Pick one [11:33:29] I don't care [11:33:39] new Foo( { [11:33:39] 'bar': 'baz' [11:33:40] } ) [11:33:40] .method(); [11:33:52] or [11:33:53] new Foo( { [11:33:53] 'bar': 'baz' [11:33:53] } ) [11:33:53] .method(); [11:34:01] No, the latter is illogical [11:34:09] You can work around it with an extra step [11:35:02] hmm [11:35:05] is this illogical: [11:35:06] var x = 1, [11:35:06] y = { [11:35:06] 'bar': 'baz' [11:35:06] }; [11:35:18] yes [11:35:22] But that's slightly different. [11:35:24] Let me pastebin [11:36:25] Alignning .method() flush left is a problem because it looks like a root statement, when it is in fact a line continuation, which are always indented one more. [11:36:35] line continuation and nested levels have one extra tab. [11:36:42] That still leaves plenty of ways, I'm sure there's one we like [12:01:33] (03PS1) 10Esanders: Demo page styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142230 [12:02:20] so 'bar': 'baz' is both a line continuation and a new block level, hence 2 tabs [12:03:32] (03CR) 10Esanders: [C: 032] build: Sync buildloader in eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142226 (owner: 10Krinkle) [12:04:30] edsanders: https://gist.github.com/Krinkle/37277a18ff5e53988b9d [12:04:53] (03CR) 10Esanders: [C: 04-1] build: Update jscs and use new "wikimedia" preset (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [12:05:10] (03Merged) 10jenkins-bot: build: Sync buildloader in eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142226 (owner: 10Krinkle) [12:05:41] edsanders: It's not line continuation, for we don't do that when there's no .method() either [12:05:42] see https://gist.github.com/Krinkle/37277a18ff5e53988b9d#file-sample-js-L31-L35 [12:07:12] let's just stick with what you have [12:10:34] (03PS2) 10Krinkle: build: Update jscs and use new "wikimedia" preset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 [12:10:36] (03CR) 10Krinkle: build: Update jscs and use new "wikimedia" preset (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [12:16:51] (03CR) 10Krinkle: "The other comments aren't related to this commit, but we should deal with that at some point." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [12:18:51] (03CR) 10Krinkle: [C: 04-1] "Hm.. I'm not sure if this commit was different first, or that there is a different intend than I think, or maybe there is the same indent " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [12:31:32] 3MediaWiki extensions / 3TemplateData: TemplateData: Unable to select type "string/line" in the GUI editor - 10https://bugzilla.wikimedia.org/66920#c2 (10Helder) I wasn't aware of that. In this case, there are docs to update, e.g.: https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/TemplateDat... [12:31:51] (03CR) 10Esanders: "I left the non-dist demos in there for debugging purposes. Being able to bring up a file by name in the debugger is essential." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [12:31:59] Krinkle, ^^ [12:32:32] 3MediaWiki extensions / 3TemplateData: TemplateData: Unable to select type "string/line" in the GUI editor - 10https://bugzilla.wikimedia.org/66920#c3 (10Helder) Or are you referring to the change from "string/line" to just "line"? https://gerrit.wikimedia.org/r/#/c/91623/9/spec.templatedata.json,unified (I... [12:34:03] (03CR) 10Esanders: "The dist version also excludes ve.debug.js, so you can run ve without any effects of ve.debug = true (e.g. the debugBar)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [12:34:47] 3MediaWiki extensions / 3TemplateData: TemplateData: Unable to select type "string/line" in the GUI editor - 10https://bugzilla.wikimedia.org/66920 (10Helder) [12:34:48] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator uses old types - 10https://bugzilla.wikimedia.org/60693 (10Helder) [12:34:49] edsanders: Do you actually use the filenames/line numbers as reported in the console directly? We've been doing concat in medaiwiki/resourceloader dev for years, never an issue. Sometimes it's useful to disable minification (though when in chrome, prettify does that already) [12:35:02] Any stacktrace, I read the identifiers, not the file names. [12:35:15] And pretty soon, if we actually rely on build for code to work, raw files don't work anyway. [12:35:40] see also jquery/oojs-core/oojs-ui/mediawiki [12:36:47] The chrome debugger has a find file by name similar to sublime (ctrl+p or ctrl+o) [12:37:02] mediawiki does have a debug mode to load files raw, but that's broken in many ways and is going away in favour of only disabling minifier + source maps, not separarate files. [12:37:03] so often I will bring up a specific file and add a breakpoint [12:37:21] I leave the debug mode on in MW [12:38:08] edsanders: does it bother you in oojs-ui? [12:38:26] a little but it's a much smaller codebase [12:38:55] I have to search for a function name or pattern [12:39:05] instead of just opening the file/class I want and scrolling a little [12:39:27] or add it in sublime indeed [12:39:41] loading raw files in the browser is imho not a debatable proposal to keep. We can do a lot to make it easier, such as source maps. [12:40:06] why, it's only a debug mode> [12:40:15] but laoding raw files is fundamentally limited and a bottle neck for a lot of things. For one, it is already not working with closures or rtl-flipping (e.g in mediawiki), or less files. [12:41:02] doesn't matter that it's only debug, it doesn't work. loading .less files requires a parser, debugging rtl, well, you need cssjanus. Having a consistent workspace? No, because in debug mode they wouldn't be in a closure. etc. [12:41:11] but don't forget source maps though [12:41:14] you wont even know the difference [12:41:14] you can parse each file separately [12:41:26] you won't have yo [12:41:54] I'll redo james commit with plain concat, dist and sourcemaps. You'll have your file finder in chrome. [12:42:22] (and firefox) [12:42:50] how> [12:42:58] source maps [12:43:26] works automatically in any modern browser console [12:45:06] will it work in RL too, because I don't see anything yet [12:45:29] (also would be nice to have a debug/non-debug versions) [12:45:57] RL doens't use dist [12:46:13] RL is on-the-fly dist, so whatever RL's debug has it will have. [12:46:19] which includes raw files for the moment [12:46:25] until I switch it to source maps too [13:04:31] (03PS37) 10Vikassy: [BrowserTest] Language Screenshot(browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [13:12:21] (03PS38) 10Zfilipin: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:17:50] (03CR) 10Amire80: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:38:29] (03PS39) 10Vikassy: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [13:42:55] (03PS40) 10Vikassy: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [13:43:35] (03PS41) 10Vikassy: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) [14:05:09] (03CR) 10Amire80: [C: 032] [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [14:05:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c2 (10Ed Sanders) In every browser except iOS7 getClientRects is relative to the viewport. In iOS7 it is relative to do... [14:06:51] (03Merged) 10jenkins-bot: [BrowserTest] Language Screenshot (browser test and their screenshots) for Headings and Formatting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135616 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [14:07:05] Argh, why is the internet so incompetent. Doesn't anyone use the software they publisih? [14:10:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c3 (10James Forrester) Want to write up a bug report for Apple? [14:55:11] (03PS1) 10Krinkle: build: Implement source maps for js build target [oojs/ui] - 10https://gerrit.wikimedia.org/r/142248 [14:55:15] edsanders: ^ [14:55:51] Works better than I thought. [15:58:26] (03PS1) 10Esanders: Use getClientRects()[0] instead of getBoundingClientRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) [16:08:26] (03CR) 10Esanders: [C: 032] build: Implement source maps for js build target [oojs/ui] - 10https://gerrit.wikimedia.org/r/142248 (owner: 10Krinkle) [16:08:39] \o/ [16:09:02] can you test https://gerrit.wikimedia.org/r/#/c/142260/ on your phone? [16:09:06] (03Merged) 10jenkins-bot: build: Implement source maps for js build target [oojs/ui] - 10https://gerrit.wikimedia.org/r/142248 (owner: 10Krinkle) [16:09:57] edsanders: On my phone? Or on browserstack? I'm not at home right now, don't think I can feasible set up a tunnel between phone and laptop here [16:10:34] Did it work out with Rachel btw regarding access? [16:10:43] I got CBT working and tested it there [16:10:48] cool [16:11:12] want to confirm on a "real" device [16:11:28] Right, OK. Will see what I can do. [16:16:58] Krinkle, https://gerrit.wikimedia.org/r/#/c/139424/ is there are better way to do this re my comments [16:19:26] Indeed there is [16:28:49] Krinkle: Bah, 142248 removed the symlinks and so broke a couple of my local scripts. [16:29:28] Krinkle: Also, if doc.wikimedia.org no longer needs it for publishing the demos, what else is the reason it's not done yet? [16:29:32] edsanders: got phone set up. Had to refactor my local wiki farm to take IP+subdirectory instead of (subdomain).wiki.dev. [16:29:41] James_F: The world [16:30:01] Krinkle: :-( [16:30:55] Hm.. is something blacklisting iPhone? [16:31:06] Krinkle: Yes, MF is only set to do VE for tablets. [16:31:09] I get VE in MF after I log in and enable the Beta pref on iPad/browseerstack [16:31:16] on iphone I get wikitext [16:31:17] Krinkle: It's been this way since the start. [16:31:28] k [16:31:52] well, then, wastedhours++ [16:32:05] I'll repro on browserstack and merge, edsanders [16:32:06] You should have asked. :-) [16:32:18] I blame ed for asking me to test it on my phone [16:32:21] :P [16:32:23] * James_F nods. [16:32:32] You /two/ should have asked rather than assuming. :-) [16:34:04] Krinkle: https://github.com/asciidisco/grunt-qunit-istanbul seems to lag quite a bit from https://github.com/gruntjs/grunt-contrib-qunit – is that going to be an issue? [16:34:27] Not really. It's all independent framework. QUnit itself is in our repository. [16:34:50] This version works. So did last year's [16:35:00] * James_F nods. [16:35:03] build scripts are pretty stable fortuantely [16:35:03] OK. [16:35:14] (03CR) 10Jforrester: [C: 032] build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 (owner: 10Krinkle) [16:35:39] James_F: I've poked upstream about it though [16:35:44] * James_F nods. [16:35:44] (no, it's not me) [16:35:48] :_D [16:35:50] This time. [16:35:55] :) [16:35:57] And "… yet". :-) [16:36:05] (03Merged) 10jenkins-bot: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 (owner: 10Krinkle) [16:36:58] ugh, beta pref is not stored in the account but in cookie? [16:37:06] I have to redo it each time I spawn the ipad [16:39:00] cant' load VE in MF [16:39:09] Uncaught Error: Unknown dependency: es5-shim [16:39:11] ? [16:39:38] Wasn't it defined for desktop and mobile? [16:40:00] was it merged? [16:40:04] Yes. [16:40:32] * James_F fixes. [16:40:35] Oh, right, you owned that change, so after it is merged, it's no longer in any of hte three sectionso f my dashboard [16:40:37] We'll need to backport. [16:41:17] Krinkle: BTW, did you work out why we can't update OOjs into MW-core/VE-core with the sync script? [16:42:07] Should be fine, will check out in a bit. Though I'm going to be offline for 3-4 hours in a bit, will be back later. [16:42:26] Coming to the KIT? [16:42:28] Yes [16:42:36] Kk. [16:42:40] Mobile should fix their code to not silently error and for ever be stuck on a spinner in case anything goes wrong anywhere [16:42:51] True. [16:42:52] I was thinking parsoid was slow or something [16:42:53] Or we should. [16:43:05] but I'm sitting here waiting for nothing on a mobile decide without a console [16:43:10] device* [16:43:31] James_F: json target mobile as wel [16:43:44] * Krinkle commented out es5-shim but was still getting error [16:43:48] Krinkle: Funny, that failure mode sounds like software I know ;) [16:43:51] Yeah, I saw. [16:44:00] * RoanKattouw grumbles something about VE's error exposure [16:44:24] RoanKattouw: It doesn't spin forever, we alert()? [16:44:29] and cancel target.activate [16:44:44] Krinkle: Not if there's a JS fatal. [16:44:59] Krinkle: https://gerrit.wikimedia.org/r/142272 and then I'll back-port? [16:45:07] module dependency is not a fatal, perfectly catchable [16:45:24] Yeah, we talked about fixing RL for that. [16:45:44] RL exposes it already [16:45:54] it has an error callback, no tru/catch needed. [16:45:59] they're just not binding it [16:46:19] Neither are we [16:46:19] OK, Ve loads in mf now, trying to repro eds bug [16:46:30] worked last I tried. We use the promise [16:46:42] plugin array etc. [16:46:45] includes loader using [16:46:52] There's something weird going on there though [16:47:05] Krinkle: Updated. Thanks. [16:47:08] If there's an error in a module, you often don't see it, and often don't get to the spinner in the first place [16:47:24] There are also too many loading stages, which 1) is wasteful and 2) is bad UX because the spinner only shows during the second stage [16:47:36] This is one of those things I've been meaning to clean up in my Copious Free Time (TM) [16:48:08] Roan, Master of Time. [16:48:11] Oh, wait… ;-) [16:49:52] (03CR) 10Catrope: [C: 032] Only allow slugs where paragraphs are allowed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [16:50:00] (03CR) 10Catrope: [C: 04-1] Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [16:50:03] * James_F claps. [16:50:16] Good morning! [16:51:30] (03CR) 10Catrope: [C: 04-1] Use getClientRects()[0] instead of getBoundingClientRect() (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) (owner: 10Esanders) [16:53:41] (03PS2) 10Krinkle: FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) (owner: 10Esanders) [16:54:16] (03CR) 10Krinkle: [C: 032] "Remains the same on Chrome/Safari (Mac), confirmed bug and fix on iPad/iOS 7 on browserstack." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) (owner: 10Esanders) [16:55:21] (03CR) 10Catrope: [C: 032] FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) (owner: 10Esanders) [16:56:31] (03Merged) 10jenkins-bot: FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142260 (https://bugzilla.wikimedia.org/67063) (owner: 10Esanders) [16:57:55] RoanKattouw: wait.. did you test this fix already? [16:58:11] Krinkle: He was removing his -1. [16:58:18] He failed [16:58:33] That was a +2 [16:58:35] He did not fail to remove his -1. His -1 is not there. [16:59:15] no matter as I did that a second earlier, but if he meant to merge it, why did I spend last hour trying to set up tunnel to browserstack, fix up core to not be broken in mf (es5/json), and repro the bug and the fix? [17:00:05] I agree he probably should have just C+0'ed. [17:00:11] * James_F meetings. [17:00:16] (03PS3) 10Krinkle: build: Update jscs and use new "wikimedia" preset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 [17:00:40] (03CR) 10Krinkle: "pretty please before it goes merge conflicty" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [17:38:31] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (9aad824bd6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142019 (owner: 10Jforrester) [17:38:32] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939 (10Krinkle) [17:40:38] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9aad824bd6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142019 (owner: 10Jforrester) [17:41:17] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c4 (10Krinkle) btw, This is a compatibility/legacy left-over from when mw.Title was part of UploadWizard and they got dibs on the more intuitive name "g... [17:41:22] Krenair: ^ [17:41:32] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c5 (10Alex Monk) Yeah, I worked that out soon after moving the bug. Still, I wonder if the documentation should be improved for those methods. [17:42:09] Krenair: I refactored mw.title docs earlier this year. Every single method now has an example and description. Should be good enough. [17:43:06] But one tends to not look at documentation for a method with such a clear name. I guess we didn't look at it either when it was added in our cide [17:43:07] code [17:43:09] ok, gone now [17:47:43] we should just kill this stupid functionality :/ [17:54:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Show something (other than a blank page) when editing a page with a redirect - 10https://bugzilla.wikimedia.org/61861#c4 (10WhatamIdoing) Created attachment 15753 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15753&action=edit In this case, I re-... [17:57:49] 3VisualEditor: VisualEditor should support redirects to sections on a page - 10https://bugzilla.wikimedia.org/67147 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Go to Page settings and tick the box to make a redirect. 2. Type in not just a page title, but also a section:... [18:03:49] 3VisualEditor: VisualEditor: In which it is apparently impossible to create a redirect to [[Foo]] because the list of possible links does not scroll - 10https://bugzilla.wikimedia.org/67150 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Go to Page settings to create a redir... [18:06:05] MatmaRex: Yeah, but that'd be a breaking change for mwTitle… [18:07:18] James_F: we should totally do it anyway. it's out of scope for this module. [18:07:36] i can't possibly imagine anything except for uploadwizard might use this intentionally [18:07:49] MatmaRex: OK. You make it (and an update for UW to fix it), I'll merge it? [18:08:48] D: [18:09:05] (03CR) 10Jforrester: [C: 032] "Let's do this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [18:09:23] * James_F believes in JFDI. :-) [18:10:18] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063 (10James Forrester) 5PATC>3RESO/FIX [18:10:36] James_F: remind me when i'm less backlogged. :) [18:10:46] (03Merged) 10jenkins-bot: build: Update jscs and use new "wikimedia" preset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142219 (owner: 10Krinkle) [18:10:46] MatmaRex: Is there every going to be such a time? ;-) [18:10:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c5 (10James Forrester) 5ASSI>3RESO/FIX Looks like it's fixed by bug 67063's fix. [18:11:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c4 (10James Forrester) 5ASSI>3RESO/FIX Probably (?) fixed by the fix to bug 67063. [18:16:30] (03CR) 10Jforrester: [C: 032] build: Implement "git-status" task and run it in CI environment (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142227 (owner: 10Krinkle) [18:17:47] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153 (10WhatamIdoing) [18:17:49] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Open a page and make a change. 2. Click the Save button. 3. Tab. The cursor starts in the edit summary... [18:18:07] (03Merged) 10jenkins-bot: build: Implement "git-status" task and run it in CI environment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142227 (owner: 10Krinkle) [18:19:47] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153#c1 (10WhatamIdoing) The above is the tab order in Safari 6.1.4 on Mac OS 10.8.5. [18:28:48] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153#c2 (10WhatamIdoing) Here's the tab order in Firefox 30, starting from the edit summary box in the Save dialog: a) tick box for minor edit b) tick box for watching the page c) the browser's UR... [18:48:05] 3VisualEditor: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None This is related to Bug 67153, but specific to Safari: Whatever the dialog box, once you've tabbed through whatever links and butto... [18:49:13] (03CR) 10Esanders: Only allow slugs where paragraphs are allowed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [18:52:29] (03CR) 10Catrope: [C: 032] Demo page styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142230 (owner: 10Esanders) [18:53:33] edsanders: What I was saying is, the caption says "No *aliens* between table rows" [18:53:44] And what I think you mean is "No *slugs* between table rows" [18:53:53] oh right, yes [18:54:38] (03Merged) 10jenkins-bot: Demo page styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142230 (owner: 10Esanders) [18:54:50] (03PS5) 10Esanders: Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 [18:55:21] mooey, Krenair: I think you guys said you wanted code review input on things? Which things were those? [18:55:42] RoanKattouw, awesome things. [18:55:47] (03CR) 10Catrope: [C: 032] Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [18:55:51] (hang on, I'll supply links) [18:56:08] RoanKattouw, Media edit/insert merge (could use testing, too) https://gerrit.wikimedia.org/r/#/c/140813/12 [18:56:53] and this is about to stop being WIP (I just need to edit the commit message and remove it from there) https://gerrit.wikimedia.org/r/#/c/141749/ [18:57:05] RoanKattouw, thaaanks! [18:57:11] Sweet thanks [18:57:51] (03Merged) 10jenkins-bot: Only allow slugs where paragraphs are allowed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [19:00:21] well. Remember svgMaxSize [19:00:35] MW doesn't [19:01:01] James_F, \o/ another chance to get my 'revenge-of-the= [19:01:23] this time I'll try to make sure the topic sticks. [19:01:40] * James_F grins. [19:05:19] 3VisualEditor / 3Editing Tools: VisualEditor: Tab order is bad in the Template dialog - 10https://bugzilla.wikimedia.org/67159 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None This is the same sort of problem as bug 67153 in the Save dialog. Here is the incomplete tab order in Safari 6: 1. Ins... [19:05:32] 3VisualEditor / 3Editing Tools: VisualEditor: Tab order is bad in the Template dialog - 10https://bugzilla.wikimedia.org/67159 (10WhatamIdoing) [19:06:32] 3VisualEditor / 3Editing Tools: VisualEditor: Tab order is bad in the Template dialog - 10https://bugzilla.wikimedia.org/67159 (10WhatamIdoing) [19:06:32] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153 (10WhatamIdoing) [19:11:20] (03CR) 10Esanders: [C: 032] test: Add test for getObjectValues with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141937 (owner: 10Krinkle) [19:12:22] (03CR) 10Esanders: [C: 032] test: Add test for mixinClass with static properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141936 (owner: 10Krinkle) [19:13:23] (03Merged) 10jenkins-bot: test: Add test for mixinClass with static properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141936 (owner: 10Krinkle) [19:13:25] (03Merged) 10jenkins-bot: test: Add test for getObjectValues with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141937 (owner: 10Krinkle) [19:13:47] 3OOjs: OOjs: Should be parseable by ES3 engines - 10https://bugzilla.wikimedia.org/63303 (10Tisza Gergő) [19:13:53] (03CR) 10Esanders: [C: 04-1] test: Add test for compare() with inherited properties (032 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 (owner: 10Krinkle) [19:19:20] James_F, edsanders followup on our old old discussion about svgMaxSize, see this page; the svgMaxSize is 2048. The image is displayed at 2543x2160 https://www.mediawiki.org/wiki/User:Mooeypoo/Testing [19:19:34] svgMaxSize doesn't work. I'm taking it out of the size limits. [19:21:32] 3VisualEditor / 3Editing Tools: VisualEditor: Menus appearing behind page content in Safari 6.1.3 (browser plugin bug?) - 10https://bugzilla.wikimedia.org/64388#c21 (10Bryce Glover) 5RESO/WOR>3VERI I'm still seeing this bug with Safari 6.1.4, guys; maybe it's more serious than we all think? It would be... [19:21:39] oh, I just made the image 4500x3822px [19:23:17] mooey: Lovely. :-( [19:23:49] James_F, I'm taking it out of VE's consideration -- but should I report a bug about this in mw? I am really rather confused about this whole svgMaxSize [19:24:02] anyone even knows about it? it seems to be 2048 by default, but isn't working. [19:24:02] * James_F nods. [19:24:10] Ask in -multimedia? [19:24:46] edsanders: You seen https://gerrit.wikimedia.org/r/#/c/141063/ BTW? Roan adjusting transactions around annotating metadata. [19:27:04] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None Steps to reproduce: 1. Open a page containing an image in Safari. 2. Open a... [19:27:17] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162 (10WhatamIdoing) [19:27:31] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10WhatamIdoing) [19:28:32] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162 (10WhatamIdoing) [19:28:47] 3VisualEditor: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156 (10WhatamIdoing) [19:37:49] (03CR) 10Esanders: test: Clean up test for copy() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 (owner: 10Krinkle) [19:38:57] (03PS1) 10Alex Monk: Don't remove 'extension' from template names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142372 (https://bugzilla.wikimedia.org/66939) [19:42:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Only display the wikitext warning once per session - 10https://bugzilla.wikimedia.org/67083#c2 (10Alex Monk) 5ASSI>3RESO/WON Displaying it once per session...? Per James, this is a wontfix I think. [19:46:48] James_F, how did you say I can keep my topic despite the fact my commit is attached to a bug? [19:48:42] mooey: Two ways. [19:48:52] mooey: Either git commit -t "…" [19:49:05] mooey: Or just add the "Bug: …" in a second patchset [19:49:21] mooey: or edit the topic in the web interface after submitting the patch [19:49:29] mooey: or don't use git-review :> [19:49:35] MatmaRex, but that seems to be overriden all the time [19:49:47] James_F, oh, if I don't have the Bug: in the original patchset, and I add it through the gerrit interface, that will work? [19:50:33] mooey: Yes. [19:51:34] (03PS1) 10Mooeypoo: Unimplement wgSVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142380 [19:54:26] James_F, ... I don't know WHAT I did, but that did NOT come out right. [19:54:47] What did you do? [19:54:56] s/do/try to do/ [19:55:35] I tried to do the git commit -t '...' but i got an error, so instead I deleted the bug from the commit and sent to review [19:55:49] but then it got there without a topic at all.. so I just changed it in the interface [19:56:04] (03PS2) 10Mooeypoo: Unimplement wgSVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142380 (https://bugzilla.wikimedia.org/66865) [19:56:16] * James_F sees. :-) [19:58:14] mooey: i think james meant `git review -t` [20:18:11] MatmaRex, that.. would make sense :D [20:18:20] I'll know for next time [20:19:23] MatmaRex: Argh, yes, whoops. Sorry mooey. [20:33:23] James_F, no matter. My topic is up, I'm happy. :D [20:34:11] is TrevorP|Away around? Can we talk about the new media dialog? [20:34:33] I had an idea about the "preview" option a while back, but I'm not entirely sure it's what he has in mind [20:38:16] Hi TrevorParscal :D [20:38:47] (03CR) 10Krinkle: test: Add test for compare() with inherited properties (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 (owner: 10Krinkle) [20:39:08] (03PS3) 10Krinkle: test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 [20:39:34] (03PS3) 10Krinkle: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 [20:40:31] (03PS4) 10Krinkle: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 [20:40:36] (03CR) 10Krinkle: test: Clean up test for copy() (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 (owner: 10Krinkle) [20:40:44] (03PS3) 10Krinkle: test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 [20:40:55] (03PS3) 10Krinkle: test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 [21:01:34] mooey: hi [21:01:37] i'm back from lunch [21:08:51] hi hi. Post-Bon apetit [21:09:19] so, talk media dialog to me. What did you have in mind for the preview? [21:09:39] I had an idea a while back, but I'm not sure it's what you had in mind [21:14:01] TrevorParscal, I was thinking of using a surface like we have now for captions, only disabled. Put a chunk of document in it and a duplicate node -- then update that node on the different actions. [21:15:10] the problem is we want to have a simplified display [21:15:11] my idea is to use an image model, render the image inside of a box which has some inline-block spans of random-sh widths which represent text and let the browser actually render it out [21:15:44] if we say there will be content before and after, and maybe use some cleverness to decide how much [21:15:59] I think we can get away with a lot of trickery [21:22:13] hm [21:22:47] I'm not sure I understand how to do that in practice, though. When you say 'use an image model' you mean the MWImageModel or an MWImage data model? [21:24:08] And if we render the image inside a block with spans, we will need to recreate the exac way the actual image works -- won't it be simpler to use an actual image inside an actual editor (which is mostly what the caption surface does) and then add blank text and stylize it with grey/black span-background ? [21:27:15] (03CR) 10Catrope: [C: 04-1] Offer to retain changes when switching to the wikitext editor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [21:27:26] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/142064/3/modules/ve-mw/ui/dialogs/ve.ui.MWWikitextSwitchConfirmDialog.js ? [21:27:43] The rest of that commit looks fine, it's just the dialog itself I'm less sure about [21:30:28] RoanKattouw, hi [21:31:08] ... actually, never mind. [21:35:14] (03CR) 10Catrope: Offer to retain changes when switching to the wikitext editor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [21:35:34] Krenair: That one ---^^ has an actually substantive comment, the last one was just coding style [21:49:44] This looks like "the internet" from it crowd [21:49:45] https://twitter.com/CIA/status/479708374310072320 [21:49:53] omg, cia owns the internet! [21:50:48] Krinkle: :-) [22:07:31] Krinkle, it *is* wireless. [22:24:25] TrevorParscal, by the way, how do I make a PopupButtonWidget's popup smaller to fit the contents properly? [22:26:09] (03PS1) 10Krinkle: build: Use grunt-contrib-concat instead of homegrown 'combine' [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 [22:27:44] Krinkle: Ooh, nice. [22:33:35] (03CR) 10Jforrester: "This changes the date format:" [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 (owner: 10Krinkle) [22:34:22] (03CR) 10Jforrester: [C: 04-1] build: Use grunt-contrib-concat instead of homegrown 'combine' [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 (owner: 10Krinkle) [22:35:18] (03CR) 10Catrope: [C: 032] Unimplement wgSVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142380 (https://bugzilla.wikimedia.org/66865) (owner: 10Mooeypoo) [22:35:20] James_F: OOjs UI, merged, https://gerrit.wikimedia.org/r/#/c/142248/1/build/banner.txt [22:35:36] Krinkle: *sighs* [22:35:41] I agree though [22:35:45] I looked for a day to make it longer [22:35:47] Krinkle: I also complained about that change for other reasons. [22:35:48] let me try again [22:36:07] http://gruntjs.com/api/grunt.template#grunt.template.date [22:36:11] https://github.com/felixge/node-dateformat [22:36:19] Tell me which you want [22:36:33] ISO ? [22:36:38] ISO would be best. [22:36:41] No timezone needed. [22:36:58] James_F: btw, copyright yyyy is nice right? [22:37:02] (03Merged) 10jenkins-bot: Unimplement wgSVGMaxSize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142380 (https://bugzilla.wikimedia.org/66865) (owner: 10Mooeypoo) [22:37:25] So "2014-06-26T22:37:03Z" or whatever. [22:37:39] Yeah, that bit I liked lots. It's a really nice change except for the date being a bit skewy. [22:37:39] woot, I got my topic to stay [22:37:45] * Date: 2014-06-27T00:37:07 [22:37:50] that looks wrong [22:38:02] 3VisualEditor / 3Editing Tools: VisualEditor: For large SVG images while trying to make it full size, it says "Size values are invalid" - 10https://bugzilla.wikimedia.org/66865 (10James Forrester) 5PATC>3RESO/FIX [22:38:02] it omits the timezone but still has my timezone applied [22:38:03] hah [22:38:03] ugh [22:38:05] That's AMS-local. [22:38:06] That's local time, not UTC [22:38:07] Yeah. [22:39:14] mooey: :-) [22:41:01] (03PS2) 10Krinkle: build: Use grunt-contrib-concat instead of homegrown 'combine' [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 [22:42:05] (03PS1) 10Krinkle: build: Use isoUtcDateTime instead of yyyy-mm-dd in banner [oojs/ui] - 10https://gerrit.wikimedia.org/r/142449 [22:42:53] (03CR) 10Jforrester: [C: 032] build: Use grunt-contrib-concat instead of homegrown 'combine' [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 (owner: 10Krinkle) [22:43:06] (03CR) 10Jforrester: [C: 032] build: Use isoUtcDateTime instead of yyyy-mm-dd in banner [oojs/ui] - 10https://gerrit.wikimedia.org/r/142449 (owner: 10Krinkle) [22:43:44] (03Merged) 10jenkins-bot: build: Use grunt-contrib-concat instead of homegrown 'combine' [oojs/core] - 10https://gerrit.wikimedia.org/r/142442 (owner: 10Krinkle) [22:43:53] (03Merged) 10jenkins-bot: build: Use isoUtcDateTime instead of yyyy-mm-dd in banner [oojs/ui] - 10https://gerrit.wikimedia.org/r/142449 (owner: 10Krinkle) [22:44:02] \o/ [22:47:05] Krinkle: BTW, CR on https://gerrit.wikimedia.org/r/#/c/140445/ (Krenair's TemplateData-for-ParserFunctions WIP) would be very welcome. [22:49:19] (03CR) 10Mattflaschen: "See bug report." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [22:50:47] 3VisualEditor / 3Editing Tools: VisualEditor: When getting TemplateData, VE automatically adds "Template:" even if another namespace is provided - 10https://bugzilla.wikimedia.org/52609#c5 (10Matthew Flaschen) The commit says the purpose of the colon is "to create a link to something that would normally be i... [22:57:24] (03CR) 10Catrope: [C: 04-1] "I read the code and it looks fine, except for where I left inline comments. I haven't tested this yet. I did, however, notice that a lot o" (0311 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (owner: 10Mooeypoo) [22:58:45] (03CR) 10Jforrester: Merge Media Edit and Media Insert dialogs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (owner: 10Mooeypoo) [22:59:20] 3VisualEditor / 3Technical Debt: VisualEditor: Merge the media editing and gallery editing dialogs - 10https://bugzilla.wikimedia.org/62677 (10James Forrester) 5ASSI>3PATC a:3Moriel Schottlender [23:03:49] 3OOjs UI: OOjs UI: Dialogs should disable "Apply changes" until a change is present - 10https://bugzilla.wikimedia.org/55976 (10James Forrester) a:3Trevor Parscal [23:06:21] 3OOjs UI: OOjs UI: Dialogs should not display below visible page area - 10https://bugzilla.wikimedia.org/52526 (10James Forrester) 5ASSI>3PATC a:3Trevor Parscal [23:10:20] 3OOjs UI: OOjs UI: Dialogs flow off-screen with small windows or high zoom level, leaving user without UI controls onscreen to close dialog - 10https://bugzilla.wikimedia.org/52187 (10James Forrester) 5ASSI>3PATC a:3Trevor Parscal [23:11:28] (03CR) 10Catrope: [C: 04-1] [wip] MWImageModel unit tests (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [23:11:49] 3OOjs UI: OOjs UI: Dialogs do not horizontally scroll in narrow windows - 10https://bugzilla.wikimedia.org/51755 (10James Forrester) 5ASSI>3PATC a:3Trevor Parscal [23:13:32] 3VisualEditor / 3Editing Tools: VisualEditor: Re-label the group UI element in the reference dialog to explain what it does - 10https://bugzilla.wikimedia.org/50171 (10James Forrester) [23:13:40] (03PS4) 10Alex Monk: Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) [23:14:22] James_F, 62677 isn't what I just merged, is it? am I misreading? It's another dialog? [23:14:49] merged in the code sense, not in gerrit sense [23:15:17] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798 (10James Forrester) [23:15:18] 3VisualEditor / 3Editing Tools: VisualEditor: Add the capacity for help pages in dialogs - 10https://bugzilla.wikimedia.org/51237#c1 (10James Forrester) 5ASSI>3RESO/WON Instead of help /pages/ we've decided to go with help /popups/, per bug 51798. [23:15:31] mooey: You're right, I'm a fool. [23:15:53] I could have sworn we had a bug for that. [23:16:19] 3VisualEditor / 3Technical Debt: VisualEditor: Merge the media editing and gallery editing dialogs - 10https://bugzilla.wikimedia.org/62677 (10James Forrester) 5PATC>3ASSI a:5Moriel Schottlender>3None [23:19:19] 3VisualEditor / 3ContentEditable: VisualEditor: Text-only GeneratedContentNode rerenderings aren't highlighted correctly - 10https://bugzilla.wikimedia.org/67169 (10Roan Kattouw) 3ASSI p:3Unprio s:3normal a:3Ed Sanders 1. Create a page with {{echo|foo}} in the text somewhere 2. Observe that the word... [23:20:04] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) a:5Ed Sanders>3Alex Monk [23:20:47] 3VisualEditor / 3Editing Tools: VisualEditor: When getting TemplateData, VE automatically adds "Template:" even if another namespace is provided - 10https://bugzilla.wikimedia.org/52609#c6 (10Roan Kattouw) What Matt pointed out is handled correctly except for main namespace titles (e.g. :Foo), where the inpu... [23:21:18] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c5 (10James Forrester) 5ASSI>3RESO/FIX I think this is now done given bug 65473's resolution. [23:22:24] TrevorParscal: You don't use jquery.uls in VE anymore? [23:22:38] yeah we do [23:22:41] InezK: Not directly, only jquery.uls.data [23:22:41] No, we don't. [23:22:51] We use … [23:22:51] Yeah, what RoanKattouw said. [23:22:51] Or whatever it's called [23:22:51] right, we use that [23:22:56] Basically we still use their data but we use our own UI [23:23:04] of course [23:23:21] I see that dependency on jquery.uls got replaced with dependency on mediawiki.language.names [23:23:32] 3VisualEditor / 3Technical Debt: VisualEditor: Merge the inserting and editing media dialogs - 10https://bugzilla.wikimedia.org/67170#c1 (10James Forrester) 5ASSI>3PATC p:5Unprio>3Normal s:5normal>3enhanc Once more with feeling. [23:23:48] Yeah, Ed also moved around where this data comes from [23:24:01] I think mediawiki.language.names is like enhanced by the CLDR extension or something [23:24:43] It makes it so that you can type "Ger" or "Deu" and in both cases it'll match de (because of "German" and "Deutsch") [23:25:18] Oooh [23:25:29] I didn't realize this, but in fact, it knows the name of every language in every language [23:25:41] So if I set my language to Dutch, then I can type "Duits" and it knows what that means [23:27:09] James_F: Am I supposed to be assignee on https://bugzilla.wikimedia.org/show_bug.cgi?id=61573 ? [23:27:14] No history entry, looks like it was created that way [23:27:32] (03CR) 10Catrope: [C: 04-1] Handle transcluding templates outside of the template namespace properly (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [23:28:05] Krinkle: I believe you expressed an interest in doing it at the time (we were talking about using it in a couple of context; I'm happy to assign to Krenair instead. [23:28:38] +) [23:28:40] Bah. [23:28:55] I don't get syntax highlighting for English in my IRC client's text box. [23:29:02] Clearly this needs fixing. :-) [23:29:21] Well, I don't mind having it in my pool, but I'm not actively looking for it. I'd like to keep query results of 'assigned:self and status:ASSIGNED' managable. I know you like using status "ASSIGNED" a lot, but I did like it better when we only used the assigned-to field and only the status when it is actively on our worklist or minds. [23:29:31] (as opposed to general goto responsibility) [23:29:32] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709 (10Chris McMahon) [23:29:33] 3OOjs UI: OOjs UI: Create a "ComboBox" (write-in-able drop-down) widget - 10https://bugzilla.wikimedia.org/61573 (10James Forrester) p:5High>3Normal a:5Krinkle>3Alex Monk [23:30:05] basically I filter out visualeditor from that query and then re-include my worklist [23:30:29] Krinkle: That is, indeed, what it means. [23:30:49] Krinkle: Items not actively meant to be worked on or cookie-licked aren't assigned to an individual. [23:31:00] Right [23:31:26] Hm.. looks like it has changed a lot [23:31:32] it's much better now [23:31:41] Krinkle: Yeah. [23:31:47] Only 3 assigned/assigned to me [23:31:49] OK :) [23:31:53] Krinkle: 6. [23:31:59] I know [23:32:00] 11 [23:32:01] even [23:32:12] 11? [23:32:19] Oh, TemplateData? [23:32:24] That's not on my dashboard. :-) [23:32:41] I think you used to use assigned as 'confirmed' and assigned-to for the indiviual. and worklist doc for worklist. [23:32:46] 11 global [23:32:59] Krinkle: Yeah, we changed this a few months ago. :-P [23:33:09] or rather we didn't have a 'nobody' default assignee, so when you confirmed the bug, it became implicitly ssigned to the default [23:33:18] well i had vE filtered out al that time [23:33:19] RoanKattouw, am currently looking at the non-Template: transclusion stuff [23:33:22] * James_F nods. [23:33:30] It's weird because... I Was pretty sure I was fixing this bug with this commit [23:34:10] And yet, looking back at it, it doesn't appear to... :| [23:34:24] (03CR) 10Catrope: [C: 04-1] "If you choose to discard your changes, you then get the "Are you sure you want to leave this page?" prompt. We should probably bypass that" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [23:34:43] Krenair: Maybe it fixes consumption of existing {{:Foo}} wikitext, that's possible, I didn't test that [23:34:47] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575#c9 (10Juliusz Gonera) @ryasmeen, it might be the same bug, yes. However, this bug is older than the one you reported. [23:36:08] (03PS8) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [23:36:19] (03CR) 10Alex Monk: [C: 04-1] "Sigh. I remember making this commit and watching it appear to be fixed. And yet, looking at it again, it doesn't seem to..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [23:36:41] (03Abandoned) 10Trevor Parscal: [WIP] Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 (owner: 10Trevor Parscal) [23:36:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:38:38] (03PS1) 10Catrope: Make ConfirmDialog interpret clicking X as 'cancel', not as 'OK' [oojs/ui] - 10https://gerrit.wikimedia.org/r/142460 [23:39:44] (03PS9) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [23:40:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:40:35] (03CR) 10Trevor Parscal: [C: 032] Make ConfirmDialog interpret clicking X as 'cancel', not as 'OK' [oojs/ui] - 10https://gerrit.wikimedia.org/r/142460 (owner: 10Catrope) [23:41:18] (03Merged) 10jenkins-bot: Make ConfirmDialog interpret clicking X as 'cancel', not as 'OK' [oojs/ui] - 10https://gerrit.wikimedia.org/r/142460 (owner: 10Catrope) [23:42:37] (03CR) 10Catrope: "(Other than that this is good to go)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [23:45:23] (03CR) 10Catrope: [C: 032] Don't remove 'extension' from template names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142372 (https://bugzilla.wikimedia.org/66939) (owner: 10Alex Monk) [23:45:40] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (b9d403a678) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142461 [23:46:03] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575#c10 (10ryasmeen) Ok, thanks for confirming.I will verify both the workflows once it is fixed. [23:46:35] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (b9d403a678) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142461 (owner: 10Jforrester) [23:46:58] RoanKattouw: https://gerrit.wikimedia.org/r/142462 [23:47:05] (03Merged) 10jenkins-bot: Don't remove 'extension' from template names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142372 (https://bugzilla.wikimedia.org/66939) (owner: 10Alex Monk) [23:47:38] Krinkle: Can I steal you for a minute re. OOjs? [23:48:47] 3OOjs UI: OOjs UI: onDomEvent('focus') does not work after jQuery upgrade - 10https://bugzilla.wikimedia.org/65608#c1 (10Krinkle) (In reply to Tisza Gergő from comment #0) > jQuery 1.9 has a nasty change in how triggered focus events are handled. > There is some documentation on it at [1] which states "jQuery... [23:48:49] I'm about to close up. It's getting late. Got up early today (local time). [23:49:10] Krinkle: It's a bit of a problem. :-( [23:49:12] Krinkle: In MW-core (clean checkout), run maintenance/resources/update-oojs.sh and explain. [23:49:18] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (b9d403a678) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142461 (owner: 10Jforrester) [23:49:20] OK [23:50:26] Krinkle: I'm getting a confusing failure which I can't work out. [23:50:39] Krinkle: I suspect it's my fault. :-( [23:50:46] It is I think [23:50:47] https://gist.github.com/Krinkle/bd6ac97af4b78d2ef9de [23:51:16] .jshintrc and .npmignore is a bug. I'll look into that [23:51:57] Maybe you had them there locally when you published? 'npm publish' uses worktree, not git. Any untracked files will be packages and uploaded to npmjs.org repo and fixed in time [23:52:50] Ah. [23:52:56] Possibly. [23:53:01] * James_F sighs. [23:53:27] Krinkle: You don't get to claim you got up early today [23:53:35] I woke up at 3:30 and couldn't go back to sleep [23:53:46] (03PS3) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [23:53:48] And two days ago I got up at 3:45 (deliberately, to make a flight) [23:53:49] Kids, kids, let's behave. [23:54:01] * RoanKattouw grumbles at Krinkle to get off his lawn [23:54:02] (03CR) 10jenkins-bot: [V: 04-1] Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [23:54:05] ^ RoanKattouw so I *think* this PS works. [23:54:06] I've been up since 01:53 yesterday, slept 6 hours in the morning from 9 [23:54:09] It certainly seems to [23:54:11] But, goddammit jenkins [23:54:15] Krenair: jenkins-bot disagrees with you :P [23:54:20] Krinkle: OK, you go to bed, and tomorrow once all of the outstanding OOjs test patches have landed we'll do 1.0.11 right this time, and pull that. [23:54:26] grumble grumble [23:54:33] merge conflict [23:55:12] OK fine, I also slept 6 hours :) [23:56:11] (03PS10) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [23:56:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:56:48] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10ryasmeen) [23:56:48] (03PS4) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [23:56:49] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575 (10ryasmeen) [23:57:22] (03CR) 10Catrope: [C: 04-1] Provide move left/right quick action buttons for images (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [23:57:34] I wish git didn't prepend filenames in diffs with 'a/' and 'b/'. Then I could select them by double click instead of having to get the right characters [23:59:18] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939#c8 (10Alex Monk) 5PATC>3RESO/FIX Should be fixed now. [23:59:32] 3VisualEditor / 3Editing Tools: VisualEditor: When editing a template, the title is truncated at first dot (period) - 10https://bugzilla.wikimedia.org/66939 (10Alex Monk)