[00:00:05] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (a63f03882e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142750 (owner: 10Jforrester) [00:00:18] Thanks RoanKattouw [00:01:29] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (a63f03882e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142750 (owner: 10Jforrester) [00:12:33] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c7 (10ryasmeen) Ok, the behavior got slightly changed here, it wont close the VE now if your second tap on the same reference follows right after your... [00:25:38] * RoanKattouw shakes fist at Krinkle|detached [00:26:31] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/140a3b84cc8fea6861ca70b8451d399de2149d3d causes hasLayout in IE [00:39:24] (03CR) 10Catrope: "Do you have a breaking example of a case where there are overlapping highlights?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142733 (owner: 10Catrope) [04:26:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Support editing of sections inside a page - 10https://bugzilla.wikimedia.org/48429#c52 (10WhatamIdoing) Mike Christie has a suggestion: Edit the whole page, but only display the chosen section. By this I don't think he means "discard" everything excep... [04:41:19] 3VisualEditor: VisualEditor crashes if the DefaultSummaries gadget is enabled - 10https://bugzilla.wikimedia.org/67236 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None VisualEditor crashes when you try to save if the Defaultsummaries gadget is enabled. (https://en.wikipedia.org/wiki/MediaWiki:Gadget-de... [05:26:35] (03CR) 10Mattflaschen: "I haven't tested, but the commit message at least needs to be updated. Per the bug, "don't try to use colon prefixes when transcluding" i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [07:48:05] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [07:52:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [08:59:59] (03CR) 10Esanders: "Then Timo started implementing source maps, which we should do here." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [09:58:17] (03PS5) 10Krinkle: test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 [09:58:22] (03PS6) 10Krinkle: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 [09:58:25] (03PS5) 10Krinkle: test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 [09:58:30] (03PS5) 10Krinkle: test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 [09:58:34] (03PS5) 10Krinkle: EventEmitter: Remove dead code that claims to prevent double bindings [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 [10:12:19] 3VisualEditor: Undesired scroll to the top of the page when text cursor/caret goes over {{lang}} template - 10https://bugzilla.wikimedia.org/67242 (10Nyq) 3UNCO p:3Unprio s:3normal a:3None Intention: Move caret with arrow keys through the text containing {{lang}} template Steps to Reproduce: 1. Naviga... [11:13:49] (03PS5) 10Bartosz Dziewoński: Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 [11:17:50] (03PS6) 10Bartosz Dziewoński: Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 [11:18:21] (03CR) 10Bartosz Dziewoński: "Okay." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [11:49:33] 3VisualEditor / 3MediaWiki integration: VisualEditor: Support editing of sections inside a page - 10https://bugzilla.wikimedia.org/48429#c53 (10Mike Christie) Re comment 52: I agree that show/hide would be nice for the uneditable sections. More importantly, if this behaviour is implemented, please make it a... [12:14:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Support editing of sections inside a page - 10https://bugzilla.wikimedia.org/48429#c54 (10Mike Christie) Another thought on the preference: currently clicking on a section edit gives a pre-filled edit summary including the section. Whether this happens s... [12:15:16] (03CR) 10Esanders: [C: 032] Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [12:16:41] (03Merged) 10jenkins-bot: Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [12:27:01] (03CR) 10Esanders: "It's not common but it's certainly possible." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142733 (owner: 10Catrope) [12:29:39] (03CR) 10Esanders: Compress HTML data with deflate before POSTing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [12:59:27] (03PS1) 10Esanders: Add a ve direction class to all surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142797 (https://bugzilla.wikimedia.org/66494) [15:10:34] (03PS1) 10Esanders: Fix up selection after deletion if at non-content offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) [15:12:02] (03CR) 10jenkins-bot: [V: 04-1] Fix up selection after deletion if at non-content offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) (owner: 10Esanders) [15:16:32] 3VisualEditor / 3ContentEditable: VisualEditor: Double-click should not open items that shouldn't be opened - 10https://bugzilla.wikimedia.org/67176#c1 (10Ed Sanders) Link to an example? [15:41:04] 3VisualEditor: VisualEditor crashes if the DefaultSummaries gadget is enabled - 10https://bugzilla.wikimedia.org/67236#c1 (10Ed Sanders) Not really a VE bug, but here you go: The gadget is using ve.init.mw.targets[0] to access the target, which isn't supposed to be a public API yet, but hey. This was removed... [15:42:47] 3VisualEditor: VisualEditor crashes if the DefaultSummaries gadget is enabled - 10https://bugzilla.wikimedia.org/67236 (10Ed Sanders) 5NEW>3RESO/INV [16:49:06] (03PS1) 10Esanders: Fix document margin trick for vector-sd [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142808 [17:29:36] (03PS1) 10Esanders: Remove old ce-surface classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142810 [17:41:19] (03CR) 10Jforrester: [C: 032] "Works locally." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142810 (owner: 10Esanders) [17:42:50] (03Merged) 10jenkins-bot: Remove old ce-surface classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142810 (owner: 10Esanders) [17:45:34] 3VisualEditor / 3Editing Tools: VisualEditor: Use a "broken link" icon as the "remove" button in the link inspector, instead of a rubbish bin - 10https://bugzilla.wikimedia.org/51464#c1 (10James Forrester) 5ASSI>3RESO/INV a:3Trevor Parscal We've decided instead to remove the use of icons here as it's t... [18:07:16] (03PS5) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [18:07:46] (03PS6) 10Alex Monk: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) [18:34:15] (03PS1) 10Jforrester: Synchronise wgExtensionCredits with AUTHORS.txt, sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142815 [18:34:51] edsanders: Ping. [18:35:15] (03CR) 10jenkins-bot: [V: 04-1] Synchronise wgExtensionCredits with AUTHORS.txt, sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142815 (owner: 10Jforrester) [18:35:18] sup [18:35:19] edsanders: What's the problem that 142808 (vector-hd) fixes? I can't work out what issue it's causing. [18:35:41] it isn't [18:35:51] Ah, it's just logical cleanup? [18:36:06] if you inspect the documentnode you'll see the padding is too wide [18:36:38] I think it isn't a problem because of overflow:hidden [18:36:49] otherwise the clickable area would bleed into the sidebar [18:36:53] * James_F nods. [18:36:55] Seen. [18:37:04] (03CR) 10Jforrester: [C: 032] Fix document margin trick for vector-sd [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142808 (owner: 10Esanders) [18:38:16] (03PS2) 10Jforrester: Synchronise wgExtensionCredits with AUTHORS.txt, sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142815 [18:38:41] (03Merged) 10jenkins-bot: Fix document margin trick for vector-sd [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142808 (owner: 10Esanders) [18:43:59] edsanders: BTW, found a fun minor bug related to the toolbar in vector.css if you care. :-) [18:45:44] where [18:45:49] * James_F files. [18:47:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256 (10James Forrester) 3ASSI p:3Unprio s:3minor a:3None Created attachment 15772 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15772&action=edit De... [18:47:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256#c1 (10James Forrester) Created attachment 15773 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15773&action=edit Non-detached static toolbar [18:47:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256 (10James Forrester) p:5Unprio>3Normal [18:49:27] Off by 16px it seems. [18:52:27] Adding "margin-left: -16px;" on the ve-ui-toolbar-floating makes it work, but it's a horrible hack. [18:52:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Focusable nodes can't be deleted - 10https://bugzilla.wikimedia.org/67257 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None (Chrome mobile) Clicking on a focusable node doesn't bring up the keyboard so there is no access to the backspace key. Even if you cl... [18:59:22] hm [19:00:18] thought I'd fixed that a while ago, will look [19:00:48] James_F, do we have any spare iOS devices for testing? [19:02:52] edsanders: We can requisition you one; if you're going to be the main mobile CE person (which is where a lot of the issues are), it would make sense. [19:03:25] edsanders: You'd probably want both an iPad and later an iPod (for the phone-sized format). [19:03:32] edsanders: You already have the equivalents for Android, right? [19:03:41] I'm the only person tasked with mobile bugs who doesn't have an iOS in the building [19:03:47] yeah - got a nexus4/7 [19:04:17] * James_F nods. [19:04:40] Ping Terry an e-mail asking if it's OK, CC'ed to me. [19:04:44] (He'll say yes. ;-)) [19:05:42] is there an ipod emulator for the ipad [19:05:51] Don't think so. [19:06:12] Of course, if you booted into Mac OS X there's a complete iPad and iPhone emulator which replicates it near-perfectly. [19:06:55] if [19:07:00] When. [19:07:02] ;-) [19:07:43] Wait. [19:08:01] Is the vector-hd CSS loaded based on the screen resolution at load time only? [19:08:16] 'Cos if so we should fix that. [19:08:32] (Also, I've got a local fix for the toolbar bug, though I don't know what caused the issue in the first place.) [19:20:47] James_F, it's not a CSS issue [19:20:57] try loading the page in SD mode [19:21:03] Yes? [19:21:09] it works fine [19:21:22] then when you expand to HD it breaks in the other direction [19:21:23] Not for me. [19:21:42] Oh, hmm, yes. [19:22:53] Something's caching the width of the leftnav (which expands by 1em when the screen is > 981px). [19:28:52] (03PS1) 10Jforrester: Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 [19:29:07] (03CR) 10jenkins-bot: [V: 04-1] Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 (owner: 10Jforrester) [19:35:20] (03PS2) 10Jforrester: Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 [19:40:00] edsanders: BTW, did you see the V-1 for https://gerrit.wikimedia.org/r/#/c/142806/ – qunit failure. [19:40:40] oh yeah, I forgot I wrote tests for that [19:40:45] :-) [19:41:13] edsanders: Also, for 137367 you want me to implement source maps that no-one will ever use? [19:41:53] The purpose of the dist single-file is to make it easier to drop into a project, which means the /src directory is unlikely to be around. [19:42:02] And we're not going to be using them ourselves. [19:42:39] are you suggesting we drop the VE source files from the MW extension? [19:42:51] Quite the reverse. [19:43:09] I'm saying that the VE-core /dist directory isn't going to be used by VE-MW. [19:43:29] It's instead going to be used by third parties, who probably aren't going to give /src as well. [19:47:24] ask Krinkle [19:47:43] He's busy. :-) [20:08:59] (03PS9) 10Jforrester: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [20:10:34] (03CR) 10Jforrester: "PS9 is a rebase onto master." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [20:10:39] (03PS19) 10Jforrester: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) [20:13:55] (03PS10) 10Jforrester: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [20:14:11] (03CR) 10Jforrester: "PS10 is a rebase onto I83ebc801." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [20:15:01] (03PS7) 10Jforrester: [BREAKING CHANGE] Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (https://bugzilla.wikimedia.org/67169) (owner: 10Esanders) [20:25:34] 3VisualEditor / 3ContentEditable: VisualEditor: Double-click should not open items that shouldn't be opened - 10https://bugzilla.wikimedia.org/67176#c2 (10James Forrester) (In reply to Ed Sanders from comment #1) > Link to an example? First reference on https://en.wikipedia.org/wiki/Anne_Dallas_Dudley?veact... [21:19:13] (03CR) 10Catrope: [C: 032] Add a ve direction class to all surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142797 (https://bugzilla.wikimedia.org/66494) (owner: 10Esanders) [21:20:45] (03Merged) 10jenkins-bot: Add a ve direction class to all surfaces [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142797 (https://bugzilla.wikimedia.org/66494) (owner: 10Esanders) [21:25:07] (03PS2) 10Catrope: Fix up selection after deletion if at non-content offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) (owner: 10Esanders) [21:26:20] (03PS2) 10Catrope: Correct various things in rangy-position to make it work in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142736 [21:26:41] (03CR) 10Catrope: [C: 032] "Re-+2ing rebased version per Ed's +2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142736 (owner: 10Catrope) [21:27:26] (03CR) 10Catrope: [C: 032] Fix up selection after deletion if at non-content offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) (owner: 10Esanders) [21:28:18] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting a block item highlights the previous line - 10https://bugzilla.wikimedia.org/67213 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Low s:5normal>3minor a:3Ed Sanders [21:28:40] (03Merged) 10jenkins-bot: Correct various things in rangy-position to make it work in IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142736 (owner: 10Catrope) [21:28:58] (03Merged) 10jenkins-bot: Fix up selection after deletion if at non-content offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) (owner: 10Esanders) [21:29:53] (03PS1) 10Catrope: Fix alignment of indicators in CategoryItemWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142837 [21:33:31] (03CR) 10Catrope: [C: 04-1] Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 (owner: 10Jforrester) [21:34:18] (03CR) 10Catrope: [C: 032] Synchronise wgExtensionCredits with AUTHORS.txt, sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142815 (owner: 10Jforrester) [21:34:40] (03PS2) 10Catrope: Fix alignment of indicators in CategoryItemWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142837 [21:35:59] (03Merged) 10jenkins-bot: Synchronise wgExtensionCredits with AUTHORS.txt, sort alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142815 (owner: 10Jforrester) [21:39:42] (03PS6) 10Catrope: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [21:41:26] (03CR) 10Catrope: [C: 04-1] Provide move left/right quick action buttons for images (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [21:50:19] (03CR) 10Catrope: Provide move left/right quick action buttons for images (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [21:55:15] Hey Krinkle. [21:55:39] (03PS1) 10Esanders: Select highlights on touchend event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) [21:58:55] (03PS1) 10Esanders: Remove isMobileDevice property [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142840 [22:03:50] (03PS1) 10Catrope: [WIP] Hide resize handles on headings in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142842 [22:04:14] (03PS3) 10Jforrester: Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 [22:05:27] (03CR) 10Jforrester: Provide move left/right quick action buttons for images (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [22:18:50] (03CR) 10Jforrester: Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 (owner: 10Jforrester) [22:20:12] (03CR) 10Jforrester: [C: 032] Remove isMobileDevice property [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142840 (owner: 10Esanders) [22:21:50] (03Merged) 10jenkins-bot: Remove isMobileDevice property [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142840 (owner: 10Esanders) [22:31:49] 3VisualEditor / 3Mobile: VIsualEditor Mobile: Chrome for mobile keyboard doesn't fire any key events for backsapce - 10https://bugzilla.wikimedia.org/67262 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None Key events fire without key codes (understandable as you can 'swipe' whole words) and backspace f... [22:32:32] 3VisualEditor / 3Mobile: VIsualEditor Mobile: Chrome for mobile keyboard doesn't fire any key events for backsapce - 10https://bugzilla.wikimedia.org/67262#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major Oy. [22:36:18] 3VisualEditor / 3MediaWiki integration: The handler MWCategoryWidget::onLookupInputKeyDown is not actually bound to anything. - 10https://bugzilla.wikimedia.org/56700 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [22:37:17] (03CR) 10Jforrester: [C: 032] Fix alignment of indicators in CategoryItemWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142837 (owner: 10Catrope) [22:37:18] 3VisualEditor / 3MediaWiki integration: VisualEditor: Suggest case insensitive results when searching for categories to add - 10https://bugzilla.wikimedia.org/57302 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [22:37:48] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire any key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10Bartosz Dziewoński) [22:38:17] 3VisualEditor / 3Data Model: VisualEditor: Double colons when linking to File/Category - 10https://bugzilla.wikimedia.org/63353#c4 (10James Forrester) 5ASSI>3RESO/DUP Dupe of 50279 (and now fixed). *** This bug has been marked as a duplicate of bug 50279 *** [22:38:17] 3VisualEditor / 3Data Model: VisualEditor: Link input widget outwits itself with the leading colon for Category/file links - 10https://bugzilla.wikimedia.org/50279#c4 (10James Forrester) *** Bug 63353 has been marked as a duplicate of this bug. *** [22:38:55] (03Merged) 10jenkins-bot: Fix alignment of indicators in CategoryItemWidgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142837 (owner: 10Catrope) [22:42:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: Focusable nodes can't be deleted - 10https://bugzilla.wikimedia.org/67257 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [22:44:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire any key events for backspace - 10https://bugzilla.wikimedia.org/67262#c2 (10Ed Sanders) There is an 'input' event which fires, but this doesn't solve the problem of prevent the default backspace behaviour. [22:45:18] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire any key events for backspace - 10https://bugzilla.wikimedia.org/67262#c3 (10Ed Sanders) See https://code.google.com/p/chromium/issues/detail?id=118639 for pitchfork waving, including a complaint from the Microsoft Office We... [22:46:35] edsanders: Lovely. [22:53:18] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494 (10James Forrester) 5PATC>3RESO/FIX [23:01:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10Ed Sanders) [23:02:47] (03PS1) 10Jforrester: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142845 (https://bugzilla.wikimedia.org/66863) [23:03:00] (03Abandoned) 10Jforrester: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142845 (https://bugzilla.wikimedia.org/66863) (owner: 10Jforrester) [23:03:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c4 (10Ed Sanders) Not quite true, see http://jsbin.com/alAKaNaZ/5 Backspace fires a keydown with keyCode 0 (same as every other key event) but not wh... [23:04:22] (03PS1) 10Jforrester: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142846 [23:04:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c5 (10Ed Sanders) "No key event is generated when the BACKSPACE key is pressed outside of composition, in other words, when AdapterInputConnection.del... [23:04:41] edsanders: Can you please merge ^^^? (Cherry-pick.) [23:07:13] is there a bug description? [23:07:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=66863 [23:07:48] Click on the change-id to see the initial merge. :-) [23:08:04] We try not to tag cherry-picks to bugs so it doesn't send loads of pointless e-mails and status changes. [23:08:20] (This cherry pick is 3 commits just for the fix for one bug, for example.) [23:21:49] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox - 10https://bugzilla.wikimedia.org/65554 (10James Forrester) a:5Ed Sanders>3Alex Monk [23:22:33] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593 (10James Forrester) a:5Ed Sanders>3James Forrester [23:24:34] 3VisualEditor / 3ContentEditable: VisualEditor: Zero width no-break space is added to the end of the article in the editing element - 10https://bugzilla.wikimedia.org/54051 (10James Forrester) a:5David Chan>3None [23:24:34] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - 10https://bugzilla.wikimedia.org/60919 (10James Forrester) a:5Ed Sanders>3None [23:24:34] 3VisualEditor / 3Language: VisualEditor: CE eats up syllables except a last syllable of a word in Korean IME - 10https://bugzilla.wikimedia.org/50631 (10James Forrester) a:5David Chan>3None [23:24:34] 3VisualEditor / 3ContentEditable: VisualEditor: Safari in-surface native font styling in ContentEditable does not reach DM as an event (or get over-written by CE) - 10https://bugzilla.wikimedia.org/61884 (10James Forrester) a:5David Chan>3None [23:24:35] 3VisualEditor / 3Technical Debt: VisualEditor: There should be tests asserting we use code points as opposed to grapheme clusters - 10https://bugzilla.wikimedia.org/57630 (10James Forrester) a:5David Chan>3None [23:24:36] 3VisualEditor / 3Language: VisualEditor: jquery.IME doesn't work in VisualEditor's iframes (template, reference, reference list, media, and page settings dialogs, and language, maths, code and link inspectors) - 10https://bugzilla.wikimedia.org/53717 (10James Forrester) a:5David Chan>3None [23:24:37] 3VisualEditor / 3Technical Debt: VisualEditor: External paste of list into list should unwrap pasted list - 10https://bugzilla.wikimedia.org/57652 (10James Forrester) a:5Ed Sanders>3None [23:24:49] 3VisualEditor / 3Language: VisualEditor: Typing problem in Assamese - 10https://bugzilla.wikimedia.org/52726 (10James Forrester) a:5David Chan>3None [23:24:49] 3VisualEditor / 3Data Model: VisualEditor: Revive Inez's way of doing sub-surfaces - 10https://bugzilla.wikimedia.org/49565 (10James Forrester) a:5Ed Sanders>3None [23:24:49] 3VisualEditor / 3Technical Debt: VisualEditor: Make fakeIme QUnit testing more rigorous - 10https://bugzilla.wikimedia.org/57538 (10James Forrester) a:5David Chan>3None [23:24:49] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.splitClusters - 10https://bugzilla.wikimedia.org/57628 (10James Forrester) a:5David Chan>3None [23:24:50] 3VisualEditor / 3Language: VisualEditor: When using jquery.IME, type a word and press space bar = eliminates typed text immediately - 10https://bugzilla.wikimedia.org/53700 (10James Forrester) a:5David Chan>3None [23:24:51] 3VisualEditor / 3Technical Debt: VisualEditor: Make SurfaceWidget constructor not depend on global target - 10https://bugzilla.wikimedia.org/65881 (10James Forrester) a:5Ed Sanders>3None [23:24:52] 3VisualEditor / 3Technical Debt: VisualEditor: Make ve.dm.Transaction chainable - 10https://bugzilla.wikimedia.org/48913 (10James Forrester) a:5Ed Sanders>3None [23:25:04] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of ve.ce.Surface.prototype.setContentBranchNodeChanged - 10https://bugzilla.wikimedia.org/56264 (10James Forrester) a:5David Chan>3None [23:25:05] 3VisualEditor / 3Technical Debt: VisualEditor: Transaction with replaceMetadata then replace at the same offset doesn't rollback cleanly - 10https://bugzilla.wikimedia.org/46138 (10James Forrester) a:5Ed Sanders>3None [23:25:05] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting the parameter of any template or the template itself, scrolls the focus up to the top of the transclusion dialog - 10https://bugzilla.wikimedia.org/62420 (10James Forrester) a:5Ed Sanders>3None [23:25:05] 3VisualEditor / 3Data Model: VisualEditor: Backspace should not delete list and line in same action - 10https://bugzilla.wikimedia.org/52557 (10James Forrester) a:5Ed Sanders>3None [23:25:06] 3VisualEditor / 3Technical Debt: VisualEditor: Share ref / references re-rendering code with Parsoid - 10https://bugzilla.wikimedia.org/50505 (10James Forrester) a:5Ed Sanders>3None [23:25:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: The tapping on Mobile VE is extremely inconsistent compared to standard - 10https://bugzilla.wikimedia.org/65413 (10James Forrester) a:5Jon>3None [23:25:08] 3VisualEditor / 3Technical Debt: VisualEditor: Factor out ./ stripping logic - 10https://bugzilla.wikimedia.org/61572 (10James Forrester) a:5Ed Sanders>3None [23:25:08] (03CR) 10Esanders: [C: 032] Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142846 (owner: 10Jforrester) [23:25:09] 3VisualEditor / 3ContentEditable: VisualEditor: Backspace from (or deleteing down) into a DL breaks badly - 10https://bugzilla.wikimedia.org/50995 (10James Forrester) a:5David Chan>3None [23:25:10] 3VisualEditor / 3ContentEditable: VisualEditor: Support magic pasting of HTML that contains a reference to a wiki image - 10https://bugzilla.wikimedia.org/64935 (10James Forrester) a:5Ed Sanders>3None [23:25:11] 3VisualEditor / 3Language: VisualEditor: Marathi/Devanagari: After typing first character cursor moves in wrong direction when using jquery.IME - 10https://bugzilla.wikimedia.org/53701 (10James Forrester) a:5David Chan>3None [23:25:19] 3VisualEditor / 3Technical Debt: VisualEditor: Internal nodes should eventually be in a separate document - 10https://bugzilla.wikimedia.org/47344 (10James Forrester) a:5Ed Sanders>3None [23:25:19] 3VisualEditor / 3ContentEditable: VisualEditor: Cannot go to the next line of an article after inserting a special character in a block slug and "TypeError: Inserted data is trying to close the root node (at index 0)" appears - 10https://bugzilla.wikimedia.org/65873 (10James Forrester) a:5Ed Sanders>3None [23:26:28] (03PS1) 10Jforrester: Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142847 [23:26:34] (03Merged) 10jenkins-bot: Correctly update full size in MediaSizeWidget [VisualEditor/VisualEditor] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142846 (owner: 10Jforrester) [23:27:18] Thanks. :-) [23:28:14] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142847 (owner: 10Jforrester) [23:38:02] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.24wmf11 (f17ee7e) [extensions/VisualEditor] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142848 [23:38:11] edsanders: ^^ And that please. [23:38:36] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to wmf/1.24wmf11 (f17ee7e) [extensions/VisualEditor] (wmf/1.24wmf11) - 10https://gerrit.wikimedia.org/r/142848 (owner: 10Jforrester) [23:38:55] v-1 [23:41:55] Hmm. Jenkins can't see it in git? [23:41:58] * James_F sighs. [23:42:08] I'll get RoanKattouw_away to help me when he's next in, then. [23:48:08] (03CR) 10Jforrester: [C: 04-1] Select highlights on touchend event (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) (owner: 10Esanders) [23:48:59] edsanders: BTW, I went and cleaned up the bugs assigned to you to make it more managable. [23:50:32] (03PS1) 10Esanders: Set XML encoding to utf-8 in SVGs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142849 [23:51:05] (03PS1) 10Esanders: Set XML encoding to utf-8 in SVGs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142850 [23:51:07] (03PS1) 10Esanders: Fix colour of new cite icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142851 [23:51:55] (03CR) 10Jforrester: [C: 032] Set XML encoding to utf-8 in SVGs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142849 (owner: 10Esanders) [23:52:22] (03CR) 10Jforrester: [C: 032] Set XML encoding to utf-8 in SVGs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142850 (owner: 10Esanders) [23:52:33] (03PS2) 10Esanders: Select highlights on touchend event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) [23:53:23] (03CR) 10Jforrester: [C: 032] Fix colour of new cite icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142851 (owner: 10Esanders) [23:53:29] (03Merged) 10jenkins-bot: Set XML encoding to utf-8 in SVGs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142849 (owner: 10Esanders) [23:53:33] (03CR) 10Esanders: Select highlights on touchend event (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) (owner: 10Esanders) [23:54:01] (03Merged) 10jenkins-bot: Set XML encoding to utf-8 in SVGs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142850 (owner: 10Esanders) [23:54:56] (03Merged) 10jenkins-bot: Fix colour of new cite icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142851 (owner: 10Esanders) [23:56:06] (03CR) 10Esanders: "Should add some more test cases..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142806 (https://bugzilla.wikimedia.org/67213) (owner: 10Esanders) [23:56:37] edsanders: You mean, given that the pull-through fails due to failing tests? :-) [23:57:00] mw tests? [23:59:22] Yeah.