[02:52:42] (03CR) 10Jforrester: Select highlights on touchend event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) (owner: 10Esanders) [05:03:51] (03PS10) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [05:04:32] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [08:07:20] (03PS1) 10Vikassy: Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [08:35:52] (03PS2) 10Vikassy: Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [10:56:16] [13oojs.github.io] 15Krinkle 04deleted 06release-1.0.10 at 147d122c6: 02https://github.com/oojs/oojs.github.io/commit/7d122c6 [11:04:03] 3VisualEditor / 3Editing Tools: Edit link dialog doesn't load target links - 10https://bugzilla.wikimedia.org/67272 (10Elitre) [11:30:07] Graveyard is filling up with lovely memories [11:30:07] https://github.com/Krinkle/ts-krinkle-misc [11:30:49] Aside from the dozen or so popular tools that've been on github for a while (and migrated a while back), most of these were never even open sourced in public. [12:43:10] (03PS2) 10Esanders: Generate RTL stylesheets with CSSJanus [oojs/ui] - 10https://gerrit.wikimedia.org/r/142879 [12:44:07] (03PS11) 10Esanders: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) [14:08:48] 3MediaWiki extensions / 3TemplateData: HHVM: TemplateDataBlobTest::testGetDataInLanguage fails with "Invalid operand type was used: expecting an array" - 10https://bugzilla.wikimedia.org/66937#c1 (10Antoine "hashar" Musso) p:5Unprio>3High We really need tests to pass when all wmf extensions are installed... [14:31:33] 3VisualEditor / 3MediaWiki integration: VisualEditor (or MediaWiki?): In automated browser tests, browser loses token or logs out when switching from VE to wikitext edit mode - 10https://bugzilla.wikimedia.org/65709#c8 (10Chris McMahon) *** Bug 62583 has been marked as a duplicate of this bug. *** [14:49:19] 3VisualEditor / 3Editing Tools: Could the embedding behavior of focusable nodes be overridable - 10https://bugzilla.wikimedia.org/67306 (10Oliver Buchtala) 3UNCO p:3Unprio s:3normal a:3None Probably a matter of taste, but we find the embedded control not too appealing. In our case (a block equation)... [15:02:02] 3VisualEditor / 3Editing Tools: Allow the embedding behavior of focusable nodes to be overridden - 10https://bugzilla.wikimedia.org/67306 (10Oliver Buchtala) [16:02:02] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c7 (10James Forrester) 5PATC>3RESO/FIX Backported to wmf11 and worki... [16:20:11] 3VisualEditor / 3Language: Core message reuse - 10https://bugzilla.wikimedia.org/67274#c2 (10Robin Pepermans (SPQRobin)) I don't see why we would need separate messages for these. As far as I can see, they are used on the same location for the same function, so having separate messages would be unnecessary d... [16:30:14] 3VisualEditor / 3Language: Core message reuse - 10https://bugzilla.wikimedia.org/67274#c3 (10Nemo) (In reply to Robin Pepermans (SPQRobin) from comment #2) > Message re-use > needs to be avoided when re-using them in a different context. How is linking veaction=edit not a different context than action=edit? [16:51:43] 3VisualEditor / 3Editing Tools: VisualEditor: Fix tabindexes in the citation dialog - 10https://bugzilla.wikimedia.org/66824 (10Alex Monk) [16:51:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox - 10https://bugzilla.wikimedia.org/65554#c1 (10Alex Monk) Looks like the same issue as bug 66824 [17:02:12] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox - 10https://bugzilla.wikimedia.org/65554#c2 (10Alex Monk) So adding this.reviewButton.$element.attr( 'tabindex', '0' ).find( 'a' ).removeAttr( 'tabindex' ); fixed this... Wtf firefox? [17:03:44] 3MediaWiki extensions / 3TemplateData: TemplateData edit dialog: When importing parameters, sort them and mark "missing" parameters - 10https://bugzilla.wikimedia.org/67310 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None This is coming from hewiki feedback. When importing new parameters fro... [17:05:59] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog doesn't display very long template names gracefully - 10https://bugzilla.wikimedia.org/67267 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Trevor Parscal [17:11:27] 3MediaWiki extensions / 3TemplateData: TemplateData: When importing parameters into the GUI, sort them and mark "missing" parameters - 10https://bugzilla.wikimedia.org/67310 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [17:11:59] 3VisualEditor: Editing pages times out every single time, so that editing an existing page is impossible - 10https://bugzilla.wikimedia.org/67313 (10jazeckel) 3UNCO p:3Unprio s:3blocke a:3None Created attachment 15786 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15786&action=edit wiki debug l... [17:18:49] ES: https://gerrit.wikimedia.org/r/#/c/142810/1/modules/ve/ce/styles/ve.ce.Surface.css [17:18:59] TrevorP|Away, ^ [17:19:00] (already merged) [17:21:45] (03PS1) 10Alex Monk: Set tabindex on button
instead of [oojs/ui] - 10https://gerrit.wikimedia.org/r/143055 (https://bugzilla.wikimedia.org/65554) [17:58:00] (03PS3) 10Catrope: [Browser tests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (owner: 10Vikassy) [18:05:51] vikas: Re formula editor: I think that's probably because the formula editor live-previews your input if you don't type for 250ms [18:13:48] 3VisualEditor / 3Language: Core message reuse - 10https://bugzilla.wikimedia.org/67274#c4 (10Robin Pepermans (SPQRobin)) (In reply to Nemo from comment #3) > How is linking veaction=edit not a different context than action=edit? They are on the same location and for the same function (i.e. editing). There i... [18:16:21] (03CR) 10Catrope: [C: 032] Set tabindex for template dialog info/remove buttons on parent
rather than [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142718 (https://bugzilla.wikimedia.org/66824) (owner: 10Alex Monk) [18:17:16] (03CR) 10Catrope: [C: 032] Set tabindex on button
instead of [oojs/ui] - 10https://gerrit.wikimedia.org/r/143055 (https://bugzilla.wikimedia.org/65554) (owner: 10Alex Monk) [18:17:49] (03CR) 10Catrope: [C: 032] Select highlights on touchend event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) (owner: 10Esanders) [18:18:07] (03Merged) 10jenkins-bot: Set tabindex for template dialog info/remove buttons on parent
rather than [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142718 (https://bugzilla.wikimedia.org/66824) (owner: 10Alex Monk) [18:19:23] (03Merged) 10jenkins-bot: Set tabindex on button
instead of [oojs/ui] - 10https://gerrit.wikimedia.org/r/143055 (https://bugzilla.wikimedia.org/65554) (owner: 10Alex Monk) [18:20:13] (03Merged) 10jenkins-bot: Select highlights on touchend event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142839 (https://bugzilla.wikimedia.org/66999) (owner: 10Esanders) [18:20:23] RoanKattouw: oh ! thank you for that information. It seems to be working great in www.mediawiki.org ; I had that problem on beta labs yesterday, I will check again in beta labs and let you know :) [18:20:34] 3VisualEditor / 3Editing Tools: VisualEditor: Fix tabindexes in the citation dialog - 10https://bugzilla.wikimedia.org/66824#c7 (10Alex Monk) 5PATC>3RESO/FIX Well that's at least a workaround. I wonder if this might be an upstream bug... [18:21:03] 3VisualEditor / 3Editing Tools: VisualEditor: Fix tabindexes in the citation dialog - 10https://bugzilla.wikimedia.org/66824 (10Alex Monk) [18:21:33] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox - 10https://bugzilla.wikimedia.org/65554#c5 (10Alex Monk) 5PATC>3RESO/FIX Well that's at least a workaround. I wonder if this might be an upstream bug... [18:21:59] (03PS2) 10Catrope: Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142854 (owner: 10Esanders) [18:22:26] (03Abandoned) 10Catrope: Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142847 (owner: 10Jforrester) [18:25:19] 3VisualEditor / 3Mobile: VisualEditor Mobile: References/images require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999 (10James Forrester) 5PATC>3RESO/FIX [18:28:19] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c8 (10ryasmeen) Verified the fix on test2 [18:30:15] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142854 (owner: 10Esanders) [18:31:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (7a128e5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142854 (owner: 10Esanders) [18:32:11] oy! What do ya'll think of this bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=67243 [18:32:25] oh, nvm [18:32:33] Krinkle already replied :) [18:32:51] greg-g: You can just ping us in -dev, you know – it's the more correct channel. [18:33:19] * James_F is keen not to split conversations when we don't have to. :-) [18:33:43] I just think "js == VE team" :P I shouldn't, I know [18:33:56] Indeed. Tsk. :-P [18:34:39] James_F, did you read https://bugzilla.wikimedia.org/show_bug.cgi?id=62337#c4 ? [18:35:11] Oh. Eurgh. [18:35:38] Yeah, we should do that too, I guess. [18:35:44] More OOUI fun. [18:47:07] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c7 (10Alex Monk) 5RESO/FIX>3REOP Apparently not. [18:47:52] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) 5REOP>3ASSI [18:53:01] (03PS5) 10Catrope: Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) (owner: 10Jforrester) [18:55:00] (03CR) 10Catrope: [C: 032] Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) (owner: 10Jforrester) [18:56:07] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as a variable () - 10https://bugzilla.wikimedia.org/52664 (10James Forrester) 5PATC>3ASSI a:5James Forrester>3None [18:56:31] (03Merged) 10jenkins-bot: Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141605 (https://bugzilla.wikimedia.org/52664) (owner: 10Jforrester) [18:56:37] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as highlighted () - 10https://bugzilla.wikimedia.org/64376 (10James Forrester) 5PATC>3ASSI a:5James Forrester>3None [18:59:29] (03PS4) 10Jforrester: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (owner: 10Vikassy) [19:12:12] (03PS3) 10Catrope: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [19:12:44] (03PS1) 10Jforrester: Update VE core submodule to master (480b813) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143078 [19:14:22] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (480b813) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143078 (owner: 10Jforrester) [19:16:19] (03PS2) 10Jforrester: Update VE core submodule to master (480b813) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143078 [19:16:50] (03PS4) 10Catrope: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [19:17:09] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (480b813) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143078 (owner: 10Jforrester) [19:18:14] (03CR) 10Catrope: [C: 04-1] "PS4 adds command definitions." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [19:19:07] (03Merged) 10jenkins-bot: Update VE core submodule to master (480b813) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143078 (owner: 10Jforrester) [19:19:36] RoanKattouw: i'm going to try to bring my togetherjs extension up to date today. might mean i revisit the VE intentions patch. [19:20:00] (but first i'm doing the mechanical 'update togetherjs, ve, parsoid, and core to latest upstream' stuff) [19:21:56] cscott: Fun. Just a few changes since then. :-) [19:22:04] yeah :( [19:22:37] i spent almost all of friday just dealing with #ops changes since the last time i was working on this [19:24:21] * James_F nods. [19:24:44] Change is an train it's almost impossible to leave and then rejoin later. [19:25:28] good change logs and release notes help a lot. [19:25:51] We have a bunch of release notes for VE, but they might not help. [19:25:59] * cscott says, as someone who's realized that some of his npm modules don't actually have good change logs and release notes [19:26:12] If you have particular views I'd be happy to look at improving them in future. :-) [19:26:31] James_F: i've contributed some README patches in the past, if i recall. ;) [19:26:41] * James_F grins. [19:26:56] i'll take a look. the VE changes in question are to the guts of the ve transaction support anyway, so release notes probably won't help me much. [19:27:11] Yeah. :-( [19:27:18] RoanKattouw and i were supposed to do the deep dive on this when i was last in SFO. but we got distracted. [19:28:02] in any case, i was going to have to rebase/refactor everything based on intentions last time, so reimplementing from scratch is probably not all that hard. most of the work is knowing what needs to be done. [19:28:04] * James_F noticed. [19:28:13] Cool. [19:28:19] Shout if you need anything. :-) [19:28:31] of course, the trouble is that i've paged out a lot of the knowing. ;) [19:28:45] i hope it's still there, once my mental disk stops thrashing. [19:30:13] cscott: We did change a few things and I felt that intentions might have helped with one or two [19:30:28] But the changes aren't very impactful, it's all pretty much still the same [19:30:58] yeah, anyway the first step is for me to do a bulk update of everything, ignoring the VE integration for the moment. and then i can probably reconstruct the intentions patches based on current git head and see how it goes. [19:37:27] (03CR) 10Catrope: [C: 032] Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [19:39:08] (03Merged) 10jenkins-bot: Handle transcluding templates outside of the template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140875 (https://bugzilla.wikimedia.org/52609) (owner: 10Alex Monk) [19:40:36] 3VisualEditor / 3Editing Tools: VisualEditor: When getting TemplateData, VE automatically adds "Template:" even if another namespace is provided - 10https://bugzilla.wikimedia.org/52609 (10James Forrester) 5PATC>3RESO/FIX [19:41:33] (03CR) 10Catrope: Compress HTML data with deflate before POSTing (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [19:41:54] TrevorP|Away, why isn't InlineMenuWidget a SelectWidget? [19:42:37] edsanders: yes [19:42:44] i mean, it is [19:42:45] no? [19:43:00] it's a menu, which is a select [19:43:03] it extends widget [19:43:08] hmm [19:43:27] it composes a menu [19:43:29] that's why [19:43:40] it's a widget with a menu (which is a select) [19:43:56] use getMenu() [19:44:11] ah [19:44:21] OOUI documentation sucks [19:44:34] I'm going to need to go through and fix all that [19:51:23] 3VisualEditor / 3Editing Tools: VisualEditor: The Math Inspector loses its focus for each time a character is typed and tries to parse that - 10https://bugzilla.wikimedia.org/67326 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15794 --> https://bugzilla.wikimedia.org/attachment.c... [19:51:38] 3VisualEditor / 3Editing Tools: VisualEditor: The Math Inspector loses its focus for each time a character is typed and tries to parse that - 10https://bugzilla.wikimedia.org/67326 (10ryasmeen) a:3Ed Sanders [19:52:56] James_F: just a gentle prod that we're still awaiting review on https://gerrit.wikimedia.org/r/#/c/141085/ [20:09:28] awjr_away: Sure, sorry. [20:10:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) 5NEW>3ASSI [20:10:23] TrevorParscal, I cant click to close a menu dropdown [20:10:30] *inline menu [20:10:50] click where? [20:11:03] the input at the top [20:11:13] it closes on mousedown the re-opens on mouseup [20:11:17] have a look at the widget demo [20:11:37] then compare the behaviour of a native select, or the toolbar menu [20:11:47] which works fine [20:12:12] yeah, it's annoying right? [20:12:16] we should fix that! [20:12:32] i gotta eat lunch, but yes, I recognize the error of my inlinemenuwidget ways [20:12:33] brb [20:15:33] (03PS1) 10Alex Monk: Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [20:15:37] 3VisualEditor / 3ContentEditable: Keyboard shortcut(Alt+Shift+v) to access VE is not working in FF browser - 10https://bugzilla.wikimedia.org/67218 (10Ritu Swain) [20:15:43] James_F, does that look... almost right? ^ [20:15:55] Krenair: Will pull. [20:18:35] Krenair: It'd help if you'd added it to the demos. ;-) [20:18:38] James_F, I was testing it with https://gist.github.com/Krenair/6bcac1a35fa4ed6b7320 btw [20:26:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: References/images require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c9 (10ryasmeen) Verified the fix in Betalabs. [20:28:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c8 (10ryasmeen) 5ASSI>3RESO/FIX This seems to got fixed by: Select highlights on touchend event https://gerrit.wikimedia.org/r/142839 [20:29:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c9 (10ryasmeen) Verified the fix in Betalabs [20:31:37] Hi edsanders :) [20:31:52] hi [20:32:19] I was checking the issues that we were having in mobile, so mots of them are fixed now [20:32:22] except : https://bugzilla.wikimedia.org/show_bug.cgi?id=65326 [20:32:40] most* [20:38:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c8 (10Ed Sanders) Links don't have any custom highlights (and shields no longer exist) so this must just be a CE bug in iOS (should... [20:38:27] that looks like a browser bug :( [20:38:52] :-( [20:39:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c9 (10James Forrester) (In reply to Ed Sanders from comment #8) > We don't even have event listeners on links at the moment but we m... [20:39:40] hmm [20:40:02] James_F, I have a weird bug in VE's feedback thing, and I'm not sure if it's something I should do in the wiki or if it's a bug in the way VE translates stuff [20:40:46] mooeypoo: … OK? [20:41:34] it appears that when you fill out a bug report from inside VE, it posts it to the page where the namespace is hebrew, but the VisualEditor/Feedback is not. [20:42:00] so the page we use is Wikipedia:VisualEditor/Feedback all in hebrew. But VE posts to ויקיפדיה/VisualEditor/Feedback [20:42:03] which is the wrong page. [20:42:50] If you go to ויקיפדיה/VisualEditor/Feedback manually, you'll be transfered to the right page, but the feedback is posted there... is this something I need to do in the hewiki page? How can we even notify VE that the page is different? [20:43:05] mooeypoo: visualeditor-feedback-link is set to "Project:VisualEditor/Feedback". [20:43:08] James_F no problem - thank you :) [20:43:22] James_F, so, I need to fix it in the local wiki? [20:43:23] mooeypoo: Which is https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:VisualEditor/Feedback [20:43:36] This is a message? [20:43:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c7 (10ryasmeen) Verified the fix in Betalabs. [20:43:40] I can't find it [20:43:40] mooeypoo: Yes. [20:43:42] oh [20:43:55] OKay, so I can just ask one of the admins to replace it locally in hewiki, I think? [20:44:08] mooeypoo: modules/ve-wmf/i18n/he.json [20:44:16] mooeypoo: You can, yes. [20:44:32] mooeypoo: Wait. [20:44:33] actually I just realized I don't need to [20:44:37] I can translate it in translatewiki [20:45:06] mooeypoo: It's posted to https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:VisualEditor/Feedback not somewhere else? [20:45:21] Yeah [20:45:28] It should instead go to https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99? [20:45:37] see here: https://he.wikipedia.org/w/index.php?title=%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:VisualEditor/Feedback&&diff=15642784&oldid=15538568 [20:45:51] * James_F nods. [20:45:58] Yeah, just change the message and you'll be fine. [20:46:01] * mooeypoo nods [20:46:05] awesome, thanks! [20:48:53] hm I can't find that message in translatewiki. aharoni you around? [20:49:05] hallllo [20:49:21] looking [20:49:46] mooeypoo: again, which message? [20:49:56] visualeditor-feedback-link [20:50:05] It found the /qqq version of it funnily enough [20:50:11] but not the actual message. eh [20:50:47] mooeypoo: I think I know what's the problem, but... [20:51:09] let me see whether this is indeed a good solution [20:51:10] ah! got it [20:51:18] oh. Okay. I won't change it, then. [20:51:29] aharoni, waiting for your approval first before I translate, then. [20:51:48] you see, ithttps://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3AVisualeditor-feedback-link%2Fhe [20:52:01] brbrbrbrbr [20:52:05] I meant to post: [20:52:06] https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3AVisualeditor-feedback-link%2Fhe [20:52:14] now I don't know about other languages, [20:52:50] I just need the one for hebrew [20:52:54] but in Hebrew I intentionally kept it as in English so it would be easier for developers [20:53:00] APPARENTLY I was wrong :0 [20:53:03] :) [20:53:07] yeah it seems to post to the wrong page, hah [20:53:15] but it's a redirect [20:53:19] I made the redirect [20:53:21] see the history [20:53:27] yup, I saw [20:53:30] so it adds stuff to the redirect. [20:53:31] but apparently the posting doesn't care [20:53:38] why isn't it resolved as a redirect? [20:53:40] aharoni, just to make sure, I should change it to this: ויקיפדיה:עורך_חזותי/משוב right? [20:53:50] or Project:עורך_חזותי/משוב [20:53:52] well, theoretically yes [20:54:01] and I can just change it locally in Wikipedia [20:54:08] James_F, should we consider redirects? Is that even possible? [20:54:19] I join the question [20:54:27] when posting, redirect should be resolved [20:54:40] aharoni, well, the feedback page should probably stay where it is, no? the redirect should be fine. Also, I'm pretty sure we're not the only wiki to do that [20:54:42] but hey, maybe I'm missing something [20:54:43] or want to do that [20:54:53] translating the product name/feedback [20:55:17] mooeypoo, aharoni: The tool doesn't follow redirects, no. :-( [20:55:25] I don't know a lot about redirects, but I think there's also hard and soft ones, no? [20:55:29] bleh [20:55:35] mooeypoo, aharoni: It's unloved and untouched for years. [20:55:39] is it the feedback tool from core? [20:57:04] is this a bug or a feature? [20:57:17] I mean... *can* the tool theoretically follow redirects, or is this an API issue? [20:57:30] aharoni: Yes. [20:57:56] mooeypoo: It's a pretty dumb tool; it probably could be made to follow redirects, but I don't know about the API. [20:57:56] aharoni, ok, for now I"ll have it translated. Should I go with Project:עורך_חזותי/משוב or ויקיפדיה:עורך_חזותי/משוב [20:58:11] Project: [20:58:15] not ויקיפדיה: [20:58:20] James_F, oh, ok, maybe i could take a look at some point. [20:58:22] but don't do it just yet [20:58:29] ok [20:58:32] not doing it [20:58:37] Why am I not doing it? [20:59:30] oh, someone's talking about VE's feedback tool? [20:59:49] MatmaRex, only cool people [21:00:06] * James_F grins. [21:00:07] (03PS1) 10Esanders: Prevent iOS Safari from following links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) [21:00:08] * MatmaRex joins in then [21:00:37] here's a data point: for about half a year now, the only things that get posted on pl.wp's feedback page (https://pl.wikipedia.org/wiki/Wikipedia:VisualEditor/Opinie) are about issues with the article content [21:00:46] edsanders: Eww. But I guess that fixes it. [21:02:15] (03CR) 10Bartosz Dziewoński: [C: 04-1] Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [21:02:18] :o [21:03:41] if ( !( e.which !== 1 || e.altKey || e.ctrlKey || e.shiftKey || e.metaKey ) ) { … } [21:04:51] (03CR) 10Bartosz Dziewoński: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [21:07:41] MatmaRex: nice that you are here [21:07:50] it doesn't resolve redirects [21:08:10] a potentially-dump question, asking before testing: [21:08:16] in mediawiki.api.edit.js [21:08:48] can we add `redirect: true` to make it resolve redirects? [21:10:31] probably [21:13:23] (03PS1) 10Alex Monk: Add tabindex=0 and role=button to tool links [oojs/ui] - 10https://gerrit.wikimedia.org/r/143155 (https://bugzilla.wikimedia.org/62337) [21:15:36] mooeypoo: [21:15:51] I'm too tired to try it now, but try this one-line fix: [21:16:39] in core, resources/src/mediawiki.api/mediawiki.api.edit.js [21:17:14] line 59 [21:17:23] add `redirect: true` [21:17:41] this should resolve the issue [21:17:44] mooeypoo: ^ [21:18:37] * mooeypoo tries [21:19:06] wait, in order to try i need to set up the redirect first [21:19:54] :-D [21:20:04] hmm what's the Project: name when it's local wiki? [21:20:18] The name of the wiki? [21:24:53] 3VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None If I go to a page that has been redirected, the URL retains the original title instead of the redirected... [21:26:21] Krinkle, did the behaviour of promises change in jQuery 1.8 -> 1.11 ? [21:26:30] Not that I know [21:26:41] Other than the removal of the isRejected and isResolved methods [21:27:19] mooeypoo: James_F MatmaRex - I tried it and it works [21:27:20] If you bind a done function to an already-resolved promise, should it execute synchronously or after yield? [21:27:22] submitting a patch [21:27:36] aharoni: Well, that's a simple fix. :-) [21:27:50] aharoni, your patch works [21:27:51] (now people will argue whether that method should resolve redirects, tra-la-la, tra-la-la, tra-la-la) [21:27:56] aharoni: :-D [21:28:00] aharoni, yes, I just tried it too.. had to set up the redirect :p [21:28:02] awesome! [21:28:07] aharoni, thanks! [21:29:44] appears to be sync [21:30:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor Rewriting the URL is a bit evil, but if we don... [21:32:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c2 (10Bartosz Dziewoński) (In reply to James Forrester from comment #1) > Ideally MediaWiki's redirects should 307 rather than... [21:32:26] https://gerrit.wikimedia.org/r/#/c/143163/ [21:32:31] (03CR) 10Jforrester: [C: 04-1] "Should be added to demos/widgets.js with a couple of examples. Maybe the 'label' element should be used as a placeholder?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [21:33:49] aharoni: re https://gerrit.wikimedia.org/r/#/c/143163/1/resources/src/mediawiki.api/mediawiki.api.edit.js,cm - if that's where you want to stick this, it should definitely have a way to disable that behavior [21:34:18] aharoni: i think a better way would be to add an optional 'options' parameter to newSection(), and pass {redirect: true} there from whatever calls this [21:34:18] James_F: as I said, people argue whether that method should resolve redirects [21:34:24] yep :) [21:34:35] it's a newSection! [21:34:41] it can, but if it does, it must provide a way to disable it imo [21:34:43] why would anybody post a new section on a redirect? [21:35:02] why would anybody post a new section to a redirect? [21:35:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c3 (10James Forrester) (In reply to Bartosz Dziewoński from comment #2) > (In reply to James Forrester from comment #1) > > Ide... [21:35:41] I can think of a bunch of things that can be done with redirects [21:36:21] aharoni, and all of them happen elsewhere...? [21:36:29] in enwiki they like adding categories and templates to them, for example [21:36:32] but posting new sections to them seems particularly useless. [21:36:47] what are you trying to do, actually? something with mediawiki.feedback, right? [21:37:07] aharoni: well, you could implement adding categories by adding new sections. :P [21:37:33] ew [21:37:35] for that I'd just do an edit [21:37:40] that's some ugly code [21:37:43] this.api.newSection( this.title, subject, message, ok, err ); [21:37:50] 'ok' and 'err' parameters are deprecated D: [21:38:03] isn't the point of that method to be a shortcut?.. [21:38:24] aharoni: this.api.newSection( this.title, subject, message ).done( ok ).fail( err ) [21:38:46] let me just fix this [21:38:50] go for it [21:43:55] https://gerrit.wikimedia.org/r/143166 anyone? the current way is logging warnings in production, it's weird that no one has fixed it yet [21:46:19] aharoni: i'm writing a patch to do this my way :) [21:55:50] aharoni: does this have an associated bug report? [21:56:05] not that I know. mooeypoo ? ^ [21:56:28] MatmaRex, no, I thought it was a message issue, I aws just going to translate it [21:56:31] (03CR) 10Esanders: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [21:56:55] MatmaRex: There are an awful lot of mw.deprecate calls in prod; a few dozen a month from mediawiki.feedback won't get noticed. :-( [21:57:22] http://codepen.io/Krinkle/full/zyodJ/ [21:57:31] aharoni: mooeypoo: https://gerrit.wikimedia.org/r/143171 [21:57:33] Finally, krinkle* redirector is in place [21:57:37] Now to monitor traffic.. [21:57:40] (please test this version because i didn't :P) [21:57:47] Krinkle: Woo? [21:57:50] Krinkle: oh, that remind me [21:57:58] Krinkle: what is on the vertical axis? [21:58:04] i think i asked you this once before, but forgot [21:58:06] hits per second or hits per minute [21:58:09] note that this is sampled [21:58:34] why 'or', and how do i know which? [21:58:45] They're all one or the other, I don't know [21:58:49] heh [21:59:08] sampled here https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/ext.wikimediaEvents.deprecate.js [21:59:23] MatmaRex: That would be api_cbParam errorsfor mediawiki.api. [21:59:25] pushed into graphite here https://github.com/wikimedia/operations-puppet/blob/production/modules/webperf/files/deprecate.py [21:59:42] I think it's hits per minute [22:00:12] summarized per day. I think summarize takes average or preak [22:00:30] anyhow, these absolute numbers don't mean much due to sampling and overal trafffic fluctuation [22:00:38] interpret them only relatively to eachother [22:00:48] do we have any data on the source of these warnings? (like tracebacks) [22:00:48] okay [22:01:41] for jqmigrate there is no tracking beyond hit counting. For mw.log.deprecate we have what https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/ext.wikimediaEvents.deprecate.js collects [22:01:48] pagename, wikiid, revisionid, and mw.inspect grep [22:02:50] which is stored privately for each hit, kept in mysql on the eventlogging server [22:03:29] We should periodically query that and make a sampled dump for inspection so that users can fix popular hits [22:03:33] It's hard to use though [22:03:46] I tend to just use Special:Search or mwgrep [22:03:47] do we intentionally not log tracebacks (this could be a privacy issue i guess?), or is it not possible right now, or has just nobody thought of that? [22:04:17] It's hard getting a trace in general, even harder cross-browser and without a natural exception [22:04:26] logging it to nthe console is trivial [22:04:47] console.error(new Error()) or console.trace() or try { throw new Error(); } cach (E) { consoel.log(er); } [22:05:04] but getting it in a string is tricky, there's long jslibs written for it [22:05:13] Feel free to give it a shot and swing it into WikimediaEvents [22:05:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c4 (10Kaity Hammerstein) Note: This doesn't happen on mobile, on refresh user stays on redirect page. [22:05:50] MatmaRex: Hm.. actually, it's trickier even [22:05:57] it's asyncronous [22:06:09] you'd have to get the trace in mediawiki-core around the mw.track call [22:06:12] caller [22:06:18] near the mw.track caller [22:06:38] Which means it's gonna have to be small, cheap and fast because it's unsampled. [22:06:46] and in mediawiki.js [22:06:50] edsanders: The answer to your promises question is "you're not supposed to make assumptions either way [22:06:58] and triggered on-call [22:07:48] Krinkle: i think you could do that in the handler in ext.wikimediaEvents.deprecate.js too [22:07:58] that's synchronous afaik [22:08:05] No [22:08:06] the traceback would just have a few levels more [22:08:07] it is not [22:08:14] (03CR) 10Catrope: [C: 031] "Looks good to merge, but let's get an answer to the skipFunction question (inline)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [22:08:42] MatmaRex: at the very least the first few calls will be async [22:08:50] because it has memory [22:08:57] hm, right [22:09:33] wait, no [22:09:42] these functions are defined in mediawiki.js [22:09:57] which is always loaded first [22:10:17] i'm pretty sure that in practice this is all synchronous [22:10:22] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c4 (10James Forrester) Can this be rechecked? [22:10:47] MatmaRex: I'm telling you it's not [22:11:08] It is only sync if you invoke track after WikimediaEvents had subscribed [22:11:16] which happens in the bottom queue and is deferred in general [22:11:28] this is not unlike ga.push from google analytics [22:11:34] ah [22:11:34] If you're familiar with that [22:11:34] duh [22:11:57] right, of course, i'm stupid [22:12:07] And if I notice event handlers are doing too much computation, I'll make the entire fire() async [22:12:22] I mean, if they have to support async might as well make it always async [22:12:30] so that mw.* is not blocked on all kinds of tracking [22:12:32] that can be deferred [22:13:08] In case of deprecated functionality slowing it down a little is fine, but mw.track is used by other things as well [22:13:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418#c1 (10James Forrester) Can this be re-checked? May have been fixed. [22:13:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [22:16:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [22:19:01] Is anyone using Monobook? [22:19:27] I can't get VisualEditor to open anything in Monobook+Firefox 30. [22:20:14] whatami: On which wiki? [22:20:18] en.wp [22:20:33] I've tried half a dozen articles, three to ten times each. [22:20:45] http://en.wikipedia.org/wiki/Harlingen?veaction=edit&useskin=monobook WFM [22:20:54] (03CR) 10Jforrester: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [22:21:03] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Remove generated content node wrappers (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (https://bugzilla.wikimedia.org/67169) (owner: 10Esanders) [22:21:19] They were all short articles via Speial:Random, so not likely to have content issues. [22:21:40] (03CR) 10Bartosz Dziewoński: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [22:22:28] It doesn't work for me. [22:23:02] I've been having better luck in Vector recently, after turning off HotCat. Now it opens on the first try almost half the time. [22:23:16] But I can't get anything in Monobook, and there's a bug report at ru.wp that I wanted to check out. [22:24:23] whatami: Does it work if you are logged out? (Try using your browser's private browsing / incognito feature) [22:24:25] James_F, are you talking about CE links? [22:24:30] * RoanKattouw grumbles about https://gerrit.wikimedia.org/r/#/c/89617/ [22:24:32] middle click does nothing for me in Chrome or FF [22:24:41] right click works with the fix [22:24:42] It broke rendering of RTL refs because rtlcite isn't loaded for some reason [22:24:46] Even though it seems like it should be ... ? [22:24:48] edsanders: Links in VE e.g. in http://en.wikipedia.org/wiki/Harlingen?veaction=edit&useskin=monobook ? [22:24:51] At least, I can't get it to open if I'm logged in. With a "private browsing" window, it always works. [22:25:02] RoanKattouw: Helpful. [22:25:08] Oh, no nvm [22:25:14] It's just a parser cache incompatibility thing [22:25:28] (03CR) 10Kaldari: [C: 04-1] Reenable mobile context and style it properly (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [22:25:30] It only breaks if the page hasn't been rerendered since the change was made [22:25:34] The change dates from Oct 2013 [22:25:40] And I updated Cite just now :) [22:25:45] James_F, chrome does nothing, FF pastes [22:25:50] whatami: OK so then it's likely to be some gadget or other [22:26:09] (03CR) 10Esanders: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [22:26:11] edsanders: Middle-click on Linux is a known-broken issue. Use a different OS (Windows, Mac, etc.) to experience. [22:26:26] edsanders: You can thank Unix, especially Solaris, for that. [22:27:28] RoanKattouw, I have just cleared Special:Preferences#mw-prefsection-gadgets entirely. I still can't get a page to open. [22:27:42] Very odd [22:27:46] Which browser? [22:27:56] Firefox 30 [22:28:38] whatami: Do you have any user scripts? [22:28:51] A couple; let me see which ones... [22:30:01] https://en.wikipedia.org/wiki/User:WhatamIdoing/common.js has four [22:30:10] nothing in Chrome/Win, works in FF/Win [22:30:31] I don't remember what https://en.wikipedia.org/wiki/User:WhatamIdoing/monobook.js contains. [22:30:38] edsanders: Interesting. [22:30:47] lol [22:30:56] I found an entertaining bug in Ed's GCNode code [22:31:12] But since it mostly screws up in Vector, too, then presumably that's not the problem. [22:31:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418#c2 (10ryasmeen) 5ASSI>3RESO/FIX Yes, not getting this issue in Betalabs.Marking it as Fixed. [22:31:29] I don't know why yet, but if you have
....
Helloworld you end up with
...
worldHello [22:31:40] RoanKattouw: Whoops. [22:31:50] Yeah something's appending to the end here [22:34:31] (03CR) 10Esanders: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [22:39:29] RoanKattouw: BTW, reminder re. https://bugzilla.wikimedia.org/show_bug.cgi?id=66604 [22:40:51] Oh yeah that one [22:40:58] You know it's bad when you recognize the bug number [22:44:21] * James_F grins. [22:46:22] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c5 (10ryasmeen) Yes, for all block items such as image, reference note, template ,math function: selecting it hides the keyboard. [22:49:56] Wow I think Ed's bug is my fault [22:50:16] It's in code I wrote ages ago to unroll some jQuery stuff in ce.BranchNode [22:50:36] 3VisualEditor / 3ContentEditable: VisualEditor: Highlight for enwiki template {{columns-list}} looks broken when selected in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) p:5Normal>3Low s:5normal>3minor [22:51:07] 3VisualEditor / 3ContentEditable: VisualEditor: enwiki template {{columns-list}} looks particularly-broken at high zoom/low width - 10https://bugzilla.wikimedia.org/50269#c3 (10James Forrester) 5ASSI>3RESO/FIX (In reply to This, that and the other from comment #2) > It looks no more broken to me in VE th... [22:52:31] (03PS7) 10JGonera: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 [22:52:51] (03CR) 10JGonera: Reenable mobile context and style it properly (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [22:53:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Diff styling in save dialog is broken - 10https://bugzilla.wikimedia.org/60497#c2 (10James Forrester) 5ASSI>3RESO/FIX This has been fixed, AFAICT. [22:55:21] 3VisualEditor / 3Editing Tools: VisualEditor: Broken layout of inspector menu, link inspector (others?) in Monobook - 10https://bugzilla.wikimedia.org/50057#c2 (10James Forrester) 5ASSI>3RESO/FIX This has been fixed, AFAICT. [22:55:37] 3VisualEditor / 3Editing Tools: VisualEditor: Toolbar buttons lack a background, are mixed with page content when window is narrow - 10https://bugzilla.wikimedia.org/50227 (10James Forrester) [22:56:21] 3VisualEditor / 3Editing Tools: VisualEditor: Controls stop working when browser window is small - 10https://bugzilla.wikimedia.org/56314 (10James Forrester) [22:56:22] 3VisualEditor / 3Editing Tools: controls stop working when browser window is small - 10https://bugzilla.wikimedia.org/56314#c4 (10James Forrester) 5NEW>3RESO/FIX AFAICT this is now fixed. [23:06:08] 3VisualEditor: VisualEditor: No vertical scrollbar on insert media (Firefox) - 10https://bugzilla.wikimedia.org/60966#c3 (10WhatamIdoing) This may have been fixed. I can't reproduce this in Firefox 30. The first search on a random article produced more images than fit on the screen, and I could get to them w... [23:08:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c2 (10ryasmeen) I am getting this issue intermittently now. Surely the behavior got chan... [23:14:49] (03PS8) 10Catrope: [BREAKING CHANGE] Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (https://bugzilla.wikimedia.org/67169) (owner: 10Esanders) [23:14:51] (03PS1) 10Catrope: Fix simulation of .prepend() in ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143194 [23:15:18] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (https://bugzilla.wikimedia.org/67169) (owner: 10Esanders) [23:15:44] (03CR) 10Jforrester: [C: 032] "Per my trust in Roan." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143194 (owner: 10Catrope) [23:17:51] (03Merged) 10jenkins-bot: Fix simulation of .prepend() in ve.ce.BranchNode#onSplice [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143194 (owner: 10Catrope) [23:17:53] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove generated content node wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140439 (https://bugzilla.wikimedia.org/67169) (owner: 10Esanders) [23:18:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar buttons overlap Vector's tabs when window is narrow - 10https://bugzilla.wikimedia.org/50227 (10James Forrester) s:5normal>3minor [23:23:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c3 (10ryasmeen) Found the steps. This happens every second attempt on adding a link wher... [23:25:17] (03PS6) 10Jforrester: Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:25:32] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:26:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696#c2 (10ryasmeen) This bug now also follows the same steps as https://bugzilla.wikimedia.org/show_bug.cg... [23:28:48] (03PS7) 10Jforrester: Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:30:35] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:35:22] (03PS8) 10Jforrester: Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:38:52] (03CR) 10Catrope: [C: 032] Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [23:39:31] (03CR) 10Catrope: "James says we should special-case the case where no changes were made." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [23:40:32] (03Merged) 10jenkins-bot: Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [23:40:41] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:41:37] (03CR) 10Catrope: [C: 032] "...or we can do that later too. This code is cool so let's merge it :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [23:42:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (dc01df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140578 (owner: 10Esanders) [23:43:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer to retain changes when switching to the "Edit Source" tab - 10https://bugzilla.wikimedia.org/57462 (10James Forrester) 5PATC>3RESO/FIX [23:43:17] (03Merged) 10jenkins-bot: Compress HTML data with deflate before POSTing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141678 (https://bugzilla.wikimedia.org/66914) (owner: 10Esanders) [23:43:18] RoanKattouw, James_F was there something else we need to do there then? [23:43:43] To special-case no changes being made [23:44:11] (03PS4) 10Krinkle: EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 [23:44:14] (03PS4) 10Krinkle: EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 [23:44:19] (03PS3) 10Krinkle: test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 [23:44:42] Krenair: Just show go directly without asking for a confirm. [23:45:01] Krenair: 'Cos that's what happened before the patch landed, and there's no reason not to. [23:45:24] Hm. Perhaps this should've been done before merging... [23:45:24] Krinkle: I take it you're done, given that you're back on OOjs things? :-) [23:45:38] James_F: monitoring traffic but yeah, mostly done [23:48:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914 (10James Forrester) 5PATC>3RESO/FIX [23:49:06] 3VisualEditor / 3ContentEditable: VisualEditor: Text-only GeneratedContentNode rerenderings aren't highlighted correctly - 10https://bugzilla.wikimedia.org/67169 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Low s:5normal>3minor [23:49:25] Krenair: Oh well. :-) [23:50:12] Krinkle: Yay. Can I sling you a high-priority CI thing or two? [23:50:23] Maybe [23:50:28] I'm going to sleep soon [23:50:39] OK, do that instead; I'll ping you an e-mail. :-) [23:53:23] What's that, no resistance? I should say this more often :P [23:53:44] I'm gonna be for 20 minutes tops. If I can do it quickly, I'll do it while finishing up e-mails [23:55:38] 3VisualEditor / 3ContentEditable: VisualEditor: Templated tables seem to fail in copy paste - 10https://bugzilla.wikimedia.org/58387#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Low a:3Ed Sanders Fixed by gerrit 140439. [23:56:53] 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders We fixed this last week with some light default styling [23:57:07] Krinkle: OK, a quick-one: OOUI doc publishing. [23:57:27] * James_F wants you awake and conscious tomorrow more than he wants urgent work. :-) [23:57:54] https://doc.wikimedia.org/oojs-ui/master/ 'Generated for branch master on Mon 30 Jun 2014 18:19:28' https://integration.wikimedia.org/ci/job/oojs-ui-jsduck-publish/ [23:58:08] 3VisualEditor / 3ContentEditable: VisualEditor: Templated table cells not rendered properly in VE, but correct in Parsoid output - 10https://bugzilla.wikimedia.org/50607#c6 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders Fixed by gerrit 140439. [23:58:11] no merges since [23:58:15] s/doc/demo/ [23:58:19] right [23:58:23] Apparently I'm the one that should sleep. ;-) [23:58:51] 3VisualEditor / 3Data Model: VisualEditor: Handle transclusions within a table better - 10https://bugzilla.wikimedia.org/50951#c3 (10James Forrester) 5ASSI>3RESO/FIX Fixed by gerrit 140439. [23:59:58] (03PS1) 10Alex Monk: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462)