[00:00:37] (03CR) 10jenkins-bot: [V: 04-1] Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [00:00:38] 3VisualEditor / 3ContentEditable: VisualEditor: Table rows with no defined cells rendered as an empty line - 10https://bugzilla.wikimedia.org/53665#c1 (10James Forrester) 5ASSI>3RESO/FIX This was fixed a while ago by the Parsoid team. [00:01:56] (03PS2) 10Alex Monk: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462) [00:14:36] 3VisualEditor: VisualEditor not opening consistently in Firefox - 10https://bugzilla.wikimedia.org/65365#c1 (10WhatamIdoing) I think this might have been solved for me, by removing one of Eran's scripts from common.js However, another user who has reported the same problem isn't running that script. [00:23:02] James_F: Submitted report to openstack, jjb is broken [00:23:02] https://gist.github.com/Krinkle/8168a5d0cb2ce3187bfa [00:23:15] o/ [00:28:36] 3VisualEditor: VisualEditor not opening consistently in Firefox - 10https://bugzilla.wikimedia.org/65365#c2 (10Roan Kattouw) Are/were there any errors in the JS console at all? [00:29:25] Krinkle|detached: Fun. [00:34:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15796 --> https://bugzilla.wikimed... [00:48:24] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachm... [00:49:21] 3VisualEditor / 3ContentEditable: VisualEditor: Using up-arrow to scroll lets you put the cursor under the toolbar in Firefox, Internet Explorer - 10https://bugzilla.wikimedia.org/48787#c8 (10James Forrester) Apparently IE is affected too (see bug 63778). [01:00:30] (03CR) 10Catrope: [C: 04-1] Merge Media Edit and Media Insert dialogs (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [01:01:37] (03PS1) 10Jforrester: Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 [01:01:40] (03PS3) 10Catrope: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [01:03:02] (03CR) 10Catrope: [C: 032] Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [01:03:11] 3VisualEditor: VisualEditor not opening consistently in Firefox - 10https://bugzilla.wikimedia.org/65365#c3 (10WhatamIdoing) "Storage error" load.php:161 "[Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: ""]" DOMExcept... [01:03:26] (03CR) 10jenkins-bot: [V: 04-1] Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [01:04:41] (03Merged) 10jenkins-bot: Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143203 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [01:06:58] (03PS2) 10Jforrester: Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 [01:09:08] (03CR) 10Catrope: [C: 04-1] "Looks fine, but should be rebased onto Trevor's window refactor when he's done. Since he's changing how windows are managed, I'm not sure " [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [01:09:21] (03PS1) 10Jforrester: Re-label "Clear formatting" to "Clear styling" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143229 [01:09:45] (03CR) 10Catrope: [C: 04-1] Add tabindex=0 and role=button to tool links (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/143155 (https://bugzilla.wikimedia.org/62337) (owner: 10Alex Monk) [01:12:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer to retain changes when switching to the "Edit Source" tab - 10https://bugzilla.wikimedia.org/57462 (10James Forrester) 5PATC>3RESO/FIX [01:21:41] (03CR) 10Catrope: [C: 04-1] Move some stuff from ViewPageTarget to MWSaveDialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140868 (https://bugzilla.wikimedia.org/65513) (owner: 10Alex Monk) [01:22:26] (03CR) 10Catrope: [C: 032] Re-label "Clear formatting" to "Clear styling" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143229 (owner: 10Jforrester) [01:23:52] (03Merged) 10jenkins-bot: Re-label "Clear formatting" to "Clear styling" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143229 (owner: 10Jforrester) [01:24:34] (03CR) 10Catrope: [C: 04-1] Move reference tool into Cite menu, and language into styling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [02:24:41] (03PS3) 10Jforrester: Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 [02:24:58] (03PS1) 10Jforrester: Update VE core submodule to master (579a214) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143237 [03:40:10] 3VisualEditor: Prompt for edit summary preference breaks the save dialog - 10https://bugzilla.wikimedia.org/67345 (10Keegan Peterzell) 3NEW p:3Unprio s:3normal a:3None If a user has the preference "Prompt me when entering a blank edit summary" selected, VisualEditor's save dialog has to be closed and r... [03:45:34] (03PS1) 10Jforrester: Provide the (currently-unused) external link icon in LTR and RTL variants [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 [03:46:24] * mooeypoo harumphs at the "old" (current) TemplateData GUI [03:49:20] (03PS1) 10Jforrester: Provide RTL variants of eight icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 [03:49:33] mooeypoo: :-) [03:50:07] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593#c1 (10James Forrester) 5ASSI>3PATC (In reply to Amir E. Aharoni from comment #0) > Some icons need to be flipped for RTL languages. Here's what I found till > now: > > In lib... [03:50:25] James_F, meh, it's like the second time I'm restarting my attempt to fix a bug that I thought was pretty straight forward when I started. [03:50:25] * mooeypoo sighs [03:50:29] :-( [03:50:32] so much for straight forward "oh that's easy!" [03:51:23] I think I just need to restart fresh instead of forcing my *clearly* not working current solution. [03:55:25] TrevorParscal: I hope you're not working. :-) [03:57:41] working on Zelda, Minish Cap [04:00:06] TrevorParscal: OK, that's allowed. :-) [04:00:25] TrevorParscal: Also, you need to come over and help me finish off 150cc on MK8. [04:01:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Prompt for edit summary preference breaks the save dialog - 10https://bugzilla.wikimedia.org/67345#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low Sounds like we need to code in that the you-must-set-an-edit-summary message is a recoverable error. [04:02:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: Prompt for edit summary preference breaks the save dialog - 10https://bugzilla.wikimedia.org/67345 (10James Forrester) a:3Alex Monk [04:08:46] TrevorParscal, omg, is Zelda's next version coming with oojs!? \o/ [04:09:06] mooeypoo: :-) [04:53:05] (03CR) 10Jforrester: Move reference tool into Cite menu, and language into styling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [05:58:36] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593#c2 (10Amir E. Aharoni) (In reply to James Forrester from comment #1) > (In reply to Amir E. Aharoni from comment #0) > > Some icons need to be flipped for RTL languages. Here's wh... [06:48:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [07:07:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [07:50:06] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10Thiemo Mättig) [09:14:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134835 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [09:54:38] 3VisualEditor: 'small' dialog doesn't fit a field label and a input field - 10https://bugzilla.wikimedia.org/67354 (10marielle.volz) 3UNCO p:3Unprio s:3trivia a:3None Created attachment 15800 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15800&action=edit example of a small dialog with label a... [09:55:06] 3VisualEditor: VisualEditor: No vertical scrollbar on insert media (Firefox) - 10https://bugzilla.wikimedia.org/60966#c4 (10Lokal_Profil) 5NEW>3RESO/FIX I can no longer reproduce it so seems fixed (in Firefox or on our side). I'll close it as fixed. [10:11:49] (03CR) 10Esanders: "Indeed, the tools claim to be 'bigger'/'small' but really they're 'big'/'small'." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [10:49:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [10:53:06] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing Escape or Tab in an empty line inserts pawn symbol (♙) in Opera 12 - 10https://bugzilla.wikimedia.org/63630#c6 (10Ed Sanders) Seems like it wouldn't be a problem if you just filtered out those keycodes. [11:01:36] 3VisualEditor / 3Data Model: VisualEditor: Handle transclusions within a table better - 10https://bugzilla.wikimedia.org/50951#c4 (10Ed Sanders) The table will still be broken after an edit as Parsoid doesn't run with context yet. [11:05:06] edsanders: Did you figure out the promise issues? [11:28:06] 3VisualEditor / 3ContentEditable: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description page - 10https://bugzilla.wikimedia.org/50321#c4 (10Ed Sanders) Middle click/ctrl click on *content editable* links in browser specific behavi... [12:14:55] How do I get to the model inside the reference dialog? [14:11:37] (03CR) 10Bartosz Dziewoński: Prevent iOS Safari from following links (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [14:16:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340#c1 (10Brion Vibber) Yep, I can confirm this on my iPad Air (iOS 7.1) when not using an external Bluetooth key... [14:38:01] (03CR) 10Alex Monk: Add tabindex=0 and role=button to tool links (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/143155 (https://bugzilla.wikimedia.org/62337) (owner: 10Alex Monk) [14:40:50] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface: Prevent incorrect pawning in Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143322 (https://bugzilla.wikimedia.org/63630) [14:54:21] (03PS1) 10Alex Monk: After showing missing edit summary error, mark the dialog as not pending anymore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143326 (https://bugzilla.wikimedia.org/67345) [14:55:39] 3VisualEditor / 3ContentEditable: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevent legit keypresses from being handled (e.g. typing "ą” in Polish) - 10https://bugzilla.wikimedia.org/67367 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Writing https://gerrit.wikimedia.... [14:55:44] James_F: :( [14:55:58] MatmaRex: Oh dear. [14:56:19] MatmaRex: Is that "sometimes prevent keypresses" or "prevent some keypresses"? [14:56:23] this is rather rare in practice, luckily [14:56:40] hm. "sometimes prevents some keypresses", in fact. :) [14:56:49] Ah. [14:57:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: Prompt for edit summary preference breaks the save dialog - 10https://bugzilla.wikimedia.org/67345#c3 (10Alex Monk) This was probably an oversight on my part in Gerrit change 135945 [14:59:51] 3VisualEditor / 3ContentEditable: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing "ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367 (10Bartosz Dziewoński) [15:03:06] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?) - 10https://bugzilla.wikimedia.org/66353 (10James Forrester) 5PATC>3RESO/FIX [15:03:07] (03CR) 10Esanders: [C: 032] test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 (owner: 10Krinkle) [15:03:53] (03CR) 10Esanders: [C: 032] test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 (owner: 10Krinkle) [15:04:32] (03CR) 10Esanders: [C: 032] test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 (owner: 10Krinkle) [15:04:49] Woo, code coverage. :-) [15:05:11] (03CR) 10Esanders: [C: 032] test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 (owner: 10Krinkle) [15:05:12] Oh, yeah. [15:05:57] Krinkle: Could you review https://gerrit.wikimedia.org/r/#/c/137367/ and re-consider "your" -1 (put there by Ed in your name)? He's suggesting adding a source map, but given that users of /dist aren't going to have /src it seems silly. [15:06:32] James_F: I'd like to focus on cssjanus at some point. That also has been on the self for about a year. Basically a sprint to start filling in github.com/cssjanus with Trevor's nodejs fork, the MW fork of the python code (with bug fixes) and our PHP version. Then get them synced up with shared unit tests and make one release. [15:07:00] Right now they're drifting in three different directions [15:07:03] Krinkle: Yes, that'd be good (and especially the LESS-related issues with flipping). [15:07:28] I'm not sure which bug you refer to. I reckon that's a bug in lessphp [15:07:38] But will see, definitely time for some bug fixes and minor enhancements [15:07:53] Depending on an abandoned project is not nice :) [15:07:54] * James_F nods. [15:07:54] (03Merged) 10jenkins-bot: test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 (owner: 10Krinkle) [15:07:56] (03Merged) 10jenkins-bot: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 (owner: 10Krinkle) [15:08:26] Krinkle: I mean https://bugzilla.wikimedia.org/show_bug.cgi?id=66091 "ResourceLoaderLESSFunctions::embed does not support CSSJanus flipping for RTL". [15:08:27] (03Merged) 10jenkins-bot: test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 (owner: 10Krinkle) [15:09:16] Krinkle: And https://bugzilla.wikimedia.org/show_bug.cgi?id=54673 ("LESS compiler should preserve the position of CSSMin / CSSJanus annotations") [15:09:34] Krinkle: But a quick code re-review on 137367 would be nice first. :-) [15:10:40] (03CR) 10Esanders: [C: 032] "jQuery.on lets you double-bind but, interestingly, native addEventListener doesn't. Either approach seems fine as long as it's documented." [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 (owner: 10Krinkle) [15:11:12] (03Merged) 10jenkins-bot: test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 (owner: 10Krinkle) [15:11:36] MatmaRex: BTW, can I bully you into +2'ing https://gerrit.wikimedia.org/r/#/c/123348/ in BetaFeatures? :-) [15:11:50] (03CR) 10Esanders: [C: 032] EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 (owner: 10Krinkle) [15:12:21] (03CR) 10Esanders: [C: 032] EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [15:12:25] edsanders: Only one to go! [15:13:46] (03CR) 10Esanders: [C: 032] test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 (owner: 10Krinkle) [15:13:58] And now we have a clean slate. Lovely. :-) [15:14:07] (03PS1) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [15:14:08] James_F: i can merge that any second, provided you don't break the Opera hack ;) [15:14:32] We don't break, we test. [15:14:55] MatmaRex: Wait, you didn't upstream the fix to MW's LESS? [15:15:05] MatmaRex: So all the extensions using that core function are broken in Opera? [15:15:17] MatmaRex: I don't think one-off hacks are the way to fix support for Opera. :-) [15:15:54] (03Merged) 10jenkins-bot: EventEmitter: Remove dead code that claims to prevent double bindings [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 (owner: 10Krinkle) [15:15:55] James_F: no, only the extensions that use the elaborate combination of markup and CSS used by BetaFeatures that triggers the bug [15:15:56] (03Merged) 10jenkins-bot: EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 (owner: 10Krinkle) [15:16:21] MatmaRex: BetaFeatures and VisualEditor and OOUI and MobileFrontend and GettingStarted and… [15:16:23] James_F, I'm slightly worried about the complexities of 'default' alignment getting into the business of your image alignment buttons [15:16:26] James_F: the correct behavior is to use SVG, the bug is that sometimes-rarely the SVG disappears magically, the "fix" is to just use the PNG instead in these cases [15:16:27] (03CR) 10jenkins-bot: [V: 04-1] Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders) [15:16:35] mooeypoo: Yeah. :-( [15:16:59] MatmaRex: So have an Opera-specific hack in background-image-svg to instead emit a PNG and be done? [15:17:00] James_F: i am not aware of any other styles that exhibit the issue [15:17:10] (03Merged) 10jenkins-bot: EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [15:17:12] (03Merged) 10jenkins-bot: test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 (owner: 10Krinkle) [15:17:20] James_F, can we use the image model through the buttons? [15:17:21] James_F: i think VE toolbar used to be affected, but i haven't reproduced that in a long while for some reason [15:17:36] and the upstream fix wouldn't work because you roll your own method for VE toolbar anyway [15:17:39] mooeypoo: Yes. [15:17:50] MatmaRex: It's still background-svgs with rounded corners. [15:18:04] James_F, might be easier.. I'm trying to test now, but my computer is crawling its way through each refresh. [15:18:06] MatmaRex: Sure, but most people re-use one of the two frameworks (MW's or OOUI's). [15:18:11] James_F: i don't think the overhead for other browsers is worth it in the general case [15:18:28] (even if tiny, there is some overhead) [15:18:42] MatmaRex: What overhead? "background-image: -o-linear-gradient(transparent, transparent), url(images/checked.png);" won't be overhead for non-Opera browsers, surely? [15:19:00] but checking checkboxes sounds like is a pretty critical feature to me [15:19:25] I agree. But you don't want to fix it? [15:19:27] James_F: i dunno. we had some long-winded discussions about what is appropriate to support in that mixin and what's not, i think [15:19:41] MatmaRex: And people decided that not supporting Opera was a good plan? :-( [15:20:07] i think the discussions happened before anyone documented this bug :) [15:20:50] Helpful. [15:21:05] Clearly we need to have a better conversation with more data. :-) [15:23:30] edsanders: Interesting, I didn't know dom/EventTarget required a unique callback list [15:23:35] http://dom.spec.whatwg.org/#eventtarget [15:23:42] "" The event listener is appended to target's list of event listeners and is not appended if it is a duplicate (the event listeners in the list are unique). [15:25:01] i dunno, i'd be okay with fewer conversations and just keeping that one line of code in the .less exactly the way it is in .css :) [15:25:54] MatmaRex: How? LESS doesn't really have a "use this function but in this browser over-ride this function with this line instead". [15:27:55] James_F: it can just be placed below? that will work as far as i can see [15:27:57] (03CR) 10Mooeypoo: [C: 04-1] "On top of my comment/suggestion for the action, I think we should also beware of confusing the users with the behavior and which images ca" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [15:27:59] .mw-ui-styled-checkbox-label.mw-ui-checked { [15:28:03] .background-image-svg('images/checked.svg','images/checked.png'); [15:28:14] James_F, I can help fixing this up if you want [15:28:15] * Fix for Opera 12 not rendering SVG backgrounds on border-radius labels */ [15:28:17] background-image: -o-linear-gradient(transparent, transparent), url(images/checked.png); [15:28:18] } [15:28:38] i'm pretty sure this will work, it's just a bit ugly maybe [15:29:06] mooeypoo: That'd be great. [15:29:13] James_F, or.. trying to fix this up. I'm slightly worried that with the whole image complexity we're missing something; but it should be straight forward.. i think. [15:29:16] * mooeypoo nods [15:29:39] MatmaRex: Won't that just set it as an SVG and then add a PNG to it? [15:29:58] no, it will override the earlier background-image rules [15:30:11] Eurgh. [15:30:36] (the .background-image-svg mixin already depends on this behavior) [15:30:56] in CSS3 an element can have multiple, comma separated, background images. But it is still one value. Overriding it (by another declaration in the same rule, or by inheritance) replaces the entire value [15:31:49] Krinkle: Aha, thanks. [15:32:04] Think about font-family [15:32:29] * James_F nods. [15:32:42] James_F: speaking of something more pleasant :) can i have a way in VE to add "autonumbered" external links? i think trying to add an external link to http://example.com when nothing is selected should produce "[http://example.com]" instead of "[http://example.com http://example.com]" [15:33:28] (excuse me for confusing ce and dm and wikitext in one sentence, but you know what i mean) [15:33:51] MatmaRex: :-) [15:34:21] (03PS2) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [15:35:14] MatmaRex: Done. [15:36:58] 3VisualEditor: VisualEditor: The Help menu does not scroll on small screens while using Monobook - 10https://bugzilla.wikimedia.org/67370 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1. Make your browser window short (<400 pixels?). 2. Open a page using the Monobook skin,... [15:40:23] James_F: will look in a minute [15:40:34] i'm trying to figure out how to implement what i just described :) [15:40:57] * James_F laughs. [15:41:22] MatmaRex: Did you see https://www.mediawiki.org/wiki/VisualEditor_gadgets#Adding_a_table that I wrote? [15:42:24] James_F: ha, didn't. neat [15:42:45] do tabelCells require a paragraph inside? [15:42:49] tableCells* [15:43:44] MatmaRex: Yes, we only allow text inside

s in CE (and then we strip them as needed). [15:44:03] MatmaRex: You want to insert a "link/mwNumberedExternal" with some settings, and then a "/link/mwNumberedExternal" [15:44:14] MatmaRex: I don't know off-hand what the settings are, but the DM node will tell you. [15:45:04] James_F: yeah, i'm trying to figure out how to make an annotation tool do that [15:45:19] MatmaRex: You can't have a mwNumberedExternal as an annotation – it's a node. [15:45:32] i know [15:45:33] MatmaRex: The whole point is that it manages its own output, it's not applied to content. [15:45:50] but ve.ui.LinkInspector is a ve.ui.AnnotationInspector [15:46:01] and it looks like ve.ui.LinkInspector is what inserts the link [15:46:12] Yes, but it has lots of magic in it that people shouldn't copy. [15:46:21] Magic ~== hacks. :-) [15:46:55] looks like i'd need to override #getFragment [15:47:06] ah, just let me play with it and leter you'll tell me if what i did was horribly wrong. :P [15:47:17] * James_F laughs. [15:50:06] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing "ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [15:51:36] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593#c3 (10James Forrester) (In reply to Amir E. Aharoni from comment #2) > (In reply to James Forrester from comment #1) > > (In reply to Amir E. Aharoni from comment #0) > > > Some i... [16:14:13] James_F, do you want the direction left/right buttons to appear on align=center images too? [16:14:15] or just left/right [16:15:05] (03PS2) 10Alex Monk: Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [16:15:29] mooeypoo: Yeah, left if right or centre, right if left or centre, not shown if none or inline. [16:15:37] * mooeypoo nods [16:15:46] (03CR) 10Catrope: [C: 032] Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [16:16:51] RoanKattouw: Woo. :-) You're in early. [16:17:40] (03Merged) 10jenkins-bot: Move reference tool into Cite menu, and language into styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [16:18:38] James_F: ha, almost got it. fun fact: you *can* place an annotation on top of a 'link/mwNumberedExternal', but that doesn't mean it will be handled gracefully. :P [16:19:01] MatmaRex: Oh, yeah, sorry, that won't work very well. [16:19:35] James_F: Yeah I magically woke up at liek 7 and was perfectly awake. No idea why [16:19:51] RoanKattouw: "liek" suggests "perfectly" may not be quite right. :-) [16:20:00] MatmaRex: Yes, inline nodes are annotatable, but you annotate them at your own risk [16:20:19] MatmaRex: Also, I think there's a separate inspector for link nodes somewhere? Trevor refactored this recently so I don't know what's going on [16:20:37] LinkNodeInspector or something. [16:20:37] Previously it was an AnnotationInspector subclass sometimes inspecting nodes instead, which meant it had to thwart its inherited behavior in all sorts of evil ways [16:20:48] yes [16:21:22] mooeypoo: Yes, James's code should probably use the image model [16:21:31] RoanKattouw, I'm working on it now [16:21:35] He has an image node object so that should be easy, right? [16:21:36] OK cool [16:21:37] + adding checks for default alignment [16:21:41] yeah that part was easy [16:21:44] Meh and mvolz is no longer around for me to respond to [16:21:54] the "check if the current alignment is the default one" was a bit more confusing [16:22:10] mooeypoo: Does MWImageModel not have a method for "tell me what the current alignment really is" that resolves default values? [16:22:26] RoanKattouw, it does, but I didn't want to build *another* image model just for that test [16:22:39] the test is small [16:22:40] Another? I don't understand [16:22:50] instantiate it, I mean [16:23:02] like, another MWImageModel object per 'isCompatibleWith [16:23:04] Oh, right [16:23:11] Because check and the action are separate, of coures [16:23:16] the test itself is a one-liner [16:23:41] I'm just cleaning it up now, basically, trying to avoid code duplication [16:24:16] RoanKattouw, is it okay to add another parameter to the 'isCompatibleWith' so I can call it from the children ? [16:24:37] 3VisualEditor: 'small' dialog doesn't fit a field label and a input field - 10https://bugzilla.wikimedia.org/67354#c1 (10Ed Sanders) The small dialog is really just for smaller alert windows. You'll probably end up with more controls and data requiring medium. If you really want to use a small, it's ok to ove... [16:24:43] so, super.isCompatibleWidth( model, 'left' ) ... or should I just call it a different name [16:24:44] mooeypoo: Explain? [16:24:54] RoanKattouw, okay, let me explain this better [16:24:56] I don't see where you're going with that [16:25:18] We have 've.ui.MWBlockMediaMoveRightTool' and 've.ui.MWBlockMediaMoveLeftTool' [16:25:32] and both are extending 've.ui.MWBlockMediaMoveTool' [16:26:00] the 'isCompatibleWith' method is the exact same for both of the children, with only a change of variable [16:26:22] so I want to put that in the parent, and have both children call the parent -- but I do need to change that variable. [16:26:26] I guess I can just name it something else. [16:27:21] (03CR) 10Esanders: [C: 032] After showing missing edit summary error, mark the dialog as not pending anymore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143326 (https://bugzilla.wikimedia.org/67345) (owner: 10Alex Monk) [16:27:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Prompt for edit summary preference breaks the save dialog - 10https://bugzilla.wikimedia.org/67345 (10James Forrester) 5PATC>3RESO/FIX [16:28:18] RoanKattouw, I can also push that code in and you can see if I this is A Bad Idea and I'll just change the name of the method [16:28:59] (03Merged) 10jenkins-bot: After showing missing edit summary error, mark the dialog as not pending anymore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143326 (https://bugzilla.wikimedia.org/67345) (owner: 10Alex Monk) [16:32:59] mooeypoo: Oooh that's clever [16:33:10] mooeypoo: Actually, you know how you should do that [16:33:14] Make the direction a static variable [16:33:31] /** @abstract */ ve.ui.MWBlockMediaMoveTool.static.alignment = null; [16:33:36] ooo! [16:33:42] oh that works [16:33:43] ve.ui.MWBlockMediaMoveLeftTool.static.alignment = 'left'; [16:33:53] Then because isCompatible is also static, you have to access it as this.alignment [16:34:10] then I won't need the individual isCompatible at all [16:34:14] just the parent's [16:34:15] Exactly [16:34:20] awesomesauce :D [16:37:35] RoanKattouw, oy, I'm getting an error [16:37:40] I have this: this.constructor.static.toAlign [16:37:51] and I get "Uncaught TypeError: Cannot read property 'toAlign' of undefined " [16:38:06] 3VisualEditor / 3Editing Tools: Embedded context menu gets in the way of content when live-editing a tall extension node - 10https://bugzilla.wikimedia.org/67306#c1 (10Ed Sanders) It would be nice to keep it consistent, although for a live-updating node it would certainly make sense to keep the context menu... [16:38:07] mooeypoo: [09:33] RoanKattouw Then because isCompatible is also static, you have to access it as this.alignment [16:38:22] ohhh [16:38:25] I missed that. [16:38:28] In a static method, 'this' obviously isn't an instance, so there is no this.constructor [16:38:44] In "normal" languages you can't use 'this' in static methods at all, but in JS it just refers to the .static object [16:39:01] oh that's a good point... I thought you can't use 'this' in static-- ah [16:39:21] awesome, testing now to make sure all works before sending to review [16:41:16] (03PS7) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [16:42:06] oh foo to eg-iframe [16:42:20] Is it out of sync again? [16:42:29] Oh, right [16:42:32] yeah :\ [16:42:38] I didn't notice [16:42:54] He must've forgotten to run grunt when writing his pull-through [16:42:58] Hold on, I'll fix this [16:43:33] RoanKattouw, btw, how does JS's garbage collection works in that aspect of objects? the 'move' action is a one-time thing. Should I do imageModel = null at the end to clean things up? [16:43:44] No he didn't forget [16:43:54] You may have your submodule out of sync instead [16:44:07] I just sync'ed it... hm [16:44:27] mooeypoo: Try running git submodule update? I mean I'm assuming you don't need any VE core changes for this change [16:44:34] ok wait suddenly the iframe is updated AGAIN [16:44:41] Re garbage collection, generally you don't need to explicitly unset things [16:45:30] As long as nothing has a reference to the object (or the only objects that have a reference to it are themselves not referenced) it'll get cleaned up [16:45:51] RoanKattouw, ok, when I look at the new iframe, it is a lot smaller than the change in gerrit -- but it still has the ve.ce.TableCellNode.css [16:45:55] In fact, nulling out the variable will not destroy the object if something else still has a reference [16:45:59] I just updated the module and re-ran grunt :\ [16:46:04] wtf [16:46:09] I ran grunt on master and it was a no-op [16:46:20] If you rebase onto master and run git submodule update it should stop updating [16:46:29] RoanKattouw, yes, I assumed the scope in this case 'cleans' the object, since imageModel in the action is local [16:46:55] Well, the variable going out of scope means that a reference is lost [16:47:09] The object continues to exist, but presumably there are zero references to it now [16:47:14] so it'll get cleaned up [16:47:20] RoanKattouw, ... git rebase master --> CONFLICT in .docs/eg-iframe.html [16:47:21] // [16:47:22] .... [16:47:40] lol [16:47:49] grunt build ; git add .docs/eg-iframe.html [16:47:54] (03PS8) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [16:48:00] gerrit to the rescue in this case [16:48:04] nice [16:48:35] Garbage collection problems tend to occur when references are stored somewhere very persistent (e.g. global variables), or when there are reference loops [16:48:42] * mooeypoo nods [16:49:01] For instance, if you have an A, and it has this.b = new B(); but then it does this.b.connect( this, { ... } ); [16:49:17] right, I know that the dialogs clean up the this.whatever references. I wanted to make sure I don't need to do that in the action. [16:49:25] Then A has a reference to B (this.b) and B has a reference to A (in the depths of this.bindings somewhere) [16:49:35] hah [16:49:50] We tend to break these kinds of loops by doing this.b.disconnect( this ); when we're done [16:49:56] * mooeypoo nods [16:49:58] You'll see .destroy() functions in classes for that reason [16:50:25] Also, if you do this.$element.on( 'eventname', ve.bind( this.onEvent, this ) ); [16:50:29] Yeah I do that with the media dialog too, when you 'attach' an image to the model, it first disconnects so then I can reconnect the events properly. [16:50:34] hmmmm. so AnnotationInspector makes it impossible to add text without annotating it with something. [16:50:37] Then this has a reference to this.$element, and this.$element has an internal reference to this [16:50:42] so i can't do what i wanted cleanly. [16:50:43] (03PS1) 10Bartosz Dziewoński: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) [16:50:49] (see commit message) [16:50:51] So we tend to do this.$element.remove() (removes from the DOM and destroys event bindings) as well [16:50:53] James_F: that almost works! [16:50:54] 3VisualEditor / 3ContentEditable: VisualEditor: Double-click should not open items that shouldn't be opened - 10https://bugzilla.wikimedia.org/67176 (10Ed Sanders) a:3Ed Sanders [16:51:29] MatmaRex: lol [16:51:38] I knew AnnotationInspector had issues [16:51:44] But I didn't realize this was one of them [16:51:54] oh.... RoanKattouw uh.. wait, remove() or detach()? [16:52:13] MatmaRex: Also surely that method needs to return a ve.dm.Annotation object, not a string? [16:52:37] 3VisualEditor / 3Editing Tools: Edit link dialog doesn't load target links - 10https://bugzilla.wikimedia.org/67272#c1 (10James Forrester) 5UNCO>3RESO/WON This is an intentional change; if you just click out of the link inspector it will apply the link. [16:52:51] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create auto-numbered external links, or convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309#c6 (10Bartosz Dziewoński) (In reply to James Forrester from comment #2) > You cannot … > > * … create an auto-numbere... [16:53:00] mooeypoo: They're different. .detach() just removes from the DOM, .remove() does that plus it removes data, event bindings, etc [16:53:07] RoanKattouw: a string works, this is passed to ve.dm.SurfaceFragment.prototype.annotateContent which accepts strings [16:53:20] You use .detach() when you want to take it out of the DOM for now but possibly reused later; you use .remove() when you want it to die in a fire [16:53:26] aahha [16:53:28] MatmaRex: Hmph, fine [16:53:44] RoanKattouw, you possibly just helped me figure out a REALLY annoying oojs-ui bug in my project [16:53:53] MatmaRex: Also (not your fault, Trevor's fault) wtf is up with that file. It's named MWLinkAnnotationInspector (sensible) but the class inside it is called MWLinkInspector [16:54:52] RoanKattouw: hah, i didn't even notice. http://i.imgur.com/sS3uRGw.png [16:55:02] MatmaRex: As to the general problem: the best way to address this may be to take an AnnotationSet rather than a single annotation; then you could return an empty set [16:55:30] oooh, that would make sense [16:56:51] 3VisualEditor / 3Editing Tools: Edit link dialog doesn't load target links - 10https://bugzilla.wikimedia.org/67272#c2 (10Elitre) 5RESO/WON>3REOP I should have probably explained this better :) If you wrote a word, then clicked on the chain icon, didn't the inspector show automatically a list of suggeste... [17:01:54] James_F: RoanKattouw_away: also, interesting behavior of the span annotation + link node thing i implemented: converting the link node to link annotation causes the outer span annotation to disappear. not sure if that's intended or not, but definitely interesting [17:02:17] (by 'disappear', i mean 'there is no in output wikitext') [17:10:23] (03PS1) 10Esanders: Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) [17:11:02] (03CR) 10jenkins-bot: [V: 04-1] Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) (owner: 10Esanders) [17:14:09] James_F: one question and one nitpick: https://gerrit.wikimedia.org/r/#/c/123348/7/resources/betafeatures.less,cm [17:17:39] 3VisualEditor / 3Editing Tools: VisualEditor: Autoconversion of external links to wikis is fabulous, except when the wiki doesn't know about the wiki - 10https://bugzilla.wikimedia.org/67373 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This may be related to bug 42986: VisualEditor and Parsoid... [17:19:22] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367 (10Bartosz Dziewoński) [17:28:32] MatmaRex: Interesting; did it also get removed from the data model? [17:28:46] MatmaRex: Ha; thanks for the spot. [17:28:51] It's possible that AnnotationInspector is additionally buggy in that it removes other annotations, but I didn't think that was the case [17:29:03] Like, I've never heard of anyone experiencing problems with bolded links for example [17:29:39] RoanKattouw: hm, i didn't check. i assumed something strips it because a simple does nothing [17:30:01] it might be parsoid's doing too? [17:30:16] although it's not stripped when the link node is annotated with it [17:30:37] Hmm yeah maybe it ends up as an empty span, that's possible [17:31:38] ah. hmm [17:32:17] so you mean it's [http://foo] →[http://foo http://foo] ? [17:32:59] asd [http://foo] asd →asd [http://foo http://foo] asd [17:36:19] Possibly [17:36:19] MatmaRex: There's a trick you can use to see what HTML is going to be sent to Parsoid [17:36:23] Krinkle, moo|lunch: BTW, I've a request to enable TemplateDataGUI on enwiki, frwiki and itwiki – any objections? It's already live on cawiki and hewiki as well as mediawikiwiki. [17:36:41] eh [17:36:44] i just verified it [17:36:48] Open the save dialog (but don't actually save), then dump ve.init.target.docToSave in the console [17:36:55] converting a link node to link annotation doesn't preserve other annotations [17:36:59] Oh, right [17:37:05] even though there is some code there are aims to do this [17:37:07] Yeah node<->annotation conversion is probably broken [17:37:14] Oh, hah [17:37:19] Yeah I think I remember writing that code [17:37:20] James_F: Hm.. would have to check it out to do a few tests. Haven't verified in a while. I think if not already it can be ready enough in a day. [17:37:35] annotations = doc.data.getAnnotationsFromOffset( [17:37:35] this.linkNode.getOffset() [17:37:35] ).clone(); [17:37:37] MatmaRex: That sounds like a real bug though, because the link node/annotation could be in a bolded/italic sentence or something [17:37:41] Krinkle: These are people using the tool on other wikis and wanting it on theirs, so… [17:37:41] i guess this doesn't work? [17:37:49] yep [17:38:19] James_F: Yes, but that's a subset of users, not the users you don't hear about that broke syntax with pages, got reverted or blocked, or stopped editing,.. [17:38:46] Krinkle: Sure, but I've seen no Bugzilla reports or IRC complaints from cawiki or hewiki. [17:38:59] Krinkle: Which isn't a perfect metric, but it's a start. [17:39:06] not that this would be that extreme, but generally that story of user X liking it and wanting it elsewhere is a nice compliment but not too re-assurring. Differnet wikis, different templates, user base, language. It could be broken for all we know or conflict with some silly gadget. [17:39:12] Yeah, no worries. [17:39:16] * James_F is aware. :-) [17:40:43] James_F, guillom, vikassy - hallo [17:40:53] Hey aharoni. [17:41:06] there's something that I'd like to do, and it's pretty cool, but could also be pretty controversial [17:41:27] so vikassy is progressing very well with his multilingual screenshots project [17:42:15] on the way he found that in the VE User guide the current screenshot for Lists and indentation is definitely out of date [17:42:22] * James_F nods. [17:42:32] go to https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide , Ctrl-F for "Lists & indentation" [17:42:59] aharoni: Yeah, that changed a couple of weeks ago and wasn't updated yet. [17:43:06] so vikassy used his code to auto-create screenshots that are both current and internationalized [17:43:13] https://commons.wikimedia.org/wiki/File:VisualEditor_Toolbar_Lists_and_indentation-en.png [17:43:15] https://commons.wikimedia.org/wiki/File:VisualEditor_Toolbar_Lists_and_indentation-de.png [17:43:17] https://commons.wikimedia.org/wiki/File:VisualEditor_Toolbar_Lists_and_indentation-he.png [17:43:25] isn't that awesome? :) [17:43:31] Very cool, yes. :-) [17:43:36] now: [17:43:54] the question is how to make this fully automated from the translators' POV [17:44:22] Add the image with a tvar? [17:45:20] mmmm. [17:45:29] that needs the language name [17:45:45] {{{LANGUAGE}}} or whatever. [17:45:47] there is https://www.mediawiki.org/wiki/Template:CURRENTCONTENTLANGUAGE , which I just copied from Meta to mediawiki.org, and it seems to work [17:45:57] Yeah, that. [17:46:10] so I can do File:VisualEditor Toolbar Lists and indentation-{{CURRENTCONTENTLANGUAGE}}.png [17:46:25] and it will work for the languages in which there is a screenshot, but all other languages will show a broken image. [17:46:43] so that's the controversial part: [17:47:23] aharoni: Why are there languages for which we don't have screenshots, if this is all automated now? [17:47:36] it's not ALL automated [17:47:37] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create autonumbered external links and to convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309 (10Bartosz Dziewoński) [17:47:47] Oh OK [17:47:52] vikassy: what does it take to run your script with more languages? [17:48:10] So maybe we could use a template that has an #ifexist-based fallback to English or something? [17:48:14] do you need a labs wiki for each language, or can it use the English labs for all languages? [17:48:26] It won't work. [17:48:30] will this work if the file is hosted on commons? [17:48:38] Remember that you need local wiki configuration for each wiki. [17:48:42] (For the Cite menu.) [17:48:57] Cite is a separate issue [17:48:59] So you need to either use the actual production wiki to take the screenshots, or have a duplicate of each wiki. [17:49:04] we are handling each case of a screenshot separately. [17:49:17] Cite is the start, not the end, of wiki-variant toolbar controls, though. [17:49:24] there are several scenarios, and Cite is certainly a special scenario [17:49:29] * James_F nods. [17:49:37] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create autonumbered external links and to convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309 (10Bartosz Dziewoński) [17:49:37] RoanKattouw: i filed a bug about this for now. https://bugzilla.wikimedia.org/show_bug.cgi?id=67377 [17:49:39] 3VisualEditor / 3Data Model: Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node - 10https://bugzilla.wikimedia.org/67377 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Converting a MWNumberedExternalLinkNode to MWExt... [17:50:02] so again, will #ifexist work with files on commons? [17:50:32] aharoni: I don't know. Maybe [17:51:03] MatmaRex: Thanks, I'll take a look at that later [17:51:08] It's probably something I broke [17:51:41] ahh, looks like it may work if you do {{#ifexist: Media: [17:53:16] lol because of course [17:54:07] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create auto-numbered external links and to convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309 (10James Forrester) [17:55:38] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create auto-numbered external links and to convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309#c7 (10James Forrester) a:3Bartosz Dziewoński (In reply to Bartosz Dziewoński from comment #6) > (In reply to Jame... [17:56:22] 3VisualEditor / 3Data Model: VisualEditor: Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node - 10https://bugzilla.wikimedia.org/67377 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [17:56:53] 3VisualEditor / 3Data Model: VisualEditor: Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node - 10https://bugzilla.wikimedia.org/67377 (10James Forrester) a:3Roan Kattouw [17:59:01] vikassy: BTW, could we rename the screenshot tests to use that word? Right now we have “browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox” and “browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce” with no explanation that the first is taking screenshots and the second testing functionality. :-) [17:59:58] James_F, vikassy - I think I made it [18:00:15] works for English and Hebrew and doesn't break for French [18:00:43] (It shouldn't be that hard to get screenshot for French auto-created Really Soon) [18:00:56] Yeah. :-) [18:03:47] what vikassy , Zeljko and I are building is a Jenkins job that doesn't run automatically, but can be started by clicking a link [18:04:01] and the languages are there as parameters [18:04:26] so every time VE is translated to a language in translatewiki, this language can be added to the list, [18:04:44] then somebody will click the link, and this will create the screenshot and upload it to commons. [18:05:03] And the translators of the user guide shouldn't bother to do anything at all. [18:05:31] [ We'll have to document it very well. ] [18:06:13] Sounds like a very neat hack. :-) [18:22:21] ext.visualEditor.mwimage.core ? [18:22:30] Interesting, I wonder why that module it split [18:22:57] (helping Inez figure out a race condition in dependencies) [18:23:00] Krinkle: So that Mobile could have images display correctly without being not-alienated. [18:23:16] Krinkle: Git log is helpful. :-) [18:23:41] Code should not require git-log in order to make sense though [18:24:11] anyhow, this wasn't the race. It's somewhere else [18:24:59] Git log is helpful to answer the question of "who did this and why", rather than "what does this do". [18:32:51] Hm.. I think this race condition is a flaw in our code, one I foresaw [18:32:57] ve.dm.MWImageNode.prototype.getScalablePromise = function () { [18:32:58] this.scalablePromise = ve.init.target.constructor.static.apiRequest( [18:33:02] ve.init.target.constructor.static.apiRequest undefined [18:33:06] In the unit tests [18:33:30] since it races and targets are racing for each other in our testutils, target can be a non-MW target, which doesn't have apiRequest [18:33:32] edsanders: [18:33:43] Not sure how that code works exactly [18:34:02] it's breaking Wikia's unit tests sometimes [18:34:12] Krinkle: moo|lunch is the expert. [18:34:26] hm? who? wha? [18:34:46] It's not related to Scalable or ImageNode [18:34:59] Krinkle, oh, I semi fixed it in my image node tests [18:35:00] James_F: can you please email vikassy, Zeljko and me about that test job naming issue? [18:35:02] Ed wrote both ends of this (using static.apiRequest, and using standalone in MW unit testutils) [18:35:11] aharoni: Sure, or a bug? [18:35:29] a bug makes sense, but I'm not sure at which component [18:35:29] using ve.init global singleton apiRequest, that is, it used to ve.init.mw.Target.apiRequest [18:36:18] Krinkle, I cheated for my unit tests with this issue and did this: https://gerrit.wikimedia.org/r/#/c/141749/5/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js [18:36:55] moo|lunch: ve.init.target always exists, the bug is that sometimes it is a standalone target instead of mw target because we abuse sa.Target in mw unit tests. [18:37:03] and apiRequest is an MW method [18:37:10] [09:12] mvolz [2014-07-01 05:13:13] How do I get to the model inside the reference dialog? [18:37:12] James_F, aharoni I do not have permission to configure that job :( Zeljko had put it there [18:37:15] mvolz: I think you should be able to use this.referenceModel in most cases [18:37:45] Krinkle, I got errors that it didn't exist (in mw tests, actually) when I ran the tests, but I see what you mean [18:38:03] moo|lunch: That's very possible, too. But a separate (worse, nice find!) race condition. [18:38:09] vikassy: Oh, hmm. Maybe I do? [18:38:24] Nodes should never be parsed or dealt with when there isn't even a target available [18:38:49] Doesn't feel right to check that, that's a genuine exception that shouldn't be silenced in the final code. [18:39:55] vikassy: Apparently I can change it – does "browsertests-VisualEditor-screenshots-de" etc. work for you? [18:41:03] James_F: ah thank you :) yes and also "browsertests-VisualEditor-he.wikipedia.beta.wmflabs.org-linux-firefox" [18:41:30] James_F: yes that should do. Thank you :) [18:44:56] (03CR) 10Catrope: [C: 04-1] "Looks fine, but the SVGs should be cleaned up" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [18:58:36] (03PS2) 10Esanders: Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) [19:09:15] (03CR) 10Esanders: "Not sure we need to flip icons that don't have a meaningful direction." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [19:17:22] (03CR) 10Jforrester: "All these icons have a direction; I discarded those suggested icons which now don't have one." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [19:18:59] vikassy: All renamed; sorry for the delay! [19:23:08] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates the "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15804 --> https://bugzilla.wikimedia.org/at... [19:23:22] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384 (10ryasmeen) [19:28:11] (03PS2) 10Esanders: Prevent iOS Safari from following links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) [19:28:23] 3VisualEditor / 3Data Model: VisualEditor: Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node - 10https://bugzilla.wikimedia.org/67377#c1 (10Bartosz Dziewoński) a:5Roan Kattouw>3Bartosz Dziewoński This is because the node is remo... [19:29:54] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog wrongly uses suffix ellipsis until input is refocused - 10https://bugzilla.wikimedia.org/67385 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Steps: 1. Create page with VE 2. Insert New Template 3. Paste a piece of text that is the prefix o... [19:31:54] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog wrongly prefixes suggestions from User namespace with colon - 10https://bugzilla.wikimedia.org/67386 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Steps: 1. Create page with VE 2. Insert New Template 3. Enter text that is the prefix of one... [19:33:25] (03PS3) 10Catrope: Prevent iOS Safari from following links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [19:33:34] (03CR) 10Catrope: [C: 032] Prevent iOS Safari from following links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [19:33:59] (03PS1) 10Esanders: Use filter instead of find for finding UL.gallery [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 [19:36:00] (03Merged) 10jenkins-bot: Prevent iOS Safari from following links [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143152 (https://bugzilla.wikimedia.org/65326) (owner: 10Esanders) [19:36:31] (03PS2) 10Esanders: Fix jQuery selector to find ul.gallery in root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 [19:37:08] (03CR) 10Krinkle: "Can we undo this and instead just pass it to apiRequest where appropriate? This seems rather exaggerated and just too generic (and as ment" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [19:37:13] (03CR) 10Esanders: [C: 032] Fix jQuery selector to find ul.gallery in root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:37:20] (03CR) 10Esanders: [C: 04-2] Fix jQuery selector to find ul.gallery in root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:37:36] (03CR) 10Esanders: "oops, didn't mean to self +2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:37:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer to retain changes when switching to the "Edit Source" tab - 10https://bugzilla.wikimedia.org/57462#c9 (10ryasmeen) Verified the fix in Betalabs [19:42:09] (03CR) 10Krinkle: "Isn't this.$element the main CE element? For this node that is a div according to static.tagName, not an ul.gallery" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:45:19] (03CR) 10Catrope: "Minor comments on Moriel's changes inline on PS7" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [19:45:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) 5PATC>3RESO/FIX [19:45:30] (03CR) 10Catrope: [C: 04-1] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [19:47:27] (03CR) 10Catrope: "It's a GeneratedContentNode, so it can be anything. It used to be that GCNs were wrapped in a div, but they're not any more, so now the ro" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:47:32] (03PS1) 10Bartosz Dziewoński: MWLinkNodeInspector: Actually preserve annotations when converting to link annotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) [19:47:34] (03CR) 10Catrope: [C: 032] Fix jQuery selector to find ul.gallery in root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:49:22] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593#c4 (10Ed Sanders) (In reply to James Forrester from comment #3) > No; OOUI only understands RTL and LTR, not specific languages. The bold icon > isn't from OOUI but from VE itself... [19:49:27] (03Merged) 10jenkins-bot: Fix jQuery selector to find ul.gallery in root [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143382 (owner: 10Esanders) [19:49:28] RoanKattouw: https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&list_id=326070&namedcmd=VE-%21marked-for-next-release [19:50:16] (03CR) 10Esanders: "They're not symmetrical but they don't have a meaningful direction. You could argue that the book is 'backwards' but the others are fairly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [19:53:32] (03CR) 10Catrope: [C: 04-1] Hide context tools when the model they match isn't "inspectable" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) (owner: 10Esanders) [19:55:38] (03CR) 10Catrope: [C: 04-1] "Looks fine, but the RTL SVG needs to not be almost twice the size of the LTR SVG." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 (owner: 10Jforrester) [19:56:30] James_F: VE code is pretty pleasant to work with :D (unless you're working with ViewPageTarget :>) [19:58:18] (03CR) 10Jforrester: "Presumably you mean journal?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [19:58:18] alex@alex-desktop:/var/www/MediaWiki/Git/extensions/VisualEditor (b67345)$ git log --author=krenair --oneline modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js | wc -l [19:58:18] 33 [19:58:32] MatmaRex: Yeah, VPT is a pile of doom that poor Krenair has to deal with. [19:58:50] heh [19:59:20] Krenair: so you're the person to complain to about how incredibly messed up the toolbar is? :> [20:00:11] MatmaRex: Roan has 45, I've 19, Trevor has 18… [20:00:24] (ve.init.mw.ViewPageTarget.prototype.attachToolbarButtons creates a new ve.ui.TargetToolbar only to rip off its buttons and attach them elsewhere) [20:02:37] * Krenair points MatmaRex somewhere vaguely in the direction of San Francisco [20:03:04] Speaking of VPT, at some point I need to talk to Roan and Trevor about tidying that and MWSaveDialog up [20:03:05] Krenair: these yanks always creating problems, right? [20:03:24] :-P [20:03:33] (03PS1) 10Esanders: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143393 (https://bugzilla.wikimedia.org/67306) [20:04:16] edsanders: Gosh, now you're really just showing off. :-) [20:04:26] you like my topic [20:05:08] 3VisualEditor / 3Editing Tools: VisualEditor: Embedded context menu gets in the way of content when live-editing a tall extension node - 10https://bugzilla.wikimedia.org/67306 (10James Forrester) p:5Unprio>3High a:3Ed Sanders [20:12:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15806 -... [20:12:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10ryasmeen) [20:20:35] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [20:28:08] 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542#c4 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Ed Sanders Sorry for the slow triage here; between this and bug 67306 we thi... [20:28:37] 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542#c5 (10James Forrester) [Bah] (In reply to James Forrester from comment #4) > Sorry for the slow triage here; between this and bug 67306 we th... [20:28:53] (03PS2) 10Jforrester: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143393 (https://bugzilla.wikimedia.org/66542) (owner: 10Esanders) [20:34:20] (03PS1) 10Jforrester: Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 [20:35:07] 3VisualEditor / 3Language: VisualEditor: Some icons need to be flipped for RTL languages - 10https://bugzilla.wikimedia.org/63593#c5 (10James Forrester) (In reply to Ed Sanders from comment #4) > (In reply to James Forrester from comment #3) > > No; OOUI only understands RTL and LTR, not specific languages.... [20:38:11] (03PS1) 10Jforrester: Update VE core submodule to master (57f01e9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143428 [20:38:57] (03PS2) 10Jforrester: Update VE core submodule to master (57f01e9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143237 [20:39:03] (03Abandoned) 10Jforrester: Update VE core submodule to master (57f01e9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143428 (owner: 10Jforrester) [20:48:52] (03CR) 10Catrope: [C: 032] Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143393 (https://bugzilla.wikimedia.org/66542) (owner: 10Esanders) [20:49:24] * RoanKattouw_away cracks up at Ed's branch name [20:50:13] (03Merged) 10jenkins-bot: Never embed the context when an inspector is present [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143393 (https://bugzilla.wikimedia.org/66542) (owner: 10Esanders) [20:53:43] James_F, TrevorParscal I have a suggestion, as someone whose computer is a p** of *** and is very slow: When clicking on a context icon for a dialog, in my computer it sometimes takes quite a while for the dialog to open (several seconds) -- can we put some indication that the dialog is building/opening? I don't know how common slow computers are in this case though. [20:54:10] mooeypoo: Wow. It really shouldn't take anything like that long. [20:54:25] My computer is special. [20:56:19] James_F, I just checked a couple of times. It takes around 2-3 seconds for the dialog to open in my machine. [20:56:32] (Sometimes longer, but that's usually when I have stuff running in the background) [20:56:33] Wow. That's … bad. [20:56:43] Also, do I need to go ping OIT for you? [20:57:48] They said the computer they ordered didn't pan out or something.. so I believe they're supposed to install a basic laptop for me. I haven't heard back since last week? [20:58:48] Hmm. [20:59:04] * James_F was just thinking that it'd be sensible to combine t-shirts and laptop into one package. [21:03:08] 3VisualEditor / 3ContentEditable: VisualEditor: Typing multiple deadkeys at the end of text expands selection to new line - 10https://bugzilla.wikimedia.org/66592#c2 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Ed Sanders Confirmed; the re-select happens on master. When the cursor is at th... [21:05:01] James_F, ooh, a tshirt laptop! [21:05:22] or a lapthirt. Okay, I'll stop while I'm ahead. [21:05:47] Lapthirts for all! [21:06:48] (03PS3) 10Catrope: Update VE core submodule to master (125632e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143237 (owner: 10Jforrester) [21:07:36] 3VisualEditor / 3Editing Tools: VisualEditor: Inspector of FocusNodes with embedded menu should not be embedded in some cases - 10https://bugzilla.wikimedia.org/66542 (10James Forrester) 5PATC>3RESO/FIX [21:08:36] 3VisualEditor / 3Editing Tools: VisualEditor: Embedded context menu gets in the way of content when live-editing a tall extension node - 10https://bugzilla.wikimedia.org/67306#c4 (10James Forrester) 5PATC>3RESO/FIX The original request was about optional disabling embedding, but this I suppose "fixes" th... [21:08:47] (03CR) 10Alex Monk: "Hmm... I kind of disagree. Kind of." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138407 (https://bugzilla.wikimedia.org/65455) (owner: 10Alex Monk) [21:11:24] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (125632e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143237 (owner: 10Jforrester) [21:12:08] (03CR) 10Catrope: [C: 032] Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 (owner: 10Jforrester) [21:12:30] RoanKattouw: What happened to waiting for Trevor? :-) [21:12:34] Meh [21:12:45] The change seemed fine anyway [21:13:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (125632e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143237 (owner: 10Jforrester) [21:13:13] * James_F grins. [21:13:15] Sure. [21:13:50] (03Merged) 10jenkins-bot: Get rid of ve.init.mw.ViewPageTarget-vector-hd.css and use a media query instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142825 (owner: 10Jforrester) [21:15:04] (03PS3) 10Catrope: Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) (owner: 10Esanders) [21:15:08] (03PS15) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) [21:15:40] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 1... [21:16:01] (03CR) 10jenkins-bot: [V: 04-1] Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [21:16:17] ... I grunted, jenkins.. what are you complaining about [21:16:23] (03CR) 10Catrope: [C: 032] Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) (owner: 10Esanders) [21:17:15] (03CR) 10Catrope: [C: 032] Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (https://bugzilla.wikimedia.org/50341) (owner: 10Alex Monk) [21:17:58] (03Merged) 10jenkins-bot: Hide context tools when the model they match isn't "inspectable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143352 (https://bugzilla.wikimedia.org/67176) (owner: 10Esanders) [21:18:55] (03Merged) 10jenkins-bot: Update displaytitle on save (try #3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141098 (https://bugzilla.wikimedia.org/50341) (owner: 10Alex Monk) [21:22:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389 (10ryasmeen) [21:22:08] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10ryasmeen) [21:24:02] (03PS16) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) [21:26:32] RoanKattouw, hey. How long does it take for a change to get pushed to the deployment-prep apaches? [21:26:46] For extension changes I think it's ~6 mins? [21:28:08] Hmm [21:28:09] I don't think so [21:30:16] (03PS8) 10Catrope: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:30:18] (03CR) 10jenkins-bot: [V: 04-1] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:31:52] 3VisualEditor / 3MediaWiki integration: The handler MWCategoryWidget::onLookupInputKeyDown is not actually bound to anything. - 10https://bugzilla.wikimedia.org/56700 (10James Forrester) a:3Alex Monk [21:32:54] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15808 --> https://bugzilla.wi... [21:33:07] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10ryasmeen) [21:33:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10ryasmeen) [21:33:09] (03PS9) 10Catrope: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:38:14] jgonera: How do I trigger mobile VE on desktop again? [21:38:24] I tried ?mobileaction=alpha but then I don't see any edit links [21:38:59] ?veaction=edit also doesn't work [21:39:27] RoanKattouw: You need to set the cookie. [21:39:35] RoanKattouw: It gets eaten every browser session or something odd. [21:40:56] The normal beta thing in settings doesn't stick on my localhost [21:41:10] And I can get into the alpha view but it has no VE links [21:41:11] RoanKattouw: No, you need to go to beta, then to alpha. [21:41:17] No VE links? [21:41:23] James_F: Enabling beta does not stick on my box [21:41:29] RoanKattouw: ** anyone's box. [21:41:38] I showed MaxSem before and rather than telling me how to stick it, he gave me a query string [21:41:47] James_F: No, I mean, does not stick even for a single request [21:41:51] So you cannot get to enabling alpha [21:42:13] RoanKattouw: … lovely. [21:42:26] RoanKattouw: I manage to get it to stick for a few minutes, enough to test. [21:42:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341#c13 (10Alex Monk) 5PATC>3RESO/FIX So this appears to actually be working now. [21:44:18] (03CR) 10Catrope: "The -200% trick doesn't seem to work very well in the standalone mobile demo viewed in Chrome on desktop. The context simply moves to righ" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:44:21] 3VisualEditor / 3Data Model: VisualEditor: When indenting a list as a block, instead of putting it inside its own type, use

s - 10https://bugzilla.wikimedia.org/55797 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [21:44:36] 3VisualEditor / 3Editing Tools: VisualEditor: Indent buttons should be used for in-/out-denting paragraphs as well as lists. - 10https://bugzilla.wikimedia.org/48010 (10James Forrester) [21:52:34] (03CR) 10Catrope: [C: 032] Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:52:59] RoanKattouw: Wait, now it works OK? [21:53:35] ryasmeen: Once that ---^ lands in beta labs, let me know if it actually works properly. In my testing in standalone it didn't position the context very well, but I couldn't test in MW [21:53:52] James_F|Away: Well no, but I can't test MW and the mobile people are in a meeting, so I'm making it their problem [21:53:58] (03Merged) 10jenkins-bot: Reenable mobile context and style it properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [21:54:05] Under the assumption they probably /kind of/ tested it [21:55:18] (03PS1) 10Catrope: Update VE core submodule to master (9ed40c3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143493 [21:55:23] James_F|Away: ---^^ [21:57:55] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (9ed40c3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143493 (owner: 10Catrope) [21:59:27] Thanks [21:59:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (9ed40c3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143493 (owner: 10Catrope) [21:59:44] James_F|Away, something odd is going on in https://bugzilla.wikimedia.org/show_bug.cgi?id=56700... [22:00:41] It will happily call keydown handlers I set with .get( 0 ).onkeydown = function () { } etc. [22:01:13] But not through jQuery's .on or .keydown, it seems.... [22:02:33] jgonera: Also you may want to figure out a way not to set a max-width on context items in mobile [22:02:48] Right now that code is in ContextItemWidget itself which is probably evil [22:03:38] 3VisualEditor / 3ContentEditable: Cannot delete a list style, if present at the start of the page by pressing the “Backspace” key. - 10https://bugzilla.wikimedia.org/67392 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Setup- none. Steps to Reproduce- 1> In the VE, add a bullet/Numbered list at the... [22:03:40] (03CR) 10Catrope: [C: 032] Add tabindex=0 and role=button to tool links [oojs/ui] - 10https://gerrit.wikimedia.org/r/143155 (https://bugzilla.wikimedia.org/62337) (owner: 10Alex Monk) [22:04:06] 3VisualEditor / 3ContentEditable: Cannot delete a list style, if present at the start of the page by pressing the “Backspace” key. - 10https://bugzilla.wikimedia.org/67392 (10Ritu Swain) [22:04:18] (03Merged) 10jenkins-bot: Add tabindex=0 and role=button to tool links [oojs/ui] - 10https://gerrit.wikimedia.org/r/143155 (https://bugzilla.wikimedia.org/62337) (owner: 10Alex Monk) [22:06:27] ok, i'm pretty pissed at tower right now [22:06:41] somehow it crashed and now my git repo is somehow broken [22:06:47] not good [22:06:57] this is only in ve core, not ooui [22:07:12] but still, I need to recover my context rewrite [22:08:56] Damn [22:09:19] TrevorParscal: So what were you trying to do when it crashed? [22:09:35] apply a stash [22:09:40] OK [22:09:46] Let's see what we can rescue [22:09:54] TrevorParscal: Can you call me on hangouts and share your screen? [22:10:32] (03CR) 10Catrope: [C: 032] "I love the fact that the LTR/RTL toggle widget gets flipped itself :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/142879 (owner: 10Esanders) [22:10:39] yeah, one sec [22:10:39] Alright guys, out with the pun. Who's trolling ? https://en.wikipedia.org/wiki/Timolol [22:10:59] There's no I in Timolol / at least not where you think [22:11:07] (03Merged) 10jenkins-bot: Generate RTL stylesheets with CSSJanus [oojs/ui] - 10https://gerrit.wikimedia.org/r/142879 (owner: 10Esanders) [22:11:56] TrevorParscal: Did you just invite me then leave? [22:12:05] you didn't join, it gave up on you [22:12:11] Oh sorry [22:12:16] I didn't notice in time [22:12:35] My sound is muted because I'm watching The Football [22:14:01] Krinkle: Should we say "Timo may give you a heart attack, but we have Timolol to counteract that"? :-) [22:14:54] (03CR) 10Krinkle: Generate RTL stylesheets with CSSJanus (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/142879 (owner: 10Esanders) [22:15:41] RoanKattouw: We had an RL bug in production for attr disabled, remember? [22:16:57] Krinkle: No? [22:17:31] But you know in general that state is maintained in properties, attributes only affect initial state of properties during parsing. After that they affect only the DOM attributes themselves, not the live rendering. [22:17:50] (except for some attribtues that are two-way synced, but generally not for dynamic field values and toggling) [22:21:53] Krinkle: Do you think https://github.com/gruntjs/grunt-contrib-imagemin might be useful for dist building? [22:26:27] RoanKattouw, were you talking about any particular patch? [22:26:53] jgonera: Yes. [22:27:10] jgonera: He was talking about https://gerrit.wikimedia.org/r/#/c/141085/ but it seems he got it working as he's now merged it. :-) [22:28:13] hm, interesting RoanKattouw_away and James_F|Away, I thought this was a huge conflicting change with what TrevorParscal was working on right now... [22:28:34] jgonera: It is, but we decided it was better to get it done now so you could move on and we'd take the hit. :-) [22:28:47] oh, OK, sounds good then [22:28:50] thank you [22:30:57] jgonera: Happy to help. :-) [22:31:56] RoanKattouw_away, I'm still not sure what max-width was about so when you're around, let me know and I'll try to avoid it [22:42:41] edsanders: How attached are you to the various bits of the SVGs. [22:42:52] ? [22:43:11] edsanders: Specifically, which flags should I pass to SVGo to retain things when I'm using it to crush the, [22:43:12] ? [22:43:26] I do it by hand [22:43:39] Most of the existing files in OOUI have ~50% of the bytes removed. [22:43:50] ah [22:43:51] um [22:43:57] James_F|Away: https://www.mediawiki.org/wiki/Manual:Assets [22:44:00] But I don't want to make bad changes. [22:44:09] not particularly, ask Trevor. I think the IDs were deliberate [22:44:18] OK. [22:44:28] MatmaRex: Yeah, I worked out retaining the prolog. :-) [22:44:53] plus with the talk of colour variables we may want to keep them readable [22:46:57] I'm using --pretty to retain formatting for human-readability. [22:50:35] (03PS1) 10Jforrester: Run svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [22:50:37] edsanders: ^^^ opinions welcome. [22:51:02] edsanders: (Also, we should convert them to say "UTF-8".) [22:55:15] MatmaRex: BTW, svgo has an option to retain XML prologs. [22:57:22] James_F|Away: i know, but when i was working with the files in core, every single one had a different prolog and svgo has no option to canonicalize them. [22:57:37] MatmaRex: My sympathies. :-( [22:59:28] jgonera: Well so it didn't work very well for me but you guys weren't around so I just merged it [22:59:31] jgonera: Specifically, loading the mobile standalone demo in desktop, I see the context moving up above the toolbar when dismissed, but not off the screen [22:59:56] But since I don't know how to do the URL manipulation to get MobileFrontend VE to load and the apps people didn't know either, I couldn't test it in the MW integration [22:59:56] RoanKattouw, yeah, but I don't see max-width anywhere in that patch ;) [23:00:00] Oh, sorry [23:00:04] What I meant is this rule: [23:00:14] .ve-ui-contextItemWidget .oo-ui-labeledElement-label { [23:00:21] [various things including max-width] [23:00:25] In ve.ui.ContextItemWidget.css [23:00:26] I see [23:00:38] Ideally that probably wouldn't be in that file to begin with, if it needs to be themed for mobile [23:00:43] Just saying, you may want to theme it at some point [23:00:46] in mobilefrontend it should be enough to apply ?mobileaction=beta [23:01:03] then by default it will probably open wikitext editor, but you have a cog in the toolbar that allows you to switch [23:01:07] Ooooh [23:01:13] I gave up once I got to the wikitext editor [23:01:40] RoanKattouw, depends if VE is set to opt-in or opt-out in your dev instance [23:02:08] RoanKattouw: I am giving a pass on the new context menus on Mobile, thing is it lets me get into all those broken dialogs for reference list, Latex etc [23:02:57] Ouch [23:02:58] I think we need to get TrevorParscal's windows refactor code merged as soon as possible to resolve this [23:03:09] I don't think that fixes it though [23:03:13] TrevorParscal: Does it? ----^^ [23:03:32] Instead I think we need to load less code on mobile [23:03:40] I see [23:04:33] OK now I just don't see edit links at all in MF, weird [23:12:10] So Roankattouw: The dialogs for which context menu should be disabled for now are: Formula,Template and Reference List [23:22:52] James_F, do you have the oojsui pull through script, and will it pick up the new css files (.rtl.css)? [23:23:54] Re:svgo [23:23:57] looking at https://gerrit.wikimedia.org/r/#/c/143502/1/src/styles/images/icons/accept.svg [23:24:25] I don't like it collapsing the into the [23:24:37] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390#c1 (10ryasmeen) This is also happening for the context menu bar in Mobile VE.When you put your cursor fo... [23:26:46] specifically the opacity should be apply to the union of all the shapes, not to the shapes directly [23:28:47] so disable "collapseGroups" [23:30:26] (03CR) 10Catrope: "So it looks like you're moving it the context to right above the toolbar. This works in the MW integration because the toolbar is at the t" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141085 (owner: 10JGonera) [23:31:33] edsanders: I do, it will, I can fix it. [23:31:40] edsanders: OK, will do. [23:32:08] other than that the SVGs look good [23:33:31] * James_F nods. [23:34:03] (03PS2) 10Jforrester: Run svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:34:39] edsanders: --disable=collapseGroups didn't do anything. [23:36:15] (03PS3) 10Jforrester: Run svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:36:43] edsanders: … because I'm an idiot and used the old version of the file. Better now? [23:38:26] (03CR) 10Krinkle: "Just curious, but which svgo? I don't suppose it was node-svgo https://github.com/svg/svgo?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 (owner: 10Jforrester) [23:40:15] James_F, that fixed some of them [23:40:20] but accept.svg is still broken [23:40:28] did you revert everything? [23:41:37] Yeah. [23:42:14] What's broken about it? [23:42:30] id is preserved. [23:44:26] edsanders: Oh, the singleton-group getting merged in? [23:44:34] yeah [23:44:40] collapseGroups [23:45:16] It's set to false. [23:46:40] Hmmmmm. [23:46:47] If I re-run it it doesn't collapse it. [23:46:49] * James_F grumbles. [23:47:25] (03PS4) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:47:44] edsanders: https://gerrit.wikimedia.org/r/#/c/143502/4/src/styles/images/icons/accept.svg better? [23:47:54] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the link suggestions are appearing on CE when you open link inspector - 10https://bugzilla.wikimedia.org/67399 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15811 --> https://bugzilla.wikimedia.org/attachment.cgi?id=1581... [23:47:57] yes [23:48:22] (03CR) 10Jforrester: "@Krinkle: Yes; npm install -g svgo FTW." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 (owner: 10Jforrester) [23:48:46] edsanders: OK, do I have your blessing to do the same for all our other repos' SVGs? [23:48:48] did you mean to merge in the change to ButtonedElement.js [23:48:56] Eurgh. [23:48:57] No. [23:49:01] didn't think so [23:49:01] * James_F sighs. [23:49:05] (03PS5) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:49:35] try again... [23:50:00] (03PS6) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:50:04] PS5 was just the initial rebase. [23:50:12] you could run in /indicators as well [23:50:12] Better now? [23:50:22] Meh. I did. [23:51:08] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399 (10ryasmeen) [23:51:10] But -f doesn't take anything other than the first result of wildcard expansion. [23:51:11] * James_F grumbles. [23:51:16] Fixed. [23:51:17] (03PS7) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:51:19] (03CR) 10jenkins-bot: [V: 04-1] Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 (owner: 10Jforrester) [23:51:37] (03PS8) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 [23:51:45] (03PS1) 10Catrope: Split mwtransclusion and mwreference into core and non-core modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143518 [23:53:07] (03CR) 10Esanders: [C: 032] Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 (owner: 10Jforrester) [23:53:44] (03Merged) 10jenkins-bot: Run node-svgo to crush all SVGs whilst retaining readibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/143502 (owner: 10Jforrester) [23:54:07] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10ryasmeen) [23:54:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399 (10ryasmeen) [23:56:38] (03PS1) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143520 [23:58:35] (03PS1) 10Jforrester: Run node-svgo to crush all SVGs whilst retaining readibility [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143521