[00:01:29] (03PS2) 10Jforrester: Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 [00:02:01] (03PS3) 10Jforrester: Make help icon have an RTL variant [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 [00:02:24] (03CR) 10Jforrester: "PS2 is a rebase; PS3 crushes the SVG using svgo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143407 (owner: 10Jforrester) [00:03:52] (03PS2) 10Jforrester: Provide RTL variants of eight icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 [00:05:42] (03PS11) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [00:06:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:06:05] (03PS2) 10Jforrester: Provide the (currently-unused) external link icon in LTR and RTL variants [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 [00:06:47] (03PS3) 10Jforrester: Provide the (currently-unused) external link icon in LTR and RTL variants [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 [00:07:04] (03CR) 10Jforrester: "PS2 is a rebase; PS3 crushes the RTL SVG icon." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 (owner: 10Jforrester) [00:07:58] (03PS2) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (c6ceece274) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [00:08:16] (03PS2) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [00:09:22] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (c6ceece274) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [00:09:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [00:11:57] TrevorParscal: Hey so I ran into this issue with mobile, and I was wondering if you had thought of how it affects your new code [00:12:00] James pointed out that it might [00:12:18] So in the mobile link inspector, I'm submitting a change to make it use a different overlay [00:12:25] Otherwise the suggestions menu is hidden [00:12:33] Presumably this also affects your auto-fullscreening inspectors? [00:14:00] (03PS1) 10Catrope: Use globalOverlay as the contextOverlay in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143524 [00:16:32] Are they actually rendering the suggestions in an overlay? [00:17:26] Well [00:17:33] Just look at that patchset I just submitted 2 minutes ago [00:17:51] I think the core of the issue is this: [00:17:57] We really need to do this properly, as I mentioned in the meeting, such that focusing on a lookup input widget either opens an overlay (desktop) or a search window (like the language one ed made only fullscreen) (on mobile) [00:18:22] In desktop, the context is inside of the surface, while the localOverlay is after the surface, so the localOverlay is on top of the context, so the suggestions are on top of the inspector [00:19:00] (03CR) 10JGonera: [C: 032] "Thanks." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143524 (owner: 10Catrope) [00:19:22] In mobile, the context's windowSet is in the globalOverlay, so that's on top of the localOverlay, and the inspector is full-screen, so the inspector is on top of the suggestions [00:19:44] (03PS2) 10Catrope: Use globalOverlay as the contextOverlay in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143524 (https://bugzilla.wikimedia.org/67399) [00:19:59] yeah, that's a hack [00:20:02] it shouldn't be done that way [00:20:11] So I moved the context's windowSet to the globalOverlay [00:20:17] I guess in general it maybe needs to be done differently [00:20:19] I get that they are just doing whatever they can to make it work, but the problem is deeper than which overlay [00:20:23] RoanKattouw: lets go over it tomorrow, i need exercise and am going to go on a walk with my kids while it's still nice [00:20:32] (03CR) 10Catrope: [C: 032] "Re-+2ing per Juliusz; now with bug tags" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143524 (https://bugzilla.wikimedia.org/67399) (owner: 10Catrope) [00:20:34] OK cool [00:20:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw [00:20:39] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [00:20:40] have a good night [00:20:44] You too [00:21:57] (I was the one that fixed that actually, but I also didn't really know what I was doing) [00:22:12] (03Merged) 10jenkins-bot: Use globalOverlay as the contextOverlay in MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143524 (https://bugzilla.wikimedia.org/67399) (owner: 10Catrope) [00:29:08] mooeypoo: What's up with the ve-ui-MWMediaDialog-panel-search and -settings classes? They don't appear to be used at all [00:29:15] I fixed a capitalization typo for the altText class [00:30:58] (03PS17) 10Catrope: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [00:31:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c12 (10ryasmeen) Verified the fix in Betalabs [00:56:31] RoanKattouw, I wanted to have something distinguishing each panel in case we need to -- I at first thought to use it for something, then eventually didn't. They can stay or go. [01:01:08] OK [01:01:13] It's fine if they stay [01:01:30] I'll test this change and then I'll merge it [01:04:15] James_F: https://gerrit.wikimedia.org/r/#/c/143518/ [01:04:23] (03CR) 10Jforrester: [C: 032] Split mwtransclusion and mwreference into core and non-core modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143518 (owner: 10Catrope) [01:06:07] (03Merged) 10jenkins-bot: Split mwtransclusion and mwreference into core and non-core modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143518 (owner: 10Catrope) [02:16:49] (03PS5) 10Jforrester: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) [02:18:09] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/143520/ https://gerrit.wikimedia.org/r/#/c/143240/ https://gerrit.wikimedia.org/r/#/c/143521/ https://gerrit.wikimedia.org/r/#/c/143241/ [02:21:40] (03CR) 10Catrope: [C: 032] Provide RTL variants of eight icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [02:23:54] (03CR) 10Catrope: [C: 032] Run node-svgo to crush all SVGs whilst retaining readibility [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143521 (owner: 10Jforrester) [02:24:32] (03CR) 10Catrope: [C: 032] Provide the (currently-unused) external link icon in LTR and RTL variants [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 (owner: 10Jforrester) [02:26:50] (03Merged) 10jenkins-bot: Run node-svgo to crush all SVGs whilst retaining readibility [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143521 (owner: 10Jforrester) [02:26:59] (03Merged) 10jenkins-bot: Provide RTL variants of eight icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143241 (owner: 10Jforrester) [02:27:18] (03CR) 10Catrope: [C: 032] Run node-svgo to crush all SVGs whilst retaining readibility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143520 (owner: 10Jforrester) [02:29:00] (03Merged) 10jenkins-bot: Run node-svgo to crush all SVGs whilst retaining readibility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143520 (owner: 10Jforrester) [02:29:02] (03Merged) 10jenkins-bot: Provide the (currently-unused) external link icon in LTR and RTL variants [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143240 (owner: 10Jforrester) [02:30:01] (03CR) 10Catrope: [C: 04-1] "Haven't looked at the code too closely, but -1ing for lack of unit tests" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [02:31:19] (03CR) 10Catrope: "Ed, what do you think about this approach?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [02:51:29] (03CR) 10Catrope: [C: 032] "Merging since this is good from a code perspective and should land this week. But there are some product issues that James identified:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [02:53:07] (03Merged) 10jenkins-bot: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (https://bugzilla.wikimedia.org/67170) (owner: 10Mooeypoo) [02:55:28] woooo [02:55:46] mooeypoo: Do look at the laundry list of product comments I transcribed from James in my +2 comment ;) [02:56:14] half-woooo [03:05:10] (03CR) 10Catrope: [C: 032] "Ideally intro.js.txt would be renamed to intro.js (or deduplicated from intro.css into intro.txt or whatever)" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [03:06:46] (03Merged) 10jenkins-bot: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [03:06:52] (03CR) 10Catrope: [C: 04-1] Use CSSJanus to generate RTL stylesheets (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [05:29:39] (03CR) 10Amire80: "Such changes should also include an explanation in qqq for the new meaning of the message. I added it in translatewiki, but please check t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143227 (owner: 10Jforrester) [07:43:52] (03PS12) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [07:44:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [07:44:58] (03PS3) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (337160468f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [07:45:40] (03PS3) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [07:46:57] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (337160468f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [07:47:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [14:48:23] (03CR) 10Esanders: "If we're going to support font size I guess we'd need something like this, however I would support it differently, perhaps as a "textSize"" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [14:52:41] (03CR) 10Bartosz Dziewoński: "Let me just point out that this is analogous to existing subscript/superscript annotations, and that there have already been problems with" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [14:56:51] 3VisualEditor / 3Editing Tools: VisualEditor: When text is being made superscripted and is already subscripted, clear the latter (and vice versa) - 10https://bugzilla.wikimedia.org/53330#c18 (10Bartosz Dziewoński) I can't reproduce. Steps? [15:23:52] (03PS1) 10Bartosz Dziewoński: In the toolbar, display superscript tool above subscript tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143617 [15:24:40] someone please tell me there's a better way to do this ^ [15:57:42] (03PS1) 10Esanders: Update OOjs UI to v0.1.0-pre (432a76f7d4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143626 [16:00:17] (03PS12) 10Esanders: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) [16:10:15] (03PS13) 10Esanders: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) [16:16:33] (03PS1) 10Esanders: Don't transplant disabled stylesheets [oojs/ui] - 10https://gerrit.wikimedia.org/r/143629 [16:16:47] (03CR) 10Jforrester: [C: 032] "This is the only real way. Wait 'til this gets split out of being an omnibus file, though…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143617 (owner: 10Bartosz Dziewoński) [16:17:31] edsanders: Did you do an MW-core OOUI update or should I? [16:18:18] (03Merged) 10jenkins-bot: In the toolbar, display superscript tool above subscript tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143617 (owner: 10Bartosz Dziewoński) [16:24:44] James_F: ;_; [16:26:49] MatmaRex: Indeed. [16:27:12] edsanders: https://gerrit.wikimedia.org/r/143632 is the update to the OOjs UI pull-through script for MW-core. [16:27:42] edsanders: If you could +2 https://gerrit.wikimedia.org/r/143631 I'd be grateful (and will do the same for https://gerrit.wikimedia.org/r/143626 of course). [16:43:18] TrevorParscal, I found the problem I had with the OO.ui.Toolbar, it is either an indication of a bigger issue with "complex" button tools (that aren't clickable-buttons) or an issue with me trying to manipulate the code wrong. [16:43:37] yeah? [16:44:42] well, I suspect both cases have been overlooked, and "wrong" really means "to do what I want in a way that makes sense" so, either way we are in for some changes before the API's UX is under control [16:45:28] TrevorParscal, you were right, it's an event that's returning "false" ,but it's in the Toolbar itself [16:45:35] so I can't really override it with specific buttons :\ [16:46:24] TrevorParscal, specifically, OO.ui.Toolbar.prototype.onMouseDown [16:46:54] You can see the weirdness if you try to play with the in here: http://moriel.smarterthanthat.com/apps/SolarPlayground/ [16:47:27] I think it's an issue with a button not being "clickable" in the normal sense [16:52:09] (03CR) 10Jforrester: "> If we're going to support font size I guess we'd need something like this, however I would support it differently, perhaps as a "textSiz" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [17:04:52] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c10 (10Alex Monk) (In reply to Derk-Jan Hartman from comment #4) > they need labels to describe them (aria-label[ledby]). Hey. Could you explain this a bit more please? [17:06:18] (03PS6) 10Mooeypoo: [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [17:07:49] I noticed GitHub recently revamped their diff tool for changes to Markdown documents: http://i.imgur.com/1cxIGp9.png [17:07:49] Granted, they're much easier off since there are no nested block level elements. [17:08:14] (03CR) 10jenkins-bot: [V: 04-1] [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [17:24:03] Krinkle: Indeed. [17:24:51] RoanKattouw: https://gerrit.wikimedia.org/r/#/q/Ieb775472b05acf42aada190a49f9f768ddcd5084,n,z pls. :-) [17:26:10] James_F: Since I know you appreciate being shocked by horrible code, here's what I did last weekend: https://github.com/Krinkle/ts-krinkle-misc/commit/544efff4fef69 - open sourced [17:26:27] That repo in general is all I did pre-2012 [17:26:41] this is the last bit, but written in 2014 to reroute it all [17:27:07] A nice memoir of all those forgotten tools: https://github.com/Krinkle/ts-krinkle-misc#readme :D [17:27:25] * Krinkle sheds a tear [17:28:44] Krinkle: :-) [17:28:46] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (432a76f7d4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143626 (owner: 10Esanders) [17:30:01] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (432a76f7d4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143626 (owner: 10Esanders) [17:30:02] RoanKattouw: Oh, and https://gerrit.wikimedia.org/r/143632 to fix MW-core's update script. [17:30:09] (03CR) 10Catrope: [C: 032] Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [17:30:51] 3VisualEditor / 3ContentEditable: VisualEditor: Double-click should not open items that shouldn't be opened - 10https://bugzilla.wikimedia.org/67176 (10James Forrester) 5PATC>3RESO/FIX [17:31:36] 3VisualEditor / 3Language: VisualEditor: Standalone doesn't have an RTL stylesheet - 10https://bugzilla.wikimedia.org/65057 (10James Forrester) 5PATC>3RESO/FIX [17:31:45] (03Merged) 10jenkins-bot: Use CSSJanus to generate RTL stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/134802 (https://bugzilla.wikimedia.org/65057) (owner: 10Esanders) [17:35:17] RoanKattouw: Ha, yeah. [17:38:36] (03PS1) 10Jforrester: Update VE core submodule to master (2a2ebe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143643 [17:40:24] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (2a2ebe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143643 (owner: 10Jforrester) [17:41:04] Krinkle: ^^^ Yay. :-) [17:41:08] 3VisualEditor / 3Editing Tools: VisualEditor: TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None When we try to add this template: http://en.wikipedia.org/wiki/User:Jay8g/sa... [17:41:34] Krinkle: (That was C-1'ed because I forgot to do the grunt update. Lovely to have it blocked rather than have to fix it later.) [17:41:48] (03PS2) 10Jforrester: Update VE core submodule to master (2a2ebe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143643 [17:42:36] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10James Forrester) 5PATC>3ASSI [17:42:51] 3VisualEditor / 3Editing Tools: VisualEditor: TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424#c1 (10Alex Monk) (In reply to WhatamIdoing from comment #0) > We have already made at least three null edits to the template. I assume... [17:49:27] Krinkle: Sweet! [17:50:11] :) [17:55:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399#c3 (10ryasmeen) 5RESO/FIX>3REOP This is still happening on Betalabs. [17:56:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c6 (10ryasmeen) 5RESO/FIX>3REOP Still happening on Betalabs [18:05:50] (03PS9) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [18:07:01] RoanKattouw: you might know: in the Media inspector, after search, when you have selectable thumbs displayed, what event does VE listen for to actually complete the selection of a media file? click() is not doing it for me automation-wise. [18:08:41] Let me look that up [18:09:21] thanks RoanKattouw I've been firing js events on it too, but it's not being registered properly as a result [18:09:53] It appears to be mousedown followed by mouseup [18:11:13] thanks RoanKattouw [18:14:53] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter data doesn't always end up in the right parameter box in Firefox - 10https://bugzilla.wikimedia.org/67427 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Report from Jay8g about a bug that may be very hard to reproduce: "After adding a param... [18:15:06] 3VisualEditor / 3Editing Tools: VisualEditor: Parameter data doesn't always end up in the right parameter box in Firefox - 10https://bugzilla.wikimedia.org/67427 (10WhatamIdoing) 5NEW>3UNCO [18:16:45] (03PS10) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [18:16:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2a2ebe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143643 (owner: 10Jforrester) [18:17:12] RoanKattouw, I went a slightly different route on this, allowing for the alignments in an array. ^^ [18:20:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (2a2ebe9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143643 (owner: 10Jforrester) [18:24:09] (03CR) 10Catrope: [C: 032] Don't transplant disabled stylesheets [oojs/ui] - 10https://gerrit.wikimedia.org/r/143629 (owner: 10Esanders) [18:27:39] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15814 --> https://bugzilla.wikimedia.org/attachment.cgi?id=158... [18:29:50] (03Merged) 10jenkins-bot: Don't transplant disabled stylesheets [oojs/ui] - 10https://gerrit.wikimedia.org/r/143629 (owner: 10Esanders) [18:32:22] (03PS1) 10Cmcmahon: Merge "Merge Media Edit and Media Insert dialogs" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143662 [18:34:11] (03CR) 10Catrope: [C: 04-2] "Clean up your git checkout, Chris ;)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143662 (owner: 10Cmcmahon) [18:35:07] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429#c1 (10ryasmeen) This is also happening for Basic reference, cite news , cite journal and reference list dialog as well. [18:36:12] RoanKattouw: I have no idea what git just did, but I'll fix it :-) [18:42:12] this.input.$input[0].onkeydown = function () { console.log( 'onkeydown with index instead of jQuery.get' ); }; [18:42:20] this.input.$input.on( 'keydown', function () { console.log( 'jQuery.on keydown' ); } ); [18:42:34] These should both get called when you press a button in that input, right Krinkle? [18:43:22] Krenair: Why is that code not using this.input.on( 'change', ... ) anyway? Or is that itself broken? [18:44:10] (03PS1) 10Cmcmahon: [BrowserTest] update Media test for new 'Apply changes' step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143664 [18:44:35] (03Abandoned) 10Cmcmahon: Merge "Merge Media Edit and Media Insert dialogs" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143662 (owner: 10Cmcmahon) [18:44:52] Krinkle: i'm using promises more and more, and I think we need to decide on a way to document them [18:44:53] Krenair: Indeed. jQuery has no special handling with keydown [18:45:01] It's using ..on( 'keydown' ) right now. I'm trying to figure out why that's not working [18:45:01] similar perhaps to how events are documented [18:45:09] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143664 (owner: 10Cmcmahon) [18:45:45] TrevorParscal: jsduck supports plugins. We can have something like @promise {Type} description. [18:45:52] Instead of returns [18:46:10] I think the code I had in my working directory was this.input.$input.get( 0 ).onkeydown = function () {} etc. actually [18:46:27] Krinkle: agreed, was hoping you could help me with that given your familiarity there [18:46:34] It appears to be running whatever I put in onkeydown, but jQuery does nothing [18:47:06] (03Merged) 10jenkins-bot: [BrowserTest] update Media test for new 'Apply changes' step [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143664 (owner: 10Cmcmahon) [18:47:14] TrevorParscal: Not right now.. but I'm not sure it's that big a deal. You can describe the same in the returns with very little. Like @return {jQuery.Promise} description with Type in it. [18:47:19] we should make it possible to indicate which promise is returned (by a symbolic name i guess) and also to document it elsewhere (like how we do with events) [18:47:26] (nothing with ".on( 'keydown, function () { etc. } )") [18:47:31] TrevorParscal: symbolic name? [18:47:35] Krinkle: that is what I am doing now [18:48:04] I think your unexplained influence by Java is creeping up [18:48:11] :P [18:48:14] Krinkle: yeah, well the problem, like events, is that the same promise might be returned in more than one place, so centralizing the documentation is useful [18:48:44] and the promise might be passed as a param, or a return, anyway we can work on that when you come to SF maybe? [18:48:50] The promise itself, if shared/re-used for caching, is an internal detail. that shoulnd't be documented and certainly not a public property. If it has any special behaviour to it, that shoul dbe described elsewhere [18:49:09] We don't centralise return values either [18:49:37] If a value within the promise is so special, similar to return types, that might warrant its own class. But the returning/promising itself should be straight forward. [18:50:01] If not, I'd say that's a problem in the code, not the documentation. And quite often, restricting documetnation tends to bring up code design questions. [18:50:10] Can you show an example of such symbolic name/ [18:50:19] this.input.$input.get( 0 ).onkeydown = function () { console.log( 'onkeydown' ); }; [18:50:19] this.input.$input.on( 'keydown', function () { console.log( 'jQuery.on keydown' ); } ); [18:50:23] only 'onkeydown' gets printed. what. [18:51:13] Krenair: .get() isn't going to be of any significant. Thats just return this[ index ] effectively. [18:51:36] yeah, it doesn't change the issue I'm running into [18:51:39] Assuming it ins't a typo, it'll be somewhere in jQuery.Event.add or something like that [18:52:20] Krenair: Have you verified the event is bound? [18:52:30] e.g. is it surpressed on fire or on bind [18:53:02] James_F, RoanKattouw btw re the alignment buttons -- do we want to add "Center" too, or just left/right? [18:53:03] basically I'm using promises for opening, opened and closing, the result of openWindow() is the opening promise, resolved when open with the opened promise, resolved when closing with the closing promise, resolved with closed - we also emit opening and closing events, which provide the opening and closing promises [18:53:08] Krenair: Also, compare it to addEventListener, not on* properties, those are legacy and inconsistent anyway [18:53:28] Krenair: addEventListener doesn't expose its list of bound functions in the API, but it can be inspected in Chrome Dev Tools [18:53:32] so, I am using the same exact promise as both a return value and an event argument [18:53:33] Krenair: Let me know if you need more :) [18:54:19] right now I am just using "see {@link #event-closing} for more details about the `closing` promise" to "share" the documentation [18:54:28] because otherwise it's quite a lot of copy/paste [18:55:57] TrevorParscal: OK, I get your point. But while these are related to the promise in your mind, really this doesn't belong in the promise. The promise should describe the value it will resolve to. Not when it is resolved, that should be irrelevant (internal) or obvious (the action currently invoked, e.g. method open() returns a promise that is resolved when the open action is completed) [18:56:38] Events providing promises doesn't make sense to me. [18:57:25] Sounds like you need to emit another event, or only the other event. Unless the promise provides a value and isn't just a delayed callback proxy. [18:57:27] Krinkle, event is called with addEventListener [18:57:34] i have a window manager, which opens/closes windows, i have a context which observes (but is not the one responsible for) opening and closing windows [18:57:46] Krenair: Good. So it isn't a bug in native addEventListener. [18:58:06] TrevorParscal: Can you link to the code in master or gerrit? [18:58:17] the progress of opening and closing is passed through the promises as progress (setup and ready for opening, hold and teardown on closing) [18:58:21] I will push it in a minute [18:58:26] then we can talk about it in review [18:58:32] Krenair: Can you verify in the Chrome Dev Tools that the element has no events bound, and 1 after native addEventListener, and 2 after jQuery .on() ? [18:58:59] In the Elements inspector, the right hand column has an "Event listeners" tab [18:59:38] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384 (10Roan Kattouw) a:3Alex Monk [18:59:38] yep, checking [18:59:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10Roan Kattouw) [19:06:43] Krinkle, seems to start with something attached via jquery [19:07:20] Krenair: Be sure to ignore bindings with a # from higher up, those are delegated down within the scope of the element, not on the element itself [19:07:48] Krenair: Cool, so they're both attached? Or are you saying it's attached already before you bind yours? [19:08:00] This is before I bind anything [19:09:12] Krinkle, with a #? I don't see that anywhere [19:09:16] good [19:09:18] (03PS13) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [19:09:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389 (10James Forrester) p:5Unprio>3High [19:09:22] Apparently the node is the document though... [19:09:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389 (10James Forrester) 5NEW>3ASSI [19:09:51] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - 10https://bugzilla.wikimedia.org/64760#c4 (10WhatamIdoing) I think we have another version of this at https://en.wikipedia.org/w/index.php?oldid=614417933#Cut_and_paste_from_a_diff This time, the cop... [19:10:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [19:10:24] Krenair: Right, so jQuery only calls addEventListener once for an event on an element for performance reasons. Like a bootstrap. So be sure to test it in isolation on an element where the real VE hasn't done the binding already as that conflcts with the one that (I assume) youre adding from the console [19:12:00] (03PS1) 10Cmcmahon: [BrowserTest] Update test for References changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143674 [19:12:23] Krenair: maybe use http://jsfiddle.net/a45pj/ as base [19:12:51] 3VisualEditor / 3Technical Debt: VisualEditor: Merge the inserting and editing media dialogs - 10https://bugzilla.wikimedia.org/67170 (10James Forrester) 5PATC>3RESO/FIX [19:12:57] (03PS3) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [19:13:01] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143674 (owner: 10Cmcmahon) [19:13:21] 3VisualEditor: VisualEditor: A pawn appears when moving a period in VisualEditor - 10https://bugzilla.wikimedia.org/67432 (10Gabriel Wicke) [19:13:23] 3VisualEditor: Parsoid: A pawn appears when moving a period in VisualEditor - 10https://bugzilla.wikimedia.org/67432#c1 (10Gabriel Wicke) a:5Parsoid Team>3None Sounds like a VE issue. Moving there. [19:14:56] Krenair, I was just reading through https://bugzilla.wikimedia.org/show_bug.cgi?id=66939 [19:15:16] I've received a similar bug report on the Russian Wikipedia [19:15:30] Can't find template in Insert-Template if his name consist a dot ".". Sample: {{См. также}}. "См. также" - "Смотри также", same as "p. s." - " post scriptum".Sunpriat 18:00, 1 июля 2014 (UTC) [19:15:52] Should that get a new bug report, or reopen that one? [19:16:27] (03Merged) 10jenkins-bot: [BrowserTest] Update test for References changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143674 (owner: 10Cmcmahon) [19:17:51] Didn't I just fix something like that? [19:17:52] hm [19:18:11] Right, the bugzilla I just found is similar [19:19:25] I think that was fixed like yesterday? [19:19:36] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [19:19:38] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Juliusz Gonera [19:19:41] https://gerrit.wikimedia.org/r/#/c/140875/ [19:19:42] I mean the fix was merged yesterday, it'll be on tomorrow's deploy train [19:19:50] RoanKattouw: Ah, cool, thanks [19:20:14] RoanKattouw, this is in beta labs, and I think it's a side effect of my change [19:20:14] Krenair: No I mean the getPrefixedText() vs getMainText() thing [19:20:24] I think this is something different [19:20:25] which is a follow-up to that one [19:20:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:21:07] (03PS1) 10Catrope: In image names in the context menu, use spaces rather than underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143679 [19:21:24] Krenair: Can haz CR? ---^^ [19:22:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) 5NEW>3ASSI [19:24:59] (03PS1) 10Catrope: Followup 54458c8: take directionality for parameter icons from frame, not toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143680 [19:25:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [19:34:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: For the first time in each edit session in Nexus 7(Android 4.4.2), Link Inspector gets auto-zoomed in, which looks like partial rendering of the UI - 10https://bugzilla.wikimedia.org/66759#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Juliusz Go... [19:34:51] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c4 (10Roan Kattouw) I... can no longer reproduce this. I tried the ste... [19:35:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None It's pretty much impossible to open the references context toolbar to edit an existing reference. Steps to reproduce: 1.... [19:35:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10Maryana Pinchuk) p:5Unprio>3High [19:36:21] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:37:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c7 (10James Forrester) Possibly a deploy issue. [19:37:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor appears over the toolbar in iPad Mini and Nexus 7 for Mobile VE - 10https://bugzilla.wikimedia.org/65325#c2 (10James Forrester) a:5Jon>3Juliusz Gonera Maybe will go away if we use a different method for a sticky header. [19:38:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697#c1 (10James Forrester) 5NEW>3ASSI Might be related to the context being wrong in iOS? [19:38:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [19:39:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:39:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [19:40:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [19:40:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756#c1 (10James Forrester) Try to recheck in case this was a deployment issue? [19:41:50] (03PS1) 10Alex Monk: Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) [19:44:50] RoanKattouw_away, looks like there's still something to do there but that should fix this bug [19:49:52] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c5 (10James Forrester) 5ASSI>3RESO/FIX a:5Roan Kattouw>3Ed Sand... [19:53:59] (03CR) 10Jforrester: [C: 032] "Whoops, yes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143680 (owner: 10Catrope) [19:55:07] (03CR) 10Jforrester: [C: 032] In image names in the context menu, use spaces rather than underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143679 (owner: 10Catrope) [19:56:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10James Forrester) 5NEW>3ASSI s:5normal>3major [19:57:41] (03Merged) 10jenkins-bot: Followup 54458c8: take directionality for parameter icons from frame, not toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143680 (owner: 10Catrope) [19:57:43] (03Merged) 10jenkins-bot: In image names in the context menu, use spaces rather than underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143679 (owner: 10Catrope) [19:58:48] Where are the labels for the context stuff set? [19:59:36] (03PS4) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [20:01:05] Krenair: getDescription on the DM nodes. [20:01:07] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c6 (10Brion Vibber) I've noticed a few bugs coming through related to certain operations hiding the keyboard and then that killing focu... [20:01:08] Krenair: Why? [20:02:16] Realised I'm not properly prefixing main-namespace templates with ':' there [20:03:15] Ah, right. [20:04:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Almost certainly a Beta Labs problem of the moment. [20:05:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399#c4 (10James Forrester) 5REOP>3RESO/FIX Yay deployment. [20:06:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c8 (10James Forrester) 5REOP>3RESO/FIX Yay deployment. [20:07:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) [20:07:06] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10James Forrester) [20:07:07] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync in Firefox - 10https://bugzilla.wikimedia.org/52171 (10James Forrester) [20:07:07] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10James Forrester) [20:07:21] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [20:07:32] (03PS2) 10Alex Monk: Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) [20:09:30] (03CR) 10jenkins-bot: [V: 04-1] Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) (owner: 10Alex Monk) [20:09:31] Aha, I've found an RTL media edit bug. [20:09:41] mooeypoo: Shame on you for not complaining earlier. [20:10:00] RoanKattouw_away, sorry I didn't get to that review request earlier [20:10:25] James_F, ... uh oh [20:10:26] (The Left | Centre | Right selector is reversed in RTL, and it shouldn't be as they're actual rather than just logical positions.) [20:10:44] * James_F has no idea how to fix it, though. :-) [20:10:46] James_F, oh, *that* is fixed in the default [20:10:54] so I just need to adjust. Interesting. Hm. [20:11:14] James_F, here's an idea: We can call them something like "text side" and "opposite" [20:11:17] (03PS3) 10Alex Monk: Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) [20:11:23] then it's easy to fix [20:11:24] Krenair: Tsk you and your PHP-loving "-over-' ways. ;-) [20:11:36] mooeypoo: Cheat. :-P [20:11:49] mooeypoo: And a poor fix. [20:11:51] James_F, I plagiarize from Unicode Bidi algorithm :P [20:12:37] Hmm. I'll think about that, then. James_F I'm almost done with the first batch of fixes to the dialog [20:12:45] Cool. [20:12:55] My latest gripe is low-priority. :-) [20:16:42] Krinkle, yeah it seems fine in that jsfiddle [20:17:00] really? [20:17:02] Krenair: interesting [20:17:04] hmm I am having a problem with one of the things in the media edit dialog list, but it can wait. I might have to fix something in ooui [20:17:20] mooeypoo: Fun. [20:17:30] Krinkle, I assume something else in VE/OOUI is suppressing things [20:17:56] Krenair: Well, there is even delegation of course [20:18:01] .stopPropagation [20:18:04] .stopImmediatePropagation [20:18:05] return false [20:18:07] those three [20:18:12] yeah... [20:18:56] Krenair: keydown doens't bubble up form inside an input field for it has no chidren, so that rules out stopPropagation [20:19:11] That means if there are other event handlers, you'll know where to find them [20:19:20] either on the native element that can be inspected in chrome [20:19:29] ir another jQuery handler, which can be inspected inside jQuery data() [20:19:42] jQuery._date(node) [20:19:45] _data* [20:19:52] .events .. .. .. down that rabbit hole [20:19:57] :) [20:20:28] that'll eventually give you the evnet handler callbacks themselves which you can log to the console to see the function body [20:20:36] that'll give you a snippet of code to grep in the repo for [20:26:29] Krinkle, well there's no keydown in this object [20:27:05] even though chrome shows a jquery event listener on it [20:29:38] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110#c7 (10James Forrester) s:5normal>3major (In reply to Brion Vibber from comment #6) > I've noticed a few bugs coming through related... [20:30:01] (03PS1) 10Mooeypoo: UX Improvements to the Media Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143749 [20:30:12] James_F, ^^ I think I got 'em all [20:33:38] Nice. [20:35:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c9 (10ryasmeen) Verified the fix in Betalabs with iOS [20:36:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399#c5 (10ryasmeen) Verified the fix in Betalabs with iOS [20:50:53] (03PS1) 10Jforrester: Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143756 [20:59:08] 3VisualEditor / 3Editing Tools: VisualEditor: Link Suggestions are now not appearing for Desktop VE in Betalabs - 10https://bugzilla.wikimedia.org/67437 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15817 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15817&action=edit Scre... [21:02:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link Suggestions are now not appearing for Desktop VE in Betalabs - 10https://bugzilla.wikimedia.org/67437 (10ryasmeen) p:5Unprio>3High a:3Roan Kattouw [21:12:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c10 (10ryasmeen) Verified the fix in Betalabs with Android as well [21:57:01] (03PS1) 10Cmcmahon: [BrowserTest] update Links test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143770 [21:58:01] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143770 (owner: 10Cmcmahon) [22:00:42] (03Merged) 10jenkins-bot: [BrowserTest] update Links test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143770 (owner: 10Cmcmahon) [22:02:08] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15818 --> https://bugzilla.wikimedia.org/attac... [22:04:33] Krenair: Are you sure that the one you see in Chrome is on that node and not on a parent node? [22:04:43] Krenair: What about after you bind it with .on(), then it shows up in _data, right? [22:05:03] (03PS5) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [22:05:37] 3VisualEditor / 3Editing Tools: Template lookahead finds nothing - 10https://bugzilla.wikimedia.org/66981#c2 (10Chris McMahon) 5RESO/DUP>3REOP This bug is back with the merge of new VE UI elements to master as of July 2. [22:06:09] (03CR) 10jenkins-bot: [V: 04-1] Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders) [22:06:33] ryasmeen: I just reopened https://bugzilla.wikimedia.org/66981 FYI [22:08:38] chrismcmahon: I believe it is due to :https://bugzilla.wikimedia.org/show_bug.cgi?id=67384 [22:08:42] Krinkle, the node is the entire iframe the element is in [22:08:46] so it's a parent [22:09:04] The search results are appearing in the template dialog [22:09:21] byt with a prefix "Template:" [22:09:25] but* [22:09:44] Krinkle, This time, keydown was set in the events object [22:10:09] But then nothing changed when I used .on [22:10:39] Krenair: Did you reproduce the bug on jsfiddle or did it work fine there? [22:10:44] was fine [22:10:52] ryasmeen: I am not seeing what you're seeing :-) [22:11:16] Right, so now you're checking in an environment that already has the one build by ve/oojs-ui naturally before you can inspect it. [22:11:26] ryasmeen: but I am seeing Template:Foo show in another unexpected context, let me see if I can nail that donw [22:11:28] down [22:11:43] Krenair: Hm.. I haven't used these myself, but I recall Dev tools has "event" breakpoints. [22:11:57] Look for it when right clicking on the elements inside the Elements tree view [22:12:00] chrismcmahon:ok [22:12:40] Krenair: Hm.. I can't find that myself. Looks like it dissapeared [22:13:07] 'Event Listener Breakpoints' in the right toolbar under Sources? [22:13:18] nice [22:13:39] that works for me [22:13:44] ryasmeen: actually not unexpected, I am visiting the page at Template:Seleniumtest to make sure at least one template exists when I look ahead using "S" in the Template inpector. Right now nothing shows up at all in the lookahead. [22:13:56] if that doesn't work or is too deep for now, something to try first might be to put a debugger; statement somewhere in the jQuery source right near where the native event is captured [22:14:50] Krenair: in jQuery source code, look for "add:" (the one in jQuery.event), near eventHandle = elemData.handle [22:15:03] that's the function that gets tossed into addEventListener as the bootstrap for that event [22:15:38] I'd ensure that that one gets called. If not, then something is cancelling it without using jQuery (e.g. an onkeydown= assignment that returns false) [22:18:06] chrismcmahon: ok , I will check it with RoanKattouw [22:24:36] 3VisualEditor / 3Editing Tools: VisualEditor: Autoconversion of external links to wikis is fabulous, except when the wiki doesn't know about the wiki - 10https://bugzilla.wikimedia.org/67373#c1 (10Ed Sanders) Does this happen in VE or Parsoid? If the latter it should be moved. [22:28:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c6 (10Ed Sanders) It looks like the above commit to Chrome for Mobile has been merged, which solves the most serious case (no event fired at all). We... [22:49:33] (03PS1) 10Catrope: Followup 96ff968: use this.$element after it's initialized, not before [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143782 (https://bugzilla.wikimedia.org/67437) [22:49:43] TrevorParscal: ---^^ [22:50:02] (03CR) 10Catrope: [C: 032] Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143756 (owner: 10Jforrester) [22:50:31] (03PS2) 10Catrope: Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143756 (https://bugzilla.wikimedia.org/53330) (owner: 10Jforrester) [22:50:40] (03CR) 10Catrope: [C: 032] Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143756 (https://bugzilla.wikimedia.org/53330) (owner: 10Jforrester) [22:52:54] (03Merged) 10jenkins-bot: Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143756 (https://bugzilla.wikimedia.org/53330) (owner: 10Jforrester) [22:56:08] (03CR) 10Trevor Parscal: [C: 032] Followup 96ff968: use this.$element after it's initialized, not before [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143782 (https://bugzilla.wikimedia.org/67437) (owner: 10Catrope) [22:57:36] (03Merged) 10jenkins-bot: Followup 96ff968: use this.$element after it's initialized, not before [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143782 (https://bugzilla.wikimedia.org/67437) (owner: 10Catrope) [22:58:51] 3VisualEditor / 3Editing Tools: VisualEditor: When text is being made superscripted and is already subscripted, clear the latter (and vice versa) - 10https://bugzilla.wikimedia.org/53330 (10James Forrester) 5PATC>3RESO/FIX [22:59:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437 (10James Forrester) 5PATC>3RESO/FIX [23:01:17] chrismcmahon: What's that I hear about no search results for templates? [23:01:20] It seems to WFM on my machine [23:01:25] Unless I misunderstood what the bug is [23:02:50] RoanKattouw: on http://en.wikipedia.beta.wmflabs.org/wiki/Links_VisualEditor_Test?veaction=edit; pick Template; type "S"; nothing appears. That should at least return "Template:Seleniumtest" [23:03:04] chrismcmahon: Was that in Beta Labs? We've been having that off and on (deployment-less) for a few days there. [23:03:07] chrismcmahon: Ah, right. [23:03:33] Yeah that appears to be a search bug [23:03:42] I can see the API request go out, and come back with nothing [23:03:49] Helpful. [23:03:56] * James_F blames Chad. [23:04:20] chrismcmahon: Note if you type 'c' there is a result (albeit only one) [23:04:47] RoanKattouw: type "S" in the normal search box and it is fine. [23:05:50] chrismcmahon: But type Template:S and it's not [23:06:07] Whereas Template:C works (kind of) [23:12:02] edsanders: How are things? You got anything you want to get in before the cut? Also, https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&list_id=326348&namedcmd=VE-%21marked-for-next-release has quite a few issues (especially mobile things) that you might want to look at if you're at a loss for fun issues. ;-) [23:26:52] nothing close to ready [23:36:08] "The search named VE-!marked-for-next-release does not exist." [23:36:18] Yeah that's annoying [23:36:23] (03PS6) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [23:36:25] It doesn't let you share that search for some reason [23:36:54] But if you go to Shared searches you can find it in James's list of searches he shares and enable it for your BZ sidebar [23:40:20] (03CR) 10Esanders: [C: 04-1] "& jsduck wants you to add a bunch of stuff to categories.json" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [23:44:37] (03CR) 10Esanders: [WIP] Dialog Rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [23:44:46] (03CR) 10Esanders: "Pressing ctrl+? for the help dialog throws an exception:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [23:46:22] (03PS14) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [23:47:10] (03PS4) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (7a7e5c617b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [23:47:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:47:14] (03CR) 10Esanders: [WIP] Dialog Rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [23:47:17] (03PS4) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [23:47:51] ed, take a look a the code, post that round of pushes [23:47:58] the link inspector was pretty busted [23:48:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [23:48:07] (didn't apply changes) [23:48:33] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (7a7e5c617b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [23:58:55] (03CR) 10Esanders: [C: 04-1] [WIP] Dialog Rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)