[09:04:50] <grrrit-wm>	 (03PS1) 10Zfilipin: [BrowserTest] Change interface language with environment variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) 
[09:06:24] <grrrit-wm>	 (03CR) 10Vikassy: [C: 031] [BrowserTest] Change interface language with environment variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin)
[09:06:33] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] Change interface language with environment variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin)
[09:08:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Change interface language with environment variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin)
[09:19:35] <grrrit-wm>	 (03PS7) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 
[09:19:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (owner: 10Vikassy)
[09:31:29] <grrrit-wm>	 (03PS8) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 
[12:41:09] <wikibugs>	 3VisualEditor: VisualEditor: Snowmen appearing for some reason - 10https://bugzilla.wikimedia.org/67591 (10Helder) 3NEW p:3Unprio s:3normal a:3None https://pt.wikipedia.org/w/index.php?diff=39208742
[13:03:08] <wikibugs>	 3VisualEditor: VisualEditor: A pawn appears when moving a period in VisualEditor - 10https://bugzilla.wikimedia.org/67432#c2 (10Elitre) If this happens in FF, can it be related to bug 54917?
[13:58:08] <grrrit-wm1>	 (03PS1) 10Zfilipin: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 
[14:00:15] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin)
[14:01:19] <grrrit-wm1>	 (03PS2) 10Zfilipin: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 
[14:02:23] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin)
[14:12:48] <grrrit-wm1>	 (03PS9) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 
[15:41:13] <grrrit-wm1>	 (03CR) 10Jforrester: "Is the intent to use this in lieu of an actual language wiki? If so, it will run into some issues, because a part of the VE interface (and" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin)
[15:58:30] <vikas>	 hello ! I was writing browser tests for Gallery for language screenshot.I wanted to know whether it(Gallery) is moved somewhere ?
[15:59:23] <James_F>	 vikas: We disabled inserting galleries because they were confusing to users.
[15:59:45] <James_F>	 vikas: We plan to have the toolbar have a "more" option inside menus, at which point we'll bring it back.
[16:01:10] <vikas>	 James_F: great ! Thank you for this information :) 
[16:01:41] <cscott>	 hello, visual editor folks.  can someone point me to mediawiki's docs on its basic javascript interface?
[16:01:49] <cscott>	 like mw.* etc
[16:02:16] <cscott>	 i'm sure you guys have that bookmarked, but i can't seem to find what i'm looking for.
[16:05:21] <James_F>	 cscott: doc.mediawiki.org ?
[16:05:51] <cscott>	 https://www.mediawiki.org/wiki/ResourceLoader/Default_modules seemed to be what i was looking for
[16:06:14] <cscott>	 also, https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#mw.config
[16:33:06] <James_F>	 TrevorParscal: Morning.
[16:45:57] <grrrit-wm1>	 (03CR) 10Jforrester: [C: 032] Clearer test message, as used in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144326 (owner: 10Esanders)
[16:48:07] <grrrit-wm1>	 (03Merged) 10jenkins-bot: Clearer test message, as used in core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144326 (owner: 10Esanders)
[17:22:03] <grrrit-wm1>	 (03PS10) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 
[17:33:01] <Krenair>	 James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=65012#c2
[17:36:01] <James_F>	 Krenair: Thanks.
[17:36:11] <James_F>	 Oh, yeah.
[17:37:55] <James_F>	 Krenair: I think having a pending state on confirmation dialogs could work.
[17:38:16] <James_F>	 Krenair: Don't think it's currently available, though (and almost certainly not post-rewrite).
[17:38:34] <Krenair>	 Yeah, I'll need to fiddle with it to get that to work but it's possible
[17:38:54] <James_F>	 *cough* rebase hell *cough* :-)
[17:39:18] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner, pending state or similar - 10https://bugzilla.wikimedia.org/65012 (10James Forrester)
[17:46:03] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] In iOS Safari, cannot open any page as it throws error "Error,can't load section" - 10https://bugzilla.wikimedia.org/67508#c4 (10ryasmeen) 5ASSI>3RESO/FIX This seems to be working now :)
[17:50:18] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] In iOS Safari, cannot open any page as it throws error "Error,can't load section" - 10https://bugzilla.wikimedia.org/67508#c5 (10James Forrester) a:3Roan Kattouw Fix by Roan unbreaking the databases.
[18:09:34] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a pa...
[18:11:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13] "Error: ve.dm.Document.getNodeFromO ffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed...
[18:15:11] <vikas>	 Hello ! I wanted to add id/class(anything specific) to certain elements like => "Insert" in VisualEditor, so that it can be used for browser tests on different languages. How do I do that ? 
[18:16:04] <James_F>	 vikas: We don't currently support that. Is it necessary?
[18:17:18] <vikas>	 James_F: for now I am using index numbers of "oo-ui-popupToolGroup-handle" to solve the problem, but if the positions are changed, then it might fail :( 
[18:17:39] <vikas>	 https://gerrit.wikimedia.org/r/#/c/142990/10/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb,cm
[18:17:44] <vikas>	 line 16
[18:17:59] <James_F>	 Hmm. That's a bit of a hack, yeah. :-(
[18:18:37] <James_F>	 The problem is (a) ids are evil, and (b) everything in the toolbar might change – there might not be a button for cites in future (though that's unlikely), so adding persistent IDs now is wildly premature.
[18:19:36] <Krenair>	 ugh, I'm lost in jquery internals
[18:20:22] <vikas>	 oh ! what if we add a class ? 
[18:21:21] <James_F>	 vikas: The same applies to classes – if we don't know what structure we'll end up with, the classes and their semantics will change massively.
[18:27:49] <vikas>	 James_F:  agreed ! 
[18:29:03] <Krenair>	 Krinkle, hey
[18:29:09] <Krinkle>	 Hi
[18:29:14] <Krinkle>	 How's it going on the event bug?
[18:29:24] <Krenair>	 badly
[18:29:41] <Krinkle>	 What have you narrowed it down to?
[18:30:23] <Krinkle>	 Reproducing on plain jsfiddle with jQuery doesn't exhibit the bug. How about on a oojs-ui demo without VE.
[18:30:42] <Krinkle>	 Did breakpoints in the event stack help?
[18:36:10] <Krenair>	 I'm really not sure what's going on
[18:37:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Changing language of a <syntaxhighlight /> node doesn't load styles for new language - 10https://bugzilla.wikimedia.org/67515 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor
[18:38:02] <Krenair>	 I'm pretty sure the handler is never making it to the... queue?
[18:38:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Pasting a syntaxhighlight block from another VE surface don't load syntaxhighlight's styling - 10https://bugzilla.wikimedia.org/58388 (10James Forrester)
[18:53:16] <wikibugs>	 3VisualEditor / 3Editing Tools: Edit link dialog doesn't load target links - 10https://bugzilla.wikimedia.org/67272#c3 (10James Forrester) 5REOP>3RESO/WON (In reply to Elitre from comment #2) > I should have probably explained this better :) > If you wrote a word, then clicked on the chain icon, didn't t...
[18:54:22] <sumanah>	 TrevorParscal: hi TrevorParscal! on June 25th you said you'd like to come together again to review a more detailed technical proposal in 2 weeks; perhaps you would like for it to happen this week? Am happy to set it up
[18:54:34] <sumanah>	 (re frontend standardization)
[18:54:40] <sumanah>	 also, I hope you enjoyed your long weekend
[18:56:18] <TrevorParscal>	 indeed, I'm in the weeds, but can see the light, on a patch to VE that is really time sensitive at this point, so after that (like tomorrow) I can resurface and start paying attention to such things
[18:57:02] <sumanah>	 TrevorParscal: ok, thanks, I'll check in again with you tomorrow
[18:58:41] <sumanah>	 TrevorParscal: in the meantime, I'll schedule the meeting for Thursday so you have a little time to prepare
[18:59:49] <Krenair>	 Krinkle, hmm... So in jquery.event.add around "handlers.push( handleObj );" I added if ( types.indexOf( 'keydown' ) !== -1 ) { console.log( handlers ); console.log( handleObj ); }
[19:00:04] <Krenair>	 We just appended handleObj to handlers, right? Well um
[19:02:19] <Krenair>	 Krinkle, better, I logged handlers and handlers.length
[19:02:59] <Krenair>	 It appears as if handlers is length 0, and then length 1? I just don't even
[19:07:23] <Krenair>	 Krinkle, http://imgur.com/a39IuMk - that's handlers, handlers.length, handleObj
[19:07:55] <Krenair>	 Immediately after handlers.push( handleObj ); in jquery.event.add
[19:13:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Template dialog wrongly prefixes suggestions from User namespace with colon - 10https://bugzilla.wikimedia.org/67386 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk
[19:14:26] <Krenair>	 sounds dupey
[19:15:03] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low a:3Alex Monk
[19:17:46] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) p:5Unprio>3High
[19:18:05] <Krenair>	 dammit I thought I fixed that
[19:19:20] <James_F>	 Krenair: 67386?
[19:22:48] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: A pawn appears when moving a period in VisualEditor - 10https://bugzilla.wikimedia.org/67432#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Ed Sanders (In reply to Elitre from comment #2) > If this happens in FF, can it be related to bug 54917?...
[19:25:13] <Krenair>	 James_F, yeah, something like it anyway
[19:27:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Editing window does not scroll when dragging - 10https://bugzilla.wikimedia.org/51669#c7 (10James Forrester) *** Bug 63170 has been marked as a duplicate of this bug. ***
[19:27:17] <wikibugs>	 3VisualEditor / 3Editing Tools: Cannot scroll while dragging image content - 10https://bugzilla.wikimedia.org/63170#c1 (10James Forrester) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 51669 ***
[19:27:17] <James_F>	 Krenair: Fun.
[19:27:45] <Krenair>	 James_F, did you see that imgur link I sent?
[19:32:30] <James_F>	 Krenair: The one about jQuery handlers?
[19:33:39] <Krenair>	 yeah
[19:34:28] <James_F>	 What about it?
[19:37:58] <grrrit-wm1>	 (03PS1) 10Alex Monk: Get rid of my prefixColon config option from TitleInputWidget, use relative title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144497 (https://bugzilla.wikimedia.org/67386) 
[19:38:14] <Krenair>	 Oh I was just hoping you'd seen it. It doesn't make a lot of sense to me.
[19:39:24] <James_F>	 Nor me. :-)
[19:39:33] <James_F>	 I'm sure Krinkle|detached may have a view.
[19:42:08] <MatmaRex>	 hi
[19:42:20] <MatmaRex>	 so i put up https://www.mediawiki.org/wiki/VisualEditor_gadgets#Adding.2Fmodifying.2Fremoving_an_internal_link the other day, and wondered
[19:42:45] <MatmaRex>	 why does one have to pass the 'normalizedTitle' and 'lookupTitle' attributes if they can and should be just computed from the 'title' attribute
[19:44:36] <MatmaRex>	 isn't it possible to just compute these if they're missing? i wonder why they're included in the dm at all, for efficiency i guess
[19:46:16] <MatmaRex>	 or rather, it would seem that it is indeed possible, is there a reason it isn't done now?
[19:49:19] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Clear styling does not work when the cursor is the middle of a text but de-selects the option from style menu - 10https://bugzilla.wikimedia.org/67619 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15858   --> https://bugzilla.wikimedia....
[19:50:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424#c2 (10Alex Monk) I don't think this is valid... I can't reproduce it on my machine (with different pages)
[19:54:31] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424#c3 (10James Forrester) (In reply to Alex Monk from comment #2) > I don't think this is valid... I can't reproduce it on my mach...
[19:54:41] <TrevorParscal>	 MatmaRex: can I run something by you?
[19:54:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: The handler MWCategoryWidget::onLookupInputKeyDown is not actually bound to anything. - 10https://bugzilla.wikimedia.org/56700#c1 (10Alex Monk) <Krenair> Krinkle, http://imgur.com/a39IuMk - that's handlers, handlers.length, handleObj <Krenair> Immediately after handler...
[19:54:56] <MatmaRex>	 TrevorParscal: anytime
[19:55:01] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Clear styling does not work when the cursor is the middle of a text but de-selects the option from style menu - 10https://bugzilla.wikimedia.org/67619#c1 (10James Forrester) 5NEW>3RESO/WON This is intentional; "clear styling" without a selection applies to th...
[19:55:04] <TrevorParscal>	 using mw.Title.prototype.getUrl(), we don't get a protocol
[19:55:31] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:  TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424#c4 (10Alex Monk) Possibly. I had to fiddle around with things like that to check that this was actually working on my machine.
[19:55:35] <TrevorParscal>	 this seems odd to me
[19:56:01] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appearing for some reason - 10https://bugzilla.wikimedia.org/67591#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Any reproduction steps? :-(
[19:56:32] <TrevorParscal>	 have you seen any pattern that people are using to add one?
[19:56:41] <MatmaRex>	 TrevorParscal: hm, you don't get the domain either, just the absolute path
[19:56:47] <TrevorParscal>	 right
[19:56:49] <MatmaRex>	 i guess this is intended to be put in <a href=>?
[19:57:04] <TrevorParscal>	 I guess I'm hoping to turn an mw.Title into a full URL
[19:57:17] <TrevorParscal>	 but I don't really recall how that is typically done
[19:57:23] <MatmaRex>	 prepending wgServer seems like a good idea
[19:57:36] <TrevorParscal>	 seems sensible
[19:57:38] <MatmaRex>	 or maybe mw.Uri supports this if you want something 'clean'?
[19:58:01] <MatmaRex>	 (wgServer can be protocol-relative too, actually)
[19:59:35] <TrevorParscal>	 yeah, i was just looking how it's protocol relative
[19:59:58] <MatmaRex>	 i assume you want to generate a full URL to give the user as something to paste into IM or something?
[20:00:20] <grrrit-wm1>	 (03PS1) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) 
[20:00:25] <TrevorParscal>	 yeah, or be able to basically preview, click on to open into another tab, etc. but having a full URL seems like it would be ideal
[20:00:35] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: A pawn appears while trying to type something to the the left/right of a reference note in Firefox - 10https://bugzilla.wikimedia.org/67620 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15859   --> https://bugzilla.wikimedia.org/attachm...
[20:00:42] <MatmaRex>	 multimediaviewer does that somehow, so i'd look there
[20:00:52] <TrevorParscal>	 i will peek
[20:01:05] * marktraceur pokes head in
[20:01:20] <MatmaRex>	 they have more abstraction layers than VE, reserve some time for this ;)
[20:01:49] <grrrit-wm1>	 (03PS2) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) 
[20:02:46] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Typing between text and a reference produces a pawn in Firefox - 10https://bugzilla.wikimedia.org/58315#c1 (10James Forrester) *** Bug 67620 has been marked as a duplicate of this bug. ***
[20:02:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: A pawn appears while trying to type something to the the left/right of a reference note in Firefox - 10https://bugzilla.wikimedia.org/67620#c1 (10James Forrester) 5NEW>3RESO/DUP Boo.  *** This bug has been marked as a duplicate of bug 58315 ***
[20:04:21] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk)
[20:04:22] <marktraceur>	 MatmaRex: I'm not sure I agree with you
[20:04:38] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Inspired by comments at various wikis and at bug 63389: pretty much what the summary says.
[20:04:52] <TrevorParscal>	 MatmaRex: i have the luxury of a rolling chair in an office, and the multimedia guys sit next to me
[20:04:53] <grrrit-wm1>	 (03CR) 10Alex Monk: "I don't think MediaWiki core does it exactly like this. As you said, part of it is in OutputPage, but obviously not all of it is." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk)
[20:05:05] <MatmaRex>	 marktraceur: :>
[20:05:17] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Re-label "Manage template documentation" to something else - 10https://bugzilla.wikimedia.org/63389 (10Elitre)
[20:05:17] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621 (10Elitre)
[20:05:23] <MatmaRex>	 marktraceur: maybe i exaggerated a little
[20:05:42] <marktraceur>	 Besides, you have me! And that's as good as a search engine for the code.
[20:05:49] <marktraceur>	 git-grep, also passable.
[20:06:18] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: add tooltip/quick link to TD help page near new TD editor button - 10https://bugzilla.wikimedia.org/67621 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc a:3Moriel Schottlender
[20:06:41] <grrrit-wm1>	 (03PS3) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) 
[20:07:16] <marktraceur>	 TrevorParscal: Yeah I don't think we do what you need
[20:07:29] <grrrit-wm1>	 (03CR) 10Alex Monk: [C: 04-2] Show pending state and block clicks when switching to source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk)
[20:07:35] <marktraceur>	 We *used* to, but I think it was because of a fundamental misunderstanding of the GlobalUsage API
[20:11:00] <James_F>	 Hey mooeypoo.
[20:11:08] <MatmaRex>	 anyway, i'd go with u = new mw.Uri(); u.path = title.getUrl(); return u.toString();, or something like this.
[20:11:24] <mooeypoo>	 heya James_F I just got your message as I logged in :P
[20:11:52] * James_F grins.
[20:22:33] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Make full Size" is not enabling "Apply changes" button therefore cannot make any image fullsize - 10https://bugzilla.wikimedia.org/67624 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with VE 2.Insert an image 3.Go to th...
[20:26:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appearing for some reason - 10https://bugzilla.wikimedia.org/67591#c2 (10Helder) Not really. I found that page by chance (while playing the Wikidata Game).
[20:29:17] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c9 (10ryasmeen) 5RESO/FIX>3REOP Its changing the size value in the d...
[20:38:47] <Raymond|afk>	 hi
[20:39:07] <Raymond|afk>	 does anyone know if this nowiki bug is new or old? https://en.wikipedia.org/w/index.php?title=Horse_%28musician%29&diff=615995870&oldid=615721476
[20:59:40] <James_F>	 Raymond_: Hmm. That's very odd
[21:01:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863 (10ryasmeen) 5REOP>3ASSI
[21:03:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Formula icon is missing in the Insert menu - 10https://bugzilla.wikimedia.org/66890#c5 (10ryasmeen) 5RESO/?>3VERI Verified in production (en.wiki)
[21:03:42] <Raymond_>	 James_F: I started the editing three times to be sure that I have not touched these parts. every the nowiki appears in the diff and I decided to save it and fix it in the next step
[21:04:01] <James_F>	 Raymond_: Looks like it was bad wikitext.
[21:04:32] <James_F>	 Raymond_: <ref …>{{cite book\n*…\n\n| first=David\n
[21:04:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf11] Template suggestions are not appearing in Betalabs while trying to add a template - 10https://bugzilla.wikimedia.org/66987#c4 (10ryasmeen) 5RESO/?>3VERI Verified in production (en.wiki)
[21:04:48] <Raymond_>	 James_F: maybe. I will leave it to you :-) I do not edit very often in enwiki, just for images
[21:05:53] <James_F>	 Raymond_: Works now.
[21:07:09] <Raymond_>	 James_F: thanks :-)
[21:08:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The Math and Heiro Inspector jumps to the beginning of the article while opening it for the first time of every edit session - 10https://bugzilla.wikimedia.org/66813#c6 (10ryasmeen) Verified the fix in production (en.wiki)
[21:11:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855#c8 (10ryasmeen) Verified the fix in production (en.wiki)
[21:11:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855 (10ryasmeen) 5RESO/?>3VERI
[21:12:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appearing for some reason - 10https://bugzilla.wikimedia.org/67591#c3 (10James Forrester) 5ASSI>3RESO/DUP Merging with bug 57884 then.  *** This bug has been marked as a duplicate of bug 57884 ***
[21:13:01] <wikibugs>	 3VisualEditor: VisualEditor: snowmen at fr.wp - 10https://bugzilla.wikimedia.org/57884#c3 (10James Forrester) *** Bug 67591 has been marked as a duplicate of this bug. ***
[21:13:31] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen being created (no reproduction steps) - 10https://bugzilla.wikimedia.org/57884 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major
[21:13:48] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Cursor jumps to the beginning of the document after adding citations/references - 10https://bugzilla.wikimedia.org/64041#c12 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production (en.wiki)
[21:14:21] * mooeypoo shrieks
[21:14:25] <mooeypoo>	 there's an *image* bug!
[21:14:32] <cscott>	 say it isn't so!
[21:14:33] <mooeypoo>	 Where's my cape..
[21:14:38] * James_F grins.
[21:14:55] * James_F mutters about TemplateData bugs. :-)
[21:15:19] <cscott>	 James_F: i'm trying to update VE on togetherjs.wmflabs.org and i'm getting "Fatal exception of type MWException" which goes away when I comment out require_once("$IP/extensions/VisualEditor/VisualEditor.php");
[21:15:20] <cscott>	 any ideas?
[21:15:37] <James_F>	 cscott: Anything more in the logs?
[21:15:42] <cscott>	 i can't seem to get a stack trace in apache's error.log, and i don't understand why not
[21:15:44] <James_F>	 cscott: What version of MW?
[21:16:00] <cscott>	 probably old-ish?  it's whatever puppet put on there.
[21:16:08] <cscott>	 1.22?
[21:16:47] <cscott>	 isn't the puppet role supposed to keep mediawiki updated?
[21:16:58] * cscott blames marktraceur
[21:17:04] * marktraceur blames RoanKattouw
[21:17:09] <marktraceur>	 What are we talking about
[21:18:24] <James_F>	 cscott: If it's not 1.24alpha you're going to have a bad time using VE-master.
[21:18:26] <cscott>	 https://wikitech.wikimedia.org/wiki/Nova_Resource:I-0000029f.eqiad.wmflabs belongs to puppet class role::mediawiki-install::labs but it's mediawiki install is really old
[21:18:36] <cscott>	 James_F: i am indeed having a bad time
[21:18:54] <cscott>	 i wasn't aware bad time extended to, "and php won't even tell you *why* it hates you"
[21:19:10] <James_F>	 It's surprising to me that it fails that badly.
[21:19:32] <James_F>	 There's a flag in VE (wfVersion or something) that explicitly is an early call to check the version number and make it abort nicely.
[21:19:46] * James_F runs.
[21:20:32] <cscott>	 that could indeed be what i'm hitting, coupled with some role::mediawiki-install::labs "niceness" which is causing it to (a) not update and (b) suppress error traces.
[21:39:04] <grrrit-wm1>	 (03PS1) 10Mooeypoo: Deprecate 'live' event in favor of 'setup' and 'teardown' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144586 (https://bugzilla.wikimedia.org/55505) 
[21:42:02] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429#c3 (10ryasmeen) Verified the fix in betalabs and test2
[21:43:18] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer to retain changes when switching to the "Edit Source" tab - 10https://bugzilla.wikimedia.org/57462#c10 (10ryasmeen) Verified the fix in test2
[21:51:31] <Krinkle>	 Krenair: Reading your messages now
[21:57:00] <Krinkle>	 Krenair: " I'm sure Krinkle|detached may have a view." what's that about?
[21:59:04] <grrrit-wm1>	 (03PS2) 10Krinkle: MWTitleInputWidget: Remove prefixColon config option and use relative title instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144497 (https://bugzilla.wikimedia.org/67386) (owner: 10Alex Monk)
[21:59:13] <grrrit-wm1>	 (03PS3) 10Krinkle: MWTitleInputWidget: Remove prefixColon option and use relative title instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144497 (https://bugzilla.wikimedia.org/67386) (owner: 10Alex Monk)
[22:04:15] <Krenair>	 Krinkle, 
[22:04:15] <Krenair>	 <Krenair> Krinkle, http://imgur.com/a39IuMk - that's handlers, handlers.length, handleObj
[22:04:15] <Krenair>	 <Krenair> Immediately after handlers.push( handleObj ); in jquery.event.add
[22:10:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494#c6 (10ryasmeen) Verified the fix in Betalabs and test2
[22:10:41] <Krinkle>	 Krenair: I'm missing some context I think. Not sure what to do with this.
[22:12:07] <Krenair>	 Krinkle, I added some console.log calls for handlers, handlers.length, and handleObj in jquery.event.add just after handlers.push( handleObj )
[22:12:12] <Krenair>	 This is the result.
[22:12:46] <Krenair>	 Notice how handleObj is not in handlers, and handlers supposedly has a length of 0 but when you do handlers.length it has a length of 1? Yeah...
[22:13:03] <Krinkle>	 Are you logging the array or the functions' length?
[22:13:06] <Krinkle>	 It's easy to mix 'em up
[22:13:21] <Krinkle>	 functions have a length property reflecting the number of specified arguments
[22:14:19] <Krenair>	 I posted the code on the bug
[22:15:46] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Use comma-separator interface message - 10https://bugzilla.wikimedia.org/66894 (10Krinkle)
[22:19:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Deleting a block item highlights the previous line - 10https://bugzilla.wikimedia.org/67213#c3 (10ryasmeen) Verified the fix in betalabs and test2
[22:41:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester)
[22:42:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The MWAlienInspector immediately closes after opening on Opera 12 sometimes - 10https://bugzilla.wikimedia.org/67530 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low
[22:43:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The MWAlienInspector immediately closes after opening on Opera 12 sometimes - 10https://bugzilla.wikimedia.org/67530 (10James Forrester) a:3Bartosz Dziewoński
[22:45:41] <TrevorParscal>	 Krinkle: hey, with jQuery.Promise, I want one promise to resolve/reject another, and I don't want to write then( bind( resolve ), bind( reject ) ) 
[22:45:51] <TrevorParscal>	 (that is pseudo code)
[22:45:54] <TrevorParscal>	 any suggestions?
[22:46:18] <TrevorParscal>	 I tried using firstPromise.then( secondPromise ) but it doesn't work
[22:52:18] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut to access VE (Alt+Shift+v) is not working from action=edit in FF browser - 10https://bugzilla.wikimedia.org/67218#c1 (10James Forrester) 5UNCO>3ASSI a:3Alex Monk Yeah, Ctrl+Alt+v (on a Mac) works fine for me in read mode, but not i...
[22:54:46] <grrrit-wm1>	 (03PS1) 10MaxSem: @group TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/144604 
[22:55:58] <grrrit-wm1>	 (03CR) 10MaxSem: [C: 032] @group TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/144604 (owner: 10MaxSem)
[22:56:19] <grrrit-wm1>	 (03Merged) 10jenkins-bot: @group TemplateData [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/144604 (owner: 10MaxSem)
[22:59:31] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433#c7 (10Keegan Peterzell) Using *any* means of copying text is making the ctrl/cmd key cause a page to jump up, not just ctrl-c/cmd-c, in Firefox. Right-click an...
[23:00:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15863...
[23:00:49] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) a:3Ed Sanders
[23:04:09] <Krinkle>	 TrevorParscal: .then( other.resolve )
[23:04:27] <Krinkle>	 TrevorParscal: Never ever bind(), call() or apply() anything related to promises
[23:04:32] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399#c6 (10ryasmeen) Verified the fix in test2 with iOS
[23:04:36] <Krinkle>	 Either breaks stuff or does absolutely nothing. 
[23:04:46] <Krinkle>	 They are all detacheable and pre-bound
[23:05:14] <Krinkle>	 just like setTimeout( deferred.resolve )
[23:05:32] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c13 (10ryasmeen) Verified the fix in test2
[23:06:07] <TrevorParscal>	 right, i forget that, so then( other.resolve, other.reject ) then?
[23:07:23] <TrevorParscal>	 also, I need to use bind for resolve because it bundles an argument, I guess I could just make a function instead
[23:07:23] <Krinkle>	 TrevorParscal: Well, yeah but that looks wrong
[23:07:40] <TrevorParscal>	 but I need both to pass through
[23:07:42] <Krinkle>	 TrevorParscal: Why would you need both? What is the return value?
[23:07:43] <TrevorParscal>	 not just one
[23:07:44] <TrevorParscal>	 I'm actually using both
[23:07:45] <Krinkle>	 pass what
[23:07:50] <Krinkle>	 to what
[23:08:01] <Krinkle>	 the caller of the deferred that you call .then() on will have the error already
[23:08:17] <Krinkle>	 Also, then( other.resolve ) will not chain it, it merely invokes it
[23:08:22] <Krinkle>	 the parent won't wait for it
[23:08:47] <Krinkle>	 I'd need to see the bigger picture though
[23:09:30] <TrevorParscal>	 it's like this: you call getWindow, and it returns a promise that is resolved with the window object (now ready to use) or rejected with an error - but it internally may need to use addWindow which returns a promise thats resolved when it's added or rejected if there was a problem
[23:10:05] <TrevorParscal>	 in any case, it is working, you can review it in a bit
[23:12:16] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c7 (10Krinkle) We now have the polyfill for Function.prototype.bind provided by MediaWiki so this should be easier to do now. Simply replace all uses of $.proxy(fn..) and ve.bind(fn)...
[23:13:51] <grrrit-wm1>	 (03PS1) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 
[23:13:55] <grrrit-wm1>	 (03PS1) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 
[23:14:01] <grrrit-wm1>	 (03PS1) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 
[23:15:05] <grrrit-wm1>	 (03PS1) 10Jforrester: Update VE core submodule to master (c81a3f3) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144609 
[23:18:32] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418#c3 (10ryasmeen) Verified the fix in test2
[23:19:56] <grrrit-wm1>	 (03CR) 10jenkins-bot: [V: 04-1] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester)
[23:25:33] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637#c1 (10ryasmeen) Another case to get such issue could be:   If you delete the c...
[23:29:12] <grrrit-wm1>	 (03CR) 10Jforrester: "This passes locally – do we need to do a matching config change in JJBC?" [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester)
[23:31:33] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762 (10James Forrester) a:3Alex Monk
[23:32:04] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor Mobile: Saving a sub page , redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with Mobile VE with desktop safari or iOS safa...
[23:32:17] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: Saving a sub page , redirects it to the parent page which contains a link to it - 10https://bugzilla.wikimedia.org/67639 (10ryasmeen)
[23:39:17] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10ryasmeen)
[23:41:40] <grrrit-wm1>	 (03PS1) 10Krinkle: cleanup: Use local var instead of bind() for inline functions [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 
[23:41:42] <Krinkle>	 TrevorParscal: ^
[23:42:16] <Krinkle>	 I'll change the remaining ones to native .bind() soon per bug 62762
[23:42:21] <Krinkle>	 But wanted to get these out of the way first
[23:42:58] <grrrit-wm1>	 (03PS2) 10Krinkle: cleanup: Use local var instead of bind() for inline functions [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 
[23:51:31] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: jQuery and mediaWiki globals should be used through closures, not directly through $ and mw - 10https://bugzilla.wikimedia.org/48885#c2 (10Krinkle) I suggest for standalone we introduce an module-intro/outro that is used to wrap around individual modules (not pe...