[00:02:18] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c8 (10ryasmeen) Verified the fix in test2 [00:16:04] 3VisualEditor / 3Technical Debt: VisualEditor: Main application namespace should be capitalised and not 2 characters short (ve -> VisualEditor) - 10https://bugzilla.wikimedia.org/67642 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Let's rename our global namespace to something longer than 2 characters... [00:17:33] 3VisualEditor / 3Technical Debt: VisualEditor: Main application namespace should be capitalised and not 2 characters short (ve -> VisualEditor) - 10https://bugzilla.wikimedia.org/67642 (10Krinkle) [00:17:33] 3VisualEditor / 3Technical Debt: VisualEditor: Load visualeditor modules in a closure mapping $/mw/ve to their globals - 10https://bugzilla.wikimedia.org/48885#c3 (10Krinkle) Rephrasing bug. Problems: * We're repeatedly referencing $/mw from global scope instead of securing the reference. This is worse fo... [00:19:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: The MWCategoryWidget::onLookupI nputKeyDown handler is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700 (10Krinkle) [00:19:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupIn putKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700 (10Krinkle) [00:23:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c10 (10ryasmeen) Verified the fix in test2 [00:25:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: References/images require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c10 (10ryasmeen) Verified the fix in test2 [00:37:40] (03PS2) 10Krinkle: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 [00:37:50] (03CR) 10Krinkle: "Rebased to resolve conflict with concat-sourcemaps" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [00:38:33] (03CR) 10jenkins-bot: [V: 04-1] build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [00:46:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389#c1 (10ryasmeen) 5ASSI>3RESO/FIX This is not happening anymore,Checked... [00:50:41] (03PS3) 10Krinkle: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 [01:03:25] (03CR) 10Krinkle: "I'm suspicious because the logic '!can(create) && !page.exists' may not be conclusive for this case. Having it be a reflection of a method" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [01:12:49] TrevorParscal: hey, could i run something by you now? https://gerrit.wikimedia.org/r/#/c/141259/ ;) [04:37:10] (03PS1) 10Mooeypoo: Deprecate 'live' event in favor of 'setup' and 'teardown' in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144634 (https://bugzilla.wikimedia.org/55505) [05:33:51] 3VisualEditor: VisualEditor: Removing comments from TemplateData still show up in VisualEditor - 10https://bugzilla.wikimedia.org/67657 (10Keegan Peterzell) 3NEW p:3Unprio s:3normal a:3None Copied from my Russian Wikipedia talk page: https://ru.wikipedia.org/wiki/%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0... [05:34:18] 3VisualEditor: VisualEditor: Removed comments from TemplateData still show up in VisualEditor - 10https://bugzilla.wikimedia.org/67657 (10Keegan Peterzell) [05:42:09] (03PS1) 10Mooeypoo: Apply 'original size' to images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144637 (https://bugzilla.wikimedia.org/66863) [05:45:14] (03PS1) 10Mooeypoo: Apply 'original size' to images and enable apply button in ve-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144638 (https://bugzilla.wikimedia.org/66863) [05:47:00] (03CR) 10jenkins-bot: [V: 04-1] Apply 'original size' to images and enable apply button in ve-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144638 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [05:51:04] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateData should have a parameter to support Wikidata - 10https://bugzilla.wikimedia.org/67659 (10Keegan Peterzell) 3NEW p:3Unprio s:3enhanc a:3None TemplateData should have a -parameter for linking to Wikidata, and then pull information from th... [07:51:36] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [09:33:19] (03CR) 10Esanders: cleanup: Use local var instead of bind() for inline functions (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 (owner: 10Krinkle) [11:26:47] hi [11:26:54] can we create tables in VE? [11:37:53] Juandev: nope :( [13:12:19] (03PS11) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [13:49:23] (03PS12) 10Vikassy: [BrowserTests]WIP Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [13:50:19] (03PS13) 10Vikassy: WIP [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [16:08:19] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [17:19:53] (03PS2) 10Mooeypoo: Apply 'original size' to images and enable apply button in ve-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144638 (https://bugzilla.wikimedia.org/66863) [17:21:49] Krenair: I've put a 'debugger' statement in jquery.js locally on the line above "if (selector) { ..}else{ handlers.push( handleObj); " [17:22:05] Then in the developer tools, using the Closure inspector to see the local variables without a console.log [17:23:09] Krinkle / Krenair my console log when attempting to update git-review: http://pastebin.com/YbHq5hbt [17:23:34] "DistributionNotFound" :\ ? [17:24:17] mooeypoo: Did you install git-review via pip originally? [17:24:21] Maybe update itself first [17:24:22] Krinkle, yeah, I know [17:24:28] https://www.mediawiki.org/wiki/Gerrit/git-review#Debian [17:24:38] uhm... I updated through what the docs say.. I don't remember, let me see [17:24:51] easy_install etc. [17:25:01] iirc yes [17:25:39] I definitely didn't install it via apt-get, I remember reading that notice [17:26:08] I basically followed the instructions on that page, so easy_install pip etc [17:26:41] (03PS3) 10Krinkle: cleanup: Use local var instead of bind() for inline functions [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 [17:26:46] Should I try turning it off and on again? [17:27:03] (03CR) 10Krinkle: cleanup: Use local var instead of bind() for inline functions (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 (owner: 10Krinkle) [17:27:24] mooeypoo: Did you try opening a new shell window? Maybe PATH changes slightly [17:27:33] e.g. it's not visible in the current bin baths [17:27:37] ahh, no [17:27:39] but maybe pip added a new one [17:27:47] instead of overwriting it [17:27:49] 3MediaWiki extensions / 3TemplateData: TemplateData: When several templates have identical parameters, it should be possible to place TemplateData in a template and transclude it onto the template's documentation - 10https://bugzilla.wikimedia.org/67677 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3No... [17:28:04] mooeypoo: see what 'which git-review' returns in that shell and a new one [17:29:19] oh.. foo, I closed the old shell, but I had one from before (wit parsoid running) -- they seem to have the same response to that [17:29:29] /usr/local/bin/git-review [17:30:29] mooeypoo: do you know where pip put it? [17:30:43] Maybe the one in local/bin is shadowing the one from pip [17:30:47] a manual install perhaps [17:31:14] Krinkle, I have no clue O.O [17:31:31] (03CR) 10Esanders: [C: 032] cleanup: Use local var instead of bind() for inline functions [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 (owner: 10Krinkle) [17:31:54] Krinkle, I'm running a search for 'git-review' though... i'll see if it exists anywhere else [17:32:18] (03Merged) 10jenkins-bot: cleanup: Use local var instead of bind() for inline functions [oojs/ui] - 10https://gerrit.wikimedia.org/r/144619 (owner: 10Krinkle) [17:32:49] mooeypoo: Hm.. I'd rename the one in bin/git-review and see if 'which' finds another :) [17:32:59] but mostly because I suck at 'find' [17:33:18] Ha. [17:33:27] We'll see how good I am at find.... [17:33:44] According to https://git.openstack.org/cgit/openstack-infra/git-review/log/?ofs=50 the first patch in git review 1.24 (the new version)… is to no longer check for new versions. :-) [17:33:56] ha [17:34:03] lol [17:34:26] Also, helpful lack-of-changelog-Batman. [17:34:58] well. I'm either awesomely incredible at "find" or I suck royally, because it's taking forever. [17:35:18] 3MediaWiki extensions / 3TemplateData: TemplateData: Provide information about preferred formatting of transclusions - 10https://bugzilla.wikimedia.org/62217#c2 (10WhatamIdoing) *** Bug 63813 has been marked as a duplicate of this bug. *** [17:35:19] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to express whether they should be laid out inline or with each parameter on its own line in wikitext - 10https://bugzilla.wikimedia.org/63813#c2 (10WhatamIdoing) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 62217... [17:35:53] https://git.openstack.org/cgit/openstack-infra/git-review/log/?qt=range&q=fed8751db7...28104e4ecd&ofs=50 is the more specific link. [17:41:34] Krinkle, what do you think of https://bugzilla.wikimedia.org/show_bug.cgi?id=56700#c1 ? [17:48:01] mooeypoo: so, lets talk about the status of mediadialog [17:51:42] TrevorParscal, ok [17:52:03] TrevorParscal, it's feeling pretty good, minus a patch that's awaiting merge [17:52:17] i see 3 patches that may be related [17:52:36] maybe just 2 [17:52:40] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/144637/ and https://gerrit.wikimedia.org/r/#/c/144638/ [17:52:45] those two are bug fixes [17:52:53] right [17:52:55] those two only [17:52:56] well, it's the same bug fix, only one in core and one in mw [17:52:57] right? [17:52:59] yep [17:53:28] (03CR) 10Trevor Parscal: [C: 032] Apply 'original size' to images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144637 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [17:53:31] \o/ [17:53:35] (03CR) 10Trevor Parscal: [C: 032] Apply 'original size' to images and enable apply button in ve-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144638 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [17:53:39] Woo. [17:53:42] woohoo [17:53:45] those looked great [17:53:51] ok, so a couple questions [17:54:47] are you using this.mediaNode instead of the supplied this.selectedNode (since it inherits NodeDialog, we already populate that property for you) because of historic reasons and it should be cleaned up? or is that intentional? [17:55:19] (03Merged) 10jenkins-bot: Apply 'original size' to images and enable apply button in ve-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144638 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [17:55:31] (03Merged) 10jenkins-bot: Apply 'original size' to images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144637 (https://bugzilla.wikimedia.org/66863) (owner: 10Mooeypoo) [17:55:55] TrevorParscal, this.mediaNode *is* this.selectedNode() [17:56:02] line #603 this.mediaNode = this.getSelectedNode(); [17:56:03] it looks like you only set it in setup, in fact you don't release it in teardown (oops!) but again, you can just use selectedNode instead, it's set in an earlier phase of the setup process for you by NodeDialog [17:56:31] I didn't realize there's a this.selectedNode, I thought since it's getSelectedNode() I could cache it with this.mediaNode [17:56:36] instead of calling it over and over [17:56:42] and yes, I forgot to release it in teardown. Oops. [17:56:57] we added this to NodeDialog because it was done over and over everywhere, with different names [17:57:16] centralizing it in NodeDialog was an easy way to reduce code and make things look more familiar [17:57:19] ok, so that seems fine [17:57:39] I will clean that up [17:57:59] TrevorParscal, are you talking about the function getSelectedNode() or is there a cached property this.selectedNode ? [17:58:09] there's a cached property [17:58:17] I recently changed it as per Roan pointing out there's a this.getSelectedNode() so I didn't realize there's a property [17:58:20] it can definitely change [17:58:30] it's ok, I just fixed it [17:58:34] awesomesauce [17:58:42] I just didn't want to step into trouble there, if there was a good reason [17:59:02] I use it to check if we're editing a node or adding one, that's why I figured I'd cache it throughout, but yeah, if it already exists, that's fine [18:08:34] (03PS2) 10Jforrester: Update VE core submodule to master (7af9774) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144609 [18:08:46] mooeypoo: ^^^ +2 that? [18:20:02] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863 (10James Forrester) 5PATC>3RESO/FIX [18:20:19] (03CR) 10Mooeypoo: [C: 032] Update VE core submodule to master (7af9774) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144609 (owner: 10Jforrester) [18:22:17] (03Merged) 10jenkins-bot: Update VE core submodule to master (7af9774) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144609 (owner: 10Jforrester) [18:23:43] mooeypoo: Thanks! [18:53:33] media dialog done, moving on to save now [18:53:41] * TrevorParscal braces himself for utter chaos [18:54:57] TrevorParscal: :-D [18:57:28] TrevorParscal: I'm sure it's worse than you fear. [19:13:25] TrevorParscal, I am torn between witty responses. A third of me wants to ask if you're only NOW saving the media dialog, another third wonders if you have a cape to save us all, and the third part wonders what the hell happened to my wittiness that it's so lame. [19:13:51] the good news is, the save dialog wasn't scary [19:13:59] sorry, the media dialog I mean [19:14:05] the save dialog is sent from hell to murder us [19:14:20] poor alex has been saddled with wrangling satan [19:24:27] Krenair: ok, your turn [19:24:37] so, why do we always dismiss errors in the save dialog? [19:24:43] like, immediately [19:25:11] ... We do? [19:26:11] see ve.ui.MWSaveDialog.prototype.onApplyChangesFail [19:26:15] this.dismissErrors [19:26:28] so, basically we never show the error screen? [19:27:07] That sounds wrong. [19:27:15] uhh... Hm. [19:28:08] TrevorParscal, I don't know, that doesn't make sense. [19:28:12] I realize this file is full of pure evil, just was wondering if I found something wrong or there was intent to that [19:28:14] no worries [19:31:42] Looks like I added it in PS9 of https://gerrit.wikimedia.org/r/#/c/135945/9 [19:32:14] Krenair: Maybe you did it as a debugging step and no-one noticed? [19:33:48] Anyway, removing it seems sensible. [19:35:50] I put it in showSaveError in ViewPageTarget in PS3 [19:36:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Can't tab to save form dialog buttons in Firefox - 10https://bugzilla.wikimedia.org/65554#c6 (10James Forrester) *** Bug 67153 has been marked as a duplicate of this bug. *** [19:36:03] 3VisualEditor: VisualEditor: Tab order or behavior is bad in the Save dialog - 10https://bugzilla.wikimedia.org/67153#c3 (10James Forrester) 5NEW>3RESO/DUP I think this is a dupe of bug 65554, which is now fixed. *** This bug has been marked as a duplicate of bug 65554 *** [19:36:06] 3VisualEditor / 3Editing Tools: VisualEditor: Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE which has an... [19:36:31] So I think it was supposed to dismiss any existing errors then show the new ones: https://gerrit.wikimedia.org/r/#/c/135945/3/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js [19:37:03] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk Krenair, is this something that we do as part of the aria-role stuff (and is it something we sh... [19:37:49] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender [19:41:02] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:41:09] Krenair: also, why are the save options not working, as in the word count and checkboxes... ? [19:41:13] they are missing [19:41:21] on both my copy, and production [19:43:48] TrevorParscal: Are you logged out? [19:43:51] TrevorParscal: :-) [19:44:02] Isn't that stuff decided by EditPage..? [19:44:15] I'm pretty sure you need to be logged in to get the ability to mark edits as minor or watch changes. [19:44:25] watch pages* [19:44:26] Krenair: Worry not; TrevorParscal always tests logged out and he's probably forgotten that MW requires you… yeah. [19:45:05] ok, that was why [19:45:10] :-D [19:45:12] also, I guess we dropped the counter? [19:45:23] i wasn't paying attention I suppose [19:46:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684#c1 (10ryasmeen) It also happens when you reopen an image which was previously has been set... [19:47:02] hmm TrevorParscal style-wise, is there anything wrong with me emitting some "statusChange" event when things change in the media size widget, kinda like the toolbar's general "updateState" ? [19:47:38] that way I can have changes tracked without caring what change it is specifically.. but it means multiple methods emit the same event. [19:47:47] TrevorParscal, I guess, it's display:none... [19:48:17] ok, I'm done, I think - the last thing I need to do is verify my error handling is working [19:48:26] what do you usually do to mimic errors? [19:52:30] TrevorParscal, not sure what I was doing before, you should be able to just emit the right event from ve.init.mw.Target.onSave [19:52:47] TrevorParscal: Block yourself (for absolute test), or trigger a CAPTCHA (for respondable test). [19:53:13] I think I just deliberately made the errors happen, e.g. by blocking, trigger captcha, or whatever [19:53:37] i was hoping for something easier... lol [19:53:39] ok [19:54:33] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.x (not 6.0.x or 7.x) - 10https://bugzilla.wikimedia.org/64388#c22 (10James Forrester) 5VERI>3REOP p:5Unprio>3Low (In reply to Bryce Glover from comment #21) > I'm still seeing this bug with Safari 6.1.4, guys; maybe it's more serious... [19:54:47] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.x (not 6.0.x or 7.x) - 10https://bugzilla.wikimedia.org/64388 (10James Forrester) 5REOP>3ASSI [19:56:51] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE which has image inside it 2.Open the... [19:58:03] ok, i found something in jquery that seems pretty evil [19:58:11] TrevorParscal: This is news? ;-) [20:00:00] Krinkle: hey, I found a problem in jQuery [20:00:20] Okay, tell me :) [20:00:25] look for getStyles = function( elem ) { in the uncompressed source [20:00:40] the next line, return elem.ownerDocument.defaultView.getComputedStyle( elem, null );" [20:00:42] Krenair: I think the only way that screenshot makes sense (short of setting .length manually) is a race condition. [20:00:50] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684 (10James Forrester) [20:00:51] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender [20:00:51] Krenair: Call .slice() on the array in the log call [20:01:02] Krenair: The log viewer evaluates the array reference [20:01:11] (03PS14) 10Vikassy: WIP [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [20:01:11] in some cases, ownerDocument.defaultView is undefined [20:01:27] TrevorParscal: consistently across browsers? [20:01:54] https://developer.mozilla.org/en-US/docs/Web/API/document.defaultView [20:02:01] I'm getting undefined in Chrome [20:02:07] according to MDN it's allowed to be null [20:02:18] TrevorParscal: Detached documents presumably [20:02:29] Right? [20:02:37] Not just randomly on a regular document or attached iframed [20:02:47] Can you reproduce that result on your machine? [20:02:55] yeah [20:03:12] Krenair: I can't reproduce the bug in general as I forgot where it happened exactly. [20:03:13] it's probably a detached iframe, I will look at it a bit more to verify the situation [20:04:04] TrevorParscal: I reckon it's a similar case as what we ran into when upgrading jQuery last time. It's a browser bug / jQuery bug, but one that doesn't really make sense to mask in a silent failure because we're probably doing something wrong on our end (e..g relying on styles where there can't be any styles yet) [20:04:17] probably some code that should be separated further to get the styles at the right time [20:04:31] so exposes a bug in our code, but through an error triggered by jQuery [20:04:46] console.log( handlers.slice() ); [20:04:59] Krenair: Can you reproduce the emptiness when calling slice() [20:05:03] in fact, this particular case is triggered because I'm using .width() as a way to force reflow (since it has to measure) [20:05:18] but doing so on content within a detached document is aparently broken [20:05:27] There is nothing to reflow.. [20:05:43] but jQuery probably shouldn't explode in this case [20:06:19] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk [20:06:21] 3VisualEditor / 3Editing Tools: VisualEditor: While inserting an image for the first time, the label for the button in Media Settings dialog should be "Insert" instead of "Apply Changes" - 10https://bugzilla.wikimedia.org/67688 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Right now while inserting a... [20:06:35] it should do the same thing it does when you measure the width of something hidden using display:none [20:06:44] TrevorParscal: Well, discuss. The alternative is changing the contract on the method signature and allow it to return null instead of a number. Thus technically forcing all users everywhere to account for it being null. [20:06:46] you could argue that in that case, as well, there's nothing to measure [20:06:47] 3VisualEditor / 3Editing Tools: VisualEditor: Tab order is bad in the Template dialog - 10https://bugzilla.wikimedia.org/67159#c1 (10James Forrester) 5NEW>3RESO/DUP I'm pretty sure this was done as part of bug 66824. *** This bug has been marked as a duplicate of bug 66824 *** [20:06:47] 3VisualEditor / 3Editing Tools: VisualEditor: Fix tabindexes in the citation dialog - 10https://bugzilla.wikimedia.org/66824#c8 (10James Forrester) *** Bug 67159 has been marked as a duplicate of this bug. *** [20:07:00] Instead of assuming it and making you responsible for not calling it when it doesn't work. [20:07:27] James_F, TrevorParscal I just realized... should I work on bug fixes in media dialog or wait for the window thing to be merged? [20:07:30] probably smarter to wait [20:07:52] wait just a bit, i'm about to start writing commit messages [20:07:53] mooeypoo: Wait sounds good. [20:07:57] TrevorParscal: Woo. [20:07:59] * mooeypoo nods [20:08:16] Krinkle: seriously, return 0 if defaultView is falsey, that's all it should do [20:08:28] it does so when the element is hidden for all other reasons [20:08:30] TrevorParscal: How is that useful to you? [20:08:34] there's no break in the contract [20:09:07] TrevorParscal: I agree that'd be typical and not unusual to have as tech debt [20:09:08] how is it useful to get 0 width when an element is hidden? They do that already. I'm just saying stick with user expectations. [20:09:34] but I think it's unreasonable for code to exist like that in the long run. It's a waste of computation and sign of lack of separation that we call width() in a detached document. [20:10:05] Whatever code thinks it needs that, probably shouldn't run in the first place [20:10:54] Pre-initialising it with 0 wouldn't be helpful either as it will have to recompute once attached, and the previous compuation would be of no use. [20:11:10] in this case, it appears that we are detaching the dialogs, then closing them (wrong order) but my point is simply that jquery should return 0 because the element is hidden, just as if it were hidden using any other method of hiding it [20:11:39] So in a way I'm glad this bug is offering us a way to find those cases where we're calling it when we don't need to. The hard failure is annoying, definitely. [20:11:51] this is the same exact behavior with display:none [20:12:13] TrevorParscal: No, display:none is a valid value and stylesheets do apply ('none' is also a value) [20:12:25] but when it is detached, there is no cascading going on. [20:12:41] How would it even know (inside getStyles) that width returns a number, or '... px' or 'auto'? [20:12:48] It wouldn't know what the initial value of a property should be [20:13:36] invisible rendering is not the same as no rendering. font-family still applies for example. And lots of other thing are inherited and available. [20:13:39] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [20:13:39] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10James Forrester) [20:13:39] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67689 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None We currently don't. We should. [20:13:39] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10James Forrester) [20:13:40] even if they're just defaults. [20:13:40] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None We currently don't. We should. [20:13:41] 3VisualEditor: VisualEditor: Tracking bugs for VisualEditor (tracking) - 10https://bugzilla.wikimedia.org/54363 (10James Forrester) [20:13:46] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) p:5Unprio>3Low [20:13:48] (03PS1) 10Vikassy: [BrowserTest]Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) [20:14:18] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) [20:14:19] 3VisualEditor / 3Editing Tools: VisualEditor: While inserting an image for the first time, the label for the button in Media Settings dialog should be "Insert {image|animation|audio|vide o}" instead of "Apply Changes" - 10https://bugzilla.wikimedia.org/67688#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>... [20:16:02] 3VisualEditor / 3Data Model: VisualEditor: Adding an image at the top of a list puts the image inside the list; instead it should insert it in the previous position (in the

) - 10https://bugzilla.wikimedia.org/55767 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [20:17:33] 3VisualEditor / 3Editing Tools: VisualEditor: Image size is shrinking to a dot size after exceeding a specific value while setting the image size - 10https://bugzilla.wikimedia.org/61282#c13 (10James Forrester) 5ASSI>3RESO/FIX This looks like it's now fixed, I think. [20:19:16] 3VisualEditor / 3Editing Tools: VisualEditor: DpmAdding anything inside the media settings of an image which is already inside an image makes the wikitext for the image appear in the readmode - 10https://bugzilla.wikimedia.org/61564 (10James Forrester) [20:19:47] 3VisualEditor / 3Editing Tools: VisualEditor: Don't allow users to insert images inside images' captions inside images' captions, as MediaWiki can't cope with that - 10https://bugzilla.wikimedia.org/61564 (10James Forrester) [20:20:09] how jquery solves it's problems doesn't concern me, I'm just saying, when jquery explodes like that, it's like NaNpx all over again, jquery shouldn't explode because it made too many assumptions about it's inputs [20:20:20] 3VisualEditor / 3ContentEditable: VisualEditor: Image resizing handlers appear on all four corners (not just one / two) if image is in another image's caption editor - 10https://bugzilla.wikimedia.org/61968#c2 (10James Forrester) *** Bug 62283 has been marked as a duplicate of this bug. *** [20:20:20] 3VisualEditor / 3Editing Tools: VisualEditor: Too many draggable image resizing handlers for frameless, frame, and basic images (thumbnails working as intended) - 10https://bugzilla.wikimedia.org/62283#c2 (10James Forrester) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 61968 *** [20:20:42] TrevorParscal: *its. [20:21:43] indeed [20:21:48] 3VisualEditor / 3ContentEditable: VisualEditor: Image resizing handlers appear on all four corners (not just one / two) if image is in another image's caption editor - 10https://bugzilla.wikimedia.org/61968#c3 (10James Forrester) 5ASSI>3RESO/FIX This appears to now be fixed. [20:22:17] TrevorParscal: How're those edit summaries coming? [20:22:43] i had to eat a sandwich and argue with someone on the internet, what do you think? :) [20:23:47] 3VisualEditor / 3ContentEditable: VisualEditor: Backwards cursoring of an image inside an image's caption selects the sub-image, not the main image (and then breaks nastily) - 10https://bugzilla.wikimedia.org/62395 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5minor>3major [20:23:47] 3VisualEditor / 3Editing Tools: VisualEditor: Support media (tracking) - 10https://bugzilla.wikimedia.org/37870 (10James Forrester) [20:25:51] 3VisualEditor / 3ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c6 (10James Forrester) 5ASSI>3RESO/FIX This now appears to be working fine? [20:27:33] 3VisualEditor / 3ContentEditable: VisualEditor: Image flickers but shield stays in the correct position while dragging the page on Mac - 10https://bugzilla.wikimedia.org/62898#c2 (10James Forrester) 5ASSI>3RESO/FIX I think this is now working. [20:28:04] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67689#c1 (10James Forrester) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 67690 *** [20:28:04] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690#c1 (10James Forrester) *** Bug 67689 has been marked as a duplicate of this bug. *** [20:30:06] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set a multimedia item's start position (start=) in the media dialog - 10https://bugzilla.wikimedia.org/62675 (10James Forrester) [20:30:06] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set a non-image multi-paged item's display page (page=) in the media dialog - 10https://bugzilla.wikimedia.org/62673 (10James Forrester) [20:30:06] 3VisualEditor / 3ContentEditable: VisualEditor: Make CE-surface fixes to make TMH's media items display correctly - 10https://bugzilla.wikimedia.org/62678 (10James Forrester) [20:30:06] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set a multimedia item to not show an icon (noicon) in the media dialog - 10https://bugzilla.wikimedia.org/62674 (10James Forrester) [20:30:07] 3VisualEditor / 3Editing Tools: VisualEditor: Support non-image media (tracking) - 10https://bugzilla.wikimedia.org/67690 (10James Forrester) [20:30:08] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set a multimedia item's thumb position (thumbtime=) in the media dialog - 10https://bugzilla.wikimedia.org/62676 (10James Forrester) [21:12:58] Krinkle, so for https://bugzilla.wikimedia.org/show_bug.cgi?id=62762#c4 we simply want something like this? [21:13:02] function ( func ) { return func.bind.apply( func, Array.prototype.slice.call( arguments, 1 ) ); }; [21:13:11] Or am I missing something big here? [21:18:51] Krinkle, also, in reply to your earlier message (sorry I forgot about that): I get the expected result from handlers.slice() [21:26:47] Krenair: expected as in, empty array, or non-empty as it should be? [21:27:08] Krenair: No, we want to rid $.proxy usage, and remove ve.bind [21:27:13] and use .bind natively. Just like we do with other ES5 methods [21:35:53] Krinkle, non-empty, has the element I was expecting [21:36:00] cool [21:36:18] Krinkle, "But keeping ve.bind with a small wrapper to bind using bind seems fine for backwards compatibility with ve plugins in the wild. " [21:37:52] Right [21:38:14] Id rather have it stick to $.proxy though [21:38:17] that's more back-compat ish [21:38:22] and shorter [21:38:25] and actually faster. [21:38:31] Turns out bind/apply is quite slow for some reason. [21:41:33] 3VisualEditor / 3ContentEditable: VisualEditor: Image flickers but shield stays in the correct position while dragging the page on Mac - 10https://bugzilla.wikimedia.org/62898#c3 (10ryasmeen) 5RESO/?>3VERI Yes, this is not happening anymore [21:52:01] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677#c1 (10Makyen) You can use templates to translude portions of the TemplateData JSON object.... [21:54:17] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677#c2 (10Makyen) I failed to remove the wikitext from the {{#tag}} example. It should have be... [22:00:26] Hello [22:00:40] hey [22:00:58] Might it be acceptable if CTRL+LEFT/RIGHT doesn't advance properly over a unicorn? [22:04:25] divec_: Eww. [22:04:45] divec_: So Alt+Left/Right on Mac [22:05:24] As in word selection, so if you're at: BOLD BOLD BOLDnotbold notbold [22:05:50] then Ctrl+Right (Or is it Alt+Right) should jump just to the end of the first "notbold" (because that's the first "word boundary") [22:06:11] Oh, hmm. Yeah, that seems fine. [22:06:23] What about end-of-line – would it interfere or is it seen as inline? [22:06:33] However, the native behaviour hits the unicorn and stops. I can then remove the unicorn but fixing up is tricky, because in general the browser definition of "word boundary" is not easy to calculate [22:06:47] End of line, what a good question. Hmmm. I'll have a look. [22:07:21] * James_F is filled with good questions. :-) [22:07:32] This behaviour ... let's call it "when I have just inserted annotated bold and then do word-by-word keyboard selection, there's an extra boundary at the edge of the bold" ... [22:07:57] may be inherently unavoidable with our current approach. I'd like to think that's enough of an edge case that we could live with it if necessary. [22:08:13] Sound reasonable? [22:10:11] James_F: if so I can get my head down and try to fix my unicorn-jumping calculations :-) [22:11:24] divec_: Sounds reasonable, yes. :-) [22:11:36] Cool ... thanks :-) [22:24:24] hey TrevorParscal - I went ahead and scheduled/announced the meeting for this Thursday to go over the new & more detailed skin proposal RfC [22:24:34] i saw [22:24:51] TrevorParscal: per our conversation yesterday - but of course I should have checked with you first [22:27:32] TrevorParscal: Thurs ok? [22:27:45] fine, i hope to make progress on the RFC tomorrow [22:27:48] today is looking bleak [22:28:09] TrevorParscal: ok. you'll have Wed and a chunk of Thurs [22:28:25] "Trevor, Roan, Timo, Kaldari" - you do have a few other people who are also supposed to help you with this, right? :) [22:35:21] (03PS1) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [22:35:44] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [22:37:38] (03PS4) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [22:37:40] (03PS2) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [22:39:51] (03PS3) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [22:40:59] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [22:44:31] Krenair: I think it just doesn't like you. :-) [22:44:52] I was fiddling with rebases for the first three [22:44:57] * James_F nods. [22:47:59] 22:40:43 TypeError: 'undefined' is not a function (evaluating 'mw.msg.bind(mw)') TypeError: 'undefined' is not a function (evaluating 'mw.msg.bind(mw)') [22:48:16] Hmm... [22:50:18] I don't quite understand that one [22:50:49] mw.msg should definitely be defined if mw is, right...? Krinkle? [22:52:40] Krenair: yes [22:52:55] 22:40:43 TypeError: 'undefined' is not a function (evaluating 'mw.msg.bind(mw)') TypeError: 'undefined' is not a function (evaluating 'mw.msg.bind(mw)') [22:55:16] Krenair: that's saying that mw.msg.bind is undefined, and nothing about mw.msg [22:55:34] what's mw.msg when that error happens? [22:55:38] if mw.msg is a function, .bind should be defined shouldn't it..? [22:57:18] it should definitely exist and it should definitely be a function, if it isn't, then something's probably overriding it… [22:57:33] 3VisualEditor / 3ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c7 (10ryasmeen) Created attachment 15871 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15871&action=edit Scree... [22:58:02] 3VisualEditor / 3ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c8 (10ryasmeen) bug* not bag :| [23:02:34] MatmaRex: Krenair: Where do you get this error? [23:02:42] Krenair: It likely means bind itself isn't available [23:02:58] Krenair: If this is ve-mw, be sure to ahdd Function#bind to the init.init check [23:03:00] add* [23:03:19] Old browsers dont support bind, including PhantomJS [23:03:24] hence es5-shim [23:05:48] 3VisualEditor / 3ContentEditable: VisualEditor: Image resizing handlers appear on all four corners (not just one / two) if image is in another image's caption editor - 10https://bugzilla.wikimedia.org/61968#c4 (10ryasmeen) 5RESO/?>3VERI yes, now it is fixed. [23:27:23] Krinkle, this was https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/10474/consoleFull [23:27:34] 3VisualEditor / 3Mobile: VisualEditor Mobile: Insert reference option is missing in the toolbar for mobile VE for in both experimental and Beta mode - 10https://bugzilla.wikimedia.org/67701 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None I don't see the option to add Cite/References in Mobile Ve anymo... [23:28:25] Krenair: Right [23:28:33] Krinkle: I have mixed feelings about the local var thing - i hate the way it looks as a programmer, but I realize it has performance benefits [23:28:38] but they seem to micro [23:28:46] TrevorParscal: How's the commit-summary writing going? [23:28:53] Krenair: Make sure that 1) init.init tests .bind(), 2) init.init itself does not use .bind(), 3) oojs and es5-shim are loaded. [23:28:54] Ah, rebasing again? [23:28:58] James_F: rebasing [23:29:10] TrevorParscal: And then we're done? [23:29:27] yeah, ended up spending a couple of hours doing API cleanup [23:29:31] but things work [23:29:33] Fun. [23:29:38] TrevorParscal: I'd argue for the opposite that .bind() for local closures look like a hack. They make code a lot look worse as a programmer. [23:29:39] Also, boo. [23:29:49] I could care less about the perf benefits, that's the least important factor for this change [23:30:15] really? because we've systematically been removing local vars over the last year [23:30:31] TrevorParscal: Maybe you have, I have been doing the opposite. [23:30:41] Maybe you two should talk? :-) [23:30:44] well we should probably come up with a standard here [23:31:27] I backed out your changes where they conflicted with mine (only in 3 files) but seriously, we should not be doing things inconsistently no matter what the preference [23:32:18] TrevorParscal: I'm opposing bind() for local closures on the basis that it obfuscates code, makes it harder to understand what 'this' is at any point in time, and it also blows away the original 'this' which means you just lost a variable you might need later on, and because it means you'll have a more logical variable name deeper down (e.g. 'this' is always the current class in the top scope, [23:32:18] and lower down it is always the local function's own 'this') [23:34:00] I imagine it might stem form an icky feeling of how weird javascript is, but I'd suggest we embrace this language feature. [23:36:41] Krinkle, init.init refers to... [23:36:59] The es5 checks in ViewPageTarget.init? [23:37:05] Krenair: Sublime, ve-mw, cmd+P, initinit. [23:37:08] you'll find only one file :) [23:37:23] ve.init.mw.ViewPageTarget.init [23:37:26] Yeah [23:42:20] Krinkle: ok, I re-applied the spirit of your change to my new code [23:43:26] so, now OOUI has no use of OO.ui.bind( function [23:44:48] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] Cite menu is missing in the toolbar for mobile VE for in both alpha and beta modes - 10https://bugzilla.wikimedia.org/67701 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [23:53:21] Krinkle, I suspect es5-shim is just not loaded. [23:57:08] (03PS4) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [23:59:44] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk)