[00:00:40] (03CR) 10Alex Monk: "I guess es5-shim is not being loaded or something." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [00:01:47] 3VisualEditor / 3ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c9 (10James Forrester) (In reply to ryasmeen from comment #7) > Created attachment 15871 [details] > Screenshot > > Ma... [00:03:47] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677#c3 (10James Forrester) (In reply to Makyen from comment #2) > I failed to remove the wikite... [00:09:04] 3VisualEditor / 3Editing Tools: VisualEditor: Making an image Frame-left/Frame-right redraws the highlight beyond CE - 10https://bugzilla.wikimedia.org/67706 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15873 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15873&action=edit... [00:14:16] 3VisualEditor / 3ContentEditable: VisualEditor: Making an image Frame-left/Frame-right redraws the highlight beyond CE - 10https://bugzilla.wikimedia.org/67706 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [00:20:48] 3VisualEditor / 3Editing Tools: VisualEditor: "Make full Size" is not enabling "Apply changes" button therefore cannot make any image fullsize - 10https://bugzilla.wikimedia.org/67624#c1 (10ryasmeen) 5NEW>3RESO/FIX This was the same issue as https://bugzilla.wikimedia.org/show_bug.cgi?id=66863 The follow... [00:21:17] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c14 (10ryasmeen) Verified the fix in Betalabs [00:25:33] 3VisualEditor / 3Editing Tools: VisualEditor: "Make full Size" is not enabling "Apply changes" button therefore cannot make any image fullsize - 10https://bugzilla.wikimedia.org/67624 (10James Forrester) p:5Unprio>3Normal a:3Moriel Schottlender [00:34:37] TrevorParscal: I have a few bugs to tag against your commits when they're ready. [00:34:53] i'm still working [00:34:57] * James_F nods. [00:35:03] Hence why I'm not making it worse for you. [00:35:07] but yeah, getting close of course :) [00:35:10] thanks [00:36:03] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c10 (10James Forrester) a:5Trevor Parscal>3Ed Sanders Based on the work that Ed did, I'm going to mark this as closed. [00:36:32] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709 (10James Forrester) 5ASSI>3RESO/FIX [00:44:32] 3VisualEditor / 3Editing Tools: VisualEditor: Insert media dialog lets you select an image via mouseup even if mousedown occurred elsewhere - 10https://bugzilla.wikimedia.org/56648#c2 (10James Forrester) 5ASSI>3RESO/FIX This was fixed a while ago. [00:46:18] 3OOjs UI: OOjs UI: [Regression] Dialogs don't animate when opening - 10https://bugzilla.wikimedia.org/63905#c1 (10James Forrester) 5ASSI>3RESO/FIX Trevor fixed this in May. [00:48:47] 3VisualEditor / 3ContentEditable: VisualEditor: A straight line appears above the image while making it (Frameless/Basic-Left/Right-border) - 10https://bugzilla.wikimedia.org/64966#c2 (10ryasmeen) 5ASSI>3RESO/FIX This issue is not happening anymore, might got fixed by some changes with image . Marking i... [00:50:18] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677#c4 (10Helder) (In reply to James Forrester from comment #3) > ... > and won't survive the c... [01:47:49] (03PS16) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [01:48:11] (03PS6) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (72c9152f82) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [01:48:18] (03PS6) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [01:48:30] (03PS1) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [01:48:44] Woo [01:48:51] Still WIP? [01:49:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [01:51:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [01:51:39] (03PS7) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [01:51:43] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (72c9152f82) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [01:53:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [01:54:44] (03PS2) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [01:55:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [01:57:31] (03PS8) 10Trevor Parscal: [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [01:57:47] (03PS3) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [01:58:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [01:58:32] James_F: I'm calling it a night, everything is working, tests are passing, etc. [01:58:41] I didn't get to the commit messages, but I'm done coding [01:58:58] TrevorParscal: Want to un-WIP them so you get actual reviews overnight? [01:59:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [01:59:15] TrevorParscal: Otherwise edsanders|away and Krinkle|detached will probably just ignore them… [01:59:33] Sure, of course I expect commit messages will be a prerequisite for actual merging [01:59:37] I will send an email [01:59:43] Cool. [02:00:25] TrevorParscal: Presumably https://gerrit.wikimedia.org/r/#/c/139550/ is actually good to go (though it'd be a pain)? [02:04:19] * James_F wanders off. [02:04:28] See you tomorrow. [02:07:31] 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to inherit/share TemplateData from/with other templates where multiple templates share identical parameters - 10https://bugzilla.wikimedia.org/67677#c5 (10Richard Morris) I'm not quite sure if this is quite whats wanted but there are alread... [06:00:47] fyi, to anyone thinking of reviewing my code, I'm breaking it up into separate commits (esp. the OOUI stuff) right now [06:23:36] (03PS1) 10Trevor Parscal: Mobile-friendly styling for demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 [06:23:59] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [06:24:17] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [06:24:39] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [06:24:41] (03PS1) 10Trevor Parscal: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 [06:25:00] (03PS1) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [06:25:15] (03PS1) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [06:25:37] (03PS1) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [06:25:53] (03PS1) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [06:26:07] (03PS1) 10Trevor Parscal: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 [06:26:24] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setting of outline item in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [06:26:50] (03PS1) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [06:27:03] (03PS1) 10Trevor Parscal: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 [06:27:11] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 (owner: 10Trevor Parscal) [06:27:20] (03PS1) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [06:27:28] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Separate setup from setting of outline item in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [06:27:44] (03PS1) 10Trevor Parscal: Add blur method to OO.ui.InpuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [06:28:15] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [06:28:21] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [06:28:25] (03PS17) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [06:28:27] (03CR) 10jenkins-bot: [V: 04-1] Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [06:28:29] (03CR) 10jenkins-bot: [V: 04-1] Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [06:28:31] (03CR) 10jenkins-bot: [V: 04-1] Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [06:28:33] (03CR) 10jenkins-bot: [V: 04-1] Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [06:28:35] (03CR) 10jenkins-bot: [V: 04-1] Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [06:28:37] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [06:28:51] (03CR) 10jenkins-bot: [V: 04-1] Add blur method to OO.ui.InpuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [06:30:11] (03PS18) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [06:33:16] (03PS7) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (053e072109) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [06:34:50] (03PS9) 10Trevor Parscal: [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [06:34:52] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (053e072109) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [06:35:09] (03PS4) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [06:36:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [06:37:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [07:33:17] (03PS1) 10Amire80: Rephrase visualeditor-parameter-search-more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 [07:34:24] (03CR) 10jenkins-bot: [V: 04-1] Rephrase visualeditor-parameter-search-more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 (owner: 10Amire80) [07:41:02] 3VisualEditor / 3Editing Tools: Edit link dialog doesn't load target links - 10https://bugzilla.wikimedia.org/67272#c4 (10Elitre) Thank you, this was what we're interested in. I'll provide an example of why I find that odd and preferred to see the target list without any need to click/type. You taught me how... [07:55:47] (03PS2) 10Trevor Parscal: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [07:56:36] (03CR) 10jenkins-bot: [V: 04-1] Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [07:57:00] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [07:58:07] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [08:05:17] (03PS2) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [08:05:26] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [08:05:34] (03PS2) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [08:06:30] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [08:06:37] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [08:06:51] (03PS3) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [08:07:16] (03CR) 10jenkins-bot: [V: 04-1] Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [08:07:21] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [08:07:34] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [08:07:38] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [08:07:50] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [08:07:53] (03PS2) 10Trevor Parscal: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 [08:08:01] (03PS2) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [08:08:08] (03PS2) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [08:08:16] (03PS3) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [08:08:23] (03PS2) 10Trevor Parscal: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 [08:08:51] (03CR) 10jenkins-bot: [V: 04-1] Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [08:08:53] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [08:08:58] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [08:09:01] (03CR) 10jenkins-bot: [V: 04-1] Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [08:09:05] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 (owner: 10Trevor Parscal) [08:09:09] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [08:09:15] (03PS2) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [08:09:19] (03PS3) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [08:09:27] (03PS2) 10Trevor Parscal: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 [08:09:29] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [08:09:37] (03PS2) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [08:09:39] (03CR) 10jenkins-bot: [V: 04-1] Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [08:09:49] (03CR) 10jenkins-bot: [V: 04-1] Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [08:09:51] (03PS3) 10Trevor Parscal: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [08:09:57] (03PS19) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [08:10:25] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [08:11:36] (03CR) 10jenkins-bot: [V: 04-1] Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [08:11:47] (03CR) 10jenkins-bot: [V: 04-1] Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [08:12:35] (03PS20) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [08:16:50] (03PS2) 10Zfilipin: [BrowserTest] Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [08:25:06] (03PS21) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [08:25:19] (03CR) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor (0310 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [08:27:09] (03CR) 10Zfilipin: [C: 04-1] [BrowserTest] Added support for uploading the language screenshots (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [08:29:58] (03PS4) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [08:30:39] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [08:30:50] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [08:30:55] (03PS3) 10Trevor Parscal: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 [08:31:00] (03PS3) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [08:32:13] (03PS3) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [08:32:21] (03PS4) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [08:32:30] (03PS4) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [08:32:36] (03PS3) 10Trevor Parscal: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 [08:32:42] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [08:32:46] (03PS4) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [08:32:50] (03PS3) 10Trevor Parscal: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 [08:32:54] (03PS3) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [08:32:59] (03PS4) 10Trevor Parscal: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [08:36:27] (03PS22) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [08:37:01] (03PS23) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [08:39:00] (03PS8) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (35e5b4b331) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [08:40:05] (03PS10) 10Trevor Parscal: [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [08:40:21] (03PS5) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [08:41:00] (03PS3) 10Trevor Parscal: [WIP] Use mw.message's plain method for JSON in SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 [08:41:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [08:42:06] (03Abandoned) 10Trevor Parscal: [WIP] Automatic menu positioning (above or below) [oojs/ui] - 10https://gerrit.wikimedia.org/r/114899 (owner: 10Trevor Parscal) [08:42:11] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (35e5b4b331) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [08:42:16] (03Abandoned) 10Trevor Parscal: [WIP] Use mw.message's plain method for JSON in SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 (owner: 10Trevor Parscal) [08:43:06] (03PS3) 10Vikassy: [BrowserTest] Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) [08:43:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [08:50:24] (03CR) 10Zfilipin: [BrowserTest] Added support for uploading the language screenshots (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [08:52:31] (03PS4) 10Vikassy: [BrowserTest] Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) [08:54:08] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [08:54:59] (03PS4) 10Zfilipin: [BrowserTest]Added script to run cucumber for various languages and upload it to commons using mediawiki_api gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138377 (owner: 10Vikassy) [08:55:15] (03Abandoned) 10Zfilipin: [BrowserTest]Added script to run cucumber for various languages and upload it to commons using mediawiki_api gem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138377 (owner: 10Vikassy) [08:58:05] (03Merged) 10jenkins-bot: [BrowserTest] Added support for uploading the language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144754 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [10:47:06] (03CR) 10Zfilipin: "Yes, this was hack to get the screenshots working on labs without having all wikis we need. If this stops working, we will find a way to m" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144433 (https://bugzilla.wikimedia.org/62737) (owner: 10Zfilipin) [11:24:01] 3VisualEditor / 3ContentEditable: VisualEditor: Reference's highlight is misplaced for the if the references list is placed before the reference - 10https://bugzilla.wikimedia.org/63244#c1 (10Ed Sanders) Is this still broken? [11:28:08] (03CR) 10Esanders: [C: 04-1] "Body height calculation seems off as I'm getting scrollbars: http://i.imgur.com/pafOO6z.png" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [13:37:08] (03CR) 10Krinkle: [C: 04-1] "The target commit in oojs-ui this updates to isn't merged yet. Pending that merge, this may have to be regenerated once more to use the ha" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [13:43:07] (03CR) 10Krinkle: [C: 04-1] Mobile-friendly styling for demos (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 (owner: 10Trevor Parscal) [13:51:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [13:52:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 (owner: 10Amire80) [14:02:16] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] Change how delay works for OO.ui.Process (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [14:06:27] (03CR) 10Krinkle: [C: 04-1] Add AccessKey API to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [14:10:43] (03CR) 10Krinkle: [C: 04-1] Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [14:21:44] (03CR) 10Krinkle: Add support for using arguments with OO.ui.deferMsg (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [14:22:51] (03CR) 10Krinkle: [C: 04-1] "Putting it in a separate commit is nice, but can you give an example of where this is used (and currently broken) or where it will be used" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [14:26:35] (03CR) 10Krinkle: [C: 04-1] "Just an idea, looks good otherwise." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [14:27:41] (03CR) 10Krinkle: "Is there a demo where I can verify this working, or some scenario in VE?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [14:31:36] (03CR) 10Krinkle: [C: 04-1] "Minor API change" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [14:35:36] mooeypoo, are you subscribed to wikitech-l? [14:46:12] mooeypoo, if not, http://lists.wikimedia.org/pipermail/wikitech-l/2014-July/077470.html [14:50:14] (03CR) 10Krinkle: [C: 04-1] [BREAKING CHANGE] The great and terrible dialog refactor (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [14:55:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [14:59:23] (03CR) 10Krinkle: "OK. So getMessage() is used in ProcessDialog.js in Id121fc3aa988f7990511c." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [15:00:39] (03CR) 10Krinkle: [C: 04-1] Add OO.ui.Error (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [15:05:43] (03CR) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor (036 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [15:08:09] (03CR) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [15:37:03] (03CR) 10Esanders: [C: 031] "LGTM apart from the -1" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 (owner: 10Trevor Parscal) [15:39:22] (03CR) 10Esanders: [C: 032] Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [15:41:36] (03CR) 10Esanders: [C: 04-1] Add AccessKey API to OO.ui.ButtonedElement (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [15:42:20] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [15:44:28] (03CR) 10Esanders: [C: 031] "LGTM apart from -1" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [15:47:25] (03CR) 10Esanders: [C: 031] "Surely we'll use it when we have messages that have parameters, which is a pretty common use case, even if none exist in OO or VE yet." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [15:50:05] (03CR) 10Esanders: Add OO.ui.Error (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [15:51:58] (03CR) 10Esanders: [C: 032] Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 (owner: 10Trevor Parscal) [15:52:55] (03CR) 10Esanders: [C: 031] Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [15:54:08] (03CR) 10Esanders: [C: 032] "Although we should start using LESS constants for theme colours." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 (owner: 10Trevor Parscal) [15:57:13] (03CR) 10Esanders: [C: 032] Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [16:21:41] (03CR) 10Jforrester: "Used in https://gerrit.wikimedia.org/r/#/c/144866/5/modules/ve-mw/ui/dialogs/ve.ui.MWBetaWelcomeDialog.js lines 37 and 40." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [16:50:02] (03PS2) 10Jforrester: Rephrase visualeditor-parameter-search-more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 (owner: 10Amire80) [16:50:54] (03CR) 10Jforrester: [C: 032] "PS2 removes accidental change to sub-module." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 (owner: 10Amire80) [16:58:54] (03Merged) 10jenkins-bot: Rephrase visualeditor-parameter-search-more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144906 (owner: 10Amire80) [17:05:30] (03CR) 10Krinkle: "Hm.. you could avoid repeating logic from a parent method (such as in TextInputMenuWidget.prototype.toggle) by using an event handler inst" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [17:10:12] (03CR) 10Esanders: [WIP] Dialog rewrite (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [17:32:48] anyone cmoing to scrum of scrums? [17:43:23] (03PS4) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [17:44:36] awjr: Oh, hey, sorry, Roan's away, and we don't really have other engineers with cross-cutting responsibilities like him. Maybe edsanders? [17:45:51] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [17:47:26] eh? [17:48:15] edsanders: Weekly meeting for people to mention that they're still waiting on something from us and haven't bothered to tell us. ;-) [17:48:20] James_F, wfMessage( 'visualeditor-specialcharinspector-characterlist-insert' )->plain() is apparently giving different answers to mw.msg( 'visualeditor-specialcharinspector-characterlist-insert' ) [17:48:20] (03CR) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [17:48:36] Krenair: Is that a new regression? [17:48:53] Krenair: Or does it just mean we need to re-reun i18n-update-bot again? [17:49:07] Not sure. [17:50:21] Maybe Krinkle will know [17:51:23] you want me to attend? [17:51:29] What is broken? [17:51:41] (03CR) 10Trevor Parscal: "It is used in ve.ui.MWBetaWelcomeDialog. See Ia74732e" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [17:51:54] Krenair: If it's l18n cache and resourceloader, I should know. [17:51:57] Krinkle: https://gerrit.wikimedia.org/r/#/c/144894/ [17:52:17] Krinkle, Nikerabbit is in -i18n implying it could be i18n cache [18:03:34] 3VisualEditor: VisualEditor: Cite tool's dropdown menu is not displaying (it's "underneath" the toolbar) - 10https://bugzilla.wikimedia.org/67741 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 15882 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15882&action=edit Cite men... [18:04:32] 3VisualEditor: VisualEditor: Cite tool's dropdown menu is not displaying (it's "underneath" the toolbar) - 10https://bugzilla.wikimedia.org/67741#c1 (10WhatamIdoing) Created attachment 15883 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15883&action=edit What happens is you have zoomed in [18:04:47] 3VisualEditor: VisualEditor: Cite tool's dropdown menu is not displaying (it's "underneath" the toolbar) - 10https://bugzilla.wikimedia.org/67741 (10WhatamIdoing) [18:06:15] (03PS5) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [18:07:00] (03CR) 10jenkins-bot: [V: 04-1] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [18:08:17] (03CR) 10Esanders: [C: 04-1] Add OO.ui.Error (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [18:08:32] (03PS24) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [18:09:20] (03PS6) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [18:10:37] (03CR) 10Trevor Parscal: "The only use of getMessage() is in Id121fc3, and I've updated it to assume the result is jQuery. Adding getMessageHtml and getMessageText " [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [18:11:08] Krinkle: Could you look at my comments here and let me know if you are happy with it? https://gerrit.wikimedia.org/r/#/c/144894/ [18:12:44] TrevorParscal: as for bind(), that wasn't serious, however it is true. you can do return function (args) {}.bind(this, arguments) [18:13:02] it's just like storing 'this' in a variable. [18:13:38] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [18:21:30] (03CR) 10Krinkle: "Thanks, that confirms a suspicion. That example runs ca-edit in the global scope. Way before the class is used." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [18:21:35] (03PS5) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [18:21:47] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c9 (10Ed Sanders) If we're going to replace ve.bind it should be done in ve core first so we'll need a polyfill there. In ve-mw we can omit that polyfill as mw loads it's own. [18:22:22] (03CR) 10Krinkle: [WIP] Dialog rewrite (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:23:16] (03PS6) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [18:23:18] (03PS4) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [18:24:01] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [18:27:19] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c10 (10Krinkle) Why? How is this different from the other ES5 methods we've been using already? VisualEditor nor OOjs UI support ES3 engines afaik. MediaWiki itself does, and OOjs c... [18:34:31] (03CR) 10Esanders: "In the same way we 'support' nested sup/sub but if you apply fresh annotations we clean up to just one or the other, we should do the same" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://bugzilla.wikimedia.org/51613) (owner: 10Jforrester) [18:36:40] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [18:38:18] (03PS2) 10Trevor Parscal: Mobile-friendly styling for demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 [18:40:43] (03PS25) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [18:48:31] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c11 (10Krinkle) (In reply to Krinkle from comment #10) > Why? How is this different from the other ES5 methods we've been using > already? VisualEditor nor OOjs UI support ES3 engine... [19:02:28] (03PS26) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [19:02:32] (03CR) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor (037 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [19:09:40] Yay, breaking VE! [19:09:44] James_F: https://nl.wikipedia.org/wiki/Gebruiker:Krinkle/MediaWiki_berichten_overzicht?veaction=edit [19:09:57] click on the {{navigatie template to edit it [19:11:24] Uncaught TypeError: Cannot read property 'replace' of null [19:11:29] Krinkle: Because of the comment? Yeah, that's a known issue. [19:11:29] MWTemplatePage invokes mw.Title(title=null) [19:11:46] I think this is broken for any template that uses a dynamic name [19:12:01] .title is optional in parsoids spec. We shouldn't assume it's presence. [19:12:22] We can fallback to anything we want (even an empty dialog or alien), but it shouldn't throw for null pointer :) [19:12:26] * Krenair has a bad feeling it might be his code breaking [19:13:54] like https://gerrit.wikimedia.org/r/#/c/143685/4/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js [19:15:41] Krenair: It's the line above [19:15:42] that [19:15:43] title = new mw.Title( this.template.getTitle() ); [19:15:47] getTitle() is string|null [19:16:31] and it needs an additional check, because mw.Title itself can also throw if you give it a string but it represents an invalid title [19:16:49] e.g. newFromText instead, and check it's truethy (an object) before calling methods on it [19:17:52] I'll draft a patch, you've got other things goign on already. I got a few minutes to yield beofr edinner [19:18:07] alright, thanks [19:18:24] James_F: Check you check whether there's a bug report for this? [19:22:51] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [19:24:51] https://en.wikipedia.org/w/index.php?title=Recorded_Time_and_Other_Stories&veaction=edit - hmm [19:25:09] I wonder if that html we see is some kind of parsoid bug [19:38:30] hey James_F, doing the meeting today? [19:38:42] kaity: Oh, hey, sorry, forgot about that one. [19:38:51] kaity: Do you have anything to talk about. [19:39:35] just want to check in on stuff, but I can just catch you whenever [19:41:54] kaity: Sure. [19:41:57] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=67657 possibly. [19:42:48] 3VisualEditor / 3ContentEditable: VisualEditor: Create relocatable markers for complex shapes, e.g. block templates - 10https://bugzilla.wikimedia.org/62006#c5 (10James Forrester) a:3Ed Sanders Was this fixed by the changes to GCNs? [19:43:39] James_F: https://www.mediawiki.org/w/index.php?title=VisualEditor%2FBasic_example_worksheet&diff=1062661&oldid=1016827 [19:43:47] the comment is fine it seems [19:43:51] (at least doesn't throw uncaught in VE) [19:43:57] the expression kills it right now [19:44:08] AH. [19:44:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=66724 [19:48:09] (03CR) 10Alex Monk: "I wrote this" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [19:48:18] 3VisualEditor / 3Data Model: VisualEditor: Template dialog throws on null title when target is a wikitext expression - 10https://bugzilla.wikimedia.org/66724#c7 (10Krinkle) Yep. It used to throw > Uncaught TypeError: title is null It now fails earlier because the code changed. Namely on > Uncaught TypeEr... [19:50:58] Not really sure what to do about https://gerrit.wikimedia.org/r/#/c/144840/ [19:51:04] 3VisualEditor / 3Data Model: VisualEditor: Template dialog throws error when target is a wikitext expression - 10https://bugzilla.wikimedia.org/66724 (10James Forrester) p:5Normal>3High [19:53:19] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10ryasmeen) 3NEW p:3Unprio s:3no... [19:57:47] 3VisualEditor: VisualEditor: Template dialog should not display html comment in the parameter label - 10https://bugzilla.wikimedia.org/67657#c1 (10Krinkle) Hm.. it sounds like the bug report says that html comments inside TemplateData conflict with VisualEditor. However I think this might've been a confusion... [19:59:03] 3VisualEditor: VisualEditor: Template dialog should not display html comment in the parameter label - 10https://bugzilla.wikimedia.org/67657#c2 (10Krinkle) Created attachment 15885 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15885&action=edit Screenshot of bug. Screenshot for editing the following... [19:59:18] 3VisualEditor / 3Data Model: VisualEditor: Template dialog throws error when target is a wikitext expression - 10https://bugzilla.wikimedia.org/66724 (10Krinkle) a:3Krinkle [19:59:28] James_F: I figured out the other bug, unrelated. [19:59:31] Hope that helps [19:59:41] Krinkle: Figured out or fixed? :-) [19:59:56] figured out, its report was a big cryptic/unactionable [20:00:00] bit [20:00:08] Ta. [20:00:49] (03CR) 10Alex Monk: "Yeah, not sure what to do about this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:05:25] (03PS11) 10Trevor Parscal: [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [20:05:43] James_F, I recommend https://bugzilla.wikimedia.org/show_bug.cgi?id=56700 be reassigned to Timo [20:06:19] mw.config.get( 'wgNamespaceIds' ) [20:06:38] Krenair: Sounds good. [20:06:48] 3VisualEditor / 3MediaWiki integration: VisualEditor: The handler MWCategoryWidget#onLookupInputKeyDown is not actually bound to anything - 10https://bugzilla.wikimedia.org/56700 (10James Forrester) a:5Alex Monk>3Krinkle [20:06:56] (03CR) 10Trevor Parscal: [WIP] Dialog rewrite (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [20:08:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [20:09:07] (03PS1) 10Krinkle: MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) [20:10:02] 3VisualEditor: VisualEditor: Template dialog should not display html comment in the parameter label - 10https://bugzilla.wikimedia.org/67657#c3 (10Krinkle) For comparison, Parsoid already strips out html comments from the template title. It should do so for parameter names as well (in addition to trimming whit... [20:18:11] (03CR) 10Esanders: [C: 032] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [20:18:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: vesection not removed on save - 10https://bugzilla.wikimedia.org/66237#c1 (10Matthew Flaschen) Same for cancel. [20:18:35] (03CR) 10Esanders: [C: 032] Mobile-friendly styling for demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 (owner: 10Trevor Parscal) [20:19:49] (03CR) 10Esanders: [C: 04-1] "Comments still outstanding from PS3" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [20:19:59] (03Merged) 10jenkins-bot: Mobile-friendly styling for demos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144887 (owner: 10Trevor Parscal) [20:20:47] (03PS6) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [20:23:01] (03CR) 10Esanders: Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [20:23:30] (03PS5) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [20:23:32] (03CR) 10jenkins-bot: [V: 04-1] Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [20:23:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [20:26:44] (03PS7) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [20:26:59] * mooeypoo throws bricks on her computer [20:27:18] (03PS7) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [20:27:22] (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [20:27:31] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [20:27:31] (03PS4) 10Trevor Parscal: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 [20:27:32] (03PS6) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [20:27:35] (03PS8) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [20:27:39] (03PS5) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [20:27:41] mooeypoo: Having fun? :-( [20:27:42] (03PS4) 10Trevor Parscal: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 [20:27:46] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [20:27:49] (03PS5) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [20:27:52] (03PS4) 10Trevor Parscal: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 [20:27:56] (03PS5) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [20:27:59] (03PS5) 10Trevor Parscal: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [20:28:49] James_F, My computer is extremely annoying. Switching windows from Sublime to Chrome/Firefox takes 2-3 seconds, and then Sublime keeps getting periodically dark as it figures out its plugins. [20:29:14] so hard to work like that. Can't wait for the laptop to come. [20:30:44] (03PS27) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [20:31:22] mooeypoo: :-( [20:32:07] mooeypoo: If you run out, I got more in my backyard I need to get rid of. [20:32:09] Willing to donate some for a good cause :) [20:32:28] Krinkle, run out of laptops, or run out of bricks? [20:32:29] :D [20:32:40] mooeypoo: Yikes. reminds me of how Sublime 2 performed when dealing with a project with submodules or symlinks. Sublime 3 is supposed to be a lot better. I myself have noticed an improvement (no more frozen screens while it decides the file index should be updated) [20:33:11] It traversing the entire tree is what bottlenecked it for me. [20:33:26] I think ST3 either yields better or no longer does that in general. [20:34:22] Krinkle, yeah I upgraded to sublime 3 over the weekend. It is better, but it still has issues... it's not sublime, though, it's my computer. I think I need to solve something with my graphics, or maybe there's an issue with my hardware.. this PC is old, but it's not THAT old, and it has quadcore and 4 gig memory.. it should definitely work with Ubuntu [20:34:53] The computer just starts getting sluggisher and sluggisher until it get so slow I have to reboot [20:35:21] sometimes it doesn't even let me get back from login screen when it's really sluggish, and I hve to force a shutdown. [20:36:10] mooeypoo: You running Ubuntu or Windows as the non-virtialised system? [20:37:01] (03PS5) 10Krinkle: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:37:17] Krinkle, my laptop is windows, but since Dell are crappy with their support of Windows 8.1 I stopped using it for work. I use my PC, which runs Ubuntu natively, no VM. [20:37:53] Krinkle, but I think it might be wise that I reinstall everything. I upgraded from Ubuntu 12 to 14 and then things got a bit sluggish. They weren't extremely fast before,but got really really bad after. [20:38:09] and it makes no sense, really, with the specs. [20:38:10] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:38:18] (03PS6) 10Krinkle: [WIP] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:38:32] (03CR) 10Krinkle: "Added some debugging for phantomjs." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:39:07] mooeypoo: yeah, quardcore with 4G, that should very well run any regular application. [20:39:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:39:39] (03PS7) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [20:39:43] and while our work is Awesome (TM), git, file systems, http servers, and text editors aren't exactly expensive operations. [20:39:56] Krinkle, yeah, I think I'll reinstall stuff, but I'll wait until I get the laptop [20:40:17] So at least I'll have a backup and can work while I wipe this machine and start from scratch [20:40:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [20:40:18] It's not like you're working with composite layers in a 1GB Photoshop file or rendering HD video. [20:40:50] Krinkle, no.. and I only have XChat, Chrome, Firefox and Sublime open. Oh, and a terminal with parsoid running. [20:40:54] That is really really light load. [20:41:01] Yep [20:41:08] Hence why it's so damn frustrating :\ [20:41:18] (03CR) 10Trevor Parscal: "I've changed the way MWBetaWelcomeDialog works, so we wait until setup time to generate these messages. However, I still think this patch " [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [20:41:21] I sometimes have to wait 3-4 minutes for Sublime to wake up and let me type. [20:41:40] mooeypoo: did you inspect the activity monitor? I wonder whether there's a spike specifically in one of CPU, RAM or I/O [20:41:49] Krinkle, the irony is that the VM on my windows machine is/was faster! [20:41:50] Krinkle: could you take a look at that deferMsg params thing one more time? [20:42:07] the only reason I don't use it anymore si because of issues with the display driver that are causing the laptop to overheat and die [20:42:49] Krinkle, uhm, no, I didn't. I should. I'm also somewhat new to linux.. I know some basics, but I don't know enough to debug the system much. I'll have to do much deeper testing for this, though. [20:43:32] Krinkle, I do watch 'top' every now and then but I can't really make sense of anything except for the "obvious" [20:43:45] ... speaking of which, holy crap chromium takes a LOT [20:44:16] (03PS7) 10Krinkle: [WIP] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:45:03] mooeypoo: I don't know how to inspect that on Linux either. I imagine there's a graphical application for it. RoanKattouw might now. [20:45:06] or edsanders [20:45:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:45:39] I just found a lifehacker article about that [20:46:13] Well, fuck. [20:46:22] Krenair: PhantomJS is the weirdest shit [20:46:27] It supports ES5 strict mode [20:46:39] but didn't implement Function.prototype.bind [20:46:52] so it passes the es5-skip test [20:47:04] wat [20:47:20] Well, I wouldn't have found that, thanks for looking at it Krinkle [20:47:49] Can it really be considered to support it without implementing bind? [20:47:53] Krenair: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/10492/consoleFull https://gerrit.wikimedia.org/r/#/c/144840/5..7/modules/ve-mw/init/ve.init.mw.Platform.js [20:48:03] 20:45:06 {"version":1404938694,"dependencies":[],"group":null,"source":"local","state":"ready","skip":null} [20:48:04] 20:45:06 undefined [20:48:04] 20:45:06 true [20:48:32] Krenair: It's very strange that they'd implement the sort of finishing touch / cherry on the pie (strict mode) but completely forget Function#bind. [20:48:49] I knew PhantomJS didn't support Function#bind, but I wouldn't have guessed it *did* implement strict mode. [20:49:25] I think the only rational explanation is that PhantomJS is at fault, not WebKit. They probably forked off WebKit at an unlucky point in time when Safari was mid-release and only had some of the features. [20:49:50] Afaik the stable releases of Safari either support all of ES5, or only parts of it (and no strict mode) [20:50:48] Krinkle, sooo... Should we be loading es5-shim when we detect that bind isn't implemented? [20:50:50] http://kangax.github.io/compat-table/es5/ [20:52:56] Well, none of the real browsers did this. They all only implemented strict mode after they did everything else (except for minor things like immuatable undefined and zero-width identifiers which we don't support anyway) [20:53:16] https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/es5-skip.js [20:53:49] Lol, that also mentions that same link [20:54:01] I guess James_F|Away didn't see the PhantomJS column there? [20:59:27] Krenair: James_F|Away: RoanKattouw: https://gerrit.wikimedia.org/r/#/c/145128/ [20:59:49] Ah, Roan's on holiday. Right. [20:59:59] Did he forget to close his laptop? [21:00:20] 3VisualEditor / 3Editing Tools: using : to manually indent in wikitext disables out/indent controls in VE - 10https://bugzilla.wikimedia.org/67751 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Repro 1. in wikitext, create the following Item :item :itme ::item 2.save page 3.open in VE... [21:06:05] (03CR) 10Florianschmidtwelzow: [C: 031] MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [21:09:26] (03CR) 10Krinkle: [C: 031] "Yep." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [21:11:45] (03PS8) 10Krinkle: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [21:11:58] (03CR) 10Krinkle: "Removed debugging." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [21:13:40] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [21:14:17] mooeypoo, htop is a bit nicer to use [21:14:28] (03CR) 10Krinkle: [C: 04-1] "What's the use for getMessageHtml()? I think getMessageText shouldn't be needed either, but it's more or less harmless. The problem with g" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [21:16:05] edsanders, I just installed it [21:16:16] edsanders, what's "Nice -/+" ?? O.o [21:16:39] also, it's VERY clear something's hogging my memory [21:16:49] 2931/3260 MB used [21:16:51] wtf. [21:17:03] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync in Firefox - 10https://bugzilla.wikimedia.org/52171#c6 (10Ed Sanders) 5ASSI>3RESO/FIX WFM in Firefox [21:17:31] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync in Firefox - 10https://bugzilla.wikimedia.org/52171 (10Ed Sanders) 5RESO/FIX>3RESO/WOR [21:21:12] (03CR) 10Esanders: [C: 032] Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [21:22:25] (03CR) 10Esanders: [C: 04-1] Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:23:18] mooeypoo, adjusts process priority [21:23:37] (03PS9) 10Krinkle: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [21:23:49] (03CR) 10Krinkle: [C: 032] "Gave test more descriptive key. And added test for 'before'." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [21:24:10] * mooeypoo sobs [21:24:24] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [21:25:24] (03PS7) 10Krinkle: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [21:25:30] ok edsanders and/or any linux/ubuntu expertses... I just rebooted my machine and straight off checked htop... is it reasonable that I have 1.2GB (out of 3.3GB) of memory used right after reboot and without turning anything on yet? [21:25:37] I think something's hogging my memory [21:25:37] (03PS5) 10Krinkle: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [21:26:10] (03CR) 10Krinkle: "Cool, score is preserved +2 :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [21:26:30] doesn't seem crazy [21:26:33] you can sort by memory usage [21:26:37] Everything is chromium [21:26:49] also you should have 8GB! [21:26:52] i just did. Chromium flashplugin [21:26:55] (03PS7) 10Krinkle: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [21:27:03] edsanders, no, this computer has 4GB of memory [21:27:12] quadcore, 4GB.. my laptop has 8GB [21:27:13] yes, but you should get 8GB [21:27:20] * Krinkle is happy with 16GB [21:27:24] :P [21:27:28] edsanders: you as well, right? [21:27:36] Krinkle, rub it in, why don'cha [21:27:59] (03CR) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:28:03] mooeypoo: you can also ask to run your work in the cloud. Labs VMs can have up to 1TB ram (!) [21:28:09] edsanders, yes, I should have a lot of things... my laptop is awesome, but crippled by Windows 8.1 and drivers that are unsuitable by Dell, which makes it unusable. [21:28:55] 1GB is pretty low usage [21:29:03] (03CR) 10Krinkle: [C: 032] "Per ed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [21:29:04] Krinkle, I'm going to get a lender laptop from the office, that should at least get me working properly. Then I plan to try and wipe my windows laptop and put Ubuntu on it. [21:29:08] I'm at 6GB [21:29:22] edsanders, but is that after you have stuff open/working ? [21:29:30] (03PS8) 10Trevor Parscal: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 [21:29:31] yeah [21:29:32] this is right off the bat after reboot.. seems high to me [21:29:44] (03CR) 10Trevor Parscal: "I'm just removing the getMessageHtml method then." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [21:29:48] well fire up htop after boot and see what it is [21:29:53] (03PS10) 10Trevor Parscal: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 [21:29:54] edsanders, that's what I did [21:29:57] (03PS8) 10Trevor Parscal: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 [21:29:58] and... [21:30:00] (03PS6) 10Trevor Parscal: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 [21:30:01] edsanders, it had 1.2GB used [21:30:05] (03PS8) 10Trevor Parscal: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 [21:30:08] (03PS9) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [21:30:12] (03PS6) 10Trevor Parscal: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 [21:30:16] (03PS5) 10Trevor Parscal: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 [21:30:16] but what processes? [21:30:21] (03PS7) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [21:30:25] (03PS6) 10Trevor Parscal: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 [21:30:27] it seems mostly chrome, even though chrome wasn't on [21:30:29] (03PS5) 10Trevor Parscal: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 [21:30:32] (03PS6) 10Trevor Parscal: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 [21:30:34] (03CR) 10Krinkle: Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:30:36] (03PS6) 10Trevor Parscal: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 [21:30:42] (03PS28) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [21:31:03] edsanders: see comments on https://gerrit.wikimedia.org/r/#/c/144892/ [21:31:13] seems odd that chrome would be running on launch [21:31:18] (03CR) 10Krinkle: [C: 032] Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [21:32:31] (03CR) 10Esanders: Add API for tabIndex to OO.ui.ButtonedElement (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:32:36] (03Merged) 10jenkins-bot: Add OO.ui.Error [oojs/ui] - 10https://gerrit.wikimedia.org/r/144893 (owner: 10Trevor Parscal) [21:32:40] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Change how delay works for OO.ui.Process [oojs/ui] - 10https://gerrit.wikimedia.org/r/144888 (owner: 10Trevor Parscal) [21:32:56] TrevorParscal, was commenting on line 12, not 11 [21:32:57] (03PS10) 10Trevor Parscal: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 [21:33:01] yup, sorry [21:33:03] got it [21:33:29] (03CR) 10Krinkle: [C: 04-1] "Hm.. Did you mean to add a null fallback in the last version? It's not an optional parameter." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [21:33:32] (03CR) 10Esanders: [C: 032] Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:34:00] (03CR) 10Esanders: [C: 04-1] "waiting for timo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:34:02] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [21:34:19] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Split part of OptionWidget into DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144889 (owner: 10Trevor Parscal) [21:34:21] (03Merged) 10jenkins-bot: Add flag event to OO.ui.FlaggableElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144890 (owner: 10Trevor Parscal) [21:34:36] (03Merged) 10jenkins-bot: Add AccessKey API to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144891 (owner: 10Trevor Parscal) [21:36:13] TrevorParscal: Hm.. can you look into this.tabIndex on https://gerrit.wikimedia.org/r/#/c/144892/10/src/elements/ButtonedElement.js ? [21:36:18] Is that ever not null? [21:36:29] Found it in the constructor and OO.ui.ButtonedElement.prototype.onMouseUp [21:36:42] Was testing it just now for comparison (since that one would potentially call attr() with -1) [21:36:49] but can't reach that code. [21:36:57] unrelated to that commit, but might want to check it out in a bit [21:37:01] (03CR) 10Krinkle: [C: 031] Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [21:37:22] (03PS7) 10Krinkle: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [21:37:28] (03PS6) 10Krinkle: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 (owner: 10Trevor Parscal) [21:38:50] Krinkle: it's used to remove and then reset the tabIndex value between mousedown and mouseup [21:39:26] this is a hack we have to do to prevent strange browser focus rendering issues [21:39:33] and also allow tabbing into a button [21:39:53] it basically acts as a cached value between event handlers [21:40:28] it's set in onMouseDown [21:41:32] 3VisualEditor / 3ContentEditable: VisualEditor: Problems typing after cursoring off an inline focusable nodes in Firefox - 10https://bugzilla.wikimedia.org/67432#c4 (10Ed Sanders) This happens just by typing anything after an inline focusable node after cursoring off it (nothing to do with deletion). If the... [21:41:37] (03CR) 10Krinkle: [C: 04-1] "The latest change removed the "&& val" per my suggestion, but it also added "null" as an input value. So that makes the ternary obsolete, " [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [21:41:53] TrevorParscal: OK [21:42:49] (03PS29) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [21:42:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [21:43:21] TrevorParscal: Contrary to the property, the attribute doesn't default to "" or -1, so it should roundtrip (if there is no such attribute, it'll get null from jQuery and attr(key, null) just ensures the attribute is removed. [21:43:30] Works well : [21:43:31] :) [21:44:00] (03PS2) 10Krinkle: [WIP] Followup 1b9c077: debounce toolbar's onSurfaceViewKeyup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119432 (owner: 10Catrope) [21:45:11] (03CR) 10Trevor Parscal: "I'm clamping non-string to null so that the internal property (this.href) has a reliable value, either a string or null. I think it's reas" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [21:45:19] Krinkle: responded: https://gerrit.wikimedia.org/r/#/c/144899/ [21:47:39] (03CR) 10Trevor Parscal: "Again, just internal consistency insurance." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [21:48:22] (03PS10) 10Krinkle: Add depends and conflicts parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/73708 (https://bugzilla.wikimedia.org/50407) (owner: 10AzaToth) [21:48:24] (03CR) 10jenkins-bot: [V: 04-1] Add depends and conflicts parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/73708 (https://bugzilla.wikimedia.org/50407) (owner: 10AzaToth) [21:48:57] (03Abandoned) 10Krinkle: Add depends and conflicts parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/73708 (https://bugzilla.wikimedia.org/50407) (owner: 10AzaToth) [22:01:54] (03CR) 10Krinkle: [C: 031] "OK." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [22:04:06] TrevorParscal: I've not really noticed the forceful casting of values for internal use before. I'd like to discuss that some other time. I'm not sure it's worth the extra code for that unlikely code. And code that is wrong (developer error, not invalid user error or unexpected input). Silently rejecting those values and assuming an intent seems dangerous. [22:04:11] I'd rather just have stuff blow up [22:04:23] maybe not with exceptions everywhery but just naturally. [22:04:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut to access VE (Alt+Shift+v) is not working from action=edit in FF browser - 10https://bugzilla.wikimedia.org/67218#c2 (10Alex Monk) The 'Show changes' button has accesskey=v, so there's a conflict. Chrome just goes for the first one on th... [22:05:15] (03CR) 10Krinkle: [C: 031] [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [22:05:53] edsanders: OK to merge? https://gerrit.wikimedia.org/r/#/c/144892/ [22:05:59] TrevorParscal, I was about to rbase stuff onto your fixes, but when I review https://gerrit.wikimedia.org/r/#/c/144866/ without anything else VE doesn't load [22:06:06] (03PS8) 10Krinkle: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [22:06:13] (03PS7) 10Krinkle: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [22:06:17] (03PS6) 10Krinkle: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 (owner: 10Trevor Parscal) [22:06:21] (03PS7) 10Krinkle: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [22:06:24] you might not have the submodule in the right state [22:06:25] (03PS7) 10Krinkle: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [22:06:30] (03PS30) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [22:06:35] git submodule update [22:07:44] TrevorParscal, yes, but then I lose the review patch [22:07:50] it's a lib/ve patch [22:08:01] Krinkle: exceptions are for exceptional situations, and exploding "naturally" almost always means exploding "mysteriously". Can we just get this merged and have a more general guidelines discussion at a later time and sweep the code for violations? [22:08:28] That's what I meant to suggest. "Discuss that some other time" [22:08:34] mooeypoo: you need to base your lib/ve patch on the lib/ve commit then, no? [22:08:35] I removed the -1 a few minutes ago [22:08:44] yeah [22:08:51] Krinkle: we agree, something should be decided and stuck to [22:09:16] I don't even have an opinion about it really, just habits that I can change [22:09:21] just, maybe another day... [22:09:26] TrevorParscal, yes, i started with a clean ve + clean ve-mw with 'git submodule update'. Then I go into lib/ve and review your lib/ve dialog fix. I reload VE and it won't load. [22:10:04] TrevorParscal, I tried to have both fixes -- the lib/ve + the ve-mw one both, but then I get tons of errors "Uncaught TypeError: Expecting a function in instanceof check, but got undefined" [22:10:35] where in the code is that happening? [22:10:39] can you get a stack trace? [22:10:48] TrevorParscal, these errors are with the ve-mw patch [22:10:50] and yes, I have them all [22:11:07] where is the error? [22:11:36] I'm getting "Uncaught Error: constructor must be a function, cannot be a undefined " on oojs.js:814" oo.Factory.register -> from "ve.ui.windowFactory.register( OO.ui.MessageDialog );" in ve.ui.js:22 [22:12:42] that's very odd, let me try and replicate [22:12:52] Then I have a bunch of "Uncaught TypeError: Expecting a function in instanceof check, but got undefined " for "oo.inheritClass()" from: ve.ui.InspectorManager.js:31 , ve.ui.CommandHelpDialog.js:25, ve.ui.FragmentDialog.js:29, ve.ui.ContextItemWidget.js:34, ve.ui.FragmentInspector.js:31 [22:13:48] I'm wondering if it might be a lib/ve patch rebase thing? Or maybe there are dependencies I don't have? [22:13:56] the patch you work on is massive.. [22:14:59] Also, these errors only happen if I have both "wip dialog rewrite" commits (for ve and ve-mw) [22:18:04] 3VisualEditor / 3Editing Tools: VisualEditor: After selecting a reference note by pressing backspace, pressing down throws error:Uncaught NotFoundError: Failed to execute 'selectNode' on 'Range': The node provided is null. - 10https://bugzilla.wikimedia.org/67755 (10ryasmeen) 3NEW p:3Unprio s:3normal a... [22:20:33] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13]After selecting a reference note by pressing backspace, pressing down throws error:Uncaught NotFoundError: Failed to execute 'selectNode' on 'Range': The node provided is null. - 10https://bugzilla.wikimedia.org/67755 (10ryasmeen) [22:23:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13]TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10ryasmeen) [22:25:15] ryasmeen, James_F I find it somewhat encouraging that the image bugs seem to be getting more and more elaborate to decipher. [22:25:24] mooeypoo: :-D [22:25:50] :) [22:26:01] and yes, this bug, I believe, is related (if not outright due-to) the weird jquery issue I've been having with the API calls. [22:28:06] (03CR) 10Esanders: [C: 032] Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [22:28:54] (03CR) 10Esanders: [C: 032] Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [22:29:02] (03Merged) 10jenkins-bot: Add API for tabIndex to OO.ui.ButtonedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/144892 (owner: 10Trevor Parscal) [22:30:06] (03Merged) 10jenkins-bot: Add support for using arguments with OO.ui.deferMsg [oojs/ui] - 10https://gerrit.wikimedia.org/r/144894 (owner: 10Trevor Parscal) [22:30:08] (03Merged) 10jenkins-bot: Add OO.ui.FormLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144895 (owner: 10Trevor Parscal) [22:31:18] (03CR) 10Esanders: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [22:34:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13]TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749#c1 (10Moriel Scho... [22:35:44] Krenair, you said something about knowing this bug, I think? the API/jQuery callback bug? or do I misremember? [22:36:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13]TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10ryasmeen) a:... [22:36:33] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13]TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10ryasmeen) 5N... [22:36:42] I... Think that might have been something I misunderstood [22:37:15] oh, okay, I thought you may have encountered this [22:37:44] TrevorParscal, testing 141089 in standalone, I'm seeing double icons in the debug bar (LTR/RTL) [22:50:46] (03CR) 10Krinkle: [C: 04-1] "Per Ed. I remembered it from the commit message, but deserves a place in the code indeed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [22:53:47] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162#c1 (10Alex Monk) WFM (Safari 5.1.7 for Windows) [22:58:34] (03PS9) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [23:00:23] (03CR) 10jenkins-bot: [V: 04-1] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [23:05:46] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156#c2 (10Alex Monk) I don't think we do this deliberately. This happens in Chrome for me... Are you sure this is Safari-specific, Sherry? [23:08:58] lookin [23:13:01] (03PS1) 10Trevor Parscal: Fix double icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/145157 [23:13:28] edsanders|away: hey, i fixed it - somewhere in the split up I lost the changes to OptionWidget [23:13:36] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/144896/ is the first thing in the stack that's got negative CR; thence all of OOUI looks mergable. [23:13:48] I checked, they aren't applied in the dialog rewrite (top of the stack) at all [23:17:46] (03PS9) 10Trevor Parscal: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 [23:17:53] James_F: how about that? [23:18:24] TrevorParscal: Works for me. :-) [23:19:28] we merging or what? [23:38:17] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [23:38:33] Krinkle: ? [23:43:24] Krinkle, any idea what's going wrong there? [23:43:32] Nope [23:43:49] I suspect a race condition, though that's unlikely [23:44:00] more likely, one of the jenkins slaves is messed up and the recheck ran on a good one [23:44:05] will follow-up later but busy right now [23:44:08] * Krinkle snaps sceenshot [23:45:29] ... The recheck failed the same way the original one did [23:46:44] Krinkle: Are you going to merge Trevor's code? Given that Ed's left it to you to do… [23:49:19] 3VisualEditor: Session state sharing between multiple tabs and windows gives access to edit other Users page in VE. - 10https://bugzilla.wikimedia.org/67765 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15887 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15887&action=edit... [23:49:47] 3VisualEditor: Session state sharing between multiple tabs and windows gives access to edit other Users page in VE. - 10https://bugzilla.wikimedia.org/67765 (10Ritu Swain) [23:54:20] Krenair: Oh, right. I didn't see that. [23:54:24] Krenair: It didn't report it to irc [23:54:39] well, at least it no longer fails on bind() [23:54:45] Krinkle: Could you please respond? We're sitting here waiting for you… [23:55:16] James_F: I might make it to review all the commits below the "The great and terrible dialog refactor" [23:55:35] but not that one and the two "[WIP] Dialog refactor" ones in ve/ ve/mw [23:55:52] Krinkle: So… you're commiting to +2 the things that already have +1? Eurgh. We're waiting for the /hard/ review to be done. [23:56:16] One of them has a +1 now, yes. But I spend the better part of the day on all those with Ed. [23:56:17] and yesterday. [23:56:28] The big one I haven't even looked at the actual code in the slightest way [23:56:34] * James_F sighs. [23:56:35] the other combined are just as big [23:56:48] They're mostly trivial; half of them I co-wrote. [23:56:59] (The VE-land ones.) [23:57:10] They also all changed in various ways before they were +1'ed and merged by me earlier. [23:57:30] They weren't trivial enough to get right the first time enough to be clear to Ed or myself. [23:57:34] Which is fine. [23:57:36] So instead of helping Trevor with CR you're double-checking Ed's CR? :-) [23:57:39] * James_F nods. [23:57:42] No, I'm not. [23:58:00] Neither did Ed double-review ones I did afaik we deferred to each other. Working towards each ohter from both ends of the stack both times [23:58:13] * James_F nods. [23:58:14] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [23:58:22] (03PS8) 10Krinkle: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [23:58:48] James_F: It's also nearly impossible to verify any of these dozen commits because there are no functional tests or visual tests for most of them. [23:58:57] And the ones that have demos were only demoed in commits later on [23:59:14] so at best I'm verifying that the commits combined work. Which is "fine" but sub optimal and hard to test. [23:59:16] Krinkle: You either get split up commits or integrated ones with tests. Pick. :-) [23:59:21] * James_F nods. [23:59:37] s/tests/use/ [23:59:42] Nope, I'd personally not do that. I'd ensure the demos are usable first. And in each commit add bits to both. [23:59:55] * James_F gives up.