[00:00:03] And I thinik Trevor did that too [00:00:10] Assuming he didn't write 12 commits blind before running any code [00:00:21] He wrote one commit split over three repos. [00:00:24] but he split them up later and the demo changes were only in the top one. [00:00:38] Then he split one of those three repos' commits into 12 commits for you to more easily understand. [00:00:52] The majority of the changes only make sense in context. [00:01:05] Which makes this near-impossible to review piecemeal. [00:01:53] It's not impossible or unreasonable. But we know Trevor's quarerly refactors go this way, and the time saved in development is presumably justified in review cost. But in any other change this wouldn't fly, of course. [00:02:49] (03PS7) 10Krinkle: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 (owner: 10Trevor Parscal) [00:02:54] (03PS8) 10Krinkle: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [00:02:59] (03PS8) 10Krinkle: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [00:03:05] (03PS31) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:05:05] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Separate setup from setOutlineItem in OO.ui.PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/144896 (owner: 10Trevor Parscal) [00:08:02] (03CR) 10Krinkle: [C: 04-1] "SelectWidgets have two tick marks and two down arrows (check widgets_apex.html). Screenshot: http://i.imgur.com/v0GEO9V.png" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:08:03] TrevorParscal: ^ [00:08:51] (03CR) 10Krinkle: [C: 032] Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [00:09:39] (03Merged) 10jenkins-bot: Make OO.ui.FieldLayout labels display inline-block when aligned top [oojs/ui] - 10https://gerrit.wikimedia.org/r/144897 (owner: 10Trevor Parscal) [00:09:47] (03Merged) 10jenkins-bot: Change color of text on frameless buttons [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 (owner: 10Trevor Parscal) [00:11:15] (03CR) 10Krinkle: "Aye, I didn't mean for this to merge yet. I can't verify this anywhere because we don't have any frameless buttons in the demo with flags " [oojs/ui] - 10https://gerrit.wikimedia.org/r/144898 (owner: 10Trevor Parscal) [00:12:46] (03CR) 10Krinkle: [C: 032] "One can actually pass null as attr(key, null) and it calls removeAttr(), but this is OK for now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [00:13:36] (03Merged) 10jenkins-bot: Add href and target API to OO.ui.ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144899 (owner: 10Trevor Parscal) [00:14:40] (03CR) 10Krinkle: [C: 04-1] "This doesn't seem to be used by Id121fc3aa988f7, and no usage in demo or tests. Presumably this is used by one of the VE or VE-MW commits," [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [00:14:52] (03CR) 10Krinkle: "2 issues:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:16:19] (03CR) 10Krinkle: "(for the record, I didn't just mean the new blur() method being unused, but also the current way via $input.blur())" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [00:17:27] RoanKattouw: Do you know about ve.dm.MWBlockExtensionNode ? [00:17:30] James_F: On the plus side, we reviewed over a dozen commits today, found a bout half a dozen issues in them which were all fixed and subsequently they got all merged. Except for the top one, which I've only reviewed about 10% now and found 1 bug and 1 minor issue. [00:17:41] InezK: Roan is on holiday and left his username non-away. [00:17:54] I see, ok [00:20:10] Krinkle: True. [00:20:25] Krinkle: TrevorP|Away's gone for the day as of 20 minutes ago. [00:21:07] Krinkle: The double-indicator issue in https://gerrit.wikimedia.org/r/139550 is fixed in https://gerrit.wikimedia.org/r/#/c/145157/ apparently. [00:22:52] (03PS2) 10Krinkle: Fix double icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/145157 (owner: 10Trevor Parscal) [00:24:46] (03PS3) 10Krinkle: OptionWidget: Fix double icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/145157 (owner: 10Trevor Parscal) [00:24:51] (03CR) 10Krinkle: [C: 032] OptionWidget: Fix double icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/145157 (owner: 10Trevor Parscal) [00:25:44] (03Merged) 10jenkins-bot: OptionWidget: Fix double icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/145157 (owner: 10Trevor Parscal) [00:25:57] (03CR) 10Krinkle: "(merge conflict)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [00:26:08] (03PS9) 10Krinkle: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [00:26:13] (03PS32) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:26:24] Krinkle: Yeah, hence why I didn't ask anyone to look at it yet. :-) [00:26:30] (03CR) 10Krinkle: "Rebased to include If165a6518c376e which fixes the double indicator issue." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [00:28:31] Krinkle: Hunting for the use of blur on inputs now. [00:32:12] James_F: Wasn't there a change to OOJS to notify downstream if the library failed for some reason? [00:32:38] marktraceur: You mean ResourceLoader's skip function? [00:32:48] Hm...maybe? [00:33:11] * marktraceur reads that doc [00:34:46] Right, because docs exist in MediaWiki [00:36:38] marktraceur: Ha. [00:38:12] marktraceur: I'd give you a link but Doxygen just crashed my Firefox tab… [00:38:20] Ha [00:38:22] I found it [00:38:26] But it's not very helpful [00:38:50] marktraceur: See resources/Resource.php for an example use. [00:39:13] es5-skip? [00:39:40] Yeah. [00:40:03] If that returns true then the es5-shim module isn't loaded. [00:40:09] Ohhhh. [00:40:42] James_F: So I can just check if OOJS is loaded and return that result. And OOJS checks if it's compatible with the browser? [00:40:52] marktraceur: Yes. [00:40:59] And doesn't load if not? [00:41:04] marktraceur: This way you don't have to worry about browser compatibility. [00:41:10] That's what I figure [00:41:38] marktraceur: Theoretically you could end up with no OOjs if es5-shim is determined to be needed but fails to load for some reason. [00:48:40] (03PS4) 10Jforrester: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [00:48:42] (03PS2) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 [00:49:04] (03CR) 10Jforrester: "PS4 rebases onto Trevor's stack (and probably doesn't work yet)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [00:49:15] (03CR) 10Jforrester: "PS2 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [00:49:58] (03CR) 10jenkins-bot: [V: 04-1] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [00:51:45] (03CR) 10Jforrester: "Used in https://gerrit.wikimedia.org/r/#/c/141089/11/modules/ve/ui/inspectors/ve.ui.LinkInspector.js,unified line 151." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [01:09:03] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162#c2 (10WhatamIdoing) 5ASSI>3RESO/FIX This works for me at Mediawiki.org (1.24wmf12) but not at the English Wikipedia on Safari 6.1.4 wi... [01:10:01] 3VisualEditor / 3Editing Tools: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - 10https://bugzilla.wikimedia.org/67162#c3 (10James Forrester) Hmm. Will sling into the list, then, but this feels odd… [01:11:05] Krinkle: Now you've got usage is https://gerrit.wikimedia.org/r/#/c/144900/ good to merge? [01:12:31] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156#c3 (10WhatamIdoing) Firefox lets me leave the dialog box, but it eventually tabs back into it. Safari gets stuck. I haven't checked Chrome; Safari and Chrome often have... [01:18:01] James_F: 00:49:57 Fatal error: Port 9002 is already in use by another process. [01:18:04] l-o-l [01:18:16] Yeah, so much for concurrency [01:19:11] Krinkle: Erk, where was that? [01:19:18] grrrit-wm1: (CR) jenkins-bot: [V: -1] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - https://gerrit.wikimedia.org/r/144607 (owner: Jforrester) [01:19:32] That's because the job is allowed to run concurrently in Jenkins [01:19:40] Oh, I just assumed it was the hard-coded-paths thing. [01:19:49] But that's for oojs-core not oojs-ui, isn't it? [01:19:51] Anyway. [01:19:55] oojs-ui [01:20:11] Krinkle: https://gerrit.wikimedia.org/r/#/c/144606/ [01:21:16] (Gah, now I've sent you down the rabbit-hole of fixing Jenkins rather than merging code! ;-() [01:21:23] (03CR) 10Krinkle: [C: 04-1] "we should tell grunt to use connect. useAvailablePort= true; and then get it via grunt.event.once('connect.tests.listening', function(hos" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [01:21:37] Not fixing it now becayse it isn't in master [01:21:45] * James_F nods. [01:22:04] (03CR) 10Krinkle: "Nope, the commit it depends on is written by an idiot. https://gerrit.wikimedia.org/r/141441" [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [01:22:11] :-) [01:22:15] * James_F hugs the idiot Krinkle. [01:23:05] I've written 10 upstream bug reports today including jquery core and jquery cookie. [01:23:10] Fun. [01:23:11] Why is the internet so broken? [01:23:40] oh, and a bug in es5-shim [01:23:54] it overloads Array.prototype.splice in Chrome (if you decide to load it, that is) [01:24:04] Helpful. [01:24:15] that's possibly the reason it breaks in PhantomJS because the method isn't broken, and then it is [01:26:47] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf13] After selecting a reference note by pressing backspace, pressing down throws error:Uncaught NotFoundError: Failed to execute 'selectNode' on 'Range': The node provided is null. - 10https://bugzilla.wikimedia.org/67755 (10James Forrester) 5NE... [01:28:48] 3VisualEditor / 3ContentEditable: VisualEditor: Select-all and typing makes document significantly out-of-sync in Firefox - 10https://bugzilla.wikimedia.org/52171#c7 (10James Forrester) 5RESO/WOR>3VERI Confirmed now fixed. [01:29:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) [01:29:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) [01:29:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684 (10James Forrester) [01:29:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) [01:29:36] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687 (10James Forrester) [01:29:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10James Forrester) [01:29:38] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [01:29:51] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) [01:29:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13] "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609 (10James Forrester) [01:29:51] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [01:29:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [01:29:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256 (10James Forrester) [01:29:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [01:29:54] 3VisualEditor / 3ContentEditable: VisualEditor: Display HTML comments to the editor (and make them editable/creatable/removable) - 10https://bugzilla.wikimedia.org/49603 (10James Forrester) [01:29:55] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) [01:29:56] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10James Forrester) [01:30:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10James Forrester) [01:30:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] Cite menu is missing in the toolbar for mobile VE for in both alpha and beta modes - 10https://bugzilla.wikimedia.org/67701 (10James Forrester) [01:30:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester) [01:30:08] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10James Forrester) [01:30:09] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10James Forrester) [01:30:10] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) [01:30:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [01:30:12] Whee. [01:30:12] 3VisualEditor / 3Data Model: VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations - 10https://bugzilla.wikimedia.org/67377 (10James Forrester) [01:30:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10James Forrester) [01:30:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [01:30:20] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) [01:30:20] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [01:30:20] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Typing when a block node is selected should replace the node with a new paragraph of the typed input - 10https://bugzilla.wikimedia.org/67177 (10James Forrester) [01:30:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [01:30:21] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) [01:30:32] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [01:33:12] (03CR) 10Krinkle: [C: 032] Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [01:34:00] (03Merged) 10jenkins-bot: Add blur method to OO.ui.InputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/144900 (owner: 10Trevor Parscal) [01:35:15] Yay. [01:52:55] James_F: Do you recall any recent change/fix to generated content node that has to do with node being wrapped twice? [01:53:30] https://github.com/wikimedia/VisualEditor-VisualEditor/commit/c19fa388903f52c3d77b7e8ef9344e36f2e8877c#diff-88a5345e4293fd9af771840287f98787 [01:53:33] seems about right I guess [01:55:35] (03CR) 10Krinkle: [C: 04-1] "Actually, no, this failure is from something else. This is because the path to node-index.js wasn't updated in package.json." [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [01:56:42] (03CR) 10Krinkle: "This failure is due to the dependemcy on "phantomcheck" which uses a hardcoded port in a test that's supposed be executable in parallel." [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [02:42:35] InezK: Ha, yeah. [02:43:04] (03PS2) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 [02:43:34] (03CR) 10Jforrester: "Aha, thanks for the spot. Forgot about that bit." [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [02:44:35] (03CR) 10jenkins-bot: [V: 04-1] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [03:31:27] (03PS5) 10Jforrester: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [03:32:33] (03CR) 10Jforrester: [C: 04-1] "This now uses grunt.event.once('connect.qunit.listening') – thanks Timo! – but unfortunately this passes even though it shouldn't (only th" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [03:32:48] (03PS3) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 [03:37:16] (03CR) 10Jforrester: [C: 032] MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [03:37:47] 3VisualEditor / 3Data Model: VisualEditor: Template dialog throws error when target is a wikitext expression - 10https://bugzilla.wikimedia.org/66724 (10James Forrester) 5PATC>3RESO/FIX [03:39:08] (03CR) 10jenkins-bot: [V: 04-1] MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [03:45:17] (03CR) 10Jforrester: [C: 032] "That's… interesting." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [03:47:07] (03CR) 10jenkins-bot: [V: 04-1] MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [03:47:16] * James_F hmms. [03:56:18] 3VisualEditor / 3Editing Tools: using : to manually indent in wikitext disables out/indent controls in VE - 10https://bugzilla.wikimedia.org/67751#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 37938 *** [03:56:18] 3VisualEditor / 3Editing Tools: VisualEditor: Support for definition-lists - 10https://bugzilla.wikimedia.org/37938#c2 (10James Forrester) *** Bug 67751 has been marked as a duplicate of this bug. *** [03:56:48] 3VisualEditor / 3MediaWiki integration: VisualEditor: vesection not removed on save/cancel - 10https://bugzilla.wikimedia.org/66237 (10James Forrester) p:5High>3Normal a:3Alex Monk [04:09:02] 3VisualEditor / 3ContentEditable: VisualEditor: Problems typing after cursoring off an inline focusable nodes in Firefox - 10https://bugzilla.wikimedia.org/67432 (10James Forrester) [04:13:47] 3VisualEditor: VisualEditor: Cite tool's dropdown menu is not displaying (it's "underneath" the toolbar) - 10https://bugzilla.wikimedia.org/67741#c2 (10James Forrester) 5NEW>3RESO/DUP This sounds like bug 64388 which is very troubling. :-( *** This bug has been marked as a duplicate of bug 64388 *** [04:14:02] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.x (not 6.0.x or 7.x) - 10https://bugzilla.wikimedia.org/64388#c23 (10James Forrester) *** Bug 67741 has been marked as a duplicate of this bug. *** [07:22:29] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [07:30:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [10:29:19] 3VisualEditor: Deprecated param w/out description text "no description" isn't in italic grey - 10https://bugzilla.wikimedia.org/67794 (10gabrasca2) 3UNCO p:3Unprio s:3minor a:3None Created attachment 15889 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15889&action=edit VisualEditor deprecated... [11:27:55] (03PS1) 10Vikassy: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 [11:42:04] 3VisualEditor: VisualEditor: Pawns and reverse typing - 10https://bugzilla.wikimedia.org/67797 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Reported on fr.wp. Verified so far in Win 7 (Chrome and FF). You can use this page https://fr.wikipedia.org/w/index.php?title=Utilisateur:Elitre_%28WMF%29/Prove2&... [11:51:24] (03CR) 10Esanders: MWImageModel unit tests (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [11:52:03] (03CR) 10Esanders: [C: 04-1] Blur contentEditable node while destroying surface. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 (owner: 10Inez) [11:52:20] (03CR) 10Esanders: [C: 04-1] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [12:02:16] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:04:07] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:09:31] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156#c4 (10Alex Monk) In that case this feels like an upstream issue [12:13:23] (03PS2) 10Zfilipin: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:14:00] (03PS2) 10Krinkle: MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) [12:15:14] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:16:06] (03CR) 10jenkins-bot: [V: 04-1] MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [12:19:20] (03PS1) 10Alex Monk: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) [12:21:09] (03CR) 10jenkins-bot: [V: 04-1] Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) (owner: 10Alex Monk) [12:22:00] (03PS3) 10Zfilipin: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:22:05] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:24:17] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [12:36:02] Fuck fuck fuck [12:36:15] Krenair: So... [12:36:20] es5-shim is now being loaded [12:36:32] and breaking other things? [12:36:44] Which breaks PhantomJS qunit because... es5-shim breaks Array.prototype.splice in a way that breaks SinonJS fake timers [12:36:50] sigh [12:37:19] shall we revert the es5-shim patch for phantomjs then? [12:38:59] Gonna dig a little deeper first [12:46:45] https://github.com/es-shims/es5-shim/issues/255 [13:25:05] Krenair: So... PhantomJS is missing Function#bind, we load es5-shim but nothing happens because they do implement strict mode. We update the skip to detect absence of Function#bind and it is broken because SinonJS relies on the fragile behaviour of Array#splice that all browsers implement (including Chrome) but es5-shim actually overrides with their Array#splice (it even overloads arraysplice [13:25:05] in latest Chrome if you load es5-shim). es5-shim is considering unbreaking that in the future, but for now the burden is on SinonJS to now use that in the first place. SinonJS already fixed that in the latest release. But their latest release contains a fatal bug that crashes every page in every browser if you even use their clock.tick function because they don't test their shit before release [13:25:05] . [13:25:34] to not use that* [13:25:53] sigh [13:27:03] So es5-shim is causing issues for non-PhantomJS browsers as well? [13:27:46] They just see if Array#splice functions the way the spec says, and if not, they overload it [13:28:12] For Array#splice that means it overrides it in every browser you load it in because not a single browser implements the specced behaviour of splice() [13:28:21] all browsers have the same variation, arguably it's a mistake in the spec. [13:28:43] I got in touch with upstream v8 and #chromium, they agree. The spec will be modified. [13:29:03] But, we're deeper down the rabbit hole, because SinonJS 1.10 no longer is subject to this splice() bug. [13:29:23] (it's very rare behaviour that is affecting splice here, you should ever call it with 1 argument of '0', that's just weird) [13:29:28] they fixed the splice() call in 1.10 [13:29:37] Has SinonJS fixed the clock.tick issue since release? [13:29:38] but 1.10 is just dead on arrival. [13:29:44] No, I only reported it a minute ago. [13:29:47] ah [13:29:47] Nobody noticed apparently [13:30:09] SinonJS is by far the worst upstream library I've ever shipped anywhere. [13:30:28] Could we backport the fix for Array#splice usage to our version? [13:30:36] Yes [13:30:40] Should we? [13:31:45] Considering waiting for SinonJS to fix their stuff will take forever, yes. [13:31:53] Let's do that then [13:33:09] Drafting patch.. [13:39:46] Krinkle, you going to abandon https://gerrit.wikimedia.org/r/#/c/145291/ for now then? [13:39:53] in favour of https://gerrit.wikimedia.org/r/#/c/145304/ ? [13:40:03] Not abandoning it, but yeah, can't merge now [13:42:20] (03PS1) 10Amire80: Add screenshots to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145305 [13:42:22] (03PS1) 10Amire80: Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 [13:44:35] (03PS2) 10Zfilipin: [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [13:44:54] (03CR) 10jenkins-bot: [V: 04-1] Add screenshots to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145305 (owner: 10Amire80) [13:45:28] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [13:45:30] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [13:45:52] (03PS2) 10Zfilipin: [BrowserTest] Add screenshots to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145305 (owner: 10Amire80) [13:46:21] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add screenshots to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145305 (owner: 10Amire80) [13:48:47] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [13:49:42] (03PS3) 10Krinkle: MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) [13:51:21] (03Merged) 10jenkins-bot: [BrowserTest] Add screenshots to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145305 (owner: 10Amire80) [13:53:14] (03PS4) 10Alex Monk: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [13:54:00] (03PS2) 10Alex Monk: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) [13:54:08] (03PS10) 10Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) [13:54:10] (03CR) 10Jforrester: [C: 032] "Trying again." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [13:54:27] (03CR) 10Zfilipin: [C: 04-1] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [13:59:02] (03Merged) 10jenkins-bot: MWTemplatePage: Account for template.title being null [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145055 (https://bugzilla.wikimedia.org/66724) (owner: 10Krinkle) [14:01:55] (03PS5) 10Vikassy: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 [14:02:15] (03PS3) 10Krinkle: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) (owner: 10Alex Monk) [14:02:45] (03PS4) 10Krinkle: mw.ViewPageTarget: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) (owner: 10Alex Monk) [14:02:50] (03CR) 10Krinkle: [C: 032] mw.ViewPageTarget: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) (owner: 10Alex Monk) [14:04:48] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Remove vesection from URL on save/cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145277 (https://bugzilla.wikimedia.org/66237) (owner: 10Alex Monk) [14:07:48] (03PS4) 10Krinkle: Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [14:09:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: vesection not removed on save/cancel - 10https://bugzilla.wikimedia.org/66237 (10James Forrester) 5PATC>3RESO/FIX [14:09:56] (03CR) 10jenkins-bot: [V: 04-1] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders) [14:10:02] (03CR) 10Krinkle: [C: 032] Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [14:11:44] (03Merged) 10jenkins-bot: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144840 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [14:18:16] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c13 (10Alex Monk) (In reply to Krinkle from comment #7) > We now have the polyfill for Function.prototype.bind provided by MediaWiki > so this should be easier to do now. Heh. Anyw... [14:19:47] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c14 (10Krinkle) (In reply to Alex Monk from comment #13) > (In reply to Krinkle from comment #7) > > We now have the polyfill for Function.prototype.bind provided by MediaWiki > > so... [14:21:27] (03CR) 10Krinkle: "node-index.js refers to files in /test/unit which don't exit." [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [14:21:34] We don't have es5-shim loading for those though, do we Krinkle? [14:22:13] Krenair: In what way? [14:22:13] We don't support nonES5 for those [14:22:14] not for ve-mw either [14:22:26] But PhantomJS doesn't have Function.bind, right [14:22:29] Yeah. [14:22:41] it supports strict mode, .super, isArray, filter/map/Object.keys etc. [14:40:03] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [15:15:44] (03PS3) 10Jforrester: [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [15:16:12] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [15:22:46] (03PS3) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 [15:24:36] (03PS3) 10Zfilipin: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 [15:25:26] (03CR) 10Zfilipin: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [15:26:57] (03CR) 10jenkins-bot: [V: 04-1] Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [15:30:24] (03CR) 10Jforrester: [C: 032] [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [15:32:07] (03Merged) 10jenkins-bot: [BrowserTest] Rename *langauge* to *language* [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145306 (owner: 10Amire80) [15:32:46] 3VisualEditor / 3ContentEditable: VisualEditor: Problems typing after cursoring off an inline focusable nodes in Firefox - 10https://bugzilla.wikimedia.org/67432#c5 (10Ed Sanders) Monitoring document.activeElement (the currently focussed element) it's apparent that simply setting a selection on the document... [15:35:41] edsanders: Fun. [15:38:00] (03CR) 10Zfilipin: "Help in getting qunit tests passing is appreciated. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [15:52:33] (03PS1) 10Esanders: Make sure the document is focused when setting a selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145346 (https://bugzilla.wikimedia.org/67432) [15:54:13] edsanders: Isn't Firefox just wonderful? [15:54:32] amazing [15:54:46] not least because the debugger crashes whenever I tried to pause a key event [15:54:54] Wait, what? [15:54:55] Wow. [16:00:33] 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut to access VE (Alt+Shift+v) is not working from action=edit in FF browser - 10https://bugzilla.wikimedia.org/67218#c3 (10James Forrester) p:5Unprio>3Low s:5normal>3minor (In reply to Alex Monk from comment #2) > The 'Show changes'... [16:00:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext editor's keyboard shortcut for show changes (shift+alt+v) no longer works - 10https://bugzilla.wikimedia.org/52701 (10James Forrester) [16:00:47] 3VisualEditor / 3MediaWiki integration: VisualEditor: Keyboard shortcut to access VE (Alt+Shift+v) is not working from action=edit in FF browser - 10https://bugzilla.wikimedia.org/67218 (10James Forrester) [16:02:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756#c3 (10James Forrester) 5PATC>3ASSI Seems to be a mis-tag. [16:05:18] James_F, http://jsfiddle.net/edg2s/HA9qt/ (firefox) [16:11:06] edsanders: Filing a bug with Mozilla about this? [16:11:20] it'll be fixed in 5-10 years https://bugzilla.mozilla.org/show_bug.cgi?id=1037004 [16:11:33] Ha. [16:12:31] 3VisualEditor / 3ContentEditable: VisualEditor: Problems typing after cursoring off an inline focusable nodes in Firefox - 10https://bugzilla.wikimedia.org/67432#c7 (10Ed Sanders) Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1037004 [16:13:01] 3VisualEditor / 3Editing Tools: VisualEditor: Deprecated param w/out description text "no description" isn't in italic grey - 10https://bugzilla.wikimedia.org/67794 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low [16:13:21] (03CR) 10Jforrester: [C: 031] Make sure the document is focused when setting a selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145346 (https://bugzilla.wikimedia.org/67432) (owner: 10Esanders) [16:21:16] 3OOjs UI: OOjs UI: A 'small' dialog doesn't fit a field label and a input field - 10https://bugzilla.wikimedia.org/67354#c2 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal Or just stack the label and field vertically? [16:49:59] (03PS6) 10Zfilipin: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [16:50:52] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy) [16:58:20] (03Abandoned) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (35e5b4b331) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [17:06:04] (03CR) 10Krinkle: [C: 032] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [17:06:58] (03Merged) 10jenkins-bot: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/core] - 10https://gerrit.wikimedia.org/r/144606 (owner: 10Jforrester) [17:17:29] Krinkle: Woo. [17:19:17] (03CR) 10Krinkle: build: Implement 'phantomcheck' task (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [17:20:13] James_F: So um...we have a position: top script that we might want to skipFunction if OOJS doesn't load. [17:20:21] I don't think OOJS is top-loaded [17:20:38] Is this A) A bad idea, B) A terrible idea [17:22:37] marktraceur: Are you top-loading only the very most minimal code you possibly can? [17:22:58] Yeah, but if we have to wait for OOJS to load to know if it will work...skipFunction probably isn't the answer [17:23:06] marktraceur: Oh, sorry, yeah. (B). [17:23:09] I mean, it can be for the most part [17:23:19] But I'll have to do something else for the top-loader [17:24:50] What kind of JS do you think you can run on boxes that can't run OOjs? [17:24:57] James_F: Wait - do mw.loader.using calls ignore the skipFunction? [17:25:03] Yes. [17:25:09] K, that explains *that* [17:25:18] I think. [17:25:18] marktraceur: The only thing top modules should be is styles-only for server output, or js that effects dom above the fold (which should just be light weight jQuery code adding event listerners and some placeholder elements maybe) [17:25:43] Krinkle: Which is what we have, but the event handlers call mw.loader.using on our main code. [17:25:48] Which is t3h suck. [17:26:01] ? [17:26:14] Ugh, one sec [17:26:23] skipFunction is part of the regular load system. It is never ignored or bypassed. [17:26:30] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMultimediaViewer.git/5edb949d017df55c77e20fd27af7981c95546be8/resources%2Fmmv%2Fmmv.head.js [17:26:40] And yet I see it loading [17:26:42] Krinkle: Oh, I thought… never mind. [17:26:55] If you request a module, no matter how (load, using, dependency, whateve), it will use the skipFunction and fetch otherwise. [17:27:13] marktraceur: What's wrong with using the dependency, BTW? [17:27:39] If it's loading, your skipFunction is probably broken :P [17:28:29] Hrm [17:29:03] marktraceur: I think you're misunderstanding what skipFunction is for. [17:29:07] Maybe. [17:29:13] I don't see how head.js relates to skipFunction [17:29:26] OOjs doesn't "not load", it always loads [17:29:30] it supports es3 now [17:29:36] (if you depend on it, that is) [17:29:37] Krinkle: It might help if there was some documentation, to be fair. :-) [17:29:50] Its' documented more than most other code I'd say. [17:29:57] That's not high praise. [17:30:09] And it is documented and tested "in the code". Quite elaborately. [17:30:16] True. [17:30:23] But as with most types of documentation, the problem isn't writing it, the problem is getting peopl to read it [17:31:29] https://github.com/wikimedia/mediawiki-core/blob/edbc1ae374b6dd3e9702f09634f041545ea95469/includes/resourceloader/ResourceLoaderModule.php#L295-L309 [17:32:13] e.g. if a module defines Array.isArray or JSON.stringify, it can use a skip function to avoid fetching lots of javascipt that won't be used. [17:32:27] But it is still a dependency that, when dependened on, must fullfill its contract [17:32:46] eg. depending on 'json' ensures JSON.stringify is present, just like mediaiwki.title does for mw.Title [17:33:14] OK so [17:33:35] I'm just going to close https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/574 as invalid [17:33:39] Sound sane? [17:33:39] marktraceur: so, 1) skipFunction is probably not what you want, and 2) is loading because you asked us to support ES3, it is never skipped. [17:33:49] oojs that is [17:34:09] marktraceur: Yes. 574 sounds like "If the world has ended, still try to work". [17:34:13] If OOUI fails I think we already skip loading the things that use it [17:34:19] The title of that bug conflicts with the enhancements "OOjs should support IE8" and "OOjs should support ES3" [17:34:22] we even support IE6 now [17:34:23] marktraceur: [17:34:27] James_F: 6 o'clock, TV hour, don't get caught without the viewer [17:34:39] Slash and burn, return, listen to Gwillhickers churn [17:34:44] marktraceur: … OK. [17:35:06] marktraceur: yep close as invalid because oojs is always gonna work [17:35:17] K [17:35:20] or worksforme, whatever suites you :) [17:35:28] suits [17:35:32] Krinkle: No, I'm using an ES2 browser so [17:35:36] It's always broken [17:35:41] marktraceur: Nope, even then [17:35:44] Trollolololo. [17:35:45] marktraceur: because startup will abort [17:35:55] before any of this comes into play [17:36:19] Krinkle: Argh, I thought https://gerrit.wikimedia.org/r/#/c/144359/ was merged. We should get that out ASAP. [17:38:17] James_F: last I checked it didn't check out. looked like maybe it was patched. Will verify again [17:39:34] Krinkle: Thanks. [18:01:42] (03PS12) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [18:02:04] 3VisualEditor / 3Editing Tools: VisualEditor: None of the cite options or templates are opening in Betalabs , throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Cannot open any cite options... [18:03:00] (03PS13) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [18:03:23] edsanders: https://gerrit.wikimedia.org/r/#/c/141089/ now is bundled into a pull-through [18:03:31] no separate dependency needed [18:04:00] (03PS8) 10Trevor Parscal: [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [18:04:31] Woo. [18:05:00] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [18:05:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:05:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13] None of the cite options or template dialogs are opening in Betalabs , throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814 (10ryasmeen) a:3Alex Monk [18:07:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Highes s:5norma... [18:13:31] 3VisualEditor / 3ContentEditable: VisualEditor: Mouse up outside the surface doesn't register a selection change. - 10https://bugzilla.wikimedia.org/59822#c1 (10Ed Sanders) Perhaps we should be using document.onselectionchange to update the model selection (polyfill: https://github.com/2is10/selectionchange-... [18:16:15] (03CR) 10Esanders: [C: 04-1] "visualeditor-dialog-action-done message not resolving" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [18:16:50] (03CR) 10Esanders: "and still seeing scrollbars on language inspector" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [18:26:02] 3VisualEditor / 3ContentEditable: VisualEditor: Mouse up outside the surface doesn't register a selection change. - 10https://bugzilla.wikimedia.org/59822#c2 (10Ed Sanders) Or just stop the surface observer from being disabled. We currently have a bug whereby if you create a selection on a blurred document t... [18:41:53] (03CR) 10Jforrester: build: Implement 'phantomcheck' task (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [18:45:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:55:20] (03CR) 10Krinkle: build: Implement 'phantomcheck' task (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [19:00:26] Krenair: so, you replaced use of ve.bind( func, context ) with func.bind( context ) [19:03:26] (03CR) 10Esanders: "I don't understand?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 (owner: 10Esanders) [19:04:58] (03PS2) 10Esanders: Fix alien test data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 [19:05:00] (03PS4) 10Esanders: Fixes to getRelativeOffset and getRelativeRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144136 (https://bugzilla.wikimedia.org/67551) [19:05:53] (03PS7) 10Esanders: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 [19:08:48] 3OOjs UI: OOjs UI: InlineMenuWidget doesn't handle mouse events properly - 10https://bugzilla.wikimedia.org/67821 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3Trevor Parscal Clicking on the widget twice at the top should close it, however the second mousedown closes it and the second mouseup opens it aga... [19:21:02] (03PS9) 10Trevor Parscal: Update VE core submodule to 1e359680539cd8348f64911fb3dd0227228fbad9 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [19:22:47] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 1e359680539cd8348f64911fb3dd0227228fbad9 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [19:30:01] edsanders: I think on https://gerrit.wikimedia.org/r/#/c/144328/ Krinkle|detached Meant that if the comment disagrees with the code and you change the code, you should expect a test to fail rather than it just continuing to work (elsewise, what was the point of the comment). I think. Maybe. [19:38:47] 3OOjs UI: OOjs UI: InlineMenuWidget doesn't handle mouse events properly - 10https://bugzilla.wikimedia.org/67821 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:41:16] 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c21 (10Ad Huikeshoven) On nl.wp a discussion has started to turn on VE. In the process feedback has been collected... [19:42:47] 3VisualEditor / 3Data Model: VisualEditor: Pressing right in a slug a the end of a document takes you back to before the slug-causing node - 10https://bugzilla.wikimedia.org/67551 (10James Forrester) p:5Unprio>3High a:3Ed Sanders [19:47:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add a Preview feature to show actual version of page (minus slugs, etc.) - 10https://bugzilla.wikimedia.org/60535 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [19:47:32] 3VisualEditor / 3ContentEditable: VisualEditor: Add a Preview feature to show actual version of page (minus slugs, etc.) - 10https://bugzilla.wikimedia.org/60535 (10James Forrester) [19:50:04] 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c22 (10James Forrester) (In reply to Ad Huikeshoven from comment #21) > On nl.wp a discussion has started to turn o... [19:55:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) p:5High>3Highes [19:55:08] edsanders: I feel that https://bugzilla.wikimedia.org/show_bug.cgi?id=67326 is our biggest issue right now – have you had a chance to look at it again? [20:20:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: References/images require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c11 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:21:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002#c11 (10ryasmeen) Verified the fix in production [20:21:18] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002 (10ryasmeen) 5RESO/?>3VERI [20:22:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c9 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:23:38] Krenair: so, you replaced use of ve.bind( func, context ) with func.bind( context ) [20:23:40] Yep. [20:24:28] Krenair: Hey. Did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=67814 – is that breakage due to the bind changes? [20:27:02] 3VisualEditor / 3Mobile: VisualEditor Mobile: Link inspector gets unresponsive once you delete all the content of a page and click on link inspector icon - 10https://bugzilla.wikimedia.org/65418#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:28:56] uhhh... maybe, looking into it now [20:29:27] Ta. [20:32:48] Okay so this is coming out of MWParameterPage [20:33:00] There I changed this.$label.on( 'click', ve.bind( this.onLabelClick, this ) ); to this.$label.on( 'click', this.onLabelClick.bind( this ) ); [20:33:03] fine, onLabelClick is definitely defined [20:33:17] But I also changed this.$description.on( 'click', ve.bind( this.onDescriptionClick, this ) ); to this.$description.on( 'click', this.onDescriptionClick.bind( this ) ); [20:33:38] I don't know where onDescriptionClick is defined. It's not here or the OOUI source [20:33:44] It's probably not defined anywhere, hence this error? [20:36:48] If I go back to the commit before my bind changes, console.log shows that function is undefined [20:36:49] So my change just showed that this is useless (except it now breaks everything, whoops) [20:39:56] (03PS1) 10Alex Monk: Fix cite/template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145427 (https://bugzilla.wikimedia.org/67814) [20:40:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814 (10Alex Monk) [20:40:34] James_F, did this bug go to prod? [20:41:03] obviously it needs to be cherry-picked to wmf13 [20:51:00] James_F, you there? [20:54:27] TrevorParscal, the other file in MF is VisualEditorOverlay.less, but it seems it's mostly toolbar styling [20:57:56] ok [21:01:18] Krenair: Yes, sorry, it was in wmf13. Cherry-pick-fun-times. [21:01:36] wmf13 went to prod, did the breakage go with it? [21:01:40] Yes. [21:02:10] So we need someone to deploy the fix [21:03:45] (03CR) 10Trevor Parscal: [C: 032] Fix cite/template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145427 (https://bugzilla.wikimedia.org/67814) (owner: 10Alex Monk) [21:04:00] (03PS1) 10Jforrester: Fix cite/template dialogs [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145431 (https://bugzilla.wikimedia.org/67814) [21:04:15] Krenair: I'll put it in the SWAT in 2 hours' time. [21:04:20] (03PS2) 10Alex Monk: Fix cite/template dialogs [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145431 (https://bugzilla.wikimedia.org/67814) (owner: 10Jforrester) [21:04:40] Ha. :-) [21:04:43] whoops, looks like we both cherry-picked it [21:04:48] No matter. [21:04:54] And your 'uploaded ps1' comment got lost in the process. [21:04:57] Feel free to +2. [21:05:03] Yeah, gerrit can get screwy in some cases. [21:05:05] Um [21:05:08] It's in 1.23, James [21:05:17] Oh, yeah, you don't have deploy rights (yet). :-) [21:05:30] You keep saying 'yet' :p [21:05:34] I do. :-D [21:05:52] (03Merged) 10jenkins-bot: Fix cite/template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145427 (https://bugzilla.wikimedia.org/67814) (owner: 10Alex Monk) [21:05:56] wmf/1.24wmf13, even. [21:06:01] (I said 1.23, wut?) [21:06:03] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326#c14 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:08:23] James_F, do you need to talk to Terry to get that done or...? [21:09:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the link suggestions are appearing on CE when you close the link inspector keeping the keyboard open - 10https://bugzilla.wikimedia.org/67399#c7 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:09:46] (03PS33) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [21:10:54] (03PS1) 10Trevor Parscal: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 [21:11:53] (03PS14) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [21:12:08] (03PS10) 10Trevor Parscal: Update VE core submodule to 1e359680539cd8348f64911fb3dd0227228fbad9 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [21:12:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 1e359680539cd8348f64911fb3dd0227228fbad9 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:12:49] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [21:15:17] Krenair: We have to wait 'til November. [21:15:38] really? -.- [21:17:43] Krenair: Sadly. [21:17:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814#c5 (10Alex Monk) Fixed on master. Need to get a deployer to deal with... [21:17:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814 (10Alex Monk) 5PATC>3RESO/FIX [21:17:50] Krenair: 'Tis only a few months away. [21:18:28] yeah, just over 4 months [21:22:22] Krenair: Whilst you're on a roll (;-)) want to look at https://bugzilla.wikimedia.org/show_bug.cgi?id=67326 ? It's pretty ugly breakage on enwiki right now… [21:23:47] 3VisualEditor / 3Editing Tools: VisualEditor: Deleting a block item highlights the previous line - 10https://bugzilla.wikimedia.org/67213#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:27:02] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494#c7 (10ryasmeen) Verified the fix in production [21:29:02] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494 (10ryasmeen) 5RESO/?>3VERI [21:32:27] James_F, hmm... how do I get parsoid to recognise tags again? [21:32:39] It's sending them back to me as plain text :/ [21:32:49] I think I need to purge the cache or restart parsoid or something [21:33:22] Krenair: Very odd. [21:33:30] Yeah, restart Parsoid often fixes issues. [21:33:32] ah, something I did fixed it [21:33:36] probably the restart [21:33:49] (03PS1) 10Esanders: Keep focus when live editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) [21:34:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Offer to retain changes when switching to the "Edit Source" tab - 10https://bugzilla.wikimedia.org/57462#c11 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:34:04] Krenair, you need to restart Parsoid [21:37:04] Hmm... If I type a backslash in the formulae editor it just removes the formula [21:37:23] or a space with a \ [21:40:26] You mean it updates it to have the content of the '\'? (Blanks and replaces?) [21:40:29] Or something else? [21:43:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:46:28] James_F, right, so it's simply because the focus was lost that the second character typed does weird stuff [21:46:36] I just happened to be typing \s, I think [21:46:51] Krenair: Ah, right. [21:47:47] 3VisualEditor / 3Editing Tools: VisualEditor:Disable "Apply changes" button on Media Search dialog now that the Edit and search dialog both are merged - 10https://bugzilla.wikimedia.org/67443#c4 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:48:07] (03PS1) 10Esanders: generateContents -> generatedContents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145445 [21:48:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437#c5 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:49:03] (03CR) 10Jforrester: [C: 031] generateContents -> generatedContents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145445 (owner: 10Esanders) [21:49:32] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384#c5 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:49:56] (03PS1) 10Esanders: [BREAKING CHANGE] Remove generatedContents argument from afterRender [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145446 [21:50:37] (03CR) 10Esanders: "Was being used in math node, but is fixed by If2458010220." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145446 (owner: 10Esanders) [21:53:58] (03CR) 10Esanders: "it's only a local var rename..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145445 (owner: 10Esanders) [21:54:20] (03CR) 10Jforrester: [C: 032] "Didn't want to merge in advance of more coming along. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145445 (owner: 10Esanders) [21:55:09] edsanders: Is ^^^ (and https://gerrit.wikimedia.org/r/#/c/145444/1/modules/VisualEditor/ve.ce.MWMathNode.js in particular) a fix for the formula oddness? [21:55:43] (03PS15) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [21:55:48] (03PS1) 10Jforrester: Add toolbar menu labels to each group for consistency [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145448 [21:56:18] (03PS11) 10Trevor Parscal: Update VE core submodule to eecc7457b90350a2c925f618efbd6f4cf6a022a1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [21:56:36] that's 145442 [21:56:37] (03PS34) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [21:56:53] the code in math fixes another issue with the highlight not redrawing properly [21:57:03] Oh. Aha. Thanks! [21:57:04] because we were no longer finding the image tag correctly, and so not waiting for it to load [21:57:09] Cc Krenair. [21:57:18] Ha. Of course. [21:57:30] Yay for GCN fixes breaking things. [21:57:54] Krenair: Sorry for sending you down the rabbit-hole on this one. [21:58:09] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (c41e956c5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [21:58:26] Yeah I've just been messing with this [21:58:43] (03Merged) 10jenkins-bot: generateContents -> generatedContents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145445 (owner: 10Esanders) [21:58:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to eecc7457b90350a2c925f618efbd6f4cf6a022a1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:59:05] Was just looking for the .filter method myself. [21:59:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753 (10ryasmeen) [22:01:12] (03PS16) 10Trevor Parscal: Update OOjs UI v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [22:01:14] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145451 [22:01:34] (03PS12) 10Trevor Parscal: Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [22:02:03] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [22:02:11] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [22:02:33] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145451 (owner: 10Trevor Parscal) [22:03:36] I probably just gave that change the wrong bug number [22:06:05] (03PS13) 10Trevor Parscal: Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [22:06:52] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [22:10:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814#c6 (10ryasmeen) Verified the fix in Betalabs [22:14:17] (03CR) 10Krinkle: "The comment said alienInline, the code said alienBlock. Assuming this part o the example tree is actually used by a test, shouldn't this b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 (owner: 10Esanders) [22:14:48] (03CR) 10Krinkle: "If not, unless the test only needed it to be an alien of some kind, look like this might be a dead node that is better off removed (or use" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 (owner: 10Esanders) [22:17:10] Krenair: Thoughts about back-porting https://gerrit.wikimedia.org/r/#/c/145442/ ? [22:22:34] busy messing with finance [22:24:53] Fun. [22:39:17] James_F: Today was pretty geat. [22:39:56] v8 was broken, es5-shim was broken, Sinon.JS was broken and then some I forgot. They all made minor releases and we're running the edge again, all working. [22:40:16] the v8 update will roll out later, but it obsolete now that es5-shim and sinonjs made patches instead. [22:40:30] open source at its best :) [22:40:42] (to be fair, I did do the work for them, they only had to merge my patch and make a minor release) [22:45:30] Krinkle, yay [22:45:40] glad that mess of a problem got sorted [22:45:53] Krenair: Can you merge the 'proper' patches that replace the hotfixes of today? [22:46:07] https://gerrit.wikimedia.org/r/#/c/145291/ and https://gerrit.wikimedia.org/r/#/c/145429/ [22:47:23] Today? I wasn't planning to merge those at all. [22:48:34] I don't think I know enough about all the other unrelated changes to +2 them [22:49:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753 (10ryasmeen) [22:50:59] Krenair: It's a minor update with detailed changelog (and the tests pass). [22:51:03] But no worries. [22:58:24] Krinkle: Yeah. Fun. [22:58:34] Krinkle: I can merge at least es5-shim with testing. [22:58:39] Krinkle: Give me a second or two. [22:58:42] k [22:58:57] Krinkle: Swap for you merging https://gerrit.wikimedia.org/r/#/c/139550/ ? :-) [22:59:07] Also nice how github links our mediawiki-core commits to that issue [22:59:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] In iOS Safari, cannot open any page as it throws error "Error,can't load section" - 10https://bugzilla.wikimedia.org/67508#c6 (10ryasmeen) Verified the fix in test2 [22:59:21] That might've triggered a "oh, Wikipedia is using my library?" [22:59:28] (03PS1) 10Jforrester: Move 'language' tool from the insert to the styling menu, like in VE-MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145458 [22:59:30] (03PS1) 10Jforrester: Remove label from 'insert' menu, and instead use a large plus icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145459 [22:59:38] I didn't mean for that to be linked [22:59:39] Krinkle: Yeah. :-) [22:59:48] When I was reading it now I saw my own commit there [22:59:50] Krinkle: GitHub being magic, I assume? [22:59:56] "Krinkle referenced this issue from a commit in wikimedia/mediawiki-core 9 hours ago" [22:59:57] yeah [23:00:01] * James_F grins. [23:00:03] foo/bar#1234 works always [23:00:06] but urls work, too [23:00:19] On https://github.com/wikimedia/mediawiki-core/commit/dcdca4944dec1228b6ca38955298c8a541f01378 it even displays it like that [23:00:43] even though the actual commit contains a url, the front-end rendering doesn't only linkify it but also prettifies the label [23:00:46] https://gerrit.wikimedia.org/r/#/c/145304/ [23:00:49] James_F: OK, deal [23:00:57] Oh wait, I didn't look at the link [23:01:05] Ha. :-D [23:01:11] I'll make progress. [23:01:14] But seriously, we really need that to land ASAP. [23:01:18] Did ed/Trevor make any progress? [23:01:35] 2 patch sets I see. No comments from Ed yet though. [23:01:37] Yeah, everything on top of it should be good to go now. [23:01:42] Ed was working on other breakages. [23:01:49] (Outside of this patch set). [23:01:56] (03PS2) 10Krinkle: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal) [23:02:11] k [23:03:24] (03CR) 10Mwalker: [C: 032] Fix cite/template dialogs [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145431 (https://bugzilla.wikimedia.org/67814) (owner: 10Jforrester) [23:04:51] Krinkle: Minor comment re the release ntoes. [23:04:55] Notes. [23:06:18] (03Merged) 10jenkins-bot: Fix cite/template dialogs [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/145431 (https://bugzilla.wikimedia.org/67814) (owner: 10Jforrester) [23:13:17] 3VisualEditor / 3Editing Tools: VisualEditor: When text is being made superscripted and is already subscripted, clear the latter (and vice versa) - 10https://bugzilla.wikimedia.org/53330#c21 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [23:14:17] 3VisualEditor / 3Editing Tools: VisualEditor: When text is being made superscripted and is already subscripted, clear the latter (and vice versa) - 10https://bugzilla.wikimedia.org/53330 (10ryasmeen) [23:28:50] (03PS35) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:29:23] Krinkle: Random indents in modules.json? [23:29:35] (03CR) 10Krinkle: "Alphabetised modules.json (was a bit arbitrary and hard to understand), and made dependencies clearer using indentation. The order is alph" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [23:29:38] Krinkle: I mean, I sort-of understand the idea, but… multiple inheritance, man. [23:29:47] James_F: There is no such thing in javascript [23:29:59] Krinkle: We call them "mixins". [23:30:09] Krinkle: It's this great technology called OOjs. ;-P [23:30:17] mixins themselves don't inherit, and those are always defined ahead of time. [23:30:19] Krinkle: You may remember having invented it. [23:30:23] The problem is just that the order was random. [23:30:32] 3VisualEditor / 3Editing Tools: VisualEditor: For large SVG images while trying to make it full size, it says "Size values are invalid" - 10https://bugzilla.wikimedia.org/66865#c4 (10ryasmeen) Verified the fix in production [23:30:36] and when I was tyring to debug something just now, it took like a dozen tries to get it right [23:30:40] Certainly the order was bad, yeah. [23:30:49] It just makes me feel queasy to see that. [23:30:54] I'm not sure how to make it appear not random and also maintainable. [23:31:09] Yeah. [23:31:11] Oh well. [23:31:48] Just going through all the code trying to understand it, and making the assumption that if I couldn't understand it, it needs to be indicated ever so slightly better. [23:31:57] * James_F nods. [23:31:59] optimising for maintenance :) [23:32:01] Fair. [23:32:02] * James_F grins. [23:32:22] the tree is courtesy of jsduck btw [23:32:28] saved me a lot of time [23:32:35] in teh sidebar there is an inheritance mode [23:32:45] Right. [23:33:16] (IN FUTURE ONCE YOU'VE MERGED THIS) Maybe there's a way to get grunt to auto-re-order modules.json. [23:34:08] Gah. [23:34:13] I shouldn't have said that. [23:34:27] We'll next hear from you in two days when you've come up with a way to do that. :-P [23:35:20] 3VisualEditor / 3Editing Tools: VisualEditor: "Make full Size" is not enabling "Apply changes" button therefore cannot make any image fullsize - 10https://bugzilla.wikimedia.org/67624#c2 (10ryasmeen) Verified the fix in test2 [23:39:46] James_F: In dialogs demo, RTL mode has the parenthesis wrong way around. Probably should mark those labels as ltr. I think that's in master though, right? Could you look into that? [23:41:43] Also, when switching to RTL after opening at least one dialog, the dialogs opened after switching will be wrong (something is probably being cached). I don't think we're supposed to support that, so the demo should probably just reload. And generating them with a .template like in VE would be nice too. [23:42:11] (03CR) 10Alex Monk: "See how EditPage::internalAttemptSave does it (search for AS_NO_CREATE_PERMISSION)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [23:47:28] James_F: are you thinking a grunt task that reorders it based on inheritance? [23:55:30] TrevorParscal: I'm adding a few things to the widgets demo locally. Got a minute to chat about a few things? Mostly just understanding, potentially changing if you feel its appropiate. [23:55:35] ActionWidget, that hover effect [23:55:36] Neat [23:55:45] But part of the dialog, not ActionWidget. [23:56:11] Should it be in ActionWidget in general instead of only when inside .oo-ui-processDialog-actions? [23:56:29] Or do you think Actionwidgets will be used elsewhere where they shouldn't have that affect? [23:56:30] effect* [23:57:03] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c15 (10ryasmeen) Verified the fix in test2 [23:59:29] TrevorParscal: Also, so it seems ActionWidget is meant for logic, not different display. Okay. It's main speciality seems to be the .action and .modes. It also has propagateResize. I'm not sure how to trigger that, where is that made use of? It seems they're always in the corner of a dialog where their size doesn't change? [23:59:57] The resize logic seems quite useful but want to see it in actino. [23:59:59] action