[00:04:14] <Krinkle>	 James_F: ^ < TrevorParscal :)
[00:04:48] <Krinkle>	 If he has an half hour for quick q/a as I review the root, and then review the rest after he's gone, that'd be helpful
[00:21:04] <James_F>	 Krinkle: Hey, sorry, was away talking to TrevorP|Away, who's now gone.
[00:21:37] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c6 (10Alex Monk) Ping. Anyone want to answer my question?
[00:22:29] <James_F>	 Krinkle: The propagateResize magic is used somewhere – the orientation changes maybe? – but I don't have a link to hand.
[00:23:00] <James_F>	 Krinkle: I might possibly be able to help re. the widgets demo if you want (as I've seen most of it as it's been built).
[00:23:03] <James_F>	 Krenair: Bah, sorry.
[00:23:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference - 10https://bugzilla.wikimedia.org/52182#c7 (10James Forrester) 5ASSI>3RESO/FIX Yes, sorry, this was great. Thanks!
[00:24:02] <Krenair>	 James_F, it was more for John Mark Vandenberg than you
[00:24:40] <Krenair>	 (he suggested deleting, but I had just fixed disabling stuff instead. I was asking if we should leave it as it is)
[00:24:46] <James_F>	 Krenair: However, as Product Owner, I'm just going to declare it fine. :-)
[00:24:56] <Krenair>	 heh
[00:33:52] <grrrit-wm>	 (03PS17) 10Jforrester: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[00:34:23] <grrrit-wm>	 (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145451 (owner: 10Trevor Parscal)
[00:34:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[00:38:34] <grrrit-wm>	 (03PS18) 10Jforrester: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[00:39:14] <grrrit-wm>	 (03CR) 10Jforrester: "PS17 rebases onto the latest version of the (as-yet unmerged) OOjs UI." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[00:40:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[00:51:24] <James_F>	 Krinkle: Is .doc/categories.json in VE-core generated automatically somehow?
[00:51:32] <Krinkle>	 Probably
[00:51:33] <Krinkle>	 grunt
[00:51:36] <Krinkle>	 oojs-ui + ve-core
[00:51:52] <Krinkle>	 fyi, I *am* reviewing the big commit
[00:52:04] <James_F>	 Awesome.
[00:52:13] <James_F>	 (And no, it appears not. *sigh*)
[01:00:27] <grrrit-wm>	 (03PS36) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[01:00:41] <grrrit-wm>	 (03CR) 10Krinkle: "Add demos for frameless/flagged buttons." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[01:01:05] <grrrit-wm>	 (03PS37) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[01:03:48] <grrrit-wm>	 (03CR) 10Krinkle: "The 'simple' dialog in the demo was far from a simple dialog (had Action and Process dialog applied and lots of inline code to make it wor" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[01:10:52] <grrrit-wm>	 (03PS19) 10Jforrester: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[01:14:11] <Krenair>	 Krinkle, so what are we going to do with PhantomJS + bind + VE core/OOUI?
[02:31:05] <Krinkle>	 James_F: Do you know anything that uses PopupWidget or Tool
[02:31:11] <Krinkle>	 PopupTool
[02:31:19] <Krinkle>	 I can't find it anywhere in the demos or even elsewhere
[02:31:26] <Krinkle>	 I'm not sure what it means by Popup
[02:31:37] <James_F>	 Krinkle: It's used in the template dialog.
[02:31:45] <Krinkle>	 I assume not windows or inspects. I also ruled out drop down menus that "pop out" of a toolbutton
[02:32:01] <James_F>	 It's the little (i) icon output against transclusion parameters for info about them.
[02:32:13] <James_F>	 It "pops up" from the trigger position.
[02:32:21] <James_F>	 Probably could do with fleshing out (and a better name), but…
[02:32:52] <grrrit-wm>	 (03PS3) 10Jforrester: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal)
[02:33:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal)
[02:33:50] <Krinkle>	 James_F: Can you verify something weird so I know it's not my lcoalhost?
[02:33:57] <James_F>	 Krinkle: Sure.
[02:34:00] <Krinkle>	 Edit a page with {{Special:AllPages}}
[02:34:16] <Krinkle>	 I don;t think it's an edge case, I just haven't narrowed it down yet to what it is
[02:34:17] <James_F>	 In VE?
[02:34:19] <Krinkle>	 Yeah
[02:34:29] <Krinkle>	 Then go to Show otions
[02:34:41] <Krinkle>	 add template "Unsigned" (or anything that has tempalte data)
[02:35:11] <Krinkle>	 There's no input fields for parameters or anything
[02:35:15] <Krinkle>	 http://i.imgur.com/ZwefNG4.png
[02:35:37] <Krinkle>	 shouldn't there be like list of suggestions here normally?
[02:35:57] <James_F>	 No.
[02:36:07] <James_F>	 Only shown below there in single-template mode.
[02:36:24] <Krinkle>	 When I click +[] (parameter) on the bottom left, then it appeas
[02:36:29] <James_F>	 Yeah.
[02:36:52] <James_F>	 Maybe we should change it, but later. :-)
[02:37:04] <James_F>	 (That's how it works in master too.)
[02:37:04] <Krinkle>	 That could just happen by default considering it doesnt' actually add a parameter yet. We do that for simple mode as well, and I'm quite sure it used to do that for the advanced one too bfore we had a simple one
[02:37:14] * James_F nods.
[02:37:16] <James_F>	 Yup.
[02:48:31] <grrrit-wm>	 (03PS38) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[02:51:27] <grrrit-wm>	 (03CR) 10Krinkle: "Added PopupWidget demo." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[02:51:28] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] "Reviewed all files." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[02:51:30] <James_F>	 Krinkle: That looks good to me.
[02:51:54] <Krinkle>	 There's my report for tonight. Everything else seems good and is tested in a demo or in VE.
[02:52:00] * James_F nods.
[02:52:03] <James_F>	 Thanks!
[02:52:44] <Krinkle>	 o/
[03:09:12] <grrrit-wm>	 (03PS8) 10Krinkle: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[03:09:41] <grrrit-wm>	 (03CR) 10Krinkle: "Added tabs/prettify to the JSON embed and formatted it similarly to regular assignments." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[03:10:45] <grrrit-wm>	 (03PS9) 10Krinkle: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[03:11:07] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] "Removed stray trim() call, oops." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[04:21:22] <grrrit-wm>	 (03CR) 10Krinkle: "https://github.com/wikimedia/mediawiki-extensions-VisualEditor/search?q=ve-mw%2Ftest&type=Code" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin)
[07:48:57] <grrrit-wm>	 (03PS6) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[07:49:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[08:01:14] <grrrit-wm>	 (03PS7) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[08:01:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[08:05:43] <grrrit-wm>	 (03PS8) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[08:06:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[08:10:03] <grrrit-wm>	 (03PS9) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[08:10:13] * mooeypoo stares jenkins down
[08:10:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[08:12:21] <mooeypoo>	 Krinkle|detached, any objections to having grunt + qunit tests in TemplateData extension? It will really make my life easier. I can try and follow the same grunt jscs/jshint stuff from VE.
[09:09:51] <grrrit-wm>	 (03PS4) 10Zfilipin: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 
[09:11:09] <grrrit-wm>	 (03CR) 10Zfilipin: "Thanks Krinkle, I should have figured that out myself. :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin)
[10:01:52] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "+1'ing Timo's changes. 1+1=2." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[10:03:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Widgetise demo menu [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143330 (owner: 10Esanders)
[10:08:58] <grrrit-wm>	 (03PS20) 10Esanders: Update OOjs UI to v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[10:17:57] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] "The scroll height issue appears to be a rounding error. getBodyHeight on a fragment inspector returns 150.200px for this.form.$element.out" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[10:39:38] <grrrit-wm>	 (03PS1) 10Esanders: Add toolbar action section to SA demo with keyboard shortcuts tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145533 
[10:40:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add toolbar action section to SA demo with keyboard shortcuts tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145533 (owner: 10Esanders)
[11:15:28] <grrrit-wm>	 (03PS1) 10Esanders: Split toolbar demo in two and add action button demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 
[11:23:41] <grrrit-wm>	 (03PS2) 10Esanders: Split toolbar demo in two and add action button demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 
[11:27:51] <grrrit-wm>	 (03PS1) 10Esanders: Prevent disabled tools from stealing focus [oojs/ui] - 10https://gerrit.wikimedia.org/r/145542 
[11:47:09] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[11:59:22] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[12:17:50] <wikibugs>	 3VisualEditor / 3ContentEditable: VE edit mode shows formatting code transcluded frome table cell template - 10https://bugzilla.wikimedia.org/67850 (10Ad Huikeshoven) 3NEW p:3Unprio s:3normal a:3None Some articles like https://nl.wikipedia.org/wiki/Justine_Henin?veaction=edit and other articles about...
[12:18:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VE edit mode shows formatting code transcluded frome table cell template - 10https://bugzilla.wikimedia.org/67850 (10Ad Huikeshoven) p:5Unprio>3High s:5normal>3blocke
[13:02:08] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145448 (owner: 10Jforrester)
[14:52:04] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Table cell templates are editable, but their re-rendering is broken - 10https://bugzilla.wikimedia.org/67856 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 15909   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15909&acti...
[14:52:19] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog shouldn't render empty text nodes - 10https://bugzilla.wikimedia.org/67857 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 15910   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15910&action=edit Screen...
[15:02:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c23 (10Ad Huikeshoven) Ok to take the conversation there. I've read through bug 47790 and the reported issues are m...
[15:40:00] <James_F>	 Heya.
[16:04:15] <Krenair>	 hey
[16:15:47] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c24 (10James Forrester) (In reply to Ad Huikeshoven from comment #23) > Ok to take the conversation there. I've rea...
[16:51:03] <wikibugs>	 3VisualEditor / 3ContentEditable: Cursor jumps around when editing - 10https://bugzilla.wikimedia.org/67862 (10Reaper Eternal) 3UNCO p:3Unprio s:3major a:3None When typing, inserting templates, hitting "backspace", and possibly more actions, the cursor moves two characters left after every action. Ob...
[16:54:02] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Down-page of {{IPA-es}} backspace behaviour is very broken - 10https://bugzilla.wikimedia.org/67862#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3High Interesting. It looks like the template IPA-es is causing this. If you delete the template, everything...
[16:57:38] <mooeypoo>	 Krinkle, oh noes, I think I screwed up my own rebase... luckily, I think it's only the language files :\
[16:58:47] <mooeypoo>	 Krinkle, look! <panic> https://gerrit.wikimedia.org/r/#/c/134928/9/i18n/en.json :(
[17:22:34] <grrrit-wm>	 (03PS7) 10Zfilipin: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (owner: 10Vikassy)
[17:29:25] <grrrit-wm>	 (03PS10) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[17:29:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[17:30:23] <James_F|Away>	 mooeypoo: So…
[17:30:47] <mooeypoo>	 James_F|Away, yeah I just fixed a message I apparently forgot.
[17:30:56] <mooeypoo>	 James_F|Away, Krinkle also, grunt works for me now! \o/ thanks Timo!
[17:31:05] <mooeypoo>	 but the i18n files are all screwed up :\
[17:31:45] <mooeypoo>	 I messed up the rebase on them
[17:39:04] <wikibugs>	 3VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868 (10Daniel Naber) 3UNCO p:3Unprio s:3normal a:3None Currently, if you review your changes you need to use the "Return to save form" button and then save. Workflow would be improved if the "Revi...
[17:40:58] <mooeypoo>	 James_F|Away, Krinkle also, the refactor checks if it's in a subpage, and if it is, then "import params" fetches the template code from the root page \o/
[17:41:02] <wikibugs>	 3VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c1 (10Bartosz Dziewoński) 5UNCO>3NEW Oh, that's a neat idea.
[17:42:04] <James_F|Away>	 mooeypoo: Does it check if the current page is a template first?
[17:42:04] <James_F|Away>	 mooeypoo: 'Cos there are 'real' templates that are sub-pages of other templates.
[17:42:20] <James_F|Away>	 mooeypoo: Template:Foo which uses Template:Foo/bar and Template:Foo/baz to do bits of itself.
[17:42:27] <mooeypoo>	 ... damnit.
[17:42:30] * James_F|Away is so unhelpful sometimes. :-(
[17:42:37] <mooeypoo>	 okay, well, the infrastructure's there, so I can adjust it, I bet.
[17:42:50] <mooeypoo>	 It will only operate on Template namespace for sure
[17:43:13] <mooeypoo>	 I could traverse the tree until I find template code -- but that can be quite a mess.
[17:43:37] <mooeypoo>	 I mean, Template:Foo/baz is a template and we're in Template:Foo/baz/docs/templatedata for instance.
[17:43:44] <James_F|Away>	 True.
[17:43:52] <mooeypoo>	 right now it'll just go to Template:Foo directly
[17:44:00] <James_F|Away>	 Try local, and if there's nothing that looks like a parameter, go to the top of the tree?
[17:44:11] * mooeypoo nods 
[17:44:24] <mooeypoo>	 or... we can let the user "tell us" what the template is
[17:44:36] <mooeypoo>	 IE, add a field "template source" or something
[17:44:43] <James_F|Away>	 Eww.
[17:44:45] <James_F|Away>	 Complexity.
[17:45:02] <James_F|Away>	 Hey Krenair.
[17:45:04] <James_F|Away>	 Err.
[17:45:04] <mooeypoo>	 It might actually make things simpler for everyone. The user knows they're dealing with {{TEmplate:Whatever/is/in/there}} 
[17:45:06] <James_F|Away>	 Hey Krinkle.
[17:45:08] * James_F|Away gives up.
[17:45:10] <mooeypoo>	 how many levels down can this go, btw ?
[17:45:17] <James_F>	 mooeypoo: There is no spoon.
[17:45:21] <mooeypoo>	 Lovely.
[17:45:25] <James_F>	 Yeah.
[17:45:36] <James_F>	 There's a 255 character limit of page names, though.
[17:45:46] <mooeypoo>	 oh, that fixes everything, then.
[17:45:56] <James_F>	 So Template:1/2/3/4/5/6/7… can only get you down to the 250th byte.
[17:46:17] <mooeypoo>	 If that's the case, it might actually be useful to let the user tell us what template they're editing. It will also let users edit Template:Foo/bar from Template:Foo/doc
[17:46:24] <mooeypoo>	 edit as in add templatedata
[17:46:42] <James_F>	 In practice I've never seen more than two sub-levels (So Template:foo/bar/doc.)
[17:46:51] <mooeypoo>	 is it always /doc ?
[17:47:01] <James_F>	 No.
[17:47:03] <mooeypoo>	 or rather, is it usually /doc
[17:47:25] <Krinkle>	 I my experience templates never contain slashes as a subpage. It's either used for private utility templates used internally (e.g. your typical /helper, /core /doc etc.) not included in articles, or its decorative and part of the name (The Dutch wikipedia is famous for having "sources, notes and/or citations" as a template)
[17:47:25] <James_F>	 I've never seen an actual template (as opposed to a documentation sub-page) more than 1 sub-level deep.
[17:47:28] <grrrit-wm>	 (03PS2) 10Esanders: Add toolbar action section to SA demo with keyboard shortcuts tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145533 
[17:47:40] <James_F>	 If that's the question.
[17:47:45] <James_F>	 Krinkle: Ha. Useful.
[17:47:52] <James_F>	 Yeah.
[17:48:03] <James_F>	 mooeypoo: Just because your template is Foo/Bar doesn't mean that Foo is an actual template.
[17:48:07] <Krinkle>	 so we probably shouldn't treat it as a hierachy (e.g. don't emphasise the subpage name or display breadcrumbs)
[17:48:07] <mooeypoo>	 okay, so the "import" feature should be fine with taking the code from root 
[17:48:15] <James_F>	 Yeah, that's probably fine.
[17:48:47] <mooeypoo>	 James_F, right, but how would we know if Foo/Bar is this case or that? :\ It seems templates are pretty much the wild west in those cases
[17:49:13] <James_F>	 mooeypoo: MW has a function somewhere, probably.
[17:49:19] <mooeypoo>	 Since this pretty much only affects the "Import" utility, I think it's okay that we assume the code is in root (I can also check first to see if the code is local before going up) 
[17:49:29] <mooeypoo>	 Or letting the user tell the importer where the heck to go
[17:51:47] * James_F nods.
[17:53:16] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c2 (10James Forrester) s:5normal>3enhanc This feels like a bad idea – you'd be letting the user press save without showing them what's in the edit summary…
[17:56:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c3 (10Bartosz Dziewoński) Perhaps the edit summary input box should stay visible, then? I think that would also be useful. I could both wait for the diff to lo...
[17:57:47] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c4 (10James Forrester) (In reply to Bartosz Dziewoński from comment #3) > Perhaps the edit summary input box should stay visible, then? I think that > would al...
[18:11:01] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c5 (10Daniel Naber) @James: see my comment about the escape key: I think the current design is confusing, as the "Review my changes" pages looks a lot like a n...
[18:12:17] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c6 (10James Forrester) (In reply to Daniel Naber from comment #5) > @James: see my comment about the escape key: I think the current design is > confusing, as...
[18:19:49] <grrrit-wm>	 (03CR) 10Trevor Parscal: "In response to the bug you found in OO.ui.PopupWidget, indeed this was a CSS issue to do with collapsing margins. Essentially you saw the " [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[18:21:04] <grrrit-wm>	 (03PS39) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 
[18:21:46] <grrrit-wm>	 (03PS40) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 
[18:24:34] <grrrit-wm>	 (03PS41) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 
[18:25:04] <James_F>	 TrevorParscal: You over-wrote a number of Timo's changes – see https://gerrit.wikimedia.org/r/#/c/139550/38..41/build/modules.json for example. :-(
[18:25:14] <TrevorParscal>	 ?
[18:25:17] <TrevorParscal>	 crap
[18:26:04] <James_F>	 Yeah.
[18:26:44] <TrevorParscal>	 i will fix
[18:30:17] <mooeypoo>	 James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=63389 <-- I think this can be closed, we've renamed that button to "Manage template documentation" which seems clear enough
[18:31:07] <James_F>	 mooeypoo: Given that enwiki just over-rode the message label to say the totally-bewildering "Manage TemplateData" apparently that's not good enough.
[18:31:26] <mooeypoo>	 O.O
[18:31:29] <mooeypoo>	 really?
[18:31:33] <James_F>	 Yeah. :-(
[18:31:43] <mooeypoo>	 oh dear.
[18:32:55] <Krenair>	 I'm pretty sure the i18n team wouldn't let me put something like that in the official messages.
[18:33:47] <James_F>	 Indeed, because it's a bad move.
[18:34:05] * James_F doesn't have the time to explain UX 101 to the whole of enwiki, though.
[18:36:06] <mooeypoo>	 James_F, we did put it in, in the first editor iteration, and they -1'ed it
[18:36:51] <James_F>	 mooeypoo: Ha.
[18:38:07] <mooeypoo>	 James_F, actually, I do believe this was the title of the widget I made in mw.org
[18:38:38] <James_F>	 mooeypoo: BTW, I lost track – I was going to help you fix your rebase for the TemplateData GUI?
[18:38:38] <mooeypoo>	 It's still pretty silly, but it might explain the change
[18:39:10] <mooeypoo>	 James_F, yeah, I'm not sure if I can avoid redoing those i18n files manually :\
[18:39:16] <mooeypoo>	 like, fixing them up. <sigh>
[18:39:44] <mooeypoo>	 https://gerrit.wikimedia.org/r/#/c/134928/10/i18n/en.json and qqq.json
[18:39:46] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c7 (10Daniel Naber) (In reply to James Forrester from comment #6)  > We used to have a booklet on the side of this, but that was more confusing. > The escape k...
[18:39:50] <mooeypoo>	 it's probably not as horrible as it looks
[18:40:05] <James_F>	 You re-sorted them which doesn't help. :-)
[18:40:43] <mooeypoo>	 James_F, the only message I actually added in this fix is "templatedata-modal-errormsg-import-paramsalreadyexist"
[18:40:48] <mooeypoo>	 the rest should exist already
[18:41:14] * James_F fiddles.
[18:41:14] <mooeypoo>	 So it's mostly a matter of reverting.. not sure how that can be done
[18:41:48] <mooeypoo>	 James_F, if there's a way to just revert to the previous version (or master) and then just add "templatedata-modal-errormsg-import-paramsalreadyexist" that wil fix it.
[18:41:54] <Krinkle>	 TrevorParscal: Also be sure to "Expand all comments" in case you missed some (we don't usually repeat them in the last comment)
[18:42:08] <Krinkle>	 I left a comment after each patch set to document what I did
[18:42:14] <TrevorParscal>	 yeah, I am going through them
[18:42:21] <TrevorParscal>	 I'm nearly done fixing my overwriting mistake
[18:43:38] <James_F>	 mooeypoo: `git reset HEAD i18n/en.json` will do that.
[18:51:16] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c8 (10Ltrlg) (In reply to James Forrester from comment #2) > This feels like a bad idea – you'd be letting the user press save without > showing them what's in...
[18:51:54] <mooeypoo>	 James_F, that didn't work :\
[18:54:48] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: new autoadded reflist does not display when in VE edit mode - 10https://bugzilla.wikimedia.org/67873 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None new reflist behavior adds in the reflist to the saved/rendered display like TOC but when in VE...
[19:03:28] * James_F fiddles.
[19:07:07] <grrrit-wm>	 (03PS11) 10Jforrester: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[19:07:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[19:09:43] <James_F>	 mooeypoo: ^^^ OK, i18n clash fixed, the rest (qunit failures) is on you.
[19:09:44] <James_F>	 :-)
[19:09:53] <mooeypoo>	 \o/ thanks James_F !
[19:10:39] <James_F>	 mooeypoo: The trick was to do `git reset HEAD^^ i18n/en.json` – the second ^ because the first was already commited.
[19:10:48] <mooeypoo>	 ohh
[19:11:02] <mooeypoo>	 did you add the 1 missing string? or should I? 
[19:11:18] <mooeypoo>	 oh you did
[19:11:22] <mooeypoo>	 awesomesauce, thanks!!
[19:11:32] * James_F grins.
[19:11:59] <mooeypoo>	 James_F, also, I'm going to fix up the qunit tests and then leave it for review -- there are a bunch of other bugs that can be fixed, but I'm thinking of adding them on top so we can start pushing this out
[19:12:07] * James_F nods.
[19:12:09] <mooeypoo>	 so, splitting the commit from now on after the units are done
[19:13:27] <mooeypoo>	 Krinkle, I did a bit of a tricksy tick there in the recent refactor where I added "view" and "model" prefixes to methods in lieu of namespaces... hope it makes it more readable rather than confusing, some 'view' might be 'ui' but I didn't want to over complicate.
[19:13:52] <grrrit-wm>	 (03PS42) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 
[19:16:05] <TrevorParscal>	 ok, I have some more things to address, but it's close
[19:16:08] <TrevorParscal>	 gotta eat lunch
[19:19:32] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814#c8 (10ryasmeen) Verified the fix in test 2
[19:25:48] <grrrit-wm>	 (03PS1) 10Jforrester: Sort i18n files alphabetically for better diffs in future [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/145622 
[19:26:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Sort i18n files alphabetically for better diffs in future [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/145622 (owner: 10Jforrester)
[19:29:01] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: "Review your changes" dialog should have a save button - 10https://bugzilla.wikimedia.org/67868#c9 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low (In reply to Ltrlg from comment #8) > (In reply to James Forrester from comment #2) > > This feels lik...
[19:32:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: PHP parser's render of {{reflist}} (and other templates) has no context, so no references appear - 10https://bugzilla.wikimedia.org/51146#c3 (10James Forrester) *** Bug 67856 has been marked as a duplicate of this bug. ***
[19:32:47] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Table cell templates are editable, but their re-rendering is broken - 10https://bugzilla.wikimedia.org/67856#c1 (10James Forrester) 5NEW>3RESO/DUP This is because we don't (can't) send context right now when asking for the template to be re-rendered – bug 511...
[19:36:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10James Forrester)...
[19:44:19] <mooeypoo>	 hrm.
[19:44:30] <mooeypoo>	 Can I test deferred methods in qunit?
[19:46:14] <mooeypoo>	 ahh asyncTest
[19:50:03] <wikibugs>	 3VisualEditor: VisualEditor: Template dialog should not display html comment in the parameter label - 10https://bugzilla.wikimedia.org/67657#c4 (10James Forrester) So… this is asking if Parsoid would consider making the 'params' block of their API give a 'normalised' version of the parameter name, possibly wit...
[19:59:18] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf13] After selecting a reference note by pressing backspace, pressing down throws error:Uncaught NotFoundError: Failed to execute 'selectNode' on 'Range': The node provided is null. - 10https://bugzilla.wikimedia.org/67755 (10James Forrester) a:3...
[20:03:58] <James_F>	 Krinkle: Any chance you could stop mucking around with the bot and instead look at Trevor's patch? :-)
[20:04:08] <Krinkle>	 I'm multi tasking
[20:04:10] <Krinkle>	 Jenkins is broken
[20:04:15] <Krinkle>	 jjb won't compile
[20:04:22] <James_F>	 Krinkle: Helpful.
[20:05:35] <Krinkle>	 https://gist.github.com/Krinkle/db81425dc783bfa9e0f0
[20:06:22] * mooeypoo mutters about async unit tests
[20:10:55] <Krinkle>	 James_F|Away: I suspect openstack changed jjb, didn't test it on mac, and now I can't work with it
[20:10:58] <Krinkle>	 I guess antoine would know
[20:14:13] <Krinkle>	 contacting #openstack
[20:15:09] <Krinkle>	 #openstack-infra rather
[20:19:54] <mooeypoo>	 Krinkle, i'm having very weird errors with my async unit tests.
[20:20:04] <Krinkle>	 mooeypoo: link?
[20:20:12] <mooeypoo>	 Krinkle, ok, let me push it to gerrit
[20:20:34] <mooeypoo>	 (grunting first! :p )
[20:22:09] <grrrit-wm>	 (03PS12) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[20:22:44] <mooeypoo>	 Krinkle, I have 7 tests, they all pass, but then I get "8. Test timed out" and "9. Expected 6 assertions, but 8 were run"
[20:23:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[20:24:02] <mooeypoo>	 Krinkle, ok, I found one problem, oops, I had the same test twice. I deleted it and I still get a redundant "Test timed out" though, even though all tests pass
[20:24:44] <grrrit-wm>	 (03PS13) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[20:25:00] <mooeypoo>	 Krinkle, ^^ just updating it without the double-test. It's giving me 'Test timed out' *after* all tests passed :\
[20:25:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[20:25:27] <Krenair>	 Hey Krinkle. Did we talk about PhantomJS + Function#bind + VE core/OOUI?
[20:27:49] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The context menu for already added category is appearing as blank in Betalabs - 10https://bugzilla.wikimedia.org/67885 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15911   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15911&acti...
[20:28:18] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] The context menu for already added category is appearing as blank in Betalabs - 10https://bugzilla.wikimedia.org/67885 (10ryasmeen)
[20:34:02] <grrrit-wm>	 (03PS14) 10Trevor Parscal: Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 
[20:35:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal)
[20:35:05] <grrrit-wm>	 (03PS15) 10Trevor Parscal: Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 
[20:35:37] <mooeypoo>	 James_F, I'll need help with this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=67749
[20:35:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal)
[20:35:54] <mooeypoo>	 James_F, it seems to me to be a jquery issue, I tried to debug it, and I'm at a dead end.
[20:37:10] <grrrit-wm>	 (03PS21) 10Trevor Parscal: Update OOjs UI v0.1.0-pre (051816c6a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 
[20:37:10] <Krinkle>	 mooeypoo: still an issue?
[20:37:27] <James_F>	 mooeypoo: Is this the same as the bug Krinkle WONTFIX'ed even though it keeps breaking things?
[20:37:42] <Krinkle>	 James_F: no, unrelated.
[20:38:04] <Krinkle>	 (she's probably not aware of that bug)
[20:38:11] <James_F>	 OK…
[20:39:33] <Krinkle>	 mooeypoo: does each asyncTest have a call to QUnit.start() somewhere?
[20:40:23] <Krinkle>	 QUnit.asyncTest('name', function (){} ) is just short for QUnit.test(name, function () {QUnit.stop(); {function} })
[20:40:42] <mooeypoo>	 wait, I'm confused
[20:40:45] <Krinkle>	 I don't see a start for all of them
[20:40:59] <Krinkle>	 it's like a callback for when that test is done and it can move on to the next test
[20:41:08] <mooeypoo>	 ohh
[20:41:11] <mooeypoo>	 I .. didn't realize there should be a start
[20:41:22] <Krinkle>	 :)
[20:41:27] <mooeypoo>	 Krinkle, all my tests are inside the async function
[20:41:33] <mooeypoo>	 so I should have 1 start... right?
[20:41:45] <Krinkle>	 every stop or asyncTest should have one start() inside it somewhere
[20:41:46] <mooeypoo>	 I read here: https://api.qunitjs.com/QUnit.asyncTest/ but they only have one test
[20:41:51] <mooeypoo>	 gotcha
[20:42:10] <mooeypoo>	 so in my case only one start, because all current assertions are inside the asyncTest
[20:42:22] <Krinkle>	 when dealing with promises, be sure to call start() from either both done() and fail(), or attach an always()
[20:42:28] <Krinkle>	 so that it doesn't time out of the promise failed
[20:42:32] <Krinkle>	 of*if
[20:43:56] <mooeypoo>	 \o/ works now
[20:44:02] <mooeypoo>	 awesome, thanks Krinkle :)
[20:44:22] <grrrit-wm>	 (03PS43) 10Trevor Parscal: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 
[20:51:41] <James_F>	 TrevorParscal: Is https://gerrit.wikimedia.org/r/#/c/139550/ (The great and terrible dialog refactor) now with all changes you want to make made?
[20:51:53] <grrrit-wm>	 (03PS14) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) 
[20:51:55] <James_F>	 TrevorParscal: And if so, have you told Krinkle you want him to re-review?
[20:52:17] <Krinkle>	 I'm not waiting for that
[20:52:25] <Krinkle>	 I've been reviewing during the day as each patch came in
[20:52:31] <James_F>	 OK.
[20:52:35] <Krinkle>	 well, only once. the before last
[20:52:42] <Krinkle>	 38..42
[20:53:43] <James_F>	 OK, in that case please review 43 with a view to merging. :-)
[20:53:57] <James_F>	 Or rather, 42..43. :-)
[20:56:55] <TrevorParscal>	 James_F: I'm not ready yet
[20:57:02] <TrevorParscal>	 i'm working on things he asked for still
[20:57:19] <James_F>	 OK.
[20:57:28] <James_F>	 Krinkle: ^^^ Belay that.
[20:57:39] <Krinkle>	 OK
[20:58:31] <Krinkle>	 TrevorParscal: Also, if you're short on time, I can continue after you leave (timezone overlap is about to run out from your end I suspect), I'd recommend writing a comment responding my points first. I can take on part of the code changes if needed. I can't however form your opinion for you :P
[20:58:46] <TrevorParscal>	 i am doing exactly that
[20:58:48] <TrevorParscal>	 point by pint
[20:58:48] <Krinkle>	 cool
[20:58:53] <TrevorParscal>	 most of your ideas are good
[20:59:08] <TrevorParscal>	 it's such a big commit, lots of moving parts, it is hard to get everything right the first time
[20:59:16] <James_F>	 Or 43rd time. :-)
[21:03:34] <Krinkle>	 :P
[21:07:10] <grrrit-wm>	 (03CR) 10Trevor Parscal: "* Widget: The show()/hide(): OK, I can sort of see why this seems bad in cases where we are literally calling toggle( true ), but in so ma" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[21:12:02] <grrrit-wm>	 (03CR) 10Trevor Parscal: "Also: "You could avoid repeating logic from a parent method (such as in TextInputMenuWidget.prototype.toggle) by using an event handler in" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[21:16:33] <TrevorParscal>	 Krinkle: i have addressed all comments
[21:17:00] <Krinkle>	 thx
[21:17:25] <Krinkle>	 I agree with your response. got nothing to add
[21:17:35] <Krinkle>	 will review code chnages since PS38 
[21:18:13] <TrevorParscal>	 basically, the only things I didn't just do as you suggested were adding hide/show methods which are wrappers for toggle (seems reasonable but we should discuss further) and having windows add themselves to the window manager (which i think we could do but i want to do in a later patch since it won't affect VE and involves some moving parts and things i want to be careful about)
[21:18:37] <TrevorParscal>	 thank you for the thoughtful review, as always
[21:20:07] <Krinkle>	 TrevorParscal: Yeah
[21:20:16] <Krinkle>	 TrevorParscal: The overrides where there's a conditional, I see those in quite a few places
[21:20:25] <Krinkle>	 where you call the parent and then immediately repeat the same conditional.
[21:20:41] <Krinkle>	 In my mind that's basically processing logic reducing the usecase in a consistent way
[21:20:55] <Krinkle>	 so that inner part should probably be a separate method and/or an event.
[21:21:27] <TrevorParscal>	 yeah, basically we are trying to only act if there's a change, one way that is more sloppy is to base the overriden functionalty on the state after calling the parent, but again it may result in re-showing or re-hiding
[21:21:38] <TrevorParscal>	 depending on how complex that is, it might be a bad thing
[21:22:22] <TrevorParscal>	 you could also have a reallyToggle() method :)
[21:22:29] <TrevorParscal>	 too bad Roan isn't listening...
[21:22:31] <TrevorParscal>	 RoanKattouw: ??
[21:22:59] <TrevorParscal>	 edsanders: reallyToggleInternal2()
[21:25:33] <edsanders>	 underscore*
[21:27:17] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806#c25 (10Ad Huikeshoven) Hi James. Thanks for the explanation. Today I learned the word "slugs". To me they are suffi...
[21:31:32] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Slugs should be more obvious to the user that they're not "really" blank lines - 10https://bugzilla.wikimedia.org/47790#c24 (10Ad Huikeshoven) On nl.wp a discussion has started to turn on VE. In the process feedback has been collected on VE. Some users commente...
[21:31:36] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: FocusableNodes (e.g. Infoboxes) are too easy to accidentally delete, especially when floated - 10https://bugzilla.wikimedia.org/55336#c7 (10Ad Huikeshoven) On nl.wp a discussion has started to turn on VE. In the process feedback has been collected on VE. Some users...
[21:40:55] <grrrit-wm>	 (03PS8) 10Zfilipin: WIP [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy)
[22:09:49] <Krinkle>	 TrevorParscal: Can you explain why this call was removed ?  https://gerrit.wikimedia.org/r/#/c/139550/38..43/src/dialogs/ProcessDialog.js
[22:09:53] <Krinkle>	 redundant?
[22:09:57] <Krinkle>	 - other.toggleFrame( true );
[22:10:16] <TrevorParscal>	 um, manual rebase mistake
[22:10:20] <Krinkle>	 TrevorParscal: btw, don't make changes
[22:10:22] <TrevorParscal>	 conflict resolution mistake
[22:10:24] <Krinkle>	 I'm sending a patch
[22:10:24] <TrevorParscal>	 i'm not
[22:10:26] <Krinkle>	 :)
[22:10:28] <TrevorParscal>	 could you reintroduce that line
[22:10:31] <Krinkle>	 OK
[22:10:32] <TrevorParscal>	 good catch
[22:10:36] <Krinkle>	 One moe
[22:10:37] <Krinkle>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/139550/38..43/src/styles/elements/ButtonedElement.less
[22:10:42] <Krinkle>	 the > 
[22:11:01] <TrevorParscal>	 yes, what happens is sometimes a button widget contains something else as well
[22:11:12] <TrevorParscal>	 like, a popup button widget, for instance
[22:11:50] <TrevorParscal>	 and if you don't use > then if there is a frameless button inside a framed button widget, the frameless button will end up looking like a mix between frameless and framed
[22:12:07] <TrevorParscal>	 I'm open to other approaches to this problem, but it's pretty strightforward
[22:12:29] <TrevorParscal>	 the actual <a> inside the button div is a peer to the popup, so > solves the problem
[22:12:57] <TrevorParscal>	 do you have any concerns about the use of this selector?
[22:18:53] <Krinkle>	 TrevorParscal: Nope
[22:18:59] <Krinkle>	 TrevorParscal: Was just wondering why it was added now
[22:19:11] <Krinkle>	 TrevorParscal: OK, so you just noticed this while working and fixed it, cool.
[22:19:16] <TrevorParscal>	 yeah, i realized the problem existed when I added the framed popup button widget
[22:19:30] <Krinkle>	 TrevorParscal: Ah, I was just about to ask, Im curious how that would fail.
[22:19:49] <Krinkle>	 TrevorParscal: So the added styles for popupwidget, I reckon that'll simplify things in ve-mw where the templatedialog currently adds these manually
[22:19:54] <Krinkle>	 (to counteract the margin collapse)
[22:20:01] <TrevorParscal>	 yes
[22:20:21] <TrevorParscal>	 margin collapse is a strange thing, but thankfully it's easy to work around
[22:20:32] <Krinkle>	 TrevorParscal: And the z-indexes for popup?
[22:20:35] <TrevorParscal>	 supposedly using inline-block and width:100% does the trick too
[22:20:38] <Krinkle>	 (that's the last thing I think)
[22:21:20] <TrevorParscal>	 yeah, well the popup is absolutely positioned, but so are icons in buttons, so if a button with an icon comes after a popup, the popup's contents will be underneeth
[22:21:29] <TrevorParscal>	 I'm not a fan of z-index, but this seemed sensible
[22:27:07] <Krinkle>	 right
[22:27:09] <grrrit-wm>	 (03CR) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:27:22] <grrrit-wm>	 (03PS44) 10Krinkle: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:34:43] <Krinkle>	 TrevorParscal: if you +1 I'll +2
[22:34:43] <James_F>	 Krinkle: Did you take down jenkins?
[22:34:47] <Krinkle>	 see ops
[22:34:52] <James_F>	 Aha,
[22:37:02] <grrrit-wm>	 (03PS6) 10Jforrester: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle)
[22:40:02] <TrevorParscal>	 Krinkle: looin
[22:40:06] <TrevorParscal>	 *lokin
[22:40:11] <TrevorParscal>	 *loooookinnnn
[22:40:26] <Krinkle>	 TrevorParscal: Hm.. checking the widgets demo just now, noticed something odd. ButtonGroupWidget keeps the buttons pressed after clicking. ButtonSelectWidget only keeps one (select vs. radio). So far so good. But the one with the arrow in it. That one is excluded in ButtonGroupWidget (doesnt' stray pressed, which is good). But in ButtonSelectWidget it does stay pressed.
[22:40:29] <Krinkle>	 Is that intentional?
[22:40:48] <TrevorParscal>	 well, yes that is correct, but maybe not a good demo
[22:40:53] <Krinkle>	 ok
[22:40:57] <TrevorParscal>	 it's actually a combination of toggle and non toggle buttons
[22:42:27] <grrrit-wm>	 (03CR) 10Trevor Parscal: [C: 031] [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:42:31] <TrevorParscal>	 lgtm
[22:43:21] <grrrit-wm>	 (03CR) 10Krinkle: "GET BACK! STAY BACK EVERYONE." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:43:31] <James_F>	 Krinkle: :-)
[22:43:36] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] "Landing..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:43:43] <James_F>	 Gosh.
[22:46:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal)
[22:48:09] <James_F>	 TrevorParscal: You updating the VE-core pull-through?
[22:48:37] <TrevorParscal>	 i have done nothing
[22:48:39] <TrevorParscal>	 but I can
[22:49:08] <TrevorParscal>	 is that a request or a "are we doing the same thing at the same time" question?
[22:50:42] <James_F>	 No, I'll do it. :-)
[22:55:38] <grrrit-wm>	 (03PS22) 10Jforrester: Update OOjs UI to v0.1.0-pre (3ba36b9a53) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal)
[22:56:21] <James_F>	 Oh, right, the build order changed.
[22:56:34] <James_F>	 Hence "M	lib/oojs-ui/oojs-ui.js		+3265, -3261"
[22:56:36] <James_F>	 I was worried.
[22:56:47] <James_F>	 Krinkle: ^^^ That should be good to go.
[23:04:31] <Krinkle>	 TrevorParscal: hm.. the oojs update in ve-core has outdated commit message though (oo.ui.ActionDialog)
[23:04:37] <Krinkle>	 may be others, can you check it out?
[23:04:57] <Krinkle>	 will do some smoke testing meanwhile
[23:07:13] <James_F>	 Krinkle: Oh, sorry, I didn't look at whether that needed adjusting.
[23:07:26] <TrevorParscal>	 ok, i got distractd, what's crackin?
[23:07:31] <TrevorParscal>	 what can I do?
[23:07:57] <James_F>	 TrevorParscal: https://gerrit.wikimedia.org/r/141089 lies about what it does due to changes to OOUI since it was written.
[23:08:13] <James_F>	 TrevorParscal: It's probably fastest for you to re-write as Krinkle reviews and merges.
[23:09:07] <TrevorParscal>	 dude, I thought I fixed that already!
[23:09:31] <TrevorParscal>	 maybe not, i did so in another change
[23:09:33] <TrevorParscal>	 let me edit
[23:10:25] <grrrit-wm>	 (03PS23) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (3ba36b9a53) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 
[23:10:35] <TrevorParscal>	 I only found a small typo
[23:11:35] * James_F nods.
[23:11:56] <James_F>	 TrevorParscal: If you're looking for something to merge, https://gerrit.wikimedia.org/r/#/c/143632/ is trivial and OOUI-related. :-)
[23:13:29] <TrevorParscal>	 lgtm
[23:22:21] <James_F>	 Thanks.
[23:49:03] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] The context menu for already added category is appearing as blank in Betalabs - 10https://bugzilla.wikimedia.org/67885#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk Goes away when debug=true is called – maybe a...