[09:27:34] 3VisualEditor: Edit links replaced with duplicate of page title - 10https://bugzilla.wikimedia.org/67943 (10Robin Green) 3NEW p:3Unprio s:3trivia a:3None After I had edited the page "Nominal income target" with VE on English Wikipedia, the page title line in my browser changed from Nominal income targ... [10:47:47] 3VisualEditor / 3Editing Tools: VisualEditor: Adding a reference cannot update fake references blocks inside templates - 10https://bugzilla.wikimedia.org/50769#c3 (10marielle.volz) So to clarify, it is a known bug that adding references will display the updated reference list when the tag is u... [11:47:17] 3VisualEditor: When using cite web, page title and access date should be filled automatically - 10https://bugzilla.wikimedia.org/56772#c2 (10Robin Green) 5RESO/DUP>3REOP This has not been implemented, as of the version in English Wikipedia. [12:37:24] (03PS1) 10Bartosz Dziewoński: Remove ext.visualEditor.editPageInit alias [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145893 [17:39:04] 3VisualEditor / 3Editing Tools: Allow to drag and move pop up windows - 10https://bugzilla.wikimedia.org/67952 (10Juan de Vojníkov) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 15928 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15928&action=edit Pop up window of a template in VisualE... [17:54:48] (03PS1) 10Esanders: Allow callers to tell the menu widget which element launched it [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 [17:54:50] (03CR) 10jenkins-bot: [V: 04-1] Allow callers to tell the menu widget which element launched it [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (owner: 10Esanders) [18:21:31] 3OOjs UI: Allow to drag and move pop up windows - 10https://bugzilla.wikimedia.org/67952 (10Alex Monk) [18:47:11] (03PS2) 10Esanders: Allow callers to tell the menu widget which element launched it [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) [20:17:17] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c9 (10Ad Huikeshoven) Adding a signature with VisualEditor can be simulated using a template: ---template code:--- {{{Sign}}} This template allows to sign using Visual... [20:47:34] (03PS1) 10Krinkle: builderloader: Omit value for boolean "disabled" attribute per HTML5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145973 [21:02:16] Krinkle: Did you get anywhere with testing the VE-core pull-through? ;-) [21:04:16] (03CR) 10Jforrester: [C: 032] "Yay for undated "safe to remove" comments. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145893 (owner: 10Bartosz Dziewoński) [21:06:28] (03Merged) 10jenkins-bot: Remove ext.visualEditor.editPageInit alias [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145893 (owner: 10Bartosz Dziewoński) [21:17:40] (03PS1) 10Krinkle: ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145981 [21:17:57] * James_F takes that as a 'no'. :-P [21:18:15] (03CR) 10Krinkle: "Went ahead and did it in Ia17f5a3e701a58537df3." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/70918 (https://bugzilla.wikimedia.org/48735) (owner: 10Robmoen) [21:18:39] (03CR) 10Krinkle: "Untested. If initiating all of animate() was good for something, let's find out and document it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145981 (owner: 10Krinkle) [21:25:07] (03PS1) 10Krinkle: OptionWidget: Simplify code by using toggleClass instead of if/else [oojs/ui] - 10https://gerrit.wikimedia.org/r/145982 [21:25:08] (03CR) 10Krinkle: Add pressed state to option widgets and use instead of initializing items (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (https://bugzilla.wikimedia.org/63502) (owner: 10Trevor Parscal) [21:27:38] (03PS1) 10Krinkle: SelectWidget: Minor coding style clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/145983 [21:27:49] (03CR) 10Krinkle: Add pressed state to option widgets and use instead of initializing items (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (https://bugzilla.wikimedia.org/63502) (owner: 10Trevor Parscal) [21:28:25] James_F: Not right now, just doing some pulp coding while watching football, music and fridaynightdinner episodes [21:29:30] Krinkle: Sounds good. :-) [21:29:42] Krinkle: Good luck to whichever team you want to win. [21:32:32] Krinkle, football football, or handegg football? [21:32:51] given today is the world cup finale [21:32:59] Football football. [21:33:05] Just checking. [21:33:12] Also, I really wanted an excuse to use "handegg". [21:33:17] I'm not interested in grown men throwing eggs around whlie beating eachothers brain out [21:33:25] hehe [21:33:33] :D [21:33:45] Although my interest in football is only marginally bigger. [21:33:56] Yeah I usually prefer basketball [21:34:02] But soccer comes next [21:34:14] I have no idea what is going on in american football [21:34:44] and baseball is boring until suddenly something happens exactly when you took a bite off your overly expensive hot dog [21:43:16] Krinkle: I'd say "greater" rather than "bigger", BTW. [21:43:37] I'm only marginally more interested in .. than .. [21:43:54] Yeah, that's also better. :-) [21:44:27] * James_F stops being as fussy. [21:44:32] (Yeah, right.) [21:44:45] Is that British for fuzzy? [21:44:46] ;-) [21:48:52] Krinkle: Watch it, you. :-) [21:48:54] Hey edsanders. [22:09:04] (03CR) 10Krinkle: "ping; status? or should we file three bugs?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [22:16:31] (03PS1) 10Krinkle: demos: Omit value for disabled attribute, use attr() instead of prop() [oojs/ui] - 10https://gerrit.wikimedia.org/r/145986 [22:16:46] (03CR) 10Krinkle: "Fixed in I52d69cdaa6." [oojs/ui] - 10https://gerrit.wikimedia.org/r/142879 (owner: 10Esanders) [22:25:34] James_F, around? [22:25:48] Yeah. [22:25:53] Krenair: How can I help? [22:26:01] (I assume you just got a similar email about https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Visualeditor-dialog-citation-insert-citation/en ) [22:26:39] Yeah, Nemo_bis pinged me. [22:27:01] I was just writing a reply to mine [22:27:21] On the citation modification dialog (if we're inserting), it looks as if this message is supposed to be used as the 'submit' button. [22:27:56] Unfortunately the variable that supposedly holds whether we're inserting or editing an existing citation is left undefined, so currently it's effectively unused. [22:35:10] * James_F nods. [22:35:17] Is that affected by Trevor's re-write? [22:35:26] I know he spent some time on the different buttons for different modes. [22:43:02] James_F, do you know if the computer+tshirt package was sent already? [22:43:35] mooeypoo: No idea. [22:43:39] Also, that reminds me. [22:43:45] I should send everyone else's shirts. :-( [22:43:48] My flight's in about a week and a half [22:43:48] * James_F is a horrible team member. [22:43:51] hah [22:43:59] well, I'll get mine, that's all that matters. [22:43:59] :P [22:46:29] :-) [22:50:42] (03CR) 10Jforrester: [C: 032] SelectWidget: Minor coding style clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/145983 (owner: 10Krinkle) [22:51:39] hmm, i wonder, would you guys be mad at me if i implemented a signature tool for VE and put it up somewhere? [22:52:37] i mean a proper one, not `surfacefragment.insertContent( blah blah ~~~~ blah blah )` [22:55:34] MatmaRex: Mad? No, but if you tell me the NSes we can just disable VE there… [22:55:55] MatmaRex: NSes for VE and NSes for ~~~~ are meant to be disjoint. [22:56:18] (03CR) 10Jforrester: [C: 04-1] "This seems to cause oo-ui-optionWidget-highlighted to get set on hover but never unset in widgets_apex.html (InlineMenuWidget tests)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/145982 (owner: 10Krinkle) [22:56:52] (03PS4) 10Jforrester: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal) [22:57:41] James_F: people stuff weird things in weird places ;) https://www.mediawiki.org/w/index.php?title=Tool_Labs/Collection_of_issues_after_Toolserver_shutdown&action=history [22:58:09] Eurgh. That list is clearly mis-placed. [22:58:17] If you're having a discussion, that's what Talk: is for… [23:01:40] well anyway, i just implemented it [23:03:11] if you ever need one… http://pastebin.com/bL4PX1e7 [23:03:52] (03CR) 10Jforrester: "@Krinkle: Please file bugs; I don't think Ed sees messages here in his workflow." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139676 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [23:04:03] i should probably put this up somewhere more persistent, i quite like it :D [23:05:01] (03PS2) 10Krinkle: OptionWidget: Simplify code by using toggleClass instead of if/else [oojs/ui] - 10https://gerrit.wikimedia.org/r/145982 [23:05:33] (03PS2) 10Krinkle: SelectWidget: Minor coding style clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/145983 [23:07:25] (03CR) 10Jforrester: [C: 032] "That'd do it, yes. :-)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/145982 (owner: 10Krinkle) [23:08:11] (03Merged) 10jenkins-bot: OptionWidget: Simplify code by using toggleClass instead of if/else [oojs/ui] - 10https://gerrit.wikimedia.org/r/145982 (owner: 10Krinkle) [23:08:24] (03Merged) 10jenkins-bot: SelectWidget: Minor coding style clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/145983 (owner: 10Krinkle) [23:21:49] James_F: also https://bugzilla.wikimedia.org/show_bug.cgi?id=51154 [23:22:38] MatmaRex: Yeah, I saw. [23:38:59] (03CR) 10Jforrester: [C: 032] demos: Omit value for disabled attribute, use attr() instead of prop() [oojs/ui] - 10https://gerrit.wikimedia.org/r/145986 (owner: 10Krinkle) [23:39:41] (03Merged) 10jenkins-bot: demos: Omit value for disabled attribute, use attr() instead of prop() [oojs/ui] - 10https://gerrit.wikimedia.org/r/145986 (owner: 10Krinkle) [23:41:50] (03CR) 10Jforrester: [C: 032] builderloader: Omit value for boolean "disabled" attribute per HTML5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145973 (owner: 10Krinkle) [23:43:20] James_F: rrrr, this makes me want to step on little chicks :-( http://cl.ly/1I3d1B2B1i1V [23:43:24] Do you know if Trevor made his ideas for the inner-selection more detailed? [23:43:26] It started with links, but applies to all annotations I guess. [23:43:28] I ran into it with [23:43:30] quite frustrating. [23:43:31] (03Merged) 10jenkins-bot: builderloader: Omit value for boolean "disabled" attribute per HTML5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145973 (owner: 10Krinkle) [23:43:32] same goes for link labels [23:43:38] yay [23:43:59] Krinkle: Yes, obviously. [23:44:05] Krinkle: That's how pre-annotation works, and always has. [23:44:15] Krinkle: We spent months talking about the way to do it. [23:44:42] Krinkle: This is exactly and faithfully following native behaviour. If you don't like, it, go back to the 1980s and complain to WordPerfect's authors who set the expectations. [23:44:55] No, this is not about pre-annotations. [23:45:12] pre-annotations have nothing to do with editing existing content. [23:45:25] They cause the bug, but they're not the justification or solution. [23:46:29] I think there is no doubt in Trevor's mind that this is not the behaviour we want. I'm also sure nobody would oppose implementing the ability to inner-select content like that s that you can select/replace/type between the markers (e.g. differnetiate between cursor before and after but before the first character, same for . [23:47:04] I'm not saying we failed or that pre-annotations are wrong. I'm saying this an unintended side-effect that could be improved a lot with an additional feature. [23:47:04] Krinkle: It's nice that you're so sure of what is and isn't pre-annotation, and isn't the behaviour we want, but I'm telling you that you're wrong. [23:47:14] No. [23:47:25] We spent months on this. [23:47:40] This, irritating as it is, is intentional. [23:48:46] Nobody "wants" this. Maybe, just maybe, some users are expecting it, but I think a superior approach is possible that is more intuitive to all users and does not confuse users with existing expectations. [23:49:24] to clarify, the superior approach I'm thinking about is not removing pre-annotations. It also would not result in extending the link or by merely typing in front of it. [23:50:35] Apple solved this problem 10 years ago [23:50:55] And yet they didn't – Pages works exactly like this. [23:51:21] Pages didn't exist 10 years ago. And they didn't apply to text annotations in Pages today either. [23:52:57] However Pages did do something separate from both of these things that we should also do: if a sentence has one bold word, double clicking the word to select it and typing over it should insert a new bold word [23:53:40] (and we do, great) [23:54:21] But just not in links at the beginning of a list item. [23:54:23] interesting [23:54:46] Links are split on whitespace, including null replacement. [23:55:09] Which is also intentionally-consistent, though perhaps it's enough of an edge case for us to deviate. [23:57:43] ; select Label, type aa; undo ->
  • Label
    • [23:57:46] That's a bug.
  • Label