[00:00:16] James_F: OK. Last thing.
  • Foo
    • ; select Foo, type Bar, inserts bold Bar. But if it is a link (even a single word label), it is replaced with plain text. Is that intentinally consistent? [00:00:44] (link instead of bold, not both) [00:01:02] Krinkle: Yeah, that's a bug. [00:01:29] Krinkle: The link -> unlink is an edge case, as I said; willing to be argued either way. [00:01:41] Krinkle: edsanders|away has particular views about how all this should work, BTW. [00:02:02] I'm curious why the link is an edge case and bold not. What is currently making it unlink? [00:02:26] which logic justifies that? I want to see it that way. [00:02:27] too [00:07:06] Krinkle: Links are split on whitespace, including null replacement. [00:08:22] Sure, but that's an observation/implementation. I'm curious why? Why would that be the case for links but not other annotations? This was explicitly changed for links I assume. I'm sure there's a logical reason, and you're saying both logics could work. I"m curious what logic applies here. [00:12:26] Oh, sorry. [00:12:53] Links (and other rich annotations, but we don't really have many obvious ones) are hard to see whether they're in effect or not. [00:13:14] So lots of editors, us included, terminate down-page auto-annotation on a word-breaking character. [00:13:28] (This is why we have UnicodeJS, amongst other reasons.) [00:14:24] Right. linktrail included [00:14:32] Typing space after bold continues bold [00:14:43] but after a link it shouldn't continue the link typicaly [00:14:51] unless you're extending the word [00:15:07] so there's what makes links special. They shouldn't extend on new word be default when typing. [00:18:41] Pages treats links as inline block annotations (similar to our inline templates/images). One cursor position for the entire link. Label can only be modified on-click via the inline inspector. Interesting. They too have lots of bugs. Just now found a funny one. Link with label "Two words" I type an "s" after the link in Pages. MacOS spell-correct suggests changing wordss into words. When I do, [00:18:41] the link is gone (both words), and "words" remains :D [00:19:07] so spell-check sees the text, but the insertion model only allows the link to be treated like a block node with attributes. [00:19:27] I'm curious whether we're subject to that with inline templates that output plain text [00:19:50] Fun. [00:20:09] Inline templates are wrapped in enough gunk that spell-check doesn't run on them, I think. [00:20:34] wrong [00:20:36] :D [00:20:49] but we handle it better than apple [00:20:51] http://i.imgur.com/VefDccg.png [00:21:37] What happens when you try to replace? [00:21:51] The text inside echo is unclickable. And when you right click, it auto select text. In this case autocorrect sees 'wordss'. But you can only right click no the last 's' (clicking on the word will select the invisible image). And then you get suggestions for 's' not 'wordss' [00:22:08] click on the last 's' ** [00:22:59] Helpful. [00:23:24] here's their link inspector btw http://i.imgur.com/8M2Yoct.pnghttp://i.imgur.com/3eAbhbY.png [00:23:32] http://i.imgur.com/8M2Yoct.png ; http://i.imgur.com/3eAbhbY.png [00:23:46] Yeah, TrevorP|Away and I were amused by how much it went the direction we did. [00:23:57] It's almost like we're all trying to solve the same problem! [00:23:59] Yeah, only recently [00:24:06] Yeah. [00:24:09] previous Pages was radically different [00:24:14] Indeed. [00:24:29] it used an office-like side bar with lots of tabs, one of which was "link" [00:24:33] not context-aware [00:24:38] BTW, if you merge Trevor's VE-core patch it will make the designs almost copies of each other. [00:24:38] ;-) [00:24:49] I saw that [00:24:53] Yeah, I loathe the "palette" concept. [00:24:55] I'm liking it [00:25:08] Hm.. what's that? [00:25:24] (nice trick into having me check out that branch again) [00:25:25] It's what Apple uses when they can't think of a good UI model. [00:25:32] * James_F laughs. [00:25:53] Krinkle: https://en.wikipedia.org/wiki/Palette_window [00:26:02] Krinkle: See everything Adobe ever made. [00:26:14] Hm.. I'd say Apple did do it better [00:26:28] you couldn't accidentally close them or get the all over the place [00:27:01] http://i.stack.imgur.com/HAZ8a.png [00:27:18] basically one big pallete with tabs for each type of 'thing' [00:27:42] including image shadows, table rows, document layout [00:27:42] Yeah, TBF Apple made the least-bad palette. [00:27:55] just everything and anything :P [00:27:57] But its context-blindness is irritating. [00:28:01] yeah [00:28:02] Exactly. [00:28:11] it could've hidden some that can't apply to the current element [00:28:45] Ours is gonna be better than both the old Pages and the current pages, since ours is context bound, but can have multiple entries (the context menu that is) [00:28:53] which is like the top row of that pallete [00:29:22] (03PS5) 10Jforrester: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal) [00:29:28] And to be fair, Adobe is moving away from it as well [00:30:01] From CS4 and up they default to sticky palette windows that stick to one enother (essentially forming a segmented vertical sidebar) [00:30:02] (03CR) 10Jforrester: [C: 032] "PS5 rebases onto I52d69cda and applies the same logic to the new dialogs_agora.html." [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal) [00:30:07] you can still close some or detach them if you like. [00:30:29] That's not new in CS4, I think. [00:30:30] But yes. [00:30:36] and also make them sticky to not overlap the document (e.g. the scrollback so to the left of the sidebar, not to the right) [00:30:47] that was my #1 annoyance, they overlapped the document [00:30:57] (03Merged) 10jenkins-bot: Split dialog demos by theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/145436 (owner: 10Trevor Parscal) [00:31:01] Yeah. [00:31:05] so you tend to make the window narrower, but that's annoying to "maintain" [00:31:59] And wastes so much space. [00:32:45] yeah, and because they're OS-level modal, they used to have full fledged title bars and close buttons [00:32:49] 3OOjs UI: OOjs UI: InlineMenuWidget doesn't handle mouse events properly - 10https://bugzilla.wikimedia.org/67821 (10James Forrester) a:5Trevor Parscal>3Ed Sanders [00:33:02] at least OSes these days support sub windows that are more minimalistic [00:34:16] (03PS17) 10Krinkle: Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [00:34:43] I'm not sure that's better. [00:34:51] Seems to add to potential user confusion. [00:35:32] I mean windows like these [00:35:35] http://i.imgur.com/vh0HYcE.png [00:35:51] separately moveable but with smaller controls [00:35:55] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to ddfe72a5149b08270595e931d574f73e1055839f [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [00:36:02] Oh, right, yeah. [00:36:03] and not show up in the dock or Expose [00:36:04] Hmm. [00:36:39] OK, found a bug. [00:36:52] (03CR) 10Krinkle: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [00:37:34] Krinkle: It's a sub-module pull-through for an unmerged commit; it will always fail. [00:37:52] ? [00:37:59] oh wrong commit [00:38:01] I meant ve/ve [00:38:19] (03PS24) 10Krinkle: Update OOjs UI to v0.1.0-pre (3ba36b9a53) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [00:38:50] I was skipping this one because it's named OOjs UI, and Im looking for VE. [00:38:50] :P [00:39:18] Krinkle: So I've found one minor bug in 141089; otherwise it looks good to go from my POV. [00:40:21] so the inspector style thing you mentioned, they don't look quite right [00:40:23] (03CR) 10Jforrester: [C: 04-1] "Have tested. Everything works except on minor issue:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [00:40:29] buttons have no border or hover background [00:40:39] Krinkle: That's intentional design. [00:40:57] Krinkle: Maybe we should try to bring you into the weekly design meetings? [00:41:15] Design that needs justification to not look broken has a problem. [00:41:17] I refuse. [00:41:28] http://i.imgur.com/RZQAPSj.png [00:41:35] I think that's not on purpose [00:41:41] Which bit? [00:41:47] I like the new buttons that have no border and highlight on hover [00:41:59] but in this shot the remove/open is neither bordered nor shaded. [00:42:22] makes me think a style isn't loaded properly [00:42:25] none of the demos look like that [00:42:59] so it's either a non-standard button style invented for this one dialog, or something was not different than intended. [00:43:21] Krinkle: Not true. [00:43:29] Krinkle: Try "broken dialog (error handling)". [00:43:50] Krinkle: This is part of the design, having very low styling for low-key buttons. [00:44:00] Look at message dialog for comparison [00:44:01] s/low styling/muted styling/ [00:44:04] or every other button anywhere [00:44:12] Yes, primary function buttons have hover and/or border. [00:44:17] And low-priority ones don't. [00:44:18] It should at least have some kind of indication the user focussed/hovered it. that's just common sense. [00:45:01] * James_F shrugs. [00:48:16] eww. VE is going Agora? [00:48:50] MatmaRex: We're continuing to converge front-end design [00:49:16] MatmaRex: Exactly what label we use, and what relation it bears to previous un-executed design concepts, remains to be seen. [00:50:52] Krinkle: BTW, I really love your screenshots from your Retina book reminding me every time, given they're 2x the resolution. :-) [00:51:02] hehe [00:51:26] * James_F grumbles about being on peasant-resolution. [01:08:34] James_F: I've mailed Trevor my concerns about the link inspector buttons. [01:08:58] nn [01:09:09] Krinkle: Good night! [01:42:18] Krinkle: Back again? :-) [01:43:17] Yeah, Trevor replied. You were mistaken. [01:43:19] And I could've known. [01:43:21] https://gerrit.wikimedia.org/r/#/c/139550/41..42/src/dialogs/ProcessDialog.js [01:43:25] That line was accidentally removed in a rebase. I pointed it out to Trevor, but then we forgot about it [01:43:27] framed(true) [01:47:35] (03PS1) 10Krinkle: ProcessDialog: "Other" action buttons should be framed. [oojs/ui] - 10https://gerrit.wikimedia.org/r/146006 [01:53:07] Krinkle: He said otherwise when I asked him in person. :-) [01:53:44] Google Docs/Drive plugins in javascript for those using Google Apps for Business [01:53:45] http://www.google.com/script/start/ [01:53:45] But happy we've agreed that that's the fix. [01:53:53] https://developers.google.com/apps-script/ http://www.google.com/enterprise/apps/business/products.html#more [01:53:54] interesting [01:53:57] (03CR) 10Jforrester: [C: 032] ProcessDialog: "Other" action buttons should be framed. [oojs/ui] - 10https://gerrit.wikimedia.org/r/146006 (owner: 10Krinkle) [01:54:27] Krinkle: Interesting indeed. [01:54:37] (03Merged) 10jenkins-bot: ProcessDialog: "Other" action buttons should be framed. [oojs/ui] - 10https://gerrit.wikimedia.org/r/146006 (owner: 10Krinkle) [01:55:43] Also covers Google Docs and Spreadsheets. Including example plugins. And of course the editing of these .gs scripts goes through a modified Google Docs app itself (which syntax highlighting) [01:56:35] * James_F nods. [01:57:05] * Krinkle saves http://i.imgur.com/pug4SRw.png as reminder for what CodeEditor might be like one day :) [01:57:18] when integrated with VE [01:57:29] Krinkle: Ha. Maybe. [01:57:39] Krinkle: The commit's sitting around for you to improve… ;-) [01:59:03] Krinkle: But if we want to show off we should build Atom into VE. :-) [01:59:12] yeah [01:59:56] Krinkle: So… do you want to do a (messy) update to the OOUI pull-through to VE-core, or merge as is and pull in the fix in an immediate follow-up? [02:02:27] * James_F heads off. [02:04:02] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c10 (10Bartosz Dziewoński) Whoa, that's scary. Please don't do that. I wrote a script to implement signatures properly. This definitely isn't what the editor was designed to do, b... [02:04:37] James_F|Away: ^ [02:04:52] i wonder if the bug should be WONTFIXed? [02:07:28] (03PS25) 10Krinkle: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [04:16:32] 3VisualEditor: VisualEditor: Using forward-delete key on a PC causes odd cursor placement - 10https://bugzilla.wikimedia.org/58221#c3 (10Tilman Bayer) Another example: In https://en.wikipedia.org/w/index.php?oldid=616866203&veaction=edit , place the cursor left of "F" in the word "Former" in the first paragr... [08:47:47] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c11 (10Ad Huikeshoven) (In reply to SJ from comment #3) > I think it is important to enable signatures in VE. I have found it useful > in a few circumstances; and regretted having... [08:55:26] (03PS1) 10Vikassy: [BrowserTest] Updating all gems in Gemfile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146039 [09:22:22] (03PS9) 10Vikassy: WIP [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable and Gems updated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) [09:30:34] (03Abandoned) 10Zfilipin: [BrowserTest] Updating all gems in Gemfile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146039 (owner: 10Vikassy) [09:41:19] (03PS15) 10Vikassy: WIP [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [09:41:34] (03CR) 10jenkins-bot: [V: 04-1] WIP [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (owner: 10Vikassy) [09:51:55] (03PS16) 10Vikassy: WIP [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [09:54:07] (03PS10) 10Vikassy: [BrowserTest] Language Screenshot Upload to handle absolute path for LANGUAGE_SCREENSHOT_PATH variable and updated gems [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) [09:55:35] (03PS11) 10Zfilipin: [BrowserTest] Fixed language screenshot upload script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [09:58:21] (03PS12) 10Zfilipin: [BrowserTest] Fixed language screenshot upload script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [09:58:51] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fixed language screenshot upload script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [10:00:33] (03Merged) 10jenkins-bot: [BrowserTest] Fixed language screenshot upload script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145271 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [10:04:17] 3OOjs UI: Allow to drag and move pop up windows - 10https://bugzilla.wikimedia.org/67952#c1 (10Andre Klapper) Who is "we" here? [11:55:47] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c12 (10Bartosz Dziewoński) I replied at [[meta:User talk:Matma Rex/visualeditor-signature.js]]. [11:57:47] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c13 (10Bartosz Dziewoński) I wonder what should we do with this bug? I think it should be marked either RESOLVED WONTFIX or RESOLVED FIXED, but I'm not sure which is more appropria... [12:39:50] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after inline alien - 10https://bugzilla.wikimedia.org/67985 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None From bug 58221: Tilman Bayer 2014-07-14 04:16:20 UTC Another example: In https://en.wikipedia.org/w/index.php?oldid=... [12:40:47] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after inline alien - 10https://bugzilla.wikimedia.org/67985#c1 (10Ed Sanders) Anywhere we do logical cursoring you get off by two errors, e.g. delete/backspace/arrow keys (after clicking) [12:41:49] 3VisualEditor: VisualEditor: Using forward-delete key on a PC causes odd cursor placement - 10https://bugzilla.wikimedia.org/58221#c4 (10Ed Sanders) 5NEW>3RESO/FIX The original issue(s) appear(s) to be fixed. The issue spotted by Tilman has been filed as bug 67985. [12:51:12] hi [12:51:26] do you know you cannot add special character into the gallery? [12:52:40] in fackt you cannot change wikitext in galeery, you see the wikitext, but you dont have WYSIWYG tools to change it [12:53:35] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after about-grouped inline alien - 10https://bugzilla.wikimedia.org/67985#c2 (10Ed Sanders) The problem here appears to be the IPA template which returns two s which are about-grouped (about="#mwtX"). I imagine the cursoring logi... [13:36:18] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c14 (10Lokal_Profil) Being a basic building block of a wiki which is currently missing from VE I would not mark this as Resolved until there is a solution integrated in VE. Better... [14:04:04] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialogs panes should include a link to the template's definition page (for further documentation) - 10https://bugzilla.wikimedia.org/49772#c6 (10Elitre) 5RESO/WOR>3REOP This is being asked at ru.wp even for templates which have TemplateData info;... [14:05:21] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986 (10Nnvu) 3UNCO p:3Unprio s:3normal a:3None In itwiki, we've noticed that when including [it.wikipedia.org/wiki/Template:A] in a page using VE doesn't show all required parameters, but just one. In fact,... [14:08:18] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986 (10Nnvu) [15:37:39] (03PS1) 10Esanders: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146079 (https://bugzilla.wikimedia.org/67985) [15:37:58] James_F, that bug is pretty serious ^^^ [15:38:03] edsanders: Yeah. :-( [15:38:25] edsanders: I was thinking of an emergency deploy this afternoon. [15:38:46] breaks one of the highest traffic pages of the last 24h ( https://en.wikipedia.org/wiki/Mario_G%C3%B6tze ) [15:38:54] Yeah. [15:38:56] * James_F sighs. [15:39:19] Who should review? CE-Document is normally RoanKattouw or divec, but maybe Trevor? [15:41:26] Trevor and Dave if possible [15:41:31] Kk. [15:51:02] is there an option to remove the saving dialog and simply save the edit? [15:57:55] (03PS11) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [15:58:37] nick____: No. Do you mean a user option or a software development option? [15:59:52] user option [16:00:59] nick____: For WMF wikis, we wouldn't create such an option. [16:01:26] nick____: It would stop you from putting in an edit summary, which you are meant to do on every edit. [16:01:30] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [16:01:55] agh I understand. It doesn't really matter [16:02:11] nick____: KO. [16:02:14] Err. OK. [16:51:52] James_F: hi [16:51:55] you can chat with me here... [16:51:59] link me again? [16:52:52] Ha. [16:52:53] Sure. [16:53:05] The urgent review is https://gerrit.wikimedia.org/r/146079 [16:53:33] The -1 from me was on https://gerrit.wikimedia.org/r/#/c/141089/ about focus being lost when you return from a ProcessDialog (or, at least, from the CommandHelp one). [16:57:13] (03PS26) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [16:59:56] (03PS27) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [17:02:45] (03PS18) 10Trevor Parscal: Update VE core submodule to e53bfc0a2cd3ef3722603456424ca8c4741e1606 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [17:03:28] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to e53bfc0a2cd3ef3722603456424ca8c4741e1606 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [17:04:30] (03CR) 10Trevor Parscal: [C: 032] Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146079 (https://bugzilla.wikimedia.org/67985) (owner: 10Esanders) [17:05:51] (03Merged) 10jenkins-bot: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146079 (https://bugzilla.wikimedia.org/67985) (owner: 10Esanders) [17:07:33] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialogs panes should include a link to the template's definition page (for further documentation) - 10https://bugzilla.wikimedia.org/49772#c7 (10Elitre) If this wasn't clear enough, the user asks for a link to the template /documentation/ page. Here'... [17:07:46] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986#c1 (10Elitre) 5UNCO>3NEW Possibly a dupe of bug 50747, but still: if a parameter is mandatory, I need to 1) know it is, 2) know I need to add it or the template will be broken. I don't understand why we 1)... [17:09:56] (03CR) 10Krinkle: [C: 04-1] "Needs focus restore and/or something James said. There's one commit that will need to be updated if we amend this again, but that one will" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [17:11:21] (03PS2) 10Krinkle: ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145981 [17:17:01] (03CR) 10Krinkle: [C: 032] Allow callers to tell the menu widget which element launched it [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:17:16] (03CR) 10jenkins-bot: [V: 04-1] Allow callers to tell the menu widget which element launched it [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:31:35] edsanders: Hm.. the menu tools in the VE standalone toolbar do close properly. [17:31:35] (03PS1) 10Jforrester: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146137 (https://bugzilla.wikimedia.org/67985) [17:31:41] Krenair: ok, i have a patch for the VE core pull through [17:31:50] Krinkle: sorry, I meant that for you... [17:31:55] (03PS1) 10Jforrester: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146138 (https://bugzilla.wikimedia.org/67985) [17:31:57] I will just include it... [17:32:20] edsanders: ^^^ Could you merge those two so I can do pull-throughs? [17:33:16] (03PS3) 10Krinkle: MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:33:18] (03PS28) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [17:33:21] (03PS4) 10Krinkle: MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:33:26] (03CR) 10Krinkle: MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:33:29] (03CR) 10Krinkle: [C: 032] MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:33:31] (03CR) 10jenkins-bot: [V: 04-1] MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:33:51] (03PS29) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [17:34:45] Labs is having DNS issues. [17:34:47] (03PS19) 10Trevor Parscal: Update VE core submodule to b141a7d23fc47938030cb6a742db51229770025e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [17:35:00] Helpful. [17:35:23] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to b141a7d23fc47938030cb6a742db51229770025e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [17:35:56] James_F: ok, we should be good, I caught a mistake, where ve.ui.Surface was binding to the "teardown" even on what is now a window manager, but such a method does not exist [17:35:56] Krinkle, they use PopupToolGroup [17:36:01] this is InlineMenuWidget [17:36:17] it's used in the demo for the page selector (Alien, Rtl... ) [17:36:47] I moved the selection assertion to the same handler in ve.ui.Surface so it works for all (not just fragment) dialogs and corrected the handler to use the closing promise progress mechanism [17:36:53] i'm heading in [17:37:13] TrevorParscal: Ah, cool. [17:37:16] (03Merged) 10jenkins-bot: MenuWidget: Add option to specify an extra widget for mouse events [oojs/ui] - 10https://gerrit.wikimedia.org/r/145903 (https://bugzilla.wikimedia.org/67821) (owner: 10Esanders) [17:39:27] (03CR) 10Jforrester: [C: 031] "Looking good." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [17:39:46] James_F: did you know Gerrit search "label:" also supports filtering who that score was left by (as opposed to reviewer: which is indepedent) [17:39:48] https://gerrit.wikimedia.org/r/#/q/label:Verified%253D-1%252Cjenkins-bot,n,z [17:40:03] Just found out [17:40:25] Krinkle: Oh, useful! [17:41:39] Krinkle: https://gerrit.wikimedia.org/r/#/q/label:Verified%253D-1%252Cjenkins-bot+label:Code-Review%253D%252B2,n,z [17:44:32] Good, so nothing left from today. [18:12:50] James_F, ok, the bug that Sherry sent me is again about the media dialog, so I'm waiting for Trevor's huge fix to be merged. Meanwhile, I was trying to find more templatedata bugs, but most of those that were left seem to be either strategic things we should decide upon first, or related to the VE-end of templatedata. [18:13:45] James_F, for example, there's something about adding a 'default value' to templates, or another about allowing for ENUM values for templatedata. I can work on those... [18:13:53] not sure what the decision is about them, though. [18:15:05] mooeypoo: Sounds good. I think VE-end might make the most sense. [18:15:17] mooeypoo: Yeah, good question. [18:15:54] I can try to add either of those to both the templatedata editor and VE-end but which, and do we know how we want them to be like? [18:16:06] Will 'default' value appear automatically when you add the field? [18:16:15] Default value is already done. [18:16:17] oh [18:16:31] What's not done is the suggestion for clients to auto-set a value. [18:16:42] isn't that the default? [18:16:46] E.g. a template with a date parameter that defaults to {{TODAY}} (or whatever). [18:16:59] No the default is "What does the template assume if you give it no parameter". [18:17:05] What's the difference between that and default? [18:17:09] oh [18:17:11] hm [18:17:21] Auto-value vs. default? [18:17:26] We need some names or something. [18:17:35] hmm... what should the behavior in that case should be like, then? The auto value will have the default value in it? [18:17:36] I'm confused. [18:18:08] (03CR) 10Jforrester: [C: 032] "Let's get this done." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [18:18:43] mooeypoo: Right now, if you have a default value for a parameter, it shows as a placeholder. [18:18:53] mooeypoo: Which is exactly the correct UX for how to use placeholders. [18:18:56] * mooeypoo nods [18:19:24] mooeypoo: I think the best thing for auto-value would be to set the actual value (not a placeholder) for a given parameter. [18:19:46] mooeypoo: But only on insert of the parameter (including initial insert of the template if it's recommended). [18:20:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (d2451ac748) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [18:20:34] I'm not sure I understand the bottom line difference, though. IF I have a parameter X which has default value Y, then if X is included in the template, it will automatically have Y even if I don't put anything *in* the box (so, use the placeholder) right? [18:20:44] what's the difference would be between having the default in placeholder or not? [18:21:02] Except for the user seeing it written in the box vs. being a placeholder [18:21:08] One of them is set, the other can change. [18:22:19] (03PS20) 10Jforrester: Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:22:38] They can both change, though...no? You override a placeholder.. you rewrite a value. I'm confused. [18:22:47] (03CR) 10Jforrester: "PS20 is a rebase onto master." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:22:50] No. [18:23:06] Say I have a template called foo, which takes two parameters bar and baz. [18:23:20] Bar has a default value of Hello! [18:23:26] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [18:23:28] Baz has an auto-value of Goodbye! [18:23:55] Can you change Baz ? [18:24:08] So if I insert the template Foo with no parameters, the template will act as if I did set bar to the value "Hello!". [18:24:17] But it will have no value for Baz. [18:24:42] Ahh [18:24:47] So {{Foo}} == {{Foo|Bar=Hello!}}. [18:25:08] The auto-value relies on VE filling in the value. [18:25:50] Okay [18:28:18] That was default value, though... so.. I can change it if I add that parameter. It will appear in VE with a placeholder which I can change. [18:28:41] No. [18:28:46] James_F, so if I understand correctly, an auto-value parameter you can't change its value, only whether it appears or not? [18:28:52] Default value appears with a placeholder than you can over-write. [18:28:57] Can't I do {{Foo|Bar=Yo!}} [18:29:09] Auto-value appears with a value you can change. [18:29:21] This is probably too complicated to explain to users easily. [18:29:47] You can do {{Foo|Bar=Yo!}}, yes. [18:29:55] O.O I understand the UX difference, but I don't see an actual difference. IF you can change both, what's the difference between setting one parameter as having "default" and another as having "auto value" ? [18:30:24] If I later come along and change the template so that the default for Bar is "Heya!" your invocation will change. [18:30:28] Can I do {{Foo|Bar=Yo!|Baz=Something else}} ? [18:30:36] But the auto-value for Baz is stuck in the value you asked for. [18:30:43] ohhh [18:30:46] This is mostly for today's date. [18:30:51] oh, oh oh ok [18:30:54] I get it now. [18:31:02] So {{citation needed|date={{{TODAY}}}}} [18:31:12] But I don't know if we can sanely explain this to users. [18:31:24] so yeah, references to some other templates.. one is to have that reference to the template, and the other is to have this moment's rendering of that template. [18:31:34] Krinkle: you have a moment? [18:32:00] I was hoping you could help me look at how slow opening a link inspector the first time is [18:32:02] TrevorParscal: If it's not blocking a merge, it'll have to wait. Fixing zuul/labs issues atm [18:32:08] no worries [18:32:15] when you have time [18:32:17] Ping me in 30 min or so [18:32:19] I just want help profiling it [18:32:42] I believe it has to do with copying the CSS to the child frame, but I know you could help - I will hit you up in a bit [18:35:40] (03PS15) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) [18:39:22] btw, Krinkle my TemplateData editor tests pass now, but when I tried to add qunit tests to the Gruntfile, it fails with "PhantomJS timed out, possibly due to a missing QUnit start() call." -- but I have a start() call (otherwise the tests inside mw would've failed) -- is this because I can't run PhantonJS tests using MW from outside MW ? [18:41:02] Look at me, all grunt up. [18:41:58] Krenair: BTW, look what Trevor did to your lovely save dialog code! ;-) https://gerrit.wikimedia.org/r/#/c/144866/20/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js [18:43:27] edsanders: Could you please merge https://gerrit.wikimedia.org/r/#/c/146137/ and https://gerrit.wikimedia.org/r/#/c/146138/ so I can prep them for release? [18:44:00] (03CR) 10Esanders: [C: 032] Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146137 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:44:05] (03CR) 10Esanders: [C: 032] Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146138 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:44:07] edsanders: Thanks. [18:45:27] (03Merged) 10jenkins-bot: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146137 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:45:40] (03Merged) 10jenkins-bot: Prevent double counting of DM nodes in getNodeAndOffset [VisualEditor/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146138 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:46:41] (03PS1) 10Jforrester: Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146159 (https://bugzilla.wikimedia.org/67985) [18:47:54] (03PS1) 10Jforrester: Update VE core submodule to cfdb3a54 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146161 (https://bugzilla.wikimedia.org/67985) [18:49:30] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146159 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:50:29] Eurgh, it's not wmf12 compatible. :-( [18:51:01] edsanders: Thoughts? [18:51:52] what failed? [18:51:56] TypeError: 'undefined' is not a function (evaluating 've.init.platform.isInternetExplorer()') [18:52:09] I'll backport that. [18:53:22] what's that got to do with my code> [18:53:29] ? [18:53:52] edsanders: Good question. [18:55:45] Does 146159 just cherry pick my change, or does it pull it others? [18:55:59] Just your change. [18:58:09] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146159 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:58:22] Ha. [18:58:24] I'm an idiot. [18:58:38] (03Abandoned) 10Jforrester: Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146159 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:58:43] (03Abandoned) 10Jforrester: Update VE core submodule to cfdb3a54 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146161 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [18:58:51] Wrong branches. [18:58:52] * James_F sighs. [18:58:56] Let's try that again. [19:00:56] (03PS1) 10Jforrester: Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146165 (https://bugzilla.wikimedia.org/67985) [19:04:57] (03PS1) 10Jforrester: Update VE core submodule to cfdb3a54 [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146166 (https://bugzilla.wikimedia.org/67985) [19:06:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to cfdb3a54 [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146166 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [19:08:20] 3VisualEditor: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Based on feedback and test by French Wikipedians, which we always thank. An editor reported getting a snowman here https://fr.wi... [19:10:02] 3VisualEditor / 3Editing Tools: VisualEditor: PHP parser's render of {{reflist}} (and other templates) has no context, so no references appear - 10https://bugzilla.wikimedia.org/51146#c4 (10James Forrester) (In reply to James Forrester from comment #2) > This will be fixed when we switch over to Parsoid rend... [19:10:48] (03PS21) 10Jforrester: Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [19:11:58] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [19:12:17] 3VisualEditor / 3Editing Tools: VisualEditor: Parsoid's render of {{reflist}} has no context, so no references appear; similarly, edited templates inside structures, look odd on edit - 10https://bugzilla.wikimedia.org/51146 (10James Forrester) [19:17:56] (03PS22) 10Jforrester: Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [19:19:03] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [19:31:48] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762#c15 (10Alex Monk) 5PATC>3ASSI (In reply to Krinkle from comment #14) > VisualEditor core, and OOjs UI. Me and Krinkle spoke about this and think it would be a better idea to def... [19:33:07] TrevorParscal: ping [20:37:49] does anyone else see bugs on this page? https://en.wikipedia.org/w/index.php?title=Foltin&veaction=edit [20:38:34] the cursor is jumping around [20:38:59] I don't see issues with cursor on other pages [20:41:36] kaity: Yeah, it's a really bad issue caused by the language template. [20:41:43] kaity: We're rushing out a fix at 16:00. [20:42:57] James_F: oh ok! [20:43:17] kaity: Sorry. :-( [20:44:03] James_F: glad it was found :) [20:44:40] James_F: Do you want to meet for the KIT today? [20:45:18] kaity: I don't have a great deal to say but Mobile might, so we should probably keep it. [20:45:37] James_F: ok sounds good [20:46:13] James_F, btw, unrelated, but I thought about this during the weekend -- I started using sass for my grad project, and that made me wonder... why aren't we using that? [20:46:19] It's friggin magical. [20:46:50] mooeypoo: Because we opted for LESS a year or so ago. [20:47:07] mooeypoo: We use LESS in OOUI for example. [20:47:09] oh, oh I see. [20:47:15] mooeypoo: Though right now there's been no LESSification of VE itself. [20:47:55] right, I was looking more at VE itself, we have a lot of css files, so combining them (and using some preprocessing method) sounded quite useful [20:47:58] but I didn't get into LESS [20:50:32] Krinkle: You spending any time reviewing https://gerrit.wikimedia.org/r/144866 (the VE-MW pull-through)? [20:50:43] Not yet [20:52:00] Krinkle: Still stopping jenkins from falling over/ [20:52:51] oh wow, I just remembered I have homework [20:52:54] * mooeypoo facedesks [20:53:31] (03PS16) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) [20:54:29] mooeypoo: :-D [20:54:51] James_F, I'm all in "graduating soon!" mode [20:55:00] * James_F laughs. [20:55:22] oh, btw, James_F uhm, who can I check about the laptop+tshirt package? I want to make sure it's sent so I get it before I fly in a week and a half [20:55:58] mooeypoo: Do you have an auto-e-mail from OIT? Respond on that? [20:56:08] oh, good point. [20:56:22] So many people on that email, I wasn't sure who to ask, but I guess answering the email itself would do [21:01:17] (03PS23) 10Jforrester: Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:02:28] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (b141a7d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:23:32] (03PS1) 10Trevor Parscal: Update reference to ConfirmationDialog to use MessageDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146272 [21:29:04] (03PS24) 10Trevor Parscal: Update VE core submodule to master (c5b3921c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [21:30:02] (03CR) 10Jforrester: [C: 032] Update reference to ConfirmationDialog to use MessageDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146272 (owner: 10Trevor Parscal) [21:30:09] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (c5b3921c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:31:25] (03Merged) 10jenkins-bot: Update reference to ConfirmationDialog to use MessageDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146272 (owner: 10Trevor Parscal) [21:33:17] James_F: Jenkins should be fine now [21:34:33] Krinkle: Cool. Can you review Trevor's thing now? [21:34:45] * James_F is just about to push a working version. [21:34:54] (03PS25) 10Jforrester: Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:35:12] Krinkle: https://gerrit.wikimedia.org/r/144866 combined with https://gerrit.wikimedia.org/r/#/c/146120/ as the MW-core OOUI pull-through. [21:36:11] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:42:30] James_F: k [21:43:27] 21:35:44 Error: constructor must be a function, cannot be a undefined Error: constructor must be a function, cannot be a undefined [21:43:35] 21:35:44 Exception thrown by ext.visualEditor.core [21:43:38] Yeah, fixing. [21:44:39] (03CR) 10Krinkle: [C: 04-1] "Files are most likely listed/loaded in the wrong order causing the class inheritance to fail fatally during initialisation because its ref" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:44:59] (03CR) 10Krinkle: "Exception thrown by ext.visualEditor.core: Error: constructor must be a function, cannot be a undefined" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [21:45:36] Running the code on a page or on Special:JavaScriptTest and having chrome pause on exceptions should bring you right to the missing class in question. [21:46:00] Let me know if you want me to get on it, otherwise after it's fixed. I'll continue here for a bit. [21:46:42] ve-tech@wikimedia.org bounced for me yesterday [21:47:45] Or did some of you receive 'Add-ons for Google Docs' ? [21:48:09] 550 Address ve-tech@wikimedia.org does not exist [21:48:21] Krinkle: It's editing-team@. [21:48:32] Krinkle: Read your email from 2 July. :-) [21:48:55] last mail to ve-tech was June 16 [21:49:00] 19 [21:49:32] I haven't recieved anything like that on July 2 on other inboxes either [21:50:01] alias or list? [21:50:04] (new one) [21:52:28] List. [21:53:34] Krinkle: Wait, no. [21:53:39] James_F: A list on wikimedia.org? [21:53:42] lists.wikimedia.org [21:53:43] Krinkle: Are you still getting the error? [21:53:47] I'm not [21:53:50] Krinkle: No, it's a Google list still. [21:53:56] Krinkle: It just changed name. [21:53:57] Right, "list" [21:54:00] k [21:54:12] Anyway, AFAICT the tests all pass now. [21:54:50] Krinkle: Remember that https://gerrit.wikimedia.org/r/144866 depends on https://gerrit.wikimedia.org/r/#/c/146120/ obviously. [21:55:43] James_F: I have another question about media settings dialog (of course!) [21:55:48] kaity: Sure. ;-) [21:56:11] James_F: Can we automatically pull the description from commons for the caption? [21:56:33] kaity: No, we're waiting for the Multimedia team's work on structured data to be able to do that. :-( [21:56:54] James_F: Oh ok [21:57:08] That will be in the works for awhile right? [21:57:54] kaity: Yeah, sadly. [21:58:34] James_F: Is it not technically possible or just a route we don't want to go down until we have better structure? [21:59:05] kaity: Not technically possible to do well. A horrible hack is possible, but would only work for a few languages and break for most users. [22:00:34] (03PS12) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [22:00:37] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:01:22] James_F: right [22:02:09] Krinkle: We could merge 146120 now and have VE-MW be broken until you merge it, but… [22:02:11] well, it depends in both ways. mw-core will have to be merged first but won't do that until I test the ve one with mw-core local checkout of that change [22:02:27] Yeah. [22:02:28] Yay for breaking changes. [22:03:25] We should really try next time to at least have 1 commit in between that supports the old interface. [22:03:29] This does not scale. [22:03:51] I had jquery.cookie (a much simpler plugin) make an extra release as well [22:04:12] backlogged to the old .x branch so taht we can upgrade to that first, then fix callers everywhere, and then upgrade to the new one [22:04:20] (03PS1) 10Trevor Parscal: [WIP] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 [22:04:38] Krinkle: But OOUI is pre-release precisely to avoid this. [22:04:56] Sure, I did that in a way. [22:04:59] But that doesnt' fly anymore [22:05:09] Krinkle: Needing to having hundreds or thousands of lines of code for backwards-compatibility (especially when we don't actually want it) is really slow. [22:05:16] It's either that or tell nobody but us to use oojs ui or ve in production [22:05:33] Or we fix the breakages ourselves. [22:05:37] Which is what we're doing. [22:05:41] Per your command. [22:05:48] You don't get both. :-) [22:05:59] community plugins, and other wmf extensions absolutely must be able work at all times (In that, they should at least have 1 day to migrate ahead to the new signature before we remove the old) [22:06:33] Krinkle: Can we stop talking about development theory and start reviewing code so people have more time to migrate? [22:06:42] (03CR) 10Trevor Parscal: "Actually, I think it was somehow based on the wrong VE core commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [22:06:54] I'm just saying, it appears we are advocating community to create plugins, and other extensions are using oojs ui. [22:07:44] I think we'll be close to an initial "release" of OOUI later in the year. [22:07:57] same for VE's API as well I reckon [22:08:09] There is no VE API. [22:08:16] We are now officially unable to deploy this refactor without breaking the plugins wikis have written. They can't migrate now, they'll have wait until after it is broken. [22:08:17] We explicitly say that things will break. [22:08:36] :) [22:09:18] But yeah, I'll reach out to a couple of people and mention the forthcoming breakage. [22:09:58] .. and that the only way to avoid readers/all users from having a fatally broken editor is to disable all your ve plugins before the deployment, and re-enable them after they've been fixed. [22:16:32] TrevorParscal: Reviewing ve-mw commit now [22:17:22] TrevorParscal: Is it intentional that the buttons are a bit slimmer? They used to have more or less equal padding top/bottom left/right (well one one tend to be more than the other, but visually it looks balanced). I see they now only have flesh on the sides, not top/bottom. [22:18:05] in the oojs-ui demos this doesn't appear to be the case (either because the font is bigger, or because the labels are shorter there) [22:18:08] Just checking [22:18:43] framed { padding: 0.2em 0.8em; } [22:18:48] right, OK. That's quite explicit. [22:18:54] * James_F nods. [22:19:34] Hm.. no that's not applying [22:19:54] actionWidget.framed button { padding: 0; } [22:20:17] The only thing applying is the "framed button label { padding: 0 1em; }" [22:20:42] eg. in the save dialog [22:23:08] James_F: TrevorParscal: Can you verify which way it should look? left is current commit, right is what it would be if I removed those two conflicting rules thus restoring the regular button (e.g. like the Cancel button on the toolbar) http://imgur.com/HDcmFLO [22:23:45] Krinkle: I think left because otherwise the footer was too large. TrevorParscal? [22:25:00] Slimmer buttons in the footer seems nice, just curious whether it's intentional as it's not so obvious (small differences in colour/font-size/font-family/padding tend to be unintentional since we don't want too many variations). [22:27:17] Krinkle: they are a little smaller, and you are probably right that the horizontal padding is a little too big [22:27:26] something we can update in OOUI [22:27:31] (that is where it is specified) [22:27:32] k, no problem [22:27:50] so smaller is fine, but we may want to make the horizontal padding smaller too. [22:28:01] for later :) (or now, but I won't hold back the pull through) [22:28:21] TrevorParscal: I like fitLabel's logic. Math.max the two labels [22:28:27] they are meant to be a little smaller, not to be unbalanced - it turns out that horizontal padding needs to be greater than vertical padding to make it look balanced, but we have probably gone too far here and it looks wrong again [22:28:35] :) [22:29:03] yeah, the eye is funny like that with text. [22:29:04] notice that it uses padding, so the window resize or label change doesn't require a re-fit, only changes in the action buttons [22:29:17] TrevorParscal, so VE uses oojs-ui from core or from VE? [22:29:27] I saw the hardcoded 93px and was worried about i18n, but it's dynamically inlined. [22:29:35] jgonera: MW-core. [22:29:42] jgonera: when using the VE extension it is pulled from core [22:29:50] jgonera: But VE-standalone uses OOUI from… VE-standalone. [22:30:09] right, it's got an embedded distribution for standalone [22:30:25] TrevorParscal commenting out OO.ui.Toolbar.prototype.onMouseDown or inserting an alert there has no effect on that Cite button [22:30:53] (03CR) 10Alex Monk: "Minor breakage from this" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [22:31:35] James_F: The context menu for extensions/templates used to have a presence on the top right of the highlight. With the new context menu this is only on the bottom. This means when selecting a large element, you don't see the context menu and more or less can't edit it (See the syntaxhighlight block on the worksheet) [22:31:47] Krenair: Whoops. I /think/ that's now fixed by https://gerrit.wikimedia.org/r/144866 [22:31:48] Can you look into that / file bug if needed? [22:32:20] Krinkle: The worksheet? [22:32:33] Krinkle: Is there a standard test page you're using? [22:32:40] we both use it? [22:32:49] Its' the one we copied to mw.org and I pulled down on my localhost [22:32:50] We do? [22:32:57] "Basic worksheet" [22:33:10] which is outdated for "Every weird crap case we can imagine" [22:33:15] http://i.imgur.com/fNGVSOd.png [22:33:25] you created it originally [22:33:29] It's my defacto test page [22:33:32] Oh, yeah, https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet [22:33:36] I forgot about that. [22:34:18] Krinkle: And hmm, that does look wrong. [22:34:50] ok, so https://gerrit.wikimedia.org/r/#/c/144866/ is being reviewed? Has it been fixed to include the right versions of things and such? [22:35:07] TrevorParscal: Yes (by Krinkle) and yes (by me). [22:36:36] Oh... why do I always find new bugs when reviewing code. The "Change image" on the media dialog doesn't work? It shows in the document, but isn't applied when I look at the diff later [22:36:54] Krinkle: Is the context embedded at the bottom or not at all for you? [22:37:07] James_F: At the bottom outside the highlight [22:37:14] like for a link basically [22:37:26] but off screen most of the time [22:37:27] Krinkle: Oh, that's Ed's change, but it sounds off. [22:37:30] James_F, trying to test it, am I missing something? [22:37:56] I'm going to bed soon, so I won't file bugs for those two things [22:38:06] It fails to load VE... [22:38:08] Krenair: The new insert / apply buttons logic for ProcessDialogs /should/ fix that issue. [22:38:35] Hm.. I think this might be a bug in the commit actually. It seems nothing I do in dialogs has any effect [22:38:37] Krenair: You need the OOUI pullthrough for MW-core too – https://gerrit.wikimedia.org/r/#/c/146120/ [22:38:41] Krenair: Krinkle is currently reviewing. [22:38:54] Krinkle: That's certainly bad-sounding. [22:39:55] James_F: Yep, confirmed [22:40:05] I can make all of 1 transaction. any edit made after that is applied to CE, but not saved. [22:40:08] Krinkle: Are you sure you're using the right version? [22:40:17] can you look to see if you have a file called ve.ui.ActionDialog [22:40:30] because if you do, it is not the right code [22:40:30] There are no exceptions or errors [22:40:36] hmm [22:40:43] James_F, confirmed, this seems to fix the issue [22:40:54] Krenair: Kk. [22:41:01] Krenair: That's good to know. :-) [22:41:11] If I remove a "." in the text, and then proceed to edit , a template, an image and add a list item somwwhere, the diff is only the removal of the dot. [22:41:21] checking master now [22:41:59] (03CR) 10Alex Monk: Use ActionDialog and NodeDialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [22:42:44] Krinkle: what about the version of OOUI you are bringing in through mw core? [22:42:56] I checked out the pending commit in core [22:43:00] mw [22:43:06] There'd be exceptions otherwise [22:44:39] change image is working for me [22:44:44] you still having issues? [22:48:13] Krinkle: you removed the getBodyHeight() from references list dialog, but maybe shouldn't have? [22:48:28] ? [22:48:32] I know of no such thing [22:48:45] ve.ui.windowFactory.register( OO.ui.ConfirmationDialog ); [22:48:48] that throws [22:49:13] how is that sneaking back in? [22:49:18] we have fixed that multiple times [22:49:24] something is messed up [22:49:45] lib/ve/modules/ve/ui/ve.ui.js [22:50:22] Hm.. Looks like patch I was reviewing changed again while I was reviewing [22:50:23] It's gone now [22:51:30] ok, well I have a fix for the referenceslist dialog's height [22:51:31] not sure if this is a new bug: Highlights are overlapping the toolbar: http://i.imgur.com/auc31lH.png [22:51:37] should I not push it? [22:51:45] z-index? [22:52:10] I'm not sure exactly when that was introduced yet [22:52:23] The image changing is still not workign though [22:52:56] Krinkle: Maybe we should ship you VM images of VE to test so you don't get as much breakage? :-) [22:55:16] TrevorParscal: "Done" button in default mw extension inspectors (e.g. for source code) is a huge improvement over the "<" arrow. [22:55:28] :) [22:56:12] Krinkle: Glad you're happy. :-) [22:56:17] It seems the new code is hitting a race condition causing the media inspector to request images twice from Commons, one of which always gets aborted (this happens when you click Chnage images, which prefills the search for page name) [22:57:48] That's not good. [22:58:19] I have a fix for some dialog heights, is it safe to push that now? [22:58:47] TrevorParscal: Go for it. [22:59:08] (03PS26) 10Trevor Parscal: Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 [23:00:26] James_F: TrevorParscal: From patch set 20 onwards, author=James instead of Trevor (not committed, but author) [23:00:30] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:01:13] TrevorParscal: git commit --amend -C HEAD --reset-author; toss :) [23:03:16] (03CR) 10Mwalker: [C: 032] Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146165 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [23:03:24] TrevorParscal: Why does it need a hardcoded number? I Don't get it [23:03:42] Doesn't the parent class have all this smart logic for outerHeight() and calculation and stuff? [23:03:47] Is that never used? [23:04:29] I removed it from the demos only, I didn't touch reference list. I removed it in the demo so that the default logic (which I guess is supposed to work) is exposed there. And that does seem cram indeed. [23:04:38] (see sample dialogs in oojs-ui) [23:06:04] (03Merged) 10jenkins-bot: Update VE core submodule to e3fa7ec8 [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/146165 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [23:07:04] (03PS1) 10Nemo bis: Simplify visualeditor-help-title and visualeditor-timeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 [23:08:28] (03CR) 10Mwalker: [C: 032 V: 032] "[16:07] mwalker: Reedy: Unrelated test that was added to core recently to catch tests leaking jQuery animations." [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146166 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [23:08:48] (03CR) 10Krinkle: "This is a backport to wmf/1.24wmf13 and jenkins tests it with mw-core master (which is wrong)." [extensions/VisualEditor] (wmf/1.24wmf13) - 10https://gerrit.wikimedia.org/r/146166 (https://bugzilla.wikimedia.org/67985) (owner: 10Jforrester) [23:09:23] (03CR) 10jenkins-bot: [V: 04-1] Simplify visualeditor-help-title and visualeditor-timeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [23:14:31] (03CR) 10Nemo bis: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [23:21:40] (03CR) 10Nemo bis: "Usual jenkins error I assume" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [23:24:47] (03PS27) 10Krinkle: Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:26:42] TrevorParscal: http://i.imgur.com/Wa9h5Ay.png [23:27:21] (03CR) 10Krinkle: "No, mediawiki-core upgraded OOjs UI which contains a breaking change. Current master can't always be compatible with master of mediawik-co" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [23:34:24] (03CR) 10Nemo bis: "OK. This can wait. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [23:46:13] Krinkle: you still alive? [23:46:27] TrevorParscal: nvm, I figured you're in a meeting. [23:46:34] yes, sorry I was [23:46:37] Leaving a comment instead and merging, I'm off to sleep [23:46:38] just curious how it's going [23:46:57] well, with mw core merged and not vemw, it's in a bad state [23:46:59] (03CR) 10Krinkle: [C: 032] "Merging, but please do read this:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:47:00] TrevorParscal: ^ [23:47:43] Bye Krinkle|detached. [23:48:40] (03CR) 10Krinkle: "(the message dialog in the oojs-ui demos, for example, does this correctly)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:49:08] (03Merged) 10jenkins-bot: Update VE core submodule to master (f2277ea) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:53:37] (03CR) 10Trevor Parscal: "We can't auto-size booklet layout dialogs because their contents are totally dynamic. There might be one outline item and small amount of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144866 (owner: 10Trevor Parscal) [23:54:08] Krinkle|detached: I replied