[00:01:01] (03PS2) 10Jforrester: Simplify visualeditor-help-title and visualeditor-timeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [00:01:44] (03PS2) 10Jforrester: Give a notice if the user isn't allowed to create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:02:06] (03PS2) 10Jforrester: Keep focus when live editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [00:02:17] (03PS2) 10Jforrester: Deprecate 'live' event in favor of 'setup' and 'teardown' in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144634 (https://bugzilla.wikimedia.org/55505) (owner: 10Mooeypoo) [00:02:46] (03PS1) 10Trevor Parscal: Mellow out the shadows being applied to dialog content [oojs/ui] - 10https://gerrit.wikimedia.org/r/146353 [00:02:58] MERGE MERGE MERGE!!!! [00:03:01] :P [00:04:36] (03CR) 10jenkins-bot: [V: 04-1] Give a notice if the user isn't allowed to create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:05:47] what [00:09:34] I rebased. [00:09:34] (03PS1) 10Trevor Parscal: Close the citation dialog after the apply changes button is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146355 [00:09:50] (03CR) 10Jforrester: [C: 032] Mellow out the shadows being applied to dialog content [oojs/ui] - 10https://gerrit.wikimedia.org/r/146353 (owner: 10Trevor Parscal) [00:10:00] (03CR) 10Jforrester: [C: 032] Close the citation dialog after the apply changes button is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146355 (owner: 10Trevor Parscal) [00:10:29] (03Merged) 10jenkins-bot: Mellow out the shadows being applied to dialog content [oojs/ui] - 10https://gerrit.wikimedia.org/r/146353 (owner: 10Trevor Parscal) [00:11:44] (03Merged) 10jenkins-bot: Close the citation dialog after the apply changes button is clicked [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146355 (owner: 10Trevor Parscal) [00:14:19] (03PS6) 10Jforrester: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:14:48] (03CR) 10Jforrester: "PS6 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:16:13] (03CR) 10jenkins-bot: [V: 04-1] Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:17:25] (03PS2) 10Jforrester: Make sure the document is focused when setting a selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145346 (https://bugzilla.wikimedia.org/67432) (owner: 10Esanders) [00:19:21] (03CR) 10Jforrester: [C: 032] Make sure the document is focused when setting a selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145346 (https://bugzilla.wikimedia.org/67432) (owner: 10Esanders) [00:21:02] (03Merged) 10jenkins-bot: Make sure the document is focused when setting a selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145346 (https://bugzilla.wikimedia.org/67432) (owner: 10Esanders) [00:21:07] (03CR) 10Jforrester: [C: 032] Add toolbar action section to SA demo with keyboard shortcuts tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145533 (owner: 10Esanders) [00:21:41] Does anyone remember how to open dialog by name from JS console? [00:22:04] (03CR) 10Jforrester: [C: 032] "Indeed, "the test only needed it to be an alien of some kind" is true." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 (owner: 10Esanders) [00:22:35] (03Merged) 10jenkins-bot: Add toolbar action section to SA demo with keyboard shortcuts tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145533 (owner: 10Esanders) [00:22:40] InezK: openWindow( 'name' ); [00:23:21] InezK: Oh, sorry, previously it was WindowSet.open( 'name' ); [00:23:35] ve.instances[0].getDialogs().getWindow( 'wikiaOrientation' ).open(); [00:23:37] InezK: Just landed a big change which introduces WindowManager instead. [00:23:39] apparently that's a one way [00:23:44] oh, interesting [00:23:50] (03Merged) 10jenkins-bot: Fix alien test data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144328 (owner: 10Esanders) [00:23:55] Yeah, that looks right. [00:24:27] (03PS5) 10Jforrester: Fixes to getRelativeOffset and getRelativeRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144136 (https://bugzilla.wikimedia.org/67551) (owner: 10Esanders) [00:24:34] (03PS2) 10Jforrester: [BREAKING CHANGE] Remove generatedContents argument from afterRender [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145446 (owner: 10Esanders) [00:55:43] (03PS3) 10Jforrester: Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [00:55:58] (03PS4) 10Jforrester: Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [00:56:41] (03CR) 10Jforrester: [C: 031] "PS3 adds some labels for clarity about what's being shown (bit of a hack; maybe instead should be fieldsets somehow?)." [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [00:57:25] (03CR) 10jenkins-bot: [V: 04-1] Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [01:01:11] (03PS1) 10Jforrester: demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 [01:02:54] (03PS5) 10Jforrester: Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [01:05:09] (03CR) 10Jforrester: [C: 031] "PS5 fixes stupid CSS errors (whoops :-))." [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [01:12:16] (03PS2) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 [01:12:20] (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 (owner: 10Jforrester) [02:08:00] (03PS13) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [02:08:02] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [02:16:59] (03PS14) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [02:17:27] (03CR) 10Divec: "Patchset 14: rebase" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [02:17:54] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [02:21:16] (03PS15) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [02:22:04] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [02:23:06] (03PS16) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [02:24:05] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [02:32:03] (03PS17) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [02:33:33] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [07:11:51] (03PS1) 10Mooeypoo: [wip] Add autovalue to TemplateData editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/146395 [07:12:11] (03PS1) 10Mooeypoo: [wip] Add 'autovalue' to TemplateData [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146396 [07:32:04] 3VisualEditor / 3Editing Tools: VisualEditor:Switching to Default tab is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Insert an image in a page 2.Change the size of the... [07:32:33] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf 14]Switching to Default tab is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10ryasmeen) 5NEW>3ASSI a:3Moriel Schottlender [07:33:18] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after about-grouped inline alien - 10https://bugzilla.wikimedia.org/67985 (10James Forrester) p:5Unprio>3Highes s:5normal>3major a:3Ed Sanders [07:38:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10James Forrester) p:5Unprio>3Normal [07:41:01] 3OOjs UI: OOjs UI: InlineMenuWidget doesn't handle mouse events properly - 10https://bugzilla.wikimedia.org/67821 (10James Forrester) 5PATC>3RESO/FIX [07:41:47] (03CR) 10Nemo bis: Simplify visualeditor-help-title and visualeditor-timeout (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [10:32:48] 3VisualEditor / 3Editing Tools: VisualEditor: switching to "Default" image size in image inspector does not make Apply Changes button active - 10https://bugzilla.wikimedia.org/68014 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None in order to save this change a user must make another change... [10:42:32] 3VisualEditor / 3ContentEditable: VisualEditor: Problems typing after cursoring off an inline focusable nodes in Firefox - 10https://bugzilla.wikimedia.org/67432 (10James Forrester) 5PATC>3RESO/FIX [10:45:33] (03PS1) 10Esanders: Unit tests for showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146422 [10:45:35] (03CR) 10jenkins-bot: [V: 04-1] Unit tests for showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146422 (owner: 10Esanders) [10:46:23] (03PS1) 10Esanders: Documentation fixes in test utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146423 [10:51:11] (03PS2) 10Esanders: Unit tests for showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146422 [10:52:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: FlaggedRevs status box causes blank space down the right side of CE content div - 10https://bugzilla.wikimedia.org/50340#c1 (10This, that and the other) Seems fixed? [10:57:05] (03CR) 10Esanders: [C: 04-1] demos: Add LTR/RTL switcher to icons demo (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [11:26:19] 3VisualEditor / 3Editing Tools: VisualEditor: Switching tabs in mobile safari sometimes causes page to refresh causing data loss for session changes - 10https://bugzilla.wikimedia.org/68017 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Invoke VE from iOS Safari on tablet, Make changes t... [11:27:18] 3VisualEditor / 3Mobile: VisualEditor: text cannot be pasted into link inspector search filed from mobile browser - 10https://bugzilla.wikimedia.org/68018 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Tap, or tap and hold on text input field in tablet VE, expected behavior, native iOS co... [11:28:02] 3VisualEditor / 3Mobile: VisualEditor: text cannot be pasted into link inspector search filed from mobile browser - 10https://bugzilla.wikimedia.org/68018 (10Jared Zimmerman (WMF)) [11:28:02] 3VisualEditor / 3Mobile: VisualEditor: Switching tabs in mobile safari sometimes causes page to refresh causing data loss for session changes - 10https://bugzilla.wikimedia.org/68017 (10Jared Zimmerman (WMF)) [11:28:17] 3VisualEditor / 3Mobile: VisualEditor: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017 (10Jared Zimmerman (WMF)) [11:28:17] 3VisualEditor / 3Mobile: VisualEditor: Switching tabs in mobile safari sometimes causes page to refresh causing data loss for session changes - 10https://bugzilla.wikimedia.org/68017 (10Jared Zimmerman (WMF)) p:5Unprio>3High s:5normal>3critic [11:32:17] 3VisualEditor / 3Editing Tools: When the text in buttons is too long, some of them may overflow - 10https://bugzilla.wikimedia.org/68005#c2 (10Rastus Vernon) Created attachment 15937 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15937&action=edit Example of the expected behavior, in English, for com... [11:35:21] 3VisualEditor / 3Editing Tools: When the text in buttons is too long, some of them may overflow - 10https://bugzilla.wikimedia.org/68005 (10Rastus Vernon) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15935 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15935&action=edit Example with c... [11:41:48] 3VisualEditor / 3Technical Debt: VisualEditor: Work out whether removing repositionOnly parameter in DesktopContext.update() was a good idea - 10https://bugzilla.wikimedia.org/66507#c3 (10James Forrester) 5ASSI>3RESO/FIX Done in gerrit 141089. [11:42:32] 3VisualEditor / 3Editing Tools: When the text in buttons is too long, some of them may overflow - 10https://bugzilla.wikimedia.org/68005#c1 (10Rastus Vernon) Created attachment 15936 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15936&action=edit Example with French text where two buttons overflow. [11:43:02] 3VisualEditor / 3ContentEditable: VisualEditor: Provide a way (beyond Ctrl-Click, middle-click, or right-click/tab) to open links in another window - 10https://bugzilla.wikimedia.org/54759#c2 (10James Forrester) 5ASSI>3RESO/FIX Fixed in gerrit 139550. [11:44:01] 3OOjs UI: OOjs UI: When the text in buttons in confirmation dialogs is too long, some of the buttons may overflow, breaking the dialog - 10https://bugzilla.wikimedia.org/68005 (10James Forrester) [11:46:48] 3VisualEditor / 3Editing Tools: VisualEditor: Font is too small in dialogs in standalone VE - 10https://bugzilla.wikimedia.org/65322#c1 (10James Forrester) 5ASSI>3RESO/FIX Fixed in gerrit 141089. [11:46:48] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501#c5 (10James Forrester) 5ASSI>3RESO/FIX Fixed in gerrit 139550. [11:46:49] 3VisualEditor / 3Editing Tools: OOjs UI: When the text in buttons in confirmation dialogs is too long, some of the buttons may overflow, breaking the dialog - 10https://bugzilla.wikimedia.org/68005#c3 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3High a:3Trevor Parscal Happily we just fixed this i... [11:47:19] (03PS8) 10Esanders: MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [11:47:47] (03PS9) 10Esanders: MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [11:52:00] (03CR) 10Esanders: MWImageModel unit tests (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [11:54:03] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery and Math inspector closes with an animation from right to left after clicking on "<" to close them - 10https://bugzilla.wikimedia.org/66552#c2 (10James Forrester) 5ASSI>3RESO/FIX Fixed in gerrit 139550. [11:54:03] 3OOjs UI: OOjs UI: Dialogs should not display below visible page area - 10https://bugzilla.wikimedia.org/52526#c1 (10James Forrester) 5PATC>3ASSI This is fixed for dialogs in gerrit 139550. It's not yet fixed for inspectors (which I suppose should scroll-into-view?). [11:54:46] 3OOjs UI: OOjs UI: Dialogs flow off-screen with small windows or high zoom level, leaving user without UI controls onscreen to close dialog - 10https://bugzilla.wikimedia.org/52187#c4 (10James Forrester) 5PATC>3RESO/FIX Fixed in gerrit 139550. [12:02:31] (03PS17) 10Vikassy: [BrowserTests] Added support for iframe elements for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [12:07:16] 3OOjs UI: OOjs UI: The Cancel dialog should not have an X (just "Continue editing" and "Discard edits"), and if it does, clicking it shouldn't discard changes - 10https://bugzilla.wikimedia.org/66851#c1 (10James Forrester) 5PATC>3RESO/FIX Fixed in gerrit 139550. [12:08:32] 3OOjs UI: OOjs UI: Dialogs do not horizontally scroll in narrow windows - 10https://bugzilla.wikimedia.org/51755#c1 (10James Forrester) 5PATC>3RESO/FIX Fixed in gerrit 139550. [12:14:33] 3VisualEditor / 3Mobile: VisualEditor Mobile: Context menu for Math is still appearing in Mobile VE - 10https://bugzilla.wikimedia.org/68010 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Tapping on a math node is still bringing up the context menu on top of the page,letting user to open math inspector. [12:15:15] (03CR) 10Zfilipin: [C: 04-1] [BrowserTests] Added support for iframe elements for language screenshot (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (owner: 10Vikassy) [12:17:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Context menu for Math is still appearing in Mobile VE - 10https://bugzilla.wikimedia.org/68010 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [12:31:33] (03PS1) 10Vikassy: Added support for page elements in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146432 [12:33:26] (03PS2) 10Vikassy: [BrowserTest] Added support for page elements in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146432 [12:36:27] (03PS18) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 [12:41:32] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after about-grouped inline alien - 10https://bugzilla.wikimedia.org/67985#c17 (10James Forrester) 5PATC>3RESO/FIX Now fixed. Thank you, all. [13:25:28] (03PS19) 10Zfilipin: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:26:11] (03PS3) 10Zfilipin: [BrowserTest] Added support for page elements in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146432 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:29:03] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Added support for page elements in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146432 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:30:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf13] "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609#c1 (10Ed Sanders) 5ASSI>3RESO/FIX Appears to be fixed in ma... [13:30:44] (03Merged) 10jenkins-bot: [BrowserTest] Added support for page elements in iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146432 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [13:32:16] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755 (10Ed Sanders) [13:33:01] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node backwards by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755 (10Ed Sanders) [13:41:46] 3VisualEditor / 3Mobile: VisualEditor: text cannot be pasted into link inspector search field from mobile browser - 10https://bugzilla.wikimedia.org/68018 (10Elitre) [14:44:48] 3VisualEditor: Half of the buttons in the cancell window - 10https://bugzilla.wikimedia.org/68036 (10AlekseiSh) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15938 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15938&action=edit window with ru-text *Edit, make change *cliсk tab "Edit so... [14:45:31] 3VisualEditor: Half of the buttons in the cancell window - 10https://bugzilla.wikimedia.org/68036#c1 (10AlekseiSh) Created attachment 15939 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15939&action=edit window with en-text normal window [14:46:31] 3VisualEditor: Half of the buttons in the cancell window - 10https://bugzilla.wikimedia.org/68036 (10AlekseiSh) [15:06:34] 3VisualEditor / 3ContentEditable: Replace text after templte with lang tag - 10https://bugzilla.wikimedia.org/68037 (10AlekseiSh) 3UNCO p:3Unprio s:3blocke a:3None (ru-wiki) template text: [[Немецкий язык|нем.]] ''{{{1}}}''{{doc|Lang/doc}}[[Категория:Шаблоны язы... [15:07:16] 3VisualEditor / 3ContentEditable: Replace text after templte with lang tag - 10https://bugzilla.wikimedia.org/68037#c1 (10AlekseiSh) https://ru.wikipedia.org/wiki/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%92%D0%B8%D0%B7%D1%83%D0%B0%D0%BB%D1%8C%D0%BD%D1%8B%D0%B9_%D1%80%D0%B5%D0%B4%D0%B0%D0%BA... [15:08:46] 3VisualEditor / 3ContentEditable: Replace text after templte with lang tag - 10https://bugzilla.wikimedia.org/68037#c2 (10AlekseiSh) Пытаюсь воспроизвести; у меня не удаление, а последовательная (циклическая?) замена текста на повторяющуюся строку "разн"; процесс останавливается по Ctrl-Z (от [15:10:13] (03PS1) 10Esanders: Don't handle up/down on focusableNodes even if backwards [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146472 (https://bugzilla.wikimedia.org/67755) [15:19:32] edsanders: heya [15:19:46] hi [15:20:12] so, how *do* dialog objects live and die? :) [15:20:20] mine is not tearing down right. [15:20:48] when I open it again basically all the old stuff persists i.e. the old reference node it's using [15:20:59] mostly that actually. [15:22:43] aaand nvm. [15:22:47] got it. [15:23:14] :) [15:23:38] see, this is why I never chat in irc, ^-^ [15:23:40] you should put form construction in initialize, then information specific to that instance in setup/teardown [15:23:53] :) [15:24:19] 3VisualEditor: Opens wrong page in Edit source after making change in VE in old version of artcle - 10https://bugzilla.wikimedia.org/68038 (10AlekseiSh) 3UNCO p:3Unprio s:3normal a:3None *open old version of artcle *press tab Edit *make some changes *press tab Edit source *in warnng window press "Disca... [15:24:31] 3VisualEditor: Opens wrong page in Edit source after making change in VE in old version of artcle - 10https://bugzilla.wikimedia.org/68038 (10AlekseiSh) [15:26:21] hey, do you know about this Impact Hub at King's Cross thing? [15:28:03] hmm I have shoved a bunch of things i shouldn't into initialize rather than setup by that metric. will move. [15:33:11] Heya. [15:33:30] hi [15:39:44] mvolz: BTW, did you get that tour of TemplateData Matt suggested? [15:40:49] 3VisualEditor: Link in floating window (Edit filter) open article in this window - 10https://bugzilla.wikimedia.org/68040 (10Sunpriat) 3UNCO p:3Unprio s:3major a:3None Created attachment 15940 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15940&action=edit window with message Calling message... [15:41:31] 3VisualEditor: Link in floating window (Edit filter) open article in this window - 10https://bugzilla.wikimedia.org/68040#c1 (10Sunpriat) Created attachment 15941 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15941&action=edit window after click on link [15:45:36] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] "Error: ve.dm.Document.getNodeFromO ffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609#c2 (10James Forrester) a:5Ed Sanders>3Trevor Parscal Yeah, fix... [15:48:01] 3VisualEditor: Link in floating window (Edit filter) open article in this window - 10https://bugzilla.wikimedia.org/68040 (10Sunpriat) [15:53:14] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Remove generatedContents argument from afterRender [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145446 (owner: 10Esanders) [15:54:45] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove generatedContents argument from afterRender [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145446 (owner: 10Esanders) [16:02:53] James_F: no, not yet. [16:03:01] at the time it wasn't super relevant yet. [16:03:12] now I'm sort of approaching that :) [16:03:18] mvolz: Cool. :-) [16:03:38] I hear Krinkle is moving to London but I don't know when, haha. [16:03:44] might have to chase him down [16:08:16] 3VisualEditor / 3ContentEditable: Replace text after template with lang tag - 10https://bugzilla.wikimedia.org/68037#c3 (10Andre Klapper) s:5blocke>3normal Hi Sunpriat, thanks for taking the time to report this! Where is this template exactly located? Is there a diff on Russian Wikipedia where this pro... [16:09:49] mvolz: Ha, yeah, though we should help you now. [16:10:00] mvolz: Krinkle is an expert but not the only one that can help. :-) [16:17:40] (03CR) 10Jforrester: demos: Add LTR/RTL switcher to icons demo (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [16:44:18] 3VisualEditor: VisualEditor and Parsoid: When saving a page, only send back the parts of the page that have been changed - 10https://bugzilla.wikimedia.org/68042 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Currently, if you change a single character in a long page, the entire contents of the pag... [16:47:31] 3VisualEditor / 3ContentEditable: Replace text after template with lang tag - 10https://bugzilla.wikimedia.org/68037#c4 (10Sunpriat) (In reply to Andre Klapper from comment #3) > Hi Sunpriat, thanks for taking the time to report this! > > Where is this template exactly located? Is there a diff on Russian >... [16:52:34] 3VisualEditor / 3Editing Tools: Undo(Ctrl+z) doesn't work on adding content by advanced options - 10https://bugzilla.wikimedia.org/68043 (10apsdehal) 3UNCO p:3Unprio s:3normal a:3None If one adds content via Advanced options then use Ctrl+z to undo it, this doesn't work. [17:04:34] http://www.trulia.com/local/san-francisco-ca/driving:0%7Ctransit:1%7Cposition:37.785825;-122.401495%7Ctime:60_commute [17:13:09] James_F: Someone on #wikipedia-nl irc pinged me saying someone should process the new feedback on https://nl.wikipedia.org/wiki/Wikipedia:Visuele_tekstverwerker/Feedback [17:13:14] Let me know if you want me to do that [17:15:55] James_F: A quick scan shows that they've grouped "current issues" from solved/invalid ones. Anything under "huidige problem" would be current. Any headings below that one may also be current as they've not been processed yet. [17:16:00] Krinkle: Ta; I think Elitre was going to look at it. [17:16:06] the most pressing one seems the bottom one (categories removed when changing whitespace) [17:16:16] "3: Categorieen verdwijnen bij weghalen witruimte" [17:16:32] Hmm. [17:17:31] (03PS18) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [17:18:51] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [17:20:00] (03CR) 10Trevor Parscal: [C: 032] Don't handle up/down on focusableNodes even if backwards [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146472 (https://bugzilla.wikimedia.org/67755) (owner: 10Esanders) [17:21:13] (03CR) 10Trevor Parscal: [C: 032] Unit tests for showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146422 (owner: 10Esanders) [17:21:30] (03Merged) 10jenkins-bot: Don't handle up/down on focusableNodes even if backwards [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146472 (https://bugzilla.wikimedia.org/67755) (owner: 10Esanders) [17:22:02] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node backwards by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755 (10James Forrester) 5PATC>3RESO/FIX [17:22:32] (03Merged) 10jenkins-bot: Unit tests for showSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146422 (owner: 10Esanders) [17:22:42] (03CR) 10Trevor Parscal: [C: 032] Documentation fixes in test utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146423 (owner: 10Esanders) [17:23:52] (03CR) 10Trevor Parscal: [C: 032] Fixes to getRelativeOffset and getRelativeRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144136 (https://bugzilla.wikimedia.org/67551) (owner: 10Esanders) [17:24:01] (03Merged) 10jenkins-bot: Documentation fixes in test utils [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146423 (owner: 10Esanders) [17:25:11] (03CR) 10Trevor Parscal: "How does this interact with the dialog rewrite, a la live editing not really working anymore?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [17:25:51] (03Merged) 10jenkins-bot: Fixes to getRelativeOffset and getRelativeRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144136 (https://bugzilla.wikimedia.org/67551) (owner: 10Esanders) [17:28:47] 3VisualEditor / 3ContentEditable: Replace text after template with lang tag - 10https://bugzilla.wikimedia.org/68037#c5 (10James Forrester) 5UNCO>3RESO/DUP This is a problem with the {{lang-**}} templates, which is bug 67985 and was fixed yesterday afternoon (SF time). *** This bug has been marked as a... [17:28:47] 3VisualEditor / 3ContentEditable: VisualEditor: Cursor positioning broken after about-grouped inline alien - 10https://bugzilla.wikimedia.org/67985#c18 (10James Forrester) *** Bug 68037 has been marked as a duplicate of this bug. *** [17:29:16] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) 5PATC>3RESO/FIX [17:29:18] TrevorParscal: I'm not convinced. [17:29:26] about the dialog thing? [17:29:32] Yeah. [17:29:45] I think the live-editing from an inspector is what we should strive for more widely. [17:29:54] It's part of what makes it cool. [17:30:26] well, we need a way to make the box not jump around on you if we are going to continue with that design [17:30:35] I agree. [17:30:47] 3VisualEditor / 3Data Model: VisualEditor: Pressing right in a slug a the end of a document takes you back to before the slug-causing node - 10https://bugzilla.wikimedia.org/67551 (10James Forrester) 5PATC>3RESO/FIX [17:30:59] and on mobile we will need to bypass the preview altogether since it will be hidden [17:31:23] Or show it inside the dialog somehow if there's space. [17:33:16] 3VisualEditor / 3Data Model: VisualEditor and Parsoid: When saving a page, only send back the parts of the page that have been changed - 10https://bugzilla.wikimedia.org/68042 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [17:38:16] 3VisualEditor: Half of the buttons in the cancell window - 10https://bugzilla.wikimedia.org/68036#c2 (10James Forrester) Created attachment 15943 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15943&action=edit New design for the window showing no missing buttons (ru i18n) [17:39:02] 3OOjs UI: OOjs UI: Long labels mean the confirmation dialog buttons can get mis-aligned / inaccessible - 10https://bugzilla.wikimedia.org/68036#c3 (10James Forrester) 5UNCO>3RESO/FIX p:5Unprio>3High a:3Trevor Parscal This has just been fixed with the new design for confirmation windows. Sorry! [18:08:32] (03CR) 10Trevor Parscal: [C: 032] Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [18:09:08] (03Merged) 10jenkins-bot: Split toolbar demo in two and add action button demo, with labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/145537 (owner: 10Esanders) [18:09:57] (03CR) 10Trevor Parscal: [C: 04-1] "Why isn't the return false in the toolbar's mousedown handler taking care of this?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/145542 (owner: 10Esanders) [18:11:14] (03CR) 10Trevor Parscal: [C: 032] ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145981 (owner: 10Krinkle) [18:12:30] (03Merged) 10jenkins-bot: ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145981 (owner: 10Krinkle) [18:12:50] TrevorParscal: Seen my little stack of toolbar fiddles from https://gerrit.wikimedia.org/r/#/c/145448/ upwards? [18:13:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15944 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15944&ac... [18:13:35] TrevorParscal: Also, Krenair's https://gerrit.wikimedia.org/r/#/c/142468/ and https://gerrit.wikimedia.org/r/#/c/143097/ are awaiting your review [18:16:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: Suppress being able to click on links in the error messages from mis-placed local wiki customisations - 10https://bugzilla.wikimedia.org/68040#c2 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low s:5major>3minor This is caused by an unsuitable us... [18:16:05] where is the combo box being used, and why do we need this vs. lookup input widget? [18:17:23] TrevorParscal: It's to be used for the reference group label (we want to push people to re-using almost always, but have the ability to write in a new one as needed). [18:17:54] TrevorParscal: The lookup input widget is too search-focussed rather than providing a simple list. [18:19:38] (03CR) 10Trevor Parscal: [C: 04-1] "Do we have a use case for this? Maybe this could be a parent class of LookupInputWidget which does the same thing, except with an async da" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [18:19:46] 3VisualEditor / 3MediaWiki integration: Opens wrong page in Edit source after making change in VE in old version of artcle - 10https://bugzilla.wikimedia.org/68038#c1 (10James Forrester) 5UNCO>3RESO/WON This is consistent with how the wikitext editor works – on an old page, the "Read" link goes to the la... [18:21:14] TrevorParscal, in the new dialog refactor-- if I need to put a method specifically only for when the user cancels the action, I assume it goes in getActionProcess and inside the action === 'back' section? [18:21:52] there's this.switchPanels( 'edit' ); in there for the media dialog right now -- that's just to reset the dialog, right? I'm making sure I'm in the right plce [18:22:23] (03CR) 10Trevor Parscal: [C: 04-1] Allow FieldLayouts to have help text (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:22:40] (03CR) 10Trevor Parscal: [C: 032] Add toolbar menu labels to each group for consistency [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145448 (owner: 10Jforrester) [18:23:03] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3minor [18:23:04] (03CR) 10Trevor Parscal: [C: 032] Move 'language' tool from the insert to the styling menu, like in VE-MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145458 (owner: 10Jforrester) [18:23:09] TrevorParscal: Thanks! [18:23:19] (03CR) 10Alex Monk: "Yes, see the bug that's blocked by this" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [18:23:57] James_F: in 145459, you introduce a "big-add" icon, but I think it could just be called insert [18:23:57] (03Merged) 10jenkins-bot: Add toolbar menu labels to each group for consistency [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145448 (owner: 10Jforrester) [18:24:21] we should try and keep icon names descriptive of the meaning, rather than descriptive of the graphic [18:24:21] TrevorParscal: Sure; it's just a bigger version of the 'add' icon though… :-) [18:24:38] TrevorParscal: If you think "insert" is a good enough name, that WFM. [18:24:40] (03Merged) 10jenkins-bot: Move 'language' tool from the insert to the styling menu, like in VE-MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145458 (owner: 10Jforrester) [18:24:47] yeah, but we use the other one, "add-item", for adding items [18:25:17] you introduced an icon for insertion, and should it change to better convey insertion, it should naturally apply [18:25:43] (03CR) 10Trevor Parscal: [C: 04-1] "Rename this icon to "insert"." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145459 (owner: 10Jforrester) [18:25:48] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15945 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15945&action=edit Screenshot Open... [18:26:18] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053 (10ryasmeen) 5NEW>3ASSI a:3Trevor Parscal [18:28:48] (03PS2) 10Jforrester: Remove label from 'insert' menu, and instead use a large plus icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145459 [18:29:17] 3VisualEditor / 3MediaWiki integration: Opens wrong page in Edit source after making change in VE in old version of artcle - 10https://bugzilla.wikimedia.org/68038#c2 (10Sunpriat) (In reply to James Forrester from comment #1) > This is consistent with how the wikitext editor works – on an old page, the > "Re... [18:29:44] (03CR) 10Jforrester: [C: 032] "Let's go with this for now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [18:30:49] TrevorParscal: (Done.) [18:30:55] (03PS3) 10Alex Monk: Allow FieldLayouts to have help text [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) [18:31:17] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053 (10James Forrester) p:5Unprio>3Normal s:5normal>3minor [18:31:33] (03Merged) 10jenkins-bot: Simplify visualeditor-help-title and visualeditor-timeout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146337 (owner: 10Nemo bis) [18:32:18] (03CR) 10Trevor Parscal: "Use case understood." [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:32:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: FlaggedRevs status box causes blank space down the right side of CE content div - 10https://bugzilla.wikimedia.org/50340#c2 (10James Forrester) 5ASSI>3RESO/FIX Indeed, probably fixed a while ago… [18:32:41] (03CR) 10Trevor Parscal: "Crap, wrong commit - sorry." [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:32:50] TrevorParscal: :-) [18:33:06] TrevorParscal, I put a breakpoint on the 'action === 'back'' condition inside the getActionProcess section and it doesn't get triggered on cancel. What am I missing? Where's the code that's triggered when the user cancels out of a dialog? [18:33:13] (03CR) 10Trevor Parscal: "Use case understood." [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [18:33:36] (03CR) 10Trevor Parscal: [C: 032] Remove label from 'insert' menu, and instead use a large plus icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145459 (owner: 10Jforrester) [18:33:49] ok, I think I got it. [18:34:11] TrevorParscal, "Cancel" seems to have a no-action (action === '') is this on purpose? [18:34:49] (03Merged) 10jenkins-bot: Remove label from 'insert' menu, and instead use a large plus icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/145459 (owner: 10Jforrester) [18:35:59] (03CR) 10Krinkle: [C: 04-1] Combo box widget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [18:37:49] mooeypoo: cancel needs no action [18:38:13] the new way of doing things is this.close() means close without doing anything, aka the safe way to get the hell out of there [18:38:18] TrevorParscal, ok, so if I add a 'action === '' { ... } I can trust that it will run on 'cancel' [18:38:26] this.close( { 'action': something } ) may have side effects [18:38:47] the parent class handles this [18:38:56] you don't want to override that [18:39:03] TrevorParscal, hm. I need to put this 'reset' method where it will only be triggered if the user cancels. [18:39:04] I have to [18:39:13] if you want to do something special on cancel, that's fine, just be sure to still fall through to the parent method [18:39:19] and !action should work [18:39:25] if it is empty or undefined [18:39:46] also, you probably always want to reset when you close right? [18:39:54] do it on teardown, not cancel [18:40:28] teardown is always called, and actions taken inside of teardown should be conditioned based on data.action [18:41:00] in short, if you are handling the cancel case (no action) anywhere, you are probably doing something wrong [18:41:29] TrevorParscal, when we're dealing with the image in the image dialog, we're using its scalable to do all calculations [18:41:41] ok [18:41:49] the media *size* widget listens to the scalable, and so is the model [18:42:03] right [18:42:04] so scalable has changes. But if we *cancel* these changes must be reset. [18:42:33] to the contrary, the changes should ONLY be kept if you don't cancel [18:42:34] That's why I need to do something in cancel. It works when I put it in getActionProcess() as "if (!action) " [18:42:36] but is it right? [18:42:40] basically, the same thing, but inverse [18:43:02] that would mean redoing the way things work now [18:43:03] completely [18:43:04] basically, handle specific cases where you keep the changes, and always cancel otherwise [18:43:11] let me look at the code [18:43:17] are you in a patchset or master? [18:43:23] let me push this [18:43:34] k [18:43:49] i can help you, i have time... it feels strange :) [18:45:18] (03CR) 10Trevor Parscal: [C: 032] Allow FieldLayouts to have help text [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:45:56] (03Merged) 10jenkins-bot: Allow FieldLayouts to have help text [oojs/ui] - 10https://gerrit.wikimedia.org/r/142468 (https://bugzilla.wikimedia.org/51798) (owner: 10Alex Monk) [18:46:12] (03PS1) 10Mooeypoo: [WIP] Reset scalable on cancel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 [18:46:19] TrevorParscal, ^^ [18:48:07] TrevorParscal, most of the problem here is the way we work with Scalable. Scalable is a sort of property of the image, that's responsible for all size calculations. Since both size widget and the model listen to events, it has to respond and actually run the actions that are there. At the end, I reset the image with 'syncScalableToType' (in teardown, because that should always happen) but if the user cancels, I have to reset the sca [18:48:08] lable's "current dimensions" that the size widget changed [18:49:13] you are correct that this is done a little wrong [18:49:19] the other option is to create a copy of the scalable for the sake of calculations and attach that copy into the size widget, letting the model listen to it. But then we will have two different scalable objects -- OR we will have a scalable object that is detached from the image. [18:49:41] what you want to be doing is working with a detached model [18:50:08] ok, so basically creating a copy of the scalable and attaching *that* to both size widget and image model ? [18:50:19] and only in the case where we apply changes to we make changes to the document [18:50:27] Right. [18:50:28] hm [18:50:31] yeah? [18:50:42] let me get this right [18:50:53] you have a ve.dm.ImageModel with a scalable [18:51:11] or a ve.dm.ImageNode with a scalable [18:51:29] my point is, a ve.dm.ImageModel is a standalone model [18:51:35] the ve.dm.ImageNode is not [18:51:36] ImageNode, ImageModel and SizeWidget *ALL* interact with the scalable object. [18:52:05] Changing type, for instance, changes the scalable considerations (max/min, default, etc) [18:52:12] that's done in the node right now. [18:52:12] yes, but we should clone the ImageModel that ImageNode provides, work with it, then if we are going to make changes, sync those changes by processing transactions [18:52:20] changing size from default to custom is done in the size widget [18:53:06] Yes, I do that for all image attributes, but scalable isn't exactly like other attributes, it's more a calculation engine. [18:53:28] but we need to NEVER modify a DM node [18:53:39] Then the scalable calculations must come out of the node. [18:53:42] because they are generative and owned exclusively by the document [18:54:01] the problem with this is that then we can have code duplication [18:54:10] we just need a clone [18:54:16] hm. [18:54:26] we don't need 2 classes, we need 2 instances [18:54:54] I guess... I'm ... a little worried though, I think that since the scalable is communicating and depends on 3 different objects, it may produce more problems, but I'll know that only after I start trying. [18:55:17] maybe we should video chat [18:55:21] got a sec? [18:55:23] sure [19:00:34] 3VisualEditor / 3Editing Tools: VisualEditor: Undoing the edit from toolbar does not disable the "Apply Changes" button inside Media Settings dialog - 10https://bugzilla.wikimedia.org/68058 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open the media settings dialog for an imag... [19:03:33] James_F: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/REL1_23/lib [19:04:10] legoktm: That's… very odd. Checkout REL1_23. There's no jquery.uls directory inside lib. [19:04:10] (re: https://gerrit.wikimedia.org/r/#/c/146430/) [19:04:16] hmm [19:04:23] * legoktm checks git.wm.o [19:05:23] James_F: it's there https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FVisualEditor.git/REL1_23/lib [19:07:44] legoktm: Hmmph. [19:08:48] legoktm: Aha. It looks like I have a local REL1_23 that doesn't have that. [19:08:50] * James_F sighs. [19:09:49] 3VisualEditor / 3Editing Tools: Media search either accessed from references or from Insert media gives Uncaught TypeError. - 10https://bugzilla.wikimedia.org/68059 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Test Environment- test2 Steps to Reproduce- Scenario #1- 1> click on “Insert” dropdown... [19:10:01] 3VisualEditor / 3Editing Tools: Media search either accessed from references or from Insert media gives Uncaught TypeError. - 10https://bugzilla.wikimedia.org/68059 (10Ritu Swain) [19:11:03] James_F: "Hmm. Do we alert users that they're subject to different terms of use from GitHub?" you mean that we won't track them on labs and github will? ;) [19:11:41] legoktm: I mean that the code sounds like it's breaking the law, or at least very bad practice, by making users subject to ToUs they've not been made aware of. :-) [19:11:55] And yes. :-) [19:13:03] 3VisualEditor / 3Editing Tools: VisualEditor: Undoing the edit from toolbar does not disable the "Apply Changes" button inside Media Settings dialog - 10https://bugzilla.wikimedia.org/68058 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:3Moriel Schottlender [19:14:01] 3VisualEditor / 3Editing Tools: Media search either accessed from references or from Insert media gives Uncaught TypeError. - 10https://bugzilla.wikimedia.org/68059#c1 (10Ritu Swain) See also Bug 49795 and Bug 49596 [19:14:23] James_F: file a bug and cc the legal people? [19:15:12] legoktm: Eh. The more interesting question is why are we using GitHub at all rather than git.wm.org? [19:15:57] we were using gitweb at the time ^d switched it to github, which would have been terrible for downloads [19:16:13] Right. [19:16:17] Can we switch it back now, then? [19:21:31] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c6 (10James Forrester) 5PATC>3ASSI So I suppose now the job is to start writing copy… [19:26:07] hm. When I want to attach a value (not reference) of an object, I do ve.copy( obj ) -- but when I want to do the same to a value that's boolean, is it enough to cast it, like !!val to get value instead of reference? [19:26:37] mooeypoo: yes [19:27:23] mooeypoo: if you think in terms of objects that are mutable or immutable and that variables point to, instead of variables that are passed by value or by reference, it will be a lot simpler to understand :) [19:29:48] MatmaRex, yeah, that's what I thought, but I wanted to make sure [19:29:54] thanks :) [19:35:40] (03PS1) 10Krinkle: [WIP] Document stuff [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 [19:36:07] TrevorP|Away: Can you look at https://gerrit.wikimedia.org/r/146523 and answer questions in Gerrit comments or by amending the commit? [19:36:34] I'm purposely being blind to anything in VisualEditor. I'm restricting myself to oojs-ui, its code and the demos. [19:38:04] 3VisualEditor / 3Mobile: VisualEditor Mobile:Link inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15946 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15946&action=edit Screenshot The Link... [19:47:35] (03PS2) 10Krinkle: [WIP] Document stuff [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 [19:50:53] TrevorParscal, Thal found a bug in Vector: https://www.youtube.com/watch?v=wYZRItTDgIY [19:50:56] James_F|Away: yeah we could. Just needs more changes to the extension [19:56:51] (03CR) 10Alex Monk: ""3. Hide the options when the control is clicked again" - hmm... The others don't seem to do this at the moment" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:59:34] (03PS3) 10Alex Monk: Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [19:59:37] (03CR) 10jenkins-bot: [V: 04-1] Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [20:00:40] (03CR) 10Alex Monk: "Is this a bit better? Not sure about the extra class, is there a correct/better way to get it to be an IndicatedElement without that?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [20:00:51] meh, need to rebase anyway [20:07:23] Krinkle: writing comments you requested [20:07:38] and of course it doesn't work properly when you do [20:07:39] edsanders: that is a feature! [20:08:05] TrevorParscal: Thx. Note that I know the answers to some (although surprisingly few) of the questions, but asking more on behalf of a new user. [20:08:20] For better docs :) [20:10:09] TrevorParscal, she said she's going to watch it to the end... [20:10:37] How dare she report a bug without verifying what happens at the end! [20:13:39] ugh, come on, did i break that vector collapsible tab thingy again? :/ [20:15:17] MatmaRex: It's broken? [20:15:32] James_F: see ed's video [20:16:06] i am positive that was not happening last time i touched it, but on the other hand i am the only person who touched that recently :P [20:17:14] (03PS4) 10Alex Monk: Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [20:17:23] MatmaRex: Oh, fun. [20:17:26] (03CR) 10Alex Monk: "Why did this break in the rebase? :/" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [20:17:56] Krinkle: "Stuff"? Fails the Timo rule of commit naming. :-) [20:17:57] i remember that was happening some time ago, then someone fixed it carefully (probably Krinkl.e) [20:18:08] legoktm: Is there an equivalent link we can drop in? [20:18:23] [WIP] is a blanket right to evade any and all good habits [20:18:55] Krinkle: Yeah yeah. [20:18:56] James_F: drop-in? no [20:19:56] James_F: the code is pretty github-specific, and just emulated what it looks for from github on labs. getting it to work with gitblit will take more work [20:20:40] legoktm: Using GH is really quite bad. [20:20:49] legoktm: Disable-extension-from-cluster-bad. [20:23:05] * legoktm blames ^d [20:23:37] Sure, but I care more about fixes than blame. :-) [20:23:50] I can probably fix it tonight though [20:24:24] legoktm: That'd be awesome. [20:24:49] 3VisualEditor / 3Editing Tools: VisualEditor:Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome for Betalabs - 10https://bugzilla.wikimedia.org/68066 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15947 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15... [20:24:54] does gitblit's tarball come with submodules? [20:25:24] I'd assume not [20:25:42] If it did that would be an easy fix to that bug, but probably not. [20:25:52] Submodules seem to be "here be dragons" tech for most. [20:26:37] my bash script to generate tarballs with submodules is pretty simple :P [20:26:50] but I just copied the one we use in pywikibot [20:33:35] * James_F nods. [20:34:27] James_F, did you see my comment on https://gerrit.wikimedia.org/r/143097 about it breaking after the rebase? Am I missing something obvious? [20:34:50] Krenair: I saw, but haven't had time to investigate yet, sorry. [20:36:33] Krenair: 436ac664c0b437d07c5a97987dff09d24fc23278 [20:37:32] ah, useful. thanks James_F + edsanders [20:37:56] still not sure why the demo is broken though [20:39:26] TrevorParscal: Ping when you're around. [20:39:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Trevor Parscal [20:41:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] Link inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Trevor Parscal [20:42:03] (03PS2) 10Jforrester: [WIP] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [20:42:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [20:42:36] (03PS1) 10Mooeypoo: Add a 'clone' method to ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 [20:44:53] Krinkle, the sourcemaps aren't working in OOJSUI for me [20:45:13] also if you're working on the demos, it would be good to have a menu for switching page/skin [20:45:38] edsanders: What kind of malfunction? Off by 1 line? [20:45:42] I'm not working on the demos atm [20:47:01] oh no you di'ent, Scalable. mrr. [20:49:42] mooeypoo: My magic scan has revealed you've been bad :P [20:49:44] mooeypoo: {Boolean} -> {boolean}; f0e9ad9513e61bc 42c35ddbabdb [20:49:48] Per your request, a reminder :) [20:52:00] James_F: what's up? [20:52:33] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Make an edit to the page 3.Cli... [20:53:14] TrevorParscal: You still looking for priorities? Top is probably https://bugzilla.wikimedia.org/show_bug.cgi?id=68066 and then https://bugzilla.wikimedia.org/show_bug.cgi?id=64575 [20:53:57] TrevorParscal: And https://bugzilla.wikimedia.org/show_bug.cgi?id=68068 ouch. [20:54:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [20:56:43] Krinkle, oh noes! where? [20:56:47] TrevorParscal: Also, progress on https://bugzilla.wikimedia.org/show_bug.cgi?id=57943 yay. [21:01:54] mooeypoo: https://github.com/wikimedia/VisualEditor/commit/f0e9ad951#diff-1822dfd467a7db9f09af9a0d85ec1d35R386 https://github.com/wikimedia/VisualEditor/commit/42c35dd#diff-1822dfd467a7db9f09af9a0d85ec1d35R163 [21:02:39] Krinkle, boo. I'll fix it [21:10:05] mooeypoo: thx [21:10:16] (03PS3) 10Trevor Parscal: [WIP] Document stuff [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (owner: 10Krinkle) [21:10:25] Krinkle: so, about OutlineWidget [21:10:46] mooeypoo: Sublime DocBlockr, use preference "jsdocs_lower_case_primitives" if you havent' already. [21:10:49] indeed, right now it is really just adding a class that BookletLayout uses, and could be easily replaced with a plain old SelectWidget [21:10:53] That'll autocomplete it to lowercase [21:10:57] Krinkle, I thought I did, but I'll verify [21:11:34] but, before we do that, I think we should look at the way the BookletLayout interacts with it, and consider what functionality may need to be moved to the outline widget to make it useful in other places [21:11:51] TrevorParscal: Right, becayse BookletLayout could apply those styles to oo-ui-selectWidget instead of outlineWidget. [21:11:58] of course [21:12:06] yup, taht makes sense. [21:12:18] ok, so that needs to be a tech debt bug, I will file it [21:13:07] how should I file it as tech debt in OOUI there's no category for that [21:15:19] 3OOjs UI: Enhance or remove OutlineWidget - 10https://bugzilla.wikimedia.org/68070 (10Trevor Parscal) 3NEW p:3Unprio s:3normal a:3None Right now it is a useless wrapper around SelectWidget, but since BookletLayout is the only place it is used, it's not clear if some of the code in BookletLayout actuall... [21:16:01] TrevorParscal: I can make one. [21:16:10] i just made one, feel free to ammend it [21:16:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=68070 [21:16:16] Ha. [21:16:17] 3OOjs UI: [Tech debt] Enhance or remove OutlineWidget - 10https://bugzilla.wikimedia.org/68070 (10Trevor Parscal) [21:16:56] TrevorParscal: You did? https://bugzilla.wikimedia.org/editcomponents.cgi?product=OOjs%20UI looks empty. [21:17:20] haaaaaaaaaa this was the funniest bug in the history of ever. [21:17:48] TrevorParscal made the bug, not a Tech debt category. [21:18:14] So I see. [21:18:16] James_F: yeah.. [21:18:26] feel free to make the category and all that [21:18:32] I just wasted an hour trying to debug WHYYYY it is that my Scalable objects receive "original dimensions" (whose 'get' method sets the ratio) but they don't have ratio... debug.. debug... not making sense... well... what came after this.setOriginalDimensions() in the constructor? Yep, 'this.ratio = null'. Brilliant. [21:18:47] 3OOjs UI: OOjs UI: Enhance or remove OutlineWidget - 10https://bugzilla.wikimedia.org/68070 (10Krinkle) [21:18:47] 3OOjs UI / 3Technical Debt: OOjs UI: Enhance or remove OutlineWidget - 10https://bugzilla.wikimedia.org/68070 (10Krinkle) [21:18:52] TrevorParscal: Fixed. [21:18:53] Bah. [21:19:01] 3OOjs UI / 3Technical Debt: OOjs UI: Enhance or remove OutlineWidget - 10https://bugzilla.wikimedia.org/68070 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [21:19:04] Edit conflict with Timo. [21:20:20] James_F: Assigned to "*VE* team bugs – take if you're interested!" :) [21:20:29] May want to change the name of that acct [21:20:58] Krinkle: Yeah, I know. [21:21:06] * James_F needs to find the password to the BZ account. :-) [21:21:14] Or do you? [21:21:52] I thought you had bz powa [21:22:26] Krinkle: Oh, point. [21:22:40] Krinkle: But I found the password. [21:22:54] Krinkle: Fixed enough for you? [21:23:04] sure [21:23:11] Krinkle: It's still "+veteambztickets" sadly. [21:23:26] Krinkle: But I really don't want to go change 1500+ tickets just to fix that. [21:23:41] James_F: If bugzilla uses proper user_ids internally, you may not have to [21:23:46] (03PS2) 10Mooeypoo: Add a 'clone' method to ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 [21:23:47] can one change the e-mailaddress of an account? [21:24:11] components can be renamed as well [21:24:15] Krinkle: You can, but I think it still locks the DB… [21:24:27] Krinkle: Want me to try? ;-) [21:24:31] :) [21:24:43] I'm not bothered by it [21:24:50] WFM. [21:25:09] (03CR) 10Krinkle: [WIP] Document stuff (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (owner: 10Krinkle) [21:25:27] (03PS2) 10Mooeypoo: Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) [21:25:31] woot [21:26:05] (03CR) 10jenkins-bot: [V: 04-1] Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [21:26:10] (03PS4) 10Krinkle: Remove useless documentation, add more useful documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (https://bugzilla.wikimedia.org/51650) [21:26:13] meh [21:26:45] (03PS5) 10Krinkle: Remove useless documentation, add more useful documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (https://bugzilla.wikimedia.org/51650) [21:26:49] 3VisualEditor / 3Editing Tools: VisualEditor: In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073 (10ryasmeen) 3NEW p:3Unprio s:3normal... [21:26:57] (03CR) 10Krinkle: [C: 031] "Attributed to Trevor." [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (https://bugzilla.wikimedia.org/51650) (owner: 10Krinkle) [21:27:07] O.O [21:27:08] TrevorParscal: +2/+1 as you see fit. [21:27:13] I don't understand the error in jenkins [21:27:24] (03CR) 10Trevor Parscal: [C: 032] Remove useless documentation, add more useful documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (https://bugzilla.wikimedia.org/51650) (owner: 10Krinkle) [21:27:31] Krinkle, any idea what "fatal: reference is not a tree: 33def4cb5143a903dae7cff8217ebb2744517030" means? "Unable to checkout '33def4cb5143a903dae7cff8217ebb2744517030' in submodule path 'lib/ve'" [21:27:31] Woo. [21:27:44] oh [21:27:45] crap [21:27:45] mooeypoo: You're pulling through a version of VE-core that isn't merged. [21:27:56] It probably means you git-added a change to lib/ve that is not merged [21:27:57] I just saw i have lib/ve in there [21:27:59] shoot [21:28:00] Yeah. [21:28:02] shooooot. [21:28:29] well, it depends on a core commit too, but still.. eh.. I guess I'll have to take it out. [21:28:48] (03Merged) 10jenkins-bot: Remove useless documentation, add more useful documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/146523 (https://bugzilla.wikimedia.org/51650) (owner: 10Krinkle) [21:29:07] dude, parsoid is hanging and bringing by webserver down [21:29:11] mooeypoo: Or just leave it. [21:29:19] 3VisualEditor / 3Technical Debt: VisualEditor: Remove (and stop adding) useless documentation - 10https://bugzilla.wikimedia.org/51650 (10James Forrester) 5PATC>3ASSI [21:29:23] James_F, won't that disturb merging? [21:29:29] when parsoid hangs so bad it brings apache down, I don't know what is going on... [21:30:14] mooeypoo: It just means it'll need to be rebased before merge, not biggie. [21:31:08] TrevorParscal, I added you as reviewer to the two commits -- one that adds "clone" method to ve.dm.Scalable, and another in ve-mw to use the clone (+ the static method in ve.dm.MWImageNode) as we discussed. [21:31:22] sweet [21:31:24] lookin [21:35:15] (03CR) 10Trevor Parscal: [C: 04-1] Add a 'clone' method to ve.dm.Scalable (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 (owner: 10Mooeypoo) [21:40:14] Hm.. copying a heading/table on https://www.mediawiki.org/w/index.php?title=Learning_JavaScript&veaction=edit and pasting it higher up the page breaks the editor irrecoverably [21:40:15] Yikes [21:40:18] Uncaught TypeError: Cannot read property 'clone' of null [21:40:44] Select beginner + the table it follows and then put cursor at |Advanced, return up, paste. [21:40:51] regression? [21:42:39] mooeypoo: in https://gerrit.wikimedia.org/r/#/c/146513/2 things look good but I feel like creating a scalable just to figure out the dimensions for the new node, something is wrong there, probably that getDimensionsFromValue being an instance method is causing you to make dummy objects [21:42:47] you should see if you can make a static version of that, and have the instance method use the static method internally [21:43:09] see OO.ui.Element - we have lots of static methods, and instance wrappers [21:43:13] we use both a lot [21:43:59] Krinkle: Sounds possibly like a regression, yes, but could be existing brokeness with pasting. [21:44:52] (03CR) 10Trevor Parscal: "I realize this commit doesn't introduce this problem, but maybe it can clean it up? Or at least you can file a tech debt bug to do so." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [21:44:59] mooeypoo: I posted that comment on the patchset [21:45:04] so it doesn't get lost in IRCland [21:45:52] TrevorParscal: IR-Cland? What's a Cland? [21:46:02] :-) [21:47:43] TrevorParscal: "in case somebody complains about parsoid entering an infinite loop: tell them to reinstall node_modules" [21:47:46] TrevorParscal: From gwicke. [21:53:40] TrevorParscal, yeah I actually thought abotu this as I went over the code myself -- I should probably make this another instance method and use the calculation itself. [21:53:50] brb, food [21:55:26] (03PS5) 10Alex Monk: Combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [21:57:22] (03CR) 10Alex Monk: "Okay, it at least works now, so back to:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [21:59:01] I have to find a different IRC client I think... [21:59:03] not sure if this got sent [21:59:05] TrevorParscal, what callback exactly is responsible for opening the tool or dropdown when ToolGroup is clicked? it seems like onMouseDown and onMouseUp are not invoked when I click on it [22:00:14] Krinkle, edsanders maybe you guys know? ^ [22:00:43] I would imagine on('click') [22:01:02] jgonera: you are using desktop? [22:01:13] TrevorParscal, yes, not matter what I use [22:01:16] or, at least, have you compared with desktop? [22:01:24] ok, so let me open the code [22:01:45] desktop Chrome, iOS Safari, those two callbacks don't seem to be called when clicking/tapping on cite icon in mobile VE [22:01:50] yet the dropdown opens [22:01:52] so, OO.ui.PopupToolgroup [22:02:12] it has it's own event handler to deal with opening/closing the popup [22:02:13] oh, alright [22:02:18] thanks [22:02:22] yup [22:02:24] should have looked at CSS classes closer [22:02:41] no worries, it's a lot of layering and the CSS classes aren't always easy to read in the DOM inspector [22:02:46] I miss them all the time [22:04:35] (03CR) 10Trevor Parscal: [C: 04-1] "This is awesome, but needs to be rebased since the great dialog refactor commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) (owner: 10Bartosz Dziewoński) [22:07:12] (03CR) 10Trevor Parscal: [C: 032] ve.ui.MWExtensionInspector: Prevent from setting impossible content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144157 (https://bugzilla.wikimedia.org/57429) (owner: 10Bartosz Dziewoński) [22:07:17] (03CR) 10Trevor Parscal: [C: 032] ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144158 (https://bugzilla.wikimedia.org/57429) (owner: 10Bartosz Dziewoński) [22:08:14] (03CR) 10Trevor Parscal: [C: 032] MWTitleInputWidget: Remove prefixColon option and use relative title instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144497 (https://bugzilla.wikimedia.org/67386) (owner: 10Alex Monk) [22:09:07] (03Merged) 10jenkins-bot: ve.ui.MWExtensionInspector: Prevent from setting impossible content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144157 (https://bugzilla.wikimedia.org/57429) (owner: 10Bartosz Dziewoński) [22:09:12] (03Merged) 10jenkins-bot: ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144158 (https://bugzilla.wikimedia.org/57429) (owner: 10Bartosz Dziewoński) [22:10:16] (03CR) 10Trevor Parscal: [C: 032] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [22:10:44] (03Merged) 10jenkins-bot: MWTitleInputWidget: Remove prefixColon option and use relative title instead [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144497 (https://bugzilla.wikimedia.org/67386) (owner: 10Alex Monk) [22:11:09] (03CR) 10Trevor Parscal: [C: 04-1] "This needs to be rebased to include new tests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [22:11:45] (03CR) 10Trevor Parscal: [C: 031] "Looks good, but I want another set of eyes on it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144586 (https://bugzilla.wikimedia.org/55505) (owner: 10Mooeypoo) [22:12:14] (03Merged) 10jenkins-bot: MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 (owner: 10Mooeypoo) [22:21:28] Hm, no more confirm dialog? [22:28:08] TrevorParscal, you around? I have an unrelated question that I noticed when I went over MWTemplate stuff (model /dialog/etc) -- in ve.dm.MWTemplateModel there's a couple of methods that are faux-static, like ve.dm.MWTemplateModel.newFromData -- is there a difference between doing it this way and adding ve.dm.MWTemplateModel.static.newFromData to make it a static method? [22:28:19] im here [22:28:25] reading... [22:28:34] those should be static [22:28:38] Is this an oversight or on purpose to make the method easier to call without having .constructor.static.newFromData() [22:28:45] oh, so it's an oversight? [22:28:48] oversight [22:28:53] ok, I was wondering if it had some special function [22:28:55] the problem is that it won't be inherited [22:28:57] which sucks [22:29:04] * mooeypoo nods [22:29:08] to make it inheritable you have to make it live inside the .static. [22:29:08] it DOES make it easier to call [22:29:16] sure, it's a little shorter [22:29:22] nicer to look at [22:29:32] but yeah, it's also a bit confusing. [22:30:13] especially now that I'm abusing the .static. properties in Scalable and the ImageModel :D [22:30:59] TrevorParscal: hey, can you summarize the dialog refactor in two sentences or fewer? :D i'm just wondering what exactly was so broken that it needed to be rewritten [22:31:22] sucked really bad on mobile [22:31:47] rofl [22:31:51] alright. is it live on some wikis already? [22:32:12] some beta site [22:32:15] also, needed to move differences between dialogs and inspectors out of the dialog and inspector classes [22:32:32] oh inspectors! that reminds me to check the comment thing [22:32:39] it's really hard to remember when it's not in my main commit list [22:34:01] MatmaRex: http://en.wikipedia.beta.wmflabs.org/wiki/0.24595949980612886?veaction=edit [22:34:06] (also, thanks for the merges) [22:34:15] oh, thanks [22:34:36] edit the reference, then make your browser very narrow [22:34:41] watch the magic [22:34:56] MatmaRex: i reviewed you connect4 game today [22:34:58] loved it [22:36:14] :D [22:36:16] 3VisualEditor / 3Editing Tools: VisualEditor: MWExtensionNode preview (, , …) double-escapes HTML (angle brackets, ampersands) - 10https://bugzilla.wikimedia.org/57429#c10 (10Bartosz Dziewoński) 5PATC>3RESO/FIX Should be fixed. Like in wikitext, it will now be impossible to input... [22:36:41] oh, that's sexy [22:36:50] hmm [22:37:11] i think i found a bug :P when you shrink the browser window, it expands both width and height [22:37:26] but when you enlarge it back, width is adjusted, but height stays the same [22:37:46] that's on Opera 20-something, http://i.imgur.com/37Vj2CP.png [22:39:13] Yeah, there are some lingering issues in some browsers when it comes to auto-height [22:40:10] we need a magical auto height evaluator, that finds the first scrollable container in the oo-ui-window-body (which may be the oo-ui-window-body) and measures it's contents height (scrollHeight, but reliable) [22:40:21] that would solve most cases where we are overriding getBodyHeight [22:40:45] unfortunately there isn't a lot of standardization within the dialogs, content-wise... [22:40:51] yet... [22:43:57] bah, i just wrote a new fancy toy yesterday and now it doesn't work on beta :( https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js [22:48:14] (03PS2) 10Bartosz Dziewoński: MWLinkNodeInspector: Actually preserve annotations when converting to link annotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) [22:49:09] (03CR) 10Bartosz Dziewoński: [C: 04-1] "There was just one small conflict (.linkNode → .selectedNode), seems to work. But I noticed we should check the 'remove' case before the '" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) (owner: 10Bartosz Dziewoński) [22:49:48] (03PS3) 10Mooeypoo: Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 [22:50:32] (03PS3) 10Bartosz Dziewoński: MWLinkNodeInspector: Actually preserve annotations when converting to link annotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) [22:51:08] (03PS1) 10Trevor Parscal: Initialize data first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146634 [22:51:12] hmm, should the z-index be like this? http://i.imgur.com/sLzxKQN.png [22:51:25] (03PS1) 10Trevor Parscal: Always initialize data before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146635 [22:51:27] (micro-inspector thingy on top of toolbar dropdown?) [22:52:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068 (10Alex Monk) a:3Alex Monk [22:52:21] MatmaRex: that's a regression, something to do with moving to using ve.ui.Overlay i think [22:52:43] (how are the inspector thingies called, anyway?) [22:53:00] omg, i'm stupid. TrevorParscal don't review my code yet! I made a stupid booboo. fixing now. [22:53:07] Actions in a MessageDialog are... empty strings in getActionProcess and on closing? [22:53:23] Krenair: ?? [22:53:39] MatmaRex: that is called the context menu [22:53:41] I'm trying to get my head around MessageDialog [22:53:47] it's ve.ui.Context [22:53:55] specifically it's ve.ui.DesktopContext [22:54:14] Krenair: it's pretty much like, you add buttons with action properties [22:54:27] then when they are clicked, getActionProcess is called and then executed [22:54:45] the first (and only) argument to getActionProcess is a string, which is the action property of the button [22:54:56] (03PS1) 10Cmcmahon: [BrowserTest] Update bullets test for new UI design [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146637 [22:55:08] if the button has no action property, it's a "safe" cancel, do nothing, close the dialog [22:55:50] if the button has an action, you should handle it, handle the actions you added to the dialog in that class, fall through to the parent method for others [22:56:01] getActionProcess returns an OO.ui.Process that can do whatever you want [22:56:22] I just found the 'action' key which looks like it will set the internal ID of an action [22:56:27] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146637 (owner: 10Cmcmahon) [22:56:33] you have to close the dialog (or not) at the end of your process, it won't happen automatically unless the action is empty and you let the parent method handle it [22:57:52] Krenair: I know the documentation is lacking [22:57:55] apologies [22:58:10] (03Merged) 10jenkins-bot: [BrowserTest] Update bullets test for new UI design [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146637 (owner: 10Cmcmahon) [22:58:39] https://gist.github.com/Krenair/b19d9e155e794c6059c1 - hm :/ [22:59:14] too verbose? [22:59:15] lol [23:00:00] (if somebody who knows the recent refactors is bored (t.r.e.v.o.r), i'd love if they looked at https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js – i just wrote it and now it doesn't work anymore :P i'm inheriting from some VE classes that probably weren't meant to be inherited from and probably something brittle broke) [23:00:05] in that case, it seems kinda crazy, there is another case like that - but in other cases it's really nice to have access to each phase of execution without binding multiple events [23:00:37] MatmaRex: ok, i'm looking at this and then I gotta run to the store for some things to make dinner with... but I'll be back online again before i'm "done for the day" [23:02:28] MatmaRex: honestly, i don't know how the dialog refactor would break this [23:02:32] how does it fail? [23:02:54] TrevorParscal: i don't see the new tool in the toolbar [23:03:00] no errors? [23:03:30] (03PS1) 10Alex Monk: Make a message dialog for cancelling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146639 (https://bugzilla.wikimedia.org/68068) [23:03:31] none [23:03:34] TrevorParscal: and trying to manually insert [ { type: 'mwSignature' }, { type: '/mwSignature' } ] yields "Unknown node type: mwSignature" [23:03:42] so i guess nothing gets registered? [23:03:47] oh wait, maybe i'm stupid [23:04:12] I doubt it... [23:04:26] haha [23:04:26] ok, i will be back in a bit, gotta get ingredients so the cooking can commence [23:04:30] i was just stupid, sorry [23:04:41] happy to take a glance, glad you found your answer [23:04:43] it wasn't working because i was testing in ns 0, and it disables itself in ns 0 [23:04:44] cya in a bit [23:04:49] (03PS1) 10JGonera: WIP: Handle touch events in toolbars and toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/146640 [23:04:51] duh [23:05:00] happy cooking :) [23:05:31] TrevorParscal, that works: https://gerrit.wikimedia.org/r/146640 but you'll probably want it to be a bit different so I marked it as WIP [23:05:37] we can talk about it tomorrow [23:05:54] (03PS4) 10Mooeypoo: Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 [23:06:16] (03PS3) 10Mooeypoo: Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) [23:06:19] (ignore my commit btw, it doesn't work) [23:07:29] (03PS2) 10Alex Monk: Make a message dialog for cancelling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146639 (https://bugzilla.wikimedia.org/68068) [23:07:31] (03CR) 10jenkins-bot: [V: 04-1] Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [23:07:49] There. [23:08:03] Now it's ready for you, TrevorParscal. :) [23:11:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Template dialog wrongly prefixes suggestions from User namespace with colon - 10https://bugzilla.wikimedia.org/67386#c3 (10Alex Monk) 5PATC>3RESO/FIX So this *should* be fixed this time... [23:12:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: Template dialog wrongly prefixes suggestions from User namespace with colon - 10https://bugzilla.wikimedia.org/67386 (10Alex Monk) [23:21:18] 3VisualEditor / 3Editing Tools: Script Error is shown as existing reference for “Basic” citation. - 10https://bugzilla.wikimedia.org/68079 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15949 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15949&action=edit Script error fo... [23:21:46] 3VisualEditor / 3Editing Tools: Script Error is shown as existing reference for “Basic” citation. - 10https://bugzilla.wikimedia.org/68079 (10Ritu Swain) [23:26:35] 3VisualEditor: performance degradation with new UI - 10https://bugzilla.wikimedia.org/68081 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Seen on beta labs as 15 July: Upon loading a simple page such as http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit Th... [23:33:32] 3VisualEditor: performance degradation with new UI - 10https://bugzilla.wikimedia.org/68081#c1 (10Chris McMahon) 5NEW>3RESO/INV I reported this poorly, needs more research.