[00:10:15] * TrevorParscal presses his own burgers [00:11:42] TrevorParscal: Does that mean you're not doing code review? ;-) [00:20:32] (03PS1) 10Cmcmahon: [BrowserTest] Update edit test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146655 [00:21:02] 3VisualEditor / 3Editing Tools: VisualEditor: MWExtensionNode preview (, , …) double-escapes HTML (angle brackets, ampersands) - 10https://bugzilla.wikimedia.org/57429#c11 (10James Forrester) Thanks Bartosz! [00:22:01] (03PS2) 10Cmcmahon: [BrowserTest] Update edit test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146655 [00:22:18] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073 (10James For... [00:22:36] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146655 (owner: 10Cmcmahon) [00:24:21] chrismcmahon: Yay for breakage. :-( [00:24:23] (03Merged) 10jenkins-bot: [BrowserTest] Update edit test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146655 (owner: 10Cmcmahon) [00:26:23] James_F: I am not real proud of that last merge, it has a sleep(5) because (near as I can tell) the whole VE UI is loading twice. that's just to get me through the night so I can address whatever else is new, then investigate. [00:26:37] chrismcmahon: Yeah… [00:26:40] chrismcmahon: :-( [00:27:33] James_F: the second time it loads REAL FAST so it's just a blink, but it's rough on the edit tests [00:33:49] James_F: it means I am hardcore [00:33:56] and... I was checking emails [00:33:59] finishing up my day [00:34:10] I will continue review tomorrow. [00:44:39] TrevorParscal: :-) [00:44:48] ChanServ: Yeah… [00:44:52] TrevorParscal: Kk. [00:49:36] (03CR) 10Jforrester: [C: 032] Initialize data first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146634 (owner: 10Trevor Parscal) [00:49:43] (03CR) 10Jforrester: [C: 032] Always initialize data before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146635 (owner: 10Trevor Parscal) [00:51:52] (03Merged) 10jenkins-bot: Initialize data first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146634 (owner: 10Trevor Parscal) [00:52:10] (03Merged) 10jenkins-bot: Always initialize data before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146635 (owner: 10Trevor Parscal) [00:52:50] (03PS7) 10Jforrester: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:54:18] (03PS8) 10Jforrester: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:56:05] (03CR) 10jenkins-bot: [V: 04-1] Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [00:58:06] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (a9d6a42680) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146664 [00:58:15] (03PS1) 10Jforrester: Update VE core submodule to master (542cdfc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146665 [01:00:37] (03PS9) 10Jforrester: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [01:03:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: Template dialog wrongly prefixes suggestions from User namespace with colon - 10https://bugzilla.wikimedia.org/67386#c4 (10James Forrester) (In reply to Alex Monk from comment #3) > So this *should* be fixed this time... Famous last words. :-) [01:04:21] (03CR) 10Jforrester: [C: 032] "Six rebases later, let's do this. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [01:06:04] (03Merged) 10jenkins-bot: Rename "test" folder to "tests" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144451 (owner: 10Zfilipin) [01:33:31] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c15 (10James Forrester) (In reply to Lokal_Profil from comment #14) > Being a basic building block of a wiki which is currently missing from VE I > would not mark this as Resolved... [01:35:01] 3OOjs UI: OOjs UI: onDomEvent('focus') does not work after jQuery upgrade - 10https://bugzilla.wikimedia.org/65608#c2 (10James Forrester) Gergő, can we close this as INVALID? [01:41:32] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969#c16 (10James Forrester) *** Bug 67952 has been marked as a duplicate of this bug. *** [01:41:32] 3OOjs UI: Allow to drag and move pop up windows - 10https://bugzilla.wikimedia.org/67952#c2 (10James Forrester) 5NEW>3RESO/DUP This is a duplicate of bug 49969; please continue discussion there. *** This bug has been marked as a duplicate of bug 49969 *** [01:49:04] 3VisualEditor / 3Editing Tools: Undo(Ctrl+z) doesn't work on adding content by advanced options - 10https://bugzilla.wikimedia.org/68043#c1 (10James Forrester) 5UNCO>3RESO/WOR Do you mean the "advanced options" of the media dialog? If so, could you give steps to reproduce? I've just tested setting the l... [02:15:31] (03PS1) 10Mooeypoo: Switch to 'custom' when MediaSizeWidget updates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146676 (https://bugzilla.wikimedia.org/67684) [02:20:21] (03PS1) 10Mooeypoo: Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) [02:26:39] (03CR) 10jenkins-bot: [V: 04-1] Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [03:44:18] Hi there, is this channel used for help? [05:32:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: there is no way to change a template without re-filling all the params - 10https://bugzilla.wikimedia.org/68088 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None There are templates that have a different name, but the same parameters. For examp... [05:32:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: there is no way to change the template name without re-filling all the params - 10https://bugzilla.wikimedia.org/68088 (10Amir E. Aharoni) [06:19:01] 3OOjs UI: OOjs UI: onDomEvent('focus') does not work after jQuery upgrade - 10https://bugzilla.wikimedia.org/65608#c3 (10Tisza Gergő) Textual criticism of the jQuery release announcement aside, the OOjs UI textinput does not trigger its focus handler when focused. I don't think that's expected behavior. Here... [08:06:40] (03PS1) 10Jagori79: WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146712 (https://bugzilla.wikimedia.org/66369) [09:59:42] Krinkle|detached, way off, sometimes it puts me in outro.txt [10:58:49] (03CR) 10Zfilipin: [C: 04-1] "Please move all files from this commit from "test" folder to "tests" folder." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) (owner: 10Jagori79) [10:59:37] (03CR) 10Zfilipin: [C: 04-1] "Please move all files from this commit from "test" folder to "tests" folder." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [11:51:04] (03PS20) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) [13:39:34] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Load VE. Say "Foobar" is the first word on the page. If you click on the link tool, by mistake or not, without selecting anyth... [13:53:35] 3VisualEditor: VisualEditor: Easy way to reproduce a weird behavior with the link tool - 10https://bugzilla.wikimedia.org/68102 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Take a page like https://en.wikipedia.org/wiki/Heliozela_rutilella?veaction=edit (that is, starting with a template, so there's som... [13:53:47] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101 (10Elitre) [13:53:47] 3VisualEditor: VisualEditor: Easy way to reproduce a weird behavior with the link tool - 10https://bugzilla.wikimedia.org/68102 (10Elitre) [14:37:39] (03PS1) 10Cmcmahon: [BrowserTest] update media test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146780 [14:38:14] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146780 (owner: 10Cmcmahon) [14:39:57] (03Merged) 10jenkins-bot: [BrowserTest] update media test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146780 (owner: 10Cmcmahon) [15:15:50] 3VisualEditor / 3Editing Tools: Multiple Media Settings dialog opens when Insert -> Media is selected. - 10https://bugzilla.wikimedia.org/68105 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Test Environment- test2 Steps to Reproduce- 1> Go to Media Settings dialog and click on Insert drop down i... [15:16:02] 3VisualEditor / 3Editing Tools: Multiple Media Settings dialog opens when Insert -> Media is selected. - 10https://bugzilla.wikimedia.org/68105 (10Ritu Swain) [15:23:46] 3VisualEditor / 3Editing Tools: Multiple Media Settings dialog opens when Insert -> Media is selected. - 10https://bugzilla.wikimedia.org/68105#c1 (10Ritu Swain) Tested in betalabs same behavior was found. This chain of multiple child windows could be confusing for the end user. [15:24:25] (03PS1) 10Cmcmahon: [BrowserTest] update links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146788 [15:25:33] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146788 (owner: 10Cmcmahon) [15:27:25] (03Merged) 10jenkins-bot: [BrowserTest] update links test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146788 (owner: 10Cmcmahon) [16:05:48] edsanders: How's it going? [16:05:55] hi [16:05:58] ok [16:06:02] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal (In reply to Ritu Swain from comment #0) > Created attachment... [16:06:29] edsanders: What are you working on? [16:07:03] was just looking at my -1's, you got something more important? [16:09:02] edsanders: I was actually going to bug you about https://gerrit.wikimedia.org/r/#/c/145542/ (one of your -1s) and then any of https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&list_id=329667&namedcmd=VE-%21marked-for-next-release [16:09:36] 'The search named VE-!marked-for-next-release does not exist. [16:09:36] ' [16:09:49] Oh, hmm. [16:10:20] https://bugzilla.wikimedia.org/buglist.cgi?columnlist=bug_severity%2Cpriority%2Ccomponent%2Cassigned_to%2Ctarget_milestone%2Cbug_status%2Cresolution%2Cshort_desc&list_id=329671&order=bug_status%20DESC%2Cpriority%20DESC%2Cassigned_to%2Cbug_severity%2Cbug_id%20DESC&product=VisualEditor&query_format=advanced&target_milestone=VE-deploy-2014-07-17 [16:10:57] ok [16:13:44] (03PS9) 10Jforrester: Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) [16:13:56] (03CR) 10Jforrester: "PS9 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [16:16:21] (03CR) 10Esanders: "The toolbar mousedown only returns false if this.$( e.target ).closest( '.oo-ui-widget' ) is equal to this.$element.closest( '.oo-ui-widge" [oojs/ui] - 10https://gerrit.wikimedia.org/r/145542 (owner: 10Esanders) [16:17:43] (03CR) 10jenkins-bot: [V: 04-1] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [16:21:49] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073#c1 (10Alex... [16:32:07] 3VisualEditor / 3ContentEditable: Can edit in Read mode in Betalabs - 10https://bugzilla.wikimedia.org/68110 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Test Environment-Betalabs Steps to Reproduce- 1> click on Edit beta tab and type in some text in VE. Clicking Cancel does nothing at this poi... [16:32:19] 3VisualEditor / 3ContentEditable: Can edit in Read mode in Betalabs - 10https://bugzilla.wikimedia.org/68110 (10Ritu Swain) [16:33:35] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c1 (10James Forrester) *** Bug 68110 has been marked as a duplicate of this bug. *** [16:33:35] 3VisualEditor / 3ContentEditable: Can edit in Read mode in Betalabs - 10https://bugzilla.wikimedia.org/68110#c1 (10James Forrester) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 68048 *** [16:35:04] Re: typing over focusable nodes [16:35:24] either way we need a fix, but personally I don't think it should be that easy to delete a node [16:36:21] chances are you didn't mean to replace a block node with a sentence (and slightly less likely, but still with an inline node) [16:36:31] ( James_F ) [16:37:01] Open/LibreOffice doesn't let you type over nodes like this [16:37:07] Google Docs does [16:38:09] I think it's better to protect nodes, it's easy to just hit backspace/delete if you really want them gone. Chances are with a floated image the user isn't even sure where the paragraph would be inserted if you typed text. [16:40:41] we already special case focusable nodes if you backspace on to them the get selected instead of immediately deleted [16:41:50] edsanders: I'm not so sure; that's also how Word does it, I believe. [16:42:30] It's easy enough to hit backspace if you really want to delete [16:42:43] just like we require double backspace if you delete past one [16:43:14] Plus it lets us bind single key shortcuts in the future [16:43:38] e.g., select an image and press 'l', 'r' or 'c' to re-align... [16:45:45] Eww. [16:45:52] But maybe. [16:50:09] (03PS1) 10Esanders: Prevent deletion of focusable nodes by typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146808 (https://bugzilla.wikimedia.org/67177) [16:50:20] 3VisualEditor / 3ContentEditable: VisualEditor: Typing when a focusable node is selected should do nothing - 10https://bugzilla.wikimedia.org/67177#c1 (10Ed Sanders) Real world comparison: * Open/Libre office: typing while selecting an image does nothing * Google docs: typing replaces the image I think it's... [16:50:31] (also fewer lines of code :) ) [16:50:45] * James_F grins. [16:51:59] edsanders: https://bugzilla.wikimedia.org/show_bug.cgi?id=67088 would be a good one to look at BTW. [16:52:49] was looking at 66548, looks very similary [16:52:51] -y [16:53:03] Yeah. [16:53:25] But I've learnt from experience that pawn bugs may look similar but have drastically different casues. [16:54:08] (03PS1) 10Alex Monk: Don't allow document save if we're already tearing down the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146810 (https://bugzilla.wikimedia.org/68073) [17:39:35] 3VisualEditor: VisualEditor: Support editing {{int:name}} blocks - 10https://bugzilla.wikimedia.org/65644#c1 (10WhatamIdoing) Update: I can insert parser functions by adding a "template" named (for example) "int:vector-view-edit". It says there's no TemplateData, but it adds it. [17:42:12] James_F, I'd like to complaint about VisualEditor at office.wiki. [17:42:28] I can't insert any templates. It's always "loading". [17:42:41] Do you have any ideas about how I can get past this? [17:43:20] Uncaught TypeError: Cannot read property 'length' of undefined [17:45:01] undefined is passed to ve.dm.MWTransclusionModel.prototype.process, which breaks it [17:57:20] 3VisualEditor / 3Editing Tools: VisualEditor: there is no way to change the template name without re-filling all the params - 10https://bugzilla.wikimedia.org/68088#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc Ideally if the templates are identical but for one piece of infor... [17:59:19] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c1 (10James Forrester) 5NEW>3RESO/WON This is explicitly a feature that was requested (years ago now). People clicking buttons and not paying attention to what they're doing... [17:59:40] (03PS21) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) [18:01:05] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusions editor should have a special mode for Parser Function and Magic Word calls - 10https://bugzilla.wikimedia.org/50855 (10James Forrester) [18:01:06] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way for users to insert variable magic words - 10https://bugzilla.wikimedia.org/49996 (10James Forrester) [18:01:06] 3VisualEditor / 3Editing Tools: VisualEditor: Support editing {{int:name}} blocks - 10https://bugzilla.wikimedia.org/65644 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [18:01:15] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [18:06:07] 3VisualEditor: impossible to edit page a second time - 10https://bugzilla.wikimedia.org/68116 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None As a logged in user on beta labs, open any page, edit the page, save the edited page. Click Edit/beta again for VE. Nothing happens. VE UI does not appear a... [18:09:13] (03PS22) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) [18:11:36] 3VisualEditor: impossible to edit page a second time - 10https://bugzilla.wikimedia.org/68116#c1 (10ryasmeen) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68048 *** [18:11:37] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c2 (10ryasmeen) *** Bug 68116 has been marked as a duplicate of this bug. *** [18:12:49] (03PS1) 10Cmcmahon: [BrowserTests] update Options test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146829 [18:14:11] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146829 (owner: 10Cmcmahon) [18:15:51] (03Merged) 10jenkins-bot: [BrowserTests] update Options test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146829 (owner: 10Cmcmahon) [18:24:40] (03PS1) 10Cmcmahon: [BrowserTests] update References test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146834 [18:25:15] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146834 (owner: 10Cmcmahon) [18:27:04] (03Merged) 10jenkins-bot: [BrowserTests] update References test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146834 (owner: 10Cmcmahon) [18:37:30] (03PS1) 10Cmcmahon: [BrowserTests] update template test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146841 [18:40:10] (03PS2) 10Cmcmahon: [BrowserTests] update template test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146841 [18:40:42] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146841 (owner: 10Cmcmahon) [18:42:00] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTests] update template test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146841 (owner: 10Cmcmahon) [18:52:07] (03PS10) 10Jforrester: Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) [18:52:37] (03CR) 10Jforrester: [C: 04-1] "PS10 adds a comments.html demo page for testing. This throws a fatal on load right now, however. :-(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [18:53:32] (03CR) 10jenkins-bot: [V: 04-1] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [18:53:38] mooeypoo: ^^^ :-( [18:53:50] mooeypoo: Sorry, I fiddled a bit but it dunnae work for me. [19:01:36] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048 (10James Forrester) a:3Alex Monk [19:02:49] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066 (10James Forrester) [19:20:33] TrevorParscal, so have the mobile team done anything with tap events? [19:21:59] (03PS1) 10Cmcmahon: [BrowserTest] update template test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146848 [19:22:02] (03Abandoned) 10Cmcmahon: [BrowserTests] update template test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146841 (owner: 10Cmcmahon) [19:22:21] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146848 (owner: 10Cmcmahon) [19:24:04] (03Merged) 10jenkins-bot: [BrowserTest] update template test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146848 (owner: 10Cmcmahon) [19:26:35] 3VisualEditor / 3Data Model: VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work - 10https://bugzilla.wikimedia.org/68079#c2 (10ryasmeen) This bugs is found in test2 so the reason why it is showing script error for the Cite News,Cite Journal,Ci... [19:30:06] hmm [19:30:32] We probably shouldn't be showing "" with a similarly labelled button when we hit an error on saving e.g. "The "editprotected" right is required to edit this page" [19:54:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=68048 [19:54:33] hmm [19:54:51] So we're not destroying the surface, because the SaveDialog closing promise doesn't get resolved [19:55:02] it's rejected with "Cannot close window: window already closing with different data" [19:55:58] I wonder if this is related to https://bugzilla.wikimedia.org/show_bug.cgi?id=68073 ... [19:56:52] Krenair: that's not good [19:57:19] Krenair: have you identified why it doesn't get resolved? [19:57:30] Krenair: Yeah, I was wondering too. [19:57:47] Not past that error, yet [19:58:19] edsanders: i don't know [20:00:02] onSave does close it first... [20:00:10] (in ViewPageTarget) [20:00:15] but then resets it, so that should be fine? [20:00:19] probably. [20:00:51] no, that's defined by MWSaveDialog directly and only clears some fields [20:03:18] Even if I check !this.saveDialog.getManager().isClosing() before trying to this.saveDialog.close() it does that [20:04:23] It's fine if I check !this.saveDialog.getManager().closing instead though [20:04:49] well, then I get "Uncaught TypeError: Cannot read property 'getComputedStyle' of undefined", but the surface is torn down [20:05:34] TrevorParscal, want to investigate further? [20:10:43] that's to do with removing the window from the dom before it's done with teardown [20:11:18] I added code in my rewrite which used promises in init to wait for the window to close before removing things, I saw that same error [20:11:28] maybe I missed something? [20:15:47] James_F, I just got home -- with a computer! it came! [20:15:53] James_F, plus the Tshirt(s) [20:15:56] they're awesome. [20:15:59] mooeypoo: Yay. [20:16:30] Did my tshirt get sent? [20:16:56] mooeypoo: You going to have time to fix up a couple of bugs or are you going to be busy setting up your new computer? :-) [20:17:01] Krenair: Not yet, sorry, need to bug admin. [20:17:51] James_F, I need to organize my OPT forms (just picked them up) for sending, but then I'm bugfixing. Also, I plan to work late tonight too, so send me bugs [20:17:59] * mooeypoo does the cookie monster impression [20:18:14] mooeypoo: Cool. :-) [20:18:41] James_F, I saw what you wrote about the comment thing. I'll take a look at it. I am also trying to understand what fails in their unit tests [20:19:03] mooeypoo: It's going from "FooBaz" to "Foo Baz". [20:19:07] mooeypoo: Note the extra whitespace. [20:19:27] mooeypoo: The comment thing would be extremely awesome to get out. :-) [20:20:20] mooeypoo: Other than that, https://bugzilla.wikimedia.org/show_bug.cgi?id=67749 and the (trivial?) https://bugzilla.wikimedia.org/show_bug.cgi?id=67438 would be nice to fix. [20:20:21] oooh. Interesting. [20:21:00] James_F, also, seems the media dialog bugs are either fixed or awaiting merge. There's one that I will need Roan's help with (regarding the jQuery + API callback) [20:21:22] Ah, that, yeah. [20:21:51] yeah that's the first bug you posted, 67749 [20:22:00] it's a really really weird issue, I think it's a problem with jQuery [20:22:05] but i'm not entirely sure what would cause it. [20:22:09] Which Krinkle|detached denies is a bug. :-) [20:22:16] Unless it's a different issue. [20:22:20] it might be a feature [20:22:21] But it looks like it's the same thing. [20:22:23] just a very bad one [20:22:28] Broken by design. [20:22:52] well, it seems to replace the "usual" api callback (what we have in VE code) with a jquery callback that then gets broken [20:23:19] This is because it's cross-domain, right? [20:23:24] I think so [20:23:34] I can try to disable the remote API sources and see if it happens [20:24:21] In that case, can you at least wrap it in a try/catch so it doesn't fatal onto the console? [20:27:33] (03PS3) 10Trevor Parscal: [WIP] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) [20:27:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [20:28:24] James_F, to be honest at this point you could just give it to me in August :) [20:28:40] Krenair: True. :-) [20:29:27] Krenair: I just worry about carrying 15 t-shirts in my bag. [20:29:58] James_F, I'm not sure *what* to wrap.. the entire API request, most likely, but does that work if it's asyncronous ? [20:30:16] thats an interesting question... does try/catch work if it has async stuff inside it... [20:30:18] * mooeypoo looks that up [20:30:22] mooeypoo: Don't ask me. I'm just the Product guy. :-) [20:30:35] I'm thinking aloud. Or.. well.. atext. [20:31:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] All inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061 (10ryasmeen) [20:32:00] James_F, well, either is fine with me. go with the easiest for you [20:32:15] Krenair: Hmm. Will ask admin. [20:32:18] (03PS1) 10Trevor Parscal: Remove lies from documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146906 [20:32:25] (03PS1) 10Trevor Parscal: Safely ignore requests to open unrecognized windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146907 [20:32:37] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (54a54f1cb6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 [20:32:51] (03CR) 10Jforrester: [C: 032] Safely ignore requests to open unrecognized windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146907 (owner: 10Trevor Parscal) [20:33:05] (03CR) 10Jforrester: [C: 032] Remove lies from documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146906 (owner: 10Trevor Parscal) [20:33:30] (03CR) 10Jforrester: [C: 032] Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 (owner: 10Mooeypoo) [20:34:34] (03CR) 10Jforrester: [C: 032] Switch to 'custom' when MediaSizeWidget updates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146676 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [20:34:52] (03PS1) 10Trevor Parscal: Update VE core submodule to 3ecd4d544b8b27ad6d83ad13a2bc1c234b4834e4 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146909 [20:35:27] (03Merged) 10jenkins-bot: Safely ignore requests to open unrecognized windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146907 (owner: 10Trevor Parscal) [20:36:30] (03PS4) 10Trevor Parscal: Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) [20:36:58] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 3ecd4d544b8b27ad6d83ad13a2bc1c234b4834e4 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146909 (owner: 10Trevor Parscal) [20:37:18] (03Merged) 10jenkins-bot: Remove lies from documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146906 (owner: 10Trevor Parscal) [20:37:20] (03Merged) 10jenkins-bot: Add 'clone' and make 'getDimensionsFromValue' static in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146593 (owner: 10Mooeypoo) [20:37:48] (03CR) 10jenkins-bot: [V: 04-1] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [20:37:59] (03Merged) 10jenkins-bot: Switch to 'custom' when MediaSizeWidget updates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146676 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [20:39:15] (03PS2) 10Jforrester: Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146665 [20:39:45] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146665 (owner: 10Jforrester) [20:40:34] 3VisualEditor / 3Editing Tools: Media search either accessed from references or from Insert media gives Uncaught TypeError. - 10https://bugzilla.wikimedia.org/68059#c2 (10Ritu Swain) reproducible in Production. type in some text in media search dialog ,like "ss" or "swainr". [20:40:50] (03CR) 10Trevor Parscal: [C: 032] Don't allow document save if we're already tearing down the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146810 (https://bugzilla.wikimedia.org/68073) (owner: 10Alex Monk) [20:41:57] (03CR) 10Trevor Parscal: [C: 032] Make a message dialog for cancelling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146639 (https://bugzilla.wikimedia.org/68068) (owner: 10Alex Monk) [20:42:26] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146665 (owner: 10Jforrester) [20:45:12] (03PS5) 10Trevor Parscal: Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) [20:45:26] (03Merged) 10jenkins-bot: Don't allow document save if we're already tearing down the surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146810 (https://bugzilla.wikimedia.org/68073) (owner: 10Alex Monk) [20:45:30] (03Merged) 10jenkins-bot: Make a message dialog for cancelling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146639 (https://bugzilla.wikimedia.org/68068) (owner: 10Alex Monk) [20:48:04] (03PS4) 10Jforrester: Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [20:48:39] (03CR) 10jenkins-bot: [V: 04-1] Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [20:48:51] 3VisualEditor / 3Editing Tools: Media search either accessed from references or from Insert media gives Uncaught TypeError. - 10https://bugzilla.wikimedia.org/68059#c3 (10ryasmeen) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 59604 *** [20:48:52] 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604#c16 (10ryasmeen) *** Bug 68059 has been marked as a duplicate of this bug. *** [20:53:31] (03PS5) 10Jforrester: Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [20:53:45] (03Abandoned) 10Jforrester: Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146665 (owner: 10Jforrester) [20:53:52] (03PS2) 10Jforrester: Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [20:54:55] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (e93e7cdc22) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146924 [20:55:18] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [20:56:03] (03PS2) 10Trevor Parscal: Update VE core submodule to 86bcc531e3fb873af40c26414d8a4227e775113c [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146909 [20:56:50] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 86bcc531e3fb873af40c26414d8a4227e775113c [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146909 (owner: 10Trevor Parscal) [20:57:03] (03CR) 10jenkins-bot: [V: 04-1] Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [20:59:17] TrevorParscal: "this.recoverable = config.recoverable === undefined || !!config.recoverable;" [20:59:43] TrevorParscal: And you complained about my suggestion for "if ( !(foo = bar.baz) ) { return; }" :-P [21:00:58] dude, that's the way Timo prefers it [21:01:08] I do too. [21:01:24] default true man! [21:05:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068 (10James Forrester) 5PATC>3RESO/FIX [21:05:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073 (10James Fo... [21:05:50] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] All inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061 (10James Forrester) [21:09:07] 3VisualEditor / 3Editing Tools: VisualEditor: While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15952... [21:11:50] 3VisualEditor / 3Editing Tools: VisualEditor: While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c1 (10ryasmeen) It happens also if I switch to Edit Source mode from the Switch t... [21:12:36] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121 (10ryasmeen) [21:20:35] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073#c4 (10Alex... [21:23:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609#c3 (10ryasmeen) Verified the fix in Betalabs [21:23:51] 3VisualEditor: VisualEditor: Select text, type = garbled, repeated text + snowman on el.wp - 10https://bugzilla.wikimedia.org/68124 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See https://el.wikipedia.org/w/index.php?title=%CE%A7%CF%81%CE%AE%CF%83%CF%84%CE%B7%CF%82%3AElitre_%28WMF%29%2Fsandbox&diff=475... [21:32:34] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c3 (10Alex Monk) So we're not destroying the surface, because the SaveDialog closing promise doesn't get resolved it's re... [21:32:47] TrevorParscal, ^ actually I wonder if it should be checking isClosing before erroring like that? [21:34:05] 3VisualEditor: VisualEditor: Select text, type = garbled, repeated text + snowman on el.wp - 10https://bugzilla.wikimedia.org/68124#c1 (10paa2004) (In reply to Elitre from comment #0) > See > https://el.wikipedia.org/w/index. > php?title=%CE%A7%CF%81%CE%AE%CF%83%CF%84%CE%B7%CF%82%3AElitre_%28WMF%29%2Fsan > dbo... [21:34:11] TrevorParscal, you know onContextChange in ve.ui.Context? [21:37:28] edsanders: see https://gerrit.wikimedia.org/r/#/c/146640/ [21:37:38] that is what juliusz is working on [21:39:17] interesting [21:39:37] aparently they have a basic tap event abstraction [21:39:49] that simulates them by listening to start/move/end events [21:39:50] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604#c12 (10ryasmeen) 5RESO/FIX>3REOP Now if I follow the minimal wikitext or the steps to reproduce in a page and try t... [21:42:01] what is supposedly broken at the moment? [21:42:17] In the chrome touch emulator I can't see anything obvious [21:42:50] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10ryasmeen) 5REOP>3ASSI [21:43:21] 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>... [21:43:32] also on Chrome Mobile [21:44:34] has to do with clicking on toolbars, toolgroups and tools on ipad [21:44:47] mouse events aren't being handled as we expected [21:45:40] eh James_F I'm submitting a fix, the qunits pass now. HOWEVER, I wanted to test myself that things work, and I am getting very very weird and huge problems with the API [21:45:52] I don't see how they can be related to my change, but.. I.. don't.. knowwww....... [21:45:56] mooeypoo: Fun. [21:46:07] is there anything wrong with the API? in general? Like, I have problems with the "save" dialog too [21:46:19] API requests go bonkers for me [21:46:21] Are you getting fatals about uselang= not being supported? [21:46:48] (03PS6) 10Mooeypoo: Work on a cloned scalable when editing images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) [21:47:04] James_F, yes, but also things seem to take a while (or fail gracefully) for API [21:47:13] for instance, new images don't get original size [21:47:28] Hmm. [21:47:29] and the save dialog's "review changes" take forever and then fails [21:47:32] might be a local thing for me [21:47:42] That's not good. Krenair, have you seen anything like this? [21:47:52] but my point was that the above fix SHOULD work now.... except that maybe everything doesn't. [21:48:18] Do you get the same behaviour in master? [21:48:24] let me try [21:48:50] (03CR) 10Esanders: demos: Add LTR/RTL switcher to icons demo (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [21:51:59] (03PS2) 10Jforrester: demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 [21:53:17] (03PS3) 10Jforrester: demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 [21:54:39] (03CR) 10Jforrester: "PS2 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [21:54:45] (03PS4) 10Jforrester: demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 [21:55:08] TrevorParscal, in the tools demo on the iPad emulator, everything appears to work fine [21:56:22] (03CR) 10Esanders: [C: 032] demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [21:56:35] Thanks edsanders. Not sure why it was broken. [21:56:58] (03Merged) 10jenkins-bot: demos: Add LTR/RTL switcher to icons demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/146366 (owner: 10Jforrester) [21:57:41] James_F, fatals? no [21:57:47] Warnings about uselang are expected [21:58:40] Sorry, yeah. [22:04:32] (03PS1) 10Trevor Parscal: Use SVG check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/146949 [22:05:22] (03CR) 10Jforrester: [C: 032] Use SVG check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/146949 (owner: 10Trevor Parscal) [22:06:10] (03Merged) 10jenkins-bot: Use SVG check icon [oojs/ui] - 10https://gerrit.wikimedia.org/r/146949 (owner: 10Trevor Parscal) [22:06:52] edsanders: I think it is different on an actual ipad [22:07:17] (03CR) 10Jforrester: [C: 032] Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [22:07:44] edsanders: What about BrowserStack (or whatever you had before that allowed you to use an iPad)? [22:07:48] (03CR) 10Trevor Parscal: [C: 032] "Fair play." [oojs/ui] - 10https://gerrit.wikimedia.org/r/145542 (owner: 10Esanders) [22:07:53] (03Merged) 10jenkins-bot: Get OOUI working with mobile again [oojs/ui] - 10https://gerrit.wikimedia.org/r/146296 (https://bugzilla.wikimedia.org/68061) (owner: 10Trevor Parscal) [22:08:13] I was using CrossBrowserTesting [22:08:20] Right. [22:08:26] Does it show with that? [22:08:39] works fine [22:08:52] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (a9d6a42680) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146664 (owner: 10Jforrester) [22:08:55] Hmm. [22:09:38] (03Merged) 10jenkins-bot: Prevent disabled tools from stealing focus [oojs/ui] - 10https://gerrit.wikimedia.org/r/145542 (owner: 10Esanders) [22:10:24] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (97dbb50137) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146924 (owner: 10Trevor Parscal) [22:10:33] same on a 'real' ipad retina 7 [22:10:34] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (97dbb50137) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146924 (owner: 10Trevor Parscal) [22:10:49] Retina 7? [22:12:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (97dbb50137) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146924 (owner: 10Trevor Parscal) [22:12:49] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] All inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061 (10James Forrester) 5PATC>3RESO/FIX [22:13:07] ios7 [22:13:50] Ah. Hmm. Talk to jgonera? [22:14:42] edsanders, that patch that TrevorParscal sent you is needed for another patch I'm working on [22:14:54] it also improves responsiveness [22:15:04] previously there was a 300ms delay before tapping and action [22:15:09] right [22:15:19] the other patch is https://gerrit.wikimedia.org/r/#/c/145185/ [22:15:24] because the simulated mouseup is delayed [22:16:47] I know [22:16:53] (03PS1) 10Alex Monk: Set title of page to use if discarding changes when changing to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146956 (https://bugzilla.wikimedia.org/68121) [22:17:14] Krenair: :-D [22:18:05] TrevorParscal: So are we reverting https://gerrit.wikimedia.org/r/#/c/143518/ ? [22:19:32] James_F, crap, I have a bug in my code, but this is a breaking change whose half is merged, and the bug is semi significant. [22:19:58] mooeypoo: Want me to revert the merged half? [22:20:07] mooeypoo: Or do you think you can fix it quickly? [22:20:14] James_F, either that, or we merge with the bug and I"ll submt a fix later today/tonight [22:20:32] There's something going wrong with listening to events when we pick new image from the API [22:20:36] James_F: my understanding is that it just needs to be fixed [22:20:50] mooeypoo: That's also fine IMO. [22:21:03] TrevorParscal: What's the fix, and can I do it? [22:21:04] James_F, I was hoping it's a quick fix, and it should be, but only I can't figure out WHY it happens. [22:21:09] because it either prevents you from working with citations at all (merged) or lets you edit stuff you shouldn't be allowed to (reverted) [22:21:11] mooeypoo: Sure. Merge now? [22:21:22] TrevorParscal: Yeah. :-( [22:21:35] Not a simple fix, I was hoping it wasn't urgent [22:21:48] because Roan is the one who needs to fix it (since he broke it) [22:21:51] :P [22:22:02] TrevorParscal: It needs to land within 170 hours. [22:22:14] TrevorParscal: Roan is back and conscious in maybe 160 hours' time. [22:22:17] TrevorParscal: You decide. :-) [22:22:30] I can take a look, has something to do with being able to specify which actions can be taken [22:22:43] lol [22:23:01] TrevorParscal: Or could we just enable all the tools in mobile, but not in the toolbar? [22:23:38] James_F, the pending-merge fix is here: https://gerrit.wikimedia.org/r/#/c/146513/ [22:23:52] it no longer breaks the qunit tests [22:24:23] but apparently there's a new bug now, where if you change an image, the scalable doesn't get properly update--- omg I know what's going on [22:24:29] TrevorParscal, !!! help me. [22:25:12] TrevorParscal, we have a casualty of using cloned scalable. The scalable is updated from the API, which is async. When we choose a new image, I *clone it* (before it's updated!!) [22:25:28] which means that when it's updating its original size, the original scalable is updated... not the cloned one. [22:25:34] TrevorParscal, :\ [22:26:34] Scalable emits changes when its originalSize is updated. I was all confused why the media size widget isn't responding to the change! (BECAUSE it has a cloned scalable object! oh man) [22:27:47] James_F, either revert the core change, or merge this and I"ll have to see how to at least temporarily fix this ... I also will have to go for a little bit to take care of things and pick something up in the city... so i will have to work on this later tonight.. [22:28:03] James_F, maybe reverting is best in this case? I'm worried about it going into production. It's wednesday, right? :\ [22:30:37] .... I have a convoluded idea for a (temporary?) fix that will make Trevor cringe, but will fix the code. [22:31:33] (03PS1) 10Cmcmahon: [BrowserTest] update switch-edit-mode test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146960 [22:34:25] mooeypoo: It is, but worry not. [22:34:45] mooeypoo: We can always backport. [22:34:54] (03PS1) 10Trevor Parscal: Enable mwreference and mwtransclusion modules on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146962 [22:35:34] mooeypoo: interesting problem [22:36:07] so, why is the API being called for the scalable on the node? [22:36:24] why not call it after clone? [22:36:35] TrevorParscal, when we choose a new image, we send a request for original size [22:36:48] TrevorParscal, here's my temporary fix: have the model listen (just listen!) to events from the original scalable [22:36:55] and when/if the original one has new details, update the clone [22:37:13] that way, even if we deal with async stuff, the clone will get updated with details it needs to have (like default size and original size) [22:37:25] or rather, original size, which is the important bit [22:37:25] one sec [22:38:01] ok, so the only time the API is called is when the user selects an image? [22:38:10] (03PS7) 10Jforrester: Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [22:38:11] isn't it called when you open the dialog to edit an existing one as well? [22:39:37] (03PS2) 10Cmcmahon: [BrowserTest] update switch-edit-mode test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146960 [22:39:55] TrevorParscal, images that already exist have the details we want (their api request goes out on load) [22:39:57] (03CR) 10Jforrester: "Effectively reverted in Icdf2a208." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143518 (owner: 10Catrope) [22:40:02] (03PS2) 10Jforrester: Enable mwreference, mwtransclusion modules on all targets including mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146962 (https://bugzilla.wikimedia.org/67701) (owner: 10Trevor Parscal) [22:40:08] TrevorParscal, the issue is only with an image we search for and then select in the search widget [22:40:13] (03CR) 10Jforrester: [C: 032] Enable mwreference, mwtransclusion modules on all targets including mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146962 (https://bugzilla.wikimedia.org/67701) (owner: 10Trevor Parscal) [22:40:35] TrevorParscal, the original dimension request goes out when we pick it up, and by the time it comes back, the node's already cloned. [22:40:40] err the scalable i mean [22:40:42] not the node [22:40:45] mooeypoo: why are we cloning in the selection case then? [22:40:49] (03CR) 10Jforrester: [C: 032] "Let's land this now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [22:41:01] we clone from the node in the edit case, because we want to leave the node alone [22:41:02] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146960 (owner: 10Cmcmahon) [22:41:03] TrevorParscal, we clone so we can change the attributes and scalable calculations [22:41:12] TrevorParscal, aye. Good point. [22:41:19] just don't clone in that case [22:41:24] selection is done, it's a throw-away [22:41:26] well, the node in the edit case is faux-node [22:41:29] just keep it 'round eh? [22:41:30] it's a temporary node anyways [22:41:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] Cite menu is missing in the toolbar for mobile VE for in both alpha and beta modes - 10https://bugzilla.wikimedia.org/67701 (10James Forrester) 5PATC>3RESO/FIX a:3Trevor Parscal [22:41:37] 3VisualEditor / 3Editing Tools: VisualEditor: Blank link inspector UI appears when trying to open it inside the Media Settings while selecting another image in the caption - 10https://bugzilla.wikimedia.org/68130 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15953 --> https://bug... [22:41:37] hm [22:42:07] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] update switch-edit-mode test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146960 (owner: 10Cmcmahon) [22:42:12] mooeypoo: the fact that you have a temporary dummy node tells me something is tied up in the node instance code that should be made static [22:42:14] (03CR) 10jenkins-bot: [V: 04-1] Enable mwreference, mwtransclusion modules on all targets including mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146962 (https://bugzilla.wikimedia.org/67701) (owner: 10Trevor Parscal) [22:42:32] TrevorParscal, yeah, that's a good point. I didn't think of that. [22:42:59] i'm thinking, with selection, we should get a scalable from the selection and keep it [22:43:03] (03Merged) 10jenkins-bot: Enable mwreference, mwtransclusion modules on all targets including mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146962 (https://bugzilla.wikimedia.org/67701) (owner: 10Trevor Parscal) [22:43:10] and, ideally not fuss with a node at all [22:43:18] TrevorParscal, yeah, we don't [22:43:24] i mean, that's what I'm doing now [22:43:28] awesome [22:43:33] the issue was with new node -- which gets the info INTO the node [22:43:52] (03Merged) 10jenkins-bot: Update VE core submodule to master (ad18102) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146513 (https://bugzilla.wikimedia.org/67687) (owner: 10Mooeypoo) [22:43:53] and... we do need it. The API request is in the node. [22:43:57] I can make it static too, I guess. [22:43:57] (03Merged) 10jenkins-bot: [BrowserTest] update switch-edit-mode test for new UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146960 (owner: 10Cmcmahon) [22:45:06] James_F, TrevorParscal ok , I know what I need to do to fix things now, but I need to run out to make sure I get stuff on time before things close (forms and get stuff for the flight).. which means I can work on this after I get back tonight... you want to revert the core change, or merge the current ve-mw with the (relatively small) bug, and later on tonight/tmorrow my fix? [22:46:28] mooeypoo: Sure, no worries. I've merged it already. :-) [22:46:36] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687 (10James Forrester) 5PATC>3RESO/FIX [22:46:37] mooeypoo: We'll work on your fix tonight/tomorrow. [22:46:43] * mooeypoo nods [22:46:48] (03PS3) 10Jforrester: Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [22:47:03] (03CR) 10Jforrester: [C: 032] Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [22:47:19] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684 (10James Forrester) 5PATC>3RESO/FIX [22:49:22] (03Merged) 10jenkins-bot: Listen to widget changes in MediaDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146682 (https://bugzilla.wikimedia.org/67684) (owner: 10Mooeypoo) [22:49:54] (03CR) 10Jforrester: [C: 032] Prevent deletion of focusable nodes by typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146808 (https://bugzilla.wikimedia.org/67177) (owner: 10Esanders) [22:51:15] (03Merged) 10jenkins-bot: Prevent deletion of focusable nodes by typing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146808 (https://bugzilla.wikimedia.org/67177) (owner: 10Esanders) [22:53:34] (03PS2) 10Jforrester: Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [22:54:58] (03CR) 10Jforrester: [C: 032] Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [22:58:04] 3VisualEditor / 3ContentEditable: VisualEditor: Typing when a focusable node is selected should do nothing - 10https://bugzilla.wikimedia.org/67177 (10James Forrester) 5PATC>3RESO/FIX [23:00:48] (03PS1) 10Jforrester: Update VE core submodule to master (48772a2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146975 [23:01:02] TrevorParscal: Please +2 https://gerrit.wikimedia.org/r/146974 and https://gerrit.wikimedia.org/r/146975 [23:01:39] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (48772a2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146975 (owner: 10Jforrester) [23:01:41] TrevorParscal: Thanks! [23:06:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (48772a2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146975 (owner: 10Jforrester) [23:07:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) [23:07:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10James Forrester) a:3Juliusz Gonera [23:07:36] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) [23:08:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) a:3Juliusz Gonera [23:13:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: Context menu for Math is still appearing in Mobile VE - 10https://bugzilla.wikimedia.org/68010 (10James Forrester) 5ASSI>3RESO/WON [23:15:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) [23:15:07] 3VisualEditor / 3ContentEditable: VisualEditor: Display HTML comments to the editor (and make them editable/creatable/removable) - 10https://bugzilla.wikimedia.org/49603 (10James Forrester) [23:15:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [23:15:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) [23:15:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10James Forrester) [23:15:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10James Forrester) [23:15:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [23:15:26] 3VisualEditor / 3Data Model: VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations - 10https://bugzilla.wikimedia.org/67377 (10James Forrester) [23:15:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [23:15:35] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [23:22:22] (03PS1) 10Trevor Parscal: Bring back global/local specific CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146980 [23:22:44] (03CR) 10Jforrester: [C: 032] Bring back global/local specific CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146980 (owner: 10Trevor Parscal) [23:26:04] (03Merged) 10jenkins-bot: Bring back global/local specific CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146980 (owner: 10Trevor Parscal) [23:28:05] (03PS1) 10Jforrester: Update VE core submodule to master (8bb3848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146981 (https://bugzilla.wikimedia.org/68066) [23:33:05] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node backwards by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755#c3 (10ryasmeen) Verified the fix in Betalabs [23:43:49] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [23:43:55] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10James Forrester) [23:43:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [23:43:55] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [23:43:55] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) [23:43:56] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any edit in mobile VE for Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66756 (10James Forrester) [23:43:57] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10James Forrester) [23:43:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on Return while cursor is at the end of a text , deletes that text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66758 (10James Forrester) [23:43:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262 (10James Forrester) [23:44:00] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10James Forrester) [23:44:05] 3VisualEditor / 3ContentEditable: VisualEditor: Copying text sometimes makes the page jump/scroll in Firefox - 10https://bugzilla.wikimedia.org/55433 (10James Forrester) [23:44:17] TrevorParscal: Overlay change -> https://gerrit.wikimedia.org/r/146981 (amend with your local stash); still-active patch should be tagged Bug: 68048. [23:45:56] (03PS1) 10Trevor Parscal: Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 [23:46:54] (03PS2) 10Jforrester: Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal) [23:47:02] (03PS2) 10Trevor Parscal: Update VE core submodule to master (8bb3848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146981 (https://bugzilla.wikimedia.org/68066) (owner: 10Jforrester) [23:47:14] (03CR) 10Jforrester: [C: 032] Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal) [23:48:08] (03PS3) 10Jforrester: Update VE core submodule to master (8bb3848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146981 (https://bugzilla.wikimedia.org/68066) [23:48:16] (03CR) 10Jforrester: [C: 032] "Thanks, Trevor!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146981 (https://bugzilla.wikimedia.org/68066) (owner: 10Jforrester) [23:48:39] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066 (10James Forrester) 5PATC>3RESO/FIX [23:48:43] (03CR) 10jenkins-bot: [V: 04-1] Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal) [23:49:21] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048 (10James Forrester) 5PATC>3RESO/FIX a:5Alex Monk>3Trevor Parscal [23:50:56] Krenair: ^^^ Trevor found and fixed the cursor-still-blinking issue in case you were still working on it. [23:51:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (8bb3848) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146981 (https://bugzilla.wikimedia.org/68066) (owner: 10Jforrester) [23:52:00] (03PS3) 10Jforrester: Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal) [23:59:10] (03CR) 10Jforrester: [C: 032] Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal)