[00:00:52] (03Merged) 10jenkins-bot: Close the save dialog on teardown only, not on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146984 (https://bugzilla.wikimedia.org/68048) (owner: 10Trevor Parscal) [00:03:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal Looks like this got fixed two weeks ago. [00:06:34] (03Abandoned) 10Jforrester: Update VE core submodule to 86bcc531e3fb873af40c26414d8a4227e775113c [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146909 (owner: 10Trevor Parscal) [00:07:15] (03CR) 10Jforrester: [C: 032] Set title of page to use if discarding changes when changing to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146956 (https://bugzilla.wikimedia.org/68121) (owner: 10Alex Monk) [00:07:50] 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121 (10James Forrester) 5PATC>3RESO/FIX [00:08:15] (03PS3) 10Jforrester: Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:09:00] (03Merged) 10jenkins-bot: Set title of page to use if discarding changes when changing to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146956 (https://bugzilla.wikimedia.org/68121) (owner: 10Alex Monk) [00:10:34] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) [00:10:36] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053 (10James Forrester) [00:10:37] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) [00:10:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073 (10James Fo... [00:10:37] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10James Forrester) [00:10:42] (03CR) 10Jforrester: "Let's try again, Zuul?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:10:48] (03CR) 10Jforrester: [C: 032] Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:10:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10James Forrester) [00:10:51] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [00:10:51] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) [00:11:47] (03CR) 10jenkins-bot: [V: 04-1] Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:13:57] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:15:13] (03Merged) 10jenkins-bot: Fix-up mobile context and surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/146908 (owner: 10Trevor Parscal) [00:17:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885#c2 (10Alex Monk) a:5Alex Monk>3Ed Sanders Changing assignee to match that... [00:17:56] (03PS1) 10Jforrester: Update VE core submodule to master (63b10db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146993 [00:18:12] Krenair: You around? [00:18:15] yes [00:18:28] Could you +2 https://gerrit.wikimedia.org/r/146993 quickly? [00:18:42] * James_F grumbles about jenkins losing its marbles yet again. [00:18:46] (not around any more, lol) [00:18:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068#c3 (10ryasmeen) Verified the fix in Betalabs [00:19:04] ok, looking [00:19:25] It's just a silly pull-through of one of Trevor's mobile fixes. [00:20:03] (03PS3) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 [00:21:18] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (63b10db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146993 (owner: 10Jforrester) [00:21:20] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c6 (10ryasmeen) Verified the fix in Betalabs [00:21:38] Krenair: Thanks! [00:22:12] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=67156 - I guess we should just report upstream to WebKit..? [00:22:44] Yeah, though that's tough now. [00:23:20] or maybe to chromium and see what they say. [00:23:26] oh, but chromium don't use webkit now, do they? sigh [00:23:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (63b10db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/146993 (owner: 10Jforrester) [00:23:44] Yeah. [00:23:52] James_F, tough? (I've never dealt with WebKit so I have no idea what you're talking about :)) [00:24:05] If Blink had the same issue we could use Google's public tracker. [00:24:17] But Webkit is now just reporting to Apple… [00:24:28] ah. [00:27:35] 3VisualEditor / 3MediaWiki integration: VisualEditor: TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424 (10Alex Monk) 5ASSI>3UNCO [00:28:12] Krenair: In this case it's a problem in Chrome and Safari, so do you want to report upstream to Google for Blink? [00:28:54] It might be that Firefox is doing something clever which it perhaps shouldn't, but I doubt it [00:29:31] Or just "not yet a standard". [00:32:42] James_F, actually I just went back and tested this again [00:33:25] Krenair: Behaviour has changed? [00:33:40] Maybe I was slightly unclear about exactly what's happening [00:33:45] There's two things here: One is letting the tab outside of the dialog box at all, the other is tab getting lost and never returning to the start [00:34:03] Right. [00:34:50] Chrome lets it out of the dialog, but it properly goes back and doesn't get stuck [00:36:16] (03CR) 10Jforrester: "Is this needed or has Ia17f5a3e over-taken it?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119432 (owner: 10Catrope) [00:38:34] Firefox does not let it out of the dialog [00:40:57] And Safari just lets it out and it gets stuck [00:44:42] * James_F sighs. [00:44:48] Well done, browsers. [00:45:10] James_F, oh, uh [00:45:15] I just checked Chrome on windows [00:45:21] (Where I was testing Safari) [00:45:45] OK… [00:45:45] And tabbing doesn't start again from the beginning there -.- [00:45:51] * James_F sighs. [00:46:28] am summarising this on the bug [00:46:32] Thanks! [00:46:36] * James_F goes home. [00:46:43] Too hot to work. [00:50:31] James_F: Tchyeah you are [00:51:04] 3VisualEditor / 3Editing Tools: VisualEditor: Do not let me tab outside the dialog box in Safari - 10https://bugzilla.wikimedia.org/67156#c5 (10Alex Monk) So after some confusion about this I looked into it again, and I believe that there's two issues here: * We perhaps shouldn't let tab take the focus out... [00:55:21] James_F: What do I deny is a bug? I'd like the oppertunity to revise my statement on whatever that is :) [00:55:51] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal Fixed by Tre... [00:56:15] thedj appreciated all your greetings and love. Was fun hanging out in our home town for a change. Except for once at the train station on our way to Utrecht or Schiphol, I'd never seen him in Enschede. [00:58:03] Krinkle: Ha. :-) [00:59:39] Anyway. I'm off. [00:59:54] Krinkle: Go to bed so you're awake in advance of tomorrow's meeting. :-) [00:59:57] * James_F waves. [01:03:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: TemplateData not being processed for a template that isn't in the Template: namespace - 10https://bugzilla.wikimedia.org/67424#c5 (10James Forrester) 5UNCO>3RESO/WOR AFAWCT this should work… marking as such. [01:10:04] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] In new save dialog, the Save button remains active while the save is in progress and clicking on that throws error: Uncaught TypeError: Cannot read property '$saveOptions' of null - 10https://bugzilla.wikimedia.org/68073 (10James Fo... [01:48:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c5 (10Krinkle) I can reproduce both the UI as... [01:50:21] Hi. I'm testing VisualEditor on 1.23.1. Everything is OK except for inserting an image. When you insert media, you can't use searching function. The error message is 'error":{"code":"readapidenied","info":"You need read permission to use this module"}'. [01:50:48] Could anyone give a clue? I've changed the permission $wgGroupPermissions['*']['writeapi'] = true; according to https://bugzilla.wikimedia.org/show_bug.cgi?id=67313#c16. But it did not work. [01:52:11] However if I set $wgGroupPermissions['*']['read'] = true, the pictures will be shown. [02:04:16] Coiby: That seems to be a general problem with your MediaWiki setup. VisualEditor communicates with the MediaWiki API on behalf of the current logged-in user. [02:04:38] I'll be right back in a few, but you may want to ask in #mediawiki instead. I'll peek there in a bit to see if I can help you. [02:29:48] Krinkle: Thank you! I previously asked the question in #mediawiki. But someone told there's this channel. So I asked the question here. [02:46:01] Coiby: Hehe, yeah, that happens [02:48:46] Krinkle: According to https://www.mediawiki.org/wiki/API:FAQ, "The wiki you're querying contains private content and requires users to log in in order to be able to read all pages. This means that a client needs to be logged in to query any information at all through the API. See the quick start guide for more information. It's not currently possible to query the contents of whitelisted pages without logging in, even though they're availab [02:50:02] Coiby: Does your wiki have a whitelist configuration? Or can users view all pages? [02:51:33] Kindkle: I noticed a GET request was sent to api.php, shouldn't api.php judge based on cookies? [02:53:08] Krinkle: (sorry for mis-spelling in previous message) I have a setting $wgWhitelistRead = array("Special:YunLogin",);. And only users who logged in can view all pages. [02:53:29] And when you're getting this error in VisualEditor, you are already logged in, right? [02:53:44] Yes [05:30:35] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c2 (10NicoV) I was the one reporting the issue with words like "le" being made into internal links by mistake on frwiki. I think the behavior of automatically selecting the entir... [07:43:52] 3VisualEditor / 3Editing Tools: can't search image when inserting media in private wiki - 10https://bugzilla.wikimedia.org/68141 (10Coiby) 3UNCO p:3Unprio s:3major a:3None I'm testing VisualEditor on 1.23.1. Everything is OK except for inserting an image. When you insert media, you can't use search f... [09:05:06] 3VisualEditor: ☃ symbol replicates when creating an article [HEBREW WIKIPEDIA]] - 10https://bugzilla.wikimedia.org/68147 (10katalavst) 3UNCO p:3Unprio s:3normal a:3None When I have created an article in the hebrew version of wikipedia, ☃ symbol replicated. The operations I did: 1. I copied an tamplate... [09:05:35] 3VisualEditor: ☃ symbol replicates when creating an article [HEBREW WIKIPEDIA]] - 10https://bugzilla.wikimedia.org/68147 (10katalavst) [09:06:05] 3VisualEditor: ☃ symbol replicates when creating an article [HEBREW WIKIPEDIA] - 10https://bugzilla.wikimedia.org/68147 (10katalavst) [09:09:51] 3VisualEditor: Letters start to replecate when writing a new article [HEBREW WIKIPEDIA] - 10https://bugzilla.wikimedia.org/68148 (10katalavst) [09:09:51] 3VisualEditor: Letters start to replecate when writing a new article [HEBREW WIKIPEDIA] - 10https://bugzilla.wikimedia.org/68148 (10katalavst) 3UNCO p:3Unprio s:3normal a:3None When I write a new article in the visual editor of the hebrew wikipedia, the letters I write replicates (I did nothing special... [09:23:50] whoops [09:56:07] 3VisualEditor: When making text bold or italic, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151 (10katalavst) 3UNCO p:3Unprio s:3normal a:3None In hebrew wikipedia, when I have created a new article, added a tamplate to it, wrote text and made it bold or italic - instead of the text appear... [09:56:20] 3VisualEditor: When making text bold or italic, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151 (10katalavst) [11:21:43] (03PS1) 10Esanders: Add special case for up/down arrow key on focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147084 [11:23:50] (03PS1) 10Esanders: Remove is*ArrowKey functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 [12:25:34] Chrome: http://jsfiddle.net/edg2s/QL87X/ [12:28:56] (03PS23) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) [12:44:36] (03PS1) 10Esanders: Fix for cursoring into focusable nodes with up/down [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147097 [13:19:13] (03PS24) 10Vikassy: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) [14:00:30] (03PS1) 10Cmcmahon: [BrowserTest] update locator for correct page text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147105 [14:01:11] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147105 (owner: 10Cmcmahon) [14:02:56] (03Merged) 10jenkins-bot: [BrowserTest] update locator for correct page text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147105 (owner: 10Cmcmahon) [14:19:16] (03CR) 10Zfilipin: "Reviewers, this code is now running in Jenkins, to make it easier to +1 or -1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [14:39:16] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [14:41:01] (03Merged) 10jenkins-bot: [BrowserTest] Added lots of new scenarios for language screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142990 (https://bugzilla.wikimedia.org/62737) (owner: 10Vikassy) [15:26:25] Heya. [15:27:45] howdy James_F! [15:28:09] ragesoss: How are you doing? [15:28:16] very well! [15:28:23] Excellent. [15:29:07] Wiki Ed is working on some more help material, and I wanted to know more about the plans around improving the citations experience. where's the most up to date info about where (and when) you're going with that? [15:30:12] I gather that you've got some work in progress on a thingy that can autofill common source types just from a pasted url? [15:30:19] Yup, that's https://www.mediawiki.org/wiki/Citoid [15:30:31] Well, that's the service we're setting up, to be specific. [15:30:52] and the idea is to make that the centerpiece of citing web pages? [15:31:09] Yes, that will be the main route. [15:31:40] and this is how far out? 3 months? a year? [15:31:56] 2–3 months, ish. [15:32:01] sweeeeet [15:32:08] There's a user-script that makes it sort-of work right now. [15:32:16] But it's not yet ready for prime-time. [15:33:02] I just played with the current VE citation experience, for the first time in a few months. it's coming along! [15:33:26] Thanks! Further to go, though. [15:33:46] Making users decide which of news/web/book/journal/DOI/etc. they want to cite is unhelpful. [15:33:54] I don't like not having all the suggested parameters visible at once. having to scroll through the small dialog box seems tedious. [15:34:25] We tested the designs a bunch and having the fields closer together made people feel over-whelmed. [15:34:38] The real answer is to have fewer suggested parameters, or more of them auto-filled, of course. :-) [15:34:46] indeed [15:35:52] I was trying to figure out how the templatedata specifies which of the many optional parameters get displayed when you first click "add more information" vs. which you have to click again the "show the other 81 fields" to reveal. [15:36:10] It shows the first three unused ones. [15:36:11] Is that just like, it takes the first 4 and hides the rest under another click? [15:36:29] They're shown in the order they're listed in in the TemplateData block. [15:36:31] first as in, first from the top in the templatedata. [15:36:39] okay, cool. [15:36:46] You can re-organise them however you want (or set a paramOrder set if you want). [15:37:54] I probably won't try bothering with that myself (to make sure the optional parameters that are part of the 'source' version of the cite tools are the first ones in the full list) [15:38:04] but I'll leave a suggestion on a talk page. [15:38:21] * James_F nods. [15:39:44] * mvolz pops into existence [15:40:18] Hey mvolz. :-) [15:41:29] Also, I tried editing a blob of templatedata that was on a talk page, using the fancy visual tool. It fuzzed the whole blob, though, adding a bunch of "null" in place of other things. Is that probably because the blob was in an outdated format? [15:41:46] ragesoss: if you feel like alpha testing here is a gadget that works with citoid: https://en.wikipedia.org/wiki/User:Mvolz/veCiteFromURL *disclaimers apply* [15:42:16] ragesoss: It could be… If you give me a link I'll look into it. [15:42:29] much more limited functionality than is planned, of course :) [15:42:42] James_F: so, template data :) [15:42:52] mvolz: Yeah. :-) [15:43:16] mvolz: thanks. I'm trying to figure out how we advise people to do citations for the pschology-specific brochure we're working on (in a context where proper PMID citations are a high priority for experienced editors in the topic area) [15:44:09] James_F: here: https://en.wikipedia.org/wiki/Template:Cite_journal/doc#Template_data [15:44:34] James_F: cool! So, cite pmid + bot? :) [15:44:39] ragesoss: Thanks. [15:44:57] so what do we mean by proper pmid citations [15:45:00] I note that this doesn't seem to be the *actual* template data, since it's just non-transcluded text on that section of the talk page. [15:45:04] that all journal citations have a pmid number? [15:45:25] mvolz: well, it's possibly more complex than that. [15:45:57] elaborate? :) [15:45:57] ragesoss: https://en.wikipedia.org/wiki/Template:Cite_journal/doc#Template_data isn't a talk page. [15:46:13] ragesoss: And I don't get NULLs when I edit it… What did you change? [15:46:26] ragesoss: (It does get re-formatted, though.) [15:46:54] James_F: I deleted one item, the one at the bottom, using the right hand delete button. [15:47:13] * James_F tries. [15:47:32] Hmm. [15:47:32] James_F: ah. so that really is the templatedata for it, and it just any old place on the /doc page? [15:47:56] ragesoss: Yes, as long as it gets transcluded to the Template (inside a there is fine) it works. [15:48:17] ragesoss: Longer-term we'll create a Template_data: namespace, so you'll just edit Template_data:Cite_journal. [15:52:07] mvolz: So, TemplateData… We need TD to have a way to map fields to citoid's concepts of metadata fields. [15:52:36] ooh, http://www.ncbi.nlm.nih.gov/pmc/tools/id-converter-api/ [15:52:41] yeah [15:52:46] mvolz: nevermind, that's basically the size of it... that all journal articles with PMID should get citations in the standard, full-filled out {{cite journal}} way. [15:53:07] the standard within WikiProject Medicine is to use this tool: WikiProject Medicine has established an expectation that citations to articles with a PMID [15:53:10] * James_F runs for meeting. [15:53:10] err.. [15:53:18] bye! [15:53:19] this tool: http://tools.wmflabs.org/citation-template-filling/cgi-bin/index.cgi?ddb=&type=pubmed_id&id=18723523 [15:53:36] yup, very cool. [15:54:04] that's an easy way to do it with wikitext [15:54:41] but it's not realistic to expect new users to rely on that tool, but they'll be told they are doing it wrong if they don't. [15:55:29] so basically, you want a VE way of doing it. :) [15:55:33] so I've been trying to figure out what to do in terms of guidance, for classes that start in a couple months. [15:55:57] mvolz: yeah. is Citoid also going to make its way into source mode? [15:56:13] because I imagine that would be something pretty much everyone would appreciate. [15:56:31] well there's precendent for it in terms of the reftoolbar [15:56:34] which is wikispecific [15:56:40] wikipedia* specific [15:57:03] but I think the focus for now is having it be a mediawiki wide project [15:57:16] are you saying, "it'll be there if someone else can port it to reftoolbar"? [15:58:04] so, basically I'm a summer intern, so I can speak for Wikimedia Foundation Proper TM :) [15:58:21] um, but my intership is prescriptively mediawiki-only [15:58:27] not wikipedia. [15:58:38] got it. [15:58:49] so if someone else, or me in another month, wants to add support there, then yes, could happen :D [15:59:08] how challenging would it be to adapt it for reftoolbar, do you think? [16:00:09] I haven't looked into reftoolbar internals but I think it would probably be easier than VE integration. but that's just a guess. [16:00:12] wild guess. [16:00:24] hahaha [16:01:15] I guess that makes sense, since zotero works in terms of rawer data. [16:01:47] well so, I believe, in the reftoolbar the citation templates are just copied in. they're not making use of template data. [16:02:05] right. [16:02:11] (neither are the gadgets that work with citoid at this point) [16:02:32] so that's easier. but of course that means it can't be used mediawiki-wide. since it is specific to those templates. [16:02:48] so it's basically just a matter of taking what the gadget does now, and building it into reftoolbar. [16:02:59] yeah [16:03:37] but at this point I need to be actually making it use template data so it could be used with any set of templates. but then James_F|Away ran off to a meeting, haha :) [16:04:00] cool. thanks much, mvolz (and James_F|Away). this gets me a lot closer to knowing what we should put into our brochure. [16:04:30] np. Actually wanted to ask again about PMID- [16:04:41] mhmm? [16:04:59] so- is it that people want a PMID on every citation [16:05:12] or that given they have a PMID, they want the full citation? [16:05:14] no. only some types of sources have them. [16:05:18] the latter. [16:06:03] ok [16:06:32] they want every source that *does* have a PMID to be formatted is a standard way, with all the key information that they can get currently with that tool (which only takes the PMID as input) [16:06:36] I guess I'm wondering if a) should annotate every citation with PMID and or b) how high a priority citing by PMID (versus other identifiers like URL or DOI) should be [16:06:52] I* [16:06:57] mvolz: PMID is very specific to the medical context. [16:07:05] right [16:07:13] when I say every, I mean, everyone that has one [16:07:16] it's for PubMed, so it's only a small fraction of them in general. [16:07:44] for ones that *have* a PMID, it's probably equal priority to DOI, maybe higher. [16:07:51] ok [16:08:10] thanks :) [16:08:11] obviously url will be the easiest in most cases, if that works well. [16:19:21] mvolz: Ah... I remember now the complication I was thinking of. Currently you can use the PMID field in reftoolbar to do a lookup of info, but it supplies only part of the info that the pmid citation tool does. Critically, it doesn't pull in the doi or pmc, so it only links to the pubmed page rather than better urls. [16:28:35] (03PS1) 10Cmcmahon: [BrowserTest] Chrome needs to wait for the inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147139 [16:30:39] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147139 (owner: 10Cmcmahon) [16:32:19] (03Merged) 10jenkins-bot: [BrowserTest] Chrome needs to wait for the inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147139 (owner: 10Cmcmahon) [16:43:30] (03CR) 10Krinkle: Combo box widget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [16:46:07] 3VisualEditor / 3Editing Tools: VisualEditor: PopupToolGroup item not 'ticked' after changing - 10https://bugzilla.wikimedia.org/68170 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None 1. Place the cursor in a paragraph and change it to a heading the the popup tool 2. Open the popup tool again and obse... [16:46:19] 3VisualEditor / 3Editing Tools: VisualEditor: PopupToolGroup item not 'ticked' after changing - 10https://bugzilla.wikimedia.org/68170#c1 (10Ed Sanders) This may well be a oojsui bug, tbd. [16:56:01] (03PS5) 10Esanders: WIP Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) [17:06:32] (03PS1) 10Vikassy: Modified conflicting step: I go to the (.*?) page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147148 [17:07:45] (03PS2) 10Vikassy: [BrowserTest] Modified conflicting step: I go to the (.*?) page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147148 [17:09:48] (03PS3) 10Vikassy: WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147148 [17:32:06] (03CR) 10Cmcmahon: [C: 032] WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147148 (owner: 10Vikassy) [17:33:47] (03Merged) 10jenkins-bot: WIP [BrowserTest] Modified conflicting step: I go to the (.*?) page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147148 (owner: 10Vikassy) [17:36:02] (03PS6) 10Alex Monk: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [18:04:22] 3VisualEditor / 3Editing Tools: VisualEditor: Langage inspector UI is broken in Betalabs , missing the Direction field - 10https://bugzilla.wikimedia.org/68180 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15958 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15958&action=ed... [18:07:37] 3VisualEditor: issues with CTRL-K on OSX (at least) - 10https://bugzilla.wikimedia.org/68181 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15959 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15959&action=edit snowmans after hitting CTRL-K twice, Chrome on OSX Seen in b... [18:09:35] 3VisualEditor / 3Editing Tools: VisualEditor: Langage inspector aUI is broken in Betalabs , missing the Direction field - 10https://bugzilla.wikimedia.org/68180#c1 (10ryasmeen) Also , Special Character inspector has its UI distorted.Are they related? [18:09:50] 3VisualEditor / 3Editing Tools: VisualEditor: Langage inspector UI is broken in Betalabs , missing the Direction field - 10https://bugzilla.wikimedia.org/68180 (10ryasmeen) [18:19:59] edsanders, did you have a chance to take a look at https://gerrit.wikimedia.org/r/#/c/146640/ ? I'm open to solving this in a different way [18:38:47] James_F: Mediterrenean [18:41:27] kaldari: Kk. [18:41:49] kaldari: As-is or customised? :-) [18:48:07] 3VisualEditor / 3Editing Tools: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:... [18:57:21] (03PS1) 10Trevor Parscal: Dialog title alignment and iframe size fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/147179 [19:08:19] (03PS1) 10Cmcmahon: [BrowserTest] support for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147187 [19:08:45] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147187 (owner: 10Cmcmahon) [19:10:12] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] support for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147187 (owner: 10Cmcmahon) [19:10:46] (03Merged) 10jenkins-bot: [BrowserTest] support for Chrome [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147187 (owner: 10Cmcmahon) [19:10:55] (03PS2) 10Jforrester: Dialog title alignment and iframe size fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/147179 (owner: 10Trevor Parscal) [19:16:11] (03CR) 10Jforrester: [C: 032] Dialog title alignment and iframe size fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/147179 (owner: 10Trevor Parscal) [19:16:54] (03Merged) 10jenkins-bot: Dialog title alignment and iframe size fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/147179 (owner: 10Trevor Parscal) [19:17:37] TrevorParscal: https://gerrit.wikimedia.org/r/147193 pls. [19:21:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Langage and Special Character inspectors' UI is broken, and dialog titles are not correctly aligned - 10https://bugzilla.wikimedia.org/68180#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Trevor Parscal Fixed in gerrit 14717... [19:32:50] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] None of the cite options or template dialogs are opening, throwing error:Uncaught TypeError: Cannot read property 'bind' of undefined - 10https://bugzilla.wikimedia.org/67814#c9 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production. [19:36:37] 3VisualEditor / 3Editing Tools: VisualEditor: Clicking on "Make full size" switches to Custom tab, keeping the default size and not making it full size on the first attempt for all kind of images - 10https://bugzilla.wikimedia.org/66863#c16 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [19:38:54] 3VisualEditor / 3Editing Tools: VisualEditor: "Make full Size" is not enabling "Apply changes" button therefore cannot make any image fullsize - 10https://bugzilla.wikimedia.org/67624#c3 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [19:41:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] In iOS Safari, cannot open any page as it throws error "Error,can't load section" - 10https://bugzilla.wikimedia.org/67508#c7 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [19:44:04] <_ob> Hi all! [19:44:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389#c2 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [19:44:23] <_ob> We have developed a math plugin for ve and want to contribute it. [19:44:35] James_F, ^ [19:44:39] <_ob> How to proceed, e.g. initiate code review [19:44:42] Hi _ob. Who is 'we'? [19:44:51] <_ob> Substance.io [19:45:00] <_ob> and Adam Hyde from booksprint [19:45:02] Do you know about the Wikimedia Git repositories? What about Gerrit? [19:45:12] <_ob> I know the repos [19:45:17] <_ob> not about gerrit [19:45:29] Gerrit is our code review system [19:45:32] <_ob> ok [19:45:43] It's used by nearly all public Wikimedia code [19:45:50] <_ob> ok [19:46:01] http://www.mediawiki.org/wiki/Gerrit has some useful info [19:46:14] <_ob> ok.. i have a look… thanx! [19:46:50] There's a very, very short tutorial for getting started here: http://www.mediawiki.org/wiki/Gerrit/Getting_started [19:47:11] Good if you already know Git and have git-review installed [19:48:35] much more detail is available at the pages linked there and http://www.mediawiki.org/wiki/Gerrit/Tutorial if you need it [19:49:29] <_ob> ok… I need some time to read ;) [19:50:32] yeah, don't bother with the long version if you don't need it [19:50:55] let me know if you have any questions/issues [19:51:09] <_ob> I'll do! thanx! [19:53:22] James_F, eh, I'm getting the annoying 'uselang' error from the API again... I'm trying to bypass, but it's eating most of my api requests. [19:53:36] _ob: have a look at https://www.mediawiki.org/wiki/Extension:Math. The math extension contains a VE plug-in [19:53:54] so it's a good way to understand how to contribute a ve plug-in via an extension [19:54:08] mooeypoo, error from it? [19:54:16] uselang should give a warning [19:54:28] Krenair, the response is "warning -> something something" instead of what should be "response -> something else" [19:54:29] If it's making some error fatal, please tell me the details [19:55:01] it's not really fatal, it's just not giving me back any details.. [19:56:50] I'm having another bug thta I"m trying to figure out before I can give you more details, Krenair [19:56:56] my promises are going wild [19:57:07] <_ob> mvolz: we have seen that. but were not happy with it. the existing is a server-side extension, right? [19:58:15] It has some client-side code there too [19:58:35] Krenair, I'm sending an API request through "ve.init.target.constructor.static.apiRequest( ... )" and the response I'm getting is 'warnings->main->*->"Unrecognized parameter: 'uselang'" [19:58:56] if you resend the request without uselang= is the response different? [19:59:00] but I don't have uselang in my data [19:59:05] I don't have uselang in there at all [19:59:13] I know [20:00:23] <_ob> krenair: maybe I should see how our plugin could enhance the existing one? [20:00:31] perhaps [20:01:03] Krenair, I don't understand what you mean? [20:01:21] if I get the same API request directly in the browser (no uselang) I get a proper response [20:01:42] what is the request? [20:01:49] let me push the code, hang on [20:02:01] (03PS1) 10Mooeypoo: [WIP] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 [20:02:26] Krenair, https://gerrit.wikimedia.org/r/#/c/147219/1/modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js line 100 [20:02:33] or rather line 111 [20:02:39] <_ob> krenair: BTW, we started a table plugin… Should I be aware of an existing one (particulary, client-side)? [20:03:33] _ob: I wasn't offering it as an alternative to yours, more that that's how one would contribute a VE plug-in to gerrit :) I'm not sure to what extent it is server side. [20:03:45] an extension can provide purely client side code as well [20:03:59] <_ob> ok… i see [20:04:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (owner: 10Mooeypoo) [20:05:06] I don't know much about the existing math extension except that it has a VE plug in :) there aren't many other examples at present except for my extension which is pretty badly formatted at this point, so not a good example :) [20:05:10] _ob, I'm aware of http://www.mediawiki.org/wiki/VisualEditor_gadgets#Adding_a_table but that's it [20:05:24] I would take a look at http://www.mediawiki.org/wiki/VisualEditor/Design/Table_editor if I were you [20:05:54] _ob: a table plug-in would be awesome!! [20:06:20] <_ob> mvolz: will be there in 2 weeks ;) [20:06:26] can't wait! [20:07:48] <_ob> BTW, do you have a concept for an additional custom context? … the global one which is used for annos and focussables should not be touched, as it still is necessary within cells. [20:08:03] <_ob> 'context' ~ e.g. DesktopContext [20:08:33] mooeypoo, so if I compare http://www.mediawiki.org/w/api.php?action=query&prop=imageinfo&indexpageids&iiprop=size|mediatype&titles=File:Flow_topic_with_hover.png with http://www.mediawiki.org/w/api.php?action=query&prop=imageinfo&indexpageids&iiprop=size|mediatype&titles=File:Flow_topic_with_hover.png&uselang=de there's not much difference [20:11:54] Hey. [20:12:02] _ob: Hi there. [20:12:18] <_ob> James_F: hey! [20:14:18] <_ob> BTW, I will attend Wikimania's hack days… some of you guys there? [20:14:49] _ob: shouldn't have said purely client side, just mostly client side. there will be some boiler plate stuff you'll need to do to hook it in to mediawiki :) [20:15:13] _ob, yes [20:15:21] _ob: I'll be there [20:15:33] <_ob> krenair, mvolz: cool! [20:15:51] _ob, I -think- most of us will be. [20:16:02] James_F will be there too, I'll just go ahead and speak for him [20:16:03] also [20:16:06] James_F: TEMPLATE DATA [20:16:07] :) [20:16:18] _ob: We used (2 years ago) to have floating context on text, and we had to kill it because of needs for mobile interfaces. [20:16:41] <_ob> nice - we will work on several plugins in the next months. Can't wait to meet you in person ;) [20:17:01] _ob: So we have context (DesktopContext) which is only for direct-action tasks on the current select/context, which is sub-optimal. [20:17:10] _ob: Would love to talk at length about this. :-) [20:17:23] mvolz: Yes ma'am. Let's talk. What are your thoughts? [20:17:39] And yes, we're all going to be at Wikimania. [20:17:54] Krenair, so what causes the bug? I'm getting an error [20:17:57] <_ob> Actually, I need to learn who is all first ;) [20:18:25] mooeypoo, I haven't seen the bug reproduced [20:18:32] found it [20:18:39] I'm stupid -- *BUT* I found a bug [20:19:01] Krenair, so, I'm working through the new computer, with a new installation of mw, in which, apparently, I forgot to enable commons API [20:19:05] _ob: https://www.mediawiki.org/wiki/Editing/Team#Editing [20:19:20] mooeypoo: Ha. [20:19:24] Krenair, so the response you get from mediawiki.org is fine, but the SAME thing in my localhost/wiki is warning [20:19:31] heh. [20:20:17] I'll fix it by using commons, but if this mean the uselang error is appearing on local repos, that's not very good either [20:21:07] Yeah... [20:21:18] uselang does change things in some contexts [20:21:33] But the *current* version of the API does not recognise it, and warns about this [20:22:04] That said, https://www.mediawiki.org/wiki/Requests_for_comment/API_roadmap#Support_uselang :) [20:22:26] Krenair: Yeah, but until then it'd be nice to suppress some of the warnings to users. [20:22:31] wait... wtf... I have $wgUseInstantCommons = true; [20:22:53] James_F: so I guess the major design decision would be whether to let template data take arbitrary params how rather than having a specific citoid parameter to list the translated item [20:23:00] the former is harder [20:23:02] That should've worked, then. Why do I get errors in my local wiki :\ [20:23:08] the latter involves potential mission creep [20:23:23] mvolz: Yeah. [20:23:38] mvolz: I worry about the former, though. [20:23:38] where we have an every exploding amount of special fields for special interests [20:23:48] the former could lead to um, unexpected results [20:23:50] * James_F nods. [20:24:04] yeah so basically that [20:24:13] have you talked to Krinkle at all about this? [20:24:15] One of the things that's been proposed (and will be discussed at Wikimania) is coming up with "the" list of cite parameters. [20:24:38] Not really; mostly with TrevorParscal who helpfully isn't here right now. (Yay meetings.) [20:24:48] (indeed) [20:25:12] okay. I briefly broached it with him like a month ago and he seemed very surprised that that was direction we were going in :) [20:25:27] Ha. [20:25:48] but I don't really see any alternatives [20:25:52] mvolz: Well, maybe we can talk about it in Wikimania, but you need to make a decision before then. [20:26:00] Krenair, meh, any ideas? I have $wgUseInstantCommons = true; in LocalSettings, and I'm still getting a warning without api response [20:26:16] mvolz: We could have /another/ system? Mapping Citoid<->specific templates' TemplateData. [20:26:22] mvolz: But that feels very fragile. [20:26:27] mooeypoo, clear cache, etc.? [20:26:30] yeah I was just about to say that [20:26:37] but, from a user perspective, pretty annoying [20:26:42] Krenair, the setting in LocalSettings was there from the beginning [20:26:44] but I'll try [20:26:46] mvolz: Yeah. [20:26:51] because basically will involve copying things you already wrote [20:26:59] mooeypoo, check the debug log as well [20:27:02] however, as an interrum solution, I could fork TemplateData [20:27:02] But only for ~4 templates [20:27:10] Eww. [20:27:11] and then if it turns out to be a mess no harm done. [20:27:14] no? [20:27:30] Well, harm done == mvolz wasting her time. :-) [20:27:33] But maybe. [20:28:05] mvolz: Want to try to co-write this in http://etherpad.wikimedia.org/p/citoid-TD-fun ? [20:28:35] ok [20:38:12] Krenair, http://pastebin.com/B8F27aCL [20:38:15] :\ [20:38:47] mvolz: Could we use TD's sets? [20:39:12] mvolz: So have named sets called citoid-URL which lists the members? [20:39:32] mooeypoo, okay, that's good [20:39:43] it runs on mediawiki.org which is where that file is hosted [20:40:02] Krenair, so why the error, while the error isn't there in mediawiki.org ? [20:40:51] Krenair, since all I really need is size considerations (I don't care bout language) I am thinking of replacing the 've.init.target.constructor.static.apiRequest(' with $.ajax call [20:41:09] James_F: I am not familiar with that param [20:41:22] mvolz: It's currently not really used. [20:41:30] Krenair, but either something's wrong with how that api request is done, or I'm missing stuff? [20:41:38] that sounds like a good avenue to explore :) [20:41:46] I'll let you fill out that section :D [20:41:49] mvolz: It's meant to let you group params together. [20:42:02] arbitrary params? [20:42:09] mooeypoo, that response you posted is exactly what I would expect [20:42:13] mvolz: But we could create citoid- sets to define which TD parameters map to what. [20:42:21] The file does not exist, so you get missing="" imagerepository="" [20:42:29] mvolz: Arbitrary groups, they have to consist of actual parameters. [20:42:38] An unrelated possibly-but-maybe-not issue is it moans about uselang. This is not an error. [20:42:57] eh I'm getting this with images that DO exist though [20:43:01] wait [20:43:04] let me find one [20:43:42] hm [20:43:45] if you think that would work that sounds great! [20:44:21] Krenair, ok, with an image that does exist I'm still getting the 'uselang' error BUT I also seem to be getting a response. Now I need to check why that response isn't passing correctly in my code, it seems [20:47:01] mvolz: It looks plausible. [20:47:04] James_F: on the other hand that is absolutely hideous [20:47:06] :) [20:48:25] but at least in the short term I am a big fan of not having to modify template data even if the result is hideous template data. might be short sighted though. [20:48:36] mvolz: Yeah. [20:48:47] * James_F will ask TrevorParscal's and Krinkle|detached's advice. [20:48:58] James_F: that would be great [20:49:09] I think the etherpad lays it out pretty well [20:57:28] <_ob> Folks, I will continue my plugin contribution mission tomorrow…. see u! [21:08:22] (03PS2) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 [21:10:08] meh, now I'm having problems with node and grunt [21:10:10] (03CR) 10jenkins-bot: [V: 04-1] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (owner: 10Mooeypoo) [21:10:38] The upstream name for the Node.js interpreter command is "node". [21:10:38] In Debian the interpreter command has been changed to "nodejs". [21:10:56] Well that's just lovely. Grunt won't install because of this, and Parsoid's "npm start" doesn't work [21:11:00] * mooeypoo grunts [21:14:00] mooeypoo, I think I ended up symlinking or something [21:14:33] hmm that's a good idea, if I knew what to what [21:15:41] it's in /usr/bin/nodejs I believe. Krenair where do I put the symlink ? [21:16:44] well you want /usr/bin/node -> /usr/bin/nodejs [21:16:58] shouldn't this also work with an alias? [21:19:52] Looks like I have lrwxrwxrwx 1 root root 22 May 11 2013 /usr/bin/node -> /etc/alternatives/node [21:20:01] Krenair, okay, now parsoid's "npm start" works, but when I run "npm install" in VE and in liv/ve nothing happens [21:20:13] and grunt is missing. ehhh. [21:20:16] `update-alternatives --display node` shows "link currently points to /usr/bin/nodejs" [21:20:25] hmmm' [21:22:30] and on my laptop I literally just have a symlink pointing /usr/bin/node to /usr/bin/nodejs [21:24:38] Krenair, 'npm install' in both VE folders doesn't work [21:24:40] * mooeypoo grunts [21:24:50] it just shows me an empty line [21:27:20] mooeypoo: you can install nodejs-legacy to get he 'node' symlink [21:28:16] hm, it seems it's a bigger issue than "just" that symlink [21:28:29] I added it myself and some things work (like Parsoid) but some don't [21:28:32] so i'm not sure [21:32:39] (03PS3) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 [21:33:34] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c6 (10Alex Monk) Does this still happen? I was... [21:34:34] (03CR) 10jenkins-bot: [V: 04-1] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (owner: 10Mooeypoo) [21:35:14] waa. I need grunt [21:36:40] (03PS4) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 [21:41:08] (03PS5) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 [21:51:59] mvolz: Hey, TrevorParscal and I fiddled and feel that option #4 is best. [21:52:03] mvolz: What do you think? [21:52:13] mvolz: (See http://etherpad.wikimedia.org/p/citoid-TD-fun for a worked-up example.) [22:00:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Remove button for the link inspector in mobile is not styled as Red - 10https://bugzilla.wikimedia.org/68194 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15962 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15962&action=edi... [22:05:45] James_F: we need to get ohohjayess.com :) [22:06:17] TrevorParscal: That sounds expensive. [22:06:39] TrevorParscal: Also ooh-ooh-ewe-eye.com [22:06:55] you know, it's a small price to pay for pronunciation clarity [22:08:34] hey James_F and TrevorParscal [22:08:39] Hey kaity. [22:09:16] did the link inspector ever open search right away when you created a link? [22:09:41] kaity: It did, but it tested poorly and caused a lot of bugs, so we got rid of it a couple of months ago. [22:10:18] James_F: oh ok cool [22:11:37] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobile VE 2.Open... [22:14:00] James_F: I just looked back at usertesting, the last test did pull the search immediately, so it will be good to test the link inspector again with all the recent changes [22:15:48] kaity: Sounds good. [22:16:13] kaity: we need to add an icon to the search input so it is clear that there are search results available [22:16:39] the main problem we have now, that we don't show it automatically, is that the user doesn't realize it's a search interface [22:16:56] TrevorParscal: yes thats what Im thinking too [22:17:38] TrevorParscal: Though I wish we could still show it right away, is there another way we could do that? [22:18:38] James_F: definitely the most extensible [22:19:26] a little intimidating though [22:21:22] not exactly sure that the function of the inputs would be? [22:21:37] imputs param* [22:22:02] kaity: i'm actually working on a patch that adds icon/indicator support to TextInputs so it will be a 1 line change to add a search icon [22:22:09] or a down arrow, or whatever [22:22:26] TrevorParscal: yea I think a search icon would be good [22:22:32] yup [22:22:47] lookup input widget (which the link widget is based on) will have a search by default [22:22:54] just gotta finish the patch [22:24:51] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS ,while opening the link inspector for the second time, the inspector gets zoomed making the inspector title overlapped with the browser tab - 10https://bugzilla.wikimedia.org/68197 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 159... [22:26:37] mvolz: For citoid it should reflect which fields should be retained "untouched". [22:27:24] mvolz: For example, if citoid detects that the user has given it a URL, it should use the link as given by the user to populate the field that "URL" inside citoid maps to, rather than modifying it. [22:27:41] mvolz: For other services, they may do something less magic and need to know what their inputs are. [22:27:45] mvolz: Does that make sense? [22:27:52] ah, I see [22:29:50] mvolz: I also think that TemplateData should maintain 'correctitude' in the user input. [22:30:02] ? [22:30:50] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS ,while opening the link inspector for the second time, the inspector gets zoomed making the inspector title overlapped with the browser tab - 10https://bugzilla.wikimedia.org/68197#c1 (10ryasmeen) Created attachment 15965 --> https://bugzilla.wikimedia.or... [22:31:05] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS ,while opening the link inspector for the second time, the inspector gets zoomed making the inspector title overlapped with the browser tab - 10https://bugzilla.wikimedia.org/68197#c2 (10ryasmeen) Created attachment 15966 --> https://bugzilla.wikimedia.or... [22:31:22] mvolz: So not only must 'services' map to an object, but each of the keys in the object should map to an object with the keys inputs which maps to an array of valid parmaters and outputs which maps to a set of keys which map to a parameter, an array of parameters, an array of arrays of parameters, or a set of items which map to parameters. [22:31:54] mvolz: I.e., for each of the cases listed in the example you can't make up invalid parameters (but the names for the service are assumed to be correct). [22:31:57] mvolz: Does that work? [22:32:37] mvolz: Also, have you had any thoughts about how to do template selection? "Best fit" or something, perhaps? [22:33:26] right now, .json message in mediawiki space with equivalencies like with citation tool [22:33:40] although again has its issues [22:33:45] re: above, still processing :) [22:33:49] * James_F nods. :-) [22:34:12] How would you know that a URL that returns an ISBN in its set should be cite_web or cite_book, for instance? [22:34:47] Bah, back in a bit. [22:34:52] ok [22:35:40] right now the key is the zotero type, and the value a citation template the admin would define [22:36:19] there's no default behaviour for if a citation type isn't defined [22:36:35] currently just use the general "Template:Citation" on localhost for those types [22:37:24] but we could even return a formatted citation in html if there's no template listed for a type. Particularly easy with zotero responses. [22:38:02] TrevorParscal: It would be good to include the link icon somewhere in the link inspector interface [22:38:19] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c7 (10Alex Monk) So for adding these to the page settings controls, it should now just be a case of adding the new messages and using them as the... [22:38:25] might be a good idea anyway. I've been looking a bit at German wikipedia and they tend to just use bare citations. argh so many use cases [22:38:29] TrevorParscal: Maybe if we dont have it by the titles, we could use the link icon in place of the checkmark? [22:44:52] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression pre-wmf15]The highlights of the nodes are appearing over the toolbar menu - 10https://bugzilla.wikimedia.org/68198 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15967 --> https://bugzilla.wikimedia.org/attachment.cgi?id=159... [22:46:14] mvolz: Yeah, but lets try to use templates if at all possible (it makes editing for downstream users much easier and more consistent). [22:46:50] mvolz: But that a seems reasonable situation (zotero type -> template mapping). [23:14:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: The "Go back" button in use existing reference dialog in mobile takes to Basic Reference dialog - 10https://bugzilla.wikimedia.org/68201 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with mobile VE 2.Select the option "... [23:14:48] James_F, so I marked https://bugzilla.wikimedia.org/show_bug.cgi?id=67845 as a dupe of https://bugzilla.wikimedia.org/show_bug.cgi?id=21798 [23:15:04] And it doesn't sound easy to me, unless I'm missing something obvious [23:16:42] Krenair: Seems like this is something Parsoid might care about (malformed quasi-HTML)? But yeah, not easy… [23:17:14] I wonder how it's i18n-related as well [23:18:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: The "Go back" button in use existing reference dialog in mobile takes to Basic Reference dialog - 10https://bugzilla.wikimedia.org/68201#c1 (10ryasmeen) Created attachment 15969 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15969&action=edit Screenshot... [23:18:31] Krenair: Ask Nemo, he's the one that added it. [23:19:54] Krenair: (I think it doesn't.) [23:20:23] You think it doesn't make sense to be marked as i18n? [23:20:33] Yeah. [23:21:01] Bah, have removed. [23:21:14] Hmm... [23:21:56] At this point it looks like I've at least commented on things I was going to do, and everything is awaiting response from other people [23:22:03] * James_F nods. [23:22:28] I would ask for more suggestions now, but it's past midnight and I'm tired [23:22:49] Yeah, go away. :-) [23:28:13] 3VisualEditor / 3Editing Tools: VisualEditor: No Language selected in the Language Selector shows “$1” - 10https://bugzilla.wikimedia.org/68202 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 15970 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15970&action=edit Screensho... [23:28:24] 3VisualEditor / 3Editing Tools: VisualEditor: No Language selected in the Language Selector shows “$1” - 10https://bugzilla.wikimedia.org/68202 (10Ritu Swain) s:5normal>3minor [23:29:24] 3VisualEditor / 3Editing Tools: VisualEditor: No Language selected in the Language Selector shows “$1” - 10https://bugzilla.wikimedia.org/68202#c1 (10Ritu Swain) Tested on test2.