[00:10:20] 3VisualEditor / 3Editing Tools: VisualEditor: No Language selected in the Language Selector shows “$1” - 10https://bugzilla.wikimedia.org/68202#c2 (10ryasmeen) 5UNCO>3NEW Yes, happening in Betalabs as well. [00:14:44] (03PS2) 10JGonera: WIP: Handle touch events in toolbars and toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/146640 [00:24:23] (03PS1) 10MaxSem: HHVM compatibility: objects don't have array-like interface [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/147349 (https://bugzilla.wikimedia.org/66937) [00:30:21] (03PS2) 10Ori.livneh: HHVM compatibility: objects don't have array-like interface [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/147349 (https://bugzilla.wikimedia.org/66937) (owner: 10MaxSem) [00:30:28] (03CR) 10Ori.livneh: [C: 032] HHVM compatibility: objects don't have array-like interface [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/147349 (https://bugzilla.wikimedia.org/66937) (owner: 10MaxSem) [00:30:48] (03Merged) 10jenkins-bot: HHVM compatibility: objects don't have array-like interface [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/147349 (https://bugzilla.wikimedia.org/66937) (owner: 10MaxSem) [00:38:20] 3MediaWiki extensions / 3TemplateData: HHVM: TemplateDataBlobTest::testGetDataInLanguage fails with "Invalid operand type was used: expecting an array" - 10https://bugzilla.wikimedia.org/66937 (10Ori Livneh) 5PATC>3RESO/FIX [01:03:26] (03PS7) 10Trevor Parscal: [WIP] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [01:04:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [01:04:24] (03PS8) 10Trevor Parscal: [WIP] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [01:05:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [08:57:56] (03PS11) 10Mooeypoo: Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [08:59:22] (03CR) 10jenkins-bot: [V: 04-1] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [09:32:34] (03PS1) 10Mooeypoo: ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 [09:33:17] (03CR) 10jenkins-bot: [V: 04-1] ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [10:03:52] (03PS12) 10Mooeypoo: Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [10:04:45] (03CR) 10jenkins-bot: [V: 04-1] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [10:12:37] jgonera seems sensible to me [10:13:05] could call it onPointerDown? [10:20:36] 3OOjs UI: OOjs UI: Large dialog doesn't resize correctly when window is enlarged - 10https://bugzilla.wikimedia.org/68213 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3Trevor Parscal 1. Shrink your window to mobile width and open the help dialog in VE standalone 2. Observe the help dialog is full screen 3... [10:53:16] (03CR) 10Esanders: "I wasn't aware you broke it. DAMN YOU TREVOR. I could go either way on inspector vs dialog but it shouldn't be difficult for us to provide" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [11:00:31] (03PS1) 10Vikassy: [BrowserTest] Fixed failing Media Icon tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147413 [11:01:11] (03PS2) 10Vikassy: [BrowserTest] Fixed failing Media Icon test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147413 [11:22:14] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fixed failing Media Icon test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147413 (owner: 10Vikassy) [11:24:16] (03Merged) 10jenkins-bot: [BrowserTest] Fixed failing Media Icon test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147413 (owner: 10Vikassy) [12:28:15] (03PS1) 10Vikassy: [BrowserTest] Updated random page step to language screenshot page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147425 [12:33:34] 3VisualEditor / 3Editing Tools: VisualEditor: Improve the message for parameters that have no TemplateData - 10https://bugzilla.wikimedia.org/56889 (10Andre Klapper) [12:36:41] (03PS2) 10Vikassy: [BrowserTest] Updated random page step to language screenshot page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147425 [12:44:51] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Updated random page step to language screenshot page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147425 (owner: 10Vikassy) [12:46:46] (03Merged) 10jenkins-bot: [BrowserTest] Updated random page step to language screenshot page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147425 (owner: 10Vikassy) [12:47:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/145622 (owner: 10Jforrester) [12:49:39] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo) [13:30:52] (03CR) 10Alex Monk: "Trevor, what happened here?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [15:27:56] hi mvolz, James_F|Away. question about Citoid plans... [15:28:20] hey [15:28:29] is the idea that url lookups will work from all the citation types that have url field? [15:29:03] or will it be like the gadget, where there's a specific option for using Citoid, but it won't be available via Cite>Journal? [15:29:16] so, the UI isn't set in stone yet [15:29:41] we're still requesting comment at https://www.mediawiki.org/wiki/VisualEditor/Design/Reference_Dialog [15:29:51] including what is already available in the citation dialog [15:30:03] https://www.mediawiki.org/wiki/Talk:VisualEditor/Design/Reference_Dialog rather [15:31:10] [Book ISBN or Web address] <- YES! [15:32:30] (I also look forward to the design looking more like the Agora stylings in those mockups!) [15:35:43] (03PS1) 10Esanders: Update context menu according to stricter rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147498 [15:36:44] (03CR) 10Esanders: "Fixed core in Id5d1dbb367d" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [15:37:01] (03PS3) 10Esanders: Keep focus when live editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) [15:49:39] mvolz or anyone: is the current plan to change from "Cite" to the book icon and "Add reference" as the ways of getting to the references? [15:50:28] I'm trying to come up with a prose explanation of how to add a citation in VE, but I'm not sure which terminology or iconography will be there in a few months. [15:51:20] (03PS1) 10Esanders: Ignore staging events in CE surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147501 (https://bugzilla.wikimedia.org/67326) [15:52:09] (03Abandoned) 10Esanders: Keep focus when live editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/145442 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [15:55:11] ragesoss: add reference has already been removed [15:55:20] it's now under the "cite" tab [15:55:24] as "cite basic" [15:55:47] okay. so "Cite" is probably going to be the long-term thing to click in the toolbar as a starting point? [15:56:14] not really sure :) James_F|Away / TrevorP|Away might have a better idea [15:57:30] James_F, ^ [15:58:27] speaking of which, TrevorP|Away, I am having sad consequences with the way the citation tool inspector determines which citation type it is [16:01:36] ragesoss: Yes. [16:05:10] cool, thanks [16:09:11] James_F: do you know if the "special" programming for cite book, web, journal, and news are part of the long term plans? [16:09:39] James_F: will "Apply changes" become something more specific for adding citations? [16:11:11] ragesoss: Inserting? Yes, it does in the new dialog system coming soon. [16:11:39] is that wording set? "Insert" or the like? [16:12:26] mvolz: Eh. A JSON file in the MediaWiki: namespace is a complete hack, but until we have a magic system that "knows" citations I'm not sure what else we can do. [16:12:40] James_F: I suppose if I say "and insert it", that will be clear enough even if the dialog they see is different. [16:12:49] ragesoss: Yeah, it says "Insert reference" or "Insert citation" right now. [16:14:22] James_F: here's what I came up with as general instruction for citing sources with VE, intended for newcomers 3 months from now: [16:14:23] To add a citation using VisualEditor: [16:14:23] Move your cursor to the end of the block of text you want to cite a source for. [16:14:23] Click "Cite" in the toolbar. [16:14:23] For a book, add the ISBN. For an online source, add the URL. (There are options for sources with neither an ISBN or a URL.) [16:14:23] Add any other key information, such as the page number(s) for a book, and insert the citation. [16:14:26] James_F, btw, I've been working on the comment inspector, and managed to get it to work partially. I'll need Trevor's help -- the inspector doesn't work right (it appears but doesn't open) which I assume is due to the changes made by his huge dialog change, but I can't manage to get it to work. [16:14:52] Sufficiently vague to cover both the current experience and the expected citoid one? [16:15:16] James_F: I get pretty good results with the system that takes arbitrary cite templates, I've installed one. The only thing it doesn't do, which I guess is important, is open up the fields available directly into the dialog. that's the part of the code that's wreaking havoc over here :) [16:15:33] ragesoss: I think they're may just be a single "cite by id" dialog at least initially [16:15:44] Yeah. [16:16:02] and that may get replaced by something that takes arbitrary input [16:16:04] James_F: mvolz: yeah, but what that ID is will vary by source type. [16:16:07] mooeypoo: Nice. TrevorP|Away's out today but yeah. [16:16:13] oh. shoot. [16:16:30] if someone knows to try either an isbn or url, they can probably figure out where to put it (both in the current default and the citoid future) [16:16:35] ok, I'm trying to wrestle with the inspector, but while it does pop up, it won't actually open. [16:18:08] Hey James_F: TrevorP|Away was showing us some of the latest oojs stuff in a nice demo yesterday. Where might I find that? [16:18:55] rmoen: MW-core right now. [16:19:16] rmoen: But if you check out oojs/ui.git and look at the demos directory it may be helpful. [16:19:30] James_F: yes the demo would be very helpful [16:19:40] James_F: The demo lives in core under what path? [16:19:54] rmoen: 'demos'. [16:20:42] rmoen: http://git.wikimedia.org/tree/oojs%2Fui.git/HEAD/demos [16:20:55] James_F: can we assume that if i'm asking where things are i need a better answer than 'demos' ? [16:21:05] thank you thoug [16:21:30] rmoen ! ltns. All good on your end I hope? [16:21:47] hi mooeypoo :) [16:22:08] :) you're still in SF ? [16:22:22] mooeypoo: until Sunday afternoon. Then back to Portland [16:23:03] Nice :) [16:23:18] Are you going to be in Wikimania this year? [16:31:53] mooeypoo: unfortunately no. I was not approved to goto any events this year. [16:33:33] aw, I was hoping to say hi in person. [16:33:36] Well, next time :) [16:48:21] 3VisualEditor / 3Technical Debt: VisualEditor: Nicer removal of Cite.php's class=error - 10https://bugzilla.wikimedia.org/51141 (10James Forrester) a:3Alex Monk [16:49:06] 3VisualEditor / 3Technical Debt: VisualEditor: Add "role" attributes to UI elements where appropriate - 10https://bugzilla.wikimedia.org/50203#c1 (10James Forrester) a:3Alex Monk Most of this has already been done in OOUI, I think. [16:49:51] 3VisualEditor / 3Editing Tools: VisualEditor: When adding a new template, if the template has no mandatory parameters, auto-open the "add parameter" window and put the cursor in the search dialog's input - 10https://bugzilla.wikimedia.org/55925 (10James Forrester) a:5Trevor Parscal>3Alex Monk [16:59:34] (03CR) 10Jforrester: Refactor TemplateData Editor (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo) [17:03:07] (03PS1) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [17:07:20] mvolz: What direction who's going in with what :D ? [17:11:22] I'm planning to turn TemplateData into an extension that inserts ascii cats into every page. [17:11:25] hop you don't mind. [17:11:33] hope* [17:11:41] possibly bunnies too. we'll see. [17:32:09] (03PS2) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [17:47:22] (03PS3) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [17:47:54] (03CR) 10Krinkle: "Using 'dots' as reporter to perhaps reduce the console output a bit (on an interactive Terminal it rewrites the lines, but on Jenkins it j" [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [17:54:15] There, automated proof oojs works on IE6 [17:54:20] :-) [18:00:13] would this have been an especially bad time to update ve? because my install is now all sad panda :( [18:00:23] oojs.js is throwing errors :( [18:12:07] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created... [18:17:54] hey James_F [18:18:05] Hey kaity. [18:18:36] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should prevent identically-named parameters (and aliases) - 10https://bugzilla.wikimedia.org/51406 (10James Forrester) a:3Alex Monk [18:18:51] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860 (10James Forrester) a:5Krinkle>3Alex Monk [18:18:51] James_F: I know I'm sending lots of emails! We can talk about stuff in person on monday if thats better to get feedback [18:19:04] kaity: That might be easier, yeah. :-) [18:19:21] kaity: Want me to grab a half hour? [18:19:32] James_F: sure [18:19:46] Is Trevor available? [18:19:56] I'll find a time that he is. [18:20:32] Thanks James_F! [18:22:06] mvolz: Can you be more exact than throwing errors? Where are you seeing errors? Is oojs itself failing or is something calling it incorrectly? [18:27:33] Krinkle: don't think it's related to anything recent because I just rolled back to my old version and still having the same issues [18:28:12] similar* [18:29:22] argh what did I do to my install [18:37:05] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223#c1 (10ryasmeen) This is also happening for Language inspector... [18:45:37] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15973 --> h... [18:46:16] edsanders: BTW could you do the ceil() fix if it's trivial? :-) [18:46:33] I'll have a go [18:46:44] Cool. Seemed like you knew exactly what to fix. [18:52:10] (03PS4) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [18:54:30] (03PS1) 10Esanders: Round up height of language inspector widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147550 [19:11:07] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3Alex Monk Created attachment 15974... [19:38:38] 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15976 -->... [19:55:12] James_F, so I started looking into this officewiki weirdness [19:55:24] Krenair: Any luck? [19:55:32] ve.init.mw.Target.onSave is expecting a plain response object [19:55:53] OK. And it's not? [19:56:11] On officewiki, this appears to be a jqXhr object... Whose responseJSON property is what we really want [19:56:22] edsanders: Do you feel you're in a place to make the agreed changes to ProcessDialog? [19:56:34] Krenair: Ah. Interesting. Config issue? [19:56:54] I don't think so... The network request itself looks fine. [19:57:05] Something about the way we're handling it... [19:57:36] ... omg, James_F [19:57:40] O. M. G. [19:57:43] This stuff touches Target's tryWithPreparedCacheKey and the chain of deferreds it's using [19:57:54] James_F, Good news! I found out the bug that caused CommentInspector to not open! [19:59:27] Just a feeling here, but maybe when I create ve.ui.CommentInspector.js it should.. I dunno... be included in the VisualEditor.php list. It was when I worked on it last time, but that file is on the ve-mw side, so it wasn't automatically updated when I reviewed the change. So yes. Adding it there? It helps. [20:01:04] Krenair: Curious. [20:01:13] mooeypoo: Ha. :-) [20:01:44] James_F, I'm adding it now to the ve-mw side of that fix so this whole not-working mess won't happen again :P [20:02:14] (03PS5) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [20:02:26] mooeypoo: Does it work OK in the stand-alone? [20:02:38] seems to. I have a couple of bugs still with the actions [20:02:52] but it seems to at least throw errors this time, which was not true until now [20:04:21] mooeypoo: Kk. [20:04:51] (03PS1) 10Krinkle: build: Update grunt-jscs to 0.6.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/147633 [20:05:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [20:06:01] James_F, I think it might be a good idea to ask Krinkle what's going on within tryWithPreparedCacheKey [20:06:51] (03PS6) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [20:07:02] I think that ajaxRequest is returning jqXhr [20:07:11] (03CR) 10Krinkle: "Safari 5 is on OSX 10.6, not 10.7; https://saucelabs.com/platforms" [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [20:07:20] Which resolves with the response data, status and jqXhr [20:07:49] Krinkle: Ooh, thanks for the grunt-jscs-checker -> grunt-jscs change, it was bugging me. [20:07:54] Krinkle, this is VE returning "Unknown error" on officewiki btw. [20:07:59] Krenair: Yeah. [20:08:16] And then... Yeah I'm not quite clear how the chain of deferreds is working here. [20:08:47] James_F: The other dozen errors about engine version warnings are also bugging me. That'll hopefully be fixed soon when I finish the new Ubuntu Trusty images in labs for integration-slaves. [20:08:52] which run nodejs 0.10 [20:09:14] Krinkle: That'd be nice to get node 0.10, yeah. [20:09:46] Krinkle: Also "PhantomJS detected, but wrong version 1.9.0 @ /usr/bin/phantomjs. " too? [20:10:17] James_F: Nah, that's a false positive. [20:10:18] Krinkle: And is "WARN [PhantomJS 1.9.7 (Linux)]: Adapter did not report total number of specs." fixable? 'Cos "Executed 30 of 0 SUCCESS" isn't great. [20:10:56] James_F: Our servers have a global phantomjs install. npm always installs in local directory node_modules, but if the global one happens to be the same version, it'll forego downloading the phantomjs binary and just use that instead. [20:11:11] Ah, right. [20:11:19] We control the version in package.json of each repo, so that global install will never the right version for everyone. [20:11:36] (03CR) 10Jforrester: [C: 032] build: Update grunt-jscs to 0.6.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/147633 (owner: 10Krinkle) [20:11:43] James_F: "Adapter did not report total number of specs" is a bug in QUnit fixed in 1.15-alpha. To be released soon. [20:11:51] Right. [20:12:09] Well, I'd argue it's a bug in Karma (they assumed a feature that never existed). But it was easy to provide so that was figured out quickly. [20:12:19] * James_F grins. [20:12:26] The total number (30) is accurate. I don't know why they don't assume success+failures=total. [20:12:43] What if it never responds. [20:12:46] They want the test framework to count the tests ahead of time. Maybe something to do with their dots [20:12:52] Sent 40, got 20 passes, success! [20:12:54] James_F: Then the timeout is 1 failure. that's all you need to know. [20:13:11] Yeah. [20:13:12] if it fails Karma doesn't say 1 of 30 failed. It just says 1 failure. [20:13:27] (03Merged) 10jenkins-bot: build: Update grunt-jscs to 0.6.1 [oojs/core] - 10https://gerrit.wikimedia.org/r/147633 (owner: 10Krinkle) [20:13:40] Krinkle: Want me to do ^^^ for all the other repos? [20:13:42] It just assumes the test framework can give you an accurate total but also assumes it might now know how to assert they all ran. [20:13:45] James_F: Yeah :) [20:13:54] KK. I was meaning to do it anyway. [20:14:08] Which is silly, it shouldn't assume the test framework is stupid, especially if it still relies on the framework to provide the total. [20:14:09] oh well [20:16:28] (03PS1) 10Jforrester: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/147639 [20:18:12] (03PS1) 10Jforrester: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147642 [20:21:35] (03PS1) 10Jforrester: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147644 [20:24:07] Krinkle: ^^^ plus https://gerrit.wikimedia.org/r/147645 in MW-core. [20:24:43] James_F: mw-core is behind further, also doesn't use preset:wikimedia yet. [20:24:47] Can you do that in the same commit as well? [20:24:54] (and it's using rules in jscsrc that were removed in 0.6) [20:24:56] Krinkle: I could; I was going to do it in a follow-up. [20:25:15] Krinkle: It passed grunt, so on the principle of minimal splittable changes… [20:26:18] well, on the principle of not having tests pass with merely the illusion of the rules being enforced and passing, I'd recommend doing it one commit (or if you really want, upgrade to 0.6.0 first and then rename in another commit where it updates to 0.6.1 [20:26:50] * James_F sighs. [20:29:04] Krinkle: But fixing 2000 coding style violations makes me sad. [20:29:12] James_F: Nonono [20:29:23] Only remove the rules that became part of the preset. [20:29:29] Krinkle: … [20:29:29] Just like in oojs-ui and ve. [20:29:39] Look there for which we havent enforced there yet. [20:29:48] I did. [20:29:54] It's 2000 with those ones. [20:29:57] probably just indentation and and quotes [20:30:04] Any one in particular? [20:30:06] Specifically, disallowQuotedKeysInObjects and requireSpacesInsideArrayBrackets [20:30:24] Yeah, mostly indentation. [20:30:31] What's the disable for that one? [20:30:53] set them to null. [20:31:07] https://github.com/wikimedia/oojs-ui/blob/master/.jscsrc#L4 [20:31:21] https://github.com/wikimedia/VisualEditor/blob/master/.jscsrc#L4-L5 [20:31:38] Krinkle: " I did." [20:31:43] (03PS1) 10Alex Monk: Don't confirm if there's no changes when switching to edit source mode through the page options menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147646 (https://bugzilla.wikimedia.org/68229) [20:32:48] James_F, is there a bugzilla entry for the officewiki issue? [20:32:50] Krinkle: Down to 111 with requireCamelCaseOrUpperCaseIdentifiers and validateIndentation [20:32:55] Krenair: No, don't think so yet. [20:33:05] James_F: No I meant, any violation in particular. (the rules you get warnigns for) [20:33:21] Krinkle: " Yeah, mostly indentation.". [20:33:37] but that's disabled already now, right? [20:33:47] James_F, want to create one? :p [20:33:53] Yes, which is why we're down from 2000 to 111. [20:33:57] ok [20:34:01] Krenair: Can you? :-0 [20:34:23] k [20:39:40] Krinkle: Does parseFloat not require a radix the way parseInt does? [20:40:53] 3VisualEditor / 3MediaWiki integration: "Unknown error" on officewiki - 10https://bugzilla.wikimedia.org/68235 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None We get "Unknown error" (not internationalised) when saving on officewiki. This is because the response object given to ve.init.mw.Target.onSav... [20:40:56] James_F, done ^ [20:41:15] Krinkle: Ta. :-) [20:41:18] Bah. [20:41:19] Krenair: Ta. [20:41:21] * James_F sighs. [20:41:30] :D [20:41:49] James_F: In fact, parseFloat doesn't support a radix param at all [20:42:10] that would be consistent, right? [20:42:55] Krinkle: So, the parseFloat calls with a second parameter are doing what? [20:43:27] shit [20:43:28] nothing [20:43:32] >> parseInt.length [20:43:32] Krinkle: (number) 2 [20:43:35] >> parseFloat.length [20:43:36] Krinkle: (number) 1 [20:43:46] >> parseInt('101', 2) [20:43:46] Krinkle: (number) 5 [20:43:52] >> parseFloat('101', 2) [20:43:52] Krinkle: (number) 101 [20:44:01] OK, should I fix colorUtil then? ;-) [20:44:20] That'd be nice yeah [20:44:29] * James_F does so. [20:46:49] Krinkle: OK, done. [20:48:19] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should prevent adding identically-named parameters (and aliases) - 10https://bugzilla.wikimedia.org/51406 (10Alex Monk) [20:51:26] (03CR) 10Jforrester: [WIP] build: Implement Karma module for cross-browser unit testing (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [20:52:35] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [20:55:26] (03CR) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [20:57:16] (03CR) 10Jforrester: [WIP] build: Implement Karma module for cross-browser unit testing (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [20:58:07] James_F, since this is officewiki-only I don't think we can consider it major [20:59:18] Krenair: Just seen a report on a public wiki – http://www.mediawiki.org/w/index.php?title=VisualEditor/Feedback&offset=20140718034004&lqt_mustshow=45581#Useless_error_message_45581 [20:59:31] Oh, hmm, no, that's different. [20:59:56] Krenair: And "major" => impacts a significant number of users on a significant wiki. I think we can count it. :-) [21:00:23] But it's officewiki... [21:00:55] Presumably any private wiki. [21:01:01] There are a few. [21:01:35] meh, anyone knows how to get sublime to complete parentheses? It did that automatically in my other computer, but here it doesn't [21:01:38] Nope [21:01:43] Does not affect otrswiki [21:02:04] Krinkle, any idea how to get sublime to autocomplete parentheses? {} and () etc? [21:02:18] mooeypoo: It's a plugin I think. [21:02:26] mooeypoo: But I've switched to Atom so I'm no help. :-( [21:02:29] Oh, it is? I thought it was an automatic thing. [21:02:37] oh, how is Atom? Heard about it, but I think it's just for mac for no [21:02:38] now [21:02:56] The builds are just for Mac, yeah – but soon… :-) [21:03:25] indeed, I am waiting for it. Saw its preview, it looks great [21:03:30] James_F, doesn't affect collabwiki either [21:03:43] Krenair: Hmm. Very odd. [21:06:35] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c1 (10Alex Monk) p:5High>3Normal s:5major>3normal Does not affect other private wikis (checked otrswiki, collabwiki), not major/high priority. [21:07:01] Krenair: However, it's a catastrophic error for a key constituency, so… [21:07:11] ... It's officewiki. :| [21:07:16] Krenair: Exactly. [21:12:40] (03PS2) 10Mooeypoo: ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 [21:13:24] (03CR) 10jenkins-bot: [V: 04-1] ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [21:13:55] meh [21:14:13] damn that lib/ve reference. [21:25:43] (03CR) 10Krinkle: [C: 032] build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147644 (owner: 10Jforrester) [21:25:51] (03CR) 10Krinkle: [C: 032] build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147642 (owner: 10Jforrester) [21:26:03] (03CR) 10Krinkle: [C: 032] build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/147639 (owner: 10Jforrester) [21:28:01] (03Merged) 10jenkins-bot: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147644 (owner: 10Jforrester) [21:28:27] (03Merged) 10jenkins-bot: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/147639 (owner: 10Jforrester) [21:28:52] (03Merged) 10jenkins-bot: build: Update grunt-jscs (formerly grunt-jscs-checker) from 0.6.0 to 0.6.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147642 (owner: 10Jforrester) [21:32:34] (03CR) 10Krinkle: [C: 04-1] "$ ack '/test' -Q" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 (owner: 10Jforrester) [21:35:48] James_F, update -- the comment node/inspector work perfectly. I'm now wrestling with the unit tests... these are pretty maddening, though. The assertions and tests are distributed over 3 files [21:36:07] And so far the tests assume 'comment' is a meta object; now it's a node. [21:36:19] also, it's a leaf node, so it's wrapped with paragraphs [21:36:22] meh. [21:36:46] James_F, I think at some point we might want to separate the comments to inline/block [21:39:05] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Langage and Special Character inspectors' UI is broken, and dialog titles are not correctly aligned - 10https://bugzilla.wikimedia.org/68180#c3 (10ryasmeen) Verified the fix in test2 [21:39:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Langage and Special Character inspectors' UI is broken, and dialog titles are not correctly aligned - 10https://bugzilla.wikimedia.org/68180#c4 (10ryasmeen) Verified the fix in test2 [21:45:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388#c2 (10ryasmeen) Verified the fix in test2 [21:46:51] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c7 (10ryasmeen) Verified the fix in test2 [21:50:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068#c4 (10ryasmeen) Verified the fix in test2 [21:59:17] mooeypoo: Yeah. Fun. [21:59:21] mooeypoo: Inline-block? [22:00:35] 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c5 (10ryasmeen) Verified the fix in test2 [22:08:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066#c3 (10ryasmeen) Verified the fix in test2 [22:13:35] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node backwards by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755#c4 (10ryasmeen) Verified the fix in test2 [22:35:23] 3VisualEditor / 3Editing Tools: VisualEditor: After changing the size of an image and applying changes, the image size changes but does not get updated in the Media dialog until saving the page - 10https://bugzilla.wikimedia.org/68242 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:... [22:38:05] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684#c6 (10ryasmeen) Verified the fix in test2 [22:40:05] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687#c3 (10ryasmeen) Verified the fix in test2 [22:41:50] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] Cite menu is missing in the toolbar for mobile VE for in both alpha and beta modes - 10https://bugzilla.wikimedia.org/67701#c3 (10ryasmeen) Verified the fix in test2 [22:51:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] All inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061#c3 (10ryasmeen) Verified the fix in test2 [22:55:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609#c4 (10ryasmeen) Verified the fix in test2 [23:00:50] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] The context menu for already added category is appearing as blank in Betalabs - 10https://bugzilla.wikimedia.org/67885#c4 (10ryasmeen) Verified the fix in test2 [23:04:41] Krinkle: What did your mysterious comment "The new" mean? https://bugzilla.wikimedia.org/show_bug.cgi?id=61508#c16 :-) [23:05:23] James_F: half comment, I have it open an will finish, but fixing ci issue now. Which is hard without documentatoin. The integation slaves now have their own puppet master apparrently [23:06:19] one breakage into the next, feel like I'm learning a lot today but only getting things that are unforseen prequisites for what I'm actually doing. [23:06:27] getting things done that are* [23:07:01] (03PS4) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 [23:07:08] (03PS5) 10Jforrester: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 [23:19:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c11 (10ryasmeen) Verified the fix in test2 with iOS and Android. [23:23:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: In android, while trying to apply a link on a selected text ,strips off the first letter of the text in the link inspector - 10https://bugzilla.wikimedia.org/68244 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobil... [23:34:34] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390#c2 (10Ryan Kaldari) Interestingly, this bug only seems to occur in landscape mode on iPad. [23:40:45] (03PS1) 10Jforrester: Scrap the cancel button from the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147682