[00:16:21] (03PS2) 10Jforrester: [WIP] Put "re-use reference" in the toolbar "Cite" menu, and give it an icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 [00:30:43] (03PS3) 10Jforrester: Put "re-use reference" in the toolbar "Cite" menu, and give it an icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 [02:09:18] (03PS4) 10Jforrester: Put "re-use reference" in the toolbar "Cite" menu, and give it an icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 [02:15:18] (03PS1) 10Jforrester: Fix heights of Reference, ReferenceList and Template dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147710 (https://bugzilla.wikimedia.org/68226) [02:27:20] (03PS5) 10Jforrester: Put "re-use reference" in the toolbar "Cite" menu, and give it an icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 [04:09:59] (03PS7) 10Krinkle: [WIP] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [04:14:12] (03CR) 10Krinkle: "Rebased to resolve merge conflict with grunt-jscs rename in Gruntfile/package.json." [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [04:51:19] (03CR) 10Krinkle: [C: 04-1] "Maybe not do this from the default test pipeline but only on CR+2 (still before merge, but not on every patch set, rebase, commit msg edit" [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle) [04:59:21] (03PS8) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [05:32:37] (03CR) 10Trevor Parscal: [C: 032] Scrap the cancel button from the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147682 (owner: 10Jforrester) [05:34:25] (03Merged) 10jenkins-bot: Scrap the cancel button from the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147682 (owner: 10Jforrester) [06:00:33] (03PS9) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:00:47] (03PS10) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:14:38] (03PS11) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:18:45] (03PS12) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:32:52] (03PS13) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:36:57] (03PS14) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:38:02] (03PS15) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [06:41:45] (03PS16) 10Krinkle: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 [10:04:57] (03PS1) 10Esanders: Set actions buttons to be framed by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/147731 [13:14:19] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c16 (10Bartosz Dziewoński) That sounds fine by me. So it would be enabled with a $wg config variable? I wonder if it would make sense to let users enable it for themselves (by loa... [13:59:10] (03PS1) 10Nemo bis: Don't steal core's 'edit', 'create', 'editsection' by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) [14:02:58] (03PS2) 10Nemo bis: Don't steal core's 'edit', 'create', 'editsection' by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) [14:10:50] 3VisualEditor / 3Language: Core message reuse - 10https://bugzilla.wikimedia.org/67274#c6 (10Nemo) (In reply to Robin Pepermans (SPQRobin) from comment #4) > having yet another message and consequently having only > few translations. No such risk in my proposal. [14:32:47] (03CR) 10Alex Monk: "Oh okay, I read the new commit message - you rewrote parts of it. Jenkins doesn't like your duplicate OO.ui.TextInputWidget.prototype.onKe" [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [14:34:39] (03PS9) 10Alex Monk: [WIP] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) [14:36:35] (03CR) 10Alex Monk: "Okay, since nobody has replied, I'll just remove the Code-Review-2 and see what people say then" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [14:39:16] (03PS3) 10Alex Monk: Give a notice if the user isn't allowed to create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) [14:40:17] (03CR) 10Alex Monk: "James, should we be doing the "isTalkPage() ? 'createtalk' : 'createpage'" ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [14:42:29] (03Abandoned) 10Alex Monk: WIP Support new column-width & list-style attributes to Cite's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (https://bugzilla.wikimedia.org/51260) (owner: 10Alex Monk) [14:50:21] (03PS13) 10Mooeypoo: Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [14:55:57] (03CR) 10Jforrester: "Maybe? VE isn't meant to be activated on any talk namespace…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [14:56:14] (03CR) 10Alex Monk: "Yeah, that's why I asked." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [15:16:54] James_F, heya [15:17:12] (03PS3) 10Mooeypoo: ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 [15:17:26] James_F, this is going to fail tests ^^ and I need help with those :\ [15:18:09] (03CR) 10jenkins-bot: [V: 04-1] ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [15:56:13] mooeypoo: OK, what help do you need? [15:57:50] mooeypoo: It will always fail if you try to pull through a version of lib/ve that isn't merged yet. [15:58:13] mooeypoo: Until the lib/ve update is merged, the server can't tell whether it will pass or not. [16:02:00] James_F, yeah no no it fals actual tests in mw' [16:02:10] I fixed most of the failed tests (the core tests pass now) [16:02:20] but there's one test that I don't understand why the result is as it is [16:02:30] (03CR) 10Jforrester: [C: 04-2] "This fundamentally violates the principle of these messages being reused." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis) [16:02:56] mooeypoo: Ah. Need me to pull the code down and run? [16:02:59] I changed the comment from meta to being a full leaf node, so the model has changed - but in that test something weird is happening. [16:03:03] sure [16:03:09] Oy. [16:04:21] mooeypoo: Swap with merge on https://gerrit.wikimedia.org/r/#/c/144608/ and https://gerrit.wikimedia.org/r/#/c/145860/ ? :-) [16:05:20] wait, what? [16:05:24] I'm confused no [16:05:24] now [16:05:59] James_F, the failed tests are purely DM [16:06:04] * mooeypoo is confused [16:09:40] mooeypoo: Yeah, the mwAlienMeta is staying in the paragraph, not breaking it. [16:09:57] mooeypoo: That's correct behaviour, isn't it? Aliens don't create paragraphs and just live wherever. [16:10:04] s/Aliens/Metas/ [16:11:18] but James_F the alien meta above it IS breaking the paragraph :\ [16:11:20] i don't understand [16:11:24] mooeypoo: In https://gerrit.wikimedia.org/r/#/c/147401/3/modules/ve-mw/tests/dm/ve.dm.mwExample.js you added "{ 'type': '/paragraph' }," on line 325. [16:11:41] ohh ohh okay, so if it's in a paragraph it stays and if it's outside of it, it doesn't get wrapped [16:11:45] Yeah. [16:11:52] I think. [16:11:54] ok .. I think I get that now. I was getting confused [16:12:00] I may be entirely wrong. :-) [16:12:10] yeah, I broke the paragraph before it, and the result was supposed to not have it broken [16:12:16] Yeah. [16:12:26] I jus didn't get why, and I didn't want to change the test just to fit the result (that would be against the point, i think.. :p ) [16:12:49] ok I'll fix that, but you can already test and see how things work inside VE [16:13:33] Yeah. [16:17:11] mooeypoo: Hmm, thinking about it I'm not sure the split between editing and reading is necessary – what do you think? [16:17:46] James_F, I was thinking of random editors who you may not want to automatically edit [16:17:56] like, discouraging the editing of the notes [16:18:22] Eh. If your note is so long that people need to click into it to read the whole thing, it probably should be edited. [16:18:23] :-) [16:18:26] but either way is fine, I can have it load directly inside the textbox. But I was trhinking that the notes are first for reading and only if you know what you're doing, for editing. So kind of go with "only if you need to" edit. [16:18:40] And we don't provide remove buttons for existing nodes (though there's a couple of suggestions that we do so); interesting. [16:18:48] * James_F nods. [16:18:52] James_F, well to be fair, it can be a block note, and also the word limit on that title is tiny [16:19:03] Intentionally. :-) [16:19:19] indeed.. but for notes? might be too short, no? [16:19:46] "Don't change! See talk!" fits fine. [16:19:50] oh, I added the remove intentionally... though it might look better up top opposite the "done" [16:19:56] rofl [16:20:20] I have no idea what comments are usually used for inside articles, honestly, so I can't judge if they're long or not. But I made it also that it can display blocks [16:20:27] "Provide references if you change." [16:20:28] Etc. [16:20:33] * James_F nods. [16:20:35] so if you have multiple line breaks or something, you'll see it formatted [16:20:40] Cool. [16:20:43] oh, okay. [16:20:51] I guess I was thinking about both inline and block comments. [16:21:27] (We can't put the remove button in the navigation bar, as it breaks the design principles, but maybe on the side or somewhere else could work.) [16:29:40] Hmm. Can it be above the form? [16:30:06] Ideally not. [16:30:07] The only real problem here imho is that I couldn't find a good way to change the size of the inspector once you switch to edit mode [16:30:31] so when you switch to edit, the input appears (bigger) and the buttons are pushed down under it, so you have to scroll to them [16:30:32] If people want to delete them the "easy" way is to click on them and press delete (or cut or backspace). [16:30:42] Right, that's also true [16:30:53] but since they're focusable, I thought that it makes sense. I can remove it, though [16:35:09] It's not a bad idea. [16:35:18] We just need to find a way to put it in the design that works. :-) [16:36:06] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature - 10https://bugzilla.wikimedia.org/51154#c17 (10James Forrester) a:3Bartosz Dziewoński (In reply to Bartosz Dziewoński from comment #16) > That sounds fine by me. So it would be enabled with a $wg config variable? That... [16:42:34] * mooeypoo nods [16:43:10] btw James_F those two commits must go together or VE won't load... should I add "breaking cchange" or is this understood from my "REQUIRES X" comment? [17:00:18] mooeypoo: Yeah, add [BREAKING CHANGE] to the VE-core commit. [17:03:25] I thought breaking change is more about having one change that affects all code after it, which isn't quite the case here,but the two commits ve/ve-mw must go together or VE won't load because of the changes in file names mainly. [17:03:32] I'll add it in [17:09:18] Yeah. [17:40:16] (03PS1) 10Jforrester: Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 [17:42:25] (03PS1) 10Jforrester: test: Move mv into the global list of globals for VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147753 [17:42:41] James_F, btw are you happy with how those help buttons display? [17:42:46] (03PS2) 10Jforrester: test: Move mw into the global list of globals for VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147753 [17:42:56] and just work in general, I guess [17:43:57] Krenair: It looks OK to me. We might want to tweak it a little but that's best understood once we put it in front of real users and see how happy they are. [17:44:13] ok, good [17:44:14] Krenair: Generally things are going well, IMO. :-) [19:05:37] 3VisualEditor: When highlighting and replacing a text, VE starts typing by itself - 10https://bugzilla.wikimedia.org/68278 (10Stryn) 3NEW p:3Unprio s:3normal a:3None When I select (highlight) some text on the edit mode and start to type some text by replacing the old text, Visual Editor starts copying... [19:08:31] Hm. Confirmed ^ [19:08:33] That's not good [19:25:52] 3VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279 (10Gabrasca) 3UNCO p:3Unprio s:3minor a:3None The text show/hide in the right of the navbox disappear after have edited a page where there is a navbox collapsed and the navbox appea... [19:26:20] 3VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279 (10Gabrasca) [20:16:16] (03PS1) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 [20:16:19] Krinkle: ^^^ Ta-dah. [20:16:52] +5986, -598 [20:16:54] 7 [20:16:55] Bah. [20:17:43] (03CR) 10jenkins-bot: [V: 04-1] build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 (owner: 10Jforrester) [20:19:10] Eurgh. Why is jsduck failing? [20:26:30] James_F: I think it doesn't like the special characters as literal keys [20:26:39] Probably a shortcoming in its javascript interpreter [20:26:41] Krinkle: Eurgh. [20:26:46] yay for parsing javascript in ruby. [20:26:48] * James_F grumbles. [20:26:59] Either jscs or jsduck won't be happy with me. [20:27:46] Also, we should probably just kill that block anyway (if the message can't be fetched from the platform you have wider issues). [20:40:48] The office hour discussion about VisualEditor will start in #wikimedia-office in 20 minutes. [20:41:43] James_F: looks like a reasonably simple fix to the underlying parser library to me ;) [20:42:11] MatmaRex: A double-upstream bug? Hmm. No thanks. :-) [20:42:35] oh you lazy-ass. :> [20:42:40] https://github.com/tenderlove/rkelly/blob/master/lib/rkelly/tokenizer.rb#L84 [20:42:56] this should allow more than just A-Za-z [20:42:57] That's… very wrong. [20:42:58] Yeah [20:43:11] um, wow [20:45:43] the regex-vs-division code also looks smelly, but i don't know enough about how that should be parsed according to the standards to complain :D [20:47:07] anyone wants to file the issue? and another one about producing "undefined method `name' for nil:NilClass" instead of "unrecognized token"… [20:49:34] MatmaRex: Am about to do Office Hours – could you? [20:50:11] probably [20:54:41] hm, so apparently the library is no longer developed and it has a fork, rkelly-remix [20:54:56] the fork also has this bug, but at least it runs on ruby 2.0 [20:55:51] oh wait, jsduck already uses rkelly-remix. [20:56:35] Yay complexity. [20:57:35] in fact, it was apparently specifically forked for jsduck. [20:57:47] so that might make the double-upstream issue less problematic :D [20:58:04] Fair. [21:06:18] hm. [21:06:22] from #wikimedia-commons: [21:06:23] Office hour for the visual editor in #wikimedia-office starting around now [21:06:23] Isn;t it a bit late for a office-hour? [21:06:23] We who "complain" a lot are probl. sleeping. That's their "plan" [21:06:23] I see [21:08:49] Pff. Joke, apparently. [21:49:10] Krenair: Don't take it personally. :-) [22:41:48] (03CR) 10Jforrester: [C: 032] Set actions buttons to be framed by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/147731 (owner: 10Esanders) [22:42:26] (03Merged) 10jenkins-bot: Set actions buttons to be framed by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/147731 (owner: 10Esanders) [22:55:18] James_F: do you know what https://releases.wikimedia.org/VisualEditor/ is? [22:59:57] legoktm: Yeah, it was a quick hack to route around the ExtensionDistributor bug. [23:00:19] :| [23:00:43] I'm thinking about just making this a proper thing in prod rather than having prod depend upon labs. [23:00:56] * James_F nods. [23:44:18] 23:00 < legoktm> I'm thinking about just making this a proper thing in prod rather than having prod depend upon labs. --- whatever you're talking about, yes [23:44:21] :)