[08:50:20] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Scroll to the user's position when VE is invoked via shortcut (Ctrl+Alt+V) - 10https://bugzilla.wikimedia.org/52577#c1 (10Daniel Naber) This should always be the case, no matter how the editor is invoked. "User's position" when the editor is opened should...
[11:30:09] <grrrit-wm>	 (03PS1) 10Vikassy: [BrowserTest] Added @login tag to language screenshot feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148048 
[12:15:00] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 04-1] [BrowserTest] Added @login tag to language screenshot feature (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148048 (owner: 10Vikassy)
[12:17:59] <grrrit-wm>	 (03PS2) 10Vikassy: [BrowserTest] Added @login tag to language screenshot feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148048 
[12:29:28] <grrrit-wm>	 (03PS1) 10Esanders: Use native focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148056 
[12:29:59] <grrrit-wm>	 (03PS1) 10Esanders: Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 
[12:30:10] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] [BrowserTest] Added @login tag to language screenshot feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148048 (owner: 10Vikassy)
[12:33:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] Added @login tag to language screenshot feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148048 (owner: 10Vikassy)
[12:49:05] <grrrit-wm>	 (03PS1) 10Esanders: Use native focus [oojs/ui] - 10https://gerrit.wikimedia.org/r/148061 
[12:59:22] <grrrit-wm>	 (03PS1) 10Esanders: Fix reference dialog focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148063 
[13:10:36] <wikibugs>	 3OOjs: es5-shim module doesn't include Object.create implementation, needed for OOjs - 10https://bugzilla.wikimedia.org/67590 (10Bartosz Dziewoński) a:3None
[13:26:39] <mvolz>	 edsanders: do you know when the new core ve stuff (i.e. FragmentDialog instead of Dialog) is getting deployed various places? is there a place I can go to look that kind of thing up?
[13:28:27] <edsanders>	 if it's master it'll usually be deployed to mediawiki within a week
[13:28:40] <edsanders>	 not sure how far behind en.wiki, but James_F|Away will know
[13:35:49] <mvolz>	 ok. yeah, it's master
[13:35:57] <mvolz>	 lots of breaking changes for existing gadgets :P
[13:36:13] <mvolz>	 wasn't sure if there was a list or something
[13:36:29] <mvolz>	 mailing list*
[14:28:44] <grrrit-wm>	 (03PS1) 10Esanders: MWReferenceSearchWidget buildIndex optimisations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148069 
[14:28:46] <grrrit-wm>	 (03PS1) 10Esanders: Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 
[14:30:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders)
[15:46:22] <grrrit-wm>	 (03CR) 10Jforrester: "> Filed rkelly-remix JS parser issue: https://github.com/tenderlove/rkelly/issues/35" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 (owner: 10Jforrester)
[15:48:46] <grrrit-wm>	 (03CR) 10Jforrester: Provide contextual help for the page settings dialog's controls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 (owner: 10Jforrester)
[15:55:25] <grrrit-wm>	 (03PS1) 10Esanders: Use proper methods for detecting data type in getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148095 
[16:00:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Give MessageDialog actions 'action' properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/147911 (owner: 10Esanders)
[16:01:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Give MessageDialog actions 'action' properties [oojs/ui] - 10https://gerrit.wikimedia.org/r/147911 (owner: 10Esanders)
[16:08:54] <grrrit-wm>	 (03PS1) 10Esanders: Add optimised method hasAnnotationsInRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148097 
[16:17:26] <mvolz>	 James_F: do you know when those changes will be deployed on en wiki?
[16:19:56] <James_F>	 mvolz: Thursday.
[16:19:58] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] update Save button locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148100 
[16:20:07] <mvolz>	 Sweet, thank you
[16:20:07] <James_F>	 mvolz: Around 11:00 SF-time.
[16:20:16] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148100 (owner: 10Cmcmahon)
[16:22:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] update Save button locator [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148100 (owner: 10Cmcmahon)
[16:34:04] <grrrit-wm>	 (03CR) 10Jforrester: "> Is "the principle of these messages being reused" defined somewhere? Never heard of this principle." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis)
[16:45:00] <grrrit-wm>	 (03PS1) 10Esanders: Use faster computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 
[16:47:11] <mvolz>	 James_F: is it possible to get on ve-tech? or is that internal only? 
[16:47:41] <Krenair>	 It's an organisation google group, IIRC
[16:47:55] <grrrit-wm>	 (03CR) 10Nemo bis: "> The principle is that the edit tab is the edit tab is the edit tab." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis)
[16:48:00] <James_F>	 mvolz: I'm not sure it's possible to add external addresses. Also, there's almost no traffic to it, so… what are you looking for?
[16:49:16] <Krenair>	 Although it doesn't show on https://groups.google.com/a/wikimedia.org/forum/#!myforums - hmm...
[16:49:30] <James_F>	 Krenair: It doesn't?
[16:49:51] <Krenair>	 Did that get renamed to editing-team?
[16:50:22] <James_F>	 Yes.
[16:50:30] <Krenair>	 ah, okay it shows there then
[16:50:35] <James_F>	 :-)
[16:51:43] <mvolz>	 James_F: oh, i just have one that ed forwarded me, and it was like "this is a new feature, it will be deployed x date, etc" and though that might be useful if it was used frequently. no biggie :)
[16:54:02] <James_F>	 mvolz: Ah, right. There's much more of that here than in e-mails. :-)
[16:56:59] <James_F>	 Krenair: Feel like +2ing https://gerrit.wikimedia.org/r/#/c/145860/ to stop cluttering up the review list? :-)
[17:18:21] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c6 (10Stryn) 5RESO/FIX>3REOP It still redirects...
[17:19:35] <wikibugs>	 3VisualEditor: When highlighting and replacing a text, VE starts typing by itself - 10https://bugzilla.wikimedia.org/68278#c1 (10Stryn) In case someone didn't understand my explanation, I have a video uploaded to http://tinypic.com/r/mbik2w/8 On the video I only typed "k" (it doesn't matter what key you hit),...
[17:24:37] <mooeypoo>	 edsanders, your point about comments is valid, and I'm not sure at all what it would do right now; I think it would either break the table or show the comment below it. I'm also not sure how we want the UX to be work with those in term of the user -- how would the user *add* such comments when they're in VE ? or is this only for displaying existing ones? If so, maybe we should separate two types of comments - in text (which will get
[17:24:37] <mooeypoo>	  to be nodes) and outside of it (which we will have to think of a clever UI for)
[17:24:42] <mooeypoo>	 James_F|Away, also for you ^^
[17:25:13] <grrrit-wm>	 (03CR) 10Siebrand: Provide contextual help for the page settings dialog's controls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 (owner: 10Jforrester)
[17:30:20] <grrrit-wm>	 (03CR) 10Siebrand: "There is no "principle of [these] messages being reused", hence there cannot be any violation of it. Message reuse is discouraged, especia" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis)
[17:30:58] <mooeypoo>	 James_F, I am not seeing RLM in hewiki's special chars
[17:31:12] <mooeypoo>	 also, I'm not seeing the Hebrew diacritics .. meh
[17:31:20] <James_F>	 mooeypoo: Boo. We should fix that.
[17:31:37] <mooeypoo>	 It's set in a message
[17:31:40] <mooeypoo>	 let me see
[17:32:37] <mooeypoo>	 "visualeditor-specialcharinspector-characterlist-insert"
[17:33:10] <mooeypoo>	 hm, so I should contact hewiki admins to add this in, or go to the translatewiki version? 
[17:33:47] <mooeypoo>	 this is functionality, I'm not sure if it should be in translatewiki... isn't the local wiki version overriding it? (not sure)
[17:34:05] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c7 (10Alex Monk) Are you sure that wiki is running...
[17:34:15] <Krenair>	 this change on* gah
[17:38:08] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c8 (10Stryn) 5REOP>3RESO/FIX (In reply to Alex...
[17:41:52] <wikibugs>	 3VisualEditor: status/error Message has no text - 10https://bugzilla.wikimedia.org/68327 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15995   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15995&action=edit no Message for error  "Not logged in" message has no Message text...
[17:42:05] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c9 (10Alex Monk) https://www.mediawiki.org/wiki/Med...
[17:42:35] <wikibugs>	 3VisualEditor: status/error Message has no text - 10https://bugzilla.wikimedia.org/68327 (10Chris McMahon)
[17:48:00] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/147852/ is the link.
[17:48:08] <James_F>	 mooeypoo: TranslateWiki version.
[17:48:53] <James_F>	 edsanders: (Please merge. :-))
[17:56:54] <MatmaRex>	 TrevorP|Away: if you need me, then i'm here, btw
[17:56:57] <Krenair>	 James_F, in https://bugzilla.wikimedia.org/show_bug.cgi?id=55925 I wonder if what we should really do is make it possible to tab to the "Add parameter" field, and possibly rearrange the order that suggested parameters appear in to prioritise required ones
[17:59:23] <Krenair>	 (make it possible to tab to the collapsed "Add parameter" field, expanding it in the process. you can tab to it if it's already been expanded)
[17:59:24] <James_F>	 MatmaRex: TrevorP|Away's ill, sadly. :-(
[17:59:33] <MatmaRex>	 ow :(
[17:59:52] <James_F>	 Krenair: Yes for tabbing, no for re-ordering – that's already done by TemplateData.
[18:02:44] <grrrit-wm>	 (03PS1) 10Jforrester: Declare dependency on ooui-dialog-* messages as they're needed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148120 (https://bugzilla.wikimedia.org/68327) 
[18:02:46] <grrrit-wm>	 (03PS1) 10Jforrester: Mention at the top of the MW-specific ve.ce.Surface.test file what it is [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148121 
[18:03:51] <wikibugs>	 3VisualEditor: VisualEditor: [Regression wmf14] ooui-dialog-* messages not imported - 10https://bugzilla.wikimedia.org/68327 (10James Forrester) p:5Unprio>3Normal a:3James Forrester
[18:04:05] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf14] ooui-dialog-* messages not imported - 10https://bugzilla.wikimedia.org/68327 (10James Forrester)
[18:17:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Round up height of language inspector widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147550 (owner: 10Esanders)
[18:17:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make the re-render flash more prominent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147988 (owner: 10Esanders)
[18:19:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Round up height of language inspector widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147550 (owner: 10Esanders)
[18:21:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make the re-render flash more prominent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147988 (owner: 10Esanders)
[18:26:20] <grrrit-wm>	 (03CR) 10Nemo bis: "Sure, it's James' call. I think it was a useful conversation to have though, for instance we found that https://www.mediawiki.org/wiki/Loc" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis)
[18:28:16] <grrrit-wm>	 (03CR) 10Siebrand: "Ah, the infamous bug 1. Will it ever be solved? I do hope, it will survive the migration off Bugzilla as the issue with ID 1." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147737 (https://bugzilla.wikimedia.org/67274) (owner: 10Nemo bis)
[18:28:21] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Down-page of {{IPA-es}} backspace behaviour is very broken - 10https://bugzilla.wikimedia.org/67862#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders Fixed by the fix for bug 67432.
[18:29:05] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: The "Go back" button in use existing reference dialog in mobile takes to Basic Reference dialog - 10https://bugzilla.wikimedia.org/68201 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[18:33:55] <grrrit-wm>	 (03CR) 10Siebrand: Refactor TemplateData Editor (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo)
[18:38:05] <wikibugs>	 3VisualEditor / 3Editing Tools: can't search image when inserting media in private wiki - 10https://bugzilla.wikimedia.org/68141#c1 (10Remco de Boer) I can confirm this issue. The problem is related to the use of the parameter 'callback=jQuery...' in the api call.   According to https://www.mediawiki.org/wik...
[18:40:50] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Image should not change size when going from read to edit - 10https://bugzilla.wikimedia.org/67047#c4 (10Jared Zimmerman (WMF)) I think I might be being unclear with the request…   As a user who sets my thumbnail preference to (120/180/220/250/300/etc)px while in...
[18:41:09] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053 (10James Forrester) 5ASSI>3RESO/FIX a:5Trevor Parscal>3Ed Sanders
[18:44:07] <MatmaRex>	 ugh
[18:44:18] <MatmaRex>	 is it just me, or is something about templates or links badly borked?
[18:44:21] <MatmaRex>	 e.g. https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki#Stage_1:_Improve_skinning_mechanisms_.28bug.C2.A043658.29
[18:44:36] <MatmaRex>	 trying to add a link (Ctrl+K) after the "In progress" template yields lots of snowmen
[18:44:48] <MatmaRex>	 trying to remove it and insert {{Done}} instead too
[18:53:37] <edsanders>	 looks like it
[18:53:39] <James_F>	 MatmaRex: Yeah. :-(
[18:55:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232 (10James Forrester) p:5Unprio>3Normal a:3James Forrester
[18:55:27] <MatmaRex>	 (is something newly broken, or am i just using VE more and seeing more problems because of that?)
[18:55:49] <James_F>	 MatmaRex: I think that's not new-new, but relatively new.
[18:55:54] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: After changing the size of an image and applying changes, the image size changes but does not get updated in the Media dialog until saving the page - 10https://bugzilla.wikimedia.org/68242 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schott...
[18:59:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5no...
[19:00:36] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5norma...
[19:02:36] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c5 (10James Forrester) 5REOP>3ASSI a:5Trevor Parscal>3Ed Sanders Selection's not being re-set t...
[19:59:22] <Krenair>	 <James_F> Krenair: Yes for tabbing, no for re-ordering � that's already done by TemplateData.
[19:59:27] <Krenair>	 What reordering is done there?
[20:02:36] <James_F>	 Krenair: https://gerrit.wikimedia.org/r/#/c/89867/
[20:04:25] <aharoni>	 troublesome to edit in VE: was appointed as the leader of the self-declared
[20:04:28] <aharoni>	 oh, sorry
[20:04:33] <aharoni>	 https://en.wikipedia.org/wiki/Cyrenaica?veaction=edit
[20:04:42] <aharoni>	 search for "was appointed as the leader of the self-declared"
[20:05:20] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When adding a new template, auto-open the "add parameter" section and put the cursor in the search dialog's input when we tab to it - 10https://bugzilla.wikimedia.org/55925#c1 (10Alex Monk) Changing this bug slightly to fit the current situation with tab indexes.
[20:05:22] <Krenair>	 James_F, ^ does that seem about right?
[20:05:23] <aharoni>	 I see "On 6 March 2012", then a paragraph break, and then "a relative of King Idris" and so on. If I delete the paragraph break, it actually deletes an image.
[20:05:53] <James_F>	 aharoni: Yeah, that's because the third image ("Movement for Federal Libya") is splitting the paragraph.
[20:05:55] * James_F fixes.
[20:07:21] <James_F>	 aharoni: Better now?
[20:07:55] <aharoni>	 James_F: well yeah, did you do it with VE?
[20:07:55] <James_F>	 Krenair: Would we tab to it by default if there are no parameters present for other reasons?
[20:07:59] <James_F>	 aharoni: Yes.
[20:08:03] <aharoni>	 wow :)
[20:08:14] <James_F>	 aharoni: I dragged the image to above the paragraph. Simple! :-)
[20:08:51] <Krenair>	 James_F, other reasons?
[20:08:52] <aharoni>	 Yeah, well, but not entirely obvious. When I first tried to fix it, I didn't even see that I'm deleting the image. It was off the screen.
[20:09:40] <James_F>	 Krenair: Other reasons == they're required or recommended.
[20:10:00] <James_F>	 aharoni: Yeah, we've got a bug about scrolling the selection into view when it changes.
[20:10:05] <James_F>	 aharoni: :-(
[20:10:10] <Krenair>	 What? What are our existing (non-other) reasons then?
[20:10:17] <aharoni>	 James_F: if a bug is reported, I'm good :)
[20:10:25] <James_F>	 Krenair: Reasons other than "user has inserted it".
[20:10:32] <James_F>	 Krenair: My comment was totally unclear, sorry. :-)
[20:10:36] <Krenair>	 yeah.
[20:10:46] <James_F>	 Krenair: Aka "yes". :-)
[20:14:09] <Krenair>	 James_F, so "Would we tab to it by default if there are no parameters present because they're required/recommended?"
[20:14:12] <Krenair>	 This is really unclear.
[20:15:23] <James_F>	 Krenair: Yes – if you insert a template with you required/recommended parameters, we would auto-open the "add parameter" section (as for other templates), and it'd be the only thing to focus?
[20:16:30] <Krenair>	 with you required?
[20:16:39] <Krenair>	 do you mean 'without'?
[20:17:32] * James_F sighs.
[20:17:32] <James_F>	 Yes.
[20:17:43] <James_F>	 This is what happens when eight people are talking to me at once.
[20:21:50] <Krenair>	 So yes, I think that's what should happen
[21:01:46] <Krenair>	 Ugh this is turning out to be much more of a pain than I expected
[21:02:00] <James_F>	 Krenair: The auto-open?
[21:02:15] <Krenair>	 yeah, when we don't have any required/suggested params
[21:07:32] <Krenair>	 But it seems to work now
[21:10:30] <grrrit-wm>	 (03PS1) 10Alex Monk: Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148233 (https://bugzilla.wikimedia.org/55925) 
[21:11:24] <James_F>	 Ha.
[21:11:48] <Krenair>	 Oh fun, more forms to fill...
[21:12:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148233 (https://bugzilla.wikimedia.org/55925) (owner: 10Alex Monk)
[21:12:37] <Krenair>	 argh
[21:13:13] <Krenair>	 I don't even know what to do about that. I didn't name it
[21:17:32] <James_F>	 Krenair: this.bookletLayout.pages.part_1.onAddButtonFocus() === this.bookletLayout.pages['part_1'].onAddButtonFocus()
[21:18:12] <Krenair>	 yeah, I just sent an amended commit with that instead
[21:18:21] * James_F grins.
[21:18:40] <Krenair>	 Except no I didn't, because I left git-review to get on with it and it is unhappy with 'submit multiple commits.' etc.
[21:18:48] <grrrit-wm>	 (03PS2) 10Alex Monk: Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148233 (https://bugzilla.wikimedia.org/55925) 
[21:20:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148233 (https://bugzilla.wikimedia.org/55925) (owner: 10Alex Monk)
[21:21:00] <Krenair>	 21:19:24                                                      ^ ['part_1'] is better written in dot notation.
[21:21:02] <James_F>	 Eurgh. Krenair: You can't win.
[21:21:06] <Krenair>	 Wat.
[21:21:18] <James_F>	 Yeah, forgot that jshint did that.
[21:21:23] <Krenair>	 Better written in dot notation! .. But you can't have it in dot notation!
[21:21:35] <James_F>	 You /can/, jscs just doesn't like you to do so.
[21:21:38] <James_F>	 jshint vs. jscs.
[21:21:41] <Krenair>	 Actually, I think I've run into this before.
[21:21:46] <James_F>	 'Cos why have one tester when you can have both?
[21:21:54] <James_F>	 Maybe we should rename the parts? :-)
[21:22:16] <Krenair>	 I'm not entirely convinced I was right to access part_1 directly like I'm doing
[21:24:31] <Krenair>	 Well, I'll move on to another bug for now
[21:28:09] <Krinkle>	 obj.part_1 is fine
[21:28:14] <Krinkle>	 the problem is underscores
[21:28:26] <Krinkle>	 Call it something else?
[21:28:34] <Krenair>	 ... I'm not naming it
[21:32:32] <James_F>	 Leave it for Trevor to pick a new name?
[21:33:21] <grrrit-wm>	 (03PS6) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 
[21:35:09] <grrrit-wm>	 (03PS7) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) 
[21:35:50] <Krinkle>	 James_F: Krenair: I guess the reason it didn't trip the linter so far is because it is always dynamically generated.
[21:36:03] <Krenair>	 yeah
[21:36:09] <Krinkle>	 Not supposed to be accessed directly for one is not supposed to know which parts exist
[21:36:18] <Krenair>	 yep.
[21:36:52] <Krenair>	 Thought I was doing something wrong by trying to access it like that
[21:37:12] <Krinkle>	 Krenair: getPage() ?
[21:37:35] <Krenair>	 We have a page = this.getPageFromPart( added );
[21:37:37] <Krinkle>	 Though still, it seems wrong to hardcode a page name like that
[21:37:39] <Krenair>	 I wonder if that's the object I was looking for
[21:38:12] <Krenair>	 Think it is
[21:38:28] <Krinkle>	 getPageFromPart creates a new page
[21:39:08] <grrrit-wm>	 (03PS3) 10Alex Monk: Auto-open "Add parameter" part of template dialog when tabbed to or opening with no required/suggested params [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148233 (https://bugzilla.wikimedia.org/55925) 
[21:39:14] <Krinkle>	 should prolly use bookletLayout.bookletLayout( part.getId() )
[21:39:28] <Krenair>	 Yes, look at the context we're in
[21:39:29] <Krinkle>	 get a reference to the part you want the page for.
[21:39:41] <Krinkle>	 taht way if the naming changes, this will continue to work
[21:39:49] <wikibugs>	 3OOjs UI: OOjs UI: Dialog resize horiztontally but stay at full height when browser window is enlarged - 10https://bugzilla.wikimedia.org/68213 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High
[21:40:02] <Krinkle>	 Hm..
[21:40:13] <Krinkle>	 if names.length / parts length is 0
[21:40:19] <Krinkle>	 how come part_1 does exist?
[21:40:49] <Krinkle>	 ah, that's added parts, not existing parts
[21:41:10] <Krinkle>	 so this is a case where it adds nothing>
[21:41:39] <Krenair>	 yeah, I'm trying to deal with the case where it's added no parameters
[21:41:49] <Krinkle>	 when does it do that?
[21:42:14] <grrrit-wm>	 (03PS1) 10Jforrester: CommandHelpDialog: Make closing action 'safe' not 'primary' for consistency [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148239 
[21:42:20] <Krinkle>	 I mean, focussing the "Add part" part when there are no parts left makes sense
[21:42:20] <Krenair>	 when you have a template with no required/suggested parameters
[21:43:23] <Krinkle>	 but it passing a part with nothing in it, isn't that a no-op?
[21:43:45] <Krinkle>	 Ah 'addPromptedParameters' is what adds it. Interesting, it doesn't pass or get passed from or to anything.
[21:44:17] <Krinkle>	 Krenair: so part_1 is the "add new part" part?
[21:44:36] <Krenair>	 Krinkle, it's the "Template page" part.
[21:44:42] <Krinkle>	 Right
[21:44:46] <Krenair>	 So you have a template page part, and then a part for each parameter
[21:44:50] <wikibugs>	 3OOjs UI: OOjs UI: Dialogs resize horiztontally but stay at full height when browser window is enlarged - 10https://bugzilla.wikimedia.org/68213 (10James Forrester)
[21:45:26] <Krinkle>	 Krenair: Relying on that being the first one (or even named that) seems wrong though. Perhaps that should have a canonical name or method to get to.
[21:45:34] <Krinkle>	 Krenair: So how do I trigger a 'replace' with an empty added?
[21:45:45] <Krenair>	 Krinkle, yes, well, the latest PS doesn't directly access part_1
[21:46:57] <Krinkle>	 Ah, there's a reference to it already
[21:47:19] <Krinkle>	 is that the same part though? I guess that's only the "template page" part if this was the replace that initialised the dialog
[21:47:35] <Krinkle>	 (strange that that is a "replace")
[21:47:38] <Krenair>	 should be.
[21:47:57] <Krenair>	 But my understanding of the whole 'parts' system here is... probably not perfect
[21:59:58] <mooeypoo>	 Krinkle, hai. any chance you'll have time to review the new TemplateData editor refactor? https://gerrit.wikimedia.org/r/#/c/134928/
[22:00:38] <grrrit-wm>	 (03PS7) 10Krinkle: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 
[22:08:12] <Krenair>	 James_F, so looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=51406 
[22:08:48] <Krenair>	 Seems to have already been fixed?
[22:09:22] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialog should prevent adding identically-named parameters (and aliases) - 10https://bugzilla.wikimedia.org/51406#c1 (10Alex Monk) Works for me... Has this been fixed since it was reported?
[22:29:01] <grrrit-wm>	 (03PS1) 10Alex Monk: Add role attribute to a few widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/148253 (https://bugzilla.wikimedia.org/50203) 
[22:37:07] <James_F>	 Krenair: I think it fails in some cases – case sensitivity? "Foo_bar" == "foo_bar" == "Foo bar" maybe?
[22:37:19] <James_F>	 Krenair: A couple of people have grumbled recently-ish.
[22:37:34] <Krenair>	 does MW consider them the same?
[22:38:03] <Krenair>	 I guess I'll check
[22:43:01] <Krenair>	 hm, nope, seems to consider 'a sd', 'a Sd' and 'a_sd' different
[22:43:24] <James_F>	 Hmm.
[22:43:28] <James_F>	 That's… surprising.
[22:52:46] <mooeypoo>	 James_F, I just looked at the hackathon page, are we having anything special?
[22:53:02] <James_F>	 mooeypoo: Not really. Just mixing and making sure people are happy.
[22:53:08] * mooeypoo nods
[22:53:12] <James_F>	 mooeypoo: I'm sure we'll get a bunch of interest.
[22:53:48] <mooeypoo>	 it'll be my first Hackathon
[22:54:05] <James_F>	 Gosh. :-)
[22:54:11] <James_F>	 Not your last, I'm sure.
[22:56:53] <mooeypoo>	 :D
[22:57:40] <James_F>	 Krinkle: Are you working on https://gerrit.wikimedia.org/r/#/c/141441/ or was it just a fly-by rebase?
[22:57:57] <Krinkle>	 James_F: Yeah, I'm gonna have to rethink it a bit.
[22:58:11] <James_F>	 Krinkle: Cool. Sorry to be the bearer of bad news.
[22:58:43] <James_F>	 Krinkle: Also, re. https://gerrit.wikimedia.org/r/#/c/147510/ – what do you think about keeping qunit around for local testing (rather than the hack of a token that is shared)?
[22:59:13] <James_F>	 Krinkle: So `grunt test` runs qunit, and `grunt ci` runs Karma using tokens.
[23:11:23] <Krenair>	 James_F, What exactly is https://bugzilla.wikimedia.org/show_bug.cgi?id=51141 about? Trevor's better class?
[23:19:34] <Krinkle>	 James_F: Have you tried it? It does that already
[23:19:47] <Krinkle>	 karma:phantom
[23:20:18] <Krinkle>	 "qunit" the task, is obsolete in that case. No point in implementing it twice. 
[23:20:39] <Krinkle>	 phantomjs, local chrome/firefox, and saucelabs all support the same wire protocol
[23:21:03] <Krinkle>	 See also doc header on https://gerrit.wikimedia.org/r/#/c/147510/16/Gruntfile.js
[23:21:15] <Krinkle>	 Let me know how I can document it better :)
[23:21:46] <Krinkle>	 On https://integration.wikimedia.org/ci/job/oojs-core-npm/226/console you see the result of 'grunt test' (the same as for you locally), which tests qunit over phamtomjs
[23:22:28] <Krinkle>	 token is only used for saucelabs browsers (when running grunt-ci)
[23:22:40] <Krinkle>	 not for phantom or local
[23:23:50] <Krinkle>	 and if you find yourself wanting to run grunt-ci often, both for your own sake and others, sign up for a free account and set the credentails in your bashrc so that you're not bothered by concurrency load from others
[23:47:56] <James_F>	 Krinkle: Sorry, yeah, I meant using the qunit package rather than Phantom, but I think this is fine.
[23:48:16] <Krinkle>	 James_F: What do you mean?
[23:48:32] <Krinkle>	 the npm package 'qunit' is for running tests in nodejs, not a browser environment like phantom.
[23:48:38] <Krinkle>	 we run that still as well.
[23:49:08] <Krinkle>	 which asserts programs like cxserver and parsoid could use oojs on the server side.
[23:49:18] <James_F>	 Krinkle: But no longer using it from /lib.
[23:49:22] * James_F nods.
[23:49:34] <Krinkle>	 Ah, the qunitjs package
[23:49:38] <Krinkle>	 from npm.
[23:50:08] <James_F>	 Yeah.
[23:50:10] <Krinkle>	 It's no longer substituted indeed, it's now grabbed from npm. That's because Karma uses require() to find the files, it can't be given a direct path to lib/
[23:50:19] <James_F>	 Ah, OK.
[23:50:21] * James_F shrugs.
[23:50:24] <James_F>	 It seems fine to me.
[23:50:40] <Krinkle>	 yeah, that's a bit of a oddity, though it does make it easier to manage.
[23:50:55] <Krinkle>	 if we need an html file again, it can be referenced still, it has a deterministic location
[23:51:08] <Krinkle>	 e.g. like https://gerrit.wikimedia.org/r/#/c/147510/12/tests/index.html
[23:51:25] <James_F>	 It just feels like we're changing direction from how we do things for OOUI and VE and I'm not sure it's a direction that works for those.
[23:51:37] <James_F>	 True.
[23:52:26] <Krinkle>	 as I explore Karma (and the semantics of how this commit uses it) further in oojs-ui and ve, we might have to reconsider parts of it.
[23:52:40] <James_F>	 Yeah.
[23:52:42] <James_F>	 Very well.
[23:52:42] <Krinkle>	 in both directions
[23:52:54] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle)
[23:53:59] <Krinkle>	 While nothing directly, it also relates loosely to using VMs for running Jenkins jobs as that complicates concurrency (more likely to hit the limit), so we may have to move it to post-merge after all so that it only runs 1 at a time for any given project.
[23:54:22] <Krinkle>	 though +2 should be close enough, and the way Zuul runs merges now, it actually does only run one at a time due to pipeline chain optimisation
[23:54:33] <Krinkle>	 and that way it'll fail when it should :)
[23:56:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Implement Karma module for cross-browser unit testing [oojs/core] - 10https://gerrit.wikimedia.org/r/147510 (owner: 10Krinkle)
[23:56:40] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The link inspector appears over the toolbar while trying to add it inside an image for the first time - 10https://bugzilla.wikimedia.org/68355 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15998   --> https://bugzilla.wikimedia.o...
[23:57:15] <James_F>	 Krinkle: Yes, but multiple projects using Karma won't be great.
[23:57:27] <Krinkle>	 They'll each have their own saucelabs account
[23:58:17] <Krinkle>	 In fact, saucelabs insists oss accounts are tied to a project/repo, not user or organisation.