[00:00:34] (03CR) 10Catrope: [C: 032] test: Move mw into the global list of globals for VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147753 (owner: 10Jforrester) [00:02:24] (03Merged) 10jenkins-bot: test: Move mw into the global list of globals for VE-MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147753 (owner: 10Jforrester) [00:05:34] (03CR) 10Catrope: "We don't need 'createpage' / 'createtalk' for userCan(), if that's what you're asking. If you pass in 'create' like you're doing here, thi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:06:11] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16011 --> https://bugzilla.w... [00:06:45] (03CR) 10Alex Monk: "Timo's -1 has stuck for some reason. Is that still valid?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:10:19] (03CR) 10Catrope: [C: 032] "This looks fine to me, merging. I found similar code in MW core, we don't need createpage/createtalk for userCan(), and I suppose we could" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:12:06] (03Merged) 10jenkins-bot: Give a notice if the user isn't allowed to create the page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144275 (https://bugzilla.wikimedia.org/67550) (owner: 10Alex Monk) [00:16:06] (03PS1) 10Catrope: Followup b6cc76d4: call parent's onSetup/onTeardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148559 (https://bugzilla.wikimedia.org/68415) [00:16:10] (03PS8) 10Mooeypoo: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) [00:16:16] mooeypoo: https://gerrit.wikimedia.org/r/148559 [00:17:21] RoanKattouw, hey. still in the office? [00:17:28] Krenair: Yeah? [00:17:39] * RoanKattouw rarely leaves before 6 [00:17:41] Any idea where James went? To a meeting I guess? [00:17:46] Yeah he's been in meetings [00:17:54] okay [00:18:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: On wikis where anons can't create pages, you aren't told this until you try and save - 10https://bugzilla.wikimedia.org/67550 (10Alex Monk) 5PATC>3RESO/FIX [00:18:47] (03CR) 10Catrope: Make the image model work without a node (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:18:51] (03CR) 10Catrope: Make the image model work without a node (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:19:09] RoanKattouw, ha, wow, thanks [00:20:08] mooeypoo: You mean the ReferenceNode change? [00:20:11] Please +2 that one :) [00:20:21] Right now just mousing over a reference makes VE crash [00:20:31] oops [00:20:47] (03CR) 10Mooeypoo: [C: 032] Followup b6cc76d4: call parent's onSetup/onTeardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148559 (https://bugzilla.wikimedia.org/68415) (owner: 10Catrope) [00:20:50] Thanks [00:20:56] Thank you, and whoops. [00:21:36] I totally missed that in review, too :S [00:22:02] (03CR) 10Catrope: [C: 032] Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 (owner: 10Jforrester) [00:22:34] (03Merged) 10jenkins-bot: Followup b6cc76d4: call parent's onSetup/onTeardown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148559 (https://bugzilla.wikimedia.org/68415) (owner: 10Catrope) [00:23:29] (03Merged) 10jenkins-bot: Tests: Move …/test/… to …/tests/… to be the same as other repos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144608 (owner: 10Jforrester) [00:23:54] (03PS2) 10Catrope: Don't confirm if there's no changes when switching to edit source mode through the page options menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147646 (https://bugzilla.wikimedia.org/68229) (owner: 10Alex Monk) [00:24:32] (03CR) 10Catrope: [C: 032] Don't confirm if there's no changes when switching to edit source mode through the page options menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147646 (https://bugzilla.wikimedia.org/68229) (owner: 10Alex Monk) [00:25:54] (03PS1) 10Catrope: Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 [00:26:02] (03CR) 10jenkins-bot: [V: 04-1] Don't confirm if there's no changes when switching to edit source mode through the page options menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147646 (https://bugzilla.wikimedia.org/68229) (owner: 10Alex Monk) [00:26:17] wait... what? [00:26:29] (03Merged) 10jenkins-bot: Don't confirm if there's no changes when switching to edit source mode through the page options menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147646 (https://bugzilla.wikimedia.org/68229) (owner: 10Alex Monk) [00:26:41] wtf [00:26:44] V-1 but got merged? [00:26:44] ... even more what [00:26:53] haha, right, it ran the tests twice [00:27:00] I rebased that because I expected it to conflict [00:27:01] But the first failed? [00:27:03] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [00:27:04] But the code it conflicts with is unmerged [00:27:18] I should update my patch [00:27:23] Oh and Krenair once I do that you should merge it :) [00:28:23] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229 (10Alex Monk) 5PATC>3RESO/FIX [00:29:17] RoanKattouw, what patch? [00:29:42] (03PS2) 10Catrope: Followup 3dd1a996: don't try to switch to source mode when surface is torn down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148531 [00:29:47] Krenair: That one ---^^ [00:31:48] (03CR) 10Alex Monk: [C: 032] Followup 3dd1a996: don't try to switch to source mode when surface is torn down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148531 (owner: 10Catrope) [00:32:25] Thanks [00:33:04] RoanKattouw, any idea what to do about licensing random VE-related tools? (that run on labs and aren't part of a VE repo) [00:33:33] Do they share code with VE? [00:33:44] no [00:33:45] Or are they completely separate tools that just happen to interact with VE and be written by the same people? [00:34:04] Just happens to look for a VE-related string in the DB and reports to this channel [00:34:14] Oh OK [00:34:17] I intend to MIT license it like we do VE [00:34:24] Yeah that sounds fine [00:34:24] Just need to put the right text in the right places etc. [00:34:30] (03Merged) 10jenkins-bot: Followup 3dd1a996: don't try to switch to source mode when surface is torn down [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148531 (owner: 10Catrope) [00:35:08] I was wondering about just taking the VE LICENSE.txt file, except there's "This software consists of voluntary contributions made by many individuals (AUTHORS.txt) For exact contribution history, see the revision history and logs, available at https://gerrit.wikimedia.org" [00:35:29] which doesn't really apply [00:35:42] Right [00:35:53] I don't know offhand how to do MIT for a single author [00:35:59] Well, uh [00:36:14] Or a few authors? [00:36:45] It's for WMF, who jointly own the copyright, according to the contract [00:37:23] In VE we have "Copyright (c) 2011-2014 VisualEditor Team and others" which should be fine [00:37:41] hah yeah that's right they do own joint copyright to what we write [00:37:41] But I don't think we actually call that out anywhere [00:38:02] (I wonder when James will notice that line actually...) [00:38:30] Like, nowhere in AUTHORS.txt or even in the authors/copyright stuff for MW core do we mention that WMF co-owns copyright to a significant portion of the code [00:39:51] However, I feel like that's probably unnecessary. If the list of authors is such that the people on that list together own the copyright to the entire code base, that should be fine I think [00:40:31] (03CR) 10Catrope: "Looks reasonable, but I'd like to get Trevor's opinion on the pointer-events:none; thing and the promise thing." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [00:42:58] (03CR) 10Catrope: [C: 032] "Thanks, this makes this code much cleaner." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) (owner: 10Bartosz Dziewoński) [00:44:28] RoanKattouw, I'm certainly not going to mention every technical owner of the code, for privacy reasons [00:44:44] (03Merged) 10jenkins-bot: MWLinkNodeInspector: Actually preserve annotations when converting to link annotation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143387 (https://bugzilla.wikimedia.org/67377) (owner: 10Bartosz Dziewoński) [00:44:55] By "technical owner" you mean like in contractual joint copyright situations? [00:45:35] I'll PM you [00:45:38] OK [00:51:08] 3VisualEditor / 3Data Model: VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations - 10https://bugzilla.wikimedia.org/67377 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [00:59:36] RoanKattouw, do you have any naming convention for boolean properties, e.g. should I use isIos or simply ios (iOS?)? [00:59:48] TrevorParscal, ^ [01:00:14] jgonera: Properties are like this.deactivating, methods are like this.isDeactivating [01:00:35] RoanKattouw, so simply ios? [01:00:40] this is not a verb though [01:00:54] and not a temporary state, rather permanent ;) [01:01:02] Yeah... I don't know [01:01:21] (Trevor is sick today) [01:01:31] We have this.active though [01:01:35] So this.ios is probably fine [01:01:37] as a property [01:06:08] Re. [01:14:18] James_F, ? [01:14:33] Hey again. [01:14:44] Hi [01:14:57] (03PS2) 10Catrope: Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 [01:15:07] * James_F is back from meetings of doom. [01:15:15] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [01:16:54] (03CR) 10Jforrester: [C: 032] Stop conditionally registering oojs and oojs-ui [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148549 (owner: 10Catrope) [01:17:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [01:19:17] Krenair: Did you have a question, sorry? [01:19:23] (03PS3) 10Catrope: Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 [01:19:45] James_F, I remembered that you're supposed to license stuff clearly for tools [01:19:57] So was wondering what text to put where, etc. [01:20:06] (03Merged) 10jenkins-bot: Stop conditionally registering oojs and oojs-ui [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148549 (owner: 10Catrope) [01:20:28] In the end I put the MIT license in a LICENSE.txt file [01:20:31] Krenair: Well, generally we as a team use MIT but you should feel free to pick a licence as long as it's OK. [01:20:35] Krenair: That works. [01:20:42] Filled out the year and my name [01:21:11] I don't need to put a header on the files right? [01:21:50] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [01:22:25] Krenair: You don't need to but it's best practice to say "@licence MIT – See LICENCE.txt". [01:23:03] (03PS4) 10Jforrester: Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [01:25:10] (03CR) 10Catrope: [C: 032] Add special case for up/down arrow key on focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147084 (owner: 10Esanders) [01:26:24] (03Merged) 10jenkins-bot: Add special case for up/down arrow key on focusable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147084 (owner: 10Esanders) [01:26:27] (03CR) 10Catrope: [C: 032] Remove is*ArrowKey functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 (owner: 10Esanders) [01:26:29] (03CR) 10jenkins-bot: [V: 04-1] Remove is*ArrowKey functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 (owner: 10Esanders) [01:28:03] RoanKattouw: Merge me: https://gerrit.wikimedia.org/r/#/c/144607/ [01:28:21] (03PS2) 10Catrope: Remove is*ArrowKey functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 (owner: 10Esanders) [01:28:39] (03CR) 10Catrope: [C: 032] "PS2 is a rebase (test->tests rename)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 (owner: 10Esanders) [01:28:59] (03CR) 10Catrope: [C: 032] Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [01:29:42] (03Merged) 10jenkins-bot: Tests: Move …/test/… to …/tests/… to be the same as other repos [oojs/ui] - 10https://gerrit.wikimedia.org/r/144607 (owner: 10Jforrester) [01:29:56] (03Merged) 10jenkins-bot: Remove is*ArrowKey functions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147085 (owner: 10Esanders) [01:36:52] (03CR) 10Catrope: [C: 032] Fix for cursoring into focusable nodes with up/down [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147097 (owner: 10Esanders) [01:38:06] (03Merged) 10jenkins-bot: Fix for cursoring into focusable nodes with up/down [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147097 (owner: 10Esanders) [01:41:23] (03PS2) 10Jforrester: Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 [01:41:52] (03CR) 10Jforrester: Provide contextual help for the page settings dialog's controls (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 (owner: 10Jforrester) [01:42:07] (03CR) 10Catrope: [C: 032] Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 (owner: 10Jforrester) [01:42:50] 3VisualEditor / 3Technical Debt: VisualEditor: Add "role" attributes to UI elements where appropriate - 10https://bugzilla.wikimedia.org/50203#c5 (10James Forrester) 5ASSI>3RESO/FIX Looks fine from my POV. [01:43:55] (03Merged) 10jenkins-bot: Provide contextual help for the page settings dialog's controls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147751 (owner: 10Jforrester) [01:47:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: On wikis where anons can't create pages, you aren't told this until you try and save - 10https://bugzilla.wikimedia.org/67550 (10James Forrester) p:5Unprio>3Normal [01:47:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf15] Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes a:3Roan Kattouw [01:47:50] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229 (10James Forrester) p:5Unprio>3Low [01:50:48] (03CR) 10Catrope: [C: 032] Fix spacing inside fragment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147913 (owner: 10Esanders) [01:52:06] (03Merged) 10jenkins-bot: Fix spacing inside fragment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147913 (owner: 10Esanders) [01:52:52] (03PS3) 10Catrope: Remove onFocusableHistory listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147920 (owner: 10Esanders) [01:52:54] (03CR) 10jenkins-bot: [V: 04-1] Remove onFocusableHistory listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147920 (owner: 10Esanders) [01:57:54] (03PS4) 10Catrope: Remove onFocusableHistory listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147920 (owner: 10Esanders) [01:58:15] (03PS1) 10Jforrester: Clamp height of MWReferenceDialog to between 300 and 400px to avoid it being too small [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148577 (https://bugzilla.wikimedia.org/68232) [01:59:25] (03CR) 10Catrope: [C: 032] "Good catch. These were here because undo/redo used to have their own code path, separate from change(), and events used to be based off ch" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147920 (owner: 10Esanders) [01:59:36] 3VisualEditor / 3Technical Debt: VisualEditor: Deprecate 'live' in favor or 'setup' and 'teardown' - 10https://bugzilla.wikimedia.org/55505 (10James Forrester) 5PATC>3RESO/FIX [02:00:38] (03CR) 10Catrope: [C: 032] Clamp height of MWReferenceDialog to between 300 and 400px to avoid it being too small [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148577 (https://bugzilla.wikimedia.org/68232) (owner: 10Jforrester) [02:00:42] (03Merged) 10jenkins-bot: Remove onFocusableHistory listeners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147920 (owner: 10Esanders) [02:01:26] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [02:02:26] (03Merged) 10jenkins-bot: Clamp height of MWReferenceDialog to between 300 and 400px to avoid it being too small [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148577 (https://bugzilla.wikimedia.org/68232) (owner: 10Jforrester) [02:03:06] (03CR) 10Jforrester: [C: 032] Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:03:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (426f9e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148562 (owner: 10Catrope) [02:03:11] (03CR) 10jenkins-bot: [V: 04-1] Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:04:48] (03CR) 10Catrope: [C: 032] "The Roan of 2011 apologizes profusely" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147987 (https://bugzilla.wikimedia.org/68301) (owner: 10Esanders) [02:05:36] (03PS2) 10Jforrester: Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:05:38] (03CR) 10Jforrester: "PS2 is a manual rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:05:48] (03CR) 10Catrope: [C: 032] Use native focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148056 (owner: 10Esanders) [02:05:51] (03CR) 10Jforrester: [C: 032] Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:06:03] (03Merged) 10jenkins-bot: Fix calculation of affectedRange in transaction processor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147987 (https://bugzilla.wikimedia.org/68301) (owner: 10Esanders) [02:06:40] (03CR) 10Catrope: [C: 032] Fix reference dialog focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148063 (owner: 10Esanders) [02:06:51] 3VisualEditor / 3Data Model: VisualEditor: Pasting more than one paragraph is painfully slow in large documents - 10https://bugzilla.wikimedia.org/68301 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal s:5normal>3enhanc [02:07:10] (03Merged) 10jenkins-bot: Use native focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148056 (owner: 10Esanders) [02:08:06] 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232#c7 (10James Forrester) 5PATC>3RESO/FIX Fixed now. :-) [02:08:09] (03Merged) 10jenkins-bot: Use native focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148057 (owner: 10Esanders) [02:08:32] (03Merged) 10jenkins-bot: Fix reference dialog focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148063 (owner: 10Esanders) [02:08:35] (03CR) 10Catrope: [C: 032] Use proper methods for detecting data type in getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148095 (owner: 10Esanders) [02:10:01] (03Merged) 10jenkins-bot: Use proper methods for detecting data type in getAnnotationIndexesFromOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148095 (owner: 10Esanders) [02:10:06] (03CR) 10Catrope: [C: 032] Add optimised method hasAnnotationsInRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148097 (owner: 10Esanders) [02:10:25] (03PS2) 10Catrope: Use faster computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [02:11:21] (03Merged) 10jenkins-bot: Add optimised method hasAnnotationsInRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148097 (owner: 10Esanders) [02:13:05] mooeypoo: When you get a chance, could you review https://gerrit.wikimedia.org/r/#/c/148104/2 ? I'm not awake enough to decide if it's correct or if it will break things [02:15:45] (03CR) 10Catrope: [C: 032] Remove Firefox listnode hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147985 (owner: 10Esanders) [02:16:53] (03CR) 10Catrope: [C: 032] Bind/unbind setResizableHandlesSizeAndPosition on focus/blur [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147914 (owner: 10Esanders) [02:17:00] (03Merged) 10jenkins-bot: Remove Firefox listnode hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147985 (owner: 10Esanders) [02:17:02] (03CR) 10jenkins-bot: [V: 04-1] Bind/unbind setResizableHandlesSizeAndPosition on focus/blur [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147914 (owner: 10Esanders) [02:20:09] (03PS4) 10Catrope: Bind/unbind setResizableHandlesSizeAndPosition on focus/blur [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147914 (owner: 10Esanders) [02:20:45] (03CR) 10Catrope: [C: 032] Bind/unbind setResizableHandlesSizeAndPosition on focus/blur [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147914 (owner: 10Esanders) [02:21:56] (03CR) 10Catrope: [C: 032] MWReferenceSearchWidget buildIndex optimisations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148069 (owner: 10Esanders) [02:22:03] (03Merged) 10jenkins-bot: Bind/unbind setResizableHandlesSizeAndPosition on focus/blur [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147914 (owner: 10Esanders) [02:23:44] (03Merged) 10jenkins-bot: MWReferenceSearchWidget buildIndex optimisations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148069 (owner: 10Esanders) [02:25:17] (03CR) 10Catrope: [C: 04-1] "This is fine but I don't like the lack of encapsulation/isolation in the search widget" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [02:26:30] (03PS1) 10Jforrester: Update VE core submodule to master (22eb203) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148586 [02:27:08] (03CR) 10Catrope: [C: 032] Use the current document when evaluating activeElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148415 (owner: 10Esanders) [02:27:25] (03PS8) 10Jforrester: build: Implement 'phantomcheck' task [oojs/ui] - 10https://gerrit.wikimedia.org/r/141441 (owner: 10Krinkle) [02:27:51] (03CR) 10Catrope: [C: 04-1] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [02:28:25] (03Merged) 10jenkins-bot: Use the current document when evaluating activeElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148415 (owner: 10Esanders) [02:30:21] (03PS1) 10Jforrester: Update VE core submodule to master (97a5007) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148587 [02:32:20] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (97a5007) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148587 (owner: 10Jforrester) [02:34:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (97a5007) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148587 (owner: 10Jforrester) [02:40:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c7 (10James Forrester) 5ASSI>3RESO/FIX Goi... [08:26:54] 3VisualEditor: Tooltips for Insert -> Special Character - 10https://bugzilla.wikimedia.org/68425 (10Daniel Naber) 3UNCO p:3Unprio s:3normal a:3None There are at least two dash-like characters in the "Special character" dialog. They should have a tooltip describing them, otherwise it won't be obvious to... [09:01:12] 3VisualEditor: Add non-breaking space to the "special character" dialog - 10https://bugzilla.wikimedia.org/68429 (10Daniel Naber) 3UNCO p:3Unprio s:3normal a:3None The most obvious way to add a non-breaking space (other than typing it, see #51045) would be the Insert -> Special Characters dialog. [09:40:52] 3VisualEditor: Tooltips for Insert -> Special Character - 10https://bugzilla.wikimedia.org/68425#c1 (10Andre Klapper) s:5normal>3enhanc (In reply to Daniel Naber from comment #0) > There are at least two dash-like characters in the "Special character" > dialog. They should have a tooltip describing them, o... [09:54:23] 3VisualEditor / 3Editing Tools: Add non-breaking space to the "special character" dialog - 10https://bugzilla.wikimedia.org/68429 (10Andre Klapper) s:5normal>3enhanc [09:54:52] 3VisualEditor / 3Editing Tools: Tooltips for Insert -> Special Character - 10https://bugzilla.wikimedia.org/68425 (10Andre Klapper) [10:06:23] 3VisualEditor / 3Editing Tools: Tooltips for Insert -> Special Character - 10https://bugzilla.wikimedia.org/68425#c2 (10Daniel Naber) (In reply to Andre Klapper from comment #1) > Assuming you refer to − and — : Don't use and situations highly depend on > cultures (and languages) anyway? I guess so (and th... [10:37:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Breadcrumb disappears upon saving page - 10https://bugzilla.wikimedia.org/68432 (10This, that and the other) 3NEW p:3Unprio s:3normal a:3None After using VE to edit a subpage in a namespace with subpages enabled, and saving changes, the breadcrumb... [11:36:36] 3VisualEditor: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org - 10https://bugzilla.wikimedia.org/68297#c1 (10Bartosz Dziewoński) This is causing breakage in edits (that is not being detected by VE): https://www.mediawiki.org/w/index.php?title=Manual:Skinning&diff=1074312... [12:34:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: Consider changing behaviour on launch when the database is locked - 10https://bugzilla.wikimedia.org/68383#c4 (10This, that and the other) When trying to save wikitext during a DB lock, you can just copy-paste your wikitext, save it to a text file, and pa... [14:03:27] (03PS3) 10Esanders: Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 [14:03:44] (03CR) 10jenkins-bot: [V: 04-1] Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [14:06:48] (03PS1) 10Esanders: [BREAKING CHANGE] Fix camel-casing of countNonInternalElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148657 [14:07:46] (03PS2) 10Esanders: [BREAKING CHANGE] Fix camel-casing of countNonInternalElements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148657 [14:09:16] (03PS1) 10Esanders: Use renamed countNonInternalElements function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 [14:10:03] (03CR) 10jenkins-bot: [V: 04-1] Use renamed countNonInternalElements function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 (owner: 10Esanders) [14:10:09] (03PS2) 10Esanders: Use renamed countNonInternalElements function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 [14:10:47] (03CR) 10jenkins-bot: [V: 04-1] Use renamed countNonInternalElements function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148659 (owner: 10Esanders) [14:12:39] (03PS4) 10Esanders: Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 [14:51:52] (03CR) 10Alex Monk: Show pending state and block clicks when switching to source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [14:57:35] Heya. [15:00:25] (03PS5) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [15:00:40] (03CR) 10jenkins-bot: [V: 04-1] Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [15:01:07] hey [15:01:34] urgh, what [15:01:51] Oh... That's not a fun rebase. [15:03:27] Enjoy! [15:03:43] Clearly it's all Roan's fault for not being around to merge things more in the last fortnight. :-) [15:05:04] yep :D [15:12:16] (03CR) 10Bartosz Dziewoński: "Another point, people who want to insert an external link probably won't use the tool, but just paste it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [15:12:51] (03PS1) 10Esanders: Fix bug in disconnect loop [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 [15:13:38] ugh, I have no idea how to do this with the new window stuff [15:15:31] getWindow... just returns a promise [15:15:53] But I need the actual window [15:19:17] meh, hacked around it [15:21:26] oh okay, getWindow resolves with the window object. [15:36:46] (03PS6) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [15:37:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf14] ooui-dialog-* messages not imported - 10https://bugzilla.wikimedia.org/68327 (10James Forrester) 5PATC>3RESO/FIX [15:39:27] heh, I'd been meaning to fix that at some point [15:40:51] (03CR) 10jenkins-bot: [V: 04-1] Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [15:41:25] Krenair: I should modify the import script at some point. [15:42:10] (03PS7) 10Alex Monk: Show pending state and block clicks when switching to source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) [15:44:38] (03Abandoned) 10Jforrester: Update VE core submodule to master (22eb203) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148586 (owner: 10Jforrester) [15:51:47] (03CR) 10Catrope: [C: 04-1] Fix bug in disconnect loop (032 comments) [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 (owner: 10Esanders) [15:55:53] James_F, btw, I could get my script to run directly [15:56:06] And cron would submit my jobs [15:56:12] Krenair: Oh, cool. [15:56:15] But the jobs appeared to do nothing [15:56:21] Ah. Less cool. [15:56:31] As in they didn't return? [15:56:53] There's something I've seen about cron and jobs going nowhere on Labs. [15:56:56] * James_F Googles. [15:57:42] I get the email saying my job got submitted [15:58:14] Also, nothing happens if I submit normally (without cron) [15:58:56] Krenair: http://lists.wikimedia.org/pipermail/labs-l/2014-June/002695.html might be relevant? [15:59:07] Krenair: Are you accessing RCStream or the DBs directly? [15:59:09] It sits there for a little bit with no queue, then when it gets a queue it disappears from qstat very quickly [15:59:12] DBs [15:59:37] Ah, apparently you have to use "the grid" to do cron-based DB access. [15:59:43] I don't know what that is. [16:00:10] The annoying thing is I have no idea where to find errors [16:00:40] 3VisualEditor / 3MediaWiki integration: VisualEditor: Breadcrumb doesn't reappear upon saving page - 10https://bugzilla.wikimedia.org/68432 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk [16:00:41] Is RCStream not an option? [16:00:47] Hm [16:00:51] Or is it just the DB access is easier? :-) [16:01:06] ew, I have found a python2.out that appears to have something useful [16:01:16] Yay Python. ;-) [16:02:49] Was some old log entry I think [16:03:20] Cleared those files, started again (properly naming the job this time instead of letting it default to the command name) [16:03:23] no useful output [16:04:11] in fact the .err and .out files are both empty [16:05:32] despite my print("test") at the top of the main file [16:06:46] Hmm. [16:07:00] Does cron run it as a different user/session? [16:10:24] should be running it as the service user [16:10:36] But cron is irrelevant, it fails when I submit the job normally (i.e. without cron) [16:14:35] Hmm. [16:14:43] But it worked yesterday? [16:15:17] ... no [16:15:30] This was not working yesterday [16:15:32] Oh, OK. [16:15:38] I am still having the same issue [16:15:45] Your data yesterday was not from the script? [16:15:53] It was from the script [16:16:06] Which I was running manually on tools-login [16:16:10] Ah. [16:16:12] Fun. [16:18:51] (03PS1) 10Esanders: Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 [16:19:38] (03CR) 10jenkins-bot: [V: 04-1] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders) [16:23:04] (03PS1) 10Esanders: Use shorthand for collapsed ranges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148693 [16:23:06] (03PS1) 10Jforrester: SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 [16:23:56] (03CR) 10jenkins-bot: [V: 04-1] Use shorthand for collapsed ranges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148693 (owner: 10Esanders) [16:28:27] (03PS2) 10Esanders: Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 [16:28:29] (03PS2) 10Esanders: Use shorthand for collapsed ranges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148693 [16:31:19] (03PS2) 10Esanders: Fix bug in disconnect loop [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 [16:35:32] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org?diff=105648366 [16:35:32] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org?diff=67191363 [16:35:32] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org?diff=64370540 [16:36:01] James_F, that worked [16:48:34] James_F, k, it should run at 16:30 every day now [17:16:52] Krenair: Yay. [17:35:39] (03CR) 10Siebrand: Put "re-use reference" in the toolbar "Cite" menu, and give it an icon (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 (https://bugzilla.wikimedia.org/68201) (owner: 10Jforrester) [17:36:30] (03CR) 10Jforrester: Put "re-use reference" in the toolbar "Cite" menu, and give it an icon (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 (https://bugzilla.wikimedia.org/68201) (owner: 10Jforrester) [17:41:09] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16014 --> https://bugzilla.wikimedia.org/attachme... [17:41:51] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455#c1 (10Ritu Swain) Created attachment 16015 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16015&action=edit screenshot... [17:59:18] (03PS15) 10Catrope: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [17:59:21] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [17:59:23] (03PS5) 10Catrope: ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [17:59:39] (03CR) 10jenkins-bot: [V: 04-1] ve-mw configuration of the Comment node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [18:02:45] edsanders: So that ---^^ will only recognize comments in content branch nodes. It works for me, but it's not perfect because it doesn't recognize things like a comment between a table and an image [18:02:48] Right now it's overly conservative and doesn't distinguish between e.g. (which is OK) and
(which is not OK) [18:03:05] (03PS19) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [18:03:49] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [18:04:30] (03PS20) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [18:05:48] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [18:06:53] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) a:3Roan Kattouw [18:06:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) a:3Roan Kattouw [18:07:14] Krenair: Were you looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=68235 ? Don't want people clashing on work, wasting time. :-) [18:09:05] James_F, I've just been having dinner, was about to go and look for that bug [18:09:13] Krenair: OK, that works. :-) [18:10:07] James_F, but actually looking back at it, I could do with a second pair of eyes looking at what I found so far [18:13:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c2 (10Alex Monk) p:5Normal>3High officewiki is important, actually [18:14:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235 (10Alex Monk) s:5normal>3major [18:14:15] :-) [18:20:37] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455#c2 (10Ritu Swain) Test Environment:Production [18:28:53] James_F++ : great changes in the saving dialog. [18:29:18] aharoni: Glad you're happy. :-) [18:29:38] aharoni: BTW, we should talk about LTR/RTL stuff (and more!) in Wikimania if you have time. [18:29:45] The close button in the diff window pestered me for a long time. It was not bad enough to complain, but I'm relieved that it's better. [18:29:57] * James_F nods. [18:30:10] You can still close with "Esc" but there's no button for it. [18:30:17] I'm not totally sure that's great, but… [18:30:57] James_F: My Wikimania attendance is questioned because of the horrible poop you may have heard about in the news - http://www.ynetnews.com/articles/0,7340,L-4548564,00.html . [18:31:14] But if I'm there, then I'll be delighted to talk about RTL, of course. [18:31:16] aharoni: Yeah, mooeypoo has the (inverse) issue where they've cancelled her flight tomorrow. [18:31:41] Oh they did, how lovely. I hope she enjoys her stay where that will be :) [18:34:35] James_F: So I was about to save with the lovely new saving dialog, and got a nice little laconic pink window saying "503" :) [18:34:42] on mediawiki.org. [18:35:41] aharoni: Eurgh. Lovely. :-( [18:35:59] gwicke: Think we should purge the Varnish cache, then? That'd be… quite an operation. [18:36:36] James_F: mmm, and I guess that it involves an extra little bug: after I press the dismiss button there, the "Save page" is still disabled, so I cannot try saving again. [18:36:50] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860#c4 (10Alex Monk) 5ASSI>3RESO/FIX Went with approach #3, it's a python script run under the 'wm-ve-needcheck-reporter' service user in tool l... [18:37:09] https://www.mediawiki.org/w/index.php?title=Architecture_guidelines&diff=1075306&oldid=1073582 [18:37:11] James_F: it's actually not that complicated, but needs root [18:37:18] Krenair: Yay. [18:37:30] yeah, sorted the issues with those hundreds of DB connections :) [18:37:37] is RoanKattouw_away still on vacation? [18:37:39] gwicke: I meant more about the catastrophic slowness for users for the next few days. [18:37:42] gwicke: No, he's in meetings. [18:37:45] down to just 7 connections [18:37:49] k [18:37:57] gwicke, he returned yesterday and merged about 30 changes for us. :D [18:37:58] gwicke: Indeed, he's now 8 minutes late for a meeting with me. [18:38:24] James_F: we could clear one cache first to reduce the impact [18:38:32] second cache 1-2 days later [18:38:35] 3VisualEditor: VisualEditor: Set up an IRC bot in #mediawiki-visualeditor to report visualeditor-needcheck edits on WMF wikis - 10https://bugzilla.wikimedia.org/62860 (10James Forrester) [18:38:43] * MatmaRex wonders which Varnish cache [18:38:44] each of those holds 50% of the total cache [18:39:03] gwicke: Still pretty major. We should work out for sure that that's the problem first. [18:39:09] James_F, this is not going to be deployed with the VE code [18:39:11] MatmaRex: Parsoid-Varnish. [18:39:13] It's a standalone tool sitting in tool labs [18:39:17] Krenair: Sure, but it was done this week. [18:39:25] Krenair: Otherwise we'll lose track. [18:39:29] But it's not VE-deploy-2014-07-24 :| [18:39:39] It was done this week. [18:39:46] fine.. [18:40:26] * James_F grins. [18:40:38] 3VisualEditor: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None I tried editing a page. I pressed Save and received a little "Something went wrong" wind... [18:44:38] James_F, are Roan or Timo looking into the officewiki thing? [18:44:55] (03PS16) 10Jforrester: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) [18:45:05] (03CR) 10Jforrester: "PS16 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [18:45:15] Krenair: Not right now, no. [18:45:19] okay [18:45:36] edsanders: ^^^ If you could review Roan's approach on the hybrid node/meta approach for comments that'd be great. [18:45:51] edsanders: No need to fully review and merge (though if you have time, that'd be great). [18:56:16] gwicke: I don't see how clearing the Varnish cache helps with 503s [18:56:27] 503 means "I had a cache miss, tried to get fresh content from a backend, but failed" [18:57:28] RoanKattouw: cache miss processing got really slow recently [18:58:09] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: Cannot read property 'context' of undefined,on pressing return after a reference note - 10https://bugzilla.wikimedia.org/68462 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Place the cursor af... [18:58:17] RoanKattouw: how's the pybal health of the backends? [18:58:27] Haven't checked [18:58:30] Will check that after this meeting [19:02:39] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [19:07:08] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10Roan Kattouw) a:3Ed Sanders [19:09:15] James_F, yeah, I haven't been able to get any further than I did on the bug [19:10:22] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10Roan Kattouw) a:5Roan Kattouw>3Ed Sanders [19:12:24] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10Roan Kattouw) a:3Ed Sanders [19:17:55] (03PS3) 10Catrope: Fix bug in disconnect loop [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 (owner: 10Esanders) [19:18:00] (03CR) 10Catrope: [C: 032] Fix bug in disconnect loop [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 (owner: 10Esanders) [19:19:35] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: Cannot read property 'context' of undefined,on pressing return after a reference note - 10https://bugzilla.wikimedia.org/68462#c1 (10Roan Kattouw) 5NEW>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/148671/ , needs an oojs release. [19:20:59] (03Merged) 10jenkins-bot: Fix bug in disconnect loop [oojs/core] - 10https://gerrit.wikimedia.org/r/148671 (owner: 10Esanders) [19:30:07] (03PS1) 10Jforrester: Tag v1.0.11 [oojs/core] - 10https://gerrit.wikimedia.org/r/148742 [19:30:50] (03CR) 10Catrope: [C: 032] Tag v1.0.11 [oojs/core] - 10https://gerrit.wikimedia.org/r/148742 (owner: 10Jforrester) [19:33:05] 3VisualEditor / 3Editing Tools: VisualEditor: "TypeError: Cannot read property 'context' of undefined" on pressing return after a reference node - 10https://bugzilla.wikimedia.org/68462 (10James Forrester) p:5Unprio>3Normal [19:47:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223 (10Rummana Yasmeen) [19:49:06] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843#c6 (10James Forrester) Roan says the fix is to fix the pre-population of the link inspector in create m... [19:58:40] RoanKattouw: https://gerrit.wikimedia.org/r/148753 [20:10:25] (03Merged) 10jenkins-bot: Tag v1.0.11 [oojs/core] - 10https://gerrit.wikimedia.org/r/148742 (owner: 10Jforrester) [20:10:52] (03PS1) 10Jforrester: build: Tell people which version they're using [oojs/core] - 10https://gerrit.wikimedia.org/r/148756 [20:11:58] (03CR) 10Catrope: [C: 032] build: Tell people which version they're using [oojs/core] - 10https://gerrit.wikimedia.org/r/148756 (owner: 10Jforrester) [20:18:21] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c8 (10Rummana Yasmeen) 5RESO/FIX>3REOP This is happening again on Betalabs [20:19:59] [13oojs.github.io] 15jdforrester created 06release-1.0.11 (+1 new commit): 02https://github.com/oojs/oojs.github.io/commit/ff0798c64f5a [20:19:59] 13oojs.github.io/06release-1.0.11 14ff0798c 15James D. Forrester: Publish v1.0.11 release from npm [20:20:34] [13oojs.github.io] 15jdforrester opened pull request #2: Publish v1.0.11 release from npm (06master...06release-1.0.11) 02https://github.com/oojs/oojs.github.io/pull/2 [20:21:15] [13oojs.github.io] 15jdforrester pushed 1 new commit to 06master: 02https://github.com/oojs/oojs.github.io/commit/e1da7717da84342bc92c9c185a2a0e01095111b8 [20:21:16] 13oojs.github.io/06master 14e1da771 15James Forrester: Merge pull request #2 from oojs/release-1.0.11... [20:22:09] (03PS1) 10Catrope: Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148757 (https://bugzilla.wikimedia.org/68235) [20:23:21] 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appear near newly added references - 10https://bugzilla.wikimedia.org/54712#c21 (10Elitre) 5RESO/FIX>3REOP I believe this is happening again at it.wp. See https://it.wikipedia.org/w/index.php?title=AA.VV.&diff=prev&oldid=67188720 (snowmen) or https:... [20:27:17] (03PS2) 10Catrope: Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148757 (https://bugzilla.wikimedia.org/68223) [20:28:18] (03CR) 10Jforrester: [C: 031] Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148757 (https://bugzilla.wikimedia.org/68223) (owner: 10Catrope) [20:29:35] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235#c4 (10James Forrester) 5PATC>3ASSI Mis-fire. [20:30:57] (03CR) 10Catrope: Show pending state and block clicks when switching to source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [20:32:19] (03PS1) 10Trevor Parscal: [WIP] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [20:32:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal) [20:34:23] (03CR) 10Hashar: [C: 032] "Zuul got broken" [oojs/core] - 10https://gerrit.wikimedia.org/r/148756 (owner: 10Jforrester) [20:34:58] (03CR) 10Alex Monk: Show pending state and block clicks when switching to source mode (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144505 (https://bugzilla.wikimedia.org/65012) (owner: 10Alex Monk) [20:37:12] (03Merged) 10jenkins-bot: build: Tell people which version they're using [oojs/core] - 10https://gerrit.wikimedia.org/r/148756 (owner: 10Jforrester) [20:41:32] (03CR) 10Jforrester: [C: 032] "Per Trevor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148757 (https://bugzilla.wikimedia.org/68223) (owner: 10Catrope) [20:46:38] (03Merged) 10jenkins-bot: Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148757 (https://bugzilla.wikimedia.org/68223) (owner: 10Catrope) [20:48:04] (03PS1) 10Jforrester: Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148770 (https://bugzilla.wikimedia.org/68223) [20:49:39] edsanders, hey [20:50:02] (03PS1) 10Catrope: Actually document .static.nodeModel in MWExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148783 [20:50:54] (03CR) 10Jforrester: [C: 032] Actually document .static.nodeModel in MWExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148783 (owner: 10Catrope) [20:51:08] (03PS17) 10Esanders: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [20:51:52] (03CR) 10Esanders: "Fixed MW tests in Ie2787c3e" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [20:52:24] (03CR) 10Catrope: [C: 04-1] SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 (owner: 10Jforrester) [20:52:53] (03PS6) 10Esanders: Use comment node and update tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [20:53:11] Krenair, hey [20:53:36] edsanders, so since you made https://gerrit.wikimedia.org/r/#/c/107036/3 there's been another few things noticed that needed updating as well [20:53:53] The latest of which is https://bugzilla.wikimedia.org/show_bug.cgi?id=68432 [20:54:10] I'm wondering why we don't just reload the page instead [20:54:46] Krenair: so you can upstream the fixes one day! and we can have fully ajaxed mediawiki! [20:55:11] Hmm. [20:55:13] I guess. [20:55:17] RoanKattouw: https://gerrit.wikimedia.org/r/148831 [20:56:11] Krenair: you can start upstreaming them already, see /resources/src/mediawiki.action/mediawiki.action.edit.preview.js ;) [20:56:26] (note that this file currently has a rewrite pending in gerrit) [20:58:44] (03PS2) 10Jforrester: SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 [21:01:30] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/148770/ [21:02:57] Krenair, yes, because slow [21:03:28] MatmaRex, so for reference, currently our replacePageContent code deals with updating the page text (duh), only touching the *descriptions* on file/category pages, category links, the 'redirect page' subheading thing [21:04:39] reloading the page has a massive overhead, and we can work around most of the issues [21:05:00] (03CR) 10jenkins-bot: [V: 04-1] Use comment node and update tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [21:05:42] (03CR) 10Catrope: [BREAKING CHANGE] Show comments inline to the user (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [21:05:51] (03CR) 10Catrope: [C: 04-1] "Comments on PS16" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [21:06:08] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [21:06:47] (03CR) 10jenkins-bot: [V: 04-1] Actually document .static.nodeModel in MWExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148783 (owner: 10Catrope) [21:08:03] (03Merged) 10jenkins-bot: Actually document .static.nodeModel in MWExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148783 (owner: 10Catrope) [21:20:20] (03PS18) 10Esanders: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [21:29:58] (03PS19) 10Esanders: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [21:31:48] James_F|Away, what is data-comment about? [21:32:16] edsanders: Have you seen my comments on PS16? [21:32:26] Also mooeypoo is the actual author [21:32:56] yes [21:33:09] I didn't see your comments [21:33:24] just fixed some of the things you pointed out though [21:33:35] Yeah [21:33:44] Thanks for fixing those tests [21:33:59] Though it seems you didn't do that for all of them [21:34:50] RoanKattouw, I just fixed the tests that were breaking, in those cases we had commentMeta anyway [21:34:55] Right [21:35:08] what we use to make meta elements other than comments? [21:35:23] Any / tag [21:37:27] also we need to do something clever for copy/paste [21:37:42] Haah [21:37:44] Yeah [21:38:25] ... [21:38:34] and then the comment in an attribute [21:38:45] Right [21:38:52] I take it copy-pasting of actual comment nodes fails horribly? [21:39:19] they're ignore from what I can tell [21:39:27] Right [21:39:29] OK, so [21:39:33] Regarding improvements to this comment code [21:39:42] I'm gonna address the comments that I left by amending this change [21:39:48] But other than that let's do the rest as separate changes [21:40:07] http://edg2s.github.io/content-editable-sandbox/ [21:40:07] Like, I think I'll get rid of the edit button (and instead just show an input widget immediately, like in the link inspector), but in a separate change [21:40:23] Cause I wanna avoid bloat for this one [21:40:32] stripped in chrome [21:40:38] Yeah stripped in FF too [21:41:23] yup [21:42:34] I'd like a designer (Trevor/Kaity/me) to take a stab at the CE node too [21:43:18] Yeah [21:43:43] James wants to put the ugly initial version in tomorrow's cut, then polish it in next week's [21:44:25] I suggested that we could take it a bit slower but he didn't seem to want to postpone it [21:44:52] I mean functionality-wise it's fine after a little cleanup, so if we can live with it being ugly initially then it's fine IMO [21:45:18] And copy-paste support is something we can do for next week (or even later) as ewll [21:49:15] haha I found a bug [21:49:20] The remove button is visible in insertion mode [21:49:24] And clicking it causes an error [21:58:54] whats this CE node? [22:02:18] kaity: It's a comment editing thing [22:02:23] If you come over to my desk I'll show you [22:02:26] RoanKattouw: oh yes [22:02:54] kaity: Shall I show you how it currently works before I rip it up and make it a bit nicer? :) [22:03:11] RoanKattouw: I'll be over in a few minutes [22:03:24] OK cool [22:03:39] (03CR) 10Catrope: [C: 032] Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148770 (https://bugzilla.wikimedia.org/68223) (owner: 10Jforrester) [22:03:42] (03PS1) 10Cmcmahon: [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 [22:04:37] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 (owner: 10Cmcmahon) [22:09:45] * RoanKattouw scowls in the general direction of TextInputWidget [22:10:08] Auto-sizing is only done for user interaction, not for setValue() *sigh* [22:10:08] James_F, are you out of the meeting now? [22:10:18] Krenair: He is, but now he's getting lunch [22:10:22] ok [22:10:22] RoanKattouw, is there a short way of calling a parent method in OO.js nowadays? [22:10:23] Which is probably a good idea given that it's 3pm [22:10:26] * RoanKattouw ate lunch at 2 [22:10:27] (03Merged) 10jenkins-bot: Followup b141a7d23: don't display:none; the popup in the DesktopContext [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148770 (https://bugzilla.wikimedia.org/68223) (owner: 10Jforrester) [22:10:31] heh [22:10:37] jgonera: Not yet. Timo and Trevor were brainstorming over one last week I think [22:10:40] ok [22:10:42] thanks [22:11:20] jgonera: That's pretty much the only reason why I haven't already pushed hard to replace Mantle's object system with oojs: we don't have an equivalent of this._super() [22:12:36] RoanKattouw, I'm all for using one system but even when you do don't push us _too_ hard because it'll mean rewriting 90% of MobileFrontend's JS code. not in a significant way but it's just going to be a PITA change that touches half of the code base ;) [22:12:59] Yeah that's true :) [22:13:16] I guess by "pushing hard" I meant something like "bribing you into agreeing to it by offering to do most of the work" [22:13:18] :) [22:13:26] that being said, it would be great to standardize on this in a couple months [22:13:33] yeah [22:16:29] RoanKattouw, I see something like "ve.ui.ContextMenuWidget.super.call( this, config );", not short but at least I don't have to specify the parent [22:16:45] Yes [22:16:52] That's what we're standardizing on now [22:17:01] that's a constructor actually, what I need is more like "ve.ui.AnnotationInspector.super.prototype.getActionProcess.call( this, action );" [22:17:03] In oojs-ui we've already fully migrated but the VE repos are mixed right now [22:17:12] jgonera: Yeah and that's hella long [22:17:29] definitely not short ;) [22:17:32] One thing we've thrown around is to have a local variable in a closure scope in which you store ve.ui.AnnotationInspector [22:17:48] So you can do foo.super.prototype.methodName.call [22:18:16] Or maybe create the class in a closure scope under a short name, then export it. Or something [22:18:21] We haven't really decided yet [22:18:28] The sad thing is that this.constructor.super doesn't work [22:18:35] You'd expect it to, but it blows up in your face [22:19:40] (03PS2) 10Cmcmahon: [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 [22:21:44] only ve.ui.AnnotationInspector or ve.ui.AnnotationInspector.super.prototype? [22:24:22] Maybe one, maybe the other [22:24:26] Let me reread this thread [22:24:37] It happened while I was on vacation so I didn't really read it very well [22:25:27] We're also considering defining classes in a way that's more similar to how Mantle does it [22:26:00] Lots of suggestions are flying around [22:26:12] jgonera: I can forward that thread to you if you want [22:26:41] RoanKattouw, where is that discussion happening? [22:27:59] (03PS1) 10Catrope: Make TextInputWidget's autosizing work when setValue() is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/148862 [22:28:17] jgonera: Private email :( should really have been editing-tech [22:28:42] RoanKattouw, yeah... that would be better in future. please, forward it to me [22:29:15] Forwarded [22:29:28] It's a bit confusing because it starts with a suggestion from Trevor that is then rejected by Timo for being broken [22:30:08] (03PS1) 10Jforrester: Update VE core submodule to master (1bfcb16) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148865 [22:30:13] 3VisualEditor / 3Editing Tools: VisualEditor: Page Settings option is getting cut off in Betalabs - 10https://bugzilla.wikimedia.org/68483 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16025 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16025&action=edit Screenshot... [22:30:49] (03Abandoned) 10Jforrester: Update VE core submodule to master (1bfcb16) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148865 (owner: 10Jforrester) [22:32:53] (03PS1) 10JGonera: Allow for a custom mechanism for scrolling to a section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 [22:35:17] (03CR) 10Esanders: [C: 04-1] "The inspector still needs some work, and we could do with a proper design for the icons." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [22:35:42] (03PS1) 10Catrope: Update VE core to 7cf68c0 [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148868 [22:36:02] edsanders: I'm almost done with my fixes for the inspector [22:36:10] There was a bunch of weird and broken stuff [22:36:26] Also kaity said she'd come look at what we have later today [22:37:08] (03PS1) 10Jforrester: Update VE core submodule to master (1bfcb16) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148869 [22:37:34] (03CR) 10jenkins-bot: [V: 04-1] Update VE core to 7cf68c0 [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148868 (owner: 10Catrope) [22:37:50] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1bfcb16) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148869 (owner: 10Jforrester) [22:38:38] James_F, hey [22:38:39] RoanKattouw, kaity cool, just ignore what we have at the moment, it was just thrown together with things we had lying around. [22:38:45] I'd like to not affect line height as much [22:39:42] (03Merged) 10jenkins-bot: Update VE core submodule to master (1bfcb16) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148869 (owner: 10Jforrester) [22:41:42] (03PS3) 10Cmcmahon: [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 [22:44:52] edsanders: Make them smaller? [22:46:47] I thought that we'd need to build subpage breadcrumbs on the client for https://bugzilla.wikimedia.org/show_bug.cgi?id=68432 [22:47:01] but actually it seems we reload the page when creating a new one [22:47:42] So what's currently broken here is how we try to deal with the 'redirect page' text under the title [22:48:21] We just do $( '#contentSub' ).text( ve.msg( 'redirectpagesub' ) ); which will overwrite the subpage breadcrumb [22:48:22] 3VisualEditor / 3Editing Tools: VisualEditor: Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16026 --> https://bugzilla.wikimedia.org/attac... [22:48:29] Krenair: Ah. [22:48:36] Unfortunately, core doesn't wrap that redirect text in a way which we could single it out. [22:48:55] edsanders: So... about copy paste. I just successfully copy-pasted a comment in Chrome [22:49:06] Which baffles me because I watched it fail in your sandbox [22:56:48] (03CR) 10Jforrester: SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 (owner: 10Jforrester) [22:58:22] 3VisualEditor / 3Editing Tools: VisualEditor: Language Selector dialog does not close with Language inspector, when the “Select a language” is opened from the top of the page. - 10https://bugzilla.wikimedia.org/68486 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Environment-test2 steps- 1> open a... [23:00:04] (03PS2) 10Jforrester: Make TextInputWidget's autosizing work when setValue() is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/148862 (owner: 10Catrope) [23:00:15] (03CR) 10Jforrester: [C: 032] Make TextInputWidget's autosizing work when setValue() is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/148862 (owner: 10Catrope) [23:00:55] (03Merged) 10jenkins-bot: Make TextInputWidget's autosizing work when setValue() is called [oojs/ui] - 10https://gerrit.wikimedia.org/r/148862 (owner: 10Catrope) [23:02:38] 3VisualEditor / 3Editing Tools: VisualEditor: Page Settings option is getting cut off in Betalabs - 10https://bugzilla.wikimedia.org/68483#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 57366 *** [23:02:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c3 (10James Forrester) *** Bug 68483 has been marked as a duplicate of this bug. *** [23:03:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366 (10James Forrester) [23:03:50] 3VisualEditor / 3Editing Tools: VisualEditor: Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484 (10James Forrester) p:5Unprio>3High s:5normal>3major [23:05:31] (03PS2) 10Jforrester: Update VE core to 7cf68c0 [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148868 (owner: 10Catrope) [23:14:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Breadcrumb doesn't reappear upon saving page - 10https://bugzilla.wikimedia.org/68432#c1 (10Alex Monk) So what's currently broken here is how we try to deal with the 'redirect page' text under the title We just do $( '#contentSub' ).te... [23:20:07] (03CR) 10MaxSem: [C: 032] Update VE core to 7cf68c0 [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148868 (owner: 10Catrope) [23:21:37] (03CR) 10MaxSem: [V: 032] Update VE core to 7cf68c0 [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/148868 (owner: 10Catrope) [23:26:36] (03Abandoned) 10JGonera: [WIP] Highlight proper item in Cite menu when reference selected [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/136358 (owner: 10JGonera) [23:46:35] (03PS20) 10Catrope: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:47:28] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:47:38] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148891 [23:48:25] (03CR) 10Catrope: [BREAKING CHANGE] Show comments inline to the user (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:48:56] (03PS21) 10Catrope: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:51:50] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226#c3 (10Rummana Yasmeen) Created attachment 16027 --> https://bugzilla.wikimedia.org/a... [23:52:05] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226 (10Rummana Yasmeen) 5RESO/FIX>3REOP [23:55:50] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c8 (10Rummana Yasmeen) Verified the fix in Bet... [23:57:57] (03PS1) 10Jforrester: Update OOjs to v1.0.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148893 [23:59:13] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs to v1.0.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148893 (owner: 10Jforrester) [23:59:35] 3VisualEditor / 3Editing Tools: VisualEditor: "TypeError: Cannot read property 'context' of undefined" on pressing return after a reference node - 10https://bugzilla.wikimedia.org/68462#c2 (10Rummana Yasmeen) Verified the fix in Betalabs [23:59:59] (03PS2) 10Jforrester: Update OOjs to v1.0.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148893