[00:00:24] (03PS1) 10Cmcmahon: [BrowserTest] Add parameter no longer exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148894 [00:00:37] (03PS22) 10Catrope: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [00:00:42] (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148893 (owner: 10Jforrester) [00:01:58] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [00:02:13] (03Merged) 10jenkins-bot: Update OOjs to v1.0.11 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148893 (owner: 10Jforrester) [00:02:54] 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232#c8 (10Rummana Yasmeen) Verified the fix in Betalabs [00:04:19] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [00:05:37] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [00:07:09] (03PS7) 10Catrope: Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:07:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf15] Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [00:07:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf15] Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415#c4 (10Rummana Yasmeen) Verified the fix in Betalabs [00:08:17] (03PS8) 10Catrope: Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:08:33] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:10:21] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053#c1 (10Rummana Yasmeen) Verified the fix in Betalabs [00:11:03] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:18:36] (03PS9) 10Catrope: Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:19:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Link inspector is not opening up in FF in first attempt, upon trying second time it throws error "TypeError: manager.opening is null" and appears with broken UI - 10https://bugzilla.wikimedia.org/68223#c6 (10Rummana Yasmeen) 5PATC>3RESO/FIX... [00:20:29] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:21:58] (03PS10) 10Catrope: Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:22:05] 3VisualEditor / 3ContentEditable: VisualEditor: Display HTML comments to the editor (and make them editable/creatable/removable) - 10https://bugzilla.wikimedia.org/49603 (10James Forrester) 5PATC>3RESO/FIX [00:22:14] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:24:07] (03CR) 10Catrope: [C: 032] Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [00:24:39] (03PS1) 10Jforrester: Bump the height of the references list a little [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148903 (https://bugzilla.wikimedia.org/68226) [00:24:49] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:25:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (4424195) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147401 (owner: 10Mooeypoo) [00:26:01] (03CR) 10Catrope: [C: 04-1] "Looks good, minor comment on the config option" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 (owner: 10JGonera) [00:27:18] (03Merged) 10jenkins-bot: Defer building of MWReferenceSearchWidget index [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148070 (owner: 10Esanders) [00:27:40] (03PS9) 10Jforrester: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:28:04] (03CR) 10Jforrester: Make the image model work without a node (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:28:43] (03CR) 10Catrope: [C: 032] Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:29:37] 3VisualEditor / 3Editing Tools: VisualEditor: After changing the size of an image and applying changes, the image size changes but does not get updated in the Media dialog until saving the page - 10https://bugzilla.wikimedia.org/68242 (10James Forrester) 5PATC>3RESO/FIX [00:29:51] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000 (10James Forrester) 5PATC>3RESO/FIX [00:32:55] (03Merged) 10jenkins-bot: Make the image model work without a node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/147219 (https://bugzilla.wikimedia.org/68242) (owner: 10Mooeypoo) [00:34:54] (03PS2) 10Jforrester: Allow for a custom mechanism for scrolling to a section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 (owner: 10JGonera) [00:35:02] (03CR) 10Jforrester: Allow for a custom mechanism for scrolling to a section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 (owner: 10JGonera) [00:36:33] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Add parameter no longer exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148894 (owner: 10Cmcmahon) [00:38:58] (03Merged) 10jenkins-bot: [BrowserTest] Add parameter no longer exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148894 (owner: 10Cmcmahon) [00:39:14] (03CR) 10Catrope: [C: 032] Ignore staging events in CE surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147501 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [00:39:37] (03CR) 10Catrope: [C: 032] "I swear I tried this before and it broke on me, but I don't remember how, and I can't reproduce any breakage now..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147498 (owner: 10Esanders) [00:41:04] (03Merged) 10jenkins-bot: Update context menu according to stricter rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147498 (owner: 10Esanders) [00:41:06] (03CR) 10Catrope: [C: 032] Allow for a custom mechanism for scrolling to a section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 (owner: 10JGonera) [00:41:08] (03Merged) 10jenkins-bot: Ignore staging events in CE surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147501 (https://bugzilla.wikimedia.org/67326) (owner: 10Esanders) [00:41:20] (03CR) 10Catrope: [C: 032] Bump the height of the references list a little [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148903 (https://bugzilla.wikimedia.org/68226) (owner: 10Jforrester) [00:41:56] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148891 (owner: 10Jforrester) [00:42:56] (03Merged) 10jenkins-bot: Allow for a custom mechanism for scrolling to a section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148867 (owner: 10JGonera) [00:43:03] (03Merged) 10jenkins-bot: Bump the height of the references list a little [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148903 (https://bugzilla.wikimedia.org/68226) (owner: 10Jforrester) [00:43:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (a7ce4d48d9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148891 (owner: 10Jforrester) [00:43:21] RoanKattouw: https://gerrit.wikimedia.org/r/148912 [00:44:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) 5PATC>3RESO/FIX [00:44:36] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226 (10James Forrester) 5PATC>3RESO/FIX [00:45:25] (03CR) 10Catrope: [C: 032] SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 (owner: 10Jforrester) [00:46:33] (03CR) 10Catrope: [C: 032] Use shorthand for collapsed ranges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148693 (owner: 10Esanders) [00:47:15] (03Merged) 10jenkins-bot: SpecialCharacterInspector: Don't have a hard-coded default message for the JSON blob [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148694 (owner: 10Jforrester) [00:59:55] (03CR) 10Catrope: [C: 04-1] Fix removals when starting/ending after inline node at end of block (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders) [01:09:47] (03PS2) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 [01:18:09] James_F: https://gerrit.wikimedia.org/r/#/c/129335/ [01:37:26] James_F, maybe we should assign https://bugzilla.wikimedia.org/show_bug.cgi?id=68235 to someone [01:41:24] Krenair: Oh, sorry – I thought I'd assigned it to you. [01:41:29] Krenair: Is that OK? [01:42:35] Well, as I said earlier, I haven't been able to make any more progress on it [01:42:40] * James_F nods. [01:42:44] * James_F slings to Roan then. [01:43:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235 (10James Forrester) a:3Roan Kattouw [01:49:03] (03PS1) 10Catrope: Followup ab2d4cbebf40: fix whitespace preservation in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148929 [01:53:21] (03PS1) 10Catrope: Followup e281f92: actually load CommentInspector CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148930 [01:56:44] (03CR) 10Jforrester: [C: 032] Followup ab2d4cbebf40: fix whitespace preservation in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148929 (owner: 10Catrope) [01:57:00] (03CR) 10Jforrester: [C: 032] Followup e281f92: actually load CommentInspector CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148930 (owner: 10Catrope) [01:57:51] RoanKattouw: Merge https://gerrit.wikimedia.org/r/#/c/147828/ ? [01:58:04] (03Merged) 10jenkins-bot: Followup ab2d4cbebf40: fix whitespace preservation in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148929 (owner: 10Catrope) [01:58:45] (03Merged) 10jenkins-bot: Followup e281f92: actually load CommentInspector CSS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148930 (owner: 10Catrope) [01:59:41] (03CR) 10Catrope: [C: 032] build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 (owner: 10Jforrester) [02:01:04] James_F: I noticed a bug I'm not sure is known/filed [02:01:05] (03Merged) 10jenkins-bot: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/147828 (owner: 10Jforrester) [02:01:15] James_F, what happened to the page settings dialog? [02:01:18] Removing a template from the page (presumably any highlight node) makes the focument focus the top of the page [02:01:40] e.g. I lost my context and where I was looking at (scrolled up) [02:02:24] (03PS1) 10Jforrester: Update VE core submodule to master (98b5c53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148934 [02:02:30] Krenair: 8e08e9f should make you happy. [02:02:31] Hm,.. loos like it's worse than that [02:02:33] Uncaught TypeError: Cannot read property 'getSurface' of null Publishing_the_RecentChanges_feed:550 [02:02:33] Uncaught TypeError: Cannot read property '$element' of null [02:02:38] weird [02:02:38] Err. Krinkle: [02:03:01] I'll try to reproduce in fewer steps in a new tab. I was just editing a page. [02:03:30] Krenair: Looking. [02:03:32] James_F: Also, I don't know how long it's been since you have a pending chrome update without restart, but as of yesterdays' stable release, Chrome throws this on any VE page [02:03:34] 'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach). [02:03:34] Discontiguous selection is not supported. [02:03:46] (one notice, one error) [02:05:54] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (98b5c53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148934 (owner: 10Jforrester) [02:06:55] 3VisualEditor / 3ContentEditable: VisualEditor: Don't use Range.detach (is now a no-op in Chrome per revised DOM spec) - 10https://bugzilla.wikimedia.org/68492 (10Krinkle) 3NEW p:3Unprio s:3major a:3None Chrome emits this notice when using VisualEditor anywhere. > 'Range.detach' is now a no-op, as p... [02:07:41] (03Merged) 10jenkins-bot: Update VE core submodule to master (98b5c53) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148934 (owner: 10Jforrester) [02:09:28] (03PS1) 10Jforrester: Revert "Provide contextual help for the page settings dialog's controls" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148937 [02:09:34] (03CR) 10Jforrester: [C: 032] Revert "Provide contextual help for the page settings dialog's controls" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148937 (owner: 10Jforrester) [02:10:53] 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported." on opening the editor - 10https://bugzilla.wikimedia.org/68493 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Might be related to bug 68492. > Discontiguous selection is not supporte... [02:12:36] (03Merged) 10jenkins-bot: Revert "Provide contextual help for the page settings dialog's controls" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148937 (owner: 10Jforrester) [02:20:53] 3VisualEditor / 3Editing Tools: VisualEditor: When cursor is on a template, "Insert > Template" does not insert a new template - 10https://bugzilla.wikimedia.org/68494 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Use case: 1. On a page with a heading and some text. Put cursor at start of the paragra... [02:21:37] 3VisualEditor / 3Editing Tools: VisualEditor: When cursor is on a template, "Insert > Template" does not insert a template - 10https://bugzilla.wikimedia.org/68494 (10Krinkle) [02:30:54] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog should provide a way to add parameters up front - 10https://bugzilla.wikimedia.org/68495 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Right now there's imho two usability issues with the default (simplified) Template editor related to gett... [02:33:23] (03PS1) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 [02:38:53] 3VisualEditor / 3Editing Tools: VisualEditor: Sidebar button "Add more information" in template dialog is cut off / too long - 10https://bugzilla.wikimedia.org/68496 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 16030 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16030&acti... [02:40:14] (03CR) 10Krinkle: [C: 04-1] build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester) [02:42:26] surfaceModel.getFragment().expandRange( 'root' ).collapseRangeToEnd().insertContent( [ ...] ) gave me Uncaught TypeError: Cannot read property 'nextSibling' of undefined [02:44:07] It's fine if I subtract 1 from range.end [03:45:57] [13oojs.github.io] 15Krinkle 04deleted 06release-1.0.11 at 14ff0798c: 02https://github.com/oojs/oojs.github.io/commit/ff0798c [04:06:35] [13oojs.github.io] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/oojs/oojs.github.io/commit/72eed36dd2c22796e471c6e36887ee084fc07836 [04:06:36] 13oojs.github.io/06master 1472eed36 15Timo Tijhof: Replace oojs v1.0.11 release files with the actual released files.... [07:25:57] RoanKattouw_away, you're going to be able to copy paste within the same document because it uses a range slice [08:07:36] (03CR) 10Esanders: "FIXME: The icon doesn't look like anything. I may be missing something but I've shown it to a few people and we're all stumped." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [08:11:46] (03PS1) 10Esanders: Remove transparent selection from focusable nodes in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148962 [08:22:49] (03PS2) 10Esanders: Remove transparent selection from focusable nodes in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148962 [08:24:04] (03PS1) 10Esanders: Add a space to the comment node for selection highlighting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148964 [08:35:25] (03PS1) 10Esanders: Highlight and bind events to $focusable, not $element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148966 [10:27:54] (03CR) 10Krinkle: "Indeed. Just noticed this too. Some kid of orange rounded corner? http://cl.ly/image/2K1V0X3o0S3c. However this new file doesn't actually " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [10:34:05] (03PS1) 10Krinkle: Remove unused 'comment.svg' indicator image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148980 [10:39:12] (03PS1) 10Krinkle: Add @embed directive for resize-nw-se and resize-nw-sw icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148981 [10:39:29] (03CR) 10Krinkle: "These should be @embed'ed like other icons, right? Fixed in I9a16a238538." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114475 (owner: 10Esanders) [10:46:47] (03Abandoned) 10Krinkle: Remove unused 'comment.svg' indicator image [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148980 (owner: 10Krinkle) [10:47:07] (03PS2) 10Krinkle: Add @embed directive for resize-nw-se and resize-nw-sw icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148981 [10:49:26] (03CR) 10Krinkle: [C: 032] Add a space to the comment node for selection highlighting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148964 (owner: 10Esanders) [10:50:36] (03Merged) 10jenkins-bot: Add a space to the comment node for selection highlighting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148964 (owner: 10Esanders) [10:51:12] 3VisualEditor: VisualEditor: blanking a page doesn't remove comments - 10https://bugzilla.wikimedia.org/52036 (10Krinkle) [10:51:14] 3VisualEditor / 3ContentEditable: VisualEditor: Display HTML comments to the editor (and make them editable/creatable/removable) - 10https://bugzilla.wikimedia.org/49603 (10Krinkle) [13:57:34] (03PS4) 10Cmcmahon: [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 [13:57:43] (03CR) 10Cmcmahon: [C: 031] [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 (owner: 10Cmcmahon) [13:57:50] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 (owner: 10Cmcmahon) [13:59:40] (03Merged) 10jenkins-bot: [BrowserTest] Switching from VE to wikitext update workflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148855 (owner: 10Cmcmahon) [15:24:22] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455#c3 (10Ritu Swain) Created attachment 16033 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16033&action=edit screenshot... [15:42:38] 3VisualEditor: VisualEditor: Adding nowiki tags in unrelated edit - 10https://bugzilla.wikimedia.org/68511 (10Elitre) 3NEW p:3Unprio s:3normal a:3None https://fr.wikipedia.org/w/index.php?title=M%C3%A9thyl%C3%A8nedioxypyroval%C3%A9rone&curid=7265462&diff=105673189&oldid=102426146 If you change anythin... [16:04:07] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455#c4 (10Ritu Swain) Issue found in test2 too. Steps- 1> Open a page in VE and select Preformatted from text style menu. 2> ent... [16:20:17] (03PS2) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 [16:20:40] (03CR) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester) [16:35:33] Corruption alert: visualeditor-needcheck on metawiki: https://meta.wikimedia.org?diff=9286527 [16:35:33] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org?diff=64399831 [16:35:33] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org?diff=1452048 [16:52:21] 3VisualEditor / 3Initialisation: VisualEditor: [Regression pre-wmf14] The cursor stays enabled in readmode after saving a page - 10https://bugzilla.wikimedia.org/68048#c9 (10James Forrester) 5REOP>3RESO/FIX WFM – BetaLabs hiccup? [17:14:03] (03PS1) 10Vikassy: [BrowserTest] Language screenshot feature runs only for language screenshot job [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149047 (https://bugzilla.wikimedia.org/68467) [17:37:34] So the weird error I ran into: [17:37:59] I was trying to add an element to the end of the page [17:38:39] I tried surfaceModel.getFragment().expandRange( 'root' ).collapseRangeToEnd().insertContent( [ ... ] ) [17:39:00] But I got "Uncaught TypeError: Cannot read property 'nextSibling' of undefined" from somewhere in the insertContent call... [17:48:37] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] Language screenshot feature runs only for language screenshot job [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149047 (https://bugzilla.wikimedia.org/68467) (owner: 10Vikassy) [17:51:59] edsanders: ^^^ Thoughts to help Krenair? [17:52:06] (03Merged) 10jenkins-bot: [BrowserTest] Language screenshot feature runs only for language screenshot job [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149047 (https://bugzilla.wikimedia.org/68467) (owner: 10Vikassy) [17:58:18] I found I could get around it by storing the result of expandRange and setting .range.to -= 1 [17:58:28] then collapseRangeToEnd, insertContent, etc. [17:58:32] But that feels wrong [18:29:46] (03CR) 10Krinkle: [C: 04-1] "lib/jquery.js probably shouldn't be modified. (see inline comment causing exception). And," (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester) [18:35:49] Krenair, it looks like you're the first person to use expandRange( 'root' ) [18:35:51] and it's broken [18:35:59] it goes to document.data.length [18:36:04] not the start of the internalList [18:36:07] what are you using it for? [18:36:40] Just wanted to place something at the very end of the document [18:42:01] RoanKattouw, just out of curiosity -- the comment code worked for me before the huge changes -- was it mostly because of the change you said yesterday about comment node being a mix with alien node or were there other issues? [18:42:46] I mean the major changes. I expected changes (i mainly suspected I got the tests wrong because of the change from meta to node) but didn't expect the change to go through such a big transformation, so I'm just curious if it's something big I missed [18:50:31] mooeypoo: No I didn't really touch the DM side much [18:50:37] I changed a bunch of things in the inspector [18:50:46] Like, creation mode had a Remove button that, when clicked, crashed [18:50:58] Also I got rid of the edit button and make it just load with a text input [18:51:00] Which I made autosizing [18:51:13] (I had to fix the autosize feature in ooui to actually work in this case) [18:53:53] random general question, had a bug in my gadget which prevented the "cancel" button from working. fixed now, but I feel like my close button should be a little more robust than that? or do I just have to make sure my code isn't buggy to begin with :P? [18:54:40] mvolz: What was the bug? [18:54:44] (03CR) 10Jforrester: "> lib/jquery.js probably shouldn't be modified." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester) [18:54:52] (03PS3) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 [18:55:36] RoanKattouw, interesting. We talked about the remove button (in terms of whether it should be there, because it's a node) but it worked for me. I wonder what made it crash.. was this in MW or standalone? Anyways, no biggie, I was just curious. I tested this mostly in MW and didn't do much in standalone, I was wondering if it may have been more of a standalone issue. [18:55:49] In MW [18:55:55] I didn't test standalone much either [18:55:57] oh also the autosize! yes! that drove me crazy :\ [18:55:59] I do seem to have screwed up the new icon [18:56:31] I can reproduce that locally now too [18:56:37] call mw.config.get on something that didn't exist and wasn't inside try. (I was copying extension code to gadget and didn't fix it). [18:56:41] probably overthinking this. [18:56:55] Yeah just don't have elementary things broken like that :) [18:57:02] sweet :) [18:57:04] I can do that! [18:57:06] mostly! [18:57:39] Stuff like that would hopefully be caught in code review anyway [18:58:31] the dangers of user js. all my common.js stuff crashed ve hard today :) [19:02:08] (03PS2) 10Esanders: Highlight and bind events to $focusable, not $element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148966 [19:02:36] (03PS1) 10Esanders: Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 [19:04:17] (03CR) 10jenkins-bot: [V: 04-1] Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 (owner: 10Esanders) [19:06:03] edsanders: Did you fix my SVG yet? Or should I? [19:06:13] I'll do it [19:08:03] (03PS1) 10Esanders: Fix expandRange( 'root' ) to not include the internal list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149085 [19:08:09] Krenair, rebase off that ^^ [19:09:47] edsanders: nvm I've already got it [19:10:07] Chrome's caching is so good that it was hard to get the image to refresh [19:10:12] So I made a bunch of bad changes without noticing [19:10:15] s/8/12/g fixes it [19:10:52] (03PS1) 10Catrope: Followup ab2d4cbe: fix comment indicator SVG [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 [19:12:16] edsanders: That ---^^ fixes the sizing. Maybe there's other things you were cleaning up, in which case please do amend :) [19:15:25] (03CR) 10Jforrester: [C: 031] Followup ab2d4cbe: fix comment indicator SVG [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [19:16:08] So would I be correct to assume that [19:16:15] $.grep( surfaceModel.getDocument().getFullData(), function ( element, index ) { [19:16:15] return element.type === 'mwReferenceList' && element.attributes.refGroup === refGroup; [19:16:16] } ); [19:16:31] is not the right way to go about checking whether there is an existing reference list in the document? [19:16:42] (03CR) 10Catrope: "Should this actually be necessary? Shouldn't we instead be cleverer about preventing the internalList from getting deleted? If we do that," [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149085 (owner: 10Esanders) [19:25:50] (03CR) 10Catrope: [C: 032] Add @embed directive for resize-nw-se and resize-nw-sw icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148981 (owner: 10Krinkle) [19:27:14] mooeypoo: I'd like your opinion on https://gerrit.wikimedia.org/r/#/c/148104/ [19:27:19] (03Merged) 10jenkins-bot: Add @embed directive for resize-nw-se and resize-nw-sw icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148981 (owner: 10Krinkle) [19:29:22] (03CR) 10Catrope: [C: 032] Highlight and bind events to $focusable, not $element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148966 (owner: 10Esanders) [19:29:36] RoanKattouw, on the face of it it looks okay, I'm slightly concerned about missing cases with flip hierarchies, but that isn't about this specific commit (it's more a general point about the dm change) and I'll test it now [19:29:48] mooeypoo: I feel like the change might be wrong [19:30:07] you mean because it's flipped left/right ? [19:30:11] It's changing from context-local direction to document-wide direction [19:30:19] well that depends on the dm [19:30:41] That's usually a bad idea, but maybe this is one of the cases where the document direction is actually what we want [19:30:44] (03Merged) 10jenkins-bot: Highlight and bind events to $focusable, not $element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148966 (owner: 10Esanders) [19:30:47] I made the point about document vs. element -- but as I understood it the plan was to make the DM hierarchical too [19:30:55] I'm asking you as our directionality person but really mostly as our image person [19:32:02] RoanKattouw, I'm testing something with block languages (we don't support those yet but they do appear on wikis) [19:32:24] I *think* the image default direction doesn't change (so, it's set per the doc and not section) but I'm checking. [19:32:32] (03PS2) 10Esanders: Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 [19:33:37] OK [19:33:45] You mean like
? [19:33:51] I have a div like that on my main page for testing [19:33:59] Mostly for contextual directionality in toolbar buttons and stuff [19:34:35] edsanders: No your @inheritdoc was actually correct there, jsduck complained only because your commit depended on the VE core change [19:34:38] RoanKattouw, https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9%D7%AA:Mooeypoo/Test <-- look here [19:34:53] RoanKattouw, I thought it was because it's a mixin [19:35:04] Oh that might also be a problem [19:35:14] You may have to specify the class, like @inheritdoc ve.ce.GeneratedContentNode [19:35:28] RoanKattouw, the thumb default alignment (left/right) seems to depend on document direction and not be affected by the context. [19:35:29] In any case, jsduck will not approve until the VE core change is pulled through [19:35:39] mooeypoo: Right, yeah. In that case Ed's change appears to be correct [19:35:48] RoanKattouw, so, actually, the fix you're showing seems to be fixing a bug in the original [19:35:54] Yes [19:35:55] using $element dir would've been wrong [19:36:04] for this particular case [19:36:09] (03PS3) 10Catrope: Use faster (and more accurate!) computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:36:16] Cool [19:36:19] i'm still a bit concerned about the non-image other cases of the directionality when it's in the DM though [19:36:23] I've amended the commit msg to say so [19:36:37] (03PS2) 10Esanders: Followup ab2d4cbe: fix comment indicator SVG [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [19:36:44] I think we may run into issues when we start dealing with language blocks [19:36:50] Right [19:36:56] In most cases I think that's already fine [19:36:58] or when we see pages with hierarchical languages [19:37:00] Because I've done some testing there [19:37:04] * mooeypoo nods [19:37:34] mooeypoo: In any case please +2 Ed's change then :) [19:38:35] aye, just tested [19:38:38] (03CR) 10Catrope: [C: 032] Remove transparent selection from focusable nodes in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148962 (owner: 10Esanders) [19:39:54] (03Merged) 10jenkins-bot: Remove transparent selection from focusable nodes in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148962 (owner: 10Esanders) [19:40:08] (03CR) 10Mooeypoo: [C: 032] "Works great." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:40:16] woot [19:42:30] (03PS3) 10Esanders: Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 [19:43:30] (03CR) 10jenkins-bot: [V: 04-1] Use faster (and more accurate!) computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:44:24] (03CR) 10Catrope: [C: 032] "Per Moriel. Come on Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:44:30] (03CR) 10jenkins-bot: [V: 04-1] Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 (owner: 10Esanders) [19:44:54] (03CR) 10Jforrester: [C: 04-1] "The orange is the Agora alert colour. Changes should be made upstream, not one-off here." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [19:44:59] (03PS4) 10Jforrester: Use faster (and more accurate!) computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:47:30] RoanKattouw, so we should add a test case for [

foo

Ba]r

... [19:47:36] any idea how to get around the inline at end problem? [19:51:14] What's the inline at end problem? [19:51:55] (03CR) 10Jforrester: [C: 032] "*sighs*" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:52:13] (03CR) 10Krinkle: [C: 04-1] "> The whitespace change for jQuery caused an exception in PopupWidget? I can't reproduce…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester) [19:52:14] RoanKattouw, are you going to be available for a brainstorming session with me in a couple f hours? Say, around 3pm your time? [19:52:38] mooeypoo: I have a meeting with David at 2pm [19:52:38] But I could do now-ish [19:52:44] Krinkle: How did you get that failure to happen? All the demos worked fine… [19:52:50] Like, I get lunch, you get ready, we talk in 15-20 mins? [19:52:56] James_F: I didn't, I'm bluffing. [19:53:05] James_F: But there is no way that code isn't broken. [19:53:27] We probably don't call that function right now from the demos [19:53:29] RoanKattouw, okay, we can do that. [19:53:36] Krinkle: Gah.\ [19:53:57] Krinkle: Stop trying to make RoanKattouw's comments about you being a walking ES5 interpreter true. :-) [19:54:09] ^_^ [19:54:09] (03Merged) 10jenkins-bot: Use faster (and more accurate!) computation of directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148104 (owner: 10Esanders) [19:54:12] Krinkle: Suggested fixes welcome. [19:54:29] James_F: Take a look closely. It's just a string. [19:54:41] (or used to be) [19:55:47] Krinkle: I've read the code. It's a bit of a mess. [19:55:52] RoanKattouw, I have a bug I can't figure out and I think it has smething to do with your reservations the other day. It's not urgent, but I could use another pair of eyes and to see if I have missed something like you suggested. [19:56:01] key vs. value [19:56:30] OK [19:56:34] Well, lemme get some food [19:58:10] It's the test case I wrote for the change [19:58:12] bon apetit [19:58:32]

foo[

Bar]

[19:58:37] if you use inner range [19:58:45] it places the offsets inside the aliens [19:58:51] James_F: nvm. Roan's wrong. [19:58:51] or just one aline (unbalanced) [19:58:52] https://gerrit.wikimedia.org/r/#/c/148940/2..3/src/widgets/PopupWidget.js [19:59:00] 'center' isn't a value, it's a key after all. [19:59:27] It looked like a value in this diff: https://gerrit.wikimedia.org/r/#/c/148940/2/src/widgets/PopupWidget.js [19:59:59] Krinkle: Yes, I'm unquoting the keys… [20:00:06] edsanders: That sounds like a bug in the selectNodes output then? [20:00:08] Krinkle: Per your standards. :-) [20:00:24] I know that was your intent, but it's easy to mistake a value of a key in the rush. [20:00:24] Or... well maybe not [20:00:35] value for a key* [20:00:46] Oooh I see [20:00:46] and this expression is really.. interesting. [20:00:49] first and last are both aliens [20:00:52] So they're "mergeable" [20:00:55] popupOffset = this.width * ( { left: 0, center: -0.5, right: -1 } )[this.align], [20:01:13] edsanders: Most likely what we need to do is run selectNodes in a different mode that does not descend into inline nodes [20:01:30] Otherwise we may need logic that correctly identifies inline nodes as not mergeable with each other [20:01:33] Krinkle: Yes. "left", "center", "right" are all keys which are mapped to this.align. It's a neat hack [20:01:39] Right now they're probably identified as mergeable [20:01:46] OK, getting lunch for real now, brb [20:02:08] James_F: k, so the only thing I saw other than that was this https://gerrit.wikimedia.org/r/#/c/148940/3/build/moduleUtils.js [20:02:29] Krinkle: Oh, bah, I thought I skipped those lines in the git add. [20:02:33] * James_F fixes. [20:02:41] Looks like that was either also by accident, or at least it's not consistently done. [20:02:46] ok :) [20:02:51] Yeah, I went through manually. [20:06:58] (03PS4) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 [20:12:12] James_F: sorry.. [20:12:32] James_F: They are indended 4 extra spaces (1 for the * offset, so 5 in total) so that they are rendered as 
[20:12:44] 	 Wait. That's a "feature" in jsduck?
[20:12:48] 	 Descriptios in jsduck are parsed using Markdown.
[20:12:52] 	 Eww.
[20:13:06] 	 that's what makes `backtick` and **etc** work as well
[20:13:08] 	 Can't I just prefix with ` instead? ;-)
[20:13:18] 	 ` is for inline 
[20:13:28] 	 ``` for 
 is a githubism, not actually in markdown.
[20:13:28] * James_F sighs.
[20:17:09] 	 (03PS3) 10Esanders: Use shorthand for collapsed ranges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148693 
[20:18:19] 	 (03PS3) 10Esanders: Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 
[20:19:36] 	 (03CR) 10jenkins-bot: [V: 04-1] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders)
[20:26:41] 	 mooeypoo: OK, I'm back, hit me
[20:27:25] 	 Krinkle, https://www.facebook.com/SecretCinema
[20:30:06] 	 http://www.secretcinema.org/tickets.html
[20:30:16] 	 seems like your sort of thing
[20:31:09] 	 RoanKattouw, can we do a hangout?
[20:32:53] 	 mooeypoo: Sure, in like 5 mins
[20:32:58] 	 James_F: hey, when I edit an article on beta, eg http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Abiathar_and_Sidonia&action=edit, my browser is making calls (GETs) to production enwiki
[20:33:00] 	 awesome
[20:33:25] 	 greg-g: Images?
[20:33:50] 	 no, the article
[20:33:54] 	 http://en.wikipedia.org/w/index.php?title=MediaWiki:RefToolbarBase.js&action=raw&ctype=text/javascript
[20:34:00] 	 http://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-refToolbarBase.js&action=raw&ctype=text/javascript
[20:34:11] 	 looks like someone just made it use the production gadget?
[20:34:13] 	 greg-g: Gadgets doing it perhaps?
[20:34:24] 	 not the article, sorry, what MatmaRex pasted
[20:34:44] 	 (I just saw the beginning of the GET request, and assumed) I have all Beta Features installed
[20:35:04] 	 edsanders: Hm.. "secret location"
[20:35:54] 	 wth, under Appearce (in prefs): "List pages for deletion in ptwiki"
[20:36:14] 	 edsanders: well, at least google knows where it is. http://i.imgur.com/3VDTYU8.png
[20:36:15] 	 xD
[20:36:28] 	 though thats prolly something else
[20:36:42] 	 thx, I'll try and find out more about it
[20:37:07] 	 they email you a day or two before
[20:37:15] 	 when I was it was Alexandra Palace
[20:37:20] 	 they used to not tell you what the film was
[20:37:38] 	 it'll be central(ish) London though
[20:38:16] 	 (03PS5) 10Jforrester: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 
[20:39:19] 	 according to Twitter it's the Olympic Park
[20:39:28] 	 edsanders: They've gone some confusing lingo on their site though (I guess this is general business boilerplate) "Disabled ticket holders are entitled to one free carer ticket, provided they hold a valid Freedom Pass."
[20:49:51] 	 we did it on pl.wp some time ago and it's nice
[20:50:09] 	 (well, mostly did it, but most things are in gadgets now)
[20:50:15] 	 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182#c1 (10Alex Monk) So we should probably just append reference lists...
[20:50:41] 	 mooeypoo: OK sorry for the delay, now calling you on hangout
[20:51:00] 	 Gadgets should go in a repo-like thing with code review and easy importability (non-redundacy) into projects :)
[20:52:21] 	 (03CR) 10Krinkle: [C: 032] build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester)
[20:52:43] 	 greg-g: like that's gonna happen :)
[20:52:56] 	 (03Merged) 10jenkins-bot: build: Remove over-ride on jscs's disallowQuotedKeysInObjects and make pass [oojs/ui] - 10https://gerrit.wikimedia.org/r/148940 (owner: 10Jforrester)
[20:52:57] 	 MatmaRex: a boy can dream
[20:53:44] 	 (03PS1) 10Alex Monk: [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) 
[20:54:29] 	 (03CR) 10Alex Monk: [C: 04-2] "We should probably think this through fully... Is that code okay? Do we really want to do this? Are wikis using custom reference lists goi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) (owner: 10Alex Monk)
[20:55:02] 	 (03CR) 10Alex Monk: "custom reference lists -> customised reference lists (via templates)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) (owner: 10Alex Monk)
[20:55:27] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) (owner: 10Alex Monk)
[20:56:12] 	 (03PS2) 10Alex Monk: [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) 
[20:57:54] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/68182) (owner: 10Alex Monk)
[20:58:00] 	 James_F, thanks for fixing https://gerrit.wikimedia.org/r/#/c/148867
[21:01:22] 	 Krinkle, https://twitter.com/annadubuis
[21:06:21] 	 (03PS1) 10Krinkle: Use native style property names instead of jQuery's css map [oojs/ui] - 10https://gerrit.wikimedia.org/r/149120 
[21:07:10] 	 (03PS2) 10Catrope: Use native style property names instead of jQuery's css map [oojs/ui] - 10https://gerrit.wikimedia.org/r/149120 (owner: 10Krinkle)
[21:07:22] 	 It's easy to forget that the native DOM doesn't expose css property names
[21:07:58] 	 It's a sensible trade-off between having convenient dot-notation for style properties vs. consistency with authored stylesheets.
[21:25:17] 	 (03PS21) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[21:25:20] 	 (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[21:32:24] 	 (03PS1) 10Mooeypoo: Initialize defaultSize as boolean in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149129 
[21:42:00] 	 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337#c11 (10Alex Monk) Derk-Jan?
[21:42:09] 	 (03CR) 10Catrope: [C: 032] Initialize defaultSize as boolean in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149129 (owner: 10Mooeypoo)
[21:42:29] 	 3VisualEditor / 3Technical Debt: VisualEditor: Nicer removal of Cite.php's class=error - 10https://bugzilla.wikimedia.org/51141#c1 (10Alex Monk) So what is this about? There's a lot of missing context here.
[21:43:31] 	 (03Merged) 10jenkins-bot: Initialize defaultSize as boolean in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149129 (owner: 10Mooeypoo)
[21:47:46] 	 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None I am getting this issue is h...
[21:48:45] 	 RoanKattouw, THANKS for that  :) 
[21:48:51] 	 both the help and the +2
[21:56:53] 	 mooeypoo: Was that all you needed to fix?
[21:57:56] 	 RoanKattouw, I'm running a bunch of tests now
[21:58:12] 	 I'm trying to Rummana my code! ryasmeen you are a good influence :)
[21:58:39] 	 RoanKattouw, that, and what you suggested with moving the scalable creation to inside the ImageModel constructor, but that's more of a refactor that doesn't fix a bug
[21:58:46] 	 :)
[21:58:58] 	 it appears the bug I had was handled with your defaultSize fix. I can't believe it was such a small oversight
[22:08:26] 	 Krinkle, TrevorParscal: I'm looking at https://gerrit.wikimedia.org/r/149121 from jdlrobson, I'm interested in merging it only if it has the JavaScript snippet from BetaFeatures that handles value change events, jdlrobson is skittish about it, what do you think?
[22:08:43] 	 Right now it means core can offer a pretty, but non-functioning, mw.ui checkbox.
[22:09:20] 	 If we add the JS it means the thing can actually be checked.
[22:09:33] 	 RoanKattouw could chime in too.
[22:13:19] 	 We might be making it independent of JavaScript.
[22:15:19] 	 marktraceur: Uh?
[22:15:23] 	 I don't get it
[22:15:29] 	 Never mind
[22:15:38] 	 Are you saying the css as proposed makes the checkbox broken without javacscript?
[22:15:42] 	 And you're only adding the css to core?
[22:15:44] 	 that smells.
[22:15:51] 	 Yeah, well, we're fixing it.
[22:15:55] 	 ok :)
[22:19:43] 	 (03CR) 10Jforrester: [C: 032] Use native style property names instead of jQuery's css map [oojs/ui] - 10https://gerrit.wikimedia.org/r/149120 (owner: 10Krinkle)
[22:20:18] * Krinkle writes down a prediction in prep for a magic trick with marktraceur
[22:20:21] 	 (03Merged) 10jenkins-bot: Use native style property names instead of jQuery's css map [oojs/ui] - 10https://gerrit.wikimedia.org/r/149120 (owner: 10Krinkle)
[22:20:41] 	 Hah Krinkle
[22:21:47] 	 marktraceur: Pick a hexidemical between 0 and F (including).
[22:21:58] 	 Krinkle: 8
[22:22:13] 	 Are you sure?
[22:22:36] 	 Yup
[22:22:41] 	 marktraceur: You can change your mind..
[22:22:45] 	 marktraceur: OK.
[22:22:49] 	 *drumroll*
[22:22:50] 	 https://gist.github.com/Krinkle/773b1311eb7ba8082e77
[22:23:02] 	 Magic.
[22:27:26] 	 marktraceur: https://medium.com/message/how-to-always-be-right-on-the-internet-delete-your-mistakes-519a595da2f5
[22:27:37] 	 I'm the worst internet magician, he always reveals his secrets!
[22:28:45] 	 https://gist.github.com/Krinkle/ I can even change it retroactively since I didn't delete them yet.
[22:28:49] 	 http://i.imgur.com/6kuyH67.png
[22:29:05] 	 so If you pick C now, I'll make that one public and delete the other one (so it's a 404, it was never there!)_
[22:29:41] 	 Heh
[22:29:51] 	 I didn't know there was a "secret" option for gists. TIL.
[22:30:07] 	 even better, you don't need to be logged in
[22:30:10] 	 anonymous and secret
[22:31:05] 	 (03PS2) 10Jforrester: [WIP] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:31:16] 	 (03CR) 10Jforrester: "PS2 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:31:39] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:31:45] 	 Of course, if you can be sure nobody is watching your timeline during the trick (you didn't know it was going to be on gist), one could just delete the quickly. Or put each of the 16 answers on different sites :P, saves having to hide/show them 
[22:32:47] 	 (03PS3) 10Jforrester: [WIP] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:33:23] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:33:55] 	 I just noticed (but I think it probably old?) I'm getting "Discontiguous selection is not supported. " error in the console for rangey-core.js
[22:34:04] 	 do I need to update something?
[22:34:33] 	 mooeypoo: Timo noticed it last night; new console complaint from Chrome, I think.
[22:34:47] 	 oh, okay
[22:34:57] 	 just checking in case my libraries need updating or something.
[22:36:11] 	 (03PS4) 10Jforrester: [WIP] [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 (owner: 10Trevor Parscal)
[22:36:24] 	 Well, rangy is unfortunately DOA so we're likely going to have to re-write it.
[22:38:58] 	 Yep, some of the native range stuff got revised in the DOM spec with fairly high priority (should ultimately work in our favour) with various methods immediately removed or replaced with no-ops.
[22:38:59] 	 Including range.detach
[22:39:13] 	 Chrome landed it in 36, which went stable a few days ago.
[22:39:25] 	 Krinkle: You know the situation with rangy, right?
[22:39:30] 	 Yeah
[22:39:37] * James_F sighs.
[23:03:14] 	 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16035   --> https://bugzilla.wikimedia.org/attachment.cgi?id=16035&act...
[23:04:27] 	 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539 (10Ritu Swain) s:5normal>3major
[23:08:02] 	 hm. RoanKattouw I found a conceptual bug.
[23:12:15] 	 Oh?
[23:13:08] 	 RoanKattouw, picture this (pun intended) -- you choose a picture that is originally 800x600, and you then switch from "default" thumb to "full size" which fills the dimensions widgets with the 800x600 values.
[23:13:21] 	 Now you go and switch your picture to one whose original dimensions were, say, 800x100
[23:13:41] 	 the dimensions widget will still have the previous size (because it won't change it, that was the request in the bug report)
[23:13:49] 	 but the image will be all screwed up in VE
[23:13:55] 	 squashed
[23:15:33] 	 Right
[23:15:35] 	 Which must never happen
[23:15:42] 	 It must always have the correct aspect ratio
[23:15:50] 	 :\
[23:16:00] 	 so... are we ignoring the request to leave the same values in the dimensions?
[23:16:21] 	 Should we assume the new image now has only the width value (and correct the height according to aspect ratio)  ?
[23:16:31] 	 should I remove the values and assume the new image is now "default" value ?
[23:16:36] 	 what do you think is best here?
[23:17:02] 	 I don't know
[23:17:08] 	 Whatever we do we need to respect the aspect ratio
[23:17:12] 	 But how to best do that I don't know
[23:17:12] 	 Maybe adjusting the height, then.
[23:17:15] 	 3VisualEditor / 3Editing Tools: VisualEditor: Increase indentation is not working when the list is wrapped around a left aligned image - 10https://bugzilla.wikimedia.org/68540 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with VE 2.Insert an image 4.Add a num...
[23:17:24] 	 That can be the closest to leaving the "size as it was"
[23:17:37] * mooeypoo will do that temporarily
[23:17:39] 	 ?
[23:18:09] 	 ok, I will leave that out of this fix, then (I'm creating one for the scalable+image model constructor. We'll have to discuss how we want to do this, though. 
[23:18:15] 	 James_F|Away, when you get back ^^
[23:20:45] 	 He went home for the day
[23:24:16] 	 RoanKattouw, ok, I don't think it's urgent. I can set up a temporary fix for what I think is best and we can discuss it tomorrow.
[23:25:38] 	 OK
[23:26:00] 	 So you're saying you'll just preserve one dimension and compute the othero ne?
[23:26:55] 	 RoanKattouw, aye
[23:27:01] 	 that's what parsoid would do
[23:27:22] 	 I mean in terms of it being a "bounding box"
[23:28:09] 	 And if I always take the width (like MW does) then it should be relatively seamless to the user
[23:28:46] 	 Right
[23:28:47] 	 (Though I should also account for what happens if the size given is bigger than the size of the new image)
[23:28:51] 	 bah
[23:29:23] 	 Then it will either have to change *OR* it will remain as-is but the dimensions widet will show it as erroneous size
[23:33:06] 	 RoanKattouw, if I have an image 800x600, the output in wikitext is [[File:whatever.jpg|800x800]] as bounding box. So after you save, it's basically the width you chose + adjusted height
[23:35:10] 	 Rigth
[23:35:12] 	 oy, I'm getting "Database query error" when I'm trying to save the page
[23:35:17] 	 Ouch
[23:35:19] 	 Locally?
[23:35:22] 	 yep
[23:35:25] 	 If so you may need to run php maintenance/update.php
[23:35:31] 	 ahh
[23:36:15] 	 ok I'm confused as hell now
[23:36:16] 	 it saved
[23:36:23] 	 Yeah it probably did
[23:36:24] 	 but my image is now 700 HIGH in view
[23:36:27] 	 The schema change was in the links table
[23:36:30] 	 wtf
[23:36:43] 	 I know.
[23:36:57] 	 [[File:Wikipedia Main Page.png|thumb|797x797px|blah]]
[23:37:07] 	 797px hight
[23:37:12] 	 height
[23:38:10] 	 ok, I opened in VE now. The dimensions are 476 (width) x797 (height)
[23:39:21] 	 I switch the image to one that's horizontal (wider than it is high). The image is stretched atm in VE but with the same dimensions. I save the page, and get this wikitext: [[File:Main page commons.jpg|thumb|797x797px|blah]] which is good (no dirty diff on size, which is what the intent was)
[23:40:01] 	 but now in view mode, the image is max-size (because its height is not as big as 797px)
[23:40:04] 	 whaaaat is going on.
[23:40:29] 	 it's now 797x425
[23:40:37] 	 oh! damnit, it's going by the wider end
[23:40:40] 	 I forgot!
[23:40:42] * mooeypoo facepalms
[23:41:30] 	 the bigger end, I mean. The bigger side. Eh. RoanKattouw if we go with preventing dirty diffs, then the presentation is going to be weird and appear somewhat random (image is once big on the width and once big on the height)
[23:41:41] 	 but it will prevent dirty diffs, so that sounds like the best strategy to start with
[23:46:09] 	 OK
[23:46:13] 	 We can clean it up later
[23:48:28] 	 I can't believe I forgot the whole width/height extravaganza. I think I repressed. It was too traumatizing.
[23:54:18] 	 (03PS1) 10Mooeypoo: Refactoring ImageModel consructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 
[23:59:02] 	 mooeypoo: *constructor
[23:59:17] 	 oops
[23:59:56] 	 (03PS2) 10Mooeypoo: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191