[00:11:24] (03PS3) 10Mooeypoo: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 [00:30:15] (03PS22) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [00:30:19] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [00:35:02] 3VisualEditor / 3Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None When running VE on mobile, in the console: $('.ve-ui-context') [] $('.ve-ui-mobileContext') [] I thought that the context not appearing on mobile was... [02:31:09] (03PS1) 10Mooeypoo: [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [02:32:48] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (owner: 10Mooeypoo) [04:02:59] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c1 (10Ritu Swain) did a fresh install of Safari, still getting WebKit2WebProcess.exe message. [04:37:15] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - 10https://bugzilla.wikimedia.org/64712#c3 (10Erik Moeller) As the citation experience overall has recently improved in leaps... [04:49:32] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - 10https://bugzilla.wikimedia.org/64712#c4 (10Roan Kattouw) (In reply to Erik Moeller from comment #3) > As the citation exper... [14:05:15] 3VisualEditor: VisualEditor: the "Save your changes" window title can be overlapped by the "Save page" button - 10https://bugzilla.wikimedia.org/68571 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None In languages where the messages "Save your changes" and "Save page" are longer than in English, the... [14:05:43] 3VisualEditor: VisualEditor: the "Save your changes" window title can be overlapped by the "Save page" button - 10https://bugzilla.wikimedia.org/68571#c1 (10Amir E. Aharoni) Created attachment 16036 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16036&action=edit a screenshot with the problem [14:06:15] 3VisualEditor: VisualEditor: the "Save your changes" window title can be overlapped by the "Save page" button - 10https://bugzilla.wikimedia.org/68571 (10Amir E. Aharoni) [14:10:45] 3VisualEditor: VisualEditor: in the saving dialog, the "Watch this page" box can move to the next line in a suboptimal way - 10https://bugzilla.wikimedia.org/68572 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16037 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16037&... [14:26:16] 3VisualEditor: VE gets stuck when saving settings - 10https://bugzilla.wikimedia.org/68573 (10Stryn) 3NEW p:3Unprio s:3normal a:3None VE get stucks when saving settings How to reproduce: 1) click "Options" and then "cancel" 2) click "Advanced settings" and then "apply changes" After this it gets stuc... [14:34:30] 3VisualEditor: VE gets stuck when saving settings - 10https://bugzilla.wikimedia.org/68573#c1 (10Alex Monk) Can't reproduce this issue. Stryn, do you get an error in the JS console when this happens? [15:27:13] 3VisualEditor: VE gets stuck when saving settings - 10https://bugzilla.wikimedia.org/68573#c2 (10Stryn) (In reply to Alex Monk from comment #1) > Can't reproduce this issue. > > Stryn, do you get an error in the JS console when this happens? Yup, with Firefox and Chrome Firefox gives: TypeError: bindings[i]... [15:28:40] (03CR) 10Esanders: "1. This isn't Agora" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [15:29:13] 3VisualEditor: VE gets stuck when saving settings - 10https://bugzilla.wikimedia.org/68573#c3 (10Alex Monk) I think Ed fixed this in Gerrit change 148671 [15:31:35] (03CR) 10Esanders: "BTW the colour in this fix is 888 grey, not orange" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [15:41:27] (03PS1) 10Esanders: Fix copy paste of comments in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149321 [15:54:28] (03CR) 10Krinkle: "Indeed. At the moment all of VisualEditor uses the apex theme of OOjs UI, so it'd make sense to not have the extension of that in VisualEd" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [15:56:24] (03PS3) 10Krinkle: Followup ab2d4cbe: Change comment indicator color and correct its size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [15:56:29] (03CR) 10Krinkle: [C: 031] Followup ab2d4cbe: Change comment indicator color and correct its size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [15:59:06] Krinkle, do you have a 5: http://support.apple.com/kb/HT5554 ? [15:59:31] edsanders: Yes, 5.0 as it were. [15:59:37] ok [15:59:53] Also, I have an iPhone, not an iPhone iPhone. [15:59:55] lol APple [16:30:37] Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org?diff=67220927 [16:30:37] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org?diff=39659108 [16:30:37] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org?diff=39659121 [16:30:37] Corruption alert: visualeditor-needcheck on sqwiki: https://sq.wikipedia.org?diff=1452145 [16:30:43] Woo. [16:30:47] Go Krenair. :-) [16:32:56] (03PS4) 10Jforrester: Followup ab2d4cbe: Correct comment indicator's size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [16:33:27] (03CR) 10Jforrester: "PS3 removes the change of colour, as this bit of the fix needs to be cherry-picked." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [16:48:47] Hm... link needs a slash after .org for it to be recognised as a url by most text parsers. [16:48:58] (they tend to cut off at . and ? for sentences) [16:54:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Highes s:5normal>3major [16:57:14] 3VisualEditor / 3Editing Tools: VisualEditor: VE gets stuck when applying changes to settings window the second time it's open - 10https://bugzilla.wikimedia.org/68573#c4 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Ed Sanders Yes, this is fixed in wmf15 (as on MediaWiki.org right now) but... [16:57:23] (03CR) 10Krinkle: [C: 032] "We should talk about the color still, but let's get this fix out first then." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [16:57:35] Thanks Krinkle. [16:58:20] James_F: Withoutaname and Umherirrender together have managed to remove almost a 100 interface from mediawiki-core over the past few weeks. [16:58:24] Astonishingly awesome. [16:58:34] "A 100 interface"? [16:58:42] a 100 intefaces, APIs, methods. [16:58:43] (03Merged) 10jenkins-bot: Followup ab2d4cbe: Correct comment indicator's size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149088 (owner: 10Catrope) [16:58:50] Oh, right. [16:58:52] -a. [16:58:55] +s [16:59:31] 'almost a hundred' is incorrect? [17:00:02] I guess you'd say 'almost one hundred'. [17:00:13] Hm.. yeah [17:01:14] 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appear near newly added references - 10https://bugzilla.wikimedia.org/54712#c22 (10Elitre) More examples from it.wp: https://it.wikipedia.org/w/index.php?title=Natale_Ciravolo&diff=67212907&oldid=67197341 , https://it.wikipedia.org/w/index.php?title=Ute... [17:04:03] (03PS1) 10Jforrester: Followup ab2d4cbe: Correct comment indicator's size [VisualEditor/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149343 [17:31:31] (03PS2) 10Mooeypoo: [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [17:33:25] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (owner: 10Mooeypoo) [17:34:23] Krinkle: https://gerrit.wikimedia.org/r/#/c/134928/ CR please. :-) [17:34:31] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/148883/ and https://gerrit.wikimedia.org/r/#/c/149343/ are easy. :-) [17:38:29] (03CR) 10Krinkle: "So I've looked at the testing again and I think, unless you intend to make the TemplateDataGenerator library standalone from mediawiki, it" (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) (owner: 10Mooeypoo) [17:38:43] James_F: mooeypoo: Will review actual code soon as well. [17:41:13] "Soon". :-P [17:44:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [17:44:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the context menu of previously selected link is appearing upon placing the cursor in a different position in the document - 10https://bugzilla.wikimedia.org/67637 (10James Forrester) [17:44:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [17:44:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [17:44:58] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) [17:44:58] 3VisualEditor / 3Editing Tools: VisualEditor: Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484 (10James Forrester) [17:44:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Unknown error" on saving on officewiki - 10https://bugzilla.wikimedia.org/68235 (10James Forrester) [17:45:12] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iPad causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [17:45:12] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) [17:45:12] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [17:45:12] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10James Forrester) [17:45:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [17:45:14] 3VisualEditor / 3Mobile: VisualEditor Mobile: references context selection is wonky - 10https://bugzilla.wikimedia.org/67433 (10James Forrester) [17:45:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] TypeError: Cannot read property 'context' of undefined appears when you try to insert another image that appears on the same index as the previous search, right after you inserted one - 10https://bugzilla.wikimedia.org/67749 (10James Forrester) [17:45:16] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) [17:45:17] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) [17:57:49] (03PS1) 10Alex Monk: Don't overwrite #contentSub just to try to get the correct subtitle for redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149351 (https://bugzilla.wikimedia.org/68432) [18:00:28] (03PS1) 10Esanders: Generate fake comment nodes (spans) when copying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 [18:00:30] (03PS1) 10Esanders: Meta-fy empty comments as they aren't editable/useful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 [18:01:04] (03PS2) 10Esanders: Fix copy paste of comments in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149321 [18:01:06] (03PS2) 10Esanders: Generate fake comment nodes (spans) when copying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 [18:01:08] (03PS2) 10Esanders: Meta-fy empty comments as they aren't editable/useful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 [18:02:50] Krinkle|detached: "A hundred" is correct, but "100" is read as "one hundred", so "a 100" is duplicative [18:03:27] (03CR) 10Catrope: [C: 032] Don't overwrite #contentSub just to try to get the correct subtitle for redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149351 (https://bugzilla.wikimedia.org/68432) (owner: 10Alex Monk) [18:03:32] (03PS1) 10Esanders: Greyscale comment icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 [18:05:06] (03Merged) 10jenkins-bot: Don't overwrite #contentSub just to try to get the correct subtitle for redirects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149351 (https://bugzilla.wikimedia.org/68432) (owner: 10Alex Monk) [18:05:30] (03PS1) 10Catrope: [WIP] Attach mobile surface to the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149356 [18:06:08] (03CR) 10Catrope: [C: 032] Fix copy paste of comments in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149321 (owner: 10Esanders) [18:06:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Breadcrumb doesn't reappear upon saving page - 10https://bugzilla.wikimedia.org/68432 (10Alex Monk) 5PATC>3RESO/FIX [18:07:38] (03Merged) 10jenkins-bot: Fix copy paste of comments in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149321 (owner: 10Esanders) [18:08:15] (03CR) 10Catrope: [C: 04-1] Generate fake comment nodes (spans) when copying (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 (owner: 10Esanders) [18:09:18] (03CR) 10Catrope: [C: 031] Meta-fy empty comments as they aren't editable/useful (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 (owner: 10Esanders) [18:10:44] (03PS2) 10Catrope: [WIP] Attach mobile surface to the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149356 (https://bugzilla.wikimedia.org/68546) [18:10:47] btw, RoanKattouw, the new image model constructor refactor and the depending commit will only work if we update the lib/ve submodule (or if you manually add "this.defaultSize = false" to ve.dm.Scalable constructor in the meantime) [18:11:04] mooeypoo: OK I'll do a submodule update soon [18:11:07] I just figured out that that's why my code wasn't updated even though it was merged :D [18:11:13] Ed did a bunch of comment copy-paste stuff anyway [18:11:32] That has very minor -1s on it, so it'll land soon [18:11:36] And once it does I'll do an update [18:11:47] cool. Yeah, it's a really tiny change for that one, so I am just adding it in manually for now [18:13:15] 3VisualEditor / 3Editing Tools: VisualEditor: Cannot include the same existing reference after adding it once in an article - 10https://bugzilla.wikimedia.org/68582 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE which has 4 citations 2.Open Cite>Re-us... [18:16:22] (03PS1) 10Cmcmahon: [BrowserTest] prevent premature click of Edit button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149359 [18:16:24] (03CR) 10Esanders: Generate fake comment nodes (spans) when copying (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 (owner: 10Esanders) [18:16:34] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149359 (owner: 10Cmcmahon) [18:17:13] (03PS3) 10Esanders: Generate fake comment nodes (spans) when copying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 [18:17:15] (03PS3) 10Esanders: Meta-fy empty comments as they aren't editable/useful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 [18:19:08] (03Merged) 10jenkins-bot: [BrowserTest] prevent premature click of Edit button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149359 (owner: 10Cmcmahon) [18:21:14] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986#c2 (10Alex Monk) Is this still valid? I just checked and the three required parameters are showing. [18:22:21] (03CR) 10Catrope: [C: 032] Generate fake comment nodes (spans) when copying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 (owner: 10Esanders) [18:22:37] (03CR) 10Catrope: [C: 032] Meta-fy empty comments as they aren't editable/useful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 (owner: 10Esanders) [18:23:35] (03Merged) 10jenkins-bot: Generate fake comment nodes (spans) when copying [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149352 (owner: 10Esanders) [18:23:54] (03Merged) 10jenkins-bot: Meta-fy empty comments as they aren't editable/useful [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149353 (owner: 10Esanders) [18:25:44] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986#c3 (10Nnvu) No. At the moment the problem seems to be solved. [18:25:57] 3VisualEditor / 3Editing Tools: VisualEditor: switching to "Default" image size in image inspector does not make Apply Changes button active - 10https://bugzilla.wikimedia.org/68014#c1 (10Alex Monk) Has this bug been fixed? It works fine for me. [18:40:09] (03PS1) 10Catrope: Actually show the corruption warning in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149367 [18:40:23] Krenair, James_F|Away: Relevant to the needcheck stuff --^^ :) [18:48:31] 3VisualEditor / 3MediaWiki integration: VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page - 10https://bugzilla.wikimedia.org/68121#c10 (10Rummana Yasmeen) 5RESO/?>3VERI Verified... [18:49:18] (03CR) 10Alex Monk: [C: 032] Actually show the corruption warning in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149367 (owner: 10Catrope) [18:50:19] Thanks [18:51:01] (03Merged) 10jenkins-bot: Actually show the corruption warning in the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149367 (owner: 10Catrope) [18:51:47] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986#c4 (10Alex Monk) 5NEW>3RESO/WOR I wonder if it was just waiting for someone to null edit the template page. I guess this bug is WFM. [18:52:01] 3VisualEditor: VisualEditor: required parameter not showing - 10https://bugzilla.wikimedia.org/67986 (10Alex Monk) [18:56:45] 3VisualEditor / 3Data Model: VisualEditor: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost - 10https://bugzilla.wikimedia.org/65301#c1 (10WhatamIdoing) Also, if the only refs are hidden in templates, then when you add a 3VisualEditor / 3Editing Tools: VisualEditor: Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484#c1 (10Alex Monk) Can't reproduce... [18:59:14] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c2 (10Alex Monk) 5UNCO>3NEW Confirmed [19:03:14] 3VisualEditor / 3Editing Tools: can't search image when inserting media in private wiki - 10https://bugzilla.wikimedia.org/68141#c2 (10Alex Monk) 5UNCO>3NEW Confirmed on officewiki [19:05:14] 3VisualEditor / 3Editing Tools: can't search image when inserting media in private wiki - 10https://bugzilla.wikimedia.org/68141 (10Alex Monk) [19:07:46] 3VisualEditor: When making text bold or italic, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151 (10Alex Monk) [19:07:46] 3VisualEditor: ☃ symbol replicates when creating an article [HEBREW WIKIPEDIA] - 10https://bugzilla.wikimedia.org/68147 (10Alex Monk) [19:10:58] 3VisualEditor: VisualEditor: Can't save after editing categories - 10https://bugzilla.wikimedia.org/64241#c3 (10Alex Monk) Can you still not reproduce this issue? Maybe this should be marked worksforme. [19:13:26] mooeypoo, did https://bugzilla.wikimedia.org/show_bug.cgi?id=53542 get fixed or is it still broken? [19:16:01] 3VisualEditor / 3Mobile: VisualEditor: Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None I cannot open any page with Mobile VE with iOS Safari, however in desktop Safari I am not seeing this issue [19:19:28] 3VisualEditor / 3ContentEditable: VisualEditor: In [[Pristina International Airport]] the backspace key makes the cursor jump further back - 10https://bugzilla.wikimedia.org/67933#c1 (10Alex Monk) Hmm... Can't reproduce on the latest version with Chrome. [19:21:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753#c12 (10Rummana Yasmeen) Verified the fix in production en.wiki for iOS only, for Android... [19:23:13] 3VisualEditor / 3ContentEditable: VisualEditor: In [[Pristina International Airport]] the backspace key makes the cursor jump further back - 10https://bugzilla.wikimedia.org/67933#c2 (10Amir E. Aharoni) 5NEW>3RESO/FIX I guess it was fixed at some point. Thanks for testing. [19:24:21] Hmm [19:24:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=68583 vs. https://bugzilla.wikimedia.org/show_bug.cgi?id=68584 [19:25:16] 3VisualEditor / 3Mobile: VisualEditor Mobile: The link text is not appearing in the link target field inside the link inspector for Android - 10https://bugzilla.wikimedia.org/68585 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobile VE in Android with C... [19:25:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] The context menu for already added category is appearing as blank in Betalabs - 10https://bugzilla.wikimedia.org/67885#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:32:04] Krenair, i think it was. I just tried to replicate this and couldn't https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9%D7%AA:Mooeypoo/%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99/%D7%91%D7%93%D7%99%D7%A7%D7%95%D7%AA_%D7%95%D7%9E%D7%A9%D7%97%D7%A7%D7%99%D7%9D?veaction=edit [19:32:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf13] "Error: ve.dm.Document.getNodeFromOffset(): offset 1 is out of bounds" appears upon selecting language or closing the language selector - 10https://bugzilla.wikimedia.org/67609#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in produc... [19:33:31] 3VisualEditor / 3ContentEditable: VisualEditor: Images after template are shielded and uneditable in RTL - 10https://bugzilla.wikimedia.org/53542#c2 (10Moriel Schottlender) This seems to be fixed now with the change of images and the way we render shields. [19:35:34] 3VisualEditor / 3Editing Tools: VisualEditor: Add reference (footnote) dialog is LTR in RTL wikis - 10https://bugzilla.wikimedia.org/66037#c1 (10Moriel Schottlender) This seems to be fixed now with the new reference/cite system. [19:36:14] Should I just close the bug reports, or is James_F|Away keeping a list ? [19:40:13] mooeypoo: If things are fixed, close them. James gets an email every time anyone touches any bug [19:40:33] mooeypoo, if it were me, I'd just close it. James is on CC so can correct things like this if necessary [19:40:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf14] All inspector UI in mobile got completely broken - 10https://bugzilla.wikimedia.org/68061#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:41:05] Also, if you /did something/ to fix the bug (as opposed to "oh look this doesn't happen anymore, mysteriously"), then also tag it against this week's milestone [19:41:12] Milestone bugs are tracked separately as well [19:43:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf12] Cite menu is missing in the toolbar for mobile VE for in both alpha and beta modes - 10https://bugzilla.wikimedia.org/67701#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:46:44] 3VisualEditor / 3Data Model: VisualEditor: Crossing out the media settings dialog after changing the image size, retains those changes - 10https://bugzilla.wikimedia.org/67687#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:50:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] Entering a custom size value in the Advanced Settings dialog for an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/67684#c7 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:51:16] 3VisualEditor / 3ContentEditable: VisualEditor: After selecting a focusable node backwards by cursoring, pressing up/down throws an exception - 10https://bugzilla.wikimedia.org/67755#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [19:52:55] RoanKattouw, Krenair okay, I'll just close these two. I didn't do anything, just noticed they don't happen anymore (thanks Krenair :p ) [19:53:27] I went through a few new/unconfirmed things checking them [19:53:36] 3VisualEditor / 3Editing Tools: VisualEditor: Add reference (footnote) dialog is LTR in RTL wikis - 10https://bugzilla.wikimedia.org/66037 (10Moriel Schottlender) 5ASSI>3RESO/FIX [19:54:07] hm. Should I close with 'fixed' or 'worksforme' [19:54:14] i just thought about it after closing htat one [19:55:14] (03PS1) 10Cmcmahon: [BrowserTest] turn Headings test back on for the builds [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149388 [19:55:50] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149388 (owner: 10Cmcmahon) [19:56:19] 3VisualEditor / 3ContentEditable: VisualEditor: Images after template are shielded and uneditable in RTL - 10https://bugzilla.wikimedia.org/53542 (10Moriel Schottlender) 5UNCO>3RESO/FIX [19:57:33] (03Merged) 10jenkins-bot: [BrowserTest] turn Headings test back on for the builds [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149388 (owner: 10Cmcmahon) [20:00:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [20:01:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Highlight/Context Menu/Inspector are appearing over the toolbar in Chrome - 10https://bugzilla.wikimedia.org/68066#c5 (10Rummana Yasmeen) Verified the fix in production en.wiki [20:02:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Cannot close VE by clicking on Cancel after making an edit in Betalabs - 10https://bugzilla.wikimedia.org/68068#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [20:07:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388#c3 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.... [20:09:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] Langage and Special Character inspectors' UI is broken, and dialog titles are not correctly aligned - 10https://bugzilla.wikimedia.org/68180#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production en.wiki [20:13:57] (03PS1) 10Catrope: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149392 [20:14:19] (03PS2) 10Catrope: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149392 [20:14:29] James_F , ryasmeen: Do we have a bug for that one? ---^^ [20:14:38] RoanKattouw: No. [20:14:42] RoanKattouw: Was going to file one. [20:14:48] RoanKattouw: Also, where are you? :-) [20:14:52] R66 [20:14:56] Coming back down [20:15:01] OK. [20:15:03] Grabbing lunch, then hangout with David around 13:40 [20:15:08] * James_F nods. [20:20:38] Are you available to talk now, James_F? [20:20:59] Krenair: Sure. [20:22:18] 3VisualEditor / 3Editing Tools: VisualEditor: Add reference (footnote) dialog is LTR in RTL wikis - 10https://bugzilla.wikimedia.org/66037 (10James Forrester) a:3Trevor Parscal [20:23:46] 3VisualEditor / 3ContentEditable: VisualEditor: Down-page of {{IPA-es}} backspace behaviour is very broken - 10https://bugzilla.wikimedia.org/67862#c3 (10James Forrester) *** Bug 67933 has been marked as a duplicate of this bug. *** [20:23:46] 3VisualEditor / 3ContentEditable: VisualEditor: In [[Pristina International Airport]] the backspace key makes the cursor jump further back - 10https://bugzilla.wikimedia.org/67933#c3 (10James Forrester) 5RESO/FIX>3RESO/DUP Aha, this was a dupe of bug 67862. Sorry! *** This bug has been marked as a dupli... [20:27:35] (03PS1) 10Catrope: Fix corruption bug in sortkeys containing underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149395 [20:30:59] 3VisualEditor: VisualEditor: Can't save after editing categories - 10https://bugzilla.wikimedia.org/64241#c4 (10James Forrester) 5UNCO>3RESO/WOR At least provisionally… [20:34:29] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf14] Each category is getting added twice in Betalabs, throws TypeError: categoryItem is undefined - 10https://bugzilla.wikimedia.org/68484#c2 (10James Forrester) 5NEW>3RESO/FIX Seems to be working again. Probably a deployment gremlin. Again... [20:37:29] 3VisualEditor / 3Editing Tools: VisualEditor:Cannot create a new page using VE on FireFox25 in test2 - 10https://bugzilla.wikimedia.org/58912 (10James Forrester) 5NEW>3RESO/WOR [20:39:45] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Alex Monk [20:39:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10James Forrester) a:3Alex Monk [20:41:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c4 (10James Forrester) p:5Normal>3High s:5minor>3major Bumping priority now that the loss of the Cancel... [20:46:03] What happened to the cancel button btw, James_F ? [20:48:11] Krenair: We killed it [20:48:21] Krenair: Thanks for that bot BTW, it led to me discovering https://gerrit.wikimedia.org/r/149395 [20:48:24] well, yeah [20:48:36] yay [20:49:00] RoanKattouw, I was wondering if we could expand the use of needcheck to cover other situations [20:49:06] Like the addition of pawn characters [20:51:09] Also Krinkle I added that slash between ".org" and "?" for you [20:52:09] Well, David and I are killing pawning soon :) [20:52:29] What will happen instead? [20:52:41] (I've probably been told already but...) [20:53:45] (03PS2) 10Alex Monk: Fix corruption bug in sortkeys containing underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149395 (owner: 10Catrope) [20:55:33] Krenair: Unicorns! [20:55:49] We're keeping pawns for slugs for now [20:55:55] But I wanna kill them there too, eventually [20:56:01] Okay, well we could detect them as well [20:56:12] No unicorns don't get inserted into the model [20:56:30] ah [20:56:52] RoanKattouw_away, thanks for the patch. I'll play with this, I might end up not attaching the context to the toolbar for now if it's too hard to make it span to full page width [20:58:27] 3VisualEditor / 3Editing Tools: VisualEditor: The size of References List dialog is appearing a bit small in Firefox making the text field almost overlap with the edge of the dialog - 10https://bugzilla.wikimedia.org/68226#c6 (10Rummana Yasmeen) Verified the fix in test2 [20:59:15] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring at end of page off focusable node following another focusable node (?) throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Ed Sanders Steps: 1. O... [20:59:29] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring at end of page off focusable node following another focusable node (?) throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588 (10James Forrester) p:5Unprio>3High [21:00:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326#c6 (10Rummana Yasmeen) Verified the fix in test2 [21:01:08] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug moves focus to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3Ed Sanders Steps: 1. Open http://en.wikipedia.beta.wmflabs.org/wiki/7thfeb?ve... [21:01:13] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug moves focus to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10James Forrester) p:5Unprio>3Normal [21:03:07] James_F, Krinkle: Okay so I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=67088 [21:03:42] Step 3 - my cursor is in the target link box [21:06:31] Although I have found a different way to break it [21:08:25] If I create a new link (not selecting any existing text), set some target, then instead of pressing 'done' I click into the surface where the link is to go, it creates the link [21:11:17] If I then press a random character to replace the text and then ctrl+z to undo changes, and then ctrl+z again, I get Uncaught Error: Invalid transaction, annotation to be cleared is not set [21:13:00] That sounds rather broken, yes. :-( [21:13:03] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069#c4 (10James Forrester) 5REOP>3RESO/FIX On discussion, we'll leave this as is. [21:13:25] perhaps I should clarify that after it creates a link the whole thing is highlighted which is why pressing a random character replaces stuff [21:13:50] Krenair: This bug's initial issue might well have been fixed through the window re-write (given it's about application of changes on implicit close). [21:15:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088#c2 (10Alex Monk) (In reply to Krinkle from comment #1) > Reduced test case video of only the steps for this bu... [21:15:42] James_F, I'll create a new bug with the issue I found [21:15:56] Krenair: Thanks! [21:16:43] 3VisualEditor / 3Editing Tools: VisualEditor: After changing the size of an image and applying changes, the image size changes but does not get updated in the Media dialog until saving the page - 10https://bugzilla.wikimedia.org/68242#c3 (10Rummana Yasmeen) Verified the fix in test2 [21:18:16] 3VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None If I create a new link (not having selected any existing text), set some target, then instead of pressing 'done' I click into the su... [21:18:18] ^ done [21:20:22] Actually I wonder if https://bugzilla.wikimedia.org/show_bug.cgi?id=66548 is still valid [21:20:38] Very similar steps to reproduce actually [21:21:08] But with undo instead of redo at the very end. [21:22:28] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548#c3 (10Alex Monk) Doesn't seem to happen anymore. Although we do now have bug 68590, which is pretty much these same steps but w... [21:27:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf14] In the media dialog, switch to default size button is not changing the size values to default after setting a custom size - 10https://bugzilla.wikimedia.org/68000#c3 (10Rummana Yasmeen) Verified the fix in test2 [21:35:30] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar is appearing inside the language inspector - 10https://bugzilla.wikimedia.org/68053#c2 (10Rummana Yasmeen) Verified the fix in test2 [21:38:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf15] Pressing return after a link is throwingTypeError: Cannot read property 'getOuterLength' of undefined VM112:521 - 10https://bugzilla.wikimedia.org/68415#c5 (10Rummana Yasmeen) Verified the fix in test2 [21:43:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088#c3 (10James Forrester) 5ASSI>3RESO/FIX a:5Alex Monk>3Trevor Parscal No longer an issue (Trevor-rewrite... [21:43:31] 3VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590#c1 (10James Forrester) Created attachment 16039 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16039&action=edit Demo video of the issue [21:43:48] 3VisualEditor / 3Editing Tools: VisualEditor: Invalid transaction involving creating+overwriting+undoin g new link - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major a:3Ed Sanders [21:44:00] 3VisualEditor / 3Editing Tools: VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [21:44:17] 3VisualEditor / 3Editing Tools: VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590 (10Alex Monk) [21:44:17] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10Alex Monk) [21:44:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10Alex Monk) [21:44:32] 3VisualEditor / 3Editing Tools: VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590 (10Alex Monk) [21:45:27] (03CR) 10Esanders: "Review?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:47:01] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548#c4 (10James Forrester) 5ASSI>3RESO/FIX a:5Ed Sanders>3Trevor Parscal Yeah, I'm going to declare this one also fixed in... [21:47:30] 3VisualEditor / 3Editing Tools: VisualEditor:While switching to edit source mode without making any edit through the Page Options , the confirmation dialog for saving change appears - 10https://bugzilla.wikimedia.org/68229#c4 (10Rummana Yasmeen) Verified the fix in test2 [21:48:01] (03CR) 10Jforrester: "Needs rebase. Manual list of icons makes me sad, but it's no worse than the non-icon ones already were." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:49:34] edsanders: Want me to rebase that? [21:52:19] * James_F does it. [21:54:58] (03PS2) 10Jforrester: Unified demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:55:09] (03PS3) 10Jforrester: Unified demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:55:34] (03CR) 10Jforrester: "PS2 is a rebase." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:56:15] (03CR) 10Jforrester: [C: 032] "May pose some issues for automated testing, but we can fix those then." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:56:21] edsanders: Happy? :-) [21:56:58] (03Merged) 10jenkins-bot: Unified demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [21:59:29] 3VisualEditor / 3Editing Tools: VisualEditor: Invalid transaction involving creating+overwriting+undoing new link - 10https://bugzilla.wikimedia.org/68590#c2 (10James Forrester) Note that if you do this in a block slug, the first character you type in goes into the paragraph above(!), not where the cursor is. [22:00:02] (03PS3) 10Jforrester: [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) (owner: 10Alex Monk) [22:00:59] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) a:5Trevor Parscal>3Alex Monk [22:01:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) (owner: 10Alex Monk) [22:06:02] (03PS4) 10Alex Monk: [WIP] If there isn't one already, append reference list to page when creating a reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149117 (https://bugzilla.wikimedia.org/54906) [22:25:01] 3VisualEditor / 3Editing Tools: VisualEditor: Use existing reference dialog gets squished upon resizing the window down and does not retain back its UI upon making window size normal - 10https://bugzilla.wikimedia.org/68232#c9 (10Rummana Yasmeen) Verified the fix in test2 [22:27:16] 3VisualEditor / 3Editing Tools: VisualEditor: "TypeError: Cannot read property 'context' of undefined" on pressing return after a reference node - 10https://bugzilla.wikimedia.org/68462#c3 (10Rummana Yasmeen) Verified the fix in test2 [22:28:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression pre-wmf14] Save button in save dialog remains active while save is in progress and throws "Uncaught TypeError: Cannot read property '$saveOptions' of null" - 10https://bugzilla.wikimedia.org/68073#c9 (10Rummana Yasmeen) Verified the fix in test2 [22:30:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: The "Go back" button in use existing reference dialog in mobile takes to Basic Reference dialog - 10https://bugzilla.wikimedia.org/68201#c5 (10Rummana Yasmeen) Verified the fix in test2 [22:40:21] (03PS3) 10Mooeypoo: [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [22:40:34] James_F, I am going at the 'bounding box' thing with the idea of preventing dirty diffs [22:40:45] mooeypoo: … OK? [22:40:54] for the moment, less about what looks reasonable and more about keeping the original bounding box [22:41:05] unless the new imageis smaller, in which case it will change the bounding box [22:41:21] that's okay? i think it might be good at least for starters. [22:41:35] at least to make sure VE doesn't stretch the image and until we figure out what the better behavior should be [22:42:15] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (owner: 10Mooeypoo) [22:42:39] (03PS23) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [22:42:49] James_F, and I think I found a parsoid issue, though I'm not sure if it's parsoid or the way we send stuff to parsoid. [22:43:00] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [22:43:29] mooeypoo: I don't know, we'd probably need to spend 15 minutes talking it through for me to have an opinion. [22:44:08] mooeypoo: The trick with Parsoid issues is to reduce it down to something you can do without using VE (using parsoid.wmflabs.org/_wikitext/ etc.) but it takes effort. [22:44:42] * mooeypoo nods [22:45:56] James_F, ok, we can talk whenever. I thought I'd have something at least temporary up so to fix the anticipated bug of where the image is stretched. Will you have time to chat about this today (it's late fo you guys) or you want to wait for monday? [22:46:09] mooeypoo: It's later for you. :-) [22:47:37] James_F, I usually stay latererer [22:47:38] :D [22:49:39] mooeypoo: I've got about six things to do before theoretically going home "on time" today, so… [22:49:46] mooeypoo: Book a meeting with me on Monday? [22:49:47] * mooeypoo nods [22:50:40] James_F, I don't think it's urgent -- I still have the unit tests to fix and there's an underlying commit that this is dependent upon. I worked on this as if diff is the important part, but it should be easy to switch it to other methods after we talk. [22:50:47] so we can settle this monday. [22:51:05] * James_F nods. [22:51:06] OK. [22:56:42] What tha-- ... I'm having a REALLY REALLY weird bug with save/view diff now. [22:56:54] it saves my previous change and not the most updated one to the image. What the hell [22:57:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546 (10James Forrester) a:3Roan Kattouw [22:58:39] The linear model looks okay, but the 'save-> view diff' doesn't represent it [22:59:19] (03CR) 10Jforrester: [C: 04-1] "If this change is being made in the name of consistency, it fails, because we don't use this grey elsewhere." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [22:59:46] James_F, is it possible we're at any point sending parsoid a non-updated representation of the current linear model ? [23:00:16] mooeypoo: We don't send linmod to Parsoid unless there's a really serious bug. [23:00:32] mooeypoo: But sending the original input HTML, you mean? [23:00:38] no, we send an html representation of the linear model, aren't we? [23:00:54] mooeypoo: That sounds very wrong. What does the network inspector show us sending? [23:01:48] (No, we take in a "DOM" – Parsoid HTML+RDFa – and convert it to "data" – linmod structure; CE nodes convert linmod to a CE DOM.) [23:03:36] Here's the bug, I may be misunderstanding something: I am adding a new image to VE, brand new, so just add in as thumb/default size. I check "save->view changed" and the wikitext is good. Now I go back (cancel save) and I change hte image to "Frame" without alignment. The change is done in CE properly. I go to 'save->view changes' and the wikitext is still |thumb [23:04:11] so I'm trying to see if it's something in my code that I am not updating properly, but the CE is supposed to reflect the DM (it at least responds to change in the dm) so that doesn't make alot of sense. [23:04:20] I'm going to check if this happens in master. [23:05:23] It does. [23:06:38] James_F, this happens in master, too -- and not just in images. I just tested a link, same thing happens. [23:10:16] (03PS3) 10Catrope: Attach mobile surface to the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149356 (https://bugzilla.wikimedia.org/68546) [23:10:42] (03CR) 10Esanders: "It's not a real icon or indicator so it has nothing to be consistent with, just the general appearance of the skin. But it could made the " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [23:20:03] 3VisualEditor / 3Data Model: Page is saved without some of the latest edits in VE - 10https://bugzilla.wikimedia.org/68595 (10Moriel Schottlender) 3NEW p:3Unprio s:3normal a:3None This is a weird bug, so I'm going to put in two ways of reproducing it, hoping that it will help seeing what causes it:... [23:20:05] James_F, it seems to be something specifically with the 'save' dialog, if that makes any sense. [23:20:08] it's very odd. [23:21:11] mooeypoo: I fixed this today [23:21:29] RoanKattouw_away, oh, you did? Is it merged? It still happens for me in master [23:21:43] mooeypoo: https://gerrit.wikimedia.org/r/149392 [23:21:54] Not merged apparently [23:22:02] oh ok [23:22:47] (03CR) 10JGonera: [C: 032] Attach mobile surface to the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149356 (https://bugzilla.wikimedia.org/68546) (owner: 10Catrope) [23:22:47] RoanKattouw, I don't know if it's "just" clearing (I don't know enough about the diff viewer) but the "bad" wikitext is also actually saved. [23:22:57] is that the same bug? [23:24:03] Yes I thnik so [23:24:18] It fails to clear the cache key and that gets used for lots of things [23:24:22] (03Merged) 10jenkins-bot: Attach mobile surface to the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149356 (https://bugzilla.wikimedia.org/68546) (owner: 10Catrope) [23:24:25] ah, okay [23:24:32] James_F: So I was wrong, it doesn't just affect diff display, it affects the actual save as well [23:24:41] Because we're being efficient and sharing data between those [23:24:45] hah [23:25:06] (03PS1) 10JGonera: Style MobileContext properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149473 [23:25:25] RoanKattouw, ^ [23:25:27] (03CR) 10Catrope: [C: 032] Style MobileContext properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149473 (owner: 10JGonera) [23:27:16] (03Merged) 10jenkins-bot: Style MobileContext properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149473 (owner: 10JGonera) [23:49:08] (03PS1) 10Catrope: Update VE core submodule to master (433007d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149477 [23:49:30] moo|food: If you feel like reviewing some code later, please look at https://gerrit.wikimedia.org/r/149395 and https://gerrit.wikimedia.org/r/149392