[00:00:07] <moo|food>	 RoanKattouw, this 149392 fixes the bug I just reported, was there any other bug i should verify?
[00:00:27] <moo|food>	 or was this just a general fix? No bugs are attached to it
[00:01:31] <RoanKattouw>	 There was no bug filed for it
[00:01:33] <RoanKattouw>	 I asked
[00:02:31] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (433007d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149477 (owner: 10Catrope)
[00:02:36] <moo|food>	 RoanKattouw, oki, it fixes the bug I just filed, so as far as I'm concerned it's good. do I +2 ...?
[00:02:49] <moo|food>	 I'm not used to +2'ing YOUR code. I'm used to that going the other way around.
[00:03:09] <RoanKattouw>	 haha
[00:03:10] <RoanKattouw>	 Yes
[00:03:20] <RoanKattouw>	 If you have verified it works and the code looks good to you, then +2
[00:03:36] <RoanKattouw>	 (And you have no reservations and aren't scared it will break things in weird ways or whatever)
[00:04:06] <moo|food>	 Well, from testing it doesn't seem to break anything, just fix.
[00:04:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (433007d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149477 (owner: 10Catrope)
[00:04:42] <RoanKattouw>	 And yeah the fact that you're not used to +2ing my code is precisely why I want you to :) so you get practice
[00:04:43] <moo|food>	 the only comment I have about the code is really petty and not sure if it's in our style -- the indentation of that segment is confusing
[00:04:47] <Krenair>	 Yes... The numbers of patches merged between me and Roan is also massively unbalanced.
[00:04:57] <RoanKattouw>	 Krenair: s/me/anyone/
[00:05:01] <Krenair>	 :D
[00:06:07] <RoanKattouw>	 moo|food: If you grep for "opening.always" you can find other examples
[00:06:18] <RoanKattouw>	 I don't know offhand if I followed the right style or not
[00:06:23] <RoanKattouw>	 If I didn't, please fix
[00:06:45] <moo|food>	 RoanKattouw, it's more about the parentheses, but it's really very minor.
[00:06:56] <moo|food>	 veeery minor. Just took me a moment to verify they're all closed.
[00:07:43] <RoanKattouw>	 Oh, right
[00:07:52] <RoanKattouw>	 Yeah with promise functions it gets a bit confusing
[00:08:45] <RoanKattouw>	 The parentheses in https://gerrit.wikimedia.org/r/#/c/149395 should be easier to count
[00:08:47] <RoanKattouw>	  :)
[00:08:50] <moo|food>	 oh, I missed the ) in the middle there. Okay, now it makes sense
[00:09:39] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Looks good and works!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149392 (owner: 10Catrope)
[00:09:44] <moo|food>	 \o/
[00:09:57] <RoanKattouw>	 Yay!
[00:09:59] <RoanKattouw>	 Next!
[00:10:01] <RoanKattouw>	 ;)
[00:10:02] <moo|food>	 (I love how my comment makes it sound as if I'm surprised that it looks good and works)
[00:10:10] <RoanKattouw>	 We'll make a code reviewer out of you yet
[00:10:14] <moo|food>	 haha
[00:10:20] * moo|food prepares the +2 button
[00:11:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149392 (owner: 10Catrope)
[00:11:44] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Pasting more than one paragraph is painfully slow in large documents - 10https://bugzilla.wikimedia.org/68301 (10James Forrester)
[00:17:59] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org - 10https://bugzilla.wikimedia.org/68297#c2 (10Alex Monk) (In reply to Bartosz Dziewoński from comment #0) > * Place cursor before/after one of the templates. > * Press 'Right'/'Left' keyboard...
[00:24:02] <grrrit-wm>	 (03PS3) 10Mooeypoo: Fix corruption bug in sortkeys containing underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149395 (owner: 10Catrope)
[00:24:58] <mooeypoo>	 RoanKattouw, that's just a straight forward "click the button in gerrit" rebase, after which I want to +2 'cause I tested and it's all good -- but do I wait for jenkins to do his thing first or just go +2 
[00:25:13] <RoanKattouw>	 Just +2
[00:25:20] <RoanKattouw>	 Apparently Jenkins now aborts useless runs
[00:26:39] <RoanKattouw>	 The post-rebase run is a subset of the +2 run anyway
[00:30:34] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Works categorically." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149395 (owner: 10Catrope)
[00:30:51] <RoanKattouw>	 mooeypoo: lol
[00:30:55] <mooeypoo>	 \o/
[00:31:08] <RoanKattouw>	 Wikitext like [[Category:Foo|_Bar baz]] was what would break
[00:31:14] <mooeypoo>	 Aye, I tested
[00:31:55] <RoanKattouw>	 Cool
[00:32:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix corruption bug in sortkeys containing underscores [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149395 (owner: 10Catrope)
[00:32:12] <mooeypoo>	 that's why it took me a bit, I added the categories in and checked I did it according to the example in the commit message
[00:32:30] <RoanKattouw>	 Oh right, I'd linked to that diff
[00:32:35] <mooeypoo>	 it dirty diffed before, now it doesn't.
[00:32:40] <mooeypoo>	 So I assumed that was the intent of the fix.
[00:33:28] <RoanKattouw>	 Yeah it was
[00:33:45] <mooeypoo>	 :D
[00:36:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Some comments on PS23" (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[00:37:32] <grrrit-wm>	 (03PS24) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[00:37:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[01:03:15] <grrrit-wm>	 (03PS25) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 
[01:03:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec)
[01:22:00] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Typing at the beginning of the document pulls annotations from the right - 10https://bugzilla.wikimedia.org/68597 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None 1. Create a document with two paragraphs, and make both of them entirely bold 2. Put the curso...
[01:33:31] <RoanKattouw>	 James_F: https://meta.wikimedia.org/?oldid=7254808
[01:40:01] <mooeypoo>	 RoanKattouw, I took a look at your "Apply bidi styles to references in Parsoid styles" fix, it looks good but if I remember correctly, there might be an issue with the *order* of the css rules. I can't find anything online except for 1 example of the 'isolate' rule where the "unicode-bidi: isolate" is above the individual -moz and -webkit rules, but I'm not completely sure. Do you know anything about the order of CSS? I may be misre
[01:40:01] <mooeypoo>	 membering.
[01:40:19] <RoanKattouw>	 Vendor-prefixed rules are always first
[01:40:34] <RoanKattouw>	 If the standardized behavior is available, you want that to override the vendor-specific behavior
[01:40:40] <mooeypoo>	 okay, just checking. I remember amir told me to double-check when I created the original fix for cite.
[01:41:16] <mooeypoo>	 Gotcha. That makes sense. I'd have +2'ed but it's not VE, I don't have rights. I can +1.
[01:41:23] <RoanKattouw>	 Yeah if the browser's implementation of the standardized version is broken, you want it to be the other way around
[01:41:29] <RoanKattouw>	 But that's rare
[01:41:38] <RoanKattouw>	 Apparently it happens for background SVGs in Opera, I hear
[01:41:43] <RoanKattouw>	 But other than that it like never happens
[01:41:56] <mooeypoo>	 okay, yeah, I remember some caveats to the bidi rule in css.
[01:42:04] <mooeypoo>	 wasn't sure exactly what, and the internets wasn't very helpful.
[01:42:06] <RoanKattouw>	 mooeypoo: Grmbl, you should be in the WMF group so you can +2, but apparently that hasn't happened yet
[01:42:16] <RoanKattouw>	 James is working on it
[01:42:19] * mooeypoo nods
[01:42:36] <mooeypoo>	 I shall +1, at lest so it's on the record that someone looked at it.. not that i's such a revolutionary complex change.
[01:44:20] <grrrit-wm>	 (03PS11) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester)
[01:45:10] <mooeypoo>	 oy vey. This is broken.
[01:45:29] <grrrit-wm>	 (03PS12) 10Mooeypoo: [wip] Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester)
[01:45:45] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org - 10https://bugzilla.wikimedia.org/68297 (10James Forrester) a:5Alex Monk>3Roan Kattouw
[02:07:47] <mooeypoo>	 RoanKattouw, I have a question for you. I'm having an error in the align buttons for images that's a little odd. There's a "isCompatibleWith" function( model ) and I get "undefined" when I read model.getDocument().getDir() -- so I put a breakpoint on it, and now it's called, but the model is "VeDmBoldAnnotation"
[02:08:07] <mooeypoo>	 ... that makes no sense, this is inside ve.ui.MWBlockMediaMoveTool.static.isCompatibleWith = function ( model ) {
[02:08:10] <mooeypoo>	 O.O
[02:08:27] <mooeypoo>	 or is 'iscompatiblewith' called on all tools ?
[02:08:34] <RoanKattouw>	 Yes
[02:08:49] <RoanKattouw>	 It's called to evaluate compatibility of every annotation against every tool
[02:09:04] <RoanKattouw>	 The parent's implementation should do an instanceOfAny check against static.modelClasses I think
[02:11:55] <mooeypoo>	 That makes sense. But don't all annotations and node have 'getDocument()' ?
[02:11:55] <mooeypoo>	 (apparently not...?)
[02:13:49] <mooeypoo>	 If not, won't that cause problems with hierarchical directions?
[02:14:06] <mooeypoo>	 if annotations can't have .getDocument().getDir() that might be an issue for the language annotation at some point.
[02:17:32] <RoanKattouw>	 You got a bold annotation with .getDocument() === null ?
[02:17:42] <RoanKattouw>	 That probably shouldn't happen
[02:17:54] <RoanKattouw>	 Also yes you may want local direction rather than document direction but that's a separate issue
[02:20:00] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: <nowiki> tags appear when editing on the Hebrew Wiki - 10https://bugzilla.wikimedia.org/66210 (10James Forrester)
[02:21:27] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High
[02:24:57] <grrrit-wm>	 (03PS4) 10Catrope: Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 (owner: 10Esanders)
[02:26:15] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Snowmen appear near newly added references - 10https://bugzilla.wikimedia.org/54712#c23 (10James Forrester) 5REOP>3RESO/FIX (In reply to Elitre from comment #22) > More examples from it.wp: > https://it.wikipedia.org/w/index. > php?title=Natale_Ciravolo&dif...
[02:26:15] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major
[02:26:44] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992#c1 (10James Forrester) Comments from Erica on another bug:  > I believe this is happening again at it.wp. > See https://it.wikipedia.org/w/index.php?title=AA.VV...
[02:27:15] <grrrit-wm>	 (03PS13) 10Mooeypoo: Provide move left/right quick action buttons for images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester)
[02:28:04] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c2 (10James Forrester) *** Bug 67797 has been marked as a duplicate of this bug. ***
[02:28:04] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Highes s:5normal>3critic a:3Ed Sanders Confirmed in Chrome and Firefox.
[02:28:04] <wikibugs>	 3VisualEditor: VisualEditor: Pawns and reverse typing - 10https://bugzilla.wikimedia.org/67797#c1 (10James Forrester) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 68151 ***
[02:31:16] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Typing at the beginning of the document pulls annotations from the right; should instead be null - 10https://bugzilla.wikimedia.org/68597 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Alex Monk
[02:31:43] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 (owner: 10Esanders)
[02:33:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Implement getFocusableNode for MWGallery nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149084 (owner: 10Esanders)
[02:35:16] <wikibugs>	 3VisualEditor / 3Mobile: VisualEditor Mobile: MobileContext is not in the DOM - 10https://bugzilla.wikimedia.org/68546 (10James Forrester) 5PATC>3RESO/FIX
[10:12:38] <grrrit-wm>	 (03PS1) 10Esanders: SVG fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/149513 
[10:13:19] <grrrit-wm>	 (03PS2) 10Esanders: SVG fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/149513 
[10:42:03] <grrrit-wm>	 (03PS1) 10Esanders: SVG fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149518 
[10:43:20] <grrrit-wm>	 (03PS1) 10Esanders: SVG fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149519 
[10:54:45] <grrrit-wm>	 (03PS2) 10Esanders: SVG fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149518 
[11:15:29] <grrrit-wm>	 (03PS1) 10Esanders: Move non-icon/indicator styles out of ve.ui.Icons.css [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149521 
[11:18:36] <grrrit-wm>	 (03PS2) 10Esanders: Greyscale comment icon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 
[12:25:22] <grrrit-wm>	 (03PS1) 10Esanders: [BREAKING CHANGE] Use getDescription for title attribute and move to model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 
[12:25:32] <grrrit-wm>	 (03PS1) 10Esanders: Move getDescription methods to model as required by core change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 
[12:27:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move getDescription methods to model as required by core change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders)
[13:18:54] <grrrit-wm>	 (03PS3) 10Krinkle: SVG fixes [oojs/ui] - 10https://gerrit.wikimedia.org/r/149513 (owner: 10Esanders)
[13:45:23] <grrrit-wm>	 (03PS3) 10Esanders: SVG fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149518 
[13:45:32] <grrrit-wm>	 (03PS2) 10Esanders: SVG fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149519 
[15:39:45] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None 1. Make a change to a page on en.wiki and click review changes form t...
[15:44:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c1 (10Moriel Schottlender) This is fixed by this change: https://gerrit.wikimedia.org/r/#/c/149392/
[15:45:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438#c2 (10Moriel Schottlender) Oops.   Wrong fix to the wrong bug (ignore the above comment)
[15:46:14] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c1 (10Moriel Schottlender) This is fixed by this - https://gerrit.wikimedia.org/r/#/c/149392/
[16:04:29] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c2 (10Ed Sanders) 5NEW>3RESO/FIX Was fixed by https://gerrit.wikimedia.org/r/#/c/149392 . Quite serious though so should...
[16:04:37] <grrrit-wm>	 (03CR) 10Esanders: "This was more serious that it suggest, see bug: 68619" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149392 (owner: 10Catrope)
[16:05:20] <moo|away>	 edsanders, I also submitted a bug like this yesterday, though for the life of me I can't find it now
[16:05:42] <edsanders>	 never mind
[16:05:59] <moo|away>	 edsanders, my point is that he knows and saw it,  we just forgot to add the bug number to the commit message 
[16:06:14] <moo|away>	 and now this elusive bug is annoying me.
[16:06:22] <moo|away>	 but report, i mean. Where did it go...
[16:07:34] <moo|away>	 ah! https://bugzilla.wikimedia.org/show_bug.cgi?id=68595
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on itwiki: https://it.wikipedia.org/?diff=67227066
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64441299
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64441337
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=64444680
[16:30:37] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32021689
[16:30:38] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32021744
[16:30:38] <wm-ve-needcheck>	 Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32026554
[17:15:21] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders)
[17:22:33] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester)
[21:21:06] <wikibugs>	 3VisualEditor / 3Data Model: Page is saved without some of the latest edits in VE - 10https://bugzilla.wikimedia.org/68595#c1 (10Ed Sanders) 5NEW>3RESO/DUP   *** This bug has been marked as a duplicate of bug 68619 ***
[21:21:06] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c3 (10Ed Sanders) *** Bug 68595 has been marked as a duplicate of this bug. ***
[21:54:42] <grrrit-wm>	 (03PS1) 10Jforrester: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 
[21:55:00] <grrrit-wm>	 (03PS1) 10Jforrester: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149589 
[21:56:03] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 (owner: 10Jforrester)
[21:56:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149589 (owner: 10Jforrester)
[21:56:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 (owner: 10Jforrester)
[21:57:28] <grrrit-wm>	 (03PS2) 10Jforrester: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 
[21:59:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149589 (owner: 10Jforrester)
[21:59:36] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 (owner: 10Jforrester)
[22:01:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actually clear diff viewer after closing save dialog and changing document [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/149588 (owner: 10Jforrester)
[22:13:20] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c19 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3None It seems that bug 5645 which I thought to be a dependency is not going to be fixed in a useful...