[00:04:14] 3MediaWiki extensions / 3TemplateData: TemplateData.hooks.php:71: MWException: Invalid callback in hooks for ParserFirstCallInit - 10https://bugzilla.wikimedia.org/68699 (10Nemo) 3NEW p:3Unprio s:3normal a:3None Doing what in attachment 16052 minus Wikibase, I get 1404 times MWException: Invalid call... [04:35:53] 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c4 (10katalavst) 1. Add a new page in Wikipedia, with the visual editor. 2. Add tamplate to it (I used "מיון" tamplate in the hebrew wikipedia). 3... [06:52:09] 3VisualEditor: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692 (10Elitre) [06:52:22] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears if you type near a [[Link]] after the {{convert}} template - 10https://bugzilla.wikimedia.org/68691 (10Elitre) [07:12:25] 3VisualEditor: VisualEditor: Remove an image, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10Elitre) 3NEW p:3Unprio s:3normal a:3None Take any article long enough to notice the effect (i.e. Cake on en.wp). Delete any of the pics at the bottom of the article. Notice the focus jumps back at... [07:28:26] 3VisualEditor: VisualEditor: Edge case of unintentional image removal - 10https://bugzilla.wikimedia.org/68709 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See https://it.wikipedia.org/w/index.php?title=Vallo_Atlantico&oldid=66317144&veaction=edit : Reach the paragraph "Comandi del Vallo Atlantico", see... [07:32:49] (03CR) 10Amire80: [C: 04-1] "Some nitpicks." (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [10:04:09] 3VisualEditor / 3Editing Tools: VisualEditor: Comment icon is truncated - 10https://bugzilla.wikimedia.org/68721 (10This, that and the other (TTO)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16054 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16054&action=edit Screenshot See screen... [10:09:39] 3VisualEditor / 3Editing Tools: VisualEditor should display entire comment when the orange icon is clicked - 10https://bugzilla.wikimedia.org/68722 (10This, that and the other (TTO)) 3NEW p:3Unprio s:3enhanc a:3None Created attachment 16055 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16055... [10:16:21] 3VisualEditor: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10Elitre) [10:19:35] I see very weird behavior in this this article: https://en.wikipedia.org/w/index.php?title=Enrico_Letta&oldid=618793889&veaction=edit Try to insert a space followed by an x anywhere in the intro paragraph, then delete the x with backspace and be surprised. Only works in first paragraph. Can't reproduce on mediawiki.org [10:21:26] 3VisualEditor: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708#c1 (10Elitre) It also happens with templates, so I'm guessing this is probably worrying but maybe a duplicate. [10:23:06] The x vanishes (as expected), but the space is replaced by the character two positions before the space. [10:23:42] editin on Chrome [11:41:22] AxelBoldt: i think there's been some bug about weird character duplication somewhere [11:48:08] (but i can't find any…) [12:09:02] (03PS1) 10Esanders: Comment used messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149842 [12:09:43] (03PS1) 10Esanders: Function name fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149844 [12:22:57] MatmaRex: I'll file a bug report, maybe someone recognizes it. [12:56:55] James_F|Away: or TrevorParscal when you get a chance, re: TemplateData new services field, so we should restrict the allowed fields to those provided by the service, correct? [12:57:24] where will this be stored? presumably there will be extra service information somewhere... [12:57:42] will the service require an extension that provides this info? [12:58:00] we'll have to register the extension with the templatedata extension somehow? [12:58:10] tl;dr i have no idea what I'm doing :) [13:08:08] 3VisualEditor / 3ContentEditable: Character duplication in paragraphs following templates - 10https://bugzilla.wikimedia.org/68733 (10Axel Boldt) 3NEW p:3Unprio s:3normal a:3None If a paragraph contains a template, and VisualEditor is used to insert two characters somewhere after the template, and th... [13:13:53] (03PS1) 10Vikassy: [BrowserTest] Language of images should be in subcategory of VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149854 [13:16:38] (03PS2) 10Vikassy: [BrowserTest] Language of images should be in subcategory of VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149854 [13:17:53] 3VisualEditor / 3ContentEditable: Character duplication in paragraphs following templates - 10https://bugzilla.wikimedia.org/68733#c1 (10Bartosz Dziewoński) Maybe related: bug 67862? [13:24:12] (03PS1) 10Esanders: Remove old message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149855 [13:25:28] (03PS1) 10Esanders: Remove unused CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149856 [14:02:09] ugh [14:02:22] it is now completely impossible to insert anything after some inline templates [14:02:25] like {{done}} [14:02:34] shit gets all fucked up [14:32:10] (03PS1) 10Vikassy: [BrowserTest] Save button locator now supports language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149863 [14:45:09] Hi. [14:45:13] Hi [15:00:44] hello [15:00:51] James_F: ^ [15:01:23] 3VisualEditor / 3ContentEditable: VisualEditor: Comment Edit dialog does not close, after inserting a list. - 10https://bugzilla.wikimedia.org/68738 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created attachment 16061 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16061&action=edit screen... [15:01:26] Hey mvolz. :-) [15:01:38] 3VisualEditor / 3ContentEditable: VisualEditor: Comment Edit dialog does not close, after inserting a list. - 10https://bugzilla.wikimedia.org/68738 (10Ritu Swain) [15:02:13] So I had some questions about the validation for the new "services" property for templatedata [15:02:23] namely, how are we going to validate it [15:02:24] :) [15:02:31] and where that information is going to come from [15:02:40] i.e. I could see each service having an extension [15:03:00] that would provide the list of valid fields to template data [15:03:13] but I am very fuzzy on it [15:03:38] and in practice [15:03:50] how to validate the template params even [15:04:03] given that templatedata is a completely passive api currently [15:04:13] has* a passive api [15:04:32] mvolz: I was imagining that it would be up to clients. [15:04:57] mvolz: So you could have 20 different services mentioned in the TemplateData block, but VE only knows about one – citoid – and so uses that. [15:05:10] Or maybe VE knows about six, and does something else. [15:05:36] so in the original design it was suggested that templatedata actually be agnositic about the name of the service [15:05:48] Yeah. [15:05:53] so for isntance, it wouldn't know what "citoid" meant- the service name could be anything [15:06:05] Yeah, no validation of the names of services. [15:06:12] But potentially of the structure. [15:06:17] but that all the parameters IN the service had to be valid [15:06:24] so the citoid params had to be valid [15:06:37] and the "params" parameters had to be valid [15:07:37] but you're saying that isn't required? [15:11:07] No? [15:11:24] * James_F thought he said. [15:11:52] Oh, no, I didn't. [15:12:23] mvolz: So TrevorParscal and I thought that maybe it would make sense to apply the same structure (inputs, outputs) to all the services blocks. [15:14:38] wait, who didn't say what? [15:14:40] :) [15:14:56] ok, so the input, output structure, should be required [15:15:09] but then... no validation after that by template data itself [15:15:50] The structure of the input and output structures is quite detailed [15:16:04] "inputs" maps to string or array of strings [15:16:24] ok, but no validation of the actually parameters within on templatedata's side [15:16:30] actual* [15:16:31] s/string/known parameter names/ [15:18:09] "outputs" maps to set of (unknown) items that map to either a known parameter name or an array of known parameter names, to an object of unknowns that maps to parameter names, or "([])+" which maps to $1-count nested arrays of known parameter names. [15:20:20] I feel like we're talking in circles here. ok, so the simplest case is outputs. [15:20:39] output is , let's say, ['url','doi'] [15:20:46] No, that's inputs. [15:20:51] inputs* [15:20:55] "outputs" is much more complicated. [15:21:02] yeah I misspoke :) [15:21:04] :-) [15:21:05] sign error! [15:21:35] input* is ['url','doi'] [15:21:41] I am template data [15:21:44] Yes. [15:22:11] "url" and "doi" are required to be valid documented parameter names. [15:22:18] I fetch the service object [15:22:22] aha [15:22:25] No. [15:22:29] no? [15:22:30] TemplateData doesn't fetch objects. [15:22:34] It sends out objects. [15:22:47] VisualEditor (or whatever client) fetches the services object from TemplateData. [15:22:57] right, passive. [15:23:01] Unless you mean when a user is changing the service object definition? [15:23:50] no [15:24:22] OK… [15:25:07] ok so TD parses the template data blob [15:25:47] Yes. [15:27:01] when it is parsing it, it could validate that the fields inside the input list are valid params [15:27:02] y/n? [15:27:27] Yes, it should. [15:27:34] ok# [15:27:41] GIGO is a bad route. [15:27:47] GIGO? [15:28:16] Garbage In Garbage Out. [15:28:26] ok [15:28:28] Once you let users write nonsense into the DB you've lost. [15:28:41] so now, onto our horribly complex output structure :) [15:29:07] we can do the same for the params in there that we did for input [15:29:15] however, what do we do with the citoid fields [15:29:34] the list of allowed citoid fields isn't defined anywhere [15:29:37] yet [15:29:41] 3VisualEditor / 3ContentEditable: VisualEditor:Snowman like character gets triggered, when trying to insert a template with Comment edit dialog open . - 10https://bugzilla.wikimedia.org/68740 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16062 --> https://bugzilla.wikimedia.or... [15:30:09] 3VisualEditor / 3ContentEditable: VisualEditor:Snowman like character gets triggered, when trying to insert a template with Comment edit dialog open . - 10https://bugzilla.wikimedia.org/68740 (10Ritu Swain) [15:30:15] Oh, yeah, TD should be wilfully blind to the service's fields. [15:30:51] In the Etherpad, for demonstration all the service fields are title-cased and all the param names are lower-cased. [15:30:55] But that's just to demonstrate. [15:31:00] willfully blind. gotcha. That was what I was asking :) [15:32:17] Aha, sorry. :-) [15:33:44] ty, somehow I interpreted the current doc as having to also validate citoid fields and my head was about to explode on how to do that without completely destroying TD :P [15:33:56] *within TD [15:34:07] Yeah, that would be a mess. [15:34:21] Theoretically we could do it (registering services with TD) but… let's not. [15:34:32] So instead services need to do their own validation. [15:49:36] 3VisualEditor / 3ContentEditable: VisualEditor:Snowman like character gets triggered, when trying to insert a template with Comment edit dialog open . - 10https://bugzilla.wikimedia.org/68740#c1 (10Ritu Swain) confirmed in betalabs. Try the template "Bar chart" [16:17:12] (03CR) 10Jforrester: [C: 032] Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [16:17:32] (03CR) 10Jforrester: [C: 032] Comment used messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149842 (owner: 10Esanders) [16:18:04] (03CR) 10Jforrester: [C: 032] Function name fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149844 (owner: 10Esanders) [16:18:57] (03CR) 10jenkins-bot: [V: 04-1] Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [16:19:35] (03Merged) 10jenkins-bot: Comment used messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149842 (owner: 10Esanders) [16:19:51] (03Merged) 10jenkins-bot: Function name fix [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149844 (owner: 10Esanders) [16:22:09] 3VisualEditor / 3Editing Tools: VisualEditor should display entire comment when the orange icon is clicked - 10https://bugzilla.wikimedia.org/68722#c1 (10James Forrester) 5NEW>3RESO/WON No. People writing long comments is a sign that they're doing it wrong, and encouraging such bad practice is contrary t... [16:23:12] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c4 (10James Forrester) p:5Unprio>3Highes s:5normal>3critic a:3Roan Kattouw Now back-ported to wmf14 and wmf15 in pr... [16:23:27] 3VisualEditor: VisualEditor: Changes made after canceling a Save are lost - 10https://bugzilla.wikimedia.org/68693#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68619 *** [16:23:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c5 (10James Forrester) *** Bug 68693 has been marked as a duplicate of this bug. *** [16:30:34] Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14192087 [16:30:34] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=39680433 [16:30:34] Corruption alert: visualeditor-needcheck on rowiki: https://ro.wikipedia.org/?diff=8757309 [16:30:34] Corruption alert: visualeditor-needcheck on slwiki: https://sl.wikipedia.org/?diff=4238211 [16:30:49] Hmm. [16:35:25] (03PS17) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/66920) [16:38:40] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears if you type near a [[Link]] after the {{convert}} template - 10https://bugzilla.wikimedia.org/68691#c1 (10James Forrester) 5NEW>3RESO/DUP Yeah, I think this is the same. *** This bug has been marked as a duplicate of bug 68151 *** [16:38:41] edsanders: You got anywhere with https://bugzilla.wikimedia.org/show_bug.cgi?id=68151 ? [16:38:44] 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c5 (10James Forrester) *** Bug 68691 has been marked as a duplicate of this bug. *** [16:39:19] didn't see the new instructions [16:40:09] can't reproduce with those [16:40:25] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c6 (10Erik Moeller) Nasty regression, but awesome response time - thanks, James & Ed! [16:41:08] nor on en.wiki [16:42:55] edsanders: Try editing around the templates in https://www.mediawiki.org/wiki/VisualEditor/Roadmap?veaction=edit [16:43:21] Though hmm, now I'm getting snowmen not pawns. [16:43:41] Aha, I can get both. [16:44:00] If you pre-annotate just after the template it pawns. [16:44:37] Go to just right of {{done}} (no space), type 'a' – it works fine. Undo, make bold (Ctrl+B), type 'a' – you get a pawn. [16:44:51] Hey Krinkle who is Guest63571. [16:45:34] That's freenode or your bouncer reconnecting without my authorisation [16:45:43] We've got another at Guest86688 [16:46:17] James_F: Got a bug for me? [16:46:29] Krinkle: Lots. I take it you now have power again? [16:47:04] Yep, just got back from Covent Garden to get a new one. I had power this morning via the adapter Ed helped improvise though. [16:47:19] edsanders: I think https://bugzilla.wikimedia.org/show_bug.cgi?id=67992 https://bugzilla.wikimedia.org/show_bug.cgi?id=68539 https://bugzilla.wikimedia.org/show_bug.cgi?id=68151 are all likely to be related. [16:47:23] James_F, doesn't happen with simpler templates [16:47:23] But was out and about, so didn't get much done. Will work this evening/tonight instead. [16:47:23] Krinkle: Yay. [16:47:27] could be the double sibling templates [16:47:31] edsanders: Is it because it's… yeah. [16:48:10] Krinkle: Would you be OK with a CSS/layout issue? https://bugzilla.wikimedia.org/show_bug.cgi?id=57366 is an OOUI problem that's become more acute. [16:48:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366 (10James Forrester) a:3Krinkle [16:49:03] k [16:49:22] Krinkle: I think it might "just" need a wrap CSS thing, but that probably breaks other things. [16:49:27] there's also a Y in there, you'd think img alt would be enough.... [16:49:28] oh yeah [16:49:57] edsanders: That's for MediaWiki's Hn parsing. [16:50:20] edsanders: IIRC images get discarded, as do the formatting of s but not their content. [16:50:23] I saw that all the dropdowns for tools are hidden by the surface (formatting, styling, cite, lists, insert, etc.).. [16:50:35] hn? [16:51:15] wtf, it also has a comment [16:51:24] 3VisualEditor / 3ContentEditable: VisualEditor: Character duplication in paragraphs following the {{lang-it}} template (and others?) - 10https://bugzilla.wikimedia.org/68733#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High Yeah, this looks a bit like bug 67862 but less severe. [16:51:48] edsanders: === foo {{done}} === for TOC. [16:51:59] right [16:52:03] James_F: Hm.. might actually be a reflow problem. We compute all the values and hardcode them at that point because of alignment and clippability. [16:52:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: version number in the help panel must be bidi-isolated - 10https://bugzilla.wikimedia.org/68688#c2 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal Thanks! [16:52:13] I guess the precomputed value is too short for that element somehow. [16:52:26] Krinkle: Isn't the value limited by the available space? [16:53:13] edsanders: And https://bugzilla.wikimedia.org/show_bug.cgi?id=68740 – maybe some bug merging ahead. [16:53:29] 3VisualEditor / 3ContentEditable: VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open. - 10https://bugzilla.wikimedia.org/68740 (10James Forrester) p:5Unprio>3High s:5normal>3major a:3Ed Sanders [16:53:32] James_F: there is enough space available afacs. [16:54:16] James_F: I did work on the object.create poly earlier. I'll finish that in a bit too. I'll repro this bug first so I have an idea and fix it after object.create. [16:54:16] Krinkle: Maybe the menu should not only flow to the right if it needs more space? [16:54:22] Krinkle: OK. [16:54:44] Krinkle: Repo steps: Go to https://www.mediawiki.org/wiki/VisualEditor/Roadmap?veaction=edit and click the menu. Observe width. [16:55:01] got it already, on local master [16:55:04] Kk. [16:56:44] James_F: Krinkle: wanna solve a related bug at the same time? http://i.imgur.com/9ESiLfJ.png [16:56:59] MatmaRex: That's the same bug. [16:57:26] So… yes? [16:57:39] James_F: not per steven's original description… if it is, even betterfor me :) [16:58:17] MatmaRex: Yeah, that's a new symptom of an older problem. [16:58:35] MatmaRex: Caused by me getting rid of the cancel button so giving it less space on the right in which to expand. [16:59:47] okay. i read the bug as just being about text overlapping the border (which can be caused by, say, ignoring the padding in some calculations), not about the text completely not fitting in its boxes (which is usually caused by just not calculating the width) [17:00:39] It's a snowmen counting bug [17:13:23] (03CR) 10Cmcmahon: [C: 032] "wfm" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149863 (owner: 10Vikassy) [17:15:02] (03Merged) 10jenkins-bot: [BrowserTest] Save button locator now supports language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149863 (owner: 10Vikassy) [17:19:36] 3VisualEditor / 3ContentEditable: VisualEditor: Character duplication in paragraphs following the {{lang-it}} template (and others?) - 10https://bugzilla.wikimedia.org/68733#c3 (10Axel Boldt) The effect seems to occur whenever you insert two or more characters in a paragraph after a template and then delete... [17:26:38] 3VisualEditor / 3ContentEditable: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992#c2 (10WhatamIdoing) Note from Jay8g: In this edit [https://en.wikipedia.org/w/index.php?title=Hong_Kong_International_Airport&diff=618742880&oldid=618629367],... [17:28:15] RoanKattouw_away, I couldn't duplicate this, but the user in hewiki posted this diff and said all he did was add a period and remove a space (notice the snowman and \ added) -- https://he.wikipedia.org/w/index.php?title=%D7%A8%D7%99%D7%A6%27%D7%A8%D7%93_%D7%A4%D7%90%D7%9C%D7%A7&diff=15756809&oldid=15629744 [17:28:59] (03PS1) 10Esanders: Add 'snowman' and '☃' in comment for greppability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149907 [17:30:13] now all I write about this topic comes with the music. [17:34:26] (03PS4) 10Mooeypoo: Refactoring ImageModel constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149191 [17:34:33] (03PS4) 10Mooeypoo: [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 [17:36:27] (03CR) 10jenkins-bot: [V: 04-1] [wip] Make images retain bounding boxes when the image is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149217 (owner: 10Mooeypoo) [17:40:03] Wow, did you know text-decoration actually takes three space-separated values? [17:40:07] text-decoration: underline solid rgb(6, 84, 172); [17:40:26] text-decoration-color; text-decoration-style; text-decoration-line; also work separately [17:42:51] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10Roan Kattouw) [17:44:12] (03CR) 10Catrope: [C: 032] Add 'snowman' and '☃' in comment for greppability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149907 (owner: 10Esanders) [17:44:34] Krinkle: I actually did, oddly. [17:44:58] I noticed it just now when retreiving he computed value of a css property ('underline' expands to that) [17:45:34] similar to other aggregated short-hand properties (such as 'font', 'background' and 'border') setting them to one value, resets the others. [17:45:40] (03Merged) 10jenkins-bot: Add 'snowman' and '☃' in comment for greppability [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149907 (owner: 10Esanders) [17:46:02] e.g. border: 1px dotted orange; border: 0; border-width: 2px; will not result in a 2px dotted orange border. [17:48:04] * James_F nods. [17:50:58] Lol, Amy Winehouse says "+1" as a verb in one of her songs. [17:51:05] I guess she ain't talking 'bout code. [17:51:47] actually, it's not a verb, it's just heard to unhear due to the way spaces out the words. [17:51:54] hard [17:51:58] :D [17:52:21] Krinkle: Have you been drinking? ;-) [17:54:02] Nah, just been hanging around in China town after going to the apple store. [17:54:11] Or rather, Apple market as the Britons call it. [17:54:27] (I kid you not, all signs except the store itself referred to it as apple market) [17:55:24] That sounds like a jokey reference to the fact that Covent Garden used to be a fruit market. [17:56:38] confusingly there was actually another apple market on the square as well. But it's neither an electronics store nor a fruit market. It's an antique stand called "Apple market" [17:59:59] Yes, that's the point. [18:00:10] Make fun of the past and tourists all at once? Great idea! [18:19:22] James_F, any ideas of stuff we need (gadgets/small-starter projects in VE) that a group of Hebrew speaking developers can take on? [18:27:34] mooeypoo: Not off the top of my head, really. [18:27:39] * mooeypoo nods [18:27:45] keep it in mind in case something comes up [18:28:36] Sure. [18:28:53] I'm thinking maybe getting them into templatedata stuff maybe, even though the current refactor should solve most issues -- but maybe the redesign we were talking about (with the ability to translate multiple languages in params?) Its biggest advantage is for RTL languages anyways [18:28:55] what do you think? [18:29:22] That might be quite… meaty for them. Maybe too much? [18:30:07] Maybe. I need to see what the level is of most people. The main deal would be that to get them into VE, they'll need to get into its structure. TD editor is standalone, that's why I thought about it. But yeah, maybe it's too much. [18:30:40] It shouldn't be a complete rebuild, though. Hm. Okay, I'll continue thinking, but if anything pops up as an idea we need and could fit them, let me know [18:30:50] They might want an intro to VE structure [18:31:42] heya eranroz [18:31:56] * James_F nods. [18:32:05] hi mooeypoo :) [18:35:22] (03PS1) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 [18:35:45] James_F: I'm still going through bugs and tagging the right ones for --^^ [18:35:49] mooeypoo: ------^^ [18:38:16] RoanKattouw, the link I posted above, I didn't start a bug for it yet since I couldn't immediately reproduce it [18:38:21] want me to add it to the bugs, or is the diff enough? [18:39:48] mooeypoo: What is the bug? [18:42:01] https://he.wikipedia.org/w/index.php?title=%D7%A8%D7%99%D7%A6%27%D7%A8%D7%93_%D7%A4%D7%90%D7%9C%D7%A7&diff=15756809&oldid=15629744 [18:42:24] RoanKattouw, ^^ the user said all he did was erase an errant space and add a dot at the end of a sentence .Notice the snowman and /. [18:42:48] The snowman is probably fixed by my change [18:43:05] The .\ is probably him typing in one place and it ending up somewhere else, which I've seen happen with this snowman bug [18:43:09] RoanKattouw, for https://bugzilla.wikimedia.org/show_bug.cgi?id=68597 I'm wondering about just doing https://gist.github.com/Krenair/3dea878b19c244a08fba [18:44:00] * mooeypoo nods [18:44:44] which fixes it (afaict) [18:44:46] (03PS1) 10Esanders: Remove unused CSS classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149924 [18:47:21] 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c6 (10Ed Sanders) The cause here is template with multiple unwrapped siblings, e.g. Template:Done -> [[File:tick.svg|20px]] Done [18:48:24] (03PS2) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/68740) [18:49:43] James_F: :D wikimania homepage refers to positions as "at The Wikimedia Foundation". [18:49:48] I guess that makes us TMF [18:49:54] *TWF [18:49:58] Right [18:50:08] Not the music station [18:50:12] RoanKattouw: Stop being so right-size-up-ist. [18:50:23] I actually did think TMF in my mind for some reason [18:50:34] And also not Thumb Wrestling Federation [18:50:58] … indeed. [18:52:36] Krenair: How and in what browser did you reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=68539 ? [18:52:42] I can't reproduce it in beta labs [18:52:57] (03PS3) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/68740) [18:55:19] Krenair: Re gist, you probably want if ( this.selection.start - 1 ) to have a comparison operator somewhere? [18:55:33] Hard for me to understand what you're trying to do without that [18:57:05] RoanKattouw, if this.selection.start - 1 is true-y (so, not 0), we still do the getNearestContentOffset [18:57:21] But if it's 0, we just do left = null; [18:57:33] So, you mean like this.selection.start !== 1 ? [18:57:38] Or <= 1? Or .. .? [18:58:12] this.selection.start > 1, yeah. [18:59:35] Right [18:59:55] Actually, that won't work quite well enough [19:00:10] I think we need to actually detect that there is no content offset to the left of .start [19:00:25] Consider the case

|Hello [19:00:30] ah [19:00:33] selection.start === 5 [19:00:36] yeah. [19:00:41] But getNearestContentOffset to the left will be 5 [19:00:47] James_F et al, is there a command to build the nifty OOjs UI Demos? And are they already built at a URL somewhere? [19:00:57] Okay, yep, good point. [19:01:01] spagewmf: grunt build should build them locally [19:05:14] RoanKattouw, re 68539: I can't actually use the comment tool at the moment because it's one of the many things broken by [19:05:26] I saw that all the dropdowns for tools are hidden by the surface (formatting, styling, cite, lists, insert, etc.).. [19:07:52] wtf [19:07:54] That wfm [19:10:36] http://i.imgur.com/UwGReVM.png [19:10:51] Krenair: Have you been fiddling with Vector or something locally? [19:10:57] Hmm, doesn't happen for me [19:10:59] * RoanKattouw updates MW core [19:11:15] Also, it works on Beta Labs… [19:11:38] James_F, I messed up all my extensions earlier trying to make a submodule update commit for the swat deploy [19:11:49] Ah. [19:12:05] Krenair: git clean -f is what I use when it's all broken, but it's a bit of a sledgehammer. [19:12:23] Krenair: Don't do that unless you know for sure you don't want any of your local code. [19:12:42] James_F, I made sure I had the latest master version of Vector and that's fine [19:12:59] MW Core and VE are both up to date [19:19:02] (03PS10) 10Trevor Parscal: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:20:04] (03CR) 10jenkins-bot: [V: 04-1] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:21:30] rmoen: https://gerrit.wikimedia.org/r/#/c/148761/ this change is going to make it so by deafult, a window manager doesn't tell dialogs to isolate their contents in an iframe [19:21:43] this should be very nice for you guys, since you probably don't need isolation [19:21:52] 3VisualEditor / 3ContentEditable: VisualEditor: Putting cursor after reference list throws "offset was inside a handlesOwnChildren node" error - 10https://bugzilla.wikimedia.org/68588#c1 (10Roan Kattouw) This doesn't seem to be related to focusable nodes or the end of the document. All you need to do is put... [19:22:11] and isolation has it's fair share of slowness and quirks which i know you are well aware of from your time on VE [19:22:32] rmoen: so, just a heads up, when this lands, dialogs won't nessecarily use iframes anymore (only if you ask them to) [19:23:35] mrr. RoanKattouw I'm working on the $.when() change in the media widget. I have a for loop, where I collect all promises in an array. After the for loop I go $.when( promiseArray ).done( funcForAllRequestsHaveFinished ) ---> and still the function is called without all requests are finished.... is that not the riht way to go? [19:24:07] hi TrevorParscal. feeling well today? :> [19:24:19] mooeypoo: $.when() doesn't take an array, it's variadic [19:24:25] it should be the way to go according to jquery docs [19:24:26] mooeypoo: So you need $.when.apply( $, promises ) [19:24:29] oh [19:24:37] Which will call $.when( promises[0], promises[1], ... ) [19:24:53] MatmaRex: much better, thank you [19:24:55] oh I totally misread that in the docs... that explains it [19:24:58] RoanKattouw, thanks! [19:25:29] mooeypoo: $.when() is just unhelpful. Q (a promise library I've used in nodejs) has a when-like function that just takes an array instead, which is easier to work with [19:25:54] RoanKattouw, can we use that VE, though? [19:26:00] No, we can't use Q [19:26:05] (03PS11) 10Trevor Parscal: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:26:20] We use jQuery. I was just saying how jQuery hasn't always made the best decisions [19:26:36] RoanKattouw, it makes sense that Q would be omnipotent. [19:26:43] you can use $.when.apply( $, [array of promises which can also be empty] ) [19:27:20] mooeypoo: I have watched *precisely* enough of TNG (first 2 episodes) to appreciate that joke [19:27:31] Phew. I thought I dated myself with that one. [19:27:43] Though I guess he appeared in the relatively newer series too. [19:28:08] (03PS12) 10Trevor Parscal: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:28:19] by the way, you probably want to read http://lists.wikimedia.org/pipermail/wikitech-l/2014-July/077835.html [19:29:34] (03CR) 10jenkins-bot: [V: 04-1] Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:30:12] TrevorParscal: Okay. Thanks for the heads up :) [19:31:06] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537#c1 (10Roan Kattouw) (In reply to Rummana Yasmeen from comment #0) > I am getting this iss... [19:33:04] (03PS1) 10Mooeypoo: Use to $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) [19:33:10] http://www.angelfire.com/ky/bussgobeep/beepercodes.html [19:34:02] that page is just about old enough to be accurate on the topic [19:34:11] TrevorParscal: How are things going with the mediawiki-ui like theming ? Today, we decided that we wouldn't be using ooui for this current experiment but hope to start using it in the next project. [19:34:12] (03PS1) 10Catrope: Fix copypasta in WindowManager documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/150002 [19:35:00] rmoen: well, I was out sick so I'm a little behind schedule, but I'm going to be starting today/tomorrow and hope to have something merged just after Wikimania [19:35:12] (03CR) 10Krinkle: "Hm.. why demo.html and not index.html?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [19:35:39] (03PS1) 10Krinkle: demos: Rename demos.html to index.html for convenience [oojs/ui] - 10https://gerrit.wikimedia.org/r/150003 [19:35:41] (03CR) 10Trevor Parscal: [C: 032] Fix copypasta in WindowManager documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/150002 (owner: 10Catrope) [19:35:53] (03CR) 10Krinkle: "Done in Ibd7a8ad03." [oojs/ui] - 10https://gerrit.wikimedia.org/r/148385 (owner: 10Esanders) [19:37:12] (03Merged) 10jenkins-bot: Fix copypasta in WindowManager documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/150002 (owner: 10Catrope) [19:37:36] (03PS13) 10Catrope: Create a combo box widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/143097 (https://bugzilla.wikimedia.org/61573) (owner: 10Alex Monk) [19:39:17] TrevorParscal: Thats no fun :( Sorry to hear man. Just after Wikimania sounds like good timing for us. [19:39:22] RoanKattouw: thanks, http://flow-tests.wmflabs.org/html/oojs-ui/demos/demo.html . Would be nice if this were on doc.wikimedia.org, and on qgil's team's "developer hub" concept. [19:40:12] (03PS1) 10Krinkle: demos: Add example of menu item with a long label [oojs/ui] - 10https://gerrit.wikimedia.org/r/150006 [19:40:17] spagewmf: I think Krinkle has been working on getting the oojs-ui demo on doc.wm.o [19:40:27] But I don't know what the status of that is [19:41:06] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10Roan Kattouw) [19:41:51] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589#c1 (10Roan Kattouw) From other reports it sounds like this may be happening for all focusable nodes, not just galleries. [19:42:13] RoanKattouw: spagewmf: Status is mostly me having to figure out the strategy to put it there properly. Not complicated, but not priority atm. [19:42:36] 3VisualEditor / 3Data Model: VisualEditor: Investigate parsing/rendering/behavior of "{{MW 1.23}}" on mediawiki.org - 10https://bugzilla.wikimedia.org/68297#c3 (10Roan Kattouw) The pawn, snowman and offset exception bugs should be fixed by https://gerrit.wikimedia.org/r/149920 . The scrolling all the way up... [19:42:49] could do a on-off hour sprint to get a fixed copy there, but it'd just get outdated. [19:43:18] contrary to the docs, it needs a grunt-build to be produced. Which isn't possible in production right now. [19:43:46] the ve demos under doc.wikimedia.org (e.g. for ve.init.sa.Target) don't have this problem since they load all files from git, and oojs-ui is precompiled in got for that [19:43:55] git [19:43:58] (03CR) 10Catrope: [C: 032] Update oojs to v1.0.11 [oojs/ui] - 10https://gerrit.wikimedia.org/r/149602 (owner: 10Jforrester) [19:44:23] (oh, i've been curious – can somebody tell me in one sentence why does oojs ui need a build process?) [19:44:35] James_F: btw, both of these urls have valid https variants. Funnily enough, neither is enforced. [19:44:44] I thought git.wm.o would be enforced at least. [19:44:55] Krinkle: Complain to Chad? :-) [19:44:55] (03CR) 10Esanders: [C: 032] demos: Rename demos.html to index.html for convenience [oojs/ui] - 10https://gerrit.wikimedia.org/r/150003 (owner: 10Krinkle) [19:45:05] (03CR) 10Jforrester: [C: 032] demos: Rename demos.html to index.html for convenience [oojs/ui] - 10https://gerrit.wikimedia.org/r/150003 (owner: 10Krinkle) [19:45:12] Thx guys.. [19:45:17] (03CR) 10Jforrester: [C: 032] demos: Add example of menu item with a long label [oojs/ui] - 10https://gerrit.wikimedia.org/r/150006 (owner: 10Krinkle) [19:45:23] Ha. [19:45:36] (03PS2) 10Krinkle: Update oojs to v1.0.11 [oojs/ui] - 10https://gerrit.wikimedia.org/r/149602 (owner: 10Jforrester) [19:45:40] (03CR) 10Krinkle: [C: 032] Update oojs to v1.0.11 [oojs/ui] - 10https://gerrit.wikimedia.org/r/149602 (owner: 10Jforrester) [19:47:51] (03Merged) 10jenkins-bot: demos: Rename demos.html to index.html for convenience [oojs/ui] - 10https://gerrit.wikimedia.org/r/150003 (owner: 10Krinkle) [19:47:55] (03Merged) 10jenkins-bot: demos: Add example of menu item with a long label [oojs/ui] - 10https://gerrit.wikimedia.org/r/150006 (owner: 10Krinkle) [19:47:59] (03Merged) 10jenkins-bot: Update oojs to v1.0.11 [oojs/ui] - 10https://gerrit.wikimedia.org/r/149602 (owner: 10Jforrester) [19:48:50] Krinkle: Oh, you mean the URLs in the OOjs commit message? [19:48:59] yeps [19:49:05] Krinkle: I was just stealing your commit message from a previous time. [19:49:08] ha [19:49:13] So I blame you. :-) [19:50:37] 3VisualEditor: VisualEditor: In which it is apparently impossible to create a redirect to [[Foo]] because the list of possible links does not scroll - 10https://bugzilla.wikimedia.org/67150#c1 (10Roan Kattouw) Clarification: the list of links does scroll, it's just that there's only 10(?) of them and Foo isn'... [19:50:42] James_F: https://bugzilla.wikimedia.org/show_bug.cgi?id=67150 is another case of the "opensearch sucks" bug, I forget what exactly we use to track all that stuff [19:51:01] RoanKattouw: It's not tracked, we just DUPE into it. [19:51:08] OK [19:51:25] This is slightly different though, maybe a depends on [19:51:25] (03CR) 10Esanders: [C: 04-1] Generate only one pair of snowmen for multi-sibling nodes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/68740) (owner: 10Catrope) [19:51:40] RoanKattouw: ISTR the bug is "OpenSearch isn't good for telling if a page exists". [19:51:43] RoanKattouw: So… [19:51:55] (03CR) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/68740) (owner: 10Catrope) [19:56:02] James_F, I tried to debug this, and I am at a loss https://bugzilla.wikimedia.org/show_bug.cgi?id=66210 [19:58:03] I''m not sure I understand enough about when nowiki shows up to get the problem. Who's the person to consult on with this? [19:58:13] (03PS4) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 [19:58:27] James_F, still no idea why the menus are hidden on my machine :/ [19:59:14] (03CR) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (owner: 10Catrope) [20:00:54] 3VisualEditor / 3Editing Tools: VisualEditor:Applying changes in Advanced settings are not reflected in Review your changes dialog. - 10https://bugzilla.wikimedia.org/68761 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16069 --> https://bugzilla.wikimedia.org/attachment.cgi?id... [20:03:22] 3VisualEditor / 3Editing Tools: VisualEditor:Applying changes in Advanced settings are not reflected in Review your changes dialog. - 10https://bugzilla.wikimedia.org/68761#c1 (10Roan Kattouw) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 68619 *** [20:03:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c7 (10Roan Kattouw) *** Bug 68761 has been marked as a duplicate of this bug. *** [20:04:24] 3VisualEditor / 3Editing Tools: VisualEditor: Opening the link inspector and closing while selecting an image moves the image to the previous position - 10https://bugzilla.wikimedia.org/68762 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert an i... [20:04:51] 3VisualEditor / 3Editing Tools: VisualEditor: Opening the link inspector and then closing, while selecting an image moves the image to the previous position - 10https://bugzilla.wikimedia.org/68762 (10Rummana Yasmeen) [20:07:32] James_F: Hm.. so why is the image for an html comment an alert icon again? [20:07:34] I forgot [20:07:48] (also why orange? that's agora, not apex, right?) [20:08:15] Krinkle: Because it's a rare occasional alert that something is bad or people should be careful. It's akin to a "Warning: Electric fence" sign. [20:08:42] And it's orange because PostIt yellow didn't have enough contrast. [20:08:49] Other colours are possible. [20:09:24] right now it's a color completely out of any relevant color scheme (oojs apex, ve default, mw vector) [20:09:36] It's in OOjs UI Agora. [20:09:39] Or… will be. [20:09:54] 3VisualEditor / 3Editing Tools: VisualEditor:Applying changes in Advanced settings are not reflected in Review your changes dialog. - 10https://bugzilla.wikimedia.org/68764 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16070 --> https://bugzilla.wikimedia.org/attachment.cgi?id... [20:09:55] Trevor thinks he'll have that done this week, which'd be impressive. [20:09:58] that's as relevant as a color from monobook or cologne blue [20:10:08] Well, not for long. [20:10:37] 3VisualEditor / 3Editing Tools: VisualEditor:Applying changes in Advanced settings are not reflected in Review your changes dialog. - 10https://bugzilla.wikimedia.org/68764#c1 (10Ritu Swain) Created attachment 16071 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16071&action=edit screenshot2 [20:12:25] I'm just confused how that makes sense to use that color now. It sticks out like a sore thumb. It doesn't say "comment" anywhere until you open the editor (and no tooltip). The error/warning icon and speech speech bubble seem to conflict as well. [20:14:03] Krinkle: there's a patch pending :) https://gerrit.wikimedia.org/r/#/c/149354/ [20:14:53] If we'd plan to switch to colonge blue as some point point, that doesnt mean it makes sense to change a random part of the interface to use that color or style. Anyhow, I guess it's just a color. At least the icon isn't foreign. [20:15:16] so... that's just the default icon already part of oojs-ui [20:15:52] (03CR) 10Krinkle: "So.. this is just the default icon already in oojs-ui. Do we still need it to be an override in VE?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [20:17:10] 3VisualEditor / 3Editing Tools: VisualEditor:Applying changes in Advanced settings are not reflected in Review your changes dialog. - 10https://bugzilla.wikimedia.org/68764#c2 (10James Forrester) 5UNCO>3RESO/DUP Yes, this is bug 68619. *** This bug has been marked as a duplicate of bug 68619 *** [20:17:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Changes made after reviewing changes are not sent (when caching is enabled) - 10https://bugzilla.wikimedia.org/68619#c8 (10James Forrester) *** Bug 68764 has been marked as a duplicate of this bug. *** [20:17:29] Krinkle: It's intended to "stick out like a sore thumb". [20:17:53] Urgh [20:18:16] Krinkle: Why is unicode-bidi: -moz-isolate; rejected by csslint in VE-MW but accepted by csslint in MW core? [20:18:32] James_F, pff, a ctrl+shift+R eventually fixed it, after I noticed firefox was showing the dropdowns correctly [20:19:11] Krenair: Ha! [20:19:35] Krinkle: nm, csslint doesn't run for MW core, that explains it [20:19:36] RoanKattouw: Not sure. different version in package.json? And rejected locally or also on jenkins? If only locally, maybe it's a .x or ~ version dependency, rm -rf node_modules and re-install to purge [20:20:07] (03PS1) 10Amire80: Shorten visualeditor-dialog-referencelist-insert-button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 [20:20:11] edsanders|away: Ping re. https://gerrit.wikimedia.org/r/149920 [20:20:15] RoanKattouw, why would csslint reject it in general, though? [20:20:28] It says "Properties should be known or be a vendor-property" [20:20:32] But this IS a vendor property [20:21:06] :\ [20:22:22] 3VisualEditor: VisualEditor: the "Save your changes" window title can be overlapped by the "Save page" button - 10https://bugzilla.wikimedia.org/68571#c3 (10Amir E. Aharoni) This happens even in English in the "Insert references list" dialog. [20:23:06] (03PS3) 10Catrope: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:23:16] RoanKattouw, I can't reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=68539 now :/ [20:23:32] It was in chrome [20:23:34] (03CR) 10jenkins-bot: [V: 04-1] Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:23:48] (03PS4) 10Catrope: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:24:48] (03PS2) 10Amire80: Shorten visualeditor-dialog-referencelist-insert-button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 [20:25:21] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c3 (10Alex Monk) I can't reproduce this now, Roan couldn't either. Ritu, does this still happen for you? [20:25:35] (03CR) 10jenkins-bot: [V: 04-1] Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:26:04] (03PS5) 10Catrope: Bidi-isolate the version in the help panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:28:35] (03CR) 10Eranroz: Bidi-isolate the version in the help panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:31:28] (03CR) 10Catrope: [C: 04-1] "Per Ed's comment on PS4" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149656 (https://bugzilla.wikimedia.org/68688) (owner: 10Amire80) [20:44:53] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584#c1 (10Ryan Kaldari) What was the error message you were seeing? Something about an invalid character. [20:53:21] (03PS4) 10Krinkle: CommentNode: Change icon from orange to grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [20:55:34] (03PS5) 10Krinkle: CommentNode: Change icon from orange to grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [20:58:24] Krinkle, you have a moment? I could use your input on this bug. I see you've answered, but there's a reply after yours that seem to contest it? I'm trying to understand how to try and solve this issue (also, I think this may be the reason for our 'callback' issues with the API requests?) https://bugzilla.wikimedia.org/show_bug.cgi?id=64822 [21:07:11] (03PS6) 10Krinkle: CommentNode: Change icon from orange to grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [21:07:41] 3VisualEditor / 3Editing Tools: Cite tool unexpected tabbing behavior - 10https://bugzilla.wikimedia.org/68768 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None This is possibly by design, but I found it unexpected: Use the Cite tool with any example having multiple fields to fill in, e.g. Website... [21:13:38] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c5 (10Krinkle) (In reply to Barry Coughlan from comment #2) > The crossDomain logic will switch between the 'script' and 'xhr' t... [21:14:52] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c6 (10Krinkle) (In reply to Krinkle from comment #5) > [callback] is only applied when the "jsonp" transport is activated (build... [21:15:23] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584#c2 (10Rummana Yasmeen) The error message that I get in the console is:SyntaxError: Invalid character '\u0031' [21:17:09] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c7 (10Krinkle) (In reply to Barry Coughlan from comment #2) > The crossDomain logic will switch between the 'script' and 'xhr' t... [21:19:39] Krinkle, sorry, I'm a bit confused. So, if it's an internal operation of jQuery, why is it failingin our code when we use $.ajax? [21:24:23] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584#c3 (10James Forrester) This occurs on desktop Safari too. It disappears when debug=true is used. Looking at the content response, it looks like Safari is get... [21:26:07] 3VisualEditor / 3Editing Tools: VisualEditor: Reconsider cite tool tabbing behaviour to go to the next field (not the info or remove buttons) - 10https://bugzilla.wikimedia.org/68768#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc Yeah, this is intentional, but maybe we should... [21:27:21] 3VisualEditor / 3Editing Tools: VisualEditor should display entire comment when the orange icon is clicked - 10https://bugzilla.wikimedia.org/68722#c2 (10This, that and the other (TTO)) You don't think 8 words is rather too short? [21:30:54] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c8 (10Krinkle) (In reply to Krinkle from comment #7) > (In reply to Barry Coughlan from comment #2) > > The crossDomain logic wi... [21:31:45] mooeypoo: Do we have the source ID in MWMediaSearchWidget? [21:32:02] e.g. 'local' or '(free form id, like "commons", whatever mw file repo has set up)' [21:32:10] basically use json for local and jsonp for ther est. [21:32:23] no need for cross domain. A foreign wiki can also be on the same domain in theory. [21:34:08] mooeypoo: Looks like it has a local:true propery? [21:35:40] James_F: interesting on local with fewer button sin the toolbar (compared ot the bug report attachment) http://i.imgur.com/hB3ihRv.png [21:35:51] advanced settings is affected for me as well [21:36:29] due to Cancel being removed [21:36:36] Krinkle: Yes, that's the bug… [21:36:54] Hm.. thats now on mw.org [21:37:01] did that co live in the past few hours? [21:37:51] when Cancel was there the width happened to be perfect that it looked right-aligned, but it's really left aligined under the button [21:37:51] (03PS5) 10Trevor Parscal: Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [21:37:54] Krinkle: No. It was in wmf15, I think. [21:37:56] and clipped to the edge of the screen. [21:38:08] Krinkle: Yes, that's what I was saying. [21:38:18] at least it has a scrollbar [21:38:47] (03PS6) 10Trevor Parscal: [BREAKING CHANGE] Merge Window and Frame, make content isolation optional [oojs/ui] - 10https://gerrit.wikimedia.org/r/148761 [21:40:11] hm [21:41:45] mooeypoo: Hmm? [21:42:56] James_F: Looks like the icon crop is still on wmf http://imgur.com/CZoxthI - should be backport the commit that fixed the dimensions to show the entire icon and not just the top left corner? [21:43:11] s/be/we [21:43:36] James_F, I'm trying to make sense of the local repos vs remote in the code. I was 'hm'ing at Krinkle's remark about the local:true property. [21:44:48] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (b0e8f2d611) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 [21:44:52] Oh, right. [21:44:57] 3VisualEditor: beta labs: JS error upon loading any page - 10https://bugzilla.wikimedia.org/68771 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Load a random page on beta labs and add ?veaction=edit, for example; http://en.wikipedia.beta.wmflabs.org/wiki/0.6273652043629694?veaction=edit JS cons... [21:45:08] (03PS1) 10Trevor Parscal: Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 [21:45:38] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150051 (owner: 10Trevor Parscal) [21:45:39] mooeypoo: meta filerepos; { query: repos: [ { name: "...", local: false, scriptDirUrl: "//commons"}, { name: "local", local: true, scriptDirUrl: "/w" [21:46:14] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (b0e8f2d611) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150050 (owner: 10Trevor Parscal) [21:46:14] it's even better than I thought. Although "local" is a reserved name, they separated that out so you don't have to look at the name. [21:46:27] there's a boolean prop for it [21:46:43] dataType: local ? 'json' : 'jsonp' basically. [21:47:39] mooeypoo: lol, we'e already using .local! [21:47:40] if ( source.local ) { [21:47:50] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (e9cf571db2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149604 [21:48:12] TrevorParscal: Please look at https://gerrit.wikimedia.org/r/149524 (+comments) [21:48:20] mooeypoo: Maybe use the else branch to set .url, .cache and .dataType [21:48:26] and default to letting apiRequest handle it [21:48:30] TrevorParscal: Also we need toolbar changes for https://gerrit.wikimedia.org/r/141091 to work [21:48:33] (which is already the correct url, cache and dataType) [21:49:10] e.g. var ajaxOptions = {} and pass as 2nd parameter [21:50:39] 3VisualEditor: beta labs: JS error upon loading any page - 10https://bugzilla.wikimedia.org/68771#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 68493 *** [21:50:51] 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported." on opening the editor - 10https://bugzilla.wikimedia.org/68493#c1 (10James Forrester) *** Bug 68771 has been marked as a duplicate of this bug. *** [21:51:36] 3VisualEditor / 3ContentEditable: VisualEditor: Chrome 36 and higher throws "Discontiguous selection is not supported" on opening the editor - 10https://bugzilla.wikimedia.org/68493 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [21:53:07] 3VisualEditor / 3Editing Tools: VisualEditor: ve.ui.MWMediaSearchWidget fails on private wikis due to forced use of JSON-P (logged-out API) - 10https://bugzilla.wikimedia.org/64822#c9 (10James Forrester) *** Bug 68141 has been marked as a duplicate of this bug. *** [21:53:07] 3VisualEditor / 3Editing Tools: can't search image when inserting media in private wiki - 10https://bugzilla.wikimedia.org/68141#c3 (10James Forrester) 5NEW>3RESO/DUP I think this is bug 64822. *** This bug has been marked as a duplicate of bug 64822 *** [21:55:41] (03CR) 10Trevor Parscal: "Like if the description needs to use internationalized messages, or use information available only to the view like text direction. The mo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders) [21:55:50] (03PS1) 10JGonera: Delay scrolling to a heading more on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150052 [21:56:01] (03CR) 10Catrope: [C: 032] Copy annotation indexes before returning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149633 (https://bugzilla.wikimedia.org/68677) (owner: 10Esanders) [21:56:38] TrevorParscal: https://gerrit.wikimedia.org/r/149635 is another one that sounds like you'd be a good person to review it [21:57:06] 3VisualEditor / 3Editing Tools: VisualEditor should display entire comment when the orange icon is clicked - 10https://bugzilla.wikimedia.org/68722#c3 (10James Forrester) (In reply to This, that and the other (TTO) from comment #2) > You don't think 8 words is rather too short? The number of words shown is... [21:57:12] (03Merged) 10jenkins-bot: Copy annotation indexes before returning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149633 (https://bugzilla.wikimedia.org/68677) (owner: 10Esanders) [21:57:49] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (3872a4a) [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149606 (owner: 10Jforrester) [21:58:00] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (8686f85) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149603 (owner: 10Jforrester) [21:59:28] (03CR) 10Trevor Parscal: [C: 04-1] "I feel like there are 2 things here:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [21:59:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (3872a4a) [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/149606 (owner: 10Jforrester) [21:59:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (8686f85) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149603 (owner: 10Jforrester) [22:00:34] (03CR) 10Trevor Parscal: [C: 032] CommentNode: Change icon from orange to grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [22:02:02] (03Merged) 10jenkins-bot: CommentNode: Change icon from orange to grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149354 (owner: 10Esanders) [22:03:52] (03PS1) 10Mooeypoo: Switch between json/jsonp for local/remote api search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) [22:04:12] (03PS1) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 [22:04:36] (03CR) 10Cmcmahon: [C: 04-2] "WIP" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 (owner: 10Cmcmahon) [22:05:57] (03PS2) 10Mooeypoo: Switch between json/jsonp for local/remote api search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) [22:10:09] Krinkle, ^^ like this? :) [22:10:20] (03CR) 10Krinkle: "yep, though a few minor clean ups to be done." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [22:10:40] if this is what you meant, I feel a lot better. The bug report made it sound like it's going to be some crazy manipulation of internal jquery stuff. [22:10:45] It is [22:11:00] woot [22:12:57] (03CR) 10Trevor Parscal: [C: 04-1] "Instead of referring to a CSS class introduced by ve.ui.Surface (an unrelated class) that isn't even selected for styling unless you are i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149635 (https://bugzilla.wikimedia.org/68486) (owner: 10Esanders) [22:13:39] TrevorParscal: thx for the icon change merge [22:13:43] TrevorParscal: Some more light reading: https://gerrit.wikimedia.org/r/149856 https://gerrit.wikimedia.org/r/149924 [22:14:49] mooeypoo: Re https://gerrit.wikimedia.org/r/#/c/150001/: 1) dang! almost got 150k there; 2) "Use to"? [22:15:44] Dang, hashar got 150k [22:15:48] https://gerrit.wikimedia.org/r/#/c/150000/ [22:15:50] mooeypoo: Also, you may enjoy the code review comments at https://gerrit.wikimedia.org/r/#/c/149920/3/modules/ve/ce/ve.ce.js [22:16:02] QUnit upgrade to more slaves. Not bad :) [22:16:18] oops hah [22:16:48] (03PS2) 10Mooeypoo: Use $.when() in MediaSearchWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150001 (https://bugzilla.wikimedia.org/65321) [22:20:56] when can i steal a trevor, or a trevor-equivalent, for a few hours? :( [22:21:11] He's not at his desk right now [22:21:19] What do you want a Trevor for? :) [22:21:28] (03CR) 10Krinkle: "In fact, considering they are joined by a comma, that means they should be localised already. message:comma-separator for yay languages th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [22:22:24] (03PS3) 10Mooeypoo: Switch between json/jsonp for local/remote api search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) [22:22:58] trevor-equivalent would be a RoanKattouw ? [22:23:08] Depends on what he wants :) [22:23:16] It may also be a Krinkle , or a James_F|Away [22:23:20] Indeed [22:23:38] I am wondering if we should get you one of those work shirts with changeable name tag [22:23:40] :D [22:23:45] hahaha [22:24:15] There's this Google doc somewhere that James wrote at some point [22:24:22] It was about who has what roles on our team [22:24:47] For me it said something like "Primary on: data model. Secondary on: all" [22:24:56] did yours have lines connecting to all other names? [22:25:03] hah [22:25:09] No, wait, Ed was primary on DM [22:25:16] I think I was primary on integration or something at the time [22:25:18] Or maybe CE, pre-David [22:25:56] We need like mixinClass for roles [22:25:59] omg RoanKattouw and edsanders|away I am SO PRINTING THIS CODE [22:26:08] or humans for that matter [22:26:09] RoanKattouw: for https://gerrit.wikimedia.org/r/#/c/141259/ [22:26:10] :D [22:26:14] https://gerrit.wikimedia.org/r/#/c/149920/3/modules/ve/ce/ve.ce.js <-- this is going to be framed and hanged on my wall [22:26:19] mooeypoo: Oh the var olaf that Ed wouldn't let me keep? ;) [22:26:27] he didn't let you keep it?! [22:26:30] party pooper [22:26:41] Oh I should've linked you to 3..4 instead [22:26:46] Change /3/ to /3..4/ in the URL and see [22:26:56] does it still do what it's supposed to do in summer? [22:26:59] Also my response to his comment kind of says it [22:27:03] onlineusers.filter(rdfaMatchTags, [trevor ish]) [22:27:37] mooeypoo: No I made it do that, by taking it out. It melted away into nothingness [22:27:55] Aww [22:28:01] incremental back off for timeout and fallback [22:28:02] haha [22:28:05] Well, love is worth melting for. [22:28:13] RoanKattouw, for https://bugzilla.wikimedia.org/show_bug.cgi?id=68597 - I looked into the way ve.dm.ElementLinearData.prototype.getRelativeOffset deals with working out what direction it should be going looked a bit strange [22:28:25] stop making fun of melted things. [22:28:27] It tries to force positive direction if at 0 or less [22:28:41] :D [22:28:49] MatmaRex: howdy [22:28:53] it was a traumatising experience. [22:28:59] If you get rid of "offset <= 0 ? 1 :" we end up getting the correct annotations, I think [22:29:00] TrevorParscal: [15:26] MatmaRex RoanKattouw: for https://gerrit.wikimedia.org/r/#/c/141259/ [22:29:30] Krenair: Yeah there's some thing where if it can't go one way it bounces around and starts going the other way, or something [22:29:37] yeah. [22:29:45] Which we want to be able to disable for this [22:32:12] Well, I wonder if it's ever necessary [22:32:22] Which depends on what the other callers want, and I don't know who they are offhand [22:33:04] Yeah, I'm wondering as well [22:36:35] RoanKattouw: Hm.. I'm trying to add a right-aligned menu to the toolbar oojs-ui to further investigate and fix bug 57366 / http://i.imgur.com/hB3ihRv.png [22:36:45] I still can't believe ed made you get rid of olaf, RoanKattouw. Also, I think I'm going to add this to my "Why you should join open source and be awesome" lecture for the "Women who code" israel branch. [22:36:53] hahahahaha [22:36:54] RoanKattouw: We're... we're instantiating two TargetToolbars in mw.VPT [22:36:56] That's awesome! [22:37:09] and then appending one internal $element to the other and float:right [22:37:11] Krinkle: A left one and a right one? [22:37:14] no [22:37:26] well, ish. [22:37:29] but kinda weird [22:37:41] the other instance is not referenced or kept anywhere [22:37:43] One "real" toolbar and one with the hamburger menu in it, right? [22:37:48] other than to construct a list of nodes and append it into the other [22:37:51] yeah [22:38:09] So at least it's /displayed/ somewhere [22:38:57] at least $actions is supported natively [22:39:05] ? [22:39:13] Krinkle: are you thinking the menu should automatically choose it's alignment based on the situation? [22:39:19] oojs/ui/demos/#toolbars-apex-ltr [22:39:21] that's how menus work on desktop GUIs [22:39:26] the buttons are right aligned because they're actions [22:39:47] but the toolbar does not 'spport' a menu on the right. Instantiating a second toolbar and dstroying it except for that oojui widget with the menu list seems weird [22:39:54] and then injecting it without the toolbar knowing [22:40:47] the menu should probably have a way of determining if it has more space on the right or left, trying to exapnd in the direction of text first (e.g. right for LTR) and going the opposite direction if needed [22:41:09] TrevorParscal: yeah, either the menu should be a regular item that gets aligned based on some setting, or even just a very bold left/right toolbar.setup(). So long is recognised as a thig in the code and not unmaintainable like this. [22:41:27] thing* [22:41:44] so taht if you ask the toolbar for its actions or items, that it knows about these. [22:41:57] what I am saying is that it should be viewport aware and open in the direction that it has space [22:42:16] TrevorParscal: We're talking about different things [22:42:20] ok [22:42:20] completely :D [22:42:26] i see [22:42:30] haha. i complained about that toolbar things here a few weeks ago [22:42:33] TrevorParscal: But yes, I was planning on that already. [22:42:48] TrevorParscal: I'm referring to how that hamburger menu ends up in the toolbar in the first place. [22:42:53] makes it a bit hard to restyle the toolbar, with the messed up nesting it creates [22:43:24] you mean how the menu is actually just a list of tools? [22:43:44] TrevorParscal: Right now ve-mw constructors two complete toolbars (one with the content actions, and one with just a hamburger menu, then it pops the hood of the content toolbar and injects the hamburger widget element into it and destroys the rest of that second toolbar) [22:44:13] yeah, that is a mess [22:44:17] (03PS2) 10Cmcmahon: [BrowserTest] WIP: create new test for Cite tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150055 [22:44:19] tearing off buttons… http://i.imgur.com/vdizOUQ.jpg [22:44:23] Which means it has no knowledge of it, and I can't test, document or reproduce it in the oojs-ui demos. [22:45:17] TrevorParscal: but yeah, the aligned clippable widget itself should back off the edge of the screen. Similar to how we do with search suggestions in Vector. [22:45:26] and most of jquery-ui's position logic as well [22:45:39] i think there are two ways of looking at this - either we make an MWEditorToolbar (or whatever) which composes 2 toolbars and manages this (rather than doing it all in ve.init.MWViewPageTarget [22:45:44] prefer bottom-left corner alignment, and offset to the left if the right is too close and visa versa for rtl. [22:45:54] or make OO.ui.Toolbar have support for putting stuff on the left/right [22:46:25] TrevorParscal: Looks like Oo.ui.Toolbar already has support for action buttons on the right, just not menus. [22:46:47] 'tools' and 'actions' respectively. [22:46:52] (left/right) [22:47:02] yeah, that is a hack then [22:47:11] mooeypoo: I still remember when many years ago (2011 I think) I was reviewing piles and piles of Neil's UploadWizard code. It was like a multi-day task. Several hours in I saw: [22:47:12] maybe we should allow tools to contain action buttons, and actions to contain tools (e.g. a menu) [22:47:17] var _this = this; // was a triumph [22:47:32] Which made me a lot happier with having to spend more hours reviewing :) [22:47:37] TrevorParscal: and then of course name them something else (maybe left/right, or something more sophisticated) [22:47:59] ideally there would be a logical separation, like [content tools|empty space|document tools] [22:48:08] right [22:48:22] RoanKattouw: _this? [22:49:19] nevermind, he told me in person, I don't have to yell [22:49:36] Yeah, don't use _this kids, it's not cool any more [22:49:46] * marktraceur finally fixed all of those *this year*, RoanKattouw [22:50:06] *_this year [22:50:18] marktraceur: Did you at least keep the // was a triumph comment? [22:52:09] TrevorParscal: :o [22:52:59] TrevorParscal: thanks for the +2, rebasing :) [22:54:01] TrevorParscal: done [22:55:39] Added in 3b9eae7f1b02b607e79190fc480e40a0b26aedab [22:55:48] Removed in 5c4a288309ec5d49df792373502966b61cc9bac8 [22:55:57] Doubt it [22:59:37] whee. thanks for the merge Krinkle TrevorParscal. i'm going to have "fun" documenting and announcing it tomorrow, heh [23:13:21] (03CR) 10Catrope: [C: 04-1] POC DONTMERGE: Unicorn (0326 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:14:16] (03CR) 10Catrope: "Trevor is looking into getting rid of the DOM manipulation in getSelectionRect(). Based on git blame it looks like it was originally a hac" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:14:46] RoanKattouw, which is a great reason to keep Olaf. [23:14:48] :D [23:16:52] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e9cf571db2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149604 (owner: 10Jforrester) [23:18:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e9cf571db2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149604 (owner: 10Jforrester) [23:37:57] RoanKattouw, meh, I don't like the idea of adding a 'bounce' argument to all the related functions to control this... [23:38:17] But it's probably there for a reason, we probably shouldn't remove it [23:41:59] I wouldn't assume that too quickly [23:42:07] Have you grepped for callers? [23:57:29] Just in ElementLinearData: getRelativeContentOffset (called by getAnnotationIndexesFromOffset, getNearestContentOffset), getRelativeStructuralOffset (called by getNearestStructuralOffset) [23:57:43] Bunch more outside, obviously