[00:00:18] Hmph right [00:00:24] So a lot of get*FromOffset stuff [00:28:51] 3VisualEditor / 3Data Model: VisualEditor: Typing over a link doesn't undo correctly - 10https://bugzilla.wikimedia.org/68677 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [00:37:39] 3VisualEditor / 3Editing Tools: VisualEditor: Comment icon is truncated - 10https://bugzilla.wikimedia.org/68721#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal s:5normal>3minor a:3Ed Sanders Fixed and deployed to wmf15 an hour ago. Sorry! [00:47:52] 3VisualEditor / 3Data Model: VisualEditor: References as part of a file description are misnumbered - 10https://bugzilla.wikimedia.org/65235#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor They now show as references [73], [74] and [75] (off-by-one error?0 [00:49:28] (03PS5) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [00:51:53] 3VisualEditor / 3ContentEditable: VisualEditor: ☃ symbol replicates when creating an article with a template - 10https://bugzilla.wikimedia.org/68147 (10James Forrester) p:5Unprio>3High s:5normal>3major a:3Roan Kattouw [00:52:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: Switching tabs in mobile safari often causes page to refresh causing data loss of session changes - 10https://bugzilla.wikimedia.org/68017 (10James Forrester) 5NEW>3ASSI [00:53:22] 3VisualEditor / 3ContentEditable: VisualEditor: Hidden templates should display as an icon in-page so they can be interacted with (e.g. a puzzle piece?) - 10https://bugzilla.wikimedia.org/49806 (10James Forrester) s:5major>3enhanc [00:58:04] (03CR) 10Jforrester: "Ping – Alex, are you going to work on this some more?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140868 (https://bugzilla.wikimedia.org/65513) (owner: 10Alex Monk) [01:04:54] 3VisualEditor / 3Technical Debt: VisualEditor: Zero width no-break space is added to the end of the article (in a slug) in the editing element (but not the document) - 10https://bugzilla.wikimedia.org/54051#c1 (10James Forrester) p:5High>3Low s:5major>3enhanc Presumably this is ve.ce.BranchNode.$bloc... [01:09:23] 3VisualEditor / 3ContentEditable: VisualEditor: Typing between text and a reference produces a pawn in Firefox - 10https://bugzilla.wikimedia.org/58315#c2 (10James Forrester) 5ASSI>3RESO/FIX This appears to be now fixed. I think. [01:12:40] (03CR) 10Alex Monk: "I think me and Roan were going to talk to Trevor about this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140868 (https://bugzilla.wikimedia.org/65513) (owner: 10Alex Monk) [01:19:23] 3VisualEditor / 3Editing Tools: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [01:19:39] 3VisualEditor / 3ContentEditable: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10James Forrester) a:3Ed Sanders [01:21:11] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off gallery into slug scrolls viewport to the top of the document, not the slug - 10https://bugzilla.wikimedia.org/68589 (10James Forrester) [01:21:14] 3VisualEditor / 3ContentEditable: VisualEditor: Remove media or templates, page loses focus - 10https://bugzilla.wikimedia.org/68708 (10James Forrester) [01:21:14] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off the page with left/right doesn't scroll the cursor in to view - 10https://bugzilla.wikimedia.org/58038 (10James Forrester) [01:31:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal What is a "real bug report form"? [01:33:08] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [01:33:24] 3VisualEditor / 3ContentEditable: VisualEditor: Comment Edit dialog does not close, after inserting a list. - 10https://bugzilla.wikimedia.org/68738#c1 (10James Forrester) 5UNCO>3RESO/DUP Merging with bug 68679. *** This bug has been marked as a duplicate of bug 68679 *** [01:33:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679#c2 (10James Forrester) *** Bug 68738 has been marked as a duplicate of this bug. *** [01:34:52] 3VisualEditor / 3Editing Tools: VisualEditor: Template dialog should not display html comment in the parameter label - 10https://bugzilla.wikimedia.org/67657 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [01:42:37] 3VisualEditor / 3Data Model: VisualEditor: Metas at the end of a link annotation's anchor cause it to be split; should instead change with it - 10https://bugzilla.wikimedia.org/68779 (10James Forrester) p:5Unprio>3Low [01:42:39] 3VisualEditor / 3Data Model: VisualEditor: Metas at the end of a link annotation's anchor cause it to be split; should instead change with it - 10https://bugzilla.wikimedia.org/68779 (10James Forrester) 3ASSI p:3Unprio s:3normal a:3None (Taken from bug 52127.) Previously, before comments were node-i... [01:43:24] 3VisualEditor / 3Data Model: VisualEditor: Editing a link spanning a comment splits the link - 10https://bugzilla.wikimedia.org/52127#c5 (10James Forrester) 5ASSI>3RESO/FIX This is now fixed because comments are editable (finally), but there's a wider, lower-priority issue for non-comments, for which I h... [01:44:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: If making a null change, the "Your edit was saved" message appears, even if there were no changes and so it wasn't - 10https://bugzilla.wikimedia.org/51243 (10James Forrester) a:3Alex Monk [01:45:06] 3VisualEditor / 3ContentEditable: VisualEditor: saving fails silently for some large edits - 10https://bugzilla.wikimedia.org/52640#c2 (10James Forrester) 5NEW>3RESO/WOR No subsequent reports or steps to fix; marking as WORKSFORME. [01:47:22] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the preceding text of a reference icon - 10https://bugzilla.wikimedia.org/57632#c2 (10James Forrester) 5NEW>3RESO/FIX This looks fixed to me. Not sure exactly when. [01:48:51] 3VisualEditor / 3ContentEditable: VisualEditor: Shift-selection of a template and then typing-replacement can cause pawns in Firefox - 10https://bugzilla.wikimedia.org/61538#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High This is fixed now. [01:49:36] 3VisualEditor / 3Editing Tools: VisualEditor:Pawns and some other icons are appearing while typing fast on a page on betalabs - 10https://bugzilla.wikimedia.org/57953#c4 (10James Forrester) 5NEW>3RESO/WOR These issues seem now to be fixed. [01:50:36] 3VisualEditor / 3Editing Tools: VisualEditor:Pawn (♙) appears in Media Settings when there is another media added in the caption - 10https://bugzilla.wikimedia.org/57722#c2 (10James Forrester) 5NEW>3RESO/FIX This appears to be long-fixed. [01:51:51] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn appears near copy/pasted template - 10https://bugzilla.wikimedia.org/57358#c2 (10James Forrester) 5UNCO>3RESO/FIX This appears to be long-fixed. [01:54:52] 3VisualEditor / 3ContentEditable: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992#c5 (10James Forrester) *** Bug 68124 has been marked as a duplicate of this bug. *** [01:54:52] 3VisualEditor: VisualEditor: Select text, type = garbled, repeated text + snowman on el.wp - 10https://bugzilla.wikimedia.org/68124#c3 (10James Forrester) 5NEW>3RESO/DUP I think the Πηγή template is the issue here; down-page of the template everything breaks, up-page it works. That means it's almost certai... [01:56:08] (03PS1) 10Alex Monk: Fix pulling of annotations when inserting new character at start of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150120 (https://bugzilla.wikimedia.org/68597) [01:56:40] 3VisualEditor / 3Editing Tools: VisualEditor: Add non-breaking space to the "special character" dialog - 10https://bugzilla.wikimedia.org/68429#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal Adding 68425 or users will have no idea what it is. [01:56:40] 3VisualEditor / 3Editing Tools: Tooltips for Insert -> Special Character - 10https://bugzilla.wikimedia.org/68425 (10James Forrester) [01:57:28] (03CR) 10jenkins-bot: [V: 04-1] Fix pulling of annotations when inserting new character at start of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150120 (https://bugzilla.wikimedia.org/68597) (owner: 10Alex Monk) [01:57:37] 3VisualEditor / 3Editing Tools: VisualEditor: Provide tooltips for each item in the Special Character inserter so users can tell items from each other - 10https://bugzilla.wikimedia.org/68425 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal [01:58:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Web Thunder Helper Plugin (download) leaves garbage in pages - 10https://bugzilla.wikimedia.org/63121 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [01:59:10] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn ♙ appears after deleting the text preceding and following a link by "undo" action - 10https://bugzilla.wikimedia.org/61521#c2 (10James Forrester) 5NEW>3RESO/FIX I think this is now fixed. [02:01:24] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring around a node leads to pawning inserting the cursor before (not after) the text in Firefox - 10https://bugzilla.wikimedia.org/54917#c7 (10James Forrester) 5ASSI>3RESO/FIX Now fixed again, hopefully for good. [02:02:09] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn appears near deleted reference in Firefox - 10https://bugzilla.wikimedia.org/54976#c3 (10James Forrester) 5ASSI>3RESO/FIX This too is fixed now. [02:02:38] 3VisualEditor / 3ContentEditable: VisualEditor: CTRL+Z occasionally inserts a pawn - 10https://bugzilla.wikimedia.org/51532#c3 (10James Forrester) 5ASSI>3RESO/FIX I believe these issues are now fixed. [02:09:39] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [02:10:06] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) p:5Unprio>3Normal [02:14:10] 3OOjs UI: OOjs UI: Windows have no visual loading state - 10https://bugzilla.wikimedia.org/68669 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [02:17:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: The link text is not appearing in the link target field inside the link inspector for Android - 10https://bugzilla.wikimedia.org/68585 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:20:54] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Remove button for the link inspector in mobile is not styled as Red - 10https://bugzilla.wikimedia.org/68194 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Trevor Parscal [02:21:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text cannot be pasted into link inspector search field from mobile browser - 10https://bugzilla.wikimedia.org/68018 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:21:52] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor moving handle (?) doesn't appear in Android - 10https://bugzilla.wikimedia.org/66783 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [02:22:53] 3VisualEditor / 3Mobile: VisualEditor Mobile: There's no way to apply heading/etc. paragraph formatting - 10https://bugzilla.wikimedia.org/66782#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc Yeah, this was intentionally left out of the MVP. [02:23:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link duplicates the preceding link text in Nexus 7 (Android 4.4.2) - 10https://bugzilla.wikimedia.org/66754 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3major [02:25:38] 3VisualEditor / 3Editing Tools: VisualEditor: Reconsider the "insert" menu because it doesn't - 10https://bugzilla.wikimedia.org/68494 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc [02:28:09] 3VisualEditor / 3ContentEditable: VisualEditor: Inserting Whitespaces at the end of a preformatted text takes the cursor out of the pre tags. - 10https://bugzilla.wikimedia.org/68455 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal [02:31:22] 3VisualEditor / 3ContentEditable: VisualEditor: Increase indentation is not working when the list is wrapped around a left aligned image - 10https://bugzilla.wikimedia.org/68540 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low [02:32:23] 3OOjs UI: OOjs UI: Auto-shortening of dialog titles when there's insufficient space isn't working - 10https://bugzilla.wikimedia.org/68571 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High a:3Trevor Parscal [02:33:23] 3VisualEditor / 3ContentEditable: VisualEditor: ☃ symbol replicates when creating an article with a template - 10https://bugzilla.wikimedia.org/68147#c2 (10James Forrester) *** Bug 68148 has been marked as a duplicate of this bug. *** [02:33:23] 3VisualEditor: Letters start to replecate when writing a new article [HEBREW WIKIPEDIA] - 10https://bugzilla.wikimedia.org/68148#c1 (10James Forrester) 5UNCO>3RESO/DUP Pretty sure this is the same as bug 68147. *** This bug has been marked as a duplicate of bug 68147 *** [02:34:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Incompatibility with Special:Preferences#mw-prefsection-editing item, "Edit pages on double click (requires JavaScript)" - 10https://bugzilla.wikimedia.org/53058 (10James Forrester) a:3Alex Monk [02:45:19] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=68589 [02:52:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c1 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Alex Monk There's a hook or something to call to get these to re-activate; it's al... [06:35:11] 3VisualEditor / 3ContentEditable: Reference template may cause loop of text insertion - 10https://bugzilla.wikimedia.org/68789 (10Eran Roz) 3NEW p:3Unprio s:3normal a:3None There is a loop of content replace when text is edited in a paragraph containig reference template. Test case: 1. Get to Ronal... [08:14:00] (03CR) 10Esanders: [C: 04-1] "Can has unit test?" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [08:50:56] 3MediaWiki extensions / 3TemplateData: enable template data editor dutch wikipedia - 10https://bugzilla.wikimedia.org/68795 (10Ad Huikeshoven) 3NEW p:3Unprio s:3normal a:3None Please enable Template Data Editor on Dutch Wikipedia, nl.wikipedia.org. Thank you, [10:32:16] (03PS6) 10Esanders: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [10:33:09] (03CR) 10Esanders: [C: 032] Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [10:34:29] (03Merged) 10jenkins-bot: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149920 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [11:14:51] (03PS1) 10Esanders: Comment icon positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150182 [11:27:19] (03PS2) 10Esanders: [BREAKING CHANGE] Fix ve.ui.Overlay classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149635 (https://bugzilla.wikimedia.org/68486) [11:27:51] (03PS1) 10Esanders: Rename overlay class rules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150188 [11:28:41] (03CR) 10Esanders: "MW fixed in Ia90b6afb" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149635 (https://bugzilla.wikimedia.org/68486) (owner: 10Esanders) [12:01:02] (03PS1) 10Esanders: Remove unused CSS classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/150192 [12:02:03] (03PS1) 10Esanders: Remove direction style attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/150193 [12:08:11] (03PS1) 10Esanders: Remove 'remove' button from comment inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 [12:33:26] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Language of images should be in subcategory of VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149854 (owner: 10Vikassy) [12:35:06] (03Merged) 10jenkins-bot: [BrowserTest] Language of images should be in subcategory of VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149854 (owner: 10Vikassy) [12:35:20] (03PS2) 10Zfilipin: [BrowserTest] Client logins only once to upload all screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148373 (owner: 10Vikassy) [12:35:27] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Client logins only once to upload all screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148373 (owner: 10Vikassy) [12:37:06] (03Merged) 10jenkins-bot: [BrowserTest] Client logins only once to upload all screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/148373 (owner: 10Vikassy) [12:43:02] hmm, i can't seem to copy and paste citation to make multiple links to the same footnote any more [12:49:17] (03Abandoned) 10Zfilipin: [WIP] [BrowserTest] Testing typing in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/83966 (https://bugzilla.wikimedia.org/54393) (owner: 10Amire80) [14:31:18] (03PS2) 10Esanders: Use getDescription for title attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 [14:31:25] (03PS2) 10Esanders: Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 [14:32:47] (03CR) 10jenkins-bot: [V: 04-1] Use getDescription for title attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders) [14:33:08] (03CR) 10jenkins-bot: [V: 04-1] Remove redundant setting of title in link nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149524 (owner: 10Esanders) [14:44:17] Heya. [14:44:19] edsanders: Can I get you to merge a couple of pull-throughs? [14:44:23] Bah. Or not. [14:51:07] (03PS1) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150222 (https://bugzilla.wikimedia.org/67992) [14:51:10] (03CR) 10jenkins-bot: [V: 04-1] Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150222 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [14:51:19] (03Abandoned) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150222 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [14:58:38] (03PS1) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) [14:58:41] (03CR) 10jenkins-bot: [V: 04-1] Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [14:59:13] (03Abandoned) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [15:01:31] (03Restored) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [15:02:49] (03Abandoned) 10Jforrester: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [15:03:28] (03PS1) 10Jforrester: Update VE core submodule to master (2fc7855) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150225 [15:05:30] (03CR) 10Jforrester: "Adding remove buttons to dialogs for node is a request we've had a few times…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders) [15:28:04] James_F, edsanders I just noticed something in the comment fix, but it's not directly related to the fix itself (it does to removal in general) - should I put the review in there or just raise it here? [15:28:27] go on... [15:28:29] mooeypoo: Raise here maybe? [15:29:32] ok, so we seem to have inconsistent behavior with empty comments. That is, the setup process trims comment, and the teardown process checks if a comment is empty and removes it. So, (for whatever reason) will be automatically deleted upon inspection [15:30:10] which can be fine (though might produce dirty diffs) but if that's what we want, then we should also make sure we trim the "newValue" in the teardown, so if the user has nothing but spaces in the edit box it's still considered empty [15:30:16] Which it isn't at the moment [15:31:09] 3VisualEditor / 3Editing Tools: VisualEditor:Caption pane Toolbar is accessible when Alternative text is clicked in Media Settings dialog . - 10https://bugzilla.wikimedia.org/68806 (10Ritu Swain) 3UNCO p:3Unprio s:3minor a:3None Created attachment 16087 --> https://bugzilla.wikimedia.org/attachment... [15:31:27] James_F, edsanders so we need to decide if we want to delete empty comments (maybe we should?) and if so, just trim at the end where we check to see if it's empty, or if we don't, we need to not trim to begin with? [15:32:23] mooeypoo: That sounds reasonable. [15:32:37] mooeypoo: (Trimming newValue on edit and deciding to remove instead.) [15:32:38] so our usual handling of whitespace is this: [15:32:51] 1. compute pre and post whitespace and store and trim [15:32:58] 2. re-apply on save [15:33:08] we do this in the mw extension inspector [15:33:46] there we also remove the node if empty [15:33:56] (for types which don't allow empty contents) [15:34:22] edsanders, that doesn't seem to work, though? I have in my source. It appears as a comment, so I inspect it -- the inspector shows me an empty editor (no spaces) and when I exit without doing anything, it removes the comment completely. [15:34:51] And that logic is in the inspector itself now " if ( newValue === '' ) {" on line #142 in the inspector [15:35:30] We just need to decide if we want to trim "newValue" or if we don't want to trim the value in advance at all, I think? [15:37:58] (03CR) 10Esanders: "Personally I think that's inconsistent with other editors. Either way we should be internally consistent. We will need to have a clickable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150194 (owner: 10Esanders) [15:38:55] mooeypoo, yes that code doesn't exist yet [15:39:13] edsanders, it's only adding .trim() at the end of 'newValue' isn't it? [15:39:26] or the other way around [15:39:45] not quite [15:39:53] the value in the textarea should always be trimmed [15:40:12] and etc --> all those get deleted upon inspection. that should probably not happen? [15:40:15] we store the initiali whitespace separately [15:40:22] yes [15:41:07] edsanders: I think mooeypoo means if the comment starts off as and the user changes "Foo" to " " it should spot the issue, regardless of the stored whitespace. [15:41:21] right [15:41:55] If a user deleted a comment, then sure. But if there already was one there with only spaces, we should beware of deleting it. Thogh that too creates a bit of an issue -- if we allow the user to see empty comments, should we allow the usre to add one? [15:42:02] we should probably discourage it [15:42:26] so the alternative to deleting is disabling the done button [15:42:31] Eww. [15:42:41] but clicking away effectively clicks done so that is confusing [15:42:53] edsanders, eh, would that work in inspectors -- you "apply" by simply leaving it and throwing focus somewhere else [15:42:53] Yeah. [15:42:59] yeah [15:43:51] Given we allow empty comments probably just don't auto delete for now [15:44:18] that's what would happen with an extension with allowEmpty = true [15:44:47] separately I should add a preserveOuterWhitespace mode to TextInputWidget [15:51:17] (03PS1) 10Bartosz Dziewoński: ve.ce.TextNode: Use getChar() helper [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150236 [15:51:19] (03PS1) 10Bartosz Dziewoński: ve.ce.TextNode: Simplify #getAnnotatedHtml logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150237 [15:51:38] 3VisualEditor / 3Editing Tools: VisualEditor:Language Inspector is not working in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68808 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16088 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16088&action=edit screensh... [15:52:06] 3VisualEditor / 3Editing Tools: VisualEditor:Language Inspector is not working in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68808#c1 (10Ritu Swain) Created attachment 16089 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16089&action=edit screenshot2 [15:52:21] 3VisualEditor / 3Editing Tools: VisualEditor:Language Inspector is not working in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68808 (10Ritu Swain) [15:52:49] James_F, do we have a plan for "preview of changes" ? that question came up on hewiki, which is interesting because VE itself is supposedly one big preview [15:52:52] 3VisualEditor / 3Editing Tools: VisualEditor:Caption pane Toolbar is accessible when Alternative text is clicked in Media Settings dialog . - 10https://bugzilla.wikimedia.org/68806 (10Ritu Swain) [16:09:07] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender [16:16:54] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not working in Media Settings dialog - 10https://bugzilla.wikimedia.org/68808#c2 (10James Forrester) 5UNCO>3ASSI a:3Ed Sanders Ed, is this fixed by gerrit 149635? [16:16:54] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not working in Media Settings dialog - 10https://bugzilla.wikimedia.org/68808 (10James Forrester) p:5Unprio>3Normal [16:19:07] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806#c1 (10Moriel Schottlender) This is a little more complicated than that, though. An image could absolutely have both a caption... [16:20:39] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16090 --> https://bugzilla.wikimedia.org/attach... [16:21:22] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809#c1 (10Ritu Swain) Created attachment 16091 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16091&action=edit screenshot2 [16:21:51] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809#c2 (10Ritu Swain) Created attachment 16092 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16092&action=edit screenshot3 [16:22:06] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809 (10Ritu Swain) [16:24:29] James_F, I'm confused. I think I misunderstood the other bug but this one looks exactly the same... ? or.. eh? do you understand what is going on between these two ? https://bugzilla.wikimedia.org/show_bug.cgi?id=68809 and https://bugzilla.wikimedia.org/show_bug.cgi?id=68806 [16:25:07] Is the new one just a better title for the old one (in which case, I misunderstood the first?) or are these two separate bugs? [16:25:13] hmm, is ve.ce.TextNode.whitespaceHtmlCharacters really not meant to be .static? [16:25:26] or private somehow? [16:30:33] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105796883 [16:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105796959 [16:30:34] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=105797061 [16:30:34] Corruption alert: visualeditor-needcheck on idwiki: https://id.wikipedia.org/?diff=8093693 [16:30:34] Corruption alert: visualeditor-needcheck on nlwiki: https://nl.wikipedia.org/?diff=41786241 [16:30:34] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13292061 [16:41:39] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16093 --> https://bugzilla.wikimedia.org/attachment.cg... [16:41:51] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810 (10Ritu Swain) [16:45:06] Norton Internet security, nice. [16:45:06] https://fr.wikipedia.org/?diff=105796883 [16:50:51] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c4 (10Ritu Swain) (In reply to Alex Monk from comment #3) > I can't reproduce this now, Roan couldn't either. Ritu, does this still > happen for y... [16:51:06] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=63229 [16:53:07] 3VisualEditor / 3Editing Tools: VisualEditor: Language Inspector is not working in Media Settings dialog - 10https://bugzilla.wikimedia.org/68808#c3 (10Ritu Swain) baehavior found in betalabs. [16:53:17] James_F: Might also be a VE or Parsoid bug hidden in there [16:53:23] note [16:53:41] Krinkle: It's still a browser bug. [16:53:55] Krinkle: CE surfaces shouldn't be futzable by browser plugins. Ever. [16:54:02] unless that was pasted as plain text from a view source (which the user probably didn't do) pasting that should not result in it going into wikitext when converted to html [16:54:18] James_F: I don't think the browser plugin added an tag inside CE. [16:54:27] The user copied/pasted it from another page from outside the surface. [16:54:35] Krinkle: We block tags on paste. [16:54:46] Krinkle: The only way it could get there is with the browser writing it in. [16:55:17] I don't see how Norton could put it in there since the surface isn't there on domready, it would have to do it X amount of time later and then also of all elements, it ends up putting it in the surface. Possible but unlikely. [16:55:36] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809#c3 (10Ritu Swain) same issue found in betalabs. [16:55:45] Yeah, but it's worth checking that we do indeed properly , and there's still a bug on our end for turning stuff from Parsoid into wikitext. [16:55:52] properly block* [16:57:05] Unless it's also inserting [16:57:26] Norton probably assumes that is always in so it can break it with abandon. [16:57:53] 3VisualEditor / 3Editing Tools: VisualEditor:Link Inspector icon is not appearing, when language is selected, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68810#c1 (10Ritu Swain) same issue found in betalabs [16:57:58] You're saying Norton is somehow fetching Parsoid HTML from somewhere, gets the tag for the mw revision and injects it into the surface? [16:59:13] Potentially. [17:00:48] (03PS4) 10Krinkle: MWMediaSearchWidget: Use json/jsonp for local/remote api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:01:02] (03CR) 10Krinkle: "Restored note about cache:true because it doesn't actually make it cacheable." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:01:08] (03PS5) 10Krinkle: MWMediaSearchWidget: Use json/jsonp for local/foreign api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:01:32] (03CR) 10Krinkle: [C: 032] "Use "foreign" instead of "remove" since foreign wikis can be on the same origin, but we still want to use jsonp for security and consisten" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:01:40] (03CR) 10Krinkle: [C: 031] MWMediaSearchWidget: Use json/jsonp for local/foreign api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [17:08:29] Hello! I'm trying to figure out how to use VisualEditor with LanguageTag. It looks like the , tags are not preserved by Visual Editor. Is there a way to configure them as valid? [17:10:22] 3VisualEditor / 3ContentEditable: VisualEditor: Pawn gets added beside the comment, when inserting a whitespace after it. - 10https://bugzilla.wikimedia.org/68539#c5 (10James Forrester) 5ASSI>3RESO/FIX Sounds like it was fixed in wmf15 then. [17:17:34] (03CR) 10Krinkle: [C: 032] Remove unused CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149856 (owner: 10Esanders) [17:18:53] (03Merged) 10jenkins-bot: Remove unused CSS classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149856 (owner: 10Esanders) [17:19:48] RoanKattouw_away, I have the absolute awesomest bug for you. https://bugzilla.wikimedia.org/show_bug.cgi?id=68789 <-- just.. follow the reproduction instructions. [17:19:53] hangouts is so awkward :P [17:20:36] Is it hangouts that's awkward, or us? [17:20:37] :D [17:21:02] I think it was just me, actually :) [17:21:23] you were great, the audio was just choppy [17:21:48] yeah I'm supposed to do a hangouts demo thing for WMF on thursday and I'm not really sure what to do [17:21:48] Krinkle, I'm a little confused about your +1 that you said i should fix -- you fixed the commit message, wasn't that what you meant? I'm confused [17:21:53] 3MediaWiki extensions / 3TemplateData: Enable the TemplateData GUI editor on Dutch Wikipedia - 10https://bugzilla.wikimedia.org/68795 (10James Forrester) p:5Unprio>3Normal s:5normal>3enhanc a:3James Forrester [17:21:54] besides signing up for fibre. [17:22:04] I think my connection is just crap. [17:22:06] mvolz, :\ [17:22:37] Sometimes my phone has better connection on hangouts than my computer, which is a bit weird. [17:23:05] mvolz: Yeah. :-( Do you have somewhere with better Internet connection from where you can connect? [17:23:38] not really :/ [17:23:57] (03PS1) 10Krinkle: ve.ce.ResizableNode: Simplify for loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 [17:24:14] (03PS2) 10Krinkle: ve.ce.ResizableNode: Simplify for loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 [17:24:58] mvolz: Hmm. :-( Maybe you could pre-record the demo? [17:25:21] mvolz: 'Cos yeah, it wasn't good enough. [17:25:29] (03PS3) 10Krinkle: ve.ce.ResizableNode: Optimise find() query by running 1x, not 4x [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 [17:26:11] (03PS4) 10Krinkle: ve.ce.ResizableNode: Run find() once instead of 4x in showHandles() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 [17:26:52] (03PS5) 10Krinkle: ve.ce.ResizableNode: Run find() once instead of 4x in showHandles() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 [17:27:09] Krinkle: Indecisive? :-0 [17:27:40] James_F: :( [17:28:15] Actually testing a way to send a squashed branch into gerrit [17:28:20] (showing the original steps sort of) [17:28:23] mvolz: Maybe you could do audio-only with a "local" video demonstration? [17:28:28] Krinkle: Interesting. [17:28:51] I had it last night but forgot about. Figured I'd try it before I forget. [17:32:33] moo|food: I think you've mis-understood bug 68806. [17:32:50] moo|food: It's saying that when the cursor focus isn't in the caption (but instead in the alt text), the toolbar should be disabled. [17:32:53] 3VisualEditor / 3Editing Tools: VisualEditor: Caption pane toolbar is accessible when cursor is in Alternative text, in Media Settings dialog. - 10https://bugzilla.wikimedia.org/68809#c4 (10James Forrester) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 68806 *** [17:32:53] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806#c2 (10James Forrester) *** Bug 68809 has been marked as a duplicate of this bug. *** [17:33:01] moo|food: It's not saying the caption box itself should be disabled… [17:37:51] (03PS1) 10Krinkle: Use native style property names instead of jQuery's css map [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150266 [17:43:55] Yikes, we're hitting almost 1,000 open bug reports on VE-* [17:44:06] Krinkle: … yes? [17:44:09] Maybe I should start using search instead of scannig through them whenl looking for one [17:44:27] Krinkle: We used to be 1100+; it's stabilised at ~ 950–1000 of late. [17:44:45] Krinkle: Or maybe you should ask me for bugs? :-) [17:45:02] Do we have a bug for the search result in template insertion (and link editor presumably) being oddly ordered (upstream bug in cirrus), e.g. on mw.org inserting a template and typing See also renders: See also/de, See also/ja, See also, See also/doc. that third one should obviously be the first. [17:45:27] Krinkle: Yes. [17:50:28] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2fc7855) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150225 (owner: 10Jforrester) [17:51:06] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584#c4 (10Rummana Yasmeen) It seems, it got resolved! Did anyone work on this one? [17:51:52] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf16] Cannot open any page with Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/68584#c5 (10James Forrester) 5ASSI>3RESO/FIX This could be the HHVM issue… [17:52:13] (03Merged) 10jenkins-bot: Update VE core submodule to master (2fc7855) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150225 (owner: 10Jforrester) [17:52:38] [10:48] MatmaRex [2014-07-29 09:23:18] hmm, is ve.ce.TextNode.whitespaceHtmlCharacters really not meant to be .static? [17:52:55] MatmaRex: It predates the introduction of .static by months, maybe a year [17:53:09] So it should be .static , it's just that no one's cleaned it up yet [17:53:40] moo|food: Is https://bugzilla.wikimedia.org/show_bug.cgi?id=68789 reproducible in master / beta labs? I suspect it may be related to the snowman fix [17:56:23] 3VisualEditor / 3ContentEditable: VisualEditor:Categories when added are shown as return character in VE. - 10https://bugzilla.wikimedia.org/68811 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16094 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16094&action=edit screens... [17:56:36] 3VisualEditor / 3ContentEditable: VisualEditor:Categories when added are shown as return character in VE. - 10https://bugzilla.wikimedia.org/68811#c1 (10Ritu Swain) Created attachment 16095 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16095&action=edit screenshot2 [17:57:06] 3VisualEditor / 3ContentEditable: VisualEditor:Categories when added are shown as return character in VE. - 10https://bugzilla.wikimedia.org/68811#c2 (10Ritu Swain) Created attachment 16096 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16096&action=edit screenshot3 [17:57:52] 3VisualEditor / 3ContentEditable: VisualEditor:Categories when added are shown as return character in VE. - 10https://bugzilla.wikimedia.org/68811 (10Ritu Swain) [17:59:09] RoanKattouw, I'm checking now, but I was having fun watching it, I admit [17:59:13] (03PS1) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150274 (https://bugzilla.wikimedia.org/67992) [17:59:39] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806#c3 (10Moriel Schottlender) Okay, I seem to have misunderstood the bug, sorry about that; I thought you were talking about the... [18:01:36] (03PS1) 10Esanders: Create a WhitespaceTextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 [18:02:18] (03CR) 10jenkins-bot: [V: 04-1] Create a WhitespaceTextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [18:02:44] super general question that I don't need the answer to just yet, but how should I push co-dependant changes both in VE and TD? Instinct is TD first, but you really need the VE stuff to adequately test it.... [18:02:54] all at once? [18:03:11] (03PS2) 10Esanders: Create a WhitespaceTextInputWidget and use in CommentInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 [18:03:36] 3VisualEditor / 3Editing Tools: 'Insert Media' in VE fails to search local repo, returns blank. - 10https://bugzilla.wikimedia.org/63989#c4 (10James Forrester) 5UNCO>3RESO/INV (In reply to Patrick King from comment #0) > Running an up-to-date VisualEditor extension and parsoid server on > mediawiki-1.22.... [18:03:36] RoanKattouw, it's really hard to test if this happens in master, I'm trying to import all the relevant templates (aaaaa) [18:04:02] mvolz: So in principle the TD change stands on its own and it's "really" dependent on the VE change, you just need the VE change to test it adequately? And the VE change does actually depend on the TD change? [18:04:46] edsanders: Re whitespace-only comments: maybe we should meta-fy them just like truly empty comments? [18:05:19] RoanKattouw, makes sense [18:05:44] yes [18:05:50] mvolz, usually I mark both changes as codependent in the commit message "Depends on [changeid]" if it's a dependency that goes one- or two- ways. [18:06:06] The typical thing is ... yeah what mooeypoo said [18:06:27] but usually they can "live" independently.. as in, usually even if you merge one before the other they're not breaking changes to either repository [18:06:32] Say "Depends on Ia13df5b" (first ~8 chars of the change ID are enough) in the commit summary [18:06:37] Ok :) [18:06:44] if it is a breaking change, you should mark it as such too, so we know to merge one before the other [18:07:04] oh, I didn't know only 8 chars are enough, I keep copy/pasting the entire ID [18:07:14] Well, maybe not 8, but a low number [18:07:19] Sufficiently low as to be unique [18:07:27] * mooeypoo nods [18:07:34] it links them automatically when they're partial, too ? [18:07:42] The first char is always I, so there are 16^7 = 2^28 change IDs with 8 chars [18:07:46] Yeah I believe it does [18:07:47] (03PS3) 10Esanders: Use getDescription for title attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 [18:07:51] This is definitely how it works for git hashes [18:08:08] git automatically truncates them to 7 chars in display, except if that's ambiguous within the repo, then it outputs 8 chras [18:08:30] I've seen a handful of 8-char hashes, one time we had two in the same week's commit listing [18:08:39] Which is *weird*, because the odds of a collision are so low [18:09:06] Krinkle, I don't understand what yo uwant me to fix in https://gerrit.wikimedia.org/r/#/c/150054/5 ? Just the commit message ? (Didn't you just fix that?) I'm a little confused about you said stops the +2 [18:09:40] mvolz: If you're doing VE-TD interaction stuff, hopefully neither change is a truly breaking change? Like, TD continues to work if queried by an old VE, and VE should deal gracefully with an old TD version, or for templates which don't yet use the new feature you added? [18:10:32] mooeypoo: I changed the commit, if you +1 my change, I'll +2 [18:11:02] I already changed remote to foreign and restored the cache:true comment. [18:11:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders) [18:11:57] ohh just +1, gotcha. I was confused. [18:12:18] hallo mooeypoo James_F TrevorParscal [18:12:24] I just had a crazy idea [18:12:27] Hey aharoni [18:12:31] heya aharoni [18:12:42] to use a bit of oojs-ui for ContentTranslation. [18:13:29] That sounds like an entirely reasonable idea :) [18:13:34] (03CR) 10Mooeypoo: [C: 031] "Foreign works" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) (owner: 10Mooeypoo) [18:14:06] for a start, I need to add icons to a few buttons [18:14:41] You can do that with the oojs-ui classes [18:14:48] maybe it's worth also styling them with the full oojs-ui, but initially I'd probably want just the icons [18:14:57] here's the design: https://commons.wikimedia.org/w/index.php?title=File:Content-translation-designs.pdf&page=7 [18:14:58] or you can use oojs/oojs-ui for the entire ui [18:15:00] What builds these buttons right now? [18:15:59] if you go to http://es.wikipedia.beta.wmflabs.org/w/index.php?title=Special:ContentTranslation&page=Atlit&from=es&to=ca&targettitle= [18:16:11] (you need to log in) [18:16:36] Yes [18:16:44] and if you click an empty paragraph in the middle column, and then click again on it to focus, you'll see a box in the sidebar [18:16:48] currently it has no icons [18:17:34] Oh you're talking about "Usar texto de origen" and "Borrar traducción"? [18:17:38] Yes, [18:17:47] and if you type some text in the translation column, you'll also see a restore button [18:17:58] so let's say that I want to add an Undo icon to the restore button [18:18:11] Right [18:18:15] So, right now these buttons are just divs [18:18:20] You could replace them with OO.ui.ButtonWidgets [18:18:21] RoanKattouw, I can't test that bug you saw in master since I seem to be having insane problems with he/en in MW import itself... the template that's probably the culprit doesn't show up in view mode and shows up completely broken in VE even though I imported the entire article from hewiki includin templates. So odd. :\ but I can't say if the bug is still there [18:18:21] is it as simple as adding an oo-ui-icon-undo class? [18:18:37] Then configure the button with { frameless: true, icon: 'undo' } [18:19:45] It's a little bit more than just adding the class, I think, but OO.ui.IconedElement handles that, and ButtonWidget uses that [18:19:58] mmmmmm [18:20:23] does this mean that I should start being dependent on ooui modules? [18:20:29] Well, yes [18:20:29] is there a guide somewhere? [18:20:30] You'll get a lot more functionality if you use the full module [18:20:47] Unfortunately we don't have good documentation right now, but we're happy to help [18:20:47] tempting, to be honest :) [18:20:53] aharoni, I can help you out if you want [18:21:03] we are supposed to unify the UI and all that anyway, aren't we? :) [18:21:30] and I can assume that all of this will be available in the core, right? [18:21:47] Yes, the oojs-ui module is available in core [18:22:21] Let me write some quick JS that replaces your undo button with an oojs-ui undo button if you run it from the console [18:22:23] i'm going to be working on documentation as part of the ui standardization stuff I'm doing [18:22:43] but, it's not going to be done for a while [18:22:44] :( [18:22:51] There's a bit of documentation but more about oojs and less oojs-ui [18:22:59] * aharoni is attempting to read https://www.mediawiki.org/wiki/OOjs_UI [18:23:23] even that documentation it's mostly oojs stuff [18:23:52] oh, it also has a whole bunch of event handling stuff [18:24:06] aharoni: In CX, when the undo button is visible, run this code in the console: [18:24:08] mw.loader.using('oojs-ui', function() { var $old = $('.cx-restore-translation'), button = new OO.ui.ButtonWidget( { framed: false, icon: 'undo', label: 'Restaurar' } ); $old.replaceWith(button.$element); } ); [18:24:11] event emitter, factories, etc. But it has button stuff [18:24:22] aharoni, look further down, there are button stuff in that page [18:24:33] https://www.mediawiki.org/wiki/OOjs_UI#Simple:_creating_a_button [18:24:58] will I have to adapt the event stuff immediately, or can I use only the icons for now? [18:25:05] mooeypoo: Holy crap who wrote all that documentation? S? [18:25:30] aharoni: You don't have to. You only need to use events to know when the button is clicked, and that's as easy as button.on( 'click', function() { do stuff when clicked } ); [18:25:39] Which honestly isn't very different from what you already have to do anyway [18:26:00] OOjs UI is very event-driven internally, but the things it exposes an event interface to the outside for are mostly things you're already used to using events for anyway [18:26:01] ok, trying that [18:26:13] RoanKattouw, the event in the button widget is already there, you just need to attach a listener [18:26:19] Yeah exactly [18:27:10] aharoni: The main advantage of the event-based stuff we use is that for things like text input boxes, you don't have to do $input.on( 'keydown keyup input change etc etc etc', function() { ... } ); , instead we abstract that away for you and you can just do textbox = new OO.ui.TextInputWidget( ... ); textbox.on( 'change', ... ) [18:27:41] textbox.connect(), no? [18:27:46] on is jquery's [18:27:46] ? [18:27:50] mooeypoo: If you have a class method, yes [18:28:05] if you do textbox = new OO.ui.TextInputWidget then it should be textbox.connect [18:28:06] that's something that I'll have to discuss with Santhosh and David... in ContentTranslation we did most of that with mw.hook [18:28:14] or textbox.$element.on() ... right? [18:28:15] I think [18:28:23] mooeypoo: Widgets support both .on() and .connect() [18:28:28] .connect() is just .on() with sugar [18:28:41] aharoni: What do you do with mw.hook? [18:28:56] oh they do? I thought that connect() is there because that's not quite an element, it's a class containing the element within it. [18:29:05] You can continue using mw.hook() if you're using it for things it's actually designed for; VE does that too [18:29:07] But that makes sense. [18:29:36] mooeypoo: We generally use .connect() because it's easier, but jQuery doesn't have it so for those we slum it and use .on() [18:29:44] But you'll see the occasional handler bound to a widget using .on() [18:29:47] yeah, probably [18:29:56] * mooeypoo nods [18:30:07] I thought it just worked on jQuery objects. [18:30:09] well, these buttons are done with .on( 'click' [18:30:25] aharoni: BTW let me tell you what .connect() actually is: anything in OOjs UI supports .on()/.off() which is jQuery-style event stuff, but it also supports .connect()/.disconnect() which is optimized for OOP [18:30:27] so we'll see, maybe we'll adopt that for events, too [18:30:52] 3VisualEditor / 3Technical Debt: VisualEditor: OpenSearch results aren't perfect for checking for page existence - 10https://bugzilla.wikimedia.org/51013#c4 (10Krinkle) Right now MediaWiki search has a bug where one searches "Foo" and a page by that name exists, it might not be included in the search results... [18:31:00] RoanKattouw, so I made https://gerrit.wikimedia.org/r/#/c/150120/ - it seemed to fix the issue, but broke a bunch of tests. [18:31:21] So you can do myTextbox.connect( this, { change: 'onTextChange', enter: 'onTextEnter' } ); and that binds to this.onTextChange() and this.onTextEnter() [18:32:05] (03Restored) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [18:32:15] (03PS2) 10Catrope: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [18:33:50] aharoni: In any case, you don't need to adopt our event emission stuff for all of your code (although it's there if you want it), you only really need it for interacting with our code [18:33:58] And simple interactions are API-compatible with jQuery [18:34:08] 3VisualEditor / 3Technical Debt: VisualEditor: Don't use OpenSearch for checking page existence - 10https://bugzilla.wikimedia.org/51013#c5 (10Krinkle) Action item: When using search in a way that the user input should be used as first hit if it exists[1], our code should always do an additional query for th... [18:35:03] (03CR) 10Jforrester: [C: 032] Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150274 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [18:35:12] (03CR) 10Jforrester: [C: 032] Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [18:36:23] (03Merged) 10jenkins-bot: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150274 (https://bugzilla.wikimedia.org/67992) (owner: 10Catrope) [18:36:38] (03Merged) 10jenkins-bot: Generate only one pair of snowmen for multi-sibling nodes [VisualEditor/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150224 (https://bugzilla.wikimedia.org/67992) (owner: 10Jforrester) [18:37:12] RoanKattouw: we need to add connect/disconnect to jQuery [18:37:19] Yeah we need to write $.fn.connect/disconnect [18:38:03] TrevorParscal: So I know this person that claims he's gonna do a lot of OOUI revamping... ;) [18:38:14] lol [18:38:17] yeah [18:38:43] Krinkle: what do you think a jQuery plugin that adds connect/disconnect? [18:38:50] I'm thinking of adding it to ooui [18:39:01] API compatible with EventEmitter [18:39:13] TrevorParscal: You mean OOjs? [18:39:25] jquery.OOjs-connecter [18:39:25] James_F: OOjs does not depend on or interact with jQuery [18:39:35] False. [18:39:44] There's OOjs and OOjs-jQuery. [18:39:44] there's a jquery distribution [18:39:46] Yeah. [18:39:48] we could put it in there [18:39:48] Yeah fair [18:40:00] We could ship it as a separate plugin thingy and bundle it with that, or something [18:40:00] seems like that would be a good place [18:40:42] * James_F nods. [18:40:50] i need to work on WM stuff [18:40:51] OOjs welcomes your patches. :-) [18:40:54] That too. [18:41:01] (03CR) 10Catrope: [C: 04-1] Create a WhitespaceTextInputWidget and use in CommentInspector (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [18:41:02] TrevorParscal: You've got the plane ride for that! ;-) [18:41:08] 3VisualEditor / 3ContentEditable: Reference template may cause loop of text insertion - 10https://bugzilla.wikimedia.org/68789#c1 (10James Forrester) 5NEW>3RESO/DUP It looks to me like this is the same as bug 68733 (the templates cause breakage down-page), which is happily just being fixed. *** This bug... [18:41:08] 3VisualEditor / 3ContentEditable: VisualEditor: Character duplication in paragraphs following the {{lang-it}} template (and others?) - 10https://bugzilla.wikimedia.org/68733#c17 (10James Forrester) *** Bug 68789 has been marked as a duplicate of this bug. *** [18:41:15] design is saying I won't have everything I need and enough of their time to make much progress until after WM [18:41:24] so, i'm going to focus this week on review and WM prep [18:41:57] I'm supposed to give a talk about VE and OOJS/OOUI [18:42:06] Awesome! [18:42:10] whee [18:42:25] * RoanKattouw prepares to bury TrevorParscal in code review [18:42:27] Boo for slide-back on deadlines. :-( [18:42:36] James_F: Not Our Fault (TM) ;) [18:42:44] the latter talk will mostly just be making a case for why abstraction is nessecary, and how OOJS/OOUI provide that level of abstraction without dictating the architecture of your application (not an MVC, just the nuts and bolts to build one) [18:42:51] RoanKattouw: Still Our Problem™. [18:42:55] True [18:42:56] and how MVCs vary based on the problem you are solving.. that sort of thing [18:43:09] what is our focus for the VE talk? [18:43:13] progress report? [18:43:19] stories from the trenches? [18:43:22] There are two VE talks, aren't there? [18:43:27] teasing with new features? [18:43:31] James_F: ? [18:43:32] There's a product talk with you and James, and a tech talk with you and me [18:43:38] right [18:43:41] For the tech talk, I was thinking of focusing on the kinds of things that make VE hard [18:43:42] TrevorParscal: The product one is about progress to date and features to come (teaser). [18:43:45] TrevorParscal: The tech… yeah. [18:43:46] so I need to prep for 3 talks [18:43:53] Fun. [18:44:03] TrevorParscal: I was going to write our one, if you want. [18:44:09] James_F: are you already making progress on the one you and I are giving? [18:44:16] So, kind of stories from the trenches stuff, but probably some general stuff as well as some somewhat detailed stuff [18:44:21] yeah, maybe you could take a first shot at it James_F [18:44:33] TrevorParscal: Not done anything yet, though. [18:44:34] RoanKattouw: ok, are you giving any other talks? [18:44:38] the browser bugs one? [18:44:41] I don't think so? [18:44:45] I think they silently rejected that one? [18:45:01] I propose we shoehorn your browser bugs talk into the VE talk [18:45:11] because it's mostly things we found in the development of VE [18:45:18] Yeah or parts of it at least [18:45:29] we can tell the ones that are relevant [18:45:32] and I can add parts [18:45:44] so, you basically give half of the talk you gave already at OSB [18:45:54] Right [18:45:57] and I give the other half, in the same sort of way but with different issues [18:45:58] I'd like to talk about some bigger things though [18:46:07] (just a thought) [18:46:09] I mean, Chrome rendering stuff weird is entertaining, but it's not /really/ why VE is so much work [18:46:11] what do you want to focus on then? [18:47:23] Fights with contentEditable [18:47:27] (for copy/paste for instance) [18:47:32] Language support problems [18:48:03] "Wikitext lets you do this horrible thing, how the hell do we build a UI for this" problems [18:48:10] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.24wmf14 HEAD (8686c23) [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150291 [18:48:15] (images, templates, lots of other things) [18:48:34] ok [18:48:40] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.24wmf14 HEAD (8686c23) [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150291 (owner: 10Jforrester) [18:49:09] so, perhaps you could outline that and then bring me in on it? [18:49:16] I'm going to focus on my OOJS/OOUI talk [18:49:20] I mean that's what I was thinking of doing, I don't know what your thoughts were [18:49:30] I think you are on the right path [18:49:48] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.24wmf15 HEAD (87a9bfa) [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150292 [18:49:51] you are better at remembering all the horrors, I think I block them like repressed childhood memories [18:50:06] of being bullied by IE6 [18:50:06] haha [18:50:21] and being publicly humiliated by Firefox 2 [18:50:24] I have to do some research to find out what all the problems were again [18:50:26] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.24wmf14 HEAD (8686c23) [extensions/VisualEditor] (wmf/1.24wmf14) - 10https://gerrit.wikimedia.org/r/150291 (owner: 10Jforrester) [18:50:35] And some of this stuff is in Ed's brain [18:51:25] I have to come up with a persuasive way to explain why browsers are like small children, and while we love to watch them grow up and learn new tricks, you can't trust them [18:51:35] haha [18:51:46] I had a metaphor like that for my OSB talk [18:51:57] Browser vendors clean up their act the way children clean their room [18:52:01] nice [18:52:05] They stash all the crap under the bed or in the closet [18:52:09] yup [18:52:22] So you walk in and it all looks nice, but if you happen to open the closet door you are quickly buried in crap [18:54:11] love it [18:54:21] We probably need to tell the ES vs CE story [18:56:30] The abstract we submitted contains the phrase " We will illustrate a few of the various difficulties in building a rich editor on the Web, looking at other open and closed source editors’ attempts to solve these issues and the problems" [18:56:42] and the first thing I thought of was Google Docs-style ES stuff vs our CE approach [18:59:23] RoanKattouw: Please merge https://gerrit.wikimedia.org/r/#/c/150292/ for wmf15 so I can do the MW pull-through. [19:00:15] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf/1.24wmf15 HEAD (87a9bfa) [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150292 (owner: 10Jforrester) [19:00:17] hm. TrevorParscal you have a minute? I'm tring to figure out how focus in surfaces work to fix a bug. In media dialog, when your focus is out of the caption surface the toolbar is still enabled; I looked at reference dialog, and there it works well -- the toolbar for the surface is disabled when your focus is on the textbox. So, I assumed this is some event I should listen to, but I can't find anything explicit for this in the refer [19:00:17] ence dialog? What am I missing? [19:00:46] RoanKattouw: Thanks. :-) [19:01:22] TrevorParscal, isn't this supposed to be something automatic that the surface itself is doing? or rather, the toolbar? I was sure I saw something about it in the toolbar itself, but since the behavior is inconsistent between the two dialogs, I'm confused now. [19:01:23] mooeypoo: sure [19:01:29] Krenair: Re your relative offset change, talk to me about how it fixes the bug. In particular, it appears to me like it would only work at offset 1, while you could have documents like

| where the first content offset is 5 (or 9, if you nest another table) [19:01:56] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.24wmf15 HEAD (87a9bfa) [extensions/VisualEditor] (wmf/1.24wmf15) - 10https://gerrit.wikimedia.org/r/150292 (owner: 10Jforrester) [19:02:26] mooeypoo: I have a feeling the timing of running initialize is different in the reference case [19:02:27] like, it hapens later [19:02:38] RoanKattouw, so I think this code was forcing a positive direction if you started from offset 0, and that it should be fine at any other non-negative offset [19:02:40] the surface widget calls surface.initialize() internally [19:03:02] and if that's not called at the same time, there may be differences that may cause problems [19:03:17] useReference() is called and sets up the surface [19:03:40] but in media I think we either re-use the same surface between calls or at least initialize it earlier [19:03:56] aye, in media dialog, "resetCaption()" does it. But in both cases that's called from getSetupProcess [19:03:59] Krenair: OK [19:04:05] AFAICT the tests are mostly just asserting the old behavior [19:04:12] Yep. [19:04:22] Although, hmm [19:04:34] Some of them are returning -1 when quite probably they shouldn't [19:04:54] And the last failure is getRelativeContentOffset returning 0 which is very wrong [19:05:05] Oh actually past that, there's a /crash/ [19:05:14] So you broke something somewhere for sure [19:05:16] Not sure what yet [19:05:43] TrevorParscal, the surface caption in media dialog is rebuilt/re-initialized every time the dialog opens, and is destroyed on teardown. It *should* be the same as the reference. I'm missing something... ? [19:09:21] TrevorParscal: What would this plugin do? [19:09:23] 3VisualEditor / 3ContentEditable: VisualEditor: ☃ symbol replicates when creating an article with a template - 10https://bugzilla.wikimedia.org/68147#c14 (10James Forrester) 5PATC>3RESO/FIX Should be now fully fixed in master; deployment to production scheduled for 4 hours' time. [19:09:24] 3VisualEditor / 3ContentEditable: VisualEditor: Easy way to trigger a snowman and other corruption at fr.wp - 10https://bugzilla.wikimedia.org/67992#c17 (10James Forrester) 5PATC>3RESO/FIX Should be now fully fixed in master; deployment to production scheduled for 4 hours' time. [19:09:29] TrevorParscal: What does it abstract? [19:09:40] 3VisualEditor / 3ContentEditable: VisualEditor: Character duplication in paragraphs following the {{lang-it}} template (and others?) - 10https://bugzilla.wikimedia.org/68733#c18 (10James Forrester) 5PATC>3RESO/FIX Should be now fully fixed in master; deployment to production scheduled for 4 hours' time. [19:09:40] 3VisualEditor / 3ContentEditable: VisualEditor: Snowman character gets triggered, when trying to insert a template with Comment edit dialog open. - 10https://bugzilla.wikimedia.org/68740#c15 (10James Forrester) 5PATC>3RESO/FIX Should be now fully fixed in master; deployment to production scheduled for 4... [19:09:40] 3VisualEditor / 3ContentEditable: VisualEditor: When making text bold or italic following a template, pawn symbol appears - 10https://bugzilla.wikimedia.org/68151#c20 (10James Forrester) 5PATC>3RESO/FIX Should be now fully fixed in master; deployment to production scheduled for 4 hours' time. [19:10:10] Krinkle: How do I enable jenkins-bot on a new repo? [19:12:07] (03PS1) 10Palerdot: Fixed Bug 62761, added invalid link title style. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150297 (https://bugzilla.wikimedia.org/62761) [19:14:21] Krinkle: Think I've done it – https://gerrit.wikimedia.org/r/#/c/150298/ – trivial merge? [19:17:55] 3VisualEditor / 3Editing Tools: VisualEditor: The style of error message for invalid page title for link should be more apparent in style - 10https://bugzilla.wikimedia.org/62761#c2 (10palerdot) I have made a fix to this bug. The gerrit patchset link is https://gerrit.wikimedia.org/r/#/c/150297/ Things done... [19:19:01] James_F: step 2) zuul-config, 3) ensure Gerrit ACL allows group=JenkinsBot to merge [19:19:25] step 1b) actually re-compile jjb-config and send to API (the git is just a log) [19:19:30] I'm doing that now [19:19:32] (1b) [19:19:41] Krinkle: I can do the ACL. [19:19:52] 3VisualEditor / 3Editing Tools: VisualEditor: The style of error message for invalid page title for link should be more apparent in style - 10https://bugzilla.wikimedia.org/62761#c3 (10palerdot) Created attachment 16097 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16097&action=edit Screenshot of Fi... [19:22:50] Krinkle: Gah, apparently I can't; is the JenkinsBot user configured oddly? [19:22:54] 3VisualEditor / 3Editing Tools: VisualEditor: The style of error message for invalid page title for link should be more apparent in style - 10https://bugzilla.wikimedia.org/62761#c4 (10palerdot) Comment on attachment 16097 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16097 Screenshot of Fix for Bug... [19:23:09] James_F: Nope [19:23:25] James_F: But Gerrit only lets you autocomplete users you have full control over [19:23:30] e.g. write access, not just read. [19:23:34] Which is silly [19:23:43] Ah. Helpful. [19:23:49] Made the edit via git instead by checking out meta/config [19:23:50] So I need someone with gerrit admin rights to fix? [19:24:00] I have to do the same [19:24:05] That would work too [19:24:11] RoanKattouw? [19:24:59] If you decide to do it via get, beware that Gerrit exposes that branch very oddly. Requires this magic (can't use plain checkout or git-review) [19:25:00] https://github.com/Krinkle/dotfiles/blob/master/gitconfig#L19-21 [19:25:05] see the -co and -review commands [19:25:32] Looks like the dashboard push issue. [19:25:36] Very messy. [19:28:28] (03CR) 10Jforrester: Create a WhitespaceTextInputWidget and use in CommentInspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [19:32:17] James_F: Still need my help? [19:32:26] RoanKattouw: Yeah, if possible. [19:32:31] With? [19:33:03] RoanKattouw: Making https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CiteThisPage,access look like https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/TemplateData,access (or giving me access so I can do it for you). [19:33:07] ah! [19:33:10] gotcha, little bug. [19:33:24] RoanKattouw: Apparently I can't set JenkinsBot to have V+2 access because I don't have write access over JenkinsBot… [19:37:18] James_F: Done. Not entirely convinced the ACL is correct, but I made it the same as TD and that one seems to work fine [19:37:30] shoot. RoanKattouw help! I accidentally commited changes to master instead of my new branch... now what? :( [19:37:45] RoanKattouw: OK. Thanks! [19:38:06] RoanKattouw: FWIW, VisualEditor's looks wrong. [19:38:24] RoanKattouw, can I "uncommit" ? [19:38:43] mooeypoo: git branch name-of-branch-you-actually-want ; git reset --hard origin/master ; git checkout name-of-branch-you-actually-want [19:38:58] (Assuming the branch you are currently on is master) [19:39:59] phew [19:40:00] thanks! [19:40:05] aaaand [19:40:38] oh. gerrit bot is out. [19:40:43] meh [19:41:03] but it seemed to have worked https://gerrit.wikimedia.org/r/#/c/150304/ [19:41:04] i think [19:41:08] thanks :) [19:44:38] RoanKattouw: is there a list of usable button icons? [19:45:55] 3VisualEditor / 3Mobile: VisualEditor Mobile: The keyboard stays in the ReadMode after tapping on the Browser back button/ the cross button on the Mobile VE - 10https://bugzilla.wikimedia.org/65411#c2 (10James Forrester) a:5Jon>3None Is this still an issue? [19:46:02] aharoni: In OOUI, go to the demos directory and choose "icons". [19:46:05] Krinkle: it would just add connect/disconnect to jQuery, essentially it's like on/off but supports late binding of methods on an object instead of immediate binding of functions without context [19:46:39] aharoni: There are several OOjs UI demos that can help you explore things. You can't run them on the internet unfortunately, but you can clone the oojs/ui repo and run it locally [19:47:09] RoanKattouw: https://github.com/oojs/oojs-ui ? [19:47:18] aharoni: git clone ssh://gerrit.wikimedia.org:29418/oojs/ui.git ; cd ui ; grunt build then point your browser to file:///wherever/oojs/ui/demos/index.html [19:47:24] oh, in gerrit [19:47:30] It's a mirror so either works [19:47:42] Oh right and the github page has better instructions [19:47:51] :-) [19:48:11] It's more like git clone ... ; cd ui ; npm install -g grunt-cli; npm install ; grunt build [19:49:12] Krinkle: Do we really not have the demos on the internet yet? I guess rebuilding them every time the code changes is hard? [19:51:39] aharoni: use wikimedia/oojs-ui, not oojs/oojs-ui [19:51:47] oojs is currently a fork not up to date [19:51:50] oh [19:51:51] thnks [19:52:10] Krinkle: Can we fix that? [19:52:17] let me turn that into a redirect using the most horrible hack [19:52:22] Ha. [19:52:41] James_F, so. Now that this bug is fixed and my other things are in gerrit awaiting review, I am, truly, bugless. [19:52:42] * Krinkle deletes oojs/oojs-ui, transfers ownerssip of wikimedia/oojs-ui (gerrit mirror) to @oojs, then transfer back. [19:52:49] I require bug-sustenance. [19:52:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150018 (owner: 10Amire80) [19:53:09] (03PS1) 10Mooeypoo: Focus the caption surface on initialization [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150304 (https://bugzilla.wikimedia.org/68806) [19:53:34] mooeypoo: Two trivial ones: https://bugzilla.wikimedia.org/show_bug.cgi?id=67621 and https://bugzilla.wikimedia.org/show_bug.cgi?id=52219 to add tooltips. [19:53:37] Krinkle: were you talking about github or gerrit? [19:53:40] https://github.com/oojs/oojs-ui is now a redirect (both at http and at git level, so you can actually use it) [19:53:47] aharoni: github. [19:53:53] aharoni: On gerrit there is only one oojs-ui [19:53:57] mooeypoo: https://bugzilla.wikimedia.org/show_bug.cgi?id=68058 is possibly also trivial? [19:54:03] is github better in any way? [19:54:52] oh, James_F ah! i saw those. I'll fix the first one in TD, but the second is not trivial at all.. there's no real "insert a thumbnail" stuff with things so dependent on one-another in the dialog -- but we talked about having a sort of "preview" which, I think, might solve this? [19:55:01] I'll add the first one to TD [19:55:18] mooeypoo: Cool. :-) [19:55:24] aharoni: The github repo is just a mirror of the Gerrit repo [19:55:28] aharoni: No, just a… yeah. [19:55:35] how are you finding bugs that are already assigned to me... [19:55:49] It renders the setup instructions nicely but those just came from README.md or whatever [19:56:00] James_F, ... well. Lovely, me. It might help if I search bugzilla properly. pff. I ruined my saved searches. [19:56:10] mooeypoo: :-( [19:56:17] James_F, that explains why I thought I am bugless. [19:56:17] :D [19:56:19] mooeypoo: I'll help you fiddle in London… [19:56:33] aye. Just want to make sure I fix stuff [19:56:45] there's a whole week *AND* a flight 'till wikimania! [19:56:46] :D [19:58:00] (03CR) 10Catrope: [C: 04-1] "This is deliberately done in getReadyProcess() instead of on setup." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150304 (https://bugzilla.wikimedia.org/68806) (owner: 10Mooeypoo) [19:58:29] (03CR) 10Catrope: [C: 032] "...but focusing during mode switches is a good idea" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150304 (https://bugzilla.wikimedia.org/68806) (owner: 10Mooeypoo) [19:58:54] RoanKattouw: :-) [20:00:20] (03Merged) 10jenkins-bot: Focus the caption surface on initialization [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150304 (https://bugzilla.wikimedia.org/68806) (owner: 10Mooeypoo) [20:03:31] (03CR) 10Catrope: [C: 032] Use getDescription for title attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders) [20:04:18] (03CR) 10Catrope: [C: 032] ve.ce.TextNode: Use getChar() helper [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150236 (owner: 10Bartosz Dziewoński) [20:05:29] (03Merged) 10jenkins-bot: Use getDescription for title attribute [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149523 (owner: 10Esanders) [20:05:37] (03Merged) 10jenkins-bot: ve.ce.TextNode: Use getChar() helper [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150236 (owner: 10Bartosz Dziewoński) [20:06:14] (03CR) 10Catrope: [C: 032] "Thanks for cleaning up this mess" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150237 (owner: 10Bartosz Dziewoński) [20:07:13] (03CR) 10Catrope: [C: 032] ve.ce.ResizableNode: Run find() once instead of 4x in showHandles() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 (owner: 10Krinkle) [20:07:38] (03Merged) 10jenkins-bot: ve.ce.TextNode: Simplify #getAnnotatedHtml logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150237 (owner: 10Bartosz Dziewoński) [20:08:35] (03Merged) 10jenkins-bot: ve.ce.ResizableNode: Run find() once instead of 4x in showHandles() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150260 (owner: 10Krinkle) [20:09:07] (03CR) 10Catrope: [C: 032] Delay scrolling to a heading more on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150052 (owner: 10JGonera) [20:10:13] (03CR) 10Catrope: [C: 032] Remove direction style attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/150193 (owner: 10Esanders) [20:10:43] (03Merged) 10jenkins-bot: Delay scrolling to a heading more on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150052 (owner: 10JGonera) [20:10:47] TrevorParscal: Can I get CR for: https://gerrit.wikimedia.org/r/#/c/150182 https://gerrit.wikimedia.org/r/149924 https://gerrit.wikimedia.org/r/149635 https://gerrit.wikimedia.org/r/150192 [20:10:58] (03Merged) 10jenkins-bot: Remove direction style attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/150193 (owner: 10Esanders) [20:12:56] (03PS18) 10Mooeypoo: Refactor TemplateData Editor [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/134928 (https://bugzilla.wikimedia.org/67621) [20:14:46] RoanKattouw: if I want to add a class to a button that was created this way, should I do button.$element.addClass() or is there something smarter? [20:16:43] aharoni, iirc, that's the way to go, unless you want to extend the button class [20:17:59] (03Abandoned) 10Alex Monk: Fix pulling of annotations when inserting new character at start of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150120 (https://bugzilla.wikimedia.org/68597) (owner: 10Alex Monk) [20:22:54] (03PS1) 10Alex Monk: [WIP] Fix pulling of annotations when typing at the beginning of the document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150378 (https://bugzilla.wikimedia.org/68597) [20:23:26] Urgh. I hate everything about this commit. [20:23:38] RoanKattouw: it's really not ready to merge, but does https://gerrit.wikimedia.org/r/#/c/150377/ make sense a first step? [20:23:55] It appears correctly, fwiw [20:24:06] I suspect jenkins will agree with me. [20:25:19] Or would if this was tested. [20:35:01] aharoni: Sorry, was at lunch. Looking [20:35:25] aharoni: You can also pass in classes: [ 'classes', 'to', 'add' ] in the config for the button [20:44:26] RoanKattouw, I had no idea about the classes: [] array. We really should enhance the docs :\ [20:44:37] Yeah [20:44:40] That's relatively new [20:50:46] guys, I'm using VE to edit on mediawiki.org and it seems like undo is completely messed up [20:50:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692#c2 (10Elitre) IMHO, currently that would be https://bugzilla.wikimedia.org/enter_bug.cgi?product=VisualEditor&component=General&format=guided . (That would... [20:50:54] it doesn't undo things in the order I did them [20:51:00] and it doesn't undo all of them [20:51:09] is that a known issue? [20:57:38] jgonera: Ahm... [20:57:42] No? [20:57:53] Are you editing near a template? Are snowman characters appearing? [20:57:57] OK, then I'll try to reproduce this on a simpler use case later [20:58:01] Anything else weird that you're doing? [20:58:01] nope [20:58:02] OK [20:58:07] RoanKattouw, simple page, no templates [20:58:12] hah [20:58:28] jgonera: BTW weren't you gonna hack MobileContext to not allow the reference dialog to be reached? [20:58:53] Cause you can now inspect references again in mobile and I hear that's not supposed to happen [20:59:03] RoanKattouw, I think we do want the reference dialog, not the other ones, related to other templates [20:59:17] RoanKattouw, by inspect references you mean the ones that don't use a Cite template? [20:59:56] RoanKattouw, I'll check on this later [21:00:00] RoanKattouw: thanks for the review [21:00:15] jgonera, I can now inspect math,templates,basic reference with the context menu [21:00:17] RoanKattouw, BTW do you know the code that scrolls the editor to a given section after using a section edit link? [21:00:32] ryasmeen, yes, math, templates for sure should not happen [21:00:41] RoanKattouw: I figured how to add an icon, but I need the actual icon file, and as far as I can see there's nothing precisely like that currently [21:00:53] and I guess Basic reference too [21:01:15] I'm not exactly sure who was supposed to hack MobileContext for now to prevent it, I just gave a temporary solution idea, I can take care of it when I'm done with scrolling issues and styling OOUI on mobile [21:02:33] aharoni: I left a CR comment on your change explaining how [21:02:49] aharoni: Or do you mean you don't physically have the .svg ? [21:03:00] yes, the latter [21:03:57] Right, OK [21:04:12] jgonera: OK, no worries, just checking that this is something that's on your radar [21:04:47] RoanKattouw, what about that scrolling to section code? [21:05:32] Didn't I merge it? [21:16:59] RoanKattouw, you did, but it still doesn't work on Kaldari's instance so there must be something weird going on. If you know that codebase well, it would be cool if you could help us track that down (but let's timebox it to ~20 minutes) [21:17:16] OK coming over [21:20:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692#c3 (10James Forrester) We can't link them to Bugzilla (or Phabricator) without: * a detailed note about the different privacy policy there, * and that thei... [21:44:22] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting the Alt Text box in the Media Settings dialog should disable the Caption box's toolbar - 10https://bugzilla.wikimedia.org/68806 (10James Forrester) 5PATC>3RESO/FIX [22:00:40] (03PS1) 10Catrope: Delay scrollToHeading() until after the selection is rerendered [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150404 [22:01:15] jgonera: ---^^ [22:01:39] (03CR) 10JGonera: [C: 032] Delay scrollToHeading() until after the selection is rerendered [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150404 (owner: 10Catrope) [22:03:20] (03Merged) 10jenkins-bot: Delay scrollToHeading() until after the selection is rerendered [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150404 (owner: 10Catrope) [22:04:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: "Switch to source editor" text overlaps with selection indicator; should expand menu or wrap if needed - 10https://bugzilla.wikimedia.org/57366#c5 (10James Forrester) @Krinkle: Ping. Any progress on this? [22:05:56] (03PS1) 10JGonera: Remove timeout in scrolling to heading on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150408 [22:06:11] RoanKattouw, ^ [22:07:48] (03PS2) 10JGonera: Remove timeout in scrolling to heading on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150408 [22:08:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: Please add a button for reporting bugs to the Save dialog - 10https://bugzilla.wikimedia.org/68692#c4 (10WhatamIdoing) I'd assumed that such a link would be the same as the existing feedback link and go to the on-wiki feedback pages (either local or at me... [22:20:37] (03CR) 10Catrope: [C: 032] Remove timeout in scrolling to heading on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150408 (owner: 10JGonera) [22:22:22] (03Merged) 10jenkins-bot: Remove timeout in scrolling to heading on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150408 (owner: 10JGonera) [22:31:01] (03CR) 10Esanders: Create a WhitespaceTextInputWidget and use in CommentInspector (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150276 (owner: 10Esanders) [22:41:12] (03PS1) 10Alex Monk: Don't show PostEdit message if we made a null edit. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) [22:41:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot type the reference name inside Re-use existing reference dialog unless select a reference from that dialog - 10https://bugzilla.wikimedia.org/68824 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with Mobile... [23:26:03] James_F: Did you guys ever looked at amount of bytes added/removed within ve vs. source? [23:26:31] For instance to answer question if VE edits are "bigger"? etc. [23:27:00] (03CR) 10Trevor Parscal: [C: 032] Remove unused CSS classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/150192 (owner: 10Esanders) [23:27:43] (03Merged) 10jenkins-bot: Remove unused CSS classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/150192 (owner: 10Esanders) [23:27:55] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Fix ve.ui.Overlay classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149635 (https://bugzilla.wikimedia.org/68486) (owner: 10Esanders) [23:28:36] (03CR) 10Trevor Parscal: [C: 032] Remove unused CSS classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149924 (owner: 10Esanders) [23:29:04] (03CR) 10Trevor Parscal: [C: 032] Comment icon positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150182 (owner: 10Esanders) [23:29:25] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Fix ve.ui.Overlay classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/149635 (https://bugzilla.wikimedia.org/68486) (owner: 10Esanders) [23:30:23] (03Merged) 10jenkins-bot: Remove unused CSS classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149924 (owner: 10Esanders) [23:30:57] (03Merged) 10jenkins-bot: Comment icon positioning [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/150182 (owner: 10Esanders) [23:32:14] (03PS2) 10Catrope: Update VE core submodule to master (0709218) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150188 (owner: 10Esanders) [23:33:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (0709218) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150188 (owner: 10Esanders) [23:35:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (0709218) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150188 (owner: 10Esanders) [23:37:24] (03PS26) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [23:37:28] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:38:06] 3VisualEditor / 3Editing Tools: VisualEditor: Language dialog launched from inspector doesn't open in a global overlay - 10https://bugzilla.wikimedia.org/68486 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal [23:41:47] James_F, what is https://bugzilla.wikimedia.org/show_bug.cgi?id=68279 ? Isn't navbox some enwiki template? [23:41:50] The summary is a bit broken [23:44:37] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342#c1 (10Rummana Yasmeen) p:5Low>3Normal This is happening in deskto... [23:47:42] (03PS27) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [23:47:46] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [23:53:02] (03CR) 10Jforrester: Don't show PostEdit message if we made a null edit. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150419 (https://bugzilla.wikimedia.org/51243) (owner: 10Alex Monk) [23:55:36] (03PS6) 10Mooeypoo: MWMediaSearchWidget: Use json/jsonp for local/foreign api respectively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/150054 (https://bugzilla.wikimedia.org/64822) [23:56:53] TrevorParscal: Hey, did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=68571 (dialog title shortening not working)? [23:57:23] Krenair: Isn't the show/hide div code in mwUtil or somewhere? I thought it was shared… [23:58:01] Roan mentioned it, i think I've fixed it a few times but it keeps getting screwed up in various rebases [23:58:07] James_F: there is code for collapsing things in core, but en.wo naturally doesn't use any of that :D [23:58:07] Yeah. :-( [23:58:09] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot srcoll a page in mobile when the keyboard is open and cursor active on CE - 10https://bugzilla.wikimedia.org/68828 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with mobile VE 2.Place the cursor somewhere a... [23:58:14] en.wp* [23:58:15] MatmaRex: Ha. Wonderful. [23:58:31] navbox JS code is probably somewhere in mediawiki:common.js [23:58:44] Krenair: In that case, ensure we actually work with the core collapse/show code, and we'll WONTFIX if it's just a local wiki failing to migrate.